1 2020-01-07T00:00:02  *** V3ct0r has quit IRC
  2 2020-01-07T00:08:17  *** Zenton has quit IRC
  3 2020-01-07T00:09:31  *** turbo_choo has quit IRC
  4 2020-01-07T00:10:27  *** marcoagner has quit IRC
  5 2020-01-07T00:11:31  *** turbo_choo has joined #bitcoin-core-dev
  6 2020-01-07T00:14:00  *** promag has quit IRC
  7 2020-01-07T00:14:18  *** promag has joined #bitcoin-core-dev
  8 2020-01-07T00:17:02  *** izaki1 has joined #bitcoin-core-dev
  9 2020-01-07T00:20:18  *** promag has quit IRC
 10 2020-01-07T00:24:08  *** promag has joined #bitcoin-core-dev
 11 2020-01-07T00:27:19  *** promag has quit IRC
 12 2020-01-07T00:28:35  *** promag has joined #bitcoin-core-dev
 13 2020-01-07T00:33:32  *** belcher has quit IRC
 14 2020-01-07T00:33:34  *** promag has quit IRC
 15 2020-01-07T00:34:42  *** promag has joined #bitcoin-core-dev
 16 2020-01-07T00:35:46  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 17 2020-01-07T00:39:29  *** promag has quit IRC
 18 2020-01-07T00:39:36  *** turbo_choo has quit IRC
 19 2020-01-07T00:45:48  *** promag has joined #bitcoin-core-dev
 20 2020-01-07T00:47:28  *** turbo_choo has joined #bitcoin-core-dev
 21 2020-01-07T00:51:41  *** apex944 has quit IRC
 22 2020-01-07T00:56:56  *** promag has quit IRC
 23 2020-01-07T00:57:00  *** turbo_choo has quit IRC
 24 2020-01-07T00:59:32  *** turbo_choo has joined #bitcoin-core-dev
 25 2020-01-07T01:08:07  *** turbo_choo has quit IRC
 26 2020-01-07T01:08:25  *** promag has joined #bitcoin-core-dev
 27 2020-01-07T01:20:01  *** turbo_choo has joined #bitcoin-core-dev
 28 2020-01-07T01:38:56  *** turbo_choo has quit IRC
 29 2020-01-07T01:43:27  *** turbo_choo has joined #bitcoin-core-dev
 30 2020-01-07T01:57:32  *** morcos has quit IRC
 31 2020-01-07T01:58:19  *** morcos has joined #bitcoin-core-dev
 32 2020-01-07T02:03:10  *** apex944 has joined #bitcoin-core-dev
 33 2020-01-07T02:18:24  *** Chris_Stewart_5 has quit IRC
 34 2020-01-07T02:55:17  *** Highway61 has quit IRC
 35 2020-01-07T02:56:01  *** apex944 has quit IRC
 36 2020-01-07T03:00:01  *** izaki1 has quit IRC
 37 2020-01-07T03:00:48  *** abrissbi1ne has joined #bitcoin-core-dev
 38 2020-01-07T03:04:16  *** abrissbirne has quit IRC
 39 2020-01-07T03:07:23  *** turbo_choo has quit IRC
 40 2020-01-07T03:10:14  *** justanotheruser has quit IRC
 41 2020-01-07T03:14:01  *** turbo_choo has joined #bitcoin-core-dev
 42 2020-01-07T03:17:04  *** apex944 has joined #bitcoin-core-dev
 43 2020-01-07T03:17:05  *** jackgassett has joined #bitcoin-core-dev
 44 2020-01-07T03:18:42  *** captjakk has joined #bitcoin-core-dev
 45 2020-01-07T03:26:56  *** justanotheruser has joined #bitcoin-core-dev
 46 2020-01-07T03:36:53  *** felixfoertsch has joined #bitcoin-core-dev
 47 2020-01-07T03:38:36  *** felixfoertsch23 has quit IRC
 48 2020-01-07T03:39:32  *** cryptoIndio has joined #bitcoin-core-dev
 49 2020-01-07T03:42:02  *** apex944 has quit IRC
 50 2020-01-07T03:47:58  *** apex944 has joined #bitcoin-core-dev
 51 2020-01-07T04:00:40  *** bitcoin-git has joined #bitcoin-core-dev
 52 2020-01-07T04:00:40  <bitcoin-git> [bitcoin] achow101 opened pull request #17886: Restore English translation option (master...fix-en-translate) https://github.com/bitcoin/bitcoin/pull/17886
 53 2020-01-07T04:00:41  *** bitcoin-git has left #bitcoin-core-dev
 54 2020-01-07T04:07:14  *** apex944 has quit IRC
 55 2020-01-07T04:07:27  *** sipa has quit IRC
 56 2020-01-07T04:07:44  *** sipa has joined #bitcoin-core-dev
 57 2020-01-07T04:16:42  *** Zenton has joined #bitcoin-core-dev
 58 2020-01-07T04:20:00  *** justanotheruser has quit IRC
 59 2020-01-07T04:30:53  *** Relis has quit IRC
 60 2020-01-07T04:39:32  *** justanotheruser has joined #bitcoin-core-dev
 61 2020-01-07T04:39:49  *** turbo_choo has quit IRC
 62 2020-01-07T04:41:56  *** turbo_choo has joined #bitcoin-core-dev
 63 2020-01-07T04:55:35  *** mol has joined #bitcoin-core-dev
 64 2020-01-07T04:57:06  *** Relis has joined #bitcoin-core-dev
 65 2020-01-07T05:13:21  *** Relis has quit IRC
 66 2020-01-07T05:31:52  *** Victor_sueca has joined #bitcoin-core-dev
 67 2020-01-07T05:34:41  *** Victorsueca has quit IRC
 68 2020-01-07T05:41:17  *** captjakk has quit IRC
 69 2020-01-07T06:00:02  *** jackgassett has quit IRC
 70 2020-01-07T06:10:33  *** mol has quit IRC
 71 2020-01-07T06:17:20  *** Y_Ichiro has joined #bitcoin-core-dev
 72 2020-01-07T06:24:46  *** Y_Ichiro has quit IRC
 73 2020-01-07T06:29:14  *** mryandao has quit IRC
 74 2020-01-07T06:29:35  *** mryandao has joined #bitcoin-core-dev
 75 2020-01-07T06:50:58  *** Darki1 has joined #bitcoin-core-dev
 76 2020-01-07T07:02:56  *** tryphe_ has joined #bitcoin-core-dev
 77 2020-01-07T07:04:48  *** tryphe_ has quit IRC
 78 2020-01-07T07:04:49  *** SiAnDoG__ has quit IRC
 79 2020-01-07T07:04:49  *** DeanWeen has quit IRC
 80 2020-01-07T07:04:50  *** kristapsk has quit IRC
 81 2020-01-07T07:05:04  *** kristapsk has joined #bitcoin-core-dev
 82 2020-01-07T07:05:05  *** DeanWeen has joined #bitcoin-core-dev
 83 2020-01-07T07:05:09  *** SiAnDoG__ has joined #bitcoin-core-dev
 84 2020-01-07T07:05:13  *** tryphe_ has joined #bitcoin-core-dev
 85 2020-01-07T07:06:33  *** tryphe has quit IRC
 86 2020-01-07T07:28:45  *** ghost43 has quit IRC
 87 2020-01-07T07:29:01  *** ghost43 has joined #bitcoin-core-dev
 88 2020-01-07T07:58:06  *** TheHoliestRoger has quit IRC
 89 2020-01-07T07:58:54  *** TheHoliestRoger has joined #bitcoin-core-dev
 90 2020-01-07T08:07:07  *** RandolfR has joined #bitcoin-core-dev
 91 2020-01-07T08:07:41  *** RandolfR is now known as Randolf
 92 2020-01-07T08:08:43  *** Randolf has quit IRC
 93 2020-01-07T08:09:03  *** Randolf has joined #bitcoin-core-dev
 94 2020-01-07T08:28:05  *** jungly has joined #bitcoin-core-dev
 95 2020-01-07T08:42:55  *** Kiminuo has joined #bitcoin-core-dev
 96 2020-01-07T08:56:03  *** SiAnDoG__ has quit IRC
 97 2020-01-07T08:57:00  *** paultroon has joined #bitcoin-core-dev
 98 2020-01-07T08:59:19  *** marcoagner has joined #bitcoin-core-dev
 99 2020-01-07T09:00:02  *** Darki1 has quit IRC
100 2020-01-07T09:01:28  *** paultroon has quit IRC
101 2020-01-07T09:08:07  *** alec has quit IRC
102 2020-01-07T09:09:50  *** aqquadro has joined #bitcoin-core-dev
103 2020-01-07T09:21:29  *** alec has joined #bitcoin-core-dev
104 2020-01-07T09:33:29  *** belcher has joined #bitcoin-core-dev
105 2020-01-07T09:37:44  *** vasild_ has joined #bitcoin-core-dev
106 2020-01-07T09:40:23  *** vasild has quit IRC
107 2020-01-07T09:47:48  *** Mark_Cockrell has joined #bitcoin-core-dev
108 2020-01-07T09:47:50  *** kljasdfvv has quit IRC
109 2020-01-07T09:51:57  *** vasild_ has quit IRC
110 2020-01-07T10:01:48  *** promag has joined #bitcoin-core-dev
111 2020-01-07T10:01:58  *** daniel_ has quit IRC
112 2020-01-07T10:05:07  *** vasild has joined #bitcoin-core-dev
113 2020-01-07T10:09:33  *** vasild has quit IRC
114 2020-01-07T10:10:10  *** vasild has joined #bitcoin-core-dev
115 2020-01-07T10:18:44  *** jonatack has quit IRC
116 2020-01-07T11:05:12  *** Guyver2 has joined #bitcoin-core-dev
117 2020-01-07T11:08:27  *** kljasdfvv has joined #bitcoin-core-dev
118 2020-01-07T11:09:12  *** Guest83 has joined #bitcoin-core-dev
119 2020-01-07T11:10:32  *** alec has quit IRC
120 2020-01-07T11:13:07  *** Guyver2_ has joined #bitcoin-core-dev
121 2020-01-07T11:16:51  *** Guyver2 has quit IRC
122 2020-01-07T11:19:09  <promag> ariard could be member in gh
123 2020-01-07T11:26:54  *** michaelfolkson has joined #bitcoin-core-dev
124 2020-01-07T11:34:32  *** michaelfolkson has quit IRC
125 2020-01-07T11:36:17  *** Dean_Guss has joined #bitcoin-core-dev
126 2020-01-07T11:36:34  *** Guest83 has quit IRC
127 2020-01-07T11:36:43  *** DeanWeen has quit IRC
128 2020-01-07T11:38:39  *** Chris_Stewart_5 has joined #bitcoin-core-dev
129 2020-01-07T11:40:00  *** timothy has joined #bitcoin-core-dev
130 2020-01-07T11:46:47  *** Relis has joined #bitcoin-core-dev
131 2020-01-07T11:51:29  *** timothy has quit IRC
132 2020-01-07T11:51:46  *** Relis has quit IRC
133 2020-01-07T11:52:37  *** Highway61 has joined #bitcoin-core-dev
134 2020-01-07T11:53:52  *** timothy has joined #bitcoin-core-dev
135 2020-01-07T11:54:08  *** michaelfolkson has joined #bitcoin-core-dev
136 2020-01-07T12:00:01  *** Mark_Cockrell has quit IRC
137 2020-01-07T12:02:38  *** michaelfolkson has quit IRC
138 2020-01-07T12:16:14  *** promag has quit IRC
139 2020-01-07T12:17:11  *** aqquadro has quit IRC
140 2020-01-07T12:17:26  *** Morgon1 has joined #bitcoin-core-dev
141 2020-01-07T12:21:51  *** michaelfolkson has joined #bitcoin-core-dev
142 2020-01-07T12:22:51  *** Relis has joined #bitcoin-core-dev
143 2020-01-07T12:29:25  *** joncoe has joined #bitcoin-core-dev
144 2020-01-07T12:39:32  *** jonatack has joined #bitcoin-core-dev
145 2020-01-07T12:44:07  *** Chris_Stewart_5 has quit IRC
146 2020-01-07T12:47:11  *** paultroon has joined #bitcoin-core-dev
147 2020-01-07T12:54:16  *** mol has joined #bitcoin-core-dev
148 2020-01-07T13:01:19  *** Chris_Stewart_5 has joined #bitcoin-core-dev
149 2020-01-07T13:03:55  *** tryphe_ is now known as tryphe
150 2020-01-07T13:06:47  *** felixfoertsch has quit IRC
151 2020-01-07T13:09:29  *** Relis has quit IRC
152 2020-01-07T13:13:19  *** Guest83 has joined #bitcoin-core-dev
153 2020-01-07T13:14:05  *** promag has joined #bitcoin-core-dev
154 2020-01-07T13:14:45  *** promag_ has joined #bitcoin-core-dev
155 2020-01-07T13:16:04  *** promag_ has quit IRC
156 2020-01-07T13:18:09  *** promag_ has joined #bitcoin-core-dev
157 2020-01-07T13:20:53  *** promag has quit IRC
158 2020-01-07T13:27:29  *** turbo_choo has quit IRC
159 2020-01-07T13:28:16  *** bitcoin-git has joined #bitcoin-core-dev
160 2020-01-07T13:28:16  <bitcoin-git> [bitcoin] kallewoof opened pull request #17887: bug-fix macos: give free bytes to F_PREALLOCATE (master...macos-f_preallocate_fix) https://github.com/bitcoin/bitcoin/pull/17887
161 2020-01-07T13:28:17  *** bitcoin-git has left #bitcoin-core-dev
162 2020-01-07T13:28:20  *** turbo_choo has joined #bitcoin-core-dev
163 2020-01-07T13:30:40  *** bitcoin-git has joined #bitcoin-core-dev
164 2020-01-07T13:30:40  <bitcoin-git> [bitcoin] xyephy opened pull request #17888: Merge (master...master) https://github.com/bitcoin/bitcoin/pull/17888
165 2020-01-07T13:30:41  *** bitcoin-git has left #bitcoin-core-dev
166 2020-01-07T13:31:20  *** bitcoin-git has joined #bitcoin-core-dev
167 2020-01-07T13:31:20  <bitcoin-git> [bitcoin] fanquake closed pull request #17888: Merge (master...master) https://github.com/bitcoin/bitcoin/pull/17888
168 2020-01-07T13:31:21  *** bitcoin-git has left #bitcoin-core-dev
169 2020-01-07T13:46:17  *** felixfoertsch has joined #bitcoin-core-dev
170 2020-01-07T13:49:02  *** Relis has joined #bitcoin-core-dev
171 2020-01-07T13:56:54  *** bitcoin-git has joined #bitcoin-core-dev
172 2020-01-07T13:56:54  <bitcoin-git> [bitcoin] promag opened pull request #17889: wallet: Improve CWallet:MarkDestinationsDirty (master...2020-01-wallettx-iscacheempty) https://github.com/bitcoin/bitcoin/pull/17889
173 2020-01-07T13:56:56  *** bitcoin-git has left #bitcoin-core-dev
174 2020-01-07T14:15:19  *** turbo_choo has quit IRC
175 2020-01-07T14:26:06  *** Chris_Stewart_5 has quit IRC
176 2020-01-07T14:26:56  *** aqquadro has joined #bitcoin-core-dev
177 2020-01-07T14:30:34  *** Kiminuo has quit IRC
178 2020-01-07T14:37:21  *** jonatack has quit IRC
179 2020-01-07T14:40:01  *** Chris_Stewart_5 has joined #bitcoin-core-dev
180 2020-01-07T14:41:44  *** andrewtoth has joined #bitcoin-core-dev
181 2020-01-07T14:41:55  *** jonatack has joined #bitcoin-core-dev
182 2020-01-07T14:45:59  *** promag_ has quit IRC
183 2020-01-07T15:00:02  *** Morgon1 has quit IRC
184 2020-01-07T15:03:55  *** promag has joined #bitcoin-core-dev
185 2020-01-07T15:15:23  *** tryphe has quit IRC
186 2020-01-07T15:17:23  *** DARKNE55 has joined #bitcoin-core-dev
187 2020-01-07T15:17:36  *** michaelfolkson has quit IRC
188 2020-01-07T15:17:49  *** jonatack has quit IRC
189 2020-01-07T15:20:21  *** michaelfolkson has joined #bitcoin-core-dev
190 2020-01-07T15:20:37  *** michaelfolkson has quit IRC
191 2020-01-07T15:27:54  *** ctrlbreak_MAD is now known as ctrlbreak
192 2020-01-07T15:40:01  *** mdunnio has joined #bitcoin-core-dev
193 2020-01-07T15:45:10  *** promag has quit IRC
194 2020-01-07T15:48:13  <kallewoof> Why would bitcoin core reopen old rev files after closing their blk files? #17890
195 2020-01-07T15:48:14  <gribble> https://github.com/bitcoin/bitcoin/issues/17890 | Non-latest rev files are sometimes re-opened but never re-flushed · Issue #17890 · bitcoin/bitcoin · GitHub
196 2020-01-07T15:49:00  <sipa> kallewoof: rev files are written at activation time, which is not the same time as the blocks are written
197 2020-01-07T15:49:26  <sipa> (not sure that explains what you're seeing, though0
198 2020-01-07T15:49:28  <kallewoof> sipa: we need to flush them afterwards then. maybe always flush after each write, if it is not the current one
199 2020-01-07T15:49:59  <kallewoof> sipa: i am seeing 2 separate bugs. 1 bug is that we over-allocate by (file size) amount, and 2nd is that we are not flushing afterwards, leaving some of the rev files in the overblown-size state.
200 2020-01-07T15:50:07  <sipa> hmm, we don't mark block index entries dirty when the corresponding block is activated/deactivated?
201 2020-01-07T15:50:35  <kallewoof> sipa: we only ever flush a undo file when we close its block file.
202 2020-01-07T15:50:51  <kallewoof> sipa: "Leaving block X" is when we flush both blk and rev. Never again after that
203 2020-01-07T15:50:57  <sipa> ah, that seems wrong
204 2020-01-07T15:51:12  <sipa> i'll have a look
205 2020-01-07T15:52:09  *** Guest83 has quit IRC
206 2020-01-07T16:19:14  *** Relis has quit IRC
207 2020-01-07T16:27:33  *** Relis has joined #bitcoin-core-dev
208 2020-01-07T16:27:38  *** morcos has quit IRC
209 2020-01-07T16:28:00  *** morcos has joined #bitcoin-core-dev
210 2020-01-07T16:28:25  *** bitcoin-git has joined #bitcoin-core-dev
211 2020-01-07T16:28:25  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #17891: scripted-diff: Replace CCriticalSection with RecursiveMutex (master...2001-c2-CC) https://github.com/bitcoin/bitcoin/pull/17891
212 2020-01-07T16:28:26  *** bitcoin-git has left #bitcoin-core-dev
213 2020-01-07T16:33:34  *** Randolf has quit IRC
214 2020-01-07T16:34:02  <kallewoof> sipa: ok. I'm looking too
215 2020-01-07T16:36:48  *** Talkless has joined #bitcoin-core-dev
216 2020-01-07T16:40:33  <kallewoof> sipa: I think part of the issue is that blocks are stored to disk and there is a lag between that and the block being connected (probably due to sig checks / utxo etc), and since undo data is written then (at activation time as you said), the system will move on to the next block file but the activation will still be working against the previous one.
217 2020-01-07T16:41:58  <kallewoof> I saw the first encounter of 'write to an older rev file' right after closing block file 0, which said it had 'heights=0...119975', but right before that line there was an UpdateTip new best for height 119963, and my code broke when it was about to find undo pos for height 119965.
218 2020-01-07T16:42:19  <kallewoof> s/broke/hit my breakpoint/g
219 2020-01-07T16:43:23  <kallewoof> looks like a decent fix here is to flush the blk/undo when the activation occurs (as well, probably, to cover both cases).
220 2020-01-07T16:43:43  <kallewoof> i mean, when the activation goes from 'X' to 'X+1' in terms of the block file #.
221 2020-01-07T16:58:02  <sipa> kallewoof: iirc we only have one set of "dirty" files which are synced at flush time, which covers both blk and rev files
222 2020-01-07T16:58:08  <sipa> it seems we'll need to split that up
223 2020-01-07T17:01:07  <kallewoof> sipa: there is a setDirtyBlockIndex which is then chucked at a txdb.cpp method which writes a bunch. It's not immediately clear to me if those are the rev/blk or the index stuff.
224 2020-01-07T17:01:50  <kallewoof> the only place we flush (truncate to actual used size) the blk/rev is in that one place in validation.cpp. there is another place which calls but with finalize=false which doesn't do that.
225 2020-01-07T17:02:05  *** Talkless has quit IRC
226 2020-01-07T17:05:30  *** promag has joined #bitcoin-core-dev
227 2020-01-07T17:05:37  *** jungly has quit IRC
228 2020-01-07T17:05:40  *** aqquadro has quit IRC
229 2020-01-07T17:05:52  *** Talkless has joined #bitcoin-core-dev
230 2020-01-07T17:10:13  <sipa> kallewoof: ah right
231 2020-01-07T17:11:31  *** pinheadmz has quit IRC
232 2020-01-07T17:13:52  *** SiAnDoG__ has joined #bitcoin-core-dev
233 2020-01-07T17:17:50  *** promag has quit IRC
234 2020-01-07T17:19:56  *** promag has joined #bitcoin-core-dev
235 2020-01-07T17:27:30  *** jarthur has joined #bitcoin-core-dev
236 2020-01-07T17:27:56  *** promag has quit IRC
237 2020-01-07T17:37:07  *** paultroon has quit IRC
238 2020-01-07T17:44:43  *** Chris_Stewart_5 has quit IRC
239 2020-01-07T17:48:25  *** paultroon has joined #bitcoin-core-dev
240 2020-01-07T17:53:03  *** paultroon has quit IRC
241 2020-01-07T17:53:12  *** tryphe has joined #bitcoin-core-dev
242 2020-01-07T17:55:37  <kallewoof> Contrary to what the block file tostring() would have you believe, it seems that blocks are not actually in a strict range inside the blk files. I see block 119776 in blk1 and 119777 in blk0.
243 2020-01-07T17:58:28  *** promag has joined #bitcoin-core-dev
244 2020-01-07T17:59:01  <goatpig_> hasnt been the case since header first
245 2020-01-07T18:00:02  *** DARKNE55 has quit IRC
246 2020-01-07T18:00:17  *** Chris_Stewart_5 has joined #bitcoin-core-dev
247 2020-01-07T18:00:35  <kallewoof> i have a sorta working patch but it needs to be reworked around the fact blocks are jumbled. see https://github.com/kallewoof/bitcoin/tree/200108-reflush-undo
248 2020-01-07T18:01:26  *** andrewtoth_ has joined #bitcoin-core-dev
249 2020-01-07T18:02:23  *** andrewtoth has quit IRC
250 2020-01-07T18:02:36  <kallewoof> I think the straightforward solution is to determine the last block in the old rev file beforehand and to have the write for that trigger the flush. But it's 3 am now. /waves
251 2020-01-07T18:06:03  *** andrewtoth_ has quit IRC
252 2020-01-07T18:06:23  *** bitcoin-git has joined #bitcoin-core-dev
253 2020-01-07T18:06:24  <bitcoin-git> [bitcoin] kallewoof opened pull request #17892: bug-fix: re-flush undo files after they have been re-opened (master...200108-reflush-undo) https://github.com/bitcoin/bitcoin/pull/17892
254 2020-01-07T18:06:35  *** bitcoin-git has left #bitcoin-core-dev
255 2020-01-07T18:17:19  *** derek1 has joined #bitcoin-core-dev
256 2020-01-07T18:22:38  *** joncoe has quit IRC
257 2020-01-07T18:34:58  *** lowentropy has quit IRC
258 2020-01-07T18:39:21  *** paultroon has joined #bitcoin-core-dev
259 2020-01-07T18:41:03  *** paultroon has joined #bitcoin-core-dev
260 2020-01-07T18:44:39  *** jonatack has joined #bitcoin-core-dev
261 2020-01-07T18:56:01  *** Kiminuo has joined #bitcoin-core-dev
262 2020-01-07T19:04:38  *** bitcoin-git has joined #bitcoin-core-dev
263 2020-01-07T19:04:39  <bitcoin-git> [bitcoin] IPGlider closed pull request #17884: utils: Use fallback for macOS in AllocateFileRange (master...workaround_apfs_allocation_problem) https://github.com/bitcoin/bitcoin/pull/17884
264 2020-01-07T19:04:39  *** bitcoin-git has left #bitcoin-core-dev
265 2020-01-07T19:09:50  *** Dean_Guss has quit IRC
266 2020-01-07T19:12:19  <sipa> e er5~
267 2020-01-07T19:12:29  <sipa> oops
268 2020-01-07T19:14:47  *** Talkless has quit IRC
269 2020-01-07T19:22:14  *** promag has quit IRC
270 2020-01-07T19:51:07  *** Highway61 has quit IRC
271 2020-01-07T19:54:28  *** ddustin has joined #bitcoin-core-dev
272 2020-01-07T19:59:20  *** jarthur has quit IRC
273 2020-01-07T20:00:15  *** ddustin has quit IRC
274 2020-01-07T20:00:50  *** ddustin has joined #bitcoin-core-dev
275 2020-01-07T20:03:26  *** promag has joined #bitcoin-core-dev
276 2020-01-07T20:04:50  *** ddustin has quit IRC
277 2020-01-07T20:08:19  *** promag has quit IRC
278 2020-01-07T20:14:43  *** andrewtoth_ has joined #bitcoin-core-dev
279 2020-01-07T20:20:49  *** rex4539 has joined #bitcoin-core-dev
280 2020-01-07T20:24:31  *** mryandao has quit IRC
281 2020-01-07T20:25:14  *** mryandao has joined #bitcoin-core-dev
282 2020-01-07T20:31:00  *** molly has joined #bitcoin-core-dev
283 2020-01-07T20:34:03  *** mol has quit IRC
284 2020-01-07T20:36:27  *** rex4539 has quit IRC
285 2020-01-07T20:49:27  *** rex4539 has joined #bitcoin-core-dev
286 2020-01-07T20:53:22  *** jarthur has joined #bitcoin-core-dev
287 2020-01-07T21:00:01  *** derek1 has quit IRC
288 2020-01-07T21:02:58  *** mr_paz has joined #bitcoin-core-dev
289 2020-01-07T21:09:25  *** mr_paz has quit IRC
290 2020-01-07T21:11:59  *** mrostecki[m] has joined #bitcoin-core-dev
291 2020-01-07T21:17:16  *** mreider has joined #bitcoin-core-dev
292 2020-01-07T21:17:59  *** Relis has quit IRC
293 2020-01-07T21:21:43  *** tryphe_ has joined #bitcoin-core-dev
294 2020-01-07T21:24:11  *** tryphe has quit IRC
295 2020-01-07T21:25:47  *** Relis has joined #bitcoin-core-dev
296 2020-01-07T21:26:17  <jeremyrubin> Does anyone have any trouble with univalue encoding VARR types?
297 2020-01-07T21:26:32  *** rex4539 has joined #bitcoin-core-dev
298 2020-01-07T21:26:42  <jeremyrubin> I'm working on an RPC and I'm getting: vector::_M_range_check: __n (which is 1) >= this->size() (which is 1)
299 2020-01-07T21:26:52  *** ghost43 has quit IRC
300 2020-01-07T21:27:10  *** ghost43 has joined #bitcoin-core-dev
301 2020-01-07T21:27:18  <jeremyrubin> (sidebar: the NONFATAL stuff makes debugging these sorts of problems harder, we should add flags to re-enable panic)
302 2020-01-07T21:28:31  <sipa> it's probably good to make NONFATAL failures turn into assertion failures in debug builds
303 2020-01-07T21:32:35  *** bitcoin-git has joined #bitcoin-core-dev
304 2020-01-07T21:32:35  <bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e8e79958a7b2...bcb4cdcca321
305 2020-01-07T21:32:36  <bitcoin-git> bitcoin/master 0950245 Gregory Sanders: IsUsedDestination should count any known single-key address
306 2020-01-07T21:32:36  <bitcoin-git> bitcoin/master bcb4cdc Samuel Dobson: Merge #17621: IsUsedDestination should count any known single-key address
307 2020-01-07T21:32:38  *** bitcoin-git has left #bitcoin-core-dev
308 2020-01-07T21:32:55  *** bitcoin-git has joined #bitcoin-core-dev
309 2020-01-07T21:32:55  <bitcoin-git> [bitcoin] meshcollider merged pull request #17621: IsUsedDestination should count any known single-key address (master...actually_no_reuse) https://github.com/bitcoin/bitcoin/pull/17621
310 2020-01-07T21:32:56  *** bitcoin-git has left #bitcoin-core-dev
311 2020-01-07T21:33:38  *** Highway61 has joined #bitcoin-core-dev
312 2020-01-07T21:36:44  <jeremyrubin> sipa: what's the debug flag named (not NDEBUG)
313 2020-01-07T21:36:50  *** nodweber has quit IRC
314 2020-01-07T21:37:25  <sipa> jeremyrubin: --enable-debug sets some flags; it could set another one that specifically control this behaviour
315 2020-01-07T21:37:43  *** vasild_ has joined #bitcoin-core-dev
316 2020-01-07T21:38:01  *** nodweber has joined #bitcoin-core-dev
317 2020-01-07T21:40:43  *** vasild has quit IRC
318 2020-01-07T21:41:30  *** bitcoin-git has joined #bitcoin-core-dev
319 2020-01-07T21:41:31  <bitcoin-git> [bitcoin] meshcollider pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/bcb4cdcca321...45f151913ef5
320 2020-01-07T21:41:31  <bitcoin-git> bitcoin/master 75a5e47 Gregory Sanders: Change bumpfee to use watch-only funds for legacy watchonly wallets
321 2020-01-07T21:41:32  <bitcoin-git> bitcoin/master e9b4f94 Gregory Sanders: bumpfee: Return PSBT when wallet has privkeys disabled
322 2020-01-07T21:41:32  <bitcoin-git> bitcoin/master 091a876 Gregory Sanders: Test watchonly wallet bumpfee with PSBT return
323 2020-01-07T21:41:34  *** bitcoin-git has left #bitcoin-core-dev
324 2020-01-07T21:42:20  *** bitcoin-git has joined #bitcoin-core-dev
325 2020-01-07T21:42:20  <bitcoin-git> [bitcoin] meshcollider merged pull request #16373: bumpfee: Return PSBT when wallet has privkeys disabled (master...bump_psbt) https://github.com/bitcoin/bitcoin/pull/16373
326 2020-01-07T21:42:21  *** bitcoin-git has left #bitcoin-core-dev
327 2020-01-07T21:44:09  *** echonaut has quit IRC
328 2020-01-07T21:45:48  *** echonaut has joined #bitcoin-core-dev
329 2020-01-07T21:52:55  *** _andrewtoth_ has joined #bitcoin-core-dev
330 2020-01-07T21:54:03  *** andrewtoth_ has quit IRC
331 2020-01-07T21:55:03  *** niska has quit IRC
332 2020-01-07T21:55:12  *** _andrewtoth_ has quit IRC
333 2020-01-07T22:00:20  *** niska has joined #bitcoin-core-dev
334 2020-01-07T22:11:05  *** echonaut has quit IRC
335 2020-01-07T22:15:25  *** echonaut has joined #bitcoin-core-dev
336 2020-01-07T22:17:33  *** Chris_Stewart_5 has quit IRC
337 2020-01-07T22:18:46  *** Lox3u has joined #bitcoin-core-dev
338 2020-01-07T22:20:35  *** paultroon has quit IRC
339 2020-01-07T22:22:22  *** Lox3u has quit IRC
340 2020-01-07T22:22:46  <jeremyrubin> Ah; I had a variable x and a string "x" and I did x.pushKV("label", x)
341 2020-01-07T22:25:35  *** bitcoin-git has joined #bitcoin-core-dev
342 2020-01-07T22:25:36  <bitcoin-git> [bitcoin] meshcollider pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/45f151913ef5...7ea3b85ecf7b
343 2020-01-07T22:25:37  <bitcoin-git> bitcoin/master 7851f14 Jon Atack: rpc: incorporate review feedback from PR 17283
344 2020-01-07T22:25:38  <bitcoin-git> bitcoin/master 60aba1f Jon Atack: rpc: simplify getaddressinfo labels, deprecate previous behavior
345 2020-01-07T22:25:39  <bitcoin-git> bitcoin/master 8bb405b Jon Atack: test: getaddressinfo labels purpose deprecation test
346 2020-01-07T22:25:47  *** bitcoin-git has left #bitcoin-core-dev
347 2020-01-07T22:26:05  *** bitcoin-git has joined #bitcoin-core-dev
348 2020-01-07T22:26:06  <bitcoin-git> [bitcoin] meshcollider merged pull request #17578: rpc: simplify getaddressinfo labels, deprecate previous behavior (master...deprecate-getaddress-info-labels-purpose) https://github.com/bitcoin/bitcoin/pull/17578
349 2020-01-07T22:26:17  *** bitcoin-git has left #bitcoin-core-dev
350 2020-01-07T22:30:27  *** bitcoin-git has joined #bitcoin-core-dev
351 2020-01-07T22:30:27  <bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7ea3b85ecf7b...cab3859a356d
352 2020-01-07T22:30:28  <bitcoin-git> bitcoin/master e1e1442 Gregory Sanders: Activate no-privkey -> ISMINE_WATCH_ONLY behavior for LegacySPKM only
353 2020-01-07T22:30:28  <bitcoin-git> bitcoin/master cab3859 Samuel Dobson: Merge #17677: Activate watchonly wallet behavior for LegacySPKM only
354 2020-01-07T22:30:30  *** bitcoin-git has left #bitcoin-core-dev
355 2020-01-07T22:30:47  *** bitcoin-git has joined #bitcoin-core-dev
356 2020-01-07T22:30:47  <bitcoin-git> [bitcoin] meshcollider merged pull request #17677: Activate watchonly wallet behavior for LegacySPKM only (master...legacy_spkm_watchonly) https://github.com/bitcoin/bitcoin/pull/17677
357 2020-01-07T22:30:48  *** bitcoin-git has left #bitcoin-core-dev
358 2020-01-07T22:37:21  <hebasto> ryanofsky: hmm, why test/functional/feature_config_args.py passed on 67518f7cc61bf59ddfa0fd7c8dbbdec3653b9556 ?
359 2020-01-07T22:39:39  <hebasto> I see now: test is broken.
360 2020-01-07T22:39:59  <ryanofsky> test should be unaffected by that change, do you see a break somewhere?
361 2020-01-07T22:41:58  <hebasto> yes: "-connect=0x7fff50369968" != "-connect=0"
362 2020-01-07T22:46:18  *** Zenton has quit IRC
363 2020-01-07T22:47:49  *** bitcoin-git has joined #bitcoin-core-dev
364 2020-01-07T22:47:50  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cab3859a356d...fcef6dbc15ef
365 2020-01-07T22:47:50  <bitcoin-git> bitcoin/master 77ef48d Jon Atack: gitignore: ignore fuzz binaries, remove test_bitcoin_fuzzy
366 2020-01-07T22:47:51  <bitcoin-git> bitcoin/master fcef6db fanquake: Merge #17452: test: update fuzz directory in .gitignore
367 2020-01-07T22:47:53  *** bitcoin-git has left #bitcoin-core-dev
368 2020-01-07T22:48:09  *** bitcoin-git has joined #bitcoin-core-dev
369 2020-01-07T22:48:09  <bitcoin-git> [bitcoin] fanquake merged pull request #17452: test: update fuzz directory in .gitignore (master...update-fuzz-gitignore) https://github.com/bitcoin/bitcoin/pull/17452
370 2020-01-07T22:48:11  *** bitcoin-git has left #bitcoin-core-dev
371 2020-01-07T22:49:38  <ryanofsky> Oh I see how that would happen, it should not be a problem in the current PR.
372 2020-01-07T22:50:10  <hebasto> going to submit a pr to fix test
373 2020-01-07T22:50:48  <ryanofsky> in the commit you mentioned, value is a pointer to a string, and it was printing the pointer address instead of the string on: LogPrintf("Warning: parsed potentially confusing double-negative -%s=%s\n", key, value);
374 2020-01-07T22:51:21  <hebasto> correct
375 2020-01-07T22:54:41  <ryanofsky> oh I see, test could be fixed to more robust and not accept trailing characters after 0
376 2020-01-07T22:59:18  *** Guyver2_ has quit IRC
377 2020-01-07T23:00:10  *** captjakk has joined #bitcoin-core-dev
378 2020-01-07T23:11:02  *** jarthur has quit IRC
379 2020-01-07T23:11:40  *** DeanGuss has joined #bitcoin-core-dev
380 2020-01-07T23:15:26  <captjakk> does bitcoind not support the newer 54 char onion addresses for tor?
381 2020-01-07T23:15:44  <sipa> no
382 2020-01-07T23:16:11  <sipa> needs bip 155 in order to represent those
383 2020-01-07T23:17:01  *** Kiminuo has quit IRC
384 2020-01-07T23:18:11  <captjakk> what's the timeline on 155, and is it something that could benefit from engineering contributions right now, or is it still being debated what the best approach is to get it in?
385 2020-01-07T23:18:36  <sipa> i don't know if anyone is working on it right now
386 2020-01-07T23:18:51  <sipa> i don't think there are any known problems with it
387 2020-01-07T23:19:23  <captjakk> kk, so if I submit a patch implementing it, are you optimistic it would be merged assuming no implementation problems?
388 2020-01-07T23:20:52  <captjakk> I'd imagine since this isn't a consensus issue, the vuln surface is substantially smaller
389 2020-01-07T23:30:06  *** mdunnio has quit IRC
390 2020-01-07T23:31:05  *** promag has joined #bitcoin-core-dev
391 2020-01-07T23:37:02  *** promag has quit IRC
392 2020-01-07T23:39:06  *** promag has joined #bitcoin-core-dev
393 2020-01-07T23:42:59  *** AaronvanW has quit IRC
394 2020-01-07T23:49:41  *** _andrewtoth_ has joined #bitcoin-core-dev
395 2020-01-07T23:54:32  *** captjakk has quit IRC
396 2020-01-07T23:55:51  *** captjakk has joined #bitcoin-core-dev