1 2020-01-11T00:00:01  *** sledges has quit IRC
  2 2020-01-11T00:02:16  *** Chris_Stewart_5 has quit IRC
  3 2020-01-11T00:08:08  *** millerti has quit IRC
  4 2020-01-11T00:22:28  *** Giszmo has quit IRC
  5 2020-01-11T00:30:50  *** apex944 has joined #bitcoin-core-dev
  6 2020-01-11T00:31:56  *** turbo_choo has joined #bitcoin-core-dev
  7 2020-01-11T00:34:05  *** bitcoin-git has joined #bitcoin-core-dev
  8 2020-01-11T00:34:05  <bitcoin-git> [bitcoin] Empact opened pull request #17907: Fix improper Doxygen inline comments (master...settings-documentation) https://github.com/bitcoin/bitcoin/pull/17907
  9 2020-01-11T00:34:07  *** bitcoin-git has left #bitcoin-core-dev
 10 2020-01-11T00:35:33  *** apex944 has quit IRC
 11 2020-01-11T00:37:56  *** promag has quit IRC
 12 2020-01-11T00:39:33  *** belcher has quit IRC
 13 2020-01-11T00:45:13  *** jsfan has joined #bitcoin-core-dev
 14 2020-01-11T00:45:18  *** turbo_choo has quit IRC
 15 2020-01-11T00:46:38  *** andytoshi has quit IRC
 16 2020-01-11T00:47:23  *** _andrewtoth_ has quit IRC
 17 2020-01-11T00:52:00  *** turbo_choo has joined #bitcoin-core-dev
 18 2020-01-11T00:56:17  *** emilengler has quit IRC
 19 2020-01-11T01:02:45  *** meshcollider has joined #bitcoin-core-dev
 20 2020-01-11T01:06:43  *** cornfeedhobo has quit IRC
 21 2020-01-11T01:07:35  *** masterdonx2 has quit IRC
 22 2020-01-11T01:07:55  *** MasterdonX has joined #bitcoin-core-dev
 23 2020-01-11T01:10:17  *** cornfeedhobo has joined #bitcoin-core-dev
 24 2020-01-11T01:25:24  *** rex4539 has quit IRC
 25 2020-01-11T01:25:33  *** turbo_choo has quit IRC
 26 2020-01-11T01:39:56  *** hari_seldon has left #bitcoin-core-dev
 27 2020-01-11T01:40:06  *** hari_seldon has joined #bitcoin-core-dev
 28 2020-01-11T01:48:01  *** andytoshi has joined #bitcoin-core-dev
 29 2020-01-11T01:48:02  *** andytoshi has quit IRC
 30 2020-01-11T01:48:02  *** andytoshi has joined #bitcoin-core-dev
 31 2020-01-11T02:08:56  *** turbo_choo has joined #bitcoin-core-dev
 32 2020-01-11T02:19:42  *** marcoagner has quit IRC
 33 2020-01-11T02:31:49  *** apex944 has joined #bitcoin-core-dev
 34 2020-01-11T02:33:03  *** mryandao has quit IRC
 35 2020-01-11T02:36:27  *** apex944 has quit IRC
 36 2020-01-11T02:37:06  *** mryandao has joined #bitcoin-core-dev
 37 2020-01-11T02:39:33  *** AaronvanW has quit IRC
 38 2020-01-11T02:50:47  *** apex944 has joined #bitcoin-core-dev
 39 2020-01-11T02:57:43  *** apex944 has quit IRC
 40 2020-01-11T03:00:01  *** jsfan has quit IRC
 41 2020-01-11T03:01:08  *** pinheadmz has quit IRC
 42 2020-01-11T03:01:18  *** abrissbi1ne has joined #bitcoin-core-dev
 43 2020-01-11T03:03:23  *** sdaftuar has quit IRC
 44 2020-01-11T03:04:26  *** abrissbirne has quit IRC
 45 2020-01-11T03:04:28  *** sdaftuar has joined #bitcoin-core-dev
 46 2020-01-11T03:05:51  *** Kevin_ has joined #bitcoin-core-dev
 47 2020-01-11T03:07:48  *** Kevin_ has quit IRC
 48 2020-01-11T03:09:03  *** shesek has quit IRC
 49 2020-01-11T03:09:29  *** shesek has joined #bitcoin-core-dev
 50 2020-01-11T03:09:29  *** shesek has joined #bitcoin-core-dev
 51 2020-01-11T03:17:22  *** gingerling has joined #bitcoin-core-dev
 52 2020-01-11T03:31:20  *** felixfoertsch has joined #bitcoin-core-dev
 53 2020-01-11T03:34:03  *** felixfoertsch23 has quit IRC
 54 2020-01-11T03:44:12  *** Guest83 has joined #bitcoin-core-dev
 55 2020-01-11T03:53:58  *** Relis has quit IRC
 56 2020-01-11T03:55:16  *** aadams has joined #bitcoin-core-dev
 57 2020-01-11T03:55:40  *** Relis has joined #bitcoin-core-dev
 58 2020-01-11T04:03:10  *** apex944 has joined #bitcoin-core-dev
 59 2020-01-11T04:13:20  *** aadams has quit IRC
 60 2020-01-11T04:14:07  *** Guest83 has quit IRC
 61 2020-01-11T04:14:27  *** AaronvanW has joined #bitcoin-core-dev
 62 2020-01-11T04:15:59  *** Relis has quit IRC
 63 2020-01-11T04:16:34  *** Relis has joined #bitcoin-core-dev
 64 2020-01-11T04:17:46  *** Tic has quit IRC
 65 2020-01-11T04:19:33  *** apex944 has quit IRC
 66 2020-01-11T04:20:50  *** bitcoin-git has joined #bitcoin-core-dev
 67 2020-01-11T04:20:51  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f8c69677a1a8...e258ce792a48
 68 2020-01-11T04:20:52  <bitcoin-git> bitcoin/master 498cdbb Ben Woosley: Fix improper Doxygen inline comments
 69 2020-01-11T04:20:53  <bitcoin-git> bitcoin/master e258ce7 fanquake: Merge #17907: doc: Fix improper Doxygen inline comments
 70 2020-01-11T04:20:55  *** bitcoin-git has left #bitcoin-core-dev
 71 2020-01-11T04:21:10  *** bitcoin-git has joined #bitcoin-core-dev
 72 2020-01-11T04:21:10  <bitcoin-git> [bitcoin] fanquake merged pull request #17907: doc: Fix improper Doxygen inline comments (master...settings-documentation) https://github.com/bitcoin/bitcoin/pull/17907
 73 2020-01-11T04:21:23  *** bitcoin-git has left #bitcoin-core-dev
 74 2020-01-11T04:23:48  *** apex944 has joined #bitcoin-core-dev
 75 2020-01-11T04:29:55  *** ddustin has joined #bitcoin-core-dev
 76 2020-01-11T04:33:27  *** ddustin_ has joined #bitcoin-core-dev
 77 2020-01-11T04:35:14  *** Highway61 has quit IRC
 78 2020-01-11T04:36:12  *** ddustin has quit IRC
 79 2020-01-11T04:48:32  *** AaronvanW has quit IRC
 80 2020-01-11T05:00:02  *** apex944 has quit IRC
 81 2020-01-11T05:13:52  *** ddustin_ has quit IRC
 82 2020-01-11T05:13:58  *** ddustin has joined #bitcoin-core-dev
 83 2020-01-11T05:25:38  *** turbo_choo has quit IRC
 84 2020-01-11T05:26:00  *** turbo_choo has joined #bitcoin-core-dev
 85 2020-01-11T05:28:43  *** sdaftuar has quit IRC
 86 2020-01-11T05:31:26  *** sdaftuar has joined #bitcoin-core-dev
 87 2020-01-11T05:38:45  *** Guest83 has joined #bitcoin-core-dev
 88 2020-01-11T05:56:16  *** ddustin has quit IRC
 89 2020-01-11T05:56:55  *** ddustin has joined #bitcoin-core-dev
 90 2020-01-11T06:00:01  *** gingerling has quit IRC
 91 2020-01-11T06:01:08  *** ddustin has quit IRC
 92 2020-01-11T06:04:09  *** felixfoertsch has quit IRC
 93 2020-01-11T06:04:19  *** felixfoertsch has joined #bitcoin-core-dev
 94 2020-01-11T06:09:14  *** turbo_choo has quit IRC
 95 2020-01-11T06:17:28  *** brycec1 has joined #bitcoin-core-dev
 96 2020-01-11T06:28:59  *** Relis has quit IRC
 97 2020-01-11T06:45:17  *** AaronvanW has joined #bitcoin-core-dev
 98 2020-01-11T07:17:45  *** AaronvanW has quit IRC
 99 2020-01-11T07:20:50  *** hari_seldon has left #bitcoin-core-dev
100 2020-01-11T07:30:54  *** Guest83 has quit IRC
101 2020-01-11T07:59:59  *** Guest83 has joined #bitcoin-core-dev
102 2020-01-11T08:27:52  *** turbo_choo has joined #bitcoin-core-dev
103 2020-01-11T08:29:56  *** turbo_choo has quit IRC
104 2020-01-11T08:35:22  *** emilengler has joined #bitcoin-core-dev
105 2020-01-11T08:35:33  *** shesek has quit IRC
106 2020-01-11T08:35:56  *** shesek has joined #bitcoin-core-dev
107 2020-01-11T08:35:56  *** shesek has joined #bitcoin-core-dev
108 2020-01-11T08:42:03  *** midnight has quit IRC
109 2020-01-11T08:45:54  *** Talkless has joined #bitcoin-core-dev
110 2020-01-11T08:46:55  *** turbo_choo has joined #bitcoin-core-dev
111 2020-01-11T08:54:12  *** pinheadmz has joined #bitcoin-core-dev
112 2020-01-11T08:54:53  *** turbo_choo has quit IRC
113 2020-01-11T08:57:37  *** ddustin has joined #bitcoin-core-dev
114 2020-01-11T09:00:02  *** brycec1 has quit IRC
115 2020-01-11T09:02:12  *** ddustin has quit IRC
116 2020-01-11T09:14:48  *** pinheadmz has quit IRC
117 2020-01-11T09:15:17  *** AaronvanW has joined #bitcoin-core-dev
118 2020-01-11T09:16:18  *** Guest83 has quit IRC
119 2020-01-11T09:17:16  *** unfo- has joined #bitcoin-core-dev
120 2020-01-11T09:20:24  *** Guest83 has joined #bitcoin-core-dev
121 2020-01-11T09:30:35  *** rex4539 has joined #bitcoin-core-dev
122 2020-01-11T09:40:43  *** vasild has quit IRC
123 2020-01-11T09:42:40  *** vasild has joined #bitcoin-core-dev
124 2020-01-11T10:28:29  *** goatpig has joined #bitcoin-core-dev
125 2020-01-11T10:32:34  *** AaronvanW has quit IRC
126 2020-01-11T10:50:26  *** murray_ has left #bitcoin-core-dev
127 2020-01-11T10:51:01  *** murrayn has joined #bitcoin-core-dev
128 2020-01-11T11:00:46  *** Guest83 has joined #bitcoin-core-dev
129 2020-01-11T11:03:54  *** Amber36Franecki has joined #bitcoin-core-dev
130 2020-01-11T11:04:34  *** Guest83 has joined #bitcoin-core-dev
131 2020-01-11T11:12:52  *** jonatack has quit IRC
132 2020-01-11T11:16:19  *** marcoagner has joined #bitcoin-core-dev
133 2020-01-11T11:19:40  *** Talkless has quit IRC
134 2020-01-11T11:31:13  *** Amber36Franecki has quit IRC
135 2020-01-11T11:31:42  *** Talkless has joined #bitcoin-core-dev
136 2020-01-11T11:37:07  *** AaronvanW has joined #bitcoin-core-dev
137 2020-01-11T11:40:11  *** Kiminuo has joined #bitcoin-core-dev
138 2020-01-11T11:44:51  *** turbo_choo has joined #bitcoin-core-dev
139 2020-01-11T11:45:39  *** belcher has joined #bitcoin-core-dev
140 2020-01-11T12:00:01  *** unfo- has quit IRC
141 2020-01-11T12:12:19  *** Guest83 has quit IRC
142 2020-01-11T12:13:40  *** Guyver2 has joined #bitcoin-core-dev
143 2020-01-11T12:14:23  *** Talkless has quit IRC
144 2020-01-11T12:17:14  *** MTecknology1 has joined #bitcoin-core-dev
145 2020-01-11T12:21:59  *** Chris_Stewart_5 has joined #bitcoin-core-dev
146 2020-01-11T12:29:24  *** Krellan__ has joined #bitcoin-core-dev
147 2020-01-11T12:29:24  *** Krellan_ has quit IRC
148 2020-01-11T12:31:47  *** Krellan_ has joined #bitcoin-core-dev
149 2020-01-11T12:35:07  *** Krellan__ has quit IRC
150 2020-01-11T12:47:22  *** bitcoin-git has joined #bitcoin-core-dev
151 2020-01-11T12:47:23  <bitcoin-git> [bitcoin] hebasto opened pull request #17908: qa, qt: Remove QFont warnings with QT_QPA_PLATFORM=minimal (master...20200111-qttest-minimal-warn) https://github.com/bitcoin/bitcoin/pull/17908
152 2020-01-11T12:47:34  *** bitcoin-git has left #bitcoin-core-dev
153 2020-01-11T12:51:12  *** joncoe has joined #bitcoin-core-dev
154 2020-01-11T13:01:22  *** Relis has joined #bitcoin-core-dev
155 2020-01-11T13:05:31  *** Relis has quit IRC
156 2020-01-11T13:10:23  *** alec has quit IRC
157 2020-01-11T13:13:09  *** Relis has joined #bitcoin-core-dev
158 2020-01-11T13:15:47  *** Highway61 has joined #bitcoin-core-dev
159 2020-01-11T13:17:28  *** alec has joined #bitcoin-core-dev
160 2020-01-11T13:24:42  *** felixfoertsch has quit IRC
161 2020-01-11T13:24:48  <hebasto> hmm, the option to restart travis job is missing for me now...
162 2020-01-11T13:28:47  <luke-jr> hebasto: does Travis know you're logged in?
163 2020-01-11T13:30:17  <hebasto> sure, I'm logged in. It is possible to "Sign Out"
164 2020-01-11T13:32:10  <hebasto> luke-jr: signed out -> signed in. It works now, Thanks!
165 2020-01-11T13:32:27  *** Talkless has joined #bitcoin-core-dev
166 2020-01-11T13:33:18  *** felixfoertsch has joined #bitcoin-core-dev
167 2020-01-11T13:35:14  *** Kiminuo has quit IRC
168 2020-01-11T13:38:15  *** goatpig has quit IRC
169 2020-01-11T13:38:18  *** Guyver2 has quit IRC
170 2020-01-11T13:38:35  *** goatpig has joined #bitcoin-core-dev
171 2020-01-11T13:40:33  *** felixfoertsch has quit IRC
172 2020-01-11T13:45:38  *** Highway62 has joined #bitcoin-core-dev
173 2020-01-11T13:46:53  *** Highway61 has quit IRC
174 2020-01-11T13:46:54  *** Highway62 is now known as Highway61
175 2020-01-11T13:49:07  *** felixfoertsch has joined #bitcoin-core-dev
176 2020-01-11T13:56:02  *** Chris_Stewart_5 has quit IRC
177 2020-01-11T14:01:51  *** Guest83 has joined #bitcoin-core-dev
178 2020-01-11T14:02:10  *** Relis has quit IRC
179 2020-01-11T14:08:13  *** apex944 has joined #bitcoin-core-dev
180 2020-01-11T14:21:02  *** Chris_Stewart_5 has joined #bitcoin-core-dev
181 2020-01-11T14:23:41  *** goatpig has quit IRC
182 2020-01-11T14:23:59  *** goatpig has joined #bitcoin-core-dev
183 2020-01-11T14:35:15  *** Relis has joined #bitcoin-core-dev
184 2020-01-11T14:38:42  *** owowo has joined #bitcoin-core-dev
185 2020-01-11T14:55:32  *** apex944 has quit IRC
186 2020-01-11T15:00:01  *** MTecknology1 has quit IRC
187 2020-01-11T15:10:16  *** goatpig has quit IRC
188 2020-01-11T15:10:31  *** goatpig has joined #bitcoin-core-dev
189 2020-01-11T15:17:16  *** sirkitree has joined #bitcoin-core-dev
190 2020-01-11T15:19:53  *** apex944 has joined #bitcoin-core-dev
191 2020-01-11T15:23:59  *** Highway61 has quit IRC
192 2020-01-11T15:25:31  *** Highway61 has joined #bitcoin-core-dev
193 2020-01-11T15:41:09  *** apex944 has quit IRC
194 2020-01-11T15:50:44  *** Guest83 has quit IRC
195 2020-01-11T15:57:18  *** Highway62 has joined #bitcoin-core-dev
196 2020-01-11T15:58:01  *** Highway61 has quit IRC
197 2020-01-11T15:58:02  *** Highway62 is now known as Highway61
198 2020-01-11T16:03:47  *** Chris_Stewart_5 has quit IRC
199 2020-01-11T16:20:20  *** Relis has quit IRC
200 2020-01-11T16:26:06  *** Chris_Stewart_5 has joined #bitcoin-core-dev
201 2020-01-11T16:29:47  *** brianhoffman_ has joined #bitcoin-core-dev
202 2020-01-11T16:30:26  *** Guyver2 has joined #bitcoin-core-dev
203 2020-01-11T16:31:03  *** brianhoffman has quit IRC
204 2020-01-11T16:31:04  *** brianhoffman_ is now known as brianhoffman
205 2020-01-11T16:31:43  *** Relis has joined #bitcoin-core-dev
206 2020-01-11T16:38:50  *** arapaho has quit IRC
207 2020-01-11T16:38:58  *** arapaho has joined #bitcoin-core-dev
208 2020-01-11T16:39:22  *** arapaho is now known as Guest76054
209 2020-01-11T16:45:42  *** apex944 has joined #bitcoin-core-dev
210 2020-01-11T16:52:08  *** morcos has quit IRC
211 2020-01-11T16:52:36  *** morcos has joined #bitcoin-core-dev
212 2020-01-11T17:01:06  *** pinheadmz has joined #bitcoin-core-dev
213 2020-01-11T17:06:15  *** cdecker has quit IRC
214 2020-01-11T17:15:03  *** joncoe has quit IRC
215 2020-01-11T17:20:26  *** apex944 has quit IRC
216 2020-01-11T17:29:38  *** Chris_Stewart_5 has quit IRC
217 2020-01-11T17:36:52  *** pinheadmz has quit IRC
218 2020-01-11T17:49:39  *** Chris_Stewart_5 has joined #bitcoin-core-dev
219 2020-01-11T17:51:26  *** Relis has quit IRC
220 2020-01-11T17:51:27  *** Kiminuo has joined #bitcoin-core-dev
221 2020-01-11T17:53:29  *** Relis has joined #bitcoin-core-dev
222 2020-01-11T17:55:52  *** apex944 has joined #bitcoin-core-dev
223 2020-01-11T17:58:48  <Kiminuo> https://github.com/bitcoin/bitcoin/blob/master/src/net_processing.cpp#L2448 - Could anyone explain this further to me? Is that byte 0x00 required for some specific reason or is it how Satoshi did that?
224 2020-01-11T18:00:01  *** sirkitree has quit IRC
225 2020-01-11T18:01:24  *** setpill has joined #bitcoin-core-dev
226 2020-01-11T18:01:27  *** apex944 has quit IRC
227 2020-01-11T18:04:02  *** promag has joined #bitcoin-core-dev
228 2020-01-11T18:05:13  <sipa> Kiminuo: the p2p protocol used to have no distinction between cblock and cblockheader
229 2020-01-11T18:05:25  <sipa> headers were just submitted as blocks with no transactiond
230 2020-01-11T18:10:20  <Kiminuo> thanks, that makes sene
231 2020-01-11T18:10:22  <Kiminuo> *sense
232 2020-01-11T18:17:09  *** Laat has joined #bitcoin-core-dev
233 2020-01-11T18:23:44  *** pinheadmz has joined #bitcoin-core-dev
234 2020-01-11T18:26:06  *** promag has quit IRC
235 2020-01-11T18:33:53  *** setpill has quit IRC
236 2020-01-11T18:35:32  *** tynes_ has joined #bitcoin-core-dev
237 2020-01-11T18:36:06  *** tynes has quit IRC
238 2020-01-11T18:40:36  *** jeremyrubin has quit IRC
239 2020-01-11T18:47:38  *** victorSN has quit IRC
240 2020-01-11T18:48:22  *** victorSN has joined #bitcoin-core-dev
241 2020-01-11T18:49:14  *** Chris_Stewart_5 has quit IRC
242 2020-01-11T18:53:32  *** victorSN6 has joined #bitcoin-core-dev
243 2020-01-11T18:54:03  *** sipa has quit IRC
244 2020-01-11T18:57:08  *** victorSN has quit IRC
245 2020-01-11T18:57:08  *** victorSN6 is now known as victorSN
246 2020-01-11T19:00:02  *** dr-orlovsky has quit IRC
247 2020-01-11T19:01:17  *** sipa has joined #bitcoin-core-dev
248 2020-01-11T19:01:49  *** dr-orlovsky has joined #bitcoin-core-dev
249 2020-01-11T19:02:12  *** Chris_Stewart_5 has joined #bitcoin-core-dev
250 2020-01-11T19:10:03  *** pinheadmz has quit IRC
251 2020-01-11T19:18:51  *** Relis7 has joined #bitcoin-core-dev
252 2020-01-11T19:19:00  *** TheRec_ has joined #bitcoin-core-dev
253 2020-01-11T19:19:00  *** TheRec_ has joined #bitcoin-core-dev
254 2020-01-11T19:19:48  *** brianhoffman_ has joined #bitcoin-core-dev
255 2020-01-11T19:21:44  *** TheRec has quit IRC
256 2020-01-11T19:21:44  *** Relis has quit IRC
257 2020-01-11T19:21:44  *** victorSN has quit IRC
258 2020-01-11T19:21:44  *** brianhoffman has quit IRC
259 2020-01-11T19:21:44  *** thaumavorio has quit IRC
260 2020-01-11T19:21:45  *** niska has quit IRC
261 2020-01-11T19:21:46  *** brianhoffman_ is now known as brianhoffman
262 2020-01-11T19:21:47  *** sturles has quit IRC
263 2020-01-11T19:22:01  *** thaumavorio_ has joined #bitcoin-core-dev
264 2020-01-11T19:22:16  *** GAit has quit IRC
265 2020-01-11T19:22:46  *** sturles has joined #bitcoin-core-dev
266 2020-01-11T19:22:46  *** sturles has joined #bitcoin-core-dev
267 2020-01-11T19:23:38  *** rh0nj has quit IRC
268 2020-01-11T19:27:03  *** niska has joined #bitcoin-core-dev
269 2020-01-11T19:49:06  *** GAit has joined #bitcoin-core-dev
270 2020-01-11T20:02:48  *** Chris_Stewart_5 has quit IRC
271 2020-01-11T20:11:19  *** lukedashjr has joined #bitcoin-core-dev
272 2020-01-11T20:12:18  *** luke-jr has quit IRC
273 2020-01-11T20:16:27  *** lukedashjr is now known as luke-jr
274 2020-01-11T20:24:15  *** Relis7 has quit IRC
275 2020-01-11T20:26:45  *** promag has joined #bitcoin-core-dev
276 2020-01-11T20:28:28  *** apex944 has joined #bitcoin-core-dev
277 2020-01-11T20:31:20  *** promag has quit IRC
278 2020-01-11T20:32:52  *** real_or_random has quit IRC
279 2020-01-11T20:33:08  *** apex944 has quit IRC
280 2020-01-11T20:33:23  *** afk11 has quit IRC
281 2020-01-11T20:35:18  *** Relis7 has joined #bitcoin-core-dev
282 2020-01-11T20:35:26  *** afk11 has joined #bitcoin-core-dev
283 2020-01-11T20:38:14  *** real_or_random has joined #bitcoin-core-dev
284 2020-01-11T20:50:39  *** promag has joined #bitcoin-core-dev
285 2020-01-11T20:54:32  *** captjakk has joined #bitcoin-core-dev
286 2020-01-11T20:57:10  *** captjakk has quit IRC
287 2020-01-11T21:00:02  *** Laat has quit IRC
288 2020-01-11T21:16:31  *** mackr has joined #bitcoin-core-dev
289 2020-01-11T21:33:49  *** brianhoffman_ has joined #bitcoin-core-dev
290 2020-01-11T21:34:56  *** brianhoffman has quit IRC
291 2020-01-11T21:34:56  *** brianhoffman_ is now known as brianhoffman
292 2020-01-11T21:40:43  *** vasild has quit IRC
293 2020-01-11T21:40:52  *** cdecker has joined #bitcoin-core-dev
294 2020-01-11T21:41:23  *** owowo has quit IRC
295 2020-01-11T21:42:39  *** vasild has joined #bitcoin-core-dev
296 2020-01-11T21:44:51  *** brianhoffman has quit IRC
297 2020-01-11T21:45:53  *** owowo has joined #bitcoin-core-dev
298 2020-01-11T21:57:08  *** Kiminuo has quit IRC
299 2020-01-11T22:08:31  *** Jackielove4u has quit IRC
300 2020-01-11T22:09:23  *** brianhoffman has joined #bitcoin-core-dev
301 2020-01-11T22:12:31  *** Highway61 has quit IRC
302 2020-01-11T22:12:59  *** Highway61 has joined #bitcoin-core-dev
303 2020-01-11T22:13:47  *** filchef has joined #bitcoin-core-dev
304 2020-01-11T22:15:13  *** filchef has quit IRC
305 2020-01-11T22:20:15  *** Highway61 has quit IRC
306 2020-01-11T22:20:36  *** Highway61 has joined #bitcoin-core-dev
307 2020-01-11T22:24:47  *** jonatack has joined #bitcoin-core-dev
308 2020-01-11T22:26:07  *** Highway61 has quit IRC
309 2020-01-11T22:26:47  *** victorSN has joined #bitcoin-core-dev
310 2020-01-11T22:27:11  *** Highway61 has joined #bitcoin-core-dev
311 2020-01-11T22:35:26  *** Guyver2 has quit IRC
312 2020-01-11T22:43:38  *** Talkless has quit IRC
313 2020-01-11T22:43:59  *** Talkless has joined #bitcoin-core-dev
314 2020-01-11T22:47:03  *** Highway61 has quit IRC
315 2020-01-11T22:53:04  *** AaronvanW has quit IRC
316 2020-01-11T23:03:23  *** mfoolb has quit IRC
317 2020-01-11T23:03:56  *** mfoolb has joined #bitcoin-core-dev
318 2020-01-11T23:12:19  <emilengler> Is there an efficient way to get the output type from a "WalletAddress"?
319 2020-01-11T23:12:37  <emilengler> Or from a CTxDestination
320 2020-01-11T23:14:38  <sipa> a CTxDestination is a boost::variant
321 2020-01-11T23:15:00  <sipa> it has a bunch of built in methods to query the type
322 2020-01-11T23:16:11  <emilengler> sipa: I see but what's the "best way" to get the output type from it
323 2020-01-11T23:16:39  *** apex944 has joined #bitcoin-core-dev
324 2020-01-11T23:16:46  <emilengler> Looks like there is no function which returns OutputType where CTxDestination is a parameter of
325 2020-01-11T23:29:09  <sipa> no, that's impossible
326 2020-01-11T23:29:37  <sipa> you can't distinguish p2sh multisig from p2sh-p2wsh multisig for example
327 2020-01-11T23:29:46  <sipa> just based on the address
328 2020-01-11T23:30:11  <emilengler> Ok thanks
329 2020-01-11T23:30:58  <sipa> what are you trying to do?
330 2020-01-11T23:31:56  <emilengler> In bitcoin-qt I wanna sort out all non legacy addresses in the sign message dialog as they are useless in this case anyway
331 2020-01-11T23:32:10  <emilengler> The addressbook*
332 2020-01-11T23:33:35  <luke-jr> can't signmessage with p2sh either, so that's doable
333 2020-01-11T23:34:13  <luke-jr> should be able to just use .get
334 2020-01-11T23:34:55  <emilengler> luke-jr: get? Of which object?
335 2020-01-11T23:35:03  <luke-jr> the CTxDestination
336 2020-01-11T23:36:54  *** midnightmagic has joined #bitcoin-core-dev
337 2020-01-11T23:37:00  <luke-jr> boost::get<PKHash>(&dest)
338 2020-01-11T23:38:22  <emilengler> So I need to check every possible type?
339 2020-01-11T23:38:37  <luke-jr> only PKHash because that's the only type that's valid for signing
340 2020-01-11T23:38:46  *** owowo has quit IRC
341 2020-01-11T23:38:52  <luke-jr> dest.type() is another way, possibly more efficient and more flexible
342 2020-01-11T23:38:55  <emilengler> Oh sure
343 2020-01-11T23:39:02  <emilengler> thanks
344 2020-01-11T23:39:11  <emilengler> what is with .which()
345 2020-01-11T23:41:02  *** owowo has joined #bitcoin-core-dev
346 2020-01-11T23:42:52  *** cdecker has quit IRC
347 2020-01-11T23:43:27  <emilengler> luke-jr: Thx, works
348 2020-01-11T23:43:30  *** cdecker has joined #bitcoin-core-dev
349 2020-01-11T23:43:45  *** luke-jr has quit IRC
350 2020-01-11T23:44:22  *** luke-jr has joined #bitcoin-core-dev