1 2020-01-15T00:00:01  *** OneFixt has quit IRC
  2 2020-01-15T00:00:18  *** felixfoertsch has joined #bitcoin-core-dev
  3 2020-01-15T00:01:30  *** DeanGuss has joined #bitcoin-core-dev
  4 2020-01-15T00:17:29  *** Implant1 has joined #bitcoin-core-dev
  5 2020-01-15T00:18:30  *** timothy has quit IRC
  6 2020-01-15T00:19:47  *** jarthur_ has joined #bitcoin-core-dev
  7 2020-01-15T00:22:42  *** cubancorona has quit IRC
  8 2020-01-15T00:23:37  *** jarthur has quit IRC
  9 2020-01-15T00:24:02  *** Highway61 has quit IRC
 10 2020-01-15T00:24:53  *** jarthur_ has quit IRC
 11 2020-01-15T00:31:32  *** Highway61 has joined #bitcoin-core-dev
 12 2020-01-15T01:01:00  *** promag_ has quit IRC
 13 2020-01-15T01:01:40  *** turbo_choo has joined #bitcoin-core-dev
 14 2020-01-15T01:13:18  *** turbo_choo has quit IRC
 15 2020-01-15T01:13:37  *** belcher has quit IRC
 16 2020-01-15T01:14:04  *** turbo_choo has joined #bitcoin-core-dev
 17 2020-01-15T01:17:07  *** marcoagner has quit IRC
 18 2020-01-15T01:19:59  *** turbo_choo has quit IRC
 19 2020-01-15T01:24:06  *** turbo_choo has joined #bitcoin-core-dev
 20 2020-01-15T01:36:50  *** Highway61 has quit IRC
 21 2020-01-15T01:38:23  *** andrewtoth_ has quit IRC
 22 2020-01-15T01:41:14  *** rex4539 has quit IRC
 23 2020-01-15T01:41:55  *** BGL has joined #bitcoin-core-dev
 24 2020-01-15T01:43:07  *** sipsorcery has quit IRC
 25 2020-01-15T02:24:20  *** rex4539 has joined #bitcoin-core-dev
 26 2020-01-15T02:39:31  *** jeremyrubin has joined #bitcoin-core-dev
 27 2020-01-15T02:48:05  *** promag_ has joined #bitcoin-core-dev
 28 2020-01-15T02:52:46  *** promag_ has quit IRC
 29 2020-01-15T02:53:10  *** jarthur has joined #bitcoin-core-dev
 30 2020-01-15T03:00:02  *** Implant1 has quit IRC
 31 2020-01-15T03:01:18  *** abrissbi1ne has joined #bitcoin-core-dev
 32 2020-01-15T03:04:36  *** abrissbirne has quit IRC
 33 2020-01-15T03:17:20  *** KuluBot has joined #bitcoin-core-dev
 34 2020-01-15T03:21:35  *** andrewtoth_ has joined #bitcoin-core-dev
 35 2020-01-15T03:26:12  *** DeanGuss has quit IRC
 36 2020-01-15T03:26:35  *** DeanGuss has joined #bitcoin-core-dev
 37 2020-01-15T03:27:25  *** psqnt has joined #bitcoin-core-dev
 38 2020-01-15T03:29:30  *** felixfoertsch23 has joined #bitcoin-core-dev
 39 2020-01-15T03:30:27  *** felixfoertsch has quit IRC
 40 2020-01-15T03:33:47  *** psqnt has quit IRC
 41 2020-01-15T03:40:41  *** apex944 has joined #bitcoin-core-dev
 42 2020-01-15T03:44:19  *** bitcoin-git has joined #bitcoin-core-dev
 43 2020-01-15T03:44:19  <bitcoin-git> [bitcoin] JeremyRubin closed pull request #17268: Epoch Mempool (master...mempool-experiments-2) https://github.com/bitcoin/bitcoin/pull/17268
 44 2020-01-15T03:44:20  *** bitcoin-git has left #bitcoin-core-dev
 45 2020-01-15T03:46:08  *** apex944 has quit IRC
 46 2020-01-15T03:51:52  *** apex944 has joined #bitcoin-core-dev
 47 2020-01-15T04:01:25  <fanquake> Wrote notes up for anyone that would like to test some of the changes in #17916
 48 2020-01-15T04:01:27  <gribble> https://github.com/bitcoin/bitcoin/issues/17916 | windows: Enable heap terminate-on-corruption by fanquake · Pull Request #17916 · bitcoin/bitcoin · GitHub
 49 2020-01-15T04:01:32  <fanquake> https://github.com/bitcoin/bitcoin/pull/17916#issuecomment-574485179
 50 2020-01-15T04:01:44  *** AaronvanW has quit IRC
 51 2020-01-15T04:02:40  *** AaronvanW has joined #bitcoin-core-dev
 52 2020-01-15T04:07:30  *** AaronvanW has quit IRC
 53 2020-01-15T04:31:39  *** Eagle[TM] has joined #bitcoin-core-dev
 54 2020-01-15T04:33:47  *** EagleTM has quit IRC
 55 2020-01-15T04:38:17  *** Randolf has joined #bitcoin-core-dev
 56 2020-01-15T04:38:57  *** apex944 has quit IRC
 57 2020-01-15T04:43:06  *** andrewtoth_ has quit IRC
 58 2020-01-15T05:03:01  *** ghost43_ is now known as ghost43
 59 2020-01-15T05:21:54  *** AaronvanW has joined #bitcoin-core-dev
 60 2020-01-15T05:39:49  *** promag_ has joined #bitcoin-core-dev
 61 2020-01-15T05:44:43  *** promag_ has quit IRC
 62 2020-01-15T05:45:25  *** jarthur has quit IRC
 63 2020-01-15T05:47:00  *** bitcoin-git has joined #bitcoin-core-dev
 64 2020-01-15T05:47:02  <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ceb789cf3a90...af05bd9e1e36
 65 2020-01-15T05:47:02  <bitcoin-git> bitcoin/master 6cbe620 MarcoFalke: scripted-diff: Replace CCriticalSection with RecursiveMutex
 66 2020-01-15T05:47:03  <bitcoin-git> bitcoin/master e09c701 MarcoFalke: scripted-diff: Bump copyright of files changed in 2020
 67 2020-01-15T05:47:04  <bitcoin-git> bitcoin/master af05bd9 fanquake: Merge #17891: scripted-diff: Replace CCriticalSection with RecursiveMutex
 68 2020-01-15T05:47:06  *** bitcoin-git has left #bitcoin-core-dev
 69 2020-01-15T05:47:20  *** bitcoin-git has joined #bitcoin-core-dev
 70 2020-01-15T05:47:20  <bitcoin-git> [bitcoin] fanquake merged pull request #17891: scripted-diff: Replace CCriticalSection with RecursiveMutex (master...2001-c2-CC) https://github.com/bitcoin/bitcoin/pull/17891
 71 2020-01-15T05:47:21  *** bitcoin-git has left #bitcoin-core-dev
 72 2020-01-15T05:48:03  *** ExEric3 has quit IRC
 73 2020-01-15T05:48:51  *** jarthur has joined #bitcoin-core-dev
 74 2020-01-15T05:55:25  *** AaronvanW has quit IRC
 75 2020-01-15T06:00:01  *** KuluBot has quit IRC
 76 2020-01-15T06:05:30  *** jeremyrubin has quit IRC
 77 2020-01-15T06:09:58  *** ExEric3 has joined #bitcoin-core-dev
 78 2020-01-15T06:17:06  *** MarconM has joined #bitcoin-core-dev
 79 2020-01-15T06:20:33  *** bitcoin-git has joined #bitcoin-core-dev
 80 2020-01-15T06:20:34  <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/af05bd9e1e36...002f9e9b4041
 81 2020-01-15T06:20:34  <bitcoin-git> bitcoin/master 7f5db16 Luke Dashjr: GUI: Use PACKAGE_NAME in modal overlay
 82 2020-01-15T06:20:35  <bitcoin-git> bitcoin/master 5855cc5 Luke Dashjr: bitcoin-wallet: Use PACKAGE_NAME in usage help
 83 2020-01-15T06:20:35  <bitcoin-git> bitcoin/master 002f9e9 fanquake: Merge #17923: refactor: Use PACKAGE_NAME in GUI modal overlay and bitcoin-...
 84 2020-01-15T06:20:45  *** bitcoin-git has left #bitcoin-core-dev
 85 2020-01-15T06:21:03  *** bitcoin-git has joined #bitcoin-core-dev
 86 2020-01-15T06:21:04  <bitcoin-git> [bitcoin] fanquake merged pull request #17923: refactor: Use PACKAGE_NAME in GUI modal overlay and bitcoin-wallet (master...fix_pkgname_202001) https://github.com/bitcoin/bitcoin/pull/17923
 87 2020-01-15T06:21:16  *** bitcoin-git has left #bitcoin-core-dev
 88 2020-01-15T06:23:30  *** Skirmant has joined #bitcoin-core-dev
 89 2020-01-15T06:27:47  <fanquake> mehscollider: can you take a look at #17843
 90 2020-01-15T06:27:50  <gribble> https://github.com/bitcoin/bitcoin/issues/17843 | wallet: Reset reused transactions cache by fjahr · Pull Request #17843 · bitcoin/bitcoin · GitHub
 91 2020-01-15T06:30:05  *** vasild_ is now known as vasild
 92 2020-01-15T07:10:45  *** goatpig has joined #bitcoin-core-dev
 93 2020-01-15T07:18:11  *** Skirmant has quit IRC
 94 2020-01-15T07:22:22  *** Eagle[TM] has quit IRC
 95 2020-01-15T07:24:47  *** jonatack has quit IRC
 96 2020-01-15T07:29:33  *** jonatack has joined #bitcoin-core-dev
 97 2020-01-15T07:43:52  *** jonatack has quit IRC
 98 2020-01-15T07:48:11  *** Randolf has quit IRC
 99 2020-01-15T07:52:41  *** AaronvanW has joined #bitcoin-core-dev
100 2020-01-15T07:59:22  *** aqquadro has joined #bitcoin-core-dev
101 2020-01-15T08:08:52  *** promag has quit IRC
102 2020-01-15T08:09:24  *** promag has joined #bitcoin-core-dev
103 2020-01-15T08:16:52  *** Guyver2 has joined #bitcoin-core-dev
104 2020-01-15T08:17:13  *** promag has quit IRC
105 2020-01-15T08:20:07  *** Bullitje has quit IRC
106 2020-01-15T08:21:49  *** Skirmant has joined #bitcoin-core-dev
107 2020-01-15T08:21:49  *** Bullit has joined #bitcoin-core-dev
108 2020-01-15T08:25:17  *** Krellan_ has quit IRC
109 2020-01-15T08:25:35  *** AaronvanW has quit IRC
110 2020-01-15T08:33:02  *** real_or_random has quit IRC
111 2020-01-15T08:34:27  *** Krellan_ has joined #bitcoin-core-dev
112 2020-01-15T08:39:25  *** real_or_random has joined #bitcoin-core-dev
113 2020-01-15T08:44:17  *** abrissbi1ne is now known as abrissbirne
114 2020-01-15T08:59:33  <meshcollider> fanquake: Yep sure :)
115 2020-01-15T08:59:49  <fanquake> meshcollider: cheers 👍
116 2020-01-15T09:00:02  *** MarconM has quit IRC
117 2020-01-15T09:06:47  *** Guyver2 has quit IRC
118 2020-01-15T09:12:10  *** bitcoin-git has joined #bitcoin-core-dev
119 2020-01-15T09:12:11  <bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/002f9e9b4041...ac61ec9da679
120 2020-01-15T09:12:11  <bitcoin-git> bitcoin/master 6fc554f Fabian Jahr: wallet: Reset reused transactions cache
121 2020-01-15T09:12:12  <bitcoin-git> bitcoin/master ac61ec9 Samuel Dobson: Merge #17843: wallet: Reset reused transactions cache
122 2020-01-15T09:12:14  *** bitcoin-git has left #bitcoin-core-dev
123 2020-01-15T09:12:30  *** bitcoin-git has joined #bitcoin-core-dev
124 2020-01-15T09:12:30  <bitcoin-git> [bitcoin] meshcollider merged pull request #17843: wallet: Reset reused transactions cache (master...getbalances) https://github.com/bitcoin/bitcoin/pull/17843
125 2020-01-15T09:12:42  *** bitcoin-git has left #bitcoin-core-dev
126 2020-01-15T09:14:16  *** jonatack has joined #bitcoin-core-dev
127 2020-01-15T09:15:01  <fanquake> meshcollider: can you confirm #17603 is closed by just that PR, and isn’t also waiting for the other one mentioned in the PR body? Or diregard if you are looking at the other one now.
128 2020-01-15T09:15:03  <gribble> https://github.com/bitcoin/bitcoin/issues/17603 | partial spend avoidance makes partial spends and getbalances doesnt notice · Issue #17603 · bitcoin/bitcoin · GitHub
129 2020-01-15T09:15:07  <fanquake> *disregard
130 2020-01-15T09:15:48  *** AaronvanW has joined #bitcoin-core-dev
131 2020-01-15T09:16:10  <meshcollider> I'll reopen the issue, I think it should be closed after the second one
132 2020-01-15T09:16:20  <fanquake> Thanks
133 2020-01-15T09:17:33  *** kutio has joined #bitcoin-core-dev
134 2020-01-15T09:24:25  *** dviola has joined #bitcoin-core-dev
135 2020-01-15T09:26:58  *** promag has joined #bitcoin-core-dev
136 2020-01-15T09:29:38  *** AaronvanW has quit IRC
137 2020-01-15T09:29:55  *** AaronvanW has joined #bitcoin-core-dev
138 2020-01-15T09:32:57  *** marcoagner has joined #bitcoin-core-dev
139 2020-01-15T09:40:43  *** vasild has quit IRC
140 2020-01-15T09:41:46  <wumpus> "make check" seems to hang indefinitely here on "bench/bench_bitcoin -evals=1 -scaling=0 > /dev/null"
141 2020-01-15T09:41:49  *** Zenton has joined #bitcoin-core-dev
142 2020-01-15T09:42:43  *** vasild has joined #bitcoin-core-dev
143 2020-01-15T09:43:03  <fanquake> wumpus: using latest master?
144 2020-01-15T09:43:04  <wumpus> (doesn't seem to be actually benchmarking, CPU use of the bench_bitcoin process is 1% or so…)
145 2020-01-15T09:43:15  <wumpus> yes
146 2020-01-15T09:43:55  <wumpus> might be a fluke, dunno, maybe I can attach a debugger
147 2020-01-15T09:44:28  <fanquake> Taking a look. Haven't seen any issues today
148 2020-01-15T09:44:37  *** Guest83_ has joined #bitcoin-core-dev
149 2020-01-15T09:45:35  <wumpus> oh it passed; that definitely took long
150 2020-01-15T09:46:16  <wumpus> (debugging is great, by the time I figured out how to enable ptrace on linux again it had already passed :-) )
151 2020-01-15T09:46:33  <fanquake> heh
152 2020-01-15T09:47:15  <wumpus> still, it's expected to pass virtually instantly isn't it, with the evals=1 scaling=0
153 2020-01-15T09:47:36  <wumpus> (still not entirely sure why "test" runs a benchmark)
154 2020-01-15T09:48:05  <fanquake> yes, here it takes ~3.8s
155 2020-01-15T09:49:28  <wumpus> sending the results to /dev/null, at that :-)
156 2020-01-15T09:51:58  *** aqquadro has quit IRC
157 2020-01-15T09:53:55  <wumpus> running it manually also runs very slow, might be a hw or local issue? trying to run it on another machine
158 2020-01-15T09:57:45  *** timothy has joined #bitcoin-core-dev
159 2020-01-15T09:58:53  <wumpus> real    1m44.629s user    0m3.896s sys     0m0.853s
160 2020-01-15T09:59:19  <wumpus> quite different from 3.8s :)
161 2020-01-15T09:59:46  <fanquake> indeed: real	0m3.910s user	0m2.194s sys	0m0.817s
162 2020-01-15T09:59:51  <wumpus> it spends its time sleeping or waiting for i/o
163 2020-01-15T10:03:03  <wumpus> done some shotgun profiling: fdatasync is the culprit, everyt ime
164 2020-01-15T10:03:51  <wumpus> in CBanDB::Write ?!?
165 2020-01-15T10:04:31  <wumpus> why is the BanMan dumping the ban list between every benchmark
166 2020-01-15T10:04:44  *** kexkey has quit IRC
167 2020-01-15T10:05:31  <promag> fanquake: I've included instagibbs fix in the backport
168 2020-01-15T10:06:00  <fanquake> promag thanks, can you update the pr body
169 2020-01-15T10:06:03  *** vasild has quit IRC
170 2020-01-15T10:06:13  <promag> will do after ci
171 2020-01-15T10:07:00  <promag> it that doesn't go well then we could split the backport and push the non controversial to 0.19
172 2020-01-15T10:07:04  <promag> *if
173 2020-01-15T10:07:34  <wumpus> removing the m_node.banman instantiation it runs in 4 seconds
174 2020-01-15T10:08:01  *** aqquadro has joined #bitcoin-core-dev
175 2020-01-15T10:08:16  *** vasild has joined #bitcoin-core-dev
176 2020-01-15T10:11:07  <promag> quite a difference indeed
177 2020-01-15T10:11:24  *** promag has quit IRC
178 2020-01-15T10:11:37  <wumpus> can't reproduce it on any other machine, so seems a local issue, still strange, I've noticed slowness with fdatasync in VMs before but not on bare hw
179 2020-01-15T10:15:49  *** Guest83_ has quit IRC
180 2020-01-15T10:16:18  *** AaronvanW has quit IRC
181 2020-01-15T10:17:23  *** mryandao has quit IRC
182 2020-01-15T10:17:59  *** mryandao has joined #bitcoin-core-dev
183 2020-01-15T10:25:08  *** bitcoin-git has joined #bitcoin-core-dev
184 2020-01-15T10:25:08  <bitcoin-git> [bitcoin] Bushstar opened pull request #17928: depends: Consistent use of package variable (master...patch-4) https://github.com/bitcoin/bitcoin/pull/17928
185 2020-01-15T10:25:09  *** bitcoin-git has left #bitcoin-core-dev
186 2020-01-15T10:26:38  *** TheRec_ has quit IRC
187 2020-01-15T10:27:13  *** mryandao has quit IRC
188 2020-01-15T10:27:33  *** goosie has joined #bitcoin-core-dev
189 2020-01-15T10:28:54  *** goosie has quit IRC
190 2020-01-15T10:32:15  *** mryandao has joined #bitcoin-core-dev
191 2020-01-15T10:32:34  *** jarthur has quit IRC
192 2020-01-15T10:45:19  *** bitcoin-git has joined #bitcoin-core-dev
193 2020-01-15T10:45:20  <bitcoin-git> [bitcoin] kallewoof closed pull request #17838: test: test the >10 UTXO case for output groups (master...191231-test-avoidreuse-many-utxos) https://github.com/bitcoin/bitcoin/pull/17838
194 2020-01-15T10:45:31  *** bitcoin-git has left #bitcoin-core-dev
195 2020-01-15T10:45:51  *** TheRec has joined #bitcoin-core-dev
196 2020-01-15T10:45:51  *** TheRec has joined #bitcoin-core-dev
197 2020-01-15T10:47:16  *** AaronvanW has joined #bitcoin-core-dev
198 2020-01-15T10:51:38  *** AaronvanW has quit IRC
199 2020-01-15T10:55:21  *** promag_ has joined #bitcoin-core-dev
200 2020-01-15T10:57:48  *** jonatack has quit IRC
201 2020-01-15T11:01:27  *** promag_ has quit IRC
202 2020-01-15T11:04:03  *** Gavin88Veum has joined #bitcoin-core-dev
203 2020-01-15T11:06:16  *** felixfoertsch23 has quit IRC
204 2020-01-15T11:08:31  *** belcher has joined #bitcoin-core-dev
205 2020-01-15T11:13:33  *** Gavin88Veum has quit IRC
206 2020-01-15T11:25:50  *** AaronvanW has joined #bitcoin-core-dev
207 2020-01-15T11:27:53  *** felixfoertsch has joined #bitcoin-core-dev
208 2020-01-15T11:44:07  *** jcoe has joined #bitcoin-core-dev
209 2020-01-15T11:46:08  *** promag has joined #bitcoin-core-dev
210 2020-01-15T11:46:10  *** Guest83_ has joined #bitcoin-core-dev
211 2020-01-15T11:48:41  <wumpus> going to test #16702
212 2020-01-15T11:48:44  <gribble> https://github.com/bitcoin/bitcoin/issues/16702 | p2p: supplying and using asmap to improve IP bucketing in addrman by naumenkogs · Pull Request #16702 · bitcoin/bitcoin · GitHub
213 2020-01-15T11:54:32  *** dviola has quit IRC
214 2020-01-15T11:59:19  *** jonatack has joined #bitcoin-core-dev
215 2020-01-15T11:59:21  <elichai2> which python version do we require in the functional test?
216 2020-01-15T11:59:22  *** AaronvanW has quit IRC
217 2020-01-15T11:59:33  <fanquake> 3.5
218 2020-01-15T11:59:54  <fanquake> See the .python-version file
219 2020-01-15T12:00:01  *** kutio has quit IRC
220 2020-01-15T12:00:02  <elichai2> hmm `p2p_invalid_messages.py` fails for me in 3.8 because of a warning it prints
221 2020-01-15T12:00:17  <elichai2> oh wait
222 2020-01-15T12:00:22  <elichai2> it requires 3.5
223 2020-01-15T12:00:28  <elichai2> i'll check and PR
224 2020-01-15T12:00:33  <fanquake> We support >= 3.5
225 2020-01-15T12:00:35  <elichai2> (I thought the "fix" requires python 3.7)
226 2020-01-15T12:01:46  *** bitcoin-git has joined #bitcoin-core-dev
227 2020-01-15T12:01:47  <bitcoin-git> [bitcoin] fanquake opened pull request #17929: build: pass optimization flags to the linker (master...pass_optimizations_to_linker) https://github.com/bitcoin/bitcoin/pull/17929
228 2020-01-15T12:01:58  *** bitcoin-git has left #bitcoin-core-dev
229 2020-01-15T12:05:15  <promag> fanquake: updated pr body
230 2020-01-15T12:05:36  <fanquake> promag thanks. Can you also add #17634
231 2020-01-15T12:05:38  <gribble> https://github.com/bitcoin/bitcoin/issues/17634 | qt: Fix comparison function signature by hebasto · Pull Request #17634 · bitcoin/bitcoin · GitHub
232 2020-01-15T12:06:06  <fanquake> I think it makes sense to backport that, given it fixes the qt build on our minimum supported centos.
233 2020-01-15T12:06:22  <fanquake> Should at least be able to compile if we claim to support it.
234 2020-01-15T12:12:57  *** Skirmant has quit IRC
235 2020-01-15T12:13:29  <promag> fanquake: done
236 2020-01-15T12:15:15  <fanquake> thanks
237 2020-01-15T12:16:07  <promag> #15443
238 2020-01-15T12:16:11  <gribble> https://github.com/bitcoin/bitcoin/issues/15443 | qa: Add getdescriptorinfo functional test by promag · Pull Request #15443 · bitcoin/bitcoin · GitHub
239 2020-01-15T12:16:21  <promag> meshcollider: please look this one ^
240 2020-01-15T12:16:22  <wumpus> python 3.8 definitely supposed to be supported, if it doesn't that's a bug
241 2020-01-15T12:17:19  *** laxanofido has joined #bitcoin-core-dev
242 2020-01-15T12:23:04  <promag> jamesob: will blockman have it's own mutex?
243 2020-01-15T12:28:26  *** rex4539 has quit IRC
244 2020-01-15T12:29:17  <promag> going to push the worst pr of 2020, sorry
245 2020-01-15T12:29:50  <fanquake> "delete whitespace"
246 2020-01-15T12:30:19  <fanquake> At least there's another 11 months for someone to steal the title
247 2020-01-15T12:31:14  *** bitcoin-git has joined #bitcoin-core-dev
248 2020-01-15T12:31:14  <bitcoin-git> [bitcoin] promag opened pull request #17930: rpc: Don't lock cs_main in getblock if verbosity=0 (master...2020-01-getblock-avoid-lock) https://github.com/bitcoin/bitcoin/pull/17930
249 2020-01-15T12:31:15  *** bitcoin-git has left #bitcoin-core-dev
250 2020-01-15T12:31:27  *** felixfoertsch has quit IRC
251 2020-01-15T12:31:53  <promag> fanquake: lol
252 2020-01-15T12:32:17  *** felixfoertsch has joined #bitcoin-core-dev
253 2020-01-15T12:33:01  *** jarthur has joined #bitcoin-core-dev
254 2020-01-15T12:33:58  <promag> I said it's stupid :| it's wrong
255 2020-01-15T12:34:00  *** bitcoin-git has joined #bitcoin-core-dev
256 2020-01-15T12:34:00  <bitcoin-git> [bitcoin] promag closed pull request #17930: rpc: Don't lock cs_main in getblock if verbosity=0 (master...2020-01-getblock-avoid-lock) https://github.com/bitcoin/bitcoin/pull/17930
257 2020-01-15T12:34:01  *** bitcoin-git has left #bitcoin-core-dev
258 2020-01-15T12:36:35  <promag> I don't get it, does ReadBlockFromDisk requires the lock or not?
259 2020-01-15T12:36:41  *** Skirmant has joined #bitcoin-core-dev
260 2020-01-15T12:38:27  *** jarthur has quit IRC
261 2020-01-15T12:40:15  *** promag has quit IRC
262 2020-01-15T12:43:10  *** rex4539 has joined #bitcoin-core-dev
263 2020-01-15T12:46:21  *** volbil has joined #bitcoin-core-dev
264 2020-01-15T12:47:47  *** rex4539 has quit IRC
265 2020-01-15T12:58:20  *** Chris_Stewart_5 has joined #bitcoin-core-dev
266 2020-01-15T13:04:55  *** bitcoin-git has joined #bitcoin-core-dev
267 2020-01-15T13:04:55  <bitcoin-git> [bitcoin] elichai opened pull request #17931: test: Fix p2p_invalid_messages failing in Python 3.8 because of warning (master...2020-01-coroutine) https://github.com/bitcoin/bitcoin/pull/17931
268 2020-01-15T13:04:56  *** bitcoin-git has left #bitcoin-core-dev
269 2020-01-15T13:10:08  *** TheRec has quit IRC
270 2020-01-15T13:11:34  *** TheRec has joined #bitcoin-core-dev
271 2020-01-15T13:11:34  *** TheRec has joined #bitcoin-core-dev
272 2020-01-15T13:13:50  *** diogosergio has joined #bitcoin-core-dev
273 2020-01-15T13:13:58  *** filchef has joined #bitcoin-core-dev
274 2020-01-15T13:16:02  <jamesob> promag: it certainly could, though because I don't think there'd be a huge performance impact I was going to wait until after the assumeutxo functionality all gets merged to start worrying about splitting the locks up - which I do think is probably worth doing
275 2020-01-15T13:16:18  *** rex4539 has joined #bitcoin-core-dev
276 2020-01-15T13:17:41  <real_or_random> another "malicious dependency" story: https://nakedsecurity.sophos.com/2020/01/15/malicious-npm-package-taken-down-after-microsoft-warning/
277 2020-01-15T13:19:00  *** diogosergio has quit IRC
278 2020-01-15T13:19:05  *** diogoser1io has joined #bitcoin-core-dev
279 2020-01-15T13:24:43  *** diogosergio has joined #bitcoin-core-dev
280 2020-01-15T13:27:37  *** diogoser1io has quit IRC
281 2020-01-15T13:33:40  *** michagogo has quit IRC
282 2020-01-15T13:34:09  *** michagogo has joined #bitcoin-core-dev
283 2020-01-15T13:36:58  <jonatack> PR #16115 has 4 acks, might be RFM
284 2020-01-15T13:37:05  <gribble> https://github.com/bitcoin/bitcoin/issues/16115 | On bitcoind startup, write config args to debug.log by LarryRuane · Pull Request #16115 · bitcoin/bitcoin · GitHub
285 2020-01-15T13:48:13  *** filchef has quit IRC
286 2020-01-15T13:48:37  *** filchef has joined #bitcoin-core-dev
287 2020-01-15T13:56:36  *** AaronvanW has joined #bitcoin-core-dev
288 2020-01-15T14:00:03  *** vasild has quit IRC
289 2020-01-15T14:01:25  *** vasild has joined #bitcoin-core-dev
290 2020-01-15T14:05:38  *** diogosergio has quit IRC
291 2020-01-15T14:06:32  *** volbil has quit IRC
292 2020-01-15T14:15:32  *** TheRec has quit IRC
293 2020-01-15T14:16:27  *** Chris_Stewart_5 has quit IRC
294 2020-01-15T14:25:10  *** Highway61 has joined #bitcoin-core-dev
295 2020-01-15T14:29:43  *** AaronvanW has quit IRC
296 2020-01-15T14:30:53  *** andrewtoth_ has joined #bitcoin-core-dev
297 2020-01-15T14:34:33  *** jarthur has joined #bitcoin-core-dev
298 2020-01-15T14:36:10  *** andrewtoth has joined #bitcoin-core-dev
299 2020-01-15T14:39:12  *** jarthur has quit IRC
300 2020-01-15T14:51:36  *** promag has joined #bitcoin-core-dev
301 2020-01-15T14:55:22  *** promag_ has joined #bitcoin-core-dev
302 2020-01-15T14:56:16  *** promag has quit IRC
303 2020-01-15T14:56:29  *** promag has joined #bitcoin-core-dev
304 2020-01-15T14:56:54  *** emilengler has joined #bitcoin-core-dev
305 2020-01-15T14:59:53  *** promag_ has quit IRC
306 2020-01-15T15:00:01  *** laxanofido has quit IRC
307 2020-01-15T15:14:44  *** promag has quit IRC
308 2020-01-15T15:15:17  *** promag has joined #bitcoin-core-dev
309 2020-01-15T15:17:19  *** kermit2 has joined #bitcoin-core-dev
310 2020-01-15T15:20:17  *** promag has quit IRC
311 2020-01-15T15:27:18  *** Chris_Stewart_5 has joined #bitcoin-core-dev
312 2020-01-15T15:34:22  *** rex4539 has quit IRC
313 2020-01-15T15:34:39  *** rex4539 has joined #bitcoin-core-dev
314 2020-01-15T15:35:12  *** Highway61 has quit IRC
315 2020-01-15T15:44:50  *** andrewtoth_ has joined #bitcoin-core-dev
316 2020-01-15T15:46:03  *** andrewtoth has quit IRC
317 2020-01-15T15:52:39  *** mdunnio has joined #bitcoin-core-dev
318 2020-01-15T15:55:03  *** andrewtoth_ has quit IRC
319 2020-01-15T16:02:53  *** Chris_Stewart_5 has quit IRC
320 2020-01-15T16:13:55  *** Chris_Stewart_5 has joined #bitcoin-core-dev
321 2020-01-15T16:26:31  *** AaronvanW has joined #bitcoin-core-dev
322 2020-01-15T16:32:05  *** ExEric3 has quit IRC
323 2020-01-15T16:32:20  *** bitcoin-git has joined #bitcoin-core-dev
324 2020-01-15T16:32:20  <bitcoin-git> [bitcoin] btc-coder opened pull request #17932: replace deprecated method of recursive_directory_iterator with the st… (master...master) https://github.com/bitcoin/bitcoin/pull/17932
325 2020-01-15T16:32:21  *** bitcoin-git has left #bitcoin-core-dev
326 2020-01-15T16:33:25  *** TheRec has joined #bitcoin-core-dev
327 2020-01-15T16:33:25  *** TheRec has joined #bitcoin-core-dev
328 2020-01-15T16:35:26  *** jarthur has joined #bitcoin-core-dev
329 2020-01-15T16:37:20  *** owowo has quit IRC
330 2020-01-15T16:39:57  *** jarthur has quit IRC
331 2020-01-15T16:42:52  *** owowo has joined #bitcoin-core-dev
332 2020-01-15T16:45:51  *** ffasdfsadfsaf has joined #bitcoin-core-dev
333 2020-01-15T16:48:37  *** goatpig has quit IRC
334 2020-01-15T16:55:21  *** ffasdfsadfsaf has quit IRC
335 2020-01-15T16:58:53  *** AaronvanW has quit IRC
336 2020-01-15T17:02:53  *** jarthur has joined #bitcoin-core-dev
337 2020-01-15T17:08:37  *** ccook has quit IRC
338 2020-01-15T17:08:52  *** ccook has joined #bitcoin-core-dev
339 2020-01-15T17:18:36  *** ExEric3 has joined #bitcoin-core-dev
340 2020-01-15T17:20:13  *** Liliaceae has quit IRC
341 2020-01-15T17:20:29  *** Liliaceae has joined #bitcoin-core-dev
342 2020-01-15T17:20:50  *** bitcoin-git has joined #bitcoin-core-dev
343 2020-01-15T17:20:50  <bitcoin-git> [bitcoin] dongcarl opened pull request #17933: guix: Pin Guix using `guix time-machine` (master...2020-01-guix-time-machine) https://github.com/bitcoin/bitcoin/pull/17933
344 2020-01-15T17:20:51  *** bitcoin-git has left #bitcoin-core-dev
345 2020-01-15T17:23:44  *** kexkey has joined #bitcoin-core-dev
346 2020-01-15T17:28:09  *** schmidty has quit IRC
347 2020-01-15T17:28:24  *** schmidty has joined #bitcoin-core-dev
348 2020-01-15T17:29:49  *** Guest83_ has quit IRC
349 2020-01-15T17:32:47  *** Chris_Stewart_5 has quit IRC
350 2020-01-15T17:33:34  *** pierre_rochard has quit IRC
351 2020-01-15T17:33:49  *** pierre_rochard has joined #bitcoin-core-dev
352 2020-01-15T17:38:04  *** Isthmus has quit IRC
353 2020-01-15T17:38:31  *** Isthmus has joined #bitcoin-core-dev
354 2020-01-15T17:40:28  *** hugohn has quit IRC
355 2020-01-15T17:40:43  *** hugohn has joined #bitcoin-core-dev
356 2020-01-15T17:46:35  *** gleb has quit IRC
357 2020-01-15T17:46:49  *** gleb has joined #bitcoin-core-dev
358 2020-01-15T17:47:22  *** Talkless has joined #bitcoin-core-dev
359 2020-01-15T17:47:37  *** Talkless has quit IRC
360 2020-01-15T17:48:13  *** Talkless has joined #bitcoin-core-dev
361 2020-01-15T17:49:01  *** Talkless has joined #bitcoin-core-dev
362 2020-01-15T17:50:03  *** Talkless has joined #bitcoin-core-dev
363 2020-01-15T17:54:00  *** jarthur has quit IRC
364 2020-01-15T17:57:27  *** jarthur has joined #bitcoin-core-dev
365 2020-01-15T17:58:19  *** andrewtoth_ has joined #bitcoin-core-dev
366 2020-01-15T18:00:01  *** kermit2 has quit IRC
367 2020-01-15T18:10:44  *** jarthur has quit IRC
368 2020-01-15T18:17:27  *** ironmarx has joined #bitcoin-core-dev
369 2020-01-15T18:29:24  <hebasto> promag: fanquake: ty
370 2020-01-15T18:29:45  *** jarthur has joined #bitcoin-core-dev
371 2020-01-15T18:29:49  *** fjahr has quit IRC
372 2020-01-15T18:30:02  *** endogenic has quit IRC
373 2020-01-15T18:30:03  *** eragmus has quit IRC
374 2020-01-15T18:30:06  *** NicolasDorier has quit IRC
375 2020-01-15T18:30:06  *** mariorz has quit IRC
376 2020-01-15T18:30:06  *** CodeShark__ has quit IRC
377 2020-01-15T18:30:18  *** Isthmus has quit IRC
378 2020-01-15T18:30:18  *** Liliaceae has quit IRC
379 2020-01-15T18:30:24  *** valwal has quit IRC
380 2020-01-15T18:30:27  *** nejon has quit IRC
381 2020-01-15T18:30:28  *** ajonas has quit IRC
382 2020-01-15T18:30:29  *** amiti has quit IRC
383 2020-01-15T18:30:29  *** hsmiths has quit IRC
384 2020-01-15T18:30:29  *** Lexyon___ has quit IRC
385 2020-01-15T18:30:29  *** wallet42 has quit IRC
386 2020-01-15T18:30:39  *** bosma has quit IRC
387 2020-01-15T18:30:46  *** neatnik has quit IRC
388 2020-01-15T18:30:49  *** amiti has joined #bitcoin-core-dev
389 2020-01-15T18:31:21  *** elichai2 has quit IRC
390 2020-01-15T18:31:30  *** gertjaap has quit IRC
391 2020-01-15T18:31:34  *** neatnik has joined #bitcoin-core-dev
392 2020-01-15T18:31:42  *** drbrule has quit IRC
393 2020-01-15T18:31:52  *** moneyball has quit IRC
394 2020-01-15T18:31:52  *** rodarmor has quit IRC
395 2020-01-15T18:32:33  *** Liliaceae has joined #bitcoin-core-dev
396 2020-01-15T18:33:14  *** Karyon has quit IRC
397 2020-01-15T18:33:15  *** chainhead has quit IRC
398 2020-01-15T18:33:20  *** aerth has quit IRC
399 2020-01-15T18:33:27  *** drbrule has joined #bitcoin-core-dev
400 2020-01-15T18:33:30  *** fjahr has joined #bitcoin-core-dev
401 2020-01-15T18:33:30  *** wallet42 has joined #bitcoin-core-dev
402 2020-01-15T18:33:37  *** hsmiths has joined #bitcoin-core-dev
403 2020-01-15T18:33:43  *** nejon has joined #bitcoin-core-dev
404 2020-01-15T18:33:48  *** valwal has joined #bitcoin-core-dev
405 2020-01-15T18:33:49  *** digi_james has quit IRC
406 2020-01-15T18:33:49  *** vfP56jSe has quit IRC
407 2020-01-15T18:33:52  *** Isthmus has joined #bitcoin-core-dev
408 2020-01-15T18:34:06  *** vfP56jSe has joined #bitcoin-core-dev
409 2020-01-15T18:34:10  *** endogenic has joined #bitcoin-core-dev
410 2020-01-15T18:34:10  *** emilengler has quit IRC
411 2020-01-15T18:34:16  *** Karyon has joined #bitcoin-core-dev
412 2020-01-15T18:34:19  *** aerth has joined #bitcoin-core-dev
413 2020-01-15T18:34:22  *** elichai2 has joined #bitcoin-core-dev
414 2020-01-15T18:34:46  *** mariorz has joined #bitcoin-core-dev
415 2020-01-15T18:34:56  *** digi_james has joined #bitcoin-core-dev
416 2020-01-15T18:35:10  *** gertjaap has joined #bitcoin-core-dev
417 2020-01-15T18:35:26  *** rodarmor has joined #bitcoin-core-dev
418 2020-01-15T18:35:27  *** moneyball has joined #bitcoin-core-dev
419 2020-01-15T18:35:49  *** chainhead has joined #bitcoin-core-dev
420 2020-01-15T18:37:10  *** Lexyon___ has joined #bitcoin-core-dev
421 2020-01-15T18:38:27  *** CodeShark__ has joined #bitcoin-core-dev
422 2020-01-15T18:40:42  *** aerth has quit IRC
423 2020-01-15T18:40:54  *** endogenic has quit IRC
424 2020-01-15T18:40:56  *** vfP56jSe has quit IRC
425 2020-01-15T18:42:27  *** Zenton has quit IRC
426 2020-01-15T18:42:45  *** promag has joined #bitcoin-core-dev
427 2020-01-15T18:42:57  *** aerth has joined #bitcoin-core-dev
428 2020-01-15T18:43:17  *** Guest83_ has joined #bitcoin-core-dev
429 2020-01-15T18:43:23  *** mryandao has quit IRC
430 2020-01-15T18:43:43  *** fjahr has quit IRC
431 2020-01-15T18:44:02  *** jarthur has quit IRC
432 2020-01-15T18:45:49  *** mryandao has joined #bitcoin-core-dev
433 2020-01-15T18:47:27  *** NicolasDorier has joined #bitcoin-core-dev
434 2020-01-15T18:48:34  *** aerth has quit IRC
435 2020-01-15T18:50:08  *** vfP56jSe has joined #bitcoin-core-dev
436 2020-01-15T18:55:05  *** vfP56jSe has quit IRC
437 2020-01-15T18:56:21  *** aerth has joined #bitcoin-core-dev
438 2020-01-15T18:56:26  *** AaronvanW has joined #bitcoin-core-dev
439 2020-01-15T18:57:02  *** Skirmant has quit IRC
440 2020-01-15T18:58:33  *** vfP56jSe has joined #bitcoin-core-dev
441 2020-01-15T19:01:24  *** promag has quit IRC
442 2020-01-15T19:04:43  *** jcoe has quit IRC
443 2020-01-15T19:09:36  *** jarthur has joined #bitcoin-core-dev
444 2020-01-15T19:12:48  *** promag has joined #bitcoin-core-dev
445 2020-01-15T19:16:50  *** Guest83_ has quit IRC
446 2020-01-15T19:19:25  *** Guest83_ has joined #bitcoin-core-dev
447 2020-01-15T19:19:38  *** promag has quit IRC
448 2020-01-15T19:21:26  *** Chris_Stewart_5 has joined #bitcoin-core-dev
449 2020-01-15T19:24:03  *** spinza has quit IRC
450 2020-01-15T19:28:25  *** ajonas has joined #bitcoin-core-dev
451 2020-01-15T19:29:57  *** AaronvanW has quit IRC
452 2020-01-15T19:41:08  *** Guest83_ has quit IRC
453 2020-01-15T19:52:51  *** justanotheruser has quit IRC
454 2020-01-15T19:53:35  *** Guyver2 has joined #bitcoin-core-dev
455 2020-01-15T19:58:21  *** AaronvanW has joined #bitcoin-core-dev
456 2020-01-15T20:02:54  *** AaronvanW has quit IRC
457 2020-01-15T20:07:33  *** justanotheruser has joined #bitcoin-core-dev
458 2020-01-15T20:16:03  *** justanotheruser has quit IRC
459 2020-01-15T20:16:22  *** Talkless has quit IRC
460 2020-01-15T20:17:54  *** bitcoinfuture has joined #bitcoin-core-dev
461 2020-01-15T20:17:56  *** bitcoin-git has joined #bitcoin-core-dev
462 2020-01-15T20:17:56  <bitcoin-git> [bitcoin] hebasto opened pull request #17934: doc: Use CONFIG_SITE variable instead of --prefix option (master...20200115-prefix-depends) https://github.com/bitcoin/bitcoin/pull/17934
463 2020-01-15T20:17:57  *** bitcoin-git has left #bitcoin-core-dev
464 2020-01-15T20:18:37  *** jonatack has quit IRC
465 2020-01-15T20:19:08  *** AaronvanW has joined #bitcoin-core-dev
466 2020-01-15T20:21:47  *** rex4539 has quit IRC
467 2020-01-15T20:22:05  *** jonatack has joined #bitcoin-core-dev
468 2020-01-15T20:26:54  *** bitcoin-git has joined #bitcoin-core-dev
469 2020-01-15T20:26:54  <bitcoin-git> [bitcoin] brakmic opened pull request #17935: gui: hide HD icon when no wallet loaded (master...hdwallet-icon-handling) https://github.com/bitcoin/bitcoin/pull/17935
470 2020-01-15T20:26:56  *** bitcoin-git has left #bitcoin-core-dev
471 2020-01-15T20:27:03  *** rex4539 has joined #bitcoin-core-dev
472 2020-01-15T20:29:14  *** justanotheruser has joined #bitcoin-core-dev
473 2020-01-15T20:34:28  *** EagleTM has joined #bitcoin-core-dev
474 2020-01-15T20:42:46  *** Jackielove4u has quit IRC
475 2020-01-15T20:43:19  *** promag has joined #bitcoin-core-dev
476 2020-01-15T20:50:06  *** spinza has joined #bitcoin-core-dev
477 2020-01-15T20:51:56  *** rex4539 has quit IRC
478 2020-01-15T21:00:01  *** ironmarx has quit IRC
479 2020-01-15T21:00:24  *** timothy has quit IRC
480 2020-01-15T21:28:02  *** SirRichard has joined #bitcoin-core-dev
481 2020-01-15T21:32:44  *** bitcoinfuture has quit IRC
482 2020-01-15T21:34:10  *** SirRichard has quit IRC
483 2020-01-15T21:37:49  *** hsmiths has quit IRC
484 2020-01-15T21:37:50  *** vasild_ has joined #bitcoin-core-dev
485 2020-01-15T21:38:18  *** aqquadro has quit IRC
486 2020-01-15T21:41:03  *** vasild has quit IRC
487 2020-01-15T21:44:01  *** michagogo has quit IRC
488 2020-01-15T21:45:22  *** bitcoin-git has joined #bitcoin-core-dev
489 2020-01-15T21:45:22  <bitcoin-git> [bitcoin] fanquake closed pull request #17932: replace deprecated method of recursive_directory_iterator with the st… (master...master) https://github.com/bitcoin/bitcoin/pull/17932
490 2020-01-15T21:45:23  *** bitcoin-git has left #bitcoin-core-dev
491 2020-01-15T21:48:38  *** manantial has quit IRC
492 2020-01-15T22:00:35  <luke-jr> fwiw, I found a new getbalance bug on v0.19.0.1; debugging now
493 2020-01-15T22:05:02  *** felixfoertsch has quit IRC
494 2020-01-15T22:06:24  *** andrewtoth_ has quit IRC
495 2020-01-15T22:09:49  *** Chris_Stewart_5 has quit IRC
496 2020-01-15T22:15:36  *** filchef has quit IRC
497 2020-01-15T22:18:52  *** felixfoertsch has joined #bitcoin-core-dev
498 2020-01-15T22:25:40  *** dviola has joined #bitcoin-core-dev
499 2020-01-15T22:48:31  *** jarthur has quit IRC
500 2020-01-15T22:50:56  *** Guyver2 has quit IRC
501 2020-01-15T23:06:53  *** bitcoin-git has joined #bitcoin-core-dev
502 2020-01-15T23:06:53  <bitcoin-git> [bitcoin] promag opened pull request #17937: gui: Remove WalletView and BitcoinGUI circular dependency (master...2020-01-remove-walletview-bitcoingui) https://github.com/bitcoin/bitcoin/pull/17937
503 2020-01-15T23:06:54  *** bitcoin-git has left #bitcoin-core-dev
504 2020-01-15T23:13:14  *** elsimio has joined #bitcoin-core-dev
505 2020-01-15T23:17:05  *** Chris_Stewart_5 has joined #bitcoin-core-dev
506 2020-01-15T23:24:55  *** Chris_Stewart_5 has quit IRC
507 2020-01-15T23:39:58  *** Highway61 has joined #bitcoin-core-dev
508 2020-01-15T23:44:23  *** SiAnDoG_ has quit IRC