12020-01-16T00:00:02  *** elsimio has quit IRC
  22020-01-16T00:01:21  *** mdunnio has quit IRC
  32020-01-16T00:02:10  *** Highway61 has quit IRC
  42020-01-16T00:07:58  *** Skirmant has joined #bitcoin-core-dev
  52020-01-16T00:12:19  *** promag has quit IRC
  62020-01-16T00:12:57  *** Highway61 has joined #bitcoin-core-dev
  72020-01-16T00:17:06  *** kodein1 has joined #bitcoin-core-dev
  82020-01-16T00:18:23  *** amiti has quit IRC
  92020-01-16T00:18:27  *** neatnik has quit IRC
 102020-01-16T00:18:30  *** valwal has quit IRC
 112020-01-16T00:18:35  *** mariorz has quit IRC
 122020-01-16T00:18:36  *** CodeShark__ has quit IRC
 132020-01-16T00:18:38  *** vfP56jSe has quit IRC
 142020-01-16T00:18:48  *** aerth has quit IRC
 152020-01-16T00:18:48  *** wbnns has quit IRC
 162020-01-16T00:18:50  *** kristapsk has quit IRC
 172020-01-16T00:19:31  *** mariorz has joined #bitcoin-core-dev
 182020-01-16T00:19:35  *** wbnns has joined #bitcoin-core-dev
 192020-01-16T00:19:54  *** amiti has joined #bitcoin-core-dev
 202020-01-16T00:19:55  *** neatnik has joined #bitcoin-core-dev
 212020-01-16T00:19:56  *** vfP56jSe has joined #bitcoin-core-dev
 222020-01-16T00:20:04  *** aerth has joined #bitcoin-core-dev
 232020-01-16T00:20:05  *** CodeShark__ has joined #bitcoin-core-dev
 242020-01-16T00:21:03  *** alec has quit IRC
 252020-01-16T00:21:13  *** endogenic has joined #bitcoin-core-dev
 262020-01-16T00:21:58  *** eragmus has joined #bitcoin-core-dev
 272020-01-16T00:22:00  *** valwal has joined #bitcoin-core-dev
 282020-01-16T00:24:26  *** alec has joined #bitcoin-core-dev
 292020-01-16T00:26:54  *** Zenton has joined #bitcoin-core-dev
 302020-01-16T00:33:41  *** promag has joined #bitcoin-core-dev
 312020-01-16T00:38:10  *** promag has quit IRC
 322020-01-16T00:40:32  *** promag has joined #bitcoin-core-dev
 332020-01-16T00:42:23  *** vfP56jSe has quit IRC
 342020-01-16T00:42:27  *** eragmus has quit IRC
 352020-01-16T00:42:34  *** peltre has quit IRC
 362020-01-16T00:42:41  *** amiti has quit IRC
 372020-01-16T00:42:48  *** aerth has quit IRC
 382020-01-16T00:42:52  *** CodeShark__ has quit IRC
 392020-01-16T00:42:57  *** endogenic has quit IRC
 402020-01-16T00:42:57  *** elichai2 has quit IRC
 412020-01-16T00:43:12  *** jamesob has quit IRC
 422020-01-16T00:43:32  *** ajonas has quit IRC
 432020-01-16T00:43:32  *** pierre_rochard has quit IRC
 442020-01-16T00:43:38  *** petezz4 has quit IRC
 452020-01-16T00:43:38  *** arik__ has quit IRC
 462020-01-16T00:43:55  *** mariorz has quit IRC
 472020-01-16T00:44:05  *** digi_james has quit IRC
 482020-01-16T00:44:05  *** fanquake has quit IRC
 492020-01-16T00:44:07  *** moneyball has quit IRC
 502020-01-16T00:44:07  *** hugohn has quit IRC
 512020-01-16T00:44:07  *** schmidty has quit IRC
 522020-01-16T00:45:09  *** promag has quit IRC
 532020-01-16T00:45:52  *** neatnik has quit IRC
 542020-01-16T00:45:59  *** Lexyon___ has quit IRC
 552020-01-16T00:45:59  *** rodarmor has quit IRC
 562020-01-16T00:45:59  *** gertjaap has quit IRC
 572020-01-16T00:45:59  *** Liliaceae has quit IRC
 582020-01-16T00:46:08  *** Isthmus has quit IRC
 592020-01-16T00:46:08  *** gleb has quit IRC
 602020-01-16T00:46:37  *** NicolasDorier has quit IRC
 612020-01-16T00:46:37  *** drbrule has quit IRC
 622020-01-16T00:47:02  *** valwal has quit IRC
 632020-01-16T00:47:15  *** nejon has quit IRC
 642020-01-16T00:47:23  *** ccook has quit IRC
 652020-01-16T00:49:47  *** wbnns has quit IRC
 662020-01-16T00:50:08  *** promag has joined #bitcoin-core-dev
 672020-01-16T00:52:53  *** AaronvanW has quit IRC
 682020-01-16T00:53:21  *** RubenSomsen has quit IRC
 692020-01-16T00:53:38  *** wallet42 has quit IRC
 702020-01-16T00:54:08  *** bitcoin-git has joined #bitcoin-core-dev
 712020-01-16T00:54:09  <bitcoin-git> [bitcoin] Empact opened pull request #17938: Disallow automatic conversion between disparate hash types (master...hash-conversion) https://github.com/bitcoin/bitcoin/pull/17938
 722020-01-16T00:54:09  *** bitcoin-git has left #bitcoin-core-dev
 732020-01-16T00:55:46  *** nirved has quit IRC
 742020-01-16T00:56:27  *** felixweis has quit IRC
 752020-01-16T00:56:40  *** nirved has joined #bitcoin-core-dev
 762020-01-16T00:57:09  *** arik__ has joined #bitcoin-core-dev
 772020-01-16T00:57:46  *** petezz4 has joined #bitcoin-core-dev
 782020-01-16T00:59:04  *** Isthmus has joined #bitcoin-core-dev
 792020-01-16T00:59:14  *** promag has quit IRC
 802020-01-16T01:03:38  *** petezz4 has quit IRC
 812020-01-16T01:09:26  *** RubenSomsen has joined #bitcoin-core-dev
 822020-01-16T01:09:37  *** RubenSomsen has quit IRC
 832020-01-16T01:10:47  *** Liliaceae has joined #bitcoin-core-dev
 842020-01-16T01:16:53  *** arik__ has quit IRC
 852020-01-16T01:18:01  *** pierre_rochard has joined #bitcoin-core-dev
 862020-01-16T01:18:17  *** Liliaceae has quit IRC
 872020-01-16T01:24:22  *** elichai2 has joined #bitcoin-core-dev
 882020-01-16T01:26:37  *** elichai2 has quit IRC
 892020-01-16T01:30:12  *** pierre_rochard has quit IRC
 902020-01-16T01:31:25  *** AaronvanW has joined #bitcoin-core-dev
 912020-01-16T01:34:26  *** luke-jr has quit IRC
 922020-01-16T01:36:37  *** AaronvanW has quit IRC
 932020-01-16T01:36:56  *** Liliaceae has joined #bitcoin-core-dev
 942020-01-16T01:39:28  *** dviola has quit IRC
 952020-01-16T01:39:55  *** luke-jr has joined #bitcoin-core-dev
 962020-01-16T01:40:54  *** felixweis has joined #bitcoin-core-dev
 972020-01-16T01:41:53  *** Liliaceae has quit IRC
 982020-01-16T01:46:32  *** felixweis has quit IRC
 992020-01-16T01:50:16  *** BlueMatt has quit IRC
1002020-01-16T01:51:50  *** felixweis has joined #bitcoin-core-dev
1012020-01-16T01:55:48  *** BlueMatt has joined #bitcoin-core-dev
1022020-01-16T01:57:33  *** felixweis has quit IRC
1032020-01-16T02:04:59  *** AaronvanW has joined #bitcoin-core-dev
1042020-01-16T02:09:31  *** belcher has quit IRC
1052020-01-16T02:33:04  *** felixfoertsch has quit IRC
1062020-01-16T02:35:42  *** Skirmant has quit IRC
1072020-01-16T02:38:37  *** AaronvanW has quit IRC
1082020-01-16T02:39:41  *** felixfoertsch has joined #bitcoin-core-dev
1092020-01-16T02:49:38  *** Highway61 has quit IRC
1102020-01-16T02:50:41  *** marcoagner has quit IRC
1112020-01-16T02:55:43  *** wullon has quit IRC
1122020-01-16T02:56:08  *** wullon has joined #bitcoin-core-dev
1132020-01-16T03:00:01  *** kodein1 has quit IRC
1142020-01-16T03:00:58  *** abrissbi1ne has joined #bitcoin-core-dev
1152020-01-16T03:04:17  *** felixfoertsch23 has joined #bitcoin-core-dev
1162020-01-16T03:04:30  *** abrissbirne has quit IRC
1172020-01-16T03:05:19  *** felixfoertsch has quit IRC
1182020-01-16T03:08:06  *** BlueMatt has quit IRC
1192020-01-16T03:09:43  *** BlueMatt has joined #bitcoin-core-dev
1202020-01-16T03:17:05  *** funkyb has joined #bitcoin-core-dev
1212020-01-16T04:03:35  *** justan0theruser has joined #bitcoin-core-dev
1222020-01-16T04:05:56  *** justanotheruser has quit IRC
1232020-01-16T04:10:26  *** volbil has joined #bitcoin-core-dev
1242020-01-16T04:18:36  *** eragmus has joined #bitcoin-core-dev
1252020-01-16T04:25:54  *** Isthmus has joined #bitcoin-core-dev
1262020-01-16T04:27:01  *** eragmus has quit IRC
1272020-01-16T04:28:05  *** Isthmus has quit IRC
1282020-01-16T04:30:26  *** Eagle[TM] has joined #bitcoin-core-dev
1292020-01-16T04:31:27  <luke-jr> update: false alarm, it's a bug in the test (part of #11413)
1302020-01-16T04:31:31  <gribble> https://github.com/bitcoin/bitcoin/issues/11413 | [wallet] [rpc] sendtoaddress/sendmany: Add explicit feerate option by kallewoof · Pull Request #11413 · bitcoin/bitcoin · GitHub
1312020-01-16T04:32:46  *** EagleTM has quit IRC
1322020-01-16T04:35:26  <sipa> luke-jr: best kind of bug
1332020-01-16T04:35:42  *** AaronvanW has joined #bitcoin-core-dev
1342020-01-16T04:36:34  <luke-jr> sipa: not when it's intermittant :p
1352020-01-16T04:40:33  *** Isthmus has joined #bitcoin-core-dev
1362020-01-16T04:56:27  <sipa> u
1372020-01-16T04:59:47  <sipa> luke-jr: if i had to have an intermittent bug, my preference would still be to have it in the tests :)
1382020-01-16T05:08:38  *** AaronvanW has quit IRC
1392020-01-16T05:17:22  <luke-jr> ☺
1402020-01-16T05:31:47  *** Victor_sueca has joined #bitcoin-core-dev
1412020-01-16T05:32:42  *** moneyball has joined #bitcoin-core-dev
1422020-01-16T05:34:29  *** Victorsueca has quit IRC
1432020-01-16T05:39:03  *** moneyball has quit IRC
1442020-01-16T06:00:01  *** funkyb has quit IRC
1452020-01-16T06:04:16  *** ossifrage has quit IRC
1462020-01-16T06:17:36  *** vkmc has joined #bitcoin-core-dev
1472020-01-16T06:18:41  *** gleb has joined #bitcoin-core-dev
1482020-01-16T06:25:07  *** ossifrage has joined #bitcoin-core-dev
1492020-01-16T06:34:23  *** achow101 has quit IRC
1502020-01-16T06:42:52  *** gleb has quit IRC
1512020-01-16T06:43:25  *** achow101 has joined #bitcoin-core-dev
1522020-01-16T06:44:03  *** gleb has joined #bitcoin-core-dev
1532020-01-16T06:48:58  *** CodeShark__ has joined #bitcoin-core-dev
1542020-01-16T06:49:28  *** moneyball has joined #bitcoin-core-dev
1552020-01-16T06:49:47  *** neatnik has joined #bitcoin-core-dev
1562020-01-16T06:51:54  *** schmidty has joined #bitcoin-core-dev
1572020-01-16T06:53:10  *** RubenSomsen has joined #bitcoin-core-dev
1582020-01-16T06:53:16  *** ccook has joined #bitcoin-core-dev
1592020-01-16T06:53:17  *** petezz4 has joined #bitcoin-core-dev
1602020-01-16T06:53:23  *** digi_james has joined #bitcoin-core-dev
1612020-01-16T06:53:23  *** NicolasDorier has joined #bitcoin-core-dev
1622020-01-16T06:53:44  *** elichai2 has joined #bitcoin-core-dev
1632020-01-16T06:56:03  *** wallet42 has joined #bitcoin-core-dev
1642020-01-16T06:56:09  *** peltre has joined #bitcoin-core-dev
1652020-01-16T06:56:56  *** fanquake has joined #bitcoin-core-dev
1662020-01-16T06:56:57  *** wbnns has joined #bitcoin-core-dev
1672020-01-16T06:57:25  *** jamesob has joined #bitcoin-core-dev
1682020-01-16T06:59:08  *** eragmus has joined #bitcoin-core-dev
1692020-01-16T07:00:10  *** Lexyon___ has joined #bitcoin-core-dev
1702020-01-16T07:00:16  *** gertjaap has joined #bitcoin-core-dev
1712020-01-16T07:00:23  *** ajonas has joined #bitcoin-core-dev
1722020-01-16T07:00:55  *** felixweis has joined #bitcoin-core-dev
1732020-01-16T07:00:59  *** pierre_rochard has joined #bitcoin-core-dev
1742020-01-16T07:01:37  *** rodarmor has joined #bitcoin-core-dev
1752020-01-16T07:01:43  *** drbrule has joined #bitcoin-core-dev
1762020-01-16T07:05:12  *** Liliaceae has joined #bitcoin-core-dev
1772020-01-16T07:05:12  *** AaronvanW has joined #bitcoin-core-dev
1782020-01-16T07:05:59  *** turbo_choo has quit IRC
1792020-01-16T07:06:34  *** manantial has joined #bitcoin-core-dev
1802020-01-16T07:06:41  *** mariorz has joined #bitcoin-core-dev
1812020-01-16T07:10:46  *** Isthmus has joined #bitcoin-core-dev
1822020-01-16T07:11:26  *** fjahr has joined #bitcoin-core-dev
1832020-01-16T07:12:54  *** valwal has joined #bitcoin-core-dev
1842020-01-16T07:17:16  *** Squidicuz has quit IRC
1852020-01-16T07:17:23  *** hugohn has joined #bitcoin-core-dev
1862020-01-16T07:19:48  *** Bullit has quit IRC
1872020-01-16T07:20:37  *** Bullit has joined #bitcoin-core-dev
1882020-01-16T07:22:04  *** arik__ has joined #bitcoin-core-dev
1892020-01-16T07:27:24  *** Eagle[TM] has quit IRC
1902020-01-16T07:38:27  *** AaronvanW has quit IRC
1912020-01-16T07:38:49  *** Jackielove4u has joined #bitcoin-core-dev
1922020-01-16T07:47:42  *** endogenic has joined #bitcoin-core-dev
1932020-01-16T07:49:26  *** bosma has joined #bitcoin-core-dev
1942020-01-16T07:53:23  *** aerth has joined #bitcoin-core-dev
1952020-01-16T07:57:03  *** vfP56jSe has joined #bitcoin-core-dev
1962020-01-16T08:03:35  *** nejon has joined #bitcoin-core-dev
1972020-01-16T08:12:09  *** promag has joined #bitcoin-core-dev
1982020-01-16T08:13:08  *** amiti has joined #bitcoin-core-dev
1992020-01-16T08:14:17  *** cfields has quit IRC
2002020-01-16T08:15:56  *** cfields has joined #bitcoin-core-dev
2012020-01-16T08:16:13  *** promag has quit IRC
2022020-01-16T08:20:19  *** ghost43_ has joined #bitcoin-core-dev
2032020-01-16T08:20:23  *** ghost43 has quit IRC
2042020-01-16T08:22:37  *** goatpig has joined #bitcoin-core-dev
2052020-01-16T08:44:03  *** EagleTM has joined #bitcoin-core-dev
2062020-01-16T08:58:02  *** Victor_sueca has quit IRC
2072020-01-16T09:00:01  *** vkmc has quit IRC
2082020-01-16T09:15:43  *** volbil has quit IRC
2092020-01-16T09:16:16  *** AaronvanW has joined #bitcoin-core-dev
2102020-01-16T09:17:29  *** hali has joined #bitcoin-core-dev
2112020-01-16T09:28:05  *** EagleTM has quit IRC
2122020-01-16T09:28:25  *** turbo_choo has joined #bitcoin-core-dev
2132020-01-16T09:34:57  *** vasild_ is now known as vasild
2142020-01-16T09:41:03  *** vasild has quit IRC
2152020-01-16T09:46:12  *** EagleTM has joined #bitcoin-core-dev
2162020-01-16T09:46:43  *** promag has joined #bitcoin-core-dev
2172020-01-16T09:51:29  *** belcher has joined #bitcoin-core-dev
2182020-01-16T09:53:00  *** vasild has joined #bitcoin-core-dev
2192020-01-16T09:58:18  *** bitcoin-git has joined #bitcoin-core-dev
2202020-01-16T09:58:19  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ac61ec9da679...4e8b564df0d4
2212020-01-16T09:58:19  <bitcoin-git> bitcoin/master f117fb0 Elichai Turkel: Replace coroutine with async def in p2p_invalid_messages.py
2222020-01-16T09:58:19  <bitcoin-git> bitcoin/master 4e8b564 fanquake: Merge #17931: test: Fix p2p_invalid_messages failing in Python 3.8 because...
2232020-01-16T09:58:20  *** bitcoin-git has left #bitcoin-core-dev
2242020-01-16T09:58:39  *** marcoagner has joined #bitcoin-core-dev
2252020-01-16T09:58:39  *** bitcoin-git has joined #bitcoin-core-dev
2262020-01-16T09:58:39  <bitcoin-git> [bitcoin] fanquake merged pull request #17931: test: Fix p2p_invalid_messages failing in Python 3.8 because of warning (master...2020-01-coroutine) https://github.com/bitcoin/bitcoin/pull/17931
2272020-01-16T09:58:50  *** bitcoin-git has left #bitcoin-core-dev
2282020-01-16T10:02:03  *** turbo_choo has quit IRC
2292020-01-16T10:02:23  *** turbo_choo has joined #bitcoin-core-dev
2302020-01-16T10:03:48  *** Soligor has quit IRC
2312020-01-16T10:04:23  *** kexkey has quit IRC
2322020-01-16T10:08:30  *** Guyver2 has joined #bitcoin-core-dev
2332020-01-16T10:09:57  *** jonatack has quit IRC
2342020-01-16T10:10:54  *** Victorsueca has joined #bitcoin-core-dev
2352020-01-16T10:11:17  *** EagleTM has quit IRC
2362020-01-16T10:18:35  *** EagleTM has joined #bitcoin-core-dev
2372020-01-16T10:19:09  *** AaronvanW has quit IRC
2382020-01-16T10:20:34  *** jonatack has joined #bitcoin-core-dev
2392020-01-16T10:21:36  *** EagleTM has quit IRC
2402020-01-16T10:22:01  *** EagleTM has joined #bitcoin-core-dev
2412020-01-16T10:29:12  *** timothy has joined #bitcoin-core-dev
2422020-01-16T10:31:37  *** EagleTM has quit IRC
2432020-01-16T10:34:35  <meshcollider> promag: will do, I'll have time tomorrow
2442020-01-16T10:44:13  *** promag has quit IRC
2452020-01-16T10:45:09  *** promag has joined #bitcoin-core-dev
2462020-01-16T10:49:35  *** promag has quit IRC
2472020-01-16T10:54:53  *** jonatack has quit IRC
2482020-01-16T11:03:57  *** Gaylord25Block has joined #bitcoin-core-dev
2492020-01-16T11:16:37  *** Gaylord25Block has quit IRC
2502020-01-16T11:18:08  *** Guest83_ has joined #bitcoin-core-dev
2512020-01-16T11:32:03  *** Victorsueca has quit IRC
2522020-01-16T11:48:04  *** Guest83_ has quit IRC
2532020-01-16T11:52:53  *** turbo_choo has quit IRC
2542020-01-16T11:53:30  *** alec has quit IRC
2552020-01-16T11:56:27  *** setpill has joined #bitcoin-core-dev
2562020-01-16T11:56:50  *** marcoagner has quit IRC
2572020-01-16T11:58:50  *** Soligor has joined #bitcoin-core-dev
2582020-01-16T12:00:02  *** hali has quit IRC
2592020-01-16T12:01:45  *** filchef has joined #bitcoin-core-dev
2602020-01-16T12:08:16  *** filchef has quit IRC
2612020-01-16T12:08:44  *** filchef has joined #bitcoin-core-dev
2622020-01-16T12:10:45  *** AaronvanW has joined #bitcoin-core-dev
2632020-01-16T12:10:48  *** sipa has quit IRC
2642020-01-16T12:11:00  *** sipa has joined #bitcoin-core-dev
2652020-01-16T12:14:45  *** jonatack has joined #bitcoin-core-dev
2662020-01-16T12:15:38  *** AaronvanW has quit IRC
2672020-01-16T12:17:16  *** kees1 has joined #bitcoin-core-dev
2682020-01-16T12:24:07  *** AaronvanW has joined #bitcoin-core-dev
2692020-01-16T12:32:46  *** turbo_choo has joined #bitcoin-core-dev
2702020-01-16T12:41:22  *** Guyver2 has quit IRC
2712020-01-16T12:49:54  *** jcoe has joined #bitcoin-core-dev
2722020-01-16T12:54:41  *** filchef has quit IRC
2732020-01-16T12:56:20  *** Kiminuo has joined #bitcoin-core-dev
2742020-01-16T13:06:43  *** Skirmant has joined #bitcoin-core-dev
2752020-01-16T13:07:11  *** Highway61 has joined #bitcoin-core-dev
2762020-01-16T13:11:38  *** diogosergio has joined #bitcoin-core-dev
2772020-01-16T13:11:55  *** Highway62 has joined #bitcoin-core-dev
2782020-01-16T13:12:41  *** Highway61 has quit IRC
2792020-01-16T13:12:41  *** Highway62 is now known as Highway61
2802020-01-16T13:17:56  *** jonatack has quit IRC
2812020-01-16T13:21:32  *** dviola has joined #bitcoin-core-dev
2822020-01-16T13:27:49  <luke-jr> any objections to adding "don't rebase if you don't need to" to developer docs? :x
2832020-01-16T13:29:07  <sipa> i think that's good advice
2842020-01-16T13:29:31  *** hsmiths has joined #bitcoin-core-dev
2852020-01-16T13:30:12  *** bitcoin-git has joined #bitcoin-core-dev
2862020-01-16T13:30:12  <bitcoin-git> [bitcoin] Sjors opened pull request #17939: gui: Remove warning "unused variable 'wallet_model'" (master...2020/01/disable-wallet-unused-variable) https://github.com/bitcoin/bitcoin/pull/17939
2872020-01-16T13:30:24  *** bitcoin-git has left #bitcoin-core-dev
2882020-01-16T13:36:33  <wumpus> I don't think that's useful, in itself, the people doing rebases probably perceive it as needing to, what would be more useful is to list concretely when to rebase and when not
2892020-01-16T13:38:03  *** emilengler has joined #bitcoin-core-dev
2902020-01-16T13:38:15  <sipa> right; but i think it's easy to enumerate the cases when you need to: the PR no longer applies cleanly (=github complains) or (very rarely) a fresh merge succeeds but is incorrect
2912020-01-16T13:38:18  <luke-jr> wumpus: sure, I was just being brief on IRC :p
2922020-01-16T13:38:30  *** diogosergio has quit IRC
2932020-01-16T13:38:47  <luke-jr> making sure others agreed before I went to the trouble to write up something
2942020-01-16T13:38:57  <wumpus> ok, that makes sense
2952020-01-16T13:39:30  <sipa> for a while i would rebase the whole PR any time i made any changs to it... which isn't very compatible with all review workflows
2962020-01-16T13:40:05  <sipa> luke-jr: to be clear, by rebase you actually changing the base of the PR, not any invocation of the "git rebase" command
2972020-01-16T13:40:16  <luke-jr> sipa: yes
2982020-01-16T13:40:27  <sipa> in that case, agreed
2992020-01-16T13:41:00  <luke-jr> I'll be clear that fixups and such are fine
3002020-01-16T13:43:27  <wumpus> I usually rebase the PR for every change when the PR is new, to avoid 'messy' commits, but when there has been review, it's better to minimise rebases
3012020-01-16T13:44:21  <sipa> right
3022020-01-16T13:44:46  <wumpus> it really depends on the PR though, sometimes it is even requested by reviewers to split things into (atomic) commits
3032020-01-16T13:45:01  <luke-jr> would be nice if more people would do daggy fixes too :x
3042020-01-16T13:45:02  <wumpus> I think it's not very easy to enumerate in pracice
3052020-01-16T13:45:17  <sipa> daggy?
3062020-01-16T13:45:33  <luke-jr> sipa: bugfixes having a base of the commit introducing the bug, unless it makes problems
3072020-01-16T13:46:12  <sipa> luke-jr: ugh, not a fan of that :)
3082020-01-16T13:46:28  <luke-jr> no downsides, and it means it's a clean merge to all affected branches
3092020-01-16T13:47:08  <wumpus> I'm not sure about that, and that's also too much to ask from most people I think regarding git skills
3102020-01-16T13:47:16  <luke-jr> hmm
3112020-01-16T13:47:47  <luke-jr> still, even if not in docs, would be nice to see people do it more ;)
3122020-01-16T13:48:05  <sipa> luke-jr: i guess i haven't even noticed you doing that, which must mean i can't complain
3132020-01-16T13:48:52  <luke-jr> usually the only thing noticable is my PR comment like "this is a clean merge to x, y, z" or such
3142020-01-16T13:52:38  *** dr-orlovsky has quit IRC
3152020-01-16T13:53:26  *** Skirmant has quit IRC
3162020-01-16T13:56:39  *** bitcoin-git has joined #bitcoin-core-dev
3172020-01-16T13:56:39  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4e8b564df0d4...a9c789ed964d
3182020-01-16T13:56:40  <bitcoin-git> bitcoin/master 486f510 Harris: gui: hide HD & encryption icons when no wallet loaded
3192020-01-16T13:56:40  <bitcoin-git> bitcoin/master a9c789e fanquake: Merge #17935: gui: hide HD & encryption icons when no wallet loaded
3202020-01-16T13:56:42  *** bitcoin-git has left #bitcoin-core-dev
3212020-01-16T13:56:59  *** bitcoin-git has joined #bitcoin-core-dev
3222020-01-16T13:56:59  <bitcoin-git> [bitcoin] fanquake merged pull request #17935: gui: hide HD & encryption icons when no wallet loaded (master...hdwallet-icon-handling) https://github.com/bitcoin/bitcoin/pull/17935
3232020-01-16T13:57:00  *** bitcoin-git has left #bitcoin-core-dev
3242020-01-16T13:57:53  *** dr-orlovsky has joined #bitcoin-core-dev
3252020-01-16T13:59:48  *** Highway62 has joined #bitcoin-core-dev
3262020-01-16T14:00:29  *** Highway61 has quit IRC
3272020-01-16T14:00:29  *** Highway62 is now known as Highway61
3282020-01-16T14:19:36  *** Highway62 has joined #bitcoin-core-dev
3292020-01-16T14:21:33  *** bitcoin-git has joined #bitcoin-core-dev
3302020-01-16T14:21:33  <bitcoin-git> [bitcoin] luke-jr opened pull request #17940: doc: Rebasing, when and when not to do it (master...devnotes_rebasing) https://github.com/bitcoin/bitcoin/pull/17940
3312020-01-16T14:21:34  *** bitcoin-git has left #bitcoin-core-dev
3322020-01-16T14:21:39  *** Highway61 has quit IRC
3332020-01-16T14:21:39  *** Highway62 is now known as Highway61
3342020-01-16T14:22:58  *** Highway61 has quit IRC
3352020-01-16T14:23:21  *** Highway61 has joined #bitcoin-core-dev
3362020-01-16T14:25:37  *** spinza has quit IRC
3372020-01-16T14:32:43  *** turbo_choo has quit IRC
3382020-01-16T14:33:41  *** turbo_choo has joined #bitcoin-core-dev
3392020-01-16T14:33:47  *** spinza has joined #bitcoin-core-dev
3402020-01-16T14:51:14  *** bitcoin-git has joined #bitcoin-core-dev
3412020-01-16T14:51:14  <bitcoin-git> [bitcoin] Sjors opened pull request #17941: depends: update to Boost 1.72 (master...2020/01/boost-bump) https://github.com/bitcoin/bitcoin/pull/17941
3422020-01-16T14:51:15  *** bitcoin-git has left #bitcoin-core-dev
3432020-01-16T15:00:01  *** kees1 has quit IRC
3442020-01-16T15:12:49  *** Skirmant has joined #bitcoin-core-dev
3452020-01-16T15:17:39  *** maop has joined #bitcoin-core-dev
3462020-01-16T15:23:58  *** promag has joined #bitcoin-core-dev
3472020-01-16T15:24:05  *** Kiminuo has quit IRC
3482020-01-16T15:24:18  *** dviola has quit IRC
3492020-01-16T15:26:19  *** Skirmant has quit IRC
3502020-01-16T15:28:33  *** promag has quit IRC
3512020-01-16T15:33:34  *** promag has joined #bitcoin-core-dev
3522020-01-16T15:36:26  *** justan0theruser is now known as justanotheruser
3532020-01-16T15:38:23  *** mdunnio has joined #bitcoin-core-dev
3542020-01-16T15:38:36  *** Guyver2 has joined #bitcoin-core-dev
3552020-01-16T16:04:09  *** paracyst has quit IRC
3562020-01-16T16:05:08  *** paracyst has joined #bitcoin-core-dev
3572020-01-16T16:05:57  *** jarthur has joined #bitcoin-core-dev
3582020-01-16T16:28:27  *** promag has quit IRC
3592020-01-16T16:29:40  *** promag has joined #bitcoin-core-dev
3602020-01-16T16:34:02  *** turbo_choo has quit IRC
3612020-01-16T16:35:39  <elichai2> meta question: free function vs methods?
3622020-01-16T16:39:01  *** turbo_choo has joined #bitcoin-core-dev
3632020-01-16T16:40:59  *** promag has quit IRC
3642020-01-16T16:51:38  *** goatpig has quit IRC
3652020-01-16T16:52:56  *** abrissbi1ne is now known as abrissbirne
3662020-01-16T16:54:20  *** bitcoin-git has joined #bitcoin-core-dev
3672020-01-16T16:54:20  <bitcoin-git> [bitcoin] fjahr opened pull request #17942: doc: Improve fuzzing docs for macOS users (master...fuzzing_docs) https://github.com/bitcoin/bitcoin/pull/17942
3682020-01-16T16:54:21  *** bitcoin-git has left #bitcoin-core-dev
3692020-01-16T16:56:13  *** Talkless has joined #bitcoin-core-dev
3702020-01-16T17:02:28  *** hznc has joined #bitcoin-core-dev
3712020-01-16T17:04:16  *** Talkless has quit IRC
3722020-01-16T17:05:01  *** Talkless has joined #bitcoin-core-dev
3732020-01-16T17:10:18  *** setpill has quit IRC
3742020-01-16T17:25:20  *** filchef has joined #bitcoin-core-dev
3752020-01-16T17:36:25  <wumpus> elichai2: if it needs to access properties or other methods of the class it should be a method, if it is a pure function the a function is better
3762020-01-16T17:39:34  *** MrPaz has joined #bitcoin-core-dev
3772020-01-16T17:49:02  *** luke-jr has quit IRC
3782020-01-16T17:56:55  *** promag has joined #bitcoin-core-dev
3792020-01-16T17:59:04  *** luke-jr has joined #bitcoin-core-dev
3802020-01-16T18:00:01  *** maop has quit IRC
3812020-01-16T18:01:47  <sipa> elichai2: functions are more composable
3822020-01-16T18:02:24  <sipa> say you want to have some function that operates on a CTransaction, if you add it as a method, you're forcing every user of CTransaction to depend on your new code
3832020-01-16T18:02:45  <sipa> as a free function, implemented where you need it (unless it's very fundamental) can avoid annoying dependency cycles
3842020-01-16T18:02:51  <wumpus> also a good point
3852020-01-16T18:03:03  <sipa> (^ my personal opinion, which not everyone always agrees with)
3862020-01-16T18:11:39  *** goatpig has joined #bitcoin-core-dev
3872020-01-16T18:15:03  <wumpus> I agree "is it fundamental" is the right question there
3882020-01-16T18:15:40  <sipa> right, i guess the differences in opinion aren't so much the principle, but what people consider fundamental
3892020-01-16T18:15:53  <wumpus> true
3902020-01-16T18:17:20  *** sirkitree has joined #bitcoin-core-dev
3912020-01-16T18:24:06  *** bitcoin-git has joined #bitcoin-core-dev
3922020-01-16T18:24:06  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a9c789ed964d...f018d0c9cd7f
3932020-01-16T18:24:07  <bitcoin-git> bitcoin/master 4b8f1e9 Gregory Sanders: IsUsedDestination shouldn't use key id as script id for ScriptHash
3942020-01-16T18:24:07  <bitcoin-git> bitcoin/master 6dd59d2 Gregory Sanders: Don't allow implementers to think ScriptHash(Witness*()) results in nestin...
3952020-01-16T18:24:08  <bitcoin-git> bitcoin/master f018d0c Wladimir J. van der Laan: Merge #17924: Bug: IsUsedDestination shouldn't use key id as script id for...
3962020-01-16T18:24:09  *** bitcoin-git has left #bitcoin-core-dev
3972020-01-16T18:24:26  *** bitcoin-git has joined #bitcoin-core-dev
3982020-01-16T18:24:26  <bitcoin-git> [bitcoin] laanwj merged pull request #17924: Bug: IsUsedDestination shouldn't use key id as script id for ScriptHash (master...reuse_regression) https://github.com/bitcoin/bitcoin/pull/17924
3992020-01-16T18:24:28  *** bitcoin-git has left #bitcoin-core-dev
4002020-01-16T18:31:53  *** Highway61 has quit IRC
4012020-01-16T18:33:43  *** promag has quit IRC
4022020-01-16T18:52:19  *** bitcoin-git has joined #bitcoin-core-dev
4032020-01-16T18:52:19  <bitcoin-git> [bitcoin] hebasto opened pull request #17943: qt, refactor: Remove never used default parameter (master...20200116-message-parameter) https://github.com/bitcoin/bitcoin/pull/17943
4042020-01-16T18:52:29  *** bitcoin-git has left #bitcoin-core-dev
4052020-01-16T18:58:51  *** jonatack has joined #bitcoin-core-dev
4062020-01-16T19:00:20  <wumpus> #startmeeting
4072020-01-16T19:00:20  <lightningbot> Meeting started Thu Jan 16 19:00:20 2020 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
4082020-01-16T19:00:20  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
4092020-01-16T19:00:25  <hebasto> hi
4102020-01-16T19:00:25  <emilengler> hi
4112020-01-16T19:00:26  <kanzure> hi
4122020-01-16T19:00:27  <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr
4132020-01-16T19:00:29  <wumpus> jeremyrubin lightlike emilengler jonatack hebasto jb55
4142020-01-16T19:00:33  <jonatack> hi
4152020-01-16T19:00:34  <achow101> hi
4162020-01-16T19:00:43  <instagibbs> hi
4172020-01-16T19:00:45  <sipa> hi
4182020-01-16T19:00:49  <nehan_> hi
4192020-01-16T19:00:51  <meshcollider> hi
4202020-01-16T19:00:53  <fjahr> hi
4212020-01-16T19:00:54  <wumpus> there have been no proposed topics in https://gist.github.com/moneyball/071d608fdae217c2a6d7c35955881d8a, any last minute proposals?
4222020-01-16T19:00:54  <andytoshi> hi
4232020-01-16T19:01:16  <adiabat> hi
4242020-01-16T19:01:41  <jamesob> hi
4252020-01-16T19:01:43  <wumpus> re: 0.19.1, we've made some progress, but there's still 3 PRs that need to be reviewed merged
4262020-01-16T19:02:11  <wumpus> #topic High priority for review
4272020-01-16T19:02:45  <wumpus> at the moment, 8 blockers, 3 bugfixes, 6 chasing concept ACK: https://github.com/bitcoin/bitcoin/projects/8
4282020-01-16T19:03:06  <wumpus> the bugfixes are for 0.19 backport, and would be good to have in 0.19.1
4292020-01-16T19:03:54  <sipa> what's blocking 0.19.1?
4302020-01-16T19:04:10  <wumpus> #17897 definitely needs more review, by someone that understands the indexing code closely
4312020-01-16T19:04:12  <gribble> https://github.com/bitcoin/bitcoin/issues/17897 | init: Stop indexes on shutdown after ChainStateFlushed callback. by jimpo · Pull Request #17897 · bitcoin/bitcoin · GitHub
4322020-01-16T19:04:25  <jamesob> can I request we add #17737? as an aside, assumeutxo is in pretty good shape - I think it's got pretty broad concept ACK and the prototype branch seems to be working well. if I can get some help with review and testing, we might be able to `loadtxoutset` by the end of the year... and then we can start thinking about (and whether or not it's worth it) to propagate utxo snapshots through the p2p network
4332020-01-16T19:04:29  <gribble> https://github.com/bitcoin/bitcoin/issues/17737 | Add ChainstateManager, remove BlockManager global by jamesob · Pull Request #17737 · bitcoin/bitcoin · GitHub
4342020-01-16T19:04:35  <wumpus> sipa: #17897 #17892 and #17887
4352020-01-16T19:04:37  <gribble> https://github.com/bitcoin/bitcoin/issues/17897 | init: Stop indexes on shutdown after ChainStateFlushed callback. by jimpo · Pull Request #17897 · bitcoin/bitcoin · GitHub
4362020-01-16T19:04:39  <gribble> https://github.com/bitcoin/bitcoin/issues/17892 | bug-fix: delay flushing undo files until after they are finalized by kallewoof · Pull Request #17892 · bitcoin/bitcoin · GitHub
4372020-01-16T19:04:40  <gribble> https://github.com/bitcoin/bitcoin/issues/17887 | bug-fix macos: give free bytes to F_PREALLOCATE by kallewoof · Pull Request #17887 · bitcoin/bitcoin · GitHub
4382020-01-16T19:04:55  <wumpus> the latter two are to work around a macosx bug with preallocating files
4392020-01-16T19:05:06  <sipa> ok, that doesn't look too daunting
4402020-01-16T19:05:34  *** jcoe has quit IRC
4412020-01-16T19:05:58  <wumpus> last week there seemed to be agreement that this was important for 0.19.1, I'm somewhat sceptical about working around an OS bug at our side, but they're not terrile backs
4422020-01-16T19:06:13  <jamesob> I'll take a look at 17897
4432020-01-16T19:06:38  <wumpus> jamesob: great to hear that assumeutxo is on the right track!
4442020-01-16T19:06:49  *** promag has joined #bitcoin-core-dev
4452020-01-16T19:07:13  <instagibbs> jamesob, is 15606 actually the "child" PR?
4462020-01-16T19:07:29  <instagibbs> or mothership, I dunno
4472020-01-16T19:07:39  <jamesob> instagibbs: yep
4482020-01-16T19:07:46  <jamesob> more mothership than child
4492020-01-16T19:08:01  <jamesob> but all the assumeutxo code is there
4502020-01-16T19:08:14  <wumpus> added 17737
4512020-01-16T19:08:19  <instagibbs> cool, will review
4522020-01-16T19:08:33  <wumpus> please also review #16702, it seems to be pretty close to mergable
4532020-01-16T19:08:38  <gribble> https://github.com/bitcoin/bitcoin/issues/16702 | p2p: supplying and using asmap to improve IP bucketing in addrman by naumenkogs · Pull Request #16702 · bitcoin/bitcoin · GitHub
4542020-01-16T19:09:06  <jamesob> instagibbs: thanks! recent utxo snapshots for testing are available here: https://github.com/bitcoin/bitcoin/pull/15606#issuecomment-555213164
4552020-01-16T19:09:08  <sipa> #17896 is close too, i think
4562020-01-16T19:09:10  <gribble> https://github.com/bitcoin/bitcoin/issues/17896 | Serialization improvements (step 2) by sipa · Pull Request #17896 · bitcoin/bitcoin · GitHub
4572020-01-16T19:09:38  <jnewbery> hi
4582020-01-16T19:10:08  <wumpus> sipa: ah yes, clearly
4592020-01-16T19:11:29  <wumpus> the review load is extremely high as usual :)
4602020-01-16T19:11:31  <jnewbery> #suggestedtopic Bitcoin Core contributor survey
4612020-01-16T19:11:50  <wumpus> #topic Bitcoin Core contributor survey (jnewbery)
4622020-01-16T19:11:57  <jnewbery> Thanks wumpus!
4632020-01-16T19:12:10  <jnewbery> we're having our next coredev irl meeting soonish
4642020-01-16T19:12:19  <promag> hi
4652020-01-16T19:12:45  <jnewbery> I'm going to send around a few questions to active contributors before the meeting, and then present the summary at the coredev meeting
4662020-01-16T19:13:09  <kanzure> regarding that meeting, i plan to once again collect topics (or maybe someone else will)- so send topic proposals that you'd like to see discussed or that you would like to discuss yourself
4672020-01-16T19:13:19  <jnewbery> so expect that in your inbox soon. It shouldn't take too long to fill out
4682020-01-16T19:13:38  <jnewbery> that's all I had. Feel free to message me if you have any questions or thoughts about that
4692020-01-16T19:13:42  <kanzure> is this meeting related or bitcoin core contributor quality of life questions?
4702020-01-16T19:13:46  <wumpus> ok, good to know
4712020-01-16T19:14:22  <jnewbery> kanzure: a bit of both. Trying to find out what people's priorities are and if they have any suggestions about the Bitcoin Core process, and then we can talk about them at the meeting
4722020-01-16T19:14:29  <kanzure> cool. makes sense.
4732020-01-16T19:15:30  <kanzure> maybe add some topic-collection questions too so i can minimize my workload :) not required though!
4742020-01-16T19:15:52  <luke-jr> hi
4752020-01-16T19:16:05  <luke-jr> jnewbery: do you want those of us who won't make it to do the survey?
4762020-01-16T19:16:47  <jnewbery> yes please! Looking for input from anyone who's active in the project.
4772020-01-16T19:17:07  <jnewbery> kanzure: good idea. I'll add a topic-collection question and share results with you
4782020-01-16T19:17:52  <kanzure> thank you
4792020-01-16T19:17:53  <wumpus> thanks jnewbery
4802020-01-16T19:18:49  <wumpus> any other topics for today?
4812020-01-16T19:20:35  <wumpus> ok, have a good week then everyone, hope we can get some more of the high priority PRs merged
4822020-01-16T19:20:40  <wumpus> #endmeeting
4832020-01-16T19:20:40  <lightningbot> Meeting ended Thu Jan 16 19:20:40 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
4842020-01-16T19:20:40  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-01-16-19.00.html
4852020-01-16T19:20:40  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-01-16-19.00.txt
4862020-01-16T19:20:40  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-01-16-19.00.log.html
4872020-01-16T19:21:15  <instagibbs> boxing the wallet is very close :)
4882020-01-16T19:21:19  <kanzure> anyone should feel free to pm/email me topic ideas for physical meeting. i was just thinking that something about fuzzing would be a fun topic....
4892020-01-16T19:21:42  <kanzure> (or the mutation testing technique for that matter.)
4902020-01-16T19:22:37  <luke-jr> jnewbery: btw, by soon just how soon do you mean?
4912020-01-16T19:22:57  <instagibbs> oh, I missed the pr review club on fuzzing. :( i even did my homework
4922020-01-16T19:23:29  <jonatack> wallet meeting tomorrow, yes?
4932020-01-16T19:23:46  <instagibbs> jonatack, yep
4942020-01-16T19:25:42  <instagibbs> MarcoFalke, Seems like no one figured out how to run `test_runner.py` for the fuzzer?
4952020-01-16T19:25:51  <instagibbs> at least in pr club notes
4962020-01-16T19:30:07  <jonatack> instagibbs: nope. still trying to catch the bad-txns-inputs-duplicate cve with that fuzz test PR and the check removed from CheckTransaction().
4972020-01-16T19:35:09  *** emilengler has quit IRC
4982020-01-16T19:40:56  *** Highway61 has joined #bitcoin-core-dev
4992020-01-16T19:45:52  *** DeanGuss has quit IRC
5002020-01-16T19:46:09  *** DeanGuss has joined #bitcoin-core-dev
5012020-01-16T19:54:43  *** Highway61 has quit IRC
5022020-01-16T19:55:47  <instagibbs> I ran it overnight and decided it wasn't getting enough runs per second to be worth it for me
5032020-01-16T20:01:05  *** promag has quit IRC
5042020-01-16T20:05:53  *** Talkless has quit IRC
5052020-01-16T20:08:11  *** hznc has quit IRC
5062020-01-16T20:13:08  *** timothy has quit IRC
5072020-01-16T20:15:23  *** goatpig has quit IRC
5082020-01-16T20:17:32  *** owowo has quit IRC
5092020-01-16T20:18:31  *** Highway61 has joined #bitcoin-core-dev
5102020-01-16T20:22:57  <MarcoFalke> instagibbs: The test_runner is mostly for travis
5112020-01-16T20:23:10  <MarcoFalke> It is meant to run over existing seeds
5122020-01-16T20:23:21  <MarcoFalke> Not really meant to create new inputs
5132020-01-16T20:24:39  *** Kiminuo has joined #bitcoin-core-dev
5142020-01-16T20:24:41  *** owowo has joined #bitcoin-core-dev
5152020-01-16T20:25:49  *** bitcoin-git has joined #bitcoin-core-dev
5162020-01-16T20:25:50  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f018d0c9cd7f...218274de7d1f
5172020-01-16T20:25:50  <bitcoin-git> bitcoin/master 42ec499 Jon Atack: doc: developer notes guideline on RPCExamples addresses
5182020-01-16T20:25:51  <bitcoin-git> bitcoin/master 218274d MarcoFalke: Merge #17819: doc: developer notes guideline on RPCExamples addresses
5192020-01-16T20:25:53  *** bitcoin-git has left #bitcoin-core-dev
5202020-01-16T20:26:09  *** bitcoin-git has joined #bitcoin-core-dev
5212020-01-16T20:26:09  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17819: doc: developer notes guideline on RPCExamples addresses (master...rpc-examples-use-invalid-addresses) https://github.com/bitcoin/bitcoin/pull/17819
5222020-01-16T20:26:10  *** bitcoin-git has left #bitcoin-core-dev
5232020-01-16T20:36:14  *** Highway61 has quit IRC
5242020-01-16T20:38:06  *** jeremyrubin has joined #bitcoin-core-dev
5252020-01-16T20:43:45  *** bitcoin-git has joined #bitcoin-core-dev
5262020-01-16T20:43:45  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/218274de7d1f...ec9b964cc998
5272020-01-16T20:43:46  <bitcoin-git> bitcoin/master 1be0b1f Sebastian Falbesoner: test: add functional test for non-standard bare multisig txs
5282020-01-16T20:43:47  <bitcoin-git> bitcoin/master ec9b964 MarcoFalke: Merge #17541: test: add functional test for non-standard bare multisig txs...
5292020-01-16T20:43:48  *** bitcoin-git has left #bitcoin-core-dev
5302020-01-16T20:44:15  *** bitcoin-git has joined #bitcoin-core-dev
5312020-01-16T20:44:15  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17541: test: add functional test for non-standard bare multisig txs (master...20191120-test-for-bare-multisig-in-mempool_accept) https://github.com/bitcoin/bitcoin/pull/17541
5322020-01-16T20:44:16  *** bitcoin-git has left #bitcoin-core-dev
5332020-01-16T20:44:59  *** rex4539 has joined #bitcoin-core-dev
5342020-01-16T20:44:59  <jnewbery> luke-jr: today or tomorrow
5352020-01-16T20:49:02  *** bitcoin-git has joined #bitcoin-core-dev
5362020-01-16T20:49:02  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ec9b964cc998...2aaeca50b22d
5372020-01-16T20:49:03  <bitcoin-git> bitcoin/master ef63f5f Sebastian Falbesoner: ci: Combine 32-bit build with CentOS 7 build
5382020-01-16T20:49:03  <bitcoin-git> bitcoin/master 2aaeca5 MarcoFalke: Merge #17900: ci: Combine 32-bit build with CentOS 7 build
5392020-01-16T20:49:05  *** bitcoin-git has left #bitcoin-core-dev
5402020-01-16T20:49:21  *** bitcoin-git has joined #bitcoin-core-dev
5412020-01-16T20:49:21  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17900: ci: Combine 32-bit build with CentOS 7 build (master...20200108-ci-add-32-bit-centos-build) https://github.com/bitcoin/bitcoin/pull/17900
5422020-01-16T20:49:22  *** bitcoin-git has left #bitcoin-core-dev
5432020-01-16T20:54:04  *** bitcoin-git has joined #bitcoin-core-dev
5442020-01-16T20:54:04  <bitcoin-git> [bitcoin] dongcarl opened pull request #17944: netaddress: Simplify reachability logic (master...2020-01-simplify-reachability) https://github.com/bitcoin/bitcoin/pull/17944
5452020-01-16T20:54:05  *** bitcoin-git has left #bitcoin-core-dev
5462020-01-16T20:57:37  *** Highway61 has joined #bitcoin-core-dev
5472020-01-16T21:00:02  *** sirkitree has quit IRC
5482020-01-16T21:00:47  *** bitcoin-git has joined #bitcoin-core-dev
5492020-01-16T21:00:47  <bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/2aaeca50b22d...95ca6aeec7b8
5502020-01-16T21:00:48  <bitcoin-git> bitcoin/master 071f2fc Hennadii Stepanov: script: Add ability to insert copyright to *.sh
5512020-01-16T21:00:48  <bitcoin-git> bitcoin/master 1998152 Hennadii Stepanov: script: Add empty line after C++ copyright
5522020-01-16T21:00:49  <bitcoin-git> bitcoin/master 6fde9d5 Hennadii Stepanov: script: Update EXLUDE list in copyright_header.py
5532020-01-16T21:00:55  *** bitcoin-git has left #bitcoin-core-dev
5542020-01-16T21:01:11  *** bitcoin-git has joined #bitcoin-core-dev
5552020-01-16T21:01:11  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17691: doc: Add missed copyright headers (master...20191207-copyright-headers) https://github.com/bitcoin/bitcoin/pull/17691
5562020-01-16T21:01:12  *** bitcoin-git has left #bitcoin-core-dev
5572020-01-16T21:08:34  *** Highway62 has joined #bitcoin-core-dev
5582020-01-16T21:08:43  *** Highway61 has quit IRC
5592020-01-16T21:08:43  *** Highway62 is now known as Highway61
5602020-01-16T21:10:06  <luke-jr> jnewbery: I mean the coredev.tech IRL meetup
5612020-01-16T21:13:23  *** promag has joined #bitcoin-core-dev
5622020-01-16T21:19:55  *** promag has quit IRC
5632020-01-16T21:29:48  *** Guyver2_ has joined #bitcoin-core-dev
5642020-01-16T21:31:51  *** Guyver2_ has quit IRC
5652020-01-16T21:33:03  *** Guyver2 has quit IRC
5662020-01-16T21:33:28  <jamesob> man my logs are packed with `Feeding [x] bytes of dynamic environment data into RNG`. wonder if we should move that to a debug level.
5672020-01-16T21:35:33  *** MrPaz has quit IRC
5682020-01-16T21:36:39  <sipa> jamesob: update master
5692020-01-16T21:37:01  <jamesob> ah, testing a branch.
5702020-01-16T21:38:20  <jonatack> jamesob: pull in commit 0ccad08
5712020-01-16T21:38:37  <jamesob> jonatack: thanks
5722020-01-16T21:40:43  *** vasild has quit IRC
5732020-01-16T21:42:42  *** vasild has joined #bitcoin-core-dev
5742020-01-16T21:46:52  *** reeiiko has joined #bitcoin-core-dev
5752020-01-16T21:49:24  *** rex4539 has quit IRC
5762020-01-16T22:04:00  *** jb55 has quit IRC
5772020-01-16T22:05:44  *** filchef has quit IRC
5782020-01-16T22:18:39  *** jeremyrubin has quit IRC
5792020-01-16T22:25:54  *** cryptapus has quit IRC
5802020-01-16T22:27:14  *** cryptapus has joined #bitcoin-core-dev
5812020-01-16T22:27:14  *** cryptapus has joined #bitcoin-core-dev
5822020-01-16T22:28:21  *** Zenton has quit IRC
5832020-01-16T22:37:28  *** tryphe has quit IRC
5842020-01-16T22:49:27  *** swamp has joined #bitcoin-core-dev
5852020-01-16T22:55:37  *** jb55 has joined #bitcoin-core-dev
5862020-01-16T22:59:51  *** tryphe has joined #bitcoin-core-dev
5872020-01-16T23:08:46  *** SiAnDoG_ has joined #bitcoin-core-dev
5882020-01-16T23:16:13  *** MrPaz has joined #bitcoin-core-dev
5892020-01-16T23:16:53  *** hex17or has quit IRC
5902020-01-16T23:17:27  *** justanotheruser has quit IRC
5912020-01-16T23:20:33  *** promag has joined #bitcoin-core-dev
5922020-01-16T23:21:06  *** justanotheruser has joined #bitcoin-core-dev
5932020-01-16T23:21:59  *** mdunnio has quit IRC
5942020-01-16T23:24:12  *** ossifrage has quit IRC
5952020-01-16T23:25:08  *** promag has quit IRC
5962020-01-16T23:27:06  *** pinheadmz has quit IRC
5972020-01-16T23:43:11  *** ossifrage has joined #bitcoin-core-dev
5982020-01-16T23:51:54  *** jarthur has quit IRC
5992020-01-16T23:58:10  <meshcollider> yep let's have the first wallet meeting of 2020 tomorrow for those who want to attend :)
6002020-01-16T23:59:25  <fanquake> #tooearlyinthemorning