1 2020-01-16T00:00:02  *** elsimio has quit IRC
  2 2020-01-16T00:01:21  *** mdunnio has quit IRC
  3 2020-01-16T00:02:10  *** Highway61 has quit IRC
  4 2020-01-16T00:07:58  *** Skirmant has joined #bitcoin-core-dev
  5 2020-01-16T00:12:19  *** promag has quit IRC
  6 2020-01-16T00:12:57  *** Highway61 has joined #bitcoin-core-dev
  7 2020-01-16T00:17:06  *** kodein1 has joined #bitcoin-core-dev
  8 2020-01-16T00:18:23  *** amiti has quit IRC
  9 2020-01-16T00:18:27  *** neatnik has quit IRC
 10 2020-01-16T00:18:30  *** valwal has quit IRC
 11 2020-01-16T00:18:35  *** mariorz has quit IRC
 12 2020-01-16T00:18:36  *** CodeShark__ has quit IRC
 13 2020-01-16T00:18:38  *** vfP56jSe has quit IRC
 14 2020-01-16T00:18:48  *** aerth has quit IRC
 15 2020-01-16T00:18:48  *** wbnns has quit IRC
 16 2020-01-16T00:18:50  *** kristapsk has quit IRC
 17 2020-01-16T00:19:31  *** mariorz has joined #bitcoin-core-dev
 18 2020-01-16T00:19:35  *** wbnns has joined #bitcoin-core-dev
 19 2020-01-16T00:19:54  *** amiti has joined #bitcoin-core-dev
 20 2020-01-16T00:19:55  *** neatnik has joined #bitcoin-core-dev
 21 2020-01-16T00:19:56  *** vfP56jSe has joined #bitcoin-core-dev
 22 2020-01-16T00:20:04  *** aerth has joined #bitcoin-core-dev
 23 2020-01-16T00:20:05  *** CodeShark__ has joined #bitcoin-core-dev
 24 2020-01-16T00:21:03  *** alec has quit IRC
 25 2020-01-16T00:21:13  *** endogenic has joined #bitcoin-core-dev
 26 2020-01-16T00:21:58  *** eragmus has joined #bitcoin-core-dev
 27 2020-01-16T00:22:00  *** valwal has joined #bitcoin-core-dev
 28 2020-01-16T00:24:26  *** alec has joined #bitcoin-core-dev
 29 2020-01-16T00:26:54  *** Zenton has joined #bitcoin-core-dev
 30 2020-01-16T00:33:41  *** promag has joined #bitcoin-core-dev
 31 2020-01-16T00:38:10  *** promag has quit IRC
 32 2020-01-16T00:40:32  *** promag has joined #bitcoin-core-dev
 33 2020-01-16T00:42:23  *** vfP56jSe has quit IRC
 34 2020-01-16T00:42:27  *** eragmus has quit IRC
 35 2020-01-16T00:42:34  *** peltre has quit IRC
 36 2020-01-16T00:42:41  *** amiti has quit IRC
 37 2020-01-16T00:42:48  *** aerth has quit IRC
 38 2020-01-16T00:42:52  *** CodeShark__ has quit IRC
 39 2020-01-16T00:42:57  *** endogenic has quit IRC
 40 2020-01-16T00:42:57  *** elichai2 has quit IRC
 41 2020-01-16T00:43:12  *** jamesob has quit IRC
 42 2020-01-16T00:43:32  *** ajonas has quit IRC
 43 2020-01-16T00:43:32  *** pierre_rochard has quit IRC
 44 2020-01-16T00:43:38  *** petezz4 has quit IRC
 45 2020-01-16T00:43:38  *** arik__ has quit IRC
 46 2020-01-16T00:43:55  *** mariorz has quit IRC
 47 2020-01-16T00:44:05  *** digi_james has quit IRC
 48 2020-01-16T00:44:05  *** fanquake has quit IRC
 49 2020-01-16T00:44:07  *** moneyball has quit IRC
 50 2020-01-16T00:44:07  *** hugohn has quit IRC
 51 2020-01-16T00:44:07  *** schmidty has quit IRC
 52 2020-01-16T00:45:09  *** promag has quit IRC
 53 2020-01-16T00:45:52  *** neatnik has quit IRC
 54 2020-01-16T00:45:59  *** Lexyon___ has quit IRC
 55 2020-01-16T00:45:59  *** rodarmor has quit IRC
 56 2020-01-16T00:45:59  *** gertjaap has quit IRC
 57 2020-01-16T00:45:59  *** Liliaceae has quit IRC
 58 2020-01-16T00:46:08  *** Isthmus has quit IRC
 59 2020-01-16T00:46:08  *** gleb has quit IRC
 60 2020-01-16T00:46:37  *** NicolasDorier has quit IRC
 61 2020-01-16T00:46:37  *** drbrule has quit IRC
 62 2020-01-16T00:47:02  *** valwal has quit IRC
 63 2020-01-16T00:47:15  *** nejon has quit IRC
 64 2020-01-16T00:47:23  *** ccook has quit IRC
 65 2020-01-16T00:49:47  *** wbnns has quit IRC
 66 2020-01-16T00:50:08  *** promag has joined #bitcoin-core-dev
 67 2020-01-16T00:52:53  *** AaronvanW has quit IRC
 68 2020-01-16T00:53:21  *** RubenSomsen has quit IRC
 69 2020-01-16T00:53:38  *** wallet42 has quit IRC
 70 2020-01-16T00:54:08  *** bitcoin-git has joined #bitcoin-core-dev
 71 2020-01-16T00:54:09  <bitcoin-git> [bitcoin] Empact opened pull request #17938: Disallow automatic conversion between disparate hash types (master...hash-conversion) https://github.com/bitcoin/bitcoin/pull/17938
 72 2020-01-16T00:54:09  *** bitcoin-git has left #bitcoin-core-dev
 73 2020-01-16T00:55:46  *** nirved has quit IRC
 74 2020-01-16T00:56:27  *** felixweis has quit IRC
 75 2020-01-16T00:56:40  *** nirved has joined #bitcoin-core-dev
 76 2020-01-16T00:57:09  *** arik__ has joined #bitcoin-core-dev
 77 2020-01-16T00:57:46  *** petezz4 has joined #bitcoin-core-dev
 78 2020-01-16T00:59:04  *** Isthmus has joined #bitcoin-core-dev
 79 2020-01-16T00:59:14  *** promag has quit IRC
 80 2020-01-16T01:03:38  *** petezz4 has quit IRC
 81 2020-01-16T01:09:26  *** RubenSomsen has joined #bitcoin-core-dev
 82 2020-01-16T01:09:37  *** RubenSomsen has quit IRC
 83 2020-01-16T01:10:47  *** Liliaceae has joined #bitcoin-core-dev
 84 2020-01-16T01:16:53  *** arik__ has quit IRC
 85 2020-01-16T01:18:01  *** pierre_rochard has joined #bitcoin-core-dev
 86 2020-01-16T01:18:17  *** Liliaceae has quit IRC
 87 2020-01-16T01:24:22  *** elichai2 has joined #bitcoin-core-dev
 88 2020-01-16T01:26:37  *** elichai2 has quit IRC
 89 2020-01-16T01:30:12  *** pierre_rochard has quit IRC
 90 2020-01-16T01:31:25  *** AaronvanW has joined #bitcoin-core-dev
 91 2020-01-16T01:34:26  *** luke-jr has quit IRC
 92 2020-01-16T01:36:37  *** AaronvanW has quit IRC
 93 2020-01-16T01:36:56  *** Liliaceae has joined #bitcoin-core-dev
 94 2020-01-16T01:39:28  *** dviola has quit IRC
 95 2020-01-16T01:39:55  *** luke-jr has joined #bitcoin-core-dev
 96 2020-01-16T01:40:54  *** felixweis has joined #bitcoin-core-dev
 97 2020-01-16T01:41:53  *** Liliaceae has quit IRC
 98 2020-01-16T01:46:32  *** felixweis has quit IRC
 99 2020-01-16T01:50:16  *** BlueMatt has quit IRC
100 2020-01-16T01:51:50  *** felixweis has joined #bitcoin-core-dev
101 2020-01-16T01:55:48  *** BlueMatt has joined #bitcoin-core-dev
102 2020-01-16T01:57:33  *** felixweis has quit IRC
103 2020-01-16T02:04:59  *** AaronvanW has joined #bitcoin-core-dev
104 2020-01-16T02:09:31  *** belcher has quit IRC
105 2020-01-16T02:33:04  *** felixfoertsch has quit IRC
106 2020-01-16T02:35:42  *** Skirmant has quit IRC
107 2020-01-16T02:38:37  *** AaronvanW has quit IRC
108 2020-01-16T02:39:41  *** felixfoertsch has joined #bitcoin-core-dev
109 2020-01-16T02:49:38  *** Highway61 has quit IRC
110 2020-01-16T02:50:41  *** marcoagner has quit IRC
111 2020-01-16T02:55:43  *** wullon has quit IRC
112 2020-01-16T02:56:08  *** wullon has joined #bitcoin-core-dev
113 2020-01-16T03:00:01  *** kodein1 has quit IRC
114 2020-01-16T03:00:58  *** abrissbi1ne has joined #bitcoin-core-dev
115 2020-01-16T03:04:17  *** felixfoertsch23 has joined #bitcoin-core-dev
116 2020-01-16T03:04:30  *** abrissbirne has quit IRC
117 2020-01-16T03:05:19  *** felixfoertsch has quit IRC
118 2020-01-16T03:08:06  *** BlueMatt has quit IRC
119 2020-01-16T03:09:43  *** BlueMatt has joined #bitcoin-core-dev
120 2020-01-16T03:17:05  *** funkyb has joined #bitcoin-core-dev
121 2020-01-16T04:03:35  *** justan0theruser has joined #bitcoin-core-dev
122 2020-01-16T04:05:56  *** justanotheruser has quit IRC
123 2020-01-16T04:10:26  *** volbil has joined #bitcoin-core-dev
124 2020-01-16T04:18:36  *** eragmus has joined #bitcoin-core-dev
125 2020-01-16T04:25:54  *** Isthmus has joined #bitcoin-core-dev
126 2020-01-16T04:27:01  *** eragmus has quit IRC
127 2020-01-16T04:28:05  *** Isthmus has quit IRC
128 2020-01-16T04:30:26  *** Eagle[TM] has joined #bitcoin-core-dev
129 2020-01-16T04:31:27  <luke-jr> update: false alarm, it's a bug in the test (part of #11413)
130 2020-01-16T04:31:31  <gribble> https://github.com/bitcoin/bitcoin/issues/11413 | [wallet] [rpc] sendtoaddress/sendmany: Add explicit feerate option by kallewoof · Pull Request #11413 · bitcoin/bitcoin · GitHub
131 2020-01-16T04:32:46  *** EagleTM has quit IRC
132 2020-01-16T04:35:26  <sipa> luke-jr: best kind of bug
133 2020-01-16T04:35:42  *** AaronvanW has joined #bitcoin-core-dev
134 2020-01-16T04:36:34  <luke-jr> sipa: not when it's intermittant :p
135 2020-01-16T04:40:33  *** Isthmus has joined #bitcoin-core-dev
136 2020-01-16T04:56:27  <sipa> u
137 2020-01-16T04:59:47  <sipa> luke-jr: if i had to have an intermittent bug, my preference would still be to have it in the tests :)
138 2020-01-16T05:08:38  *** AaronvanW has quit IRC
139 2020-01-16T05:17:22  <luke-jr> ☺
140 2020-01-16T05:31:47  *** Victor_sueca has joined #bitcoin-core-dev
141 2020-01-16T05:32:42  *** moneyball has joined #bitcoin-core-dev
142 2020-01-16T05:34:29  *** Victorsueca has quit IRC
143 2020-01-16T05:39:03  *** moneyball has quit IRC
144 2020-01-16T06:00:01  *** funkyb has quit IRC
145 2020-01-16T06:04:16  *** ossifrage has quit IRC
146 2020-01-16T06:17:36  *** vkmc has joined #bitcoin-core-dev
147 2020-01-16T06:18:41  *** gleb has joined #bitcoin-core-dev
148 2020-01-16T06:25:07  *** ossifrage has joined #bitcoin-core-dev
149 2020-01-16T06:34:23  *** achow101 has quit IRC
150 2020-01-16T06:42:52  *** gleb has quit IRC
151 2020-01-16T06:43:25  *** achow101 has joined #bitcoin-core-dev
152 2020-01-16T06:44:03  *** gleb has joined #bitcoin-core-dev
153 2020-01-16T06:48:58  *** CodeShark__ has joined #bitcoin-core-dev
154 2020-01-16T06:49:28  *** moneyball has joined #bitcoin-core-dev
155 2020-01-16T06:49:47  *** neatnik has joined #bitcoin-core-dev
156 2020-01-16T06:51:54  *** schmidty has joined #bitcoin-core-dev
157 2020-01-16T06:53:10  *** RubenSomsen has joined #bitcoin-core-dev
158 2020-01-16T06:53:16  *** ccook has joined #bitcoin-core-dev
159 2020-01-16T06:53:17  *** petezz4 has joined #bitcoin-core-dev
160 2020-01-16T06:53:23  *** digi_james has joined #bitcoin-core-dev
161 2020-01-16T06:53:23  *** NicolasDorier has joined #bitcoin-core-dev
162 2020-01-16T06:53:44  *** elichai2 has joined #bitcoin-core-dev
163 2020-01-16T06:56:03  *** wallet42 has joined #bitcoin-core-dev
164 2020-01-16T06:56:09  *** peltre has joined #bitcoin-core-dev
165 2020-01-16T06:56:56  *** fanquake has joined #bitcoin-core-dev
166 2020-01-16T06:56:57  *** wbnns has joined #bitcoin-core-dev
167 2020-01-16T06:57:25  *** jamesob has joined #bitcoin-core-dev
168 2020-01-16T06:59:08  *** eragmus has joined #bitcoin-core-dev
169 2020-01-16T07:00:10  *** Lexyon___ has joined #bitcoin-core-dev
170 2020-01-16T07:00:16  *** gertjaap has joined #bitcoin-core-dev
171 2020-01-16T07:00:23  *** ajonas has joined #bitcoin-core-dev
172 2020-01-16T07:00:55  *** felixweis has joined #bitcoin-core-dev
173 2020-01-16T07:00:59  *** pierre_rochard has joined #bitcoin-core-dev
174 2020-01-16T07:01:37  *** rodarmor has joined #bitcoin-core-dev
175 2020-01-16T07:01:43  *** drbrule has joined #bitcoin-core-dev
176 2020-01-16T07:05:12  *** Liliaceae has joined #bitcoin-core-dev
177 2020-01-16T07:05:12  *** AaronvanW has joined #bitcoin-core-dev
178 2020-01-16T07:05:59  *** turbo_choo has quit IRC
179 2020-01-16T07:06:34  *** manantial has joined #bitcoin-core-dev
180 2020-01-16T07:06:41  *** mariorz has joined #bitcoin-core-dev
181 2020-01-16T07:10:46  *** Isthmus has joined #bitcoin-core-dev
182 2020-01-16T07:11:26  *** fjahr has joined #bitcoin-core-dev
183 2020-01-16T07:12:54  *** valwal has joined #bitcoin-core-dev
184 2020-01-16T07:17:16  *** Squidicuz has quit IRC
185 2020-01-16T07:17:23  *** hugohn has joined #bitcoin-core-dev
186 2020-01-16T07:19:48  *** Bullit has quit IRC
187 2020-01-16T07:20:37  *** Bullit has joined #bitcoin-core-dev
188 2020-01-16T07:22:04  *** arik__ has joined #bitcoin-core-dev
189 2020-01-16T07:27:24  *** Eagle[TM] has quit IRC
190 2020-01-16T07:38:27  *** AaronvanW has quit IRC
191 2020-01-16T07:38:49  *** Jackielove4u has joined #bitcoin-core-dev
192 2020-01-16T07:47:42  *** endogenic has joined #bitcoin-core-dev
193 2020-01-16T07:49:26  *** bosma has joined #bitcoin-core-dev
194 2020-01-16T07:53:23  *** aerth has joined #bitcoin-core-dev
195 2020-01-16T07:57:03  *** vfP56jSe has joined #bitcoin-core-dev
196 2020-01-16T08:03:35  *** nejon has joined #bitcoin-core-dev
197 2020-01-16T08:12:09  *** promag has joined #bitcoin-core-dev
198 2020-01-16T08:13:08  *** amiti has joined #bitcoin-core-dev
199 2020-01-16T08:14:17  *** cfields has quit IRC
200 2020-01-16T08:15:56  *** cfields has joined #bitcoin-core-dev
201 2020-01-16T08:16:13  *** promag has quit IRC
202 2020-01-16T08:20:19  *** ghost43_ has joined #bitcoin-core-dev
203 2020-01-16T08:20:23  *** ghost43 has quit IRC
204 2020-01-16T08:22:37  *** goatpig has joined #bitcoin-core-dev
205 2020-01-16T08:44:03  *** EagleTM has joined #bitcoin-core-dev
206 2020-01-16T08:58:02  *** Victor_sueca has quit IRC
207 2020-01-16T09:00:01  *** vkmc has quit IRC
208 2020-01-16T09:15:43  *** volbil has quit IRC
209 2020-01-16T09:16:16  *** AaronvanW has joined #bitcoin-core-dev
210 2020-01-16T09:17:29  *** hali has joined #bitcoin-core-dev
211 2020-01-16T09:28:05  *** EagleTM has quit IRC
212 2020-01-16T09:28:25  *** turbo_choo has joined #bitcoin-core-dev
213 2020-01-16T09:34:57  *** vasild_ is now known as vasild
214 2020-01-16T09:41:03  *** vasild has quit IRC
215 2020-01-16T09:46:12  *** EagleTM has joined #bitcoin-core-dev
216 2020-01-16T09:46:43  *** promag has joined #bitcoin-core-dev
217 2020-01-16T09:51:29  *** belcher has joined #bitcoin-core-dev
218 2020-01-16T09:53:00  *** vasild has joined #bitcoin-core-dev
219 2020-01-16T09:58:18  *** bitcoin-git has joined #bitcoin-core-dev
220 2020-01-16T09:58:19  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ac61ec9da679...4e8b564df0d4
221 2020-01-16T09:58:19  <bitcoin-git> bitcoin/master f117fb0 Elichai Turkel: Replace coroutine with async def in p2p_invalid_messages.py
222 2020-01-16T09:58:19  <bitcoin-git> bitcoin/master 4e8b564 fanquake: Merge #17931: test: Fix p2p_invalid_messages failing in Python 3.8 because...
223 2020-01-16T09:58:20  *** bitcoin-git has left #bitcoin-core-dev
224 2020-01-16T09:58:39  *** marcoagner has joined #bitcoin-core-dev
225 2020-01-16T09:58:39  *** bitcoin-git has joined #bitcoin-core-dev
226 2020-01-16T09:58:39  <bitcoin-git> [bitcoin] fanquake merged pull request #17931: test: Fix p2p_invalid_messages failing in Python 3.8 because of warning (master...2020-01-coroutine) https://github.com/bitcoin/bitcoin/pull/17931
227 2020-01-16T09:58:50  *** bitcoin-git has left #bitcoin-core-dev
228 2020-01-16T10:02:03  *** turbo_choo has quit IRC
229 2020-01-16T10:02:23  *** turbo_choo has joined #bitcoin-core-dev
230 2020-01-16T10:03:48  *** Soligor has quit IRC
231 2020-01-16T10:04:23  *** kexkey has quit IRC
232 2020-01-16T10:08:30  *** Guyver2 has joined #bitcoin-core-dev
233 2020-01-16T10:09:57  *** jonatack has quit IRC
234 2020-01-16T10:10:54  *** Victorsueca has joined #bitcoin-core-dev
235 2020-01-16T10:11:17  *** EagleTM has quit IRC
236 2020-01-16T10:18:35  *** EagleTM has joined #bitcoin-core-dev
237 2020-01-16T10:19:09  *** AaronvanW has quit IRC
238 2020-01-16T10:20:34  *** jonatack has joined #bitcoin-core-dev
239 2020-01-16T10:21:36  *** EagleTM has quit IRC
240 2020-01-16T10:22:01  *** EagleTM has joined #bitcoin-core-dev
241 2020-01-16T10:29:12  *** timothy has joined #bitcoin-core-dev
242 2020-01-16T10:31:37  *** EagleTM has quit IRC
243 2020-01-16T10:34:35  <meshcollider> promag: will do, I'll have time tomorrow
244 2020-01-16T10:44:13  *** promag has quit IRC
245 2020-01-16T10:45:09  *** promag has joined #bitcoin-core-dev
246 2020-01-16T10:49:35  *** promag has quit IRC
247 2020-01-16T10:54:53  *** jonatack has quit IRC
248 2020-01-16T11:03:57  *** Gaylord25Block has joined #bitcoin-core-dev
249 2020-01-16T11:16:37  *** Gaylord25Block has quit IRC
250 2020-01-16T11:18:08  *** Guest83_ has joined #bitcoin-core-dev
251 2020-01-16T11:32:03  *** Victorsueca has quit IRC
252 2020-01-16T11:48:04  *** Guest83_ has quit IRC
253 2020-01-16T11:52:53  *** turbo_choo has quit IRC
254 2020-01-16T11:53:30  *** alec has quit IRC
255 2020-01-16T11:56:27  *** setpill has joined #bitcoin-core-dev
256 2020-01-16T11:56:50  *** marcoagner has quit IRC
257 2020-01-16T11:58:50  *** Soligor has joined #bitcoin-core-dev
258 2020-01-16T12:00:02  *** hali has quit IRC
259 2020-01-16T12:01:45  *** filchef has joined #bitcoin-core-dev
260 2020-01-16T12:08:16  *** filchef has quit IRC
261 2020-01-16T12:08:44  *** filchef has joined #bitcoin-core-dev
262 2020-01-16T12:10:45  *** AaronvanW has joined #bitcoin-core-dev
263 2020-01-16T12:10:48  *** sipa has quit IRC
264 2020-01-16T12:11:00  *** sipa has joined #bitcoin-core-dev
265 2020-01-16T12:14:45  *** jonatack has joined #bitcoin-core-dev
266 2020-01-16T12:15:38  *** AaronvanW has quit IRC
267 2020-01-16T12:17:16  *** kees1 has joined #bitcoin-core-dev
268 2020-01-16T12:24:07  *** AaronvanW has joined #bitcoin-core-dev
269 2020-01-16T12:32:46  *** turbo_choo has joined #bitcoin-core-dev
270 2020-01-16T12:41:22  *** Guyver2 has quit IRC
271 2020-01-16T12:49:54  *** jcoe has joined #bitcoin-core-dev
272 2020-01-16T12:54:41  *** filchef has quit IRC
273 2020-01-16T12:56:20  *** Kiminuo has joined #bitcoin-core-dev
274 2020-01-16T13:06:43  *** Skirmant has joined #bitcoin-core-dev
275 2020-01-16T13:07:11  *** Highway61 has joined #bitcoin-core-dev
276 2020-01-16T13:11:38  *** diogosergio has joined #bitcoin-core-dev
277 2020-01-16T13:11:55  *** Highway62 has joined #bitcoin-core-dev
278 2020-01-16T13:12:41  *** Highway61 has quit IRC
279 2020-01-16T13:12:41  *** Highway62 is now known as Highway61
280 2020-01-16T13:17:56  *** jonatack has quit IRC
281 2020-01-16T13:21:32  *** dviola has joined #bitcoin-core-dev
282 2020-01-16T13:27:49  <luke-jr> any objections to adding "don't rebase if you don't need to" to developer docs? :x
283 2020-01-16T13:29:07  <sipa> i think that's good advice
284 2020-01-16T13:29:31  *** hsmiths has joined #bitcoin-core-dev
285 2020-01-16T13:30:12  *** bitcoin-git has joined #bitcoin-core-dev
286 2020-01-16T13:30:12  <bitcoin-git> [bitcoin] Sjors opened pull request #17939: gui: Remove warning "unused variable 'wallet_model'" (master...2020/01/disable-wallet-unused-variable) https://github.com/bitcoin/bitcoin/pull/17939
287 2020-01-16T13:30:24  *** bitcoin-git has left #bitcoin-core-dev
288 2020-01-16T13:36:33  <wumpus> I don't think that's useful, in itself, the people doing rebases probably perceive it as needing to, what would be more useful is to list concretely when to rebase and when not
289 2020-01-16T13:38:03  *** emilengler has joined #bitcoin-core-dev
290 2020-01-16T13:38:15  <sipa> right; but i think it's easy to enumerate the cases when you need to: the PR no longer applies cleanly (=github complains) or (very rarely) a fresh merge succeeds but is incorrect
291 2020-01-16T13:38:18  <luke-jr> wumpus: sure, I was just being brief on IRC :p
292 2020-01-16T13:38:30  *** diogosergio has quit IRC
293 2020-01-16T13:38:47  <luke-jr> making sure others agreed before I went to the trouble to write up something
294 2020-01-16T13:38:57  <wumpus> ok, that makes sense
295 2020-01-16T13:39:30  <sipa> for a while i would rebase the whole PR any time i made any changs to it... which isn't very compatible with all review workflows
296 2020-01-16T13:40:05  <sipa> luke-jr: to be clear, by rebase you actually changing the base of the PR, not any invocation of the "git rebase" command
297 2020-01-16T13:40:16  <luke-jr> sipa: yes
298 2020-01-16T13:40:27  <sipa> in that case, agreed
299 2020-01-16T13:41:00  <luke-jr> I'll be clear that fixups and such are fine
300 2020-01-16T13:43:27  <wumpus> I usually rebase the PR for every change when the PR is new, to avoid 'messy' commits, but when there has been review, it's better to minimise rebases
301 2020-01-16T13:44:21  <sipa> right
302 2020-01-16T13:44:46  <wumpus> it really depends on the PR though, sometimes it is even requested by reviewers to split things into (atomic) commits
303 2020-01-16T13:45:01  <luke-jr> would be nice if more people would do daggy fixes too :x
304 2020-01-16T13:45:02  <wumpus> I think it's not very easy to enumerate in pracice
305 2020-01-16T13:45:17  <sipa> daggy?
306 2020-01-16T13:45:33  <luke-jr> sipa: bugfixes having a base of the commit introducing the bug, unless it makes problems
307 2020-01-16T13:46:12  <sipa> luke-jr: ugh, not a fan of that :)
308 2020-01-16T13:46:28  <luke-jr> no downsides, and it means it's a clean merge to all affected branches
309 2020-01-16T13:47:08  <wumpus> I'm not sure about that, and that's also too much to ask from most people I think regarding git skills
310 2020-01-16T13:47:16  <luke-jr> hmm
311 2020-01-16T13:47:47  <luke-jr> still, even if not in docs, would be nice to see people do it more ;)
312 2020-01-16T13:48:05  <sipa> luke-jr: i guess i haven't even noticed you doing that, which must mean i can't complain
313 2020-01-16T13:48:52  <luke-jr> usually the only thing noticable is my PR comment like "this is a clean merge to x, y, z" or such
314 2020-01-16T13:52:38  *** dr-orlovsky has quit IRC
315 2020-01-16T13:53:26  *** Skirmant has quit IRC
316 2020-01-16T13:56:39  *** bitcoin-git has joined #bitcoin-core-dev
317 2020-01-16T13:56:39  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4e8b564df0d4...a9c789ed964d
318 2020-01-16T13:56:40  <bitcoin-git> bitcoin/master 486f510 Harris: gui: hide HD & encryption icons when no wallet loaded
319 2020-01-16T13:56:40  <bitcoin-git> bitcoin/master a9c789e fanquake: Merge #17935: gui: hide HD & encryption icons when no wallet loaded
320 2020-01-16T13:56:42  *** bitcoin-git has left #bitcoin-core-dev
321 2020-01-16T13:56:59  *** bitcoin-git has joined #bitcoin-core-dev
322 2020-01-16T13:56:59  <bitcoin-git> [bitcoin] fanquake merged pull request #17935: gui: hide HD & encryption icons when no wallet loaded (master...hdwallet-icon-handling) https://github.com/bitcoin/bitcoin/pull/17935
323 2020-01-16T13:57:00  *** bitcoin-git has left #bitcoin-core-dev
324 2020-01-16T13:57:53  *** dr-orlovsky has joined #bitcoin-core-dev
325 2020-01-16T13:59:48  *** Highway62 has joined #bitcoin-core-dev
326 2020-01-16T14:00:29  *** Highway61 has quit IRC
327 2020-01-16T14:00:29  *** Highway62 is now known as Highway61
328 2020-01-16T14:19:36  *** Highway62 has joined #bitcoin-core-dev
329 2020-01-16T14:21:33  *** bitcoin-git has joined #bitcoin-core-dev
330 2020-01-16T14:21:33  <bitcoin-git> [bitcoin] luke-jr opened pull request #17940: doc: Rebasing, when and when not to do it (master...devnotes_rebasing) https://github.com/bitcoin/bitcoin/pull/17940
331 2020-01-16T14:21:34  *** bitcoin-git has left #bitcoin-core-dev
332 2020-01-16T14:21:39  *** Highway61 has quit IRC
333 2020-01-16T14:21:39  *** Highway62 is now known as Highway61
334 2020-01-16T14:22:58  *** Highway61 has quit IRC
335 2020-01-16T14:23:21  *** Highway61 has joined #bitcoin-core-dev
336 2020-01-16T14:25:37  *** spinza has quit IRC
337 2020-01-16T14:32:43  *** turbo_choo has quit IRC
338 2020-01-16T14:33:41  *** turbo_choo has joined #bitcoin-core-dev
339 2020-01-16T14:33:47  *** spinza has joined #bitcoin-core-dev
340 2020-01-16T14:51:14  *** bitcoin-git has joined #bitcoin-core-dev
341 2020-01-16T14:51:14  <bitcoin-git> [bitcoin] Sjors opened pull request #17941: depends: update to Boost 1.72 (master...2020/01/boost-bump) https://github.com/bitcoin/bitcoin/pull/17941
342 2020-01-16T14:51:15  *** bitcoin-git has left #bitcoin-core-dev
343 2020-01-16T15:00:01  *** kees1 has quit IRC
344 2020-01-16T15:12:49  *** Skirmant has joined #bitcoin-core-dev
345 2020-01-16T15:17:39  *** maop has joined #bitcoin-core-dev
346 2020-01-16T15:23:58  *** promag has joined #bitcoin-core-dev
347 2020-01-16T15:24:05  *** Kiminuo has quit IRC
348 2020-01-16T15:24:18  *** dviola has quit IRC
349 2020-01-16T15:26:19  *** Skirmant has quit IRC
350 2020-01-16T15:28:33  *** promag has quit IRC
351 2020-01-16T15:33:34  *** promag has joined #bitcoin-core-dev
352 2020-01-16T15:36:26  *** justan0theruser is now known as justanotheruser
353 2020-01-16T15:38:23  *** mdunnio has joined #bitcoin-core-dev
354 2020-01-16T15:38:36  *** Guyver2 has joined #bitcoin-core-dev
355 2020-01-16T16:04:09  *** paracyst has quit IRC
356 2020-01-16T16:05:08  *** paracyst has joined #bitcoin-core-dev
357 2020-01-16T16:05:57  *** jarthur has joined #bitcoin-core-dev
358 2020-01-16T16:28:27  *** promag has quit IRC
359 2020-01-16T16:29:40  *** promag has joined #bitcoin-core-dev
360 2020-01-16T16:34:02  *** turbo_choo has quit IRC
361 2020-01-16T16:35:39  <elichai2> meta question: free function vs methods?
362 2020-01-16T16:39:01  *** turbo_choo has joined #bitcoin-core-dev
363 2020-01-16T16:40:59  *** promag has quit IRC
364 2020-01-16T16:51:38  *** goatpig has quit IRC
365 2020-01-16T16:52:56  *** abrissbi1ne is now known as abrissbirne
366 2020-01-16T16:54:20  *** bitcoin-git has joined #bitcoin-core-dev
367 2020-01-16T16:54:20  <bitcoin-git> [bitcoin] fjahr opened pull request #17942: doc: Improve fuzzing docs for macOS users (master...fuzzing_docs) https://github.com/bitcoin/bitcoin/pull/17942
368 2020-01-16T16:54:21  *** bitcoin-git has left #bitcoin-core-dev
369 2020-01-16T16:56:13  *** Talkless has joined #bitcoin-core-dev
370 2020-01-16T17:02:28  *** hznc has joined #bitcoin-core-dev
371 2020-01-16T17:04:16  *** Talkless has quit IRC
372 2020-01-16T17:05:01  *** Talkless has joined #bitcoin-core-dev
373 2020-01-16T17:10:18  *** setpill has quit IRC
374 2020-01-16T17:25:20  *** filchef has joined #bitcoin-core-dev
375 2020-01-16T17:36:25  <wumpus> elichai2: if it needs to access properties or other methods of the class it should be a method, if it is a pure function the a function is better
376 2020-01-16T17:39:34  *** MrPaz has joined #bitcoin-core-dev
377 2020-01-16T17:49:02  *** luke-jr has quit IRC
378 2020-01-16T17:56:55  *** promag has joined #bitcoin-core-dev
379 2020-01-16T17:59:04  *** luke-jr has joined #bitcoin-core-dev
380 2020-01-16T18:00:01  *** maop has quit IRC
381 2020-01-16T18:01:47  <sipa> elichai2: functions are more composable
382 2020-01-16T18:02:24  <sipa> say you want to have some function that operates on a CTransaction, if you add it as a method, you're forcing every user of CTransaction to depend on your new code
383 2020-01-16T18:02:45  <sipa> as a free function, implemented where you need it (unless it's very fundamental) can avoid annoying dependency cycles
384 2020-01-16T18:02:51  <wumpus> also a good point
385 2020-01-16T18:03:03  <sipa> (^ my personal opinion, which not everyone always agrees with)
386 2020-01-16T18:11:39  *** goatpig has joined #bitcoin-core-dev
387 2020-01-16T18:15:03  <wumpus> I agree "is it fundamental" is the right question there
388 2020-01-16T18:15:40  <sipa> right, i guess the differences in opinion aren't so much the principle, but what people consider fundamental
389 2020-01-16T18:15:53  <wumpus> true
390 2020-01-16T18:17:20  *** sirkitree has joined #bitcoin-core-dev
391 2020-01-16T18:24:06  *** bitcoin-git has joined #bitcoin-core-dev
392 2020-01-16T18:24:06  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a9c789ed964d...f018d0c9cd7f
393 2020-01-16T18:24:07  <bitcoin-git> bitcoin/master 4b8f1e9 Gregory Sanders: IsUsedDestination shouldn't use key id as script id for ScriptHash
394 2020-01-16T18:24:07  <bitcoin-git> bitcoin/master 6dd59d2 Gregory Sanders: Don't allow implementers to think ScriptHash(Witness*()) results in nestin...
395 2020-01-16T18:24:08  <bitcoin-git> bitcoin/master f018d0c Wladimir J. van der Laan: Merge #17924: Bug: IsUsedDestination shouldn't use key id as script id for...
396 2020-01-16T18:24:09  *** bitcoin-git has left #bitcoin-core-dev
397 2020-01-16T18:24:26  *** bitcoin-git has joined #bitcoin-core-dev
398 2020-01-16T18:24:26  <bitcoin-git> [bitcoin] laanwj merged pull request #17924: Bug: IsUsedDestination shouldn't use key id as script id for ScriptHash (master...reuse_regression) https://github.com/bitcoin/bitcoin/pull/17924
399 2020-01-16T18:24:28  *** bitcoin-git has left #bitcoin-core-dev
400 2020-01-16T18:31:53  *** Highway61 has quit IRC
401 2020-01-16T18:33:43  *** promag has quit IRC
402 2020-01-16T18:52:19  *** bitcoin-git has joined #bitcoin-core-dev
403 2020-01-16T18:52:19  <bitcoin-git> [bitcoin] hebasto opened pull request #17943: qt, refactor: Remove never used default parameter (master...20200116-message-parameter) https://github.com/bitcoin/bitcoin/pull/17943
404 2020-01-16T18:52:29  *** bitcoin-git has left #bitcoin-core-dev
405 2020-01-16T18:58:51  *** jonatack has joined #bitcoin-core-dev
406 2020-01-16T19:00:20  <wumpus> #startmeeting
407 2020-01-16T19:00:20  <lightningbot> Meeting started Thu Jan 16 19:00:20 2020 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
408 2020-01-16T19:00:20  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
409 2020-01-16T19:00:25  <hebasto> hi
410 2020-01-16T19:00:25  <emilengler> hi
411 2020-01-16T19:00:26  <kanzure> hi
412 2020-01-16T19:00:27  <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr
413 2020-01-16T19:00:29  <wumpus> jeremyrubin lightlike emilengler jonatack hebasto jb55
414 2020-01-16T19:00:33  <jonatack> hi
415 2020-01-16T19:00:34  <achow101> hi
416 2020-01-16T19:00:43  <instagibbs> hi
417 2020-01-16T19:00:45  <sipa> hi
418 2020-01-16T19:00:49  <nehan_> hi
419 2020-01-16T19:00:51  <meshcollider> hi
420 2020-01-16T19:00:53  <fjahr> hi
421 2020-01-16T19:00:54  <wumpus> there have been no proposed topics in https://gist.github.com/moneyball/071d608fdae217c2a6d7c35955881d8a, any last minute proposals?
422 2020-01-16T19:00:54  <andytoshi> hi
423 2020-01-16T19:01:16  <adiabat> hi
424 2020-01-16T19:01:41  <jamesob> hi
425 2020-01-16T19:01:43  <wumpus> re: 0.19.1, we've made some progress, but there's still 3 PRs that need to be reviewed merged
426 2020-01-16T19:02:11  <wumpus> #topic High priority for review
427 2020-01-16T19:02:45  <wumpus> at the moment, 8 blockers, 3 bugfixes, 6 chasing concept ACK: https://github.com/bitcoin/bitcoin/projects/8
428 2020-01-16T19:03:06  <wumpus> the bugfixes are for 0.19 backport, and would be good to have in 0.19.1
429 2020-01-16T19:03:54  <sipa> what's blocking 0.19.1?
430 2020-01-16T19:04:10  <wumpus> #17897 definitely needs more review, by someone that understands the indexing code closely
431 2020-01-16T19:04:12  <gribble> https://github.com/bitcoin/bitcoin/issues/17897 | init: Stop indexes on shutdown after ChainStateFlushed callback. by jimpo · Pull Request #17897 · bitcoin/bitcoin · GitHub
432 2020-01-16T19:04:25  <jamesob> can I request we add #17737? as an aside, assumeutxo is in pretty good shape - I think it's got pretty broad concept ACK and the prototype branch seems to be working well. if I can get some help with review and testing, we might be able to `loadtxoutset` by the end of the year... and then we can start thinking about (and whether or not it's worth it) to propagate utxo snapshots through the p2p network
433 2020-01-16T19:04:29  <gribble> https://github.com/bitcoin/bitcoin/issues/17737 | Add ChainstateManager, remove BlockManager global by jamesob · Pull Request #17737 · bitcoin/bitcoin · GitHub
434 2020-01-16T19:04:35  <wumpus> sipa: #17897 #17892 and #17887
435 2020-01-16T19:04:37  <gribble> https://github.com/bitcoin/bitcoin/issues/17897 | init: Stop indexes on shutdown after ChainStateFlushed callback. by jimpo · Pull Request #17897 · bitcoin/bitcoin · GitHub
436 2020-01-16T19:04:39  <gribble> https://github.com/bitcoin/bitcoin/issues/17892 | bug-fix: delay flushing undo files until after they are finalized by kallewoof · Pull Request #17892 · bitcoin/bitcoin · GitHub
437 2020-01-16T19:04:40  <gribble> https://github.com/bitcoin/bitcoin/issues/17887 | bug-fix macos: give free bytes to F_PREALLOCATE by kallewoof · Pull Request #17887 · bitcoin/bitcoin · GitHub
438 2020-01-16T19:04:55  <wumpus> the latter two are to work around a macosx bug with preallocating files
439 2020-01-16T19:05:06  <sipa> ok, that doesn't look too daunting
440 2020-01-16T19:05:34  *** jcoe has quit IRC
441 2020-01-16T19:05:58  <wumpus> last week there seemed to be agreement that this was important for 0.19.1, I'm somewhat sceptical about working around an OS bug at our side, but they're not terrile backs
442 2020-01-16T19:06:13  <jamesob> I'll take a look at 17897
443 2020-01-16T19:06:38  <wumpus> jamesob: great to hear that assumeutxo is on the right track!
444 2020-01-16T19:06:49  *** promag has joined #bitcoin-core-dev
445 2020-01-16T19:07:13  <instagibbs> jamesob, is 15606 actually the "child" PR?
446 2020-01-16T19:07:29  <instagibbs> or mothership, I dunno
447 2020-01-16T19:07:39  <jamesob> instagibbs: yep
448 2020-01-16T19:07:46  <jamesob> more mothership than child
449 2020-01-16T19:08:01  <jamesob> but all the assumeutxo code is there
450 2020-01-16T19:08:14  <wumpus> added 17737
451 2020-01-16T19:08:19  <instagibbs> cool, will review
452 2020-01-16T19:08:33  <wumpus> please also review #16702, it seems to be pretty close to mergable
453 2020-01-16T19:08:38  <gribble> https://github.com/bitcoin/bitcoin/issues/16702 | p2p: supplying and using asmap to improve IP bucketing in addrman by naumenkogs · Pull Request #16702 · bitcoin/bitcoin · GitHub
454 2020-01-16T19:09:06  <jamesob> instagibbs: thanks! recent utxo snapshots for testing are available here: https://github.com/bitcoin/bitcoin/pull/15606#issuecomment-555213164
455 2020-01-16T19:09:08  <sipa> #17896 is close too, i think
456 2020-01-16T19:09:10  <gribble> https://github.com/bitcoin/bitcoin/issues/17896 | Serialization improvements (step 2) by sipa · Pull Request #17896 · bitcoin/bitcoin · GitHub
457 2020-01-16T19:09:38  <jnewbery> hi
458 2020-01-16T19:10:08  <wumpus> sipa: ah yes, clearly
459 2020-01-16T19:11:29  <wumpus> the review load is extremely high as usual :)
460 2020-01-16T19:11:31  <jnewbery> #suggestedtopic Bitcoin Core contributor survey
461 2020-01-16T19:11:50  <wumpus> #topic Bitcoin Core contributor survey (jnewbery)
462 2020-01-16T19:11:57  <jnewbery> Thanks wumpus!
463 2020-01-16T19:12:10  <jnewbery> we're having our next coredev irl meeting soonish
464 2020-01-16T19:12:19  <promag> hi
465 2020-01-16T19:12:45  <jnewbery> I'm going to send around a few questions to active contributors before the meeting, and then present the summary at the coredev meeting
466 2020-01-16T19:13:09  <kanzure> regarding that meeting, i plan to once again collect topics (or maybe someone else will)- so send topic proposals that you'd like to see discussed or that you would like to discuss yourself
467 2020-01-16T19:13:19  <jnewbery> so expect that in your inbox soon. It shouldn't take too long to fill out
468 2020-01-16T19:13:38  <jnewbery> that's all I had. Feel free to message me if you have any questions or thoughts about that
469 2020-01-16T19:13:42  <kanzure> is this meeting related or bitcoin core contributor quality of life questions?
470 2020-01-16T19:13:46  <wumpus> ok, good to know
471 2020-01-16T19:14:22  <jnewbery> kanzure: a bit of both. Trying to find out what people's priorities are and if they have any suggestions about the Bitcoin Core process, and then we can talk about them at the meeting
472 2020-01-16T19:14:29  <kanzure> cool. makes sense.
473 2020-01-16T19:15:30  <kanzure> maybe add some topic-collection questions too so i can minimize my workload :) not required though!
474 2020-01-16T19:15:52  <luke-jr> hi
475 2020-01-16T19:16:05  <luke-jr> jnewbery: do you want those of us who won't make it to do the survey?
476 2020-01-16T19:16:47  <jnewbery> yes please! Looking for input from anyone who's active in the project.
477 2020-01-16T19:17:07  <jnewbery> kanzure: good idea. I'll add a topic-collection question and share results with you
478 2020-01-16T19:17:52  <kanzure> thank you
479 2020-01-16T19:17:53  <wumpus> thanks jnewbery
480 2020-01-16T19:18:49  <wumpus> any other topics for today?
481 2020-01-16T19:20:35  <wumpus> ok, have a good week then everyone, hope we can get some more of the high priority PRs merged
482 2020-01-16T19:20:40  <wumpus> #endmeeting
483 2020-01-16T19:20:40  <lightningbot> Meeting ended Thu Jan 16 19:20:40 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
484 2020-01-16T19:20:40  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-01-16-19.00.html
485 2020-01-16T19:20:40  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-01-16-19.00.txt
486 2020-01-16T19:20:40  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-01-16-19.00.log.html
487 2020-01-16T19:21:15  <instagibbs> boxing the wallet is very close :)
488 2020-01-16T19:21:19  <kanzure> anyone should feel free to pm/email me topic ideas for physical meeting. i was just thinking that something about fuzzing would be a fun topic....
489 2020-01-16T19:21:42  <kanzure> (or the mutation testing technique for that matter.)
490 2020-01-16T19:22:37  <luke-jr> jnewbery: btw, by soon just how soon do you mean?
491 2020-01-16T19:22:57  <instagibbs> oh, I missed the pr review club on fuzzing. :( i even did my homework
492 2020-01-16T19:23:29  <jonatack> wallet meeting tomorrow, yes?
493 2020-01-16T19:23:46  <instagibbs> jonatack, yep
494 2020-01-16T19:25:42  <instagibbs> MarcoFalke, Seems like no one figured out how to run `test_runner.py` for the fuzzer?
495 2020-01-16T19:25:51  <instagibbs> at least in pr club notes
496 2020-01-16T19:30:07  <jonatack> instagibbs: nope. still trying to catch the bad-txns-inputs-duplicate cve with that fuzz test PR and the check removed from CheckTransaction().
497 2020-01-16T19:35:09  *** emilengler has quit IRC
498 2020-01-16T19:40:56  *** Highway61 has joined #bitcoin-core-dev
499 2020-01-16T19:45:52  *** DeanGuss has quit IRC
500 2020-01-16T19:46:09  *** DeanGuss has joined #bitcoin-core-dev
501 2020-01-16T19:54:43  *** Highway61 has quit IRC
502 2020-01-16T19:55:47  <instagibbs> I ran it overnight and decided it wasn't getting enough runs per second to be worth it for me
503 2020-01-16T20:01:05  *** promag has quit IRC
504 2020-01-16T20:05:53  *** Talkless has quit IRC
505 2020-01-16T20:08:11  *** hznc has quit IRC
506 2020-01-16T20:13:08  *** timothy has quit IRC
507 2020-01-16T20:15:23  *** goatpig has quit IRC
508 2020-01-16T20:17:32  *** owowo has quit IRC
509 2020-01-16T20:18:31  *** Highway61 has joined #bitcoin-core-dev
510 2020-01-16T20:22:57  <MarcoFalke> instagibbs: The test_runner is mostly for travis
511 2020-01-16T20:23:10  <MarcoFalke> It is meant to run over existing seeds
512 2020-01-16T20:23:21  <MarcoFalke> Not really meant to create new inputs
513 2020-01-16T20:24:39  *** Kiminuo has joined #bitcoin-core-dev
514 2020-01-16T20:24:41  *** owowo has joined #bitcoin-core-dev
515 2020-01-16T20:25:49  *** bitcoin-git has joined #bitcoin-core-dev
516 2020-01-16T20:25:50  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f018d0c9cd7f...218274de7d1f
517 2020-01-16T20:25:50  <bitcoin-git> bitcoin/master 42ec499 Jon Atack: doc: developer notes guideline on RPCExamples addresses
518 2020-01-16T20:25:51  <bitcoin-git> bitcoin/master 218274d MarcoFalke: Merge #17819: doc: developer notes guideline on RPCExamples addresses
519 2020-01-16T20:25:53  *** bitcoin-git has left #bitcoin-core-dev
520 2020-01-16T20:26:09  *** bitcoin-git has joined #bitcoin-core-dev
521 2020-01-16T20:26:09  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17819: doc: developer notes guideline on RPCExamples addresses (master...rpc-examples-use-invalid-addresses) https://github.com/bitcoin/bitcoin/pull/17819
522 2020-01-16T20:26:10  *** bitcoin-git has left #bitcoin-core-dev
523 2020-01-16T20:36:14  *** Highway61 has quit IRC
524 2020-01-16T20:38:06  *** jeremyrubin has joined #bitcoin-core-dev
525 2020-01-16T20:43:45  *** bitcoin-git has joined #bitcoin-core-dev
526 2020-01-16T20:43:45  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/218274de7d1f...ec9b964cc998
527 2020-01-16T20:43:46  <bitcoin-git> bitcoin/master 1be0b1f Sebastian Falbesoner: test: add functional test for non-standard bare multisig txs
528 2020-01-16T20:43:47  <bitcoin-git> bitcoin/master ec9b964 MarcoFalke: Merge #17541: test: add functional test for non-standard bare multisig txs...
529 2020-01-16T20:43:48  *** bitcoin-git has left #bitcoin-core-dev
530 2020-01-16T20:44:15  *** bitcoin-git has joined #bitcoin-core-dev
531 2020-01-16T20:44:15  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17541: test: add functional test for non-standard bare multisig txs (master...20191120-test-for-bare-multisig-in-mempool_accept) https://github.com/bitcoin/bitcoin/pull/17541
532 2020-01-16T20:44:16  *** bitcoin-git has left #bitcoin-core-dev
533 2020-01-16T20:44:59  *** rex4539 has joined #bitcoin-core-dev
534 2020-01-16T20:44:59  <jnewbery> luke-jr: today or tomorrow
535 2020-01-16T20:49:02  *** bitcoin-git has joined #bitcoin-core-dev
536 2020-01-16T20:49:02  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ec9b964cc998...2aaeca50b22d
537 2020-01-16T20:49:03  <bitcoin-git> bitcoin/master ef63f5f Sebastian Falbesoner: ci: Combine 32-bit build with CentOS 7 build
538 2020-01-16T20:49:03  <bitcoin-git> bitcoin/master 2aaeca5 MarcoFalke: Merge #17900: ci: Combine 32-bit build with CentOS 7 build
539 2020-01-16T20:49:05  *** bitcoin-git has left #bitcoin-core-dev
540 2020-01-16T20:49:21  *** bitcoin-git has joined #bitcoin-core-dev
541 2020-01-16T20:49:21  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17900: ci: Combine 32-bit build with CentOS 7 build (master...20200108-ci-add-32-bit-centos-build) https://github.com/bitcoin/bitcoin/pull/17900
542 2020-01-16T20:49:22  *** bitcoin-git has left #bitcoin-core-dev
543 2020-01-16T20:54:04  *** bitcoin-git has joined #bitcoin-core-dev
544 2020-01-16T20:54:04  <bitcoin-git> [bitcoin] dongcarl opened pull request #17944: netaddress: Simplify reachability logic (master...2020-01-simplify-reachability) https://github.com/bitcoin/bitcoin/pull/17944
545 2020-01-16T20:54:05  *** bitcoin-git has left #bitcoin-core-dev
546 2020-01-16T20:57:37  *** Highway61 has joined #bitcoin-core-dev
547 2020-01-16T21:00:02  *** sirkitree has quit IRC
548 2020-01-16T21:00:47  *** bitcoin-git has joined #bitcoin-core-dev
549 2020-01-16T21:00:47  <bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/2aaeca50b22d...95ca6aeec7b8
550 2020-01-16T21:00:48  <bitcoin-git> bitcoin/master 071f2fc Hennadii Stepanov: script: Add ability to insert copyright to *.sh
551 2020-01-16T21:00:48  <bitcoin-git> bitcoin/master 1998152 Hennadii Stepanov: script: Add empty line after C++ copyright
552 2020-01-16T21:00:49  <bitcoin-git> bitcoin/master 6fde9d5 Hennadii Stepanov: script: Update EXLUDE list in copyright_header.py
553 2020-01-16T21:00:55  *** bitcoin-git has left #bitcoin-core-dev
554 2020-01-16T21:01:11  *** bitcoin-git has joined #bitcoin-core-dev
555 2020-01-16T21:01:11  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17691: doc: Add missed copyright headers (master...20191207-copyright-headers) https://github.com/bitcoin/bitcoin/pull/17691
556 2020-01-16T21:01:12  *** bitcoin-git has left #bitcoin-core-dev
557 2020-01-16T21:08:34  *** Highway62 has joined #bitcoin-core-dev
558 2020-01-16T21:08:43  *** Highway61 has quit IRC
559 2020-01-16T21:08:43  *** Highway62 is now known as Highway61
560 2020-01-16T21:10:06  <luke-jr> jnewbery: I mean the coredev.tech IRL meetup
561 2020-01-16T21:13:23  *** promag has joined #bitcoin-core-dev
562 2020-01-16T21:19:55  *** promag has quit IRC
563 2020-01-16T21:29:48  *** Guyver2_ has joined #bitcoin-core-dev
564 2020-01-16T21:31:51  *** Guyver2_ has quit IRC
565 2020-01-16T21:33:03  *** Guyver2 has quit IRC
566 2020-01-16T21:33:28  <jamesob> man my logs are packed with `Feeding [x] bytes of dynamic environment data into RNG`. wonder if we should move that to a debug level.
567 2020-01-16T21:35:33  *** MrPaz has quit IRC
568 2020-01-16T21:36:39  <sipa> jamesob: update master
569 2020-01-16T21:37:01  <jamesob> ah, testing a branch.
570 2020-01-16T21:38:20  <jonatack> jamesob: pull in commit 0ccad08
571 2020-01-16T21:38:37  <jamesob> jonatack: thanks
572 2020-01-16T21:40:43  *** vasild has quit IRC
573 2020-01-16T21:42:42  *** vasild has joined #bitcoin-core-dev
574 2020-01-16T21:46:52  *** reeiiko has joined #bitcoin-core-dev
575 2020-01-16T21:49:24  *** rex4539 has quit IRC
576 2020-01-16T22:04:00  *** jb55 has quit IRC
577 2020-01-16T22:05:44  *** filchef has quit IRC
578 2020-01-16T22:18:39  *** jeremyrubin has quit IRC
579 2020-01-16T22:25:54  *** cryptapus has quit IRC
580 2020-01-16T22:27:14  *** cryptapus has joined #bitcoin-core-dev
581 2020-01-16T22:27:14  *** cryptapus has joined #bitcoin-core-dev
582 2020-01-16T22:28:21  *** Zenton has quit IRC
583 2020-01-16T22:37:28  *** tryphe has quit IRC
584 2020-01-16T22:49:27  *** swamp has joined #bitcoin-core-dev
585 2020-01-16T22:55:37  *** jb55 has joined #bitcoin-core-dev
586 2020-01-16T22:59:51  *** tryphe has joined #bitcoin-core-dev
587 2020-01-16T23:08:46  *** SiAnDoG_ has joined #bitcoin-core-dev
588 2020-01-16T23:16:13  *** MrPaz has joined #bitcoin-core-dev
589 2020-01-16T23:16:53  *** hex17or has quit IRC
590 2020-01-16T23:17:27  *** justanotheruser has quit IRC
591 2020-01-16T23:20:33  *** promag has joined #bitcoin-core-dev
592 2020-01-16T23:21:06  *** justanotheruser has joined #bitcoin-core-dev
593 2020-01-16T23:21:59  *** mdunnio has quit IRC
594 2020-01-16T23:24:12  *** ossifrage has quit IRC
595 2020-01-16T23:25:08  *** promag has quit IRC
596 2020-01-16T23:27:06  *** pinheadmz has quit IRC
597 2020-01-16T23:43:11  *** ossifrage has joined #bitcoin-core-dev
598 2020-01-16T23:51:54  *** jarthur has quit IRC
599 2020-01-16T23:58:10  <meshcollider> yep let's have the first wallet meeting of 2020 tomorrow for those who want to attend :)
600 2020-01-16T23:59:25  <fanquake> #tooearlyinthemorning