1 2020-01-22T00:00:01  *** smtx has quit IRC
  2 2020-01-22T00:02:45  *** promag has joined #bitcoin-core-dev
  3 2020-01-22T00:16:26  *** bitcoin-git has joined #bitcoin-core-dev
  4 2020-01-22T00:16:26  <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/631df3ee87ec...742f84d0de79
  5 2020-01-22T00:16:27  <bitcoin-git> bitcoin/master e3b19d8 Gregory Sanders: QT: bump fee returns PSBT on clipboard for watchonly-only wallets
  6 2020-01-22T00:16:27  <bitcoin-git> bitcoin/master 3c30d71 Gregory Sanders: QT: Change bumpFee asserts to simple error message
  7 2020-01-22T00:16:28  <bitcoin-git> bitcoin/master 742f84d fanquake: Merge #17492: QT: bump fee returns PSBT on clipboard for watchonly-only wa...
  8 2020-01-22T00:16:29  *** bitcoin-git has left #bitcoin-core-dev
  9 2020-01-22T00:17:01  *** bitcoin-git has joined #bitcoin-core-dev
 10 2020-01-22T00:17:01  <bitcoin-git> [bitcoin] fanquake merged pull request #17492: QT: bump fee returns PSBT on clipboard for watchonly-only wallets (master...gui_bump_psbt) https://github.com/bitcoin/bitcoin/pull/17492
 11 2020-01-22T00:17:02  *** bitcoin-git has left #bitcoin-core-dev
 12 2020-01-22T00:19:09  *** fox2p has quit IRC
 13 2020-01-22T00:20:22  *** fox2p has joined #bitcoin-core-dev
 14 2020-01-22T00:21:23  *** jcoe has quit IRC
 15 2020-01-22T00:23:49  *** BGL has joined #bitcoin-core-dev
 16 2020-01-22T00:25:19  *** promag has quit IRC
 17 2020-01-22T00:44:15  *** turbo_choo has quit IRC
 18 2020-01-22T00:45:49  *** Hellaenergy has joined #bitcoin-core-dev
 19 2020-01-22T00:56:43  *** alec has quit IRC
 20 2020-01-22T00:57:16  *** SiAnDoG_ has joined #bitcoin-core-dev
 21 2020-01-22T00:58:40  *** alec has joined #bitcoin-core-dev
 22 2020-01-22T00:59:23  *** SiAnDoG__ has quit IRC
 23 2020-01-22T02:02:15  *** kristapsk has joined #bitcoin-core-dev
 24 2020-01-22T02:15:05  *** vasild has quit IRC
 25 2020-01-22T02:15:16  *** vasild has joined #bitcoin-core-dev
 26 2020-01-22T02:36:23  *** willcl_ark has quit IRC
 27 2020-01-22T02:38:45  *** willcl_ark has joined #bitcoin-core-dev
 28 2020-01-22T02:54:23  *** mryandao has quit IRC
 29 2020-01-22T02:55:03  *** DeanWeen has quit IRC
 30 2020-01-22T02:55:23  *** morcos has quit IRC
 31 2020-01-22T02:55:23  *** mfoolb has quit IRC
 32 2020-01-22T02:55:43  *** sipa has quit IRC
 33 2020-01-22T02:56:03  *** vasild has quit IRC
 34 2020-01-22T02:56:03  *** alec has quit IRC
 35 2020-01-22T02:56:03  *** SiAnDoG_ has quit IRC
 36 2020-01-22T02:56:04  *** jb55 has quit IRC
 37 2020-01-22T02:56:04  *** ghost43 has quit IRC
 38 2020-01-22T02:56:04  *** sdaftuar has quit IRC
 39 2020-01-22T02:56:23  *** kristapsk has quit IRC
 40 2020-01-22T02:56:23  *** afk11 has quit IRC
 41 2020-01-22T02:56:23  *** braydonf has quit IRC
 42 2020-01-22T02:59:45  *** jonasschnelli has quit IRC
 43 2020-01-22T03:00:02  *** Hellaenergy has quit IRC
 44 2020-01-22T03:00:59  *** abrissbirne has joined #bitcoin-core-dev
 45 2020-01-22T03:04:28  *** abrissbi1ne has quit IRC
 46 2020-01-22T03:10:44  *** braydonf has joined #bitcoin-core-dev
 47 2020-01-22T03:11:40  *** sipa has joined #bitcoin-core-dev
 48 2020-01-22T03:11:47  *** jonasschnelli has joined #bitcoin-core-dev
 49 2020-01-22T03:12:05  *** mryandao has joined #bitcoin-core-dev
 50 2020-01-22T03:12:13  *** Highway61 has quit IRC
 51 2020-01-22T03:12:35  *** ghost43 has joined #bitcoin-core-dev
 52 2020-01-22T03:12:36  *** mfoolb has joined #bitcoin-core-dev
 53 2020-01-22T03:12:59  *** alec has joined #bitcoin-core-dev
 54 2020-01-22T03:13:04  *** vasild has joined #bitcoin-core-dev
 55 2020-01-22T03:13:30  *** sdaftuar has joined #bitcoin-core-dev
 56 2020-01-22T03:13:56  *** afk11 has joined #bitcoin-core-dev
 57 2020-01-22T03:15:10  *** jb55 has joined #bitcoin-core-dev
 58 2020-01-22T03:16:36  *** davterra has joined #bitcoin-core-dev
 59 2020-01-22T03:17:13  *** FunPika has joined #bitcoin-core-dev
 60 2020-01-22T03:17:51  *** AaronvanW has quit IRC
 61 2020-01-22T03:23:44  *** morcos has joined #bitcoin-core-dev
 62 2020-01-22T03:56:32  *** AaronvanW has joined #bitcoin-core-dev
 63 2020-01-22T03:57:57  *** felixfoertsch23 has joined #bitcoin-core-dev
 64 2020-01-22T03:59:43  *** felixfoertsch has quit IRC
 65 2020-01-22T04:01:18  *** AaronvanW has quit IRC
 66 2020-01-22T04:24:17  *** Eagle[TM] has joined #bitcoin-core-dev
 67 2020-01-22T04:25:03  *** EagleTM has quit IRC
 68 2020-01-22T04:31:29  *** AaronvanW has joined #bitcoin-core-dev
 69 2020-01-22T04:48:00  *** volbil has joined #bitcoin-core-dev
 70 2020-01-22T05:04:18  *** AaronvanW has quit IRC
 71 2020-01-22T05:07:32  *** ctrlbreak has quit IRC
 72 2020-01-22T05:07:57  *** ctrlbreak has joined #bitcoin-core-dev
 73 2020-01-22T05:20:26  *** davec_ has quit IRC
 74 2020-01-22T05:28:26  *** davec has joined #bitcoin-core-dev
 75 2020-01-22T05:38:38  *** brianhoffman_ has joined #bitcoin-core-dev
 76 2020-01-22T05:41:48  *** brianhoffman has quit IRC
 77 2020-01-22T05:41:49  *** brianhoffman_ is now known as brianhoffman
 78 2020-01-22T05:50:41  *** dongcarl6 has joined #bitcoin-core-dev
 79 2020-01-22T05:52:08  *** dongcarl has quit IRC
 80 2020-01-22T05:52:09  *** dongcarl6 is now known as dongcarl
 81 2020-01-22T06:00:01  *** FunPika has quit IRC
 82 2020-01-22T06:17:11  *** kenperkins has joined #bitcoin-core-dev
 83 2020-01-22T06:38:47  *** turbo_choo has joined #bitcoin-core-dev
 84 2020-01-22T06:59:29  *** Highway61 has joined #bitcoin-core-dev
 85 2020-01-22T07:01:10  *** AaronvanW has joined #bitcoin-core-dev
 86 2020-01-22T07:13:31  *** Eagle[TM] has quit IRC
 87 2020-01-22T07:34:26  *** AaronvanW has quit IRC
 88 2020-01-22T07:38:52  *** Soligor has quit IRC
 89 2020-01-22T07:47:11  *** Soligor has joined #bitcoin-core-dev
 90 2020-01-22T08:01:07  *** commavir has quit IRC
 91 2020-01-22T08:01:33  *** commavir has joined #bitcoin-core-dev
 92 2020-01-22T08:05:53  *** real_or_random has quit IRC
 93 2020-01-22T08:09:46  *** real_or_random has joined #bitcoin-core-dev
 94 2020-01-22T08:15:24  *** bitcoin-git has joined #bitcoin-core-dev
 95 2020-01-22T08:15:24  <bitcoin-git> [bitcoin] kallewoof opened pull request #17980: test: add missing #include to fix compiler errors (master...200122-tests-cuckoo-dequeue) https://github.com/bitcoin/bitcoin/pull/17980
 96 2020-01-22T08:15:25  *** bitcoin-git has left #bitcoin-core-dev
 97 2020-01-22T08:17:41  *** goatpig has joined #bitcoin-core-dev
 98 2020-01-22T08:19:04  *** timothy has joined #bitcoin-core-dev
 99 2020-01-22T08:27:58  <fanquake> kallewoof: hopefully the fix is that simple!
100 2020-01-22T08:28:36  <kallewoof> fanquake: we'll know in half an hour or so :)
101 2020-01-22T08:42:40  *** volbil has quit IRC
102 2020-01-22T08:49:06  *** turbo_choo has quit IRC
103 2020-01-22T08:54:54  *** timothy has quit IRC
104 2020-01-22T09:00:02  *** kenperkins has quit IRC
105 2020-01-22T09:02:25  *** timothy has joined #bitcoin-core-dev
106 2020-01-22T09:05:48  *** promag has joined #bitcoin-core-dev
107 2020-01-22T09:08:44  <fanquake> kallewoof: looks good. Has made it through to the functional tests. Wanna update the PR to mention it closes #17976.
108 2020-01-22T09:08:46  <gribble> https://github.com/bitcoin/bitcoin/issues/17976 | Appveyor ci fails again · Issue #17976 · bitcoin/bitcoin · GitHub
109 2020-01-22T09:09:09  <kallewoof> Oh, yeah okay
110 2020-01-22T09:09:10  <kallewoof> Nice
111 2020-01-22T09:09:29  <kallewoof> Done
112 2020-01-22T09:09:42  <fanquake> :thu
113 2020-01-22T09:09:48  <fanquake> 👍
114 2020-01-22T09:12:34  *** timothy has quit IRC
115 2020-01-22T09:16:12  *** AaronvanW has joined #bitcoin-core-dev
116 2020-01-22T09:17:17  *** tonsofpcs1 has joined #bitcoin-core-dev
117 2020-01-22T09:25:44  *** bitcoin-git has joined #bitcoin-core-dev
118 2020-01-22T09:25:45  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/742f84d0de79...e45463a06abe
119 2020-01-22T09:25:45  <bitcoin-git> bitcoin/master a5a2654 Karl-Johan Alm: test: add missing #include to fix compiler errors
120 2020-01-22T09:25:45  <bitcoin-git> bitcoin/master e45463a fanquake: Merge #17980: test: add missing #include to fix compiler errors
121 2020-01-22T09:25:47  *** bitcoin-git has left #bitcoin-core-dev
122 2020-01-22T09:26:04  *** bitcoin-git has joined #bitcoin-core-dev
123 2020-01-22T09:26:04  <bitcoin-git> [bitcoin] fanquake merged pull request #17980: test: add missing #include to fix compiler errors (master...200122-tests-cuckoo-dequeue) https://github.com/bitcoin/bitcoin/pull/17980
124 2020-01-22T09:26:06  *** bitcoin-git has left #bitcoin-core-dev
125 2020-01-22T09:32:40  *** turbo_choo has joined #bitcoin-core-dev
126 2020-01-22T09:33:40  *** bitcoin-git has joined #bitcoin-core-dev
127 2020-01-22T09:33:40  <bitcoin-git> [bitcoin] giulio92 opened pull request #17981: Docs: Improve release-process.md formatting (master...release-process-formatting) https://github.com/bitcoin/bitcoin/pull/17981
128 2020-01-22T09:33:41  *** bitcoin-git has left #bitcoin-core-dev
129 2020-01-22T09:36:50  *** Guyver2 has joined #bitcoin-core-dev
130 2020-01-22T09:41:43  *** vasild has quit IRC
131 2020-01-22T09:43:07  *** bitcoin-git has joined #bitcoin-core-dev
132 2020-01-22T09:43:07  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e45463a06abe...a51aa2880d12
133 2020-01-22T09:43:08  <bitcoin-git> bitcoin/master 9dd58ca Jim Posen: init: Stop indexes on shutdown after ChainStateFlushed callback.
134 2020-01-22T09:43:09  <bitcoin-git> bitcoin/master a51aa28 fanquake: Merge #17897: init: Stop indexes on shutdown after ChainStateFlushed callb...
135 2020-01-22T09:43:10  *** bitcoin-git has left #bitcoin-core-dev
136 2020-01-22T09:43:22  *** bitcoin-git has joined #bitcoin-core-dev
137 2020-01-22T09:43:22  <bitcoin-git> [bitcoin] fanquake merged pull request #17897: init: Stop indexes on shutdown after ChainStateFlushed callback. (master...index-commit) https://github.com/bitcoin/bitcoin/pull/17897
138 2020-01-22T09:43:24  *** bitcoin-git has left #bitcoin-core-dev
139 2020-01-22T09:43:38  *** vasild has joined #bitcoin-core-dev
140 2020-01-22T09:52:09  *** AaronvanW has quit IRC
141 2020-01-22T09:52:25  *** AaronvanW has joined #bitcoin-core-dev
142 2020-01-22T10:04:15  *** bitcoin-git has joined #bitcoin-core-dev
143 2020-01-22T10:04:15  <bitcoin-git> [bitcoin] fanquake pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/98159132c3e7...9d980c1f7f6f
144 2020-01-22T10:04:15  <bitcoin-git> bitcoin/0.19 9d980c1 Jim Posen: init: Stop indexes on shutdown after ChainStateFlushed callback.
145 2020-01-22T10:04:17  *** bitcoin-git has left #bitcoin-core-dev
146 2020-01-22T10:10:23  *** EagleTM has joined #bitcoin-core-dev
147 2020-01-22T10:11:56  *** bitcoin-git has joined #bitcoin-core-dev
148 2020-01-22T10:11:56  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/9d980c1f7f6f...4cf73504220e
149 2020-01-22T10:11:56  <bitcoin-git> bitcoin/0.19 4cf7350 Wladimir J. van der Laan: Merge branch '0.19_2' into 0.19
150 2020-01-22T10:11:58  *** bitcoin-git has left #bitcoin-core-dev
151 2020-01-22T10:17:17  *** timothy has joined #bitcoin-core-dev
152 2020-01-22T10:19:05  *** jcoe has joined #bitcoin-core-dev
153 2020-01-22T10:20:27  <fanquake> In case anyone is wondering what has just happened; I had a lapse of concentration while preparing commits for backport (planning on cherry-picking to a branch and opening a PR), and accidentally pushed 9d980c1f7f6fd0eb686d3cc94ba4698547f151c2 straight to the 0.19 branch. wumpus has pushed 4cf73504220e95ea1c4961509ea757ce6d393a9b as a followup to 0.19 to add a Tree-SHA512 hash.
154 2020-01-22T10:23:14  *** jcoe has quit IRC
155 2020-01-22T10:23:43  <kallewoof> Now that you mention it it did look kinda odd. I just assumed it ws because it wasn't master. :)
156 2020-01-22T10:31:37  *** AaronvanW has quit IRC
157 2020-01-22T10:39:03  *** jcoe has joined #bitcoin-core-dev
158 2020-01-22T10:56:41  <wumpus> we kept it as it was as it's a good backport, avoiding the need to do a force-push
159 2020-01-22T11:03:54  *** Adan11Smitham has joined #bitcoin-core-dev
160 2020-01-22T11:04:10  <kallewoof> FTR, verified the backport matches the original.
161 2020-01-22T11:08:52  *** Adan11Smitham has quit IRC
162 2020-01-22T11:11:58  *** timothy has quit IRC
163 2020-01-22T11:24:04  *** promag has quit IRC
164 2020-01-22T11:42:54  *** AaronvanW has joined #bitcoin-core-dev
165 2020-01-22T11:44:04  *** Chris_Stewart_5 has joined #bitcoin-core-dev
166 2020-01-22T11:44:49  *** promag has joined #bitcoin-core-dev
167 2020-01-22T11:49:26  *** promag has quit IRC
168 2020-01-22T11:49:43  *** promag has joined #bitcoin-core-dev
169 2020-01-22T12:00:01  *** tonsofpcs1 has quit IRC
170 2020-01-22T12:08:59  *** Guyver2_ has joined #bitcoin-core-dev
171 2020-01-22T12:09:39  *** jonatack has quit IRC
172 2020-01-22T12:12:03  *** Guyver2 has quit IRC
173 2020-01-22T12:14:26  *** AaronvanW has quit IRC
174 2020-01-22T12:17:14  *** ermau has joined #bitcoin-core-dev
175 2020-01-22T12:18:51  *** gfgdfgdfg4 has joined #bitcoin-core-dev
176 2020-01-22T12:20:52  *** turbo_choo has quit IRC
177 2020-01-22T12:22:35  *** gfgdfgdfg4 has joined #bitcoin-core-dev
178 2020-01-22T12:29:12  *** timothy has joined #bitcoin-core-dev
179 2020-01-22T12:30:00  *** gfgdfgdfg4 has quit IRC
180 2020-01-22T12:30:40  *** ddustin has joined #bitcoin-core-dev
181 2020-01-22T12:31:12  *** gfgdfgdfg4 has joined #bitcoin-core-dev
182 2020-01-22T12:32:45  *** gfgdfgdfg4 has quit IRC
183 2020-01-22T12:35:40  *** ddustin has quit IRC
184 2020-01-22T12:38:13  *** jcoe has quit IRC
185 2020-01-22T12:38:33  *** jonatack has joined #bitcoin-core-dev
186 2020-01-22T12:39:32  *** timothy has quit IRC
187 2020-01-22T12:39:44  *** filchef has joined #bitcoin-core-dev
188 2020-01-22T12:42:11  *** promag has quit IRC
189 2020-01-22T12:47:13  *** emilengler has joined #bitcoin-core-dev
190 2020-01-22T13:01:09  *** Guyver2__ has joined #bitcoin-core-dev
191 2020-01-22T13:03:03  *** Guyver2_ has quit IRC
192 2020-01-22T13:05:13  *** Eagle[TM] has joined #bitcoin-core-dev
193 2020-01-22T13:05:27  *** EagleTM has quit IRC
194 2020-01-22T13:09:51  *** zivl has quit IRC
195 2020-01-22T13:26:48  *** promag has joined #bitcoin-core-dev
196 2020-01-22T13:31:21  *** promag has quit IRC
197 2020-01-22T13:47:15  *** kristapsk has joined #bitcoin-core-dev
198 2020-01-22T13:51:14  *** Chris_Stewart_5 has quit IRC
199 2020-01-22T13:59:26  *** Chris_Stewart_5 has joined #bitcoin-core-dev
200 2020-01-22T14:05:53  *** filchef has quit IRC
201 2020-01-22T14:11:54  *** AaronvanW has joined #bitcoin-core-dev
202 2020-01-22T14:23:28  *** SiAnDoG_ has joined #bitcoin-core-dev
203 2020-01-22T14:24:24  *** mfoolb has quit IRC
204 2020-01-22T14:24:41  *** mfoolb has joined #bitcoin-core-dev
205 2020-01-22T14:24:50  *** Eagle[TM] has quit IRC
206 2020-01-22T14:32:04  *** IGHOR has quit IRC
207 2020-01-22T14:37:10  *** Aaronvan_ has joined #bitcoin-core-dev
208 2020-01-22T14:38:41  *** IGHOR has joined #bitcoin-core-dev
209 2020-01-22T14:38:52  *** Guyver2_ has joined #bitcoin-core-dev
210 2020-01-22T14:40:39  *** AaronvanW has quit IRC
211 2020-01-22T14:40:51  *** Guyver2__ has quit IRC
212 2020-01-22T14:42:05  *** Aaronvan_ has quit IRC
213 2020-01-22T14:45:29  *** AaronvanW has joined #bitcoin-core-dev
214 2020-01-22T14:45:58  *** michaelfolkson has joined #bitcoin-core-dev
215 2020-01-22T14:52:53  *** bitcoin-git has joined #bitcoin-core-dev
216 2020-01-22T14:52:54  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a51aa2880d12...0a8b68cdf7d2
217 2020-01-22T14:52:55  <bitcoin-git> bitcoin/master fae7530 MarcoFalke: scripted-diff: Set gitian arch back to amd64
218 2020-01-22T14:52:56  <bitcoin-git> bitcoin/master 0a8b68c MarcoFalke: Merge #17483: build: Set gitian arch back to amd64
219 2020-01-22T14:52:58  *** bitcoin-git has left #bitcoin-core-dev
220 2020-01-22T14:53:28  *** bitcoin-git has joined #bitcoin-core-dev
221 2020-01-22T14:53:28  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17483: build: Set gitian arch back to amd64 (master...1911-gitianRevertToAmd64) https://github.com/bitcoin/bitcoin/pull/17483
222 2020-01-22T14:53:29  *** bitcoin-git has left #bitcoin-core-dev
223 2020-01-22T14:55:55  *** michaelfolkson has quit IRC
224 2020-01-22T14:56:33  *** michaelfolkson has joined #bitcoin-core-dev
225 2020-01-22T15:00:01  *** ermau has quit IRC
226 2020-01-22T15:02:17  *** jcoe has joined #bitcoin-core-dev
227 2020-01-22T15:12:52  *** bitcoin-git has joined #bitcoin-core-dev
228 2020-01-22T15:12:54  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/0a8b68cdf7d2...0038e536de6e
229 2020-01-22T15:12:55  <bitcoin-git> bitcoin/master 219417b Hennadii Stepanov: Revert "refactor: Simplify connection syntax"
230 2020-01-22T15:12:55  <bitcoin-git> bitcoin/master 70e4706 Hennadii Stepanov: Revert "refactor: Remove never used default parameter"
231 2020-01-22T15:12:56  <bitcoin-git> bitcoin/master 0038e53 Wladimir J. van der Laan: Merge #17965: qt: Revert changes of pr17943
232 2020-01-22T15:13:04  *** bitcoin-git has left #bitcoin-core-dev
233 2020-01-22T15:13:22  *** bitcoin-git has joined #bitcoin-core-dev
234 2020-01-22T15:13:23  <bitcoin-git> [bitcoin] laanwj merged pull request #17965: qt: Revert changes of pr17943 (master...20200119-revert17943) https://github.com/bitcoin/bitcoin/pull/17965
235 2020-01-22T15:13:23  *** bitcoin-git has left #bitcoin-core-dev
236 2020-01-22T15:17:24  *** AmberJ_ has joined #bitcoin-core-dev
237 2020-01-22T15:28:29  *** goatpig has quit IRC
238 2020-01-22T15:43:15  *** andrewtoth has joined #bitcoin-core-dev
239 2020-01-22T15:49:01  *** bitcoin-git has joined #bitcoin-core-dev
240 2020-01-22T15:49:02  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0038e536de6e...04f78b818f02
241 2020-01-22T15:49:02  <bitcoin-git> bitcoin/master 75163f4 Karl-Johan Alm: bug-fix macos: give free bytes to F_PREALLOCATE
242 2020-01-22T15:49:03  <bitcoin-git> bitcoin/master 04f78b8 Wladimir J. van der Laan: Merge #17887: bug-fix macos: give free bytes to F_PREALLOCATE
243 2020-01-22T15:49:06  *** bitcoin-git has left #bitcoin-core-dev
244 2020-01-22T15:49:25  *** bitcoin-git has joined #bitcoin-core-dev
245 2020-01-22T15:49:25  <bitcoin-git> [bitcoin] laanwj merged pull request #17887: bug-fix macos: give free bytes to F_PREALLOCATE (master...macos-f_preallocate_fix) https://github.com/bitcoin/bitcoin/pull/17887
246 2020-01-22T15:49:26  *** bitcoin-git has left #bitcoin-core-dev
247 2020-01-22T15:54:08  *** jcoe has quit IRC
248 2020-01-22T15:54:53  *** rex4539 has joined #bitcoin-core-dev
249 2020-01-22T15:59:18  *** EagleTM has joined #bitcoin-core-dev
250 2020-01-22T15:59:23  *** fox2p has quit IRC
251 2020-01-22T16:02:41  *** fox2p has joined #bitcoin-core-dev
252 2020-01-22T16:12:07  *** jonatack has quit IRC
253 2020-01-22T16:16:29  *** jarthur has joined #bitcoin-core-dev
254 2020-01-22T16:29:33  *** Guyver2__ has joined #bitcoin-core-dev
255 2020-01-22T16:31:36  *** bsm117532 has joined #bitcoin-core-dev
256 2020-01-22T16:32:28  *** Guyver2_ has quit IRC
257 2020-01-22T16:41:01  *** thor has joined #bitcoin-core-dev
258 2020-01-22T16:42:28  *** thor has quit IRC
259 2020-01-22T16:48:44  *** jonatack has joined #bitcoin-core-dev
260 2020-01-22T16:58:56  *** Talkless has joined #bitcoin-core-dev
261 2020-01-22T17:05:10  *** Talkless has quit IRC
262 2020-01-22T17:05:58  *** Talkless has joined #bitcoin-core-dev
263 2020-01-22T17:09:15  *** Talkless has quit IRC
264 2020-01-22T17:09:32  *** tsujp has quit IRC
265 2020-01-22T17:10:06  *** Talkless has joined #bitcoin-core-dev
266 2020-01-22T17:16:12  *** Chris_Stewart_5 has quit IRC
267 2020-01-22T17:29:07  *** jarthur_ has joined #bitcoin-core-dev
268 2020-01-22T17:30:44  *** jcoe has joined #bitcoin-core-dev
269 2020-01-22T17:33:18  *** jarthur has quit IRC
270 2020-01-22T17:35:55  *** jarthur_ has quit IRC
271 2020-01-22T17:38:56  *** gr0kchain has joined #bitcoin-core-dev
272 2020-01-22T17:46:25  *** jarthur has joined #bitcoin-core-dev
273 2020-01-22T17:46:57  *** lightlike has joined #bitcoin-core-dev
274 2020-01-22T17:50:29  *** goatpig has joined #bitcoin-core-dev
275 2020-01-22T17:52:06  *** jarthur has quit IRC
276 2020-01-22T17:56:22  *** jarthur has joined #bitcoin-core-dev
277 2020-01-22T17:57:46  *** gr0kchain has quit IRC
278 2020-01-22T18:00:01  *** AmberJ_ has quit IRC
279 2020-01-22T18:03:10  *** jarthur has quit IRC
280 2020-01-22T18:04:25  <jeremyrubin> hebasto: btw if you're interested in eliminating dependencies, you might be interested in reviewing https://github.com/JeremyRubin/bitcoin/pull/7
281 2020-01-22T18:04:51  <jeremyrubin> Currently we maintain an entire *data structure* in the mempool just because of a circular resolution issue
282 2020-01-22T18:04:57  *** jarthur has joined #bitcoin-core-dev
283 2020-01-22T18:07:34  <jeremyrubin> And we then have to do all these extra map lookups too rather than just keeping the data in the owning class
284 2020-01-22T18:08:13  *** Kiminuo has joined #bitcoin-core-dev
285 2020-01-22T18:09:27  *** Guyver2_ has joined #bitcoin-core-dev
286 2020-01-22T18:12:03  *** Guyver2__ has quit IRC
287 2020-01-22T18:14:28  *** Chris_Stewart_5 has joined #bitcoin-core-dev
288 2020-01-22T18:15:46  *** morcos has quit IRC
289 2020-01-22T18:15:48  *** jarthur has quit IRC
290 2020-01-22T18:16:31  *** jarthur has joined #bitcoin-core-dev
291 2020-01-22T18:16:33  *** morcos has joined #bitcoin-core-dev
292 2020-01-22T18:17:32  *** erwin_bullet has joined #bitcoin-core-dev
293 2020-01-22T18:18:47  *** tys0n_ has joined #bitcoin-core-dev
294 2020-01-22T18:37:23  <sipa> i haven't followed up on the fuzzing work that's been done to the codebase... but i wonder has anyone considered using a dummy signature checker, and fuzzing script execution with it?
295 2020-01-22T18:47:16  *** EagleTM has quit IRC
296 2020-01-22T18:50:48  <wumpus> not sure either, would be best to ask practicalswift
297 2020-01-22T19:02:12  <phantomcircuit> sipa, i dont think anybody has done that
298 2020-01-22T19:02:46  <sipa> maybe i'll spend some time looking into how fuzzing works :)
299 2020-01-22T19:03:44  <instagibbs> sipa, you shoudl attend the PR review club they did it 2 weeks ago :)
300 2020-01-22T19:04:02  <instagibbs> https://bitcoincore.reviews/17860.html
301 2020-01-22T19:04:25  <sipa> i have not mastered the skill of attending meetings held in the past
302 2020-01-22T19:04:38  <wumpus> hehe
303 2020-01-22T19:04:48  <instagibbs> here I dropped this: ;
304 2020-01-22T19:09:14  <jonatack> heh, the review club is gradually transitioning into a bitcoin optech-like resource
305 2020-01-22T19:21:16  *** bitcoin-git has joined #bitcoin-core-dev
306 2020-01-22T19:21:17  <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/04f78b818f02...1ae46dce60a1
307 2020-01-22T19:21:17  <bitcoin-git> bitcoin/master 9574de8 practicalswift: net: Avoid using C-style NUL-terminated strings as arguments in the netbas...
308 2020-01-22T19:21:18  <bitcoin-git> bitcoin/master fefb916 practicalswift: tests: Add tests to make sure lookup methods fail on std::string parameter...
309 2020-01-22T19:21:18  <bitcoin-git> bitcoin/master 7a046cd practicalswift: tests: Avoid using C-style NUL-terminated strings as arguments
310 2020-01-22T19:21:19  *** bitcoin-git has left #bitcoin-core-dev
311 2020-01-22T19:21:35  *** bitcoin-git has joined #bitcoin-core-dev
312 2020-01-22T19:21:36  <bitcoin-git> [bitcoin] laanwj merged pull request #17754: net: Don't allow resolving of std::string with embedded NUL characters. Add tests.  (master...c_str-cleanup-netbase) https://github.com/bitcoin/bitcoin/pull/17754
313 2020-01-22T19:21:47  *** bitcoin-git has left #bitcoin-core-dev
314 2020-01-22T19:29:07  *** truther10 has joined #bitcoin-core-dev
315 2020-01-22T19:31:06  <phantomcircuit> sipa, is it easy to replace the signature checker for a script instance?
316 2020-01-22T19:31:26  <phantomcircuit> iirc i looked into it but realized i'd need to much with the internals of the scripting stuff more than i wanted to
317 2020-01-22T19:31:55  <sipa> phantomcircuit: the script interpreter literally takes in an object that abstracts that out
318 2020-01-22T19:32:02  <sipa> you can pass one in that always returns true
319 2020-01-22T19:32:11  <sipa> no code changes to the script interpreter itself needed
320 2020-01-22T19:34:15  *** bitcoin-git has joined #bitcoin-core-dev
321 2020-01-22T19:34:16  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1ae46dce60a1...a3d198c93cbe
322 2020-01-22T19:34:17  <bitcoin-git> bitcoin/master 76bf972 fanquake: scripts: fix check-symbols & check-security argument passing
323 2020-01-22T19:34:18  <bitcoin-git> bitcoin/master c491368 fanquake: scripts: add MACHO dylib checking to symbol-check.py
324 2020-01-22T19:34:18  <bitcoin-git> bitcoin/master a3d198c Wladimir J. van der Laan: Merge #17863: scripts: Add MACHO dylib checks to symbol-check.py
325 2020-01-22T19:34:20  *** bitcoin-git has left #bitcoin-core-dev
326 2020-01-22T19:34:35  *** bitcoin-git has joined #bitcoin-core-dev
327 2020-01-22T19:34:35  <bitcoin-git> [bitcoin] laanwj merged pull request #17863: scripts: Add MACHO dylib checks to symbol-check.py (master...add_macos_dylib_checks) https://github.com/bitcoin/bitcoin/pull/17863
328 2020-01-22T19:34:37  *** bitcoin-git has left #bitcoin-core-dev
329 2020-01-22T19:35:48  *** jcoe has quit IRC
330 2020-01-22T19:37:45  <phantomcircuit> sipa, neat, then it should be pretty easy to do
331 2020-01-22T19:38:01  *** michaelfolkson has quit IRC
332 2020-01-22T19:39:02  <sipa> see the BaseSignatureChecker passed to EvalScript/VerifyScript
333 2020-01-22T19:49:35  *** truther10 has quit IRC
334 2020-01-22T19:55:39  *** jarthur has quit IRC
335 2020-01-22T19:56:15  *** Talkless has quit IRC
336 2020-01-22T19:56:52  *** emilengler has quit IRC
337 2020-01-22T20:00:50  *** diogosergio has joined #bitcoin-core-dev
338 2020-01-22T20:05:14  *** diogosergio has quit IRC
339 2020-01-22T20:05:39  *** EagleTM has joined #bitcoin-core-dev
340 2020-01-22T20:07:12  <dongcarl> jonasschnelli: Rebased a few of the net refactor PRs for you :-)
341 2020-01-22T20:09:51  *** bitcoin-git has joined #bitcoin-core-dev
342 2020-01-22T20:09:52  <bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/a3d198c93cbe...4a072330763b
343 2020-01-22T20:09:53  <bitcoin-git> bitcoin/master fa5d709 MarcoFalke: ci: Move wrap-qemu into separate script
344 2020-01-22T20:09:53  <bitcoin-git> bitcoin/master faba467 MarcoFalke: ci: Fix QEMU_USER_CMD parse issues
345 2020-01-22T20:09:55  <bitcoin-git> bitcoin/master fabb946 MarcoFalke: ci: Install needed gcc and qemu-user iff cross-compiling
346 2020-01-22T20:09:56  *** bitcoin-git has left #bitcoin-core-dev
347 2020-01-22T20:10:11  *** bitcoin-git has joined #bitcoin-core-dev
348 2020-01-22T20:10:11  <bitcoin-git> [bitcoin] laanwj merged pull request #17767: ci: Fix qemu issues (master...1912-ciFixWrapQemu) https://github.com/bitcoin/bitcoin/pull/17767
349 2020-01-22T20:10:22  *** bitcoin-git has left #bitcoin-core-dev
350 2020-01-22T20:12:37  *** owowo has quit IRC
351 2020-01-22T20:17:12  *** owowo has joined #bitcoin-core-dev
352 2020-01-22T20:23:56  *** bitcoin-git has joined #bitcoin-core-dev
353 2020-01-22T20:23:56  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #17984: test: Add p2p test for forcerelay permission (master...2001-qaTxForceRelay) https://github.com/bitcoin/bitcoin/pull/17984
354 2020-01-22T20:23:58  *** bitcoin-git has left #bitcoin-core-dev
355 2020-01-22T20:31:03  *** owowo has quit IRC
356 2020-01-22T20:35:43  *** owowo has joined #bitcoin-core-dev
357 2020-01-22T20:44:22  *** manantial has quit IRC
358 2020-01-22T20:45:04  *** manantial has joined #bitcoin-core-dev
359 2020-01-22T20:46:32  *** EagleTM has quit IRC
360 2020-01-22T20:47:19  *** goatpig has quit IRC
361 2020-01-22T20:52:00  *** lightlike has quit IRC
362 2020-01-22T20:53:29  *** Highway61 has quit IRC
363 2020-01-22T20:54:15  *** Highway61 has joined #bitcoin-core-dev
364 2020-01-22T21:00:02  *** erwin_bullet has quit IRC
365 2020-01-22T21:05:00  *** bitcoin-git has joined #bitcoin-core-dev
366 2020-01-22T21:05:00  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #17985: net: Remove forcerelay of rejected txs (master...2001-p2pNoDeadCode) https://github.com/bitcoin/bitcoin/pull/17985
367 2020-01-22T21:05:01  *** bitcoin-git has left #bitcoin-core-dev
368 2020-01-22T21:17:17  *** pmuir has joined #bitcoin-core-dev
369 2020-01-22T21:25:36  *** bitcoin-git has joined #bitcoin-core-dev
370 2020-01-22T21:25:37  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4a072330763b...7a311fa54a93
371 2020-01-22T21:25:37  <bitcoin-git> bitcoin/master f7453dc fanquake: build: remove linking librt for backwards compatibility
372 2020-01-22T21:25:38  <bitcoin-git> bitcoin/master 7a311fa Wladimir J. van der Laan: Merge #17738: build: remove linking librt for backwards compatibility
373 2020-01-22T21:25:40  *** bitcoin-git has left #bitcoin-core-dev
374 2020-01-22T21:25:56  *** bitcoin-git has joined #bitcoin-core-dev
375 2020-01-22T21:25:56  <bitcoin-git> [bitcoin] laanwj merged pull request #17738: build: remove linking librt for backwards compatibility (master...remove_librt_back_compat) https://github.com/bitcoin/bitcoin/pull/17738
376 2020-01-22T21:25:57  *** bitcoin-git has left #bitcoin-core-dev
377 2020-01-22T21:35:28  *** Kiminuo has quit IRC
378 2020-01-22T21:41:43  *** vasild has quit IRC
379 2020-01-22T21:42:48  *** vasild has joined #bitcoin-core-dev
380 2020-01-22T21:51:57  *** Chris_Stewart_5 has quit IRC
381 2020-01-22T21:56:38  *** EagleTM has joined #bitcoin-core-dev
382 2020-01-22T22:00:52  <MarcoFalke> sipa: phantomcircuit: There is https://github.com/bitcoin/bitcoin/blob/master/src/test/fuzz/eval_script.cpp and https://github.com/bitcoin/bitcoin/blob/master/src/test/fuzz/script_flags.cpp
383 2020-01-22T22:02:17  *** diogosergio has joined #bitcoin-core-dev
384 2020-01-22T22:05:14  *** vasild has quit IRC
385 2020-01-22T22:05:19  *** vasild_ has joined #bitcoin-core-dev
386 2020-01-22T22:07:09  *** diogosergio has quit IRC
387 2020-01-22T22:10:11  *** sdaftuar has quit IRC
388 2020-01-22T22:10:36  *** sdaftuar has joined #bitcoin-core-dev
389 2020-01-22T22:25:35  *** krvopije has joined #bitcoin-core-dev
390 2020-01-22T22:25:47  *** krvopije has quit IRC
391 2020-01-22T22:41:35  *** side^effects has joined #bitcoin-core-dev
392 2020-01-22T22:43:19  *** Guyver2_ has quit IRC
393 2020-01-22T22:49:47  *** jonatack has quit IRC
394 2020-01-22T23:08:19  *** Chris_Stewart_5 has joined #bitcoin-core-dev
395 2020-01-22T23:09:43  *** braydonf has quit IRC
396 2020-01-22T23:19:33  *** jonatack has joined #bitcoin-core-dev
397 2020-01-22T23:22:58  *** braydonf has joined #bitcoin-core-dev
398 2020-01-22T23:27:12  *** michaelfolkson has joined #bitcoin-core-dev
399 2020-01-22T23:27:23  *** michaelfolkson has quit IRC
400 2020-01-22T23:30:45  *** Chris_Stewart_5 has quit IRC
401 2020-01-22T23:47:26  *** promag has joined #bitcoin-core-dev
402 2020-01-22T23:50:17  *** orlovsky has joined #bitcoin-core-dev
403 2020-01-22T23:50:18  *** dr-orlovsky has quit IRC