1 2020-01-25T00:00:01  *** pmxb0t has quit IRC
  2 2020-01-25T00:43:53  *** promag has joined #bitcoin-core-dev
  3 2020-01-25T00:45:22  *** fimp has joined #bitcoin-core-dev
  4 2020-01-25T00:48:02  *** promag has quit IRC
  5 2020-01-25T00:54:48  *** roconnor has quit IRC
  6 2020-01-25T00:56:18  <jeremyrubin> by the way; last call for OP_CTV BIP 119 registrations
  7 2020-01-25T00:56:31  <jeremyrubin> https://utxos.org/workshops/
  8 2020-01-25T01:02:04  *** promag has joined #bitcoin-core-dev
  9 2020-01-25T01:06:48  *** promag has quit IRC
 10 2020-01-25T01:15:50  *** promag has joined #bitcoin-core-dev
 11 2020-01-25T01:17:24  *** zivl has quit IRC
 12 2020-01-25T01:20:47  *** promag has quit IRC
 13 2020-01-25T01:43:25  *** brianhoffman_ has joined #bitcoin-core-dev
 14 2020-01-25T01:45:03  *** brianhoffman has quit IRC
 15 2020-01-25T01:45:03  *** brianhoffman_ is now known as brianhoffman
 16 2020-01-25T02:02:54  *** promag has joined #bitcoin-core-dev
 17 2020-01-25T02:07:43  *** promag has quit IRC
 18 2020-01-25T03:00:02  *** fimp has quit IRC
 19 2020-01-25T03:00:57  *** abrissbi1ne has joined #bitcoin-core-dev
 20 2020-01-25T03:04:10  *** abrissbirne has quit IRC
 21 2020-01-25T03:17:21  *** machty has joined #bitcoin-core-dev
 22 2020-01-25T03:21:52  <fanquake>  5-6 gitian sigs each for the 0.19.1rc1 binaries so far, and the windows detached sigs are up, thanks cfields
 23 2020-01-25T03:22:08  <fanquake> jonasschnelli are you able to get some osx detached sigs up soon?
 24 2020-01-25T03:30:54  *** SiAnDoG__ has joined #bitcoin-core-dev
 25 2020-01-25T03:31:42  *** SiAnDoG_ has quit IRC
 26 2020-01-25T03:31:51  *** SiAnDoG__ has quit IRC
 27 2020-01-25T03:49:00  *** justanotheruser has quit IRC
 28 2020-01-25T03:52:23  *** afk11 has quit IRC
 29 2020-01-25T03:53:28  *** felixfoertsch has joined #bitcoin-core-dev
 30 2020-01-25T03:53:40  *** felixfoertsch23 has quit IRC
 31 2020-01-25T03:54:39  *** afk11 has joined #bitcoin-core-dev
 32 2020-01-25T04:04:12  *** promag has joined #bitcoin-core-dev
 33 2020-01-25T04:08:42  *** promag has quit IRC
 34 2020-01-25T04:11:26  *** justanotheruser has joined #bitcoin-core-dev
 35 2020-01-25T04:45:06  *** AaronvanW has quit IRC
 36 2020-01-25T06:00:01  *** machty has quit IRC
 37 2020-01-25T06:00:23  *** manantial has quit IRC
 38 2020-01-25T06:04:23  *** manantial has joined #bitcoin-core-dev
 39 2020-01-25T06:04:43  *** promag has joined #bitcoin-core-dev
 40 2020-01-25T06:09:26  *** promag has quit IRC
 41 2020-01-25T06:17:17  *** MarkusH1 has joined #bitcoin-core-dev
 42 2020-01-25T06:29:03  *** afk11 has quit IRC
 43 2020-01-25T06:29:47  *** justanotheruser has quit IRC
 44 2020-01-25T06:31:26  *** afk11 has joined #bitcoin-core-dev
 45 2020-01-25T06:52:43  *** justanotheruser has joined #bitcoin-core-dev
 46 2020-01-25T07:19:28  *** kinlo has quit IRC
 47 2020-01-25T07:40:05  *** vasild_ has joined #bitcoin-core-dev
 48 2020-01-25T07:43:03  *** vasild has quit IRC
 49 2020-01-25T08:09:32  *** bitcoin-git has joined #bitcoin-core-dev
 50 2020-01-25T08:09:32  <bitcoin-git> [bitcoin] fanquake closed pull request #17565: Fixed freezing GUI on reindex (master...freezing-gui-on-reindex) https://github.com/bitcoin/bitcoin/pull/17565
 51 2020-01-25T08:09:33  *** bitcoin-git has left #bitcoin-core-dev
 52 2020-01-25T08:12:26  *** bitcoin-git has joined #bitcoin-core-dev
 53 2020-01-25T08:12:26  <bitcoin-git> [bitcoin] fanquake closed pull request #16696: validation: static_assert to ensure width in unit class (master...fix-uintbase) https://github.com/bitcoin/bitcoin/pull/16696
 54 2020-01-25T08:12:27  *** bitcoin-git has left #bitcoin-core-dev
 55 2020-01-25T08:26:43  *** alec has quit IRC
 56 2020-01-25T08:26:57  *** alec has joined #bitcoin-core-dev
 57 2020-01-25T08:41:41  *** dr-orlovsky has quit IRC
 58 2020-01-25T08:47:39  *** abrissbi1ne is now known as abrissbirne
 59 2020-01-25T08:56:40  *** promag has joined #bitcoin-core-dev
 60 2020-01-25T09:00:02  *** MarkusH1 has quit IRC
 61 2020-01-25T09:00:57  *** promag has quit IRC
 62 2020-01-25T09:01:53  *** promag has joined #bitcoin-core-dev
 63 2020-01-25T09:14:35  *** Talkless has joined #bitcoin-core-dev
 64 2020-01-25T09:17:24  *** chaosagent has joined #bitcoin-core-dev
 65 2020-01-25T09:20:08  *** promag has quit IRC
 66 2020-01-25T09:20:19  *** promag has joined #bitcoin-core-dev
 67 2020-01-25T09:26:06  *** MasterdonX has quit IRC
 68 2020-01-25T09:26:31  *** emilengler has joined #bitcoin-core-dev
 69 2020-01-25T09:26:39  *** promag has quit IRC
 70 2020-01-25T09:27:32  *** promag has joined #bitcoin-core-dev
 71 2020-01-25T09:30:14  *** MasterdonX has joined #bitcoin-core-dev
 72 2020-01-25T09:35:18  *** RJ has joined #bitcoin-core-dev
 73 2020-01-25T10:02:43  *** EagleTM has joined #bitcoin-core-dev
 74 2020-01-25T10:04:49  *** kexkey has quit IRC
 75 2020-01-25T10:18:49  *** jonatack has quit IRC
 76 2020-01-25T10:26:04  *** kinlo has joined #bitcoin-core-dev
 77 2020-01-25T10:48:40  *** owowo has quit IRC
 78 2020-01-25T10:55:46  *** owowo has joined #bitcoin-core-dev
 79 2020-01-25T10:56:53  *** RJ has quit IRC
 80 2020-01-25T11:03:59  *** Kennedi43Haag has joined #bitcoin-core-dev
 81 2020-01-25T11:16:07  *** mfoolb has quit IRC
 82 2020-01-25T11:16:50  *** mfoolb has joined #bitcoin-core-dev
 83 2020-01-25T11:19:17  *** SiAnDoG__ has joined #bitcoin-core-dev
 84 2020-01-25T11:31:10  *** AaronvanW has joined #bitcoin-core-dev
 85 2020-01-25T11:33:01  *** jonasschnelli has quit IRC
 86 2020-01-25T11:33:02  *** jonasschnelli has joined #bitcoin-core-dev
 87 2020-01-25T11:33:39  <jonasschnelli> I have a different hash than wumpus for bitcoin-0.19.1rc1-osx-unsigned.tar.gz (https://bitcointools.jonasschnelli.ch/data/builds/1333/bitcoin-core-osx-0.19-build.assert)
 88 2020-01-25T11:33:52  <jonasschnelli> I guess wumpus'es are off (everyone else has the same)
 89 2020-01-25T11:33:57  <jonasschnelli> 	I pushed the osx detatched signature. Sorry, had to force push since my git email was set wrong.
 90 2020-01-25T11:35:19  *** jonasschnelli has quit IRC
 91 2020-01-25T11:35:33  *** jonasschnelli has joined #bitcoin-core-dev
 92 2020-01-25T11:35:47  *** jonasschnelli has joined #bitcoin-core-dev
 93 2020-01-25T11:37:37  *** test has joined #bitcoin-core-dev
 94 2020-01-25T11:38:01  *** test is now known as Guest34183
 95 2020-01-25T11:38:02  <jonasschnelli> looks like my irc messages end up in the nirvana...
 96 2020-01-25T11:39:30  <jonasschnelli> (good now though)
 97 2020-01-25T11:39:36  *** Guest34183 has quit IRC
 98 2020-01-25T11:44:22  *** zivl has joined #bitcoin-core-dev
 99 2020-01-25T11:52:36  *** Kennedi43Haag has quit IRC
100 2020-01-25T11:54:55  <fanquake> jonasschnelli: thanks
101 2020-01-25T11:58:43  *** braydonf has quit IRC
102 2020-01-25T12:00:01  *** chaosagent has quit IRC
103 2020-01-25T12:08:53  *** dr-orlovsky has joined #bitcoin-core-dev
104 2020-01-25T12:14:12  *** braydonf has joined #bitcoin-core-dev
105 2020-01-25T12:19:43  *** thelounge2467250 has quit IRC
106 2020-01-25T12:20:17  *** thelounge2467250 has joined #bitcoin-core-dev
107 2020-01-25T12:44:09  *** promag_ has joined #bitcoin-core-dev
108 2020-01-25T12:44:09  *** promag has quit IRC
109 2020-01-25T12:46:12  *** Stuk has joined #bitcoin-core-dev
110 2020-01-25T12:48:50  <wumpus> strange...
111 2020-01-25T12:51:29  <wumpus> at least it's only osx that mismatches, linux and windows are ok
112 2020-01-25T12:51:54  <wumpus> will try rebuilding
113 2020-01-25T12:51:57  <fanquake> wumpus might have modified your macOS SDK somehow?
114 2020-01-25T12:52:21  <wumpus> no, not as far as I know
115 2020-01-25T12:52:41  <wumpus> pretty sure this is the same setup I've used to build 0.19.0.1
116 2020-01-25T12:53:11  <fanquake> ok. If you wanted to upload bitcoin-0.19.1rc1-osx-unsigned.tar.gz I'd take a look
117 2020-01-25T12:55:20  <wumpus> will do! first going to try again to see if it's not just a fluke
118 2020-01-25T13:09:17  *** pandorian has joined #bitcoin-core-dev
119 2020-01-25T13:12:25  *** VoidVextor0 has quit IRC
120 2020-01-25T13:12:26  *** owowo has quit IRC
121 2020-01-25T13:17:02  <wumpus> re-built: same problem. The .tar.gz differs (but it is determinstic) but the dmg matches
122 2020-01-25T13:17:30  *** owowo has joined #bitcoin-core-dev
123 2020-01-25T13:22:20  <wumpus> fanquake: put up my version of the file here if anyone wants to try to compare it: https://download.visucore.com/bitcoin/bitcoin-0.19.1rc1-osx-unsigned.tar.gz
124 2020-01-25T13:25:33  <fanquake> wumpus: thanks. Having a look
125 2020-01-25T13:26:00  <wumpus> thankyou!
126 2020-01-25T13:28:12  <fanquake> wumpus the difference is in the .note.gnu.build-id section of the dmg tool
127 2020-01-25T13:29:02  <fanquake> can you do a readelf --string-dump .note.gnu.build-id path/to/dmg
128 2020-01-25T13:36:29  <fanquake> wumpus in the second part of that section I'm seeing
129 2020-01-25T13:36:37  <fanquake>  [    10]  r^[T???'Ó½?d?*???f?? for my binary
130 2020-01-25T13:36:45  <fanquake> [    10]  #{?^Vv^[s_?ْb?^D? ? for yours
131 2020-01-25T13:38:23  *** braydonf has quit IRC
132 2020-01-25T13:40:38  *** braydonf has joined #bitcoin-core-dev
133 2020-01-25T13:41:36  <fanquake> Looks like the difference is actually a little bigger.
134 2020-01-25T13:41:38  <fanquake> https://gist.github.com/fanquake/3303ac3bc9efc63293d59df5b81d1cef
135 2020-01-25T13:42:50  *** promag_ has quit IRC
136 2020-01-25T13:43:02  *** promag has joined #bitcoin-core-dev
137 2020-01-25T13:47:17  <fanquake> Our libdmg package in the 0.19 branch hasn't been changed since it was introduced, https://github.com/bitcoin/bitcoin/blob/0.19/depends/packages/native_libdmg-hfsplus.mk, so I'm quite interested to no what might be causing this difference
138 2020-01-25T13:54:05  *** jonatack has joined #bitcoin-core-dev
139 2020-01-25T13:55:22  *** promag has quit IRC
140 2020-01-25T13:56:18  *** promag has joined #bitcoin-core-dev
141 2020-01-25T13:57:08  *** tommy20 has joined #bitcoin-core-dev
142 2020-01-25T13:58:40  *** tommy20 has quit IRC
143 2020-01-25T14:42:46  *** thelounge2467250 has quit IRC
144 2020-01-25T14:43:22  *** thelounge2467250 has joined #bitcoin-core-dev
145 2020-01-25T15:00:01  *** Stuk has quit IRC
146 2020-01-25T15:09:13  *** VoidVextor0 has joined #bitcoin-core-dev
147 2020-01-25T15:12:01  *** jungly has quit IRC
148 2020-01-25T15:12:40  *** pandorian has quit IRC
149 2020-01-25T15:45:34  *** promag_ has joined #bitcoin-core-dev
150 2020-01-25T15:45:34  *** promag has quit IRC
151 2020-01-25T15:47:11  *** paolo|out has joined #bitcoin-core-dev
152 2020-01-25T15:57:15  *** justanotheruser has quit IRC
153 2020-01-25T16:12:53  <kanzure> #proposedmeetingtopic topic idea collection for physical meeting
154 2020-01-25T16:24:49  *** bitcoin-git has joined #bitcoin-core-dev
155 2020-01-25T16:24:49  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/28fbe68fdcac...c26b05c2b78f
156 2020-01-25T16:24:49  <bitcoin-git> bitcoin/master 2d23082 Micky Yun Chan: bump test timeouts so that functional tests run in valgrind
157 2020-01-25T16:24:50  <bitcoin-git> bitcoin/master c26b05c MarcoFalke: Merge #17770: test: bump test timeouts so that functional tests run in val...
158 2020-01-25T16:24:51  *** bitcoin-git has left #bitcoin-core-dev
159 2020-01-25T16:25:13  *** bitcoin-git has joined #bitcoin-core-dev
160 2020-01-25T16:25:13  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17770: test: bump test timeouts so that functional tests run in valgrind (master...bump) https://github.com/bitcoin/bitcoin/pull/17770
161 2020-01-25T16:25:14  *** bitcoin-git has left #bitcoin-core-dev
162 2020-01-25T16:33:45  *** Guyver2 has joined #bitcoin-core-dev
163 2020-01-25T16:34:23  *** promag_ has quit IRC
164 2020-01-25T16:34:41  *** justanotheruser has joined #bitcoin-core-dev
165 2020-01-25T16:38:40  *** dr-orlovsky has quit IRC
166 2020-01-25T16:47:23  *** justanotheruser has quit IRC
167 2020-01-25T16:48:05  *** belcher has quit IRC
168 2020-01-25T16:49:04  *** bitcoin-git has joined #bitcoin-core-dev
169 2020-01-25T16:49:04  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #17999: refactor: Add ChainClient setMockTime, getWallets methods (master...pr/ipc-clients) https://github.com/bitcoin/bitcoin/pull/17999
170 2020-01-25T16:49:05  *** bitcoin-git has left #bitcoin-core-dev
171 2020-01-25T16:49:30  *** bitcoin-git has joined #bitcoin-core-dev
172 2020-01-25T16:49:30  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #17999: refactor: Add ChainClient setMockTime, getWallets methods (master...pr/ipc-clients) https://github.com/bitcoin/bitcoin/pull/17999
173 2020-01-25T16:49:31  *** bitcoin-git has left #bitcoin-core-dev
174 2020-01-25T16:55:13  <hebasto> are detached sigs for 0.19.1rc1 tagged?
175 2020-01-25T16:59:06  *** dr-orlovsky has joined #bitcoin-core-dev
176 2020-01-25T17:02:26  *** bitcoin-git has joined #bitcoin-core-dev
177 2020-01-25T17:02:26  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #17997: refactor: Remove mempool global from net (master...2001-netMempool) https://github.com/bitcoin/bitcoin/pull/17997
178 2020-01-25T17:02:27  *** bitcoin-git has left #bitcoin-core-dev
179 2020-01-25T17:02:41  *** bitcoin-git has joined #bitcoin-core-dev
180 2020-01-25T17:02:41  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #17997: refactor: Remove mempool global from net (master...2001-netMempool) https://github.com/bitcoin/bitcoin/pull/17997
181 2020-01-25T17:02:42  *** bitcoin-git has left #bitcoin-core-dev
182 2020-01-25T17:08:17  *** dr-orlovsky has quit IRC
183 2020-01-25T17:23:29  *** jonatack has quit IRC
184 2020-01-25T17:28:57  *** justanotheruser has joined #bitcoin-core-dev
185 2020-01-25T17:30:47  *** promag has joined #bitcoin-core-dev
186 2020-01-25T17:38:28  <wumpus> fanquake: I'm really confused, so there is some difference in a third-party tool, not one of our own executables, and it's mostly just a difference in message?
187 2020-01-25T17:38:51  <wumpus> dmg is replaced by <elf>?
188 2020-01-25T17:39:35  <wumpus> I gues I'll delete the cache and retry...
189 2020-01-25T17:48:11  *** jonatack has joined #bitcoin-core-dev
190 2020-01-25T17:48:43  *** side^effects has quit IRC
191 2020-01-25T17:51:28  *** killer has joined #bitcoin-core-dev
192 2020-01-25T18:00:02  *** paolo|out has quit IRC
193 2020-01-25T18:06:06  *** dr-orlovsky has joined #bitcoin-core-dev
194 2020-01-25T18:16:42  *** promag has quit IRC
195 2020-01-25T18:17:37  *** chrippa has joined #bitcoin-core-dev
196 2020-01-25T18:18:50  *** dr-orlovsky has quit IRC
197 2020-01-25T18:26:02  *** rh0nj has quit IRC
198 2020-01-25T18:27:07  *** rh0nj has joined #bitcoin-core-dev
199 2020-01-25T19:03:31  *** Talkless has quit IRC
200 2020-01-25T19:11:28  *** EagleTM has quit IRC
201 2020-01-25T19:20:03  <wumpus> that didn't solve it either, I'm baffled
202 2020-01-25T19:29:02  <wumpus> fanquake: in your comparisons in https://gist.github.com/fanquake/3303ac3bc9efc63293d59df5b81d1cef, there's
203 2020-01-25T19:29:04  <wumpus>  -  0x0001ccf0 7c69736f 7c646d67 5d203c69 6e3e203c |iso|<elf>] <in> <
204 2020-01-25T19:29:13  <wumpus>  +  0x0001ccf0 7c69736f 7c646d67 5d203c69 6e3e203c |iso|dmg] <in> <
205 2020-01-25T19:29:32  <wumpus> I don't unnderstand why the text is different in that hexdump, but the hex digits seem the same?
206 2020-01-25T19:29:57  *** bitcoin-git has joined #bitcoin-core-dev
207 2020-01-25T19:29:57  <bitcoin-git> [bitcoin] sipsorcery opened pull request #18001: Updated appveyor job to checkout a specific vcpkg commit ID (master...vcpkg-specific-version) https://github.com/bitcoin/bitcoin/pull/18001
208 2020-01-25T19:29:58  *** bitcoin-git has left #bitcoin-core-dev
209 2020-01-25T19:30:32  <wumpus> they're supposed to be different representation of the same data, right?
210 2020-01-25T19:30:47  *** bitcoin-git has joined #bitcoin-core-dev
211 2020-01-25T19:30:47  <bitcoin-git> [bitcoin] sipsorcery closed pull request #17995: Load vcpkg port files from a separate repository. (master...vcpkg-ports-separate) https://github.com/bitcoin/bitcoin/pull/17995
212 2020-01-25T19:30:48  *** bitcoin-git has left #bitcoin-core-dev
213 2020-01-25T19:34:10  <sipa> Œð|iso|dmg] <in> <
214 2020-01-25T19:34:46  <sipa> is the hex ascii conversion
215 2020-01-25T19:42:38  <wumpus> exactly! so I don't see where the <elf> comes from; the dmg executable definitely differs from the ones generated by other's gitian, but I don't yet know in what way (besides the build id, but that's a kind of hash of some sections)
216 2020-01-25T19:43:22  <wumpus> deleted and regenerating the gitian base image, will delete the cache again, and try yet again if I get a different output
217 2020-01-25T19:43:43  *** vasild_ has quit IRC
218 2020-01-25T19:45:05  *** vasild has joined #bitcoin-core-dev
219 2020-01-25T19:46:21  <wumpus> can someone please put up their "correct" version of bitcoin-0.19.1rc1-osx-unsigned.tar.gz?
220 2020-01-25T19:47:50  *** dr-orlovsky has joined #bitcoin-core-dev
221 2020-01-25T19:50:16  *** Kiminuo has joined #bitcoin-core-dev
222 2020-01-25T20:04:22  <fanquake> wumpus sure
223 2020-01-25T20:04:48  <fanquake> I'm also confused by the supposed string substitution
224 2020-01-25T20:07:13  <fanquake> wumpus https://uploadfiles.io/xb1hzk0i 5023cb07d685a7f4b6ff3e1c12753da0b7cbf4f492d309d9b74b1f4e76af21eb
225 2020-01-25T20:09:50  <jonatack> fanquake: am gitian building 0.19.1rc1, is that the correct tag atm?
226 2020-01-25T20:10:53  <fanquake> that's the most recent tag, yes
227 2020-01-25T20:11:19  <jonatack> thanks
228 2020-01-25T20:12:04  <jeremyrubin> Independent of Taproot PR; would there be any strong objections to picking *an* implementation of std::optional (from some compiler's includes)  or adding a minimal optional subsititue and eliminating the boost dependency? see https://github.com/martinmoene/optional-bare/blob/master/include/nonstd/optional.hpp and https://github.com/tcbrindle/cpp17_headers/blob/master/include/stx/optional.hpp as copyable examples
229 2020-01-25T20:12:31  <jeremyrubin> (This came up in the context of taproot of not wanting to use optional in consensus to avoid a boost dep)
230 2020-01-25T20:13:02  <gwillen> wumpus: sipa: that hexdump is not a hexdump
231 2020-01-25T20:13:24  <gwillen> some tool has blindly performed an s/dmg/<elf>/ _after_ the hexdump was run, on whatever file contained the output
232 2020-01-25T20:13:50  <gwillen> there is a mistargeted glob somewhere or something in that toolchain
233 2020-01-25T20:14:26  <fanquake> gwillen I guess diffoscope must be broken then
234 2020-01-25T20:15:09  <fanquake> As that's what was used to generate those dumps.
235 2020-01-25T20:15:14  <gwillen> I am not familiar with diffoscope so I can't comment, but (1) the hex in the hexdump always controls, the displayed characters are just for convenience, and (2) you can see the the NUMBER of characters in the right column is wrong
236 2020-01-25T20:15:21  <gwillen> because dmg and <elf> are not the same length
237 2020-01-25T20:16:46  <gwillen> I suspect the same of the --symbols output, probably there is no <elf> in the binary, something is messing with the tool output
238 2020-01-25T20:17:28  <jeremyrubin> Another option would just be to fill in with boost::optional if c++17 isn't available, and std::optional otherwise (so libconsensus can build w/o boost on newer compilers)
239 2020-01-25T20:17:41  <fanquake> I think you might be right. Maybe the difference really is only the Build ID
240 2020-01-25T20:18:55  <fanquake> heh
241 2020-01-25T20:18:57  <fanquake> https://salsa.debian.org/reproducible-builds/diffoscope/issues/80
242 2020-01-25T20:19:20  <fanquake> wumpus The iso <elf> substitution is a bug in diffoscope
243 2020-01-25T20:19:49  <fanquake> I think the only difference between the two tools might actually just be the build ID
244 2020-01-25T20:19:50  <sipa> fanquake: more like crazy feature
245 2020-01-25T20:20:03  *** justinmoon_ is now known as justinmoon
246 2020-01-25T20:20:27  <fanquake> sipa a good time waster
247 2020-01-25T20:20:36  <gwillen> oh, good find fanquake, thanks, I was going to go nuts trying to track that down
248 2020-01-25T20:22:02  <gwillen> I guess you named one of the files "dmg" when passing it to diffoscope, triggering the overzealous search-and-replace on only one side
249 2020-01-25T20:22:56  <fanquake> gwillen yea the binary is just named dmg
250 2020-01-25T20:23:11  <fanquake> I was doing diffoscope wumpus.dmg dmg
251 2020-01-25T20:23:26  <gwillen> that is a pretty nasty bug / misfeature in diffoscope
252 2020-01-25T20:23:34  <fanquake> If I swap that for diffoscope wumpus.dmg fanquake.dmg I see
253 2020-01-25T20:24:09  <fanquake> https://gist.github.com/fanquake/c2108e690a320e23727c80b839197b91
254 2020-01-25T20:26:38  <gwillen> that build ID is allegedly supposed to be a hash of the binary contents to make it reproducible, I wonder what went wrong here
255 2020-01-25T20:29:58  <gwillen> I wonder if the way build ID is computed changed between versions of ld -- the original default is documented to have been md5, whereas the current default is allegedly sha1
256 2020-01-25T20:32:42  <fanquake> From what I understand, Build ID isn't necessarily a content hash, almost more like a UUID. However will continue looking tomorrow.
257 2020-01-25T20:32:48  * fanquake goes back to sleep
258 2020-01-25T20:33:54  <gwillen> there is apparently a --build-id flag you pass to ld, which you can set to values like "sha1" or "md5" or "uuid" or "0x..." (a constant)
259 2020-01-25T20:34:04  <gwillen> see e.g. https://fedoraproject.org/wiki/RolandMcGrath/BuildID
260 2020-01-25T20:34:40  <sipa> fanquake: so that's how you do it
261 2020-01-25T20:34:43  <gwillen> but given apparently identical inputs, and a difference in build ID on exactly one machine, I definitely wonder if the difference is the ld on that machine is doing something funny
262 2020-01-25T20:35:15  <sipa> you have an AI to wake you up when there are interesting IRC or github conversations and sleep in between
263 2020-01-25T20:36:28  <fanquake> sipa: yea something fancy like that
264 2020-01-25T20:39:14  *** luke-jr has quit IRC
265 2020-01-25T20:39:44  *** luke-jr has joined #bitcoin-core-dev
266 2020-01-25T21:00:01  *** chrippa has quit IRC
267 2020-01-25T21:06:54  *** bitcoin-git has joined #bitcoin-core-dev
268 2020-01-25T21:06:54  <bitcoin-git> [bitcoin] sipa opened pull request #18002: Abstract out script execution out of VerifyWitnessProgram() (master...202001_execute_witness) https://github.com/bitcoin/bitcoin/pull/18002
269 2020-01-25T21:06:57  *** bitcoin-git has left #bitcoin-core-dev
270 2020-01-25T21:17:23  *** vexed[vexed] has joined #bitcoin-core-dev
271 2020-01-25T21:19:09  <wumpus> fanquake: after building with a newly generated base image I managed to get the same output as everyone else now, pushed new sigs
272 2020-01-25T21:19:55  <wumpus> fanquake: likely it's some ubuntu package difference that caused it; will still do a comparison just to be sure
273 2020-01-25T21:19:55  *** pinheadmz has joined #bitcoin-core-dev
274 2020-01-25T21:24:56  <wumpus> right: the only difference I get is the .note.gnu.build-id section -- well, okay, that's only a id and can't be an implanted backdoor at least :-) thank you for your help fanquake, seems this has been resolved
275 2020-01-25T21:31:14  *** brianhoffman has quit IRC
276 2020-01-25T21:33:36  *** brianhoffman has joined #bitcoin-core-dev
277 2020-01-25T21:36:45  *** Kiminuo has quit IRC
278 2020-01-25T21:56:57  *** pandorian has joined #bitcoin-core-dev
279 2020-01-25T21:57:14  <fanquake> wumpus great!
280 2020-01-25T22:01:07  *** VoidVextor0 has quit IRC
281 2020-01-25T22:37:08  *** Guyver2 has quit IRC
282 2020-01-25T22:38:07  *** Guyver2 has joined #bitcoin-core-dev
283 2020-01-25T22:38:24  *** Guyver2 has quit IRC
284 2020-01-25T22:38:37  *** Guyver2 has joined #bitcoin-core-dev
285 2020-01-25T22:39:44  *** Guyver2 has quit IRC
286 2020-01-25T22:48:24  *** belcher has joined #bitcoin-core-dev
287 2020-01-25T22:52:01  *** Kiminuo has joined #bitcoin-core-dev
288 2020-01-25T22:56:23  *** luke-jr has quit IRC
289 2020-01-25T22:56:54  *** luke-jr has joined #bitcoin-core-dev
290 2020-01-25T23:04:13  *** justanotheruser has quit IRC
291 2020-01-25T23:05:15  *** emilengler has quit IRC
292 2020-01-25T23:17:09  *** Talkless has joined #bitcoin-core-dev
293 2020-01-25T23:23:05  *** Highway61 has quit IRC
294 2020-01-25T23:28:58  *** Talkless has quit IRC
295 2020-01-25T23:29:59  *** Talkless has joined #bitcoin-core-dev
296 2020-01-25T23:44:56  *** Talkless has quit IRC
297 2020-01-25T23:58:41  *** Kiminuo has quit IRC