1 2020-01-28T00:00:01  *** Alex3 has quit IRC
  2 2020-01-28T00:06:29  *** sipsorcery has quit IRC
  3 2020-01-28T00:15:11  *** diogosergio has quit IRC
  4 2020-01-28T00:17:05  *** willmoffat has joined #bitcoin-core-dev
  5 2020-01-28T00:23:10  *** sipsorcery has joined #bitcoin-core-dev
  6 2020-01-28T00:33:16  *** Krellan_ has joined #bitcoin-core-dev
  7 2020-01-28T00:34:37  *** Dean_Guss has joined #bitcoin-core-dev
  8 2020-01-28T00:36:32  *** DeanWeen has quit IRC
  9 2020-01-28T00:54:58  *** justanotheruser has quit IRC
 10 2020-01-28T01:01:35  *** sipsorcery has quit IRC
 11 2020-01-28T01:08:07  *** Krellan_ has quit IRC
 12 2020-01-28T01:11:05  *** justanotheruser has joined #bitcoin-core-dev
 13 2020-01-28T01:28:23  *** vasild has quit IRC
 14 2020-01-28T01:30:11  *** vasild has joined #bitcoin-core-dev
 15 2020-01-28T01:43:36  *** belcher has quit IRC
 16 2020-01-28T01:44:15  *** lnostdal has joined #bitcoin-core-dev
 17 2020-01-28T02:11:34  *** diogosergio has joined #bitcoin-core-dev
 18 2020-01-28T02:14:01  *** AaronvanW has quit IRC
 19 2020-01-28T02:16:18  *** diogosergio has quit IRC
 20 2020-01-28T02:46:29  *** dr-orlovsky has quit IRC
 21 2020-01-28T02:47:34  *** dr-orlovsky has joined #bitcoin-core-dev
 22 2020-01-28T03:00:02  *** willmoffat has quit IRC
 23 2020-01-28T03:01:14  *** abrissbi1ne has joined #bitcoin-core-dev
 24 2020-01-28T03:04:26  *** abrissbirne has quit IRC
 25 2020-01-28T03:11:35  *** diogosergio has joined #bitcoin-core-dev
 26 2020-01-28T03:16:26  *** diogosergio has quit IRC
 27 2020-01-28T03:16:30  *** zyga1 has joined #bitcoin-core-dev
 28 2020-01-28T03:20:07  *** SiAnDoG__ has quit IRC
 29 2020-01-28T03:20:25  *** SiAnDoG__ has joined #bitcoin-core-dev
 30 2020-01-28T03:37:24  *** Krellan_ has joined #bitcoin-core-dev
 31 2020-01-28T03:50:18  *** felixfoertsch has joined #bitcoin-core-dev
 32 2020-01-28T03:51:00  *** felixfoertsch23 has quit IRC
 33 2020-01-28T04:11:20  *** EagleTM has quit IRC
 34 2020-01-28T04:11:24  *** Eagle[TM] has joined #bitcoin-core-dev
 35 2020-01-28T04:11:34  *** Krellan_ has quit IRC
 36 2020-01-28T04:12:05  *** Krellan_ has joined #bitcoin-core-dev
 37 2020-01-28T04:16:10  *** Soligor has quit IRC
 38 2020-01-28T04:21:24  *** Soligor has joined #bitcoin-core-dev
 39 2020-01-28T05:03:09  *** cryptapus has quit IRC
 40 2020-01-28T06:00:01  *** zyga1 has quit IRC
 41 2020-01-28T06:17:40  *** pwgn has joined #bitcoin-core-dev
 42 2020-01-28T06:25:51  *** mryandao has quit IRC
 43 2020-01-28T06:27:05  *** mryandao has joined #bitcoin-core-dev
 44 2020-01-28T06:41:47  *** BlueMatt has quit IRC
 45 2020-01-28T06:42:02  *** BlueMatt has joined #bitcoin-core-dev
 46 2020-01-28T06:57:09  *** abrissbi1ne is now known as abrissbirne
 47 2020-01-28T07:19:14  *** Eagle[TM] has quit IRC
 48 2020-01-28T07:20:41  *** sipsorcery has joined #bitcoin-core-dev
 49 2020-01-28T07:29:06  *** goatpig has joined #bitcoin-core-dev
 50 2020-01-28T07:39:17  *** tecnecio_ has joined #bitcoin-core-dev
 51 2020-01-28T07:43:23  *** vasild has quit IRC
 52 2020-01-28T07:45:00  *** vasild has joined #bitcoin-core-dev
 53 2020-01-28T07:47:59  *** Soligor has quit IRC
 54 2020-01-28T07:48:27  *** Soligor has joined #bitcoin-core-dev
 55 2020-01-28T08:03:48  *** real_or_random has quit IRC
 56 2020-01-28T08:11:05  *** promag has quit IRC
 57 2020-01-28T08:11:19  *** promag has joined #bitcoin-core-dev
 58 2020-01-28T08:16:52  *** Guyver2 has joined #bitcoin-core-dev
 59 2020-01-28T08:17:19  *** promag has quit IRC
 60 2020-01-28T08:23:12  *** promag has joined #bitcoin-core-dev
 61 2020-01-28T08:24:14  *** Blaz has joined #bitcoin-core-dev
 62 2020-01-28T08:27:38  *** promag has quit IRC
 63 2020-01-28T08:52:53  *** promag has joined #bitcoin-core-dev
 64 2020-01-28T08:57:23  *** promag has quit IRC
 65 2020-01-28T09:00:01  *** pwgn has quit IRC
 66 2020-01-28T09:01:16  *** kljasdfvv has quit IRC
 67 2020-01-28T09:03:06  *** kljasdfvv has joined #bitcoin-core-dev
 68 2020-01-28T09:15:02  *** Guyver2 has quit IRC
 69 2020-01-28T09:15:28  *** bitcoin-git has joined #bitcoin-core-dev
 70 2020-01-28T09:15:29  <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b89f2d059937...3774281327c8
 71 2020-01-28T09:15:30  <bitcoin-git> bitcoin/master e605088 Carl Dong: guix: Pin Guix using `guix time-machine`
 72 2020-01-28T09:15:30  <bitcoin-git> bitcoin/master 88c8363 Carl Dong: guix: Update documentation for time-machine
 73 2020-01-28T09:15:31  <bitcoin-git> bitcoin/master 3774281 fanquake: Merge #17933: guix: Pin Guix using `guix time-machine`
 74 2020-01-28T09:15:33  *** bitcoin-git has left #bitcoin-core-dev
 75 2020-01-28T09:15:48  *** bitcoin-git has joined #bitcoin-core-dev
 76 2020-01-28T09:15:48  <bitcoin-git> [bitcoin] fanquake merged pull request #17933: guix: Pin Guix using `guix time-machine` (master...2020-01-guix-time-machine) https://github.com/bitcoin/bitcoin/pull/17933
 77 2020-01-28T09:15:49  *** bitcoin-git has left #bitcoin-core-dev
 78 2020-01-28T09:17:17  *** popey1 has joined #bitcoin-core-dev
 79 2020-01-28T09:21:33  *** promag has joined #bitcoin-core-dev
 80 2020-01-28T09:32:01  *** dr-orlovsky has quit IRC
 81 2020-01-28T09:36:29  *** Zenton has joined #bitcoin-core-dev
 82 2020-01-28T09:47:32  *** diogosergio has joined #bitcoin-core-dev
 83 2020-01-28T09:52:33  *** diogosergio has quit IRC
 84 2020-01-28T10:03:24  *** jdmark has quit IRC
 85 2020-01-28T10:05:59  *** dr-orlovsky has joined #bitcoin-core-dev
 86 2020-01-28T10:07:42  *** Blaz has quit IRC
 87 2020-01-28T10:26:31  *** bitcoin-git has joined #bitcoin-core-dev
 88 2020-01-28T10:26:31  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3774281327c8...2755b2b1092d
 89 2020-01-28T10:26:32  <bitcoin-git> bitcoin/master b3c4d9b Sebastian Falbesoner: test: rename test suite name "tx_validationcache_tests" to match filename
 90 2020-01-28T10:26:33  <bitcoin-git> bitcoin/master 2755b2b fanquake: Merge #18010: test: rename test suite name "tx_validationcache_tests" to m...
 91 2020-01-28T10:26:34  *** bitcoin-git has left #bitcoin-core-dev
 92 2020-01-28T10:26:54  *** bitcoin-git has joined #bitcoin-core-dev
 93 2020-01-28T10:26:54  <bitcoin-git> [bitcoin] fanquake merged pull request #18010: test: rename test suite name "tx_validationcache_tests" to match filename (master...20200127-test-adapt-test-suite-names-to-file-names) https://github.com/bitcoin/bitcoin/pull/18010
 94 2020-01-28T10:26:55  *** bitcoin-git has left #bitcoin-core-dev
 95 2020-01-28T10:38:46  <provoostenator> valgrind
 96 2020-01-28T10:39:11  *** belcher has joined #bitcoin-core-dev
 97 2020-01-28T10:39:14  <provoostenator> Update on the valgrind mystery in #15382; it appears it doesn't like "echo"
 98 2020-01-28T10:39:17  <gribble> https://github.com/bitcoin/bitcoin/issues/15382 | util: add runCommandParseJSON by Sjors · Pull Request #15382 · bitcoin/bitcoin · GitHub
 99 2020-01-28T10:40:50  *** AaronvanW has joined #bitcoin-core-dev
100 2020-01-28T10:41:06  *** bitcoin-git has joined #bitcoin-core-dev
101 2020-01-28T10:41:07  <bitcoin-git> [bitcoin] Bushstar opened pull request #18012: GBT segwit rule in RPC error msg missing single quotes (master...patch-5) https://github.com/bitcoin/bitcoin/pull/18012
102 2020-01-28T10:41:08  *** bitcoin-git has left #bitcoin-core-dev
103 2020-01-28T10:42:46  <provoostenator> echo also handles quotes differently between Windows and Linux, so I probably need an alternative incantation for that test anyway.
104 2020-01-28T11:00:17  *** timothy has joined #bitcoin-core-dev
105 2020-01-28T11:03:56  *** Agustina73Watsic has joined #bitcoin-core-dev
106 2020-01-28T11:08:42  *** jcoe has joined #bitcoin-core-dev
107 2020-01-28T11:32:28  *** hsmiths has quit IRC
108 2020-01-28T11:32:45  *** hsmiths has joined #bitcoin-core-dev
109 2020-01-28T11:35:29  *** alec_ is now known as alec
110 2020-01-28T11:37:48  *** dr-orlovsky has quit IRC
111 2020-01-28T11:37:57  *** orlovsky has joined #bitcoin-core-dev
112 2020-01-28T11:43:38  *** Chris_Stewart_5 has joined #bitcoin-core-dev
113 2020-01-28T11:46:02  *** orlovsky has quit IRC
114 2020-01-28T11:47:35  *** dr-orlovsky has joined #bitcoin-core-dev
115 2020-01-28T11:48:49  *** diogosergio has joined #bitcoin-core-dev
116 2020-01-28T11:52:36  *** Agustina73Watsic has quit IRC
117 2020-01-28T11:54:02  *** diogosergio has quit IRC
118 2020-01-28T11:58:46  *** orlovsky has joined #bitcoin-core-dev
119 2020-01-28T12:00:02  *** popey1 has quit IRC
120 2020-01-28T12:00:21  *** dr-orlovsky has quit IRC
121 2020-01-28T12:15:19  *** rob01 has joined #bitcoin-core-dev
122 2020-01-28T12:21:59  *** thelounge2467250 has quit IRC
123 2020-01-28T12:22:37  *** thelounge2467250 has joined #bitcoin-core-dev
124 2020-01-28T12:36:11  *** jamesob has quit IRC
125 2020-01-28T12:36:27  *** jamesob has joined #bitcoin-core-dev
126 2020-01-28T12:53:03  *** Chris_Stewart_5 has quit IRC
127 2020-01-28T12:53:28  *** Chris_Stewart_5 has joined #bitcoin-core-dev
128 2020-01-28T12:55:12  *** jcoe1 has joined #bitcoin-core-dev
129 2020-01-28T12:55:45  *** jcoe has quit IRC
130 2020-01-28T13:02:01  *** zac94 has joined #bitcoin-core-dev
131 2020-01-28T13:08:06  *** promag has quit IRC
132 2020-01-28T13:09:23  *** rob01 has quit IRC
133 2020-01-28T13:12:46  *** rodarmor has quit IRC
134 2020-01-28T13:13:02  *** rodarmor has joined #bitcoin-core-dev
135 2020-01-28T13:15:28  *** tryphe_ has joined #bitcoin-core-dev
136 2020-01-28T13:18:31  *** tecnecio_ has quit IRC
137 2020-01-28T13:18:43  *** tryphe has quit IRC
138 2020-01-28T13:20:40  *** tryphe_ is now known as tryphe
139 2020-01-28T13:30:58  *** Soligor has quit IRC
140 2020-01-28T13:32:53  <fanquake> Qt is ditching LTS releases for non-commercial users, and it looks like a “Qt Account” will soon be required to even download the open source packages: https://www.qt.io/blog/qt-offering-changes-2020
141 2020-01-28T13:34:06  <fanquake> Ooh actually, should still be able to download the source with no account. Looks like it’ll just be for the installers?
142 2020-01-28T13:36:23  *** NilsHitze has joined #bitcoin-core-dev
143 2020-01-28T13:44:45  *** Soligor has joined #bitcoin-core-dev
144 2020-01-28T13:49:06  *** orlovsky has quit IRC
145 2020-01-28T13:49:56  *** dr-orlovsky has joined #bitcoin-core-dev
146 2020-01-28T13:51:29  *** dr-orlovsky has quit IRC
147 2020-01-28T13:52:06  *** dr-orlovsky has joined #bitcoin-core-dev
148 2020-01-28T13:53:44  *** Chris_Stewart_5 has quit IRC
149 2020-01-28T13:56:59  *** Chris_Stewart_5 has joined #bitcoin-core-dev
150 2020-01-28T13:58:09  <luke-jr> fanquake: hmm, LTS only for commercial users sounds like pretty reasonable funding for open source
151 2020-01-28T13:59:18  <luke-jr> they should probably think of a more reasonable price for end users tho (not sure how that will mesh with open source licensing)
152 2020-01-28T14:01:10  <luke-jr> I guess there are practical complications of such a policy for a library ^^;
153 2020-01-28T14:05:25  <luke-jr> is there a reason #16507 wasn't backported? cc fanquake instagibbs
154 2020-01-28T14:05:28  <gribble> https://github.com/bitcoin/bitcoin/issues/16507 | feefilter: Compute the absolute fee rather than stored rate by instagibbs · Pull Request #16507 · bitcoin/bitcoin · GitHub
155 2020-01-28T14:05:40  *** promag has joined #bitcoin-core-dev
156 2020-01-28T14:09:18  *** promag has quit IRC
157 2020-01-28T14:09:34  *** promag has joined #bitcoin-core-dev
158 2020-01-28T14:21:49  *** dr-orlovsky has quit IRC
159 2020-01-28T14:22:00  *** orlovsky has joined #bitcoin-core-dev
160 2020-01-28T14:30:29  *** Soligor has quit IRC
161 2020-01-28T14:41:14  *** emilengler has joined #bitcoin-core-dev
162 2020-01-28T14:46:30  *** torstein18 has joined #bitcoin-core-dev
163 2020-01-28T14:49:36  <instagibbs> luke-jr, AFAICT it only matters if min relay fee is changed to something not % 1000 == 0
164 2020-01-28T14:49:48  <instagibbs> which no one is talking about doing basically ever
165 2020-01-28T14:50:42  <instagibbs> I only found it because I was investigating for liquid related purposes, where DoS is less of a concern...
166 2020-01-28T14:55:44  *** Skirmant has joined #bitcoin-core-dev
167 2020-01-28T15:00:01  *** NilsHitze has quit IRC
168 2020-01-28T15:01:51  *** justanotheruser is now known as FeudalBear
169 2020-01-28T15:01:56  *** Skirmant has quit IRC
170 2020-01-28T15:05:41  <elichai2> I'm getting this when running `./bench_bitcoin -filter=something` (it doesn't matter what "somethng" is ) `bench_bitcoin: bench/bench.cpp:119: static void benchmark::BenchRunner::RunAll(benchmark::Printer&, uint64_t, double, const string&, bool): Assertion `g_testing_setup == nullptr' failed.`
171 2020-01-28T15:07:34  <elichai2> @MarcoFalke  ahhm
172 2020-01-28T15:08:29  <elichai2> I think I've found the problem+fix
173 2020-01-28T15:10:23  *** Soligor has joined #bitcoin-core-dev
174 2020-01-28T15:11:15  *** bitcoin-git has joined #bitcoin-core-dev
175 2020-01-28T15:11:15  <bitcoin-git> [bitcoin] elichai opened pull request #18013: bench: Fix benchmarks filters (master...patch-2) https://github.com/bitcoin/bitcoin/pull/18013
176 2020-01-28T15:11:16  *** bitcoin-git has left #bitcoin-core-dev
177 2020-01-28T15:17:03  *** meoblast001 has joined #bitcoin-core-dev
178 2020-01-28T15:17:26  *** meoblast001 is now known as Guest53426
179 2020-01-28T15:23:14  *** Chris_Stewart_5 has quit IRC
180 2020-01-28T15:41:47  *** promag has quit IRC
181 2020-01-28T15:42:30  *** promag has joined #bitcoin-core-dev
182 2020-01-28T15:51:30  *** goatpig has quit IRC
183 2020-01-28T15:58:59  *** promag has quit IRC
184 2020-01-28T15:59:16  *** promag has joined #bitcoin-core-dev
185 2020-01-28T16:27:29  *** aqquadro has joined #bitcoin-core-dev
186 2020-01-28T16:27:29  *** aqquadro has quit IRC
187 2020-01-28T16:27:29  *** aqquadro has joined #bitcoin-core-dev
188 2020-01-28T16:28:47  *** aqquadro has quit IRC
189 2020-01-28T16:30:01  *** Talkless has joined #bitcoin-core-dev
190 2020-01-28T16:39:23  *** filchef has joined #bitcoin-core-dev
191 2020-01-28T16:42:58  *** jcoe has joined #bitcoin-core-dev
192 2020-01-28T16:43:15  *** jcoe1 has quit IRC
193 2020-01-28T16:43:57  *** promag has quit IRC
194 2020-01-28T16:44:31  *** promag has joined #bitcoin-core-dev
195 2020-01-28T16:46:28  *** moneyball has quit IRC
196 2020-01-28T16:46:43  *** moneyball has joined #bitcoin-core-dev
197 2020-01-28T16:53:58  *** RubenSomsen has quit IRC
198 2020-01-28T16:54:13  *** RubenSomsen has joined #bitcoin-core-dev
199 2020-01-28T17:02:58  *** dr-orlovsky has joined #bitcoin-core-dev
200 2020-01-28T17:05:16  *** orlovsky has quit IRC
201 2020-01-28T17:10:23  *** andrewtoth has quit IRC
202 2020-01-28T17:14:39  *** dr-orlovsky has quit IRC
203 2020-01-28T17:17:28  *** dr-orlovsky has joined #bitcoin-core-dev
204 2020-01-28T17:23:31  *** orlovsky has joined #bitcoin-core-dev
205 2020-01-28T17:26:08  *** dr-orlovsky has quit IRC
206 2020-01-28T17:39:39  *** bitcoin-git has joined #bitcoin-core-dev
207 2020-01-28T17:39:39  <bitcoin-git> [bitcoin] elichai opened pull request #18014: Optimizing siphash implementation (master...2020-01-siphash) https://github.com/bitcoin/bitcoin/pull/18014
208 2020-01-28T17:39:51  *** bitcoin-git has left #bitcoin-core-dev
209 2020-01-28T17:39:56  *** promag has quit IRC
210 2020-01-28T17:40:11  *** promag has joined #bitcoin-core-dev
211 2020-01-28T17:44:58  *** tryphe_ has joined #bitcoin-core-dev
212 2020-01-28T17:48:10  *** tryphe has quit IRC
213 2020-01-28T17:52:50  <elichai2> I'll do clickbait and say that this PR makes siphash 3X times faster 😉
214 2020-01-28T17:55:46  <provoostenator> AppVeyor is having a tantrum again, lots of failures like this: https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/30410830
215 2020-01-28T17:56:33  * elichai2 sigh 
216 2020-01-28T17:57:21  <provoostenator> (not the same issue as #17976)
217 2020-01-28T17:57:23  <gribble> https://github.com/bitcoin/bitcoin/issues/17976 | Appveyor ci fails again · Issue #17976 · bitcoin/bitcoin · GitHub
218 2020-01-28T18:00:02  *** Guest53426 has quit IRC
219 2020-01-28T18:10:40  *** tecnecio_ has joined #bitcoin-core-dev
220 2020-01-28T18:13:57  <elichai2> No space left on s390x again :/ a kick will be appreciated https://travis-ci.org/bitcoin/bitcoin/jobs/643008022
221 2020-01-28T18:15:24  *** drybjed1 has joined #bitcoin-core-dev
222 2020-01-28T18:17:27  *** promag_ has joined #bitcoin-core-dev
223 2020-01-28T18:21:38  *** promag_ has quit IRC
224 2020-01-28T18:37:18  *** timothy has quit IRC
225 2020-01-28T18:45:10  *** Zenton has quit IRC
226 2020-01-28T18:46:58  *** promag has quit IRC
227 2020-01-28T18:47:40  *** promag has joined #bitcoin-core-dev
228 2020-01-28T18:57:43  <jeremyrubin> wumpus: I think https://github.com/bitcoin/bitcoin/pull/17925 is in a mergeable state (2 acks, 1 looks good)
229 2020-01-28T18:59:37  <wumpus> jeremyrubin: will take a look, tahnks
230 2020-01-28T18:59:55  <wumpus> btw s390 travis build keeps running out of space
231 2020-01-28T19:04:54  *** bitcoin-git has joined #bitcoin-core-dev
232 2020-01-28T19:04:54  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2755b2b1092d...fe48ac8580ae
233 2020-01-28T19:04:55  <bitcoin-git> bitcoin/master 0dae5a5 Elichai Turkel: Fix benchmarks filters
234 2020-01-28T19:04:55  <bitcoin-git> bitcoin/master fe48ac8 MarcoFalke: Merge #18013: bench: Fix benchmarks filters
235 2020-01-28T19:05:06  *** bitcoin-git has left #bitcoin-core-dev
236 2020-01-28T19:05:15  *** ajonas has quit IRC
237 2020-01-28T19:05:24  *** bitcoin-git has joined #bitcoin-core-dev
238 2020-01-28T19:05:24  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18013: bench: Fix benchmarks filters (master...patch-2) https://github.com/bitcoin/bitcoin/pull/18013
239 2020-01-28T19:05:25  *** bitcoin-git has left #bitcoin-core-dev
240 2020-01-28T19:05:27  *** ajonas has joined #bitcoin-core-dev
241 2020-01-28T19:15:58  *** promag_ has joined #bitcoin-core-dev
242 2020-01-28T19:18:35  <achow101> I think #17156 is rtm?
243 2020-01-28T19:18:38  <gribble> https://github.com/bitcoin/bitcoin/issues/17156 | psbt: check that various indexes and amounts are within bounds by achow101 · Pull Request #17156 · bitcoin/bitcoin · GitHub
244 2020-01-28T19:19:24  <achow101> and maybe #17261, tho meshcollider needs to ack it
245 2020-01-28T19:19:26  <gribble> https://github.com/bitcoin/bitcoin/issues/17261 | Make ScriptPubKeyMan an actual interface and the wallet to have multiple by achow101 · Pull Request #17261 · bitcoin/bitcoin · GitHub
246 2020-01-28T19:20:30  *** promag_ has quit IRC
247 2020-01-28T19:21:20  *** promag has quit IRC
248 2020-01-28T19:21:34  *** promag has joined #bitcoin-core-dev
249 2020-01-28T19:40:12  *** vasild_ has joined #bitcoin-core-dev
250 2020-01-28T19:42:34  *** Lexyon___ has quit IRC
251 2020-01-28T19:42:47  *** Lexyon___ has joined #bitcoin-core-dev
252 2020-01-28T19:44:03  *** vasild has quit IRC
253 2020-01-28T19:46:31  *** Guyver2 has joined #bitcoin-core-dev
254 2020-01-28T19:47:03  *** zac94 has quit IRC
255 2020-01-28T19:49:44  <luke-jr> how about #17843 ?
256 2020-01-28T19:49:48  <gribble> https://github.com/bitcoin/bitcoin/issues/17843 | wallet: Reset reused transactions cache by fjahr · Pull Request #17843 · bitcoin/bitcoin · GitHub
257 2020-01-28T20:12:11  *** Talkless has quit IRC
258 2020-01-28T20:12:40  *** bitcoin-git has joined #bitcoin-core-dev
259 2020-01-28T20:12:40  <bitcoin-git> [bitcoin] JeremyRubin closed pull request #17375: Add asymptotes for benchmarking framework (master...asymptotic-benchmarks) https://github.com/bitcoin/bitcoin/pull/17375
260 2020-01-28T20:12:44  *** bitcoin-git has left #bitcoin-core-dev
261 2020-01-28T20:15:35  *** emilengler has quit IRC
262 2020-01-28T20:30:49  *** EagleTM has joined #bitcoin-core-dev
263 2020-01-28T20:37:01  *** promag has quit IRC
264 2020-01-28T20:37:43  *** promag has joined #bitcoin-core-dev
265 2020-01-28T20:39:07  *** vasild_ is now known as vd
266 2020-01-28T20:39:10  *** vd is now known as vasild
267 2020-01-28T20:45:57  *** jarthur has joined #bitcoin-core-dev
268 2020-01-28T20:46:50  *** FeudalBear is now known as justanotheruser
269 2020-01-28T21:00:02  *** drybjed1 has quit IRC
270 2020-01-28T21:14:30  *** promag has quit IRC
271 2020-01-28T21:14:44  *** promag has joined #bitcoin-core-dev
272 2020-01-28T21:15:32  *** dbcooper has joined #bitcoin-core-dev
273 2020-01-28T21:19:39  <fjahr> luke-jr: maybe wrong pr? That one is already merged.
274 2020-01-28T21:24:40  *** promag_ has joined #bitcoin-core-dev
275 2020-01-28T21:25:30  *** scottb856 has joined #bitcoin-core-dev
276 2020-01-28T21:25:46  *** scottb856 has quit IRC
277 2020-01-28T21:32:57  *** Zenton has joined #bitcoin-core-dev
278 2020-01-28T21:35:04  *** francisco has quit IRC
279 2020-01-28T21:35:18  *** francisco has joined #bitcoin-core-dev
280 2020-01-28T21:49:55  <luke-jr> fjahr: not to backports
281 2020-01-28T21:56:16  *** Highway61 has quit IRC
282 2020-01-28T21:57:45  <fjahr> luke-jr: ah ok, i thought you meant rtm :)
283 2020-01-28T21:58:04  <luke-jr> rtm?
284 2020-01-28T21:58:12  <jeremyrubin> ready to merge
285 2020-01-28T22:08:29  *** Highway61 has joined #bitcoin-core-dev
286 2020-01-28T22:11:12  *** Highway62 has joined #bitcoin-core-dev
287 2020-01-28T22:13:25  *** Highway61 has quit IRC
288 2020-01-28T22:13:25  *** Highway62 is now known as Highway61
289 2020-01-28T22:24:06  *** cryptapus has joined #bitcoin-core-dev
290 2020-01-28T22:24:26  *** filchef has quit IRC
291 2020-01-28T22:37:38  *** tecnecio_ has quit IRC
292 2020-01-28T22:40:57  *** bsm117532 has joined #bitcoin-core-dev
293 2020-01-28T22:41:10  *** bsm117532 has left #bitcoin-core-dev
294 2020-01-28T22:57:28  <gwillen> achow101: (or anybody) -- is it possible to have a PSBT with all inputs signed and yet for some reason we can't finalize and extract it
295 2020-01-28T22:57:39  <gwillen> (and is that "in theory" or in practice?)
296 2020-01-28T22:58:07  <achow101> no in theory, yes in practice :p
297 2020-01-28T22:58:17  <achow101> In theory, the finalizer should be pretty dumb
298 2020-01-28T22:58:34  <gwillen> what are the kinds of cases where this can happen in practice?
299 2020-01-28T22:58:37  <achow101> but in practice, it verifies the transaction before spitting it out, so in practice, if you have an invalid signature, it won't finalize
300 2020-01-28T22:58:47  <gwillen> ahhh, interesting
301 2020-01-28T22:58:56  <gwillen> is that the only case you're aware of?
302 2020-01-28T22:59:03  <achow101> yes
303 2020-01-28T22:59:46  <achow101> other cases are usually that you've done something subtly wrong and it isn't actually signed
304 2020-01-28T23:00:54  <sipa> or the scripts used are not understood by the finalizer
305 2020-01-28T23:01:14  *** bsm117532 has joined #bitcoin-core-dev
306 2020-01-28T23:01:25  <sipa> so despite having enough signatures present, the finalizer doesn't know how to combine them into a full satisfying witness
307 2020-01-28T23:01:26  *** jarthur_ has joined #bitcoin-core-dev
308 2020-01-28T23:02:58  *** bsm117532 has quit IRC
309 2020-01-28T23:04:12  <gwillen> I guess actually, from my perspective if I see that an input is "signed" that already means the signature parts have been combined
310 2020-01-28T23:04:26  <gwillen> and as far as I can tell if all inputs are "signed" in that way, then finalization looks like it can't fail
311 2020-01-28T23:04:29  <gwillen> nor extraction
312 2020-01-28T23:05:23  <gwillen> since PSBTInputSigned declares true if it sees a final_script_sig or a final_script_witness
313 2020-01-28T23:05:24  *** jarthur has quit IRC
314 2020-01-28T23:05:59  <gwillen> and extraction does nothing but copy those fields out, it does not check anything as long as they exist (although presumbly broadcast will fail if they're bad)
315 2020-01-28T23:06:12  *** jarthur_ has quit IRC
316 2020-01-28T23:09:05  *** Guyver2 has quit IRC
317 2020-01-28T23:09:51  *** bsm117532 has joined #bitcoin-core-dev
318 2020-01-28T23:10:07  *** bsm117532 has quit IRC
319 2020-01-28T23:11:17  <sipa> gwillen: finalization is creating the final_script_sig etc; if those already exist, then extraction will never fail
320 2020-01-28T23:12:08  <sipa> extraction in theory could run a script verifier first; there should be enough information in psbt to do that
321 2020-01-28T23:13:36  *** ppisati has quit IRC
322 2020-01-28T23:15:20  *** ppisati has joined #bitcoin-core-dev
323 2020-01-28T23:31:32  <achow101> sipa: is there a command line descriptor to script compiler somewhere?
324 2020-01-28T23:33:07  *** promag_ has quit IRC
325 2020-01-28T23:51:35  *** jcoe has quit IRC