1 2020-01-29T00:00:01  *** dbcooper has quit IRC
  2 2020-01-29T00:05:33  *** lnostdal has quit IRC
  3 2020-01-29T00:05:47  *** lnostdal has joined #bitcoin-core-dev
  4 2020-01-29T00:08:29  *** zavan has joined #bitcoin-core-dev
  5 2020-01-29T00:13:17  *** kensanata has joined #bitcoin-core-dev
  6 2020-01-29T00:53:36  *** tryphe_ is now known as tryphe
  7 2020-01-29T01:13:30  *** kristapsk_ is now known as kristapsk
  8 2020-01-29T01:38:09  *** AaronvanW has quit IRC
  9 2020-01-29T01:54:19  *** Victorsueca has joined #bitcoin-core-dev
 10 2020-01-29T01:54:23  *** SiAnDoG_ has joined #bitcoin-core-dev
 11 2020-01-29T01:54:36  *** Victor_sueca has quit IRC
 12 2020-01-29T01:55:36  *** kristapsk has quit IRC
 13 2020-01-29T01:55:36  *** Dean_Guss has quit IRC
 14 2020-01-29T01:55:36  *** SiAnDoG__ has quit IRC
 15 2020-01-29T01:55:51  *** kristapsk has joined #bitcoin-core-dev
 16 2020-01-29T01:55:53  *** Dean_Guss has joined #bitcoin-core-dev
 17 2020-01-29T01:56:43  *** braydonf has quit IRC
 18 2020-01-29T01:57:12  *** braydonf has joined #bitcoin-core-dev
 19 2020-01-29T02:00:33  *** belcher has quit IRC
 20 2020-01-29T02:21:27  *** zavan has quit IRC
 21 2020-01-29T03:00:01  *** kensanata has quit IRC
 22 2020-01-29T03:00:53  *** abrissbi1ne has joined #bitcoin-core-dev
 23 2020-01-29T03:04:20  *** abrissbirne has quit IRC
 24 2020-01-29T03:15:24  *** neutraltc has joined #bitcoin-core-dev
 25 2020-01-29T04:07:02  *** promag has quit IRC
 26 2020-01-29T04:08:51  *** Eagle[TM] has joined #bitcoin-core-dev
 27 2020-01-29T04:11:16  *** EagleTM has quit IRC
 28 2020-01-29T04:22:49  *** frogar has quit IRC
 29 2020-01-29T04:28:58  *** mryandao has quit IRC
 30 2020-01-29T04:29:15  *** mryandao has joined #bitcoin-core-dev
 31 2020-01-29T04:30:39  *** frogar has joined #bitcoin-core-dev
 32 2020-01-29T04:46:29  *** bitcoin-git has joined #bitcoin-core-dev
 33 2020-01-29T04:46:29  <bitcoin-git> [bitcoin] ajtowns opened pull request #18017: txmempool: split epoch logic into class (master...202001-epoch) https://github.com/bitcoin/bitcoin/pull/18017
 34 2020-01-29T04:46:30  *** bitcoin-git has left #bitcoin-core-dev
 35 2020-01-29T05:19:15  *** jb55 has quit IRC
 36 2020-01-29T05:19:42  *** jb55 has joined #bitcoin-core-dev
 37 2020-01-29T05:38:16  *** Dean_Guss has quit IRC
 38 2020-01-29T05:38:39  *** Dean_Guss has joined #bitcoin-core-dev
 39 2020-01-29T05:41:49  *** promag has joined #bitcoin-core-dev
 40 2020-01-29T05:45:04  *** promag_ has joined #bitcoin-core-dev
 41 2020-01-29T05:47:25  *** bitcoin-git has joined #bitcoin-core-dev
 42 2020-01-29T05:47:25  <bitcoin-git> [bitcoin] fanquake opened pull request #18018: tests: reset fIsBareMultisigStd after bare-multisig tests (master...fix_p2sh_tests_failure) https://github.com/bitcoin/bitcoin/pull/18018
 43 2020-01-29T05:47:37  *** bitcoin-git has left #bitcoin-core-dev
 44 2020-01-29T05:50:07  *** promag_ has quit IRC
 45 2020-01-29T06:00:01  *** neutraltc has quit IRC
 46 2020-01-29T06:00:47  *** retr0 has joined #bitcoin-core-dev
 47 2020-01-29T06:13:00  *** retr0 has quit IRC
 48 2020-01-29T06:18:31  *** abrissbi1ne is now known as abrissbirne
 49 2020-01-29T06:29:03  *** Dean_Guss has quit IRC
 50 2020-01-29T06:39:34  *** bitcoin-git has joined #bitcoin-core-dev
 51 2020-01-29T06:39:34  <bitcoin-git> [bitcoin] Bushstar closed pull request #18012: GBT segwit rule in RPC error msg missing single quotes (master...patch-5) https://github.com/bitcoin/bitcoin/pull/18012
 52 2020-01-29T06:39:36  *** bitcoin-git has left #bitcoin-core-dev
 53 2020-01-29T06:42:11  *** luto1 has joined #bitcoin-core-dev
 54 2020-01-29T06:44:03  *** abacus has quit IRC
 55 2020-01-29T06:46:33  *** hardforkthis7 has quit IRC
 56 2020-01-29T06:46:52  *** hardforkthis7 has joined #bitcoin-core-dev
 57 2020-01-29T06:50:10  *** abacus has joined #bitcoin-core-dev
 58 2020-01-29T06:54:33  *** abacus has quit IRC
 59 2020-01-29T06:55:13  *** abacus has joined #bitcoin-core-dev
 60 2020-01-29T07:08:15  *** goatpig has joined #bitcoin-core-dev
 61 2020-01-29T07:13:54  *** asoltys has quit IRC
 62 2020-01-29T07:15:02  *** asoltys has joined #bitcoin-core-dev
 63 2020-01-29T07:23:57  *** tecnecio_ has joined #bitcoin-core-dev
 64 2020-01-29T07:26:57  *** Eagle[TM] has quit IRC
 65 2020-01-29T07:28:23  *** abacus has quit IRC
 66 2020-01-29T07:34:04  *** PaulTroon has joined #bitcoin-core-dev
 67 2020-01-29T07:40:05  *** abacus has joined #bitcoin-core-dev
 68 2020-01-29T07:43:23  *** vasild has quit IRC
 69 2020-01-29T07:45:05  *** abacus has quit IRC
 70 2020-01-29T07:45:09  *** vasild has joined #bitcoin-core-dev
 71 2020-01-29T07:52:25  *** abacus has joined #bitcoin-core-dev
 72 2020-01-29T08:05:05  *** IGHOR has quit IRC
 73 2020-01-29T08:06:03  *** mryandao has quit IRC
 74 2020-01-29T08:06:58  *** mryandao has joined #bitcoin-core-dev
 75 2020-01-29T08:07:46  *** promag has quit IRC
 76 2020-01-29T08:07:59  *** promag has joined #bitcoin-core-dev
 77 2020-01-29T08:08:00  *** gribble has quit IRC
 78 2020-01-29T08:14:04  *** promag has quit IRC
 79 2020-01-29T08:21:48  *** gribble has joined #bitcoin-core-dev
 80 2020-01-29T08:28:11  *** IGHOR has joined #bitcoin-core-dev
 81 2020-01-29T08:29:14  *** torstein18 has joined #bitcoin-core-dev
 82 2020-01-29T08:34:03  *** torstein18 has quit IRC
 83 2020-01-29T08:36:08  *** torstein18 has joined #bitcoin-core-dev
 84 2020-01-29T08:40:20  *** torstein18 has quit IRC
 85 2020-01-29T08:40:38  *** torstein18 has joined #bitcoin-core-dev
 86 2020-01-29T08:41:19  *** torstein18 has joined #bitcoin-core-dev
 87 2020-01-29T09:00:02  *** luto1 has quit IRC
 88 2020-01-29T09:08:21  *** promag has joined #bitcoin-core-dev
 89 2020-01-29T09:11:08  *** peutetre has joined #bitcoin-core-dev
 90 2020-01-29T09:37:07  *** AaronvanW has joined #bitcoin-core-dev
 91 2020-01-29T09:47:23  *** Emcy has quit IRC
 92 2020-01-29T10:00:05  *** jcoe has joined #bitcoin-core-dev
 93 2020-01-29T10:23:06  *** AaronvanW has quit IRC
 94 2020-01-29T10:27:29  *** timothy has joined #bitcoin-core-dev
 95 2020-01-29T10:32:50  *** PaulTroon has quit IRC
 96 2020-01-29T10:40:16  *** timothy has quit IRC
 97 2020-01-29T10:40:27  *** Emcy has joined #bitcoin-core-dev
 98 2020-01-29T10:45:05  *** Guyver2 has joined #bitcoin-core-dev
 99 2020-01-29T11:03:56  *** Alessandra22Mori has joined #bitcoin-core-dev
100 2020-01-29T11:05:23  *** belcher has joined #bitcoin-core-dev
101 2020-01-29T11:38:27  *** orlovsky has quit IRC
102 2020-01-29T11:40:51  *** bitcoin-git has joined #bitcoin-core-dev
103 2020-01-29T11:40:52  <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/fe48ac8580ae...1326092e6cef
104 2020-01-29T11:40:52  <bitcoin-git> bitcoin/master f1ef7f0 Andrew Chow: Don't calculate tx fees for PSBTs with invalid money values
105 2020-01-29T11:40:53  <bitcoin-git> bitcoin/master deaa6dd Andrew Chow: psbt: check output index is within bounds before accessing
106 2020-01-29T11:40:54  <bitcoin-git> bitcoin/master 1326092 fanquake: Merge #17156: psbt: check that various indexes and amounts are within boun...
107 2020-01-29T11:40:55  *** bitcoin-git has left #bitcoin-core-dev
108 2020-01-29T11:41:36  *** bitcoin-git has joined #bitcoin-core-dev
109 2020-01-29T11:41:36  <bitcoin-git> [bitcoin] fanquake merged pull request #17156: psbt: check that various indexes and amounts are within bounds (master...psbt-fuzz-fix) https://github.com/bitcoin/bitcoin/pull/17156
110 2020-01-29T11:41:37  *** bitcoin-git has left #bitcoin-core-dev
111 2020-01-29T11:48:57  *** dr-orlovsky has joined #bitcoin-core-dev
112 2020-01-29T11:49:03  *** dr-orlovsky has quit IRC
113 2020-01-29T12:00:01  *** peutetre has quit IRC
114 2020-01-29T12:00:13  *** Emcy has quit IRC
115 2020-01-29T12:02:39  *** Emcy has joined #bitcoin-core-dev
116 2020-01-29T12:10:15  *** AIM` has joined #bitcoin-core-dev
117 2020-01-29T12:10:25  *** Alessandra22Mori has quit IRC
118 2020-01-29T12:16:36  *** bitcoin-git has joined #bitcoin-core-dev
119 2020-01-29T12:16:36  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1326092e6cef...e061b8dc8fba
120 2020-01-29T12:16:37  <bitcoin-git> bitcoin/master e80317b Bushstar: refactor: Remove redundant conditional
121 2020-01-29T12:16:37  <bitcoin-git> bitcoin/master e061b8d fanquake: Merge #17971: refactor: Remove redundant conditional
122 2020-01-29T12:16:39  *** bitcoin-git has left #bitcoin-core-dev
123 2020-01-29T12:16:56  *** bitcoin-git has joined #bitcoin-core-dev
124 2020-01-29T12:16:56  <bitcoin-git> [bitcoin] fanquake merged pull request #17971: refactor: Remove redundant conditional (master...remove-redundant-conditional) https://github.com/bitcoin/bitcoin/pull/17971
125 2020-01-29T12:16:57  *** bitcoin-git has left #bitcoin-core-dev
126 2020-01-29T12:23:09  *** PaulTroon has joined #bitcoin-core-dev
127 2020-01-29T12:26:35  *** Skirmant has joined #bitcoin-core-dev
128 2020-01-29T12:31:20  *** Skirmant has quit IRC
129 2020-01-29T12:34:56  <fanquake> Thanks fjahr
130 2020-01-29T12:35:19  <fjahr> fanquake: sure :)
131 2020-01-29T12:49:20  *** bitcoin-git has joined #bitcoin-core-dev
132 2020-01-29T12:49:21  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e061b8dc8fba...c434282d2cb8
133 2020-01-29T12:49:21  <bitcoin-git> bitcoin/master b35567f fanquake: test: only declare a main() when fuzzing with AFL
134 2020-01-29T12:49:22  <bitcoin-git> bitcoin/master c434282 fanquake: Merge #18008: test: only declare a main() when fuzzing with AFL
135 2020-01-29T12:49:31  *** bitcoin-git has left #bitcoin-core-dev
136 2020-01-29T12:49:50  *** bitcoin-git has joined #bitcoin-core-dev
137 2020-01-29T12:49:51  <bitcoin-git> [bitcoin] fanquake merged pull request #18008: test: only declare a main() when fuzzing with AFL (master...macos_libfuzzer_weak_main) https://github.com/bitcoin/bitcoin/pull/18008
138 2020-01-29T12:49:51  *** bitcoin-git has left #bitcoin-core-dev
139 2020-01-29T12:50:30  *** filchef has joined #bitcoin-core-dev
140 2020-01-29T12:56:17  *** bitcoin-git has joined #bitcoin-core-dev
141 2020-01-29T12:56:19  <bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/c434282d2cb8...01fc5891fb57
142 2020-01-29T12:56:19  <bitcoin-git> bitcoin/master 8feb4e4 Gleb Naumenko:  Add asmap utility which queries a mapping
143 2020-01-29T12:56:20  <bitcoin-git> bitcoin/master ec45646 Gleb Naumenko: Integrate ASN bucketing in Addrman and add tests
144 2020-01-29T12:56:21  <bitcoin-git> bitcoin/master e4658aa Gleb Naumenko: Return mapped AS in RPC call getpeerinfo
145 2020-01-29T12:56:28  *** bitcoin-git has left #bitcoin-core-dev
146 2020-01-29T12:57:12  *** bitcoin-git has joined #bitcoin-core-dev
147 2020-01-29T12:57:12  <bitcoin-git> [bitcoin] laanwj merged pull request #16702: p2p: supplying and using asmap to improve IP bucketing in addrman (master...asn_buckets) https://github.com/bitcoin/bitcoin/pull/16702
148 2020-01-29T12:57:13  *** bitcoin-git has left #bitcoin-core-dev
149 2020-01-29T13:00:49  *** promag has quit IRC
150 2020-01-29T13:10:32  *** real_or_random has joined #bitcoin-core-dev
151 2020-01-29T13:19:20  *** bitcoin-git has joined #bitcoin-core-dev
152 2020-01-29T13:19:20  <bitcoin-git> [bitcoin] laanwj closed pull request #17514: util: Make logging noexcept (master...2019_11_logging_noexcept) https://github.com/bitcoin/bitcoin/pull/17514
153 2020-01-29T13:19:21  *** bitcoin-git has left #bitcoin-core-dev
154 2020-01-29T13:23:24  *** promag has joined #bitcoin-core-dev
155 2020-01-29T13:28:07  *** promag has quit IRC
156 2020-01-29T13:37:08  *** jonatack has quit IRC
157 2020-01-29T13:47:49  *** bitcoin-git has joined #bitcoin-core-dev
158 2020-01-29T13:47:49  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/01fc5891fb57...3b5b27673414
159 2020-01-29T13:47:50  <bitcoin-git> bitcoin/master b6c3e84 Fabian Jahr: doc: Improve fuzzing docs for macOS users
160 2020-01-29T13:47:50  <bitcoin-git> bitcoin/master 3b5b276 MarcoFalke: Merge #17942: doc: Improve fuzzing docs for macOS users
161 2020-01-29T13:47:52  *** bitcoin-git has left #bitcoin-core-dev
162 2020-01-29T13:48:09  *** bitcoin-git has joined #bitcoin-core-dev
163 2020-01-29T13:48:09  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17942: doc: Improve fuzzing docs for macOS users (master...fuzzing_docs) https://github.com/bitcoin/bitcoin/pull/17942
164 2020-01-29T13:48:11  *** bitcoin-git has left #bitcoin-core-dev
165 2020-01-29T13:53:45  *** Highway61 has quit IRC
166 2020-01-29T13:59:15  <wumpus> replaced #17892 with #17994 in high prio
167 2020-01-29T13:59:19  <gribble> https://github.com/bitcoin/bitcoin/issues/17892 | bug-fix: delay flushing undo files until after they are finalized by kallewoof · Pull Request #17892 · bitcoin/bitcoin · GitHub
168 2020-01-29T13:59:20  <gribble> https://github.com/bitcoin/bitcoin/issues/17994 | validation: flush undo files after last block write by kallewoof · Pull Request #17994 · bitcoin/bitcoin · GitHub
169 2020-01-29T14:02:11  *** setpill has joined #bitcoin-core-dev
170 2020-01-29T14:08:06  *** promag has joined #bitcoin-core-dev
171 2020-01-29T14:11:38  *** bitcoin-git has joined #bitcoin-core-dev
172 2020-01-29T14:11:39  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3b5b27673414...c1607b5df487
173 2020-01-29T14:11:40  <bitcoin-git> bitcoin/master ca34c5c Pieter Wuille: Add FORMATTER_METHODS, similar to SERIALIZE_METHODS, but for formatters
174 2020-01-29T14:11:40  <bitcoin-git> bitcoin/master 4de934b Pieter Wuille: Convert compression.h to new serialization framework
175 2020-01-29T14:11:41  <bitcoin-git> bitcoin/master c1607b5 Wladimir J. van der Laan: Merge #17957: Serialization improvements step 3 (compression.h)
176 2020-01-29T14:11:42  *** bitcoin-git has left #bitcoin-core-dev
177 2020-01-29T14:11:56  *** bitcoin-git has joined #bitcoin-core-dev
178 2020-01-29T14:11:57  <bitcoin-git> [bitcoin] laanwj merged pull request #17957: Serialization improvements step 3 (compression.h) (master...202001_noncastserial_3) https://github.com/bitcoin/bitcoin/pull/17957
179 2020-01-29T14:12:09  *** bitcoin-git has left #bitcoin-core-dev
180 2020-01-29T14:19:12  *** PaulTroon has quit IRC
181 2020-01-29T14:19:43  *** Highway61 has joined #bitcoin-core-dev
182 2020-01-29T14:20:27  *** PaulTroon has joined #bitcoin-core-dev
183 2020-01-29T14:30:02  *** jb55 has quit IRC
184 2020-01-29T14:30:31  *** jb55 has joined #bitcoin-core-dev
185 2020-01-29T14:48:17  *** jonatack has joined #bitcoin-core-dev
186 2020-01-29T14:55:45  *** bitcoin-git has joined #bitcoin-core-dev
187 2020-01-29T14:55:45  <bitcoin-git> [bitcoin] sdaftuar closed pull request #16401: Add package acceptance logic to mempool (master...2019-07-package-relay) https://github.com/bitcoin/bitcoin/pull/16401
188 2020-01-29T14:55:46  *** bitcoin-git has left #bitcoin-core-dev
189 2020-01-29T15:00:01  *** AIM` has quit IRC
190 2020-01-29T15:04:04  *** jonatack has quit IRC
191 2020-01-29T15:05:16  *** rex4539 has joined #bitcoin-core-dev
192 2020-01-29T15:05:35  *** csknk has joined #bitcoin-core-dev
193 2020-01-29T15:12:17  *** timothy has joined #bitcoin-core-dev
194 2020-01-29T15:15:54  *** dr-orlovsky has joined #bitcoin-core-dev
195 2020-01-29T15:19:42  *** timothy has quit IRC
196 2020-01-29T15:21:43  *** timothy has joined #bitcoin-core-dev
197 2020-01-29T15:31:23  *** timothy has quit IRC
198 2020-01-29T15:34:15  *** timothy has joined #bitcoin-core-dev
199 2020-01-29T15:35:22  *** cpow has joined #bitcoin-core-dev
200 2020-01-29T15:43:12  *** dr-orlovsky has quit IRC
201 2020-01-29T15:44:52  *** Emcy has quit IRC
202 2020-01-29T15:45:48  *** dr-orlovsky has joined #bitcoin-core-dev
203 2020-01-29T15:48:55  *** goatpig has quit IRC
204 2020-01-29T15:53:02  *** felixfoertsch has quit IRC
205 2020-01-29T15:53:13  *** felixfoertsch23 has joined #bitcoin-core-dev
206 2020-01-29T16:00:10  *** dr-orlovsky has quit IRC
207 2020-01-29T16:02:54  *** dr-orlovsky has joined #bitcoin-core-dev
208 2020-01-29T16:05:04  *** tsujp has joined #bitcoin-core-dev
209 2020-01-29T16:15:35  *** setpill has quit IRC
210 2020-01-29T16:16:05  *** dr-orlovsky has quit IRC
211 2020-01-29T16:19:48  *** dr-orlovsky has joined #bitcoin-core-dev
212 2020-01-29T16:21:53  *** frankie has joined #bitcoin-core-dev
213 2020-01-29T16:22:17  *** frankie is now known as Guest41554
214 2020-01-29T16:27:28  *** Talkless has joined #bitcoin-core-dev
215 2020-01-29T16:27:44  *** Talkless has quit IRC
216 2020-01-29T16:28:28  *** Talkless has joined #bitcoin-core-dev
217 2020-01-29T16:31:03  *** Guest41554 has quit IRC
218 2020-01-29T16:31:44  *** Highway61 has joined #bitcoin-core-dev
219 2020-01-29T16:34:56  *** dr-orlovsky has quit IRC
220 2020-01-29T16:37:05  *** davterra has joined #bitcoin-core-dev
221 2020-01-29T16:38:27  *** prettycolors has quit IRC
222 2020-01-29T16:43:35  *** goatpig has joined #bitcoin-core-dev
223 2020-01-29T16:48:27  *** dr-orlovsky has joined #bitcoin-core-dev
224 2020-01-29T16:54:47  *** dr-orlovsky has quit IRC
225 2020-01-29T17:05:45  *** Deacyde has joined #bitcoin-core-dev
226 2020-01-29T17:05:59  *** Deacyde has quit IRC
227 2020-01-29T17:07:21  *** Deacyde has joined #bitcoin-core-dev
228 2020-01-29T17:08:16  *** jonatack has joined #bitcoin-core-dev
229 2020-01-29T17:12:43  *** ghost43 has quit IRC
230 2020-01-29T17:12:56  *** jonatack has quit IRC
231 2020-01-29T17:12:57  *** ghost43_ has joined #bitcoin-core-dev
232 2020-01-29T17:13:44  *** jonatack has joined #bitcoin-core-dev
233 2020-01-29T17:14:47  *** emilengler has joined #bitcoin-core-dev
234 2020-01-29T17:20:48  *** andrewtoth has joined #bitcoin-core-dev
235 2020-01-29T17:23:13  *** Highway61 has quit IRC
236 2020-01-29T17:23:54  *** Emcy has joined #bitcoin-core-dev
237 2020-01-29T17:29:49  *** millerti has joined #bitcoin-core-dev
238 2020-01-29T17:37:07  *** kiwi_74 has joined #bitcoin-core-dev
239 2020-01-29T17:41:04  *** kiwi_74 has quit IRC
240 2020-01-29T17:49:42  *** hanhua has joined #bitcoin-core-dev
241 2020-01-29T17:52:42  *** pelt has joined #bitcoin-core-dev
242 2020-01-29T18:00:01  *** cpow has quit IRC
243 2020-01-29T18:03:37  *** jarthur has joined #bitcoin-core-dev
244 2020-01-29T18:04:32  *** michaelfolkson has joined #bitcoin-core-dev
245 2020-01-29T18:11:41  *** wgolden has joined #bitcoin-core-dev
246 2020-01-29T18:14:13  *** tsujp has quit IRC
247 2020-01-29T18:15:40  *** Highway61 has joined #bitcoin-core-dev
248 2020-01-29T18:21:13  *** tsujp has joined #bitcoin-core-dev
249 2020-01-29T18:28:41  <jeremyrubin> Anyone opposed to adding a reference to review #15465 in the style guide?
250 2020-01-29T18:28:43  <gribble> https://github.com/bitcoin/bitcoin/issues/15465 | Code style PRs after v0.18 branch split · Issue #15465 · bitcoin/bitcoin · GitHub
251 2020-01-29T19:01:22  *** PaulTroon has quit IRC
252 2020-01-29T19:07:52  <jonatack> jeremyrubin: I learned a great deal from reading and taking notes on the discussion in that PR. Out of curiosity were there particular comments you are referring to?
253 2020-01-29T19:10:40  <gwillen> jeremyrubin: like, adding it as a reference / further explanation where the styleguide talks about when one should or should not make style changes?
254 2020-01-29T19:10:48  <gwillen> (and to encourage people not to argue about it without reading this first? :-) )
255 2020-01-29T19:16:13  <jeremyrubin> yeah
256 2020-01-29T19:16:39  *** michaelfolkson has quit IRC
257 2020-01-29T19:24:26  *** tripleslash has joined #bitcoin-core-dev
258 2020-01-29T19:30:55  *** bitcoin-git has joined #bitcoin-core-dev
259 2020-01-29T19:30:56  <bitcoin-git> [bitcoin] sipa opened pull request #18021: Serialization improvements step 4 (undo.h) (master...202001_noncastserial_4) https://github.com/bitcoin/bitcoin/pull/18021
260 2020-01-29T19:30:56  *** bitcoin-git has left #bitcoin-core-dev
261 2020-01-29T19:31:38  <gwillen> jeremyrubin: I feel like after reading that thread, one thing that I would love to see would be guidelines for how to _review_ PRs
262 2020-01-29T19:32:25  <jeremyrubin> Certainly. I don't want to point at specific examples, as it's a bit more of a general issue with review presently.
263 2020-01-29T19:32:53  <gwillen> yeah, and I think it's absolutely not bitcoin-specific, I have had similar problems with code review processes in most contexts where I've had code review
264 2020-01-29T19:33:03  <jeremyrubin> But the way I think about style is it's a sub-goal. And as long as the style is flagrantly bad, focusing on the substance of a PR and correctness are priroties
265 2020-01-29T19:33:30  <gwillen> is not* I think you meant, but yeah
266 2020-01-29T19:33:42  <jeremyrubin> yes
267 2020-01-29T19:33:53  * jeremyrubin adds whitespace to the end of every line
268 2020-01-29T19:34:10  <jeremyrubin> I also think that unlike other projects perhaps we have a low trust environment, which means that re-review is particularly annoying
269 2020-01-29T19:34:21  <gwillen> I think a more-structured review process would be helpful, i.e. "currently we are in design review, next we will be in general code review, then after that is nitpick review"
270 2020-01-29T19:34:25  <jonatack> gwillen: been working on guidelines since last Spring https://jonatack.github.io/articles/how-to-review-pull-requests-in-bitcoin-core
271 2020-01-29T19:34:43  <jeremyrubin> Paired with a culture of preferring squashed branches it's kind of annoying because you trigger re-review for all prior reviewers
272 2020-01-29T19:34:54  <jeremyrubin> Which can then add weeks to the cycle of a PR
273 2020-01-29T19:35:18  <gwillen> one problem with any kind of more structured review is that, as you say it's a bit low-trust, and the longer your PR is open the more likely you are to draw a comment that says "please make huge changes", which has a good chance of killing your work
274 2020-01-29T19:35:21  *** tripleslash is now known as imsaguy
275 2020-01-29T19:35:29  <sipa> really? i've never felt that requests for squashing delay things
276 2020-01-29T19:35:32  *** jcoe has quit IRC
277 2020-01-29T19:35:34  *** imsaguy is now known as [\\\]
278 2020-01-29T19:36:45  <gwillen> well, if you require everybody to re-ack after squash because the commit ID changed, it seems like it would be surprising if it did not create dleay?
279 2020-01-29T19:36:58  <sipa> sure, but those acks are trivial
280 2020-01-29T19:37:17  <sipa> i mean, obviously it adds something... but i've never seen that being a problem
281 2020-01-29T19:38:08  <jeremyrubin> I think they're also just not worth it -- people are likely to be less dilligent in their re-review unless they are actually fetching the branch and diffiing
282 2020-01-29T19:38:37  <sipa> i don't think so
283 2020-01-29T19:38:47  <sipa> the majority of the work when reviewing a PR is understanding it
284 2020-01-29T19:38:57  <gwillen> I have indeed been fetching the branch and diffing the squash
285 2020-01-29T19:39:16  <jeremyrubin> Anyways the squashing is a minor issue sipa
286 2020-01-29T19:39:18  <sipa> a re-review can be much faster, even if you diligently read every line again, just because you already know what's going on
287 2020-01-29T19:39:22  <sipa> jeremyrubin: fair
288 2020-01-29T19:39:37  <jeremyrubin> I think that if it's a functional change, fixing a bug, yes, squash it
289 2020-01-29T19:39:42  <gwillen> just as a matter of policy I'm not comfortable giving an ack unless I'm confident I know exactly what changed since my last ack
290 2020-01-29T19:40:14  *** vasild_ has joined #bitcoin-core-dev
291 2020-01-29T19:40:21  <gwillen> but also I tend not to be comfortable giving an ack without a pretty detailed understanding of the change, to the point where doing a re-review (without a diff-since-last-review) does feel like a significant burden
292 2020-01-29T19:40:26  <jeremyrubin> but for things like comments improvements or renaming variables for semantics it's not a great use of contributor time compared to a separate fix up
293 2020-01-29T19:40:58  <gwillen> is everybody aware that git will show you the diff across a force-push (usually) if you click the words 'force push'
294 2020-01-29T19:41:14  <jeremyrubin> click?
295 2020-01-29T19:41:32  <sipa> sure, comment improvements can totally be separate commits
296 2020-01-29T19:41:42  <gwillen> sorry, github, oops. I have become the thing I despise XD
297 2020-01-29T19:42:19  <sipa> git push --force will also show you the diff (in the form of commitid..commitid)
298 2020-01-29T19:42:28  <jeremyrubin> sipa: I think this is all we're expressing is a desire to better contextualize when that's OK to just be like "address this later"
299 2020-01-29T19:42:52  <sipa> jeremyrubin: i think those things are mostly up to the author really
300 2020-01-29T19:43:01  <jeremyrubin> Because pointing to a doc or something that says "in general, style changes are not worth a re-ack unless the author wants to" is good
301 2020-01-29T19:43:03  *** vasild has quit IRC
302 2020-01-29T19:44:18  <jeremyrubin> I like jonatack's doc
303 2020-01-29T19:44:23  <gwillen> it's a little tricky because I'd say you want at least one person other than the contributor to carefully examine it enough to say "yes, this is indeed just a style change"
304 2020-01-29T19:44:25  <jonatack> gwillen: even if GitHub can show the diff, i reckon it's best to do git diffing locally after pulling the changes, moreso for final acks
305 2020-01-29T19:44:59  <gwillen> jonatack: I agree, but I discovered the other day that if you don't have all the previous branch heads after a force push, you can't easily get them to diff them
306 2020-01-29T19:45:05  <jonatack> jeremyrubin: thanks, looks like i need to add a section about re-acking and git diffing
307 2020-01-29T19:45:06  <gwillen> there's a trick but it's annoying
308 2020-01-29T19:46:53  <jonatack> gwillen: agreed, pulling prev branch heads seems par for the course
309 2020-01-29T19:46:53  *** AaronvanW has joined #bitcoin-core-dev
310 2020-01-29T19:47:36  <gwillen> well in particular, after a force push of a PR branch from X to Y, if you do not already have X locally, you can't easily get X in order to "git diff X Y"
311 2020-01-29T19:47:51  <gwillen> you have to have already done it (which I guess is a good habit to be in anyway, having reviewed it)
312 2020-01-29T19:48:02  <sipa> some reviewers prefer not rebasing unless necessary (even if you're rewriting commits)
313 2020-01-29T19:48:59  <jeremyrubin> it also might not be the worst to have it be a maintainer script that we maintain a master unsquashed and a master squashed branch -- where master squashed squashes all commits prefixed as a fixup@<hash> to fixup @hash
314 2020-01-29T19:49:14  <jeremyrubin> retract that idea
315 2020-01-29T19:49:18  <jeremyrubin> sounds like a nightmare
316 2020-01-29T19:50:10  <sipa> at some point it's a tradeoff between tangible benefits and process overhead
317 2020-01-29T19:51:51  <jeremyrubin> I think it's reasonable to say that style/whatever fixes don't need a rebase. But if there's a bug, which requires a fix, it actually *should* invalidate all acks, because they missed the bug.
318 2020-01-29T19:53:37  *** vasild_ is now known as vasild
319 2020-01-29T19:53:41  <jeremyrubin> Anyways, jonatack if you were to make a PR for the "How to Review in Core" guide I think it could be acceptable.
320 2020-01-29T19:54:57  <jonatack> jeremyrubin: I still update it frequently, but maybe when it settles down
321 2020-01-29T20:10:50  *** bitcoin-git has joined #bitcoin-core-dev
322 2020-01-29T20:10:51  <bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c1607b5df487...aabec94541e2
323 2020-01-29T20:10:51  <bitcoin-git> bitcoin/master f41d589 Antoine Riard: Document better -keypool as a look-ahead safety mechanism
324 2020-01-29T20:10:52  <bitcoin-git> bitcoin/master aabec94 Samuel Dobson: Merge #17719: Document better -keypool as a look-ahead safety mechanism
325 2020-01-29T20:10:54  *** bitcoin-git has left #bitcoin-core-dev
326 2020-01-29T20:11:10  *** bitcoin-git has joined #bitcoin-core-dev
327 2020-01-29T20:11:11  <bitcoin-git> [bitcoin] meshcollider merged pull request #17719: Document better -keypool as a look-ahead safety mechanism (master...2019-12-improve-keypool-doc) https://github.com/bitcoin/bitcoin/pull/17719
328 2020-01-29T20:11:12  *** bitcoin-git has left #bitcoin-core-dev
329 2020-01-29T20:11:20  *** dr-orlovsky has joined #bitcoin-core-dev
330 2020-01-29T20:12:21  *** pelt has quit IRC
331 2020-01-29T20:13:06  *** AaronvanW has quit IRC
332 2020-01-29T20:14:09  *** orlovsky has joined #bitcoin-core-dev
333 2020-01-29T20:14:10  *** PaulTroon has joined #bitcoin-core-dev
334 2020-01-29T20:17:34  *** dr-orlovsky has quit IRC
335 2020-01-29T20:30:27  *** emilengler has quit IRC
336 2020-01-29T20:31:39  *** rex4539 has quit IRC
337 2020-01-29T20:33:35  *** Talkless has quit IRC
338 2020-01-29T20:34:54  *** [\\\] is now known as tripleslash
339 2020-01-29T20:35:32  *** EagleTM has joined #bitcoin-core-dev
340 2020-01-29T20:40:19  *** rex4539 has joined #bitcoin-core-dev
341 2020-01-29T20:53:41  <elichai2> <<jeremyrubin> > Anyways, jonatack if you were to make a PR for the "How to Review in Core" guide I think it could be acceptable. I'd definitely like to read it :)
342 2020-01-29T20:57:12  *** jonatack has quit IRC
343 2020-01-29T21:00:01  *** wgolden has quit IRC
344 2020-01-29T21:03:26  *** goatpig has quit IRC
345 2020-01-29T21:03:27  *** tecnecio_ has quit IRC
346 2020-01-29T21:03:59  *** manantial has joined #bitcoin-core-dev
347 2020-01-29T21:10:31  *** manantial has quit IRC
348 2020-01-29T21:12:15  *** manantial has joined #bitcoin-core-dev
349 2020-01-29T21:15:35  *** kpyke has joined #bitcoin-core-dev
350 2020-01-29T21:45:01  *** filchef has quit IRC
351 2020-01-29T21:52:04  *** dr-orlovsky has joined #bitcoin-core-dev
352 2020-01-29T21:53:21  *** orlovsky has quit IRC
353 2020-01-29T21:58:40  *** bitcoin-git has joined #bitcoin-core-dev
354 2020-01-29T21:58:40  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18022: test: Fix appveyor test_bitcoin build of *.raw (master...2001-winTestRaw) https://github.com/bitcoin/bitcoin/pull/18022
355 2020-01-29T21:58:41  *** bitcoin-git has left #bitcoin-core-dev
356 2020-01-29T22:01:46  *** csknk has quit IRC
357 2020-01-29T22:03:50  *** PaulTroon has quit IRC
358 2020-01-29T22:06:16  *** Guyver2 has quit IRC
359 2020-01-29T22:14:34  *** meshcollider has quit IRC
360 2020-01-29T22:15:31  *** jarthur has quit IRC
361 2020-01-29T22:26:08  *** EagleTM has quit IRC
362 2020-01-29T22:40:09  *** dr-orlovsky has quit IRC
363 2020-01-29T22:41:24  *** dr-orlovsky has joined #bitcoin-core-dev
364 2020-01-29T22:52:56  *** AaronvanW has joined #bitcoin-core-dev
365 2020-01-29T23:05:17  *** hanhua has quit IRC
366 2020-01-29T23:08:40  *** bitcoin-git has joined #bitcoin-core-dev
367 2020-01-29T23:08:40  <bitcoin-git> [bitcoin] sipa opened pull request #18023: Some asmap improvements (master...202001_asmap_nits) https://github.com/bitcoin/bitcoin/pull/18023
368 2020-01-29T23:08:42  *** bitcoin-git has left #bitcoin-core-dev
369 2020-01-29T23:15:30  *** bitcoin-git has joined #bitcoin-core-dev
370 2020-01-29T23:15:30  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/aabec94541e2...638239de7502
371 2020-01-29T23:15:31  <bitcoin-git> bitcoin/master fa1a46e MarcoFalke: build: Fix appveyor test_bitcoin build of *.raw
372 2020-01-29T23:15:32  <bitcoin-git> bitcoin/master 638239d MarcoFalke: Merge #18022: test: Fix appveyor test_bitcoin build of *.raw
373 2020-01-29T23:15:40  *** bitcoin-git has left #bitcoin-core-dev
374 2020-01-29T23:15:55  *** bitcoin-git has joined #bitcoin-core-dev
375 2020-01-29T23:15:55  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18022: test: Fix appveyor test_bitcoin build of *.raw (master...2001-winTestRaw) https://github.com/bitcoin/bitcoin/pull/18022
376 2020-01-29T23:15:57  *** bitcoin-git has left #bitcoin-core-dev
377 2020-01-29T23:36:51  *** timothy has quit IRC
378 2020-01-29T23:41:14  *** rex4539 has quit IRC