12020-02-05T00:00:01  *** SRV_DW20 has quit IRC
  22020-02-05T00:08:01  *** _andrewtoth_ has joined #bitcoin-core-dev
  32020-02-05T00:09:03  *** andrewtoth_ has quit IRC
  42020-02-05T00:10:08  *** turbo_choo has joined #bitcoin-core-dev
  52020-02-05T00:11:56  *** AaronvanW has quit IRC
  62020-02-05T00:16:11  *** AaronvanW has joined #bitcoin-core-dev
  72020-02-05T00:17:55  *** mreider has joined #bitcoin-core-dev
  82020-02-05T00:20:27  *** AaronvanW has quit IRC
  92020-02-05T00:21:03  *** _andrewtoth_ has quit IRC
 102020-02-05T00:27:17  *** DaleBewan has joined #bitcoin-core-dev
 112020-02-05T00:31:51  *** PaulTroon has quit IRC
 122020-02-05T00:31:52  *** DaleBewan has quit IRC
 132020-02-05T00:33:03  *** DaleBewan has joined #bitcoin-core-dev
 142020-02-05T00:37:56  *** DaleBewan has quit IRC
 152020-02-05T00:38:21  *** jarthur_ has joined #bitcoin-core-dev
 162020-02-05T00:42:23  *** jarthur has quit IRC
 172020-02-05T00:42:51  *** jarthur_ has quit IRC
 182020-02-05T00:45:34  *** bitcoin-git has joined #bitcoin-core-dev
 192020-02-05T00:45:34  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f32564f0a73c...8625446b4d86
 202020-02-05T00:45:34  <bitcoin-git> bitcoin/master 317fb96 Rjected: Add search for first blk file with pruned node
 212020-02-05T00:45:35  <bitcoin-git> bitcoin/master 8625446 fanquake: Merge #17336: scripts: search for first block file for linearize-data with...
 222020-02-05T00:45:36  *** bitcoin-git has left #bitcoin-core-dev
 232020-02-05T00:46:24  *** bitcoin-git has joined #bitcoin-core-dev
 242020-02-05T00:46:24  <bitcoin-git> [bitcoin] fanquake merged pull request #17336: scripts: search for first block file for linearize-data with some block files pruned (master...linearize) https://github.com/bitcoin/bitcoin/pull/17336
 252020-02-05T00:46:25  *** bitcoin-git has left #bitcoin-core-dev
 262020-02-05T00:46:57  *** promag has quit IRC
 272020-02-05T01:16:03  *** _andrewtoth_ has joined #bitcoin-core-dev
 282020-02-05T01:21:31  *** AaronvanW has joined #bitcoin-core-dev
 292020-02-05T01:27:56  *** Zachu has quit IRC
 302020-02-05T01:29:53  *** Zachu has joined #bitcoin-core-dev
 312020-02-05T01:33:35  *** rachelfish has quit IRC
 322020-02-05T01:36:38  *** achow101 has quit IRC
 332020-02-05T01:49:53  *** promag has joined #bitcoin-core-dev
 342020-02-05T01:54:24  *** promag has quit IRC
 352020-02-05T01:54:51  *** AaronvanW has quit IRC
 362020-02-05T02:02:03  *** jeremyrubin has quit IRC
 372020-02-05T02:07:23  *** _andrewtoth_ has quit IRC
 382020-02-05T02:12:17  *** _andrewtoth_ has joined #bitcoin-core-dev
 392020-02-05T02:37:49  *** jeremyrubin has joined #bitcoin-core-dev
 402020-02-05T02:41:40  *** lnostdal_ has quit IRC
 412020-02-05T02:43:16  *** Highway61 has quit IRC
 422020-02-05T02:53:02  *** shesek has joined #bitcoin-core-dev
 432020-02-05T02:53:03  *** shesek has quit IRC
 442020-02-05T02:53:03  *** shesek has joined #bitcoin-core-dev
 452020-02-05T03:00:02  *** mreider has quit IRC
 462020-02-05T03:01:35  *** abrissbi1ne has joined #bitcoin-core-dev
 472020-02-05T03:04:47  *** abrissbirne has quit IRC
 482020-02-05T03:09:39  *** achow101 has joined #bitcoin-core-dev
 492020-02-05T03:16:48  *** bitcoin-git has joined #bitcoin-core-dev
 502020-02-05T03:16:48  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8625446b4d86...a064e005fa6b
 512020-02-05T03:16:49  <bitcoin-git> bitcoin/master 6c22315 fanquake: build: add additional attributes to Win installer
 522020-02-05T03:16:49  <bitcoin-git> bitcoin/master a064e00 fanquake: Merge #18059: build: add missing attributes to Win installer
 532020-02-05T03:16:51  *** bitcoin-git has left #bitcoin-core-dev
 542020-02-05T03:17:08  *** bitcoin-git has joined #bitcoin-core-dev
 552020-02-05T03:17:08  <bitcoin-git> [bitcoin] fanquake merged pull request #18059: build: add missing attributes to Win installer (master...win_installer_attributes) https://github.com/bitcoin/bitcoin/pull/18059
 562020-02-05T03:17:09  *** bitcoin-git has left #bitcoin-core-dev
 572020-02-05T03:17:55  *** andrea has joined #bitcoin-core-dev
 582020-02-05T03:18:20  *** andrea is now known as Guest29236
 592020-02-05T03:31:31  *** jarthur has joined #bitcoin-core-dev
 602020-02-05T03:33:02  *** jarthur has quit IRC
 612020-02-05T03:33:48  *** captjakk has joined #bitcoin-core-dev
 622020-02-05T03:36:52  *** bitcoin-git has joined #bitcoin-core-dev
 632020-02-05T03:36:52  <bitcoin-git> [bitcoin] theStack opened pull request #18069: test: replace 'regtest' leftovers by self.chain (master...20200205-test-replace-regtest-by-self_chain) https://github.com/bitcoin/bitcoin/pull/18069
 642020-02-05T03:36:53  *** bitcoin-git has left #bitcoin-core-dev
 652020-02-05T03:48:47  *** felixfoertsch23 has joined #bitcoin-core-dev
 662020-02-05T03:49:13  *** felixfoertsch has quit IRC
 672020-02-05T03:52:14  *** AaronvanW has joined #bitcoin-core-dev
 682020-02-05T04:06:03  *** _andrewtoth_ has quit IRC
 692020-02-05T04:24:51  *** AaronvanW has quit IRC
 702020-02-05T04:28:06  *** _andrewtoth_ has joined #bitcoin-core-dev
 712020-02-05T04:32:23  *** _andrewtoth_ has quit IRC
 722020-02-05T04:35:01  *** DaleBewan has joined #bitcoin-core-dev
 732020-02-05T04:39:47  *** DaleBewan has quit IRC
 742020-02-05T04:58:57  *** Eagle[TM] has joined #bitcoin-core-dev
 752020-02-05T05:00:38  *** EagleTM has quit IRC
 762020-02-05T05:01:37  *** tryphe_ has joined #bitcoin-core-dev
 772020-02-05T05:01:42  *** CubicEarth has quit IRC
 782020-02-05T05:04:53  *** tryphe has quit IRC
 792020-02-05T05:05:00  *** morcos has quit IRC
 802020-02-05T05:05:25  *** morcos has joined #bitcoin-core-dev
 812020-02-05T05:07:14  *** afk11 has quit IRC
 822020-02-05T05:07:41  *** afk11 has joined #bitcoin-core-dev
 832020-02-05T05:14:51  *** bitcoin-git has joined #bitcoin-core-dev
 842020-02-05T05:14:51  <bitcoin-git> [bitcoin] givanse opened pull request #18070: [doc] add note about `brew doctor` (master...documentation) https://github.com/bitcoin/bitcoin/pull/18070
 852020-02-05T05:14:52  *** bitcoin-git has left #bitcoin-core-dev
 862020-02-05T05:28:36  *** CubicEarth has joined #bitcoin-core-dev
 872020-02-05T05:51:27  *** braydonf_ has quit IRC
 882020-02-05T05:51:50  *** braydonf_ has joined #bitcoin-core-dev
 892020-02-05T06:00:02  *** Guest29236 has quit IRC
 902020-02-05T06:00:53  *** abacus has quit IRC
 912020-02-05T06:02:29  *** ctrlbreak has quit IRC
 922020-02-05T06:03:52  *** morcos has quit IRC
 932020-02-05T06:04:05  *** morcos has joined #bitcoin-core-dev
 942020-02-05T06:06:00  *** cryptapus_ has joined #bitcoin-core-dev
 952020-02-05T06:06:00  *** cryptapus_ has quit IRC
 962020-02-05T06:06:00  *** cryptapus_ has joined #bitcoin-core-dev
 972020-02-05T06:06:14  *** cryptapus has quit IRC
 982020-02-05T06:09:25  *** abacus has joined #bitcoin-core-dev
 992020-02-05T06:16:25  *** ctrlbreak has joined #bitcoin-core-dev
1002020-02-05T06:18:50  *** furkanmustafa has joined #bitcoin-core-dev
1012020-02-05T06:22:20  *** AaronvanW has joined #bitcoin-core-dev
1022020-02-05T06:40:23  *** Madars has joined #bitcoin-core-dev
1032020-02-05T06:56:18  *** AaronvanW has quit IRC
1042020-02-05T06:57:28  *** manantial has joined #bitcoin-core-dev
1052020-02-05T06:59:12  *** Highway61 has joined #bitcoin-core-dev
1062020-02-05T07:00:29  *** DaleBewan has joined #bitcoin-core-dev
1072020-02-05T07:02:54  *** PaulTroon has joined #bitcoin-core-dev
1082020-02-05T07:05:12  *** DaleBewan has quit IRC
1092020-02-05T07:15:00  *** goatpig has joined #bitcoin-core-dev
1102020-02-05T07:20:11  *** Eagle[TM] has quit IRC
1112020-02-05T07:21:10  *** aqua42 has joined #bitcoin-core-dev
1122020-02-05T07:24:58  *** tryphe_ is now known as tryphe
1132020-02-05T07:48:10  *** promag has joined #bitcoin-core-dev
1142020-02-05T07:52:24  *** promag has quit IRC
1152020-02-05T08:12:00  *** spinza has quit IRC
1162020-02-05T08:12:12  *** jonatack has quit IRC
1172020-02-05T08:21:57  *** bitcoin-git has joined #bitcoin-core-dev
1182020-02-05T08:21:57  <bitcoin-git> [bitcoin] JeremyRubin opened pull request #18071: [WIP] Refactoring CHashWriter & moving  some hashed fields around (master...refactoring-hashers) https://github.com/bitcoin/bitcoin/pull/18071
1192020-02-05T08:21:58  *** bitcoin-git has left #bitcoin-core-dev
1202020-02-05T08:28:08  *** DaleBewan has joined #bitcoin-core-dev
1212020-02-05T08:30:21  *** DaleBewan has quit IRC
1222020-02-05T08:40:22  *** afk11 has quit IRC
1232020-02-05T08:40:43  *** afk11 has joined #bitcoin-core-dev
1242020-02-05T08:46:33  *** AaronvanW has joined #bitcoin-core-dev
1252020-02-05T08:54:32  *** Guyver2 has joined #bitcoin-core-dev
1262020-02-05T09:00:01  *** furkanmustafa has quit IRC
1272020-02-05T09:04:30  *** jonatack has joined #bitcoin-core-dev
1282020-02-05T09:18:22  *** gluxon has joined #bitcoin-core-dev
1292020-02-05T09:29:01  *** promag has joined #bitcoin-core-dev
1302020-02-05T09:35:04  <elichai2> kick plz? https://travis-ci.org/bitcoin/bitcoin/builds/646009773
1312020-02-05T09:35:15  *** Aaronvan_ has joined #bitcoin-core-dev
1322020-02-05T09:38:08  *** AaronvanW has quit IRC
1332020-02-05T09:42:18  *** nijynot has joined #bitcoin-core-dev
1342020-02-05T09:42:57  <kallewoof> elichai2: Kicked linter.
1352020-02-05T09:45:42  *** timothy has joined #bitcoin-core-dev
1362020-02-05T09:47:46  *** tryphe_ has joined #bitcoin-core-dev
1372020-02-05T09:51:54  *** tryphe has quit IRC
1382020-02-05T09:58:46  *** Aaronvan_ is now known as AaronvanW
1392020-02-05T10:06:03  <elichai2> kallewoof: thanks!
1402020-02-05T10:06:32  *** jonasschnelli has quit IRC
1412020-02-05T10:07:51  *** nijynot has quit IRC
1422020-02-05T10:09:28  *** AaronvanW has quit IRC
1432020-02-05T10:12:08  *** nijynot has joined #bitcoin-core-dev
1442020-02-05T10:15:25  *** AaronvanW has joined #bitcoin-core-dev
1452020-02-05T10:15:33  *** jonasschnelli has joined #bitcoin-core-dev
1462020-02-05T10:17:11  *** nijynot has quit IRC
1472020-02-05T10:19:39  *** AaronvanW has quit IRC
1482020-02-05T10:30:43  *** promag_ has joined #bitcoin-core-dev
1492020-02-05T10:35:29  *** promag_ has quit IRC
1502020-02-05T10:36:33  *** spinza has joined #bitcoin-core-dev
1512020-02-05T10:38:28  *** midnight has quit IRC
1522020-02-05T10:40:49  *** AaronvanW has joined #bitcoin-core-dev
1532020-02-05T10:41:09  *** bitcoin-git has joined #bitcoin-core-dev
1542020-02-05T10:41:10  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a064e005fa6b...554d89fb295e
1552020-02-05T10:41:10  <bitcoin-git> bitcoin/master 8d07706 practicalswift: tests: Add fuzzing harness for AS-mapping (asmap)
1562020-02-05T10:41:11  <bitcoin-git> bitcoin/master 4d2acea practicalswift: tests: Add fuzzer asmap to FUZZERS_MISSING_CORPORA (temporarily)
1572020-02-05T10:41:11  <bitcoin-git> bitcoin/master 554d89f Wladimir J. van der Laan: Merge #18029: tests: Add fuzzing harness for AS-mapping (asmap)
1582020-02-05T10:41:13  *** bitcoin-git has left #bitcoin-core-dev
1592020-02-05T10:41:29  *** bitcoin-git has joined #bitcoin-core-dev
1602020-02-05T10:41:29  <bitcoin-git> [bitcoin] laanwj merged pull request #18029: tests: Add fuzzing harness for AS-mapping (asmap) (master...fuzzers-asmap) https://github.com/bitcoin/bitcoin/pull/18029
1612020-02-05T10:41:37  *** bitcoin-git has left #bitcoin-core-dev
1622020-02-05T10:43:40  *** midnightmagic has joined #bitcoin-core-dev
1632020-02-05T10:44:54  *** bitcoin-git has joined #bitcoin-core-dev
1642020-02-05T10:44:55  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/554d89fb295e...bd5c4c69716e
1652020-02-05T10:44:55  <bitcoin-git> bitcoin/master eca56f8 Sebastian Falbesoner: test: replace 'regtest' leftovers by self.chain
1662020-02-05T10:44:56  <bitcoin-git> bitcoin/master bd5c4c6 MarcoFalke: Merge #18069: test: replace 'regtest' leftovers by self.chain
1672020-02-05T10:45:06  *** bitcoin-git has left #bitcoin-core-dev
1682020-02-05T10:45:24  *** bitcoin-git has joined #bitcoin-core-dev
1692020-02-05T10:45:24  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18069: test: replace 'regtest' leftovers by self.chain (master...20200205-test-replace-regtest-by-self_chain) https://github.com/bitcoin/bitcoin/pull/18069
1702020-02-05T10:45:25  *** bitcoin-git has left #bitcoin-core-dev
1712020-02-05T10:45:35  *** IGHOR has quit IRC
1722020-02-05T10:46:35  *** jonatack has quit IRC
1732020-02-05T11:02:41  *** AaronvanW has quit IRC
1742020-02-05T11:02:57  *** nijynot has joined #bitcoin-core-dev
1752020-02-05T11:03:57  *** Cletus17Grady has joined #bitcoin-core-dev
1762020-02-05T11:09:59  *** AaronvanW has joined #bitcoin-core-dev
1772020-02-05T11:15:28  *** AaronvanW has quit IRC
1782020-02-05T11:15:39  *** Cletus17Grady has quit IRC
1792020-02-05T11:17:05  *** afk11 has quit IRC
1802020-02-05T11:17:05  *** jb55 has quit IRC
1812020-02-05T11:17:05  *** morcos has quit IRC
1822020-02-05T11:17:05  *** braydonf_ has quit IRC
1832020-02-05T11:17:05  *** SiAnDoG__ has quit IRC
1842020-02-05T11:17:05  *** ghost43 has quit IRC
1852020-02-05T11:17:05  *** kristapsk has quit IRC
1862020-02-05T11:17:05  *** DeanWeen has quit IRC
1872020-02-05T11:17:05  *** mryandao has quit IRC
1882020-02-05T11:17:05  *** alec has quit IRC
1892020-02-05T11:17:05  *** sipa has quit IRC
1902020-02-05T11:17:05  *** sdaftuar has quit IRC
1912020-02-05T11:17:17  *** alec has joined #bitcoin-core-dev
1922020-02-05T11:17:23  *** ghost43 has joined #bitcoin-core-dev
1932020-02-05T11:17:36  *** sdaftuar has joined #bitcoin-core-dev
1942020-02-05T11:17:50  *** mryandao has joined #bitcoin-core-dev
1952020-02-05T11:18:15  *** braydonf_ has joined #bitcoin-core-dev
1962020-02-05T11:18:21  *** morcos has joined #bitcoin-core-dev
1972020-02-05T11:19:51  *** afk11 has joined #bitcoin-core-dev
1982020-02-05T11:22:16  *** jcoe has joined #bitcoin-core-dev
1992020-02-05T11:22:27  *** sipa has joined #bitcoin-core-dev
2002020-02-05T11:22:42  *** gribble has quit IRC
2012020-02-05T11:26:03  *** Victorsueca has quit IRC
2022020-02-05T11:28:49  *** Victorsueca has joined #bitcoin-core-dev
2032020-02-05T11:34:06  *** jcoe has quit IRC
2042020-02-05T11:37:56  *** promag_ has joined #bitcoin-core-dev
2052020-02-05T11:38:01  *** jb55 has joined #bitcoin-core-dev
2062020-02-05T11:42:12  *** AaronvanW has joined #bitcoin-core-dev
2072020-02-05T11:42:28  *** promag_ has quit IRC
2082020-02-05T11:42:34  *** bitcoin-git has joined #bitcoin-core-dev
2092020-02-05T11:42:34  <bitcoin-git> [bitcoin] dongcarl opened pull request #18072: Use `libc++` headers from macOS SDK instead of from clang (master...2020-01-macos-sdk-with-headers) https://github.com/bitcoin/bitcoin/pull/18072
2102020-02-05T11:42:47  *** bitcoin-git has left #bitcoin-core-dev
2112020-02-05T11:43:55  *** jonatack has joined #bitcoin-core-dev
2122020-02-05T11:50:31  *** Victor_sueca has joined #bitcoin-core-dev
2132020-02-05T11:50:52  *** AaronvanW has quit IRC
2142020-02-05T11:51:00  *** Victorsueca has quit IRC
2152020-02-05T11:52:17  *** Victor_sueca has quit IRC
2162020-02-05T12:00:02  *** gluxon has quit IRC
2172020-02-05T12:06:10  *** IGHOR has joined #bitcoin-core-dev
2182020-02-05T12:13:20  *** promag_ has joined #bitcoin-core-dev
2192020-02-05T12:16:32  *** promag_ has quit IRC
2202020-02-05T12:17:25  *** promag_ has joined #bitcoin-core-dev
2212020-02-05T12:18:30  *** pinkieval1 has joined #bitcoin-core-dev
2222020-02-05T12:22:10  *** promag_ has quit IRC
2232020-02-05T12:22:15  *** morcos has quit IRC
2242020-02-05T12:22:37  *** morcos has joined #bitcoin-core-dev
2252020-02-05T12:39:32  *** tecnovert has left #bitcoin-core-dev
2262020-02-05T12:42:49  *** cryptapus_ is now known as cryptapus
2272020-02-05T12:44:09  *** tecnovert has joined #bitcoin-core-dev
2282020-02-05T12:44:33  *** promag has quit IRC
2292020-02-05T12:56:18  *** Highway62 has joined #bitcoin-core-dev
2302020-02-05T12:58:16  *** Guyver2 has quit IRC
2312020-02-05T12:58:33  *** Highway61 has quit IRC
2322020-02-05T12:58:33  *** Highway62 is now known as Highway61
2332020-02-05T13:00:29  *** bitcoin-git has joined #bitcoin-core-dev
2342020-02-05T13:00:30  <bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/bd5c4c69716e...adea5e1b54cf
2352020-02-05T13:00:30  <bitcoin-git> bitcoin/master d58bcdc Pieter Wuille: Avoid asmap copies in initialization
2362020-02-05T13:00:31  <bitcoin-git> bitcoin/master 6f8c937 Pieter Wuille: Mark asmap const in statistics code
2372020-02-05T13:00:31  <bitcoin-git> bitcoin/master 38c2395 Pieter Wuille: Use ASNs for mapped IPv4 addresses correctly
2382020-02-05T13:00:32  *** bitcoin-git has left #bitcoin-core-dev
2392020-02-05T13:00:49  *** bitcoin-git has joined #bitcoin-core-dev
2402020-02-05T13:00:50  <bitcoin-git> [bitcoin] laanwj merged pull request #18023: Fix some asmap issues (master...202001_asmap_nits) https://github.com/bitcoin/bitcoin/pull/18023
2412020-02-05T13:00:51  *** bitcoin-git has left #bitcoin-core-dev
2422020-02-05T13:16:02  *** gribble has joined #bitcoin-core-dev
2432020-02-05T13:16:37  *** ghost43 has quit IRC
2442020-02-05T13:16:53  *** ghost43 has joined #bitcoin-core-dev
2452020-02-05T13:22:25  *** zivl has quit IRC
2462020-02-05T13:26:30  *** bitcoin-git has joined #bitcoin-core-dev
2472020-02-05T13:26:31  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/adea5e1b54cf...01668839de36
2482020-02-05T13:26:32  <bitcoin-git> bitcoin/master c0bc453 fanquake: build: remove deprecated key from macOS Info.plist
2492020-02-05T13:26:32  <bitcoin-git> bitcoin/master 0166883 Wladimir J. van der Laan: Merge #17660: build: remove deprecated key from macOS Info.plist
2502020-02-05T13:26:34  *** bitcoin-git has left #bitcoin-core-dev
2512020-02-05T13:26:55  *** bitcoin-git has joined #bitcoin-core-dev
2522020-02-05T13:26:56  <bitcoin-git> [bitcoin] laanwj merged pull request #17660: build: remove deprecated key from macOS Info.plist (master...remove_deprecated_cfbundle_usage) https://github.com/bitcoin/bitcoin/pull/17660
2532020-02-05T13:26:57  *** bitcoin-git has left #bitcoin-core-dev
2542020-02-05T13:28:00  *** bitcoin-git has joined #bitcoin-core-dev
2552020-02-05T13:28:02  <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/01668839de36...c8ce2632ebff
2562020-02-05T13:28:03  <bitcoin-git> bitcoin/master 1de8c06 fanquake: depends: clang 6.0.1
2572020-02-05T13:28:03  <bitcoin-git> bitcoin/master ca5055a fanquake: depends: native_cctools 921, ld64 409.12, libtapi 1000.10.8
2582020-02-05T13:28:04  <bitcoin-git> bitcoin/master 7e21044 fanquake: build: use macOS 10.14 SDK
2592020-02-05T13:28:06  *** bitcoin-git has left #bitcoin-core-dev
2602020-02-05T13:29:12  *** bitcoin-git has joined #bitcoin-core-dev
2612020-02-05T13:29:12  <bitcoin-git> [bitcoin] laanwj merged pull request #16392: build: macOS toolchain update (master...macos-toolchain-update) https://github.com/bitcoin/bitcoin/pull/16392
2622020-02-05T13:29:13  *** bitcoin-git has left #bitcoin-core-dev
2632020-02-05T13:33:20  <wumpus> looks like we got a new "warning: ‘*((void*)& time_first_key +8)’ may be used uninitialized in this function [-Wmaybe-uninitialized]" in wallet.cpp
2642020-02-05T13:34:00  <wumpus> (g++ 7.4.0)
2652020-02-05T13:35:26  <elichai2> wumpus: I don't see that line in master
2662020-02-05T13:36:19  <fanquake> wumpus: Pretty sure there’s a pr open to fix that
2672020-02-05T13:36:57  <elichai2> https://github.com/bitcoin/bitcoin/pull/18052
2682020-02-05T13:37:08  *** vincenzopalazzo has joined #bitcoin-core-dev
2692020-02-05T13:37:24  <fanquake> #18052
2702020-02-05T13:37:25  <gribble> https://github.com/bitcoin/bitcoin/issues/18052 | Remove false positive GCC warning by hebasto · Pull Request #18052 · bitcoin/bitcoin · GitHub
2712020-02-05T13:38:19  *** vincentpalazzo has joined #bitcoin-core-dev
2722020-02-05T13:39:36  <wumpus> good to know it's a false positive at least!
2732020-02-05T13:39:45  <wumpus> thanks
2742020-02-05T13:41:56  *** vincenzopalazzo has quit IRC
2752020-02-05T13:43:55  *** bitcoin-git has joined #bitcoin-core-dev
2762020-02-05T13:43:56  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c8ce2632ebff...b30a1f3e39aa
2772020-02-05T13:43:56  <bitcoin-git> bitcoin/master e9434ee Hennadii Stepanov: Remove false positive GCC warning
2782020-02-05T13:43:57  <bitcoin-git> bitcoin/master b30a1f3 Wladimir J. van der Laan: Merge #18052: Remove false positive GCC warning
2792020-02-05T13:43:58  *** bitcoin-git has left #bitcoin-core-dev
2802020-02-05T13:44:15  *** bitcoin-git has joined #bitcoin-core-dev
2812020-02-05T13:44:16  <bitcoin-git> [bitcoin] laanwj merged pull request #18052: Remove false positive GCC warning (master...20200201-false-positive-warning) https://github.com/bitcoin/bitcoin/pull/18052
2822020-02-05T13:44:17  *** bitcoin-git has left #bitcoin-core-dev
2832020-02-05T13:54:48  *** trotski2000_ has joined #bitcoin-core-dev
2842020-02-05T13:55:12  *** bitcoin-git has joined #bitcoin-core-dev
2852020-02-05T13:55:13  <bitcoin-git> [bitcoin] laanwj pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/b30a1f3e39aa...712b7d9b479d
2862020-02-05T13:55:13  <bitcoin-git> bitcoin/master fa05459 MarcoFalke: doc: Add missing "optional" to "long" estimaterawfee RPC help
2872020-02-05T13:55:14  <bitcoin-git> bitcoin/master faff5a6 MarcoFalke: doc: Fix syntax error (trailing square bracket) in walletprocesspsbt
2882020-02-05T13:55:15  <bitcoin-git> bitcoin/master fa9dec7 MarcoFalke: doc: Fix syntax error (trailing square bracket) in finalizepsbt
2892020-02-05T13:55:22  *** bitcoin-git has left #bitcoin-core-dev
2902020-02-05T13:55:42  *** bitcoin-git has joined #bitcoin-core-dev
2912020-02-05T13:55:42  <bitcoin-git> [bitcoin] laanwj merged pull request #17804: doc: Misc RPC help fixes (master...1912-rpcDocFixes) https://github.com/bitcoin/bitcoin/pull/17804
2922020-02-05T13:55:43  *** bitcoin-git has left #bitcoin-core-dev
2932020-02-05T13:56:13  *** laurentmt has joined #bitcoin-core-dev
2942020-02-05T14:01:04  *** laurentmt has quit IRC
2952020-02-05T14:08:13  *** justan0theruser has quit IRC
2962020-02-05T14:23:53  *** sipsorcery has quit IRC
2972020-02-05T14:25:56  *** promag has joined #bitcoin-core-dev
2982020-02-05T14:45:18  *** andrewtoth has joined #bitcoin-core-dev
2992020-02-05T14:45:41  *** ccdle12 has joined #bitcoin-core-dev
3002020-02-05T14:49:46  *** ccdle12 has quit IRC
3012020-02-05T14:52:15  *** AaronvanW has joined #bitcoin-core-dev
3022020-02-05T14:54:23  *** nijynot has quit IRC
3032020-02-05T15:00:01  *** pinkieval1 has quit IRC
3042020-02-05T15:00:34  *** timothy has quit IRC
3052020-02-05T15:04:23  *** timothy has joined #bitcoin-core-dev
3062020-02-05T15:17:56  *** ccdle12 has joined #bitcoin-core-dev
3072020-02-05T15:18:01  *** whartung1 has joined #bitcoin-core-dev
3082020-02-05T15:24:29  *** bitcoin-git has joined #bitcoin-core-dev
3092020-02-05T15:24:30  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/712b7d9b479d...8a56f79d4912
3102020-02-05T15:24:30  <bitcoin-git> bitcoin/master 900d8f6 Russell Yanofsky: util: Disallow network-qualified command line options
3112020-02-05T15:24:31  <bitcoin-git> bitcoin/master 8a56f79 Wladimir J. van der Laan: Merge #17482: util: Disallow network-qualified command line options
3122020-02-05T15:24:37  *** EagleTM has joined #bitcoin-core-dev
3132020-02-05T15:24:41  *** bitcoin-git has left #bitcoin-core-dev
3142020-02-05T15:24:59  *** bitcoin-git has joined #bitcoin-core-dev
3152020-02-05T15:24:59  <bitcoin-git> [bitcoin] laanwj merged pull request #17482: util: Disallow network-qualified command line options (master...pr/wdqual) https://github.com/bitcoin/bitcoin/pull/17482
3162020-02-05T15:25:10  *** bitcoin-git has left #bitcoin-core-dev
3172020-02-05T15:27:17  *** davterra has joined #bitcoin-core-dev
3182020-02-05T15:29:09  *** ccdle12 has quit IRC
3192020-02-05T15:29:09  *** ccdle12_ has joined #bitcoin-core-dev
3202020-02-05T15:34:17  *** Guyver2 has joined #bitcoin-core-dev
3212020-02-05T15:34:44  *** mdunnio has joined #bitcoin-core-dev
3222020-02-05T15:37:00  *** emilengler has joined #bitcoin-core-dev
3232020-02-05T15:46:44  *** goatpig has quit IRC
3242020-02-05T15:47:08  *** dqx has quit IRC
3252020-02-05T15:48:04  *** dqx has joined #bitcoin-core-dev
3262020-02-05T15:51:24  *** justanotheruser has joined #bitcoin-core-dev
3272020-02-05T15:51:25  *** turbo_choo has quit IRC
3282020-02-05T15:55:10  *** Jackielove4u has quit IRC
3292020-02-05T15:55:26  *** Jackielove4u has joined #bitcoin-core-dev
3302020-02-05T15:56:21  *** promag has quit IRC
3312020-02-05T15:57:03  *** shesek has quit IRC
3322020-02-05T15:58:06  *** promag has joined #bitcoin-core-dev
3332020-02-05T15:58:49  *** turbo_choo has joined #bitcoin-core-dev
3342020-02-05T16:01:05  *** dqx has quit IRC
3352020-02-05T16:01:52  *** dqx has joined #bitcoin-core-dev
3362020-02-05T16:02:58  <sdaftuar> Is not sending any p2p message between VERSION and VERACK an important thing to do? i was going to add this new wtxidrelay feature negotiation there, but just realized I also would need to change some code that ignores messages received before VERACK, which gave me pause
3372020-02-05T16:03:11  *** emilengler has quit IRC
3382020-02-05T16:12:09  <promag> any idea when qt update >= 5.10? not clear from #13478
3392020-02-05T16:12:12  <gribble> https://github.com/bitcoin/bitcoin/issues/13478 | [RFC] gui: Minimum required Qt5 · Issue #13478 · bitcoin/bitcoin · GitHub
3402020-02-05T16:15:43  *** EagleTM has quit IRC
3412020-02-05T16:26:44  *** ccdle12_ has quit IRC
3422020-02-05T16:34:04  *** promag has quit IRC
3432020-02-05T16:39:07  *** kljasdfvv has joined #bitcoin-core-dev
3442020-02-05T16:41:40  *** lkjhlkjhlkjhktuz has quit IRC
3452020-02-05T16:42:24  *** turbo_choo has quit IRC
3462020-02-05T16:43:05  <sipa> sdaftuar: how is this different than sendheaders etc?
3472020-02-05T16:44:39  <sdaftuar> sendheaders, feefilter, etc all are sent in response to VERACK
3482020-02-05T16:45:25  <sdaftuar> but the issue i wanted to avoid is there being a relay failure in between processing a peer's VERACK (allowing announcement of transactions to that peer, generally) and processing that peer's WTXIDRELAY message (changing the relay to be via wtxid)
3492020-02-05T16:45:47  <sdaftuar> (of course, with extra bookkeeping there would not necessarily be a failure, but it would be tedious to do that)
3502020-02-05T16:46:37  <sdaftuar> it's a pretty minor issue IMO, as it is a very short window that this could happen -- but i did notice a test failure due to this, so i thought it better to fix somehow
3512020-02-05T16:52:51  *** bosma has quit IRC
3522020-02-05T16:53:07  *** bosma has joined #bitcoin-core-dev
3532020-02-05T16:54:46  *** shesek has joined #bitcoin-core-dev
3542020-02-05T16:57:54  <jonatack> sdaftuar: right, looking at the latest commit at https://github.com/bitcoin/bitcoin/pull/18044/commits/c4a23a1ffc588064f2fbffa9259335322a296a1b. Was the test failure in p2p_tx_download.py?
3552020-02-05T16:59:00  *** EagleTM has joined #bitcoin-core-dev
3562020-02-05T17:03:33  *** EagleTM has quit IRC
3572020-02-05T17:04:44  <sipa> sdaftuar: but receiving a message before verack may be a problem for other applications, maybe?
3582020-02-05T17:05:39  *** Talkless has joined #bitcoin-core-dev
3592020-02-05T17:07:56  *** promag has joined #bitcoin-core-dev
3602020-02-05T17:09:32  <sdaftuar> sipa: yeah, i wasn't sure about that. we assign a misbheavior point to a node that gives us an unexpected message before VERACK
3612020-02-05T17:10:17  <sdaftuar> jonatack: the test failure i saw when doing this after VERACK was in p2p_permissions i think
3622020-02-05T17:10:32  *** kristapsk has joined #bitcoin-core-dev
3632020-02-05T17:10:43  <sdaftuar> (the intermediate commit, where i tried to move this to before VERACK, was totally busted by the way; i pushed a better version a little while ago)
3642020-02-05T17:11:52  *** braydonf_ has quit IRC
3652020-02-05T17:12:15  *** braydonf_ has joined #bitcoin-core-dev
3662020-02-05T17:14:44  <jonatack> thanks -- seems safer (in principle) to handle a post-VERACK time gap before WTXIDRELAY, if reasonably feasible
3672020-02-05T17:16:09  <wumpus> promag: what do you need that for?
3682020-02-05T17:17:17  <promag> wumpus: connect to lambda and kill invoke by slot name
3692020-02-05T17:24:06  *** eragmus has quit IRC
3702020-02-05T17:24:22  *** eragmus has joined #bitcoin-core-dev
3712020-02-05T17:27:01  <jonatack> sdaftuar: in p2p_leak.py it actually states "A node should never send anything other than VERSION/VERACK/REJECT until it's received a VERACK" and test for that
3722020-02-05T17:27:30  <sipa> sdaftuar: in the past people have used appending data to the version message for this purpose
3732020-02-05T17:27:45  <jonatack> (non-exhaustively apparently)
3742020-02-05T17:28:42  <sipa> heh, REJECT was permitted?
3752020-02-05T17:30:59  *** promag has quit IRC
3762020-02-05T17:32:12  <jonatack> seems so in the test
3772020-02-05T17:32:40  <jonatack> (if i'm reading it correctly and it's functioning properly)
3782020-02-05T17:34:21  *** PaulTroon has quit IRC
3792020-02-05T17:35:02  *** PaulTroon has joined #bitcoin-core-dev
3802020-02-05T17:36:24  *** lightlike has joined #bitcoin-core-dev
3812020-02-05T17:40:03  *** PaulTroon has quit IRC
3822020-02-05T17:42:07  *** ccdle12 has joined #bitcoin-core-dev
3832020-02-05T17:43:03  *** sipsorcery has joined #bitcoin-core-dev
3842020-02-05T17:48:06  *** promag has joined #bitcoin-core-dev
3852020-02-05T17:48:45  *** SirRichard has joined #bitcoin-core-dev
3862020-02-05T17:49:08  *** promag has quit IRC
3872020-02-05T17:49:24  *** promag has joined #bitcoin-core-dev
3882020-02-05T17:51:29  *** hanhua has joined #bitcoin-core-dev
3892020-02-05T17:53:29  *** turbo_choo has joined #bitcoin-core-dev
3902020-02-05T18:00:02  *** whartung1 has quit IRC
3912020-02-05T18:01:14  <sdaftuar> cfields: I think you wrote that comment jonatack is referencing, any thoughts?
3922020-02-05T18:05:40  *** hardforkthis7 is now known as tylerlevine
3932020-02-05T18:07:23  *** ccdle12 has quit IRC
3942020-02-05T18:08:16  <sdaftuar> sipa: extending the version message would be nice and simple, but i assume no one likes these variable length messages that ensue from that approach?
3952020-02-05T18:09:34  *** timothy has quit IRC
3962020-02-05T18:09:53  <sipa> sdaftuar: exactly
3972020-02-05T18:10:55  <sipa> some libbitcoin people complained about BIP37 adding an optional field to version
3982020-02-05T18:13:24  <sipa> that was also 8 years ago
3992020-02-05T18:14:36  <sdaftuar> i guess if there's nothing intrinsically wrong with a design where we throw message in between VERSION and VERACK, that seems most extensible to me
4002020-02-05T18:15:09  <sdaftuar> but if software complains, then i am not sure what to do
4012020-02-05T18:16:00  <sdaftuar> one option could be to do a bunch more work to support txid or wtxid-based announcements with a peer, so that turning on wtxidrelay on a link is seamless, but that is not clearly worth the effort t ome
4022020-02-05T18:16:25  *** emilengler has joined #bitcoin-core-dev
4032020-02-05T18:17:09  <sipa> sdaftuar: perhaps just do it with a message between version and verack (and gated by version number, i guess?), and when things are more ready, discuss on the ML whether that could cause problems
4042020-02-05T18:17:17  *** EagleTM has joined #bitcoin-core-dev
4052020-02-05T18:17:44  *** Nipo1 has joined #bitcoin-core-dev
4062020-02-05T18:17:49  <sdaftuar> that is where it's at right now (including gating it on version number, which i bumped)
4072020-02-05T18:17:51  <sdaftuar> seems reasonable
4082020-02-05T18:18:42  <sipa> i agree that's actually cleanest
4092020-02-05T18:18:46  <sdaftuar> possibly i could also just move it to being after VERACK -- in some ways, transaction relay failing between VERACK and negotiation of wtxid relay is no different than transaction relay failing because the connection wasn't set up yet at the time the transaction was announced
4102020-02-05T18:18:59  <sdaftuar> eg the test failure i observed could have happened for other reasons
4112020-02-05T18:19:09  <sdaftuar> it just happened to have happened because of the thing i could sort of control
4122020-02-05T18:20:13  <sdaftuar> anyway i'll leave it for now and revisit, thanks for thinking about this
4132020-02-05T18:21:57  *** EagleTM has quit IRC
4142020-02-05T18:31:39  *** turbo_choo has quit IRC
4152020-02-05T18:33:33  *** PaulTroon has joined #bitcoin-core-dev
4162020-02-05T18:33:56  *** scone has joined #bitcoin-core-dev
4172020-02-05T18:36:35  *** turbo_choo has joined #bitcoin-core-dev
4182020-02-05T18:57:40  *** shesek has quit IRC
4192020-02-05T19:02:24  *** fode has joined #bitcoin-core-dev
4202020-02-05T19:03:03  *** fode has left #bitcoin-core-dev
4212020-02-05T19:08:31  *** promag has quit IRC
4222020-02-05T19:13:17  *** scone has left #bitcoin-core-dev
4232020-02-05T19:14:49  *** lightlike has quit IRC
4242020-02-05T19:23:27  *** jarthur has joined #bitcoin-core-dev
4252020-02-05T19:28:46  *** thaumavorio has quit IRC
4262020-02-05T19:30:15  *** thaumavorio has joined #bitcoin-core-dev
4272020-02-05T19:37:05  *** bitcoin-git has joined #bitcoin-core-dev
4282020-02-05T19:37:05  <bitcoin-git> [bitcoin] tarrenj opened pull request #18076: doc: Resolves a spelling mistake (master...master) https://github.com/bitcoin/bitcoin/pull/18076
4292020-02-05T19:37:06  *** bitcoin-git has left #bitcoin-core-dev
4302020-02-05T19:39:03  *** bosma has quit IRC
4312020-02-05T19:39:03  *** Jackielove4u has quit IRC
4322020-02-05T19:39:13  *** eragmus has quit IRC
4332020-02-05T19:40:11  <luke-jr> sdaftuar: sipa: for reference https://github.com/bitcoin/bips/blob/master/bip-0060.mediawiki
4342020-02-05T19:40:58  <sipa> luke-jr: ah yes, exactly
4352020-02-05T19:42:01  <luke-jr> it's not entirely clear to me if this BIP got implemented or not
4362020-02-05T19:42:14  <luke-jr> if not, then the ship has sailed, and IMO we should be free to extend this way again :P
4372020-02-05T19:43:04  <sipa> it's not because the BIP didn't get adopted that the problem it was trying to address is solved
4382020-02-05T19:43:34  *** ccdle12 has joined #bitcoin-core-dev
4392020-02-05T19:44:52  <luke-jr> ?
4402020-02-05T19:47:54  <sipa> BIP60 argued that adding optional fields to the version message was problematic, and suggested a solution; even if that solutions wasn't adopted, that does not imply that its concern (optional fields at the end of version) does not matter
4412020-02-05T20:04:08  <luke-jr> sipa: my point is that if the version message is already variable-length, adding another field doesn't chnage that
4422020-02-05T20:04:58  <sipa> it still has problems with serialization of deployments (what if two P2P extensions both want to add extra data?)... historically speaking that hasn't been a problem though :p
4432020-02-05T20:05:41  *** emilengler has quit IRC
4442020-02-05T20:09:58  *** Talkless has quit IRC
4452020-02-05T20:10:01  *** promag has joined #bitcoin-core-dev
4462020-02-05T20:10:28  *** ccdle12 has quit IRC
4472020-02-05T20:13:02  *** PaulTroon has quit IRC
4482020-02-05T20:19:27  *** promag has quit IRC
4492020-02-05T20:19:31  *** EagleTM has joined #bitcoin-core-dev
4502020-02-05T20:45:01  *** ccdle12 has joined #bitcoin-core-dev
4512020-02-05T20:55:36  *** ccdle12 has quit IRC
4522020-02-05T21:00:02  *** Nipo1 has quit IRC
4532020-02-05T21:00:58  *** fox2p has quit IRC
4542020-02-05T21:02:28  *** bitcoin-git has joined #bitcoin-core-dev
4552020-02-05T21:02:29  <bitcoin-git> [bitcoin] hebasto opened pull request #18077: [WIP] net: Add NAT-PMP port forwarding support (master...20200130-natpmp) https://github.com/bitcoin/bitcoin/pull/18077
4562020-02-05T21:02:30  *** bitcoin-git has left #bitcoin-core-dev
4572020-02-05T21:03:19  *** fox2p has joined #bitcoin-core-dev
4582020-02-05T21:15:52  *** Guyver2 has quit IRC
4592020-02-05T21:17:49  *** ggainey1 has joined #bitcoin-core-dev
4602020-02-05T21:23:33  *** ccdle12 has joined #bitcoin-core-dev
4612020-02-05T21:28:25  *** bitcoin-git has joined #bitcoin-core-dev
4622020-02-05T21:28:25  <bitcoin-git> [bitcoin] tarrenj closed pull request #18076: doc: Resolves a spelling mistake (master...master) https://github.com/bitcoin/bitcoin/pull/18076
4632020-02-05T21:28:26  *** bitcoin-git has left #bitcoin-core-dev
4642020-02-05T22:13:39  *** PaulTroon has joined #bitcoin-core-dev
4652020-02-05T22:18:27  *** PaulTroon has quit IRC
4662020-02-05T22:20:07  *** promag has joined #bitcoin-core-dev
4672020-02-05T22:24:36  *** promag has quit IRC
4682020-02-05T22:32:24  *** SirRichard has quit IRC
4692020-02-05T22:56:12  *** shesek has joined #bitcoin-core-dev
4702020-02-05T22:57:20  *** bitcoin-git has joined #bitcoin-core-dev
4712020-02-05T22:57:20  <bitcoin-git> [bitcoin] luke-jr opened pull request #18078: [0.19] psbt: check that various indexes and amounts are within bounds (master...psbt_fix_pr17156-0.19.1) https://github.com/bitcoin/bitcoin/pull/18078
4722020-02-05T22:57:21  *** bitcoin-git has left #bitcoin-core-dev
4732020-02-05T22:57:40  *** bitcoin-git has joined #bitcoin-core-dev
4742020-02-05T22:57:40  <bitcoin-git> [bitcoin] luke-jr closed pull request #18078: [0.19] psbt: check that various indexes and amounts are within bounds (master...psbt_fix_pr17156-0.19.1) https://github.com/bitcoin/bitcoin/pull/18078
4752020-02-05T22:57:41  *** bitcoin-git has left #bitcoin-core-dev
4762020-02-05T22:58:10  *** bitcoin-git has joined #bitcoin-core-dev
4772020-02-05T22:58:10  <bitcoin-git> [bitcoin] luke-jr opened pull request #18079: [0.19] psbt: check that various indexes and amounts are within bounds (0.19...psbt_fix_pr17156-0.19.1) https://github.com/bitcoin/bitcoin/pull/18079
4782020-02-05T22:58:11  *** bitcoin-git has left #bitcoin-core-dev
4792020-02-05T22:59:16  *** bosma has joined #bitcoin-core-dev
4802020-02-05T23:00:07  *** eragmus has joined #bitcoin-core-dev
4812020-02-05T23:00:25  *** hanhua has quit IRC
4822020-02-05T23:01:39  *** Jackielove4u has joined #bitcoin-core-dev
4832020-02-05T23:08:04  *** mdunnio has quit IRC
4842020-02-05T23:09:29  *** hex17or has quit IRC
4852020-02-05T23:10:46  *** spaced0ut has joined #bitcoin-core-dev
4862020-02-05T23:34:21  *** trotski2000_ has quit IRC
4872020-02-05T23:39:35  *** nijynot has joined #bitcoin-core-dev
4882020-02-05T23:58:32  *** jarthur has quit IRC
4892020-02-05T23:58:56  *** promag has joined #bitcoin-core-dev