1 2020-02-17T00:00:01  *** Voker571 has quit IRC
  2 2020-02-17T00:17:59  *** matael1 has joined #bitcoin-core-dev
  3 2020-02-17T00:20:07  *** promag has quit IRC
  4 2020-02-17T00:20:47  *** promag has joined #bitcoin-core-dev
  5 2020-02-17T00:25:39  *** promag has quit IRC
  6 2020-02-17T00:30:52  *** promag has joined #bitcoin-core-dev
  7 2020-02-17T00:38:26  *** AaronvanW has quit IRC
  8 2020-02-17T00:40:43  *** asukan has joined #bitcoin-core-dev
  9 2020-02-17T00:41:04  <promag> review/merge beg #13339
 10 2020-02-17T00:41:08  <gribble> https://github.com/bitcoin/bitcoin/issues/13339 | wallet: Replace %w by wallet name in -walletnotify script by promag · Pull Request #13339 · bitcoin/bitcoin · GitHub
 11 2020-02-17T00:46:43  *** promag has quit IRC
 12 2020-02-17T00:52:05  *** sipsorcery has quit IRC
 13 2020-02-17T00:52:34  *** sipsorcery has joined #bitcoin-core-dev
 14 2020-02-17T00:57:56  *** Highway61 has quit IRC
 15 2020-02-17T00:58:46  *** Highway61 has joined #bitcoin-core-dev
 16 2020-02-17T00:59:49  *** asukan has quit IRC
 17 2020-02-17T01:00:10  *** asukan has joined #bitcoin-core-dev
 18 2020-02-17T01:02:18  *** promag has joined #bitcoin-core-dev
 19 2020-02-17T01:02:27  *** promag_ has joined #bitcoin-core-dev
 20 2020-02-17T01:08:51  *** promag has quit IRC
 21 2020-02-17T01:11:39  *** sipsorcery has quit IRC
 22 2020-02-17T01:12:11  *** promag_ has quit IRC
 23 2020-02-17T01:14:58  *** Highway62 has joined #bitcoin-core-dev
 24 2020-02-17T01:16:57  *** Highway61 has quit IRC
 25 2020-02-17T01:16:57  *** Highway62 is now known as Highway61
 26 2020-02-17T01:23:34  *** asukan has quit IRC
 27 2020-02-17T01:23:55  *** asukan has joined #bitcoin-core-dev
 28 2020-02-17T01:29:46  *** bitcoin-git has joined #bitcoin-core-dev
 29 2020-02-17T01:29:47  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/94c0287aec9a...263f53e2d07a
 30 2020-02-17T01:29:47  <bitcoin-git> bitcoin/master fad027f MarcoFalke: scripted-diff: Add missing spaces in RPCResult, Fix type names
 31 2020-02-17T01:29:48  <bitcoin-git> bitcoin/master 263f53e MarcoFalke: Merge #18098: scripted-diff: Add missing spaces in RPCResult, Normalize ty...
 32 2020-02-17T01:29:49  *** bitcoin-git has left #bitcoin-core-dev
 33 2020-02-17T01:30:06  *** bitcoin-git has joined #bitcoin-core-dev
 34 2020-02-17T01:30:07  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18098: scripted-diff: Add missing spaces in RPCResult, Normalize type names (master...1912-rpcDocFixes) https://github.com/bitcoin/bitcoin/pull/18098
 35 2020-02-17T01:30:08  *** bitcoin-git has left #bitcoin-core-dev
 36 2020-02-17T01:38:32  *** promag has joined #bitcoin-core-dev
 37 2020-02-17T01:42:51  *** promag has quit IRC
 38 2020-02-17T01:50:55  *** gleb has quit IRC
 39 2020-02-17T01:52:01  *** Highway61 has quit IRC
 40 2020-02-17T01:52:38  *** gleb has joined #bitcoin-core-dev
 41 2020-02-17T01:52:44  *** AaronvanW has joined #bitcoin-core-dev
 42 2020-02-17T01:54:49  *** bitcoin-git has joined #bitcoin-core-dev
 43 2020-02-17T01:54:49  <bitcoin-git> [bitcoin] luke-jr opened pull request #18165: Consolidate service flag bit-to-name conversion to a shared serviceFlagToStr function (master...svcflags2str) https://github.com/bitcoin/bitcoin/pull/18165
 44 2020-02-17T01:54:50  *** bitcoin-git has left #bitcoin-core-dev
 45 2020-02-17T02:26:03  *** AaronvanW has quit IRC
 46 2020-02-17T02:34:30  *** molly has joined #bitcoin-core-dev
 47 2020-02-17T02:36:45  *** mol has quit IRC
 48 2020-02-17T02:48:29  *** asukan has quit IRC
 49 2020-02-17T03:00:01  *** matael1 has quit IRC
 50 2020-02-17T03:01:01  *** abrissbi1ne has joined #bitcoin-core-dev
 51 2020-02-17T03:04:08  *** abrissbirne has quit IRC
 52 2020-02-17T03:18:02  *** xorAxAx has joined #bitcoin-core-dev
 53 2020-02-17T03:31:34  *** asukan has joined #bitcoin-core-dev
 54 2020-02-17T03:37:58  *** asukan has joined #bitcoin-core-dev
 55 2020-02-17T03:49:11  *** felixfoertsch has joined #bitcoin-core-dev
 56 2020-02-17T03:51:37  *** felixfoertsch23 has quit IRC
 57 2020-02-17T04:23:13  *** AaronvanW has joined #bitcoin-core-dev
 58 2020-02-17T04:28:08  *** Eagle[TM] has joined #bitcoin-core-dev
 59 2020-02-17T04:30:53  *** EagleTM has quit IRC
 60 2020-02-17T04:56:44  *** AaronvanW has quit IRC
 61 2020-02-17T05:04:32  *** promag has joined #bitcoin-core-dev
 62 2020-02-17T05:08:51  *** promag has quit IRC
 63 2020-02-17T06:00:02  *** xorAxAx has quit IRC
 64 2020-02-17T06:18:10  *** gholms1 has joined #bitcoin-core-dev
 65 2020-02-17T06:50:22  *** justan0theruser has joined #bitcoin-core-dev
 66 2020-02-17T06:53:23  *** justanotheruser has quit IRC
 67 2020-02-17T06:53:49  *** AaronvanW has joined #bitcoin-core-dev
 68 2020-02-17T07:23:48  *** Eagle[TM] has quit IRC
 69 2020-02-17T07:26:51  *** AaronvanW has quit IRC
 70 2020-02-17T07:29:00  *** manantial has joined #bitcoin-core-dev
 71 2020-02-17T07:43:23  *** vasild has quit IRC
 72 2020-02-17T07:45:20  *** vasild has joined #bitcoin-core-dev
 73 2020-02-17T07:58:14  *** EagleTM has joined #bitcoin-core-dev
 74 2020-02-17T08:04:16  *** vasild has quit IRC
 75 2020-02-17T08:06:06  *** vasild has joined #bitcoin-core-dev
 76 2020-02-17T08:09:58  *** Kiminuo has joined #bitcoin-core-dev
 77 2020-02-17T08:13:38  *** mol has joined #bitcoin-core-dev
 78 2020-02-17T08:15:17  *** promag has joined #bitcoin-core-dev
 79 2020-02-17T08:16:31  *** molly has quit IRC
 80 2020-02-17T08:25:55  *** EagleTM has quit IRC
 81 2020-02-17T08:28:34  *** marcoagner has joined #bitcoin-core-dev
 82 2020-02-17T08:30:03  *** ivycheeuf has quit IRC
 83 2020-02-17T08:34:00  *** willcl_ark has quit IRC
 84 2020-02-17T08:34:57  *** willcl_ark has joined #bitcoin-core-dev
 85 2020-02-17T08:35:56  *** sipsorcery has joined #bitcoin-core-dev
 86 2020-02-17T08:52:37  *** wumpus2 is now known as wumpus
 87 2020-02-17T08:57:03  *** TheHoliestRoger has quit IRC
 88 2020-02-17T08:57:53  *** TheHoliestRoger has joined #bitcoin-core-dev
 89 2020-02-17T09:00:02  *** gholms1 has quit IRC
 90 2020-02-17T09:06:43  *** Guyver2 has joined #bitcoin-core-dev
 91 2020-02-17T09:07:20  *** yozaam has joined #bitcoin-core-dev
 92 2020-02-17T09:12:25  *** jkk has joined #bitcoin-core-dev
 93 2020-02-17T09:13:48  *** willcl_ark has quit IRC
 94 2020-02-17T09:14:14  *** willcl_ark has joined #bitcoin-core-dev
 95 2020-02-17T09:14:56  *** jkk has quit IRC
 96 2020-02-17T09:17:58  *** dfreedm has joined #bitcoin-core-dev
 97 2020-02-17T09:18:35  *** promag has quit IRC
 98 2020-02-17T09:24:24  *** AaronvanW has joined #bitcoin-core-dev
 99 2020-02-17T09:33:05  <jonasschnelli> Oh. I can macOS notarize the 0.19.1rc2 binary
100 2020-02-17T09:33:06  <jonasschnelli> "message": "The executable does not have the hardened runtime enabled.",
101 2020-02-17T09:34:05  <fanquake> jonasschnelli: likely need some additions to a .plist somewhere
102 2020-02-17T09:34:19  <jonasschnelli> Probably... strange it worked with rc1?!
103 2020-02-17T09:34:34  <fanquake> Interesting
104 2020-02-17T09:35:43  <jonasschnelli> maybe they (Apple) just started to enforce it? dunno
105 2020-02-17T09:35:55  <fanquake> I think that might be the case, was just trying to find the dates
106 2020-02-17T09:36:12  <fanquake> It would have been January when you signed rc1 right? https://developer.apple.com/news/?id=09032019a
107 2020-02-17T09:36:26  <fanquake> I assume now that it's Feb something has changed
108 2020-02-17T09:38:16  <jonasschnelli> I notarized rc1 5 days ago and Sjors did confirm it worked: https://github.com/bitcoin/bitcoin/issues/15774#issuecomment-585324648
109 2020-02-17T09:38:48  <jonasschnelli> Interesting:
110 2020-02-17T09:38:48  <jonasschnelli> https://osxapps-ssl.itunes.apple.com/itunes-assets/Enigma124/v4/70/50/9d/70509d8c-c1b2-5e0c-47fc-b0c5df5de7f0/developer_log.json?accessKey=1582126708_7042408886895258564_pAgS0zq76QE9xKf6bLXiRcUifSnsajT%2BOMaGiI2hapSXmKhFdNM%2BgQdCZPgc2Oq5bL7IjkoP1gQQVStu7TIxONtJdQm6jpMTLP%2FsLi2NUGmcycExtzhgKIFBnxbP2Xy1YwM12BR2jhOkh%2BpT3pyzcU1kKGTUBZNv3DdEfdnDWNE%3D
111 2020-02-17T09:39:01  <jonasschnelli> Apple had just a warning for the rc1 for the hardening entitlements
112 2020-02-17T09:40:57  <fanquake> hmm. I can PR the .plist requirements if you're not already working on it
113 2020-02-17T09:45:31  <jonasschnelli> fanquake: Yes. Please do if you know how...
114 2020-02-17T09:45:55  <jonasschnelli> There is eventually a flag we need to change during code signing...
115 2020-02-17T09:45:59  <jonasschnelli> (just looking into it)
116 2020-02-17T09:45:59  <jonasschnelli> OTHER_CODE_SIGN_FLAGS
117 2020-02-17T09:46:02  <jonasschnelli> https://developer.apple.com/documentation/xcode/notarizing_macos_software_before_distribution/resolving_common_notarization_issues
118 2020-02-17T09:47:55  <jonasschnelli> I can't see a difference in the Info.plist when enabling hardening in a sample XCode project..
119 2020-02-17T09:48:00  <jonasschnelli> I guess its more on the code signing level?
120 2020-02-17T09:48:25  *** asukan has quit IRC
121 2020-02-17T09:49:17  <fanquake> I think the changes might actually be in a separate .xml file
122 2020-02-17T09:49:42  <fanquake> Which you pass to the codesigning tool
123 2020-02-17T09:49:57  <jonasschnelli> https://devblogs.microsoft.com/xamarin/macos-hardened-runtime-notary/
124 2020-02-17T09:50:06  <jonasschnelli> fanquake: I think so. Yes.
125 2020-02-17T09:50:22  *** promag has joined #bitcoin-core-dev
126 2020-02-17T09:50:39  <fanquake> Although we can add that to our tree with the other macdeploy files
127 2020-02-17T09:50:47  *** achow101 has quit IRC
128 2020-02-17T09:53:13  <jonasschnelli> fanquake: I guess we need `--options runtime` during codesign
129 2020-02-17T09:53:19  <jonasschnelli> (detached-sig-create)
130 2020-02-17T09:54:05  <jonasschnelli> fanquake: would be nice if you can investigate further and PR. We can make a testbuild for rc2 and make sure we land in rc3 or final
131 2020-02-17T09:54:27  <fanquake> Sure. I can take a look at some changes.
132 2020-02-17T09:54:59  *** achow101 has joined #bitcoin-core-dev
133 2020-02-17T09:56:24  *** timothy has joined #bitcoin-core-dev
134 2020-02-17T09:58:23  <wumpus> FWIW I'm not going to be at bitcoin 2020 / coredev next month, sorry, even less eager than normal to go on a long flight like that with the coronavirus and quarantaine scare
135 2020-02-17T10:00:23  <jonasschnelli> I won't be there as well...
136 2020-02-17T10:00:46  <wumpus> I don't have a good feeling about this tbh
137 2020-02-17T10:01:40  <promag> wumpus: keep calm and enjoy merging #13339
138 2020-02-17T10:01:44  <gribble> https://github.com/bitcoin/bitcoin/issues/13339 | wallet: Replace %w by wallet name in -walletnotify script by promag · Pull Request #13339 · bitcoin/bitcoin · GitHub
139 2020-02-17T10:05:48  <wumpus> yes these are the times i'm quite happy to work remotely
140 2020-02-17T10:07:10  <wumpus> jonasschnelli: glad to see the notarization worked
141 2020-02-17T10:10:36  <fanquake> wumpus: If you want to get even more remote, feel free to come hang out on the farm. hah.
142 2020-02-17T10:13:39  *** mol has quit IRC
143 2020-02-17T10:15:57  *** jcoe has joined #bitcoin-core-dev
144 2020-02-17T10:20:09  <wumpus> fanquake: thinking about it :)
145 2020-02-17T10:32:51  *** AaronvanW has quit IRC
146 2020-02-17T10:34:38  *** pingwindyktator has joined #bitcoin-core-dev
147 2020-02-17T10:45:22  *** mol has joined #bitcoin-core-dev
148 2020-02-17T11:00:34  *** bitcoin-git has joined #bitcoin-core-dev
149 2020-02-17T11:00:35  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/263f53e2d07a...051439813e2c
150 2020-02-17T11:00:36  <bitcoin-git> bitcoin/master 9a5b5ee João Barbosa: wallet: Replace %w by wallet name in -walletnotify script
151 2020-02-17T11:00:37  <bitcoin-git> bitcoin/master 4e9efac João Barbosa: test: Check wallet name in -walletnotify script
152 2020-02-17T11:00:37  <bitcoin-git> bitcoin/master 0514398 Wladimir J. van der Laan: Merge #13339: wallet: Replace %w by wallet name in -walletnotify script
153 2020-02-17T11:00:39  *** bitcoin-git has left #bitcoin-core-dev
154 2020-02-17T11:00:49  <promag> \o/
155 2020-02-17T11:01:28  <promag> wumpus: I was kidding... that PR is really bad
156 2020-02-17T11:01:59  *** bitcoin-git has joined #bitcoin-core-dev
157 2020-02-17T11:01:59  <bitcoin-git> [bitcoin] laanwj merged pull request #13339: wallet: Replace %w by wallet name in -walletnotify script (master...2018-05-walletnotify) https://github.com/bitcoin/bitcoin/pull/13339
158 2020-02-17T11:02:00  *** bitcoin-git has left #bitcoin-core-dev
159 2020-02-17T11:02:35  <wumpus> worst PR ever
160 2020-02-17T11:02:53  <promag> sorry heh
161 2020-02-17T11:03:12  <wumpus> happy we got it over with though, that was one shedpainting party
162 2020-02-17T11:03:29  <promag> curious about who is going to pick win support
163 2020-02-17T11:03:55  <promag> not me!
164 2020-02-17T11:03:58  *** Lambert82Morar has joined #bitcoin-core-dev
165 2020-02-17T11:04:28  <promag> #18160
166 2020-02-17T11:04:29  <gribble> https://github.com/bitcoin/bitcoin/issues/18160 | gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged by promag · Pull Request #18160 · bitcoin/bitcoin · GitHub
167 2020-02-17T11:04:53  <promag> this one might fix high cpu of bitcoin-qt
168 2020-02-17T11:04:57  <wumpus> me neither, linux and BSD only here
169 2020-02-17T11:05:13  <promag> so if you have a big wallet test let me know
170 2020-02-17T11:06:08  *** bitcoin-git has joined #bitcoin-core-dev
171 2020-02-17T11:06:09  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/051439813e2c...179504ccb6f4
172 2020-02-17T11:06:09  <bitcoin-git> bitcoin/master 530d02a fanquake: build: pass -fno-ident in Windows gitian descriptor
173 2020-02-17T11:06:10  <bitcoin-git> bitcoin/master 179504c Wladimir J. van der Laan: Merge #17948: build: pass -fno-ident in Windows gitian descriptor
174 2020-02-17T11:06:12  *** bitcoin-git has left #bitcoin-core-dev
175 2020-02-17T11:06:33  *** bitcoin-git has joined #bitcoin-core-dev
176 2020-02-17T11:06:33  <bitcoin-git> [bitcoin] laanwj merged pull request #17948: build: pass -fno-ident in Windows gitian descriptor (master...pass_fno_ident) https://github.com/bitcoin/bitcoin/pull/17948
177 2020-02-17T11:06:34  *** bitcoin-git has left #bitcoin-core-dev
178 2020-02-17T11:06:45  <promag> I wasn't aware of MODEL_UPDATE_DELAY = 250ms
179 2020-02-17T11:07:21  <promag> so we are calling GetBalances 4 times a second
180 2020-02-17T11:07:24  *** AaronvanW has joined #bitcoin-core-dev
181 2020-02-17T11:07:31  <promag> *always*
182 2020-02-17T11:13:40  <wumpus> at least there should be a try_lock there so that lock contention won't hang the whole UI, but yea
183 2020-02-17T11:19:54  <promag> don't get fooled with that try_lock
184 2020-02-17T11:20:15  <promag> not waiting for locks is nice obviously
185 2020-02-17T11:21:41  <wumpus> right it helps a bit but doesn't change that it's still bad to do that polling in the GUI thread
186 2020-02-17T11:21:41  <promag> problem is after, if GetBalances takes some time, and also it's called for no good reason
187 2020-02-17T11:22:47  <promag> right
188 2020-02-17T11:23:21  <promag> also we are caching the last block height but we aren't checking for that as early as possible
189 2020-02-17T11:24:09  <wumpus> mind that the balance can change without the block height changing
190 2020-02-17T11:24:50  <wumpus> (e.g. if you send, or unconfirmed balance for unconfirmed incoming transactions)
191 2020-02-17T11:25:16  <wumpus> then again that's always after a transaction
192 2020-02-17T11:25:34  <promag> yeah, there's the force flag for that
193 2020-02-17T11:25:35  <wumpus> I guess the polling is only needed if blocks changed
194 2020-02-17T11:26:02  <wumpus> (e.g. coinbases becoming mature, transactions confirming)
195 2020-02-17T11:26:11  <promag> and if locks couldn't be acquired
196 2020-02-17T11:27:20  <promag> I'm planning to move the timer from walletmodel(s) to wallet controller, and move the calls to the background thread
197 2020-02-17T11:27:30  <wumpus> makes sense
198 2020-02-17T11:28:05  <promag> but that's a bigger change and I think 18160 improves a lot cpu usage and is an easy backport
199 2020-02-17T11:28:14  <promag> let's see what jonasschnelli and ryanofsky say
200 2020-02-17T11:55:29  *** masterdonx2 has quit IRC
201 2020-02-17T11:55:54  *** promag has quit IRC
202 2020-02-17T11:58:40  *** MasterdonX has joined #bitcoin-core-dev
203 2020-02-17T12:00:01  *** dfreedm has quit IRC
204 2020-02-17T12:09:15  *** promag has joined #bitcoin-core-dev
205 2020-02-17T12:09:22  *** promag has quit IRC
206 2020-02-17T12:12:45  *** promag_ has joined #bitcoin-core-dev
207 2020-02-17T12:13:37  *** promag_ has quit IRC
208 2020-02-17T12:13:49  *** promag_ has joined #bitcoin-core-dev
209 2020-02-17T12:15:23  *** mhzesent has joined #bitcoin-core-dev
210 2020-02-17T12:17:49  *** IOMonster1 has joined #bitcoin-core-dev
211 2020-02-17T12:20:11  *** Lambert82Morar has quit IRC
212 2020-02-17T12:52:42  *** promag_ has quit IRC
213 2020-02-17T12:59:42  *** laurentmt has joined #bitcoin-core-dev
214 2020-02-17T13:07:06  *** promag has joined #bitcoin-core-dev
215 2020-02-17T13:09:00  *** promag has quit IRC
216 2020-02-17T13:10:28  *** promag has joined #bitcoin-core-dev
217 2020-02-17T13:17:56  *** promag has quit IRC
218 2020-02-17T13:22:53  *** promag has joined #bitcoin-core-dev
219 2020-02-17T13:28:13  *** laurentmt has quit IRC
220 2020-02-17T13:31:19  *** promag has quit IRC
221 2020-02-17T13:35:47  *** Guyver2 has quit IRC
222 2020-02-17T13:35:51  *** Guyver2_ has joined #bitcoin-core-dev
223 2020-02-17T13:39:25  *** mhzesent has quit IRC
224 2020-02-17T13:47:39  *** jonatack has quit IRC
225 2020-02-17T13:51:59  *** promag has joined #bitcoin-core-dev
226 2020-02-17T13:59:10  *** promag has quit IRC
227 2020-02-17T14:09:24  *** Highway61 has joined #bitcoin-core-dev
228 2020-02-17T14:13:00  *** jonatack has joined #bitcoin-core-dev
229 2020-02-17T14:21:13  *** promag has joined #bitcoin-core-dev
230 2020-02-17T14:27:58  *** promag has quit IRC
231 2020-02-17T14:38:27  *** fox2p has quit IRC
232 2020-02-17T14:39:34  *** fox2p has joined #bitcoin-core-dev
233 2020-02-17T14:46:17  *** promag has joined #bitcoin-core-dev
234 2020-02-17T14:50:53  *** promag has quit IRC
235 2020-02-17T14:53:58  *** promag has joined #bitcoin-core-dev
236 2020-02-17T14:55:43  *** promag has quit IRC
237 2020-02-17T14:56:32  *** promag has joined #bitcoin-core-dev
238 2020-02-17T15:00:02  *** IOMonster1 has quit IRC
239 2020-02-17T15:00:27  *** promag has quit IRC
240 2020-02-17T15:02:54  *** promag has joined #bitcoin-core-dev
241 2020-02-17T15:10:49  *** qubenix has quit IRC
242 2020-02-17T15:11:23  *** qubenix has joined #bitcoin-core-dev
243 2020-02-17T15:17:12  *** promag has quit IRC
244 2020-02-17T15:18:11  *** kerbyu has joined #bitcoin-core-dev
245 2020-02-17T15:18:46  *** promag has joined #bitcoin-core-dev
246 2020-02-17T15:19:02  *** promag_ has joined #bitcoin-core-dev
247 2020-02-17T15:19:05  *** promag has quit IRC
248 2020-02-17T15:23:46  <luke-jr> wumpus: does RISC-V need #17569 backported? (why not?)
249 2020-02-17T15:23:47  <gribble> https://github.com/bitcoin/bitcoin/issues/17569 | build: Allow export of environ symbols and work around rv64 toolchain issue by laanwj · Pull Request #17569 · bitcoin/bitcoin · GitHub
250 2020-02-17T15:29:47  *** qubenix has quit IRC
251 2020-02-17T15:30:54  *** qubenix has joined #bitcoin-core-dev
252 2020-02-17T15:31:24  <wumpus> luke-jr: couldn't hurt at least
253 2020-02-17T15:37:31  *** Kiminuo has quit IRC
254 2020-02-17T15:39:58  *** SiAnDoG has joined #bitcoin-core-dev
255 2020-02-17T15:49:45  *** emilengler has joined #bitcoin-core-dev
256 2020-02-17T16:05:14  *** promag_ has quit IRC
257 2020-02-17T16:33:34  *** molly has joined #bitcoin-core-dev
258 2020-02-17T16:37:16  *** mol has quit IRC
259 2020-02-17T16:55:34  *** roconnor has quit IRC
260 2020-02-17T17:02:25  <luke-jr> wumpus: well, it means a rc3… :/
261 2020-02-17T17:03:11  <luke-jr> wumpus: if the rc2 binaries work on RISC-V as-is, then we don't need it in 0.19.1 at least
262 2020-02-17T17:03:28  <luke-jr> (IIRC you have a RISC-V system to test on, right?)
263 2020-02-17T17:06:19  *** Talkless has joined #bitcoin-core-dev
264 2020-02-17T17:06:22  <luke-jr> (to be clear, it's the noexecstack commit that I'm unsure about - obviously gitian builds complete ;P)
265 2020-02-17T17:06:36  <hebasto> promag: mind looking into #17966 ?
266 2020-02-17T17:06:38  <gribble> https://github.com/bitcoin/bitcoin/issues/17966 | qt, refactor: Optimize signal-slot connections logic by hebasto · Pull Request #17966 · bitcoin/bitcoin · GitHub
267 2020-02-17T17:11:20  *** Talkless has quit IRC
268 2020-02-17T17:12:00  *** Talkless has joined #bitcoin-core-dev
269 2020-02-17T17:15:35  *** Kiminuo has joined #bitcoin-core-dev
270 2020-02-17T17:17:21  *** bsm1175321 has joined #bitcoin-core-dev
271 2020-02-17T17:21:09  *** afk11 has quit IRC
272 2020-02-17T17:21:27  *** afk11 has joined #bitcoin-core-dev
273 2020-02-17T17:21:28  *** jcoe1 has joined #bitcoin-core-dev
274 2020-02-17T17:21:39  *** jcoe has quit IRC
275 2020-02-17T17:37:39  *** Highway61 has quit IRC
276 2020-02-17T17:53:19  *** sipsorcery has quit IRC
277 2020-02-17T17:55:12  *** promag has joined #bitcoin-core-dev
278 2020-02-17T17:55:39  *** luke-jr has quit IRC
279 2020-02-17T17:58:17  *** sipsorcery has joined #bitcoin-core-dev
280 2020-02-17T17:58:40  *** promag has quit IRC
281 2020-02-17T17:58:55  *** promag has joined #bitcoin-core-dev
282 2020-02-17T18:00:01  *** kerbyu has quit IRC
283 2020-02-17T18:02:46  *** Talkless has quit IRC
284 2020-02-17T18:02:48  *** Kiminuo has quit IRC
285 2020-02-17T18:03:11  *** Kiminuo has joined #bitcoin-core-dev
286 2020-02-17T18:03:24  *** luke-jr has joined #bitcoin-core-dev
287 2020-02-17T18:04:06  *** Highway61 has joined #bitcoin-core-dev
288 2020-02-17T18:04:42  *** owowo has quit IRC
289 2020-02-17T18:05:03  *** braydonf_ has quit IRC
290 2020-02-17T18:05:27  *** justan0theruser has quit IRC
291 2020-02-17T18:05:49  *** icota[m] has quit IRC
292 2020-02-17T18:07:24  *** TheFuzzStone[m] has quit IRC
293 2020-02-17T18:07:24  *** mrostecki has quit IRC
294 2020-02-17T18:07:28  *** mael-rolland[m] has quit IRC
295 2020-02-17T18:09:17  *** owowo has joined #bitcoin-core-dev
296 2020-02-17T18:13:20  *** braydonf_ has joined #bitcoin-core-dev
297 2020-02-17T18:14:30  *** justan0theruser has joined #bitcoin-core-dev
298 2020-02-17T18:14:54  *** spinza has quit IRC
299 2020-02-17T18:16:11  *** selenamarie has joined #bitcoin-core-dev
300 2020-02-17T18:18:32  *** justan0theruser has quit IRC
301 2020-02-17T18:21:37  *** mael-rolland[m] has joined #bitcoin-core-dev
302 2020-02-17T18:21:44  *** justan0theruser has joined #bitcoin-core-dev
303 2020-02-17T18:22:49  *** mol has joined #bitcoin-core-dev
304 2020-02-17T18:24:23  *** icota[m] has joined #bitcoin-core-dev
305 2020-02-17T18:24:51  *** molly has quit IRC
306 2020-02-17T18:30:38  *** spinza has joined #bitcoin-core-dev
307 2020-02-17T18:43:16  <dongcarl> What's the current thinking on running Bitcoin Core on non-ECC devices? Are there enough safe guards in place so that at least casual users can use non-ECC devices?
308 2020-02-17T18:43:43  <sipa> what is a non-ECC device?
309 2020-02-17T18:43:54  <sipa> elliptic curve crypto?
310 2020-02-17T18:44:16  <sipa> error correcting code?
311 2020-02-17T18:44:20  <dongcarl> devices without ECC RAM haha
312 2020-02-17T18:45:33  <luke-jr> I suspect most people do
313 2020-02-17T18:46:03  <luke-jr> IIRC Intel doesn't even allow you to use ECC with their normal CPUs
314 2020-02-17T18:46:31  *** owowo has quit IRC
315 2020-02-17T18:46:31  <rafalcpp> dongcarl: almost all users sadly sit on non-ECC RAM. and you have no idea what will bitflip, it could be disk driver that will erase wallet or whatever. probably rather  pointless to defend in software
316 2020-02-17T18:46:41  <sipa> is there *any* consumer oriented CPU that supports ECC?
317 2020-02-17T18:46:46  *** mrostecki has joined #bitcoin-core-dev
318 2020-02-17T18:47:03  <rafalcpp> sipa: pretty sure AMD Bulldozer supports, for example
319 2020-02-17T18:47:05  <luke-jr> rafalcpp: there are places we *should* definitely defend.. your backups won't help you if you bitflip a change address
320 2020-02-17T18:47:13  <luke-jr> sipa: POWER9
321 2020-02-17T18:47:52  <luke-jr> (not typical, but the 4-core variants are consumer-oriented)
322 2020-02-17T18:48:21  <dongcarl> This one too: https://www.96boards.org/product/developerbox/
323 2020-02-17T18:48:47  <dongcarl> I guess I'm just trying to understand the specific risks here...
324 2020-02-17T18:49:29  <dongcarl> If I want to buy hardware to be my dedicated Bitcoin Core node... Should ECC RAM be a main concern? Or is it outweighed by other concerns
325 2020-02-17T18:49:59  <luke-jr> dongcarl: I would put supervisor-free over ECC
326 2020-02-17T18:50:56  <dongcarl> luke-jr: supervisor = BMC?
327 2020-02-17T18:51:20  *** owowo has joined #bitcoin-core-dev
328 2020-02-17T18:52:05  <luke-jr> dongcarl: nah, backdoors like Intel ME and AMD PSP
329 2020-02-17T18:52:10  <sipa> dongcarl: if an ECC system is more expensive than a non-ECC system that can run two instances of bitcoind in parallel, pick the latter :)
330 2020-02-17T18:52:18  <luke-jr> and the Microsoft ThreadX in Raspberry Pi
331 2020-02-17T18:52:32  <rafalcpp> this purity in choosing realiable and not backdoored hardware is highly inspiring at least for me
332 2020-02-17T18:53:23  <dongcarl> sipa: That's very true!
333 2020-02-17T18:54:23  <dongcarl> luke-jr: Is that normally reported on wikichip? e.g., how do I tell if https://en.wikichip.org/wiki/socionext/sc2a11 has a supervisor?
334 2020-02-17T18:54:29  * dongcarl googles Microsoft ThreadX
335 2020-02-17T18:54:46  <rafalcpp> 2-of-2 multisign on other, cheap, device would solve it basically, although much less comfortable to use, dongcarl. an idea for future when it becomes non-trivial amount
336 2020-02-17T18:54:51  <luke-jr> dongcarl: I don't know :/
337 2020-02-17T18:56:52  <dongcarl> rafalcpp: Right, I think the fact that usable SBCs are getting cheaper and cheaper is great. However, setting up clusters is quite a pain still
338 2020-02-17T18:58:25  <dongcarl> Another question: When testing out lower-power SBCs, what's a good metric for "runs Bitcoin Core well"? Is "being able to keep up with tip" good enough?
339 2020-02-17T18:58:56  <luke-jr> dongcarl: IBD in an hour? :P (haha)
340 2020-02-17T19:00:29  <yevaud> dongcarl: even on the upper end SOCs IBD takes days.
341 2020-02-17T19:01:27  <yevaud> dongcarl: the cheapest "sbc" with ECC is almost certainly the APU2/APU4, it's still slow and fanless, like any other SBC.
342 2020-02-17T19:01:41  <dongcarl> Disregarding IBD I mean... In a steady state, is there anything else that would hinder correct operation and security other than keeping up with tip?
343 2020-02-17T19:01:43  *** Highway61 has quit IRC
344 2020-02-17T19:03:39  <dongcarl> yevaud: right, from my understanding the apu2 might be affected by PSP, but I'm not sure that the NICs will cooperate if someone wants to attack
345 2020-02-17T19:03:44  <yevaud> not really. on most SBCs you're going to see rather high rates of data loss due to MicroSD cards, but they run acceptably in the sync state.
346 2020-02-17T19:06:52  <dongcarl> luke-jr: Did you get to look at the apu2 architecture and evaluate the risks closely?
347 2020-02-17T19:06:59  <rafalcpp> dongcarl: a cluster? just run two separate instances.  If anything is needed, I suppose bitcoind/gui could support 2-2 multisign more easily (if it doesn't yet)
348 2020-02-17T19:07:09  <yevaud> dongcarl: yes, it has a PSP core.
349 2020-02-17T19:07:24  <luke-jr> dongcarl: no
350 2020-02-17T19:08:03  <luke-jr> dongcarl: I saw AMD and closed it
351 2020-02-17T19:08:12  <dongcarl> yevaud: Right, but what's the exact attack though? From my understanding you'd need the NICs to cooperate, and PSP isn't in the coreboot payload that PC Engine builds...
352 2020-02-17T19:09:12  <dongcarl> rafalcpp: That's true, you could probably do some deduplication at the FS level to save some space too
353 2020-02-17T19:09:35  <rafalcpp> dongcarl: well this isn't separate computer then.  but just fully prune one (or both) then it is around 6 GB
354 2020-02-17T19:09:37  *** promag has quit IRC
355 2020-02-17T19:10:00  <yevaud> dongcarl: I don't know without asking PcEngines (do, they're helpful), but I don't think it's a realistic concern in the real world.
356 2020-02-17T19:10:35  <luke-jr> I'm not sure PcEngines would know either?
357 2020-02-17T19:10:42  <dongcarl> yevaud: That's a good point. Will email.
358 2020-02-17T19:11:15  <dongcarl> luke-jr: They have quite a deep understanding of their hardware: https://github.com/pcengines/apu2-documentation
359 2020-02-17T19:11:26  *** spaced0ut has quit IRC
360 2020-02-17T19:12:32  <luke-jr> dongcarl: but afaik the PSP is inivislbe  outside the CPU?
361 2020-02-17T19:13:51  <yevaud> luke-jr: on the Intel one it's stored on an external flash chip.
362 2020-02-17T19:14:52  <luke-jr> but at least on Intel, if you deprive it, it won't work
363 2020-02-17T19:15:21  <yevaud> stands to reason the manufacturer would have to understand that, if it were the case on AMD.
364 2020-02-17T19:15:55  * dongcarl has some reading to do
365 2020-02-17T19:16:06  *** willcl_ark has quit IRC
366 2020-02-17T19:16:25  <luke-jr> yevaud: they might not understand the ramifications of not providing it, even if that is the case
367 2020-02-17T19:16:49  <luke-jr> eg, on Intel the IME is used to workaround silicon bugs, so with me_cleaner and such, you're vulnerable to undisclosed vulnerabilities
368 2020-02-17T19:17:38  <yevaud> uh, really? the microcode is a separate thing to the ME core.
369 2020-02-17T19:18:54  *** bitcoin-git has joined #bitcoin-core-dev
370 2020-02-17T19:18:54  <bitcoin-git> [bitcoin] practicalswift opened pull request #18166: ci: Run fuzz testing test cases under valgrind (master...fuzz-test-cases-under-valgrind) https://github.com/bitcoin/bitcoin/pull/18166
371 2020-02-17T19:19:04  *** bitcoin-git has left #bitcoin-core-dev
372 2020-02-17T19:19:30  <luke-jr> yevaud: someone disclosed or leaked that a while ago. it's not just microcode that patches silicon issues.
373 2020-02-17T19:20:04  *** kristapsk has quit IRC
374 2020-02-17T19:20:14  <luke-jr> I don't know that any of the specific details of the silicon bug were disclosed, so we can only speculate on why Intel might have done ti that way
375 2020-02-17T19:20:53  <luke-jr> (maybe it's a silicon issue with the ME core, and not patching it means external attackers can compromise the ME core?)
376 2020-02-17T19:21:59  <dongcarl> (if this is off-topic, someone should let me know)
377 2020-02-17T19:22:22  <dongcarl> luke-jr: I think the PSP firmware has to be in the BIOS to be loaded
378 2020-02-17T19:22:49  <yevaud> luke-jr: I was under the impression that ME operations against the main cores were effectively a NMI, so having it do any sort of continuous operation would demolish performance.
379 2020-02-17T19:22:58  <dongcarl> And in the apu2 case, they did not include it in the coreboot payload: https://coreboot.coreboot.narkive.com/7e2UHc2x/pc-engines-apu2-platform-psp-support
380 2020-02-17T19:23:31  <yevaud> luke-jr: but obviously I don't have specific knowledge here, so I'll leave it at that.
381 2020-02-17T19:25:44  <luke-jr> yevaud: I'm not sure why that would matter. Injecting a bit of code wouldn't need to be continuous, and most things can be done by reading/changing RAM directly
382 2020-02-17T19:25:49  *** willcl_ark has joined #bitcoin-core-dev
383 2020-02-17T19:27:35  *** willcl_ark has quit IRC
384 2020-02-17T19:37:24  *** willcl_ark has joined #bitcoin-core-dev
385 2020-02-17T19:38:34  *** jcoe1 has quit IRC
386 2020-02-17T19:43:43  *** vasild has quit IRC
387 2020-02-17T19:46:45  *** mrostecki has quit IRC
388 2020-02-17T19:46:47  *** mael-rolland[m] has quit IRC
389 2020-02-17T19:47:13  *** icota[m] has quit IRC
390 2020-02-17T19:49:15  *** sanket1729 has quit IRC
391 2020-02-17T19:50:17  *** Kiminuo has quit IRC
392 2020-02-17T19:50:18  *** vasild has joined #bitcoin-core-dev
393 2020-02-17T19:51:50  *** sanket1729 has joined #bitcoin-core-dev
394 2020-02-17T19:55:33  *** jimmysong has joined #bitcoin-core-dev
395 2020-02-17T19:55:38  *** jimmysong_ has joined #bitcoin-core-dev
396 2020-02-17T19:57:08  *** jimmysong_ has quit IRC
397 2020-02-17T20:00:45  *** jimmysong has quit IRC
398 2020-02-17T20:02:09  *** rafalcpp has quit IRC
399 2020-02-17T20:07:23  <wumpus> luke-jr: they work fine without the patch, #17569 does work around a noexecstack issue (so the stack is executable), I don't think it's worth doing a new rc for but if there is one anyway we could include it
400 2020-02-17T20:07:25  <gribble> https://github.com/bitcoin/bitcoin/issues/17569 | build: Allow export of environ symbols and work around rv64 toolchain issue by laanwj · Pull Request #17569 · bitcoin/bitcoin · GitHub
401 2020-02-17T20:11:20  *** jimmysong has joined #bitcoin-core-dev
402 2020-02-17T20:12:25  <dongcarl> Does anyone know how to setup gribble for another channel? I'm thinking #bitcoin-builds
403 2020-02-17T20:14:08  *** Kiminuo has joined #bitcoin-core-dev
404 2020-02-17T20:14:11  *** Highway61 has joined #bitcoin-core-dev
405 2020-02-17T20:15:25  *** bitcoin-git has joined #bitcoin-core-dev
406 2020-02-17T20:15:25  <bitcoin-git> [bitcoin] TheQuantumPhysicist opened pull request #18167: Fix a violation of C++ standard rules where unions are used for type-punning (master...master) https://github.com/bitcoin/bitcoin/pull/18167
407 2020-02-17T20:15:26  *** bitcoin-git has left #bitcoin-core-dev
408 2020-02-17T20:16:37  *** TheFuzzStone[m] has joined #bitcoin-core-dev
409 2020-02-17T20:21:57  *** Guyver2__ has joined #bitcoin-core-dev
410 2020-02-17T20:22:12  *** icota[m] has joined #bitcoin-core-dev
411 2020-02-17T20:22:12  *** mrostecki has joined #bitcoin-core-dev
412 2020-02-17T20:22:18  *** mael-rolland[m] has joined #bitcoin-core-dev
413 2020-02-17T20:23:24  *** Guyver2_ has quit IRC
414 2020-02-17T20:29:08  *** willcl_ark has quit IRC
415 2020-02-17T20:30:01  *** willcl_ark has joined #bitcoin-core-dev
416 2020-02-17T20:32:27  *** willcl_ark has quit IRC
417 2020-02-17T20:33:26  *** willcl_ark has joined #bitcoin-core-dev
418 2020-02-17T20:33:29  *** willcl_ark has quit IRC
419 2020-02-17T20:35:41  *** willcl_ark has joined #bitcoin-core-dev
420 2020-02-17T20:36:36  *** emilengler has quit IRC
421 2020-02-17T20:42:27  *** dr-orlovsky has quit IRC
422 2020-02-17T20:45:40  *** dr-orlovsky has joined #bitcoin-core-dev
423 2020-02-17T21:00:01  *** selenamarie has quit IRC
424 2020-02-17T21:07:55  *** Kiminuo has quit IRC
425 2020-02-17T21:08:39  *** proshanta has joined #bitcoin-core-dev
426 2020-02-17T21:14:22  *** proshanta has quit IRC
427 2020-02-17T21:18:19  *** unknown1 has joined #bitcoin-core-dev
428 2020-02-17T21:19:24  *** Highway61 has quit IRC
429 2020-02-17T21:25:39  *** promag has joined #bitcoin-core-dev
430 2020-02-17T21:29:09  *** Guyver2__ has quit IRC
431 2020-02-17T21:36:03  <achow101> dongcarl: talk to nanotube
432 2020-02-17T21:40:08  *** promag has quit IRC
433 2020-02-17T21:45:43  *** Chris_Stewart_5 has quit IRC
434 2020-02-17T22:03:47  *** timothy has quit IRC
435 2020-02-17T22:25:01  *** IGHOR has quit IRC
436 2020-02-17T22:31:12  *** jarthur has joined #bitcoin-core-dev
437 2020-02-17T22:42:22  *** cavemansalem has joined #bitcoin-core-dev
438 2020-02-17T22:48:53  *** cavemansalem has quit IRC
439 2020-02-17T22:49:14  *** cavemansalem has joined #bitcoin-core-dev
440 2020-02-17T22:49:56  *** DeanGuss has joined #bitcoin-core-dev
441 2020-02-17T22:55:49  *** promag has joined #bitcoin-core-dev
442 2020-02-17T22:58:56  *** manantial has quit IRC
443 2020-02-17T23:00:06  *** Highway61 has joined #bitcoin-core-dev
444 2020-02-17T23:39:19  *** AaronvanW has quit IRC
445 2020-02-17T23:46:19  *** Chris_Stewart_5 has joined #bitcoin-core-dev
446 2020-02-17T23:58:15  *** Zenton has quit IRC