1 2020-02-25T00:00:02  *** TheCavalry has quit IRC
  2 2020-02-25T00:00:07  *** MasterdonX has quit IRC
  3 2020-02-25T00:00:51  *** MasterdonX has joined #bitcoin-core-dev
  4 2020-02-25T00:12:15  *** moth has joined #bitcoin-core-dev
  5 2020-02-25T00:19:08  *** justanotheruser has quit IRC
  6 2020-02-25T00:20:58  *** bitcoin-git has joined #bitcoin-core-dev
  7 2020-02-25T00:20:58  <bitcoin-git> [bitcoin] achow101 opened pull request #18204: descriptors: improve descriptor cache and cache xpubs (master...desc-xpub-cache) https://github.com/bitcoin/bitcoin/pull/18204
  8 2020-02-25T00:20:59  *** bitcoin-git has left #bitcoin-core-dev
  9 2020-02-25T00:26:06  *** marcoagner has quit IRC
 10 2020-02-25T00:39:43  *** promag has quit IRC
 11 2020-02-25T00:43:27  *** promag has joined #bitcoin-core-dev
 12 2020-02-25T00:48:17  *** promag has quit IRC
 13 2020-02-25T01:04:18  *** promag has joined #bitcoin-core-dev
 14 2020-02-25T01:08:59  *** promag has quit IRC
 15 2020-02-25T01:19:54  *** learnday20 has joined #bitcoin-core-dev
 16 2020-02-25T01:21:28  *** jb55 has quit IRC
 17 2020-02-25T01:22:53  *** mol has joined #bitcoin-core-dev
 18 2020-02-25T01:25:25  *** molly has quit IRC
 19 2020-02-25T01:29:02  *** jb55 has joined #bitcoin-core-dev
 20 2020-02-25T02:06:29  *** justanotheruser has joined #bitcoin-core-dev
 21 2020-02-25T02:07:11  *** bitcoin-git has joined #bitcoin-core-dev
 22 2020-02-25T02:07:11  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/225aa5d6d519...a674e89d2771
 23 2020-02-25T02:07:11  <bitcoin-git> bitcoin/master 12a2f37 practicalswift: util: Avoid potential uninitialized read in FormatISO8601DateTime(int64_t ...
 24 2020-02-25T02:07:12  <bitcoin-git> bitcoin/master a674e89 fanquake: Merge #18162: util: Avoid potential uninitialized read in FormatISO8601Dat...
 25 2020-02-25T02:07:13  *** bitcoin-git has left #bitcoin-core-dev
 26 2020-02-25T02:07:26  *** bitcoin-git has joined #bitcoin-core-dev
 27 2020-02-25T02:07:26  <bitcoin-git> [bitcoin] fanquake merged pull request #18162: util: Avoid potential uninitialized read in FormatISO8601DateTime(int64_t) by checking gmtime_s/gmtime_r return value (master...FormatISO8601DateTime-unitialized-read) https://github.com/bitcoin/bitcoin/pull/18162
 28 2020-02-25T02:07:31  *** bitcoin-git has left #bitcoin-core-dev
 29 2020-02-25T02:09:54  *** bitcoin-git has joined #bitcoin-core-dev
 30 2020-02-25T02:09:54  <bitcoin-git> [bitcoin] fanquake closed pull request #16523: Add removemempoolentry RPC to evict transactions from the mempool (master...removemempoolentry) https://github.com/bitcoin/bitcoin/pull/16523
 31 2020-02-25T02:09:55  *** bitcoin-git has left #bitcoin-core-dev
 32 2020-02-25T02:13:29  *** bitcoin-git has joined #bitcoin-core-dev
 33 2020-02-25T02:13:29  <bitcoin-git> [bitcoin] fanquake closed pull request #15873: Rpc removemempoolentry (master...rpc-removemempoolentry) https://github.com/bitcoin/bitcoin/pull/15873
 34 2020-02-25T02:13:30  *** bitcoin-git has left #bitcoin-core-dev
 35 2020-02-25T02:15:25  *** bitcoin-git has joined #bitcoin-core-dev
 36 2020-02-25T02:15:25  <bitcoin-git> [bitcoin] fanquake closed pull request #16486: [consensus] skip bip30 checks when assumevalid is set for the block (master...2019-07-29-fassumevalid-bip34) https://github.com/bitcoin/bitcoin/pull/16486
 37 2020-02-25T02:15:26  *** bitcoin-git has left #bitcoin-core-dev
 38 2020-02-25T02:20:37  *** bitcoin-git has joined #bitcoin-core-dev
 39 2020-02-25T02:20:37  <bitcoin-git> [bitcoin] fanquake closed pull request #13989: add avx512 instrinsic (master...1-avx512) https://github.com/bitcoin/bitcoin/pull/13989
 40 2020-02-25T02:20:38  *** bitcoin-git has left #bitcoin-core-dev
 41 2020-02-25T02:27:52  *** bitcoin-git has joined #bitcoin-core-dev
 42 2020-02-25T02:27:52  <bitcoin-git> [bitcoin] fanquake closed pull request #17815: rpc: Make __cookie__ user immune to rpcwhitelist (master...2019-12-rpc-cookie-user-independence) https://github.com/bitcoin/bitcoin/pull/17815
 43 2020-02-25T02:27:53  *** bitcoin-git has left #bitcoin-core-dev
 44 2020-02-25T02:28:36  <ariard> #17443 has been rebased and is quite simple to review and push forward wallet-node refactoring (though maybe conflicts with other wallet PRs)
 45 2020-02-25T02:28:39  <gribble> https://github.com/bitcoin/bitcoin/issues/17443 | Drop checkFinalTx and use Median Time Past to check finality of wallet transactions by ariard · Pull Request #17443 · bitcoin/bitcoin · GitHub
 46 2020-02-25T02:30:53  *** Highway61 has quit IRC
 47 2020-02-25T03:00:01  *** moth has quit IRC
 48 2020-02-25T03:17:53  *** gac410 has joined #bitcoin-core-dev
 49 2020-02-25T03:18:17  *** gac410 is now known as Guest80845
 50 2020-02-25T03:25:36  *** luke-jr has quit IRC
 51 2020-02-25T03:28:31  *** luke-jr has joined #bitcoin-core-dev
 52 2020-02-25T03:30:47  *** ahmed_ has quit IRC
 53 2020-02-25T03:36:18  <hadjiszs> sipa: MarcoFalke: is there someone working on dandelion++ implementation as for BIP156 ? I am planning to work on top of your #13947
 54 2020-02-25T03:36:22  <gribble> https://github.com/bitcoin/bitcoin/issues/13947 | Dandelion transaction relay (BIP 156) by MarcoFalke · Pull Request #13947 · bitcoin/bitcoin · GitHub
 55 2020-02-25T03:41:44  *** felixfoertsch has joined #bitcoin-core-dev
 56 2020-02-25T03:42:06  *** felixfoertsch23 has quit IRC
 57 2020-02-25T03:49:30  *** DougieBot5000_ has joined #bitcoin-core-dev
 58 2020-02-25T03:49:45  *** DougieBot5000 is now known as Guest92832
 59 2020-02-25T03:49:45  *** DougieBot5000_ is now known as DougieBot5000
 60 2020-02-25T03:49:57  *** Victorsueca has joined #bitcoin-core-dev
 61 2020-02-25T03:50:39  *** stevenro- has quit IRC
 62 2020-02-25T03:50:50  *** dongcarl8 has joined #bitcoin-core-dev
 63 2020-02-25T03:51:39  *** stevenroose has joined #bitcoin-core-dev
 64 2020-02-25T03:52:03  *** CubicEarth has quit IRC
 65 2020-02-25T03:52:04  *** brikk has quit IRC
 66 2020-02-25T03:52:04  *** hex17or has quit IRC
 67 2020-02-25T03:52:31  *** Victor_sueca has quit IRC
 68 2020-02-25T03:52:32  *** dongcarl has quit IRC
 69 2020-02-25T03:52:32  *** commavir has quit IRC
 70 2020-02-25T03:52:32  *** kcalvinalvin has quit IRC
 71 2020-02-25T03:52:34  *** dongcarl8 is now known as dongcarl
 72 2020-02-25T03:52:59  *** sturles has quit IRC
 73 2020-02-25T03:53:00  *** exhoplex has quit IRC
 74 2020-02-25T03:53:24  *** brikk has joined #bitcoin-core-dev
 75 2020-02-25T03:53:25  *** CubicEarth has joined #bitcoin-core-dev
 76 2020-02-25T03:53:57  *** sturles has joined #bitcoin-core-dev
 77 2020-02-25T03:53:57  *** sturles has joined #bitcoin-core-dev
 78 2020-02-25T03:54:15  *** commavir has joined #bitcoin-core-dev
 79 2020-02-25T03:54:44  *** exhoplex has joined #bitcoin-core-dev
 80 2020-02-25T03:54:54  *** kcalvinalvin has joined #bitcoin-core-dev
 81 2020-02-25T03:58:37  *** hex17or has joined #bitcoin-core-dev
 82 2020-02-25T04:00:44  *** kris11 has joined #bitcoin-core-dev
 83 2020-02-25T04:04:39  *** spinny has joined #bitcoin-core-dev
 84 2020-02-25T04:05:58  *** kris11 has quit IRC
 85 2020-02-25T04:18:04  <sipa> hadjiszs: i believe dandelion os a dead end
 86 2020-02-25T04:19:47  <sipa> hadjiszs: https://bitcoin.stackexchange.com/q/81503/208
 87 2020-02-25T04:22:30  <aj> sipa: hmm, i thought that was just "it's a lot more work than we thought" not "it's impossible and not worth further work" ?
 88 2020-02-25T04:26:50  <sipa> i pretty much believe there isn't a reasonable solution that ticks all the boxes
 89 2020-02-25T04:26:50  <sipa> i don't have a strong argument for this, and would be very happy to be convinced otherwise
 90 2020-02-25T04:30:17  *** shapeare has joined #bitcoin-core-dev
 91 2020-02-25T04:35:14  <aj> ok, i'll remain naively optimistic then
 92 2020-02-25T04:37:03  *** sipa has quit IRC
 93 2020-02-25T04:43:02  *** sipa has joined #bitcoin-core-dev
 94 2020-02-25T04:46:21  *** ddustin has joined #bitcoin-core-dev
 95 2020-02-25T04:46:47  *** learnday20 has quit IRC
 96 2020-02-25T04:46:59  *** ddustin has quit IRC
 97 2020-02-25T04:47:48  *** ddustin has joined #bitcoin-core-dev
 98 2020-02-25T05:03:20  *** ddustin has quit IRC
 99 2020-02-25T05:03:26  *** ddustin_ has joined #bitcoin-core-dev
100 2020-02-25T05:04:40  *** ddustin_ has quit IRC
101 2020-02-25T05:05:15  *** ddustin has joined #bitcoin-core-dev
102 2020-02-25T05:09:59  *** ddustin has quit IRC
103 2020-02-25T05:40:56  *** promag has joined #bitcoin-core-dev
104 2020-02-25T05:42:16  *** spinny has quit IRC
105 2020-02-25T05:45:06  *** promag has quit IRC
106 2020-02-25T06:00:01  *** Guest80845 has quit IRC
107 2020-02-25T06:06:51  *** sipsorcery has quit IRC
108 2020-02-25T06:07:07  *** sipsorcery has joined #bitcoin-core-dev
109 2020-02-25T06:17:41  *** kermit2 has joined #bitcoin-core-dev
110 2020-02-25T06:29:36  *** Kiminuo has joined #bitcoin-core-dev
111 2020-02-25T07:14:13  *** manantial has joined #bitcoin-core-dev
112 2020-02-25T07:19:56  *** goatpig has joined #bitcoin-core-dev
113 2020-02-25T07:22:29  *** Guyver2 has joined #bitcoin-core-dev
114 2020-02-25T07:35:33  *** shapeare has quit IRC
115 2020-02-25T07:40:32  *** vasild has joined #bitcoin-core-dev
116 2020-02-25T07:43:43  *** vasild_ has quit IRC
117 2020-02-25T07:52:48  *** bitcoin-git has joined #bitcoin-core-dev
118 2020-02-25T07:52:48  <bitcoin-git> [bitcoin] fanquake closed pull request #18116: depends: Use clang for Ubuntu 16.04 (master...20200211-clang-ubuntu) https://github.com/bitcoin/bitcoin/pull/18116
119 2020-02-25T07:52:49  *** bitcoin-git has left #bitcoin-core-dev
120 2020-02-25T07:57:06  *** jonatack has quit IRC
121 2020-02-25T08:03:58  *** EagleTM has joined #bitcoin-core-dev
122 2020-02-25T08:05:58  *** Eagle[TM] has joined #bitcoin-core-dev
123 2020-02-25T08:08:38  *** EagleTM has quit IRC
124 2020-02-25T08:09:29  *** AaronvanW has joined #bitcoin-core-dev
125 2020-02-25T08:17:26  *** okeyzc has joined #bitcoin-core-dev
126 2020-02-25T08:18:03  *** bitcoin-git has joined #bitcoin-core-dev
127 2020-02-25T08:18:03  <bitcoin-git> [bitcoin] practicalswift opened pull request #18206: tests: Add fuzzing harness for bloom filter classes (CBloomFilter + CRollingBloomFilter) (master...fuzzers-bloom_filter) https://github.com/bitcoin/bitcoin/pull/18206
128 2020-02-25T08:18:04  *** bitcoin-git has left #bitcoin-core-dev
129 2020-02-25T08:33:18  *** jonatack has joined #bitcoin-core-dev
130 2020-02-25T08:39:16  *** Eagle[TM] has quit IRC
131 2020-02-25T08:51:52  *** sdjkertuz has joined #bitcoin-core-dev
132 2020-02-25T08:53:43  *** okeyzc has left #bitcoin-core-dev
133 2020-02-25T08:55:27  *** kljasdfvv has quit IRC
134 2020-02-25T08:58:40  *** marcoagner has joined #bitcoin-core-dev
135 2020-02-25T09:00:02  *** kermit2 has quit IRC
136 2020-02-25T09:01:01  *** jonatack has quit IRC
137 2020-02-25T09:02:51  *** mol has quit IRC
138 2020-02-25T09:03:53  *** rafalcpp has joined #bitcoin-core-dev
139 2020-02-25T09:16:02  *** Dieterbe1 has joined #bitcoin-core-dev
140 2020-02-25T09:30:34  *** side^effects has joined #bitcoin-core-dev
141 2020-02-25T09:38:26  *** promag has joined #bitcoin-core-dev
142 2020-02-25T09:42:06  *** timothy has joined #bitcoin-core-dev
143 2020-02-25T09:57:00  *** jonatack has joined #bitcoin-core-dev
144 2020-02-25T10:01:23  *** ddustin has joined #bitcoin-core-dev
145 2020-02-25T10:05:56  *** ddustin has quit IRC
146 2020-02-25T10:07:29  *** AaronvanW has quit IRC
147 2020-02-25T10:30:41  *** bitcoin-git has joined #bitcoin-core-dev
148 2020-02-25T10:30:43  <bitcoin-git> [bitcoin] meshcollider pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/a674e89d2771...03f98b15ad4f
149 2020-02-25T10:30:43  <bitcoin-git> bitcoin/master 2ce3447 Vasil Dimov: Deduplicate the message verifying code
150 2020-02-25T10:30:44  <bitcoin-git> bitcoin/master f8f0d98 Vasil Dimov: Deduplicate the message signing code
151 2020-02-25T10:30:45  <bitcoin-git> bitcoin/master e193a84 Jeffrey Czyz: Refactor message hashing into a utility function
152 2020-02-25T10:30:47  *** bitcoin-git has left #bitcoin-core-dev
153 2020-02-25T10:31:16  *** bitcoin-git has joined #bitcoin-core-dev
154 2020-02-25T10:31:16  <bitcoin-git> [bitcoin] meshcollider merged pull request #17577: refactor: deduplicate the message sign/verify code (master...message-dedup) https://github.com/bitcoin/bitcoin/pull/17577
155 2020-02-25T10:31:19  *** bitcoin-git has left #bitcoin-core-dev
156 2020-02-25T10:33:15  *** Emcy has quit IRC
157 2020-02-25T10:46:03  *** Emcy has joined #bitcoin-core-dev
158 2020-02-25T10:51:41  *** bitcoin-git has joined #bitcoin-core-dev
159 2020-02-25T10:51:42  <bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/03f98b15ad4f...31c0006a6cd5
160 2020-02-25T10:51:42  <bitcoin-git> bitcoin/master 29a21c9 Sjors Provoost: [rpc] set default bip32derivs to true for psbt methods
161 2020-02-25T10:51:43  <bitcoin-git> bitcoin/master 5bad792 Sjors Provoost: [test] PSBT RPC: check that bip32_derivs are present by default
162 2020-02-25T10:51:43  <bitcoin-git> bitcoin/master 31c0006 Samuel Dobson: Merge #17264: rpc: set default bip32derivs to true for psbt methods
163 2020-02-25T10:51:45  *** bitcoin-git has left #bitcoin-core-dev
164 2020-02-25T10:52:31  *** bitcoin-git has joined #bitcoin-core-dev
165 2020-02-25T10:52:31  <bitcoin-git> [bitcoin] meshcollider merged pull request #17264: rpc: set default bip32derivs to true for psbt methods (master...2019/10/bip32_derivs) https://github.com/bitcoin/bitcoin/pull/17264
166 2020-02-25T10:52:32  *** bitcoin-git has left #bitcoin-core-dev
167 2020-02-25T10:56:42  <provoostenator> AppVeyor is in a bad mood again.
168 2020-02-25T11:03:58  *** Keven34Dooley has joined #bitcoin-core-dev
169 2020-02-25T11:27:41  *** promag has quit IRC
170 2020-02-25T11:32:13  *** AaronvanW has joined #bitcoin-core-dev
171 2020-02-25T11:35:38  *** AaronvanW has quit IRC
172 2020-02-25T11:37:25  *** Guyver2_ has joined #bitcoin-core-dev
173 2020-02-25T11:40:25  *** Guyver2 has quit IRC
174 2020-02-25T11:44:47  *** Emcy has quit IRC
175 2020-02-25T12:00:01  *** Dieterbe1 has quit IRC
176 2020-02-25T12:03:29  *** bitcoin-git has joined #bitcoin-core-dev
177 2020-02-25T12:03:29  <bitcoin-git> [bitcoin] sipsorcery opened pull request #18207: WIP: Touch appveyor vcpkg file to force refresh (master...appveyor-force-refresh) https://github.com/bitcoin/bitcoin/pull/18207
178 2020-02-25T12:03:30  *** bitcoin-git has left #bitcoin-core-dev
179 2020-02-25T12:04:04  *** promag has joined #bitcoin-core-dev
180 2020-02-25T12:04:26  <provoostenator> Surprising number of "needs rebase" after #17577, even though most of those PRs built right on top of it.
181 2020-02-25T12:04:29  <gribble> https://github.com/bitcoin/bitcoin/issues/17577 | refactor: deduplicate the message sign/verify code by vasild · Pull Request #17577 · bitcoin/bitcoin · GitHub
182 2020-02-25T12:07:50  *** Kiminuo has quit IRC
183 2020-02-25T12:10:40  *** promag has quit IRC
184 2020-02-25T12:29:31  *** rafalcpp has quit IRC
185 2020-02-25T12:34:18  *** Kiminuo has joined #bitcoin-core-dev
186 2020-02-25T12:36:00  *** rafalcpp has joined #bitcoin-core-dev
187 2020-02-25T12:37:02  *** promag has joined #bitcoin-core-dev
188 2020-02-25T12:41:43  *** promag has quit IRC
189 2020-02-25T12:43:34  *** Ceriand has joined #bitcoin-core-dev
190 2020-02-25T12:51:53  *** Emcy has joined #bitcoin-core-dev
191 2020-02-25T13:00:02  *** provoostenator has quit IRC
192 2020-02-25T13:02:11  *** mol has joined #bitcoin-core-dev
193 2020-02-25T13:14:48  *** promag has joined #bitcoin-core-dev
194 2020-02-25T13:19:18  *** promag has quit IRC
195 2020-02-25T13:20:59  *** belcher has joined #bitcoin-core-dev
196 2020-02-25T13:22:46  *** bitcoin-git has joined #bitcoin-core-dev
197 2020-02-25T13:22:46  <bitcoin-git> [bitcoin] sipsorcery closed pull request #18207: WIP: Touch appveyor vcpkg file to force refresh (master...appveyor-force-refresh) https://github.com/bitcoin/bitcoin/pull/18207
198 2020-02-25T13:22:47  *** bitcoin-git has left #bitcoin-core-dev
199 2020-02-25T13:42:23  *** Highway61 has joined #bitcoin-core-dev
200 2020-02-25T13:51:07  *** goatpig has quit IRC
201 2020-02-25T13:51:43  <instagibbs> yeah annoying, but review should be pretty simply
202 2020-02-25T13:51:47  <instagibbs> simple
203 2020-02-25T13:58:41  <vasild> I just checked #18115 for example. It is "based" on #17577 but the commit ids are different: https://0bin.net/paste/ZgRPbnAXjrPZvk9Q#KZaaPhwa3QeB34w8wMdr5JVyKwkl+WaVI9rcjfb5H7z
204 2020-02-25T13:58:45  <gribble> https://github.com/bitcoin/bitcoin/issues/18115 | wallet: Pass in transactions and messages for signing instead of exporting the private keys by achow101 · Pull Request #18115 · bitcoin/bitcoin · GitHub
205 2020-02-25T13:58:47  <gribble> https://github.com/bitcoin/bitcoin/issues/17577 | refactor: deduplicate the message sign/verify code by vasild · Pull Request #17577 · bitcoin/bitcoin · GitHub
206 2020-02-25T13:59:15  <vasild> so, from git perspective #18115 is not based on #17577
207 2020-02-25T13:59:17  <gribble> https://github.com/bitcoin/bitcoin/issues/18115 | wallet: Pass in transactions and messages for signing instead of exporting the private keys by achow101 · Pull Request #18115 · bitcoin/bitcoin · GitHub
208 2020-02-25T13:59:19  <gribble> https://github.com/bitcoin/bitcoin/issues/17577 | refactor: deduplicate the message sign/verify code by vasild · Pull Request #17577 · bitcoin/bitcoin · GitHub
209 2020-02-25T14:13:35  *** goatpig has joined #bitcoin-core-dev
210 2020-02-25T14:19:02  <vasild> I tried to rebase achow101/sign-in-spkman on top of bitcoin/master and got a conflict not related to 17577, but due to #17264 which modified src/wallet/psbtwallet.h (git show 29a21c906 -- src/wallet/psbtwallet.h) and 18115 deleted the file. To resolve, I replayed the change on wallet.h: git rebase bitcoin/master ; git rm src/wallet/psbtwallet.h ; sed -i '' 's/bip32derivs = false/bip32derivs =
211 2020-02-25T14:19:05  <gribble> https://github.com/bitcoin/bitcoin/issues/17264 | rpc: set default bip32derivs to true for psbt methods by Sjors · Pull Request #17264 · bitcoin/bitcoin · GitHub
212 2020-02-25T14:19:09  <vasild> true/' src/wallet/wallet.h ; git add src/wallet/wallet.h ; git rebase --continue
213 2020-02-25T14:19:19  *** goatpig has quit IRC
214 2020-02-25T14:26:36  *** Keven34Dooley has quit IRC
215 2020-02-25T14:37:14  *** goatpig has joined #bitcoin-core-dev
216 2020-02-25T14:37:26  *** provoostenator has joined #bitcoin-core-dev
217 2020-02-25T14:37:55  *** Kiminuo has quit IRC
218 2020-02-25T15:00:02  *** Ceriand has quit IRC
219 2020-02-25T15:14:43  *** Kiminuo has joined #bitcoin-core-dev
220 2020-02-25T15:15:23  *** brianhoffman has quit IRC
221 2020-02-25T15:15:49  *** NilsHitze has joined #bitcoin-core-dev
222 2020-02-25T15:18:02  *** brianhoffman has joined #bitcoin-core-dev
223 2020-02-25T15:26:10  *** pinheadmz has quit IRC
224 2020-02-25T15:26:35  *** pinheadmz has joined #bitcoin-core-dev
225 2020-02-25T15:26:55  *** t420babe has quit IRC
226 2020-02-25T15:27:24  *** t420babe has joined #bitcoin-core-dev
227 2020-02-25T15:27:31  *** adam3us has quit IRC
228 2020-02-25T15:27:54  *** nsh has quit IRC
229 2020-02-25T15:29:11  *** adam3us has joined #bitcoin-core-dev
230 2020-02-25T15:45:02  *** nsh has joined #bitcoin-core-dev
231 2020-02-25T15:47:30  *** mdunnio has joined #bitcoin-core-dev
232 2020-02-25T15:49:25  *** AaronvanW has joined #bitcoin-core-dev
233 2020-02-25T16:03:26  *** ahmed_ has joined #bitcoin-core-dev
234 2020-02-25T16:09:52  *** goatpig has quit IRC
235 2020-02-25T16:13:10  <sdaftuar> sipa: around?  i was just discussing wtxid-relay with gleb, he brought up that the erlay proposal included a 128-bit wtxid-relay component as well, which made me think that if we wanted to go that route, i should just update my proposal for wtxid-relay to do that
236 2020-02-25T16:13:57  <sipa> sdaftuar: yeah, that seems reasonable
237 2020-02-25T16:14:00  <sdaftuar> sipa: but that made me wonder if 128-bit commitments are secure enough for transaction relay; seems like in protocols where multiple parties are jointly constructing transactions, you only get 64-bit security against collisions, which could be used to interfere with relay?
238 2020-02-25T16:14:20  <sipa> hmm
239 2020-02-25T16:16:02  *** ddustin has joined #bitcoin-core-dev
240 2020-02-25T16:16:54  *** AaronvanW has quit IRC
241 2020-02-25T16:16:56  <sipa> 2^64 is still an enormous amount of work... not "impossible", but it's still several days with a modern ASIC miner
242 2020-02-25T16:17:19  <gleb> For the context, there's no real need to use 128-bit in Erlay, it's just an additional bandwidth saving, maybe about 5% of the overall bandwidth a node consumes.
243 2020-02-25T16:17:49  <sipa> (assuming an ASIC could even be used for that purpose of course)
244 2020-02-25T16:18:09  <sipa> and at those cost levels there are probably easier ways to interfere with relay
245 2020-02-25T16:18:28  *** bitcoin-git has joined #bitcoin-core-dev
246 2020-02-25T16:18:28  <bitcoin-git> [bitcoin] yusufsahinhamza opened pull request #18208: rpc: Fix RPCExamples (master...fix-rpc-examples) https://github.com/bitcoin/bitcoin/pull/18208
247 2020-02-25T16:18:29  *** bitcoin-git has left #bitcoin-core-dev
248 2020-02-25T16:18:31  <sdaftuar> right, and maybe protocols today work in such a way to make this not really an issue, just hard for me to reason about it
249 2020-02-25T16:19:33  *** bitcoin-git has joined #bitcoin-core-dev
250 2020-02-25T16:19:33  <bitcoin-git> [bitcoin] yusufsahinhamza closed pull request #18197: rpc: update some RPCExamples to bech32 (master...rpc-examples) https://github.com/bitcoin/bitcoin/pull/18197
251 2020-02-25T16:19:34  *** bitcoin-git has left #bitcoin-core-dev
252 2020-02-25T16:56:31  <sipa> sdaftuar: like... you could just create a double spend instead
253 2020-02-25T16:56:51  *** bitcoin-git has joined #bitcoin-core-dev
254 2020-02-25T16:56:51  <bitcoin-git> [bitcoin] yusufsahinhamza reopened pull request #18197: rpc: update some RPCExamples to bech32 (master...rpc-examples) https://github.com/bitcoin/bitcoin/pull/18197
255 2020-02-25T16:56:52  *** bitcoin-git has left #bitcoin-core-dev
256 2020-02-25T16:56:52  <sipa> so i think the goal is making sure relay isn't worse accidentally
257 2020-02-25T16:56:57  <sipa> rather tha  intentionally
258 2020-02-25T16:57:20  *** mol has quit IRC
259 2020-02-25T17:03:57  <MarcoFalke> PSA to review locally. GitHub is again serving corrupt pull requests on the website
260 2020-02-25T17:07:20  <achow101> vasild: usually when I base a PR on other commits, we just cherry pick those commits and base the whole thing on whatever the master was at that time
261 2020-02-25T17:07:42  <achow101> so the commit hashes won't match, but the diffs do
262 2020-02-25T17:07:51  <achow101> then during a rebase, those commits can be dropped and the overall diff stays the same
263 2020-02-25T17:10:37  <vasild> achow101: I see, github nevertheless, still prints "This branch has conflicts that must be resolved ... src/util/message.h" even though when I tried the rebase there was not a conflict in src/util/message.h
264 2020-02-25T17:11:35  <MarcoFalke> vasild: GitHub backend is down or lagging, so that might be the issue
265 2020-02-25T17:12:04  <sdaftuar> sipa: not sure i follow... are there protocols where you and i might produce a multisig transaction (signing a shared output i can't double-spend),but where interfering with the relay of that jointly-constructed transaction is beneficial to me somehow?
266 2020-02-25T17:12:12  <sdaftuar> ie in lightning
267 2020-02-25T17:12:18  <achow101> It's normal for github to say there's a merge conflict when the files that were modified by the base PR gets merged
268 2020-02-25T17:12:43  <sdaftuar> this might be easier for me to talk about if i actually had any idea how lightning works, let me ask someone here :)
269 2020-02-25T17:14:08  <sipa> sdaftuar: oh good point, let me think more
270 2020-02-25T17:15:17  <vasild> achow101: yes, all good
271 2020-02-25T17:16:15  *** promag has joined #bitcoin-core-dev
272 2020-02-25T17:17:31  <sipa> sdaftuar: somehow i thought a collision would need multiple parties to collaborate; need more caffeine
273 2020-02-25T17:19:35  <sdaftuar> i just talked it through with matt and he seems to believe that what i'm saying would be a concern in lightning (at least theoretically -- as a practical matter i have no idea)
274 2020-02-25T17:20:21  <sipa> another possibility is just skipping 128-bit wtxid for now, and doing it as a later step (orthogonal to wtxid and erlay)
275 2020-02-25T17:20:38  *** promag has quit IRC
276 2020-02-25T17:22:38  <sipa> or not
277 2020-02-25T17:25:27  *** Emcy has quit IRC
278 2020-02-25T17:36:40  *** krvopije has joined #bitcoin-core-dev
279 2020-02-25T17:37:06  *** krvopije has quit IRC
280 2020-02-25T17:46:01  *** justanotheruser has quit IRC
281 2020-02-25T17:50:32  *** Emcy has joined #bitcoin-core-dev
282 2020-02-25T17:56:36  <gleb> I'm afraid that means that final potential version will have to support txid, wtxid, and trunc-wtxid, so 3 different filters?
283 2020-02-25T18:00:01  *** NilsHitze has quit IRC
284 2020-02-25T18:02:33  *** bitcoin-git has joined #bitcoin-core-dev
285 2020-02-25T18:02:33  <bitcoin-git> [bitcoin] yusufsahinhamza closed pull request #18197: rpc: update some RPCExamples to bech32 (master...rpc-examples) https://github.com/bitcoin/bitcoin/pull/18197
286 2020-02-25T18:02:35  *** bitcoin-git has left #bitcoin-core-dev
287 2020-02-25T18:07:06  *** spinny has joined #bitcoin-core-dev
288 2020-02-25T18:07:19  <sipa> gleb: at least with ordered indexes, one index suffices for both 128-bit and 256-bit lookups
289 2020-02-25T18:07:46  <sipa> ah, but the current mempool index is not ordered
290 2020-02-25T18:12:29  *** justanotheruser has joined #bitcoin-core-dev
291 2020-02-25T18:16:05  *** StephenS1 has joined #bitcoin-core-dev
292 2020-02-25T18:22:14  *** ahmed_ has quit IRC
293 2020-02-25T18:34:05  *** theoRem_ has joined #bitcoin-core-dev
294 2020-02-25T18:34:11  *** justanotheruser has quit IRC
295 2020-02-25T18:34:29  *** theoRem_ is now known as Guest52093
296 2020-02-25T18:34:58  <sdaftuar> my instinct is that for a 5% bandwidth savings (once we have erlay), it's not really worth the effort to try to convince ourselves that the truncated hash is safe, but i feel a bit bad being a defeatist
297 2020-02-25T18:43:29  *** Guest52093 has quit IRC
298 2020-02-25T18:43:43  *** ghost43 has quit IRC
299 2020-02-25T18:44:02  *** ghost43 has joined #bitcoin-core-dev
300 2020-02-25T18:45:36  *** promag has joined #bitcoin-core-dev
301 2020-02-25T18:49:58  *** justanotheruser has joined #bitcoin-core-dev
302 2020-02-25T18:55:31  <gleb> Yeah, at this point I'd also prefer to stick with 256-bit ids, for the reason suhas points out. I also bet someone smart would decide to waste their time to write a paper about attacking bitcoin with this thing :)
303 2020-02-25T19:02:08  <sipa> maybe that's indeed best
304 2020-02-25T19:03:33  *** promag has quit IRC
305 2020-02-25T19:07:14  *** captjakk has joined #bitcoin-core-dev
306 2020-02-25T19:14:27  *** ghost43 has quit IRC
307 2020-02-25T19:15:12  *** ghost43 has joined #bitcoin-core-dev
308 2020-02-25T19:15:54  *** bitcoin-git has joined #bitcoin-core-dev
309 2020-02-25T19:15:54  <bitcoin-git> [bitcoin] kiminuo opened pull request #18210: Type hints in Python tests (master...feature/type-hint-minimum) https://github.com/bitcoin/bitcoin/pull/18210
310 2020-02-25T19:15:55  *** bitcoin-git has left #bitcoin-core-dev
311 2020-02-25T19:21:40  <instagibbs> gleb, another way to look at it is including truncated wtxid may slow down erlay, which has asymptotic win, not just %
312 2020-02-25T19:21:46  <instagibbs> wrt number of peers
313 2020-02-25T19:21:52  <instagibbs> slow down acceptance of erlay*
314 2020-02-25T19:22:44  <gleb> instagibbs: Why would it slow down the acceptance of erlay?
315 2020-02-25T19:26:31  <instagibbs> another bikeshedding/discussion, just like here :)
316 2020-02-25T19:26:46  <instagibbs> maybe I'm wrong, then nevermind me
317 2020-02-25T19:27:21  <sipa> instagibbs: that's boring, sure you're not up for a trial by combat to determine who is right?
318 2020-02-25T19:28:56  <gleb> instagibbs: In this particular case I was less optimistic about people caring, but yeah, you're right in that sense.
319 2020-02-25T19:32:41  *** mk_ has quit IRC
320 2020-02-25T19:38:39  *** bitcoin-git has joined #bitcoin-core-dev
321 2020-02-25T19:38:39  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/31c0006a6cd5...c3b471592346
322 2020-02-25T19:38:40  <bitcoin-git> bitcoin/master 2a6a6ea practicalswift: tests: Add fuzzing harness for bloom filter class CBloomFilter
323 2020-02-25T19:38:40  <bitcoin-git> bitcoin/master eabbbe4 practicalswift: tests: Add fuzzing harness for rolling bloom filter class CRollingBloomFil...
324 2020-02-25T19:38:41  <bitcoin-git> bitcoin/master c3b4715 MarcoFalke: Merge #18206: tests: Add fuzzing harness for bloom filter classes (CBloomF...
325 2020-02-25T19:38:51  *** bitcoin-git has left #bitcoin-core-dev
326 2020-02-25T19:39:09  *** bitcoin-git has joined #bitcoin-core-dev
327 2020-02-25T19:39:09  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18206: tests: Add fuzzing harness for bloom filter classes (CBloomFilter + CRollingBloomFilter) (master...fuzzers-bloom_filter) https://github.com/bitcoin/bitcoin/pull/18206
328 2020-02-25T19:39:10  *** bitcoin-git has left #bitcoin-core-dev
329 2020-02-25T19:40:30  *** vasild_ has joined #bitcoin-core-dev
330 2020-02-25T19:43:43  *** vasild has quit IRC
331 2020-02-25T19:57:14  *** jonatack has quit IRC
332 2020-02-25T20:16:26  <sdaftuar> jeremyrubin: around?
333 2020-02-25T20:29:29  *** bitcoin-git has joined #bitcoin-core-dev
334 2020-02-25T20:29:29  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18211: test: Work around scheduler_tests intermittent failures (take 2) (master...2002-testSchedulerWorkaround) https://github.com/bitcoin/bitcoin/pull/18211
335 2020-02-25T20:29:30  *** bitcoin-git has left #bitcoin-core-dev
336 2020-02-25T20:32:09  *** guest534543 has joined #bitcoin-core-dev
337 2020-02-25T20:35:23  *** Kiminuo has quit IRC
338 2020-02-25T20:43:11  *** justanotheruser has quit IRC
339 2020-02-25T20:49:14  *** guest534543 has quit IRC
340 2020-02-25T20:49:38  *** Kiminuo has joined #bitcoin-core-dev
341 2020-02-25T20:52:00  *** promag has joined #bitcoin-core-dev
342 2020-02-25T21:00:01  *** StephenS1 has quit IRC
343 2020-02-25T21:20:16  *** spinny has quit IRC
344 2020-02-25T21:35:14  *** ghost1 has joined #bitcoin-core-dev
345 2020-02-25T21:37:16  *** timothy has quit IRC
346 2020-02-25T21:39:33  *** manantial has quit IRC
347 2020-02-25T21:45:11  *** mikeyman77 has joined #bitcoin-core-dev
348 2020-02-25T21:57:16  *** ghost1 has quit IRC
349 2020-02-25T22:02:52  *** andrewtoth has joined #bitcoin-core-dev
350 2020-02-25T22:04:04  *** captjakk has quit IRC
351 2020-02-25T22:13:38  *** justanotheruser has joined #bitcoin-core-dev
352 2020-02-25T22:14:36  *** Guyver2_ has quit IRC
353 2020-02-25T22:16:15  *** belcher has quit IRC
354 2020-02-25T22:16:27  *** Emcy has quit IRC
355 2020-02-25T22:29:07  *** Emcy has joined #bitcoin-core-dev
356 2020-02-25T22:32:13  *** AaronvanW has joined #bitcoin-core-dev
357 2020-02-25T22:40:34  *** djpeen has joined #bitcoin-core-dev
358 2020-02-25T22:42:14  *** djpeen_ has joined #bitcoin-core-dev
359 2020-02-25T22:43:03  *** djpeen has joined #bitcoin-core-dev
360 2020-02-25T22:51:46  *** AaronvanW has quit IRC
361 2020-02-25T22:58:24  *** captjakk has joined #bitcoin-core-dev
362 2020-02-25T23:00:16  <achow101> what would cause std::map to not find an element that's definitely there?
363 2020-02-25T23:00:54  <achow101> examining in gdb tells me the element is there and the key I'm searching with is correct. but it always returns end()
364 2020-02-25T23:02:08  *** filchef has joined #bitcoin-core-dev
365 2020-02-25T23:03:19  *** filchef has quit IRC
366 2020-02-25T23:07:10  <sipa> achow101: was the key elememt modified after inserting?
367 2020-02-25T23:07:39  <achow101> no
368 2020-02-25T23:07:57  <sipa> what is the key type?
369 2020-02-25T23:08:08  <achow101> KeyOriginInfo. I added an operator<
370 2020-02-25T23:08:33  <sipa> what pr?
371 2020-02-25T23:09:24  <achow101> I haven't pushed it yet. it's supposed to be a modification to #18204
372 2020-02-25T23:09:26  <gribble> https://github.com/bitcoin/bitcoin/issues/18204 | descriptors: improve descriptor cache and cache xpubs by achow101 · Pull Request #18204 · bitcoin/bitcoin · GitHub
373 2020-02-25T23:09:52  <sipa> ok link to code/branchm
374 2020-02-25T23:09:54  <sipa> ?
375 2020-02-25T23:09:57  *** mdunnio has quit IRC
376 2020-02-25T23:10:57  <achow101> https://github.com/achow101/bitcoin/tree/desc-xpub-cache2
377 2020-02-25T23:11:30  <achow101> descriptor_tests fails currently due to that maps thing
378 2020-02-25T23:11:41  <sipa> your operator< is inconsistent
379 2020-02-25T23:11:48  <achow101> it is?
380 2020-02-25T23:12:10  <sipa> if a.fingerprint > b.fingerprint you have to return false
381 2020-02-25T23:12:26  <sipa> even if a.path < b.path
382 2020-02-25T23:13:14  <achow101> ah
383 2020-02-25T23:13:39  <sipa> the general structure of such comparators is something like: if a.x < b.x return true; if a.x > b.x return false; if a.x == b.x fall through to next tie breaker
384 2020-02-25T23:15:36  <achow101> I guess that explains why it only failed with the multi descriptors too
385 2020-02-25T23:15:47  <achow101> when I had more than one xpub in the map
386 2020-02-25T23:16:35  <sipa> right
387 2020-02-25T23:19:43  *** captjakk has quit IRC
388 2020-02-25T23:21:55  *** AaronvanW has joined #bitcoin-core-dev
389 2020-02-25T23:21:59  *** captjakk has joined #bitcoin-core-dev
390 2020-02-25T23:24:40  *** promag has quit IRC
391 2020-02-25T23:31:27  *** wullon5 has quit IRC
392 2020-02-25T23:35:55  *** nullptr| has quit IRC
393 2020-02-25T23:49:42  *** captjakk has quit IRC
394 2020-02-25T23:50:30  *** nullptr| has joined #bitcoin-core-dev