1 2020-02-26T00:00:02  *** mikeyman77 has quit IRC
  2 2020-02-26T00:16:21  *** captjakk has joined #bitcoin-core-dev
  3 2020-02-26T00:17:58  *** aqu4 has joined #bitcoin-core-dev
  4 2020-02-26T00:24:00  *** AaronvanW has quit IRC
  5 2020-02-26T00:28:55  *** captjakk has quit IRC
  6 2020-02-26T00:31:39  *** marcoagner has quit IRC
  7 2020-02-26T00:45:08  *** captjakk has joined #bitcoin-core-dev
  8 2020-02-26T00:54:18  *** captjakk has quit IRC
  9 2020-02-26T00:56:46  *** AaronvanW has joined #bitcoin-core-dev
 10 2020-02-26T01:01:37  *** AaronvanW has quit IRC
 11 2020-02-26T01:16:27  *** promag has joined #bitcoin-core-dev
 12 2020-02-26T01:33:02  *** mol has joined #bitcoin-core-dev
 13 2020-02-26T01:35:06  *** AaronvanW has joined #bitcoin-core-dev
 14 2020-02-26T01:41:57  *** promag_ has joined #bitcoin-core-dev
 15 2020-02-26T01:42:37  *** promag__ has joined #bitcoin-core-dev
 16 2020-02-26T01:43:51  *** promag has quit IRC
 17 2020-02-26T01:46:37  *** promag_ has quit IRC
 18 2020-02-26T02:00:59  <fanquake> promag: does #18160 actually fix a bug, like incorrect balances, or just improves on "a waste of resources"? If it's the later, it's unlikely it'd be backported.
 19 2020-02-26T02:01:01  <gribble> https://github.com/bitcoin/bitcoin/issues/18160 | gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged by promag · Pull Request #18160 · bitcoin/bitcoin · GitHub
 20 2020-02-26T02:02:42  <fanquake> Generally we only want to backport actual bug/security fixes. Making some poll/loop in the GUI slightly more efficient doesn't really qualify. Unless I'm missing something of course.
 21 2020-02-26T02:07:14  *** AaronvanW has quit IRC
 22 2020-02-26T02:08:29  *** promag__ has quit IRC
 23 2020-02-26T02:16:55  *** Highway61 has quit IRC
 24 2020-02-26T02:55:12  *** captjakk has joined #bitcoin-core-dev
 25 2020-02-26T03:00:01  *** aqu4 has quit IRC
 26 2020-02-26T03:01:13  *** bitcoin-git has joined #bitcoin-core-dev
 27 2020-02-26T03:01:13  <bitcoin-git> [bitcoin] luke-jr closed pull request #17213: gui: Add Windows taskbar progress (master...win_taskbar_progress) https://github.com/bitcoin/bitcoin/pull/17213
 28 2020-02-26T03:01:18  *** bitcoin-git has left #bitcoin-core-dev
 29 2020-02-26T03:01:28  *** SiAnDoG has quit IRC
 30 2020-02-26T03:01:51  *** SiAnDoG has joined #bitcoin-core-dev
 31 2020-02-26T03:07:58  *** captjakk has quit IRC
 32 2020-02-26T03:17:52  *** Lord1 has joined #bitcoin-core-dev
 33 2020-02-26T03:26:09  *** AaronvanW has joined #bitcoin-core-dev
 34 2020-02-26T03:30:50  *** andrewtoth has quit IRC
 35 2020-02-26T03:31:16  *** andrewtoth has joined #bitcoin-core-dev
 36 2020-02-26T03:40:07  *** felixfoertsch has quit IRC
 37 2020-02-26T03:40:17  *** felixfoertsch23 has joined #bitcoin-core-dev
 38 2020-02-26T03:40:58  <meshcollider> fanquake: I think it's the latter
 39 2020-02-26T03:47:36  *** dingus is now known as grubles
 40 2020-02-26T03:59:22  *** AaronvanW has quit IRC
 41 2020-02-26T04:13:26  *** captjakk has joined #bitcoin-core-dev
 42 2020-02-26T04:24:43  *** captjakk has quit IRC
 43 2020-02-26T04:26:20  *** captjakk has joined #bitcoin-core-dev
 44 2020-02-26T04:30:42  *** captjakk has quit IRC
 45 2020-02-26T05:10:07  *** nullptr| has quit IRC
 46 2020-02-26T05:24:59  *** nullptr| has joined #bitcoin-core-dev
 47 2020-02-26T05:44:52  *** captjakk has joined #bitcoin-core-dev
 48 2020-02-26T05:49:15  *** captjakk has quit IRC
 49 2020-02-26T05:56:50  *** AaronvanW has joined #bitcoin-core-dev
 50 2020-02-26T06:00:01  *** Lord1 has quit IRC
 51 2020-02-26T06:17:49  *** jchris has joined #bitcoin-core-dev
 52 2020-02-26T06:29:27  *** AaronvanW has quit IRC
 53 2020-02-26T06:52:24  *** ghost43 has quit IRC
 54 2020-02-26T06:53:43  *** ghost43 has joined #bitcoin-core-dev
 55 2020-02-26T06:54:39  *** Kiminuo has quit IRC
 56 2020-02-26T06:59:31  *** Highway61 has joined #bitcoin-core-dev
 57 2020-02-26T07:05:13  *** Kiminuo has joined #bitcoin-core-dev
 58 2020-02-26T07:15:50  *** ddustin has joined #bitcoin-core-dev
 59 2020-02-26T07:20:31  *** ddustin has quit IRC
 60 2020-02-26T07:40:36  *** vasild has joined #bitcoin-core-dev
 61 2020-02-26T07:43:43  *** vasild_ has quit IRC
 62 2020-02-26T07:44:35  *** Karyon has quit IRC
 63 2020-02-26T07:53:50  *** molly has joined #bitcoin-core-dev
 64 2020-02-26T07:56:56  *** mol has quit IRC
 65 2020-02-26T08:06:51  *** Karyon has joined #bitcoin-core-dev
 66 2020-02-26T08:26:33  *** AaronvanW has joined #bitcoin-core-dev
 67 2020-02-26T08:32:11  *** AaronvanW has quit IRC
 68 2020-02-26T08:32:30  *** AaronvanW has joined #bitcoin-core-dev
 69 2020-02-26T08:37:54  *** marcoagner has joined #bitcoin-core-dev
 70 2020-02-26T08:38:41  *** luke-jr has quit IRC
 71 2020-02-26T08:41:42  *** luke-jr has joined #bitcoin-core-dev
 72 2020-02-26T08:55:29  *** goatpig has joined #bitcoin-core-dev
 73 2020-02-26T08:55:43  *** AaronvanW has quit IRC
 74 2020-02-26T08:56:20  *** AaronvanW has joined #bitcoin-core-dev
 75 2020-02-26T08:58:31  *** promag has joined #bitcoin-core-dev
 76 2020-02-26T09:00:02  *** jchris has quit IRC
 77 2020-02-26T09:01:39  *** promag has quit IRC
 78 2020-02-26T09:14:00  *** ccallahan1 has joined #bitcoin-core-dev
 79 2020-02-26T09:15:27  *** promag has joined #bitcoin-core-dev
 80 2020-02-26T09:22:32  *** promag has quit IRC
 81 2020-02-26T09:47:57  *** Guyver2 has joined #bitcoin-core-dev
 82 2020-02-26T09:49:28  *** justanotheruser has quit IRC
 83 2020-02-26T09:59:15  *** promag has joined #bitcoin-core-dev
 84 2020-02-26T10:02:49  *** timothy has joined #bitcoin-core-dev
 85 2020-02-26T10:03:49  *** promag has quit IRC
 86 2020-02-26T10:06:49  *** promag has joined #bitcoin-core-dev
 87 2020-02-26T10:55:31  *** tryphe_ has joined #bitcoin-core-dev
 88 2020-02-26T10:56:59  *** tryphe__ has joined #bitcoin-core-dev
 89 2020-02-26T10:57:29  *** tryphe has quit IRC
 90 2020-02-26T11:00:10  *** tryphe_ has quit IRC
 91 2020-02-26T11:03:57  *** Kira21Altenwerth has joined #bitcoin-core-dev
 92 2020-02-26T11:32:03  *** bitcoin-git has joined #bitcoin-core-dev
 93 2020-02-26T11:32:03  <bitcoin-git> [bitcoin] promag closed pull request #16145: gui: Prevent idle sleep in macos while in IBD (master...2019-06-prevent-idle-sleep-ibd) https://github.com/bitcoin/bitcoin/pull/16145
 94 2020-02-26T11:32:04  *** bitcoin-git has left #bitcoin-core-dev
 95 2020-02-26T11:40:33  *** manantial has joined #bitcoin-core-dev
 96 2020-02-26T11:44:56  *** EagleTM has joined #bitcoin-core-dev
 97 2020-02-26T12:00:02  *** ccallahan1 has quit IRC
 98 2020-02-26T12:17:42  *** RandIter has joined #bitcoin-core-dev
 99 2020-02-26T12:30:39  *** Kira21Altenwerth has quit IRC
100 2020-02-26T12:34:43  *** vasild has quit IRC
101 2020-02-26T12:36:36  *** vasild has joined #bitcoin-core-dev
102 2020-02-26T12:45:38  *** ddustin has joined #bitcoin-core-dev
103 2020-02-26T12:50:34  *** ddustin has quit IRC
104 2020-02-26T13:29:24  *** Guyver2_ has joined #bitcoin-core-dev
105 2020-02-26T13:31:57  *** Guyver2 has quit IRC
106 2020-02-26T13:32:48  *** ghost43 has quit IRC
107 2020-02-26T13:33:44  *** bitcoin-git has joined #bitcoin-core-dev
108 2020-02-26T13:33:44  <bitcoin-git> [bitcoin] jonatack closed pull request #18178: script: de-dupe and update valgrind suppressions (master...add-valgrind-suppressions) https://github.com/bitcoin/bitcoin/pull/18178
109 2020-02-26T13:33:45  *** bitcoin-git has left #bitcoin-core-dev
110 2020-02-26T13:34:38  *** ghost43 has joined #bitcoin-core-dev
111 2020-02-26T13:38:55  *** jonatack has joined #bitcoin-core-dev
112 2020-02-26T13:43:33  *** promag has quit IRC
113 2020-02-26T13:43:54  *** Highway61 has quit IRC
114 2020-02-26T13:44:55  *** promag has joined #bitcoin-core-dev
115 2020-02-26T13:46:57  *** justanotheruser has joined #bitcoin-core-dev
116 2020-02-26T13:49:36  *** promag has quit IRC
117 2020-02-26T14:16:59  *** Highway61 has joined #bitcoin-core-dev
118 2020-02-26T14:23:30  *** promag has joined #bitcoin-core-dev
119 2020-02-26T14:27:56  *** promag has quit IRC
120 2020-02-26T14:39:21  *** promag has joined #bitcoin-core-dev
121 2020-02-26T14:41:02  *** promag has quit IRC
122 2020-02-26T14:42:35  *** promag has joined #bitcoin-core-dev
123 2020-02-26T14:45:26  *** promag has quit IRC
124 2020-02-26T14:53:51  *** promag has joined #bitcoin-core-dev
125 2020-02-26T15:00:01  *** RandIter has quit IRC
126 2020-02-26T15:02:49  *** promag has quit IRC
127 2020-02-26T15:03:30  *** promag has joined #bitcoin-core-dev
128 2020-02-26T15:08:21  *** Highway62 has joined #bitcoin-core-dev
129 2020-02-26T15:08:24  *** molly has quit IRC
130 2020-02-26T15:08:38  *** andrewtoth_ has joined #bitcoin-core-dev
131 2020-02-26T15:09:36  *** promag has quit IRC
132 2020-02-26T15:09:43  *** andrewtoth has quit IRC
133 2020-02-26T15:10:06  *** Highway61 has quit IRC
134 2020-02-26T15:10:06  *** Highway62 is now known as Highway61
135 2020-02-26T15:11:06  *** promag has joined #bitcoin-core-dev
136 2020-02-26T15:12:18  *** Chris_Stewart_5 has quit IRC
137 2020-02-26T15:12:37  *** Chris_Stewart_5 has joined #bitcoin-core-dev
138 2020-02-26T15:15:35  *** promag has quit IRC
139 2020-02-26T15:15:59  *** promag has joined #bitcoin-core-dev
140 2020-02-26T15:18:18  *** andyvk5 has joined #bitcoin-core-dev
141 2020-02-26T15:18:55  *** goatpig has quit IRC
142 2020-02-26T15:19:15  *** goatpig has joined #bitcoin-core-dev
143 2020-02-26T15:23:49  *** goatpig has quit IRC
144 2020-02-26T15:25:51  *** promag has quit IRC
145 2020-02-26T15:28:01  *** promag has joined #bitcoin-core-dev
146 2020-02-26T15:41:29  *** goatpig has joined #bitcoin-core-dev
147 2020-02-26T15:44:53  *** andrewtoth_ has quit IRC
148 2020-02-26T15:44:59  *** _andrewtoth_ has joined #bitcoin-core-dev
149 2020-02-26T15:46:12  *** mdunnio has joined #bitcoin-core-dev
150 2020-02-26T15:49:00  *** goat_ has joined #bitcoin-core-dev
151 2020-02-26T15:49:01  *** goatpig has quit IRC
152 2020-02-26T15:56:06  *** Guyver2__ has joined #bitcoin-core-dev
153 2020-02-26T15:58:10  *** Kiminuo has quit IRC
154 2020-02-26T15:59:20  *** Guyver2_ has quit IRC
155 2020-02-26T16:16:39  *** Guyver2__ is now known as Guyver2
156 2020-02-26T16:25:47  *** ghost43 has quit IRC
157 2020-02-26T16:26:43  *** ghost43 has joined #bitcoin-core-dev
158 2020-02-26T16:30:36  *** promag_ has joined #bitcoin-core-dev
159 2020-02-26T16:32:16  *** Kiminuo has joined #bitcoin-core-dev
160 2020-02-26T16:45:27  *** Emcy has quit IRC
161 2020-02-26T16:46:10  *** fox2p has quit IRC
162 2020-02-26T16:47:14  *** fox2p has joined #bitcoin-core-dev
163 2020-02-26T16:51:47  <stevenroose> Is anyone aware of some tools that auto-generate Core documentation from the source code? Basically like https://masonicboom.github.io/btcrpcapi/ but updated?
164 2020-02-26T16:52:23  <sdaftuar> stevenroose: doxygen?
165 2020-02-26T16:52:58  <sdaftuar> oh you mean API stuff, i don't know anything about that
166 2020-02-26T16:53:11  <stevenroose> I'm talking about rpc docs, yes.
167 2020-02-26T16:53:24  <stevenroose> Are the ones on bitcoin.org hand-crafted?
168 2020-02-26T16:53:48  <sdaftuar> no idea, maybe check with that project
169 2020-02-26T16:55:29  <sipa> sdaftuar: they're autogenerated from the rpc help command
170 2020-02-26T16:58:23  *** Emcy has joined #bitcoin-core-dev
171 2020-02-26T17:01:17  *** MasterdonX has quit IRC
172 2020-02-26T17:01:19  *** vvvpinuocao has joined #bitcoin-core-dev
173 2020-02-26T17:01:20  *** masterdonx2 has joined #bitcoin-core-dev
174 2020-02-26T17:01:59  *** vvvpinuocao has quit IRC
175 2020-02-26T17:05:37  *** promag has quit IRC
176 2020-02-26T17:07:41  *** promag has joined #bitcoin-core-dev
177 2020-02-26T17:08:42  *** captjakk has joined #bitcoin-core-dev
178 2020-02-26T17:10:28  <harding> stevenroose: this is the tool used for the RPC docs on BitcoinCore.org: https://github.com/bitcoin-core/bitcoincore.org/tree/master/contrib/doc-gen
179 2020-02-26T17:11:03  <stevenroose> harding: thanks!
180 2020-02-26T17:11:04  <harding> Bitcoin.org currently uses: https://github.com/cornelius/rpc-docs-helper
181 2020-02-26T17:11:24  <stevenroose> eh, there's two different ones?
182 2020-02-26T17:11:32  <stevenroose> harding: do you have an opinion on which one is better? :D
183 2020-02-26T17:12:13  <harding> stevenroose: I've only used the BitcoinCore.org.  Back when I worked on Bitcoin.org, I hand crafted those docs.  After years of those docs bitrotting, they wrote their own tool, but I've never used it.
184 2020-02-26T17:13:19  *** promag has quit IRC
185 2020-02-26T17:16:05  *** Guyver2_ has joined #bitcoin-core-dev
186 2020-02-26T17:18:53  *** Guyver2 has quit IRC
187 2020-02-26T17:30:26  *** promag has joined #bitcoin-core-dev
188 2020-02-26T17:37:23  *** bitcoin-git has joined #bitcoin-core-dev
189 2020-02-26T17:37:23  <bitcoin-git> [bitcoin] achow101 closed pull request #18163: descriptors: Use xpub at last hardened step if possible (master...desc-last-hardened) https://github.com/bitcoin/bitcoin/pull/18163
190 2020-02-26T17:37:25  *** bitcoin-git has left #bitcoin-core-dev
191 2020-02-26T17:38:03  *** promag has quit IRC
192 2020-02-26T17:38:41  *** lightlike has joined #bitcoin-core-dev
193 2020-02-26T17:44:38  *** promag has joined #bitcoin-core-dev
194 2020-02-26T17:46:30  *** promag has quit IRC
195 2020-02-26T17:46:39  *** bitcoin-git has joined #bitcoin-core-dev
196 2020-02-26T17:46:39  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c3b471592346...89a97a71f2ee
197 2020-02-26T17:46:40  <bitcoin-git> bitcoin/master facb715 MarcoFalke: net: Remove forcerelay of rejected txs
198 2020-02-26T17:46:40  <bitcoin-git> bitcoin/master 89a97a7 Wladimir J. van der Laan: Merge #17985: net: Remove forcerelay of rejected txs
199 2020-02-26T17:46:42  *** bitcoin-git has left #bitcoin-core-dev
200 2020-02-26T17:47:04  *** bitcoin-git has joined #bitcoin-core-dev
201 2020-02-26T17:47:04  <bitcoin-git> [bitcoin] laanwj merged pull request #17985: net: Remove forcerelay of rejected txs (master...2001-p2pNoDeadCode) https://github.com/bitcoin/bitcoin/pull/17985
202 2020-02-26T17:47:11  *** promag has joined #bitcoin-core-dev
203 2020-02-26T17:47:14  *** bitcoin-git has left #bitcoin-core-dev
204 2020-02-26T17:48:56  *** promag has quit IRC
205 2020-02-26T18:00:01  *** andyvk5 has quit IRC
206 2020-02-26T18:00:53  *** bitcoin-git has joined #bitcoin-core-dev
207 2020-02-26T18:00:53  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/89a97a71f2ee...e5d47ed8fd37
208 2020-02-26T18:00:54  <bitcoin-git> bitcoin/master be94096 Samer Afach: Fix a violation of C++ standard rules that unions cannot be switched.
209 2020-02-26T18:00:54  <bitcoin-git> bitcoin/master 0653939 Samer Afach: Add static_asserts to ser_X_to_Y() methods
210 2020-02-26T18:00:55  <bitcoin-git> bitcoin/master e5d47ed Wladimir J. van der Laan: Merge #18167: Fix a violation of C++ standard rules where unions are used ...
211 2020-02-26T18:00:56  *** bitcoin-git has left #bitcoin-core-dev
212 2020-02-26T18:01:13  *** bitcoin-git has joined #bitcoin-core-dev
213 2020-02-26T18:01:13  <bitcoin-git> [bitcoin] laanwj merged pull request #18167: Fix a violation of C++ standard rules where unions are used for type-punning (master...master) https://github.com/bitcoin/bitcoin/pull/18167
214 2020-02-26T18:01:15  *** bitcoin-git has left #bitcoin-core-dev
215 2020-02-26T18:02:13  *** laurentmt has joined #bitcoin-core-dev
216 2020-02-26T18:06:14  *** promag_ has quit IRC
217 2020-02-26T18:07:09  *** promag has joined #bitcoin-core-dev
218 2020-02-26T18:13:18  *** promag_ has joined #bitcoin-core-dev
219 2020-02-26T18:17:02  *** Mark_Cockrell has joined #bitcoin-core-dev
220 2020-02-26T18:18:10  *** promag_ has quit IRC
221 2020-02-26T18:19:33  *** promag has joined #bitcoin-core-dev
222 2020-02-26T18:20:13  *** promag has quit IRC
223 2020-02-26T18:22:29  *** mdunnio has quit IRC
224 2020-02-26T18:35:31  *** owowo has quit IRC
225 2020-02-26T18:38:01  *** mdunnio has joined #bitcoin-core-dev
226 2020-02-26T18:39:47  *** laurentmt has quit IRC
227 2020-02-26T18:40:17  *** owowo has joined #bitcoin-core-dev
228 2020-02-26T18:43:15  *** mdunnio has quit IRC
229 2020-02-26T18:46:26  *** promag has joined #bitcoin-core-dev
230 2020-02-26T18:48:22  *** mdunnio has joined #bitcoin-core-dev
231 2020-02-26T18:55:53  *** timothy has quit IRC
232 2020-02-26T18:58:27  *** captjakk has quit IRC
233 2020-02-26T19:03:42  *** captjakk has joined #bitcoin-core-dev
234 2020-02-26T19:10:14  *** tryphe__ is now known as tryphe
235 2020-02-26T19:11:59  *** promag has quit IRC
236 2020-02-26T19:16:28  *** captjakk has quit IRC
237 2020-02-26T19:18:49  *** captjakk has joined #bitcoin-core-dev
238 2020-02-26T19:20:09  *** fox2p has quit IRC
239 2020-02-26T19:20:53  <luke-jr> Is there a reason 0.19.1 isn't tagged yet? :x  wumpus
240 2020-02-26T19:27:55  <luke-jr> are we waiting on the macOS notary stuff?
241 2020-02-26T19:28:02  <luke-jr> (if not, relnotes are missing the right-click tip)
242 2020-02-26T19:40:34  *** vasild_ has joined #bitcoin-core-dev
243 2020-02-26T19:43:43  *** vasild has quit IRC
244 2020-02-26T20:07:13  *** filchef has joined #bitcoin-core-dev
245 2020-02-26T20:17:02  <achow101> provoostenator: instagibbs: with descriptor wallets, do we even want to cache the individual keys if we're going to cache the intermediate xpub?
246 2020-02-26T20:17:26  <achow101> so we just do on the fly key derivation
247 2020-02-26T20:23:20  *** ghost43 has quit IRC
248 2020-02-26T20:24:16  *** ghost43 has joined #bitcoin-core-dev
249 2020-02-26T20:25:23  <meshcollider> yeah i dont think we need individual pubkeys cached
250 2020-02-26T20:25:50  <achow101> I guess we only need them cached for hardened derivation
251 2020-02-26T20:26:33  <luke-jr> uh, are descriptor wallets not going to support hardened derivation?
252 2020-02-26T20:26:43  <achow101> they do
253 2020-02-26T20:27:15  <luke-jr> so then we need to cache the individual keys..
254 2020-02-26T20:27:29  <achow101> but only if they are hardened
255 2020-02-26T20:27:48  <luke-jr> seems like a bad idea to special-case each type of derivation
256 2020-02-26T20:28:29  <achow101> it shouldn't be a problem, just depends on what's in the cache
257 2020-02-26T20:28:45  <achow101> i'm trying to avoid storing a ton of pubkeys in the wallet file
258 2020-02-26T20:35:16  <luke-jr> never been a problem before..
259 2020-02-26T20:43:08  *** pinheadmz has quit IRC
260 2020-02-26T20:43:28  *** pinheadmz has joined #bitcoin-core-dev
261 2020-02-26T20:46:13  <instagibbs> achow101, remind me what things are currently being cached when
262 2020-02-26T20:46:19  <instagibbs> (in descriptor wallet PR)
263 2020-02-26T20:46:36  <achow101> instagibbs: all derived pubkeys are cached during TopUp
264 2020-02-26T20:46:44  <achow101> no intermediate xpubs yet, currently writing that
265 2020-02-26T20:46:56  *** promag has joined #bitcoin-core-dev
266 2020-02-26T20:47:12  *** promag has joined #bitcoin-core-dev
267 2020-02-26T20:47:51  <instagibbs> cached where? (I gotta seriously review the PR...)
268 2020-02-26T20:48:08  <achow101> in the wallet file
269 2020-02-26T20:48:10  <instagibbs> ah
270 2020-02-26T20:49:53  <instagibbs> It's two different things to test vs 1 if you make it different. Depends on relative complexity I guess
271 2020-02-26T20:52:51  *** francisco___ has quit IRC
272 2020-02-26T20:58:07  *** promag has quit IRC
273 2020-02-26T20:58:27  *** captjakk has quit IRC
274 2020-02-26T21:00:02  *** Mark_Cockrell has quit IRC
275 2020-02-26T21:00:07  *** bitcoin-git has joined #bitcoin-core-dev
276 2020-02-26T21:00:07  <bitcoin-git> [bitcoin] luke-jr closed pull request #10729: Wrap EvalScript in a ScriptExecution class (master...scriptex) https://github.com/bitcoin/bitcoin/pull/10729
277 2020-02-26T21:00:12  *** bitcoin-git has left #bitcoin-core-dev
278 2020-02-26T21:00:46  *** promag has joined #bitcoin-core-dev
279 2020-02-26T21:01:08  *** captjakk has joined #bitcoin-core-dev
280 2020-02-26T21:17:57  *** jMCg has joined #bitcoin-core-dev
281 2020-02-26T21:35:31  *** Emcy has quit IRC
282 2020-02-26T21:36:46  *** Guyver2__ has joined #bitcoin-core-dev
283 2020-02-26T21:39:44  *** Guyver2_ has quit IRC
284 2020-02-26T21:48:06  *** Emcy has joined #bitcoin-core-dev
285 2020-02-26T21:55:12  *** dviola has joined #bitcoin-core-dev
286 2020-02-26T21:58:10  *** filchef has quit IRC
287 2020-02-26T22:37:11  *** dviola has quit IRC
288 2020-02-26T22:41:05  *** belcher has joined #bitcoin-core-dev
289 2020-02-26T22:46:31  *** francisco____ has joined #bitcoin-core-dev
290 2020-02-26T22:49:27  *** manantial has quit IRC
291 2020-02-26T22:58:46  *** masterdonx2 has quit IRC
292 2020-02-26T23:01:51  *** MasterdonX has joined #bitcoin-core-dev
293 2020-02-26T23:03:36  *** Guyver2__ has quit IRC
294 2020-02-26T23:09:47  *** mol has joined #bitcoin-core-dev
295 2020-02-26T23:16:02  *** captjakk has quit IRC
296 2020-02-26T23:16:28  *** captjakk has joined #bitcoin-core-dev
297 2020-02-26T23:21:11  *** captjakk has quit IRC
298 2020-02-26T23:24:13  *** captjakk has joined #bitcoin-core-dev
299 2020-02-26T23:31:16  *** marcoagner has quit IRC
300 2020-02-26T23:46:45  *** mdunnio has quit IRC