1 2020-03-02T00:00:03 *** ferringb has quit IRC
2 2020-03-02T00:01:46 *** promag has joined #bitcoin-core-dev
3 2020-03-02T00:05:12 *** Zenton has quit IRC
4 2020-03-02T00:06:16 *** promag has quit IRC
5 2020-03-02T00:11:32 *** promag has joined #bitcoin-core-dev
6 2020-03-02T00:22:04 *** Azor has joined #bitcoin-core-dev
7 2020-03-02T00:36:06 *** Giderey36 has quit IRC
8 2020-03-02T00:59:49 *** captjakk has joined #bitcoin-core-dev
9 2020-03-02T01:01:15 *** captjakk has quit IRC
10 2020-03-02T01:06:51 *** AaronvanW has quit IRC
11 2020-03-02T01:06:59 *** captjakk has joined #bitcoin-core-dev
12 2020-03-02T01:08:47 *** captjakk has quit IRC
13 2020-03-02T01:09:21 *** captjakk has joined #bitcoin-core-dev
14 2020-03-02T01:10:47 *** promag has quit IRC
15 2020-03-02T01:13:26 *** captjakk has quit IRC
16 2020-03-02T01:13:35 *** promag has joined #bitcoin-core-dev
17 2020-03-02T01:16:41 *** captjakk has joined #bitcoin-core-dev
18 2020-03-02T01:18:42 *** captjakk has quit IRC
19 2020-03-02T01:20:42 *** promag_ has joined #bitcoin-core-dev
20 2020-03-02T01:23:20 *** promag has quit IRC
21 2020-03-02T01:24:34 *** captjakk has joined #bitcoin-core-dev
22 2020-03-02T01:29:23 *** DeanWeen has quit IRC
23 2020-03-02T01:41:55 *** belcher has quit IRC
24 2020-03-02T02:06:24 *** promag_ has quit IRC
25 2020-03-02T02:09:01 *** captjakk has quit IRC
26 2020-03-02T02:09:50 *** Highway61 has quit IRC
27 2020-03-02T02:11:35 *** felixfoertsch23 has quit IRC
28 2020-03-02T02:15:29 *** captjakk has joined #bitcoin-core-dev
29 2020-03-02T03:00:02 *** Azor has quit IRC
30 2020-03-02T03:02:00 *** felixfoertsch has joined #bitcoin-core-dev
31 2020-03-02T03:04:01 *** captjakk has quit IRC
32 2020-03-02T03:04:42 *** promag has joined #bitcoin-core-dev
33 2020-03-02T03:09:25 *** promag has quit IRC
34 2020-03-02T03:10:56 *** Highway61 has joined #bitcoin-core-dev
35 2020-03-02T03:11:44 *** Highway61 has quit IRC
36 2020-03-02T03:14:21 *** captjakk has joined #bitcoin-core-dev
37 2020-03-02T03:22:15 *** davidfg41 has joined #bitcoin-core-dev
38 2020-03-02T03:32:22 *** TheHoliestRoger has quit IRC
39 2020-03-02T03:33:09 *** TheHoliestRoger has joined #bitcoin-core-dev
40 2020-03-02T03:33:32 *** felixfoertsch23 has joined #bitcoin-core-dev
41 2020-03-02T03:35:56 *** felixfoertsch has quit IRC
42 2020-03-02T03:47:18 *** Klox has quit IRC
43 2020-03-02T03:59:54 *** captjakk has quit IRC
44 2020-03-02T04:04:31 *** Klox has joined #bitcoin-core-dev
45 2020-03-02T04:08:34 *** Klox has quit IRC
46 2020-03-02T04:14:26 *** Klox has joined #bitcoin-core-dev
47 2020-03-02T04:23:21 *** bitcoin-git has joined #bitcoin-core-dev
48 2020-03-02T04:23:21 <bitcoin-git> [bitcoin] zachwylde00 opened pull request #18237: Create circle.ci.yml (master...master) https://github.com/bitcoin/bitcoin/pull/18237
49 2020-03-02T04:23:22 *** bitcoin-git has left #bitcoin-core-dev
50 2020-03-02T04:24:06 *** bitcoin-git has joined #bitcoin-core-dev
51 2020-03-02T04:24:06 <bitcoin-git> [bitcoin] fanquake closed pull request #18237: Create circle.ci.yml (master...master) https://github.com/bitcoin/bitcoin/pull/18237
52 2020-03-02T04:24:07 *** bitcoin-git has left #bitcoin-core-dev
53 2020-03-02T04:37:14 *** DeanWeen has joined #bitcoin-core-dev
54 2020-03-02T04:57:00 *** Eagle[TM] has joined #bitcoin-core-dev
55 2020-03-02T04:58:19 *** EagleTM has quit IRC
56 2020-03-02T05:10:44 <kallewoof> So, bitcoin core right now seems to lean towards constant func/method parameters to pointers in the form "type* const" (55 instances of "CWallet* const pwallet") over "const type*" (15 instances of "const CWallet*"), but from what I understand, "type* const" means the pointer itself is const (i.e. "pwallet = blarf" is illegal) but the pointed to instance is not const (i.e. pwallet->MutableThing() is legal). I tested this
57 2020-03-02T05:10:45 <kallewoof> by adding a call to pwallet->handleNotifications(), a non-const marked function, and it compiles w/o issue.
58 2020-03-02T05:12:24 <kallewoof> Switching the parameter to "const CWallet* pwallet" and recompiling gave an error, so yeah, those type* const declarations are all pretty much pointless.
59 2020-03-02T05:12:28 <sipa> kallewoof: that's correct
60 2020-03-02T05:13:01 <sipa> i wouldn't say it's "leaning towards"... they're completely different things
61 2020-03-02T05:13:05 <sipa> with different meanings
62 2020-03-02T05:13:20 <sipa> if someone wrote on while meaning the other, that's a bug
63 2020-03-02T05:13:52 <sipa> you can also have "const Type* const varname" to make both the variable amd the pointed-to object const
64 2020-03-02T05:13:59 <kallewoof> I can't see why "retval method(CWallet* const pwallet, ...)" would ever mean "let's not change the pwallet pointer"
65 2020-03-02T05:14:26 <sipa> i don't understand; that is what it means
66 2020-03-02T05:14:44 <kallewoof> Yeah I mean, I can't see the reason why anyone would wanna do that
67 2020-03-02T05:15:09 <kallewoof> The thing expires on return anyway. If you really want to a CWallet pointer to something else, just make a new one. That's better practice anyway.
68 2020-03-02T05:15:20 <sipa> some people like making parameters const-valued if they know the function body won't change it
69 2020-03-02T05:15:24 <sipa> in general
70 2020-03-02T05:16:01 <sipa> i don't (i don't think it adds much), but it's not unreasonable to mark everything you know to be const as const
71 2020-03-02T05:16:34 <kallewoof> Yeah, that's a fair point. I do think this is easy to mis(s/understand). I did, until I looked it up again for the Nth time.
72 2020-03-02T05:17:13 <sipa> maybe it's worth trying to make the CWallet const as well in those 55 instances
73 2020-03-02T05:17:21 <sipa> and see if it still compiles in some of the.
74 2020-03-02T05:17:21 <kallewoof> I'd say that the majority of those 55 "CWallet* const" parameters were indeed meant to be "const CWallet*", but I could be mistaken.
75 2020-03-02T05:17:34 <kallewoof> Yeah, I'll give it a shot
76 2020-03-02T05:17:48 <sipa> if so, that would be strong indication that those const markers were added in error
77 2020-03-02T05:21:22 <luke-jr> kallewoof: the reason is so you don't accidentally change the param
78 2020-03-02T05:21:37 <luke-jr> I certainly mean *const when I put *const :p
79 2020-03-02T05:23:41 <fanquake> kallewoof looks like similar comments have been made before: https://github.com/bitcoin/bitcoin/pull/8775#discussion_r103283605
80 2020-03-02T05:26:18 <kallewoof> luke-jr: you mean, so you don't accidentally set e.g. pwallet to something else while inside the method? sounds like a rather obvious thing to spot, though, but safe > sorry. I think the drawback in this case is that people who add code will see a bunch of "CWallet* const" declarations and assume they mean "immutable CWallets" when they mean "immutable pointers to mutable CWallets".
81 2020-03-02T05:28:02 <aj> better to use "Foo&" than "Foo* const" for a class member, isn't it?
82 2020-03-02T05:37:11 <sipa> aj: ifyou k
83 2020-03-02T05:37:20 <sipa> if you know it can't be nullptr
84 2020-03-02T05:37:50 <aj> fair point
85 2020-03-02T05:50:54 <sipa> also if you store references in a class and also accept a reference type in the constructor to build it with, it may not be clear to callers that the new object's lifetime is limited to that of the argument
86 2020-03-02T05:51:16 <sipa> if you pass a pointer, it's generally more obvious (to me, at least) that you need to be careful
87 2020-03-02T06:00:02 *** davidfg41 has quit IRC
88 2020-03-02T06:21:07 *** ddustin has quit IRC
89 2020-03-02T06:21:45 *** ddustin has joined #bitcoin-core-dev
90 2020-03-02T06:28:03 *** ddustin has quit IRC
91 2020-03-02T06:55:24 *** Guest47070 has joined #bitcoin-core-dev
92 2020-03-02T06:58:07 *** sdddddd has quit IRC
93 2020-03-02T07:05:06 *** bitcoin-git has joined #bitcoin-core-dev
94 2020-03-02T07:05:06 <bitcoin-git> [bitcoin] ajtowns opened pull request #18238: net_processing: Retry notfounds with more urgency (master...202002-bump-notfound) https://github.com/bitcoin/bitcoin/pull/18238
95 2020-03-02T07:05:08 *** bitcoin-git has left #bitcoin-core-dev
96 2020-03-02T07:15:32 *** manantial has joined #bitcoin-core-dev
97 2020-03-02T07:16:06 *** manantial has joined #bitcoin-core-dev
98 2020-03-02T07:19:36 *** sdddddd has joined #bitcoin-core-dev
99 2020-03-02T07:24:43 *** Eagle[TM] has quit IRC
100 2020-03-02T07:26:34 *** Kiminuo has quit IRC
101 2020-03-02T07:35:02 *** SiAnDoG_ has quit IRC
102 2020-03-02T07:35:42 *** Kiminuo has joined #bitcoin-core-dev
103 2020-03-02T07:43:43 *** vasild has quit IRC
104 2020-03-02T07:45:30 *** vasild has joined #bitcoin-core-dev
105 2020-03-02T07:51:12 *** promag has joined #bitcoin-core-dev
106 2020-03-02T07:57:02 *** bitcoin-git has joined #bitcoin-core-dev
107 2020-03-02T07:57:02 <bitcoin-git> [bitcoin] promag opened pull request #18239: gui: Refactor to drop client and wallet models setters (master...2020-03-drop-setmodel) https://github.com/bitcoin/bitcoin/pull/18239
108 2020-03-02T07:57:03 *** bitcoin-git has left #bitcoin-core-dev
109 2020-03-02T08:02:49 <promag> wumpus: pushed #18239 to address your comment in #18064 - if you agree with the concept then #18064 can already be merged given the existing acks
110 2020-03-02T08:02:50 <gribble> https://github.com/bitcoin/bitcoin/issues/18239 | wip: gui: Refactor to drop client and wallet models setters by promag · Pull Request #18239 · bitcoin/bitcoin · GitHub
111 2020-03-02T08:02:53 <gribble> https://github.com/bitcoin/bitcoin/issues/18064 | gui: Drop WalletModel dependency to RecentRequestsTableModel by promag · Pull Request #18064 · bitcoin/bitcoin · GitHub
112 2020-03-02T08:02:54 <gribble> https://github.com/bitcoin/bitcoin/issues/18064 | gui: Drop WalletModel dependency to RecentRequestsTableModel by promag · Pull Request #18064 · bitcoin/bitcoin · GitHub
113 2020-03-02T08:07:22 *** sdddddd has quit IRC
114 2020-03-02T08:08:54 *** marcoagner has joined #bitcoin-core-dev
115 2020-03-02T08:18:58 *** Guyver2 has joined #bitcoin-core-dev
116 2020-03-02T08:20:21 <jonasschnelli> how do I get the fuzzer to compile on macOS?
117 2020-03-02T08:20:54 <jonasschnelli> just dropping a --enable-fuzz leads to linker errors on my end
118 2020-03-02T08:22:32 *** rex4539 has joined #bitcoin-core-dev
119 2020-03-02T08:22:47 <fanquake> jonasschnelli I'd suggest using a brew installed llvm/clang 9 if you aren't already, rather than Apple Clang.
120 2020-03-02T08:22:53 <fanquake> What errors are you seeing?
121 2020-03-02T08:24:09 *** rex4539 has quit IRC
122 2020-03-02T08:24:19 *** promag has quit IRC
123 2020-03-02T08:24:55 *** jonatack has joined #bitcoin-core-dev
124 2020-03-02T08:28:34 *** sdddddd has joined #bitcoin-core-dev
125 2020-03-02T08:30:35 <jonasschnelli> fanquake: ld: entry point (_main) undefined. for architecture x86_64
126 2020-03-02T08:30:53 *** promag has joined #bitcoin-core-dev
127 2020-03-02T08:31:58 <fanquake> jonasschnelli is this on latest master? I fixed some fuzzing issues related to main() and libfuzzer in #18008.
128 2020-03-02T08:32:00 <gribble> https://github.com/bitcoin/bitcoin/issues/18008 | test: only declare a main() when fuzzing with AFL by fanquake · Pull Request #18008 · bitcoin/bitcoin · GitHub
129 2020-03-02T08:33:10 <jonasschnelli> fanquake: Yes. Master. I never used the fuzzers... so could be dumb me
130 2020-03-02T08:34:32 <jonasschnelli> I'll try now with brews clang
131 2020-03-02T08:35:07 *** promag has quit IRC
132 2020-03-02T08:35:47 <fanquake> Ok. That should work well. Using a ./configure like
133 2020-03-02T08:35:55 <fanquake> ./configure --enable-fuzz --with-sanitizers=fuzzer,address,undefined CC=/usr/local/opt/llvm/bin/clang CXX=/usr/local/opt/llvm/bin/clang++
134 2020-03-02T08:35:59 *** promag has joined #bitcoin-core-dev
135 2020-03-02T08:37:10 *** promag has quit IRC
136 2020-03-02T08:40:45 *** _tnull has joined #bitcoin-core-dev
137 2020-03-02T08:50:57 *** kljasdfvv has joined #bitcoin-core-dev
138 2020-03-02T08:57:39 <jonasschnelli> fanquake: with brews llvm packaged it worked. Thanks.
139 2020-03-02T08:57:53 <fanquake> jonasschnelli: np
140 2020-03-02T08:58:29 *** timothy has joined #bitcoin-core-dev
141 2020-03-02T09:00:02 *** Guest47070 has quit IRC
142 2020-03-02T09:14:03 *** sipsorcery has joined #bitcoin-core-dev
143 2020-03-02T09:17:36 *** peutetre has joined #bitcoin-core-dev
144 2020-03-02T09:33:34 *** _tnull has quit IRC
145 2020-03-02T09:33:54 *** _tnull has joined #bitcoin-core-dev
146 2020-03-02T09:35:32 *** Zenton has joined #bitcoin-core-dev
147 2020-03-02T09:37:26 *** Guyver2_ has joined #bitcoin-core-dev
148 2020-03-02T09:39:35 *** promag has joined #bitcoin-core-dev
149 2020-03-02T09:40:05 *** Guyver2 has quit IRC
150 2020-03-02T09:41:15 *** promag_ has joined #bitcoin-core-dev
151 2020-03-02T09:44:04 *** promag has quit IRC
152 2020-03-02T09:45:04 *** Guyver2_ has quit IRC
153 2020-03-02T09:47:07 *** filchef has joined #bitcoin-core-dev
154 2020-03-02T09:48:32 *** bitcoin-git has joined #bitcoin-core-dev
155 2020-03-02T09:48:32 <bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/54a7ef612a3b...1f886243e464
156 2020-03-02T09:48:33 <bitcoin-git> bitcoin/master 1ef28b4 Gregory Sanders: Make AnalyzePSBT next role calculation simple, correct
157 2020-03-02T09:48:33 <bitcoin-git> bitcoin/master 1f88624 Samuel Dobson: Merge #18224: Make AnalyzePSBT next role calculation simple, correct
158 2020-03-02T09:48:35 *** bitcoin-git has left #bitcoin-core-dev
159 2020-03-02T09:48:51 *** bitcoin-git has joined #bitcoin-core-dev
160 2020-03-02T09:48:51 <bitcoin-git> [bitcoin] meshcollider merged pull request #18224: Make AnalyzePSBT next role calculation simple, correct (master...analyze_psbt_role_simple) https://github.com/bitcoin/bitcoin/pull/18224
161 2020-03-02T09:48:53 *** bitcoin-git has left #bitcoin-core-dev
162 2020-03-02T09:51:43 *** promag_ has quit IRC
163 2020-03-02T09:51:46 *** promag has joined #bitcoin-core-dev
164 2020-03-02T09:53:37 *** promag_ has joined #bitcoin-core-dev
165 2020-03-02T09:57:42 *** _tnull has quit IRC
166 2020-03-02T09:58:15 *** promag_ has quit IRC
167 2020-03-02T10:00:09 *** _tnull has joined #bitcoin-core-dev
168 2020-03-02T10:04:19 *** kexkey has quit IRC
169 2020-03-02T10:05:27 *** _tnull has quit IRC
170 2020-03-02T10:14:25 *** promag has quit IRC
171 2020-03-02T10:18:06 <kallewoof> sipa, aj, luke-jr: for the record, changing to immutable-CWallet-pointers in places where it made sense (many places did non-const stuff) resulted in 68 changes; see https://github.com/bitcoin/bitcoin/compare/master...kallewoof:2002-const-fixes ... is this something people would concept ack on a PR?
172 2020-03-02T10:27:29 *** promag has joined #bitcoin-core-dev
173 2020-03-02T10:29:00 <sipa> sounds good to me; this is the sort of change that as long as it compiles, the behavior shouldn't change
174 2020-03-02T10:29:49 <sipa> though in general it may lead to introducing automatic copying of objects sometimes (e.g. trying to std::move a const object will work, but generally result in a copy rather than an efficient move)
175 2020-03-02T10:29:59 <sipa> CWallet objects aren't copied or moved though
176 2020-03-02T10:36:03 *** justanotheruser has quit IRC
177 2020-03-02T10:36:11 <kallewoof> sipa: ohh, good point.
178 2020-03-02T10:40:30 *** filchef has quit IRC
179 2020-03-02T10:44:06 *** bitcoin-git has joined #bitcoin-core-dev
180 2020-03-02T10:44:06 <bitcoin-git> [bitcoin] kallewoof opened pull request #18241: wallet/refactor: refer to CWallet immutably when possible (master...2002-const-fixes) https://github.com/bitcoin/bitcoin/pull/18241
181 2020-03-02T10:44:07 *** bitcoin-git has left #bitcoin-core-dev
182 2020-03-02T10:57:42 *** sdddddd has quit IRC
183 2020-03-02T10:58:41 *** _tnull has joined #bitcoin-core-dev
184 2020-03-02T11:00:39 <jonasschnelli> why do I get a asan heap buffer overflow detection in ParseHex (vch.push_back(n);)?
185 2020-03-02T11:03:57 *** Gilberto17Harber has joined #bitcoin-core-dev
186 2020-03-02T11:08:28 *** DougieBot5000_ has joined #bitcoin-core-dev
187 2020-03-02T11:11:07 *** EagleTM has joined #bitcoin-core-dev
188 2020-03-02T11:11:49 *** DougieBot5000 has quit IRC
189 2020-03-02T11:20:07 <promag> jonasschnelli: not sure, proly due to `while (true)`?
190 2020-03-02T11:20:55 <jonasschnelli> promag: I don't know. I though we use the same env (clang/asan) on travis
191 2020-03-02T11:20:59 <jonasschnelli> *thought
192 2020-03-02T11:21:11 <promag> but you get am error or warning?
193 2020-03-02T11:25:03 *** dviola has joined #bitcoin-core-dev
194 2020-03-02T11:25:06 *** DougieBot5000_ has quit IRC
195 2020-03-02T11:33:09 *** DougieBot5000_ has joined #bitcoin-core-dev
196 2020-03-02T11:33:24 *** DougieBot5000_ is now known as DougieBot5000
197 2020-03-02T11:35:28 *** promag has quit IRC
198 2020-03-02T11:35:35 <kallewoof> Tried -fsanitize=address but compiler errors on crypto/sha256_sse4.cpp:44, saying "expected relocatable expression". Should probably read up on how it works somewhere.
199 2020-03-02T11:36:14 *** promag has joined #bitcoin-core-dev
200 2020-03-02T11:37:48 *** AaronvanW has joined #bitcoin-core-dev
201 2020-03-02T11:39:03 *** Gilberto17Harber has quit IRC
202 2020-03-02T11:41:56 *** promag has quit IRC
203 2020-03-02T11:42:09 *** promag has joined #bitcoin-core-dev
204 2020-03-02T11:50:52 *** ddustin has joined #bitcoin-core-dev
205 2020-03-02T11:55:51 *** Chris_Stewart_5 has quit IRC
206 2020-03-02T12:00:01 *** peutetre has quit IRC
207 2020-03-02T12:00:11 *** Chris_Stewart_5 has joined #bitcoin-core-dev
208 2020-03-02T12:04:46 *** _tnull has quit IRC
209 2020-03-02T12:11:25 *** _tnull has joined #bitcoin-core-dev
210 2020-03-02T12:19:26 *** Chris_Stewart_5 has quit IRC
211 2020-03-02T12:21:49 *** Chris_Stewart_5 has joined #bitcoin-core-dev
212 2020-03-02T12:21:55 *** Perlboy has joined #bitcoin-core-dev
213 2020-03-02T12:56:38 *** rafalcpp has joined #bitcoin-core-dev
214 2020-03-02T13:00:10 <fanquake> kallewoof: you might have to pass --disable-asm to configure
215 2020-03-02T13:00:36 <fanquake> iirc there's a note about a similar issue in our docs
216 2020-03-02T13:01:52 *** _tnull has quit IRC
217 2020-03-02T13:08:03 *** bitcoin-git has joined #bitcoin-core-dev
218 2020-03-02T13:08:03 <bitcoin-git> [bitcoin] jonasschnelli opened pull request #18242: Add BIP324 encrypted p2p transport de-/serializer (only used in tests) (master...2020/03/net_v2) https://github.com/bitcoin/bitcoin/pull/18242
219 2020-03-02T13:08:04 *** bitcoin-git has left #bitcoin-core-dev
220 2020-03-02T13:12:07 *** Highway61 has joined #bitcoin-core-dev
221 2020-03-02T13:16:48 <kallewoof> fanquake: aha! thanks
222 2020-03-02T13:28:06 *** ddustin has quit IRC
223 2020-03-02T13:28:23 *** ddustin has joined #bitcoin-core-dev
224 2020-03-02T13:36:27 *** jonatack has quit IRC
225 2020-03-02T13:36:57 *** _tnull has joined #bitcoin-core-dev
226 2020-03-02T13:41:17 *** Highway61 has quit IRC
227 2020-03-02T13:49:19 *** Highway61 has joined #bitcoin-core-dev
228 2020-03-02T13:52:34 *** jonatack has joined #bitcoin-core-dev
229 2020-03-02T14:07:57 <instagibbs> would people accept a "mockfeeestimation" RPC that would let the test-writer hardcode the rates? Looking at a reported issue and without this or something like it it makes writing tests difficult
230 2020-03-02T14:08:16 <instagibbs> obviously only active on test-related networks, hidden blah blah
231 2020-03-02T14:08:42 <instagibbs> issue is with respect to bumpfee*
232 2020-03-02T14:13:26 *** luke-jr has quit IRC
233 2020-03-02T14:34:13 <provoostenator> instagibbs: sounds good to me
234 2020-03-02T14:34:42 <provoostenator> Makes sense for Signet too
235 2020-03-02T14:40:12 *** luke-jr has joined #bitcoin-core-dev
236 2020-03-02T14:41:37 *** _tnull has quit IRC
237 2020-03-02T14:48:29 *** _tnull has joined #bitcoin-core-dev
238 2020-03-02T14:57:40 *** justanotheruser has joined #bitcoin-core-dev
239 2020-03-02T15:00:02 *** Perlboy has quit IRC
240 2020-03-02T15:00:46 *** luke-jr has quit IRC
241 2020-03-02T15:03:36 <instagibbs> for now I hijacked feature_estimate_fee.py to write additional test cases :P
242 2020-03-02T15:05:36 <instagibbs> opened an issue
243 2020-03-02T15:22:27 *** tomkap1 has joined #bitcoin-core-dev
244 2020-03-02T15:32:23 *** EagleTM has quit IRC
245 2020-03-02T15:39:39 *** Kiminuo has quit IRC
246 2020-03-02T15:44:22 *** Chris_Stewart_5 has quit IRC
247 2020-03-02T15:44:22 *** Highway61 has quit IRC
248 2020-03-02T15:47:57 *** mdunnio has joined #bitcoin-core-dev
249 2020-03-02T15:48:08 *** Chris_Stewart_5 has joined #bitcoin-core-dev
250 2020-03-02T15:52:43 *** Henry151_ has joined #bitcoin-core-dev
251 2020-03-02T15:54:11 *** Henry151_ is now known as Henry151
252 2020-03-02T15:55:21 *** promag_ has joined #bitcoin-core-dev
253 2020-03-02T15:56:12 *** _tnull has quit IRC
254 2020-03-02T15:58:13 *** luke-jr has joined #bitcoin-core-dev
255 2020-03-02T15:58:54 *** promag_ has quit IRC
256 2020-03-02T16:00:12 *** ddustin has quit IRC
257 2020-03-02T16:00:40 *** jarthur has joined #bitcoin-core-dev
258 2020-03-02T16:01:02 *** ddustin has joined #bitcoin-core-dev
259 2020-03-02T16:05:27 *** ddustin has quit IRC
260 2020-03-02T16:06:41 *** _tnull has joined #bitcoin-core-dev
261 2020-03-02T16:11:55 *** bitcoin-git has joined #bitcoin-core-dev
262 2020-03-02T16:11:56 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1f886243e464...ac5c5d0162a9
263 2020-03-02T16:11:56 <bitcoin-git> bitcoin/master aff2748 Filip Gospodinov: httpserver: use own HTTP status codes
264 2020-03-02T16:11:57 <bitcoin-git> bitcoin/master ac5c5d0 Wladimir J. van der Laan: Merge #18168: httpserver: use own HTTP status codes
265 2020-03-02T16:11:59 *** bitcoin-git has left #bitcoin-core-dev
266 2020-03-02T16:12:15 *** bitcoin-git has joined #bitcoin-core-dev
267 2020-03-02T16:12:15 <bitcoin-git> [bitcoin] laanwj merged pull request #18168: httpserver: use own HTTP status codes (master...500) https://github.com/bitcoin/bitcoin/pull/18168
268 2020-03-02T16:12:16 *** bitcoin-git has left #bitcoin-core-dev
269 2020-03-02T16:20:01 <wumpus> instagibbs: if it helps increasing test coverage and it doesn't complicate the non-test code paths too much it sounds like a good idea
270 2020-03-02T16:22:57 *** Talkless has joined #bitcoin-core-dev
271 2020-03-02T16:30:08 *** francisco_____ has joined #bitcoin-core-dev
272 2020-03-02T16:33:17 *** _tnull has quit IRC
273 2020-03-02T16:33:53 *** jarthur has quit IRC
274 2020-03-02T16:34:19 *** jarthur has joined #bitcoin-core-dev
275 2020-03-02T16:34:32 *** luke-jr has quit IRC
276 2020-03-02T16:38:06 *** justanotheruser has quit IRC
277 2020-03-02T16:42:39 *** jonatack has quit IRC
278 2020-03-02T16:43:01 *** jarthur has quit IRC
279 2020-03-02T16:43:24 *** Chris_Stewart_5 has quit IRC
280 2020-03-02T16:44:13 *** kexkey has joined #bitcoin-core-dev
281 2020-03-02T16:44:57 *** jonatack has joined #bitcoin-core-dev
282 2020-03-02T16:46:15 *** promag_ has joined #bitcoin-core-dev
283 2020-03-02T16:49:47 *** Chris_Stewart_5 has joined #bitcoin-core-dev
284 2020-03-02T16:50:07 *** luke-jr has joined #bitcoin-core-dev
285 2020-03-02T16:54:24 *** jarthur has joined #bitcoin-core-dev
286 2020-03-02T16:54:50 *** justanotheruser has joined #bitcoin-core-dev
287 2020-03-02T16:55:33 *** promag_ has quit IRC
288 2020-03-02T17:01:01 *** promag_ has joined #bitcoin-core-dev
289 2020-03-02T17:05:42 *** justanotheruser has quit IRC
290 2020-03-02T17:19:32 *** luke-jr has quit IRC
291 2020-03-02T17:23:51 *** justanotheruser has joined #bitcoin-core-dev
292 2020-03-02T17:31:15 *** bitcoin-git has joined #bitcoin-core-dev
293 2020-03-02T17:31:15 <bitcoin-git> [bitcoin] Sjors opened pull request #18244: rpc: have lockUnspents also lock manually selected coins (master...2020/03/rpc_coin_locks) https://github.com/bitcoin/bitcoin/pull/18244
294 2020-03-02T17:31:16 *** bitcoin-git has left #bitcoin-core-dev
295 2020-03-02T17:34:22 *** promag_ has quit IRC
296 2020-03-02T17:34:35 *** andrewtoth_ has joined #bitcoin-core-dev
297 2020-03-02T17:43:40 *** fox2p has quit IRC
298 2020-03-02T17:44:01 *** Kiminuo has joined #bitcoin-core-dev
299 2020-03-02T17:45:05 *** fox2p has joined #bitcoin-core-dev
300 2020-03-02T17:56:26 *** justanotheruser has quit IRC
301 2020-03-02T17:58:21 *** pinheadmz has joined #bitcoin-core-dev
302 2020-03-02T17:58:22 *** ddustin has joined #bitcoin-core-dev
303 2020-03-02T17:59:55 *** MrPaz has joined #bitcoin-core-dev
304 2020-03-02T18:00:01 *** tomkap1 has quit IRC
305 2020-03-02T18:11:59 *** captjakk has joined #bitcoin-core-dev
306 2020-03-02T18:16:12 *** bitcoin-git has joined #bitcoin-core-dev
307 2020-03-02T18:16:12 <bitcoin-git> [bitcoin] instagibbs opened pull request #18245: Test some transaction creation with non-empty fee estimator (master...test_est_txn) https://github.com/bitcoin/bitcoin/pull/18245
308 2020-03-02T18:16:14 *** bitcoin-git has left #bitcoin-core-dev
309 2020-03-02T18:21:00 *** johanna1 has joined #bitcoin-core-dev
310 2020-03-02T18:25:37 *** justanotheruser has joined #bitcoin-core-dev
311 2020-03-02T18:35:14 *** dviola has quit IRC
312 2020-03-02T18:47:55 *** Zenton has quit IRC
313 2020-03-02T18:48:22 *** mdunnio has quit IRC
314 2020-03-02T19:00:45 *** jarthur_ has joined #bitcoin-core-dev
315 2020-03-02T19:01:02 *** bitcoin-git has joined #bitcoin-core-dev
316 2020-03-02T19:01:02 <bitcoin-git> [bitcoin] promag opened pull request #18246: gui: Drop connectSlotsByName usage (master...2020-03-drop-connectslotsbyName) https://github.com/bitcoin/bitcoin/pull/18246
317 2020-03-02T19:01:03 *** bitcoin-git has left #bitcoin-core-dev
318 2020-03-02T19:03:26 *** jarthur has quit IRC
319 2020-03-02T19:04:17 *** mdunnio has joined #bitcoin-core-dev
320 2020-03-02T19:08:49 *** mdunnio has quit IRC
321 2020-03-02T19:13:26 *** mdunnio has joined #bitcoin-core-dev
322 2020-03-02T19:14:36 *** bitcoin-git has joined #bitcoin-core-dev
323 2020-03-02T19:14:36 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18247: test: Wait for both veracks in add_p2p_connection (master...2003-qaMininodeVerackRace) https://github.com/bitcoin/bitcoin/pull/18247
324 2020-03-02T19:14:37 *** bitcoin-git has left #bitcoin-core-dev
325 2020-03-02T19:16:05 *** captjakk has quit IRC
326 2020-03-02T19:16:36 *** jarthur_ has quit IRC
327 2020-03-02T19:17:54 *** jarthur has joined #bitcoin-core-dev
328 2020-03-02T19:19:09 *** justanotheruser has quit IRC
329 2020-03-02T19:29:19 *** jarthur_ has joined #bitcoin-core-dev
330 2020-03-02T19:30:42 *** csgreenawalt has joined #bitcoin-core-dev
331 2020-03-02T19:31:28 *** Highway61 has joined #bitcoin-core-dev
332 2020-03-02T19:32:13 *** jarthur has quit IRC
333 2020-03-02T19:34:46 *** captjakk has joined #bitcoin-core-dev
334 2020-03-02T19:38:38 *** csgreenawalt has left #bitcoin-core-dev
335 2020-03-02T19:40:38 *** vasild_ has joined #bitcoin-core-dev
336 2020-03-02T19:43:23 *** vasild has quit IRC
337 2020-03-02T19:48:10 *** Highway62 has joined #bitcoin-core-dev
338 2020-03-02T19:50:05 *** Highway61 has quit IRC
339 2020-03-02T19:50:05 *** Highway62 is now known as Highway61
340 2020-03-02T20:02:00 *** Rhiannon16Klocko has joined #bitcoin-core-dev
341 2020-03-02T20:03:03 *** owowo has quit IRC
342 2020-03-02T20:04:59 *** Guyver2 has joined #bitcoin-core-dev
343 2020-03-02T20:07:32 *** owowo has joined #bitcoin-core-dev
344 2020-03-02T20:07:33 *** owowo has quit IRC
345 2020-03-02T20:07:33 *** owowo has joined #bitcoin-core-dev
346 2020-03-02T20:07:48 *** sdaftuar has quit IRC
347 2020-03-02T20:08:13 *** sdaftuar has joined #bitcoin-core-dev
348 2020-03-02T20:08:39 *** Talkless has quit IRC
349 2020-03-02T20:14:53 *** paracyst has quit IRC
350 2020-03-02T20:15:16 *** rjected has joined #bitcoin-core-dev
351 2020-03-02T20:16:12 *** paracyst has joined #bitcoin-core-dev
352 2020-03-02T20:16:46 *** Highway61 has quit IRC
353 2020-03-02T20:17:02 *** mdunnio has quit IRC
354 2020-03-02T20:26:03 *** sipa has quit IRC
355 2020-03-02T20:27:06 *** sipa has joined #bitcoin-core-dev
356 2020-03-02T20:29:57 *** captjakk has quit IRC
357 2020-03-02T20:30:50 *** rjected has quit IRC
358 2020-03-02T20:33:00 *** mdunnio has joined #bitcoin-core-dev
359 2020-03-02T20:37:35 *** mdunnio has quit IRC
360 2020-03-02T20:37:50 *** rjected has joined #bitcoin-core-dev
361 2020-03-02T20:38:31 *** roconnor has quit IRC
362 2020-03-02T20:41:37 *** justanotheruser has joined #bitcoin-core-dev
363 2020-03-02T20:42:02 *** jarthur has joined #bitcoin-core-dev
364 2020-03-02T20:48:46 *** mdunnio has joined #bitcoin-core-dev
365 2020-03-02T20:53:30 *** mdunnio has quit IRC
366 2020-03-02T20:53:46 *** rjected has quit IRC
367 2020-03-02T20:54:29 *** ddustin has quit IRC
368 2020-03-02T20:54:36 *** Zenton has joined #bitcoin-core-dev
369 2020-03-02T20:55:09 *** ddustin has joined #bitcoin-core-dev
370 2020-03-02T20:57:03 *** DeanWeen has quit IRC
371 2020-03-02T20:59:15 *** Rhiannon16Klocko has quit IRC
372 2020-03-02T21:00:01 *** johanna1 has quit IRC
373 2020-03-02T21:03:42 *** mdunnio has joined #bitcoin-core-dev
374 2020-03-02T21:06:04 *** rjected has joined #bitcoin-core-dev
375 2020-03-02T21:21:16 *** ski1 has joined #bitcoin-core-dev
376 2020-03-02T21:21:53 *** jarthur has quit IRC
377 2020-03-02T21:26:20 *** bitcoin-git has joined #bitcoin-core-dev
378 2020-03-02T21:26:20 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18249: test: Bump timeouts to accomodate really slow disks (master...2003-testTimeout) https://github.com/bitcoin/bitcoin/pull/18249
379 2020-03-02T21:26:21 *** bitcoin-git has left #bitcoin-core-dev
380 2020-03-02T21:37:26 *** promag_ has joined #bitcoin-core-dev
381 2020-03-02T21:39:56 *** filchef has joined #bitcoin-core-dev
382 2020-03-02T21:54:37 *** promag_ has quit IRC
383 2020-03-02T21:55:54 *** promag_ has joined #bitcoin-core-dev
384 2020-03-02T22:00:03 *** Chris_Stewart_5 has quit IRC
385 2020-03-02T22:11:06 *** ddustin has quit IRC
386 2020-03-02T22:11:19 *** ddustin has joined #bitcoin-core-dev
387 2020-03-02T22:16:11 *** _andrewtoth_ has joined #bitcoin-core-dev
388 2020-03-02T22:16:56 *** willcl_ark has quit IRC
389 2020-03-02T22:17:21 *** rjected has quit IRC
390 2020-03-02T22:17:43 *** andrewtoth_ has quit IRC
391 2020-03-02T22:17:56 *** rjected has joined #bitcoin-core-dev
392 2020-03-02T22:19:22 *** willcl_ark has joined #bitcoin-core-dev
393 2020-03-02T22:20:52 *** luke-jr has joined #bitcoin-core-dev
394 2020-03-02T22:25:25 *** promag_ has quit IRC
395 2020-03-02T22:26:43 *** _andrewtoth_ has quit IRC
396 2020-03-02T22:29:32 *** promag_ has joined #bitcoin-core-dev
397 2020-03-02T22:33:34 *** manantial has quit IRC
398 2020-03-02T22:43:26 *** rjected has quit IRC
399 2020-03-02T22:44:34 *** justanotheruser has quit IRC
400 2020-03-02T22:47:04 *** luke-jr has quit IRC
401 2020-03-02T22:47:38 *** luke-jr has joined #bitcoin-core-dev
402 2020-03-02T22:51:05 *** lukedashjr has joined #bitcoin-core-dev
403 2020-03-02T22:52:30 *** luke-jr has quit IRC
404 2020-03-02T22:56:04 *** lukedashjr has quit IRC
405 2020-03-02T23:05:20 *** luke-jr has joined #bitcoin-core-dev
406 2020-03-02T23:07:49 *** rjected has joined #bitcoin-core-dev
407 2020-03-02T23:08:46 *** promag_ has quit IRC
408 2020-03-02T23:09:00 *** promag_ has joined #bitcoin-core-dev
409 2020-03-02T23:20:50 *** promag_ has quit IRC
410 2020-03-02T23:24:33 *** promag_ has joined #bitcoin-core-dev
411 2020-03-02T23:27:23 *** mdunnio has quit IRC
412 2020-03-02T23:30:51 *** josh has joined #bitcoin-core-dev
413 2020-03-02T23:31:23 *** josh is now known as Guest17323
414 2020-03-02T23:32:33 *** Guest17323 has quit IRC
415 2020-03-02T23:37:47 *** Zenton has quit IRC
416 2020-03-02T23:38:27 *** filchef has quit IRC
417 2020-03-02T23:38:49 *** promag_ has quit IRC
418 2020-03-02T23:40:16 *** promag_ has joined #bitcoin-core-dev
419 2020-03-02T23:40:25 *** timothy has quit IRC
420 2020-03-02T23:43:47 *** gleb has quit IRC
421 2020-03-02T23:44:43 *** captjakk has joined #bitcoin-core-dev
422 2020-03-02T23:45:11 *** kexkey has quit IRC
423 2020-03-02T23:45:15 *** gleb has joined #bitcoin-core-dev
424 2020-03-02T23:46:29 *** gleb has quit IRC
425 2020-03-02T23:46:29 *** kexkey has joined #bitcoin-core-dev
426 2020-03-02T23:52:18 *** Guyver2 has quit IRC
427 2020-03-02T23:58:26 *** felixfoertsch23 has quit IRC