12020-03-04T00:00:04 *** Dragavnir has quit IRC
22020-03-04T00:05:23 *** promag has quit IRC
32020-03-04T00:08:20 *** Victorsueca has joined #bitcoin-core-dev
42020-03-04T00:11:43 *** vasild_ has quit IRC
52020-03-04T00:21:09 *** captjakk has quit IRC
62020-03-04T00:21:14 *** AmberJ_ has joined #bitcoin-core-dev
72020-03-04T00:21:36 *** captjakk has joined #bitcoin-core-dev
82020-03-04T00:21:56 *** marcoagner has quit IRC
92020-03-04T00:23:05 *** turbo_choo has quit IRC
102020-03-04T00:24:47 *** turbo_choo has joined #bitcoin-core-dev
112020-03-04T00:25:53 *** captjakk has quit IRC
122020-03-04T00:37:24 *** promag has joined #bitcoin-core-dev
132020-03-04T00:41:49 *** promag has quit IRC
142020-03-04T01:01:50 *** turbo_choo has quit IRC
152020-03-04T01:03:06 *** turbo_choo has joined #bitcoin-core-dev
162020-03-04T01:08:22 *** TheRec has quit IRC
172020-03-04T01:10:48 *** TheRec has joined #bitcoin-core-dev
182020-03-04T01:10:48 *** TheRec has joined #bitcoin-core-dev
192020-03-04T01:16:55 *** vasild has joined #bitcoin-core-dev
202020-03-04T01:17:56 *** captjakk has joined #bitcoin-core-dev
212020-03-04T01:27:27 *** justanotheruser has joined #bitcoin-core-dev
222020-03-04T01:35:35 *** jarthur has joined #bitcoin-core-dev
232020-03-04T01:44:22 *** turbo_choo has quit IRC
242020-03-04T01:49:17 *** turbo_choo has joined #bitcoin-core-dev
252020-03-04T01:51:34 *** EagleTM has quit IRC
262020-03-04T02:00:53 *** turbo_choo has quit IRC
272020-03-04T02:06:46 *** felixfoertsch has quit IRC
282020-03-04T02:08:40 *** Emcy has quit IRC
292020-03-04T02:13:30 *** Emcy has joined #bitcoin-core-dev
302020-03-04T02:39:44 *** turbo_choo has joined #bitcoin-core-dev
312020-03-04T02:46:43 *** DougieBot5000 has quit IRC
322020-03-04T02:48:06 *** Emcy has quit IRC
332020-03-04T02:49:54 *** Emcy has joined #bitcoin-core-dev
342020-03-04T02:56:39 *** promag has joined #bitcoin-core-dev
352020-03-04T03:00:01 *** AmberJ_ has quit IRC
362020-03-04T03:01:19 *** promag has quit IRC
372020-03-04T03:03:07 *** DougieBot5000 has joined #bitcoin-core-dev
382020-03-04T03:21:43 *** Pysis|work has joined #bitcoin-core-dev
392020-03-04T03:37:07 *** Dean_Guss has joined #bitcoin-core-dev
402020-03-04T03:38:00 *** andrewtoth_ has quit IRC
412020-03-04T03:38:39 *** DeanGuss has quit IRC
422020-03-04T03:39:43 *** jb55 has quit IRC
432020-03-04T03:42:31 *** jb55 has joined #bitcoin-core-dev
442020-03-04T03:44:15 *** Emcy has quit IRC
452020-03-04T03:59:56 *** felixfoertsch has joined #bitcoin-core-dev
462020-03-04T04:03:11 *** captjakk_ has joined #bitcoin-core-dev
472020-03-04T04:05:26 *** captjakk has quit IRC
482020-03-04T04:05:27 *** ppisati has quit IRC
492020-03-04T04:05:27 *** Zenton has quit IRC
502020-03-04T04:06:07 *** kakobrekla has quit IRC
512020-03-04T04:06:15 *** ppisati has joined #bitcoin-core-dev
522020-03-04T04:08:45 *** jonatack has quit IRC
532020-03-04T04:12:17 *** kakobrekla has joined #bitcoin-core-dev
542020-03-04T04:22:51 *** bitcoin-git has joined #bitcoin-core-dev
552020-03-04T04:22:52 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ac5c5d0162a9...088604221b4a
562020-03-04T04:22:53 <bitcoin-git> bitcoin/master 9b0e162 Ben Woosley: doc: Correct spelling errors in comments
572020-03-04T04:22:54 <bitcoin-git> bitcoin/master 0886042 fanquake: Merge #18253: doc: Correct spelling errors in comments
582020-03-04T04:22:56 *** bitcoin-git has left #bitcoin-core-dev
592020-03-04T04:23:10 *** bitcoin-git has joined #bitcoin-core-dev
602020-03-04T04:23:11 <bitcoin-git> [bitcoin] fanquake merged pull request #18253: doc: Correct spelling errors in comments (master...2020-03-lint-spelling) https://github.com/bitcoin/bitcoin/pull/18253
612020-03-04T04:23:12 *** bitcoin-git has left #bitcoin-core-dev
622020-03-04T04:33:07 *** hadjiszs has quit IRC
632020-03-04T04:40:31 *** pinheadmz has joined #bitcoin-core-dev
642020-03-04T04:41:18 *** justanotheruser has quit IRC
652020-03-04T04:48:32 *** captjakk_ has quit IRC
662020-03-04T04:55:56 *** djpeen has quit IRC
672020-03-04T05:01:03 *** Dean_Guss has quit IRC
682020-03-04T05:10:00 *** captjakk has joined #bitcoin-core-dev
692020-03-04T05:13:07 *** captjakk has quit IRC
702020-03-04T05:13:20 *** captjakk has joined #bitcoin-core-dev
712020-03-04T05:15:20 *** promag has joined #bitcoin-core-dev
722020-03-04T05:32:15 *** justanotheruser has joined #bitcoin-core-dev
732020-03-04T05:35:48 *** ossifrage has quit IRC
742020-03-04T05:37:02 *** ossifrage has joined #bitcoin-core-dev
752020-03-04T05:43:50 <kallewoof> Is there a way to undo a git checkout -B <existing branch>? I just did it, in the reverse order, and undid all my work. :/
762020-03-04T05:44:41 <sipa> git reflog
772020-03-04T05:44:46 <fanquake> ^
782020-03-04T05:45:35 <sipa> that'll give you a history of commits andnbranches you went through
792020-03-04T05:45:42 <kallewoof> Thanks... I think checking out HEAD@{6} got me back where I wanted to be
802020-03-04T05:45:54 <sipa> awesome
812020-03-04T06:00:02 *** Pysis|work has quit IRC
822020-03-04T06:01:55 *** hadjiszs has joined #bitcoin-core-dev
832020-03-04T06:13:13 *** jarthur has quit IRC
842020-03-04T06:18:36 *** promag has quit IRC
852020-03-04T06:19:09 *** EagleTM has joined #bitcoin-core-dev
862020-03-04T06:21:23 *** head_victim has joined #bitcoin-core-dev
872020-03-04T06:22:55 *** manantial has joined #bitcoin-core-dev
882020-03-04T06:24:37 *** captjakk has quit IRC
892020-03-04T06:31:29 *** head_victim has quit IRC
902020-03-04T06:40:42 *** Kiminuo has quit IRC
912020-03-04T06:56:10 *** SukhE1 has joined #bitcoin-core-dev
922020-03-04T06:56:53 *** EagleTM has quit IRC
932020-03-04T07:04:56 *** turbo_choo has quit IRC
942020-03-04T07:11:14 *** promag has joined #bitcoin-core-dev
952020-03-04T07:12:09 *** harrigan_ has quit IRC
962020-03-04T07:13:43 *** harrigan has joined #bitcoin-core-dev
972020-03-04T07:34:59 *** Kiminuo has joined #bitcoin-core-dev
982020-03-04T07:35:02 *** turbo_choo has joined #bitcoin-core-dev
992020-03-04T07:43:23 *** vasild has quit IRC
1002020-03-04T07:45:31 *** vasild has joined #bitcoin-core-dev
1012020-03-04T07:49:46 *** as_pnn has joined #bitcoin-core-dev
1022020-03-04T07:57:43 *** jplix7k has joined #bitcoin-core-dev
1032020-03-04T08:04:22 *** promag has quit IRC
1042020-03-04T08:04:43 *** promag has joined #bitcoin-core-dev
1052020-03-04T08:09:05 *** promag has quit IRC
1062020-03-04T08:11:35 *** promag has joined #bitcoin-core-dev
1072020-03-04T08:15:54 *** promag has quit IRC
1082020-03-04T08:40:50 *** promag has joined #bitcoin-core-dev
1092020-03-04T08:44:18 *** promag has quit IRC
1102020-03-04T09:00:02 *** SukhE1 has quit IRC
1112020-03-04T09:04:25 *** jonatack has joined #bitcoin-core-dev
1122020-03-04T09:05:08 *** jplix7k has quit IRC
1132020-03-04T09:09:35 *** jonatack has quit IRC
1142020-03-04T09:10:56 *** timothy has joined #bitcoin-core-dev
1152020-03-04T09:11:11 *** jonatack has joined #bitcoin-core-dev
1162020-03-04T09:12:49 *** tylerlevine6 has joined #bitcoin-core-dev
1172020-03-04T09:13:29 *** tylerlevine has quit IRC
1182020-03-04T09:13:33 *** marcoagner has joined #bitcoin-core-dev
1192020-03-04T09:17:57 *** Victorsueca has quit IRC
1202020-03-04T09:20:55 *** dvratil1 has joined #bitcoin-core-dev
1212020-03-04T09:21:00 *** AaronvanW has joined #bitcoin-core-dev
1222020-03-04T09:23:55 *** Victorsueca has joined #bitcoin-core-dev
1232020-03-04T09:26:07 <provoostenator> Or the lazy version if Github is still up to date and you trust them: git reset --hard origin/my-precious-branch
1242020-03-04T09:26:35 <provoostenator> * origin -> your github remote
1252020-03-04T09:29:38 *** Zenton has joined #bitcoin-core-dev
1262020-03-04T09:33:11 *** Guyver2 has joined #bitcoin-core-dev
1272020-03-04T09:33:19 *** goatpig has joined #bitcoin-core-dev
1282020-03-04T09:40:28 *** turbo_choo has quit IRC
1292020-03-04T09:45:27 *** filchef has joined #bitcoin-core-dev
1302020-03-04T09:53:22 *** turbo_choo has joined #bitcoin-core-dev
1312020-03-04T10:00:09 *** jonatack_ has joined #bitcoin-core-dev
1322020-03-04T10:03:11 *** jonatack has quit IRC
1332020-03-04T10:04:35 *** promag has joined #bitcoin-core-dev
1342020-03-04T10:04:42 *** kexkey has quit IRC
1352020-03-04T10:09:14 *** promag has quit IRC
1362020-03-04T10:14:14 *** AaronvanW has quit IRC
1372020-03-04T10:20:17 <kallewoof> prob is, i checked out from master into a new branch, did a bunch of stuff, and then screwed up when I meant to do git checkout -B OVERWRITE_THIS by instead checking out OVERWRITE_THIS branch and doing git checkout -B MYCHANGES...
1382020-03-04T10:20:53 <kallewoof> I think my brain decided that checkout -B meant "checkout whatever is on the branch and use that as the new head for this branch"..
1392020-03-04T10:22:05 *** promag has joined #bitcoin-core-dev
1402020-03-04T10:49:02 *** AaronvanW has joined #bitcoin-core-dev
1412020-03-04T10:54:00 *** AaronvanW has quit IRC
1422020-03-04T11:02:27 *** votesmith has joined #bitcoin-core-dev
1432020-03-04T11:02:56 *** sdaftuar has quit IRC
1442020-03-04T11:03:15 *** jonatack_ has quit IRC
1452020-03-04T11:03:20 *** sdaftuar has joined #bitcoin-core-dev
1462020-03-04T11:03:54 *** Rudy3Heaney has joined #bitcoin-core-dev
1472020-03-04T11:04:05 *** jonatack_ has joined #bitcoin-core-dev
1482020-03-04T11:21:11 *** AaronvanW has joined #bitcoin-core-dev
1492020-03-04T11:36:32 *** promag has quit IRC
1502020-03-04T11:41:18 *** promag has joined #bitcoin-core-dev
1512020-03-04T11:50:24 *** promag has quit IRC
1522020-03-04T11:52:25 *** promag has joined #bitcoin-core-dev
1532020-03-04T11:54:00 *** AaronvanW has quit IRC
1542020-03-04T11:54:07 *** belcher has joined #bitcoin-core-dev
1552020-03-04T11:58:31 *** promag has quit IRC
1562020-03-04T12:00:02 *** dvratil1 has quit IRC
1572020-03-04T12:05:15 <wumpus> shall I tag v0.19.1?
1582020-03-04T12:06:04 <wumpus> I guess I forgot about it a bit and no one reminded me. I don't think anything critical has come up with rc2?
1592020-03-04T12:09:51 <fanquake> wumpus: sounds good
1602020-03-04T12:09:58 <fanquake> I haven't seen anything re rc2
1612020-03-04T12:15:31 *** bitcoin-git has joined #bitcoin-core-dev
1622020-03-04T12:15:31 <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/a28ea316ed47...58ba7c314d55
1632020-03-04T12:15:31 <bitcoin-git> bitcoin/0.19 58ba7c3 Wladimir J. van der Laan: build: Bump version for 0.19.1 final
1642020-03-04T12:15:33 *** bitcoin-git has left #bitcoin-core-dev
1652020-03-04T12:16:12 *** bitcoin-git has joined #bitcoin-core-dev
1662020-03-04T12:16:12 <bitcoin-git> [bitcoin] laanwj pushed tag v0.19.1: https://github.com/bitcoin/bitcoin/compare/v0.19.1
1672020-03-04T12:16:22 *** bitcoin-git has left #bitcoin-core-dev
1682020-03-04T12:20:08 *** jonatack_ has quit IRC
1692020-03-04T12:20:45 *** phyll1s_work has joined #bitcoin-core-dev
1702020-03-04T12:22:05 *** promag has joined #bitcoin-core-dev
1712020-03-04T12:22:25 *** jonatack_ has joined #bitcoin-core-dev
1722020-03-04T12:25:05 *** promag has quit IRC
1732020-03-04T12:29:50 *** promag has joined #bitcoin-core-dev
1742020-03-04T12:32:47 *** promag has quit IRC
1752020-03-04T12:34:55 *** promag has joined #bitcoin-core-dev
1762020-03-04T12:54:18 *** CodeShark__ has quit IRC
1772020-03-04T12:54:24 *** arik__ has quit IRC
1782020-03-04T12:54:44 *** NicolasDorier has quit IRC
1792020-03-04T12:54:46 *** CodeShark__ has joined #bitcoin-core-dev
1802020-03-04T12:55:01 *** NicolasDorier has joined #bitcoin-core-dev
1812020-03-04T12:55:25 *** arik__ has joined #bitcoin-core-dev
1822020-03-04T12:56:20 *** dongcarl has quit IRC
1832020-03-04T13:01:53 *** Guyver2 has quit IRC
1842020-03-04T13:06:56 *** Giderey36 has joined #bitcoin-core-dev
1852020-03-04T13:11:51 *** promag has quit IRC
1862020-03-04T13:13:53 *** Highway61 has quit IRC
1872020-03-04T13:14:32 *** Highway61 has joined #bitcoin-core-dev
1882020-03-04T13:16:15 *** promag has joined #bitcoin-core-dev
1892020-03-04T13:18:08 *** promag has quit IRC
1902020-03-04T13:18:11 *** bitcoin-git has joined #bitcoin-core-dev
1912020-03-04T13:18:12 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/088604221b4a...a71c34742c24
1922020-03-04T13:18:13 <bitcoin-git> bitcoin/master fa7d050 MarcoFalke: rpc: Move OuterType enum to header
1932020-03-04T13:18:14 <bitcoin-git> bitcoin/master fa6b061 MarcoFalke: rpc: Auto-format RPCResult
1942020-03-04T13:18:14 <bitcoin-git> bitcoin/master a71c347 MarcoFalke: Merge #17809: rpc: Auto-format RPCResult
1952020-03-04T13:18:16 *** bitcoin-git has left #bitcoin-core-dev
1962020-03-04T13:18:45 *** jb55 has quit IRC
1972020-03-04T13:18:46 *** bitcoin-git has joined #bitcoin-core-dev
1982020-03-04T13:18:46 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17809: rpc: Auto-format RPCResult (master...1906-rpcResult) https://github.com/bitcoin/bitcoin/pull/17809
1992020-03-04T13:18:48 *** bitcoin-git has left #bitcoin-core-dev
2002020-03-04T13:19:39 *** jb55 has joined #bitcoin-core-dev
2012020-03-04T13:19:56 *** promag has joined #bitcoin-core-dev
2022020-03-04T13:23:26 *** arik__ has quit IRC
2032020-03-04T13:23:41 *** arik__ has joined #bitcoin-core-dev
2042020-03-04T13:23:46 *** valwal has quit IRC
2052020-03-04T13:24:49 *** TheRec has quit IRC
2062020-03-04T13:25:00 *** valwal has joined #bitcoin-core-dev
2072020-03-04T13:25:53 *** TheRec has joined #bitcoin-core-dev
2082020-03-04T13:26:05 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2092020-03-04T13:33:21 *** promag has quit IRC
2102020-03-04T13:34:35 *** promag has joined #bitcoin-core-dev
2112020-03-04T13:36:13 *** Chris_Stewart_5 has quit IRC
2122020-03-04T13:36:22 *** promag has quit IRC
2132020-03-04T13:37:55 *** promag has joined #bitcoin-core-dev
2142020-03-04T13:38:04 *** promag has quit IRC
2152020-03-04T13:48:25 *** turbo_choo has quit IRC
2162020-03-04T13:50:15 *** turbo_choo has joined #bitcoin-core-dev
2172020-03-04T13:50:38 *** AaronvanW has joined #bitcoin-core-dev
2182020-03-04T13:58:34 *** promag has joined #bitcoin-core-dev
2192020-03-04T13:59:18 *** turbo_choo has quit IRC
2202020-03-04T14:02:49 *** promag has quit IRC
2212020-03-04T14:03:49 *** promag has joined #bitcoin-core-dev
2222020-03-04T14:08:33 *** promag has quit IRC
2232020-03-04T14:24:14 *** AaronvanW has quit IRC
2242020-03-04T14:25:05 *** promag has joined #bitcoin-core-dev
2252020-03-04T14:25:24 *** emilengler has joined #bitcoin-core-dev
2262020-03-04T14:30:06 *** turbo_choo has joined #bitcoin-core-dev
2272020-03-04T14:35:20 *** emilengler has quit IRC
2282020-03-04T14:35:34 *** emilengler has joined #bitcoin-core-dev
2292020-03-04T14:36:51 *** bitcoin-git has joined #bitcoin-core-dev
2302020-03-04T14:36:51 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18164: rpc: generalize address in decoderawtransaction RPCResult (master...20200216-rpc-remove-concrete-address-from-rpcresult) https://github.com/bitcoin/bitcoin/pull/18164
2312020-03-04T14:36:52 *** bitcoin-git has left #bitcoin-core-dev
2322020-03-04T14:40:37 *** turbo_choo has quit IRC
2332020-03-04T14:53:56 *** jarthur has joined #bitcoin-core-dev
2342020-03-04T14:58:45 *** andrewtoth_ has joined #bitcoin-core-dev
2352020-03-04T15:00:01 *** phyll1s_work has quit IRC
2362020-03-04T15:01:17 <harding> wumpus: FYI, 0.19.1 release stuff for the website: https://github.com/bitcoin-core/bitcoincore.org/pull/698
2372020-03-04T15:01:23 *** Giderey36 has quit IRC
2382020-03-04T15:04:28 *** Rudy3Heaney has quit IRC
2392020-03-04T15:06:25 *** bitcoin-git has joined #bitcoin-core-dev
2402020-03-04T15:06:26 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18259: doc: Merge release notes for 0.20.0 release (master...2003-docMergeRel) https://github.com/bitcoin/bitcoin/pull/18259
2412020-03-04T15:06:27 *** bitcoin-git has left #bitcoin-core-dev
2422020-03-04T15:06:59 *** turbo_choo has joined #bitcoin-core-dev
2432020-03-04T15:17:43 *** andrewtoth_ has quit IRC
2442020-03-04T15:21:46 *** pinheadmz has quit IRC
2452020-03-04T15:22:16 *** mdunnio has joined #bitcoin-core-dev
2462020-03-04T15:22:19 *** Kiminuo has quit IRC
2472020-03-04T15:24:27 *** bitcoin-git has joined #bitcoin-core-dev
2482020-03-04T15:24:29 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to 0.19: https://github.com/bitcoin/bitcoin/compare/58ba7c314d55...05f5dd96c71e
2492020-03-04T15:24:29 <bitcoin-git> bitcoin/0.19 1964561 fanquake: build: don't embed a build-id when building libdmg-hfsplus
2502020-03-04T15:24:30 <bitcoin-git> bitcoin/0.19 48fef5e Russell Yanofsky: gui: Fix race in WalletModel::pollBalanceChanged
2512020-03-04T15:24:31 <bitcoin-git> bitcoin/0.19 05f5dd9 MarcoFalke: Merge #18218: [0.19] Further 0.19 backports
2522020-03-04T15:24:33 *** bitcoin-git has left #bitcoin-core-dev
2532020-03-04T15:24:47 *** bitcoin-git has joined #bitcoin-core-dev
2542020-03-04T15:24:47 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18218: [0.19] Further 0.19 backports (0.19...futher-0-19-backports) https://github.com/bitcoin/bitcoin/pull/18218
2552020-03-04T15:24:49 *** bitcoin-git has left #bitcoin-core-dev
2562020-03-04T15:26:36 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2572020-03-04T15:26:46 *** goatpig has quit IRC
2582020-03-04T15:32:37 *** AaronvanW has joined #bitcoin-core-dev
2592020-03-04T15:34:36 *** Giderey36 has joined #bitcoin-core-dev
2602020-03-04T15:41:44 <jonatack_> Re-kick appveyor for #17812 please
2612020-03-04T15:41:46 <gribble> https://github.com/bitcoin/bitcoin/issues/17812 | config, net, test: asmap feature refinements and functional tests by jonatack · Pull Request #17812 · bitcoin/bitcoin · GitHub
2622020-03-04T15:41:52 *** Giderey36 has quit IRC
2632020-03-04T15:44:59 *** promag_ has joined #bitcoin-core-dev
2642020-03-04T15:49:20 *** promag_ has quit IRC
2652020-03-04T15:51:19 *** jonatack_ has quit IRC
2662020-03-04T15:51:41 *** jonatack has joined #bitcoin-core-dev
2672020-03-04T15:55:54 *** Guyver2 has joined #bitcoin-core-dev
2682020-03-04T15:56:45 *** grafa has joined #bitcoin-core-dev
2692020-03-04T16:02:01 *** turbo_choo has quit IRC
2702020-03-04T16:03:54 <instagibbs> sipa, https://github.com/bitcoin/bitcoin/pull/18204#discussion_r387761668 mind just giving an straw function of inputs to "key expressions numbers"?
2712020-03-04T16:06:21 <sipa> instagibbs: sh(multi(2,xpubA...,xpubB,xpubC))
2722020-03-04T16:06:26 <sipa> xpubA would be 0
2732020-03-04T16:06:33 <sipa> xpubB woukd be 1
2742020-03-04T16:06:36 <sipa> xoubC would be 2
2752020-03-04T16:11:33 <instagibbs> ah. Slightly different abstraction than I was thinking
2762020-03-04T16:28:05 <sipa> for hardened paths you'd still need a pubkey per derivation as well
2772020-03-04T16:29:10 <luke-jr> MarcoFalke: how does the boost bug tested in #18232 affect us?
2782020-03-04T16:29:12 <gribble> https://github.com/bitcoin/bitcoin/issues/18232 | test: Check that wait_until returns if time point is in the past by MarcoFalke · Pull Request #18232 · bitcoin/bitcoin · GitHub
2792020-03-04T16:36:26 *** vincenzopalazzo has joined #bitcoin-core-dev
2802020-03-04T16:51:43 *** vincentpalazzo has joined #bitcoin-core-dev
2812020-03-04T16:54:06 *** vincenzopalazzo has quit IRC
2822020-03-04T16:54:49 *** Kiminuo has joined #bitcoin-core-dev
2832020-03-04T16:59:19 *** captjakk has joined #bitcoin-core-dev
2842020-03-04T17:04:56 *** lightlike has joined #bitcoin-core-dev
2852020-03-04T17:05:54 *** sdaftuar has quit IRC
2862020-03-04T17:06:18 *** sdaftuar has joined #bitcoin-core-dev
2872020-03-04T17:06:59 *** promag has quit IRC
2882020-03-04T17:07:05 *** Talkless has joined #bitcoin-core-dev
2892020-03-04T17:16:03 *** Guyver2_ has joined #bitcoin-core-dev
2902020-03-04T17:18:35 *** Guyver2 has quit IRC
2912020-03-04T17:19:48 <MarcoFalke> luke-jr: I don't think it affects us
2922020-03-04T17:20:35 <MarcoFalke> Well, it might if you change your time zone or system time. But I think Bitcoin Core does not support that anyway?!
2932020-03-04T17:21:45 <MarcoFalke> Or if you schedule something with a timestamp in the past. I think we don't do that either
2942020-03-04T17:21:48 <luke-jr> then why test it?
2952020-03-04T17:22:31 <luke-jr> no reason to create hurdles to tests passing, if they don't affect us..
2962020-03-04T17:22:42 <MarcoFalke> It does happen in unit tests or functional test, because there we schedule things in the past (for testing reasons)
2972020-03-04T17:22:54 <luke-jr> hmm
2982020-03-04T17:23:05 <luke-jr> well, we still should be able to test on current systems IMO
2992020-03-04T17:23:26 <MarcoFalke> Yeah, which is why the mockscheduler test is disabled
3002020-03-04T17:24:41 <MarcoFalke> I think the only feasible solution is to remove boost
3012020-03-04T17:24:46 *** bitcoin-git has joined #bitcoin-core-dev
3022020-03-04T17:24:46 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18232: WIP test: Check that wait_until returns if time point is in the past (master...2002-debugBoost) https://github.com/bitcoin/bitcoin/pull/18232
3032020-03-04T17:24:47 *** bitcoin-git has left #bitcoin-core-dev
3042020-03-04T17:25:31 <luke-jr> or handle the exception?
3052020-03-04T17:30:05 *** vincentpalazzo has quit IRC
3062020-03-04T17:31:05 <MarcoFalke> How would you handle it and then proceed with execution?
3072020-03-04T17:31:11 <MarcoFalke> The next call would throw the same exception
3082020-03-04T17:32:11 <MarcoFalke> And if the exception is handled in the scheduler, it seems overkill to modify Bitcoin Core code for purly (unit) testing needs
3092020-03-04T17:32:15 <MarcoFalke> *purely
3102020-03-04T17:32:46 *** michaelfolkson has joined #bitcoin-core-dev
3112020-03-04T17:33:14 * MarcoFalke lunch
3122020-03-04T17:33:20 <luke-jr> MarcoFalke: if the exception is thrown, check manually if the time is past; if not, rethrow
3132020-03-04T17:33:24 <luke-jr> if so, nothing more to do
3142020-03-04T17:37:23 *** spaced0ut has quit IRC
3152020-03-04T17:39:43 *** rafalcpp_ has quit IRC
3162020-03-04T17:41:44 *** rafalcpp_ has joined #bitcoin-core-dev
3172020-03-04T17:42:00 *** timothy has quit IRC
3182020-03-04T17:49:03 *** lightlike has left #bitcoin-core-dev
3192020-03-04T17:57:35 *** captjakk has quit IRC
3202020-03-04T18:00:01 *** grafa has quit IRC
3212020-03-04T18:11:09 <MarcoFalke> Jup, in that case it would need to be handled in the scheduler, which I'd rather not for the reason just mentioned
3222020-03-04T18:21:29 *** dougvann has joined #bitcoin-core-dev
3232020-03-04T18:21:51 *** andrewtoth_ has joined #bitcoin-core-dev
3242020-03-04T18:22:46 <nothingmuch> MarcoFalke: i think the currently disabled test can be made robust to the failure by deducting a delta that doesn't go too far into the past, i'm attempting that now
3252020-03-04T18:23:02 <nothingmuch> the mockforward test, that is
3262020-03-04T18:23:17 <MarcoFalke> I know. But that still doesn't *solve* the problem
3272020-03-04T18:24:01 <MarcoFalke> If you reboot your machine and have the tests already compiled it will still fail, even with a minimal delta
3282020-03-04T18:24:01 *** captjakk has joined #bitcoin-core-dev
3292020-03-04T18:24:14 <nothingmuch> oh!
3302020-03-04T18:24:25 <nothingmuch> i didn't realize that =(
3312020-03-04T18:24:27 <MarcoFalke> Basically any delta that is larger than the time it took you to start your machine
3322020-03-04T18:25:16 <nothingmuch> oh, ok that's how i understood it before... just to make sure - the time of compilation itself doesn't factor in, right? it's that if the compilation is fast?
3332020-03-04T18:25:41 <nothingmuch> what i was going to do is just compute a delta for mockforward that is enough to be in the past, but no further in the past than the start of the test
3342020-03-04T18:25:51 <MarcoFalke> The boost::internal_clock (whatever that is) starts to count when you start your computer
3352020-03-04T18:26:06 <MarcoFalke> if boot+compile takes 2 minutes, the clock will show 2 minutes
3362020-03-04T18:26:35 *** bitcoin-git has joined #bitcoin-core-dev
3372020-03-04T18:26:35 <bitcoin-git> [bitcoin] rex4539 closed pull request #17839: build: depends macOS: hide linker visibility warnings (master...hide-warnings) https://github.com/bitcoin/bitcoin/pull/17839
3382020-03-04T18:26:40 *** bitcoin-git has left #bitcoin-core-dev
3392020-03-04T18:27:02 <MarcoFalke> The unit test should fully run in 2 milliseconds, so I don't think you can use the start of the test as a useful reference time
3402020-03-04T18:29:00 <nothingmuch> because such a test would be too slow to be acceptable? i was going to reduce the 5 minutes by a few orders of magnitude
3412020-03-04T18:30:15 <nothingmuch> i.e. t0 = now; microsleep; dt = now-t0; schedule for dt from now; mock forward by 2*dt
3422020-03-04T18:31:06 <MarcoFalke> The test is disabled now, so it doesn't do any harm. Long term we should focus on #18234
3432020-03-04T18:31:08 <gribble> https://github.com/bitcoin/bitcoin/issues/18234 | refactor: Replace boost::mutex,condition_var,chrono with std equivalents in scheduler by ajtowns · Pull Request #18234 · bitcoin/bitcoin · GitHub
3442020-03-04T18:31:23 <MarcoFalke> 18234 also fixes the bug, by removing boost
3452020-03-04T18:31:51 <nothingmuch> fair enough, though i didn't feel qualified to review that
3462020-03-04T18:35:37 *** jimmysong has joined #bitcoin-core-dev
3472020-03-04T18:37:16 *** ak has joined #bitcoin-core-dev
3482020-03-04T18:39:44 *** Emcy has joined #bitcoin-core-dev
3492020-03-04T18:49:07 *** Chris_Stewart_5 has quit IRC
3502020-03-04T18:53:25 *** bitcoin-git has joined #bitcoin-core-dev
3512020-03-04T18:53:26 <bitcoin-git> [bitcoin] Empact opened pull request #18260: refactor: Fix implicit value conversion in formatPingTime (master...2020-03-ping-time) https://github.com/bitcoin/bitcoin/pull/18260
3522020-03-04T18:53:27 *** bitcoin-git has left #bitcoin-core-dev
3532020-03-04T18:59:27 *** ak has quit IRC
3542020-03-04T19:07:39 *** promag has joined #bitcoin-core-dev
3552020-03-04T19:11:49 <jonasschnelli> 0.19.1 detached sigs are up: https://github.com/bitcoin-core/bitcoin-detached-sigs/commits/0.19
3562020-03-04T19:12:07 *** promag has quit IRC
3572020-03-04T19:21:18 *** emilengler has quit IRC
3582020-03-04T19:22:24 *** captjakk has quit IRC
3592020-03-04T19:22:27 *** emilengler has joined #bitcoin-core-dev
3602020-03-04T19:22:38 *** paracyst has quit IRC
3612020-03-04T19:22:49 *** captjakk has joined #bitcoin-core-dev
3622020-03-04T19:23:12 <cfields_> jonasschnelli: need to tag first ;)
3632020-03-04T19:23:14 <cfields_> tagging now
3642020-03-04T19:23:15 *** Talkless has quit IRC
3652020-03-04T19:23:56 <jonasschnelli> cfields_: oh. Right. Thanks...
3662020-03-04T19:24:18 <jonasschnelli> cfields_: whats sigs would it take if there is no tag? Just the head of the 0.19 branch?
3672020-03-04T19:24:45 *** paracyst has joined #bitcoin-core-dev
3682020-03-04T19:25:10 <cfields_> jonasschnelli: it tries to checkout a ref with the same name as the release. So 'git reset --hard v0.19.1' (or something like that) would just fail.
3692020-03-04T19:26:05 <cfields_> ok, gitian builders: detached sigs for v0.19.1 are up
3702020-03-04T19:27:02 *** emilengler has quit IRC
3712020-03-04T19:27:16 *** captjakk has quit IRC
3722020-03-04T19:28:35 *** emilengler has joined #bitcoin-core-dev
3732020-03-04T19:32:45 *** ddustin has joined #bitcoin-core-dev
3742020-03-04T19:40:26 *** sdddddd has quit IRC
3752020-03-04T19:40:35 *** vasild_ has joined #bitcoin-core-dev
3762020-03-04T19:41:02 *** sdddddd has joined #bitcoin-core-dev
3772020-03-04T19:43:23 *** vasild has quit IRC
3782020-03-04T19:57:27 *** owowo has quit IRC
3792020-03-04T19:58:02 *** vasild_ is now known as vasild
3802020-03-04T19:59:44 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3812020-03-04T20:01:48 *** bitcoin-git has joined #bitcoin-core-dev
3822020-03-04T20:01:48 <bitcoin-git> [bitcoin] naumenkogs opened pull request #18261: Erlay: bandwidth-efficient transaction relay protocol (master...erlay) https://github.com/bitcoin/bitcoin/pull/18261
3832020-03-04T20:01:49 *** bitcoin-git has left #bitcoin-core-dev
3842020-03-04T20:02:47 *** owowo has joined #bitcoin-core-dev
3852020-03-04T20:06:50 *** rh0nj has quit IRC
3862020-03-04T20:06:54 *** jonatack has quit IRC
3872020-03-04T20:12:17 *** jonatack has joined #bitcoin-core-dev
3882020-03-04T20:14:10 <instagibbs> luke-jr, unless I have serious misunderstandings, erlay shouldn't really effected anymore than flooding relay with respect to diverse network policies
3892020-03-04T20:14:38 <instagibbs> it's basically a batching of INVs you would have sent your peer, then compact exchange of that difference
3902020-03-04T20:15:26 *** ddustin has quit IRC
3912020-03-04T20:16:51 *** bitcoin-git has joined #bitcoin-core-dev
3922020-03-04T20:16:51 <bitcoin-git> [bitcoin] luke-jr reopened pull request #15600: lockedpool: When possible, use madvise to avoid including sensitive information in core dumps or forked process memory spaces (master...lockedpool_dontdump) https://github.com/bitcoin/bitcoin/pull/15600
3932020-03-04T20:16:52 *** bitcoin-git has left #bitcoin-core-dev
3942020-03-04T20:17:06 *** ddustin has joined #bitcoin-core-dev
3952020-03-04T20:22:28 *** ddustin has quit IRC
3962020-03-04T20:23:29 *** ddustin has joined #bitcoin-core-dev
3972020-03-04T20:28:22 *** ddustin has quit IRC
3982020-03-04T20:29:45 *** promag has joined #bitcoin-core-dev
3992020-03-04T20:42:17 *** Guyver2_ is now known as Guyver2
4002020-03-04T20:45:09 *** captjakk has joined #bitcoin-core-dev
4012020-03-04T20:49:37 *** captjakk has quit IRC
4022020-03-04T20:50:35 *** promag has quit IRC
4032020-03-04T20:54:04 *** ddustin has joined #bitcoin-core-dev
4042020-03-04T20:55:14 *** captjakk has joined #bitcoin-core-dev
4052020-03-04T20:57:45 *** jimmysong has quit IRC
4062020-03-04T20:58:53 *** promag has joined #bitcoin-core-dev
4072020-03-04T21:00:01 *** dougvann has quit IRC
4082020-03-04T21:02:22 *** ddustin has quit IRC
4092020-03-04T21:03:34 *** promag has quit IRC
4102020-03-04T21:12:22 *** ddustin has joined #bitcoin-core-dev
4112020-03-04T21:16:46 *** ddustin has quit IRC
4122020-03-04T21:38:14 *** bitcoin-git has joined #bitcoin-core-dev
4132020-03-04T21:38:14 <bitcoin-git> [bitcoin] achow101 opened pull request #18262: bnb: exit selection when best_waste is 0 (master...bnb-waste-zero) https://github.com/bitcoin/bitcoin/pull/18262
4142020-03-04T21:38:15 *** bitcoin-git has left #bitcoin-core-dev
4152020-03-04T21:39:26 *** mdunnio has quit IRC
4162020-03-04T21:41:28 *** mdunnio has joined #bitcoin-core-dev
4172020-03-04T21:50:32 *** justanotheruser has quit IRC
4182020-03-04T21:56:15 *** Dantman has joined #bitcoin-core-dev
4192020-03-04T21:59:16 *** Guyver2_ has joined #bitcoin-core-dev
4202020-03-04T22:02:05 *** Guyver2 has quit IRC
4212020-03-04T22:03:34 *** ddustin has joined #bitcoin-core-dev
4222020-03-04T22:08:26 *** ddustin has quit IRC
4232020-03-04T22:10:43 *** promag has joined #bitcoin-core-dev
4242020-03-04T22:12:39 *** ddustin has joined #bitcoin-core-dev
4252020-03-04T22:13:51 *** as_pnn has quit IRC
4262020-03-04T22:14:51 *** promag has quit IRC
4272020-03-04T22:14:55 *** roconnor has joined #bitcoin-core-dev
4282020-03-04T22:17:27 *** ddustin has quit IRC
4292020-03-04T22:17:56 *** Guyver2_ has quit IRC
4302020-03-04T22:25:19 *** bitcoin-git has joined #bitcoin-core-dev
4312020-03-04T22:25:19 <bitcoin-git> [bitcoin] gzhao408 opened pull request #18263: rpc change setmocktime check to use IsMockableChain (master...rpc-setmocktime-check) https://github.com/bitcoin/bitcoin/pull/18263
4322020-03-04T22:25:20 *** bitcoin-git has left #bitcoin-core-dev
4332020-03-04T22:28:03 *** justanotheruser has joined #bitcoin-core-dev
4342020-03-04T22:31:58 *** ddustin has joined #bitcoin-core-dev
4352020-03-04T22:32:10 *** captjakk has quit IRC
4362020-03-04T22:34:08 *** manantial has quit IRC
4372020-03-04T22:36:26 *** ddustin has quit IRC
4382020-03-04T22:38:05 *** ddustin has joined #bitcoin-core-dev
4392020-03-04T22:40:18 *** captjakk has joined #bitcoin-core-dev
4402020-03-04T22:42:40 *** ddustin has quit IRC
4412020-03-04T22:50:13 *** as_pnn has joined #bitcoin-core-dev
4422020-03-04T22:51:07 *** Chris_Stewart_5 has quit IRC
4432020-03-04T22:51:51 *** promag has joined #bitcoin-core-dev
4442020-03-04T22:56:30 *** promag has quit IRC
4452020-03-04T23:02:01 *** filchef has quit IRC
4462020-03-04T23:04:37 *** promag has joined #bitcoin-core-dev
4472020-03-04T23:15:47 *** YoungWoma has joined #bitcoin-core-dev
4482020-03-04T23:18:43 *** braydonf has quit IRC
4492020-03-04T23:19:09 *** YoungWoma has quit IRC
4502020-03-04T23:23:42 *** braydonf has joined #bitcoin-core-dev
4512020-03-04T23:23:52 *** michaelfolkson has quit IRC
4522020-03-04T23:23:58 *** francisco______ has joined #bitcoin-core-dev
4532020-03-04T23:38:21 *** marcoagner has quit IRC
4542020-03-04T23:38:31 *** _flow_ has quit IRC
4552020-03-04T23:41:46 *** _flow_ has joined #bitcoin-core-dev
4562020-03-04T23:44:41 *** mdunnio has quit IRC
4572020-03-04T23:55:39 *** jarthur has quit IRC