1 2020-03-13T00:00:02  *** sirkitree has quit IRC
  2 2020-03-13T00:00:54  *** rjected has joined #bitcoin-core-dev
  3 2020-03-13T00:03:10  *** braydonf has quit IRC
  4 2020-03-13T00:03:51  *** braydonf has joined #bitcoin-core-dev
  5 2020-03-13T00:06:07  *** achow101 has joined #bitcoin-core-dev
  6 2020-03-13T00:18:28  *** paxed1 has joined #bitcoin-core-dev
  7 2020-03-13T00:24:28  *** braydonf has quit IRC
  8 2020-03-13T00:26:17  *** MrSquanchee has joined #bitcoin-core-dev
  9 2020-03-13T00:27:22  *** sonofhan has joined #bitcoin-core-dev
 10 2020-03-13T00:27:57  *** sonofhan has quit IRC
 11 2020-03-13T00:28:29  *** sonofhan has joined #bitcoin-core-dev
 12 2020-03-13T00:29:29  *** marcoagner has quit IRC
 13 2020-03-13T00:36:28  *** pinheadmz_ has joined #bitcoin-core-dev
 14 2020-03-13T00:38:28  *** provoostenator has quit IRC
 15 2020-03-13T00:39:15  *** pinheadmz has quit IRC
 16 2020-03-13T00:39:15  *** pinheadmz_ is now known as pinheadmz
 17 2020-03-13T00:45:13  *** braydonf has joined #bitcoin-core-dev
 18 2020-03-13T00:45:44  *** provoostenator has joined #bitcoin-core-dev
 19 2020-03-13T00:48:21  *** dr-orlovsky has joined #bitcoin-core-dev
 20 2020-03-13T01:13:59  *** DeanGuss has joined #bitcoin-core-dev
 21 2020-03-13T01:21:33  *** belcher has quit IRC
 22 2020-03-13T01:26:55  *** I_LIKE_FREE has quit IRC
 23 2020-03-13T01:28:22  *** dr-orlovsky has quit IRC
 24 2020-03-13T01:30:18  *** captjakk has joined #bitcoin-core-dev
 25 2020-03-13T01:37:38  *** bitcoin-git has joined #bitcoin-core-dev
 26 2020-03-13T01:37:38  <bitcoin-git> [bitcoin] promag opened pull request #18338: wip: Fix wallet unload race condition (master...notify-shared) https://github.com/bitcoin/bitcoin/pull/18338
 27 2020-03-13T01:37:40  *** bitcoin-git has left #bitcoin-core-dev
 28 2020-03-13T01:38:15  *** pinheadmz has quit IRC
 29 2020-03-13T01:53:03  *** DeanGuss has quit IRC
 30 2020-03-13T01:57:43  *** AaronvanW has quit IRC
 31 2020-03-13T02:01:54  *** bitcoin-git has joined #bitcoin-core-dev
 32 2020-03-13T02:01:54  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18337: init: Remove boost::thread_group (master...2003-NoBoostThreadGroup) https://github.com/bitcoin/bitcoin/pull/18337
 33 2020-03-13T02:01:55  *** bitcoin-git has left #bitcoin-core-dev
 34 2020-03-13T02:11:43  *** mdunnio has joined #bitcoin-core-dev
 35 2020-03-13T02:14:44  *** promag has quit IRC
 36 2020-03-13T02:19:53  *** bitcoin-git has joined #bitcoin-core-dev
 37 2020-03-13T02:19:53  <bitcoin-git> [bitcoin] gzhao408 opened pull request #18339: wip [test] multiple reject reasons for test_witness_block (master...test_witness_block-multiple-reasons) https://github.com/bitcoin/bitcoin/pull/18339
 38 2020-03-13T02:19:54  *** bitcoin-git has left #bitcoin-core-dev
 39 2020-03-13T02:23:57  *** promag has joined #bitcoin-core-dev
 40 2020-03-13T02:24:03  *** braydonf has quit IRC
 41 2020-03-13T02:24:23  *** bitcoin-git has joined #bitcoin-core-dev
 42 2020-03-13T02:24:24  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e2d36639ca87...3f9e6a3c1ce8
 43 2020-03-13T02:24:25  <bitcoin-git> bitcoin/master a33cffb Jon Atack: util: HelpExampleRpc formatting fixup
 44 2020-03-13T02:24:26  <bitcoin-git> bitcoin/master 3f9e6a3 fanquake: Merge #18316: util: HelpExampleRpc formatting
 45 2020-03-13T02:24:28  *** bitcoin-git has left #bitcoin-core-dev
 46 2020-03-13T02:24:28  *** braydonf has joined #bitcoin-core-dev
 47 2020-03-13T02:24:43  *** bitcoin-git has joined #bitcoin-core-dev
 48 2020-03-13T02:24:43  <bitcoin-git> [bitcoin] fanquake merged pull request #18316: util: HelpExampleRpc formatting (master...json-rpc-example-template-formatting) https://github.com/bitcoin/bitcoin/pull/18316
 49 2020-03-13T02:24:46  *** bitcoin-git has left #bitcoin-core-dev
 50 2020-03-13T02:24:57  *** braydonf has joined #bitcoin-core-dev
 51 2020-03-13T02:28:27  *** promag has quit IRC
 52 2020-03-13T02:28:36  *** rjected has quit IRC
 53 2020-03-13T02:30:40  *** braydonf has quit IRC
 54 2020-03-13T02:31:14  *** braydonf has joined #bitcoin-core-dev
 55 2020-03-13T02:32:55  *** AaronvanW has joined #bitcoin-core-dev
 56 2020-03-13T02:37:47  *** AaronvanW has quit IRC
 57 2020-03-13T02:43:31  *** mdunnio has quit IRC
 58 2020-03-13T03:00:02  *** paxed1 has quit IRC
 59 2020-03-13T03:07:03  <sipa> MarcoFalke: lol at your github profile picture
 60 2020-03-13T03:08:56  *** pinheadmz has joined #bitcoin-core-dev
 61 2020-03-13T03:10:39  *** krvopije has joined #bitcoin-core-dev
 62 2020-03-13T03:13:30  *** krvopije has quit IRC
 63 2020-03-13T03:17:30  *** dviola has joined #bitcoin-core-dev
 64 2020-03-13T03:17:37  *** UltimateNate has joined #bitcoin-core-dev
 65 2020-03-13T03:19:35  *** AaronvanW has joined #bitcoin-core-dev
 66 2020-03-13T03:19:44  *** sonofhan has quit IRC
 67 2020-03-13T03:26:08  *** Chris_Stewart_5 has quit IRC
 68 2020-03-13T03:26:53  *** bitcoin-git has joined #bitcoin-core-dev
 69 2020-03-13T03:26:53  <bitcoin-git> [bitcoin] fanquake opened pull request #18340: doc: mention MAKE=gmake workaround when building on a BSD (master...fixup_18129) https://github.com/bitcoin/bitcoin/pull/18340
 70 2020-03-13T03:26:54  *** bitcoin-git has left #bitcoin-core-dev
 71 2020-03-13T03:27:13  *** bitcoin-git has joined #bitcoin-core-dev
 72 2020-03-13T03:27:13  <bitcoin-git> [bitcoin] fanquake closed pull request #18129: Doc: Fix BSD docs regarding gmake (master...bsddocs) https://github.com/bitcoin/bitcoin/pull/18129
 73 2020-03-13T03:27:17  *** bitcoin-git has left #bitcoin-core-dev
 74 2020-03-13T03:30:29  *** provoostenator has quit IRC
 75 2020-03-13T03:31:44  *** provoostenator has joined #bitcoin-core-dev
 76 2020-03-13T03:39:59  *** provoostenator has quit IRC
 77 2020-03-13T03:41:14  *** provoostenator has joined #bitcoin-core-dev
 78 2020-03-13T03:41:42  *** felixfoertsch has joined #bitcoin-core-dev
 79 2020-03-13T03:42:03  *** felixfoertsch23 has quit IRC
 80 2020-03-13T03:46:14  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 81 2020-03-13T03:48:54  *** captjakk has quit IRC
 82 2020-03-13T03:49:28  *** captjakk has joined #bitcoin-core-dev
 83 2020-03-13T03:52:13  *** AaronvanW has quit IRC
 84 2020-03-13T03:53:39  *** captjakk has quit IRC
 85 2020-03-13T03:56:18  *** Highway61 has quit IRC
 86 2020-03-13T04:06:44  *** hadjiszs has joined #bitcoin-core-dev
 87 2020-03-13T04:12:25  *** Chris_Stewart_5 has quit IRC
 88 2020-03-13T04:49:38  *** bitcoin-git has joined #bitcoin-core-dev
 89 2020-03-13T04:49:38  <bitcoin-git> [bitcoin] fanquake closed pull request #16083: [WIP] transaction fees in getblock (master...201905_grt_prevout) https://github.com/bitcoin/bitcoin/pull/16083
 90 2020-03-13T04:49:40  *** bitcoin-git has left #bitcoin-core-dev
 91 2020-03-13T05:03:03  *** achow101 has quit IRC
 92 2020-03-13T05:12:57  *** achow101 has joined #bitcoin-core-dev
 93 2020-03-13T05:39:50  *** anditto has joined #bitcoin-core-dev
 94 2020-03-13T05:49:32  *** AaronvanW has joined #bitcoin-core-dev
 95 2020-03-13T05:55:37  *** achow101_ has joined #bitcoin-core-dev
 96 2020-03-13T05:56:56  *** achow101 has quit IRC
 97 2020-03-13T05:58:18  *** anditto has quit IRC
 98 2020-03-13T05:58:45  *** anditto has joined #bitcoin-core-dev
 99 2020-03-13T06:00:02  *** UltimateNate has quit IRC
100 2020-03-13T06:03:18  *** anditto has quit IRC
101 2020-03-13T06:19:45  *** Morgon1 has joined #bitcoin-core-dev
102 2020-03-13T06:21:39  *** AaronvanW has quit IRC
103 2020-03-13T06:30:56  *** achow101_ has quit IRC
104 2020-03-13T06:31:48  *** achow101 has joined #bitcoin-core-dev
105 2020-03-13T06:39:01  *** anditto has joined #bitcoin-core-dev
106 2020-03-13T07:00:16  *** promag has joined #bitcoin-core-dev
107 2020-03-13T07:04:46  *** promag has quit IRC
108 2020-03-13T07:40:43  *** vasild_ has joined #bitcoin-core-dev
109 2020-03-13T07:41:20  *** Deacyde has quit IRC
110 2020-03-13T07:42:49  *** Deacyde has joined #bitcoin-core-dev
111 2020-03-13T07:44:03  *** vasild has quit IRC
112 2020-03-13T07:44:04  *** vasild_ is now known as vasild
113 2020-03-13T07:45:36  *** ddustin has joined #bitcoin-core-dev
114 2020-03-13T07:49:46  *** ddustin has quit IRC
115 2020-03-13T08:11:22  *** sipsorcery has joined #bitcoin-core-dev
116 2020-03-13T08:11:26  *** anditto has quit IRC
117 2020-03-13T08:19:38  *** AaronvanW has joined #bitcoin-core-dev
118 2020-03-13T08:33:54  *** lnostdal_ has joined #bitcoin-core-dev
119 2020-03-13T08:46:51  *** bitcoin-git has joined #bitcoin-core-dev
120 2020-03-13T08:46:51  <bitcoin-git> [bitcoin] promag closed pull request #18280: wallet: UnregisterValidationInterface before SyncWithValidationInterfaceQueue (master...2020-03-sync-unregistervalidationinterface) https://github.com/bitcoin/bitcoin/pull/18280
121 2020-03-13T08:46:52  *** bitcoin-git has left #bitcoin-core-dev
122 2020-03-13T08:53:13  *** AaronvanW has quit IRC
123 2020-03-13T09:00:02  *** Morgon1 has quit IRC
124 2020-03-13T09:04:33  *** marcoagner has joined #bitcoin-core-dev
125 2020-03-13T09:16:17  *** promag has joined #bitcoin-core-dev
126 2020-03-13T09:17:40  *** b0o has joined #bitcoin-core-dev
127 2020-03-13T09:31:52  *** marcoagner has quit IRC
128 2020-03-13T09:43:15  *** manantial has joined #bitcoin-core-dev
129 2020-03-13T09:49:19  *** timothy has joined #bitcoin-core-dev
130 2020-03-13T10:00:20  *** AaronvanW has joined #bitcoin-core-dev
131 2020-03-13T10:14:33  *** MrSquanchee has quit IRC
132 2020-03-13T10:16:34  *** hadjiszs has quit IRC
133 2020-03-13T10:28:29  *** filchef has joined #bitcoin-core-dev
134 2020-03-13T10:42:53  *** bitcoin-git has joined #bitcoin-core-dev
135 2020-03-13T10:42:54  <bitcoin-git> [bitcoin] domob1812 opened pull request #18341: Replace remaining literal BTC with CURRENCY_UNIT. (master...currency-unit) https://github.com/bitcoin/bitcoin/pull/18341
136 2020-03-13T10:42:55  *** bitcoin-git has left #bitcoin-core-dev
137 2020-03-13T10:52:15  *** promag_ has joined #bitcoin-core-dev
138 2020-03-13T10:52:15  *** promag has quit IRC
139 2020-03-13T11:03:56  *** Dessie18Rosenbau has joined #bitcoin-core-dev
140 2020-03-13T11:04:19  *** AaronvanW has quit IRC
141 2020-03-13T11:08:24  *** sipsorcery has quit IRC
142 2020-03-13T11:08:27  *** Dessie18Rosenbau has quit IRC
143 2020-03-13T11:08:47  *** nullptr_ has quit IRC
144 2020-03-13T11:09:49  *** Chris_Stewart_5 has joined #bitcoin-core-dev
145 2020-03-13T11:12:51  *** nullptr| has joined #bitcoin-core-dev
146 2020-03-13T11:23:49  *** sipsorcery has joined #bitcoin-core-dev
147 2020-03-13T11:27:55  *** shigeya has quit IRC
148 2020-03-13T11:28:45  *** shigeya has joined #bitcoin-core-dev
149 2020-03-13T11:31:26  *** promag_ has quit IRC
150 2020-03-13T11:42:42  *** AaronvanW has joined #bitcoin-core-dev
151 2020-03-13T11:46:01  *** Guyver2 has joined #bitcoin-core-dev
152 2020-03-13T12:00:01  *** b0o has quit IRC
153 2020-03-13T12:14:21  *** belcher has joined #bitcoin-core-dev
154 2020-03-13T12:42:46  *** bitcoin-git has joined #bitcoin-core-dev
155 2020-03-13T12:42:46  <bitcoin-git> [bitcoin] practicalswift opened pull request #18342: doc: Add fuzzing quickstart guide (master...fuzzing-quick-start-guide) https://github.com/bitcoin/bitcoin/pull/18342
156 2020-03-13T12:42:47  *** bitcoin-git has left #bitcoin-core-dev
157 2020-03-13T12:51:07  *** kaeru has joined #bitcoin-core-dev
158 2020-03-13T13:10:09  *** mdunnio has joined #bitcoin-core-dev
159 2020-03-13T13:10:15  *** mdunnio has quit IRC
160 2020-03-13T13:17:17  *** jarthur has joined #bitcoin-core-dev
161 2020-03-13T13:40:48  *** mdunnio has joined #bitcoin-core-dev
162 2020-03-13T13:55:38  *** bitcoin-git has joined #bitcoin-core-dev
163 2020-03-13T13:55:38  <bitcoin-git> [bitcoin] instagibbs opened pull request #18343: Use min relay value constant in QT (master...qt_min_relay) https://github.com/bitcoin/bitcoin/pull/18343
164 2020-03-13T13:55:39  *** bitcoin-git has left #bitcoin-core-dev
165 2020-03-13T14:10:58  *** bitcoin-git has joined #bitcoin-core-dev
166 2020-03-13T14:10:58  <bitcoin-git> [bitcoin] stevenroose opened pull request #18344: Fix nit in getblockchaininfo (master...nit-blockchaininfo) https://github.com/bitcoin/bitcoin/pull/18344
167 2020-03-13T14:11:02  *** bitcoin-git has left #bitcoin-core-dev
168 2020-03-13T14:24:28  *** Chris_Stewart_5 has quit IRC
169 2020-03-13T14:29:26  *** spaced0ut has quit IRC
170 2020-03-13T14:34:36  *** Guyver2_ has joined #bitcoin-core-dev
171 2020-03-13T14:38:05  *** Guyver2 has quit IRC
172 2020-03-13T14:44:56  *** mohammadbitcoina has joined #bitcoin-core-dev
173 2020-03-13T14:46:13  *** Chris_Stewart_5 has joined #bitcoin-core-dev
174 2020-03-13T14:47:44  *** mol has quit IRC
175 2020-03-13T15:00:02  *** kaeru has quit IRC
176 2020-03-13T15:03:57  *** mohammadbitcoina has quit IRC
177 2020-03-13T15:05:54  *** MrSquanchee has joined #bitcoin-core-dev
178 2020-03-13T15:08:42  *** ddustin has joined #bitcoin-core-dev
179 2020-03-13T15:11:13  *** bitcoin-git has joined #bitcoin-core-dev
180 2020-03-13T15:11:13  <bitcoin-git> [bitcoin] instagibbs closed pull request #18343: Use min relay value constant in QT (master...qt_min_relay) https://github.com/bitcoin/bitcoin/pull/18343
181 2020-03-13T15:11:23  *** bitcoin-git has left #bitcoin-core-dev
182 2020-03-13T15:13:25  *** ddustin has quit IRC
183 2020-03-13T15:18:17  *** jungnam has joined #bitcoin-core-dev
184 2020-03-13T15:19:20  *** bitcoin-git has joined #bitcoin-core-dev
185 2020-03-13T15:19:20  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18345: test: Bump timeouts to avoid valgrind failures (master...2003-qaBumpTimeoutsAgain) https://github.com/bitcoin/bitcoin/pull/18345
186 2020-03-13T15:19:21  *** bitcoin-git has left #bitcoin-core-dev
187 2020-03-13T15:21:18  *** captjakk has joined #bitcoin-core-dev
188 2020-03-13T15:23:21  *** captjakk has quit IRC
189 2020-03-13T15:23:34  *** captjakk has joined #bitcoin-core-dev
190 2020-03-13T16:12:16  *** SiAnDoG__ has joined #bitcoin-core-dev
191 2020-03-13T16:13:42  *** SiAnDoG_ has quit IRC
192 2020-03-13T16:17:58  *** jarthur has quit IRC
193 2020-03-13T16:23:36  *** ddustin has joined #bitcoin-core-dev
194 2020-03-13T16:27:09  *** promag has joined #bitcoin-core-dev
195 2020-03-13T16:28:37  *** ddustin has quit IRC
196 2020-03-13T16:38:27  *** justanotheruser has quit IRC
197 2020-03-13T16:47:45  *** emilengler has joined #bitcoin-core-dev
198 2020-03-13T16:50:53  *** mol has joined #bitcoin-core-dev
199 2020-03-13T17:03:56  *** promag has quit IRC
200 2020-03-13T17:10:12  *** promag has joined #bitcoin-core-dev
201 2020-03-13T17:15:00  *** kljasdfvv has quit IRC
202 2020-03-13T17:17:27  *** dviola has quit IRC
203 2020-03-13T17:24:33  *** lnostdal has quit IRC
204 2020-03-13T17:25:09  *** AaronvanW has quit IRC
205 2020-03-13T17:27:04  <emilengler> Does strprintf jusnt formats the string or also translates?
206 2020-03-13T17:45:27  *** berndj has quit IRC
207 2020-03-13T17:50:43  *** jonatack has quit IRC
208 2020-03-13T17:51:54  *** jonatack has joined #bitcoin-core-dev
209 2020-03-13T17:54:25  *** emilengler has quit IRC
210 2020-03-13T17:54:38  <fjahr> emilengler: you give the translated string to strprintf, example: https://github.com/bitcoin/bitcoin/blob/master/src/wallet/wallet.cpp#L3783
211 2020-03-13T18:00:01  *** jungnam has quit IRC
212 2020-03-13T18:03:21  *** AaronvanW has joined #bitcoin-core-dev
213 2020-03-13T18:18:39  *** mdunnio has quit IRC
214 2020-03-13T18:21:57  *** Ultifest2 has joined #bitcoin-core-dev
215 2020-03-13T18:25:36  <wumpus> strprintf is simply an alias for tfm::format, it doesn't perform any kind of translation
216 2020-03-13T18:26:07  <wumpus> luckily not; most of its uses are, and should be, completely independent of locale
217 2020-03-13T18:26:56  <sipa> it uses c++ stream formatting under the hood though, so it could be affected by changing the c++ global locale (which afaik we don't do)
218 2020-03-13T18:27:11  <wumpus> oh no...
219 2020-03-13T18:27:21  * wumpus wants to really never use C++ again
220 2020-03-13T18:27:28  *** berndj has joined #bitcoin-core-dev
221 2020-03-13T18:27:28  <sipa> haha
222 2020-03-13T18:28:29  <wumpus> I really thought we had avoided that but it's worse every time
223 2020-03-13T18:29:17  <wumpus> in any case, it doesn't translate ...
224 2020-03-13T18:29:24  <sipa> yes!
225 2020-03-13T18:30:46  *** AaronvanW has quit IRC
226 2020-03-13T18:31:31  *** AaronvanW has joined #bitcoin-core-dev
227 2020-03-13T18:35:30  *** sipsorcery has quit IRC
228 2020-03-13T18:38:17  *** sipsorcery has joined #bitcoin-core-dev
229 2020-03-13T18:45:46  *** jarthur has joined #bitcoin-core-dev
230 2020-03-13T18:51:12  <meshcollider> Reminder: wallet meeting in 10 mins :)
231 2020-03-13T18:53:24  *** mdunnio has joined #bitcoin-core-dev
232 2020-03-13T19:00:16  <meshcollider> #startmeeting
233 2020-03-13T19:00:16  <lightningbot> Meeting started Fri Mar 13 19:00:16 2020 UTC.  The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot.
234 2020-03-13T19:00:16  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
235 2020-03-13T19:00:24  <achow101> hi
236 2020-03-13T19:00:25  <sipa> hi
237 2020-03-13T19:00:26  <meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball ariard digi_james amiti fjahr
238 2020-03-13T19:00:27  <meshcollider> jeremyrubin emilengler jonatack hebasto jb55
239 2020-03-13T19:00:36  <jonatack> hi
240 2020-03-13T19:00:38  <meshcollider> topics?
241 2020-03-13T19:01:10  <sipa> i'm wondering how to integrate miniscript
242 2020-03-13T19:02:23  <achow101> how so?
243 2020-03-13T19:02:23  <meshcollider> #topic Miniscript Integration (sipa)
244 2020-03-13T19:02:46  <wumpus> hi
245 2020-03-13T19:03:04  <sipa> so the big question is what the relation between the miniscript c++ code/library i have, and its integration in core
246 2020-03-13T19:03:33  <sipa> as it's written currently, it relies on core's script.h and a few other utilities, to avoid code duplication
247 2020-03-13T19:03:53  <sipa> but that makes it harder to use as a standalone separate library (you'd need to copy files)
248 2020-03-13T19:04:59  <sipa> so i was wondering if it wouldn't be better to make it an actual standalone thing, which can be subtree'd or whatever instead, but is also fully functional on its own - even though that implies some code duplication
249 2020-03-13T19:05:44  <meshcollider> ( Link for reference: https://github.com/sipa/miniscript )
250 2020-03-13T19:05:51  <sipa> indeed
251 2020-03-13T19:06:17  <achow101> how much duplication would there be?
252 2020-03-13T19:06:44  <hebasto> hi
253 2020-03-13T19:06:49  <luke-jr> sipa: another possibility could be to make a library for script stuff, shared by both
254 2020-03-13T19:07:09  <sipa> luke-jr: right, that is a possibility - though probably pretty far off
255 2020-03-13T19:07:19  <sipa> achow101: at least CScript and all opcode definitions
256 2020-03-13T19:07:27  <sipa> there is probably more
257 2020-03-13T19:07:43  <achow101> would you need to have all opcodes though?
258 2020-03-13T19:08:07  <sipa> no, but i don't think that's a material distinction
259 2020-03-13T19:08:46  <wumpus> if it's going to be consensus code, it would be good to avoid code duplication and aim for tight integration into bitcoin core, I think
260 2020-03-13T19:09:10  <sipa> none of this should ever need to be consensus code
261 2020-03-13T19:09:11  <ryanofsky> how would the duplication work? would there be functions to convert one cscript struct to the other?
262 2020-03-13T19:09:24  <wumpus> okay, then that's not an issue
263 2020-03-13T19:09:56  <sipa> ryanofsky: right, by treating them as byte arrays
264 2020-03-13T19:10:02  <wumpus> I was just afraid of ballooning complexity of some things, which are already complex to test/verify/ by having them multiple times
265 2020-03-13T19:10:07  <sipa> which they affectively are
266 2020-03-13T19:10:32  <wumpus> yes, CScript is effectively a byte array, wasn't there a PR to separate the script functions from the storage?
267 2020-03-13T19:10:35  <ryanofsky> is the serialization framework duplicated too?
268 2020-03-13T19:10:36  <achow101> sipa: that would seem to make other areas more complicated where conversions between miniscript's cscript and core's cscript are necessary
269 2020-03-13T19:10:48  <sipa> #13062
270 2020-03-13T19:10:52  <gribble> https://github.com/bitcoin/bitcoin/issues/13062 | Make script interpreter independent from storage type CScript by sipa · Pull Request #13062 · bitcoin/bitcoin · GitHub
271 2020-03-13T19:10:53  <wumpus> right
272 2020-03-13T19:11:09  <sipa> ryanofsky: no, the serialization framework isn't used internally to script
273 2020-03-13T19:11:20  <meshcollider> The alternative is to just include the miniscript code directly into core right?
274 2020-03-13T19:11:43  <luke-jr> could always split it out later :x
275 2020-03-13T19:11:56  <sipa> yeah, better reusable generic script code would be useful
276 2020-03-13T19:12:04  <luke-jr> (eg, when we finally split out the wallet)
277 2020-03-13T19:12:08  <sipa> and as luke-jr suggested, maybe the miniscript logic could evolve into that
278 2020-03-13T19:12:33  <sipa> (which i guess would mean we keep the existing CScript or a stripped-down version of it in consensus, but not for signing/... etc)
279 2020-03-13T19:12:52  <achow101> would it be possible to just have it link against core's cscript while still keeping miniscript's cscript when people want to use it as a separate library?
280 2020-03-13T19:13:17  <wumpus> I was about to say, the advantage of duplication in this case wouldb e that no code affecting consensus needs to be changed for something not affecting consensus
281 2020-03-13T19:13:27  <sipa> achow101: maybe- but i'm not sure there is much benefit to that
282 2020-03-13T19:13:41  <sipa> because now you need to test miniscript with both
283 2020-03-13T19:14:15  <sipa> ryanofsky: actually the code i have right now does copy serialize.h, though if i remember correctly it's just because CScript's serializers need it, despite not being used
284 2020-03-13T19:15:04  <sipa> maybe i should just try to make it something independent, and see how bad it is
285 2020-03-13T19:15:22  <luke-jr> make it a dependency of the library, and only support using it within Core for now?
286 2020-03-13T19:16:30  <sipa> the same code is used for the policy compiler i have on my site
287 2020-03-13T19:16:43  <luke-jr> (eg, so other code using the library needs to provide a compatible CScript)
288 2020-03-13T19:17:00  <sipa> that's what i'm doing now, but it's kinda painful
289 2020-03-13T19:17:09  <sipa> especially to keep the library itself testable
290 2020-03-13T19:18:44  <luke-jr> sounds like something to fix in the test framework / build system
291 2020-03-13T19:18:44  <luke-jr> or at least fixable
292 2020-03-13T19:19:23  <sipa> i don't think having 2 separate CScript-and-opcodes implementations is beneficial
293 2020-03-13T19:19:36  <sipa> they're effectively trivial modulus, with only boilerplate code
294 2020-03-13T19:20:15  <sipa> if somehow one side of things needs to provide a compatible interface, it would just copy it
295 2020-03-13T19:20:39  <achow101> how about we integrate miniscript into core, then library-ize script, and then library-ize miniscript?
296 2020-03-13T19:20:53  <sipa> achow101: so also include the policy compiler in core?
297 2020-03-13T19:21:12  <achow101> sure
298 2020-03-13T19:21:23  <sipa> i'm not opposed to that, but i'm not sure it's the right approach
299 2020-03-13T19:22:38  <meshcollider> Mhm I think trying to make miniscript independent first and seeing how it goes would be better
300 2020-03-13T19:23:46  <sipa> i think i prefer that- especially the idea that it could perhaps evolve into something of a "non-consensus script subtree" is appealing
301 2020-03-13T19:24:36  <sipa> any other topics?
302 2020-03-13T19:25:57  <sipa> meshcollider: intro to hyperelliptic curves?
303 2020-03-13T19:26:07  <achow101> ha
304 2020-03-13T19:26:32  <meshcollider> sipa: lol someone already wrote a blog post about it so I don't need to :p
305 2020-03-13T19:26:50  <sipa> i know :)
306 2020-03-13T19:27:05  <meshcollider> achow101 any other reviews/merge begs for me to add to my to-do list for the next 2 days?
307 2020-03-13T19:27:22  <achow101> meshcollider: every PR i have open :)
308 2020-03-13T19:27:24  <jonatack> any last-minute feature freeze reviews? i'll be doing those this weekend
309 2020-03-13T19:27:38  <achow101> meshcollider: #18204
310 2020-03-13T19:27:42  <gribble> https://github.com/bitcoin/bitcoin/issues/18204 | descriptors: improve descriptor cache and cache xpubs by achow101 · Pull Request #18204 · bitcoin/bitcoin · GitHub
311 2020-03-13T19:27:54  <meshcollider> Yeah I already have that one down :p
312 2020-03-13T19:28:25  <achow101> #16946 and #16463 are both tagged 0.20 but neither have gotten review, so I don't think they'll make it
313 2020-03-13T19:28:26  <gribble> https://github.com/bitcoin/bitcoin/issues/16946 | wallet: include a checksum of encrypted private keys by achow101 · Pull Request #16946 · bitcoin/bitcoin · GitHub
314 2020-03-13T19:28:28  <gribble> https://github.com/bitcoin/bitcoin/issues/16463 | [BIP 174] Implement serialization support for GLOBAL_XPUB field. by achow101 · Pull Request #16463 · bitcoin/bitcoin · GitHub
315 2020-03-13T19:28:59  <jonatack> maybe #17509
316 2020-03-13T19:29:02  <gribble> https://github.com/bitcoin/bitcoin/issues/17509 | gui: save and load PSBT by Sjors · Pull Request #17509 · bitcoin/bitcoin · GitHub
317 2020-03-13T19:29:19  *** bitcoin-git has joined #bitcoin-core-dev
318 2020-03-13T19:29:19  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18346: rpc: Document an RPCResult for all calls; Enforce at compile time (master...2003-docAllRpcRes) https://github.com/bitcoin/bitcoin/pull/18346
319 2020-03-13T19:29:20  *** bitcoin-git has left #bitcoin-core-dev
320 2020-03-13T19:29:28  <achow101> 17509 would be nice to have for 0.20
321 2020-03-13T19:29:34  <meshcollider> Yep 17509 is very nice
322 2020-03-13T19:29:50  <meshcollider> Ok that's all for the meeting then
323 2020-03-13T19:29:56  <meshcollider> #endmeeting
324 2020-03-13T19:29:56  <lightningbot> Meeting ended Fri Mar 13 19:29:56 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
325 2020-03-13T19:29:56  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-03-13-19.00.html
326 2020-03-13T19:29:56  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-03-13-19.00.txt
327 2020-03-13T19:29:56  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-03-13-19.00.log.html
328 2020-03-13T19:32:39  <meshcollider> sipa: I'm updating the paper at the moment btw, at the moment I'm trying to create a convincing argument that for large prime field order, the proportion of non-simple isogeny classes of Jacobians is pretty negligible (those which cover an elliptic curve)
329 2020-03-13T19:33:09  *** Guyver2_ is now known as Guyver2
330 2020-03-13T19:34:07  <sipa> :)
331 2020-03-13T19:43:43  *** vasild has quit IRC
332 2020-03-13T19:45:16  *** ekrok has joined #bitcoin-core-dev
333 2020-03-13T19:45:43  *** vasild has joined #bitcoin-core-dev
334 2020-03-13T20:07:16  *** promag has quit IRC
335 2020-03-13T20:07:56  *** jarthur has quit IRC
336 2020-03-13T20:11:11  *** jarthur has joined #bitcoin-core-dev
337 2020-03-13T20:12:27  *** jarthur has quit IRC
338 2020-03-13T20:21:34  <achow101> meshcollider: do you think we can get #17681 into 0.20? it's kind of a bug fix, kind of a feature
339 2020-03-13T20:21:37  <gribble> https://github.com/bitcoin/bitcoin/issues/17681 | wallet: Keep inactive seeds after sethdseed and derive keys from them as needed by achow101 · Pull Request #17681 · bitcoin/bitcoin · GitHub
340 2020-03-13T20:25:44  <meshcollider> Um it's not looking good since it only has concept ACKs
341 2020-03-13T20:26:22  <meshcollider> Depends if you can bribe enough people for a fast review today/tomorrow :p
342 2020-03-13T20:26:40  <sipa> if it's a bug fix it can go in after the feature freeze
343 2020-03-13T20:28:27  <meshcollider> Im not sure it's really bug-fix-y enough to be a "bugfix"?
344 2020-03-13T20:29:58  <meshcollider> Ok yeah why not, its a good change, I think we can get it in
345 2020-03-13T20:36:54  *** promag has joined #bitcoin-core-dev
346 2020-03-13T20:40:36  *** mdunnio has quit IRC
347 2020-03-13T20:42:29  *** captjakk has quit IRC
348 2020-03-13T20:43:04  *** captjakk has joined #bitcoin-core-dev
349 2020-03-13T20:45:50  *** mdunnio has joined #bitcoin-core-dev
350 2020-03-13T20:46:52  *** captjakk has quit IRC
351 2020-03-13T20:47:08  *** captjakk has joined #bitcoin-core-dev
352 2020-03-13T20:49:35  *** promag has quit IRC
353 2020-03-13T20:50:08  *** promag has joined #bitcoin-core-dev
354 2020-03-13T20:50:11  *** captjakk has quit IRC
355 2020-03-13T20:50:34  *** captjakk has joined #bitcoin-core-dev
356 2020-03-13T20:51:00  <instagibbs> oh yeah meeting stuff
357 2020-03-13T20:51:44  <instagibbs> I'd prefer subtree or something for miniscript, just for the "let's not touch consensus" reasons
358 2020-03-13T20:52:03  <instagibbs> and #17509 is quite easy to test and would be nice, please review :)
359 2020-03-13T20:52:06  <gribble> https://github.com/bitcoin/bitcoin/issues/17509 | gui: save and load PSBT by Sjors · Pull Request #17509 · bitcoin/bitcoin · GitHub
360 2020-03-13T20:52:55  <sipa> instagibbs: to be clear, i don't think any of this, regardless of what approach is used, should ever affect consensus code
361 2020-03-13T20:53:17  <instagibbs> of course
362 2020-03-13T20:53:31  <instagibbs> I guess I just think it'd be cleaner to be a separate project :shrug:
363 2020-03-13T20:53:41  <instagibbs> s/proj/repo/
364 2020-03-13T20:54:07  <sipa> yeah, i think so too
365 2020-03-13T20:56:57  <instagibbs> You may also get a bit more downstream usage/contribution/feedback that way too if it's really a library
366 2020-03-13T20:57:09  *** bitcoin-git has joined #bitcoin-core-dev
367 2020-03-13T20:57:09  <bitcoin-git> [bitcoin] jnewbery closed pull request #17485: WIP: net processing: Don't reach into CBlockIndex to check for block mutation (master...2019-11-processnewblock-early-return2) https://github.com/bitcoin/bitcoin/pull/17485
368 2020-03-13T20:57:19  *** bitcoin-git has left #bitcoin-core-dev
369 2020-03-13T20:57:55  *** emilengler has joined #bitcoin-core-dev
370 2020-03-13T20:58:04  *** bitcoin-git has joined #bitcoin-core-dev
371 2020-03-13T20:58:04  <bitcoin-git> [bitcoin] jnewbery closed pull request #17562: WIP: Validation: Remove ConnectTrace and PerBlockConnectTrace (master...2019-11-remove-connect-trace) https://github.com/bitcoin/bitcoin/pull/17562
372 2020-03-13T20:58:06  *** bitcoin-git has left #bitcoin-core-dev
373 2020-03-13T21:00:02  *** Ultifest2 has quit IRC
374 2020-03-13T21:00:05  <instagibbs> I would like a real C++ miniscript library :)
375 2020-03-13T21:03:46  *** dviola has joined #bitcoin-core-dev
376 2020-03-13T21:04:26  *** dviola has joined #bitcoin-core-dev
377 2020-03-13T21:19:15  *** dviola has left #bitcoin-core-dev
378 2020-03-13T21:19:33  *** dviola has joined #bitcoin-core-dev
379 2020-03-13T21:20:19  *** dviola has left #bitcoin-core-dev
380 2020-03-13T21:20:35  *** dviola has joined #bitcoin-core-dev
381 2020-03-13T21:21:34  *** kermit1 has joined #bitcoin-core-dev
382 2020-03-13T21:22:43  *** dviola has left #bitcoin-core-dev
383 2020-03-13T21:22:59  *** dviola has joined #bitcoin-core-dev
384 2020-03-13T21:23:05  <jnewbery> #18002 has 6 ACKs. I think it's good for merge
385 2020-03-13T21:23:07  <gribble> https://github.com/bitcoin/bitcoin/issues/18002 | Abstract out script execution out of VerifyWitnessProgram() by sipa · Pull Request #18002 · bitcoin/bitcoin · GitHub
386 2020-03-13T21:26:54  <jnewbery> #16902 also has 5 ACKs and should be RFM
387 2020-03-13T21:26:57  <gribble> https://github.com/bitcoin/bitcoin/issues/16902 | O(1) OP_IF/NOTIF/ELSE/ENDIF script implementation by sipa · Pull Request #16902 · bitcoin/bitcoin · GitHub
388 2020-03-13T21:27:16  <jnewbery> (I left some comment nits on 16902 which can easily be added in a follow-up PR if people think they're helpful)
389 2020-03-13T21:28:07  *** dviola has quit IRC
390 2020-03-13T21:31:20  *** bitcoin-git has joined #bitcoin-core-dev
391 2020-03-13T21:31:21  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3f9e6a3c1ce8...e5cb0dffd5ac
392 2020-03-13T21:31:21  <bitcoin-git> bitcoin/master c8e24dd Pieter Wuille: [REFACTOR] Abstract out script execution out of VerifyWitnessProgram()
393 2020-03-13T21:31:22  <bitcoin-git> bitcoin/master e5cb0df Wladimir J. van der Laan: Merge #18002: Abstract out script execution out of VerifyWitnessProgram()
394 2020-03-13T21:31:26  *** bitcoin-git has left #bitcoin-core-dev
395 2020-03-13T21:31:45  *** bitcoin-git has joined #bitcoin-core-dev
396 2020-03-13T21:31:45  <bitcoin-git> [bitcoin] laanwj merged pull request #18002: Abstract out script execution out of VerifyWitnessProgram() (master...202001_execute_witness) https://github.com/bitcoin/bitcoin/pull/18002
397 2020-03-13T21:31:46  *** bitcoin-git has left #bitcoin-core-dev
398 2020-03-13T21:31:58  *** dviola has joined #bitcoin-core-dev
399 2020-03-13T21:33:01  *** Guyver2 has quit IRC
400 2020-03-13T21:36:45  *** sipsorcery has quit IRC
401 2020-03-13T21:37:52  <ysangkok> instagibbs: when you say "real library", does that include version numbers and API/ABI stability? ;)
402 2020-03-13T21:38:52  <sipa> one problem with doing so at this point that it'd need reviewers...
403 2020-03-13T21:45:35  *** bitcoin-git has joined #bitcoin-core-dev
404 2020-03-13T21:45:35  <bitcoin-git> [bitcoin] laanwj pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/e5cb0dffd5ac...7f8176a1ebd0
405 2020-03-13T21:45:36  <bitcoin-git> bitcoin/master 474ea3b Andrew Chow: Introduce DescriptorCache struct which caches xpubs
406 2020-03-13T21:45:36  <bitcoin-git> bitcoin/master df55d44 Andrew Chow: Track the index of the key expression in PubkeyProvider
407 2020-03-13T21:45:37  <bitcoin-git> bitcoin/master 66c2cad Andrew Chow: Rename BIP32PubkeyProvider.m_extkey to m_root_extkey
408 2020-03-13T21:45:38  *** bitcoin-git has left #bitcoin-core-dev
409 2020-03-13T21:46:13  *** bitcoin-git has joined #bitcoin-core-dev
410 2020-03-13T21:46:14  <bitcoin-git> [bitcoin] laanwj merged pull request #18204: descriptors: improve descriptor cache and cache xpubs (master...desc-xpub-cache) https://github.com/bitcoin/bitcoin/pull/18204
411 2020-03-13T21:46:15  *** bitcoin-git has left #bitcoin-core-dev
412 2020-03-13T21:47:14  *** Talkless has joined #bitcoin-core-dev
413 2020-03-13T21:47:52  *** emilengler has quit IRC
414 2020-03-13T21:48:05  *** emilengler has joined #bitcoin-core-dev
415 2020-03-13T21:48:17  *** emilengler has joined #bitcoin-core-dev
416 2020-03-13T21:50:58  <aj> instagibbs: c++, not c or rust?
417 2020-03-13T21:53:26  *** commavir has quit IRC
418 2020-03-13T21:54:05  <achow101> \o/ I think there's no pre-reqs left for descriptor wallets
419 2020-03-13T21:55:10  *** bitcoin-git has joined #bitcoin-core-dev
420 2020-03-13T21:55:11  <bitcoin-git> [bitcoin] joe-rodgers opened pull request #18347: Update all occurences of 2009-2019 to be 2009-2020 (master...master) https://github.com/bitcoin/bitcoin/pull/18347
421 2020-03-13T21:55:12  *** bitcoin-git has left #bitcoin-core-dev
422 2020-03-13T21:55:41  <sipa> aj: one challenge is that so far it has seemed very useful to have miniscript types with parametrized key types (in the compiler they're strings, in signing logic they're CKeyIDs, in descriptors they're pubkey expressions...), which seems hard to accomodate with a simple C-callable API
423 2020-03-13T22:03:52  <jonatack> achow101: hoorah! :)
424 2020-03-13T22:04:05  <luke-jr> instagibbs: non-consensus shouldn't be subtreed at all, though we might have to in this case
425 2020-03-13T22:05:22  <sipa> luke-jr: well it'd be pretty much a headers-only library anyway, there wouldn't really be anything to dynamically link
426 2020-03-13T22:05:32  <luke-jr> :x
427 2020-03-13T22:05:50  <luke-jr> metaprogramming/templates kinda do force static linking by nature
428 2020-03-13T22:05:52  <sipa> (that doesn't mean it needs to be subtreed, but the advantages of not doing it go down significantly)
429 2020-03-13T22:08:08  *** MrSquanchee has quit IRC
430 2020-03-13T22:08:27  *** manantial has quit IRC
431 2020-03-13T22:10:59  *** justanotheruser has joined #bitcoin-core-dev
432 2020-03-13T22:18:24  *** bitcoin-git has joined #bitcoin-core-dev
433 2020-03-13T22:18:24  <bitcoin-git> [bitcoin] fanquake closed pull request #18347: Update all occurences of 2009-2019 to be 2009-2020 (master...master) https://github.com/bitcoin/bitcoin/pull/18347
434 2020-03-13T22:18:25  *** bitcoin-git has left #bitcoin-core-dev
435 2020-03-13T22:30:39  *** captjakk has quit IRC
436 2020-03-13T22:31:13  *** captjakk has joined #bitcoin-core-dev
437 2020-03-13T22:32:40  *** sipsorcery has joined #bitcoin-core-dev
438 2020-03-13T22:35:43  *** captjakk has quit IRC
439 2020-03-13T22:38:51  *** sipsorcery has quit IRC
440 2020-03-13T22:43:55  *** timothy has quit IRC
441 2020-03-13T22:48:59  *** captjakk has joined #bitcoin-core-dev
442 2020-03-13T23:02:53  *** sipsorcery has joined #bitcoin-core-dev
443 2020-03-13T23:07:38  *** captjakk has quit IRC
444 2020-03-13T23:08:11  *** captjakk has joined #bitcoin-core-dev
445 2020-03-13T23:12:35  *** captjakk has quit IRC
446 2020-03-13T23:15:02  *** Talkless has quit IRC
447 2020-03-13T23:19:07  *** commavir has joined #bitcoin-core-dev
448 2020-03-13T23:26:32  *** filchef has quit IRC
449 2020-03-13T23:29:11  *** molly has joined #bitcoin-core-dev
450 2020-03-13T23:31:15  *** mol has quit IRC
451 2020-03-13T23:38:08  *** sipsorcery has quit IRC
452 2020-03-13T23:38:30  *** sipsorcery has joined #bitcoin-core-dev
453 2020-03-13T23:41:54  *** mdunnio has quit IRC
454 2020-03-13T23:44:39  *** captjakk has joined #bitcoin-core-dev
455 2020-03-13T23:49:26  *** captjakk has quit IRC
456 2020-03-13T23:56:06  *** justanotheruser has quit IRC
457 2020-03-13T23:56:55  *** sipsorcery has quit IRC
458 2020-03-13T23:57:26  *** emilengler has quit IRC
459 2020-03-13T23:59:14  *** jonatack has quit IRC