12020-03-13T00:00:02  *** sirkitree has quit IRC
  22020-03-13T00:00:54  *** rjected has joined #bitcoin-core-dev
  32020-03-13T00:03:10  *** braydonf has quit IRC
  42020-03-13T00:03:51  *** braydonf has joined #bitcoin-core-dev
  52020-03-13T00:06:07  *** achow101 has joined #bitcoin-core-dev
  62020-03-13T00:18:28  *** paxed1 has joined #bitcoin-core-dev
  72020-03-13T00:24:28  *** braydonf has quit IRC
  82020-03-13T00:26:17  *** MrSquanchee has joined #bitcoin-core-dev
  92020-03-13T00:27:22  *** sonofhan has joined #bitcoin-core-dev
 102020-03-13T00:27:57  *** sonofhan has quit IRC
 112020-03-13T00:28:29  *** sonofhan has joined #bitcoin-core-dev
 122020-03-13T00:29:29  *** marcoagner has quit IRC
 132020-03-13T00:36:28  *** pinheadmz_ has joined #bitcoin-core-dev
 142020-03-13T00:38:28  *** provoostenator has quit IRC
 152020-03-13T00:39:15  *** pinheadmz has quit IRC
 162020-03-13T00:39:15  *** pinheadmz_ is now known as pinheadmz
 172020-03-13T00:45:13  *** braydonf has joined #bitcoin-core-dev
 182020-03-13T00:45:44  *** provoostenator has joined #bitcoin-core-dev
 192020-03-13T00:48:21  *** dr-orlovsky has joined #bitcoin-core-dev
 202020-03-13T01:13:59  *** DeanGuss has joined #bitcoin-core-dev
 212020-03-13T01:21:33  *** belcher has quit IRC
 222020-03-13T01:26:55  *** I_LIKE_FREE has quit IRC
 232020-03-13T01:28:22  *** dr-orlovsky has quit IRC
 242020-03-13T01:30:18  *** captjakk has joined #bitcoin-core-dev
 252020-03-13T01:37:38  *** bitcoin-git has joined #bitcoin-core-dev
 262020-03-13T01:37:38  <bitcoin-git> [bitcoin] promag opened pull request #18338: wip: Fix wallet unload race condition (master...notify-shared) https://github.com/bitcoin/bitcoin/pull/18338
 272020-03-13T01:37:40  *** bitcoin-git has left #bitcoin-core-dev
 282020-03-13T01:38:15  *** pinheadmz has quit IRC
 292020-03-13T01:53:03  *** DeanGuss has quit IRC
 302020-03-13T01:57:43  *** AaronvanW has quit IRC
 312020-03-13T02:01:54  *** bitcoin-git has joined #bitcoin-core-dev
 322020-03-13T02:01:54  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18337: init: Remove boost::thread_group (master...2003-NoBoostThreadGroup) https://github.com/bitcoin/bitcoin/pull/18337
 332020-03-13T02:01:55  *** bitcoin-git has left #bitcoin-core-dev
 342020-03-13T02:11:43  *** mdunnio has joined #bitcoin-core-dev
 352020-03-13T02:14:44  *** promag has quit IRC
 362020-03-13T02:19:53  *** bitcoin-git has joined #bitcoin-core-dev
 372020-03-13T02:19:53  <bitcoin-git> [bitcoin] gzhao408 opened pull request #18339: wip [test] multiple reject reasons for test_witness_block (master...test_witness_block-multiple-reasons) https://github.com/bitcoin/bitcoin/pull/18339
 382020-03-13T02:19:54  *** bitcoin-git has left #bitcoin-core-dev
 392020-03-13T02:23:57  *** promag has joined #bitcoin-core-dev
 402020-03-13T02:24:03  *** braydonf has quit IRC
 412020-03-13T02:24:23  *** bitcoin-git has joined #bitcoin-core-dev
 422020-03-13T02:24:24  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e2d36639ca87...3f9e6a3c1ce8
 432020-03-13T02:24:25  <bitcoin-git> bitcoin/master a33cffb Jon Atack: util: HelpExampleRpc formatting fixup
 442020-03-13T02:24:26  <bitcoin-git> bitcoin/master 3f9e6a3 fanquake: Merge #18316: util: HelpExampleRpc formatting
 452020-03-13T02:24:28  *** bitcoin-git has left #bitcoin-core-dev
 462020-03-13T02:24:28  *** braydonf has joined #bitcoin-core-dev
 472020-03-13T02:24:43  *** bitcoin-git has joined #bitcoin-core-dev
 482020-03-13T02:24:43  <bitcoin-git> [bitcoin] fanquake merged pull request #18316: util: HelpExampleRpc formatting (master...json-rpc-example-template-formatting) https://github.com/bitcoin/bitcoin/pull/18316
 492020-03-13T02:24:46  *** bitcoin-git has left #bitcoin-core-dev
 502020-03-13T02:24:57  *** braydonf has joined #bitcoin-core-dev
 512020-03-13T02:28:27  *** promag has quit IRC
 522020-03-13T02:28:36  *** rjected has quit IRC
 532020-03-13T02:30:40  *** braydonf has quit IRC
 542020-03-13T02:31:14  *** braydonf has joined #bitcoin-core-dev
 552020-03-13T02:32:55  *** AaronvanW has joined #bitcoin-core-dev
 562020-03-13T02:37:47  *** AaronvanW has quit IRC
 572020-03-13T02:43:31  *** mdunnio has quit IRC
 582020-03-13T03:00:02  *** paxed1 has quit IRC
 592020-03-13T03:07:03  <sipa> MarcoFalke: lol at your github profile picture
 602020-03-13T03:08:56  *** pinheadmz has joined #bitcoin-core-dev
 612020-03-13T03:10:39  *** krvopije has joined #bitcoin-core-dev
 622020-03-13T03:13:30  *** krvopije has quit IRC
 632020-03-13T03:17:30  *** dviola has joined #bitcoin-core-dev
 642020-03-13T03:17:37  *** UltimateNate has joined #bitcoin-core-dev
 652020-03-13T03:19:35  *** AaronvanW has joined #bitcoin-core-dev
 662020-03-13T03:19:44  *** sonofhan has quit IRC
 672020-03-13T03:26:08  *** Chris_Stewart_5 has quit IRC
 682020-03-13T03:26:53  *** bitcoin-git has joined #bitcoin-core-dev
 692020-03-13T03:26:53  <bitcoin-git> [bitcoin] fanquake opened pull request #18340: doc: mention MAKE=gmake workaround when building on a BSD (master...fixup_18129) https://github.com/bitcoin/bitcoin/pull/18340
 702020-03-13T03:26:54  *** bitcoin-git has left #bitcoin-core-dev
 712020-03-13T03:27:13  *** bitcoin-git has joined #bitcoin-core-dev
 722020-03-13T03:27:13  <bitcoin-git> [bitcoin] fanquake closed pull request #18129: Doc: Fix BSD docs regarding gmake (master...bsddocs) https://github.com/bitcoin/bitcoin/pull/18129
 732020-03-13T03:27:17  *** bitcoin-git has left #bitcoin-core-dev
 742020-03-13T03:30:29  *** provoostenator has quit IRC
 752020-03-13T03:31:44  *** provoostenator has joined #bitcoin-core-dev
 762020-03-13T03:39:59  *** provoostenator has quit IRC
 772020-03-13T03:41:14  *** provoostenator has joined #bitcoin-core-dev
 782020-03-13T03:41:42  *** felixfoertsch has joined #bitcoin-core-dev
 792020-03-13T03:42:03  *** felixfoertsch23 has quit IRC
 802020-03-13T03:46:14  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 812020-03-13T03:48:54  *** captjakk has quit IRC
 822020-03-13T03:49:28  *** captjakk has joined #bitcoin-core-dev
 832020-03-13T03:52:13  *** AaronvanW has quit IRC
 842020-03-13T03:53:39  *** captjakk has quit IRC
 852020-03-13T03:56:18  *** Highway61 has quit IRC
 862020-03-13T04:06:44  *** hadjiszs has joined #bitcoin-core-dev
 872020-03-13T04:12:25  *** Chris_Stewart_5 has quit IRC
 882020-03-13T04:49:38  *** bitcoin-git has joined #bitcoin-core-dev
 892020-03-13T04:49:38  <bitcoin-git> [bitcoin] fanquake closed pull request #16083: [WIP] transaction fees in getblock (master...201905_grt_prevout) https://github.com/bitcoin/bitcoin/pull/16083
 902020-03-13T04:49:40  *** bitcoin-git has left #bitcoin-core-dev
 912020-03-13T05:03:03  *** achow101 has quit IRC
 922020-03-13T05:12:57  *** achow101 has joined #bitcoin-core-dev
 932020-03-13T05:39:50  *** anditto has joined #bitcoin-core-dev
 942020-03-13T05:49:32  *** AaronvanW has joined #bitcoin-core-dev
 952020-03-13T05:55:37  *** achow101_ has joined #bitcoin-core-dev
 962020-03-13T05:56:56  *** achow101 has quit IRC
 972020-03-13T05:58:18  *** anditto has quit IRC
 982020-03-13T05:58:45  *** anditto has joined #bitcoin-core-dev
 992020-03-13T06:00:02  *** UltimateNate has quit IRC
1002020-03-13T06:03:18  *** anditto has quit IRC
1012020-03-13T06:19:45  *** Morgon1 has joined #bitcoin-core-dev
1022020-03-13T06:21:39  *** AaronvanW has quit IRC
1032020-03-13T06:30:56  *** achow101_ has quit IRC
1042020-03-13T06:31:48  *** achow101 has joined #bitcoin-core-dev
1052020-03-13T06:39:01  *** anditto has joined #bitcoin-core-dev
1062020-03-13T07:00:16  *** promag has joined #bitcoin-core-dev
1072020-03-13T07:04:46  *** promag has quit IRC
1082020-03-13T07:40:43  *** vasild_ has joined #bitcoin-core-dev
1092020-03-13T07:41:20  *** Deacyde has quit IRC
1102020-03-13T07:42:49  *** Deacyde has joined #bitcoin-core-dev
1112020-03-13T07:44:03  *** vasild has quit IRC
1122020-03-13T07:44:04  *** vasild_ is now known as vasild
1132020-03-13T07:45:36  *** ddustin has joined #bitcoin-core-dev
1142020-03-13T07:49:46  *** ddustin has quit IRC
1152020-03-13T08:11:22  *** sipsorcery has joined #bitcoin-core-dev
1162020-03-13T08:11:26  *** anditto has quit IRC
1172020-03-13T08:19:38  *** AaronvanW has joined #bitcoin-core-dev
1182020-03-13T08:33:54  *** lnostdal_ has joined #bitcoin-core-dev
1192020-03-13T08:46:51  *** bitcoin-git has joined #bitcoin-core-dev
1202020-03-13T08:46:51  <bitcoin-git> [bitcoin] promag closed pull request #18280: wallet: UnregisterValidationInterface before SyncWithValidationInterfaceQueue (master...2020-03-sync-unregistervalidationinterface) https://github.com/bitcoin/bitcoin/pull/18280
1212020-03-13T08:46:52  *** bitcoin-git has left #bitcoin-core-dev
1222020-03-13T08:53:13  *** AaronvanW has quit IRC
1232020-03-13T09:00:02  *** Morgon1 has quit IRC
1242020-03-13T09:04:33  *** marcoagner has joined #bitcoin-core-dev
1252020-03-13T09:16:17  *** promag has joined #bitcoin-core-dev
1262020-03-13T09:17:40  *** b0o has joined #bitcoin-core-dev
1272020-03-13T09:31:52  *** marcoagner has quit IRC
1282020-03-13T09:43:15  *** manantial has joined #bitcoin-core-dev
1292020-03-13T09:49:19  *** timothy has joined #bitcoin-core-dev
1302020-03-13T10:00:20  *** AaronvanW has joined #bitcoin-core-dev
1312020-03-13T10:14:33  *** MrSquanchee has quit IRC
1322020-03-13T10:16:34  *** hadjiszs has quit IRC
1332020-03-13T10:28:29  *** filchef has joined #bitcoin-core-dev
1342020-03-13T10:42:53  *** bitcoin-git has joined #bitcoin-core-dev
1352020-03-13T10:42:54  <bitcoin-git> [bitcoin] domob1812 opened pull request #18341: Replace remaining literal BTC with CURRENCY_UNIT. (master...currency-unit) https://github.com/bitcoin/bitcoin/pull/18341
1362020-03-13T10:42:55  *** bitcoin-git has left #bitcoin-core-dev
1372020-03-13T10:52:15  *** promag_ has joined #bitcoin-core-dev
1382020-03-13T10:52:15  *** promag has quit IRC
1392020-03-13T11:03:56  *** Dessie18Rosenbau has joined #bitcoin-core-dev
1402020-03-13T11:04:19  *** AaronvanW has quit IRC
1412020-03-13T11:08:24  *** sipsorcery has quit IRC
1422020-03-13T11:08:27  *** Dessie18Rosenbau has quit IRC
1432020-03-13T11:08:47  *** nullptr_ has quit IRC
1442020-03-13T11:09:49  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1452020-03-13T11:12:51  *** nullptr| has joined #bitcoin-core-dev
1462020-03-13T11:23:49  *** sipsorcery has joined #bitcoin-core-dev
1472020-03-13T11:27:55  *** shigeya has quit IRC
1482020-03-13T11:28:45  *** shigeya has joined #bitcoin-core-dev
1492020-03-13T11:31:26  *** promag_ has quit IRC
1502020-03-13T11:42:42  *** AaronvanW has joined #bitcoin-core-dev
1512020-03-13T11:46:01  *** Guyver2 has joined #bitcoin-core-dev
1522020-03-13T12:00:01  *** b0o has quit IRC
1532020-03-13T12:14:21  *** belcher has joined #bitcoin-core-dev
1542020-03-13T12:42:46  *** bitcoin-git has joined #bitcoin-core-dev
1552020-03-13T12:42:46  <bitcoin-git> [bitcoin] practicalswift opened pull request #18342: doc: Add fuzzing quickstart guide (master...fuzzing-quick-start-guide) https://github.com/bitcoin/bitcoin/pull/18342
1562020-03-13T12:42:47  *** bitcoin-git has left #bitcoin-core-dev
1572020-03-13T12:51:07  *** kaeru has joined #bitcoin-core-dev
1582020-03-13T13:10:09  *** mdunnio has joined #bitcoin-core-dev
1592020-03-13T13:10:15  *** mdunnio has quit IRC
1602020-03-13T13:17:17  *** jarthur has joined #bitcoin-core-dev
1612020-03-13T13:40:48  *** mdunnio has joined #bitcoin-core-dev
1622020-03-13T13:55:38  *** bitcoin-git has joined #bitcoin-core-dev
1632020-03-13T13:55:38  <bitcoin-git> [bitcoin] instagibbs opened pull request #18343: Use min relay value constant in QT (master...qt_min_relay) https://github.com/bitcoin/bitcoin/pull/18343
1642020-03-13T13:55:39  *** bitcoin-git has left #bitcoin-core-dev
1652020-03-13T14:10:58  *** bitcoin-git has joined #bitcoin-core-dev
1662020-03-13T14:10:58  <bitcoin-git> [bitcoin] stevenroose opened pull request #18344: Fix nit in getblockchaininfo (master...nit-blockchaininfo) https://github.com/bitcoin/bitcoin/pull/18344
1672020-03-13T14:11:02  *** bitcoin-git has left #bitcoin-core-dev
1682020-03-13T14:24:28  *** Chris_Stewart_5 has quit IRC
1692020-03-13T14:29:26  *** spaced0ut has quit IRC
1702020-03-13T14:34:36  *** Guyver2_ has joined #bitcoin-core-dev
1712020-03-13T14:38:05  *** Guyver2 has quit IRC
1722020-03-13T14:44:56  *** mohammadbitcoina has joined #bitcoin-core-dev
1732020-03-13T14:46:13  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1742020-03-13T14:47:44  *** mol has quit IRC
1752020-03-13T15:00:02  *** kaeru has quit IRC
1762020-03-13T15:03:57  *** mohammadbitcoina has quit IRC
1772020-03-13T15:05:54  *** MrSquanchee has joined #bitcoin-core-dev
1782020-03-13T15:08:42  *** ddustin has joined #bitcoin-core-dev
1792020-03-13T15:11:13  *** bitcoin-git has joined #bitcoin-core-dev
1802020-03-13T15:11:13  <bitcoin-git> [bitcoin] instagibbs closed pull request #18343: Use min relay value constant in QT (master...qt_min_relay) https://github.com/bitcoin/bitcoin/pull/18343
1812020-03-13T15:11:23  *** bitcoin-git has left #bitcoin-core-dev
1822020-03-13T15:13:25  *** ddustin has quit IRC
1832020-03-13T15:18:17  *** jungnam has joined #bitcoin-core-dev
1842020-03-13T15:19:20  *** bitcoin-git has joined #bitcoin-core-dev
1852020-03-13T15:19:20  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18345: test: Bump timeouts to avoid valgrind failures (master...2003-qaBumpTimeoutsAgain) https://github.com/bitcoin/bitcoin/pull/18345
1862020-03-13T15:19:21  *** bitcoin-git has left #bitcoin-core-dev
1872020-03-13T15:21:18  *** captjakk has joined #bitcoin-core-dev
1882020-03-13T15:23:21  *** captjakk has quit IRC
1892020-03-13T15:23:34  *** captjakk has joined #bitcoin-core-dev
1902020-03-13T16:12:16  *** SiAnDoG__ has joined #bitcoin-core-dev
1912020-03-13T16:13:42  *** SiAnDoG_ has quit IRC
1922020-03-13T16:17:58  *** jarthur has quit IRC
1932020-03-13T16:23:36  *** ddustin has joined #bitcoin-core-dev
1942020-03-13T16:27:09  *** promag has joined #bitcoin-core-dev
1952020-03-13T16:28:37  *** ddustin has quit IRC
1962020-03-13T16:38:27  *** justanotheruser has quit IRC
1972020-03-13T16:47:45  *** emilengler has joined #bitcoin-core-dev
1982020-03-13T16:50:53  *** mol has joined #bitcoin-core-dev
1992020-03-13T17:03:56  *** promag has quit IRC
2002020-03-13T17:10:12  *** promag has joined #bitcoin-core-dev
2012020-03-13T17:15:00  *** kljasdfvv has quit IRC
2022020-03-13T17:17:27  *** dviola has quit IRC
2032020-03-13T17:24:33  *** lnostdal has quit IRC
2042020-03-13T17:25:09  *** AaronvanW has quit IRC
2052020-03-13T17:27:04  <emilengler> Does strprintf jusnt formats the string or also translates?
2062020-03-13T17:45:27  *** berndj has quit IRC
2072020-03-13T17:50:43  *** jonatack has quit IRC
2082020-03-13T17:51:54  *** jonatack has joined #bitcoin-core-dev
2092020-03-13T17:54:25  *** emilengler has quit IRC
2102020-03-13T17:54:38  <fjahr> emilengler: you give the translated string to strprintf, example: https://github.com/bitcoin/bitcoin/blob/master/src/wallet/wallet.cpp#L3783
2112020-03-13T18:00:01  *** jungnam has quit IRC
2122020-03-13T18:03:21  *** AaronvanW has joined #bitcoin-core-dev
2132020-03-13T18:18:39  *** mdunnio has quit IRC
2142020-03-13T18:21:57  *** Ultifest2 has joined #bitcoin-core-dev
2152020-03-13T18:25:36  <wumpus> strprintf is simply an alias for tfm::format, it doesn't perform any kind of translation
2162020-03-13T18:26:07  <wumpus> luckily not; most of its uses are, and should be, completely independent of locale
2172020-03-13T18:26:56  <sipa> it uses c++ stream formatting under the hood though, so it could be affected by changing the c++ global locale (which afaik we don't do)
2182020-03-13T18:27:11  <wumpus> oh no...
2192020-03-13T18:27:21  * wumpus wants to really never use C++ again
2202020-03-13T18:27:28  *** berndj has joined #bitcoin-core-dev
2212020-03-13T18:27:28  <sipa> haha
2222020-03-13T18:28:29  <wumpus> I really thought we had avoided that but it's worse every time
2232020-03-13T18:29:17  <wumpus> in any case, it doesn't translate ...
2242020-03-13T18:29:24  <sipa> yes!
2252020-03-13T18:30:46  *** AaronvanW has quit IRC
2262020-03-13T18:31:31  *** AaronvanW has joined #bitcoin-core-dev
2272020-03-13T18:35:30  *** sipsorcery has quit IRC
2282020-03-13T18:38:17  *** sipsorcery has joined #bitcoin-core-dev
2292020-03-13T18:45:46  *** jarthur has joined #bitcoin-core-dev
2302020-03-13T18:51:12  <meshcollider> Reminder: wallet meeting in 10 mins :)
2312020-03-13T18:53:24  *** mdunnio has joined #bitcoin-core-dev
2322020-03-13T19:00:16  <meshcollider> #startmeeting
2332020-03-13T19:00:16  <lightningbot> Meeting started Fri Mar 13 19:00:16 2020 UTC.  The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot.
2342020-03-13T19:00:16  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
2352020-03-13T19:00:24  <achow101> hi
2362020-03-13T19:00:25  <sipa> hi
2372020-03-13T19:00:26  <meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball ariard digi_james amiti fjahr
2382020-03-13T19:00:27  <meshcollider> jeremyrubin emilengler jonatack hebasto jb55
2392020-03-13T19:00:36  <jonatack> hi
2402020-03-13T19:00:38  <meshcollider> topics?
2412020-03-13T19:01:10  <sipa> i'm wondering how to integrate miniscript
2422020-03-13T19:02:23  <achow101> how so?
2432020-03-13T19:02:23  <meshcollider> #topic Miniscript Integration (sipa)
2442020-03-13T19:02:46  <wumpus> hi
2452020-03-13T19:03:04  <sipa> so the big question is what the relation between the miniscript c++ code/library i have, and its integration in core
2462020-03-13T19:03:33  <sipa> as it's written currently, it relies on core's script.h and a few other utilities, to avoid code duplication
2472020-03-13T19:03:53  <sipa> but that makes it harder to use as a standalone separate library (you'd need to copy files)
2482020-03-13T19:04:59  <sipa> so i was wondering if it wouldn't be better to make it an actual standalone thing, which can be subtree'd or whatever instead, but is also fully functional on its own - even though that implies some code duplication
2492020-03-13T19:05:44  <meshcollider> ( Link for reference: https://github.com/sipa/miniscript )
2502020-03-13T19:05:51  <sipa> indeed
2512020-03-13T19:06:17  <achow101> how much duplication would there be?
2522020-03-13T19:06:44  <hebasto> hi
2532020-03-13T19:06:49  <luke-jr> sipa: another possibility could be to make a library for script stuff, shared by both
2542020-03-13T19:07:09  <sipa> luke-jr: right, that is a possibility - though probably pretty far off
2552020-03-13T19:07:19  <sipa> achow101: at least CScript and all opcode definitions
2562020-03-13T19:07:27  <sipa> there is probably more
2572020-03-13T19:07:43  <achow101> would you need to have all opcodes though?
2582020-03-13T19:08:07  <sipa> no, but i don't think that's a material distinction
2592020-03-13T19:08:46  <wumpus> if it's going to be consensus code, it would be good to avoid code duplication and aim for tight integration into bitcoin core, I think
2602020-03-13T19:09:10  <sipa> none of this should ever need to be consensus code
2612020-03-13T19:09:11  <ryanofsky> how would the duplication work? would there be functions to convert one cscript struct to the other?
2622020-03-13T19:09:24  <wumpus> okay, then that's not an issue
2632020-03-13T19:09:56  <sipa> ryanofsky: right, by treating them as byte arrays
2642020-03-13T19:10:02  <wumpus> I was just afraid of ballooning complexity of some things, which are already complex to test/verify/ by having them multiple times
2652020-03-13T19:10:07  <sipa> which they affectively are
2662020-03-13T19:10:32  <wumpus> yes, CScript is effectively a byte array, wasn't there a PR to separate the script functions from the storage?
2672020-03-13T19:10:35  <ryanofsky> is the serialization framework duplicated too?
2682020-03-13T19:10:36  <achow101> sipa: that would seem to make other areas more complicated where conversions between miniscript's cscript and core's cscript are necessary
2692020-03-13T19:10:48  <sipa> #13062
2702020-03-13T19:10:52  <gribble> https://github.com/bitcoin/bitcoin/issues/13062 | Make script interpreter independent from storage type CScript by sipa · Pull Request #13062 · bitcoin/bitcoin · GitHub
2712020-03-13T19:10:53  <wumpus> right
2722020-03-13T19:11:09  <sipa> ryanofsky: no, the serialization framework isn't used internally to script
2732020-03-13T19:11:20  <meshcollider> The alternative is to just include the miniscript code directly into core right?
2742020-03-13T19:11:43  <luke-jr> could always split it out later :x
2752020-03-13T19:11:56  <sipa> yeah, better reusable generic script code would be useful
2762020-03-13T19:12:04  <luke-jr> (eg, when we finally split out the wallet)
2772020-03-13T19:12:08  <sipa> and as luke-jr suggested, maybe the miniscript logic could evolve into that
2782020-03-13T19:12:33  <sipa> (which i guess would mean we keep the existing CScript or a stripped-down version of it in consensus, but not for signing/... etc)
2792020-03-13T19:12:52  <achow101> would it be possible to just have it link against core's cscript while still keeping miniscript's cscript when people want to use it as a separate library?
2802020-03-13T19:13:17  <wumpus> I was about to say, the advantage of duplication in this case wouldb e that no code affecting consensus needs to be changed for something not affecting consensus
2812020-03-13T19:13:27  <sipa> achow101: maybe- but i'm not sure there is much benefit to that
2822020-03-13T19:13:41  <sipa> because now you need to test miniscript with both
2832020-03-13T19:14:15  <sipa> ryanofsky: actually the code i have right now does copy serialize.h, though if i remember correctly it's just because CScript's serializers need it, despite not being used
2842020-03-13T19:15:04  <sipa> maybe i should just try to make it something independent, and see how bad it is
2852020-03-13T19:15:22  <luke-jr> make it a dependency of the library, and only support using it within Core for now?
2862020-03-13T19:16:30  <sipa> the same code is used for the policy compiler i have on my site
2872020-03-13T19:16:43  <luke-jr> (eg, so other code using the library needs to provide a compatible CScript)
2882020-03-13T19:17:00  <sipa> that's what i'm doing now, but it's kinda painful
2892020-03-13T19:17:09  <sipa> especially to keep the library itself testable
2902020-03-13T19:18:44  <luke-jr> sounds like something to fix in the test framework / build system
2912020-03-13T19:18:44  <luke-jr> or at least fixable
2922020-03-13T19:19:23  <sipa> i don't think having 2 separate CScript-and-opcodes implementations is beneficial
2932020-03-13T19:19:36  <sipa> they're effectively trivial modulus, with only boilerplate code
2942020-03-13T19:20:15  <sipa> if somehow one side of things needs to provide a compatible interface, it would just copy it
2952020-03-13T19:20:39  <achow101> how about we integrate miniscript into core, then library-ize script, and then library-ize miniscript?
2962020-03-13T19:20:53  <sipa> achow101: so also include the policy compiler in core?
2972020-03-13T19:21:12  <achow101> sure
2982020-03-13T19:21:23  <sipa> i'm not opposed to that, but i'm not sure it's the right approach
2992020-03-13T19:22:38  <meshcollider> Mhm I think trying to make miniscript independent first and seeing how it goes would be better
3002020-03-13T19:23:46  <sipa> i think i prefer that- especially the idea that it could perhaps evolve into something of a "non-consensus script subtree" is appealing
3012020-03-13T19:24:36  <sipa> any other topics?
3022020-03-13T19:25:57  <sipa> meshcollider: intro to hyperelliptic curves?
3032020-03-13T19:26:07  <achow101> ha
3042020-03-13T19:26:32  <meshcollider> sipa: lol someone already wrote a blog post about it so I don't need to :p
3052020-03-13T19:26:50  <sipa> i know :)
3062020-03-13T19:27:05  <meshcollider> achow101 any other reviews/merge begs for me to add to my to-do list for the next 2 days?
3072020-03-13T19:27:22  <achow101> meshcollider: every PR i have open :)
3082020-03-13T19:27:24  <jonatack> any last-minute feature freeze reviews? i'll be doing those this weekend
3092020-03-13T19:27:38  <achow101> meshcollider: #18204
3102020-03-13T19:27:42  <gribble> https://github.com/bitcoin/bitcoin/issues/18204 | descriptors: improve descriptor cache and cache xpubs by achow101 · Pull Request #18204 · bitcoin/bitcoin · GitHub
3112020-03-13T19:27:54  <meshcollider> Yeah I already have that one down :p
3122020-03-13T19:28:25  <achow101> #16946 and #16463 are both tagged 0.20 but neither have gotten review, so I don't think they'll make it
3132020-03-13T19:28:26  <gribble> https://github.com/bitcoin/bitcoin/issues/16946 | wallet: include a checksum of encrypted private keys by achow101 · Pull Request #16946 · bitcoin/bitcoin · GitHub
3142020-03-13T19:28:28  <gribble> https://github.com/bitcoin/bitcoin/issues/16463 | [BIP 174] Implement serialization support for GLOBAL_XPUB field. by achow101 · Pull Request #16463 · bitcoin/bitcoin · GitHub
3152020-03-13T19:28:59  <jonatack> maybe #17509
3162020-03-13T19:29:02  <gribble> https://github.com/bitcoin/bitcoin/issues/17509 | gui: save and load PSBT by Sjors · Pull Request #17509 · bitcoin/bitcoin · GitHub
3172020-03-13T19:29:19  *** bitcoin-git has joined #bitcoin-core-dev
3182020-03-13T19:29:19  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18346: rpc: Document an RPCResult for all calls; Enforce at compile time (master...2003-docAllRpcRes) https://github.com/bitcoin/bitcoin/pull/18346
3192020-03-13T19:29:20  *** bitcoin-git has left #bitcoin-core-dev
3202020-03-13T19:29:28  <achow101> 17509 would be nice to have for 0.20
3212020-03-13T19:29:34  <meshcollider> Yep 17509 is very nice
3222020-03-13T19:29:50  <meshcollider> Ok that's all for the meeting then
3232020-03-13T19:29:56  <meshcollider> #endmeeting
3242020-03-13T19:29:56  <lightningbot> Meeting ended Fri Mar 13 19:29:56 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
3252020-03-13T19:29:56  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-03-13-19.00.html
3262020-03-13T19:29:56  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-03-13-19.00.txt
3272020-03-13T19:29:56  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-03-13-19.00.log.html
3282020-03-13T19:32:39  <meshcollider> sipa: I'm updating the paper at the moment btw, at the moment I'm trying to create a convincing argument that for large prime field order, the proportion of non-simple isogeny classes of Jacobians is pretty negligible (those which cover an elliptic curve)
3292020-03-13T19:33:09  *** Guyver2_ is now known as Guyver2
3302020-03-13T19:34:07  <sipa> :)
3312020-03-13T19:43:43  *** vasild has quit IRC
3322020-03-13T19:45:16  *** ekrok has joined #bitcoin-core-dev
3332020-03-13T19:45:43  *** vasild has joined #bitcoin-core-dev
3342020-03-13T20:07:16  *** promag has quit IRC
3352020-03-13T20:07:56  *** jarthur has quit IRC
3362020-03-13T20:11:11  *** jarthur has joined #bitcoin-core-dev
3372020-03-13T20:12:27  *** jarthur has quit IRC
3382020-03-13T20:21:34  <achow101> meshcollider: do you think we can get #17681 into 0.20? it's kind of a bug fix, kind of a feature
3392020-03-13T20:21:37  <gribble> https://github.com/bitcoin/bitcoin/issues/17681 | wallet: Keep inactive seeds after sethdseed and derive keys from them as needed by achow101 · Pull Request #17681 · bitcoin/bitcoin · GitHub
3402020-03-13T20:25:44  <meshcollider> Um it's not looking good since it only has concept ACKs
3412020-03-13T20:26:22  <meshcollider> Depends if you can bribe enough people for a fast review today/tomorrow :p
3422020-03-13T20:26:40  <sipa> if it's a bug fix it can go in after the feature freeze
3432020-03-13T20:28:27  <meshcollider> Im not sure it's really bug-fix-y enough to be a "bugfix"?
3442020-03-13T20:29:58  <meshcollider> Ok yeah why not, its a good change, I think we can get it in
3452020-03-13T20:36:54  *** promag has joined #bitcoin-core-dev
3462020-03-13T20:40:36  *** mdunnio has quit IRC
3472020-03-13T20:42:29  *** captjakk has quit IRC
3482020-03-13T20:43:04  *** captjakk has joined #bitcoin-core-dev
3492020-03-13T20:45:50  *** mdunnio has joined #bitcoin-core-dev
3502020-03-13T20:46:52  *** captjakk has quit IRC
3512020-03-13T20:47:08  *** captjakk has joined #bitcoin-core-dev
3522020-03-13T20:49:35  *** promag has quit IRC
3532020-03-13T20:50:08  *** promag has joined #bitcoin-core-dev
3542020-03-13T20:50:11  *** captjakk has quit IRC
3552020-03-13T20:50:34  *** captjakk has joined #bitcoin-core-dev
3562020-03-13T20:51:00  <instagibbs> oh yeah meeting stuff
3572020-03-13T20:51:44  <instagibbs> I'd prefer subtree or something for miniscript, just for the "let's not touch consensus" reasons
3582020-03-13T20:52:03  <instagibbs> and #17509 is quite easy to test and would be nice, please review :)
3592020-03-13T20:52:06  <gribble> https://github.com/bitcoin/bitcoin/issues/17509 | gui: save and load PSBT by Sjors · Pull Request #17509 · bitcoin/bitcoin · GitHub
3602020-03-13T20:52:55  <sipa> instagibbs: to be clear, i don't think any of this, regardless of what approach is used, should ever affect consensus code
3612020-03-13T20:53:17  <instagibbs> of course
3622020-03-13T20:53:31  <instagibbs> I guess I just think it'd be cleaner to be a separate project :shrug:
3632020-03-13T20:53:41  <instagibbs> s/proj/repo/
3642020-03-13T20:54:07  <sipa> yeah, i think so too
3652020-03-13T20:56:57  <instagibbs> You may also get a bit more downstream usage/contribution/feedback that way too if it's really a library
3662020-03-13T20:57:09  *** bitcoin-git has joined #bitcoin-core-dev
3672020-03-13T20:57:09  <bitcoin-git> [bitcoin] jnewbery closed pull request #17485: WIP: net processing: Don't reach into CBlockIndex to check for block mutation (master...2019-11-processnewblock-early-return2) https://github.com/bitcoin/bitcoin/pull/17485
3682020-03-13T20:57:19  *** bitcoin-git has left #bitcoin-core-dev
3692020-03-13T20:57:55  *** emilengler has joined #bitcoin-core-dev
3702020-03-13T20:58:04  *** bitcoin-git has joined #bitcoin-core-dev
3712020-03-13T20:58:04  <bitcoin-git> [bitcoin] jnewbery closed pull request #17562: WIP: Validation: Remove ConnectTrace and PerBlockConnectTrace (master...2019-11-remove-connect-trace) https://github.com/bitcoin/bitcoin/pull/17562
3722020-03-13T20:58:06  *** bitcoin-git has left #bitcoin-core-dev
3732020-03-13T21:00:02  *** Ultifest2 has quit IRC
3742020-03-13T21:00:05  <instagibbs> I would like a real C++ miniscript library :)
3752020-03-13T21:03:46  *** dviola has joined #bitcoin-core-dev
3762020-03-13T21:04:26  *** dviola has joined #bitcoin-core-dev
3772020-03-13T21:19:15  *** dviola has left #bitcoin-core-dev
3782020-03-13T21:19:33  *** dviola has joined #bitcoin-core-dev
3792020-03-13T21:20:19  *** dviola has left #bitcoin-core-dev
3802020-03-13T21:20:35  *** dviola has joined #bitcoin-core-dev
3812020-03-13T21:21:34  *** kermit1 has joined #bitcoin-core-dev
3822020-03-13T21:22:43  *** dviola has left #bitcoin-core-dev
3832020-03-13T21:22:59  *** dviola has joined #bitcoin-core-dev
3842020-03-13T21:23:05  <jnewbery> #18002 has 6 ACKs. I think it's good for merge
3852020-03-13T21:23:07  <gribble> https://github.com/bitcoin/bitcoin/issues/18002 | Abstract out script execution out of VerifyWitnessProgram() by sipa · Pull Request #18002 · bitcoin/bitcoin · GitHub
3862020-03-13T21:26:54  <jnewbery> #16902 also has 5 ACKs and should be RFM
3872020-03-13T21:26:57  <gribble> https://github.com/bitcoin/bitcoin/issues/16902 | O(1) OP_IF/NOTIF/ELSE/ENDIF script implementation by sipa · Pull Request #16902 · bitcoin/bitcoin · GitHub
3882020-03-13T21:27:16  <jnewbery> (I left some comment nits on 16902 which can easily be added in a follow-up PR if people think they're helpful)
3892020-03-13T21:28:07  *** dviola has quit IRC
3902020-03-13T21:31:20  *** bitcoin-git has joined #bitcoin-core-dev
3912020-03-13T21:31:21  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3f9e6a3c1ce8...e5cb0dffd5ac
3922020-03-13T21:31:21  <bitcoin-git> bitcoin/master c8e24dd Pieter Wuille: [REFACTOR] Abstract out script execution out of VerifyWitnessProgram()
3932020-03-13T21:31:22  <bitcoin-git> bitcoin/master e5cb0df Wladimir J. van der Laan: Merge #18002: Abstract out script execution out of VerifyWitnessProgram()
3942020-03-13T21:31:26  *** bitcoin-git has left #bitcoin-core-dev
3952020-03-13T21:31:45  *** bitcoin-git has joined #bitcoin-core-dev
3962020-03-13T21:31:45  <bitcoin-git> [bitcoin] laanwj merged pull request #18002: Abstract out script execution out of VerifyWitnessProgram() (master...202001_execute_witness) https://github.com/bitcoin/bitcoin/pull/18002
3972020-03-13T21:31:46  *** bitcoin-git has left #bitcoin-core-dev
3982020-03-13T21:31:58  *** dviola has joined #bitcoin-core-dev
3992020-03-13T21:33:01  *** Guyver2 has quit IRC
4002020-03-13T21:36:45  *** sipsorcery has quit IRC
4012020-03-13T21:37:52  <ysangkok> instagibbs: when you say "real library", does that include version numbers and API/ABI stability? ;)
4022020-03-13T21:38:52  <sipa> one problem with doing so at this point that it'd need reviewers...
4032020-03-13T21:45:35  *** bitcoin-git has joined #bitcoin-core-dev
4042020-03-13T21:45:35  <bitcoin-git> [bitcoin] laanwj pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/e5cb0dffd5ac...7f8176a1ebd0
4052020-03-13T21:45:36  <bitcoin-git> bitcoin/master 474ea3b Andrew Chow: Introduce DescriptorCache struct which caches xpubs
4062020-03-13T21:45:36  <bitcoin-git> bitcoin/master df55d44 Andrew Chow: Track the index of the key expression in PubkeyProvider
4072020-03-13T21:45:37  <bitcoin-git> bitcoin/master 66c2cad Andrew Chow: Rename BIP32PubkeyProvider.m_extkey to m_root_extkey
4082020-03-13T21:45:38  *** bitcoin-git has left #bitcoin-core-dev
4092020-03-13T21:46:13  *** bitcoin-git has joined #bitcoin-core-dev
4102020-03-13T21:46:14  <bitcoin-git> [bitcoin] laanwj merged pull request #18204: descriptors: improve descriptor cache and cache xpubs (master...desc-xpub-cache) https://github.com/bitcoin/bitcoin/pull/18204
4112020-03-13T21:46:15  *** bitcoin-git has left #bitcoin-core-dev
4122020-03-13T21:47:14  *** Talkless has joined #bitcoin-core-dev
4132020-03-13T21:47:52  *** emilengler has quit IRC
4142020-03-13T21:48:05  *** emilengler has joined #bitcoin-core-dev
4152020-03-13T21:48:17  *** emilengler has joined #bitcoin-core-dev
4162020-03-13T21:50:58  <aj> instagibbs: c++, not c or rust?
4172020-03-13T21:53:26  *** commavir has quit IRC
4182020-03-13T21:54:05  <achow101> \o/ I think there's no pre-reqs left for descriptor wallets
4192020-03-13T21:55:10  *** bitcoin-git has joined #bitcoin-core-dev
4202020-03-13T21:55:11  <bitcoin-git> [bitcoin] joe-rodgers opened pull request #18347: Update all occurences of 2009-2019 to be 2009-2020 (master...master) https://github.com/bitcoin/bitcoin/pull/18347
4212020-03-13T21:55:12  *** bitcoin-git has left #bitcoin-core-dev
4222020-03-13T21:55:41  <sipa> aj: one challenge is that so far it has seemed very useful to have miniscript types with parametrized key types (in the compiler they're strings, in signing logic they're CKeyIDs, in descriptors they're pubkey expressions...), which seems hard to accomodate with a simple C-callable API
4232020-03-13T22:03:52  <jonatack> achow101: hoorah! :)
4242020-03-13T22:04:05  <luke-jr> instagibbs: non-consensus shouldn't be subtreed at all, though we might have to in this case
4252020-03-13T22:05:22  <sipa> luke-jr: well it'd be pretty much a headers-only library anyway, there wouldn't really be anything to dynamically link
4262020-03-13T22:05:32  <luke-jr> :x
4272020-03-13T22:05:50  <luke-jr> metaprogramming/templates kinda do force static linking by nature
4282020-03-13T22:05:52  <sipa> (that doesn't mean it needs to be subtreed, but the advantages of not doing it go down significantly)
4292020-03-13T22:08:08  *** MrSquanchee has quit IRC
4302020-03-13T22:08:27  *** manantial has quit IRC
4312020-03-13T22:10:59  *** justanotheruser has joined #bitcoin-core-dev
4322020-03-13T22:18:24  *** bitcoin-git has joined #bitcoin-core-dev
4332020-03-13T22:18:24  <bitcoin-git> [bitcoin] fanquake closed pull request #18347: Update all occurences of 2009-2019 to be 2009-2020 (master...master) https://github.com/bitcoin/bitcoin/pull/18347
4342020-03-13T22:18:25  *** bitcoin-git has left #bitcoin-core-dev
4352020-03-13T22:30:39  *** captjakk has quit IRC
4362020-03-13T22:31:13  *** captjakk has joined #bitcoin-core-dev
4372020-03-13T22:32:40  *** sipsorcery has joined #bitcoin-core-dev
4382020-03-13T22:35:43  *** captjakk has quit IRC
4392020-03-13T22:38:51  *** sipsorcery has quit IRC
4402020-03-13T22:43:55  *** timothy has quit IRC
4412020-03-13T22:48:59  *** captjakk has joined #bitcoin-core-dev
4422020-03-13T23:02:53  *** sipsorcery has joined #bitcoin-core-dev
4432020-03-13T23:07:38  *** captjakk has quit IRC
4442020-03-13T23:08:11  *** captjakk has joined #bitcoin-core-dev
4452020-03-13T23:12:35  *** captjakk has quit IRC
4462020-03-13T23:15:02  *** Talkless has quit IRC
4472020-03-13T23:19:07  *** commavir has joined #bitcoin-core-dev
4482020-03-13T23:26:32  *** filchef has quit IRC
4492020-03-13T23:29:11  *** molly has joined #bitcoin-core-dev
4502020-03-13T23:31:15  *** mol has quit IRC
4512020-03-13T23:38:08  *** sipsorcery has quit IRC
4522020-03-13T23:38:30  *** sipsorcery has joined #bitcoin-core-dev
4532020-03-13T23:41:54  *** mdunnio has quit IRC
4542020-03-13T23:44:39  *** captjakk has joined #bitcoin-core-dev
4552020-03-13T23:49:26  *** captjakk has quit IRC
4562020-03-13T23:56:06  *** justanotheruser has quit IRC
4572020-03-13T23:56:55  *** sipsorcery has quit IRC
4582020-03-13T23:57:26  *** emilengler has quit IRC
4592020-03-13T23:59:14  *** jonatack has quit IRC