1 2020-03-15T00:00:01  *** ButterflyOfFire has quit IRC
  2 2020-03-15T00:07:10  *** glowang has joined #bitcoin-core-dev
  3 2020-03-15T00:08:15  *** owowo has quit IRC
  4 2020-03-15T00:13:14  *** owowo has joined #bitcoin-core-dev
  5 2020-03-15T00:13:15  *** owowo has joined #bitcoin-core-dev
  6 2020-03-15T00:17:36  *** glowang has quit IRC
  7 2020-03-15T00:21:20  *** roconnor has joined #bitcoin-core-dev
  8 2020-03-15T00:21:54  *** kwm1 has joined #bitcoin-core-dev
  9 2020-03-15T00:23:45  *** nux0r has quit IRC
 10 2020-03-15T00:25:32  *** manantial has quit IRC
 11 2020-03-15T00:49:56  *** captjakk has quit IRC
 12 2020-03-15T00:51:32  *** Jackielove4u has quit IRC
 13 2020-03-15T00:56:17  *** molz_ has joined #bitcoin-core-dev
 14 2020-03-15T00:58:19  *** AaronvanW has quit IRC
 15 2020-03-15T00:58:51  *** molly has quit IRC
 16 2020-03-15T01:01:23  *** jb55 has quit IRC
 17 2020-03-15T01:04:42  *** sdddddd has quit IRC
 18 2020-03-15T01:18:10  *** sdddddd has joined #bitcoin-core-dev
 19 2020-03-15T01:25:46  *** justanotheruser has quit IRC
 20 2020-03-15T01:26:33  *** marcoagner has quit IRC
 21 2020-03-15T01:36:55  *** dviola has quit IRC
 22 2020-03-15T01:38:41  *** provoostenator has quit IRC
 23 2020-03-15T01:45:26  *** mdunnio has joined #bitcoin-core-dev
 24 2020-03-15T01:45:54  *** provoostenator has joined #bitcoin-core-dev
 25 2020-03-15T01:46:46  *** sdddddd has quit IRC
 26 2020-03-15T01:55:47  *** provoostenator has quit IRC
 27 2020-03-15T01:56:13  *** dviola has joined #bitcoin-core-dev
 28 2020-03-15T01:56:51  *** dviola has left #bitcoin-core-dev
 29 2020-03-15T02:00:59  *** sdddddd has joined #bitcoin-core-dev
 30 2020-03-15T02:08:03  *** provoostenator has joined #bitcoin-core-dev
 31 2020-03-15T02:11:26  *** jb55 has joined #bitcoin-core-dev
 32 2020-03-15T02:11:54  *** sdddddd has quit IRC
 33 2020-03-15T02:14:57  *** TheV01d has quit IRC
 34 2020-03-15T02:15:24  *** TheV01d has joined #bitcoin-core-dev
 35 2020-03-15T02:15:33  *** promag_ has joined #bitcoin-core-dev
 36 2020-03-15T02:16:07  *** captjakk has joined #bitcoin-core-dev
 37 2020-03-15T02:17:03  *** captjakk_ has joined #bitcoin-core-dev
 38 2020-03-15T02:18:03  *** provoostenator has quit IRC
 39 2020-03-15T02:19:51  *** promag_ has quit IRC
 40 2020-03-15T02:20:27  *** captjakk has quit IRC
 41 2020-03-15T02:23:56  *** sdddddd has joined #bitcoin-core-dev
 42 2020-03-15T02:30:10  *** justanotheruser has joined #bitcoin-core-dev
 43 2020-03-15T02:32:15  *** provoostenator has joined #bitcoin-core-dev
 44 2020-03-15T02:35:42  *** sdddddd has quit IRC
 45 2020-03-15T02:38:47  *** mdunnio has quit IRC
 46 2020-03-15T02:40:18  *** MrSquanchee has joined #bitcoin-core-dev
 47 2020-03-15T02:43:54  *** jb55 has quit IRC
 48 2020-03-15T02:49:16  *** sdddddd has joined #bitcoin-core-dev
 49 2020-03-15T03:00:01  *** kwm1 has quit IRC
 50 2020-03-15T03:00:26  *** sdddddd has quit IRC
 51 2020-03-15T03:05:48  *** belcher has quit IRC
 52 2020-03-15T03:06:45  *** promag has quit IRC
 53 2020-03-15T03:14:39  *** sdddddd has joined #bitcoin-core-dev
 54 2020-03-15T03:17:52  *** mdunnio has joined #bitcoin-core-dev
 55 2020-03-15T03:20:54  *** nhandler has joined #bitcoin-core-dev
 56 2020-03-15T03:21:18  *** nhandler is now known as Guest12044
 57 2020-03-15T03:22:58  *** mdunnio has quit IRC
 58 2020-03-15T03:26:42  *** sdddddd has quit IRC
 59 2020-03-15T03:39:50  *** sdddddd has joined #bitcoin-core-dev
 60 2020-03-15T03:40:57  *** felixfoertsch has joined #bitcoin-core-dev
 61 2020-03-15T03:41:16  *** promag has joined #bitcoin-core-dev
 62 2020-03-15T03:42:06  *** felixfoertsch23 has quit IRC
 63 2020-03-15T03:45:52  *** promag has quit IRC
 64 2020-03-15T04:03:32  *** sdddddd has quit IRC
 65 2020-03-15T04:08:17  *** ariard_ has quit IRC
 66 2020-03-15T04:15:41  *** sdddddd has joined #bitcoin-core-dev
 67 2020-03-15T04:20:27  *** promag has joined #bitcoin-core-dev
 68 2020-03-15T04:24:51  *** promag has quit IRC
 69 2020-03-15T04:28:46  *** sdddddd has quit IRC
 70 2020-03-15T04:31:12  *** IGHOR_ has quit IRC
 71 2020-03-15T04:39:22  *** IGHOR has joined #bitcoin-core-dev
 72 2020-03-15T04:43:46  *** captjakk_ has quit IRC
 73 2020-03-15T04:49:18  *** sdddddd has joined #bitcoin-core-dev
 74 2020-03-15T04:51:08  *** kristapsk_ has joined #bitcoin-core-dev
 75 2020-03-15T04:52:14  *** kristapsk has quit IRC
 76 2020-03-15T04:55:33  *** sonofhan has joined #bitcoin-core-dev
 77 2020-03-15T05:05:22  *** sonofhan has quit IRC
 78 2020-03-15T05:33:17  *** BlueMatt has quit IRC
 79 2020-03-15T05:37:35  *** BlueMatt has joined #bitcoin-core-dev
 80 2020-03-15T06:00:02  *** Guest12044 has quit IRC
 81 2020-03-15T06:16:11  *** promag has joined #bitcoin-core-dev
 82 2020-03-15T06:20:40  *** promag has quit IRC
 83 2020-03-15T06:21:06  *** rosseaux1 has joined #bitcoin-core-dev
 84 2020-03-15T06:21:15  *** promag has joined #bitcoin-core-dev
 85 2020-03-15T06:26:00  *** promag has quit IRC
 86 2020-03-15T06:31:14  *** molly has joined #bitcoin-core-dev
 87 2020-03-15T06:34:39  *** molz_ has quit IRC
 88 2020-03-15T06:39:25  *** glowang has joined #bitcoin-core-dev
 89 2020-03-15T06:46:21  *** mdunnio has joined #bitcoin-core-dev
 90 2020-03-15T06:50:49  *** mdunnio has quit IRC
 91 2020-03-15T06:56:13  *** promag has joined #bitcoin-core-dev
 92 2020-03-15T06:59:33  *** luke-jr has quit IRC
 93 2020-03-15T06:59:53  *** luke-jr has joined #bitcoin-core-dev
 94 2020-03-15T07:00:49  *** promag has quit IRC
 95 2020-03-15T07:31:44  *** promag has joined #bitcoin-core-dev
 96 2020-03-15T07:36:16  *** promag has quit IRC
 97 2020-03-15T07:39:02  *** manantial has joined #bitcoin-core-dev
 98 2020-03-15T07:40:44  *** vasild_ has joined #bitcoin-core-dev
 99 2020-03-15T07:43:43  *** vasild has quit IRC
100 2020-03-15T07:43:44  *** vasild_ is now known as vasild
101 2020-03-15T08:04:10  *** nux0r has joined #bitcoin-core-dev
102 2020-03-15T08:06:16  *** emilengler has joined #bitcoin-core-dev
103 2020-03-15T08:18:29  *** nux0r has quit IRC
104 2020-03-15T08:19:10  *** nux0r has joined #bitcoin-core-dev
105 2020-03-15T08:21:05  *** nux0r has joined #bitcoin-core-dev
106 2020-03-15T08:38:28  *** Jackielove4u has joined #bitcoin-core-dev
107 2020-03-15T08:41:16  *** nux0r has quit IRC
108 2020-03-15T08:41:50  *** nux0r has joined #bitcoin-core-dev
109 2020-03-15T08:47:23  *** nux0r has quit IRC
110 2020-03-15T08:52:25  *** nux0r has joined #bitcoin-core-dev
111 2020-03-15T08:54:42  *** nux0r has quit IRC
112 2020-03-15T08:54:55  *** nux0r has joined #bitcoin-core-dev
113 2020-03-15T08:57:11  *** oguz_ has joined #bitcoin-core-dev
114 2020-03-15T09:00:02  *** rosseaux1 has quit IRC
115 2020-03-15T09:02:56  *** mdunnio has joined #bitcoin-core-dev
116 2020-03-15T09:10:56  *** nux0r has quit IRC
117 2020-03-15T09:20:39  *** nux0r has joined #bitcoin-core-dev
118 2020-03-15T09:22:20  *** ZeroZiat has joined #bitcoin-core-dev
119 2020-03-15T09:34:59  <wumpus> jnewbery: performance improvements are a bit of a grey area, agreed, but I think in general we've taken "feature freeze" as "no more user-facing features" and did still merge other non-bugfix changes such as optimizations and refactors
120 2020-03-15T09:45:22  *** promag has joined #bitcoin-core-dev
121 2020-03-15T10:03:50  *** mdunnio has quit IRC
122 2020-03-15T10:13:13  *** marcoagner has joined #bitcoin-core-dev
123 2020-03-15T10:13:19  *** nux0r has quit IRC
124 2020-03-15T10:13:39  *** AaronvanW has joined #bitcoin-core-dev
125 2020-03-15T10:13:51  *** nux0r has joined #bitcoin-core-dev
126 2020-03-15T10:18:37  *** nux0r has quit IRC
127 2020-03-15T10:19:32  *** Guyver2 has joined #bitcoin-core-dev
128 2020-03-15T10:20:05  *** jorijn has quit IRC
129 2020-03-15T10:20:59  *** jorijn has joined #bitcoin-core-dev
130 2020-03-15T10:21:31  *** captjakk has joined #bitcoin-core-dev
131 2020-03-15T10:22:22  *** captjakk has quit IRC
132 2020-03-15T10:27:19  *** Talkless has joined #bitcoin-core-dev
133 2020-03-15T10:29:55  *** oguzkoroglu has quit IRC
134 2020-03-15T10:30:18  *** oguzkoroglu has joined #bitcoin-core-dev
135 2020-03-15T10:30:58  *** oguzkoroglu has joined #bitcoin-core-dev
136 2020-03-15T10:31:03  *** oguz_ has quit IRC
137 2020-03-15T10:31:58  *** oguzkoroglu has quit IRC
138 2020-03-15T10:32:21  *** oguzkoroglu_ has joined #bitcoin-core-dev
139 2020-03-15T10:36:12  *** oguzkoroglu has joined #bitcoin-core-dev
140 2020-03-15T10:48:45  *** nux0r has joined #bitcoin-core-dev
141 2020-03-15T10:55:29  *** bitcoin-git has joined #bitcoin-core-dev
142 2020-03-15T10:55:30  <bitcoin-git> [bitcoin] bvbfan closed pull request #18279: Ensure wallet and chain tip are in sync (master...master) https://github.com/bitcoin/bitcoin/pull/18279
143 2020-03-15T10:55:31  *** bitcoin-git has left #bitcoin-core-dev
144 2020-03-15T11:03:59  *** Deon47Olson has joined #bitcoin-core-dev
145 2020-03-15T11:31:00  *** Deon47Olson has quit IRC
146 2020-03-15T11:51:43  *** chiji14 has joined #bitcoin-core-dev
147 2020-03-15T11:56:25  *** promag has quit IRC
148 2020-03-15T12:00:02  *** ZeroZiat has quit IRC
149 2020-03-15T12:07:57  *** emilengler has quit IRC
150 2020-03-15T12:12:05  *** promag has joined #bitcoin-core-dev
151 2020-03-15T12:20:56  *** promag has quit IRC
152 2020-03-15T12:25:39  *** vasild has quit IRC
153 2020-03-15T12:25:52  *** vasild has joined #bitcoin-core-dev
154 2020-03-15T12:26:12  *** kristapsk_ has quit IRC
155 2020-03-15T12:27:37  *** chiji14 has quit IRC
156 2020-03-15T12:29:01  *** nux0r has quit IRC
157 2020-03-15T12:29:36  *** nux0r has joined #bitcoin-core-dev
158 2020-03-15T12:33:56  *** nux0r has quit IRC
159 2020-03-15T12:48:20  *** nux0r has joined #bitcoin-core-dev
160 2020-03-15T12:51:01  *** mdunnio has joined #bitcoin-core-dev
161 2020-03-15T12:56:44  *** manishearth1 has joined #bitcoin-core-dev
162 2020-03-15T12:57:47  *** belcher has joined #bitcoin-core-dev
163 2020-03-15T13:00:23  *** vasild has quit IRC
164 2020-03-15T13:00:32  *** nux0r has quit IRC
165 2020-03-15T13:01:18  *** nux0r has joined #bitcoin-core-dev
166 2020-03-15T13:01:19  *** vasild has joined #bitcoin-core-dev
167 2020-03-15T13:05:45  *** nux0r has quit IRC
168 2020-03-15T13:14:10  *** kristapsk has joined #bitcoin-core-dev
169 2020-03-15T13:15:19  *** vasild has quit IRC
170 2020-03-15T13:15:31  *** vasild has joined #bitcoin-core-dev
171 2020-03-15T13:34:00  *** nux0r has joined #bitcoin-core-dev
172 2020-03-15T13:48:18  *** Talkless has quit IRC
173 2020-03-15T13:48:43  *** Talkless has joined #bitcoin-core-dev
174 2020-03-15T13:51:20  *** mdunnio has quit IRC
175 2020-03-15T13:55:11  *** promag has joined #bitcoin-core-dev
176 2020-03-15T14:16:15  *** bitcoin-git has joined #bitcoin-core-dev
177 2020-03-15T14:16:15  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/67dfd18f4401...d402c1e4d3e8
178 2020-03-15T14:16:15  <bitcoin-git> bitcoin/master fa19295 MarcoFalke: test: Bump timeouts to avoid valgrind failures
179 2020-03-15T14:16:16  <bitcoin-git> bitcoin/master d402c1e MarcoFalke: Merge #18345: test: Bump timeouts to avoid valgrind failures
180 2020-03-15T14:16:17  *** bitcoin-git has left #bitcoin-core-dev
181 2020-03-15T14:16:30  *** bitcoin-git has joined #bitcoin-core-dev
182 2020-03-15T14:16:31  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18345: test: Bump timeouts to avoid valgrind failures (master...2003-qaBumpTimeoutsAgain) https://github.com/bitcoin/bitcoin/pull/18345
183 2020-03-15T14:16:32  *** bitcoin-git has left #bitcoin-core-dev
184 2020-03-15T14:33:28  *** mdunnio has joined #bitcoin-core-dev
185 2020-03-15T14:38:32  *** nux0r has quit IRC
186 2020-03-15T14:38:44  *** nux0r has joined #bitcoin-core-dev
187 2020-03-15T14:58:50  *** gleb1 has quit IRC
188 2020-03-15T15:00:01  *** manishearth1 has quit IRC
189 2020-03-15T15:21:20  *** agrajag` has joined #bitcoin-core-dev
190 2020-03-15T15:27:15  *** promag has quit IRC
191 2020-03-15T15:34:12  *** mdunnio has quit IRC
192 2020-03-15T15:50:28  *** oguzkoroglu has quit IRC
193 2020-03-15T15:51:24  *** oguzkoroglu has joined #bitcoin-core-dev
194 2020-03-15T16:02:58  *** _andrewtoth_ has joined #bitcoin-core-dev
195 2020-03-15T16:03:43  *** andrewtoth_ has quit IRC
196 2020-03-15T16:19:27  *** bitcoin-git has joined #bitcoin-core-dev
197 2020-03-15T16:19:27  <bitcoin-git> [bitcoin] practicalswift opened pull request #18353: tests: Add fuzzing harnesses for classes CBlockHeader, CFeeRate and various functions (master...fuzzers-coverage) https://github.com/bitcoin/bitcoin/pull/18353
198 2020-03-15T16:19:38  *** bitcoin-git has left #bitcoin-core-dev
199 2020-03-15T16:26:57  *** MrSquanchee has quit IRC
200 2020-03-15T16:47:47  *** justanotheruser has quit IRC
201 2020-03-15T16:48:23  *** _andrewtoth_ has quit IRC
202 2020-03-15T16:51:27  *** tsujp has quit IRC
203 2020-03-15T16:51:58  *** gleb1 has joined #bitcoin-core-dev
204 2020-03-15T16:58:08  *** MrSquanchee has joined #bitcoin-core-dev
205 2020-03-15T17:00:42  *** mdunnio has joined #bitcoin-core-dev
206 2020-03-15T17:01:40  *** justanotheruser has joined #bitcoin-core-dev
207 2020-03-15T17:18:48  *** sdddddd has quit IRC
208 2020-03-15T17:26:41  *** sdddddd has joined #bitcoin-core-dev
209 2020-03-15T17:27:37  *** bitcoin-git has joined #bitcoin-core-dev
210 2020-03-15T17:27:37  <bitcoin-git> [bitcoin] bvbfan opened pull request #18354: Protect wallet from scheduler race conditions. (master...master) https://github.com/bitcoin/bitcoin/pull/18354
211 2020-03-15T17:27:39  *** bitcoin-git has left #bitcoin-core-dev
212 2020-03-15T17:33:19  *** DeanGuss has joined #bitcoin-core-dev
213 2020-03-15T17:45:13  *** dviola has joined #bitcoin-core-dev
214 2020-03-15T18:00:01  *** agrajag` has quit IRC
215 2020-03-15T18:11:14  *** peant has joined #bitcoin-core-dev
216 2020-03-15T18:22:33  *** albertlast1 has joined #bitcoin-core-dev
217 2020-03-15T18:30:58  *** DeanGuss has quit IRC
218 2020-03-15T18:39:16  *** roasbeef has quit IRC
219 2020-03-15T18:39:39  *** roasbeef_ has joined #bitcoin-core-dev
220 2020-03-15T18:40:03  *** dviola has quit IRC
221 2020-03-15T18:52:47  *** DeanGuss has joined #bitcoin-core-dev
222 2020-03-15T18:54:51  *** emilengler has joined #bitcoin-core-dev
223 2020-03-15T18:56:51  *** nux0r has quit IRC
224 2020-03-15T19:09:07  *** _andrewtoth_ has joined #bitcoin-core-dev
225 2020-03-15T19:09:39  *** owowo has quit IRC
226 2020-03-15T19:14:42  *** owowo has joined #bitcoin-core-dev
227 2020-03-15T19:17:56  *** AaronvanW has quit IRC
228 2020-03-15T19:27:26  *** someone235 has quit IRC
229 2020-03-15T19:29:48  *** emilengler has quit IRC
230 2020-03-15T19:30:03  *** emilengler has joined #bitcoin-core-dev
231 2020-03-15T19:36:08  *** Talkless has quit IRC
232 2020-03-15T19:36:31  *** Lightsword has quit IRC
233 2020-03-15T19:36:31  *** treyzania has quit IRC
234 2020-03-15T19:36:31  *** mr_burdell has quit IRC
235 2020-03-15T19:36:31  *** enasigurd has quit IRC
236 2020-03-15T19:36:31  *** pingwindyktator has quit IRC
237 2020-03-15T19:36:31  *** fengling has quit IRC
238 2020-03-15T19:36:31  *** kanzure has quit IRC
239 2020-03-15T19:36:31  *** wpaulino has quit IRC
240 2020-03-15T19:36:39  *** mr_burdell has joined #bitcoin-core-dev
241 2020-03-15T19:36:42  *** enasigurd has joined #bitcoin-core-dev
242 2020-03-15T19:36:42  *** kanzure_ has joined #bitcoin-core-dev
243 2020-03-15T19:36:46  *** treyzania has joined #bitcoin-core-dev
244 2020-03-15T19:36:50  *** fengling has joined #bitcoin-core-dev
245 2020-03-15T19:36:51  *** wpaulino has joined #bitcoin-core-dev
246 2020-03-15T19:37:06  *** pingwindyktator has joined #bitcoin-core-dev
247 2020-03-15T19:37:21  *** Lightsword has joined #bitcoin-core-dev
248 2020-03-15T19:37:32  *** Bullit has quit IRC
249 2020-03-15T19:40:49  *** vasild_ has joined #bitcoin-core-dev
250 2020-03-15T19:44:03  *** vasild has quit IRC
251 2020-03-15T19:44:04  *** vasild_ is now known as vasild
252 2020-03-15T19:49:15  *** mdunnio has quit IRC
253 2020-03-15T19:50:44  *** AaronvanW has joined #bitcoin-core-dev
254 2020-03-15T19:55:15  *** AaronvanW has quit IRC
255 2020-03-15T19:56:03  *** _andrewtoth_ has quit IRC
256 2020-03-15T19:58:15  *** phantomcircuit_ is now known as phantomcircuit
257 2020-03-15T20:06:36  *** oguzkoroglu has quit IRC
258 2020-03-15T20:07:31  <jnewbery> wumpus: is that formalised/documented anywhere? I'd argue we probably shouldn't be doing performance/refactors during a feature freeze
259 2020-03-15T20:09:19  <wumpus> ok, yes, some people disagree on that, it has alwys been a fairly good time to do, for example, code moves, because there was no pressure for something else to get in
260 2020-03-15T20:10:31  *** willcl_ark__ has quit IRC
261 2020-03-15T20:10:52  <wumpus> a feature freeze is really about features, don't know about extending it to other things too, it was usually after the first rc that only bugfixes make it in
262 2020-03-15T20:13:08  <wumpus> I don't particularly have any optinion about this one way or the other, btw
263 2020-03-15T20:14:21  <wumpus> it's always been more a heuristic about not merging large risk things last minute
264 2020-03-15T20:15:00  <wumpus> no matter waht kind of change it is
265 2020-03-15T20:18:48  *** Randolf has joined #bitcoin-core-dev
266 2020-03-15T20:24:52  *** owowo has quit IRC
267 2020-03-15T20:27:46  *** willcl_ark_ has joined #bitcoin-core-dev
268 2020-03-15T20:28:18  *** jorijn has quit IRC
269 2020-03-15T20:29:16  *** jorijn has joined #bitcoin-core-dev
270 2020-03-15T20:29:42  *** owowo has joined #bitcoin-core-dev
271 2020-03-15T20:30:15  *** midnight has quit IRC
272 2020-03-15T20:30:15  *** harding has quit IRC
273 2020-03-15T20:30:15  *** _0x0ff has quit IRC
274 2020-03-15T20:30:16  *** Anduck has quit IRC
275 2020-03-15T20:30:16  *** nothingmuch has quit IRC
276 2020-03-15T20:30:16  *** nehan_ has quit IRC
277 2020-03-15T20:30:16  *** raj_ has quit IRC
278 2020-03-15T20:30:16  *** dlb76 has quit IRC
279 2020-03-15T20:30:25  *** harding_ has joined #bitcoin-core-dev
280 2020-03-15T20:30:26  *** Anduck has joined #bitcoin-core-dev
281 2020-03-15T20:30:27  *** justanotheruser has quit IRC
282 2020-03-15T20:30:31  *** nehan has joined #bitcoin-core-dev
283 2020-03-15T20:30:40  *** nothingmuch has joined #bitcoin-core-dev
284 2020-03-15T20:30:48  *** raj_149 has joined #bitcoin-core-dev
285 2020-03-15T20:31:25  *** _0x0ff has joined #bitcoin-core-dev
286 2020-03-15T20:36:48  *** dlb76 has joined #bitcoin-core-dev
287 2020-03-15T20:40:12  <jnewbery> yeah, I don't have a strong opinion either. Mostly trying to understand the process/rationale
288 2020-03-15T20:44:24  *** peant has quit IRC
289 2020-03-15T20:46:18  *** AaronvanW has joined #bitcoin-core-dev
290 2020-03-15T20:46:26  *** promag has joined #bitcoin-core-dev
291 2020-03-15T20:46:43  *** justanotheruser has joined #bitcoin-core-dev
292 2020-03-15T20:50:11  <wumpus> AFAIK the reason features are treated specialy here is because they usually involve extra translation strings, and tend to be trickier to test (might involve manual testing in some cases, even for pure API features someone needs to try it out whether it is usable)
293 2020-03-15T20:50:37  <wumpus> so it's better to have it longer in before a release
294 2020-03-15T20:57:28  *** midnight has joined #bitcoin-core-dev
295 2020-03-15T20:58:32  <stevenroose> So I'm trying to automate a test of an RPC client library for Core, but I can't seem to get regtest to provide a fee estimate. No matter how many blocks I create, I keep getting "Insufficient data or no feerate found"
296 2020-03-15T20:58:59  <stevenroose> I create a few txs with non-zero fees before. Should I make more of those.
297 2020-03-15T21:00:02  *** albertlast1 has quit IRC
298 2020-03-15T21:00:05  <sipa> stevenroose: do you submit the transactions individually too?
299 2020-03-15T21:00:18  <stevenroose> Yeah, in other test methods.
300 2020-03-15T21:00:23  <stevenroose> It's a total of 10 maybe, though
301 2020-03-15T21:00:29  <stevenroose> Do I need more of them?
302 2020-03-15T21:00:55  <aj> stevenroose: do any of them sit in the mempool, or do they all get confirmed immediately in the next block? i think you need some to sit in the mempool?
303 2020-03-15T21:00:58  <sipa> i suspect you need many more, but i don't know for sure
304 2020-03-15T21:01:26  <sipa> yeah they have to sit in the mempool, and then confirm
305 2020-03-15T21:01:26  <stevenroose> Ah I do mine blocks before, so there's never any in the mempool.
306 2020-03-15T21:01:40  <sipa> then there is jo way to measure how quickly they confirm :)
307 2020-03-15T21:01:42  <stevenroose> Heh? What does the "and then confirm" mean?
308 2020-03-15T21:01:52  <stevenroose> Ah wow Core measures confirmation times?
309 2020-03-15T21:01:59  <sipa> yes
310 2020-03-15T21:02:00  <aj> stevenroose: tx arrives; block without tx arrives; ..; block with tx arrives
311 2020-03-15T21:02:12  <sipa> that's the only thing it measures
312 2020-03-15T21:02:27  <stevenroose> aj: would tx arrives; sleep; block with tx arrives work?
313 2020-03-15T21:02:43  <aj> stevenroose: no, it's block count, not times
314 2020-03-15T21:02:45  <sipa> sure
315 2020-03-15T21:03:00  <sipa> i believe it looks at how many blocks it takes.for certain feerate levels to confirm
316 2020-03-15T21:03:07  <stevenroose> Hmm, is it even possible to let Core create a block without txs if there are any in its mempool?
317 2020-03-15T21:03:21  <aj> set the maxblocksize to super small?
318 2020-03-15T21:03:39  <sipa> stevenroose: you can consteuct blocks directly from the python test framework
319 2020-03-15T21:04:01  <aj> also, you could just prepopulate fee_estimates.dat and not worry about the mempool
320 2020-03-15T21:04:23  <stevenroose> oh that'd be smart
321 2020-03-15T21:04:52  *** mdunnio has joined #bitcoin-core-dev
322 2020-03-15T21:19:35  *** AaronvanW has quit IRC
323 2020-03-15T21:22:09  *** them_ has joined #bitcoin-core-dev
324 2020-03-15T21:27:03  *** DeanGuss has quit IRC
325 2020-03-15T21:48:38  *** DeanGuss has joined #bitcoin-core-dev
326 2020-03-15T21:52:16  *** kristapsk has quit IRC
327 2020-03-15T21:52:41  *** kristapsk has joined #bitcoin-core-dev
328 2020-03-15T21:53:28  *** emilengler has quit IRC
329 2020-03-15T21:58:19  *** captjakk has joined #bitcoin-core-dev
330 2020-03-15T21:58:46  *** mdunnio has quit IRC
331 2020-03-15T22:09:01  *** ariard has joined #bitcoin-core-dev
332 2020-03-15T22:12:30  *** Guyver2 has quit IRC
333 2020-03-15T22:17:46  *** AaronvanW has joined #bitcoin-core-dev
334 2020-03-15T22:30:15  *** _andrewtoth_ has joined #bitcoin-core-dev
335 2020-03-15T22:30:25  *** mdunnio has joined #bitcoin-core-dev
336 2020-03-15T22:34:59  *** mdunnio has quit IRC
337 2020-03-15T22:45:37  *** justanotheruser has quit IRC
338 2020-03-15T22:46:11  <achow101> cfields_: jonasschnelli: what do I need to do for the Windows codesigning cert?
339 2020-03-15T22:48:41  *** bitcoin-git has joined #bitcoin-core-dev
340 2020-03-15T22:48:42  <bitcoin-git> [bitcoin] promag opened pull request #18357: Fix missing header in sync.h (master...2020-03-missing-include) https://github.com/bitcoin/bitcoin/pull/18357
341 2020-03-15T22:48:43  *** bitcoin-git has left #bitcoin-core-dev
342 2020-03-15T22:53:16  *** oguzkoroglu_ has quit IRC
343 2020-03-15T22:54:00  *** oguzkoroglu_ has joined #bitcoin-core-dev
344 2020-03-15T22:57:45  *** roasbeef_ is now known as roasbeef
345 2020-03-15T23:12:43  *** mdunnio has joined #bitcoin-core-dev
346 2020-03-15T23:16:23  *** hutsot has joined #bitcoin-core-dev
347 2020-03-15T23:16:26  *** hutsot has left #bitcoin-core-dev
348 2020-03-15T23:17:15  *** mdunnio has quit IRC
349 2020-03-15T23:19:32  *** dgenr8 has quit IRC
350 2020-03-15T23:21:12  *** Randolf has quit IRC
351 2020-03-15T23:29:06  <stevenroose> Was afk for a bit. So I tried to generate 2 empty blocks, invalidate them, create a bunch of txs, reconsider the 2 empty blocks, then mine a tx. So purely from the mempool, that should look as if it took 2 blocks to confirm those txs.
352 2020-03-15T23:29:15  <stevenroose> I do that 10 times in a row with 10 transactions.
353 2020-03-15T23:29:49  <stevenroose> I'm trying to find a pure RPC way to do this, but it seems like it's not possible. Go and mine a block in pure code (like Python does it) is a bit more annoying, wanted to avoid that.
354 2020-03-15T23:31:06  <sipa> stevenroose: i would not be surprised if the fee estimation code ignores transactions that get reorged
355 2020-03-15T23:31:15  *** dgenr8 has joined #bitcoin-core-dev
356 2020-03-15T23:31:34  <stevenroose> they don't get reorged
357 2020-03-15T23:32:13  <stevenroose> In the scenario I detailed above, no txs get confirmed and then unconfirmed.
358 2020-03-15T23:32:28  <stevenroose> There are just 2 empty blocks reconsidered whle they are in the mempool.
359 2020-03-15T23:32:45  <stevenroose> Perhaps the fee estimation logic doesn't count reconsidered blocks as "a new block is mined"
360 2020-03-15T23:33:32  <aj> stevenroose: i think it compares the height of the tip when the tx was first seen, and the height of the block it was mined in
361 2020-03-15T23:33:48  <aj> stevenroose: so i think that should be plausible
362 2020-03-15T23:34:39  <stevenroose> and invalidated blocks count as tip?
363 2020-03-15T23:34:41  <stevenroose> hmmm
364 2020-03-15T23:35:09  <stevenroose> I'm going to bed, gonna think about this more tomorrow probably. About copying the dat file, how version-compatible is that?
365 2020-03-15T23:35:22  <stevenroose> I'm a bit reluctant to do that, but it's a possibility.
366 2020-03-15T23:35:42  <stevenroose> Alternative is implementing mining in Rust..
367 2020-03-15T23:36:15  <aj> stevenroose: it got an upgrade in 0.15.0, anything since then has been the same
368 2020-03-15T23:36:30  <stevenroose> aj hmm, k thanks
369 2020-03-15T23:36:43  <stevenroose> that's good, I don't think we'll be supporting anything before 0.18.0
370 2020-03-15T23:36:57  *** MrSquanchee has quit IRC
371 2020-03-15T23:36:58  <aj> stevenroose: you might need the chain you're using to have a similar height as the one you got the fee estimates from
372 2020-03-15T23:37:30  <aj> stevenroose: (there's functional tests that test estimates though, so just copy one of those)
373 2020-03-15T23:37:32  <sipa> stevenroose: i think the easiest approach is just mining blocks directly from python
374 2020-03-15T23:37:45  <sipa> as all infrastructure is already there
375 2020-03-15T23:37:57  <stevenroose> but I'm not using python..
376 2020-03-15T23:38:44  <sipa> wait, what are we talking about then?
377 2020-03-15T23:39:30  <sipa> ah, rpc client library
378 2020-03-15T23:40:46  <sipa> if you just want to test what rpcs work and give syntactically correct answers, and not want to test the fee estimation logic itself, you can probably just create enough transactions that don't fit in a block, and use the generate RPCs
379 2020-03-15T23:41:58  <sipa> the more you deviate using things like reorgs or block invalidation, the less representative the test will be
380 2020-03-15T23:42:46  <sipa> have a look at what test/functional/feature_fee_estimation.py does
381 2020-03-15T23:56:59  *** Dean_Guss has joined #bitcoin-core-dev
382 2020-03-15T23:59:04  *** manantial has quit IRC