1 2020-03-17T00:00:02  *** hwangjy9 has quit IRC
  2 2020-03-17T00:03:39  *** emilengler has quit IRC
  3 2020-03-17T00:13:45  *** Deacydal is now known as deacyde
  4 2020-03-17T00:22:19  *** zeromus1 has joined #bitcoin-core-dev
  5 2020-03-17T00:31:37  *** diogorsergio has quit IRC
  6 2020-03-17T00:34:30  <achow101> sipa: hardware wallets can't do the generic way of signing
  7 2020-03-17T00:34:45  *** tryphe_ is now known as tryphe
  8 2020-03-17T00:35:03  *** AaronvanW has joined #bitcoin-core-dev
  9 2020-03-17T00:35:22  <achow101> Our generic way of signing was to get a SigningProvider and pass that to ProduceSignature. but you can't get a SigningProvider with private keys for a hardware wallet
 10 2020-03-17T00:36:18  <sipa> achow101: hmm, you imagine having a SPKM for hardware wallets?
 11 2020-03-17T00:36:39  <achow101> yes
 12 2020-03-17T00:36:54  <achow101> I imagine it would be a subclass of DescriptorScriptPubKeyMan
 13 2020-03-17T00:37:07  <sipa> hmm, i had never imagined it that way
 14 2020-03-17T00:37:17  <sipa> it may make sense
 15 2020-03-17T00:38:14  <achow101> what were you thinking it would be?
 16 2020-03-17T00:39:33  <sipa> a descriptorscriptpubkeyman that simply had no private keys, and maybe a meta data field saying "use hardware device X", so the UI could suggest the user try PSBT interface/etc
 17 2020-03-17T00:40:03  <sipa> i wasn't expecting dealing with hardware wallets so deep down in the stack
 18 2020-03-17T00:43:37  *** marcoagner has quit IRC
 19 2020-03-17T00:45:09  <sipa> i guess if you want to transparently support hardware wallets, without having the user jump through hoops exporting/importing PSBTs, etc, or specialized UIs for it, this is how you'd do it
 20 2020-03-17T00:45:44  <achow101> my end goal for hardware wallets is to have the seamless experience where it calls out to the device automatically on send
 21 2020-03-17T00:45:53  <achow101> so this seemed to be the easiest way to do that
 22 2020-03-17T00:46:16  <achow101> instead of sprinkling around a bunch of hardware wallet things everywhere we had signing code
 23 2020-03-17T00:46:16  <sipa> still it feels awkward that SPKMs (which really ought to just deal with keys and scripts) need to be aware of transactions and messages
 24 2020-03-17T00:48:50  <achow101> i guess
 25 2020-03-17T00:54:33  <sipa> it also means things like signet (block signing) and generic message signing need to add their own methods to every SPKM implementation?
 26 2020-03-17T01:08:21  *** AaronvanW has quit IRC
 27 2020-03-17T01:23:23  <ysangkok> achow101: forgive me if it is a stupid question, but if SignTransaction needs to block and wait for a HW wallet, won't it need to be more complicated than just a function call (because of asynchrony)? i guess it would block for e.g. 1 minute while the user interacts with the HW wallet. is that how it will be?
 28 2020-03-17T01:31:56  <achow101> sipa: we can have a default implementation that calls a protected GetSigningProvider and then does the signing thing generically. then if the specific SPKM can't do that, they can override it and implement it differently
 29 2020-03-17T01:32:49  <achow101> ysangkok: it only blocks the thread for that part of the ui (or specific RPC). IIRC we already have async dialogs so it shouldn't be a problem
 30 2020-03-17T01:32:55  <achow101> but I haven't thought about that too much yet
 31 2020-03-17T01:42:55  *** diogorsergio has joined #bitcoin-core-dev
 32 2020-03-17T01:44:04  <sipa> achow101: right
 33 2020-03-17T01:44:34  <sipa> achow101: SignTransaction can probably be written as a wrapper around PSBT operations, actually
 34 2020-03-17T01:45:00  <achow101> it'd be nice if the wallet moved entirely to psbt operations
 35 2020-03-17T01:45:23  <sipa> so maybe it suffices if SPKMs (or even some.other class) can just provide "here is another method you can try to uodate a PSBT"
 36 2020-03-17T01:46:58  <sipa> maybe related: why does the SigningProvider returned not give access to private keys?
 37 2020-03-17T01:49:02  <achow101> that SigningProvider is specifically just for the solving date (hence the function name GetSolvingProvider)
 38 2020-03-17T01:49:04  <midnight> btw, psbt has made offline signing *incredibly much easier*. Seriously, thank you.
 39 2020-03-17T01:49:50  <achow101> so the no private keys thing is to be explicit about it not actually being useful for signing
 40 2020-03-17T01:50:14  <sipa> i see
 41 2020-03-17T01:51:12  <achow101> there was a suggestion of moving the public parts of SigningProvider to a parent SolvingProvider
 42 2020-03-17T01:51:17  <achow101> to make that clearer
 43 2020-03-17T01:52:29  <sipa> that may make sense
 44 2020-03-17T01:52:45  <sipa> but there should be a way to get access to private keys too, no?
 45 2020-03-17T01:53:00  <sipa> or is that only possible through the SignTransacrion and SignMessage functions?
 46 2020-03-17T01:53:22  <achow101> i'm not sure that it useful to have the privkeys given SignTransaction and SignMessage
 47 2020-03-17T01:54:00  <sipa> well i hope that at some point we don't need tx specific logic in SPKMs
 48 2020-03-17T01:56:23  <sipa> but i see why that's the case now
 49 2020-03-17T01:56:25  <sipa> thanks
 50 2020-03-17T02:02:23  *** Highway61 has quit IRC
 51 2020-03-17T02:09:20  *** captjakk_ has quit IRC
 52 2020-03-17T02:09:28  *** shibshop has left #bitcoin-core-dev
 53 2020-03-17T02:29:05  *** bitcoin-git has joined #bitcoin-core-dev
 54 2020-03-17T02:29:06  <bitcoin-git> [bitcoin] practicalswift opened pull request #18363: tests: Add fuzzing harness for HTTPRequest, libevent's evhttp and related functions (master...fuzzers-http_request) https://github.com/bitcoin/bitcoin/pull/18363
 55 2020-03-17T02:29:06  *** bitcoin-git has left #bitcoin-core-dev
 56 2020-03-17T02:32:15  *** DeanWeen is now known as DeanGuss
 57 2020-03-17T03:00:01  *** zeromus1 has quit IRC
 58 2020-03-17T03:01:09  *** hadjiszs has joined #bitcoin-core-dev
 59 2020-03-17T03:05:43  *** AaronvanW has joined #bitcoin-core-dev
 60 2020-03-17T03:12:06  *** ddustin has joined #bitcoin-core-dev
 61 2020-03-17T03:13:21  *** ddustin has joined #bitcoin-core-dev
 62 2020-03-17T03:14:41  *** ddustin has joined #bitcoin-core-dev
 63 2020-03-17T03:15:10  *** ddustin has quit IRC
 64 2020-03-17T03:21:46  *** geekosaur has joined #bitcoin-core-dev
 65 2020-03-17T03:21:48  *** geekosaur is now known as Guest11588
 66 2020-03-17T03:37:39  *** felixfoertsch has joined #bitcoin-core-dev
 67 2020-03-17T03:37:43  *** felixfoertsch23 has quit IRC
 68 2020-03-17T03:39:13  *** AaronvanW has quit IRC
 69 2020-03-17T03:48:09  *** jorijn_ has joined #bitcoin-core-dev
 70 2020-03-17T03:48:50  *** jorijn has quit IRC
 71 2020-03-17T04:54:23  *** jb55 has quit IRC
 72 2020-03-17T04:59:21  *** ghost43 has quit IRC
 73 2020-03-17T05:31:43  *** kristapsk has quit IRC
 74 2020-03-17T05:36:17  *** AaronvanW has joined #bitcoin-core-dev
 75 2020-03-17T05:47:49  *** sipa has quit IRC
 76 2020-03-17T05:53:04  *** sipa has joined #bitcoin-core-dev
 77 2020-03-17T06:00:02  *** Guest11588 has quit IRC
 78 2020-03-17T06:09:13  *** AaronvanW has quit IRC
 79 2020-03-17T06:19:46  *** chrippa has joined #bitcoin-core-dev
 80 2020-03-17T06:23:51  *** chrippa has quit IRC
 81 2020-03-17T06:49:01  *** goatpig has quit IRC
 82 2020-03-17T06:55:17  *** meshcollider has quit IRC
 83 2020-03-17T06:55:37  *** maurits has joined #bitcoin-core-dev
 84 2020-03-17T07:15:46  *** justanotheruser has quit IRC
 85 2020-03-17T07:29:57  *** kristapsk has joined #bitcoin-core-dev
 86 2020-03-17T07:40:50  *** vasild_ has joined #bitcoin-core-dev
 87 2020-03-17T07:44:23  *** vasild has quit IRC
 88 2020-03-17T07:44:24  *** vasild_ is now known as vasild
 89 2020-03-17T07:44:41  *** bitcoin-git has joined #bitcoin-core-dev
 90 2020-03-17T07:44:41  <bitcoin-git> [bitcoin] fanquake opened pull request #18364: random: remove getentropy() fallback for macOS < 10.12 (master...macos_remove_1012_fallback) https://github.com/bitcoin/bitcoin/pull/18364
 91 2020-03-17T07:44:42  *** bitcoin-git has left #bitcoin-core-dev
 92 2020-03-17T07:45:49  *** justanotheruser has joined #bitcoin-core-dev
 93 2020-03-17T08:03:09  *** justanotheruser has quit IRC
 94 2020-03-17T08:06:03  *** AaronvanW has joined #bitcoin-core-dev
 95 2020-03-17T08:13:53  *** meshcollider has joined #bitcoin-core-dev
 96 2020-03-17T08:28:29  <vasild> fanquake: I find it strange that we used to test whether the getentropy() function is present with "if (&getentropy != nullptr)".
 97 2020-03-17T08:30:39  <vasild> Would it even compile if getentropy() is missing? Maybe old macos versions define the symbol but set it to nullptr!?
 98 2020-03-17T08:38:27  *** AaronvanW has quit IRC
 99 2020-03-17T08:40:22  <fanquake> vaslid: From my understanding it would compile, but crash at runtime on a version of macOS, because of the way new SDK symbols are handled. There's some more discussion in #15103
100 2020-03-17T08:40:24  <gribble> https://github.com/bitcoin/bitcoin/issues/15103 | fix getentropy import check on osx by jameshilliard · Pull Request #15103 · bitcoin/bitcoin · GitHub
101 2020-03-17T08:40:51  <fanquake> opps *vasild
102 2020-03-17T08:42:04  *** Guyver2 has joined #bitcoin-core-dev
103 2020-03-17T08:43:18  <vasild> good that it is going to be deleted now :)
104 2020-03-17T09:00:02  *** maurits has quit IRC
105 2020-03-17T09:09:36  *** someone235 has joined #bitcoin-core-dev
106 2020-03-17T09:22:01  *** OldMiner has joined #bitcoin-core-dev
107 2020-03-17T09:26:23  *** AaronvanW has joined #bitcoin-core-dev
108 2020-03-17T09:37:37  *** marcoagner has joined #bitcoin-core-dev
109 2020-03-17T09:47:57  *** Highway61 has joined #bitcoin-core-dev
110 2020-03-17T10:15:46  *** kinlo has quit IRC
111 2020-03-17T10:19:06  *** votesmith has quit IRC
112 2020-03-17T10:20:43  *** kinlo has joined #bitcoin-core-dev
113 2020-03-17T10:24:49  *** votesmith has joined #bitcoin-core-dev
114 2020-03-17T10:26:18  *** gleec has joined #bitcoin-core-dev
115 2020-03-17T10:32:34  *** oguzkoroglu has joined #bitcoin-core-dev
116 2020-03-17T10:34:33  *** timothy has joined #bitcoin-core-dev
117 2020-03-17T10:44:21  *** votesmith has quit IRC
118 2020-03-17T10:53:23  *** votesmith has joined #bitcoin-core-dev
119 2020-03-17T11:02:20  *** votesmith has quit IRC
120 2020-03-17T11:03:57  *** Mathias63Hudson has joined #bitcoin-core-dev
121 2020-03-17T11:04:44  *** manantial has joined #bitcoin-core-dev
122 2020-03-17T11:23:33  *** votesmith has joined #bitcoin-core-dev
123 2020-03-17T11:25:24  *** Mathias63Hudson has quit IRC
124 2020-03-17T11:35:17  *** votesmith has quit IRC
125 2020-03-17T11:38:10  *** emilengler has joined #bitcoin-core-dev
126 2020-03-17T11:39:48  *** meshcollider has quit IRC
127 2020-03-17T11:52:35  *** votesmith has joined #bitcoin-core-dev
128 2020-03-17T12:00:02  *** OldMiner has quit IRC
129 2020-03-17T12:04:31  *** ghost43 has joined #bitcoin-core-dev
130 2020-03-17T12:16:13  *** meshcollider has joined #bitcoin-core-dev
131 2020-03-17T12:22:30  *** SirVerII has joined #bitcoin-core-dev
132 2020-03-17T12:30:23  *** kristapsk has quit IRC
133 2020-03-17T12:30:44  *** vasild has quit IRC
134 2020-03-17T12:30:44  *** sipa has quit IRC
135 2020-03-17T12:30:44  *** sdaftuar has quit IRC
136 2020-03-17T12:30:44  *** braydonf has quit IRC
137 2020-03-17T12:31:03  *** ghost43 has quit IRC
138 2020-03-17T12:31:04  *** DeanGuss has quit IRC
139 2020-03-17T12:31:04  *** afk11 has quit IRC
140 2020-03-17T12:31:23  *** SiAnDoG__ has quit IRC
141 2020-03-17T12:31:37  *** mryandao has quit IRC
142 2020-03-17T12:32:51  *** sipa has joined #bitcoin-core-dev
143 2020-03-17T12:33:10  *** braydonf has joined #bitcoin-core-dev
144 2020-03-17T12:33:28  *** ghost43 has joined #bitcoin-core-dev
145 2020-03-17T12:34:27  *** mryandao has joined #bitcoin-core-dev
146 2020-03-17T12:36:50  *** vasild has joined #bitcoin-core-dev
147 2020-03-17T12:37:54  *** afk11 has joined #bitcoin-core-dev
148 2020-03-17T12:37:54  *** sdaftuar has joined #bitcoin-core-dev
149 2020-03-17T13:05:29  *** ghost43 has quit IRC
150 2020-03-17T13:06:20  *** ghost43 has joined #bitcoin-core-dev
151 2020-03-17T13:10:23  *** afk11 has quit IRC
152 2020-03-17T13:12:38  *** afk11 has joined #bitcoin-core-dev
153 2020-03-17T13:15:47  *** SiAnDoG__ has joined #bitcoin-core-dev
154 2020-03-17T13:22:37  *** michagogo has quit IRC
155 2020-03-17T13:24:15  *** jonatack has quit IRC
156 2020-03-17T13:26:00  *** jonatack has joined #bitcoin-core-dev
157 2020-03-17T13:27:13  *** belcher has joined #bitcoin-core-dev
158 2020-03-17T13:40:56  *** mdunnio has joined #bitcoin-core-dev
159 2020-03-17T13:46:55  *** bitcoin-git has joined #bitcoin-core-dev
160 2020-03-17T13:46:56  <bitcoin-git> [bitcoin] jnewbery opened pull request #18366: tests: simplify next_block() function in feature_block (master...2020-03-feature-block-next-block) https://github.com/bitcoin/bitcoin/pull/18366
161 2020-03-17T13:46:56  *** bitcoin-git has left #bitcoin-core-dev
162 2020-03-17T13:47:03  *** Guyver2 has quit IRC
163 2020-03-17T14:02:43  *** justanotheruser has joined #bitcoin-core-dev
164 2020-03-17T14:03:34  *** lnostdal has quit IRC
165 2020-03-17T14:10:49  *** AaronvanW has quit IRC
166 2020-03-17T14:20:20  *** ghost43 has quit IRC
167 2020-03-17T14:21:35  *** ghost43 has joined #bitcoin-core-dev
168 2020-03-17T14:25:28  *** Guyver2 has joined #bitcoin-core-dev
169 2020-03-17T14:25:41  *** bitcoin-git has joined #bitcoin-core-dev
170 2020-03-17T14:25:42  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7060d2d97a28...8fc5f2bdf01d
171 2020-03-17T14:25:42  <bitcoin-git> bitcoin/master 612a931 John Newbery: tests: simplify next_block() function in feature_block
172 2020-03-17T14:25:43  <bitcoin-git> bitcoin/master 8fc5f2b MarcoFalke: Merge #18366: tests: simplify next_block() function in feature_block
173 2020-03-17T14:25:45  *** bitcoin-git has left #bitcoin-core-dev
174 2020-03-17T14:26:01  *** bitcoin-git has joined #bitcoin-core-dev
175 2020-03-17T14:26:01  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18366: tests: simplify next_block() function in feature_block (master...2020-03-feature-block-next-block) https://github.com/bitcoin/bitcoin/pull/18366
176 2020-03-17T14:26:02  *** bitcoin-git has left #bitcoin-core-dev
177 2020-03-17T14:31:47  *** AaronvanW has joined #bitcoin-core-dev
178 2020-03-17T14:37:18  *** jorijn_ has quit IRC
179 2020-03-17T14:37:38  *** jorijn has joined #bitcoin-core-dev
180 2020-03-17T14:38:47  *** manantial has quit IRC
181 2020-03-17T14:40:21  *** tsujp has joined #bitcoin-core-dev
182 2020-03-17T14:40:23  *** manantial has joined #bitcoin-core-dev
183 2020-03-17T14:58:49  *** jorijn has quit IRC
184 2020-03-17T14:59:27  *** jorijn has joined #bitcoin-core-dev
185 2020-03-17T15:00:01  *** SirVerII has quit IRC
186 2020-03-17T15:07:26  *** manantial has quit IRC
187 2020-03-17T15:10:39  *** manantial has joined #bitcoin-core-dev
188 2020-03-17T15:18:05  *** ghost43 has quit IRC
189 2020-03-17T15:19:29  *** ghost43 has joined #bitcoin-core-dev
190 2020-03-17T15:21:31  *** r2wj has joined #bitcoin-core-dev
191 2020-03-17T15:30:42  *** justanotheruser has quit IRC
192 2020-03-17T15:30:56  *** tsujp has quit IRC
193 2020-03-17T15:31:23  *** jonatack has quit IRC
194 2020-03-17T15:37:11  *** jonatack has joined #bitcoin-core-dev
195 2020-03-17T15:39:24  *** TheRec has quit IRC
196 2020-03-17T15:48:21  *** justanotheruser has joined #bitcoin-core-dev
197 2020-03-17T15:56:06  *** kristapsk has joined #bitcoin-core-dev
198 2020-03-17T16:03:56  *** bitcoin-git has joined #bitcoin-core-dev
199 2020-03-17T16:03:57  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/8fc5f2bdf01d...1d64dfe4fa05
200 2020-03-17T16:03:57  <bitcoin-git> bitcoin/master a889711 fanquake: rand: remove getentropy() fallback for macOS < 10.12
201 2020-03-17T16:03:58  <bitcoin-git> bitcoin/master f9f210d fanquake: doc: fix GetTimeMicros() comment in random.cpp
202 2020-03-17T16:03:58  <bitcoin-git> bitcoin/master 1d64dfe Wladimir J. van der Laan: Merge #18364: random: remove getentropy() fallback for macOS < 10.12
203 2020-03-17T16:04:00  *** bitcoin-git has left #bitcoin-core-dev
204 2020-03-17T16:04:16  *** bitcoin-git has joined #bitcoin-core-dev
205 2020-03-17T16:04:16  <bitcoin-git> [bitcoin] laanwj merged pull request #18364: random: remove getentropy() fallback for macOS < 10.12 (master...macos_remove_1012_fallback) https://github.com/bitcoin/bitcoin/pull/18364
206 2020-03-17T16:04:17  *** bitcoin-git has left #bitcoin-core-dev
207 2020-03-17T16:05:39  *** ghost43 has quit IRC
208 2020-03-17T16:06:46  *** tryphe_ has joined #bitcoin-core-dev
209 2020-03-17T16:06:55  *** ghost43 has joined #bitcoin-core-dev
210 2020-03-17T16:09:41  *** tryphe has quit IRC
211 2020-03-17T16:12:48  *** oguz_ has joined #bitcoin-core-dev
212 2020-03-17T16:15:13  *** oguzkoroglu has quit IRC
213 2020-03-17T16:26:19  *** Talkless has joined #bitcoin-core-dev
214 2020-03-17T16:26:23  *** ghost43 has quit IRC
215 2020-03-17T16:27:39  *** ghost43 has joined #bitcoin-core-dev
216 2020-03-17T16:30:10  *** captjakk has joined #bitcoin-core-dev
217 2020-03-17T16:33:07  *** TheRec has joined #bitcoin-core-dev
218 2020-03-17T16:33:07  *** TheRec has joined #bitcoin-core-dev
219 2020-03-17T16:38:45  *** Bullit has joined #bitcoin-core-dev
220 2020-03-17T16:52:05  *** oguz_ has quit IRC
221 2020-03-17T17:03:25  *** jb55 has joined #bitcoin-core-dev
222 2020-03-17T17:08:50  *** bitcoin-git has joined #bitcoin-core-dev
223 2020-03-17T17:08:50  <bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/1d64dfe4fa05...d2d0a04a661f
224 2020-03-17T17:08:51  <bitcoin-git> bitcoin/master cb4eec1 practicalswift: tests: Add fuzzing harness for count_seconds(...)
225 2020-03-17T17:08:51  <bitcoin-git> bitcoin/master 0579a27 practicalswift: tests: Add fuzzing harness for CBlockHeader
226 2020-03-17T17:08:51  <bitcoin-git> bitcoin/master 7726f3b practicalswift: tests: Add fuzzing harness for CFeeRate
227 2020-03-17T17:08:53  *** bitcoin-git has left #bitcoin-core-dev
228 2020-03-17T17:09:10  *** bitcoin-git has joined #bitcoin-core-dev
229 2020-03-17T17:09:10  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18353: tests: Add fuzzing harnesses for classes CBlockHeader, CFeeRate and various functions (master...fuzzers-coverage) https://github.com/bitcoin/bitcoin/pull/18353
230 2020-03-17T17:09:11  *** bitcoin-git has left #bitcoin-core-dev
231 2020-03-17T17:23:56  *** ghost43 has quit IRC
232 2020-03-17T17:24:57  *** ghost43 has joined #bitcoin-core-dev
233 2020-03-17T17:28:58  *** molly has joined #bitcoin-core-dev
234 2020-03-17T17:32:01  *** mol has quit IRC
235 2020-03-17T17:39:11  *** bitcoin-git has joined #bitcoin-core-dev
236 2020-03-17T17:39:12  <bitcoin-git> [bitcoin] MarcoFalke pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/d2d0a04a661f...ad04f0d8a533
237 2020-03-17T17:39:12  <bitcoin-git> bitcoin/master f31fc0e John Newbery: [tests] fix flake8 warnings in script.py and bignum.py
238 2020-03-17T17:39:12  <bitcoin-git> bitcoin/master 1dc68ae John Newbery: [tests] add function comments to bignum
239 2020-03-17T17:39:13  <bitcoin-git> bitcoin/master 9a60bef John Newbery: [tests] don't encode the integer size in bignum
240 2020-03-17T17:39:14  *** bitcoin-git has left #bitcoin-core-dev
241 2020-03-17T17:39:51  *** bitcoin-git has joined #bitcoin-core-dev
242 2020-03-17T17:39:51  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17319: Tests: remove bignum module (master...2019-10-bignum) https://github.com/bitcoin/bitcoin/pull/17319
243 2020-03-17T17:39:52  *** bitcoin-git has left #bitcoin-core-dev
244 2020-03-17T18:00:02  *** r2wj has quit IRC
245 2020-03-17T18:10:10  *** owowo has quit IRC
246 2020-03-17T18:15:02  *** owowo has joined #bitcoin-core-dev
247 2020-03-17T18:21:57  *** jchris has joined #bitcoin-core-dev
248 2020-03-17T18:28:55  *** bitcoin-git has joined #bitcoin-core-dev
249 2020-03-17T18:28:56  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ad04f0d8a533...39497d1f3268
250 2020-03-17T18:28:56  <bitcoin-git> bitcoin/master ec30a79 Gregory Sanders: Fix UB with bench on genesis block
251 2020-03-17T18:28:57  <bitcoin-git> bitcoin/master 39497d1 MarcoFalke: Merge #15283: log: Fix UB with bench on genesis block
252 2020-03-17T18:28:58  *** bitcoin-git has left #bitcoin-core-dev
253 2020-03-17T18:30:26  *** bitcoin-git has joined #bitcoin-core-dev
254 2020-03-17T18:30:26  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15283: log: Fix UB with bench on genesis block (master...ub_genesis_bench) https://github.com/bitcoin/bitcoin/pull/15283
255 2020-03-17T18:30:27  *** bitcoin-git has left #bitcoin-core-dev
256 2020-03-17T18:35:54  *** pinheadmz has quit IRC
257 2020-03-17T18:46:16  *** face has quit IRC
258 2020-03-17T18:51:20  *** DeanGuss has joined #bitcoin-core-dev
259 2020-03-17T18:52:48  *** timothy has quit IRC
260 2020-03-17T18:53:36  *** gleec has quit IRC
261 2020-03-17T18:53:58  *** pinheadmz has joined #bitcoin-core-dev
262 2020-03-17T18:56:30  *** ghost43 has quit IRC
263 2020-03-17T18:57:24  *** ghost43 has joined #bitcoin-core-dev
264 2020-03-17T19:03:59  *** pinheadmz has quit IRC
265 2020-03-17T19:11:20  *** afk11` has joined #bitcoin-core-dev
266 2020-03-17T19:11:41  *** nanotube has quit IRC
267 2020-03-17T19:12:23  *** afk11 has quit IRC
268 2020-03-17T19:13:54  *** ghost43 has quit IRC
269 2020-03-17T19:14:19  *** nanotube has joined #bitcoin-core-dev
270 2020-03-17T19:14:44  *** ghost43 has joined #bitcoin-core-dev
271 2020-03-17T19:16:32  *** Talkless has quit IRC
272 2020-03-17T19:24:58  *** pinheadmz has joined #bitcoin-core-dev
273 2020-03-17T19:27:40  *** bitcoin-git has joined #bitcoin-core-dev
274 2020-03-17T19:27:40  <bitcoin-git> [bitcoin] sipa opened pull request #18367: Avoid strncopy for CMessageHeader::pchCommand (master...202003_strncopy_warning) https://github.com/bitcoin/bitcoin/pull/18367
275 2020-03-17T19:27:41  *** bitcoin-git has left #bitcoin-core-dev
276 2020-03-17T19:34:37  *** ghost43 has quit IRC
277 2020-03-17T19:35:54  *** ghost43 has joined #bitcoin-core-dev
278 2020-03-17T19:44:03  *** vasild has quit IRC
279 2020-03-17T19:49:40  *** TheRec has quit IRC
280 2020-03-17T19:50:48  *** vasild has joined #bitcoin-core-dev
281 2020-03-17T20:03:11  *** TheRec has joined #bitcoin-core-dev
282 2020-03-17T20:16:23  *** ghost43 has quit IRC
283 2020-03-17T20:16:39  *** ghost43 has joined #bitcoin-core-dev
284 2020-03-17T20:22:42  *** mol has joined #bitcoin-core-dev
285 2020-03-17T20:25:27  *** molly has quit IRC
286 2020-03-17T20:30:41  *** Chris_Stewart_5 has quit IRC
287 2020-03-17T20:32:25  *** mol has quit IRC
288 2020-03-17T20:32:47  *** Chris_Stewart_5 has joined #bitcoin-core-dev
289 2020-03-17T20:36:00  *** bitcoin-git has joined #bitcoin-core-dev
290 2020-03-17T20:36:02  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/39497d1f3268...ce87d5613a55
291 2020-03-17T20:36:02  <bitcoin-git> bitcoin/master fa70ccc MarcoFalke: scheduler: Use C++11 member initialization, add shutdown assert
292 2020-03-17T20:36:02  <bitcoin-git> bitcoin/master fadafb8 MarcoFalke: scheduler: Make schedule* methods type safe
293 2020-03-17T20:36:03  <bitcoin-git> bitcoin/master fa36f3a MarcoFalke: refactor: move DUMP_BANS_INTERVAL to banman.h
294 2020-03-17T20:36:13  *** bitcoin-git has left #bitcoin-core-dev
295 2020-03-17T20:36:30  *** bitcoin-git has joined #bitcoin-core-dev
296 2020-03-17T20:36:31  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18289: refactor: Make scheduler methods type safe (master...2003-schedTypeChrono) https://github.com/bitcoin/bitcoin/pull/18289
297 2020-03-17T20:36:43  *** bitcoin-git has left #bitcoin-core-dev
298 2020-03-17T20:38:55  *** emilengler has quit IRC
299 2020-03-17T20:57:01  *** GoldmanSats has joined #bitcoin-core-dev
300 2020-03-17T21:00:02  *** jchris has quit IRC
301 2020-03-17T21:05:17  *** mdunnio has quit IRC
302 2020-03-17T21:22:30  *** Eartaker has joined #bitcoin-core-dev
303 2020-03-17T21:27:41  *** sonofhan has joined #bitcoin-core-dev
304 2020-03-17T21:37:07  *** TheRec has quit IRC
305 2020-03-17T21:43:36  *** Krellan_ has joined #bitcoin-core-dev
306 2020-03-17T21:50:53  *** TheRec has joined #bitcoin-core-dev
307 2020-03-17T21:50:53  *** TheRec has joined #bitcoin-core-dev
308 2020-03-17T21:57:07  *** kinlo has quit IRC
309 2020-03-17T22:03:13  *** manantial has quit IRC
310 2020-03-17T22:03:49  *** sonofhan has quit IRC
311 2020-03-17T22:06:00  *** tryphe_ is now known as tryphe
312 2020-03-17T22:15:20  *** kinlo has joined #bitcoin-core-dev
313 2020-03-17T22:21:18  *** justanotheruser has quit IRC
314 2020-03-17T22:24:54  *** mol has joined #bitcoin-core-dev
315 2020-03-17T22:29:21  *** captjakk has quit IRC
316 2020-03-17T22:29:54  *** captjakk has joined #bitcoin-core-dev
317 2020-03-17T22:34:18  *** captjakk has quit IRC
318 2020-03-17T22:36:41  *** Dean_Guss has joined #bitcoin-core-dev
319 2020-03-17T22:37:28  *** justanotheruser has joined #bitcoin-core-dev
320 2020-03-17T22:38:48  *** DeanWeen has joined #bitcoin-core-dev
321 2020-03-17T22:38:52  *** Guyver2 has quit IRC
322 2020-03-17T22:40:23  *** DeanGuss has quit IRC
323 2020-03-17T22:41:43  *** captjakk has joined #bitcoin-core-dev
324 2020-03-17T22:42:23  *** Dean_Guss has quit IRC
325 2020-03-17T22:59:19  *** someone235 has quit IRC
326 2020-03-17T23:04:52  *** captjakk has quit IRC
327 2020-03-17T23:15:06  *** captjakk has joined #bitcoin-core-dev
328 2020-03-17T23:39:59  <fanquake> aj can you follow up in #13990
329 2020-03-17T23:40:01  <gribble> https://github.com/bitcoin/bitcoin/issues/13990 | Allow fee estimation to work with lower fees by ajtowns · Pull Request #13990 · bitcoin/bitcoin · GitHub
330 2020-03-17T23:40:22  <aj> fanquake: yeah
331 2020-03-17T23:47:25  *** mryandao has quit IRC
332 2020-03-17T23:49:33  *** mryandao has joined #bitcoin-core-dev
333 2020-03-17T23:50:44  *** captjakk has quit IRC
334 2020-03-17T23:53:06  *** apaval has joined #bitcoin-core-dev
335 2020-03-17T23:54:05  *** apaval has quit IRC
336 2020-03-17T23:54:18  *** apaval has joined #bitcoin-core-dev
337 2020-03-17T23:57:23  *** mryandao has quit IRC