1 2020-03-18T00:00:02  *** Eartaker has quit IRC
  2 2020-03-18T00:04:10  *** apaval has quit IRC
  3 2020-03-18T00:04:21  *** apaval has joined #bitcoin-core-dev
  4 2020-03-18T00:04:36  *** sonofhan has joined #bitcoin-core-dev
  5 2020-03-18T00:05:45  *** apaval has quit IRC
  6 2020-03-18T00:06:16  *** mryandao has joined #bitcoin-core-dev
  7 2020-03-18T00:09:32  *** apaval_ has joined #bitcoin-core-dev
  8 2020-03-18T00:09:49  *** sonofhan has quit IRC
  9 2020-03-18T00:21:48  *** dscho has joined #bitcoin-core-dev
 10 2020-03-18T00:22:02  *** marcoagner has quit IRC
 11 2020-03-18T00:22:03  *** bitcoin-git has joined #bitcoin-core-dev
 12 2020-03-18T00:22:03  <bitcoin-git> [bitcoin] sipa closed pull request #18367: Avoid strncpy for CMessageHeader::pchCommand (master...202003_strncopy_warning) https://github.com/bitcoin/bitcoin/pull/18367
 13 2020-03-18T00:22:04  *** bitcoin-git has left #bitcoin-core-dev
 14 2020-03-18T00:53:58  *** Krellan_ has quit IRC
 15 2020-03-18T00:54:26  *** Krellan_ has joined #bitcoin-core-dev
 16 2020-03-18T00:54:35  *** justanotheruser has quit IRC
 17 2020-03-18T01:00:12  *** Krellan_ has quit IRC
 18 2020-03-18T01:09:53  *** justanotheruser has joined #bitcoin-core-dev
 19 2020-03-18T01:13:19  <fanquake> sipa did you want to review #16995 ?
 20 2020-03-18T01:13:21  <gribble> https://github.com/bitcoin/bitcoin/issues/16995 | Fix gcc 9 warnings by laanwj · Pull Request #16995 · bitcoin/bitcoin · GitHub
 21 2020-03-18T01:13:29  <sipa> fanquake: of course
 22 2020-03-18T01:14:10  * fanquake moves away from the merge button
 23 2020-03-18T01:14:34  <sipa> give me 15 min
 24 2020-03-18T01:14:51  <fanquake> No worries, no rush
 25 2020-03-18T01:19:47  *** jb55 has quit IRC
 26 2020-03-18T01:28:25  *** Highway61 has quit IRC
 27 2020-03-18T01:42:20  *** captjakk has joined #bitcoin-core-dev
 28 2020-03-18T02:01:41  *** AaronvanW has quit IRC
 29 2020-03-18T02:04:35  *** ddustin has joined #bitcoin-core-dev
 30 2020-03-18T02:04:45  *** captjakk has joined #bitcoin-core-dev
 31 2020-03-18T02:06:10  *** sonofhan has joined #bitcoin-core-dev
 32 2020-03-18T02:10:43  *** sonofhan has quit IRC
 33 2020-03-18T02:21:51  *** Krellan_ has joined #bitcoin-core-dev
 34 2020-03-18T02:26:48  *** mol has quit IRC
 35 2020-03-18T02:27:36  *** mol has joined #bitcoin-core-dev
 36 2020-03-18T02:28:10  *** belcher has quit IRC
 37 2020-03-18T02:28:32  *** justanotheruser has quit IRC
 38 2020-03-18T02:30:59  *** ddustin has quit IRC
 39 2020-03-18T02:33:49  *** Krellan_ has quit IRC
 40 2020-03-18T03:00:02  *** dscho has quit IRC
 41 2020-03-18T03:13:16  *** bitcoin-git has joined #bitcoin-core-dev
 42 2020-03-18T03:13:16  <bitcoin-git> [bitcoin] fanquake opened pull request #18371: test: use fs namespace in dbwrapper unicodepath test (master...dbwrapper_use_fs_namespace) https://github.com/bitcoin/bitcoin/pull/18371
 43 2020-03-18T03:13:17  *** bitcoin-git has left #bitcoin-core-dev
 44 2020-03-18T03:14:14  *** deacyde has quit IRC
 45 2020-03-18T03:22:23  *** SynOps has joined #bitcoin-core-dev
 46 2020-03-18T03:33:38  *** Krellan_ has joined #bitcoin-core-dev
 47 2020-03-18T03:35:48  *** felixfoertsch23 has joined #bitcoin-core-dev
 48 2020-03-18T03:37:29  *** felixfoertsch has quit IRC
 49 2020-03-18T03:37:41  *** Rapsil has quit IRC
 50 2020-03-18T03:55:25  *** Randolf has joined #bitcoin-core-dev
 51 2020-03-18T04:06:58  *** sonofhan has joined #bitcoin-core-dev
 52 2020-03-18T04:11:28  *** sonofhan has quit IRC
 53 2020-03-18T04:50:59  *** justanotheruser has joined #bitcoin-core-dev
 54 2020-03-18T05:46:26  *** bitcoin-git has joined #bitcoin-core-dev
 55 2020-03-18T05:46:26  <bitcoin-git> [bitcoin] sipa opened pull request #18374: Bugfix in bn2vch: avoid excessive padding (master...202003_fix_bn2vch) https://github.com/bitcoin/bitcoin/pull/18374
 56 2020-03-18T05:46:27  *** bitcoin-git has left #bitcoin-core-dev
 57 2020-03-18T05:47:53  *** tryphe_ has joined #bitcoin-core-dev
 58 2020-03-18T05:48:42  *** kristapsk_ has joined #bitcoin-core-dev
 59 2020-03-18T05:49:59  *** SiAnDoG__ has quit IRC
 60 2020-03-18T05:50:17  *** SiAnDoG__ has joined #bitcoin-core-dev
 61 2020-03-18T05:50:29  *** kristapsk has quit IRC
 62 2020-03-18T05:50:59  *** niska` has quit IRC
 63 2020-03-18T05:51:09  *** achow101 has quit IRC
 64 2020-03-18T05:51:13  *** tryphe has quit IRC
 65 2020-03-18T05:51:20  *** wraithm has quit IRC
 66 2020-03-18T05:51:29  *** ghost43 has quit IRC
 67 2020-03-18T05:51:40  *** ghost43_ has joined #bitcoin-core-dev
 68 2020-03-18T05:52:26  *** niska has joined #bitcoin-core-dev
 69 2020-03-18T05:52:27  *** achow101 has joined #bitcoin-core-dev
 70 2020-03-18T05:54:20  *** wraithm has joined #bitcoin-core-dev
 71 2020-03-18T05:59:20  *** Highway61 has joined #bitcoin-core-dev
 72 2020-03-18T06:00:01  *** SynOps has quit IRC
 73 2020-03-18T06:03:47  *** Karyon has quit IRC
 74 2020-03-18T06:07:57  *** sonofhan has joined #bitcoin-core-dev
 75 2020-03-18T06:12:34  *** sonofhan has quit IRC
 76 2020-03-18T06:19:31  *** Karyon has joined #bitcoin-core-dev
 77 2020-03-18T06:22:19  *** ldoguin has joined #bitcoin-core-dev
 78 2020-03-18T06:38:50  *** niknebis has joined #bitcoin-core-dev
 79 2020-03-18T06:43:35  *** kristapsk_ has quit IRC
 80 2020-03-18T06:43:35  *** ghost43_ has quit IRC
 81 2020-03-18T06:43:56  *** kristapsk_ has joined #bitcoin-core-dev
 82 2020-03-18T06:44:08  *** niknebis has quit IRC
 83 2020-03-18T06:44:22  *** ghost43 has joined #bitcoin-core-dev
 84 2020-03-18T07:00:37  *** nik23 has joined #bitcoin-core-dev
 85 2020-03-18T07:10:36  *** nik23 has quit IRC
 86 2020-03-18T07:11:43  * fanquake kills his terminal
 87 2020-03-18T07:11:55  * fanquake realises he should have respected LLDBs advice that there were too many  frame variables to print 
 88 2020-03-18T07:25:02  <fanquake> vasild: see #18372 for why master is broken
 89 2020-03-18T07:25:03  <gribble> https://github.com/bitcoin/bitcoin/issues/18372 | sanitizer: heap-use-after-free in checkinputs_test · Issue #18372 · bitcoin/bitcoin · GitHub
 90 2020-03-18T07:27:59  <vasild> fanquake: so, its not the .md changes that broke it ;D
 91 2020-03-18T07:28:11  <vasild> any idea how did this sneak into master?
 92 2020-03-18T07:29:41  <fanquake> vasild: no, I haven't investigated yet
 93 2020-03-18T07:32:17  <vasild> maybe one of 1. it is undeterministic failure and the PR that introduced it was lucky to get green. or 2. somebody merged a red/broken PR or 3. changes in the travis environment that revealed an existent problem.
 94 2020-03-18T07:40:46  *** vasild_ has joined #bitcoin-core-dev
 95 2020-03-18T07:43:43  *** vasild has quit IRC
 96 2020-03-18T07:43:44  *** vasild_ is now known as vasild
 97 2020-03-18T07:49:55  *** manantial has joined #bitcoin-core-dev
 98 2020-03-18T07:59:10  *** justanotheruser has quit IRC
 99 2020-03-18T08:07:43  <aj> vasild: or it only comes about because of two changes that were independently okay
100 2020-03-18T08:08:55  *** sonofhan has joined #bitcoin-core-dev
101 2020-03-18T08:13:25  *** sonofhan has quit IRC
102 2020-03-18T08:14:41  *** justanotheruser has joined #bitcoin-core-dev
103 2020-03-18T08:20:38  *** real_or_random has quit IRC
104 2020-03-18T08:21:30  *** real_or_random has joined #bitcoin-core-dev
105 2020-03-18T08:22:23  *** kristapsk_ has quit IRC
106 2020-03-18T08:26:32  *** ghost43 has quit IRC
107 2020-03-18T08:27:50  *** ghost43 has joined #bitcoin-core-dev
108 2020-03-18T08:40:32  <vasild> aj: right! lets see...
109 2020-03-18T09:00:01  *** ldoguin has quit IRC
110 2020-03-18T09:09:31  *** oguzkoroglu has joined #bitcoin-core-dev
111 2020-03-18T09:20:15  *** marcoagner has joined #bitcoin-core-dev
112 2020-03-18T09:22:17  *** true-asset has joined #bitcoin-core-dev
113 2020-03-18T09:59:26  *** Lightsword_ has joined #bitcoin-core-dev
114 2020-03-18T10:00:32  *** IGHOR_ has joined #bitcoin-core-dev
115 2020-03-18T10:00:45  *** raj_ has joined #bitcoin-core-dev
116 2020-03-18T10:00:46  *** willcl_ark__ has joined #bitcoin-core-dev
117 2020-03-18T10:01:52  *** kanzure_ has joined #bitcoin-core-dev
118 2020-03-18T10:02:18  *** nehan_ has joined #bitcoin-core-dev
119 2020-03-18T10:04:49  *** raj_149 has quit IRC
120 2020-03-18T10:04:49  *** nehan has quit IRC
121 2020-03-18T10:04:49  *** willcl_ark_ has quit IRC
122 2020-03-18T10:04:49  *** Lightsword has quit IRC
123 2020-03-18T10:04:49  *** pingwindyktator has quit IRC
124 2020-03-18T10:04:49  *** treyzania has quit IRC
125 2020-03-18T10:04:49  *** kanzure has quit IRC
126 2020-03-18T10:04:49  *** IGHOR has quit IRC
127 2020-03-18T10:04:49  *** Lightsword_ is now known as Lightsword
128 2020-03-18T10:04:57  *** treyzania has joined #bitcoin-core-dev
129 2020-03-18T10:06:04  *** pingwindyktator has joined #bitcoin-core-dev
130 2020-03-18T10:09:55  *** sonofhan has joined #bitcoin-core-dev
131 2020-03-18T10:11:09  *** ghost43 has quit IRC
132 2020-03-18T10:12:27  *** timothy has joined #bitcoin-core-dev
133 2020-03-18T10:12:28  *** ghost43 has joined #bitcoin-core-dev
134 2020-03-18T10:14:45  *** sonofhan has quit IRC
135 2020-03-18T10:23:14  *** kristapsk has joined #bitcoin-core-dev
136 2020-03-18T10:43:56  *** apaval_ has quit IRC
137 2020-03-18T10:44:18  *** apaval_ has joined #bitcoin-core-dev
138 2020-03-18T11:04:11  *** Malvina89Heidenr has joined #bitcoin-core-dev
139 2020-03-18T11:14:38  *** bitcoin-git has joined #bitcoin-core-dev
140 2020-03-18T11:14:38  <bitcoin-git> [bitcoin] AleGiovanardi opened pull request #18375: Merge pull request #1 from bitcoin/master (master...master) https://github.com/bitcoin/bitcoin/pull/18375
141 2020-03-18T11:14:40  *** bitcoin-git has left #bitcoin-core-dev
142 2020-03-18T11:15:01  *** bitcoin-git has joined #bitcoin-core-dev
143 2020-03-18T11:15:01  <bitcoin-git> [bitcoin] AleGiovanardi closed pull request #18375: Merge pull request #1 from bitcoin/master (master...master) https://github.com/bitcoin/bitcoin/pull/18375
144 2020-03-18T11:15:02  *** bitcoin-git has left #bitcoin-core-dev
145 2020-03-18T11:15:47  *** AaronvanW has joined #bitcoin-core-dev
146 2020-03-18T11:17:05  *** manantial has quit IRC
147 2020-03-18T11:17:35  *** manantial has joined #bitcoin-core-dev
148 2020-03-18T11:49:49  *** braydonf has quit IRC
149 2020-03-18T11:50:15  *** braydonf has joined #bitcoin-core-dev
150 2020-03-18T12:00:02  *** true-asset has quit IRC
151 2020-03-18T12:05:21  *** bitcoin-git has joined #bitcoin-core-dev
152 2020-03-18T12:05:22  <bitcoin-git> [bitcoin] vasild opened pull request #18376: net: fix use-after-free in tests (master...fix_use_after_free_issue18372) https://github.com/bitcoin/bitcoin/pull/18376
153 2020-03-18T12:05:22  *** bitcoin-git has left #bitcoin-core-dev
154 2020-03-18T12:10:55  *** sonofhan has joined #bitcoin-core-dev
155 2020-03-18T12:15:39  *** sonofhan has quit IRC
156 2020-03-18T12:22:10  *** jjj1 has joined #bitcoin-core-dev
157 2020-03-18T12:48:17  *** sipsorcery has quit IRC
158 2020-03-18T12:49:17  *** sipsorcery has joined #bitcoin-core-dev
159 2020-03-18T12:50:45  *** Malvina89Heidenr has quit IRC
160 2020-03-18T12:51:11  *** emilengler has joined #bitcoin-core-dev
161 2020-03-18T13:04:37  *** emilengler has quit IRC
162 2020-03-18T13:04:50  *** emilengler has joined #bitcoin-core-dev
163 2020-03-18T13:08:07  *** meshcollider has quit IRC
164 2020-03-18T13:08:20  *** vasild has quit IRC
165 2020-03-18T13:08:33  *** vasild has joined #bitcoin-core-dev
166 2020-03-18T13:12:18  *** kanzure_ is now known as kanzure
167 2020-03-18T13:26:28  *** meshcollider has joined #bitcoin-core-dev
168 2020-03-18T13:38:39  *** Guyver2 has joined #bitcoin-core-dev
169 2020-03-18T13:42:06  *** captjakk_ has joined #bitcoin-core-dev
170 2020-03-18T13:43:33  *** bitcoin-git has joined #bitcoin-core-dev
171 2020-03-18T13:43:33  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ce87d5613a55...3a8d25064e70
172 2020-03-18T13:43:34  <bitcoin-git> bitcoin/master 6afaf2f fanquake: test: use fs namespace in dbwrapper unicodepath test
173 2020-03-18T13:43:34  <bitcoin-git> bitcoin/master 3a8d250 MarcoFalke: Merge #18371: test: use fs namespace in dbwrapper unicodepath test
174 2020-03-18T13:43:36  *** bitcoin-git has left #bitcoin-core-dev
175 2020-03-18T13:43:45  *** Krellan__ has joined #bitcoin-core-dev
176 2020-03-18T13:43:53  *** bitcoin-git has joined #bitcoin-core-dev
177 2020-03-18T13:43:53  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18371: test: use fs namespace in dbwrapper unicodepath test (master...dbwrapper_use_fs_namespace) https://github.com/bitcoin/bitcoin/pull/18371
178 2020-03-18T13:43:54  *** bitcoin-git has left #bitcoin-core-dev
179 2020-03-18T13:44:15  *** captjakk has quit IRC
180 2020-03-18T13:44:36  *** kanzure has quit IRC
181 2020-03-18T13:44:36  *** Karyon has quit IRC
182 2020-03-18T13:44:57  *** Krellan_ has quit IRC
183 2020-03-18T13:46:31  *** kanzure has joined #bitcoin-core-dev
184 2020-03-18T13:48:03  *** Karyon has joined #bitcoin-core-dev
185 2020-03-18T13:49:03  *** ghost43 has quit IRC
186 2020-03-18T13:49:17  *** ghost43 has joined #bitcoin-core-dev
187 2020-03-18T13:59:47  *** mdunnio has joined #bitcoin-core-dev
188 2020-03-18T14:01:58  *** cfields_ is now known as cfields
189 2020-03-18T14:02:29  <vasild> MarcoFalke: wrt https://github.com/bitcoin/bitcoin/pull/18376#discussion_r394349862 - I will change it as you suggest to just "=" once travis confirms the fix (if I push now it will restart the tests)
190 2020-03-18T14:03:19  <vasild> now, if we can explain why travis was green on the PR that introduced the issue I will sleep well tonight
191 2020-03-18T14:11:55  *** sonofhan has joined #bitcoin-core-dev
192 2020-03-18T14:16:33  *** sonofhan has quit IRC
193 2020-03-18T14:34:12  *** kristapsk_ has joined #bitcoin-core-dev
194 2020-03-18T14:34:20  *** kristapsk has quit IRC
195 2020-03-18T14:42:36  *** Randolf has quit IRC
196 2020-03-18T14:45:46  *** oguzkoroglu has quit IRC
197 2020-03-18T14:49:35  *** AaronvanW has quit IRC
198 2020-03-18T14:51:34  *** TheFuzzStone[m] has quit IRC
199 2020-03-18T14:51:34  *** mrostecki has quit IRC
200 2020-03-18T14:55:31  *** TheFuzzStone[m] has joined #bitcoin-core-dev
201 2020-03-18T14:55:33  *** mrostecki has joined #bitcoin-core-dev
202 2020-03-18T14:56:15  *** bitcoin-git has joined #bitcoin-core-dev
203 2020-03-18T14:56:15  <bitcoin-git> [bitcoin] brakmic opened pull request #18377: build: fix libevent linking errors for bench-only builds (master...bench-compilation) https://github.com/bitcoin/bitcoin/pull/18377
204 2020-03-18T14:56:17  *** bitcoin-git has left #bitcoin-core-dev
205 2020-03-18T15:00:02  *** jjj1 has quit IRC
206 2020-03-18T15:03:28  *** belcher has joined #bitcoin-core-dev
207 2020-03-18T15:06:44  *** brakmic has joined #bitcoin-core-dev
208 2020-03-18T15:13:06  *** lukedashjr has joined #bitcoin-core-dev
209 2020-03-18T15:14:37  *** sipsorcery has quit IRC
210 2020-03-18T15:15:03  *** luke-jr has quit IRC
211 2020-03-18T15:17:24  *** lukedashjr is now known as luke-jr
212 2020-03-18T15:21:58  *** Perlboy has joined #bitcoin-core-dev
213 2020-03-18T15:46:34  <willcl_ark> Is it worth me opening an issue for this project related to with a specific clang version segfaulting during tests, if the solution is to simply upgrade clang?
214 2020-03-18T15:47:39  <fanquake> willcl_ark: what version of Clang?
215 2020-03-18T15:48:11  <willcl_ark> fanquake: 11.0.0 (bundled with commandlinetools). Upgrading to 11.0.3 fixed.
216 2020-03-18T15:48:22  <fanquake> So Apple Clang?
217 2020-03-18T15:48:27  <willcl_ark> Indeed
218 2020-03-18T15:48:37  <fanquake> Was the issue related to stack checking?
219 2020-03-18T15:48:48  <fanquake> Possibly libsecp related?
220 2020-03-18T15:49:20  <willcl_ark> yes libsecp test segfaulted too. wait I'll just recall the error
221 2020-03-18T15:49:36  <willcl_ark> it was unaligned stack stuff
222 2020-03-18T15:50:04  <willcl_ark> I guess this is pretty much the same issue: https://github.com/jedisct1/libsodium/issues/848
223 2020-03-18T15:50:27  <fanquake> Yea I assume you're seeing https://github.com/bitcoin-core/secp256k1/issues/674
224 2020-03-18T15:51:17  <willcl_ark> ah great, I just wanted to make sure it was documented within this project in some way :)
225 2020-03-18T15:52:26  <fanquake> willcl_ark: no worries, thanks for asking
226 2020-03-18T15:54:09  *** andrewtoth has joined #bitcoin-core-dev
227 2020-03-18T15:57:20  *** sipsorcery has joined #bitcoin-core-dev
228 2020-03-18T16:12:55  *** sonofhan has joined #bitcoin-core-dev
229 2020-03-18T16:17:27  *** sonofhan has quit IRC
230 2020-03-18T16:20:42  *** shaunsun has joined #bitcoin-core-dev
231 2020-03-18T16:20:49  *** shaunsun_ has joined #bitcoin-core-dev
232 2020-03-18T16:24:15  *** sonofhan has joined #bitcoin-core-dev
233 2020-03-18T16:26:33  <stevenroose> I'd like to get a clear summary of the peering strategy for Core nodes. Especially regarding limits (incoming and outgoing) and how the limit applies to `connect=`. Is that written up somewhere?
234 2020-03-18T16:27:39  <stevenroose> Personally I assumed that `connect=` configs would have no limit as they are a clear order "make sure you connect to this peer always". But it seems that they might fall under the 8- (or 12?) peer outgoing connection limit?
235 2020-03-18T16:28:09  <stevenroose> These policies are quite hard to find in the code, tbh. Hence my Q here :)
236 2020-03-18T16:28:43  <harding> stevenroose: the -help documentation for connect= says "Connect only to the specified node"
237 2020-03-18T16:29:17  <harding> Oh, your question is how many times you can specify -connect?
238 2020-03-18T16:29:18  <stevenroose> Yeah..
239 2020-03-18T16:29:47  <stevenroose> No mostly it is "if I specify 30, will it connect to all 30 or will it stop at the 8 (or 12?) limit?"
240 2020-03-18T16:29:47  <sipa> i think 8 times
241 2020-03-18T16:30:22  <stevenroose> IMO "Connect only to the specified node" should be "Connect to the specified node"
242 2020-03-18T16:30:30  <sipa> no
243 2020-03-18T16:30:33  *** ddustin has joined #bitcoin-core-dev
244 2020-03-18T16:30:33  <stevenroose> Hmm no
245 2020-03-18T16:30:41  <sipa> -connect disables the normal automatic connection mechanism
246 2020-03-18T16:30:43  <stevenroose> Indeed, because that doesn't rule out that it doesn't connect to others.
247 2020-03-18T16:31:33  <stevenroose> sipa: so your understanding is as well that with 9 `connect=`'s, it will just pick 8 of them to connect to? And probably pick the 9th if one of the 9 goes down?
248 2020-03-18T16:31:35  *** ddustin has quit IRC
249 2020-03-18T16:32:18  <sipa> stevenroose: i believe it's something like that
250 2020-03-18T16:32:25  <stevenroose> Is there a way to make a node connect to *all* `connect=`'s? By upping the limit? By config? Or can that only be done through a code change?
251 2020-03-18T16:32:39  <sipa> no
252 2020-03-18T16:32:42  <sipa> and yes, intentionally
253 2020-03-18T16:33:29  <stevenroose> The docs don't mention the limit, though: "This option can be specified multiple times to connect to multiple nodes."
254 2020-03-18T16:33:45  <sipa> (because a while ago there was a flurry of people who believed that more connections means better, faster, safer, ...; and were causing the network to run out of connectable ports)
255 2020-03-18T16:34:10  <stevenroose> Hmm. Well I understand that having a `-outgoinglimit` flag is exploitable.
256 2020-03-18T16:34:23  <stevenroose> But letting `-connect=` go over the limit is way harder to exploit.
257 2020-03-18T16:34:32  <yevaud> if you think you need more outgoing connections, you almost certainly don't.
258 2020-03-18T16:34:33  <stevenroose> These people would have to keep adding nodes to their config files.
259 2020-03-18T16:34:57  <sipa> yeah, generally there is no point
260 2020-03-18T16:34:59  <stevenroose> yevaud: special-case situation
261 2020-03-18T16:36:03  <yevaud> there's no special cases that justify it, honestly. manually pinning certain peers causes a bunch of issues.
262 2020-03-18T16:37:07  <yevaud> for running nodes behind a network of external gateways, sure, but that's a very specific use case which doesn't need a large number of them.
263 2020-03-18T16:37:20  <stevenroose> yevaud: briefly explained we're trying to bridge a bunch of internla nodes that only interconnect with the public network through 2 bridges. And we want to ensure the bridges connect to the internal nodes but also at least a few public connections
264 2020-03-18T16:37:42  <sipa> stevenroose: you can use -addnode instead
265 2020-03-18T16:38:03  <yevaud> you want addnode, which has a different connection pool to outgoing connections.
266 2020-03-18T16:38:04  <sipa> which works like -connect, but doesn't disable the normal random peer mechanism
267 2020-03-18T16:39:16  <yevaud> and you have that backwards anyway.
268 2020-03-18T16:39:36  <yevaud> internal nodes want to be connecting to the bridges, not the other way around.
269 2020-03-18T16:40:00  <yevaud> just from a management perspective it's a lot less painful.
270 2020-03-18T16:40:07  <stevenroose> yeah so somehow we've been trying to make the bridge not accept incoming connections to prevent them from being DoS'ed (I think), but I'm starting to quesiton that requirement
271 2020-03-18T16:40:32  <stevenroose> AFAIU if some public nodes we have and all the internal ones just -addnode the bridges, it should all work
272 2020-03-18T16:41:04  <yevaud> read about whitebind, and the docs in general.
273 2020-03-18T16:41:59  <sipa> stevenroose: all these nodes (bridges, internal ones) connect over the public internet, right? no VPN or so
274 2020-03-18T16:42:19  <stevenroose> sipa: all tor
275 2020-03-18T16:42:26  *** Talkless has joined #bitcoin-core-dev
276 2020-03-18T16:42:56  <sipa> so if the onion addresses are kept secret, there is no risk for incoming DOS to the bridge nodes
277 2020-03-18T16:43:14  <sipa> whitebind won't help in this case
278 2020-03-18T16:43:40  <yevaud> for bridges you definitely want whitebind for the transaction relay logic.
279 2020-03-18T16:44:38  <stevenroose> hmm yeah I think I'm getting the gist of what we should do. Thanks.
280 2020-03-18T16:45:36  *** jb55 has joined #bitcoin-core-dev
281 2020-03-18T16:46:31  <yevaud> don't listen on bridges, whitebind on them, and use connect on the "hidden" peers.
282 2020-03-18T16:50:12  *** michaelfolkson has joined #bitcoin-core-dev
283 2020-03-18T16:51:18  *** AaronvanW has joined #bitcoin-core-dev
284 2020-03-18T17:16:17  *** sonofhan has quit IRC
285 2020-03-18T17:23:08  *** bitcoin-git has joined #bitcoin-core-dev
286 2020-03-18T17:23:08  <bitcoin-git> [bitcoin] sipa opened pull request #18378: Bugfix & simplify bn2vch using int.to_bytes (master...202003_simple_bn2vch) https://github.com/bitcoin/bitcoin/pull/18378
287 2020-03-18T17:23:09  *** bitcoin-git has left #bitcoin-core-dev
288 2020-03-18T17:23:58  *** justanotheruser has quit IRC
289 2020-03-18T17:24:03  *** bitcoin-git has joined #bitcoin-core-dev
290 2020-03-18T17:24:03  <bitcoin-git> [bitcoin] sipa closed pull request #18374: Bugfix in bn2vch: avoid excessive padding (master...202003_fix_bn2vch) https://github.com/bitcoin/bitcoin/pull/18374
291 2020-03-18T17:24:04  *** bitcoin-git has left #bitcoin-core-dev
292 2020-03-18T17:36:25  *** bitcoin-git has joined #bitcoin-core-dev
293 2020-03-18T17:36:25  <bitcoin-git> [bitcoin] 4d55397500 opened pull request #18379: Comment fix merkle.cpp (master...4d55397500-patch-1-1) https://github.com/bitcoin/bitcoin/pull/18379
294 2020-03-18T17:36:26  *** bitcoin-git has left #bitcoin-core-dev
295 2020-03-18T17:38:56  *** justanotheruser has joined #bitcoin-core-dev
296 2020-03-18T18:00:01  *** Perlboy has quit IRC
297 2020-03-18T18:03:48  *** bitcoin-git has joined #bitcoin-core-dev
298 2020-03-18T18:03:49  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3a8d25064e70...dbb067da389d
299 2020-03-18T18:03:49  <bitcoin-git> bitcoin/master 5b59a19 4d55397500: Update merkle.cpp
300 2020-03-18T18:03:50  <bitcoin-git> bitcoin/master dbb067d MarcoFalke: Merge #18379: doc: Comment fix merkle.cpp
301 2020-03-18T18:03:52  *** bitcoin-git has left #bitcoin-core-dev
302 2020-03-18T18:04:08  *** bitcoin-git has joined #bitcoin-core-dev
303 2020-03-18T18:04:08  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18379: doc: Comment fix merkle.cpp (master...4d55397500-patch-1-1) https://github.com/bitcoin/bitcoin/pull/18379
304 2020-03-18T18:04:09  *** bitcoin-git has left #bitcoin-core-dev
305 2020-03-18T18:07:26  *** captjakk_ has quit IRC
306 2020-03-18T18:21:17  *** Lthere has joined #bitcoin-core-dev
307 2020-03-18T18:23:33  *** jarthur has joined #bitcoin-core-dev
308 2020-03-18T18:29:14  *** michaelfolkson has quit IRC
309 2020-03-18T18:38:25  *** captjakk has joined #bitcoin-core-dev
310 2020-03-18T18:41:34  *** captjakk has quit IRC
311 2020-03-18T18:44:04  *** michaelfolkson has joined #bitcoin-core-dev
312 2020-03-18T18:51:53  *** michaelfolkson has quit IRC
313 2020-03-18T18:59:58  *** michaelfolkson has joined #bitcoin-core-dev
314 2020-03-18T19:00:41  *** michaelfolkson has quit IRC
315 2020-03-18T19:16:43  *** vasild has quit IRC
316 2020-03-18T19:16:58  *** vasild has joined #bitcoin-core-dev
317 2020-03-18T19:40:46  *** vasild_ has joined #bitcoin-core-dev
318 2020-03-18T19:44:23  *** vasild has quit IRC
319 2020-03-18T19:44:24  *** vasild_ is now known as vasild
320 2020-03-18T19:49:50  *** bitcoin-git has joined #bitcoin-core-dev
321 2020-03-18T19:49:50  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dbb067da389d...e83a1de4c03f
322 2020-03-18T19:49:50  <bitcoin-git> bitcoin/master 5e47b19 practicalswift: tests: Add harness which fuzzes EvalScript and VerifyScript using a fuzzed...
323 2020-03-18T19:49:50  <bitcoin-git> bitcoin/master e83a1de MarcoFalke: Merge #18155: tests: Add harness which fuzzes EvalScript and VerifyScript ...
324 2020-03-18T19:49:52  *** bitcoin-git has left #bitcoin-core-dev
325 2020-03-18T19:49:53  *** MrSquanchee has joined #bitcoin-core-dev
326 2020-03-18T19:50:10  *** bitcoin-git has joined #bitcoin-core-dev
327 2020-03-18T19:50:10  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18155: tests: Add harness which fuzzes EvalScript and VerifyScript using a fuzzed signature checker (master...fuzzers-signature_checker) https://github.com/bitcoin/bitcoin/pull/18155
328 2020-03-18T19:50:12  *** bitcoin-git has left #bitcoin-core-dev
329 2020-03-18T19:52:56  *** bitcoin-git has joined #bitcoin-core-dev
330 2020-03-18T19:52:57  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/e83a1de4c03f...5c9d408b2dd8
331 2020-03-18T19:52:57  <bitcoin-git> bitcoin/master fa4fa88 MarcoFalke: doc: Remove --disable-ccache from docs
332 2020-03-18T19:52:58  <bitcoin-git> bitcoin/master aaaa055 MarcoFalke: fuzz: Add option to merge input dir to test runner
333 2020-03-18T19:52:58  <bitcoin-git> bitcoin/master fa3fa27 MarcoFalke: fuzz: Remove option --export_coverage from test_runner
334 2020-03-18T19:53:00  *** bitcoin-git has left #bitcoin-core-dev
335 2020-03-18T19:53:01  *** captjakk has joined #bitcoin-core-dev
336 2020-03-18T19:53:16  *** bitcoin-git has joined #bitcoin-core-dev
337 2020-03-18T19:53:16  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18300: fuzz: Add option to merge input dir to test runner (master...Mf1902-fuzzMerge) https://github.com/bitcoin/bitcoin/pull/18300
338 2020-03-18T19:53:17  *** bitcoin-git has left #bitcoin-core-dev
339 2020-03-18T20:09:09  *** Talkless has quit IRC
340 2020-03-18T20:26:55  *** AaronvanW has quit IRC
341 2020-03-18T20:42:15  *** bitcoin-git has joined #bitcoin-core-dev
342 2020-03-18T20:42:15  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5c9d408b2dd8...a421e0a22f12
343 2020-03-18T20:42:16  <bitcoin-git> bitcoin/master 7d8e1de Vasil Dimov: net: fix use-after-free in tests
344 2020-03-18T20:42:16  <bitcoin-git> bitcoin/master a421e0a MarcoFalke: Merge #18376: net: fix use-after-free in tests
345 2020-03-18T20:42:18  *** bitcoin-git has left #bitcoin-core-dev
346 2020-03-18T20:42:35  *** bitcoin-git has joined #bitcoin-core-dev
347 2020-03-18T20:42:35  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18376: net: fix use-after-free in tests (master...fix_use_after_free_issue18372) https://github.com/bitcoin/bitcoin/pull/18376
348 2020-03-18T20:42:36  *** bitcoin-git has left #bitcoin-core-dev
349 2020-03-18T20:46:43  *** andrewtoth has quit IRC
350 2020-03-18T20:59:33  *** manantial has quit IRC
351 2020-03-18T21:00:02  *** Lthere has quit IRC
352 2020-03-18T21:02:09  *** andrewtoth has joined #bitcoin-core-dev
353 2020-03-18T21:15:06  *** bitcoin-git has joined #bitcoin-core-dev
354 2020-03-18T21:15:06  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18380: doc: Remove html comment in PULL_REQUEST_TEMPLATE (master...2003-docGitHubTemplateNoComment) https://github.com/bitcoin/bitcoin/pull/18380
355 2020-03-18T21:15:07  *** bitcoin-git has left #bitcoin-core-dev
356 2020-03-18T21:21:26  *** Kenya53Schuster has joined #bitcoin-core-dev
357 2020-03-18T21:22:04  *** kaeru has joined #bitcoin-core-dev
358 2020-03-18T21:28:36  *** kexkey has joined #bitcoin-core-dev
359 2020-03-18T21:32:32  *** Kenya53Schuster has quit IRC
360 2020-03-18T21:33:50  *** andrewtoth_ has joined #bitcoin-core-dev
361 2020-03-18T21:34:43  *** andrewtoth has quit IRC
362 2020-03-18T21:38:33  *** timothy has quit IRC
363 2020-03-18T21:39:13  *** AaronvanW has joined #bitcoin-core-dev
364 2020-03-18T21:40:14  *** andrewtoth_ has quit IRC
365 2020-03-18T21:51:56  *** MrSquanchee has quit IRC
366 2020-03-18T21:55:25  *** owowo has quit IRC
367 2020-03-18T22:01:17  *** owowo has joined #bitcoin-core-dev
368 2020-03-18T22:04:38  *** mdunnio has quit IRC
369 2020-03-18T22:14:20  *** captjakk_ has joined #bitcoin-core-dev
370 2020-03-18T22:15:19  *** Deacyde has joined #bitcoin-core-dev
371 2020-03-18T22:20:31  *** bitcoin-git has joined #bitcoin-core-dev
372 2020-03-18T22:20:31  <bitcoin-git> [bitcoin] practicalswift closed pull request #18308: depends: Make it possible to build Boost dependency using a clang toolset (./b2 toolset=clang) (master...b2-toolset-clang) https://github.com/bitcoin/bitcoin/pull/18308
373 2020-03-18T22:20:32  *** bitcoin-git has left #bitcoin-core-dev
374 2020-03-18T22:21:14  *** AaronvanW has quit IRC
375 2020-03-18T22:59:17  *** AaronvanW has joined #bitcoin-core-dev
376 2020-03-18T23:00:01  *** apaval_ has quit IRC
377 2020-03-18T23:00:20  *** apaval has joined #bitcoin-core-dev
378 2020-03-18T23:04:25  *** AaronvanW has quit IRC
379 2020-03-18T23:10:25  *** nullptr_ has quit IRC
380 2020-03-18T23:12:19  *** emilengler has quit IRC
381 2020-03-18T23:14:22  *** justanotheruser has quit IRC
382 2020-03-18T23:14:33  *** nullptr| has joined #bitcoin-core-dev
383 2020-03-18T23:17:44  *** Guyver2 has quit IRC
384 2020-03-18T23:29:58  *** justanotheruser has joined #bitcoin-core-dev
385 2020-03-18T23:30:56  *** captjakk_ has quit IRC
386 2020-03-18T23:38:15  *** captjakk_ has joined #bitcoin-core-dev
387 2020-03-18T23:39:23  *** captjakk has quit IRC
388 2020-03-18T23:39:29  *** gleb1 has joined #bitcoin-core-dev
389 2020-03-18T23:39:56  *** captjakk has joined #bitcoin-core-dev
390 2020-03-18T23:42:03  *** gleb1 has quit IRC
391 2020-03-18T23:43:30  *** sonofhan has joined #bitcoin-core-dev
392 2020-03-18T23:43:58  *** sonofhan has quit IRC
393 2020-03-18T23:44:13  *** captjakk has quit IRC
394 2020-03-18T23:49:55  *** captjakk_ has quit IRC
395 2020-03-18T23:51:22  *** AaronvanW has joined #bitcoin-core-dev
396 2020-03-18T23:51:29  *** gleb has joined #bitcoin-core-dev
397 2020-03-18T23:55:01  *** captjakk has joined #bitcoin-core-dev