1 2020-03-23T00:00:01  *** VitamineD has quit IRC
  2 2020-03-23T00:03:25  *** justanotheruser has joined #bitcoin-core-dev
  3 2020-03-23T00:19:02  *** justanotheruser has quit IRC
  4 2020-03-23T00:21:44  *** zepheiryan has joined #bitcoin-core-dev
  5 2020-03-23T00:26:36  *** marcoagner has quit IRC
  6 2020-03-23T00:36:47  *** justanotheruser has joined #bitcoin-core-dev
  7 2020-03-23T00:37:34  *** Highway61 has quit IRC
  8 2020-03-23T00:38:48  <kallewoof> sipa: I had the same error yesterday. Tried restarting the job again today and now it seems to be working.
  9 2020-03-23T00:41:20  *** sipsorcery has quit IRC
 10 2020-03-23T00:45:21  *** owowo has quit IRC
 11 2020-03-23T00:50:38  *** owowo has joined #bitcoin-core-dev
 12 2020-03-23T00:52:10  *** promag has quit IRC
 13 2020-03-23T00:52:31  *** promag has joined #bitcoin-core-dev
 14 2020-03-23T00:53:49  *** gleb has joined #bitcoin-core-dev
 15 2020-03-23T00:57:26  *** promag has quit IRC
 16 2020-03-23T01:04:15  *** ddustin has quit IRC
 17 2020-03-23T01:06:49  *** ddustin has joined #bitcoin-core-dev
 18 2020-03-23T01:08:32  *** promag has joined #bitcoin-core-dev
 19 2020-03-23T01:11:15  *** ddustin has quit IRC
 20 2020-03-23T01:12:58  *** promag has quit IRC
 21 2020-03-23T01:13:12  *** promag has joined #bitcoin-core-dev
 22 2020-03-23T01:18:25  *** molly has joined #bitcoin-core-dev
 23 2020-03-23T01:20:54  *** mol has quit IRC
 24 2020-03-23T01:21:04  <promag> #18160 for 0.20?
 25 2020-03-23T01:21:06  <gribble> https://github.com/bitcoin/bitcoin/issues/18160 | gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged by promag · Pull Request #18160 · bitcoin/bitcoin · GitHub
 26 2020-03-23T01:24:06  <fanquake> promag: can you clarify if that is a bugfix?
 27 2020-03-23T01:25:35  <promag> not a bugfix, but rather a GUI improvement
 28 2020-03-23T01:26:13  <fanquake> ok
 29 2020-03-23T01:26:49  <promag> #15015
 30 2020-03-23T01:26:50  <gribble> https://github.com/bitcoin/bitcoin/issues/15015 | slow GUI with large wallets · Issue #15015 · bitcoin/bitcoin · GitHub
 31 2020-03-23T01:33:26  <promag> fanquake: fwiw it has 4 acks
 32 2020-03-23T01:34:16  <fanquake> promag: ok, I'll take a look this morning
 33 2020-03-23T01:34:35  <promag> I also think it could be backport in 0.19.1
 34 2020-03-23T01:34:42  <promag> thanks
 35 2020-03-23T01:35:19  *** belcher has quit IRC
 36 2020-03-23T01:40:00  *** tys0n_ has quit IRC
 37 2020-03-23T01:40:35  *** promag has quit IRC
 38 2020-03-23T01:42:29  *** promag has joined #bitcoin-core-dev
 39 2020-03-23T01:46:53  *** emilengler has quit IRC
 40 2020-03-23T01:51:10  *** promag_ has joined #bitcoin-core-dev
 41 2020-03-23T01:55:35  *** ddustin has joined #bitcoin-core-dev
 42 2020-03-23T01:56:26  *** promag_ has joined #bitcoin-core-dev
 43 2020-03-23T01:56:43  *** luke-jr has quit IRC
 44 2020-03-23T01:57:42  *** promag_ has quit IRC
 45 2020-03-23T01:57:48  *** luke-jr has joined #bitcoin-core-dev
 46 2020-03-23T01:58:19  *** promag_ has joined #bitcoin-core-dev
 47 2020-03-23T01:59:41  *** promag_ has joined #bitcoin-core-dev
 48 2020-03-23T02:01:54  *** promag__ has joined #bitcoin-core-dev
 49 2020-03-23T02:10:44  *** promag_ has quit IRC
 50 2020-03-23T02:13:25  *** promag__ has quit IRC
 51 2020-03-23T02:13:32  *** ddustin has quit IRC
 52 2020-03-23T02:13:49  *** ddustin has joined #bitcoin-core-dev
 53 2020-03-23T02:16:10  *** promag_ has joined #bitcoin-core-dev
 54 2020-03-23T02:18:06  *** promag has quit IRC
 55 2020-03-23T02:25:14  *** promag_ has quit IRC
 56 2020-03-23T02:25:34  *** Victorsueca has quit IRC
 57 2020-03-23T02:28:27  *** Victorsueca has joined #bitcoin-core-dev
 58 2020-03-23T02:31:20  *** Victor_sueca has joined #bitcoin-core-dev
 59 2020-03-23T02:34:25  *** Victorsueca has quit IRC
 60 2020-03-23T02:36:04  *** Victorsueca has joined #bitcoin-core-dev
 61 2020-03-23T02:38:43  *** Victor_sueca has quit IRC
 62 2020-03-23T02:46:50  *** bitcoin-git has joined #bitcoin-core-dev
 63 2020-03-23T02:46:50  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5504703a9f83...57a8fa9c3b44
 64 2020-03-23T02:46:51  <bitcoin-git> bitcoin/master f0dfac7 Sebastian Falbesoner: test: add executable flag for rpc_estimatefee.py
 65 2020-03-23T02:46:51  <bitcoin-git> bitcoin/master 57a8fa9 fanquake: Merge #18406: test: add executable flag for rpc_estimatefee.py
 66 2020-03-23T02:46:53  *** bitcoin-git has left #bitcoin-core-dev
 67 2020-03-23T02:47:10  *** bitcoin-git has joined #bitcoin-core-dev
 68 2020-03-23T02:47:10  <bitcoin-git> [bitcoin] fanquake merged pull request #18406: test: add executable flag for rpc_estimatefee.py (master...20200322-test-add-executable-flag-for-rpc-estimatefee) https://github.com/bitcoin/bitcoin/pull/18406
 69 2020-03-23T02:47:11  *** bitcoin-git has left #bitcoin-core-dev
 70 2020-03-23T02:59:59  *** ddustin has quit IRC
 71 2020-03-23T03:00:01  *** zepheiryan has quit IRC
 72 2020-03-23T03:00:38  *** ddustin has joined #bitcoin-core-dev
 73 2020-03-23T03:04:55  *** ddustin has quit IRC
 74 2020-03-23T03:17:50  *** dviola has quit IRC
 75 2020-03-23T03:18:29  *** promag has joined #bitcoin-core-dev
 76 2020-03-23T03:20:08  *** andrewtoth has joined #bitcoin-core-dev
 77 2020-03-23T03:20:25  *** skydrome1 has joined #bitcoin-core-dev
 78 2020-03-23T03:23:01  *** promag has quit IRC
 79 2020-03-23T03:26:34  *** kexkey has quit IRC
 80 2020-03-23T03:30:23  *** felixfoertsch23 has joined #bitcoin-core-dev
 81 2020-03-23T03:32:53  *** felixfoertsch has quit IRC
 82 2020-03-23T04:01:51  *** smie has joined #bitcoin-core-dev
 83 2020-03-23T04:01:55  *** smie has left #bitcoin-core-dev
 84 2020-03-23T04:02:06  *** Ocheg has joined #bitcoin-core-dev
 85 2020-03-23T04:02:10  *** Ocheg has left #bitcoin-core-dev
 86 2020-03-23T04:02:37  *** obeafrae has joined #bitcoin-core-dev
 87 2020-03-23T04:02:41  *** obeafrae has left #bitcoin-core-dev
 88 2020-03-23T04:02:51  *** sivi has joined #bitcoin-core-dev
 89 2020-03-23T04:02:56  *** sivi has left #bitcoin-core-dev
 90 2020-03-23T04:02:58  *** veefobaxe has joined #bitcoin-core-dev
 91 2020-03-23T04:03:02  *** veefobaxe has left #bitcoin-core-dev
 92 2020-03-23T04:03:04  *** Oslasw has joined #bitcoin-core-dev
 93 2020-03-23T04:08:14  *** morcos has quit IRC
 94 2020-03-23T04:08:33  *** morcos has joined #bitcoin-core-dev
 95 2020-03-23T04:19:22  *** promag has joined #bitcoin-core-dev
 96 2020-03-23T04:19:44  *** promag has joined #bitcoin-core-dev
 97 2020-03-23T04:28:18  *** bitcoin-git has joined #bitcoin-core-dev
 98 2020-03-23T04:28:18  <bitcoin-git> [bitcoin] practicalswift opened pull request #18407: tests: Add proof-of-work fuzzing harness (master...fuzzers-proof-of-work) https://github.com/bitcoin/bitcoin/pull/18407
 99 2020-03-23T04:28:19  *** bitcoin-git has left #bitcoin-core-dev
100 2020-03-23T04:35:58  <aj> instagibbs: #13990 if you're bored
101 2020-03-23T04:36:00  <gribble> https://github.com/bitcoin/bitcoin/issues/13990 | Allow fee estimation to work with lower fees by ajtowns · Pull Request #13990 · bitcoin/bitcoin · GitHub
102 2020-03-23T05:42:07  *** TheHoliestRoger has quit IRC
103 2020-03-23T05:44:16  *** TheHoliestRoger has joined #bitcoin-core-dev
104 2020-03-23T05:59:25  *** Highway61 has joined #bitcoin-core-dev
105 2020-03-23T06:00:02  *** skydrome1 has quit IRC
106 2020-03-23T06:21:50  *** gnomus has joined #bitcoin-core-dev
107 2020-03-23T06:32:02  *** justanotheruser has quit IRC
108 2020-03-23T07:01:23  *** tsujp has joined #bitcoin-core-dev
109 2020-03-23T07:02:36  *** Highway61 has quit IRC
110 2020-03-23T07:06:05  *** BamBaRay36 has joined #bitcoin-core-dev
111 2020-03-23T07:19:46  *** justanotheruser has joined #bitcoin-core-dev
112 2020-03-23T07:34:35  *** bitcoin-git has joined #bitcoin-core-dev
113 2020-03-23T07:34:35  <bitcoin-git> [bitcoin] hebasto closed pull request #18387: gui: Fix segfault for loading and immediately unloading wallet (master...20200319-fix-modelwallet-segfault) https://github.com/bitcoin/bitcoin/pull/18387
114 2020-03-23T07:34:37  *** bitcoin-git has left #bitcoin-core-dev
115 2020-03-23T07:41:01  *** vasild_ has joined #bitcoin-core-dev
116 2020-03-23T07:44:03  *** vasild has quit IRC
117 2020-03-23T07:44:04  *** vasild_ is now known as vasild
118 2020-03-23T08:06:38  *** manantial has joined #bitcoin-core-dev
119 2020-03-23T08:11:11  *** kristapsk_ has joined #bitcoin-core-dev
120 2020-03-23T08:13:22  *** mdunnio has joined #bitcoin-core-dev
121 2020-03-23T08:13:23  *** kristapsk has quit IRC
122 2020-03-23T08:16:27  *** sipsorcery has joined #bitcoin-core-dev
123 2020-03-23T08:17:54  *** mdunnio has quit IRC
124 2020-03-23T08:29:52  <vasild> kallewoof: wrt #17994 - I assumed that we should first flush the block file to a persistent storage and afterwards flush the undo file (finalization not being relevant for this). Because in the case of a crash/power outage in between flushing both we could end up with a block on disk without undo, or with undo on disk without a block.
125 2020-03-23T08:29:54  <gribble> https://github.com/bitcoin/bitcoin/issues/17994 | validation: flush undo files after last block write by kallewoof · Pull Request #17994 · bitcoin/bitcoin · GitHub
126 2020-03-23T08:30:46  <vasild> and I assume we dont want the latter
127 2020-03-23T08:31:32  <vasild> but now I can't find anything in the code that would brick if we have undo without a block
128 2020-03-23T08:56:44  *** kljasdfvv has joined #bitcoin-core-dev
129 2020-03-23T09:00:01  *** gnomus has quit IRC
130 2020-03-23T09:09:40  *** Guyver2 has joined #bitcoin-core-dev
131 2020-03-23T09:11:44  <vasild> https://github.com/bitcoin/bitcoin/blob/312d27b/src/validation.cpp#L4810 -- this code would get upset if it finds an undo without a block, hmm
132 2020-03-23T09:13:25  *** dr-orlovsky has joined #bitcoin-core-dev
133 2020-03-23T09:21:56  *** yhsiang has joined #bitcoin-core-dev
134 2020-03-23T09:22:03  *** tsujp has quit IRC
135 2020-03-23T09:23:14  *** marcoagner has joined #bitcoin-core-dev
136 2020-03-23T09:23:40  *** promag_ has joined #bitcoin-core-dev
137 2020-03-23T09:30:15  *** AaronvanW has joined #bitcoin-core-dev
138 2020-03-23T09:40:14  *** Kiminuo has quit IRC
139 2020-03-23T09:42:51  *** tsujp has joined #bitcoin-core-dev
140 2020-03-23T09:47:22  *** Kiminuo has joined #bitcoin-core-dev
141 2020-03-23T10:08:36  *** timothy has joined #bitcoin-core-dev
142 2020-03-23T10:23:59  *** dr-orlovsky has quit IRC
143 2020-03-23T10:26:22  *** bitcoin-git has joined #bitcoin-core-dev
144 2020-03-23T10:26:22  <bitcoin-git> [bitcoin] vova557 opened pull request #18408: Bitcoin (master...master) https://github.com/bitcoin/bitcoin/pull/18408
145 2020-03-23T10:26:25  *** bitcoin-git has left #bitcoin-core-dev
146 2020-03-23T10:28:02  *** bitcoin-git has joined #bitcoin-core-dev
147 2020-03-23T10:28:02  <bitcoin-git> [bitcoin] fanquake closed pull request #18408: Bitcoin (master...master) https://github.com/bitcoin/bitcoin/pull/18408
148 2020-03-23T10:28:03  *** bitcoin-git has left #bitcoin-core-dev
149 2020-03-23T10:37:16  *** emilengler has joined #bitcoin-core-dev
150 2020-03-23T10:52:48  *** kristapsk_ has quit IRC
151 2020-03-23T10:53:13  *** kristapsk_ has joined #bitcoin-core-dev
152 2020-03-23T11:03:58  *** Jalen30Runte has joined #bitcoin-core-dev
153 2020-03-23T11:15:15  *** AaronvanW has quit IRC
154 2020-03-23T11:31:36  *** AaronvanW has joined #bitcoin-core-dev
155 2020-03-23T11:36:42  *** Deacyde has quit IRC
156 2020-03-23T11:39:31  *** bitcoin-git has joined #bitcoin-core-dev
157 2020-03-23T11:39:32  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/57a8fa9c3b44...d478a737dbdd
158 2020-03-23T11:39:32  <bitcoin-git> bitcoin/master fa01feb MarcoFalke: test: Remove ci timeout restriction in test_runner
159 2020-03-23T11:39:33  <bitcoin-git> bitcoin/master fa92af5 MarcoFalke: ci: Run feature_block and feature_abortnode in valgrind
160 2020-03-23T11:39:33  <bitcoin-git> bitcoin/master d478a73 MarcoFalke: Merge #18392: ci: Run feature_block in valgrind
161 2020-03-23T11:39:35  *** bitcoin-git has left #bitcoin-core-dev
162 2020-03-23T11:39:51  *** bitcoin-git has joined #bitcoin-core-dev
163 2020-03-23T11:39:51  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18392: ci: Run feature_block in valgrind (master...2003-ciMoreVal) https://github.com/bitcoin/bitcoin/pull/18392
164 2020-03-23T11:39:52  *** bitcoin-git has left #bitcoin-core-dev
165 2020-03-23T11:41:01  *** bitcoin-git has joined #bitcoin-core-dev
166 2020-03-23T11:41:01  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d478a737dbdd...97b0687501ce
167 2020-03-23T11:41:01  <bitcoin-git> bitcoin/master 7c1ac70 practicalswift: tests: Don't assume presence of __builtin_mul_overflow in MultiplicationOv...
168 2020-03-23T11:41:02  <bitcoin-git> bitcoin/master 97b0687 MarcoFalke: Merge #18393: tests: Don't assume presence of __builtin_mul_overflow(…) in...
169 2020-03-23T11:41:03  *** bitcoin-git has left #bitcoin-core-dev
170 2020-03-23T11:41:21  *** bitcoin-git has joined #bitcoin-core-dev
171 2020-03-23T11:41:21  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18393: tests: Don't assume presence of __builtin_mul_overflow(…) in MultiplicationOverflow(…) fuzzing harness (master...multiplication-overflow-fixup) https://github.com/bitcoin/bitcoin/pull/18393
172 2020-03-23T11:41:22  *** bitcoin-git has left #bitcoin-core-dev
173 2020-03-23T11:47:06  *** Highway61 has joined #bitcoin-core-dev
174 2020-03-23T11:53:04  *** bitcoin-git has joined #bitcoin-core-dev
175 2020-03-23T11:53:04  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18380: doc: Remove html comment in PULL_REQUEST_TEMPLATE (master...2003-docGitHubTemplateNoComment) https://github.com/bitcoin/bitcoin/pull/18380
176 2020-03-23T11:53:05  *** bitcoin-git has left #bitcoin-core-dev
177 2020-03-23T12:00:02  *** yhsiang has quit IRC
178 2020-03-23T12:21:14  *** promag_ has quit IRC
179 2020-03-23T12:21:59  *** castironpi has joined #bitcoin-core-dev
180 2020-03-23T12:39:34  *** Jalen30Runte has quit IRC
181 2020-03-23T12:41:36  *** emilengler has quit IRC
182 2020-03-23T12:47:07  *** emilengler has joined #bitcoin-core-dev
183 2020-03-23T12:47:35  *** promag_ has joined #bitcoin-core-dev
184 2020-03-23T12:51:54  *** promag_ has quit IRC
185 2020-03-23T12:51:59  *** emilengler has quit IRC
186 2020-03-23T12:52:07  *** emilengler has joined #bitcoin-core-dev
187 2020-03-23T12:55:24  *** emilengler has quit IRC
188 2020-03-23T12:55:31  *** emilengler has joined #bitcoin-core-dev
189 2020-03-23T12:57:13  *** emilengler has joined #bitcoin-core-dev
190 2020-03-23T13:01:57  *** emilengler has quit IRC
191 2020-03-23T13:02:11  *** emilengler has joined #bitcoin-core-dev
192 2020-03-23T13:06:56  *** roconnor has joined #bitcoin-core-dev
193 2020-03-23T13:22:08  *** promag_ has joined #bitcoin-core-dev
194 2020-03-23T13:26:15  *** promag_ has quit IRC
195 2020-03-23T13:29:12  <kallewoof> vasild: Damn. I guess having undo without block is bad, even if there weren't any instances of badness happening. I wanted to keep this as simple as possible...
196 2020-03-23T13:29:40  <vasild> just composing a comment on gh...
197 2020-03-23T13:29:41  <kallewoof> vasild: But wait. We do have the block. It's just that we don't flush the block file. Or am I confused now?
198 2020-03-23T13:30:04  <kallewoof> vasild: Block is written when it comes in, and later it is connected to tip and undo data is written.
199 2020-03-23T13:31:08  <kallewoof> I guess no flush essentially means no guarantees that block was actually written or not, though...
200 2020-03-23T13:31:51  *** mdunnio has joined #bitcoin-core-dev
201 2020-03-23T13:32:22  <vasild> posted: https://github.com/bitcoin/bitcoin/pull/17994#discussion_r396451804
202 2020-03-23T13:32:27  <vasild> now, lets figure this out :)
203 2020-03-23T13:33:53  <kallewoof> Thanks, your comment makes perfect sense.
204 2020-03-23T13:35:00  <vasild> so, something like the crude patch in https://github.com/bitcoin/bitcoin/pull/17994/files#r395635091 would restore the order of flushing to blk,undo
205 2020-03-23T13:36:47  <vasild> it can be simplified because at the time FlushBlockFile() is called thisUndoNeedsFlushingAndFinalizing == nLastBlockFile, so we can FlushUndoFile(nLastBlockFile, true).
206 2020-03-23T13:37:37  <vasild> FlushBlockFile() flushes nLastBlockFile
207 2020-03-23T13:41:41  <vasild> hmm
208 2020-03-23T13:45:46  <vasild> there is a mutex protecting nLastBlockFile :/
209 2020-03-23T13:47:34  <kallewoof> vasild: It feels like you can just use a flag. Kinda like https://github.com/bitcoin/bitcoin/pull/17994/commits/84ed7228b69a03c56dfd77bb0df84b39b77b5cea
210 2020-03-23T13:47:52  <kallewoof> vasild: maybe I'm overengineering this
211 2020-03-23T13:49:15  <vasild> yes, my thought, exactly!
212 2020-03-23T13:49:40  <vasild> ^^ replying to your comment about the flag, not about overengineering ;-)
213 2020-03-23T13:50:35  * kallewoof nodnods
214 2020-03-23T13:51:18  <vasild> kallewoof: now the patch looks good to me, I will stare at it for some more time and will test it.
215 2020-03-23T13:52:21  <kallewoof> Nice! :) I recompiled my running node and running this code on it now.
216 2020-03-23T13:55:11  *** promag_ has joined #bitcoin-core-dev
217 2020-03-23T13:59:29  *** promag_ has quit IRC
218 2020-03-23T14:02:06  *** AaronvanW has quit IRC
219 2020-03-23T14:02:55  *** kljasdfvv has quit IRC
220 2020-03-23T14:04:03  *** kljasdfvv has joined #bitcoin-core-dev
221 2020-03-23T14:11:39  *** kljasdfvv has quit IRC
222 2020-03-23T14:12:11  *** apaval has quit IRC
223 2020-03-23T14:12:23  *** apaval has joined #bitcoin-core-dev
224 2020-03-23T14:13:02  *** kljasdfvv has joined #bitcoin-core-dev
225 2020-03-23T14:18:52  *** kljasdfvv has quit IRC
226 2020-03-23T14:19:27  *** kljasdfvv has joined #bitcoin-core-dev
227 2020-03-23T14:26:01  *** kljasdfvv has quit IRC
228 2020-03-23T14:26:25  *** kljasdfvv has joined #bitcoin-core-dev
229 2020-03-23T14:27:45  *** promag_ has joined #bitcoin-core-dev
230 2020-03-23T14:29:21  <hebasto> promag: mind separating a fix of #18362 from #18338 into its own pr?
231 2020-03-23T14:29:23  <gribble> https://github.com/bitcoin/bitcoin/issues/18362 | gui: segfault unloading and immediately reloading wallet with gui · Issue #18362 · bitcoin/bitcoin · GitHub
232 2020-03-23T14:29:27  <gribble> https://github.com/bitcoin/bitcoin/issues/18338 | Fix wallet unload race condition by promag · Pull Request #18338 · bitcoin/bitcoin · GitHub
233 2020-03-23T14:31:54  *** promag_ has quit IRC
234 2020-03-23T14:33:10  *** kljasdfvv has quit IRC
235 2020-03-23T14:34:02  *** kljasdfvv has joined #bitcoin-core-dev
236 2020-03-23T14:40:14  *** kljasdfvv has quit IRC
237 2020-03-23T14:41:30  *** kljasdfvv has joined #bitcoin-core-dev
238 2020-03-23T14:48:04  *** kljasdfvv has quit IRC
239 2020-03-23T14:48:46  *** AaronvanW has joined #bitcoin-core-dev
240 2020-03-23T15:00:01  *** castironpi has quit IRC
241 2020-03-23T15:09:42  *** bitcoin-git has joined #bitcoin-core-dev
242 2020-03-23T15:09:42  <bitcoin-git> [bitcoin] jnewbery opened pull request #18410: Docs: Improve commenting for coins.cpp|h (master...2020-03-coins-comments) https://github.com/bitcoin/bitcoin/pull/18410
243 2020-03-23T15:09:43  *** bitcoin-git has left #bitcoin-core-dev
244 2020-03-23T15:12:06  *** kljasdfvv has joined #bitcoin-core-dev
245 2020-03-23T15:16:07  *** promag_ has joined #bitcoin-core-dev
246 2020-03-23T15:20:05  *** dr-orlovsky has joined #bitcoin-core-dev
247 2020-03-23T15:20:46  *** promag_ has quit IRC
248 2020-03-23T15:22:21  *** chendo_ has joined #bitcoin-core-dev
249 2020-03-23T15:37:04  *** justanotheruser has quit IRC
250 2020-03-23T15:38:16  *** berndj has quit IRC
251 2020-03-23T15:43:16  *** berndj has joined #bitcoin-core-dev
252 2020-03-23T15:44:23  <stevenroose> Are genesis txs included in the txindex?
253 2020-03-23T15:44:43  <stevenroose> Is it possible something regarding that changed between 0.17 and 0.18? (I know it's a stretch :p)
254 2020-03-23T15:44:49  *** apaval has quit IRC
255 2020-03-23T15:45:08  *** apaval has joined #bitcoin-core-dev
256 2020-03-23T15:45:13  *** promag has quit IRC
257 2020-03-23T15:46:16  *** promag has joined #bitcoin-core-dev
258 2020-03-23T15:46:19  *** promag_ has joined #bitcoin-core-dev
259 2020-03-23T15:47:58  *** AaronvanW has quit IRC
260 2020-03-23T15:48:34  *** captjakk has joined #bitcoin-core-dev
261 2020-03-23T15:48:57  *** Kiminuo has quit IRC
262 2020-03-23T15:52:54  *** justanotheruser has joined #bitcoin-core-dev
263 2020-03-23T15:54:01  <fjahr> stevenroose: You mean the genesis coinbase tx, right? It is not in the utxo set and it should also not be in txindex. It was never indexed by satoshis original software and changing it would be a change in consensus rules, however unlikely it is that that output is spent. So I doubt there were any changes, although I don't know. See also the discussion here: https://github.com/bitcoin/bitcoin/issues/3303
264 2020-03-23T15:54:55  <stevenroose> fjahr: k thanks
265 2020-03-23T15:55:14  <stevenroose> I know it's not in the UTXO set. But it might have been indexed. But so it appears not.
266 2020-03-23T15:58:35  <fjahr> Yeah, it is skipped here: https://github.com/bitcoin/bitcoin/blame/master/src/index/txindex.cpp#L250 The changes you might be referring to are probably the rewrite of the indexing code by jimpo but that should not have changed behavior.
267 2020-03-23T16:02:31  <stevenroose> Hmm, ed12d5df1ba52b5ef3dd3799de26bb5e1d3fc654 seems to have introduced that in 2018
268 2020-03-23T16:03:23  *** captjakk has quit IRC
269 2020-03-23T16:03:41  *** captjakk has joined #bitcoin-core-dev
270 2020-03-23T16:04:43  *** roconnor has quit IRC
271 2020-03-23T16:05:30  *** shesek has joined #bitcoin-core-dev
272 2020-03-23T16:07:00  *** shesek has quit IRC
273 2020-03-23T16:07:57  *** shesek has joined #bitcoin-core-dev
274 2020-03-23T16:10:41  *** shesek has quit IRC
275 2020-03-23T16:10:42  *** shesek has joined #bitcoin-core-dev
276 2020-03-23T16:11:03  *** shesek has joined #bitcoin-core-dev
277 2020-03-23T16:17:30  *** AaronvanW has joined #bitcoin-core-dev
278 2020-03-23T16:18:04  *** captjakk has quit IRC
279 2020-03-23T16:18:38  *** captjakk has joined #bitcoin-core-dev
280 2020-03-23T16:22:55  *** captjakk has quit IRC
281 2020-03-23T16:28:10  *** promag has quit IRC
282 2020-03-23T16:29:14  *** bitcoin-git has joined #bitcoin-core-dev
283 2020-03-23T16:29:14  <bitcoin-git> [bitcoin] theStack opened pull request #18412: script: fix SCRIPT_ERR_SIG_PUSHONLY error string (master...20200323-fix-script-err-sig-pushonly-error-message) https://github.com/bitcoin/bitcoin/pull/18412
284 2020-03-23T16:29:15  *** bitcoin-git has left #bitcoin-core-dev
285 2020-03-23T16:29:57  *** AaronvanW has quit IRC
286 2020-03-23T16:37:12  *** promag has joined #bitcoin-core-dev
287 2020-03-23T16:41:01  <fjahr> stevenroose: ah, true, interesting. So it was a bug for some amount of time: https://github.com/bitcoin/bitcoin/pull/14085
288 2020-03-23T16:42:28  <fjahr> and the blockfilter headers where want made the fix actually get in, TIL
289 2020-03-23T16:43:15  <fjahr> s/want/what/
290 2020-03-23T16:50:19  *** sipsorcery has quit IRC
291 2020-03-23T16:51:06  *** sipsorcery has joined #bitcoin-core-dev
292 2020-03-23T16:57:23  *** captjakk has joined #bitcoin-core-dev
293 2020-03-23T16:58:58  *** mdunnio has quit IRC
294 2020-03-23T16:59:22  *** mdunnio has joined #bitcoin-core-dev
295 2020-03-23T16:59:28  *** mdunnio has quit IRC
296 2020-03-23T17:00:01  *** mdunnio has joined #bitcoin-core-dev
297 2020-03-23T17:04:24  *** mdunnio has quit IRC
298 2020-03-23T17:07:52  *** captjakk has quit IRC
299 2020-03-23T17:08:15  *** captjakk has joined #bitcoin-core-dev
300 2020-03-23T17:12:33  *** captjakk has quit IRC
301 2020-03-23T17:12:36  *** AaronvanW has joined #bitcoin-core-dev
302 2020-03-23T17:13:15  <gleb> We don't have any shared policy for dns seeder implementations for rate-limiting, do we? There's no expectation that "one client ip will send at most 1 request per minute" or whatever? sipa
303 2020-03-23T17:14:50  <sipa> that sounds like a client policy, not a seeder policy.
304 2020-03-23T17:15:09  <sipa> as in: the seeder can't prevent people from querying more than once per minite
305 2020-03-23T17:15:14  <sipa> *minute
306 2020-03-23T17:15:19  *** Kiminuo has joined #bitcoin-core-dev
307 2020-03-23T17:15:40  <luke-jr> well, it can ignore floods
308 2020-03-23T17:15:47  <luke-jr> no reason for a shared policy on that tho
309 2020-03-23T17:16:40  <luke-jr> gleb: also note that clients don't talk to the seed itself; they talk to DNS servers (typically run by their ISP), and that will query and cache from the seed
310 2020-03-23T17:17:59  <sipa> honest clienta do :)
311 2020-03-23T17:18:08  <gleb> I'm implementing DNS cache invalidation triggering by reachable (thus already known) nodes, and I think it makes sense to query like 10 different services (legacy, segwit, BLOOM), etc.
312 2020-03-23T17:18:24  <luke-jr> sipa: you'd need to go out of your way to bypass it and go direct; and there's no benefit in doing so?
313 2020-03-23T17:18:45  <gleb> And I was wondering if your seeders would be angry if someone from the same endpoint asks 10 requests at once for different service combinations
314 2020-03-23T17:18:55  <sipa> gleb: they wouldn't know
315 2020-03-23T17:19:15  <sipa> luke-jr: if you want to DoS attack the seeders, you'd want to connect to them directly i meam
316 2020-03-23T17:19:16  <luke-jr> I don't understand why you would do that
317 2020-03-23T17:19:20  <luke-jr> sipa: oh, true
318 2020-03-23T17:19:58  <gleb> luke-jr: so that private nodes hit early caches more often
319 2020-03-23T17:19:58  <sipa> gleb: i don't understanx what you're trying to do, though
320 2020-03-23T17:20:11  <gleb> sipa: i think we were discussing this the other day
321 2020-03-23T17:20:17  <luke-jr> gleb: I don't get it.
322 2020-03-23T17:20:39  <sipa> gleb: DNS seeds should only be queried when addrman is low, as a fallback
323 2020-03-23T17:21:24  <sipa> (not as a last resort like hardcoded seeds, but usually nodes shouldn't be contacting them at all if they're run before and have healthy number of connections)
324 2020-03-23T17:21:38  <gleb> sipa: or on the first start.
325 2020-03-23T17:21:58  <luke-jr> "if they've run before"
326 2020-03-23T17:22:30  <sipa> yeah
327 2020-03-23T17:23:44  *** emilengler has quit IRC
328 2020-03-23T17:24:04  <sipa> i also don't understand why you're querying for multiple services
329 2020-03-23T17:24:44  <gleb> sipa: Do you understand why I want to do it in the first place? (ignoring multiple services)
330 2020-03-23T17:24:51  <sipa> no
331 2020-03-23T17:27:51  *** emilengler has joined #bitcoin-core-dev
332 2020-03-23T17:30:25  <gleb> luke-jr Managed to explain this to sipa via quoting greg from that day :)
333 2020-03-23T17:30:41  <gleb> "I wonder if listening nodes who are getting incoming connections should randomly query dnsseeds to keep upstream caches primed, but throwing out the results (or comparing to their addrman, logging if there are a bunch of results they don't now about, then throwing away the results).  Those nodes are already not anonymous by virtue of sucessfully
334 2020-03-23T17:30:41  <gleb> listening, so they don't gain anything by trying"
335 2020-03-23T17:31:14  *** captjakk has joined #bitcoin-core-dev
336 2020-03-23T17:32:00  *** Krellan_ has quit IRC
337 2020-03-23T17:32:09  <luke-jr> hmm
338 2020-03-23T17:32:27  <luke-jr> I don't know if there's actually value to priming caches tho?
339 2020-03-23T17:32:41  *** Krellan_ has joined #bitcoin-core-dev
340 2020-03-23T17:32:59  <luke-jr> even a few seconds delay querying isn't going to matter..
341 2020-03-23T17:33:47  *** emilengler has quit IRC
342 2020-03-23T17:34:43  <sipa> luke-jr: it's a privacy gain too, as it means private nodes would reveal less to the seeders, if they're coming from a network with public nodes
343 2020-03-23T17:35:39  <gleb> I'd say privacy gain has more value than little latency decrease in this context.
344 2020-03-23T17:35:48  *** captjakk has quit IRC
345 2020-03-23T17:35:48  <luke-jr> sipa: reveal what?
346 2020-03-23T17:35:52  *** mdunnio has joined #bitcoin-core-dev
347 2020-03-23T17:36:16  *** molz_ has joined #bitcoin-core-dev
348 2020-03-23T17:36:40  <sipa> luke-jr: e.g. the network that the private node is in
349 2020-03-23T17:37:01  <sipa> i wouldn't be surprised if more things can be inferred from the DNS query
350 2020-03-23T17:37:28  *** Krellan_ has quit IRC
351 2020-03-23T17:39:14  *** molly has quit IRC
352 2020-03-23T17:40:14  *** mdunnio has quit IRC
353 2020-03-23T17:40:42  *** mdunnio has joined #bitcoin-core-dev
354 2020-03-23T17:42:04  <luke-jr> sipa: more queries on that same network won't hide it..
355 2020-03-23T17:42:26  <sipa> queries from nodes that are already public
356 2020-03-23T17:42:52  <luke-jr> the seed doesn't know if they are or aren't..
357 2020-03-23T17:45:07  <sipa> ?
358 2020-03-23T17:45:20  <sipa> the seed has a database of public IPs already, even when it is honest
359 2020-03-23T17:47:08  <luke-jr> what is more queries supposed to do?
360 2020-03-23T17:47:56  <sipa> i don't know what there is to explain
361 2020-03-23T17:48:02  <sipa> or what you're missing
362 2020-03-23T17:48:28  <gleb> sipa: I had the same feeling 10 minute ago with you too :)
363 2020-03-23T17:48:40  <luke-jr> the seed knows <DNS server> made a query. <DNS server> serving more clients doesn't tell or conceal from the seed anything
364 2020-03-23T17:48:54  <sipa> gleb: well "cache invalidation" was very confusing! there is no cache invalidation going on at all :)
365 2020-03-23T17:49:52  <luke-jr> I suppose the querying of more service bit combos might conceal what clients using the DNS server are interested in.. but that's just as easily solved by the client using the DNS seed making multiple queries
366 2020-03-23T17:50:04  <luke-jr> (perhaps even more reliably!)
367 2020-03-23T17:50:44  <sipa> luke-jr: when a DNS seed sees a query from a DNS server, it has a better than average guess that there is a private node in that DNS server's network
368 2020-03-23T17:50:54  *** dr-orlovsky has quit IRC
369 2020-03-23T17:51:35  <sipa> if the public nodes in that network keep the cache fresh, that changes to "seeing a query has a high probability of there being either private or public nodes in that network"... but the public nodes are already public
370 2020-03-23T17:52:13  <luke-jr> it could already be public or private
371 2020-03-23T17:52:36  <luke-jr> oh, except public nodes are already running
372 2020-03-23T17:52:58  <luke-jr> not sure that matters actually
373 2020-03-23T17:53:04  <sipa> that makes it much stronger (public nodes in general query much less frequently), but I don't think that's actually necessary for the argument
374 2020-03-23T17:53:14  <sipa> i think it's still a privacy improvement to private nodes without that
375 2020-03-23T17:53:26  <luke-jr> I don't
376 2020-03-23T17:54:04  *** captjakk has joined #bitcoin-core-dev
377 2020-03-23T17:54:25  <sipa> imagine some networks have just 1 private node; some have just one public node; some have both; right now, assume both query the seed equally frequently
378 2020-03-23T17:55:03  <sipa> that means if a seed now sees a query from a DNS server, it has a 50/50 guess about whether there is a private or public node behind it
379 2020-03-23T17:55:03  <luke-jr> if there are public nodes on the same DNS-server-network, the seed has no idea if it was one of them already
380 2020-03-23T17:55:42  <luke-jr> 50/50 seems like about the best we could hope for?
381 2020-03-23T17:55:45  <sipa> if we now change the public nodes to query 10x more frequently, the information the seed gets about whether there is a private node when seeing a query goes down to 10% ish
382 2020-03-23T17:55:53  <sipa> luke-jr: no, because the public nodes are already public
383 2020-03-23T17:56:08  <sipa> they don't care about hiding their existence
384 2020-03-23T17:56:37  <luke-jr> 90/10 means the seed can reliably determine if there is a private node querying..
385 2020-03-23T17:56:47  <luke-jr> semi-reliably*
386 2020-03-23T17:57:45  *** promag has quit IRC
387 2020-03-23T17:57:54  <sipa> how so?
388 2020-03-23T17:58:08  *** promag has joined #bitcoin-core-dev
389 2020-03-23T17:58:42  *** filchef has joined #bitcoin-core-dev
390 2020-03-23T17:59:11  <luke-jr> look at deviations in the query pattern?
391 2020-03-23T17:59:52  <luke-jr> and DNS servers without a public node become very obvious
392 2020-03-23T18:00:01  *** chendo_ has quit IRC
393 2020-03-23T18:01:00  <sipa> sure
394 2020-03-23T18:01:09  <sipa> but the ones in a network with public ones are very reliably hidden
395 2020-03-23T18:01:30  <luke-jr> hmm, forgot caching is like an hour
396 2020-03-23T18:01:57  <luke-jr> I wonder if the private nodes just querying every hour themselves would have the same effect
397 2020-03-23T18:02:13  <luke-jr> maybe counter-productive if they're not 24/7 tho
398 2020-03-23T18:05:04  *** promag__ has joined #bitcoin-core-dev
399 2020-03-23T18:05:04  *** promag_ has quit IRC
400 2020-03-23T18:09:40  *** promag has quit IRC
401 2020-03-23T18:20:37  *** molz_ has quit IRC
402 2020-03-23T18:22:04  *** ski1 has joined #bitcoin-core-dev
403 2020-03-23T18:37:12  *** emilengler has joined #bitcoin-core-dev
404 2020-03-23T18:42:47  *** Krellan_ has joined #bitcoin-core-dev
405 2020-03-23T18:44:09  <moneyball> hi. fyi only 8 people responded "yes" to the survey for still doing a CoreDev virtually. therefore i didn't do any planning around this. obviously if contributors would like to self-organize in small remote groups, by all means.
406 2020-03-23T18:48:14  *** owowo has quit IRC
407 2020-03-23T18:49:13  *** Krellan_ has quit IRC
408 2020-03-23T18:50:54  *** andrewtoth_ has joined #bitcoin-core-dev
409 2020-03-23T18:51:23  *** andrewtoth has quit IRC
410 2020-03-23T18:53:19  *** owowo has joined #bitcoin-core-dev
411 2020-03-23T18:55:18  *** dr-orlovsky has joined #bitcoin-core-dev
412 2020-03-23T18:56:23  *** andrewtoth_ has quit IRC
413 2020-03-23T19:09:54  *** hajen has joined #bitcoin-core-dev
414 2020-03-23T19:11:53  *** promag has joined #bitcoin-core-dev
415 2020-03-23T19:18:02  *** promag has quit IRC
416 2020-03-23T19:23:12  *** Krellan_ has joined #bitcoin-core-dev
417 2020-03-23T19:27:18  *** mol has joined #bitcoin-core-dev
418 2020-03-23T19:34:22  *** Krellan_ has quit IRC
419 2020-03-23T19:39:39  *** captjakk has quit IRC
420 2020-03-23T19:40:06  *** captjakk has joined #bitcoin-core-dev
421 2020-03-23T19:40:13  *** hajen has quit IRC
422 2020-03-23T19:40:58  *** vasild_ has joined #bitcoin-core-dev
423 2020-03-23T19:44:23  *** vasild has quit IRC
424 2020-03-23T19:44:24  *** vasild_ is now known as vasild
425 2020-03-23T20:07:38  <provoostenator> moneyball: thanks for trying to coordinate! Hopefully we can do an in-person meetup again after the apocalypse.
426 2020-03-23T20:15:11  *** sonofhan has joined #bitcoin-core-dev
427 2020-03-23T20:15:50  *** Krellan_ has joined #bitcoin-core-dev
428 2020-03-23T20:29:17  *** Krellan_ has quit IRC
429 2020-03-23T20:33:03  *** bitcoin-git has joined #bitcoin-core-dev
430 2020-03-23T20:33:03  <bitcoin-git> [bitcoin] pierreN opened pull request #18413: script: prevent UB when computing abs value for num opcode serialize (master...fix-script-absolute) https://github.com/bitcoin/bitcoin/pull/18413
431 2020-03-23T20:33:05  *** bitcoin-git has left #bitcoin-core-dev
432 2020-03-23T20:39:18  *** bitcoin-git has joined #bitcoin-core-dev
433 2020-03-23T20:39:20  <bitcoin-git> [bitcoin] MarcoFalke pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/97b0687501ce...ac579ada7e83
434 2020-03-23T20:39:20  <bitcoin-git> bitcoin/master 77e4b06 Russell Yanofsky: refactor: Get rid of Wallet::IsWalletFlagSet method
435 2020-03-23T20:39:21  <bitcoin-git> bitcoin/master 1c2ab1a Russell Yanofsky: refactor: Rename Node::disconnect methods
436 2020-03-23T20:39:22  <bitcoin-git> bitcoin/master 6ceb219 Russell Yanofsky: refactor: Rename Chain::Notifications methods to be consistent with other ...
437 2020-03-23T20:39:30  *** bitcoin-git has left #bitcoin-core-dev
438 2020-03-23T20:39:48  *** bitcoin-git has joined #bitcoin-core-dev
439 2020-03-23T20:39:49  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18278: interfaces: Describe and follow some code conventions (master...pr/ipc-conv) https://github.com/bitcoin/bitcoin/pull/18278
440 2020-03-23T20:39:59  *** bitcoin-git has left #bitcoin-core-dev
441 2020-03-23T20:44:06  *** roconnor has joined #bitcoin-core-dev
442 2020-03-23T20:51:43  *** roconnor has quit IRC
443 2020-03-23T20:53:01  *** roconnor has joined #bitcoin-core-dev
444 2020-03-23T21:00:01  *** ski1 has quit IRC
445 2020-03-23T21:00:35  *** ddustin has joined #bitcoin-core-dev
446 2020-03-23T21:05:01  *** ddustin has quit IRC
447 2020-03-23T21:14:23  *** BamBaRay36 has quit IRC
448 2020-03-23T21:21:50  *** Aaaron1 has joined #bitcoin-core-dev
449 2020-03-23T21:27:08  *** emilengler has quit IRC
450 2020-03-23T21:27:22  *** emilengler has joined #bitcoin-core-dev
451 2020-03-23T21:29:06  *** manantial has quit IRC
452 2020-03-23T21:30:22  *** brakmic has joined #bitcoin-core-dev
453 2020-03-23T21:36:38  *** Krellan_ has joined #bitcoin-core-dev
454 2020-03-23T22:00:42  *** captjakk has quit IRC
455 2020-03-23T22:01:26  *** captjakk has joined #bitcoin-core-dev
456 2020-03-23T22:12:11  *** timothy has quit IRC
457 2020-03-23T22:13:14  *** Krellan_ has quit IRC
458 2020-03-23T22:20:00  *** captjakk has quit IRC
459 2020-03-23T22:30:04  *** captjakk has joined #bitcoin-core-dev
460 2020-03-23T22:30:05  *** Guyver2 has quit IRC
461 2020-03-23T22:35:13  *** emilengler has quit IRC
462 2020-03-23T22:36:15  *** dr-orlovsky has quit IRC
463 2020-03-23T22:40:40  *** mdunnio has quit IRC
464 2020-03-23T22:42:16  *** mdunnio has joined #bitcoin-core-dev
465 2020-03-23T22:46:41  *** yancy has quit IRC
466 2020-03-23T22:47:17  *** mdunnio has quit IRC
467 2020-03-23T22:47:19  *** yancy has joined #bitcoin-core-dev
468 2020-03-23T22:48:23  *** sonofhan has quit IRC
469 2020-03-23T22:50:34  *** Klox has quit IRC
470 2020-03-23T22:51:55  *** Klox has joined #bitcoin-core-dev
471 2020-03-23T23:00:01  *** apaval has quit IRC
472 2020-03-23T23:00:20  *** apaval has joined #bitcoin-core-dev
473 2020-03-23T23:03:53  *** filchef has quit IRC
474 2020-03-23T23:06:57  *** Emcy has joined #bitcoin-core-dev
475 2020-03-23T23:07:42  *** justanotheruser has quit IRC
476 2020-03-23T23:08:10  *** lukedashjr has joined #bitcoin-core-dev
477 2020-03-23T23:08:14  *** luke-jr has quit IRC
478 2020-03-23T23:10:17  *** lukedashjr is now known as luke-jr
479 2020-03-23T23:15:39  *** luke-jr has quit IRC
480 2020-03-23T23:17:12  *** luke-jr has joined #bitcoin-core-dev
481 2020-03-23T23:18:45  *** mdunnio has joined #bitcoin-core-dev
482 2020-03-23T23:18:48  *** brakmic_ has joined #bitcoin-core-dev
483 2020-03-23T23:21:49  *** brakmic has quit IRC
484 2020-03-23T23:23:37  *** mdunnio has quit IRC
485 2020-03-23T23:23:57  *** lukedashjr has joined #bitcoin-core-dev
486 2020-03-23T23:25:05  *** justanotheruser has joined #bitcoin-core-dev
487 2020-03-23T23:25:17  *** luke-jr has quit IRC
488 2020-03-23T23:27:05  *** luke-jr has joined #bitcoin-core-dev
489 2020-03-23T23:30:34  *** lukedashjr has quit IRC
490 2020-03-23T23:31:33  *** lukedashjr has joined #bitcoin-core-dev
491 2020-03-23T23:34:28  *** kljasdfvv has quit IRC
492 2020-03-23T23:34:46  *** luke-jr- has joined #bitcoin-core-dev
493 2020-03-23T23:34:57  *** Chris_Stewart_5 has quit IRC
494 2020-03-23T23:35:07  *** kljasdfvv has joined #bitcoin-core-dev
495 2020-03-23T23:35:15  *** luke-jr has quit IRC
496 2020-03-23T23:38:11  *** luke-jr has joined #bitcoin-core-dev
497 2020-03-23T23:38:14  *** lukedashjr has quit IRC
498 2020-03-23T23:42:14  *** luke-jr- has quit IRC
499 2020-03-23T23:43:06  *** sdaftuar has quit IRC
500 2020-03-23T23:43:30  *** sdaftuar has joined #bitcoin-core-dev
501 2020-03-23T23:51:50  *** marcoagner has quit IRC
502 2020-03-23T23:52:17  *** lukedashjr has joined #bitcoin-core-dev
503 2020-03-23T23:54:33  *** mdunnio has joined #bitcoin-core-dev
504 2020-03-23T23:55:54  *** luke-jr has quit IRC
505 2020-03-23T23:56:33  *** lukedashjr is now known as luke-jr
506 2020-03-23T23:59:17  *** mdunnio has quit IRC