1 2020-03-25T00:00:02  *** rejon1 has quit IRC
  2 2020-03-25T00:02:44  *** AaronvanW has quit IRC
  3 2020-03-25T00:04:33  *** felixfoertsch has quit IRC
  4 2020-03-25T00:11:20  <luke-jr> did anyone ever confirm that #17740 doesn't reintroduce CVE-2012-1910?
  5 2020-03-25T00:11:22  <gribble> https://github.com/bitcoin/bitcoin/issues/17740 | build: remove configure checks for win libraries we dont link against by fanquake · Pull Request #17740 · bitcoin/bitcoin · GitHub
  6 2020-03-25T00:12:33  <fanquake> luke-jr: Those checks don't determine what is linked against
  7 2020-03-25T00:14:40  <fanquake> From what I remember we did discuss that in the issue, and the only libs that were removed were unused.
  8 2020-03-25T00:15:45  <luke-jr> fanquake: it's supposed to
  9 2020-03-25T00:15:50  *** dviola has quit IRC
 10 2020-03-25T00:17:32  <fanquake> You're right. I've just re-read, and at the time I did check that none of those libs were being passed to the linker
 11 2020-03-25T00:20:56  *** felixfoertsch has joined #bitcoin-core-dev
 12 2020-03-25T00:22:07  *** hmachado has joined #bitcoin-core-dev
 13 2020-03-25T00:22:28  <luke-jr> which makes my question: have we reintroduced it previously? XD
 14 2020-03-25T00:24:07  *** belcher has quit IRC
 15 2020-03-25T00:24:48  <fanquake> luke-jr: I'll look. btw if you've got time can you rebase #15704
 16 2020-03-25T00:24:50  <gribble> https://github.com/bitcoin/bitcoin/issues/15704 | Move Win32 defines to configure.ac to ensure they are globally defined by luke-jr · Pull Request #15704 · bitcoin/bitcoin · GitHub
 17 2020-03-25T00:26:17  <fanquake> This is the link for master: https://gist.github.com/fanquake/7d1c147ba28a36b1690e8b42bed3bfc8
 18 2020-03-25T00:28:45  <luke-jr> well, of course it won't be linking with the removed checks _now_ :P
 19 2020-03-25T00:30:39  <luke-jr> if I add the AC_CHECK_LIB back in, it seems to link to it
 20 2020-03-25T00:33:19  <fanquake> luke-jr: It's the same for something like winspool though right? It'll link to it even though we don't use it
 21 2020-03-25T00:33:46  <luke-jr> fanquake: using threads in mingw requires linking it
 22 2020-03-25T00:33:53  <luke-jr> otherwise we get thread-unsafe stuff linked in
 23 2020-03-25T00:33:57  *** marcoagner has quit IRC
 24 2020-03-25T00:35:32  <fanquake> Can you point to any mingwthrd documentation? I'm struggling to find anything that isn't close to 10+ years old
 25 2020-03-25T00:36:47  <luke-jr>        -mthreads
 26 2020-03-25T00:36:49  <luke-jr>            Support thread-safe exception handling on MinGW.  Programs that rely on thread-safe exception handling must compile and link all code with
 27 2020-03-25T00:36:50  <luke-jr>            the -mthreads option.  When compiling, -mthreads defines -D_MT; when linking, it links in a special thread helper library -lmingwthrd which
 28 2020-03-25T00:36:52  <luke-jr>            cleans up per-thread exception-handling data.
 29 2020-03-25T00:36:53  <luke-jr> from `man gcc`
 30 2020-03-25T00:37:37  <luke-jr> (-mthreads IIRC is itself broken for static linking though)
 31 2020-03-25T00:38:15  * fanquake looking
 32 2020-03-25T00:42:12  *** dviola has joined #bitcoin-core-dev
 33 2020-03-25T00:42:41  *** jb551 has quit IRC
 34 2020-03-25T00:46:44  *** jb55 has joined #bitcoin-core-dev
 35 2020-03-25T00:48:28  <luke-jr> wumpus: ping^ in case you investigated already
 36 2020-03-25T00:54:38  *** AaronvanW has joined #bitcoin-core-dev
 37 2020-03-25T00:56:46  <luke-jr> fanquake: http://gavintech.blogspot.com/2012/03/full-disclosure-bitcoin-qt-on-windows.html
 38 2020-03-25T00:59:10  *** AaronvanW has quit IRC
 39 2020-03-25T01:01:41  *** Highway61 has quit IRC
 40 2020-03-25T01:10:44  *** Krellan_ has joined #bitcoin-core-dev
 41 2020-03-25T01:12:59  <fanquake> luke-jr: I can’t test right now but will by the end of the day
 42 2020-03-25T01:15:25  <luke-jr> I'm working on it; will just dig out the Windows test box
 43 2020-03-25T01:16:13  *** Krellan_ has quit IRC
 44 2020-03-25T01:16:34  <fanquake> Just make sure you update it first so you don’t get RCE’d
 45 2020-03-25T01:21:11  <luke-jr> RCE'd?
 46 2020-03-25T01:22:38  <luke-jr> or I should ask: which one? :p
 47 2020-03-25T01:40:32  *** GreyJediCode has joined #bitcoin-core-dev
 48 2020-03-25T01:47:50  *** mdunnio has joined #bitcoin-core-dev
 49 2020-03-25T02:20:38  <luke-jr> 21633 ?        S      0:00 /usr/bin/i686-w64-mingw32-g++-posix -std=c++11 -fstack-reuse=none -Wstack-protector -fstack-protector-all -fPIE -pipe -O2 -O2 -g -fno-ident -fvisibility=hidden -Wl,--exclude-libs -Wl,ALL -pthread -Wl,--dynamicbase -Wl,--nxcompat -pie -static -Wl,--large-address-aware -o bitcoin-cli.exe bitcoin_cli-bitcoin-cli.o bitcoin-cli-res.o -L/home/ubuntu/build/bitcoin/depends/i686-w64-mingw32/share/../lib libbitcoin_cli.a
 50 2020-03-25T02:20:40  <luke-jr> univalue/.libs/libunivalue.a libbitcoin_util.a crypto/libbitcoin_crypto_base.a crypto/libbitcoin_crypto_sse41.a crypto/libbitcoin_crypto_avx2.a crypto/libbitcoin_crypto_shani.a -lboost_system-mt-s-x32 -lboost_filesystem-mt-s-x32 -lboost_thread-mt-s-x32 -levent -lQt5AccessibilitySupport -lQt5DeviceDiscoverySupport -lQt5FbSupport -lQt5ThemeSupport -lQt5EventDispatcherSupport -lQt5FontDatabaseSupport -lssp -liphlpapi -lshlwapi -lws2_32 -
 51 2020-03-25T02:20:41  <luke-jr> ladvapi32 -luuid -loleaut32 -lole32 -lcomctl32 -lshell32 -lwinmm -lcomdlg32 -lgdi32 -luser32 -lkernel32 -lmingwthrd -pthread
 52 2020-03-25T02:20:55  <luke-jr> so -lmingwthrd is definitely being passed here
 53 2020-03-25T02:26:34  *** Klox has quit IRC
 54 2020-03-25T02:29:36  *** dviola has quit IRC
 55 2020-03-25T02:30:25  <fanquake> luke-jr:  looking at the mingw-w64 source, in regards to mingwthrd I'm seeing:  As _CRT_MT is getting defined in libgcc when using shared version, or it is getting defined by startup code itself, this library is a dummy version for supporting the link library for gcc's option -mthreads.  As we support TLS-cleanup even without specifying this library, this library is deprecated and just kept for compatibility.
 56 2020-03-25T02:31:08  <fanquake> The only code in mingwthrd_mt.c is: int _CRT_MT_OLD = 1;
 57 2020-03-25T02:31:56  <fanquake> mingwthrd_mt.c is the source for libmingwthrd.a
 58 2020-03-25T02:33:47  <fanquake> https://sourceforge.net/p/mingw-w64/mingw-w64/ci/master/tree/mingw-w64-crt/libsrc/mingwthrd_mt.c
 59 2020-03-25T02:41:04  <luke-jr> that file hasn't changed since Date:   Fri Jun 26 10:49:35 2009 +0000
 60 2020-03-25T02:42:30  <fanquake> Yea I'm looking at the history now. Those changes happened in 22b6398a8acf17e6687375c414fae832888de53a
 61 2020-03-25T02:42:51  <luke-jr> we also don't have a minimum mingw version afaik
 62 2020-03-25T02:43:04  <luke-jr> if we decide to bump it, we should also check it meets the required version
 63 2020-03-25T02:44:01  <luke-jr> that commit first released in 2.0, sometime after Date:   Tue Oct 4 15:17:14 2011 +0000
 64 2020-03-25T02:44:43  <luke-jr> but CVE-2012-1910 was Date: 2012-03-17
 65 2020-03-25T02:45:32  <fanquake> Right, because gitian builds would likely have been done with an older version of mingw-w64
 66 2020-03-25T02:46:05  *** justan0theruser has joined #bitcoin-core-dev
 67 2020-03-25T02:46:22  *** justanotheruser has quit IRC
 68 2020-03-25T02:47:59  * luke-jr checking that
 69 2020-03-25T02:49:21  <fanquake> Need to find out what version of mingw-w64 was shipping with ubuntu lucid
 70 2020-03-25T02:49:34  <fanquake> *mingw32
 71 2020-03-25T02:51:44  *** mdunnio has quit IRC
 72 2020-03-25T02:53:46  <luke-jr> Version: 3.15.2-0ubuntu1
 73 2020-03-25T02:53:48  <luke-jr> :/
 74 2020-03-25T02:54:03  <luke-jr> there is no 3.15 tho
 75 2020-03-25T02:55:43  *** GreyJediCode has quit IRC
 76 2020-03-25T02:56:12  *** AaronvanW has joined #bitcoin-core-dev
 77 2020-03-25T02:56:17  *** roconnor has quit IRC
 78 2020-03-25T03:00:02  *** hmachado has quit IRC
 79 2020-03-25T03:00:28  <luke-jr> mingwrt-3.15.2-mingw32/include/_mingw.h:#define __MINGW32_VERSION           3.15.2
 80 2020-03-25T03:00:30  <luke-jr> sigh
 81 2020-03-25T03:01:48  <luke-jr> I propose we just add mingwthrd back in. It's harmless at worst.
 82 2020-03-25T03:06:05  <luke-jr> 26805 ?        S      0:00 /usr/bin/x86_64-w64-mingw32-g++-posix -std=c++11 -fstack-reuse=none -Wstack-protector -fstack-protector-all -fPIE -pipe -O2 -O2 -g -fno-ident -fvisibility=hidden -Wl,--exclude-libs -Wl,ALL -pthread -Wl,--dynamicbase -Wl,--nxcompat -Wl,--high-entropy-va -pie -static -o bitcoind.exe bitcoind-bitcoind.o bitcoind-res.o -L/home/ubuntu/build/bitcoin/depends/x86_64-w64-mingw32/share/../lib libbitcoin_server.a libbitcoin_
 83 2020-03-25T03:06:07  <luke-jr> wallet.a libbitcoin_common.a univalue/.libs/libunivalue.a libbitcoin_util.a libbitcoin_zmq.a libbitcoin_consensus.a crypto/libbitcoin_crypto_base.a crypto/libbitcoin_crypto_sse41.a crypto/libbitcoin_crypto_avx2.a crypto/libbitcoin_crypto_shani.a leveldb/libleveldb.a crc32c/libcrc32c.a crc32c/libcrc32c_sse42.a leveldb/libmemenv.a secp256k1/.libs/libsecp256k1.a -lboost_system-mt-s-x64 -lboost_filesystem-mt-s-x64 -lboost_thread-mt-s-x64 -ldb_
 84 2020-03-25T03:06:09  <luke-jr> cxx-4.8 -lminiupnpc -levent -lzmq -lQt5AccessibilitySupport -lQt5DeviceDiscoverySupport -lQt5FbSupport -lQt5ThemeSupport -lQt5EventDispatcherSupport -lQt5FontDatabaseSupport -lssp -liphlpapi -lshlwapi -lws2_32 -ladvapi32 -luuid -loleaut32 -lole32 -lcomctl32 -lshell32 -lwinmm -lcomdlg32 -lgdi32 -luser32 -lkernel32 -lmingwthrd -pthread
 85 2020-03-25T03:06:10  <luke-jr> so x86_64 uses it too
 86 2020-03-25T03:10:58  <fanquake> I just checked that binaries produced with and without -lmingwthrd are basically identical. I see 5 bytes difference, and that's the git commit and what looks like 2 timestamps.
 87 2020-03-25T03:13:03  *** sipa has quit IRC
 88 2020-03-25T03:13:30  *** bitcoin-git has joined #bitcoin-core-dev
 89 2020-03-25T03:13:31  <bitcoin-git> [bitcoin] luke-jr opened pull request #18427: Bugfix? Restore linking to libmingwthrd (master...2020mingwthrd) https://github.com/bitcoin/bitcoin/pull/18427
 90 2020-03-25T03:13:43  *** bitcoin-git has left #bitcoin-core-dev
 91 2020-03-25T03:20:12  *** laen_ has joined #bitcoin-core-dev
 92 2020-03-25T03:23:07  *** Krellan_ has joined #bitcoin-core-dev
 93 2020-03-25T03:24:41  *** mdunnio has joined #bitcoin-core-dev
 94 2020-03-25T03:27:26  *** sipa has joined #bitcoin-core-dev
 95 2020-03-25T03:29:37  *** mdunnio has quit IRC
 96 2020-03-25T03:29:39  *** AaronvanW has quit IRC
 97 2020-03-25T03:32:37  *** Krellan_ has quit IRC
 98 2020-03-25T03:34:21  *** justan0theruser has quit IRC
 99 2020-03-25T03:34:41  *** justanotheruser has joined #bitcoin-core-dev
100 2020-03-25T03:38:44  *** Highway61 has joined #bitcoin-core-dev
101 2020-03-25T03:44:48  *** felixfoertsch23 has joined #bitcoin-core-dev
102 2020-03-25T03:47:37  *** felixfoertsch has quit IRC
103 2020-03-25T04:14:30  <fanquake> MarcoFalke: did DrahtBot get an upgrade: https://github.com/bitcoin/bitcoin/pull/18426#discussion_r397534721
104 2020-03-25T04:16:32  *** Krellan_ has joined #bitcoin-core-dev
105 2020-03-25T04:19:34  *** roconnor has joined #bitcoin-core-dev
106 2020-03-25T04:59:03  *** Highway61 has quit IRC
107 2020-03-25T05:19:27  *** Krellan_ has quit IRC
108 2020-03-25T05:26:49  *** AaronvanW has joined #bitcoin-core-dev
109 2020-03-25T05:44:30  *** mdunnio has joined #bitcoin-core-dev
110 2020-03-25T05:48:34  *** mdunnio has quit IRC
111 2020-03-25T05:50:35  *** apaval has quit IRC
112 2020-03-25T05:58:32  *** Talkless has joined #bitcoin-core-dev
113 2020-03-25T05:59:10  *** Highway61 has joined #bitcoin-core-dev
114 2020-03-25T05:59:17  *** AaronvanW has quit IRC
115 2020-03-25T05:59:43  *** Talkless has quit IRC
116 2020-03-25T06:00:01  *** laen_ has quit IRC
117 2020-03-25T06:13:57  *** as_pnn has joined #bitcoin-core-dev
118 2020-03-25T06:21:53  *** zerstoerer has joined #bitcoin-core-dev
119 2020-03-25T06:23:40  *** tsujp has joined #bitcoin-core-dev
120 2020-03-25T06:33:10  *** tsujp has quit IRC
121 2020-03-25T06:34:44  *** tsujp has joined #bitcoin-core-dev
122 2020-03-25T06:36:44  *** bitcoin-git has joined #bitcoin-core-dev
123 2020-03-25T06:36:44  <bitcoin-git> [bitcoin] kallewoof closed pull request #16440: BIP-322: Generic signed message format (master...feature-generic-signed-message-format) https://github.com/bitcoin/bitcoin/pull/16440
124 2020-03-25T06:36:45  *** bitcoin-git has left #bitcoin-core-dev
125 2020-03-25T06:38:52  *** Livestradamus has quit IRC
126 2020-03-25T06:39:14  *** Livestradamus has joined #bitcoin-core-dev
127 2020-03-25T06:47:22  *** tsujp has quit IRC
128 2020-03-25T06:51:34  *** Kiminuo has quit IRC
129 2020-03-25T06:58:36  *** apaval has joined #bitcoin-core-dev
130 2020-03-25T07:00:28  *** Kiminuo has joined #bitcoin-core-dev
131 2020-03-25T07:13:50  *** BGL has quit IRC
132 2020-03-25T07:14:38  *** Kiminuo has quit IRC
133 2020-03-25T07:14:59  *** Kiminuo has joined #bitcoin-core-dev
134 2020-03-25T07:16:17  *** Krellan_ has joined #bitcoin-core-dev
135 2020-03-25T07:22:19  *** Krellan_ has quit IRC
136 2020-03-25T07:29:48  *** Guyver2 has joined #bitcoin-core-dev
137 2020-03-25T07:40:57  *** vasild_ has joined #bitcoin-core-dev
138 2020-03-25T07:41:30  *** bitcoin-git has joined #bitcoin-core-dev
139 2020-03-25T07:41:30  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5236b2e267a5...5b4a9f4bdf9d
140 2020-03-25T07:41:30  <bitcoin-git> bitcoin/master 33dd764 practicalswift: doc: Add fuzzing quickstart guides for libFuzzer and afl-fuzz. Simplify in...
141 2020-03-25T07:41:31  <bitcoin-git> bitcoin/master 5b4a9f4 fanquake: Merge #18342: doc: Add fuzzing quickstart guides for libFuzzer and afl-fuz...
142 2020-03-25T07:41:32  *** bitcoin-git has left #bitcoin-core-dev
143 2020-03-25T07:41:50  *** bitcoin-git has joined #bitcoin-core-dev
144 2020-03-25T07:41:50  <bitcoin-git> [bitcoin] fanquake merged pull request #18342: doc: Add fuzzing quickstart guides for libFuzzer and afl-fuzz (master...fuzzing-quick-start-guide) https://github.com/bitcoin/bitcoin/pull/18342
145 2020-03-25T07:41:51  *** bitcoin-git has left #bitcoin-core-dev
146 2020-03-25T07:43:43  *** vasild has quit IRC
147 2020-03-25T07:43:44  *** vasild_ is now known as vasild
148 2020-03-25T07:53:01  *** felixfoertsch23 has quit IRC
149 2020-03-25T07:56:24  *** AaronvanW has joined #bitcoin-core-dev
150 2020-03-25T07:56:32  *** SiAnDoG__ has quit IRC
151 2020-03-25T07:56:53  *** SiAnDoG__ has joined #bitcoin-core-dev
152 2020-03-25T08:00:48  *** bitcoin-git has joined #bitcoin-core-dev
153 2020-03-25T08:00:48  <bitcoin-git> [bitcoin] fanquake closed pull request #18377: build: fix libevent linking errors for bench-only builds (master...bench-compilation) https://github.com/bitcoin/bitcoin/pull/18377
154 2020-03-25T08:00:49  *** bitcoin-git has left #bitcoin-core-dev
155 2020-03-25T08:10:15  *** felixfoertsch has joined #bitcoin-core-dev
156 2020-03-25T08:27:22  *** tsujp_ has joined #bitcoin-core-dev
157 2020-03-25T08:29:45  *** AaronvanW has quit IRC
158 2020-03-25T08:30:13  *** tsujp has joined #bitcoin-core-dev
159 2020-03-25T08:32:21  *** tsujp_ has quit IRC
160 2020-03-25T08:33:10  *** tsujp__ has joined #bitcoin-core-dev
161 2020-03-25T08:36:09  *** tsujp has quit IRC
162 2020-03-25T08:37:58  *** manantial has joined #bitcoin-core-dev
163 2020-03-25T08:38:45  *** tsujp__ has quit IRC
164 2020-03-25T09:00:02  *** zerstoerer has quit IRC
165 2020-03-25T09:01:23  *** BGL has joined #bitcoin-core-dev
166 2020-03-25T09:01:32  *** AaronvanW has joined #bitcoin-core-dev
167 2020-03-25T09:15:22  *** felixfoertsch has quit IRC
168 2020-03-25T09:15:44  *** felixfoertsch has joined #bitcoin-core-dev
169 2020-03-25T09:16:34  *** tsujp has joined #bitcoin-core-dev
170 2020-03-25T09:19:00  *** Krellan_ has joined #bitcoin-core-dev
171 2020-03-25T09:20:45  *** felixfoertsch has quit IRC
172 2020-03-25T09:22:21  *** RiscTaker1 has joined #bitcoin-core-dev
173 2020-03-25T09:23:37  *** Krellan_ has quit IRC
174 2020-03-25T09:23:40  *** AaronvanW has quit IRC
175 2020-03-25T09:23:58  *** AaronvanW has joined #bitcoin-core-dev
176 2020-03-25T09:31:51  *** marcoagner has joined #bitcoin-core-dev
177 2020-03-25T09:32:52  *** felixfoertsch has joined #bitcoin-core-dev
178 2020-03-25T09:40:26  *** tsujp has quit IRC
179 2020-03-25T09:56:35  *** timothy has joined #bitcoin-core-dev
180 2020-03-25T10:21:43  *** as_pnn has quit IRC
181 2020-03-25T10:23:08  *** as_pnn has joined #bitcoin-core-dev
182 2020-03-25T10:25:49  *** felixfoertsch23 has joined #bitcoin-core-dev
183 2020-03-25T10:26:14  *** felixfoertsch has quit IRC
184 2020-03-25T10:28:03  *** theStack has joined #bitcoin-core-dev
185 2020-03-25T10:29:23  *** sipa has quit IRC
186 2020-03-25T10:30:24  *** sipa has joined #bitcoin-core-dev
187 2020-03-25T10:30:43  *** braydonf has quit IRC
188 2020-03-25T10:31:16  *** braydonf has joined #bitcoin-core-dev
189 2020-03-25T10:42:36  *** emilengler has joined #bitcoin-core-dev
190 2020-03-25T11:04:03  *** Lisa60Baumbach has joined #bitcoin-core-dev
191 2020-03-25T11:28:26  *** Lisa60Baumbach has quit IRC
192 2020-03-25T11:28:56  *** AaronvanW has quit IRC
193 2020-03-25T11:32:13  *** AaronvanW has joined #bitcoin-core-dev
194 2020-03-25T11:34:24  *** roconnor has quit IRC
195 2020-03-25T11:36:40  *** bitcoin-git has joined #bitcoin-core-dev
196 2020-03-25T11:36:40  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5b4a9f4bdf9d...3f5107d008e1
197 2020-03-25T11:36:41  <bitcoin-git> bitcoin/master 87d24e6 practicalswift: tests: Add integer serialization/deserialization fuzzing harness
198 2020-03-25T11:36:41  <bitcoin-git> bitcoin/master 102f326 practicalswift: tests: Add fuzzing harness for classes/functions in blockfilter.h
199 2020-03-25T11:36:42  <bitcoin-git> bitcoin/master 3f5107d MarcoFalke: Merge #18423: tests: Add fuzzing harness for classes/functions in blockfil...
200 2020-03-25T11:36:43  *** bitcoin-git has left #bitcoin-core-dev
201 2020-03-25T11:37:00  *** bitcoin-git has joined #bitcoin-core-dev
202 2020-03-25T11:37:01  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18423: tests: Add fuzzing harness for classes/functions in blockfilter.h. Add integer {de,}serialization fuzzing. (master...fuzzers-misc-2) https://github.com/bitcoin/bitcoin/pull/18423
203 2020-03-25T11:37:02  *** bitcoin-git has left #bitcoin-core-dev
204 2020-03-25T11:39:55  <stevenroose> aj: about https://github.com/bitcoin/bitcoin/pull/13990
205 2020-03-25T11:40:22  <stevenroose> If you would just have applied https://github.com/bitcoin/bitcoin/pull/13990/commits/c68f796c41b9b145c9c1b2c24aea505362ad1b63 without the other changes, what would have be the problem?
206 2020-03-25T11:40:49  <stevenroose> It seems that at least part of the other commits are intended to not require users to remove the fee_estimatoin.dat file, is that correct?
207 2020-03-25T11:59:03  *** promag has joined #bitcoin-core-dev
208 2020-03-25T12:00:01  *** RiscTaker1 has quit IRC
209 2020-03-25T12:03:14  *** promag has quit IRC
210 2020-03-25T12:09:22  <aj> stevenroose: seems kinda rude to have to spend a week before you can get fee estimates again?
211 2020-03-25T12:11:29  <aj> stevenroose: (if you just did that, users who upgrade would continue to not get estimates for below 1s/B until they deleted their fee_estimates.dat, they'd continue using the same buckets that were current when f_e.dat was generated)
212 2020-03-25T12:15:13  <stevenroose> aj: where does that week come from?
213 2020-03-25T12:15:25  <stevenroose> does that mean a week before getting any estimate? Or a week before getting reliable ones?
214 2020-03-25T12:18:14  <aj> stevenroose: i'm not sure of the numbers, but there's a weekly cycle so i wouldn't really trust the numbers much without that much data
215 2020-03-25T12:32:21  *** jb55 has quit IRC
216 2020-03-25T12:32:50  *** jb55 has joined #bitcoin-core-dev
217 2020-03-25T12:33:20  *** promag has joined #bitcoin-core-dev
218 2020-03-25T12:38:07  *** promag has quit IRC
219 2020-03-25T12:39:12  *** bitcoin-git has joined #bitcoin-core-dev
220 2020-03-25T12:39:13  <bitcoin-git> [bitcoin] brakmic opened pull request #18429: build: remove double LIBBITCOIN_SERVER from bench-Makefile (master...bench-makefile) https://github.com/bitcoin/bitcoin/pull/18429
221 2020-03-25T12:39:13  *** bitcoin-git has left #bitcoin-core-dev
222 2020-03-25T12:45:41  *** theStack has quit IRC
223 2020-03-25T12:56:04  *** sunetoft has joined #bitcoin-core-dev
224 2020-03-25T13:06:37  *** mdunnio has joined #bitcoin-core-dev
225 2020-03-25T13:11:07  *** promag has joined #bitcoin-core-dev
226 2020-03-25T13:11:22  *** mdunnio has quit IRC
227 2020-03-25T13:15:33  *** promag has quit IRC
228 2020-03-25T13:20:49  *** Krellan_ has joined #bitcoin-core-dev
229 2020-03-25T13:21:36  *** Krellan_ has joined #bitcoin-core-dev
230 2020-03-25T13:26:29  *** Krellan_ has quit IRC
231 2020-03-25T13:34:30  *** mdunnio has joined #bitcoin-core-dev
232 2020-03-25T13:44:38  *** promag has joined #bitcoin-core-dev
233 2020-03-25T13:49:14  *** bitcoin-git has joined #bitcoin-core-dev
234 2020-03-25T13:49:15  <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/3f5107d008e1...baa72cd9a2fd
235 2020-03-25T13:49:16  <bitcoin-git> bitcoin/master 5e6b8b3 Hennadii Stepanov: build: Use git archive as source tarball
236 2020-03-25T13:49:16  <bitcoin-git> bitcoin/master 6c4da59 Hennadii Stepanov: build: Drop SOURCEDIST reordering
237 2020-03-25T13:49:16  *** promag has quit IRC
238 2020-03-25T13:49:17  <bitcoin-git> bitcoin/master e4d3667 Hennadii Stepanov: build: Drop needless EXTRA_DIST content
239 2020-03-25T13:49:19  *** bitcoin-git has left #bitcoin-core-dev
240 2020-03-25T13:49:33  *** bitcoin-git has joined #bitcoin-core-dev
241 2020-03-25T13:49:33  <bitcoin-git> [bitcoin] laanwj merged pull request #18331: build: Use git archive as source tarball  (master...20200312-git-archive) https://github.com/bitcoin/bitcoin/pull/18331
242 2020-03-25T13:49:34  *** bitcoin-git has left #bitcoin-core-dev
243 2020-03-25T13:53:58  *** roconnor has joined #bitcoin-core-dev
244 2020-03-25T13:56:44  *** AaronvanW has quit IRC
245 2020-03-25T14:03:12  *** theStack has joined #bitcoin-core-dev
246 2020-03-25T14:07:03  *** braydonf has quit IRC
247 2020-03-25T14:11:50  *** bitcoin-git has joined #bitcoin-core-dev
248 2020-03-25T14:11:51  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/baa72cd9a2fd...244e88e6b580
249 2020-03-25T14:11:52  <bitcoin-git> bitcoin/master aae2605 Jon Atack: gui: display Mapped AS in peers info window
250 2020-03-25T14:11:52  <bitcoin-git> bitcoin/master 76db4b2 Jon Atack: gui: avoid QT Designer/Form Editor re-formatting
251 2020-03-25T14:11:53  <bitcoin-git> bitcoin/master 244e88e Wladimir J. van der Laan: Merge #18402: gui: display mapped AS in peers info window
252 2020-03-25T14:11:55  *** bitcoin-git has left #bitcoin-core-dev
253 2020-03-25T14:12:10  *** bitcoin-git has joined #bitcoin-core-dev
254 2020-03-25T14:12:10  <bitcoin-git> [bitcoin] laanwj merged pull request #18402: gui: display mapped AS in peers info window (master...gui-peers-display-mapped_as) https://github.com/bitcoin/bitcoin/pull/18402
255 2020-03-25T14:12:11  *** bitcoin-git has left #bitcoin-core-dev
256 2020-03-25T14:18:44  <wumpus> i think it would be nice to have #15600 in 0.20.0, as it prevents leaking private key data into core dumps; does anyone here know enough about linux internals and madvise() to review / test it?
257 2020-03-25T14:18:46  <gribble> https://github.com/bitcoin/bitcoin/issues/15600 | lockedpool: When possible, use madvise to avoid including sensitive information in core dumps by luke-jr · Pull Request #15600 · bitcoin/bitcoin · GitHub
258 2020-03-25T14:19:28  *** theStack has quit IRC
259 2020-03-25T14:20:26  *** promag has joined #bitcoin-core-dev
260 2020-03-25T14:20:36  *** braydonf has joined #bitcoin-core-dev
261 2020-03-25T14:23:02  *** DeanWeen has quit IRC
262 2020-03-25T14:23:24  <vasild> wumpus: I was just wondering what to pick up next :)
263 2020-03-25T14:25:25  *** promag has quit IRC
264 2020-03-25T14:29:00  *** AaronvanW has joined #bitcoin-core-dev
265 2020-03-25T14:32:44  *** apaval has quit IRC
266 2020-03-25T14:33:03  *** apaval has joined #bitcoin-core-dev
267 2020-03-25T14:36:18  *** bitcoin-git has joined #bitcoin-core-dev
268 2020-03-25T14:36:19  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/244e88e6b580...3e50fdbe4e5b
269 2020-03-25T14:36:19  <bitcoin-git> bitcoin/master 1a0993a fanquake: scripts: add PE dylib checking to symbol-check.py
270 2020-03-25T14:36:20  <bitcoin-git> bitcoin/master 3e50fdb Wladimir J. van der Laan: Merge #18395: scripts: add PE dylib checking to symbol-check.py
271 2020-03-25T14:36:21  *** bitcoin-git has left #bitcoin-core-dev
272 2020-03-25T14:36:37  *** bitcoin-git has joined #bitcoin-core-dev
273 2020-03-25T14:36:38  <bitcoin-git> [bitcoin] laanwj merged pull request #18395: scripts: add PE dylib checking to symbol-check.py (master...pe_dll_checking) https://github.com/bitcoin/bitcoin/pull/18395
274 2020-03-25T14:36:39  *** bitcoin-git has left #bitcoin-core-dev
275 2020-03-25T14:41:09  <luke-jr> fanquake: freaking Windows Update fails -.-
276 2020-03-25T14:41:15  *** promag has joined #bitcoin-core-dev
277 2020-03-25T14:42:58  <jonatack> wumpus: having a look
278 2020-03-25T14:43:44  *** slimcognito has quit IRC
279 2020-03-25T14:43:44  *** bsm117532 has quit IRC
280 2020-03-25T14:43:44  *** nothingmuch has quit IRC
281 2020-03-25T14:45:34  *** promag has quit IRC
282 2020-03-25T14:47:10  *** shesek has quit IRC
283 2020-03-25T14:47:38  *** shesek has joined #bitcoin-core-dev
284 2020-03-25T14:49:00  *** justanotheruser has quit IRC
285 2020-03-25T14:50:37  <phantomcircuit> luke-jr, akamai is currently exploding a little bit
286 2020-03-25T14:52:06  *** shesek has quit IRC
287 2020-03-25T14:52:43  *** shesek has joined #bitcoin-core-dev
288 2020-03-25T14:54:34  *** Kiminuo has quit IRC
289 2020-03-25T14:57:25  *** shesek has quit IRC
290 2020-03-25T14:59:27  <luke-jr> phantomcircuit: what?
291 2020-03-25T14:59:37  *** shesek has joined #bitcoin-core-dev
292 2020-03-25T15:00:02  *** sunetoft has quit IRC
293 2020-03-25T15:03:28  *** Talkless has joined #bitcoin-core-dev
294 2020-03-25T15:04:11  *** shesek has quit IRC
295 2020-03-25T15:06:13  *** captjakk has joined #bitcoin-core-dev
296 2020-03-25T15:06:55  *** justanotheruser has joined #bitcoin-core-dev
297 2020-03-25T15:07:07  *** captjakk has quit IRC
298 2020-03-25T15:07:11  *** shesek has joined #bitcoin-core-dev
299 2020-03-25T15:11:55  *** shesek has quit IRC
300 2020-03-25T15:14:31  *** bitcoin-git has joined #bitcoin-core-dev
301 2020-03-25T15:14:31  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18430: ci: Only clone bitcoin-core/qa-assets when fuzzing (master...2003-ciFuzzClone) https://github.com/bitcoin/bitcoin/pull/18430
302 2020-03-25T15:14:32  *** bitcoin-git has left #bitcoin-core-dev
303 2020-03-25T15:15:51  *** shesek has joined #bitcoin-core-dev
304 2020-03-25T15:18:17  *** promag has joined #bitcoin-core-dev
305 2020-03-25T15:19:33  *** apaval has quit IRC
306 2020-03-25T15:19:53  *** apaval has joined #bitcoin-core-dev
307 2020-03-25T15:20:37  *** shesek has quit IRC
308 2020-03-25T15:22:10  *** Snowstormer has joined #bitcoin-core-dev
309 2020-03-25T15:22:44  *** shesek has joined #bitcoin-core-dev
310 2020-03-25T15:23:29  *** promag has quit IRC
311 2020-03-25T15:23:47  *** promag has joined #bitcoin-core-dev
312 2020-03-25T15:24:01  *** Krellan_ has joined #bitcoin-core-dev
313 2020-03-25T15:27:23  *** shesek has quit IRC
314 2020-03-25T15:31:30  *** shesek has joined #bitcoin-core-dev
315 2020-03-25T15:32:13  *** AaronvanW has quit IRC
316 2020-03-25T15:32:33  *** AaronvanW has joined #bitcoin-core-dev
317 2020-03-25T15:36:05  *** shesek has quit IRC
318 2020-03-25T15:38:39  *** promag has quit IRC
319 2020-03-25T15:38:56  *** AaronvanW has quit IRC
320 2020-03-25T15:40:34  *** shesek has joined #bitcoin-core-dev
321 2020-03-25T15:45:16  *** shesek has quit IRC
322 2020-03-25T15:49:15  *** shesek has joined #bitcoin-core-dev
323 2020-03-25T15:49:27  *** bsm117532 has joined #bitcoin-core-dev
324 2020-03-25T15:53:58  *** shesek has quit IRC
325 2020-03-25T15:55:31  *** promag has joined #bitcoin-core-dev
326 2020-03-25T15:56:12  *** Krellan_ has quit IRC
327 2020-03-25T15:56:18  *** DeanGuss has joined #bitcoin-core-dev
328 2020-03-25T15:58:15  *** shesek has joined #bitcoin-core-dev
329 2020-03-25T15:58:57  *** AaronvanW has joined #bitcoin-core-dev
330 2020-03-25T15:59:42  *** promag has quit IRC
331 2020-03-25T16:03:09  *** shesek has quit IRC
332 2020-03-25T16:04:51  *** shesek has joined #bitcoin-core-dev
333 2020-03-25T16:05:39  *** bitcoin-git has joined #bitcoin-core-dev
334 2020-03-25T16:05:40  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3e50fdbe4e5b...60a39a96fc04
335 2020-03-25T16:05:40  <bitcoin-git> bitcoin/master 3e0df92 Andrew Chow: Update with new Windows code signing certificate
336 2020-03-25T16:05:41  <bitcoin-git> bitcoin/master 60a39a9 Wladimir J. van der Laan: Merge #18425: releases: Update with new Windows code signing certificate
337 2020-03-25T16:05:42  *** bitcoin-git has left #bitcoin-core-dev
338 2020-03-25T16:06:00  *** bitcoin-git has joined #bitcoin-core-dev
339 2020-03-25T16:06:01  <bitcoin-git> [bitcoin] laanwj merged pull request #18425: releases: Update with new Windows code signing certificate (master...win-cert-3-20) https://github.com/bitcoin/bitcoin/pull/18425
340 2020-03-25T16:06:02  *** bitcoin-git has left #bitcoin-core-dev
341 2020-03-25T16:09:26  *** shesek has quit IRC
342 2020-03-25T16:11:46  *** DeanGuss has quit IRC
343 2020-03-25T16:12:41  *** shesek has joined #bitcoin-core-dev
344 2020-03-25T16:14:25  <wumpus> is there something wrong with Travis? it looks like it isn't running on #18430
345 2020-03-25T16:14:26  <gribble> https://github.com/bitcoin/bitcoin/issues/18430 | ci: Only clone bitcoin-core/qa-assets when fuzzing by MarcoFalke · Pull Request #18430 · bitcoin/bitcoin · GitHub
346 2020-03-25T16:17:10  *** shesek has quit IRC
347 2020-03-25T16:21:31  *** shesek has joined #bitcoin-core-dev
348 2020-03-25T16:23:29  *** andrewtoth has joined #bitcoin-core-dev
349 2020-03-25T16:26:21  *** shesek has quit IRC
350 2020-03-25T16:26:22  <achow101> something is always wrong with travis..
351 2020-03-25T16:26:45  *** promag has joined #bitcoin-core-dev
352 2020-03-25T16:26:50  *** BamBaRay36 has quit IRC
353 2020-03-25T16:28:34  <vasild> btw that condition "if (addr)" https://github.com/bitcoin/bitcoin/commit/ca126d490#diff-4b0d3d6c6796a93894e682b4073a9865R254 is never going to be false. mmap() returns MAP_FAILED on failure, and given that we already checked that the return value is not MAP_FAILED, then for sure it is going to evaluate to true (e.g. not going to be a null pointer).
354 2020-03-25T16:30:54  *** promag has quit IRC
355 2020-03-25T16:32:10  *** shesek has joined #bitcoin-core-dev
356 2020-03-25T16:33:34  * luke-jr gives up on Windows Update nonsense. How do people even use Windows? smh
357 2020-03-25T16:34:09  <vasild> luke-jr: ^ maybe sneak a removal of "if (addr)" into #15600, or maybe not. It is definitely out of scope.
358 2020-03-25T16:34:11  <gribble> https://github.com/bitcoin/bitcoin/issues/15600 | lockedpool: When possible, use madvise to avoid including sensitive information in core dumps by luke-jr · Pull Request #15600 · bitcoin/bitcoin · GitHub
359 2020-03-25T16:36:59  *** shesek has quit IRC
360 2020-03-25T16:38:40  *** promag has joined #bitcoin-core-dev
361 2020-03-25T16:40:01  *** shesek has joined #bitcoin-core-dev
362 2020-03-25T16:40:03  *** andrewtoth has quit IRC
363 2020-03-25T16:42:20  *** DeanGuss has joined #bitcoin-core-dev
364 2020-03-25T16:42:54  *** promag has quit IRC
365 2020-03-25T16:44:43  *** shesek has quit IRC
366 2020-03-25T16:46:25  *** michaelfolkson has joined #bitcoin-core-dev
367 2020-03-25T16:46:27  *** mael-rolland[m] has quit IRC
368 2020-03-25T16:46:58  *** mrostecki has quit IRC
369 2020-03-25T16:47:08  *** shesek has joined #bitcoin-core-dev
370 2020-03-25T16:48:53  *** mael-rolland[m] has joined #bitcoin-core-dev
371 2020-03-25T16:51:58  *** shesek has quit IRC
372 2020-03-25T16:52:23  <phantomcircuit> luke-jr, windows update is akamai who seem to be randomly on fire from huge demand at the moment
373 2020-03-25T16:53:36  *** andrewtoth has joined #bitcoin-core-dev
374 2020-03-25T16:55:03  <fjahr> wumpus: that looks like the same issue that I saw here https://github.com/bitcoin-core/bitcoin-maintainer-tools/pull/54 I think while there could be something wrong on travis side, Github should definitely not hide the check either way. I will report it to Github as a bug.
375 2020-03-25T16:55:16  *** MrSquanchee has joined #bitcoin-core-dev
376 2020-03-25T16:55:43  *** shesek has joined #bitcoin-core-dev
377 2020-03-25T16:57:20  *** michaelfolkson has quit IRC
378 2020-03-25T16:58:13  *** mrostecki has joined #bitcoin-core-dev
379 2020-03-25T16:58:27  *** r251d has joined #bitcoin-core-dev
380 2020-03-25T16:58:50  *** Chris_Stewart_5 has quit IRC
381 2020-03-25T16:59:49  <luke-jr> phantomcircuit: the download works fine, it just errors installing
382 2020-03-25T17:00:01  <wumpus> vasild: huh, good catch, "On error, the value MAP_FAILED (that is, (void *) -1)". Seems out of scope for this issue but might still make sense to open a PR for it.
383 2020-03-25T17:00:11  *** shesek has quit IRC
384 2020-03-25T17:00:54  <vasild> yes, I was thinking the same
385 2020-03-25T17:01:02  <wumpus> fjahr: ah yes it might be a github issue too, that they skip calling travis for some reason. i suspected a travis issue because last time travis was 'under maintenance' the same happened.
386 2020-03-25T17:01:19  *** michaelfolkson has joined #bitcoin-core-dev
387 2020-03-25T17:03:46  <hebasto> wumpus: since 18331 is merged, mind looking into ##18349 ?
388 2020-03-25T17:03:48  <gribble> https://github.com/bitcoin/bitcoin/issues/18349 | build: Fix quick hack for version string in releases by hebasto · Pull Request #18349 · bitcoin/bitcoin · GitHub
389 2020-03-25T17:06:08  *** Kiminuo has joined #bitcoin-core-dev
390 2020-03-25T17:06:27  *** shesek has joined #bitcoin-core-dev
391 2020-03-25T17:07:21  *** timothy has quit IRC
392 2020-03-25T17:11:18  *** shesek has quit IRC
393 2020-03-25T17:13:46  *** shesek has joined #bitcoin-core-dev
394 2020-03-25T17:14:30  <wumpus> hebasto: sure will take a look
395 2020-03-25T17:15:58  *** felixfoertsch23 has quit IRC
396 2020-03-25T17:16:22  *** felixfoertsch has joined #bitcoin-core-dev
397 2020-03-25T17:16:34  *** timothy has joined #bitcoin-core-dev
398 2020-03-25T17:18:25  <hebasto> wumpus: ty
399 2020-03-25T17:18:33  *** shesek has quit IRC
400 2020-03-25T17:18:43  *** Chris_Stewart_5 has joined #bitcoin-core-dev
401 2020-03-25T17:20:44  *** shesek has joined #bitcoin-core-dev
402 2020-03-25T17:25:19  *** shesek has quit IRC
403 2020-03-25T17:26:00  *** AaronvanW has quit IRC
404 2020-03-25T17:28:25  *** DeanGuss has quit IRC
405 2020-03-25T17:30:27  *** DeanGuss has joined #bitcoin-core-dev
406 2020-03-25T17:31:27  *** shesek has joined #bitcoin-core-dev
407 2020-03-25T17:33:58  *** gloria56 has joined #bitcoin-core-dev
408 2020-03-25T17:35:57  *** shesek has quit IRC
409 2020-03-25T17:38:14  *** shesek has joined #bitcoin-core-dev
410 2020-03-25T17:38:14  *** bitcoin-git has joined #bitcoin-core-dev
411 2020-03-25T17:38:14  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/60a39a96fc04...7c942250264e
412 2020-03-25T17:38:15  <bitcoin-git> bitcoin/master fae1e99 MarcoFalke: ci: Only clone bitcoin-core/qa-assets when fuzzing
413 2020-03-25T17:38:15  <bitcoin-git> bitcoin/master 7c94225 MarcoFalke: Merge #18430: ci: Only clone bitcoin-core/qa-assets when fuzzing
414 2020-03-25T17:38:17  *** bitcoin-git has left #bitcoin-core-dev
415 2020-03-25T17:38:32  *** bitcoin-git has joined #bitcoin-core-dev
416 2020-03-25T17:38:32  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18430: ci: Only clone bitcoin-core/qa-assets when fuzzing (master...2003-ciFuzzClone) https://github.com/bitcoin/bitcoin/pull/18430
417 2020-03-25T17:38:34  *** bitcoin-git has left #bitcoin-core-dev
418 2020-03-25T17:42:43  *** shesek has quit IRC
419 2020-03-25T17:45:04  *** shesek has joined #bitcoin-core-dev
420 2020-03-25T17:49:58  *** shesek has quit IRC
421 2020-03-25T17:54:22  *** shesek has joined #bitcoin-core-dev
422 2020-03-25T17:59:09  *** shesek has quit IRC
423 2020-03-25T18:00:02  *** Snowstormer has quit IRC
424 2020-03-25T18:00:30  *** gloria56 has quit IRC
425 2020-03-25T18:01:24  *** r251d has quit IRC
426 2020-03-25T18:01:42  *** promag has joined #bitcoin-core-dev
427 2020-03-25T18:02:45  *** shesek has joined #bitcoin-core-dev
428 2020-03-25T18:05:46  *** promag has quit IRC
429 2020-03-25T18:05:56  *** AaronvanW has joined #bitcoin-core-dev
430 2020-03-25T18:06:20  *** ^Gise^ has joined #bitcoin-core-dev
431 2020-03-25T18:06:29  *** ^Gise^ has left #bitcoin-core-dev
432 2020-03-25T18:07:22  *** shesek has quit IRC
433 2020-03-25T18:09:43  *** shesek has joined #bitcoin-core-dev
434 2020-03-25T18:10:14  *** AaronvanW has quit IRC
435 2020-03-25T18:13:15  <fjahr> wumpus: yes, but even if there is an issue on travis' side then at least Github should warn that one of the checks didn't run in my opinion. I had to send them an email. Seems like they can't think of a better way to track issues %)
436 2020-03-25T18:13:29  *** timothy has quit IRC
437 2020-03-25T18:14:37  *** shesek has quit IRC
438 2020-03-25T18:16:14  *** as_pnn has quit IRC
439 2020-03-25T18:16:39  *** shesek has joined #bitcoin-core-dev
440 2020-03-25T18:19:31  *** as_pnn has joined #bitcoin-core-dev
441 2020-03-25T18:21:23  *** shesek has quit IRC
442 2020-03-25T18:22:01  *** them_ has joined #bitcoin-core-dev
443 2020-03-25T18:23:24  *** shesek has joined #bitcoin-core-dev
444 2020-03-25T18:24:28  <wumpus> hehe
445 2020-03-25T18:28:03  *** molly has joined #bitcoin-core-dev
446 2020-03-25T18:28:09  *** shesek has quit IRC
447 2020-03-25T18:28:14  *** Guyver2_ has joined #bitcoin-core-dev
448 2020-03-25T18:30:59  *** mol has quit IRC
449 2020-03-25T18:31:08  *** Guyver2 has quit IRC
450 2020-03-25T18:31:18  *** Guyver2_ is now known as Guyver2
451 2020-03-25T18:33:39  *** promag has joined #bitcoin-core-dev
452 2020-03-25T18:34:03  *** shesek has joined #bitcoin-core-dev
453 2020-03-25T18:37:03  *** michaelfolkson has quit IRC
454 2020-03-25T18:38:20  *** promag has quit IRC
455 2020-03-25T18:38:47  *** shesek has quit IRC
456 2020-03-25T18:40:15  *** AaronvanW has joined #bitcoin-core-dev
457 2020-03-25T18:40:37  *** molly has quit IRC
458 2020-03-25T18:42:48  *** shesek has joined #bitcoin-core-dev
459 2020-03-25T18:44:35  *** mol has joined #bitcoin-core-dev
460 2020-03-25T18:47:29  *** shesek has quit IRC
461 2020-03-25T18:49:48  *** shesek has joined #bitcoin-core-dev
462 2020-03-25T18:51:48  *** michaelfolkson has joined #bitcoin-core-dev
463 2020-03-25T18:58:30  *** Dean_Guss has joined #bitcoin-core-dev
464 2020-03-25T19:01:18  *** DeanWeen has joined #bitcoin-core-dev
465 2020-03-25T19:01:43  *** DeanGuss has quit IRC
466 2020-03-25T19:02:17  *** promag has joined #bitcoin-core-dev
467 2020-03-25T19:04:43  *** Dean_Guss has quit IRC
468 2020-03-25T19:12:22  *** bitcoin-git has joined #bitcoin-core-dev
469 2020-03-25T19:12:23  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7c942250264e...2e97d8001705
470 2020-03-25T19:12:23  <bitcoin-git> bitcoin/master d056df0 Ben Woosley: Replace std::to_string with locale-independent alternative
471 2020-03-25T19:12:24  <bitcoin-git> bitcoin/master 2e97d80 Wladimir J. van der Laan: Merge #18134: Replace std::to_string with locale-independent alternative
472 2020-03-25T19:12:25  *** bitcoin-git has left #bitcoin-core-dev
473 2020-03-25T19:12:42  *** bitcoin-git has joined #bitcoin-core-dev
474 2020-03-25T19:12:43  <bitcoin-git> [bitcoin] laanwj merged pull request #18134: Replace std::to_string with locale-independent alternative (master...2020-02-to-string) https://github.com/bitcoin/bitcoin/pull/18134
475 2020-03-25T19:12:44  *** bitcoin-git has left #bitcoin-core-dev
476 2020-03-25T19:15:28  *** Krellan_ has joined #bitcoin-core-dev
477 2020-03-25T19:16:24  *** Dean_Guss has joined #bitcoin-core-dev
478 2020-03-25T19:18:26  *** promag has quit IRC
479 2020-03-25T19:19:27  *** DeanGuss has joined #bitcoin-core-dev
480 2020-03-25T19:19:41  *** timothy has joined #bitcoin-core-dev
481 2020-03-25T19:19:43  *** DeanWeen has quit IRC
482 2020-03-25T19:19:54  *** MrSquanchee has quit IRC
483 2020-03-25T19:22:23  *** Dean_Guss has quit IRC
484 2020-03-25T19:28:01  *** Talkless has quit IRC
485 2020-03-25T19:36:47  *** pingwindyktator has quit IRC
486 2020-03-25T19:37:14  *** pingwindyktator has joined #bitcoin-core-dev
487 2020-03-25T19:40:51  *** vasild_ has joined #bitcoin-core-dev
488 2020-03-25T19:44:03  *** vasild has quit IRC
489 2020-03-25T19:44:04  *** vasild_ is now known as vasild
490 2020-03-25T19:47:23  *** promag has joined #bitcoin-core-dev
491 2020-03-25T19:48:49  *** luke-jr has quit IRC
492 2020-03-25T19:50:43  *** roconnor has quit IRC
493 2020-03-25T19:51:42  *** promag has quit IRC
494 2020-03-25T19:52:21  *** luke-jr has joined #bitcoin-core-dev
495 2020-03-25T19:53:42  <vasild> luke-jr: jonatack: wumpus: Do you think that #15600 may create too crippled core files and thus impede debugging? In gdb, inspecting a core file and trying to read the value of a pointer that points to a removed page I get "Cannot access memory at address 0x803200000" which looks like a bogus/dangling pointer.
496 2020-03-25T19:53:44  <gribble> https://github.com/bitcoin/bitcoin/issues/15600 | lockedpool: When possible, use madvise to avoid including sensitive information in core dumps by luke-jr · Pull Request #15600 · bitcoin/bitcoin · GitHub
497 2020-03-25T19:55:10  <vasild> I do not want to bloat the PR with this, but maybe surround the madvise(DONTDUMP) call with "#ifdef DEBUG"?
498 2020-03-25T19:55:47  <vasild> I mean #ifndef
499 2020-03-25T19:57:32  *** DeanGuss has quit IRC
500 2020-03-25T19:59:10  <jonatack> vasild: interesting review, good catch! am trying to reproduce your tests with the steps you gave
501 2020-03-25T19:59:16  <vasild> I am ok with the patch as it is. Just got this thought which you may want to consider.
502 2020-03-25T19:59:56  <vasild> jonatack: abort() is king! :)
503 2020-03-25T20:00:32  <jonatack> :)
504 2020-03-25T20:01:56  <sipa> vasild: due to our secure allocator, the only thing actually stored in the protected pages is private keys
505 2020-03-25T20:02:15  <sipa> so i think the degree to which it would hurt debugging is probably very limited?
506 2020-03-25T20:05:44  <vasild> sipa: this is why I only mention it here instead of "bloating the PR". Btw, at least some random bytes are also allocated with the secure_allocator, see https://bpaste.net/RWOQ
507 2020-03-25T20:06:00  <luke-jr> vasild: that's what it's supposed to do..
508 2020-03-25T20:06:25  <sipa> right, the RNG state, of course
509 2020-03-25T20:06:40  <sipa> my point is mainly that it's just *data* that's stored there
510 2020-03-25T20:06:52  <sipa> not for example allocation tables
511 2020-03-25T20:07:06  <sipa> or complex data structures
512 2020-03-25T20:07:21  <luke-jr> I don't know any way to execute anything in a coredump-loaded gdb, but if there is, you could also fix it by mmaping something
513 2020-03-25T20:07:37  <luke-jr> (IIRC, mmap lets you choose a location)
514 2020-03-25T20:07:52  <sipa> luke-jr: i don't follow
515 2020-03-25T20:08:12  *** promag has joined #bitcoin-core-dev
516 2020-03-25T20:08:20  <luke-jr> sipa: if you're worried that you may get a SEGV running some funcitons to debug with, you can simply first mmap a blank file to the DONTDUMP pages
517 2020-03-25T20:08:42  <vasild> ok, so leave the PR as is
518 2020-03-25T20:09:02  <sipa> luke-jr: i don't think you can execute anything in a core-dump inspection; just observe
519 2020-03-25T20:09:15  <sipa> and non-dumped data you cannot observe
520 2020-03-25T20:09:29  <luke-jr> sipa: right, I don't know a way how either; but in that scenario, you can't get a SEGV either
521 2020-03-25T20:09:51  <luke-jr> being unable to observe non-dumped data, is the point of the PR
522 2020-03-25T20:10:37  <sipa> it may be undesirable in debug settings, which is certainly true
523 2020-03-25T20:12:14  *** promag has quit IRC
524 2020-03-25T20:19:28  *** Krellan_ has quit IRC
525 2020-03-25T20:27:55  *** captjakk has joined #bitcoin-core-dev
526 2020-03-25T20:30:39  *** Krellan_ has joined #bitcoin-core-dev
527 2020-03-25T20:37:32  <wumpus> vasild: I think that's an acceptable risk personally, we have to err on the side of security/privacy in general
528 2020-03-25T20:38:07  <wumpus> I think people rarely use core files for debugging, but if they do, if that means gdb gives a few more warnings I think that's acceptable
529 2020-03-25T20:38:40  <wumpus> yes, as sipa  already says, it only applies to private key data and some very limited things
530 2020-03-25T20:38:56  <vasild> +1
531 2020-03-25T20:39:11  <jonatack> reproduced vasild's findings
532 2020-03-25T20:39:45  *** DeanGuss has joined #bitcoin-core-dev
533 2020-03-25T20:40:02  <jonatack> describing with a comment in the PR
534 2020-03-25T20:41:12  <vasild> So it works! \o/
535 2020-03-25T20:41:35  <jonatack> yes! good stuff
536 2020-03-25T20:42:42  *** Krellan_ has quit IRC
537 2020-03-25T20:46:14  *** niska has quit IRC
538 2020-03-25T20:46:32  *** niska has joined #bitcoin-core-dev
539 2020-03-25T20:49:06  *** masterdonx2 has joined #bitcoin-core-dev
540 2020-03-25T20:49:47  *** MasterdonX has quit IRC
541 2020-03-25T20:56:43  *** andrewtoth_ has joined #bitcoin-core-dev
542 2020-03-25T20:58:03  *** andrewtoth has quit IRC
543 2020-03-25T21:00:02  *** them_ has quit IRC
544 2020-03-25T21:01:48  *** BamBaRay36 has joined #bitcoin-core-dev
545 2020-03-25T21:14:22  *** captjakk has quit IRC
546 2020-03-25T21:19:17  *** promag has joined #bitcoin-core-dev
547 2020-03-25T21:21:09  *** kutio has joined #bitcoin-core-dev
548 2020-03-25T21:25:39  *** promag has quit IRC
549 2020-03-25T21:35:58  *** captjakk has joined #bitcoin-core-dev
550 2020-03-25T21:38:43  *** DeanGuss has quit IRC
551 2020-03-25T21:39:36  *** manantial has quit IRC
552 2020-03-25T21:40:07  *** kristapsk has joined #bitcoin-core-dev
553 2020-03-25T21:52:18  *** jb55 has quit IRC
554 2020-03-25T22:10:41  *** mdunnio has quit IRC
555 2020-03-25T22:10:51  <fjahr> Is there a github access token available in travis and if yes, what is the variable name? I would need it to prevent running into rate limiting with #18399
556 2020-03-25T22:10:52  <gribble> https://github.com/bitcoin/bitcoin/issues/18399 | lint: PR description linter by fjahr · Pull Request #18399 · bitcoin/bitcoin · GitHub
557 2020-03-25T22:11:38  *** mdunnio has joined #bitcoin-core-dev
558 2020-03-25T22:16:27  *** mdunnio has quit IRC
559 2020-03-25T22:20:58  *** JeromeLegoupil has joined #bitcoin-core-dev
560 2020-03-25T22:22:57  *** jonatack has quit IRC
561 2020-03-25T22:26:26  *** shigeya has quit IRC
562 2020-03-25T22:27:16  *** fengling has quit IRC
563 2020-03-25T22:29:05  *** shigeya has joined #bitcoin-core-dev
564 2020-03-25T22:29:25  *** fengling has joined #bitcoin-core-dev
565 2020-03-25T22:30:35  *** JeromeLegoupil has quit IRC
566 2020-03-25T22:31:41  *** jonatack has joined #bitcoin-core-dev
567 2020-03-25T22:39:29  *** Krellan_ has joined #bitcoin-core-dev
568 2020-03-25T22:42:40  *** Guyver2 has quit IRC
569 2020-03-25T22:43:54  *** Krellan_ has quit IRC
570 2020-03-25T22:51:04  *** mdunnio has joined #bitcoin-core-dev
571 2020-03-25T22:55:34  *** mdunnio has quit IRC
572 2020-03-25T22:58:14  *** AaronvanW has quit IRC
573 2020-03-25T23:00:00  *** apaval has quit IRC
574 2020-03-25T23:00:19  *** apaval has joined #bitcoin-core-dev
575 2020-03-25T23:02:03  *** emilengler has quit IRC
576 2020-03-25T23:02:17  *** emilengler has joined #bitcoin-core-dev
577 2020-03-25T23:16:14  *** bitcoin-git has joined #bitcoin-core-dev
578 2020-03-25T23:16:14  <bitcoin-git> [bitcoin] practicalswift opened pull request #18432: util: Make current implicit C++ locale assumption in tfm::format(...) explicit (master...cpp-locale) https://github.com/bitcoin/bitcoin/pull/18432
579 2020-03-25T23:16:16  *** bitcoin-git has left #bitcoin-core-dev
580 2020-03-25T23:21:01  *** justanotheruser has quit IRC
581 2020-03-25T23:29:15  *** Chris_Stewart_5 has quit IRC
582 2020-03-25T23:30:18  *** mdunnio has joined #bitcoin-core-dev
583 2020-03-25T23:34:34  *** mdunnio has quit IRC
584 2020-03-25T23:45:17  *** marcoagner has quit IRC
585 2020-03-25T23:51:26  *** gleb has quit IRC
586 2020-03-25T23:51:53  *** gleb has joined #bitcoin-core-dev
587 2020-03-25T23:56:14  *** gleb has quit IRC
588 2020-03-25T23:56:52  *** justanotheruser has joined #bitcoin-core-dev
589 2020-03-25T23:57:50  *** gleb has joined #bitcoin-core-dev