12020-03-25T00:00:02 *** rejon1 has quit IRC
22020-03-25T00:02:44 *** AaronvanW has quit IRC
32020-03-25T00:04:33 *** felixfoertsch has quit IRC
42020-03-25T00:11:20 <luke-jr> did anyone ever confirm that #17740 doesn't reintroduce CVE-2012-1910?
52020-03-25T00:11:22 <gribble> https://github.com/bitcoin/bitcoin/issues/17740 | build: remove configure checks for win libraries we dont link against by fanquake · Pull Request #17740 · bitcoin/bitcoin · GitHub
62020-03-25T00:12:33 <fanquake> luke-jr: Those checks don't determine what is linked against
72020-03-25T00:14:40 <fanquake> From what I remember we did discuss that in the issue, and the only libs that were removed were unused.
82020-03-25T00:15:45 <luke-jr> fanquake: it's supposed to
92020-03-25T00:15:50 *** dviola has quit IRC
102020-03-25T00:17:32 <fanquake> You're right. I've just re-read, and at the time I did check that none of those libs were being passed to the linker
112020-03-25T00:20:56 *** felixfoertsch has joined #bitcoin-core-dev
122020-03-25T00:22:07 *** hmachado has joined #bitcoin-core-dev
132020-03-25T00:22:28 <luke-jr> which makes my question: have we reintroduced it previously? XD
142020-03-25T00:24:07 *** belcher has quit IRC
152020-03-25T00:24:48 <fanquake> luke-jr: I'll look. btw if you've got time can you rebase #15704
162020-03-25T00:24:50 <gribble> https://github.com/bitcoin/bitcoin/issues/15704 | Move Win32 defines to configure.ac to ensure they are globally defined by luke-jr · Pull Request #15704 · bitcoin/bitcoin · GitHub
172020-03-25T00:26:17 <fanquake> This is the link for master: https://gist.github.com/fanquake/7d1c147ba28a36b1690e8b42bed3bfc8
182020-03-25T00:28:45 <luke-jr> well, of course it won't be linking with the removed checks _now_ :P
192020-03-25T00:30:39 <luke-jr> if I add the AC_CHECK_LIB back in, it seems to link to it
202020-03-25T00:33:19 <fanquake> luke-jr: It's the same for something like winspool though right? It'll link to it even though we don't use it
212020-03-25T00:33:46 <luke-jr> fanquake: using threads in mingw requires linking it
222020-03-25T00:33:53 <luke-jr> otherwise we get thread-unsafe stuff linked in
232020-03-25T00:33:57 *** marcoagner has quit IRC
242020-03-25T00:35:32 <fanquake> Can you point to any mingwthrd documentation? I'm struggling to find anything that isn't close to 10+ years old
252020-03-25T00:36:47 <luke-jr> -mthreads
262020-03-25T00:36:49 <luke-jr> Support thread-safe exception handling on MinGW. Programs that rely on thread-safe exception handling must compile and link all code with
272020-03-25T00:36:50 <luke-jr> the -mthreads option. When compiling, -mthreads defines -D_MT; when linking, it links in a special thread helper library -lmingwthrd which
282020-03-25T00:36:52 <luke-jr> cleans up per-thread exception-handling data.
292020-03-25T00:36:53 <luke-jr> from `man gcc`
302020-03-25T00:37:37 <luke-jr> (-mthreads IIRC is itself broken for static linking though)
312020-03-25T00:38:15 * fanquake looking
322020-03-25T00:42:12 *** dviola has joined #bitcoin-core-dev
332020-03-25T00:42:41 *** jb551 has quit IRC
342020-03-25T00:46:44 *** jb55 has joined #bitcoin-core-dev
352020-03-25T00:48:28 <luke-jr> wumpus: ping^ in case you investigated already
362020-03-25T00:54:38 *** AaronvanW has joined #bitcoin-core-dev
372020-03-25T00:56:46 <luke-jr> fanquake: http://gavintech.blogspot.com/2012/03/full-disclosure-bitcoin-qt-on-windows.html
382020-03-25T00:59:10 *** AaronvanW has quit IRC
392020-03-25T01:01:41 *** Highway61 has quit IRC
402020-03-25T01:10:44 *** Krellan_ has joined #bitcoin-core-dev
412020-03-25T01:12:59 <fanquake> luke-jr: I canât test right now but will by the end of the day
422020-03-25T01:15:25 <luke-jr> I'm working on it; will just dig out the Windows test box
432020-03-25T01:16:13 *** Krellan_ has quit IRC
442020-03-25T01:16:34 <fanquake> Just make sure you update it first so you donât get RCEâd
452020-03-25T01:21:11 <luke-jr> RCE'd?
462020-03-25T01:22:38 <luke-jr> or I should ask: which one? :p
472020-03-25T01:40:32 *** GreyJediCode has joined #bitcoin-core-dev
482020-03-25T01:47:50 *** mdunnio has joined #bitcoin-core-dev
492020-03-25T02:20:38 <luke-jr> 21633 ? S 0:00 /usr/bin/i686-w64-mingw32-g++-posix -std=c++11 -fstack-reuse=none -Wstack-protector -fstack-protector-all -fPIE -pipe -O2 -O2 -g -fno-ident -fvisibility=hidden -Wl,--exclude-libs -Wl,ALL -pthread -Wl,--dynamicbase -Wl,--nxcompat -pie -static -Wl,--large-address-aware -o bitcoin-cli.exe bitcoin_cli-bitcoin-cli.o bitcoin-cli-res.o -L/home/ubuntu/build/bitcoin/depends/i686-w64-mingw32/share/../lib libbitcoin_cli.a
502020-03-25T02:20:40 <luke-jr> univalue/.libs/libunivalue.a libbitcoin_util.a crypto/libbitcoin_crypto_base.a crypto/libbitcoin_crypto_sse41.a crypto/libbitcoin_crypto_avx2.a crypto/libbitcoin_crypto_shani.a -lboost_system-mt-s-x32 -lboost_filesystem-mt-s-x32 -lboost_thread-mt-s-x32 -levent -lQt5AccessibilitySupport -lQt5DeviceDiscoverySupport -lQt5FbSupport -lQt5ThemeSupport -lQt5EventDispatcherSupport -lQt5FontDatabaseSupport -lssp -liphlpapi -lshlwapi -lws2_32 -
512020-03-25T02:20:41 <luke-jr> ladvapi32 -luuid -loleaut32 -lole32 -lcomctl32 -lshell32 -lwinmm -lcomdlg32 -lgdi32 -luser32 -lkernel32 -lmingwthrd -pthread
522020-03-25T02:20:55 <luke-jr> so -lmingwthrd is definitely being passed here
532020-03-25T02:26:34 *** Klox has quit IRC
542020-03-25T02:29:36 *** dviola has quit IRC
552020-03-25T02:30:25 <fanquake> luke-jr: looking at the mingw-w64 source, in regards to mingwthrd I'm seeing: As _CRT_MT is getting defined in libgcc when using shared version, or it is getting defined by startup code itself, this library is a dummy version for supporting the link library for gcc's option -mthreads. As we support TLS-cleanup even without specifying this library, this library is deprecated and just kept for compatibility.
562020-03-25T02:31:08 <fanquake> The only code in mingwthrd_mt.c is: int _CRT_MT_OLD = 1;
572020-03-25T02:31:56 <fanquake> mingwthrd_mt.c is the source for libmingwthrd.a
582020-03-25T02:33:47 <fanquake> https://sourceforge.net/p/mingw-w64/mingw-w64/ci/master/tree/mingw-w64-crt/libsrc/mingwthrd_mt.c
592020-03-25T02:41:04 <luke-jr> that file hasn't changed since Date: Fri Jun 26 10:49:35 2009 +0000
602020-03-25T02:42:30 <fanquake> Yea I'm looking at the history now. Those changes happened in 22b6398a8acf17e6687375c414fae832888de53a
612020-03-25T02:42:51 <luke-jr> we also don't have a minimum mingw version afaik
622020-03-25T02:43:04 <luke-jr> if we decide to bump it, we should also check it meets the required version
632020-03-25T02:44:01 <luke-jr> that commit first released in 2.0, sometime after Date: Tue Oct 4 15:17:14 2011 +0000
642020-03-25T02:44:43 <luke-jr> but CVE-2012-1910 was Date: 2012-03-17
652020-03-25T02:45:32 <fanquake> Right, because gitian builds would likely have been done with an older version of mingw-w64
662020-03-25T02:46:05 *** justan0theruser has joined #bitcoin-core-dev
672020-03-25T02:46:22 *** justanotheruser has quit IRC
682020-03-25T02:47:59 * luke-jr checking that
692020-03-25T02:49:21 <fanquake> Need to find out what version of mingw-w64 was shipping with ubuntu lucid
702020-03-25T02:49:34 <fanquake> *mingw32
712020-03-25T02:51:44 *** mdunnio has quit IRC
722020-03-25T02:53:46 <luke-jr> Version: 3.15.2-0ubuntu1
732020-03-25T02:53:48 <luke-jr> :/
742020-03-25T02:54:03 <luke-jr> there is no 3.15 tho
752020-03-25T02:55:43 *** GreyJediCode has quit IRC
762020-03-25T02:56:12 *** AaronvanW has joined #bitcoin-core-dev
772020-03-25T02:56:17 *** roconnor has quit IRC
782020-03-25T03:00:02 *** hmachado has quit IRC
792020-03-25T03:00:28 <luke-jr> mingwrt-3.15.2-mingw32/include/_mingw.h:#define __MINGW32_VERSION 3.15.2
802020-03-25T03:00:30 <luke-jr> sigh
812020-03-25T03:01:48 <luke-jr> I propose we just add mingwthrd back in. It's harmless at worst.
822020-03-25T03:06:05 <luke-jr> 26805 ? S 0:00 /usr/bin/x86_64-w64-mingw32-g++-posix -std=c++11 -fstack-reuse=none -Wstack-protector -fstack-protector-all -fPIE -pipe -O2 -O2 -g -fno-ident -fvisibility=hidden -Wl,--exclude-libs -Wl,ALL -pthread -Wl,--dynamicbase -Wl,--nxcompat -Wl,--high-entropy-va -pie -static -o bitcoind.exe bitcoind-bitcoind.o bitcoind-res.o -L/home/ubuntu/build/bitcoin/depends/x86_64-w64-mingw32/share/../lib libbitcoin_server.a libbitcoin_
832020-03-25T03:06:07 <luke-jr> wallet.a libbitcoin_common.a univalue/.libs/libunivalue.a libbitcoin_util.a libbitcoin_zmq.a libbitcoin_consensus.a crypto/libbitcoin_crypto_base.a crypto/libbitcoin_crypto_sse41.a crypto/libbitcoin_crypto_avx2.a crypto/libbitcoin_crypto_shani.a leveldb/libleveldb.a crc32c/libcrc32c.a crc32c/libcrc32c_sse42.a leveldb/libmemenv.a secp256k1/.libs/libsecp256k1.a -lboost_system-mt-s-x64 -lboost_filesystem-mt-s-x64 -lboost_thread-mt-s-x64 -ldb_
842020-03-25T03:06:09 <luke-jr> cxx-4.8 -lminiupnpc -levent -lzmq -lQt5AccessibilitySupport -lQt5DeviceDiscoverySupport -lQt5FbSupport -lQt5ThemeSupport -lQt5EventDispatcherSupport -lQt5FontDatabaseSupport -lssp -liphlpapi -lshlwapi -lws2_32 -ladvapi32 -luuid -loleaut32 -lole32 -lcomctl32 -lshell32 -lwinmm -lcomdlg32 -lgdi32 -luser32 -lkernel32 -lmingwthrd -pthread
852020-03-25T03:06:10 <luke-jr> so x86_64 uses it too
862020-03-25T03:10:58 <fanquake> I just checked that binaries produced with and without -lmingwthrd are basically identical. I see 5 bytes difference, and that's the git commit and what looks like 2 timestamps.
872020-03-25T03:13:03 *** sipa has quit IRC
882020-03-25T03:13:30 *** bitcoin-git has joined #bitcoin-core-dev
892020-03-25T03:13:31 <bitcoin-git> [bitcoin] luke-jr opened pull request #18427: Bugfix? Restore linking to libmingwthrd (master...2020mingwthrd) https://github.com/bitcoin/bitcoin/pull/18427
902020-03-25T03:13:43 *** bitcoin-git has left #bitcoin-core-dev
912020-03-25T03:20:12 *** laen_ has joined #bitcoin-core-dev
922020-03-25T03:23:07 *** Krellan_ has joined #bitcoin-core-dev
932020-03-25T03:24:41 *** mdunnio has joined #bitcoin-core-dev
942020-03-25T03:27:26 *** sipa has joined #bitcoin-core-dev
952020-03-25T03:29:37 *** mdunnio has quit IRC
962020-03-25T03:29:39 *** AaronvanW has quit IRC
972020-03-25T03:32:37 *** Krellan_ has quit IRC
982020-03-25T03:34:21 *** justan0theruser has quit IRC
992020-03-25T03:34:41 *** justanotheruser has joined #bitcoin-core-dev
1002020-03-25T03:38:44 *** Highway61 has joined #bitcoin-core-dev
1012020-03-25T03:44:48 *** felixfoertsch23 has joined #bitcoin-core-dev
1022020-03-25T03:47:37 *** felixfoertsch has quit IRC
1032020-03-25T04:14:30 <fanquake> MarcoFalke: did DrahtBot get an upgrade: https://github.com/bitcoin/bitcoin/pull/18426#discussion_r397534721
1042020-03-25T04:16:32 *** Krellan_ has joined #bitcoin-core-dev
1052020-03-25T04:19:34 *** roconnor has joined #bitcoin-core-dev
1062020-03-25T04:59:03 *** Highway61 has quit IRC
1072020-03-25T05:19:27 *** Krellan_ has quit IRC
1082020-03-25T05:26:49 *** AaronvanW has joined #bitcoin-core-dev
1092020-03-25T05:44:30 *** mdunnio has joined #bitcoin-core-dev
1102020-03-25T05:48:34 *** mdunnio has quit IRC
1112020-03-25T05:50:35 *** apaval has quit IRC
1122020-03-25T05:58:32 *** Talkless has joined #bitcoin-core-dev
1132020-03-25T05:59:10 *** Highway61 has joined #bitcoin-core-dev
1142020-03-25T05:59:17 *** AaronvanW has quit IRC
1152020-03-25T05:59:43 *** Talkless has quit IRC
1162020-03-25T06:00:01 *** laen_ has quit IRC
1172020-03-25T06:13:57 *** as_pnn has joined #bitcoin-core-dev
1182020-03-25T06:21:53 *** zerstoerer has joined #bitcoin-core-dev
1192020-03-25T06:23:40 *** tsujp has joined #bitcoin-core-dev
1202020-03-25T06:33:10 *** tsujp has quit IRC
1212020-03-25T06:34:44 *** tsujp has joined #bitcoin-core-dev
1222020-03-25T06:36:44 *** bitcoin-git has joined #bitcoin-core-dev
1232020-03-25T06:36:44 <bitcoin-git> [bitcoin] kallewoof closed pull request #16440: BIP-322: Generic signed message format (master...feature-generic-signed-message-format) https://github.com/bitcoin/bitcoin/pull/16440
1242020-03-25T06:36:45 *** bitcoin-git has left #bitcoin-core-dev
1252020-03-25T06:38:52 *** Livestradamus has quit IRC
1262020-03-25T06:39:14 *** Livestradamus has joined #bitcoin-core-dev
1272020-03-25T06:47:22 *** tsujp has quit IRC
1282020-03-25T06:51:34 *** Kiminuo has quit IRC
1292020-03-25T06:58:36 *** apaval has joined #bitcoin-core-dev
1302020-03-25T07:00:28 *** Kiminuo has joined #bitcoin-core-dev
1312020-03-25T07:13:50 *** BGL has quit IRC
1322020-03-25T07:14:38 *** Kiminuo has quit IRC
1332020-03-25T07:14:59 *** Kiminuo has joined #bitcoin-core-dev
1342020-03-25T07:16:17 *** Krellan_ has joined #bitcoin-core-dev
1352020-03-25T07:22:19 *** Krellan_ has quit IRC
1362020-03-25T07:29:48 *** Guyver2 has joined #bitcoin-core-dev
1372020-03-25T07:40:57 *** vasild_ has joined #bitcoin-core-dev
1382020-03-25T07:41:30 *** bitcoin-git has joined #bitcoin-core-dev
1392020-03-25T07:41:30 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5236b2e267a5...5b4a9f4bdf9d
1402020-03-25T07:41:30 <bitcoin-git> bitcoin/master 33dd764 practicalswift: doc: Add fuzzing quickstart guides for libFuzzer and afl-fuzz. Simplify in...
1412020-03-25T07:41:31 <bitcoin-git> bitcoin/master 5b4a9f4 fanquake: Merge #18342: doc: Add fuzzing quickstart guides for libFuzzer and afl-fuz...
1422020-03-25T07:41:32 *** bitcoin-git has left #bitcoin-core-dev
1432020-03-25T07:41:50 *** bitcoin-git has joined #bitcoin-core-dev
1442020-03-25T07:41:50 <bitcoin-git> [bitcoin] fanquake merged pull request #18342: doc: Add fuzzing quickstart guides for libFuzzer and afl-fuzz (master...fuzzing-quick-start-guide) https://github.com/bitcoin/bitcoin/pull/18342
1452020-03-25T07:41:51 *** bitcoin-git has left #bitcoin-core-dev
1462020-03-25T07:43:43 *** vasild has quit IRC
1472020-03-25T07:43:44 *** vasild_ is now known as vasild
1482020-03-25T07:53:01 *** felixfoertsch23 has quit IRC
1492020-03-25T07:56:24 *** AaronvanW has joined #bitcoin-core-dev
1502020-03-25T07:56:32 *** SiAnDoG__ has quit IRC
1512020-03-25T07:56:53 *** SiAnDoG__ has joined #bitcoin-core-dev
1522020-03-25T08:00:48 *** bitcoin-git has joined #bitcoin-core-dev
1532020-03-25T08:00:48 <bitcoin-git> [bitcoin] fanquake closed pull request #18377: build: fix libevent linking errors for bench-only builds (master...bench-compilation) https://github.com/bitcoin/bitcoin/pull/18377
1542020-03-25T08:00:49 *** bitcoin-git has left #bitcoin-core-dev
1552020-03-25T08:10:15 *** felixfoertsch has joined #bitcoin-core-dev
1562020-03-25T08:27:22 *** tsujp_ has joined #bitcoin-core-dev
1572020-03-25T08:29:45 *** AaronvanW has quit IRC
1582020-03-25T08:30:13 *** tsujp has joined #bitcoin-core-dev
1592020-03-25T08:32:21 *** tsujp_ has quit IRC
1602020-03-25T08:33:10 *** tsujp__ has joined #bitcoin-core-dev
1612020-03-25T08:36:09 *** tsujp has quit IRC
1622020-03-25T08:37:58 *** manantial has joined #bitcoin-core-dev
1632020-03-25T08:38:45 *** tsujp__ has quit IRC
1642020-03-25T09:00:02 *** zerstoerer has quit IRC
1652020-03-25T09:01:23 *** BGL has joined #bitcoin-core-dev
1662020-03-25T09:01:32 *** AaronvanW has joined #bitcoin-core-dev
1672020-03-25T09:15:22 *** felixfoertsch has quit IRC
1682020-03-25T09:15:44 *** felixfoertsch has joined #bitcoin-core-dev
1692020-03-25T09:16:34 *** tsujp has joined #bitcoin-core-dev
1702020-03-25T09:19:00 *** Krellan_ has joined #bitcoin-core-dev
1712020-03-25T09:20:45 *** felixfoertsch has quit IRC
1722020-03-25T09:22:21 *** RiscTaker1 has joined #bitcoin-core-dev
1732020-03-25T09:23:37 *** Krellan_ has quit IRC
1742020-03-25T09:23:40 *** AaronvanW has quit IRC
1752020-03-25T09:23:58 *** AaronvanW has joined #bitcoin-core-dev
1762020-03-25T09:31:51 *** marcoagner has joined #bitcoin-core-dev
1772020-03-25T09:32:52 *** felixfoertsch has joined #bitcoin-core-dev
1782020-03-25T09:40:26 *** tsujp has quit IRC
1792020-03-25T09:56:35 *** timothy has joined #bitcoin-core-dev
1802020-03-25T10:21:43 *** as_pnn has quit IRC
1812020-03-25T10:23:08 *** as_pnn has joined #bitcoin-core-dev
1822020-03-25T10:25:49 *** felixfoertsch23 has joined #bitcoin-core-dev
1832020-03-25T10:26:14 *** felixfoertsch has quit IRC
1842020-03-25T10:28:03 *** theStack has joined #bitcoin-core-dev
1852020-03-25T10:29:23 *** sipa has quit IRC
1862020-03-25T10:30:24 *** sipa has joined #bitcoin-core-dev
1872020-03-25T10:30:43 *** braydonf has quit IRC
1882020-03-25T10:31:16 *** braydonf has joined #bitcoin-core-dev
1892020-03-25T10:42:36 *** emilengler has joined #bitcoin-core-dev
1902020-03-25T11:04:03 *** Lisa60Baumbach has joined #bitcoin-core-dev
1912020-03-25T11:28:26 *** Lisa60Baumbach has quit IRC
1922020-03-25T11:28:56 *** AaronvanW has quit IRC
1932020-03-25T11:32:13 *** AaronvanW has joined #bitcoin-core-dev
1942020-03-25T11:34:24 *** roconnor has quit IRC
1952020-03-25T11:36:40 *** bitcoin-git has joined #bitcoin-core-dev
1962020-03-25T11:36:40 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5b4a9f4bdf9d...3f5107d008e1
1972020-03-25T11:36:41 <bitcoin-git> bitcoin/master 87d24e6 practicalswift: tests: Add integer serialization/deserialization fuzzing harness
1982020-03-25T11:36:41 <bitcoin-git> bitcoin/master 102f326 practicalswift: tests: Add fuzzing harness for classes/functions in blockfilter.h
1992020-03-25T11:36:42 <bitcoin-git> bitcoin/master 3f5107d MarcoFalke: Merge #18423: tests: Add fuzzing harness for classes/functions in blockfil...
2002020-03-25T11:36:43 *** bitcoin-git has left #bitcoin-core-dev
2012020-03-25T11:37:00 *** bitcoin-git has joined #bitcoin-core-dev
2022020-03-25T11:37:01 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18423: tests: Add fuzzing harness for classes/functions in blockfilter.h. Add integer {de,}serialization fuzzing. (master...fuzzers-misc-2) https://github.com/bitcoin/bitcoin/pull/18423
2032020-03-25T11:37:02 *** bitcoin-git has left #bitcoin-core-dev
2042020-03-25T11:39:55 <stevenroose> aj: about https://github.com/bitcoin/bitcoin/pull/13990
2052020-03-25T11:40:22 <stevenroose> If you would just have applied https://github.com/bitcoin/bitcoin/pull/13990/commits/c68f796c41b9b145c9c1b2c24aea505362ad1b63 without the other changes, what would have be the problem?
2062020-03-25T11:40:49 <stevenroose> It seems that at least part of the other commits are intended to not require users to remove the fee_estimatoin.dat file, is that correct?
2072020-03-25T11:59:03 *** promag has joined #bitcoin-core-dev
2082020-03-25T12:00:01 *** RiscTaker1 has quit IRC
2092020-03-25T12:03:14 *** promag has quit IRC
2102020-03-25T12:09:22 <aj> stevenroose: seems kinda rude to have to spend a week before you can get fee estimates again?
2112020-03-25T12:11:29 <aj> stevenroose: (if you just did that, users who upgrade would continue to not get estimates for below 1s/B until they deleted their fee_estimates.dat, they'd continue using the same buckets that were current when f_e.dat was generated)
2122020-03-25T12:15:13 <stevenroose> aj: where does that week come from?
2132020-03-25T12:15:25 <stevenroose> does that mean a week before getting any estimate? Or a week before getting reliable ones?
2142020-03-25T12:18:14 <aj> stevenroose: i'm not sure of the numbers, but there's a weekly cycle so i wouldn't really trust the numbers much without that much data
2152020-03-25T12:32:21 *** jb55 has quit IRC
2162020-03-25T12:32:50 *** jb55 has joined #bitcoin-core-dev
2172020-03-25T12:33:20 *** promag has joined #bitcoin-core-dev
2182020-03-25T12:38:07 *** promag has quit IRC
2192020-03-25T12:39:12 *** bitcoin-git has joined #bitcoin-core-dev
2202020-03-25T12:39:13 <bitcoin-git> [bitcoin] brakmic opened pull request #18429: build: remove double LIBBITCOIN_SERVER from bench-Makefile (master...bench-makefile) https://github.com/bitcoin/bitcoin/pull/18429
2212020-03-25T12:39:13 *** bitcoin-git has left #bitcoin-core-dev
2222020-03-25T12:45:41 *** theStack has quit IRC
2232020-03-25T12:56:04 *** sunetoft has joined #bitcoin-core-dev
2242020-03-25T13:06:37 *** mdunnio has joined #bitcoin-core-dev
2252020-03-25T13:11:07 *** promag has joined #bitcoin-core-dev
2262020-03-25T13:11:22 *** mdunnio has quit IRC
2272020-03-25T13:15:33 *** promag has quit IRC
2282020-03-25T13:20:49 *** Krellan_ has joined #bitcoin-core-dev
2292020-03-25T13:21:36 *** Krellan_ has joined #bitcoin-core-dev
2302020-03-25T13:26:29 *** Krellan_ has quit IRC
2312020-03-25T13:34:30 *** mdunnio has joined #bitcoin-core-dev
2322020-03-25T13:44:38 *** promag has joined #bitcoin-core-dev
2332020-03-25T13:49:14 *** bitcoin-git has joined #bitcoin-core-dev
2342020-03-25T13:49:15 <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/3f5107d008e1...baa72cd9a2fd
2352020-03-25T13:49:16 <bitcoin-git> bitcoin/master 5e6b8b3 Hennadii Stepanov: build: Use git archive as source tarball
2362020-03-25T13:49:16 <bitcoin-git> bitcoin/master 6c4da59 Hennadii Stepanov: build: Drop SOURCEDIST reordering
2372020-03-25T13:49:16 *** promag has quit IRC
2382020-03-25T13:49:17 <bitcoin-git> bitcoin/master e4d3667 Hennadii Stepanov: build: Drop needless EXTRA_DIST content
2392020-03-25T13:49:19 *** bitcoin-git has left #bitcoin-core-dev
2402020-03-25T13:49:33 *** bitcoin-git has joined #bitcoin-core-dev
2412020-03-25T13:49:33 <bitcoin-git> [bitcoin] laanwj merged pull request #18331: build: Use git archive as source tarball (master...20200312-git-archive) https://github.com/bitcoin/bitcoin/pull/18331
2422020-03-25T13:49:34 *** bitcoin-git has left #bitcoin-core-dev
2432020-03-25T13:53:58 *** roconnor has joined #bitcoin-core-dev
2442020-03-25T13:56:44 *** AaronvanW has quit IRC
2452020-03-25T14:03:12 *** theStack has joined #bitcoin-core-dev
2462020-03-25T14:07:03 *** braydonf has quit IRC
2472020-03-25T14:11:50 *** bitcoin-git has joined #bitcoin-core-dev
2482020-03-25T14:11:51 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/baa72cd9a2fd...244e88e6b580
2492020-03-25T14:11:52 <bitcoin-git> bitcoin/master aae2605 Jon Atack: gui: display Mapped AS in peers info window
2502020-03-25T14:11:52 <bitcoin-git> bitcoin/master 76db4b2 Jon Atack: gui: avoid QT Designer/Form Editor re-formatting
2512020-03-25T14:11:53 <bitcoin-git> bitcoin/master 244e88e Wladimir J. van der Laan: Merge #18402: gui: display mapped AS in peers info window
2522020-03-25T14:11:55 *** bitcoin-git has left #bitcoin-core-dev
2532020-03-25T14:12:10 *** bitcoin-git has joined #bitcoin-core-dev
2542020-03-25T14:12:10 <bitcoin-git> [bitcoin] laanwj merged pull request #18402: gui: display mapped AS in peers info window (master...gui-peers-display-mapped_as) https://github.com/bitcoin/bitcoin/pull/18402
2552020-03-25T14:12:11 *** bitcoin-git has left #bitcoin-core-dev
2562020-03-25T14:18:44 <wumpus> i think it would be nice to have #15600 in 0.20.0, as it prevents leaking private key data into core dumps; does anyone here know enough about linux internals and madvise() to review / test it?
2572020-03-25T14:18:46 <gribble> https://github.com/bitcoin/bitcoin/issues/15600 | lockedpool: When possible, use madvise to avoid including sensitive information in core dumps by luke-jr · Pull Request #15600 · bitcoin/bitcoin · GitHub
2582020-03-25T14:19:28 *** theStack has quit IRC
2592020-03-25T14:20:26 *** promag has joined #bitcoin-core-dev
2602020-03-25T14:20:36 *** braydonf has joined #bitcoin-core-dev
2612020-03-25T14:23:02 *** DeanWeen has quit IRC
2622020-03-25T14:23:24 <vasild> wumpus: I was just wondering what to pick up next :)
2632020-03-25T14:25:25 *** promag has quit IRC
2642020-03-25T14:29:00 *** AaronvanW has joined #bitcoin-core-dev
2652020-03-25T14:32:44 *** apaval has quit IRC
2662020-03-25T14:33:03 *** apaval has joined #bitcoin-core-dev
2672020-03-25T14:36:18 *** bitcoin-git has joined #bitcoin-core-dev
2682020-03-25T14:36:19 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/244e88e6b580...3e50fdbe4e5b
2692020-03-25T14:36:19 <bitcoin-git> bitcoin/master 1a0993a fanquake: scripts: add PE dylib checking to symbol-check.py
2702020-03-25T14:36:20 <bitcoin-git> bitcoin/master 3e50fdb Wladimir J. van der Laan: Merge #18395: scripts: add PE dylib checking to symbol-check.py
2712020-03-25T14:36:21 *** bitcoin-git has left #bitcoin-core-dev
2722020-03-25T14:36:37 *** bitcoin-git has joined #bitcoin-core-dev
2732020-03-25T14:36:38 <bitcoin-git> [bitcoin] laanwj merged pull request #18395: scripts: add PE dylib checking to symbol-check.py (master...pe_dll_checking) https://github.com/bitcoin/bitcoin/pull/18395
2742020-03-25T14:36:39 *** bitcoin-git has left #bitcoin-core-dev
2752020-03-25T14:41:09 <luke-jr> fanquake: freaking Windows Update fails -.-
2762020-03-25T14:41:15 *** promag has joined #bitcoin-core-dev
2772020-03-25T14:42:58 <jonatack> wumpus: having a look
2782020-03-25T14:43:44 *** slimcognito has quit IRC
2792020-03-25T14:43:44 *** bsm117532 has quit IRC
2802020-03-25T14:43:44 *** nothingmuch has quit IRC
2812020-03-25T14:45:34 *** promag has quit IRC
2822020-03-25T14:47:10 *** shesek has quit IRC
2832020-03-25T14:47:38 *** shesek has joined #bitcoin-core-dev
2842020-03-25T14:49:00 *** justanotheruser has quit IRC
2852020-03-25T14:50:37 <phantomcircuit> luke-jr, akamai is currently exploding a little bit
2862020-03-25T14:52:06 *** shesek has quit IRC
2872020-03-25T14:52:43 *** shesek has joined #bitcoin-core-dev
2882020-03-25T14:54:34 *** Kiminuo has quit IRC
2892020-03-25T14:57:25 *** shesek has quit IRC
2902020-03-25T14:59:27 <luke-jr> phantomcircuit: what?
2912020-03-25T14:59:37 *** shesek has joined #bitcoin-core-dev
2922020-03-25T15:00:02 *** sunetoft has quit IRC
2932020-03-25T15:03:28 *** Talkless has joined #bitcoin-core-dev
2942020-03-25T15:04:11 *** shesek has quit IRC
2952020-03-25T15:06:13 *** captjakk has joined #bitcoin-core-dev
2962020-03-25T15:06:55 *** justanotheruser has joined #bitcoin-core-dev
2972020-03-25T15:07:07 *** captjakk has quit IRC
2982020-03-25T15:07:11 *** shesek has joined #bitcoin-core-dev
2992020-03-25T15:11:55 *** shesek has quit IRC
3002020-03-25T15:14:31 *** bitcoin-git has joined #bitcoin-core-dev
3012020-03-25T15:14:31 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18430: ci: Only clone bitcoin-core/qa-assets when fuzzing (master...2003-ciFuzzClone) https://github.com/bitcoin/bitcoin/pull/18430
3022020-03-25T15:14:32 *** bitcoin-git has left #bitcoin-core-dev
3032020-03-25T15:15:51 *** shesek has joined #bitcoin-core-dev
3042020-03-25T15:18:17 *** promag has joined #bitcoin-core-dev
3052020-03-25T15:19:33 *** apaval has quit IRC
3062020-03-25T15:19:53 *** apaval has joined #bitcoin-core-dev
3072020-03-25T15:20:37 *** shesek has quit IRC
3082020-03-25T15:22:10 *** Snowstormer has joined #bitcoin-core-dev
3092020-03-25T15:22:44 *** shesek has joined #bitcoin-core-dev
3102020-03-25T15:23:29 *** promag has quit IRC
3112020-03-25T15:23:47 *** promag has joined #bitcoin-core-dev
3122020-03-25T15:24:01 *** Krellan_ has joined #bitcoin-core-dev
3132020-03-25T15:27:23 *** shesek has quit IRC
3142020-03-25T15:31:30 *** shesek has joined #bitcoin-core-dev
3152020-03-25T15:32:13 *** AaronvanW has quit IRC
3162020-03-25T15:32:33 *** AaronvanW has joined #bitcoin-core-dev
3172020-03-25T15:36:05 *** shesek has quit IRC
3182020-03-25T15:38:39 *** promag has quit IRC
3192020-03-25T15:38:56 *** AaronvanW has quit IRC
3202020-03-25T15:40:34 *** shesek has joined #bitcoin-core-dev
3212020-03-25T15:45:16 *** shesek has quit IRC
3222020-03-25T15:49:15 *** shesek has joined #bitcoin-core-dev
3232020-03-25T15:49:27 *** bsm117532 has joined #bitcoin-core-dev
3242020-03-25T15:53:58 *** shesek has quit IRC
3252020-03-25T15:55:31 *** promag has joined #bitcoin-core-dev
3262020-03-25T15:56:12 *** Krellan_ has quit IRC
3272020-03-25T15:56:18 *** DeanGuss has joined #bitcoin-core-dev
3282020-03-25T15:58:15 *** shesek has joined #bitcoin-core-dev
3292020-03-25T15:58:57 *** AaronvanW has joined #bitcoin-core-dev
3302020-03-25T15:59:42 *** promag has quit IRC
3312020-03-25T16:03:09 *** shesek has quit IRC
3322020-03-25T16:04:51 *** shesek has joined #bitcoin-core-dev
3332020-03-25T16:05:39 *** bitcoin-git has joined #bitcoin-core-dev
3342020-03-25T16:05:40 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3e50fdbe4e5b...60a39a96fc04
3352020-03-25T16:05:40 <bitcoin-git> bitcoin/master 3e0df92 Andrew Chow: Update with new Windows code signing certificate
3362020-03-25T16:05:41 <bitcoin-git> bitcoin/master 60a39a9 Wladimir J. van der Laan: Merge #18425: releases: Update with new Windows code signing certificate
3372020-03-25T16:05:42 *** bitcoin-git has left #bitcoin-core-dev
3382020-03-25T16:06:00 *** bitcoin-git has joined #bitcoin-core-dev
3392020-03-25T16:06:01 <bitcoin-git> [bitcoin] laanwj merged pull request #18425: releases: Update with new Windows code signing certificate (master...win-cert-3-20) https://github.com/bitcoin/bitcoin/pull/18425
3402020-03-25T16:06:02 *** bitcoin-git has left #bitcoin-core-dev
3412020-03-25T16:09:26 *** shesek has quit IRC
3422020-03-25T16:11:46 *** DeanGuss has quit IRC
3432020-03-25T16:12:41 *** shesek has joined #bitcoin-core-dev
3442020-03-25T16:14:25 <wumpus> is there something wrong with Travis? it looks like it isn't running on #18430
3452020-03-25T16:14:26 <gribble> https://github.com/bitcoin/bitcoin/issues/18430 | ci: Only clone bitcoin-core/qa-assets when fuzzing by MarcoFalke · Pull Request #18430 · bitcoin/bitcoin · GitHub
3462020-03-25T16:17:10 *** shesek has quit IRC
3472020-03-25T16:21:31 *** shesek has joined #bitcoin-core-dev
3482020-03-25T16:23:29 *** andrewtoth has joined #bitcoin-core-dev
3492020-03-25T16:26:21 *** shesek has quit IRC
3502020-03-25T16:26:22 <achow101> something is always wrong with travis..
3512020-03-25T16:26:45 *** promag has joined #bitcoin-core-dev
3522020-03-25T16:26:50 *** BamBaRay36 has quit IRC
3532020-03-25T16:28:34 <vasild> btw that condition "if (addr)" https://github.com/bitcoin/bitcoin/commit/ca126d490#diff-4b0d3d6c6796a93894e682b4073a9865R254 is never going to be false. mmap() returns MAP_FAILED on failure, and given that we already checked that the return value is not MAP_FAILED, then for sure it is going to evaluate to true (e.g. not going to be a null pointer).
3542020-03-25T16:30:54 *** promag has quit IRC
3552020-03-25T16:32:10 *** shesek has joined #bitcoin-core-dev
3562020-03-25T16:33:34 * luke-jr gives up on Windows Update nonsense. How do people even use Windows? smh
3572020-03-25T16:34:09 <vasild> luke-jr: ^ maybe sneak a removal of "if (addr)" into #15600, or maybe not. It is definitely out of scope.
3582020-03-25T16:34:11 <gribble> https://github.com/bitcoin/bitcoin/issues/15600 | lockedpool: When possible, use madvise to avoid including sensitive information in core dumps by luke-jr · Pull Request #15600 · bitcoin/bitcoin · GitHub
3592020-03-25T16:36:59 *** shesek has quit IRC
3602020-03-25T16:38:40 *** promag has joined #bitcoin-core-dev
3612020-03-25T16:40:01 *** shesek has joined #bitcoin-core-dev
3622020-03-25T16:40:03 *** andrewtoth has quit IRC
3632020-03-25T16:42:20 *** DeanGuss has joined #bitcoin-core-dev
3642020-03-25T16:42:54 *** promag has quit IRC
3652020-03-25T16:44:43 *** shesek has quit IRC
3662020-03-25T16:46:25 *** michaelfolkson has joined #bitcoin-core-dev
3672020-03-25T16:46:27 *** mael-rolland[m] has quit IRC
3682020-03-25T16:46:58 *** mrostecki has quit IRC
3692020-03-25T16:47:08 *** shesek has joined #bitcoin-core-dev
3702020-03-25T16:48:53 *** mael-rolland[m] has joined #bitcoin-core-dev
3712020-03-25T16:51:58 *** shesek has quit IRC
3722020-03-25T16:52:23 <phantomcircuit> luke-jr, windows update is akamai who seem to be randomly on fire from huge demand at the moment
3732020-03-25T16:53:36 *** andrewtoth has joined #bitcoin-core-dev
3742020-03-25T16:55:03 <fjahr> wumpus: that looks like the same issue that I saw here https://github.com/bitcoin-core/bitcoin-maintainer-tools/pull/54 I think while there could be something wrong on travis side, Github should definitely not hide the check either way. I will report it to Github as a bug.
3752020-03-25T16:55:16 *** MrSquanchee has joined #bitcoin-core-dev
3762020-03-25T16:55:43 *** shesek has joined #bitcoin-core-dev
3772020-03-25T16:57:20 *** michaelfolkson has quit IRC
3782020-03-25T16:58:13 *** mrostecki has joined #bitcoin-core-dev
3792020-03-25T16:58:27 *** r251d has joined #bitcoin-core-dev
3802020-03-25T16:58:50 *** Chris_Stewart_5 has quit IRC
3812020-03-25T16:59:49 <luke-jr> phantomcircuit: the download works fine, it just errors installing
3822020-03-25T17:00:01 <wumpus> vasild: huh, good catch, "On error, the value MAP_FAILED (that is, (void *) -1)". Seems out of scope for this issue but might still make sense to open a PR for it.
3832020-03-25T17:00:11 *** shesek has quit IRC
3842020-03-25T17:00:54 <vasild> yes, I was thinking the same
3852020-03-25T17:01:02 <wumpus> fjahr: ah yes it might be a github issue too, that they skip calling travis for some reason. i suspected a travis issue because last time travis was 'under maintenance' the same happened.
3862020-03-25T17:01:19 *** michaelfolkson has joined #bitcoin-core-dev
3872020-03-25T17:03:46 <hebasto> wumpus: since 18331 is merged, mind looking into ##18349 ?
3882020-03-25T17:03:48 <gribble> https://github.com/bitcoin/bitcoin/issues/18349 | build: Fix quick hack for version string in releases by hebasto · Pull Request #18349 · bitcoin/bitcoin · GitHub
3892020-03-25T17:06:08 *** Kiminuo has joined #bitcoin-core-dev
3902020-03-25T17:06:27 *** shesek has joined #bitcoin-core-dev
3912020-03-25T17:07:21 *** timothy has quit IRC
3922020-03-25T17:11:18 *** shesek has quit IRC
3932020-03-25T17:13:46 *** shesek has joined #bitcoin-core-dev
3942020-03-25T17:14:30 <wumpus> hebasto: sure will take a look
3952020-03-25T17:15:58 *** felixfoertsch23 has quit IRC
3962020-03-25T17:16:22 *** felixfoertsch has joined #bitcoin-core-dev
3972020-03-25T17:16:34 *** timothy has joined #bitcoin-core-dev
3982020-03-25T17:18:25 <hebasto> wumpus: ty
3992020-03-25T17:18:33 *** shesek has quit IRC
4002020-03-25T17:18:43 *** Chris_Stewart_5 has joined #bitcoin-core-dev
4012020-03-25T17:20:44 *** shesek has joined #bitcoin-core-dev
4022020-03-25T17:25:19 *** shesek has quit IRC
4032020-03-25T17:26:00 *** AaronvanW has quit IRC
4042020-03-25T17:28:25 *** DeanGuss has quit IRC
4052020-03-25T17:30:27 *** DeanGuss has joined #bitcoin-core-dev
4062020-03-25T17:31:27 *** shesek has joined #bitcoin-core-dev
4072020-03-25T17:33:58 *** gloria56 has joined #bitcoin-core-dev
4082020-03-25T17:35:57 *** shesek has quit IRC
4092020-03-25T17:38:14 *** shesek has joined #bitcoin-core-dev
4102020-03-25T17:38:14 *** bitcoin-git has joined #bitcoin-core-dev
4112020-03-25T17:38:14 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/60a39a96fc04...7c942250264e
4122020-03-25T17:38:15 <bitcoin-git> bitcoin/master fae1e99 MarcoFalke: ci: Only clone bitcoin-core/qa-assets when fuzzing
4132020-03-25T17:38:15 <bitcoin-git> bitcoin/master 7c94225 MarcoFalke: Merge #18430: ci: Only clone bitcoin-core/qa-assets when fuzzing
4142020-03-25T17:38:17 *** bitcoin-git has left #bitcoin-core-dev
4152020-03-25T17:38:32 *** bitcoin-git has joined #bitcoin-core-dev
4162020-03-25T17:38:32 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18430: ci: Only clone bitcoin-core/qa-assets when fuzzing (master...2003-ciFuzzClone) https://github.com/bitcoin/bitcoin/pull/18430
4172020-03-25T17:38:34 *** bitcoin-git has left #bitcoin-core-dev
4182020-03-25T17:42:43 *** shesek has quit IRC
4192020-03-25T17:45:04 *** shesek has joined #bitcoin-core-dev
4202020-03-25T17:49:58 *** shesek has quit IRC
4212020-03-25T17:54:22 *** shesek has joined #bitcoin-core-dev
4222020-03-25T17:59:09 *** shesek has quit IRC
4232020-03-25T18:00:02 *** Snowstormer has quit IRC
4242020-03-25T18:00:30 *** gloria56 has quit IRC
4252020-03-25T18:01:24 *** r251d has quit IRC
4262020-03-25T18:01:42 *** promag has joined #bitcoin-core-dev
4272020-03-25T18:02:45 *** shesek has joined #bitcoin-core-dev
4282020-03-25T18:05:46 *** promag has quit IRC
4292020-03-25T18:05:56 *** AaronvanW has joined #bitcoin-core-dev
4302020-03-25T18:06:20 *** ^Gise^ has joined #bitcoin-core-dev
4312020-03-25T18:06:29 *** ^Gise^ has left #bitcoin-core-dev
4322020-03-25T18:07:22 *** shesek has quit IRC
4332020-03-25T18:09:43 *** shesek has joined #bitcoin-core-dev
4342020-03-25T18:10:14 *** AaronvanW has quit IRC
4352020-03-25T18:13:15 <fjahr> wumpus: yes, but even if there is an issue on travis' side then at least Github should warn that one of the checks didn't run in my opinion. I had to send them an email. Seems like they can't think of a better way to track issues %)
4362020-03-25T18:13:29 *** timothy has quit IRC
4372020-03-25T18:14:37 *** shesek has quit IRC
4382020-03-25T18:16:14 *** as_pnn has quit IRC
4392020-03-25T18:16:39 *** shesek has joined #bitcoin-core-dev
4402020-03-25T18:19:31 *** as_pnn has joined #bitcoin-core-dev
4412020-03-25T18:21:23 *** shesek has quit IRC
4422020-03-25T18:22:01 *** them_ has joined #bitcoin-core-dev
4432020-03-25T18:23:24 *** shesek has joined #bitcoin-core-dev
4442020-03-25T18:24:28 <wumpus> hehe
4452020-03-25T18:28:03 *** molly has joined #bitcoin-core-dev
4462020-03-25T18:28:09 *** shesek has quit IRC
4472020-03-25T18:28:14 *** Guyver2_ has joined #bitcoin-core-dev
4482020-03-25T18:30:59 *** mol has quit IRC
4492020-03-25T18:31:08 *** Guyver2 has quit IRC
4502020-03-25T18:31:18 *** Guyver2_ is now known as Guyver2
4512020-03-25T18:33:39 *** promag has joined #bitcoin-core-dev
4522020-03-25T18:34:03 *** shesek has joined #bitcoin-core-dev
4532020-03-25T18:37:03 *** michaelfolkson has quit IRC
4542020-03-25T18:38:20 *** promag has quit IRC
4552020-03-25T18:38:47 *** shesek has quit IRC
4562020-03-25T18:40:15 *** AaronvanW has joined #bitcoin-core-dev
4572020-03-25T18:40:37 *** molly has quit IRC
4582020-03-25T18:42:48 *** shesek has joined #bitcoin-core-dev
4592020-03-25T18:44:35 *** mol has joined #bitcoin-core-dev
4602020-03-25T18:47:29 *** shesek has quit IRC
4612020-03-25T18:49:48 *** shesek has joined #bitcoin-core-dev
4622020-03-25T18:51:48 *** michaelfolkson has joined #bitcoin-core-dev
4632020-03-25T18:58:30 *** Dean_Guss has joined #bitcoin-core-dev
4642020-03-25T19:01:18 *** DeanWeen has joined #bitcoin-core-dev
4652020-03-25T19:01:43 *** DeanGuss has quit IRC
4662020-03-25T19:02:17 *** promag has joined #bitcoin-core-dev
4672020-03-25T19:04:43 *** Dean_Guss has quit IRC
4682020-03-25T19:12:22 *** bitcoin-git has joined #bitcoin-core-dev
4692020-03-25T19:12:23 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7c942250264e...2e97d8001705
4702020-03-25T19:12:23 <bitcoin-git> bitcoin/master d056df0 Ben Woosley: Replace std::to_string with locale-independent alternative
4712020-03-25T19:12:24 <bitcoin-git> bitcoin/master 2e97d80 Wladimir J. van der Laan: Merge #18134: Replace std::to_string with locale-independent alternative
4722020-03-25T19:12:25 *** bitcoin-git has left #bitcoin-core-dev
4732020-03-25T19:12:42 *** bitcoin-git has joined #bitcoin-core-dev
4742020-03-25T19:12:43 <bitcoin-git> [bitcoin] laanwj merged pull request #18134: Replace std::to_string with locale-independent alternative (master...2020-02-to-string) https://github.com/bitcoin/bitcoin/pull/18134
4752020-03-25T19:12:44 *** bitcoin-git has left #bitcoin-core-dev
4762020-03-25T19:15:28 *** Krellan_ has joined #bitcoin-core-dev
4772020-03-25T19:16:24 *** Dean_Guss has joined #bitcoin-core-dev
4782020-03-25T19:18:26 *** promag has quit IRC
4792020-03-25T19:19:27 *** DeanGuss has joined #bitcoin-core-dev
4802020-03-25T19:19:41 *** timothy has joined #bitcoin-core-dev
4812020-03-25T19:19:43 *** DeanWeen has quit IRC
4822020-03-25T19:19:54 *** MrSquanchee has quit IRC
4832020-03-25T19:22:23 *** Dean_Guss has quit IRC
4842020-03-25T19:28:01 *** Talkless has quit IRC
4852020-03-25T19:36:47 *** pingwindyktator has quit IRC
4862020-03-25T19:37:14 *** pingwindyktator has joined #bitcoin-core-dev
4872020-03-25T19:40:51 *** vasild_ has joined #bitcoin-core-dev
4882020-03-25T19:44:03 *** vasild has quit IRC
4892020-03-25T19:44:04 *** vasild_ is now known as vasild
4902020-03-25T19:47:23 *** promag has joined #bitcoin-core-dev
4912020-03-25T19:48:49 *** luke-jr has quit IRC
4922020-03-25T19:50:43 *** roconnor has quit IRC
4932020-03-25T19:51:42 *** promag has quit IRC
4942020-03-25T19:52:21 *** luke-jr has joined #bitcoin-core-dev
4952020-03-25T19:53:42 <vasild> luke-jr: jonatack: wumpus: Do you think that #15600 may create too crippled core files and thus impede debugging? In gdb, inspecting a core file and trying to read the value of a pointer that points to a removed page I get "Cannot access memory at address 0x803200000" which looks like a bogus/dangling pointer.
4962020-03-25T19:53:44 <gribble> https://github.com/bitcoin/bitcoin/issues/15600 | lockedpool: When possible, use madvise to avoid including sensitive information in core dumps by luke-jr · Pull Request #15600 · bitcoin/bitcoin · GitHub
4972020-03-25T19:55:10 <vasild> I do not want to bloat the PR with this, but maybe surround the madvise(DONTDUMP) call with "#ifdef DEBUG"?
4982020-03-25T19:55:47 <vasild> I mean #ifndef
4992020-03-25T19:57:32 *** DeanGuss has quit IRC
5002020-03-25T19:59:10 <jonatack> vasild: interesting review, good catch! am trying to reproduce your tests with the steps you gave
5012020-03-25T19:59:16 <vasild> I am ok with the patch as it is. Just got this thought which you may want to consider.
5022020-03-25T19:59:56 <vasild> jonatack: abort() is king! :)
5032020-03-25T20:00:32 <jonatack> :)
5042020-03-25T20:01:56 <sipa> vasild: due to our secure allocator, the only thing actually stored in the protected pages is private keys
5052020-03-25T20:02:15 <sipa> so i think the degree to which it would hurt debugging is probably very limited?
5062020-03-25T20:05:44 <vasild> sipa: this is why I only mention it here instead of "bloating the PR". Btw, at least some random bytes are also allocated with the secure_allocator, see https://bpaste.net/RWOQ
5072020-03-25T20:06:00 <luke-jr> vasild: that's what it's supposed to do..
5082020-03-25T20:06:25 <sipa> right, the RNG state, of course
5092020-03-25T20:06:40 <sipa> my point is mainly that it's just *data* that's stored there
5102020-03-25T20:06:52 <sipa> not for example allocation tables
5112020-03-25T20:07:06 <sipa> or complex data structures
5122020-03-25T20:07:21 <luke-jr> I don't know any way to execute anything in a coredump-loaded gdb, but if there is, you could also fix it by mmaping something
5132020-03-25T20:07:37 <luke-jr> (IIRC, mmap lets you choose a location)
5142020-03-25T20:07:52 <sipa> luke-jr: i don't follow
5152020-03-25T20:08:12 *** promag has joined #bitcoin-core-dev
5162020-03-25T20:08:20 <luke-jr> sipa: if you're worried that you may get a SEGV running some funcitons to debug with, you can simply first mmap a blank file to the DONTDUMP pages
5172020-03-25T20:08:42 <vasild> ok, so leave the PR as is
5182020-03-25T20:09:02 <sipa> luke-jr: i don't think you can execute anything in a core-dump inspection; just observe
5192020-03-25T20:09:15 <sipa> and non-dumped data you cannot observe
5202020-03-25T20:09:29 <luke-jr> sipa: right, I don't know a way how either; but in that scenario, you can't get a SEGV either
5212020-03-25T20:09:51 <luke-jr> being unable to observe non-dumped data, is the point of the PR
5222020-03-25T20:10:37 <sipa> it may be undesirable in debug settings, which is certainly true
5232020-03-25T20:12:14 *** promag has quit IRC
5242020-03-25T20:19:28 *** Krellan_ has quit IRC
5252020-03-25T20:27:55 *** captjakk has joined #bitcoin-core-dev
5262020-03-25T20:30:39 *** Krellan_ has joined #bitcoin-core-dev
5272020-03-25T20:37:32 <wumpus> vasild: I think that's an acceptable risk personally, we have to err on the side of security/privacy in general
5282020-03-25T20:38:07 <wumpus> I think people rarely use core files for debugging, but if they do, if that means gdb gives a few more warnings I think that's acceptable
5292020-03-25T20:38:40 <wumpus> yes, as sipa already says, it only applies to private key data and some very limited things
5302020-03-25T20:38:56 <vasild> +1
5312020-03-25T20:39:11 <jonatack> reproduced vasild's findings
5322020-03-25T20:39:45 *** DeanGuss has joined #bitcoin-core-dev
5332020-03-25T20:40:02 <jonatack> describing with a comment in the PR
5342020-03-25T20:41:12 <vasild> So it works! \o/
5352020-03-25T20:41:35 <jonatack> yes! good stuff
5362020-03-25T20:42:42 *** Krellan_ has quit IRC
5372020-03-25T20:46:14 *** niska has quit IRC
5382020-03-25T20:46:32 *** niska has joined #bitcoin-core-dev
5392020-03-25T20:49:06 *** masterdonx2 has joined #bitcoin-core-dev
5402020-03-25T20:49:47 *** MasterdonX has quit IRC
5412020-03-25T20:56:43 *** andrewtoth_ has joined #bitcoin-core-dev
5422020-03-25T20:58:03 *** andrewtoth has quit IRC
5432020-03-25T21:00:02 *** them_ has quit IRC
5442020-03-25T21:01:48 *** BamBaRay36 has joined #bitcoin-core-dev
5452020-03-25T21:14:22 *** captjakk has quit IRC
5462020-03-25T21:19:17 *** promag has joined #bitcoin-core-dev
5472020-03-25T21:21:09 *** kutio has joined #bitcoin-core-dev
5482020-03-25T21:25:39 *** promag has quit IRC
5492020-03-25T21:35:58 *** captjakk has joined #bitcoin-core-dev
5502020-03-25T21:38:43 *** DeanGuss has quit IRC
5512020-03-25T21:39:36 *** manantial has quit IRC
5522020-03-25T21:40:07 *** kristapsk has joined #bitcoin-core-dev
5532020-03-25T21:52:18 *** jb55 has quit IRC
5542020-03-25T22:10:41 *** mdunnio has quit IRC
5552020-03-25T22:10:51 <fjahr> Is there a github access token available in travis and if yes, what is the variable name? I would need it to prevent running into rate limiting with #18399
5562020-03-25T22:10:52 <gribble> https://github.com/bitcoin/bitcoin/issues/18399 | lint: PR description linter by fjahr · Pull Request #18399 · bitcoin/bitcoin · GitHub
5572020-03-25T22:11:38 *** mdunnio has joined #bitcoin-core-dev
5582020-03-25T22:16:27 *** mdunnio has quit IRC
5592020-03-25T22:20:58 *** JeromeLegoupil has joined #bitcoin-core-dev
5602020-03-25T22:22:57 *** jonatack has quit IRC
5612020-03-25T22:26:26 *** shigeya has quit IRC
5622020-03-25T22:27:16 *** fengling has quit IRC
5632020-03-25T22:29:05 *** shigeya has joined #bitcoin-core-dev
5642020-03-25T22:29:25 *** fengling has joined #bitcoin-core-dev
5652020-03-25T22:30:35 *** JeromeLegoupil has quit IRC
5662020-03-25T22:31:41 *** jonatack has joined #bitcoin-core-dev
5672020-03-25T22:39:29 *** Krellan_ has joined #bitcoin-core-dev
5682020-03-25T22:42:40 *** Guyver2 has quit IRC
5692020-03-25T22:43:54 *** Krellan_ has quit IRC
5702020-03-25T22:51:04 *** mdunnio has joined #bitcoin-core-dev
5712020-03-25T22:55:34 *** mdunnio has quit IRC
5722020-03-25T22:58:14 *** AaronvanW has quit IRC
5732020-03-25T23:00:00 *** apaval has quit IRC
5742020-03-25T23:00:19 *** apaval has joined #bitcoin-core-dev
5752020-03-25T23:02:03 *** emilengler has quit IRC
5762020-03-25T23:02:17 *** emilengler has joined #bitcoin-core-dev
5772020-03-25T23:16:14 *** bitcoin-git has joined #bitcoin-core-dev
5782020-03-25T23:16:14 <bitcoin-git> [bitcoin] practicalswift opened pull request #18432: util: Make current implicit C++ locale assumption in tfm::format(...) explicit (master...cpp-locale) https://github.com/bitcoin/bitcoin/pull/18432
5792020-03-25T23:16:16 *** bitcoin-git has left #bitcoin-core-dev
5802020-03-25T23:21:01 *** justanotheruser has quit IRC
5812020-03-25T23:29:15 *** Chris_Stewart_5 has quit IRC
5822020-03-25T23:30:18 *** mdunnio has joined #bitcoin-core-dev
5832020-03-25T23:34:34 *** mdunnio has quit IRC
5842020-03-25T23:45:17 *** marcoagner has quit IRC
5852020-03-25T23:51:26 *** gleb has quit IRC
5862020-03-25T23:51:53 *** gleb has joined #bitcoin-core-dev
5872020-03-25T23:56:14 *** gleb has quit IRC
5882020-03-25T23:56:52 *** justanotheruser has joined #bitcoin-core-dev
5892020-03-25T23:57:50 *** gleb has joined #bitcoin-core-dev