1 2020-03-31T00:00:02  *** vBm1 has quit IRC
  2 2020-03-31T00:06:09  *** bitcoin-git has joined #bitcoin-core-dev
  3 2020-03-31T00:06:09  <bitcoin-git> [bitcoin] dongcarl opened pull request #18478: build: Automatically include both `git`-tracked and bootstrapped files. (master...2020-03-adventures-in-reconciling-automake-and-git) https://github.com/bitcoin/bitcoin/pull/18478
  4 2020-03-31T00:06:10  *** bitcoin-git has left #bitcoin-core-dev
  5 2020-03-31T00:14:06  *** justanotheruser has quit IRC
  6 2020-03-31T00:20:20  *** gnomus has joined #bitcoin-core-dev
  7 2020-03-31T00:25:20  *** bitcoin-git has joined #bitcoin-core-dev
  8 2020-03-31T00:25:20  <bitcoin-git> [bitcoin] amitiuttarwar closed pull request #16698: Mempool: rework rebroadcast logic to improve privacy (master...rebroadcast) https://github.com/bitcoin/bitcoin/pull/16698
  9 2020-03-31T00:25:21  *** bitcoin-git has left #bitcoin-core-dev
 10 2020-03-31T00:30:19  *** Krellan_ has joined #bitcoin-core-dev
 11 2020-03-31T00:31:26  *** ddustin has joined #bitcoin-core-dev
 12 2020-03-31T00:32:36  *** theStack has quit IRC
 13 2020-03-31T00:33:14  *** mdunnio has joined #bitcoin-core-dev
 14 2020-03-31T00:34:26  *** Krellan_ has quit IRC
 15 2020-03-31T00:36:21  *** promag has quit IRC
 16 2020-03-31T00:36:30  *** timothy has quit IRC
 17 2020-03-31T00:41:12  *** mkcisse has quit IRC
 18 2020-03-31T00:43:44  *** thango has joined #bitcoin-core-dev
 19 2020-03-31T00:52:28  *** shesek has joined #bitcoin-core-dev
 20 2020-03-31T00:52:28  *** shesek has quit IRC
 21 2020-03-31T00:52:28  *** shesek has joined #bitcoin-core-dev
 22 2020-03-31T00:57:14  *** IGHOR has quit IRC
 23 2020-03-31T01:00:56  <ryanofsky> gwillen: where is the option on github commit pages to "create a branch from it"?
 24 2020-03-31T01:02:07  <ryanofsky> the only way i've found to download orphan commits on github not on a known tag or branch is to use web api and reconstruct tree and commit objects locally
 25 2020-03-31T01:03:06  *** Chris_Stewart_5 has quit IRC
 26 2020-03-31T01:08:13  *** captjakk has quit IRC
 27 2020-03-31T01:08:45  *** captjakk has joined #bitcoin-core-dev
 28 2020-03-31T01:10:52  *** IGHOR has joined #bitcoin-core-dev
 29 2020-03-31T01:12:15  *** PaulTroon has joined #bitcoin-core-dev
 30 2020-03-31T01:14:56  *** go11111111111 has joined #bitcoin-core-dev
 31 2020-03-31T01:17:02  *** spinza has quit IRC
 32 2020-03-31T01:17:16  *** PaulTroon has quit IRC
 33 2020-03-31T01:17:25  *** captjakk has quit IRC
 34 2020-03-31T01:17:30  *** go121212 has quit IRC
 35 2020-03-31T01:21:39  *** ddustin has quit IRC
 36 2020-03-31T01:22:19  *** ddustin has joined #bitcoin-core-dev
 37 2020-03-31T01:23:47  *** ddustin_ has joined #bitcoin-core-dev
 38 2020-03-31T01:27:06  *** ddustin has quit IRC
 39 2020-03-31T01:28:06  *** ddustin_ has quit IRC
 40 2020-03-31T01:30:34  *** justanotheruser has joined #bitcoin-core-dev
 41 2020-03-31T01:31:42  *** jb55 has joined #bitcoin-core-dev
 42 2020-03-31T01:31:53  *** AaronvanW has joined #bitcoin-core-dev
 43 2020-03-31T01:38:55  *** captjakk has joined #bitcoin-core-dev
 44 2020-03-31T01:52:30  <gwillen> ryanofsky: yeah it's slightly tricky, I'm not sure whether or how you can easily reach it directly from the GUI
 45 2020-03-31T01:52:47  <gwillen> but e.g. https://github.com/bitcoin/bitcoin/commit/208b9f00140e0243707e98e1f58a0fcd07f427ce is a commit that's been force-pushed over on a PR, and this is the page that you get to if you click the commit ID
 46 2020-03-31T01:53:09  <gwillen> then if you change the "commit" in the URL to "commits", you get a different view, like, the branch view from that tip
 47 2020-03-31T01:53:34  <gwillen> then if you click "Tree: NNNNNNN" you should be able to commit a branch, if you have that permission on the repo you're looking at
 48 2020-03-31T01:53:39  <gwillen> er, create* a branch
 49 2020-03-31T01:56:19  *** ddustin has joined #bitcoin-core-dev
 50 2020-03-31T02:00:50  *** go121212 has joined #bitcoin-core-dev
 51 2020-03-31T02:02:45  *** ddustin has quit IRC
 52 2020-03-31T02:03:50  *** go11111111111 has quit IRC
 53 2020-03-31T02:05:40  *** AaronvanW has quit IRC
 54 2020-03-31T02:08:14  *** IGHOR has quit IRC
 55 2020-03-31T02:08:46  *** dviola has quit IRC
 56 2020-03-31T02:09:32  *** IGHOR has joined #bitcoin-core-dev
 57 2020-03-31T02:10:54  *** jtimon has quit IRC
 58 2020-03-31T02:24:11  *** ddustin has joined #bitcoin-core-dev
 59 2020-03-31T02:29:11  *** ddustin has quit IRC
 60 2020-03-31T02:30:58  *** mdunnio has quit IRC
 61 2020-03-31T02:31:12  *** Krellan_ has joined #bitcoin-core-dev
 62 2020-03-31T02:37:11  *** ddustin has joined #bitcoin-core-dev
 63 2020-03-31T02:39:03  *** Krellan_ has quit IRC
 64 2020-03-31T02:42:19  *** ddustin has quit IRC
 65 2020-03-31T02:46:08  *** Krellan_ has joined #bitcoin-core-dev
 66 2020-03-31T02:46:14  *** adiabat has joined #bitcoin-core-dev
 67 2020-03-31T02:46:49  <kallewoof> I can't restart travis jobs for some reason.
 68 2020-03-31T02:48:26  <sipa> kallewoof: try logging out and back in
 69 2020-03-31T02:51:04  <kallewoof> sipa: that fixed it. thanks!
 70 2020-03-31T02:51:33  <sipa> i've experienced it as well since a few days
 71 2020-03-31T02:51:37  <sipa> i don't know what causes it
 72 2020-03-31T02:55:45  *** thango has quit IRC
 73 2020-03-31T02:57:42  <fanquake> sipa: can you block Domel1985
 74 2020-03-31T02:57:50  <sipa> again?
 75 2020-03-31T02:58:00  <fanquake> In the bitcoin/bitcoin repo now
 76 2020-03-31T02:58:01  <sipa> ah, from different repo
 77 2020-03-31T02:58:23  <sipa> Done.
 78 2020-03-31T03:00:02  *** gnomus has quit IRC
 79 2020-03-31T03:07:14  *** mdunnio has joined #bitcoin-core-dev
 80 2020-03-31T03:08:35  *** ddustin has joined #bitcoin-core-dev
 81 2020-03-31T03:08:53  *** mdunnio has quit IRC
 82 2020-03-31T03:09:39  *** mdunnio has joined #bitcoin-core-dev
 83 2020-03-31T03:12:46  *** ddustin has quit IRC
 84 2020-03-31T03:13:40  *** PaulTroon has joined #bitcoin-core-dev
 85 2020-03-31T03:14:08  *** ddustin has joined #bitcoin-core-dev
 86 2020-03-31T03:14:15  *** mdunnio has quit IRC
 87 2020-03-31T03:17:54  *** PaulTroon has quit IRC
 88 2020-03-31T03:18:30  *** santa_1 has joined #bitcoin-core-dev
 89 2020-03-31T03:18:39  *** ddustin has quit IRC
 90 2020-03-31T03:32:55  *** achow101 has quit IRC
 91 2020-03-31T03:33:27  *** achow101 has joined #bitcoin-core-dev
 92 2020-03-31T03:42:58  *** mdunnio has joined #bitcoin-core-dev
 93 2020-03-31T03:45:39  *** captjakk has quit IRC
 94 2020-03-31T03:47:35  *** mdunnio has quit IRC
 95 2020-03-31T03:50:05  *** Krellan_ has quit IRC
 96 2020-03-31T03:50:10  *** bitcoin-git has joined #bitcoin-core-dev
 97 2020-03-31T03:50:10  <bitcoin-git> [bitcoin] luke-jr opened pull request #18479: RPC: Show fee in results for signrawtransaction* for segwit inputs (master...rpc_sign_show_fees) https://github.com/bitcoin/bitcoin/pull/18479
 98 2020-03-31T03:50:11  *** bitcoin-git has left #bitcoin-core-dev
 99 2020-03-31T03:51:42  *** molz_ has joined #bitcoin-core-dev
100 2020-03-31T03:54:49  *** molly has quit IRC
101 2020-03-31T03:59:31  *** molz_ has quit IRC
102 2020-03-31T04:01:16  *** ddustin has joined #bitcoin-core-dev
103 2020-03-31T04:02:43  *** AaronvanW has joined #bitcoin-core-dev
104 2020-03-31T04:08:09  *** ddustin has quit IRC
105 2020-03-31T04:13:58  *** ddustin has joined #bitcoin-core-dev
106 2020-03-31T04:18:23  *** ddustin has quit IRC
107 2020-03-31T04:29:32  *** ddustin has joined #bitcoin-core-dev
108 2020-03-31T04:35:06  *** ddustin has quit IRC
109 2020-03-31T04:35:27  *** AaronvanW has quit IRC
110 2020-03-31T04:57:59  *** ddustin has joined #bitcoin-core-dev
111 2020-03-31T05:07:51  *** spinza has joined #bitcoin-core-dev
112 2020-03-31T05:14:21  *** santa_1 has quit IRC
113 2020-03-31T05:14:33  *** PaulTroon has joined #bitcoin-core-dev
114 2020-03-31T05:19:19  *** PaulTroon has quit IRC
115 2020-03-31T05:25:31  *** Suntop1 has joined #bitcoin-core-dev
116 2020-03-31T05:32:56  *** Suntop1 has quit IRC
117 2020-03-31T05:36:48  *** xavierfabric has joined #bitcoin-core-dev
118 2020-03-31T05:40:42  *** xavier_fabric has joined #bitcoin-core-dev
119 2020-03-31T05:43:07  *** Kiminuo has quit IRC
120 2020-03-31T05:43:54  *** xavier_fabric has quit IRC
121 2020-03-31T05:44:08  *** xavier_fabric has joined #bitcoin-core-dev
122 2020-03-31T05:47:05  *** xavier_fabric has quit IRC
123 2020-03-31T05:51:01  *** Kiminuo has joined #bitcoin-core-dev
124 2020-03-31T05:55:16  *** rhauch has joined #bitcoin-core-dev
125 2020-03-31T06:00:02  *** rhauch has quit IRC
126 2020-03-31T06:01:51  *** mol has joined #bitcoin-core-dev
127 2020-03-31T06:22:12  *** flukiluke1 has joined #bitcoin-core-dev
128 2020-03-31T06:30:23  *** sipa has quit IRC
129 2020-03-31T06:30:39  *** sipa has joined #bitcoin-core-dev
130 2020-03-31T06:32:24  *** AaronvanW has joined #bitcoin-core-dev
131 2020-03-31T06:33:24  *** provoostenator has quit IRC
132 2020-03-31T06:34:36  *** provoostenator has joined #bitcoin-core-dev
133 2020-03-31T06:34:49  *** ddustin has quit IRC
134 2020-03-31T06:36:19  *** Talkless has joined #bitcoin-core-dev
135 2020-03-31T06:45:19  *** ddustin has joined #bitcoin-core-dev
136 2020-03-31T06:52:16  *** filchef has joined #bitcoin-core-dev
137 2020-03-31T06:52:26  *** ddustin has quit IRC
138 2020-03-31T07:01:14  *** PaulTroon has joined #bitcoin-core-dev
139 2020-03-31T07:02:55  <wumpus> vasild: yup tarballs work fine for 'orphaned' commits, downloading patches/diffs also works, but never found a trick to be able to do it with git itself
140 2020-03-31T07:06:58  *** lucaferr has joined #bitcoin-core-dev
141 2020-03-31T07:10:10  *** lucaferr has quit IRC
142 2020-03-31T07:12:52  *** Krellan_ has joined #bitcoin-core-dev
143 2020-03-31T07:21:46  *** Krellan_ has quit IRC
144 2020-03-31T07:22:35  <wumpus> (or alternatively, to download a tarball w/ .git directory, or say, a git bundle for a commit range)
145 2020-03-31T07:22:48  <vasild> https://stackoverflow.com/questions/28958327/does-github-remember-commit-ids/28958418#28958418 is relevant. It's like gwillen's way, but using the github api. Requires write permissions though, to create a new branch from the orphaned commit.
146 2020-03-31T07:22:49  <gribble> https://github.com/bitcoin/bitcoin/issues/28958418 | HTTP Error 404: Not Found
147 2020-03-31T07:24:30  <vasild> I have already forked the repo in my github account, so I cannot fork it a second time to check whether the orphaned commits will be copied into my fork (where I would have write permissions)
148 2020-03-31T07:24:30  *** lucaferr has joined #bitcoin-core-dev
149 2020-03-31T07:25:08  <wumpus> oh interesting! that's at least something, though, I'd most frequently wanted it for other people's commits and don't tend to have write access to them
150 2020-03-31T07:25:42  <lucaferr> How does peer protocol command "notfound" behave when a "getdata" request only partially matches. Will it return a partial result plus "notfound", or will it only return "notfound"?
151 2020-03-31T07:25:43  <wumpus> haaaah fork their repository first, of course
152 2020-03-31T07:26:41  <wumpus> lucaferr: it either returns a (partial) result or "notfound" never both IIRC
153 2020-03-31T07:26:56  <lucaferr> wumpus: great, thank you
154 2020-03-31T07:41:02  *** vasild_ has joined #bitcoin-core-dev
155 2020-03-31T07:43:26  <vasild_> wumpus: but when I go to https://github.com/practicalswift/bitcoin and try to "Fork" it into my account I am redirected to vasild/bitcoin (nothing gets forked)
156 2020-03-31T07:44:03  *** vasild has quit IRC
157 2020-03-31T07:44:04  *** vasild_ is now known as vasild
158 2020-03-31T07:51:25  *** manantial has joined #bitcoin-core-dev
159 2020-03-31T07:58:39  *** provoostenator has quit IRC
160 2020-03-31T07:59:55  *** provoostenator has joined #bitcoin-core-dev
161 2020-03-31T08:00:25  *** votesmith has quit IRC
162 2020-03-31T08:01:04  *** marcoagner has joined #bitcoin-core-dev
163 2020-03-31T08:02:47  *** AaronvanW has quit IRC
164 2020-03-31T08:12:45  <jonasschnelli> Can we consider #18160 a bugfix? I'd like to get that into 0.20?
165 2020-03-31T08:12:47  <gribble> https://github.com/bitcoin/bitcoin/issues/18160 | gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged by promag · Pull Request #18160 · bitcoin/bitcoin · GitHub
166 2020-03-31T08:13:46  <sipa> lucaferr: it wul
167 2020-03-31T08:14:01  <sipa> lucaferr: it will respond with tx/blocks for the found things, and a notfound for the rest
168 2020-03-31T08:15:11  <lucaferr> sipa: ah, ok. So the arity will match between the requested inventory vectors and the notfound inventory plus data messages (tx or block)?
169 2020-03-31T08:17:48  *** votesmith has joined #bitcoin-core-dev
170 2020-03-31T08:20:23  *** Guyver2 has joined #bitcoin-core-dev
171 2020-03-31T08:23:22  *** votesmith has quit IRC
172 2020-03-31T08:29:54  *** kljasdfvv has quit IRC
173 2020-03-31T08:31:11  *** kljasdfvv has joined #bitcoin-core-dev
174 2020-03-31T08:41:37  *** promag has joined #bitcoin-core-dev
175 2020-03-31T08:42:45  *** AaronvanW has joined #bitcoin-core-dev
176 2020-03-31T08:49:27  <wumpus> sipa: oh you're right, I was confused with how 'reject' messages used to be handled
177 2020-03-31T08:50:21  *** g0000n has joined #bitcoin-core-dev
178 2020-03-31T09:00:01  *** flukiluke1 has quit IRC
179 2020-03-31T09:02:03  <lucaferr> wumpus, sipa: thanks to both for replying :)
180 2020-03-31T09:13:43  *** braydonf has quit IRC
181 2020-03-31T09:14:16  *** timothy has joined #bitcoin-core-dev
182 2020-03-31T09:14:24  *** braydonf has joined #bitcoin-core-dev
183 2020-03-31T09:17:55  *** timothy has quit IRC
184 2020-03-31T09:18:27  *** Krellan_ has joined #bitcoin-core-dev
185 2020-03-31T09:21:02  *** DarTar has joined #bitcoin-core-dev
186 2020-03-31T09:23:43  *** braydonf has quit IRC
187 2020-03-31T09:23:44  *** bitcoin-git has joined #bitcoin-core-dev
188 2020-03-31T09:23:44  <bitcoin-git> [bitcoin] theStack opened pull request #18481: test: add BIP37 'filterclear' test to p2p_filter.py (master...20200330-test-add-BIP37-filterclear-message) https://github.com/bitcoin/bitcoin/pull/18481
189 2020-03-31T09:23:44  *** bitcoin-git has left #bitcoin-core-dev
190 2020-03-31T09:24:11  *** braydonf has joined #bitcoin-core-dev
191 2020-03-31T09:33:12  *** ddustin has joined #bitcoin-core-dev
192 2020-03-31T09:37:35  *** ddustin has quit IRC
193 2020-03-31T09:40:02  *** Krellan_ has quit IRC
194 2020-03-31T09:40:23  *** braydonf has quit IRC
195 2020-03-31T09:40:59  *** timothy has joined #bitcoin-core-dev
196 2020-03-31T09:43:55  *** braydonf has joined #bitcoin-core-dev
197 2020-03-31T10:00:18  *** Zenton has quit IRC
198 2020-03-31T10:04:02  *** Jed4Koelpin has joined #bitcoin-core-dev
199 2020-03-31T10:10:51  *** jtimon has joined #bitcoin-core-dev
200 2020-03-31T10:10:53  *** Zenton has joined #bitcoin-core-dev
201 2020-03-31T10:14:27  <wumpus> jonasschnelli: yes, I think it's a fix of some kind
202 2020-03-31T10:15:53  <wumpus> jonasschnelli: I was holding it off because of the idea to merge #17905 first, which isn't merged yet, seems too late to merge both now (and do a last-minute rebase of the latter)
203 2020-03-31T10:15:55  <gribble> https://github.com/bitcoin/bitcoin/issues/17905 | gui: Avoid redundant tx status updates by ryanofsky · Pull Request #17905 · bitcoin/bitcoin · GitHub
204 2020-03-31T10:16:10  <wumpus> so I don't know what's best now
205 2020-03-31T10:23:47  <promag> #18338 #18160
206 2020-03-31T10:23:51  <gribble> https://github.com/bitcoin/bitcoin/issues/18338 | Fix wallet unload race condition by promag · Pull Request #18338 · bitcoin/bitcoin · GitHub
207 2020-03-31T10:23:53  <gribble> https://github.com/bitcoin/bitcoin/issues/18160 | gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged by promag · Pull Request #18160 · bitcoin/bitcoin · GitHub
208 2020-03-31T10:23:59  <promag> these should be ready to merge
209 2020-03-31T10:24:11  <wumpus> ok!
210 2020-03-31T10:24:13  <promag> #16923 another fix that could also go
211 2020-03-31T10:24:15  <gribble> https://github.com/bitcoin/bitcoin/issues/16923 | wallet: Handle duplicate fileid exception by promag · Pull Request #16923 · bitcoin/bitcoin · GitHub
212 2020-03-31T10:25:28  <promag> #18160 is easer to backport to 0.19 without 17905
213 2020-03-31T10:25:30  <gribble> https://github.com/bitcoin/bitcoin/issues/18160 | gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged by promag · Pull Request #18160 · bitcoin/bitcoin · GitHub
214 2020-03-31T10:25:31  *** emilengler has joined #bitcoin-core-dev
215 2020-03-31T10:35:09  *** theStack has joined #bitcoin-core-dev
216 2020-03-31T10:36:28  *** emilengler has quit IRC
217 2020-03-31T10:36:42  *** emilengler has joined #bitcoin-core-dev
218 2020-03-31T10:45:28  *** PaulTroon has quit IRC
219 2020-03-31T10:48:45  *** Chris_Stewart_5 has joined #bitcoin-core-dev
220 2020-03-31T10:55:07  *** PaulTroon has joined #bitcoin-core-dev
221 2020-03-31T11:00:02  *** apaval_ has quit IRC
222 2020-03-31T11:00:21  *** apaval_ has joined #bitcoin-core-dev
223 2020-03-31T11:37:22  *** Krellan_ has joined #bitcoin-core-dev
224 2020-03-31T11:44:30  *** ddustin has joined #bitcoin-core-dev
225 2020-03-31T11:46:17  *** theStack has quit IRC
226 2020-03-31T12:00:02  *** DarTar has quit IRC
227 2020-03-31T12:04:26  *** Krellan_ has quit IRC
228 2020-03-31T12:04:34  <wumpus> looking at them now, doesn't help that my main computer's case fan decided to die today
229 2020-03-31T12:08:56  *** Jed4Koelpin has quit IRC
230 2020-03-31T12:11:56  <luke-jr> :|
231 2020-03-31T12:22:00  *** FenderQ1 has joined #bitcoin-core-dev
232 2020-03-31T12:22:22  <wumpus> ordered a new one and it'll probably get here tomorrow, but who knows these days
233 2020-03-31T12:24:06  *** bitcoin-git has joined #bitcoin-core-dev
234 2020-03-31T12:24:06  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/965c0c37d54c...f2880e21eff2
235 2020-03-31T12:24:06  <bitcoin-git> bitcoin/master 0933a37 João Barbosa: gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged
236 2020-03-31T12:24:07  <bitcoin-git> bitcoin/master f2880e2 Wladimir J. van der Laan: Merge #18160: gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceCha...
237 2020-03-31T12:24:08  *** bitcoin-git has left #bitcoin-core-dev
238 2020-03-31T12:24:31  *** bitcoin-git has joined #bitcoin-core-dev
239 2020-03-31T12:24:31  <bitcoin-git> [bitcoin] laanwj merged pull request #18160: gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged (master...2020-02-avoid-getbalance) https://github.com/bitcoin/bitcoin/pull/18160
240 2020-03-31T12:24:32  *** bitcoin-git has left #bitcoin-core-dev
241 2020-03-31T12:25:22  *** braydonf has quit IRC
242 2020-03-31T12:25:40  <luke-jr> even though it's internal to the PC, I'd take precautions to sanitize it somehow
243 2020-03-31T12:25:44  *** braydonf has joined #bitcoin-core-dev
244 2020-03-31T12:27:03  *** vasild has quit IRC
245 2020-03-31T12:28:42  *** Guyver2_ has joined #bitcoin-core-dev
246 2020-03-31T12:29:05  *** vasild has joined #bitcoin-core-dev
247 2020-03-31T12:30:08  *** Guyver2 has quit IRC
248 2020-03-31T12:30:19  *** theStack has joined #bitcoin-core-dev
249 2020-03-31T12:34:20  *** theStack has quit IRC
250 2020-03-31T12:37:44  <wumpus> yeah
251 2020-03-31T12:58:30  *** justanotheruser has quit IRC
252 2020-03-31T13:03:03  *** Highway61 has quit IRC
253 2020-03-31T13:03:16  *** Guyver2_ is now known as Guyver2
254 2020-03-31T13:06:33  *** lucaferr has quit IRC
255 2020-03-31T13:07:38  *** bitcoin-git has joined #bitcoin-core-dev
256 2020-03-31T13:07:40  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f2880e21eff2...9a2b5f22c1f6
257 2020-03-31T13:07:40  <bitcoin-git> bitcoin/master ab31b9d Russell Yanofsky: Fix wallet unload race condition
258 2020-03-31T13:07:41  <bitcoin-git> bitcoin/master 41b0baf João Barbosa: gui: Handle WalletModel::unload asynchronous
259 2020-03-31T13:07:42  <bitcoin-git> bitcoin/master 9a2b5f2 Wladimir J. van der Laan: Merge #18338: Fix wallet unload race condition
260 2020-03-31T13:07:44  *** bitcoin-git has left #bitcoin-core-dev
261 2020-03-31T13:07:58  *** bitcoin-git has joined #bitcoin-core-dev
262 2020-03-31T13:07:58  <bitcoin-git> [bitcoin] laanwj merged pull request #18338: Fix wallet unload race condition (master...notify-shared) https://github.com/bitcoin/bitcoin/pull/18338
263 2020-03-31T13:07:59  *** bitcoin-git has left #bitcoin-core-dev
264 2020-03-31T13:09:27  *** mdunnio has joined #bitcoin-core-dev
265 2020-03-31T13:16:28  *** emilengler has quit IRC
266 2020-03-31T13:16:41  *** emilengler has joined #bitcoin-core-dev
267 2020-03-31T13:20:58  *** emilengler has quit IRC
268 2020-03-31T13:21:12  *** emilengler has joined #bitcoin-core-dev
269 2020-03-31T13:22:49  *** per has quit IRC
270 2020-03-31T13:24:14  *** per has joined #bitcoin-core-dev
271 2020-03-31T13:26:43  *** hebasto has quit IRC
272 2020-03-31T13:29:23  *** per has quit IRC
273 2020-03-31T13:36:58  *** bitcoin-git has joined #bitcoin-core-dev
274 2020-03-31T13:36:58  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9a2b5f22c1f6...d52ba21dfff9
275 2020-03-31T13:36:59  <bitcoin-git> bitcoin/master 0055922 Sebastian Falbesoner: test: add BIP37 'filterclear' test to p2p_filter.py
276 2020-03-31T13:36:59  <bitcoin-git> bitcoin/master d52ba21 MarcoFalke: Merge #18481: test: add BIP37 'filterclear' test to p2p_filter.py
277 2020-03-31T13:37:01  *** bitcoin-git has left #bitcoin-core-dev
278 2020-03-31T13:37:18  *** bitcoin-git has joined #bitcoin-core-dev
279 2020-03-31T13:37:18  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18481: test: add BIP37 'filterclear' test to p2p_filter.py (master...20200330-test-add-BIP37-filterclear-message) https://github.com/bitcoin/bitcoin/pull/18481
280 2020-03-31T13:37:19  *** bitcoin-git has left #bitcoin-core-dev
281 2020-03-31T13:48:44  *** g0000n has quit IRC
282 2020-03-31T14:02:04  *** Krellan_ has joined #bitcoin-core-dev
283 2020-03-31T14:03:37  *** AaronvanW has quit IRC
284 2020-03-31T14:05:50  *** g0000n has joined #bitcoin-core-dev
285 2020-03-31T14:21:46  *** Highway61 has joined #bitcoin-core-dev
286 2020-03-31T14:29:57  *** promag_ has joined #bitcoin-core-dev
287 2020-03-31T14:30:09  *** promag has quit IRC
288 2020-03-31T14:30:32  *** promag_ is now known as promag
289 2020-03-31T14:30:57  *** promag_ has joined #bitcoin-core-dev
290 2020-03-31T14:32:35  *** Krellan_ has quit IRC
291 2020-03-31T14:34:34  *** BamBaRay36 has quit IRC
292 2020-03-31T14:38:47  <emilengler> By the way, is someone working on the switch from C++11 to C++17 right now? Like #17904? Otherwise I would try to pick it up
293 2020-03-31T14:38:50  <gribble> https://github.com/bitcoin/bitcoin/issues/17904 | [wip] build: Switch from C++11 to C++17 by practicalswift · Pull Request #17904 · bitcoin/bitcoin · GitHub
294 2020-03-31T14:39:36  *** Kiminuo has quit IRC
295 2020-03-31T14:39:52  <provoostenator> emilengler: usually we have to wait for ancient distros to support it, luke-jr tends to be up to date on those...
296 2020-03-31T14:40:07  <aj> i thought we were just deferring 'til 0.20 was done?
297 2020-03-31T14:40:31  <emilengler> aj: It has the milestone of 0.21
298 2020-03-31T14:40:34  <aj> #16684 has info about distros
299 2020-03-31T14:40:36  <gribble> https://github.com/bitcoin/bitcoin/issues/16684 | Discussion: upgrading to C++17 · Issue #16684 · bitcoin/bitcoin · GitHub
300 2020-03-31T14:43:41  <emilengler> The only problem was CentOS 7 then but CentOS 8 is already out
301 2020-03-31T15:00:01  *** FenderQ1 has quit IRC
302 2020-03-31T15:01:26  <promag> so how about #16923?
303 2020-03-31T15:01:29  <gribble> https://github.com/bitcoin/bitcoin/issues/16923 | wallet: Handle duplicate fileid exception by promag · Pull Request #16923 · bitcoin/bitcoin · GitHub
304 2020-03-31T15:12:04  *** captjakk has joined #bitcoin-core-dev
305 2020-03-31T15:21:27  *** tomkap1 has joined #bitcoin-core-dev
306 2020-03-31T15:24:34  *** theStack has joined #bitcoin-core-dev
307 2020-03-31T15:26:34  *** Kiminuo has joined #bitcoin-core-dev
308 2020-03-31T15:30:01  *** AaronvanW has joined #bitcoin-core-dev
309 2020-03-31T15:43:58  *** emilengler has quit IRC
310 2020-03-31T15:44:12  *** emilengler has joined #bitcoin-core-dev
311 2020-03-31T16:04:48  <luke-jr> dongcarl: for #16684, note Gentoo is at 9.2.0
312 2020-03-31T16:04:50  <gribble> https://github.com/bitcoin/bitcoin/issues/16684 | Discussion: upgrading to C++17 · Issue #16684 · bitcoin/bitcoin · GitHub
313 2020-03-31T16:13:20  *** guest534543 has joined #bitcoin-core-dev
314 2020-03-31T16:16:00  *** Kiminuo has quit IRC
315 2020-03-31T16:24:44  *** justanotheruser has joined #bitcoin-core-dev
316 2020-03-31T16:25:53  <jonatack> promag: re-acked #16923. lone travis failure (mempool_reorg.py) is unrelated
317 2020-03-31T16:25:55  <gribble> https://github.com/bitcoin/bitcoin/issues/16923 | wallet: Handle duplicate fileid exception by promag · Pull Request #16923 · bitcoin/bitcoin · GitHub
318 2020-03-31T16:27:46  *** PaulTroon has quit IRC
319 2020-03-31T16:29:23  *** andrewtoth has quit IRC
320 2020-03-31T16:29:30  *** Krellan_ has joined #bitcoin-core-dev
321 2020-03-31T16:34:34  *** Randolf has joined #bitcoin-core-dev
322 2020-03-31T16:34:45  *** Randolf is now known as LumberCartel
323 2020-03-31T16:35:11  *** LumberCartel is now known as Randolf
324 2020-03-31T16:38:21  <wumpus> yes maybe with 0.21 we can switch to c++17, I hope so
325 2020-03-31T16:39:43  <wumpus> restarted travis run for 16923
326 2020-03-31T16:39:57  *** seddd has joined #bitcoin-core-dev
327 2020-03-31T16:40:44  *** PaulTroon has joined #bitcoin-core-dev
328 2020-03-31T16:40:49  *** andrewtoth has joined #bitcoin-core-dev
329 2020-03-31T16:46:40  *** seddd has quit IRC
330 2020-03-31T17:02:15  *** ddustin_ has joined #bitcoin-core-dev
331 2020-03-31T17:02:26  *** Krellan_ has quit IRC
332 2020-03-31T17:05:26  *** ddustin has quit IRC
333 2020-03-31T17:34:00  *** mdunnio has quit IRC
334 2020-03-31T17:34:35  *** mdunnio has joined #bitcoin-core-dev
335 2020-03-31T17:38:59  *** mdunnio has quit IRC
336 2020-03-31T17:45:40  *** bitcoin-git has joined #bitcoin-core-dev
337 2020-03-31T17:45:41  <bitcoin-git> [bitcoin] achow101 opened pull request #18484: Correctly compute redeemScript from witnessScript for signrawtransaction (master...signrawtx-p2pkh-p2wsh) https://github.com/bitcoin/bitcoin/pull/18484
338 2020-03-31T17:45:42  *** bitcoin-git has left #bitcoin-core-dev
339 2020-03-31T17:56:45  *** mdunnio has joined #bitcoin-core-dev
340 2020-03-31T18:00:01  *** tomkap1 has quit IRC
341 2020-03-31T18:08:15  *** jarthur has joined #bitcoin-core-dev
342 2020-03-31T18:21:40  *** furkanmustafa has joined #bitcoin-core-dev
343 2020-03-31T18:31:55  *** bitcoin-git has joined #bitcoin-core-dev
344 2020-03-31T18:31:55  <bitcoin-git> [bitcoin] hebasto opened pull request #18485: test: Add mempool_updatefromblock.py (master...20200331-test-mempool) https://github.com/bitcoin/bitcoin/pull/18485
345 2020-03-31T18:31:56  *** bitcoin-git has left #bitcoin-core-dev
346 2020-03-31T18:33:08  *** g0000n has left #bitcoin-core-dev
347 2020-03-31T18:43:52  *** millerti has joined #bitcoin-core-dev
348 2020-03-31T18:51:45  *** rjected has joined #bitcoin-core-dev
349 2020-03-31T19:00:58  *** Krellan_ has joined #bitcoin-core-dev
350 2020-03-31T19:11:17  *** Highway61 has quit IRC
351 2020-03-31T19:11:38  *** Highway61 has joined #bitcoin-core-dev
352 2020-03-31T19:35:27  *** Krellan_ has quit IRC
353 2020-03-31T19:38:03  *** kristapsk has quit IRC
354 2020-03-31T19:40:17  *** bitcoin-git has joined #bitcoin-core-dev
355 2020-03-31T19:40:17  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d52ba21dfff9...72ef36656439
356 2020-03-31T19:40:18  <bitcoin-git> bitcoin/master fa3cc0b MarcoFalke: test: Remove unsafe BOOST_TEST_MESSAGE
357 2020-03-31T19:40:18  <bitcoin-git> bitcoin/master 72ef366 MarcoFalke: Merge #18472: test: Remove unsafe BOOST_TEST_MESSAGE
358 2020-03-31T19:40:20  *** bitcoin-git has left #bitcoin-core-dev
359 2020-03-31T19:40:37  *** bitcoin-git has joined #bitcoin-core-dev
360 2020-03-31T19:40:37  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18472: test: Remove unsafe BOOST_TEST_MESSAGE (master...2003-testNoBoost) https://github.com/bitcoin/bitcoin/pull/18472
361 2020-03-31T19:40:38  *** bitcoin-git has left #bitcoin-core-dev
362 2020-03-31T19:40:56  *** vasild_ has joined #bitcoin-core-dev
363 2020-03-31T19:42:18  *** hebasto has joined #bitcoin-core-dev
364 2020-03-31T19:44:23  *** vasild has quit IRC
365 2020-03-31T19:44:24  *** vasild_ is now known as vasild
366 2020-03-31T19:47:30  *** Krellan_ has joined #bitcoin-core-dev
367 2020-03-31T19:50:55  <hebasto> travis did not handle #18485. Could reopening help? Or just wait?
368 2020-03-31T19:50:56  <gribble> https://github.com/bitcoin/bitcoin/issues/18485 | test: Add mempool_updatefromblock.py by hebasto · Pull Request #18485 · bitcoin/bitcoin · GitHub
369 2020-03-31T19:51:46  *** Krellan_ has quit IRC
370 2020-03-31T20:06:36  *** per has joined #bitcoin-core-dev
371 2020-03-31T20:08:54  <jeremyrubin> hebasto: good work on that test!
372 2020-03-31T20:11:00  <hebasto> jeremyrubin: how large tx graph do you suggest?
373 2020-03-31T20:11:36  <jeremyrubin> Up to you -- You can see the code in the ComplexMempool benchmark for "generate a large tx graph" idiom.
374 2020-03-31T20:11:54  <jeremyrubin> I think the question is less so largeness but the 'weirdness' of the structure
375 2020-03-31T20:12:16  <jeremyrubin> You want it to have a lot of stuff where a child is also a grandchild
376 2020-03-31T20:12:40  <hebasto> "child is also a grandchild" included already :)
377 2020-03-31T20:12:48  <jeremyrubin> Ah let me re-check
378 2020-03-31T20:13:15  <jeremyrubin> Maybe some ascii art :)
379 2020-03-31T20:14:15  <jeremyrubin> ok so TX 0 pays into tx 1 and into tx2 and tx3
380 2020-03-31T20:14:22  <jeremyrubin> Tx 1 pays into tx 2
381 2020-03-31T20:14:33  <jeremyrubin> gotcha
382 2020-03-31T20:14:35  <hebasto> what are our rules: an arrow from a parent to a child or opposite?
383 2020-03-31T20:14:36  <jeremyrubin> I see
384 2020-03-31T20:15:06  <jeremyrubin> For ascii? I think there are arguments for both arrow directions
385 2020-03-31T20:15:44  <hebasto> if don't mind, let skip ascii :)
386 2020-03-31T20:15:56  <jeremyrubin> Personally I've always preferred arrow to parent conceptually, but arrow to child makes more sense to people intuitively
387 2020-03-31T20:16:45  <hebasto> it seems I tend to agree with your point
388 2020-03-31T20:17:07  <jeremyrubin> yeah arrow to parent makes sense because it's a pointer and the parent is immutable
389 2020-03-31T20:17:15  <jeremyrubin> But value "flows" from parent to child
390 2020-03-31T20:17:16  <hebasto> sure
391 2020-03-31T20:18:11  <jeremyrubin> I'll think if there's cases that wouldn't be caught here.
392 2020-03-31T20:18:19  <hebasto> maybe just add a note that a complete graph is used?
393 2020-03-31T20:18:21  <hebasto> https://en.wikipedia.org/wiki/Complete_graph
394 2020-03-31T20:18:27  <jeremyrubin> I think making it bigger (e.g., 50 txns) would be useful
395 2020-03-31T20:18:43  <jeremyrubin> because then you will trip over the mempool descendants and ancestors limits
396 2020-03-31T20:18:52  <jeremyrubin> So you check that they aren't being enforced during reorg
397 2020-03-31T20:18:57  <hebasto> yeah, limits...
398 2020-03-31T20:19:50  <jeremyrubin> can be done as follow up work tho
399 2020-03-31T20:19:54  <jeremyrubin> test is fine as is IMO
400 2020-03-31T20:20:22  <hebasto> "they aren't being enforced during reorg" mind pointing me to code?
401 2020-03-31T20:21:16  <jeremyrubin> UpdateTransactionsFromBlock
402 2020-03-31T20:21:20  <hebasto> ty
403 2020-03-31T20:21:42  <hebasto> oh, I know that part of code ;)
404 2020-03-31T20:21:45  *** jarthur has quit IRC
405 2020-03-31T20:22:06  <jeremyrubin> yeah we're just not checking things like "how many descendants does a tx have" here
406 2020-03-31T20:22:17  <hebasto> I see
407 2020-03-31T20:22:47  <jeremyrubin> So by doing your test with 50 things you would confirm that we aren't eviciting stuff even if not re-mined
408 2020-03-31T20:23:16  <jeremyrubin> (which can be a potential problem, and behavior we'd want to change, but... let's skip that for now)
409 2020-03-31T20:24:02  *** jarthur has joined #bitcoin-core-dev
410 2020-03-31T20:27:31  *** bitcoin-git has joined #bitcoin-core-dev
411 2020-03-31T20:27:31  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18486: doc: Explain new test logging (master...2004-docTestLogging) https://github.com/bitcoin/bitcoin/pull/18486
412 2020-03-31T20:27:32  *** bitcoin-git has left #bitcoin-core-dev
413 2020-03-31T20:32:08  *** manantial has quit IRC
414 2020-03-31T20:36:05  *** bitcoin-git has joined #bitcoin-core-dev
415 2020-03-31T20:36:05  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/72ef36656439...d2db25233cf0
416 2020-03-31T20:36:06  <bitcoin-git> bitcoin/master fac3716 MarcoFalke: test: check that peer is connected when calling sync_*
417 2020-03-31T20:36:06  <bitcoin-git> bitcoin/master d2db252 MarcoFalke: Merge #18474: test: check that peer is connected when calling sync_*
418 2020-03-31T20:36:11  *** bitcoin-git has left #bitcoin-core-dev
419 2020-03-31T20:36:25  *** bitcoin-git has joined #bitcoin-core-dev
420 2020-03-31T20:36:25  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18474: test: check that peer is connected when calling sync_* (master...2003-qaCheckConnSync) https://github.com/bitcoin/bitcoin/pull/18474
421 2020-03-31T20:36:27  *** sipsorcery has quit IRC
422 2020-03-31T20:36:29  *** bitcoin-git has left #bitcoin-core-dev
423 2020-03-31T20:37:55  *** jarthur has quit IRC
424 2020-03-31T20:41:45  *** theStack has quit IRC
425 2020-03-31T20:46:32  *** jarthur has joined #bitcoin-core-dev
426 2020-03-31T20:59:56  *** Talkless has quit IRC
427 2020-03-31T21:00:02  *** furkanmustafa has quit IRC
428 2020-03-31T21:03:13  *** Guyver2 has quit IRC
429 2020-03-31T21:04:06  *** emilengler has quit IRC
430 2020-03-31T21:06:14  *** AaronvanW has quit IRC
431 2020-03-31T21:15:04  *** jarthur has quit IRC
432 2020-03-31T21:17:04  *** jarthur has joined #bitcoin-core-dev
433 2020-03-31T21:19:33  *** hebasto has quit IRC
434 2020-03-31T21:21:00  *** ddustin_ has quit IRC
435 2020-03-31T21:21:39  *** ddustin has joined #bitcoin-core-dev
436 2020-03-31T21:23:16  *** hebasto has joined #bitcoin-core-dev
437 2020-03-31T21:26:33  *** ddustin has quit IRC
438 2020-03-31T21:30:57  *** jarthur has quit IRC
439 2020-03-31T21:41:05  *** RandolfR has joined #bitcoin-core-dev
440 2020-03-31T21:42:53  *** Randolf has quit IRC
441 2020-03-31T21:48:29  *** Krellan_ has joined #bitcoin-core-dev
442 2020-03-31T21:52:57  *** Krellan_ has quit IRC
443 2020-03-31T21:55:15  *** ddustin has joined #bitcoin-core-dev
444 2020-03-31T21:55:37  *** glidenote1 has joined #bitcoin-core-dev
445 2020-03-31T21:57:14  *** owowo has quit IRC
446 2020-03-31T22:02:27  *** owowo has joined #bitcoin-core-dev
447 2020-03-31T22:11:50  *** jarthur has joined #bitcoin-core-dev
448 2020-03-31T22:15:56  *** jarthur has quit IRC
449 2020-03-31T22:17:04  *** jarthur has joined #bitcoin-core-dev
450 2020-03-31T22:22:07  *** jarthur has quit IRC
451 2020-03-31T22:37:02  *** justanotheruser has quit IRC
452 2020-03-31T22:43:20  *** mdunnio has quit IRC
453 2020-03-31T22:46:31  *** marcoagner has quit IRC
454 2020-03-31T22:54:49  *** jarthur has joined #bitcoin-core-dev
455 2020-03-31T22:55:02  *** justanotheruser has joined #bitcoin-core-dev
456 2020-03-31T22:55:11  *** captjakk has quit IRC
457 2020-03-31T22:55:43  *** captjakk has joined #bitcoin-core-dev
458 2020-03-31T22:57:13  *** captjakk has quit IRC
459 2020-03-31T22:57:27  *** captjakk has joined #bitcoin-core-dev
460 2020-03-31T22:59:20  *** jarthur has quit IRC
461 2020-03-31T23:00:01  *** apaval_ has quit IRC
462 2020-03-31T23:00:21  *** apaval_ has joined #bitcoin-core-dev
463 2020-03-31T23:04:06  *** PaulTroon has quit IRC
464 2020-03-31T23:04:15  *** hebasto has quit IRC
465 2020-03-31T23:09:55  *** filchef has quit IRC
466 2020-03-31T23:15:32  *** ddustin has quit IRC
467 2020-03-31T23:16:07  *** mdunnio has joined #bitcoin-core-dev
468 2020-03-31T23:20:40  *** mdunnio has quit IRC
469 2020-03-31T23:26:40  *** promag has quit IRC
470 2020-03-31T23:26:46  *** promag__ has joined #bitcoin-core-dev
471 2020-03-31T23:27:07  *** promag has joined #bitcoin-core-dev
472 2020-03-31T23:27:28  *** promag_ has quit IRC
473 2020-03-31T23:28:04  *** hebasto has joined #bitcoin-core-dev
474 2020-03-31T23:29:51  *** timothy has quit IRC
475 2020-03-31T23:31:14  *** bitcoin-git has joined #bitcoin-core-dev
476 2020-03-31T23:31:14  <bitcoin-git> [bitcoin] promag opened pull request #18487: wip: rpc: Fix rpcRunLater race in walletpassphrase (master...2020-04-fix-rpcrunlater-race) https://github.com/bitcoin/bitcoin/pull/18487
477 2020-03-31T23:31:15  *** bitcoin-git has left #bitcoin-core-dev
478 2020-03-31T23:32:49  *** ddustin has joined #bitcoin-core-dev
479 2020-03-31T23:37:00  *** jarthur has joined #bitcoin-core-dev
480 2020-03-31T23:48:35  *** mdunnio has joined #bitcoin-core-dev
481 2020-03-31T23:49:13  *** Krellan_ has joined #bitcoin-core-dev
482 2020-03-31T23:51:28  *** jarthur has quit IRC
483 2020-03-31T23:51:44  <promag> I'd like to consider #18487 for 0.20
484 2020-03-31T23:51:46  <gribble> https://github.com/bitcoin/bitcoin/issues/18487 | wip: rpc: Fix rpcRunLater race in walletpassphrase by promag · Pull Request #18487 · bitcoin/bitcoin · GitHub
485 2020-03-31T23:51:58  <promag> at worst case it doesn't fix the issue and only reduces the lock scopes
486 2020-03-31T23:53:15  *** mdunnio has quit IRC