1 2020-04-03T00:00:01  *** vkmc1 has quit IRC
  2 2020-04-03T00:03:52  *** PaulTroon has quit IRC
  3 2020-04-03T00:05:17  *** dviola has quit IRC
  4 2020-04-03T00:08:58  *** mdunnio has quit IRC
  5 2020-04-03T00:15:47  *** justanotheruser has joined #bitcoin-core-dev
  6 2020-04-03T00:17:41  *** AaronvanW has joined #bitcoin-core-dev
  7 2020-04-03T00:20:33  *** promag has joined #bitcoin-core-dev
  8 2020-04-03T00:21:21  *** iMast777 has joined #bitcoin-core-dev
  9 2020-04-03T00:25:19  *** promag has quit IRC
 10 2020-04-03T00:29:37  *** nodweber has quit IRC
 11 2020-04-03T00:32:45  *** bitcoin-git has joined #bitcoin-core-dev
 12 2020-04-03T00:32:45  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18509: fuzz: Avoid running over all inputs after merging them (master...2004-fuzzMergeOnce) https://github.com/bitcoin/bitcoin/pull/18509
 13 2020-04-03T00:32:46  *** bitcoin-git has left #bitcoin-core-dev
 14 2020-04-03T00:39:52  *** mdunnio has joined #bitcoin-core-dev
 15 2020-04-03T00:43:09  <achow101> is it intentional that a new default wallet cannot be created when running with -nowallet?
 16 2020-04-03T00:44:44  *** mdunnio has quit IRC
 17 2020-04-03T00:54:54  <luke-jr> achow101: afaik -nowallet currently emulates a build w/o wallet support
 18 2020-04-03T00:55:22  <achow101> you can make and add new wallets even when -nowallet
 19 2020-04-03T00:55:45  <achow101> I think this is just a bug because who would want to make a wallet with no name
 20 2020-04-03T01:04:13  *** AaronvanW has quit IRC
 21 2020-04-03T01:08:06  *** bitcoin-git has joined #bitcoin-core-dev
 22 2020-04-03T01:08:06  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18510: fuzz: Add CScriptNum::getint coverage (master...2004-fuzzScriptNumGetInt) https://github.com/bitcoin/bitcoin/pull/18510
 23 2020-04-03T01:08:07  *** bitcoin-git has left #bitcoin-core-dev
 24 2020-04-03T01:08:33  *** promag has joined #bitcoin-core-dev
 25 2020-04-03T01:12:54  *** promag has quit IRC
 26 2020-04-03T01:19:27  *** afk11` has quit IRC
 27 2020-04-03T01:19:52  *** afk11` has joined #bitcoin-core-dev
 28 2020-04-03T01:28:54  *** promag has joined #bitcoin-core-dev
 29 2020-04-03T01:31:43  *** stackingcore21 has joined #bitcoin-core-dev
 30 2020-04-03T01:33:29  *** promag has quit IRC
 31 2020-04-03T01:34:53  *** bitcoin-git has joined #bitcoin-core-dev
 32 2020-04-03T01:34:53  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18484: rpc: Correctly compute redeemScript from witnessScript for signrawtransaction (master...signrawtx-p2pkh-p2wsh) https://github.com/bitcoin/bitcoin/pull/18484
 33 2020-04-03T01:34:54  *** bitcoin-git has left #bitcoin-core-dev
 34 2020-04-03T01:35:13  *** bitcoin-git has joined #bitcoin-core-dev
 35 2020-04-03T01:35:13  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18484: rpc: Correctly compute redeemScript from witnessScript for signrawtransaction (master...signrawtx-p2pkh-p2wsh) https://github.com/bitcoin/bitcoin/pull/18484
 36 2020-04-03T01:35:15  *** bitcoin-git has left #bitcoin-core-dev
 37 2020-04-03T01:37:14  *** Chris_Stewart_5 has quit IRC
 38 2020-04-03T01:38:01  *** Highway61 has quit IRC
 39 2020-04-03T01:46:24  *** Emcy has quit IRC
 40 2020-04-03T02:04:27  *** PaulTroon has joined #bitcoin-core-dev
 41 2020-04-03T02:09:27  *** Dean_Guss has joined #bitcoin-core-dev
 42 2020-04-03T02:09:47  *** PaulTroon has quit IRC
 43 2020-04-03T02:09:54  *** meshcollider has quit IRC
 44 2020-04-03T02:10:23  *** DeanWeen has quit IRC
 45 2020-04-03T02:10:59  *** Emcy has joined #bitcoin-core-dev
 46 2020-04-03T02:18:11  *** meshcollider has joined #bitcoin-core-dev
 47 2020-04-03T02:20:22  *** bitcoin-git has joined #bitcoin-core-dev
 48 2020-04-03T02:20:23  <bitcoin-git> [bitcoin] sipa opened pull request #18512: Improve asmap checks and add sanity check (master...202003_asmap_checks) https://github.com/bitcoin/bitcoin/pull/18512
 49 2020-04-03T02:20:34  *** bitcoin-git has left #bitcoin-core-dev
 50 2020-04-03T02:24:43  *** molz_ has quit IRC
 51 2020-04-03T02:44:11  *** Deacyde has joined #bitcoin-core-dev
 52 2020-04-03T02:58:30  <luke-jr> MarcoFalke: I have a working test for the bug #18192 fixes; should I leave it for another PR since it already has 2 ACKs?
 53 2020-04-03T02:58:32  <gribble> https://github.com/bitcoin/bitcoin/issues/18192 | Bugfix: Wallet: Safely deal with change in the address book by luke-jr · Pull Request #18192 · bitcoin/bitcoin · GitHub
 54 2020-04-03T03:00:02  *** iMast777 has quit IRC
 55 2020-04-03T03:16:58  *** pehjota1 has joined #bitcoin-core-dev
 56 2020-04-03T03:36:29  *** mdunnio has joined #bitcoin-core-dev
 57 2020-04-03T03:37:00  *** captjakk has quit IRC
 58 2020-04-03T03:37:34  *** captjakk has joined #bitcoin-core-dev
 59 2020-04-03T03:40:54  *** mdunnio has quit IRC
 60 2020-04-03T03:42:18  *** captjakk has quit IRC
 61 2020-04-03T03:44:24  *** captjakk has joined #bitcoin-core-dev
 62 2020-04-03T03:51:36  *** AaronvanW has joined #bitcoin-core-dev
 63 2020-04-03T03:52:10  *** EagleTM has joined #bitcoin-core-dev
 64 2020-04-03T03:54:14  *** Eagle[TM] has quit IRC
 65 2020-04-03T04:04:30  *** mdunnio has joined #bitcoin-core-dev
 66 2020-04-03T04:04:56  *** mdunnio has quit IRC
 67 2020-04-03T04:12:00  *** captjakk has quit IRC
 68 2020-04-03T04:12:36  *** captjakk has joined #bitcoin-core-dev
 69 2020-04-03T04:17:24  *** captjakk has quit IRC
 70 2020-04-03T04:23:23  *** AaronvanW has quit IRC
 71 2020-04-03T04:27:16  *** mol has joined #bitcoin-core-dev
 72 2020-04-03T04:43:59  *** captjakk has joined #bitcoin-core-dev
 73 2020-04-03T04:49:00  *** captjakk has quit IRC
 74 2020-04-03T05:22:59  *** Kiminuo has quit IRC
 75 2020-04-03T05:25:51  *** tryphe has joined #bitcoin-core-dev
 76 2020-04-03T05:28:28  *** tryphe_ has quit IRC
 77 2020-04-03T05:30:13  *** Kiminuo has joined #bitcoin-core-dev
 78 2020-04-03T05:49:57  *** ddustin has joined #bitcoin-core-dev
 79 2020-04-03T05:52:26  *** ddustin has quit IRC
 80 2020-04-03T05:59:30  *** Highway61 has joined #bitcoin-core-dev
 81 2020-04-03T06:00:02  *** pehjota1 has quit IRC
 82 2020-04-03T06:05:41  *** PaulTroon has joined #bitcoin-core-dev
 83 2020-04-03T06:10:54  *** PaulTroon has quit IRC
 84 2020-04-03T06:12:13  *** jarthur_ has joined #bitcoin-core-dev
 85 2020-04-03T06:15:46  *** jarthur has quit IRC
 86 2020-04-03T06:19:23  *** kristapsk has quit IRC
 87 2020-04-03T06:19:58  *** ToBeFree has joined #bitcoin-core-dev
 88 2020-04-03T06:20:16  *** ToBeFree is now known as Guest52194
 89 2020-04-03T06:20:24  *** AaronvanW has joined #bitcoin-core-dev
 90 2020-04-03T06:25:26  *** jorijn has quit IRC
 91 2020-04-03T06:28:42  *** jorijn has joined #bitcoin-core-dev
 92 2020-04-03T06:36:49  *** jorijn has quit IRC
 93 2020-04-03T06:37:55  *** jorijn has joined #bitcoin-core-dev
 94 2020-04-03T06:44:52  *** captjakk has joined #bitcoin-core-dev
 95 2020-04-03T06:44:54  *** mryandao has quit IRC
 96 2020-04-03T06:45:22  *** mryandao has joined #bitcoin-core-dev
 97 2020-04-03T06:49:15  *** captjakk has quit IRC
 98 2020-04-03T06:53:00  *** AaronvanW has quit IRC
 99 2020-04-03T06:54:40  *** jorijn has quit IRC
100 2020-04-03T07:00:10  *** jorijn has joined #bitcoin-core-dev
101 2020-04-03T07:04:29  *** dviola has joined #bitcoin-core-dev
102 2020-04-03T07:05:12  *** PaulTroon has joined #bitcoin-core-dev
103 2020-04-03T07:08:57  *** manantial has joined #bitcoin-core-dev
104 2020-04-03T07:10:23  *** manantial has quit IRC
105 2020-04-03T07:11:22  *** jorijn has quit IRC
106 2020-04-03T07:12:09  *** manantial has joined #bitcoin-core-dev
107 2020-04-03T07:15:53  *** lucaferr has joined #bitcoin-core-dev
108 2020-04-03T07:19:09  *** jorijn has joined #bitcoin-core-dev
109 2020-04-03T07:22:08  *** Talkless has joined #bitcoin-core-dev
110 2020-04-03T07:23:34  *** jorijn has quit IRC
111 2020-04-03T07:26:46  *** alec_ has joined #bitcoin-core-dev
112 2020-04-03T07:27:23  *** alec has quit IRC
113 2020-04-03T07:41:06  *** vasild_ has joined #bitcoin-core-dev
114 2020-04-03T07:43:07  *** jorijn has joined #bitcoin-core-dev
115 2020-04-03T07:44:03  *** vasild has quit IRC
116 2020-04-03T07:44:04  *** vasild_ is now known as vasild
117 2020-04-03T07:45:38  *** AaronvanW has joined #bitcoin-core-dev
118 2020-04-03T07:51:24  *** emilengler has joined #bitcoin-core-dev
119 2020-04-03T07:59:54  *** TheHoliestRoger has quit IRC
120 2020-04-03T08:10:12  *** TheHoliestRoger has joined #bitcoin-core-dev
121 2020-04-03T08:14:17  *** marcoagner has joined #bitcoin-core-dev
122 2020-04-03T08:31:23  *** Dean_Guss has quit IRC
123 2020-04-03T08:36:57  *** AaronvanW has quit IRC
124 2020-04-03T08:37:12  *** AaronvanW has joined #bitcoin-core-dev
125 2020-04-03T08:41:39  *** manantial has quit IRC
126 2020-04-03T08:45:53  *** captjakk has joined #bitcoin-core-dev
127 2020-04-03T08:47:38  *** timothy has joined #bitcoin-core-dev
128 2020-04-03T08:50:09  *** captjakk has quit IRC
129 2020-04-03T08:54:59  <jonatack> fanquake: see the edit message, "Removed "macOS does not yet support dark mode". I believe it does since at least 10.14.6 and Apple is aggressive in pushing updates. Feel free to revert/update if I'm wrong."
130 2020-04-03T08:58:05  <jonatack> fanquake: also added release notes for the removal of the deprecated totalFee arg from rpc bumpfee, for rpc getpeerinfo now including "mapped_as" (mapped Asynchronous System) used for diversifying peer networking, and GUI Peers window now showing "Mapped AS" for the same.
131 2020-04-03T09:00:01  *** Guest52194 has quit IRC
132 2020-04-03T09:05:11  <fanquake> jonatack: it doesn’t support dark mode, and we explicitly opt out. Don’t think qt 5.9 supports dark mode in any case.
133 2020-04-03T09:05:47  *** manantial has joined #bitcoin-core-dev
134 2020-04-03T09:06:01  <fanquake> #14593
135 2020-04-03T09:06:04  <gribble> https://github.com/bitcoin/bitcoin/issues/14593 | gui: explicitly disable "Dark Mode" appearance on macOS by fanquake · Pull Request #14593 · bitcoin/bitcoin · GitHub
136 2020-04-03T09:14:40  *** ccdle12 has joined #bitcoin-core-dev
137 2020-04-03T09:27:02  *** cycheng has joined #bitcoin-core-dev
138 2020-04-03T09:34:32  *** molly has joined #bitcoin-core-dev
139 2020-04-03T09:37:54  *** mol has quit IRC
140 2020-04-03T09:39:50  *** promag has joined #bitcoin-core-dev
141 2020-04-03T09:42:20  *** kristapsk has joined #bitcoin-core-dev
142 2020-04-03T09:52:34  *** FunPika has joined #bitcoin-core-dev
143 2020-04-03T10:03:59  *** Kelton24Gerlach has joined #bitcoin-core-dev
144 2020-04-03T10:11:33  *** bitcoin-git has joined #bitcoin-core-dev
145 2020-04-03T10:11:33  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dce6f3b29b41...6ec42df32b06
146 2020-04-03T10:11:34  <bitcoin-git> bitcoin/master 332f373 Sebastian Falbesoner: [scripts] previous_release: improve failed download error message
147 2020-04-03T10:11:35  <bitcoin-git> bitcoin/master 6ec42df fanquake: Merge #18426: scripts: previous_release: improve behaviour on failed downl...
148 2020-04-03T10:11:36  *** bitcoin-git has left #bitcoin-core-dev
149 2020-04-03T10:11:37  *** EagleTM has quit IRC
150 2020-04-03T10:11:53  *** bitcoin-git has joined #bitcoin-core-dev
151 2020-04-03T10:11:53  <bitcoin-git> [bitcoin] fanquake merged pull request #18426: scripts: previous_release: improve behaviour on failed download (master...20200324-scripts-previous-release-show-error-message-if-download-fails) https://github.com/bitcoin/bitcoin/pull/18426
152 2020-04-03T10:11:54  *** bitcoin-git has left #bitcoin-core-dev
153 2020-04-03T10:13:46  *** justanotheruser has quit IRC
154 2020-04-03T10:17:38  *** bitcoin-git has joined #bitcoin-core-dev
155 2020-04-03T10:17:39  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6ec42df32b06...d478595fad6e
156 2020-04-03T10:17:39  <bitcoin-git> bitcoin/master d695eb4 Vasil Dimov: doc: note the costs of fetching all pull requests
157 2020-04-03T10:17:40  <bitcoin-git> bitcoin/master d478595 fanquake: Merge #18382: doc: note the costs of fetching all pull requests
158 2020-04-03T10:17:42  *** bitcoin-git has left #bitcoin-core-dev
159 2020-04-03T10:17:58  *** bitcoin-git has joined #bitcoin-core-dev
160 2020-04-03T10:17:58  <bitcoin-git> [bitcoin] fanquake merged pull request #18382: doc: note the costs of fetching all pull requests (master...note_fetch_all_cost) https://github.com/bitcoin/bitcoin/pull/18382
161 2020-04-03T10:17:59  *** bitcoin-git has left #bitcoin-core-dev
162 2020-04-03T10:21:49  *** molly has quit IRC
163 2020-04-03T10:25:08  *** bitcoin-git has joined #bitcoin-core-dev
164 2020-04-03T10:25:08  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d478595fad6e...be60e37e4041
165 2020-04-03T10:25:09  <bitcoin-git> bitcoin/master 7b2975a Suriyaa Sundararuban: doc: Update webchat URLs in README.md
166 2020-04-03T10:25:09  <bitcoin-git> bitcoin/master be60e37 fanquake: Merge #18505: doc: Update webchat URLs in README.md
167 2020-04-03T10:25:11  *** bitcoin-git has left #bitcoin-core-dev
168 2020-04-03T10:25:28  *** bitcoin-git has joined #bitcoin-core-dev
169 2020-04-03T10:25:28  <bitcoin-git> [bitcoin] fanquake merged pull request #18505: doc: Update webchat URLs in README.md (master...update-webchat-urls) https://github.com/bitcoin/bitcoin/pull/18505
170 2020-04-03T10:25:29  *** bitcoin-git has left #bitcoin-core-dev
171 2020-04-03T10:30:40  *** cycheng has quit IRC
172 2020-04-03T10:32:57  *** EagleTM has joined #bitcoin-core-dev
173 2020-04-03T10:34:55  *** gets has joined #bitcoin-core-dev
174 2020-04-03T10:36:14  *** gets has quit IRC
175 2020-04-03T10:44:01  *** justanotheruser has joined #bitcoin-core-dev
176 2020-04-03T10:46:44  *** alec_ is now known as alec
177 2020-04-03T10:48:15  *** frogar has quit IRC
178 2020-04-03T10:48:34  *** frogar has joined #bitcoin-core-dev
179 2020-04-03T10:53:55  *** bitcoin-git has joined #bitcoin-core-dev
180 2020-04-03T10:53:55  <bitcoin-git> [bitcoin] HashUnlimited opened pull request #18513: [doc] fix git add argument (master...master) https://github.com/bitcoin/bitcoin/pull/18513
181 2020-04-03T10:53:56  *** bitcoin-git has left #bitcoin-core-dev
182 2020-04-03T11:05:04  *** Chris_Stewart_5 has joined #bitcoin-core-dev
183 2020-04-03T11:09:05  *** mol has joined #bitcoin-core-dev
184 2020-04-03T11:11:50  *** bitcoin-git has joined #bitcoin-core-dev
185 2020-04-03T11:11:51  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/be60e37e4041...08c4994969be
186 2020-04-03T11:11:51  <bitcoin-git> bitcoin/master fad2f68 MarcoFalke: init: Replace URL_WEBSITE with PACKAGE_URL
187 2020-04-03T11:11:52  <bitcoin-git> bitcoin/master 08c4994 fanquake: Merge #18503: init: Replace URL_WEBSITE with PACKAGE_URL
188 2020-04-03T11:12:02  *** bitcoin-git has left #bitcoin-core-dev
189 2020-04-03T11:12:19  *** bitcoin-git has joined #bitcoin-core-dev
190 2020-04-03T11:12:20  <bitcoin-git> [bitcoin] fanquake merged pull request #18503: init: Replace URL_WEBSITE with PACKAGE_URL (master...2004-initRebrand) https://github.com/bitcoin/bitcoin/pull/18503
191 2020-04-03T11:12:20  *** bitcoin-git has left #bitcoin-core-dev
192 2020-04-03T11:18:47  <jonatack> fanquake: thanks. i found the release notes surprising this time aroun, as i have an old 2012 macbook pro running a node on mojave 10.14.6 and qt 5.14.1 and dark mode looks good (not like in 14593). perhaps we should mention what versions of qt or macOS do/don't work
193 2020-04-03T11:19:48  <fanquake> jonatack: that's expected. If you're self compiling, and just running src/qt/bitcoin-qt, it will work. If you run deploy and use the app bundle (as releases are built) it wont.
194 2020-04-03T11:20:28  <fanquake> I don't think we need to mention anything more in the readme, as releases are not affected.
195 2020-04-03T11:20:34  <fanquake> s/readme/release-notes
196 2020-04-03T11:21:16  <jonatack> fanquake: ok. i'll revert the notes change then if you haven't already. here's what dark mode looks like for me: https://github.com/bitcoin/bitcoin/pull/16923#issuecomment-606770987
197 2020-04-03T11:21:28  *** Kelton24Gerlach has quit IRC
198 2020-04-03T11:26:22  <jonatack> fanquake: it says: "Additionally, Bitcoin Core does not yet change appearance when macOS "dark mode" is activated." -> what say you to appending ", except if compiling from source." or similar, for dummies like me :)
199 2020-04-03T11:27:49  <jonatack> (done, reverted the removal)
200 2020-04-03T11:29:54  *** bitcoin-git has joined #bitcoin-core-dev
201 2020-04-03T11:29:54  <bitcoin-git> [bitcoin] fanquake opened pull request #18514: test: remove rapidcheck integration and tests (master...remove_rapidcheck) https://github.com/bitcoin/bitcoin/pull/18514
202 2020-04-03T11:29:55  *** bitcoin-git has left #bitcoin-core-dev
203 2020-04-03T11:32:05  *** bitcoin-git has joined #bitcoin-core-dev
204 2020-04-03T11:32:05  <bitcoin-git> [bitcoin] Christewart closed pull request #14430: Add more property based tests for basic bitcoin data structures (master...add_tests_from_8469) https://github.com/bitcoin/bitcoin/pull/14430
205 2020-04-03T11:32:07  *** bitcoin-git has left #bitcoin-core-dev
206 2020-04-03T11:32:45  *** bitcoin-git has joined #bitcoin-core-dev
207 2020-04-03T11:32:45  <bitcoin-git> [bitcoin] fanquake closed pull request #14694: tests: Separately check for rapidcheck/boost_test.h in configure (master...rapidcheck-boost-test) https://github.com/bitcoin/bitcoin/pull/14694
208 2020-04-03T11:32:51  *** bitcoin-git has left #bitcoin-core-dev
209 2020-04-03T11:37:48  *** bitcoin-git has joined #bitcoin-core-dev
210 2020-04-03T11:37:49  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/08c4994969be...f0d6487e2907
211 2020-04-03T11:37:50  <bitcoin-git> bitcoin/master 4928a99 Michael Polzer: [doc] fix git add argument
212 2020-04-03T11:37:51  <bitcoin-git> bitcoin/master f0d6487 fanquake: Merge #18513: doc: fix git add argument
213 2020-04-03T11:37:53  *** bitcoin-git has left #bitcoin-core-dev
214 2020-04-03T11:38:08  *** bitcoin-git has joined #bitcoin-core-dev
215 2020-04-03T11:38:08  <bitcoin-git> [bitcoin] fanquake merged pull request #18513: doc: fix git add argument (master...master) https://github.com/bitcoin/bitcoin/pull/18513
216 2020-04-03T11:38:09  *** bitcoin-git has left #bitcoin-core-dev
217 2020-04-03T11:40:15  *** jonatack has quit IRC
218 2020-04-03T11:45:21  *** jonatack has joined #bitcoin-core-dev
219 2020-04-03T11:51:58  *** cycheng has joined #bitcoin-core-dev
220 2020-04-03T12:00:01  *** FunPika has quit IRC
221 2020-04-03T12:05:16  *** cycheng has quit IRC
222 2020-04-03T12:06:27  *** mol has quit IRC
223 2020-04-03T12:08:08  *** EagleTM has quit IRC
224 2020-04-03T12:43:55  <instagibbs> provoostenator, change detection is not a "can I sign this" question, that's a "can I understand what's mine" question
225 2020-04-03T12:44:48  <instagibbs> if the signer sees additional outputs going to stuff the wallet doesn't recognise/user has to look up, what's the damage
226 2020-04-03T12:47:22  <instagibbs> As long as the user is prompted with useful information, I don't see what issue "eager" signing causes.
227 2020-04-03T12:47:25  *** captjakk has joined #bitcoin-core-dev
228 2020-04-03T12:51:08  *** dholbach has joined #bitcoin-core-dev
229 2020-04-03T12:52:23  *** captjakk has quit IRC
230 2020-04-03T13:03:37  *** MasterdonX has joined #bitcoin-core-dev
231 2020-04-03T13:04:44  *** masterdonx2 has quit IRC
232 2020-04-03T13:06:56  *** Victorsueca has quit IRC
233 2020-04-03T13:07:59  *** EagleTM has joined #bitcoin-core-dev
234 2020-04-03T13:11:29  *** mol has joined #bitcoin-core-dev
235 2020-04-03T13:14:01  *** Victorsueca has joined #bitcoin-core-dev
236 2020-04-03T13:18:34  *** Victorsueca has quit IRC
237 2020-04-03T13:22:59  *** jarthur has joined #bitcoin-core-dev
238 2020-04-03T13:25:04  *** Victorsueca has joined #bitcoin-core-dev
239 2020-04-03T13:27:32  *** kljasdfvv has quit IRC
240 2020-04-03T13:35:37  *** Victorsueca has quit IRC
241 2020-04-03T13:40:33  *** michagogo has joined #bitcoin-core-dev
242 2020-04-03T13:50:52  *** Victorsueca has joined #bitcoin-core-dev
243 2020-04-03T13:54:36  *** cycheng has joined #bitcoin-core-dev
244 2020-04-03T13:58:04  *** EagleTM has quit IRC
245 2020-04-03T14:04:16  *** Highway61 has quit IRC
246 2020-04-03T14:07:18  *** Kiminuo has quit IRC
247 2020-04-03T14:11:36  *** Dean_Guss has joined #bitcoin-core-dev
248 2020-04-03T14:11:45  *** Highway61 has joined #bitcoin-core-dev
249 2020-04-03T14:16:41  *** captjakk has joined #bitcoin-core-dev
250 2020-04-03T14:20:11  *** mol has quit IRC
251 2020-04-03T14:22:35  *** mol has joined #bitcoin-core-dev
252 2020-04-03T14:24:35  *** braydonf has quit IRC
253 2020-04-03T14:25:04  *** braydonf has joined #bitcoin-core-dev
254 2020-04-03T14:25:12  *** Deacyde has quit IRC
255 2020-04-03T14:35:52  *** mol has quit IRC
256 2020-04-03T14:41:01  *** mol has joined #bitcoin-core-dev
257 2020-04-03T14:44:21  *** bitcoin-git has joined #bitcoin-core-dev
258 2020-04-03T14:44:21  <bitcoin-git> [bitcoin] theStack opened pull request #18515: test: add BIP37 remote crash bug [CVE-2013-5700] test to p2p_filter.py (master...20200403-test-check-for-CVE20135700-vuln-in-bip37-tests) https://github.com/bitcoin/bitcoin/pull/18515
259 2020-04-03T14:44:22  *** bitcoin-git has left #bitcoin-core-dev
260 2020-04-03T14:45:26  *** ccdle12 has quit IRC
261 2020-04-03T14:46:59  *** Guyver2 has joined #bitcoin-core-dev
262 2020-04-03T14:48:33  *** molly has joined #bitcoin-core-dev
263 2020-04-03T14:50:36  <gleb> I just hanged the process (it's stuck for minutes) by sending SIGINT multiple times during "FlushStateToDisk: write coins cache".  Is this expected? :)
264 2020-04-03T14:52:04  *** mol has quit IRC
265 2020-04-03T14:54:20  <vasild> What is it doing?
266 2020-04-03T14:58:25  <gleb> It's just stuck with that line being last in the logs forever. I then used "kill -9" to kill the process.
267 2020-04-03T14:59:48  <vasild> SIGINT would cause StartShutdown() to be called which only sets a boolean fRequestShutdown to true. Shouldn't cause issues if executed multiple times.
268 2020-04-03T15:00:02  *** dholbach has quit IRC
269 2020-04-03T15:00:44  <vasild> If its possible to reproduce then maybe try to attach gdb and see what it is doing.
270 2020-04-03T15:03:16  <gleb> I was more generally curious, if I see something like this, is it a worthy bug looking at? I don't have an intuition about the expectations in a case like this. If it is, I'll try to reproduce and take a closer look.
271 2020-04-03T15:03:18  <vasild> maybe some of the writes or flushes being executed gets interrupted due to the (second) signal arrival and the code mishandles that?
272 2020-04-03T15:05:03  <vasild> Any hang looks like a (serious) bug to me. In a sense maybe even worse than a crash because in a crash the user or some automated system can detect it and start it again.
273 2020-04-03T15:05:33  *** ccdle12 has joined #bitcoin-core-dev
274 2020-04-03T15:07:22  *** Victorsueca has quit IRC
275 2020-04-03T15:08:30  *** andrewtoth has joined #bitcoin-core-dev
276 2020-04-03T15:08:50  *** molly has quit IRC
277 2020-04-03T15:10:15  *** justanotheruser has quit IRC
278 2020-04-03T15:12:38  *** dr-orlovsky has joined #bitcoin-core-dev
279 2020-04-03T15:13:46  *** Victorsueca has joined #bitcoin-core-dev
280 2020-04-03T15:15:49  *** emilengler has quit IRC
281 2020-04-03T15:16:16  *** emilengler has joined #bitcoin-core-dev
282 2020-04-03T15:18:27  *** Victorsueca has quit IRC
283 2020-04-03T15:19:45  *** mol has joined #bitcoin-core-dev
284 2020-04-03T15:19:48  <wumpus> it's worth reporting though if it's not easy to reproduce, *please* add information, such as where in the code it hangs (e.g. gdb output)
285 2020-04-03T15:21:47  <wumpus> always get a backtrace when there's a hang
286 2020-04-03T15:22:05  *** matael1 has joined #bitcoin-core-dev
287 2020-04-03T15:24:02  *** Victorsueca has joined #bitcoin-core-dev
288 2020-04-03T15:25:47  *** justanotheruser has joined #bitcoin-core-dev
289 2020-04-03T15:26:26  *** bitcoin-git has joined #bitcoin-core-dev
290 2020-04-03T15:26:26  <bitcoin-git> [bitcoin] jonatack opened pull request #18516: test: relax bumpfee dust_to_fee txsize an extra vbyte (master...relax-dust_to_fee-test) https://github.com/bitcoin/bitcoin/pull/18516
291 2020-04-03T15:26:27  *** bitcoin-git has left #bitcoin-core-dev
292 2020-04-03T15:33:46  *** Victorsueca has quit IRC
293 2020-04-03T15:37:18  *** belcher has joined #bitcoin-core-dev
294 2020-04-03T15:43:11  *** EagleTM has joined #bitcoin-core-dev
295 2020-04-03T15:45:12  *** Highway61 has quit IRC
296 2020-04-03T15:45:34  *** Highway61 has joined #bitcoin-core-dev
297 2020-04-03T15:49:13  *** Kiminuo has joined #bitcoin-core-dev
298 2020-04-03T15:56:35  *** Guyver2_ has joined #bitcoin-core-dev
299 2020-04-03T15:58:22  *** Guyver2 has quit IRC
300 2020-04-03T16:04:52  *** cycheng has quit IRC
301 2020-04-03T16:05:36  *** AaronvanW has quit IRC
302 2020-04-03T16:54:05  *** jarthur has quit IRC
303 2020-04-03T16:55:12  *** jarthur has joined #bitcoin-core-dev
304 2020-04-03T17:03:25  *** AaronvanW has joined #bitcoin-core-dev
305 2020-04-03T17:28:06  *** captjakk has quit IRC
306 2020-04-03T17:28:38  *** captjakk has joined #bitcoin-core-dev
307 2020-04-03T17:30:25  *** bitcoin-git has joined #bitcoin-core-dev
308 2020-04-03T17:30:26  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18518: fuzz: Extend descriptor fuzz test (master...2004-fuzDesc) https://github.com/bitcoin/bitcoin/pull/18518
309 2020-04-03T17:30:27  *** bitcoin-git has left #bitcoin-core-dev
310 2020-04-03T17:33:23  *** bitcoin-git has joined #bitcoin-core-dev
311 2020-04-03T17:33:23  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18519: fuzz: Extend script fuzz test (master...2004-fuzzScript) https://github.com/bitcoin/bitcoin/pull/18519
312 2020-04-03T17:33:24  *** bitcoin-git has left #bitcoin-core-dev
313 2020-04-03T17:35:51  *** captjakk has quit IRC
314 2020-04-03T17:36:07  *** captjakk has joined #bitcoin-core-dev
315 2020-04-03T17:48:30  *** sdaftuar_ has quit IRC
316 2020-04-03T17:49:10  *** sdaftuar_ has joined #bitcoin-core-dev
317 2020-04-03T17:50:26  *** theStack has quit IRC
318 2020-04-03T17:50:47  *** ghost43 has quit IRC
319 2020-04-03T17:51:07  *** ghost43 has joined #bitcoin-core-dev
320 2020-04-03T17:52:04  *** ddustin has joined #bitcoin-core-dev
321 2020-04-03T17:53:07  *** ddustin has quit IRC
322 2020-04-03T17:57:55  *** ddustin has joined #bitcoin-core-dev
323 2020-04-03T18:00:02  *** matael1 has quit IRC
324 2020-04-03T18:14:56  *** Chris_Stewart_5 has quit IRC
325 2020-04-03T18:20:20  *** Snuupy1 has joined #bitcoin-core-dev
326 2020-04-03T18:21:07  *** Chris_Stewart_5 has joined #bitcoin-core-dev
327 2020-04-03T18:25:55  *** jb55 has quit IRC
328 2020-04-03T18:28:16  *** jb55 has joined #bitcoin-core-dev
329 2020-04-03T18:30:33  *** jb55 has quit IRC
330 2020-04-03T18:31:51  *** ghost43 has quit IRC
331 2020-04-03T18:32:59  *** ghost43 has joined #bitcoin-core-dev
332 2020-04-03T18:40:05  *** jb55 has joined #bitcoin-core-dev
333 2020-04-03T19:02:54  *** owowo has quit IRC
334 2020-04-03T19:04:19  *** molly has joined #bitcoin-core-dev
335 2020-04-03T19:06:50  *** mol has quit IRC
336 2020-04-03T19:07:43  *** owowo has joined #bitcoin-core-dev
337 2020-04-03T19:07:44  *** owowo has joined #bitcoin-core-dev
338 2020-04-03T19:09:53  *** bitcoin-git has joined #bitcoin-core-dev
339 2020-04-03T19:09:53  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/f0d6487e2907...e35e118656e9
340 2020-04-03T19:09:54  <bitcoin-git> bitcoin/master eca65ca Luke Dashjr: Bugfix: RPC: Add missing commas and correct indentation of explicit ELISION
341 2020-04-03T19:09:54  <bitcoin-git> bitcoin/master 26dcf39 Luke Dashjr: Bugfix: RPC: Don't use a continuation elipsis after an elision elipsis
342 2020-04-03T19:09:55  <bitcoin-git> bitcoin/master f32ab44 Luke Dashjr: Bugfix: RPC: JSON null is not "None"
343 2020-04-03T19:09:56  *** bitcoin-git has left #bitcoin-core-dev
344 2020-04-03T19:10:13  *** bitcoin-git has joined #bitcoin-core-dev
345 2020-04-03T19:10:13  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18508: RPC: Fix more formatting nits (master...rpcdoc_format_20200402) https://github.com/bitcoin/bitcoin/pull/18508
346 2020-04-03T19:10:14  *** bitcoin-git has left #bitcoin-core-dev
347 2020-04-03T19:16:40  *** bitcoin-git has joined #bitcoin-core-dev
348 2020-04-03T19:16:41  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e35e118656e9...c8971547d9c9
349 2020-04-03T19:16:41  <bitcoin-git> bitcoin/master fab3255 MarcoFalke: rpc: Make rpc documentation not depend on rpc args
350 2020-04-03T19:16:41  <bitcoin-git> bitcoin/master c897154 MarcoFalke: Merge #18499: rpc: Make rpc documentation not depend on call-time rpc args...
351 2020-04-03T19:16:42  *** bitcoin-git has left #bitcoin-core-dev
352 2020-04-03T19:16:56  *** bitcoin-git has joined #bitcoin-core-dev
353 2020-04-03T19:16:57  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18499: rpc: Make rpc documentation not depend on call-time rpc args (master...2004-rpcStaticDoc) https://github.com/bitcoin/bitcoin/pull/18499
354 2020-04-03T19:16:57  *** bitcoin-git has left #bitcoin-core-dev
355 2020-04-03T19:38:03  *** vaibs26 has joined #bitcoin-core-dev
356 2020-04-03T19:40:59  *** vasild_ has joined #bitcoin-core-dev
357 2020-04-03T19:43:59  *** andrewtoth has quit IRC
358 2020-04-03T19:44:23  *** vasild has quit IRC
359 2020-04-03T19:44:24  *** vasild_ is now known as vasild
360 2020-04-03T19:44:40  *** andrewtoth has joined #bitcoin-core-dev
361 2020-04-03T19:47:51  *** vaibs26 has quit IRC
362 2020-04-03T19:48:15  *** guest534543 has joined #bitcoin-core-dev
363 2020-04-03T19:50:32  *** jarthur_ has joined #bitcoin-core-dev
364 2020-04-03T19:51:25  *** Kiminuo has quit IRC
365 2020-04-03T19:53:59  *** jarthur has quit IRC
366 2020-04-03T19:59:37  *** Guyver2_ has quit IRC
367 2020-04-03T20:09:20  *** captjakk has quit IRC
368 2020-04-03T20:09:55  *** captjakk has joined #bitcoin-core-dev
369 2020-04-03T20:10:21  *** ghost43 has quit IRC
370 2020-04-03T20:11:50  *** ghost43 has joined #bitcoin-core-dev
371 2020-04-03T20:13:45  *** andrewtoth has quit IRC
372 2020-04-03T20:13:49  *** andrewtoth_ has joined #bitcoin-core-dev
373 2020-04-03T20:14:35  *** captjakk has quit IRC
374 2020-04-03T20:16:39  *** jarthur_ is now known as jarthur
375 2020-04-03T20:18:34  *** justanotheruser has quit IRC
376 2020-04-03T20:18:58  *** captjakk has joined #bitcoin-core-dev
377 2020-04-03T20:19:41  *** stackingcore21 has joined #bitcoin-core-dev
378 2020-04-03T20:35:16  *** ddustin has quit IRC
379 2020-04-03T20:37:05  *** ddustin has joined #bitcoin-core-dev
380 2020-04-03T20:41:57  *** ddustin has quit IRC
381 2020-04-03T20:56:00  *** ghost43 has quit IRC
382 2020-04-03T20:56:20  *** ghost43 has joined #bitcoin-core-dev
383 2020-04-03T21:00:02  *** Snuupy1 has quit IRC
384 2020-04-03T21:02:46  *** PaulTroon has quit IRC
385 2020-04-03T21:13:25  *** promag has quit IRC
386 2020-04-03T21:15:23  *** Highway61 has quit IRC
387 2020-04-03T21:16:33  *** Highway61 has joined #bitcoin-core-dev
388 2020-04-03T21:16:55  *** Highway61 has quit IRC
389 2020-04-03T21:17:16  *** Highway61 has joined #bitcoin-core-dev
390 2020-04-03T21:18:57  *** emilengler has quit IRC
391 2020-04-03T21:20:48  *** manantial has quit IRC
392 2020-04-03T21:21:58  *** lugosi1 has joined #bitcoin-core-dev
393 2020-04-03T21:22:25  *** promag has joined #bitcoin-core-dev
394 2020-04-03T21:24:03  *** bitcoin-git has joined #bitcoin-core-dev
395 2020-04-03T21:24:03  <bitcoin-git> [bitcoin] theStack opened pull request #18520: test: remaining replacements of (send_message+sync_with_ping) with send_and_ping (master...20200403-test-remaining-send_and_ping-substitutes) https://github.com/bitcoin/bitcoin/pull/18520
396 2020-04-03T21:24:04  *** bitcoin-git has left #bitcoin-core-dev
397 2020-04-03T21:25:25  *** ddustin has joined #bitcoin-core-dev
398 2020-04-03T21:30:22  *** filchef has joined #bitcoin-core-dev
399 2020-04-03T21:34:52  *** promag has quit IRC
400 2020-04-03T21:35:47  *** Highway61 has quit IRC
401 2020-04-03T21:36:35  *** Highway61 has joined #bitcoin-core-dev
402 2020-04-03T21:50:10  <fjahr> Just repeating it here in case someone is missing it on Twitter: there are fishing emails going around seemingly targeting email addresses from Github commits, made to look like official emails from Github. At least some of them seem to get around spam filters. Some topics I got: "Activate your account", "Accept Terms of Service change", "Complete your profile" etc.
403 2020-04-03T21:50:18  *** promag has joined #bitcoin-core-dev
404 2020-04-03T21:51:16  <sipa> fjahr: i just got a "File has been modified from your private repository"
405 2020-04-03T21:55:07  *** promag has quit IRC
406 2020-04-03T21:56:18  *** jarthur has quit IRC
407 2020-04-03T21:56:32  <jonatack> same. strange sender address was the tip-off: "Support Github app71076620@skydropx.com via sendgrid.me". stay alert.
408 2020-04-03T22:04:46  *** Talkless has quit IRC
409 2020-04-03T22:10:59  <gwillen> jonatack: if you have one of those in your inbox, and it appears to be genuinely coming via sendgrid, you should forward it to their abuse address
410 2020-04-03T22:11:06  <gwillen> so they can take out the sender's account
411 2020-04-03T22:11:48  <gwillen> I'm not consistent about reporting stuff like this because there's just too much of it, but if it's worth a warning it's probably worth a report
412 2020-04-03T22:12:30  *** Dean_Guss has quit IRC
413 2020-04-03T22:12:44  *** Dean_Guss has joined #bitcoin-core-dev
414 2020-04-03T22:22:49  *** jarthur has joined #bitcoin-core-dev
415 2020-04-03T22:23:45  *** jarthur has quit IRC
416 2020-04-03T22:24:02  *** Murch has quit IRC
417 2020-04-03T22:24:11  *** jarthur has joined #bitcoin-core-dev
418 2020-04-03T22:33:57  *** ddustin has quit IRC
419 2020-04-03T22:40:23  *** sdaftuar_ has quit IRC
420 2020-04-03T22:42:15  *** sdaftuar_ has joined #bitcoin-core-dev
421 2020-04-03T22:57:15  *** ddustin has joined #bitcoin-core-dev
422 2020-04-03T23:03:56  *** ddustin has quit IRC
423 2020-04-03T23:06:23  *** timothy has quit IRC
424 2020-04-03T23:14:57  *** jarthur_ has joined #bitcoin-core-dev
425 2020-04-03T23:17:44  *** jarthur__ has joined #bitcoin-core-dev
426 2020-04-03T23:17:51  *** jarthur__ has quit IRC
427 2020-04-03T23:18:52  *** jarthur has quit IRC
428 2020-04-03T23:21:12  *** jarthur_ has quit IRC
429 2020-04-03T23:22:58  *** Chris_Stewart_5 has quit IRC
430 2020-04-03T23:38:54  *** justanotheruser has joined #bitcoin-core-dev
431 2020-04-03T23:51:30  *** ddustin has joined #bitcoin-core-dev
432 2020-04-03T23:55:15  *** promag has joined #bitcoin-core-dev
433 2020-04-03T23:57:22  *** ddustin has quit IRC