1 2020-04-06T00:00:02  *** kwm1 has quit IRC
  2 2020-04-06T00:12:31  *** ddustin has joined #bitcoin-core-dev
  3 2020-04-06T00:17:47  *** heftig1 has joined #bitcoin-core-dev
  4 2020-04-06T00:25:53  *** paracyst has quit IRC
  5 2020-04-06T00:27:41  *** paracyst has joined #bitcoin-core-dev
  6 2020-04-06T00:51:12  *** TheHoliestRoger has quit IRC
  7 2020-04-06T00:52:03  *** TheHoliestRoger has joined #bitcoin-core-dev
  8 2020-04-06T00:55:50  *** btc4ever has quit IRC
  9 2020-04-06T00:58:12  *** Chris_Stewart_5 has quit IRC
 10 2020-04-06T00:59:19  *** chy has quit IRC
 11 2020-04-06T01:07:59  *** paracyst has quit IRC
 12 2020-04-06T01:11:11  *** paracyst has joined #bitcoin-core-dev
 13 2020-04-06T01:36:33  *** bitcoin-git has joined #bitcoin-core-dev
 14 2020-04-06T01:36:33  <bitcoin-git> [bitcoin] fanquake opened pull request #18534: test: skip backwards compat tests if not compiled with wallet (master...skip_feature_compat_no_wallet) https://github.com/bitcoin/bitcoin/pull/18534
 15 2020-04-06T01:36:44  *** bitcoin-git has left #bitcoin-core-dev
 16 2020-04-06T01:44:02  *** belcher has quit IRC
 17 2020-04-06T01:48:54  *** bitcoin-git has joined #bitcoin-core-dev
 18 2020-04-06T01:48:54  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cf21293ef7fd...516ebe8a62de
 19 2020-04-06T01:48:55  <bitcoin-git> bitcoin/master 9e071b0 fanquake: test: remove rapidcheck integration and tests
 20 2020-04-06T01:48:55  <bitcoin-git> bitcoin/master 516ebe8 fanquake: Merge #18514: test: remove rapidcheck integration and tests
 21 2020-04-06T01:48:57  *** bitcoin-git has left #bitcoin-core-dev
 22 2020-04-06T01:49:14  *** bitcoin-git has joined #bitcoin-core-dev
 23 2020-04-06T01:49:14  <bitcoin-git> [bitcoin] fanquake merged pull request #18514: test: remove rapidcheck integration and tests (master...remove_rapidcheck) https://github.com/bitcoin/bitcoin/pull/18514
 24 2020-04-06T01:49:15  *** bitcoin-git has left #bitcoin-core-dev
 25 2020-04-06T01:55:43  *** alec has quit IRC
 26 2020-04-06T01:59:56  *** AaronvanW has quit IRC
 27 2020-04-06T02:10:16  *** captjakk has quit IRC
 28 2020-04-06T02:14:42  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 29 2020-04-06T02:18:46  *** meshcollider has quit IRC
 30 2020-04-06T02:23:54  *** Chris_Stewart_5 has quit IRC
 31 2020-04-06T02:24:44  *** meshcollider has joined #bitcoin-core-dev
 32 2020-04-06T02:34:58  *** pinheadmz has quit IRC
 33 2020-04-06T02:46:16  *** pinheadmz has joined #bitcoin-core-dev
 34 2020-04-06T03:00:02  *** heftig1 has quit IRC
 35 2020-04-06T03:18:21  *** freakofmimsy has joined #bitcoin-core-dev
 36 2020-04-06T03:18:44  *** murray_ has quit IRC
 37 2020-04-06T03:21:42  *** AaronvanW has joined #bitcoin-core-dev
 38 2020-04-06T03:34:40  *** EagleTM has joined #bitcoin-core-dev
 39 2020-04-06T03:37:12  *** Eagle[TM] has quit IRC
 40 2020-04-06T03:38:01  *** rjected_ has joined #bitcoin-core-dev
 41 2020-04-06T03:38:02  *** rjected has quit IRC
 42 2020-04-06T03:43:55  *** Guest28075 has joined #bitcoin-core-dev
 43 2020-04-06T03:55:23  *** AaronvanW has quit IRC
 44 2020-04-06T04:07:49  *** justan0theruser is now known as justanotheruser
 45 2020-04-06T04:09:04  *** Guest28075 has quit IRC
 46 2020-04-06T04:20:48  *** captjakk has joined #bitcoin-core-dev
 47 2020-04-06T04:24:35  *** alec has joined #bitcoin-core-dev
 48 2020-04-06T04:25:13  *** luke-jr has quit IRC
 49 2020-04-06T04:25:32  *** captjakk has quit IRC
 50 2020-04-06T04:26:40  *** luke-jr has joined #bitcoin-core-dev
 51 2020-04-06T04:41:38  *** jarthur has joined #bitcoin-core-dev
 52 2020-04-06T04:44:43  *** anditto has joined #bitcoin-core-dev
 53 2020-04-06T05:14:47  *** captjakk has joined #bitcoin-core-dev
 54 2020-04-06T05:19:27  *** captjakk has quit IRC
 55 2020-04-06T05:38:15  *** mryandao has quit IRC
 56 2020-04-06T05:38:55  *** mryandao has joined #bitcoin-core-dev
 57 2020-04-06T05:39:42  *** guest534543 has quit IRC
 58 2020-04-06T05:47:18  *** Kiminuo has joined #bitcoin-core-dev
 59 2020-04-06T05:52:25  *** AaronvanW has joined #bitcoin-core-dev
 60 2020-04-06T05:53:35  *** jarthur has quit IRC
 61 2020-04-06T05:58:09  *** jorijn has quit IRC
 62 2020-04-06T06:00:02  *** freakofmimsy has quit IRC
 63 2020-04-06T06:04:23  *** jorijn has joined #bitcoin-core-dev
 64 2020-04-06T06:12:37  *** shesek has quit IRC
 65 2020-04-06T06:13:02  *** shesek has joined #bitcoin-core-dev
 66 2020-04-06T06:13:02  *** shesek has joined #bitcoin-core-dev
 67 2020-04-06T06:20:51  *** leoburd has joined #bitcoin-core-dev
 68 2020-04-06T06:26:22  *** AaronvanW has quit IRC
 69 2020-04-06T06:41:28  *** mryandao has left #bitcoin-core-dev
 70 2020-04-06T06:42:44  *** anditto has quit IRC
 71 2020-04-06T06:59:09  <fanquake> wumpus /  sipa can you block RANDALL-hub
 72 2020-04-06T07:01:59  *** Guyver2 has joined #bitcoin-core-dev
 73 2020-04-06T07:19:49  *** dviola has joined #bitcoin-core-dev
 74 2020-04-06T07:23:06  *** anditto has joined #bitcoin-core-dev
 75 2020-04-06T07:27:45  *** anditto has quit IRC
 76 2020-04-06T07:35:29  *** EagleTM has quit IRC
 77 2020-04-06T07:35:53  *** ddustin_ has joined #bitcoin-core-dev
 78 2020-04-06T07:38:07  *** ddustin has quit IRC
 79 2020-04-06T07:40:11  *** anditto has joined #bitcoin-core-dev
 80 2020-04-06T07:41:05  *** vasild_ has joined #bitcoin-core-dev
 81 2020-04-06T07:42:47  *** manantial has joined #bitcoin-core-dev
 82 2020-04-06T07:44:03  *** vasild has quit IRC
 83 2020-04-06T07:44:04  *** vasild_ is now known as vasild
 84 2020-04-06T07:44:35  *** DeanWeen has quit IRC
 85 2020-04-06T07:45:41  <sipa>  fanquake: done
 86 2020-04-06T08:00:34  *** marcoagner has joined #bitcoin-core-dev
 87 2020-04-06T08:01:57  *** bitcoin-git has joined #bitcoin-core-dev
 88 2020-04-06T08:01:57  <bitcoin-git> [bitcoin] fanquake opened pull request #18535: build: remove -Qunused-arguments workaround for clang + ccache (master...dont_quash_unused_driver_arguments) https://github.com/bitcoin/bitcoin/pull/18535
 89 2020-04-06T08:01:58  *** bitcoin-git has left #bitcoin-core-dev
 90 2020-04-06T08:07:18  *** emilengler has joined #bitcoin-core-dev
 91 2020-04-06T08:13:20  *** irc_user826134 has joined #bitcoin-core-dev
 92 2020-04-06T08:23:11  *** AaronvanW has joined #bitcoin-core-dev
 93 2020-04-06T08:28:00  *** kljasdfvv has joined #bitcoin-core-dev
 94 2020-04-06T08:32:25  *** AaronvanW has quit IRC
 95 2020-04-06T08:32:44  *** AaronvanW has joined #bitcoin-core-dev
 96 2020-04-06T08:49:10  *** emilengler has quit IRC
 97 2020-04-06T08:49:28  *** emilengler has joined #bitcoin-core-dev
 98 2020-04-06T08:54:19  *** Talkless has joined #bitcoin-core-dev
 99 2020-04-06T08:57:03  *** sdaftuar_ has quit IRC
100 2020-04-06T08:57:28  *** sdaftuar_ has joined #bitcoin-core-dev
101 2020-04-06T09:00:01  *** leoburd has quit IRC
102 2020-04-06T09:16:36  *** captjakk has joined #bitcoin-core-dev
103 2020-04-06T09:17:48  <aj> huh, when trying to reference a pr in github, you can type "#" then some text from the topic and press enter on the one you want, and it'll replace the text you typed with the correct pr number. convenient!
104 2020-04-06T09:19:01  <fanquake> very
105 2020-04-06T09:20:24  *** feb has joined #bitcoin-core-dev
106 2020-04-06T09:20:54  *** captjakk has quit IRC
107 2020-04-06T09:21:31  *** dr-orlovsky has joined #bitcoin-core-dev
108 2020-04-06T09:33:09  *** anditto has quit IRC
109 2020-04-06T09:38:40  *** sonofhan has joined #bitcoin-core-dev
110 2020-04-06T09:41:16  *** cajetanp has joined #bitcoin-core-dev
111 2020-04-06T09:49:43  *** sdaftuar_ has quit IRC
112 2020-04-06T09:50:44  *** sdaftuar_ has joined #bitcoin-core-dev
113 2020-04-06T09:52:46  *** cajetanp has quit IRC
114 2020-04-06T09:53:52  *** someone235 has joined #bitcoin-core-dev
115 2020-04-06T09:56:22  *** hkjn0 has quit IRC
116 2020-04-06T10:03:58  *** Miller30Fritsch has joined #bitcoin-core-dev
117 2020-04-06T10:11:00  *** anditto has joined #bitcoin-core-dev
118 2020-04-06T10:15:37  *** anditto has quit IRC
119 2020-04-06T10:27:45  *** midnight has quit IRC
120 2020-04-06T10:35:44  *** midnight has joined #bitcoin-core-dev
121 2020-04-06T10:35:47  *** sonofhan has quit IRC
122 2020-04-06T10:38:16  <wumpus> oh good find!
123 2020-04-06T10:47:06  *** midnight has quit IRC
124 2020-04-06T10:50:16  *** Miller30Fritsch has quit IRC
125 2020-04-06T10:51:16  *** midnight has joined #bitcoin-core-dev
126 2020-04-06T10:54:15  *** sipsorcery has joined #bitcoin-core-dev
127 2020-04-06T10:57:51  *** timothy has joined #bitcoin-core-dev
128 2020-04-06T11:00:00  *** Chris_Stewart_5 has joined #bitcoin-core-dev
129 2020-04-06T11:17:22  *** captjakk has joined #bitcoin-core-dev
130 2020-04-06T11:22:15  *** captjakk has quit IRC
131 2020-04-06T11:28:45  *** dr-orlovsky has quit IRC
132 2020-04-06T11:30:15  <wumpus> I guess it's time to branch off and wrap up 0.20.0rc1 today
133 2020-04-06T11:31:22  <instagibbs> \o/
134 2020-04-06T11:32:26  *** anditto has joined #bitcoin-core-dev
135 2020-04-06T11:32:46  *** anditto has quit IRC
136 2020-04-06T11:37:09  <luke-jr> wumpus: #18192 has some potential improvements, but also 3 ACKs, so hesitant to touch it - seems better to follow up with the rest in another PR
137 2020-04-06T11:37:11  <gribble> https://github.com/bitcoin/bitcoin/issues/18192 | Bugfix: Wallet: Safely deal with change in the address book by luke-jr · Pull Request #18192 · bitcoin/bitcoin · GitHub
138 2020-04-06T11:39:32  *** bitcoin-git has joined #bitcoin-core-dev
139 2020-04-06T11:39:33  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/516ebe8a62de...adac12ae73e8
140 2020-04-06T11:39:33  <bitcoin-git> bitcoin/master 0eeb046 Wladimir J. van der Laan: net: Hardcoded seeds update for 0.20
141 2020-04-06T11:39:34  <bitcoin-git> bitcoin/master adac12a Wladimir J. van der Laan: Merge #18506: net: Hardcoded seeds update for 0.20
142 2020-04-06T11:39:36  *** bitcoin-git has left #bitcoin-core-dev
143 2020-04-06T11:39:52  *** bitcoin-git has joined #bitcoin-core-dev
144 2020-04-06T11:39:52  <bitcoin-git> [bitcoin] laanwj merged pull request #18506: net: Hardcoded seeds update for 0.20 (master...2020_04_hardcoded_seeds) https://github.com/bitcoin/bitcoin/pull/18506
145 2020-04-06T11:39:53  *** bitcoin-git has left #bitcoin-core-dev
146 2020-04-06T11:41:25  <wumpus> why did #18524 get added to 0.20?
147 2020-04-06T11:41:28  <gribble> https://github.com/bitcoin/bitcoin/issues/18524 | refactor: drop boost::signals2 in validationinterface by ryanofsky · Pull Request #18524 · bitcoin/bitcoin · GitHub
148 2020-04-06T11:43:00  <wumpus> seems a good change but why do such a (potentialy risky) refactor last-minute before a release
149 2020-04-06T11:45:51  <instagibbs> luke-jr, imo adding the test(as new commit) is fine to get merged if 3 acks sans test was enough :)
150 2020-04-06T11:51:05  *** ryanofsky_ has left #bitcoin-core-dev
151 2020-04-06T11:51:22  *** ryanofsky has joined #bitcoin-core-dev
152 2020-04-06T11:51:28  <ryanofsky> wumpus, i don't know if it should be added to 0.20, but it fixes a hang #18517 caused by #18338 that happens with old boost versions
153 2020-04-06T11:51:29  <gribble> https://github.com/bitcoin/bitcoin/issues/18517 | [wallet] Node process hangs after SIGINT · Issue #18517 · bitcoin/bitcoin · GitHub
154 2020-04-06T11:51:32  <gribble> https://github.com/bitcoin/bitcoin/issues/18338 | Fix wallet unload race condition by promag · Pull Request #18338 · bitcoin/bitcoin · GitHub
155 2020-04-06T11:51:33  <ryanofsky> alternative would be to revert #18338
156 2020-04-06T11:51:34  <gribble> https://github.com/bitcoin/bitcoin/issues/18338 | Fix wallet unload race condition by promag · Pull Request #18338 · bitcoin/bitcoin · GitHub
157 2020-04-06T11:52:38  <wumpus> ryanofsky: let's label it as a bugfix then
158 2020-04-06T11:54:31  <ryanofsky> that's fine. it is a refactor with new versions of boost, a bugfix with old versions of boost
159 2020-04-06T11:55:09  <wumpus> a fix for a hang caused by a fix for another hang
160 2020-04-06T11:55:59  <wumpus> well if it is boost versions that are still supported that's kind of important
161 2020-04-06T11:57:28  <wumpus> in any case, independent of that PR, it might be that we don't have enough active reviewers to really do a 0.20 release right now
162 2020-04-06T11:58:00  <wumpus> this is what I was afraid of about a month ago
163 2020-04-06T11:58:58  <luke-jr> could still spin a rc1
164 2020-04-06T11:59:11  <ryanofsky> i would just revert #18517, a bugfix for a rare bug caused a more serious bug, so drop it
165 2020-04-06T11:59:12  <gribble> https://github.com/bitcoin/bitcoin/issues/18517 | [wallet] Node process hangs after SIGINT · Issue #18517 · bitcoin/bitcoin · GitHub
166 2020-04-06T11:59:28  <ryanofsky> revert #18338 I mean
167 2020-04-06T11:59:30  <gribble> https://github.com/bitcoin/bitcoin/issues/18338 | Fix wallet unload race condition by promag · Pull Request #18338 · bitcoin/bitcoin · GitHub
168 2020-04-06T12:00:01  *** feb has quit IRC
169 2020-04-06T12:00:39  <wumpus> ryanofsky: maybe revert it after the 0.20 branch? then go forward with your PR on master
170 2020-04-06T12:02:02  <wumpus> I mean, it still makes sense as a refactor
171 2020-04-06T12:02:15  <ryanofsky> i don't know how things are normally done. i'd revert it on master for but some reason bitcoin projects treats reverts as more of a big deal than other projects i've worked on
172 2020-04-06T12:03:12  <wumpus> but does your PR solve the original issue that #18338 solved, too?
173 2020-04-06T12:03:14  <gribble> https://github.com/bitcoin/bitcoin/issues/18338 | Fix wallet unload race condition by promag · Pull Request #18338 · bitcoin/bitcoin · GitHub
174 2020-04-06T12:04:45  <wumpus> it seems that not fixing that issue at all (in master, at least) is strictly worse
175 2020-04-06T12:05:17  <ryanofsky> no, my pr is really just a refactor that doesn't change bitcoin behavior. #18338 is an actual bugfix but the implementation relies on behavior only implemented in new boost versions
176 2020-04-06T12:05:20  <gribble> https://github.com/bitcoin/bitcoin/issues/18338 | Fix wallet unload race condition by promag · Pull Request #18338 · bitcoin/bitcoin · GitHub
177 2020-04-06T12:06:06  <ryanofsky> #18338 is a weird corner case issue that's been around for a few releases, while #18517 is a serious new regression
178 2020-04-06T12:06:09  <gribble> https://github.com/bitcoin/bitcoin/issues/18338 | Fix wallet unload race condition by promag · Pull Request #18338 · bitcoin/bitcoin · GitHub
179 2020-04-06T12:06:10  <gribble> https://github.com/bitcoin/bitcoin/issues/18517 | [wallet] Node process hangs after SIGINT · Issue #18517 · bitcoin/bitcoin · GitHub
180 2020-04-06T12:07:17  <ryanofsky> if you want to fix both reverting won't work, but the issue 18338 fixes is a crash that happens when loading and unloading the same wallet repeatedly in a loop
181 2020-04-06T12:08:03  <ryanofsky> the issue 18338 causes is a hang on shutdown with ctrl-c, though only with old boost versions
182 2020-04-06T12:09:01  <ryanofsky> reverting might not be appropriate here because we rarely revert
183 2020-04-06T12:09:08  <wumpus> yes, so I think reverting the fix for the weird corner case on 0.20 is acceptable to solve the more serious issue there, but if your refactor (which will go into master) solves the ensuing issue I don't see the point of reverting it on master too
184 2020-04-06T12:10:19  <wumpus> alternatively we should just merge your PR into 0.20 too
185 2020-04-06T12:10:30  <wumpus> I mean it has ACKs, more than some other 0.20-tagged things
186 2020-04-06T12:11:18  <ryanofsky> yep, either way is reasonable
187 2020-04-06T12:21:55  *** defnordic has joined #bitcoin-core-dev
188 2020-04-06T12:33:32  <fanquake> ryanofsky: you don’t necessarily need to be loading and unloading in a loop. The wallet crash can happen with just a wallet close/unload.
189 2020-04-06T12:35:21  *** dviola has quit IRC
190 2020-04-06T12:36:36  *** irc_user826134 has quit IRC
191 2020-04-06T12:37:35  *** irc_user826134 has joined #bitcoin-core-dev
192 2020-04-06T12:56:51  *** irc_user826134 has quit IRC
193 2020-04-06T13:01:15  *** fearbeag has joined #bitcoin-core-dev
194 2020-04-06T13:08:40  *** Highway61 has quit IRC
195 2020-04-06T13:11:43  *** morcos has quit IRC
196 2020-04-06T13:11:52  *** morcos_ has joined #bitcoin-core-dev
197 2020-04-06T13:12:17  *** morcos_ is now known as morcos
198 2020-04-06T13:15:48  *** Highway61 has joined #bitcoin-core-dev
199 2020-04-06T13:25:16  <jonatack> fwiw i'll be reviewing 0
200 2020-04-06T13:25:49  <jonatack> prs tagged v0.20 today, priority guidance welcome
201 2020-04-06T13:26:08  <jonatack> among the list at https://github.com/bitcoin/bitcoin/milestone/42
202 2020-04-06T13:26:11  <luke-jr> zero PRs? :x
203 2020-04-06T13:26:29  <jonatack> s/0/0.20/ :x
204 2020-04-06T13:28:20  *** promag_ is now known as promag
205 2020-04-06T13:29:29  *** bitcoin-git has joined #bitcoin-core-dev
206 2020-04-06T13:29:30  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/adac12ae73e8...299544f9c537
207 2020-04-06T13:29:30  <bitcoin-git> bitcoin/master c0c43ae fanquake: test: skip backwards compat tests if not compiled with wallet
208 2020-04-06T13:29:30  <bitcoin-git> bitcoin/master 299544f MarcoFalke: Merge #18534: test: skip backwards compat tests if not compiled with walle...
209 2020-04-06T13:29:31  *** bitcoin-git has left #bitcoin-core-dev
210 2020-04-06T13:29:48  *** bitcoin-git has joined #bitcoin-core-dev
211 2020-04-06T13:29:49  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18534: test: skip backwards compat tests if not compiled with wallet (master...skip_feature_compat_no_wallet) https://github.com/bitcoin/bitcoin/pull/18534
212 2020-04-06T13:29:49  *** bitcoin-git has left #bitcoin-core-dev
213 2020-04-06T13:31:05  <jonatack> luke-jr: are you planning to update #18192 (3 acks) with the test addition and review comments?
214 2020-04-06T13:31:07  <gribble> https://github.com/bitcoin/bitcoin/issues/18192 | Bugfix: Wallet: Safely deal with change in the address book by luke-jr · Pull Request #18192 · bitcoin/bitcoin · GitHub
215 2020-04-06T13:32:16  <promag> wumpus, ryanofsky: how about updating minimum boost version?
216 2020-04-06T13:32:38  <promag> depends uses 1.70.0
217 2020-04-06T13:33:05  <luke-jr> jonatack: don't want to lose the ACKs
218 2020-04-06T13:33:19  <promag> not against merging ryanofsky refactor
219 2020-04-06T13:33:33  <luke-jr> jonatack: feel free to re-ACK the test commit too, though, in case a merge-person wants me to include that
220 2020-04-06T13:33:52  <promag> which seems fine btw
221 2020-04-06T13:40:59  <fanquake> promag why update minimum boost?
222 2020-04-06T13:42:08  <promag> #18517 only happens with boost < 1.59.0
223 2020-04-06T13:42:11  <gribble> https://github.com/bitcoin/bitcoin/issues/18517 | [wallet] Node process hangs after SIGINT · Issue #18517 · bitcoin/bitcoin · GitHub
224 2020-04-06T13:47:02  *** SiAnDoG_ has quit IRC
225 2020-04-06T13:47:24  *** SiAnDoG_ has joined #bitcoin-core-dev
226 2020-04-06T13:52:38  <hebasto> promag: #16381
227 2020-04-06T13:52:40  <gribble> https://github.com/bitcoin/bitcoin/issues/16381 | Set minimum required Boost to 1.53.0 by hebasto · Pull Request #16381 · bitcoin/bitcoin · GitHub
228 2020-04-06T13:54:27  <promag> hebasto: thanks!
229 2020-04-06T13:55:51  <hebasto> it seems boost 1.59+ is not a choice for Centos 7 and ubuntu xenial
230 2020-04-06T13:56:04  <promag> so from fanquake comment, Jessie, Xenial, Trusty OpenBSD have <1.59 ?
231 2020-04-06T13:56:24  <promag> oh and centos7
232 2020-04-06T13:57:10  <hebasto> https://packages.ubuntu.com/xenial/libboost-dev
233 2020-04-06T13:58:05  *** EagleTM has joined #bitcoin-core-dev
234 2020-04-06T13:58:10  <promag> ok ¯\_(ツ)_/¯
235 2020-04-06T14:08:51  <wumpus> promag: I have a slight preference to solve the problem instead of burying it that way
236 2020-04-06T14:10:30  <promag> when you say "solve" you mean ditch boost
237 2020-04-06T14:10:55  <wumpus> in the long run but I really meant merging ryanofsky 's refactor/fix
238 2020-04-06T14:11:15  <promag> because the problem is solved in boost>1.58
239 2020-04-06T14:11:28  <wumpus> but we have that PR already that fixes the problem
240 2020-04-06T14:12:17  <promag> yeah, I ack that. just saying that we can hit this problem again in other boost signals2 usage
241 2020-04-06T14:12:34  <wumpus> then let's move away from signals2 use
242 2020-04-06T14:12:55  <wumpus> I think there's already been movement in that direction in other places
243 2020-04-06T14:13:01  <promag> sure sgtm
244 2020-04-06T14:14:54  <wumpus> for example, another thing people have een complaining about boost::signals2 is terribly noisy gdb backtraces
245 2020-04-06T14:17:04  <wumpus> I only asked why #18524 was added to 0.20 because I was genuinely suprised a refactor was added, that was cleared up quickly, I like the PR itself, I don't particularly think we need an alternative solution
246 2020-04-06T14:17:07  <gribble> https://github.com/bitcoin/bitcoin/issues/18524 | refactor: drop boost::signals2 in validationinterface by ryanofsky · Pull Request #18524 · bitcoin/bitcoin · GitHub
247 2020-04-06T14:18:41  <promag> yeah, sad behavior change with < 1.59.0
248 2020-04-06T14:19:11  *** AaronvanW has quit IRC
249 2020-04-06T14:29:31  *** dviola has joined #bitcoin-core-dev
250 2020-04-06T14:32:12  *** EagleTM has quit IRC
251 2020-04-06T14:38:34  *** Kiminuo has quit IRC
252 2020-04-06T14:42:34  *** EagleTM has joined #bitcoin-core-dev
253 2020-04-06T14:45:59  *** captjakk has joined #bitcoin-core-dev
254 2020-04-06T14:46:43  *** bitcoin-git has joined #bitcoin-core-dev
255 2020-04-06T14:46:44  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/299544f9c537...fdeb445a34a9
256 2020-04-06T14:46:44  <bitcoin-git> bitcoin/master d6815a2 Russell Yanofsky: refactor: drop boost::signals2 in validationinterface
257 2020-04-06T14:46:45  <bitcoin-git> bitcoin/master fdeb445 Wladimir J. van der Laan: Merge #18524: refactor: drop boost::signals2 in validationinterface
258 2020-04-06T14:46:47  *** bitcoin-git has left #bitcoin-core-dev
259 2020-04-06T14:47:03  *** bitcoin-git has joined #bitcoin-core-dev
260 2020-04-06T14:47:03  <bitcoin-git> [bitcoin] laanwj merged pull request #18524: refactor: drop boost::signals2 in validationinterface (master...pr/nosig) https://github.com/bitcoin/bitcoin/pull/18524
261 2020-04-06T14:47:04  *** bitcoin-git has left #bitcoin-core-dev
262 2020-04-06T14:49:14  *** molly has joined #bitcoin-core-dev
263 2020-04-06T14:51:09  <luke-jr> speaking of unnecessary refactors <.<
264 2020-04-06T14:51:49  *** EagleTM has quit IRC
265 2020-04-06T14:52:25  *** mol has quit IRC
266 2020-04-06T14:53:52  *** sdaftuar_ has quit IRC
267 2020-04-06T14:54:15  *** sdaftuar_ has joined #bitcoin-core-dev
268 2020-04-06T14:55:39  *** jarthur has joined #bitcoin-core-dev
269 2020-04-06T14:57:02  *** dr-orlovsky has joined #bitcoin-core-dev
270 2020-04-06T14:57:04  <wumpus> this one is necessary, see above discussion
271 2020-04-06T14:58:11  *** AaronvanW has joined #bitcoin-core-dev
272 2020-04-06T14:58:26  <wumpus> it's a bugfix and should probably have been called that but with so many ACKs it's abad idea to start changing commit messages
273 2020-04-06T14:59:17  <luke-jr> ah
274 2020-04-06T15:00:00  <luke-jr> I saw that, just didn't make the connection XD
275 2020-04-06T15:00:01  *** defnordic has quit IRC
276 2020-04-06T15:01:32  *** Aaronvan_ has joined #bitcoin-core-dev
277 2020-04-06T15:01:59  *** AaronvanW has quit IRC
278 2020-04-06T15:08:18  <ryanofsky> it is a refactor if you're using a new boost version, a change in behavior / bugfix if using an old boost
279 2020-04-06T15:10:48  <wumpus> right
280 2020-04-06T15:11:13  <wumpus> it's a refactor that moves a potentially buggy dependency out of the way
281 2020-04-06T15:20:21  *** jes1 has joined #bitcoin-core-dev
282 2020-04-06T15:23:15  *** jarthur has joined #bitcoin-core-dev
283 2020-04-06T15:23:47  *** Aaronvan_ is now known as AaronvanW
284 2020-04-06T15:28:10  *** molly has quit IRC
285 2020-04-06T15:29:13  *** justanotheruser has quit IRC
286 2020-04-06T15:37:04  *** bitcoin-git has joined #bitcoin-core-dev
287 2020-04-06T15:37:04  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18471: qa: Test shared validation interface (master...2020-03-test-shared-validation-interface) https://github.com/bitcoin/bitcoin/pull/18471
288 2020-04-06T15:37:05  *** bitcoin-git has left #bitcoin-core-dev
289 2020-04-06T15:37:24  *** bitcoin-git has joined #bitcoin-core-dev
290 2020-04-06T15:37:24  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18471: qa: Test shared validation interface (master...2020-03-test-shared-validation-interface) https://github.com/bitcoin/bitcoin/pull/18471
291 2020-04-06T15:37:25  *** bitcoin-git has left #bitcoin-core-dev
292 2020-04-06T15:39:41  *** bitcoin-git has joined #bitcoin-core-dev
293 2020-04-06T15:39:42  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fdeb445a34a9...425a7f900ed8
294 2020-04-06T15:39:42  <bitcoin-git> bitcoin/master 25e03ba Jon Atack: test: relax bumpfee dust_to_fee txsize an extra vbyte
295 2020-04-06T15:39:43  <bitcoin-git> bitcoin/master 425a7f9 MarcoFalke: Merge #18516: test: relax bumpfee dust_to_fee txsize an extra vbyte
296 2020-04-06T15:39:45  *** bitcoin-git has left #bitcoin-core-dev
297 2020-04-06T15:40:01  *** bitcoin-git has joined #bitcoin-core-dev
298 2020-04-06T15:40:01  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18516: test: relax bumpfee dust_to_fee txsize an extra vbyte (master...relax-dust_to_fee-test) https://github.com/bitcoin/bitcoin/pull/18516
299 2020-04-06T15:40:02  *** bitcoin-git has left #bitcoin-core-dev
300 2020-04-06T15:40:44  *** mol has joined #bitcoin-core-dev
301 2020-04-06T15:42:23  *** Pierre25Hilll has joined #bitcoin-core-dev
302 2020-04-06T15:48:25  <MarcoFalke> > [04:56] <luke-jr> Is there a reason we don't gitian-sign each individual file in addition to the packaged/tar files?
303 2020-04-06T15:48:47  <MarcoFalke> The tar is a concatenation of the individual files, so the signature on it includes the individual files already
304 2020-04-06T15:48:57  <MarcoFalke> > [06:25] <luke-jr> right now, we have zero way for users to verify snap installs
305 2020-04-06T15:49:01  <MarcoFalke> ^ So this is not true
306 2020-04-06T15:49:59  <luke-jr> MarcoFalke: short of redownloading and comparing the tarball binaries..
307 2020-04-06T15:50:44  <luke-jr> also see our website
308 2020-04-06T15:50:46  <luke-jr> "While the Snap packages use the deterministically generated executables, the Snap tool itself does not provide a streamlined way to reveal the contents of a Snap package. Thus, the Bitcoin Core project does not have the information necessary to help you verify the Bitcoin Core Snap packages."
309 2020-04-06T15:51:09  *** bitcoin-git has joined #bitcoin-core-dev
310 2020-04-06T15:51:09  <bitcoin-git> [bitcoin] practicalswift opened pull request #18539: Avoid using locale-dependent boost trim functions in RPCAuthorized(…) and bitcoin-tx (master...avoid-locale-dependent-trim) https://github.com/bitcoin/bitcoin/pull/18539
311 2020-04-06T15:51:10  *** bitcoin-git has left #bitcoin-core-dev
312 2020-04-06T15:51:59  *** Pierre25Hilll has quit IRC
313 2020-04-06T16:00:49  *** AaronvanW has quit IRC
314 2020-04-06T16:04:36  *** setpill has joined #bitcoin-core-dev
315 2020-04-06T16:20:46  *** andrewtoth_ has joined #bitcoin-core-dev
316 2020-04-06T16:21:23  *** justanotheruser has joined #bitcoin-core-dev
317 2020-04-06T16:21:23  *** andrewtoth has quit IRC
318 2020-04-06T16:25:36  *** filchef has joined #bitcoin-core-dev
319 2020-04-06T16:26:43  *** andrewtoth_ has quit IRC
320 2020-04-06T16:34:43  *** Kiminuo has joined #bitcoin-core-dev
321 2020-04-06T16:35:08  *** EagleTM has joined #bitcoin-core-dev
322 2020-04-06T16:36:50  <wumpus> can we have some more review on  #18484 please
323 2020-04-06T16:36:51  <gribble> https://github.com/bitcoin/bitcoin/issues/18484 | rpc: Correctly compute redeemScript from witnessScript for signrawtransaction by achow101 · Pull Request #18484 · bitcoin/bitcoin · GitHub
324 2020-04-06T16:40:49  *** bitcoin-git has joined #bitcoin-core-dev
325 2020-04-06T16:40:49  <bitcoin-git> [bitcoin] jonatack opened pull request #18540: test: wallet_bumpfee assertion fixup (master...bumpfee-test-assertion-fixup) https://github.com/bitcoin/bitcoin/pull/18540
326 2020-04-06T16:40:50  *** bitcoin-git has left #bitcoin-core-dev
327 2020-04-06T16:49:52  <jonatack> wumpus: thanks, looking at 18484
328 2020-04-06T16:55:52  *** AaronvanW has joined #bitcoin-core-dev
329 2020-04-06T16:56:03  *** bitcoin-git has joined #bitcoin-core-dev
330 2020-04-06T16:56:03  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18541: rpc: Make verifychain default values static, not depend on global args (master...2004-rpcStaticDefaults) https://github.com/bitcoin/bitcoin/pull/18541
331 2020-04-06T16:56:04  *** bitcoin-git has left #bitcoin-core-dev
332 2020-04-06T16:59:22  <wumpus> thanks! it's a one-line change, apart from test changes
333 2020-04-06T17:01:33  *** bitcoin-git has joined #bitcoin-core-dev
334 2020-04-06T17:01:34  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/425a7f900ed8...c0b389b33516
335 2020-04-06T17:01:34  <bitcoin-git> bitcoin/master cd3b156 Andrew Chow: Correctly compute redeemScript from witnessScript for signrawtransaction
336 2020-04-06T17:01:35  <bitcoin-git> bitcoin/master c0b389b MarcoFalke: Merge #18484: rpc: Correctly compute redeemScript from witnessScript for s...
337 2020-04-06T17:01:36  *** bitcoin-git has left #bitcoin-core-dev
338 2020-04-06T17:01:53  *** bitcoin-git has joined #bitcoin-core-dev
339 2020-04-06T17:01:54  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18484: rpc: Correctly compute redeemScript from witnessScript for signrawtransaction (master...signrawtx-p2pkh-p2wsh) https://github.com/bitcoin/bitcoin/pull/18484
340 2020-04-06T17:01:55  *** bitcoin-git has left #bitcoin-core-dev
341 2020-04-06T17:06:38  *** RubenSomsen_ is now known as RubenSomsen
342 2020-04-06T17:07:47  *** andrewtoth has joined #bitcoin-core-dev
343 2020-04-06T17:09:31  *** bitcoin-git has joined #bitcoin-core-dev
344 2020-04-06T17:09:31  <bitcoin-git> [bitcoin] promag opened pull request #18542: 0.19: gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged (0.19...2020-04-backport-18160) https://github.com/bitcoin/bitcoin/pull/18542
345 2020-04-06T17:09:32  *** bitcoin-git has left #bitcoin-core-dev
346 2020-04-06T17:12:05  <luke-jr> wumpus: how should I wrap up #18192?
347 2020-04-06T17:12:08  <gribble> https://github.com/bitcoin/bitcoin/issues/18192 | Bugfix: Wallet: Safely deal with change in the address book by luke-jr · Pull Request #18192 · bitcoin/bitcoin · GitHub
348 2020-04-06T17:14:10  *** bitcoin-git has joined #bitcoin-core-dev
349 2020-04-06T17:14:10  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18543: test: Properly sync utxo set to avoid race (master...2004-testFixes) https://github.com/bitcoin/bitcoin/pull/18543
350 2020-04-06T17:14:11  *** bitcoin-git has left #bitcoin-core-dev
351 2020-04-06T17:15:58  *** EagleTM has quit IRC
352 2020-04-06T17:16:21  <MarcoFalke> PSA: If you see an (intermittent) test failure, please open a bug report with a link to the log.
353 2020-04-06T17:17:19  <MarcoFalke> Just resetting the build will make all intermittent failures accumulate and put the test suite in an unusable state where all failures are ignored and just re-run.
354 2020-04-06T17:21:15  <sipa> MarcoFalke: ack
355 2020-04-06T17:21:25  <sipa> (i occasionally did reset build failures)
356 2020-04-06T17:34:03  *** binarybonanza has joined #bitcoin-core-dev
357 2020-04-06T17:48:04  *** modfort has joined #bitcoin-core-dev
358 2020-04-06T17:48:10  *** Highway62 has joined #bitcoin-core-dev
359 2020-04-06T17:49:07  *** Highway61 has quit IRC
360 2020-04-06T17:49:07  *** Highway62 is now known as Highway61
361 2020-04-06T17:59:14  *** bitcoin-git has joined #bitcoin-core-dev
362 2020-04-06T17:59:15  <bitcoin-git> [bitcoin] theStack opened pull request #18544: net: limit BIP37 filter lifespan (active between 'filterload'..'filterclear') (master...20200406-net-limit_bip37_filter_lifetime) https://github.com/bitcoin/bitcoin/pull/18544
363 2020-04-06T17:59:16  *** bitcoin-git has left #bitcoin-core-dev
364 2020-04-06T18:00:02  *** jes1 has quit IRC
365 2020-04-06T18:02:00  *** DeanWeen has joined #bitcoin-core-dev
366 2020-04-06T18:05:16  *** wumpus2 has joined #bitcoin-core-dev
367 2020-04-06T18:05:17  *** modfort has quit IRC
368 2020-04-06T18:06:07  *** nejon_ has joined #bitcoin-core-dev
369 2020-04-06T18:07:04  *** timothy has quit IRC
370 2020-04-06T18:08:05  *** nejon has quit IRC
371 2020-04-06T18:08:05  *** wumpus has quit IRC
372 2020-04-06T18:08:05  *** nejon_ is now known as nejon
373 2020-04-06T18:08:06  *** wraithm has quit IRC
374 2020-04-06T18:08:06  *** jonatack has quit IRC
375 2020-04-06T18:08:17  *** jonatack_ has joined #bitcoin-core-dev
376 2020-04-06T18:08:55  *** wraithm has joined #bitcoin-core-dev
377 2020-04-06T18:16:04  *** DeanWeen has quit IRC
378 2020-04-06T18:16:28  *** DeanWeen has joined #bitcoin-core-dev
379 2020-04-06T18:22:01  *** FalconKirtaran has joined #bitcoin-core-dev
380 2020-04-06T18:23:27  *** bitcoin-git has joined #bitcoin-core-dev
381 2020-04-06T18:23:27  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c0b389b33516...54d5ba3d9cb4
382 2020-04-06T18:23:28  <bitcoin-git> bitcoin/master b224b4e Jon Atack: test: wallet_bumpfee assertion fixup
383 2020-04-06T18:23:28  <bitcoin-git> bitcoin/master 54d5ba3 MarcoFalke: Merge #18540: test: wallet_bumpfee assertion fixup
384 2020-04-06T18:23:30  *** bitcoin-git has left #bitcoin-core-dev
385 2020-04-06T18:23:47  *** bitcoin-git has joined #bitcoin-core-dev
386 2020-04-06T18:23:47  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18540: test: wallet_bumpfee assertion fixup (master...bumpfee-test-assertion-fixup) https://github.com/bitcoin/bitcoin/pull/18540
387 2020-04-06T18:23:49  *** bitcoin-git has left #bitcoin-core-dev
388 2020-04-06T18:26:24  *** DeanWeen has quit IRC
389 2020-04-06T18:26:45  *** DeanWeen has joined #bitcoin-core-dev
390 2020-04-06T18:30:11  *** bitcoin-git has joined #bitcoin-core-dev
391 2020-04-06T18:30:11  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/54d5ba3d9cb4...75021e80ee44
392 2020-04-06T18:30:12  <bitcoin-git> bitcoin/master 7b8e157 João Barbosa: rpc: Fix rpcRunLater race in walletpassphrase
393 2020-04-06T18:30:12  <bitcoin-git> bitcoin/master 75021e8 Wladimir J. van der Laan: Merge #18487: rpc: Fix rpcRunLater race in walletpassphrase
394 2020-04-06T18:30:13  *** bitcoin-git has left #bitcoin-core-dev
395 2020-04-06T18:30:31  *** bitcoin-git has joined #bitcoin-core-dev
396 2020-04-06T18:30:31  <bitcoin-git> [bitcoin] laanwj merged pull request #18487: rpc: Fix rpcRunLater race in walletpassphrase (master...2020-04-fix-rpcrunlater-race) https://github.com/bitcoin/bitcoin/pull/18487
397 2020-04-06T18:30:32  *** bitcoin-git has left #bitcoin-core-dev
398 2020-04-06T18:36:16  *** jarthur has quit IRC
399 2020-04-06T18:36:46  *** jarthur has joined #bitcoin-core-dev
400 2020-04-06T18:37:34  *** setpill has quit IRC
401 2020-04-06T19:01:17  *** EagleTM has joined #bitcoin-core-dev
402 2020-04-06T19:03:33  *** captjakk has quit IRC
403 2020-04-06T19:04:44  *** dr-orlovsky has quit IRC
404 2020-04-06T19:06:51  *** bitcoin-git has joined #bitcoin-core-dev
405 2020-04-06T19:06:51  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/75021e80ee44...c31bcaf203b5
406 2020-04-06T19:06:52  <bitcoin-git> bitcoin/master fa36965 MarcoFalke: net: Add missing cs_vNodes lock
407 2020-04-06T19:06:52  <bitcoin-git> bitcoin/master c31bcaf Wladimir J. van der Laan: Merge #18458: net: Add missing cs_vNodes lock
408 2020-04-06T19:06:54  *** bitcoin-git has left #bitcoin-core-dev
409 2020-04-06T19:07:11  *** bitcoin-git has joined #bitcoin-core-dev
410 2020-04-06T19:07:11  <bitcoin-git> [bitcoin] laanwj merged pull request #18458: net: Add missing cs_vNodes lock (master...2003-netLock) https://github.com/bitcoin/bitcoin/pull/18458
411 2020-04-06T19:07:12  *** bitcoin-git has left #bitcoin-core-dev
412 2020-04-06T19:07:14  *** wumpus2 is now known as wumpus
413 2020-04-06T19:09:01  <wumpus> MarcoFalke: I generally do that, unless it's something clearly travis related like a timeout in fetching packages
414 2020-04-06T19:13:40  *** bitcoin-git has joined #bitcoin-core-dev
415 2020-04-06T19:13:40  <bitcoin-git> [bitcoin] jonatack opened pull request #18545: test: refactor rpc_signrawtransaction and add logging (master...refactor-rpc_signrawtransaction) https://github.com/bitcoin/bitcoin/pull/18545
416 2020-04-06T19:13:41  *** bitcoin-git has left #bitcoin-core-dev
417 2020-04-06T19:14:54  <wumpus> as it's often is
418 2020-04-06T19:15:53  <wumpus> luke-jr: I agree with jnewbery's comment, if there's an actual error return mechanism that's better than asserting
419 2020-04-06T19:19:26  <wumpus> I think asserts (and other "crash the program now") should be used in cases the client is really in a unrecoverable, buggy state, I'm not sure that's the case here
420 2020-04-06T19:21:27  *** captjakk has joined #bitcoin-core-dev
421 2020-04-06T19:27:35  <luke-jr> well, it's a code error if we get there
422 2020-04-06T19:32:25  *** captjakk has quit IRC
423 2020-04-06T19:40:20  *** jorijn has quit IRC
424 2020-04-06T19:40:45  *** jorijn has joined #bitcoin-core-dev
425 2020-04-06T19:44:23  *** vasild has quit IRC
426 2020-04-06T19:46:16  *** vasild has joined #bitcoin-core-dev
427 2020-04-06T19:46:22  *** rjected_ has quit IRC
428 2020-04-06T19:47:14  *** rjected has joined #bitcoin-core-dev
429 2020-04-06T19:49:00  *** captjakk has joined #bitcoin-core-dev
430 2020-04-06T19:50:59  *** jarthur has quit IRC
431 2020-04-06T19:52:43  *** bitcoin-git has joined #bitcoin-core-dev
432 2020-04-06T19:52:43  <bitcoin-git> [bitcoin] MarcoFalke pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/c31bcaf203b5...c5966a87d1fd
433 2020-04-06T19:52:44  <bitcoin-git> bitcoin/master b86cd15 Luke Dashjr: scripted-diff: Wallet: Rename mapAddressBook to m_address_book
434 2020-04-06T19:52:45  <bitcoin-git> bitcoin/master 144b2f8 Luke Dashjr: Wallet: Require usage of new CAddressBookData::setLabel to change label
435 2020-04-06T19:52:45  <bitcoin-git> bitcoin/master 65b6bdc Luke Dashjr: Wallet: Add CAddressBookData::IsChange which returns true iff label has ne...
436 2020-04-06T19:52:46  *** bitcoin-git has left #bitcoin-core-dev
437 2020-04-06T19:54:17  <luke-jr> doh
438 2020-04-06T19:54:32  <luke-jr> I had just done that change >_<
439 2020-04-06T19:54:48  *** bitcoin-git has joined #bitcoin-core-dev
440 2020-04-06T19:54:48  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18192: Bugfix: Wallet: Safely deal with change in the address book (master...bugfix_addressbook_change) https://github.com/bitcoin/bitcoin/pull/18192
441 2020-04-06T19:54:49  *** bitcoin-git has left #bitcoin-core-dev
442 2020-04-06T19:55:53  <MarcoFalke> Whoopsie
443 2020-04-06T19:56:03  <MarcoFalke> Missed the message on IRC
444 2020-04-06T19:57:23  <MarcoFalke> At least the three ACKs weren't invalidated 😅
445 2020-04-06T19:58:30  *** bitcoin-git has joined #bitcoin-core-dev
446 2020-04-06T19:58:30  <bitcoin-git> [bitcoin] luke-jr opened pull request #18546: Bugfix: Wallet: Safely deal with change in the address book [part 2] (master...bugfix_addressbook_change) https://github.com/bitcoin/bitcoin/pull/18546
447 2020-04-06T19:58:41  *** bitcoin-git has left #bitcoin-core-dev
448 2020-04-06T20:02:30  *** jarthur has joined #bitcoin-core-dev
449 2020-04-06T20:23:10  *** bitcoin-git has joined #bitcoin-core-dev
450 2020-04-06T20:23:10  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c5966a87d1fd...abc145c9a4ae
451 2020-04-06T20:23:10  <bitcoin-git> bitcoin/master fa2251d MarcoFalke: test: Use one node to avoid a race due to missing sync in rpc_signrawtrans...
452 2020-04-06T20:23:11  <bitcoin-git> bitcoin/master abc145c MarcoFalke: Merge #18543: test: Use one node to avoid a race due to missing sync in rp...
453 2020-04-06T20:23:12  *** bitcoin-git has left #bitcoin-core-dev
454 2020-04-06T20:23:25  *** bitcoin-git has joined #bitcoin-core-dev
455 2020-04-06T20:23:25  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18543: test: Use one node to avoid a race due to missing sync in rpc_signrawtransaction (master...2004-testFixes) https://github.com/bitcoin/bitcoin/pull/18543
456 2020-04-06T20:23:26  *** bitcoin-git has left #bitcoin-core-dev
457 2020-04-06T20:26:24  *** Krellan_ has quit IRC
458 2020-04-06T20:26:27  *** Guyver2 has quit IRC
459 2020-04-06T20:26:53  *** Krellan_ has joined #bitcoin-core-dev
460 2020-04-06T20:31:36  *** Chris_Stewart_5 has quit IRC
461 2020-04-06T20:32:41  *** Krellan_ has quit IRC
462 2020-04-06T20:42:03  *** ddustin_ has quit IRC
463 2020-04-06T20:42:42  *** ddustin has joined #bitcoin-core-dev
464 2020-04-06T20:51:48  *** bitcoin-git has joined #bitcoin-core-dev
465 2020-04-06T20:51:48  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18507: test: Check that calling walletpasshprase does not freeze the node (master...2004-qaWalletFreeze) https://github.com/bitcoin/bitcoin/pull/18507
466 2020-04-06T20:51:49  *** bitcoin-git has left #bitcoin-core-dev
467 2020-04-06T20:54:54  <MarcoFalke> ok, we fixed all bugs! Ship it!?!
468 2020-04-06T20:59:48  *** dr-orlovsky has joined #bitcoin-core-dev
469 2020-04-06T20:59:54  <sipa> MarcoFalke: do we use -use_value_profile=1 anywhere in fuzzing?
470 2020-04-06T21:00:02  *** FalconKirtaran has quit IRC
471 2020-04-06T21:02:02  <MarcoFalke> sipa: It is a run-time flag you can enable when searching for seeds. It doesn't help when merely iterating over existing seeds (this is what travis is doing)
472 2020-04-06T21:02:17  <sipa> MarcoFalke: sure
473 2020-04-06T21:02:43  <sipa> but the seeds we have in in qa-assets directory, are they produced with that option enabled?
474 2020-04-06T21:03:18  <MarcoFalke> I didn't know the option exists until you told me about it ;)
475 2020-04-06T21:03:31  *** emilengler has quit IRC
476 2020-04-06T21:03:36  <sipa> it seems oss-fuzz uses it for a percentage of their runs
477 2020-04-06T21:03:43  <sipa> and always when -merge=1'ing
478 2020-04-06T21:04:00  <MarcoFalke> oh, hmm
479 2020-04-06T21:05:11  <MarcoFalke> We don't so we should maybe fix that: use_value_profile
480 2020-04-06T21:05:17  <sipa> with the fuzzer for asmap i've been working on, it seems that without that option, you very quickly converge on a set of seeds where no NEW lines appear anymore (or very rarely)
481 2020-04-06T21:06:06  <sipa> my intuition is that for actual testing this option isn't very useful
482 2020-04-06T21:06:13  <MarcoFalke> https://github.com/bitcoin/bitcoin/blob/abc145c9a4aef8ec269b7e0a3e9403cff9970fe4/test/fuzz/test_runner.py#L149
483 2020-04-06T21:06:20  <MarcoFalke> This is what I wanted to copy-paste
484 2020-04-06T21:06:45  <MarcoFalke> For some reason I can only copy one thing with the clipboard and then have to restart :thinking:
485 2020-04-06T21:06:55  <sipa> but it may help find "intermediate" fuzzer inputs that have a better chance of being mutated into useful ones
486 2020-04-06T21:08:02  *** manantial has quit IRC
487 2020-04-06T21:08:39  <MarcoFalke> Yes, I suspect it should help with structs that have state and already full line coverage
488 2020-04-06T21:09:28  <sipa> the default feature set tracker (without -use_value_profile) is already much wider than just coverage in the typical sense, i believe
489 2020-04-06T21:09:36  <sipa> use_value_profile expands it further
490 2020-04-06T21:14:28  <luke-jr> ugh, moving on, I'm beginning to question that address book bugfix (it's still safe/good, but not something we can rely on really)
491 2020-04-06T21:16:47  *** jarthur has quit IRC
492 2020-04-06T21:18:51  *** jarthur has joined #bitcoin-core-dev
493 2020-04-06T21:20:35  <MarcoFalke> Just used use_value_profile on a toy example and it seems to slow down the fuzzing and make it take longer to find my hidden crash. Obviously my toy example isn't representative, but it shouldn't be enabled for all searches.
494 2020-04-06T21:21:13  <sipa> agree
495 2020-04-06T21:21:31  *** nevada-smith has joined #bitcoin-core-dev
496 2020-04-06T21:21:41  *** dr-orlovsky has quit IRC
497 2020-04-06T21:28:48  *** jarthur has quit IRC
498 2020-04-06T21:34:26  *** Chris_Stewart_5 has joined #bitcoin-core-dev
499 2020-04-06T21:40:39  *** jarthur has joined #bitcoin-core-dev
500 2020-04-06T21:42:25  *** Krellan_ has joined #bitcoin-core-dev
501 2020-04-06T21:42:40  <sipa> ryanofsky: making sure you don't miss this: https://github.com/bitcoin/bitcoin/pull/18524/files#r404395685
502 2020-04-06T21:44:26  <ryanofsky> thanks, will fix
503 2020-04-06T21:47:31  *** bitcoin-git has joined #bitcoin-core-dev
504 2020-04-06T21:47:31  <bitcoin-git> [bitcoin] hebasto opened pull request #18549: qt: Fix Window -> Minimize menu item (master...20200406-fix-minimize) https://github.com/bitcoin/bitcoin/pull/18549
505 2020-04-06T21:47:36  *** bitcoin-git has left #bitcoin-core-dev
506 2020-04-06T21:48:14  *** Talkless has quit IRC
507 2020-04-06T21:48:43  *** sdaftuar_ has quit IRC
508 2020-04-06T21:49:12  *** Krellan_ has quit IRC
509 2020-04-06T21:49:52  <hebasto> promag: ^
510 2020-04-06T21:51:37  *** sdaftuar_ has joined #bitcoin-core-dev
511 2020-04-06T21:53:47  *** Chris_Stewart_5 has quit IRC
512 2020-04-06T21:59:00  *** filchef has quit IRC
513 2020-04-06T22:09:20  *** dviola has quit IRC
514 2020-04-06T22:11:13  *** dviola has joined #bitcoin-core-dev
515 2020-04-06T22:11:52  *** wullon has quit IRC
516 2020-04-06T22:13:28  *** wullon has joined #bitcoin-core-dev
517 2020-04-06T22:28:15  *** provoostenator has quit IRC
518 2020-04-06T22:28:56  *** provoostenator has joined #bitcoin-core-dev
519 2020-04-06T22:35:19  *** Krellan_ has joined #bitcoin-core-dev
520 2020-04-06T22:42:17  *** Krellan_ has quit IRC
521 2020-04-06T22:56:14  *** justanotheruser has quit IRC
522 2020-04-06T22:57:23  *** captjakk has quit IRC
523 2020-04-06T23:02:15  *** luke-jr has quit IRC
524 2020-04-06T23:02:36  *** luke-jr has joined #bitcoin-core-dev
525 2020-04-06T23:06:10  *** captjakk has joined #bitcoin-core-dev
526 2020-04-06T23:08:27  *** murray has joined #bitcoin-core-dev
527 2020-04-06T23:08:50  *** murray is now known as Guest73993
528 2020-04-06T23:10:51  *** SiAnDoG__ has joined #bitcoin-core-dev
529 2020-04-06T23:11:20  *** SiAnDoG_ has quit IRC
530 2020-04-06T23:12:40  *** owowo has quit IRC
531 2020-04-06T23:13:18  *** justanotheruser has joined #bitcoin-core-dev
532 2020-04-06T23:14:05  *** Guest73993 has left #bitcoin-core-dev
533 2020-04-06T23:14:07  *** Krellan_ has joined #bitcoin-core-dev
534 2020-04-06T23:14:40  *** murrayn has joined #bitcoin-core-dev
535 2020-04-06T23:18:04  *** owowo has joined #bitcoin-core-dev
536 2020-04-06T23:18:04  *** owowo has joined #bitcoin-core-dev
537 2020-04-06T23:21:22  *** Krellan_ has quit IRC
538 2020-04-06T23:23:04  *** captjakk has quit IRC
539 2020-04-06T23:23:18  *** marcoagner has quit IRC
540 2020-04-06T23:32:29  *** ddustin has quit IRC
541 2020-04-06T23:40:31  *** bitcoin-git has joined #bitcoin-core-dev
542 2020-04-06T23:40:31  <bitcoin-git> [bitcoin] luke-jr opened pull request #18550: Store destdata for change in separate key for backward compatibility (master...changedata) https://github.com/bitcoin/bitcoin/pull/18550
543 2020-04-06T23:40:44  *** bitcoin-git has left #bitcoin-core-dev
544 2020-04-06T23:41:07  <luke-jr> ^ this feels like it really needs tests, but I'm not sure what the best way to do that is, since it's all about compatibility with older versions
545 2020-04-06T23:51:25  *** Krellan_ has joined #bitcoin-core-dev