1 2020-04-08T00:00:01  *** simonbusborg has quit IRC
  2 2020-04-08T00:16:15  *** Bille has joined #bitcoin-core-dev
  3 2020-04-08T00:58:45  *** dviola has quit IRC
  4 2020-04-08T01:00:27  *** dviola has joined #bitcoin-core-dev
  5 2020-04-08T01:02:25  *** dviola has left #bitcoin-core-dev
  6 2020-04-08T01:02:47  *** dviola has joined #bitcoin-core-dev
  7 2020-04-08T01:36:56  *** owowo has quit IRC
  8 2020-04-08T01:42:37  *** anditto has joined #bitcoin-core-dev
  9 2020-04-08T01:56:05  *** jarthur_ has joined #bitcoin-core-dev
 10 2020-04-08T01:59:42  *** jarthur has quit IRC
 11 2020-04-08T02:03:45  *** jarthur_ has quit IRC
 12 2020-04-08T02:05:04  *** jarthur has joined #bitcoin-core-dev
 13 2020-04-08T02:12:25  *** anditto has quit IRC
 14 2020-04-08T02:12:54  *** anditto has joined #bitcoin-core-dev
 15 2020-04-08T02:17:38  *** anditto has quit IRC
 16 2020-04-08T02:17:56  *** glooooooo has quit IRC
 17 2020-04-08T02:23:37  *** Highway61 has quit IRC
 18 2020-04-08T02:24:16  *** fearbeag has joined #bitcoin-core-dev
 19 2020-04-08T02:26:25  *** belcher has quit IRC
 20 2020-04-08T02:30:31  *** fearbeag has quit IRC
 21 2020-04-08T02:32:01  *** Krellan_ has joined #bitcoin-core-dev
 22 2020-04-08T02:53:35  *** owowo has joined #bitcoin-core-dev
 23 2020-04-08T03:00:01  *** Bille has quit IRC
 24 2020-04-08T03:18:29  *** aljungberg has joined #bitcoin-core-dev
 25 2020-04-08T03:20:58  *** tryphe has quit IRC
 26 2020-04-08T03:21:01  *** tryphe_ has joined #bitcoin-core-dev
 27 2020-04-08T03:21:14  *** tryphe_ is now known as tryphe
 28 2020-04-08T03:28:25  *** anditto has joined #bitcoin-core-dev
 29 2020-04-08T03:32:27  *** EagleTM has joined #bitcoin-core-dev
 30 2020-04-08T03:33:14  *** Eagle[TM] has quit IRC
 31 2020-04-08T03:34:29  *** Krellan_ has quit IRC
 32 2020-04-08T03:56:08  *** AaronvanW has quit IRC
 33 2020-04-08T03:58:05  *** anditto has quit IRC
 34 2020-04-08T03:58:33  *** anditto has joined #bitcoin-core-dev
 35 2020-04-08T04:03:22  *** anditto has quit IRC
 36 2020-04-08T04:05:31  *** anditto has joined #bitcoin-core-dev
 37 2020-04-08T04:26:40  *** anditto has quit IRC
 38 2020-04-08T04:51:55  *** go11111111111 has joined #bitcoin-core-dev
 39 2020-04-08T04:54:18  *** go121212 has quit IRC
 40 2020-04-08T05:01:07  *** jarthur has quit IRC
 41 2020-04-08T05:11:09  *** Kiminuo has quit IRC
 42 2020-04-08T05:14:23  *** sdaftuar_ has quit IRC
 43 2020-04-08T05:20:09  *** Kiminuo has joined #bitcoin-core-dev
 44 2020-04-08T05:21:30  *** AaronvanW has joined #bitcoin-core-dev
 45 2020-04-08T05:22:15  *** sdaftuar_ has joined #bitcoin-core-dev
 46 2020-04-08T05:31:29  *** Krellan_ has joined #bitcoin-core-dev
 47 2020-04-08T05:37:52  *** Krellan_ has quit IRC
 48 2020-04-08T05:42:02  *** jarthur has joined #bitcoin-core-dev
 49 2020-04-08T05:55:51  *** AaronvanW has quit IRC
 50 2020-04-08T06:00:02  *** aljungberg has quit IRC
 51 2020-04-08T06:13:05  *** shesek has quit IRC
 52 2020-04-08T06:21:02  *** RiscTaker has joined #bitcoin-core-dev
 53 2020-04-08T06:33:47  *** jarthur has quit IRC
 54 2020-04-08T06:54:33  *** years_ has joined #bitcoin-core-dev
 55 2020-04-08T07:04:43  *** years_ has left #bitcoin-core-dev
 56 2020-04-08T07:15:45  *** manantial has joined #bitcoin-core-dev
 57 2020-04-08T07:17:02  *** justanotheruser has quit IRC
 58 2020-04-08T07:33:58  *** Krellan_ has joined #bitcoin-core-dev
 59 2020-04-08T07:38:29  *** Krellan_ has quit IRC
 60 2020-04-08T07:41:08  *** vasild_ has joined #bitcoin-core-dev
 61 2020-04-08T07:44:03  *** vasild has quit IRC
 62 2020-04-08T07:44:04  *** vasild_ is now known as vasild
 63 2020-04-08T07:53:09  *** AaronvanW has joined #bitcoin-core-dev
 64 2020-04-08T07:57:17  *** filchef has joined #bitcoin-core-dev
 65 2020-04-08T08:09:43  *** marcoagner has joined #bitcoin-core-dev
 66 2020-04-08T08:10:10  *** goatpig has joined #bitcoin-core-dev
 67 2020-04-08T08:10:20  <goatpig> hello
 68 2020-04-08T08:10:47  <goatpig> is there a requirement to set the tx version to 2 for native segwit?
 69 2020-04-08T08:12:56  *** Talkless has joined #bitcoin-core-dev
 70 2020-04-08T08:13:28  <sipa> no
 71 2020-04-08T08:13:49  <goatpig> is there any requirement on tx version at all?
 72 2020-04-08T08:13:57  <goatpig> ive always made mine with 1
 73 2020-04-08T08:14:00  <goatpig> sw or not
 74 2020-04-08T08:14:47  *** Guyver2 has joined #bitcoin-core-dev
 75 2020-04-08T08:17:22  <sipa> BIP 68 requires version 2
 76 2020-04-08T08:17:34  <goatpig> oh thanks
 77 2020-04-08T08:19:26  *** votesmith has joined #bitcoin-core-dev
 78 2020-04-08T08:21:18  *** AaronvanW has quit IRC
 79 2020-04-08T08:21:34  *** AaronvanW has joined #bitcoin-core-dev
 80 2020-04-08T08:37:03  *** kristapsk has quit IRC
 81 2020-04-08T09:00:02  *** RiscTaker has quit IRC
 82 2020-04-08T09:04:23  *** sdaftuar_ has quit IRC
 83 2020-04-08T09:04:38  *** DeanWeen has quit IRC
 84 2020-04-08T09:05:00  *** DeanWeen has joined #bitcoin-core-dev
 85 2020-04-08T09:06:42  *** sdaftuar_ has joined #bitcoin-core-dev
 86 2020-04-08T09:08:12  *** emilengler has joined #bitcoin-core-dev
 87 2020-04-08T09:11:03  *** sdaftuar_ has quit IRC
 88 2020-04-08T09:20:32  *** Lestaty has joined #bitcoin-core-dev
 89 2020-04-08T09:20:56  *** Lestaty is now known as Guest93944
 90 2020-04-08T09:21:22  *** timothy has joined #bitcoin-core-dev
 91 2020-04-08T09:28:19  *** sdaftuar_ has joined #bitcoin-core-dev
 92 2020-04-08T09:34:40  *** Krellan_ has joined #bitcoin-core-dev
 93 2020-04-08T09:43:27  *** Krellan_ has quit IRC
 94 2020-04-08T10:03:54  *** Zora88Kuhic has joined #bitcoin-core-dev
 95 2020-04-08T10:10:32  <wumpus> hebasto: agree with replacing #18501
 96 2020-04-08T10:10:33  <gribble> https://github.com/bitcoin/bitcoin/issues/18501 | build: Fix boost detection on Ubuntu ARM 18.04 by hebasto · Pull Request #18501 · bitcoin/bitcoin · GitHub
 97 2020-04-08T10:18:53  *** Krellan_ has joined #bitcoin-core-dev
 98 2020-04-08T10:23:21  *** Krellan_ has quit IRC
 99 2020-04-08T10:34:43  *** AaronvanW has quit IRC
100 2020-04-08T10:39:59  <Talkless> Could it be "controversial" to implement addrindex, so that other third party wallets (like Electrum) would not need intermediary server (like Electrumx) to make it work? It could access all info via Bitcoin RPC instead.
101 2020-04-08T10:40:03  <Talkless> Would it*
102 2020-04-08T10:45:07  *** lucaferr has quit IRC
103 2020-04-08T10:50:44  *** molly has joined #bitcoin-core-dev
104 2020-04-08T10:52:00  *** bitcoin-git has joined #bitcoin-core-dev
105 2020-04-08T10:52:01  <bitcoin-git> [bitcoin] hebasto opened pull request #18558: build: Fix boost detection for arch armv7l (master...20200408-boost-arm) https://github.com/bitcoin/bitcoin/pull/18558
106 2020-04-08T10:52:02  *** bitcoin-git has left #bitcoin-core-dev
107 2020-04-08T10:52:31  *** bitcoin-git has joined #bitcoin-core-dev
108 2020-04-08T10:52:31  <bitcoin-git> [bitcoin] hebasto closed pull request #18501: build: Fix boost detection on Ubuntu ARM 18.04 (master...20200402-boost-arm) https://github.com/bitcoin/bitcoin/pull/18501
109 2020-04-08T10:52:32  *** bitcoin-git has left #bitcoin-core-dev
110 2020-04-08T10:52:41  <hebasto> wumpus: done
111 2020-04-08T10:54:08  *** mol has quit IRC
112 2020-04-08T10:57:13  *** Zora88Kuhic has quit IRC
113 2020-04-08T11:08:01  *** kristapsk has joined #bitcoin-core-dev
114 2020-04-08T11:08:52  *** modfort has joined #bitcoin-core-dev
115 2020-04-08T11:23:20  *** Highway61 has joined #bitcoin-core-dev
116 2020-04-08T11:25:25  <jonasschnelli> Talkless: there where plenty of discussions about indexes in the past. AFAIK it looks like the tone among developers is to support an address index for the UTXO set but not a full including spent index.
117 2020-04-08T11:26:16  <jonasschnelli> Using and relying an address index does probably indicate conceptual issue
118 2020-04-08T11:26:23  *** kristapsk has quit IRC
119 2020-04-08T11:26:26  <jonasschnelli> (like centralised validation)
120 2020-04-08T11:27:15  <jonasschnelli> With multiwallet and enforced watch-only support, I think using Bitcoin Core as a backand for personal wallets is possible/fine.
121 2020-04-08T11:28:11  <jonasschnelli> Some glue code is today necessary (to speak stratum/electrum, have hardened endpoint). Look at software like EPS (electrum personal server) from belcher.
122 2020-04-08T11:28:22  <Talkless> jonasschnelli: what centralized? If I have my own full node, and I want some software to access it's address index via RPC (I'm not about peer services), how's that centralzied?
123 2020-04-08T11:28:49  <Talkless> I know EPS and ElectrumX, the point is to get rid fo these extra hassle
124 2020-04-08T11:28:57  <jonasschnelli> Talkless: why would you need to index the whole blockchain if you just query a handful of addresses for your personal wallets?
125 2020-04-08T11:29:45  <Talkless> I run txindex of "whole" blockhain too
126 2020-04-08T11:29:59  <Talkless> It doesn't have to be only for my own wallet
127 2020-04-08T11:30:01  <jonasschnelli> Talkless: Ideally we get rid of those "in-between" servers. But there are no plans to add an hardened API that allows exposing to the broader internet (which is the main concern IMO)
128 2020-04-08T11:30:10  <Talkless> this feature could be used for self-hosted explorers, etc.
129 2020-04-08T11:30:19  <jonasschnelli> Talkless: so yes. That's why I said "centralised" validation.
130 2020-04-08T11:30:26  <Talkless> jonasschnelli: I'm about RPC, not peer services, again :)
131 2020-04-08T11:30:46  <jonasschnelli> RPC should not be exposed to the broad internet!
132 2020-04-08T11:30:49  <Talkless> yes
133 2020-04-08T11:31:06  <Talkless> I speak if you have your own full node, and your own Elecrum wallet (or whatever)
134 2020-04-08T11:31:24  <Talkless> you setup your Electum to conenct to your node via RPC credentials, and that's it!
135 2020-04-08T11:31:25  <jonasschnelli> I see the usecase for a personal block explorer. But IMO you should use third party software for this. There is no need to add complex indexing to the software that provides also the Bitcoin consensus protocol.
136 2020-04-08T11:31:33  <Talkless> now I need to setup ElectrumX or EPS or whatever in between
137 2020-04-08T11:31:51  <Talkless> This is not the consesus protocol, it's RPC! :)
138 2020-04-08T11:31:57  <Talkless> or am I missing something
139 2020-04-08T11:32:01  <jonasschnelli> EPS / ElectrumX are currently your endpoints (authentication, hardening, anti DDOS).
140 2020-04-08T11:32:02  <jonasschnelli> We can't have that in Bitcoin-Core
141 2020-04-08T11:32:10  <jonasschnelli> No. It's not consensus.
142 2020-04-08T11:32:39  <jonasschnelli> But if we add a such index (that has no broader use case), we would add it into the same software that also provides the consensus protocol. Thus. Developer resources, etc.
143 2020-04-08T11:33:06  <Talkless> jonasschnelli: does txindex has no broaeder use case too?
144 2020-04-08T11:33:14  <Talkless> i.e. txindex vs addrindex
145 2020-04-08T11:33:40  <Talkless> "EPS / ElectrumX are currently your endpoints" yes, and I am just thinking if it's possible to get rid of them
146 2020-04-08T11:34:03  <Talkless> And it seems we would need address index inside Core to do that
147 2020-04-08T11:34:06  <jonasschnelli> txindex is a relict and a development feature. I think no productive software should ultimatively rely on it
148 2020-04-08T11:34:32  <Talkless> Core also provides fee info via RPC, so with full set, no extra intermediaey local servers would b eneeded, just bitcoind + Electurm
149 2020-04-08T11:34:59  <jonasschnelli> Even if Bitcoin Core would have a such full address index,... I think it would be naive to also add the endpoint with all the required httpd hardening and authentication methods.
150 2020-04-08T11:35:13  <Talkless> no, no endpoint
151 2020-04-08T11:35:18  <Talkless> just same RPC we have now with auth
152 2020-04-08T11:35:21  <Talkless> just for local use
153 2020-04-08T11:35:30  <jonasschnelli> I totally get your point. But we have limited resources. We can't add everything into one package.
154 2020-04-08T11:35:39  <Talkless> not PUBLIC endpoint like peer servics, that is*
155 2020-04-08T11:35:49  <Talkless> if you want you can publish your RPC ports, if you into it.. :)
156 2020-04-08T11:36:10  <jonasschnelli> If it would be on the same RPC level, you still need an additional server that provides TLS, authentication, etc.
157 2020-04-08T11:36:26  <Talkless> jonasschnelli: of course, I understand, but if someone (me or whatever) would consider adding -addrindex, how it would be contraveral, "doable".
158 2020-04-08T11:36:28  <jonasschnelli> then the question remains, why not use EPS/ElectrumX anyways?
159 2020-04-08T11:36:48  <jonasschnelli> Talkless: I don't understand your last message
160 2020-04-08T11:36:52  <Talkless> It's extra software to trust, update, install, etc..
161 2020-04-08T11:38:02  <jonasschnelli> But as long as Core has no http server that can be exposed to the public, you won't get rid of that extra software/trust?
162 2020-04-08T11:38:05  <Talkless> jonasschnelli: I understand that there are limited dev. resources and I am not asking for some one to implement. Let's say hypothetically I would like to impelment it (or pay someone), how it would be reasonable to ask to merge it, how controversal that would be
163 2020-04-08T11:38:25  <Talkless> I don't know why you keep talking about http server :/
164 2020-04-08T11:38:50  <jonasschnelli> I can't say that for sure. But the past has shown that full indexes required to get rid of electrumX have little chance to get merged
165 2020-04-08T11:38:55  * jonasschnelli looking for past PRs
166 2020-04-08T11:38:55  <Talkless> I have LOCAL full node, LOCAL electrum wallet, I would like that my (and only my) local electrum wallet would connect DIRECTLY to that local bitcoin full node via RPC and could work just like that
167 2020-04-08T11:39:12  <jonasschnelli> run EPS. :)
168 2020-04-08T11:39:14  <Talkless> I'm not suggesting to add public peer service accessible for everyone, like ElecrurmX server does.
169 2020-04-08T11:39:38  <jonasschnelli> Or add the Core RPC protocol to electrum (so it could not only speak stratum/electrum it could also use Core directly to fetch data)
170 2020-04-08T11:39:39  <Talkless> it's still another software to maintain
171 2020-04-08T11:39:50  <jonasschnelli> Maybe it's simpler to tell electrum to speak with core
172 2020-04-08T11:39:58  <Talkless> jonasschnelli: electrum needs address info, which is provided by ElectrumX
173 2020-04-08T11:40:17  <Talkless> jonasschnelli: yes that's the idea, that electrum would speek to core, but it needs one extra index! :)
174 2020-04-08T11:40:17  <jonasschnelli> No on a conceptual layer
175 2020-04-08T11:40:25  <fjahr> @Talkless have you checked out previous attempts to add this index? See for example #14053 which is still active and bitcoin core reviews session https://bitcoincore.reviews/14053.html. If you haven't seen it I think it will provide more context on the issues.
176 2020-04-08T11:40:28  <gribble> https://github.com/bitcoin/bitcoin/issues/14053 | Add address-based index (attempt 4?) by marcinja · Pull Request #14053 · bitcoin/bitcoin · GitHub
177 2020-04-08T11:40:32  <jonasschnelli> Electrum needs a backand that can get transaction for a specific set of addresses
178 2020-04-08T11:40:39  <Talkless> No I haven't seen.
179 2020-04-08T11:40:43  <jonasschnelli> a full index is 99% wasted data for a personal wallet
180 2020-04-08T11:40:51  <jonasschnelli> That's why EPS works
181 2020-04-08T11:40:59  <jonasschnelli> EPS won't provide you a full index
182 2020-04-08T11:41:12  <jonasschnelli> It just makes Core speak "stratum" (the electrum protocol)
183 2020-04-08T11:41:20  <Talkless> jonasschnelli: it would be nice if EPS would be integrated as a "backend" withing Electrum, but now I need to setup extras softeware, it's just a hassle.
184 2020-04-08T11:41:46  <Talkless> jonasschnelli: you need to fiddlle with these xpubs and stuff, and I have multiple wallets...
185 2020-04-08T11:42:01  <Talkless> Anyway, I'll see that PR, thanks for that!
186 2020-04-08T11:42:12  <jonasschnelli> IMO a future version of a software acting like EPS could be a 500 line script that runs in a httpd-daemon process.
187 2020-04-08T11:42:58  <jonasschnelli> #14053 only adds an UTXO set address index (limited electrum feature set, no backup recivery with historical transaction).
188 2020-04-08T11:42:59  <Talkless> IMO it should be a swtich in Electum to select Electrum P2P or Bitcoin Core backend (which would use EPS within Electrum).
189 2020-04-08T11:43:01  <gribble> https://github.com/bitcoin/bitcoin/issues/14053 | Add address-based index (attempt 4?) by marcinja · Pull Request #14053 · bitcoin/bitcoin · GitHub
190 2020-04-08T11:44:18  <Talkless> jonasschnelli: alternative is just to wait until Bitcoin Qt has BIP39 support and easy HW wallet support, so I could just switch to Bitcoin Qt :)
191 2020-04-08T11:44:26  <jonasschnelli> #10370
192 2020-04-08T11:44:28  <gribble> https://github.com/bitcoin/bitcoin/issues/10370 | [pull request idea] addressindex, spentindex, timestampindex (Bitcore patches) by karel-3d · Pull Request #10370 · bitcoin/bitcoin · GitHub
193 2020-04-08T11:44:31  <jonasschnelli> ^^ (is the full index)
194 2020-04-08T11:44:39  <Talkless> oh cool
195 2020-04-08T11:44:51  <jonasschnelli> needs a non trivial rebase I guess
196 2020-04-08T11:45:38  <Talkless> yeahm 2017..
197 2020-04-08T11:46:12  <fjahr> thanks, the different versions of the index are discussed in the PR discussions of 14053 and the review club so it will still be interesting to check those out, especially since this is the most up to date perspective
198 2020-04-08T11:47:09  *** inoor has joined #bitcoin-core-dev
199 2020-04-08T11:48:02  <jonasschnelli> maybe 14053 could list some use cases. That would help a lot
200 2020-04-08T11:52:24  *** modfort has quit IRC
201 2020-04-08T12:00:02  *** Guest93944 has quit IRC
202 2020-04-08T12:19:20  *** Usurp1 has joined #bitcoin-core-dev
203 2020-04-08T12:21:20  <MarcoFalke> [02:38] <sipa> MarcoFalke or others: do you know what's going wrong here? https://travis-ci.org/github/bitcoin/bitcoin/jobs/671910152
204 2020-04-08T12:21:29  <MarcoFalke> Looks like a race in the test to me
205 2020-04-08T12:22:27  *** Krellan_ has joined #bitcoin-core-dev
206 2020-04-08T12:24:26  *** dr-orlovsky has joined #bitcoin-core-dev
207 2020-04-08T12:27:23  *** braydonf has quit IRC
208 2020-04-08T12:32:45  *** braydonf has joined #bitcoin-core-dev
209 2020-04-08T12:34:18  *** someone235 has joined #bitcoin-core-dev
210 2020-04-08T12:45:10  *** bitcoin-git has joined #bitcoin-core-dev
211 2020-04-08T12:45:12  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1b151e3ffce7...1f70185a8093
212 2020-04-08T12:45:12  <bitcoin-git> bitcoin/master 3c61abb Pieter Wuille: Do not clear validationinterface entries being executed
213 2020-04-08T12:45:13  <bitcoin-git> bitcoin/master 2276339 Russell Yanofsky: Add test for UnregisterAllValidationInterfaces bug
214 2020-04-08T12:45:14  <bitcoin-git> bitcoin/master 1f70185 MarcoFalke: Merge #18551: Do not clear validationinterface entries being executed
215 2020-04-08T12:45:16  *** bitcoin-git has left #bitcoin-core-dev
216 2020-04-08T12:45:30  *** bitcoin-git has joined #bitcoin-core-dev
217 2020-04-08T12:45:30  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18551: Do not clear validationinterface entries being executed (master...202004_fix_validation_notify_clear) https://github.com/bitcoin/bitcoin/pull/18551
218 2020-04-08T12:45:31  *** bitcoin-git has left #bitcoin-core-dev
219 2020-04-08T12:46:47  *** justanotheruser has joined #bitcoin-core-dev
220 2020-04-08T12:48:07  *** AaronvanW has joined #bitcoin-core-dev
221 2020-04-08T13:05:06  <hebasto> MarcoFalke: should I modify #18558 in any way when upstream is merged?
222 2020-04-08T13:05:07  <gribble> https://github.com/bitcoin/bitcoin/issues/18558 | build: Fix boost detection for arch armv7l by hebasto · Pull Request #18558 · bitcoin/bitcoin · GitHub
223 2020-04-08T13:06:03  <MarcoFalke> It is the same code, but the comment where it is from could be updated?
224 2020-04-08T13:06:27  *** Krellan_ has quit IRC
225 2020-04-08T13:06:37  *** ghost43_ has joined #bitcoin-core-dev
226 2020-04-08T13:07:17  <MarcoFalke> or just say it is the latest serial
227 2020-04-08T13:07:23  *** ghost43 has quit IRC
228 2020-04-08T13:07:42  <hebasto> in commit message, right?
229 2020-04-08T13:08:14  <MarcoFalke> yeah, it seems that is what people do if you `git log` on that file
230 2020-04-08T13:13:24  *** ghost43_ has quit IRC
231 2020-04-08T13:15:08  *** belcher has joined #bitcoin-core-dev
232 2020-04-08T13:15:15  *** ghost43 has joined #bitcoin-core-dev
233 2020-04-08T13:16:00  <hebasto> MarcoFalke: done; is it correct?
234 2020-04-08T13:18:27  <MarcoFalke> looks good (I've edited the comment on GitHub as well)
235 2020-04-08T13:19:29  <hebasto> cool
236 2020-04-08T13:23:06  *** dr-orlovsky has quit IRC
237 2020-04-08T13:24:23  *** braydonf has quit IRC
238 2020-04-08T13:35:29  *** kristapsk has joined #bitcoin-core-dev
239 2020-04-08T13:38:59  *** braydonf has joined #bitcoin-core-dev
240 2020-04-08T13:46:51  *** bitcoin-git has joined #bitcoin-core-dev
241 2020-04-08T13:46:51  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18561: test: Properly raise FailedToStartError when rpc shutdown before warmup finished (master...2004-qaFailedToStartConnectionReset) https://github.com/bitcoin/bitcoin/pull/18561
242 2020-04-08T13:46:52  *** bitcoin-git has left #bitcoin-core-dev
243 2020-04-08T13:47:05  <MarcoFalke> sipa: Fixed the race ^ (I think)
244 2020-04-08T13:50:11  <fanquake> 99% sure that #18551 broke the tests on windows
245 2020-04-08T13:50:13  <gribble> https://github.com/bitcoin/bitcoin/issues/18551 | Do not clear validationinterface entries being executed by sipa · Pull Request #18551 · bitcoin/bitcoin · GitHub
246 2020-04-08T13:51:19  <MarcoFalke> The test broke the tests on windows
247 2020-04-08T13:51:31  <MarcoFalke> Remove all the tests!
248 2020-04-08T13:51:45  <fanquake> Sure. Is our new merge policy just to merge things that are clearly broken heh
249 2020-04-08T13:52:20  <MarcoFalke> travis was green and appveyor is red already for days
250 2020-04-08T13:52:36  <fanquake> Yea, but the 1073740791 exit code is different.
251 2020-04-08T13:53:11  <fanquake> Regardless, the failure is "Expression !m_internals"
252 2020-04-08T13:53:19  <fanquake> In the validation interface test
253 2020-04-08T13:54:36  <MarcoFalke> huh, why would that hit only on windows?
254 2020-04-08T13:56:57  <MarcoFalke> oh, I see
255 2020-04-08T13:58:26  <MarcoFalke> It is probably because that global survises from the previous subtests
256 2020-04-08T13:59:15  <fanquake> That could be, because it looks like it passes when run by itself
257 2020-04-08T14:00:16  <fanquake> Another  case like #18018
258 2020-04-08T14:00:18  <gribble> https://github.com/bitcoin/bitcoin/issues/18018 | tests: reset fIsBareMultisigStd after bare-multisig tests by fanquake · Pull Request #18018 · bitcoin/bitcoin · GitHub
259 2020-04-08T14:00:43  <MarcoFalke> but setup_common calls UnregisterBackgroundSignalScheduler
260 2020-04-08T14:01:05  <MarcoFalke> but the test doesn't maybe?
261 2020-04-08T14:01:52  <MarcoFalke> will push a fix in a sec
262 2020-04-08T14:02:10  <MarcoFalke> Thanks for reproducing the failure fanquake
263 2020-04-08T14:03:57  *** ghost43 has quit IRC
264 2020-04-08T14:05:08  *** inoor has quit IRC
265 2020-04-08T14:05:14  *** ghost43 has joined #bitcoin-core-dev
266 2020-04-08T14:11:55  *** Kiminuo has quit IRC
267 2020-04-08T14:17:52  *** bitcoin-git has joined #bitcoin-core-dev
268 2020-04-08T14:17:52  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18562: 2004 qa fix test teardown (master...2004-qaFixTestTeardown) https://github.com/bitcoin/bitcoin/pull/18562
269 2020-04-08T14:17:53  *** bitcoin-git has left #bitcoin-core-dev
270 2020-04-08T14:19:03  *** goatpig has quit IRC
271 2020-04-08T14:19:12  *** bitcoin-git has joined #bitcoin-core-dev
272 2020-04-08T14:19:12  <bitcoin-git> [bitcoin] ryanofsky opened pull request #18563: test: Fix unregister_all_during_call cleanup (master...pr/valfix) https://github.com/bitcoin/bitcoin/pull/18563
273 2020-04-08T14:19:13  *** bitcoin-git has left #bitcoin-core-dev
274 2020-04-08T14:20:37  *** ghost43 has quit IRC
275 2020-04-08T14:21:55  *** ghost43 has joined #bitcoin-core-dev
276 2020-04-08T14:29:28  *** bitcoin-git has joined #bitcoin-core-dev
277 2020-04-08T14:29:29  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1f70185a8093...b3c3d9a518f8
278 2020-04-08T14:29:29  <bitcoin-git> bitcoin/master da0842d Hennadii Stepanov: build: Update ax_boost_mase.m4 to the latest serial
279 2020-04-08T14:29:30  <bitcoin-git> bitcoin/master b3c3d9a Wladimir J. van der Laan: Merge #18558: build: Fix boost detection for arch armv7l
280 2020-04-08T14:29:32  *** bitcoin-git has left #bitcoin-core-dev
281 2020-04-08T14:29:48  *** bitcoin-git has joined #bitcoin-core-dev
282 2020-04-08T14:29:48  <bitcoin-git> [bitcoin] laanwj merged pull request #18558: build: Fix boost detection for arch armv7l (master...20200408-boost-arm) https://github.com/bitcoin/bitcoin/pull/18558
283 2020-04-08T14:29:50  *** bitcoin-git has left #bitcoin-core-dev
284 2020-04-08T14:38:14  <MarcoFalke> looks like travis is down and not booting any machines
285 2020-04-08T14:38:57  *** bitcoin-git has joined #bitcoin-core-dev
286 2020-04-08T14:38:58  <bitcoin-git> [bitcoin] jimbo313 opened pull request #18564: 0.19 (master...0.19) https://github.com/bitcoin/bitcoin/pull/18564
287 2020-04-08T14:38:59  *** bitcoin-git has left #bitcoin-core-dev
288 2020-04-08T14:42:45  *** molly has quit IRC
289 2020-04-08T14:42:58  *** bitcoin-git has joined #bitcoin-core-dev
290 2020-04-08T14:42:58  <bitcoin-git> [bitcoin] laanwj closed pull request #18564: 0.19 (master...0.19) https://github.com/bitcoin/bitcoin/pull/18564
291 2020-04-08T14:42:59  *** bitcoin-git has left #bitcoin-core-dev
292 2020-04-08T14:47:10  *** bitcoin-git has joined #bitcoin-core-dev
293 2020-04-08T14:47:11  <bitcoin-git> [bitcoin] practicalswift opened pull request #18565: tests: Add fuzzing harnesses for classes/functions in policy/fees.h, checkqueue.h and cuckoocache.h. Add fuzzing coverage. (master...fuzzers-2020-04-07) https://github.com/bitcoin/bitcoin/pull/18565
294 2020-04-08T14:47:11  *** bitcoin-git has left #bitcoin-core-dev
295 2020-04-08T15:00:01  *** Usurp1 has quit IRC
296 2020-04-08T15:02:32  *** AaronvanW has quit IRC
297 2020-04-08T15:04:14  *** hebasto has quit IRC
298 2020-04-08T15:04:28  *** Krellan_ has joined #bitcoin-core-dev
299 2020-04-08T15:07:31  *** hebasto has joined #bitcoin-core-dev
300 2020-04-08T15:07:40  *** ghost43 has quit IRC
301 2020-04-08T15:08:38  *** alec has quit IRC
302 2020-04-08T15:08:57  *** ghost43 has joined #bitcoin-core-dev
303 2020-04-08T15:13:54  *** alec has joined #bitcoin-core-dev
304 2020-04-08T15:20:39  *** NS-DonaldL has joined #bitcoin-core-dev
305 2020-04-08T15:25:53  *** mol has joined #bitcoin-core-dev
306 2020-04-08T15:26:36  *** ghost43 has quit IRC
307 2020-04-08T15:26:48  *** bitcoin-git has joined #bitcoin-core-dev
308 2020-04-08T15:26:49  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b3c3d9a518f8...2392566284d8
309 2020-04-08T15:26:49  <bitcoin-git> bitcoin/master 13d2a33 Russell Yanofsky: Fix unregister_all_during_call cleanup
310 2020-04-08T15:26:50  <bitcoin-git> bitcoin/master 2392566 MarcoFalke: Merge #18563: test: Fix unregister_all_during_call cleanup
311 2020-04-08T15:26:52  *** bitcoin-git has left #bitcoin-core-dev
312 2020-04-08T15:26:56  *** ghost43 has joined #bitcoin-core-dev
313 2020-04-08T15:27:08  *** bitcoin-git has joined #bitcoin-core-dev
314 2020-04-08T15:27:08  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18563: test: Fix unregister_all_during_call cleanup (master...pr/valfix) https://github.com/bitcoin/bitcoin/pull/18563
315 2020-04-08T15:27:09  *** bitcoin-git has left #bitcoin-core-dev
316 2020-04-08T15:27:28  *** bitcoin-git has joined #bitcoin-core-dev
317 2020-04-08T15:27:28  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18562: ci: Run unit tests sequential once (master...2004-qaFixTestTeardown) https://github.com/bitcoin/bitcoin/pull/18562
318 2020-04-08T15:27:29  *** bitcoin-git has left #bitcoin-core-dev
319 2020-04-08T15:27:48  *** bitcoin-git has joined #bitcoin-core-dev
320 2020-04-08T15:27:48  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18562: ci: Run unit tests sequential once (master...2004-qaFixTestTeardown) https://github.com/bitcoin/bitcoin/pull/18562
321 2020-04-08T15:27:49  *** bitcoin-git has left #bitcoin-core-dev
322 2020-04-08T15:28:23  *** marcoagner has quit IRC
323 2020-04-08T15:29:31  *** marcoagner has joined #bitcoin-core-dev
324 2020-04-08T15:37:18  *** Krellan_ has quit IRC
325 2020-04-08T15:41:18  *** AaronvanW has joined #bitcoin-core-dev
326 2020-04-08T15:43:50  *** justanotheruser has quit IRC
327 2020-04-08T15:44:59  *** bitcoin-git has joined #bitcoin-core-dev
328 2020-04-08T15:44:59  <bitcoin-git> [bitcoin] MarcoFalke pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/2392566284d8...bfef72d0fb02
329 2020-04-08T15:45:00  <bitcoin-git> bitcoin/master 44fb2a5 practicalswift: tests: Add fuzzing harness for FeeFilterRounder
330 2020-04-08T15:45:00  <bitcoin-git> bitcoin/master 7b9a2dc practicalswift: tests: Add fuzzing harness for AdditionOverflow(...)
331 2020-04-08T15:45:01  <bitcoin-git> bitcoin/master 2df5701 practicalswift: tests: Add coverage of GetVirtualTransactionSize(...) to existing fuzzer
332 2020-04-08T15:45:02  *** bitcoin-git has left #bitcoin-core-dev
333 2020-04-08T15:45:19  *** bitcoin-git has joined #bitcoin-core-dev
334 2020-04-08T15:45:19  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18565: tests: Add fuzzing harnesses for classes/functions in policy/fees.h, checkqueue.h and cuckoocache.h. Add fuzzing coverage. (master...fuzzers-2020-04-07) https://github.com/bitcoin/bitcoin/pull/18565
335 2020-04-08T15:45:20  *** bitcoin-git has left #bitcoin-core-dev
336 2020-04-08T15:53:51  *** Guyver2_ has joined #bitcoin-core-dev
337 2020-04-08T15:54:28  *** Guyver2 has quit IRC
338 2020-04-08T16:00:42  *** justanotheruser has joined #bitcoin-core-dev
339 2020-04-08T16:01:08  *** kasskash has joined #bitcoin-core-dev
340 2020-04-08T16:06:13  *** Guyver2_ is now known as Guyver2
341 2020-04-08T16:08:31  *** kasskash has quit IRC
342 2020-04-08T16:14:24  *** bitcoin-git has joined #bitcoin-core-dev
343 2020-04-08T16:14:25  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bfef72d0fb02...4c5923637653
344 2020-04-08T16:14:26  <bitcoin-git> bitcoin/master 7777e36 MarcoFalke: scripted-diff: Replace strCommand with msg_type
345 2020-04-08T16:14:27  <bitcoin-git> bitcoin/master 4c59236 MarcoFalke: Merge #18533: scripted-diff: Replace strCommand with msg_type
346 2020-04-08T16:14:29  *** bitcoin-git has left #bitcoin-core-dev
347 2020-04-08T16:14:44  *** bitcoin-git has joined #bitcoin-core-dev
348 2020-04-08T16:14:44  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18533: scripted-diff: Replace strCommand with msg_type (master...2004-netMsgType) https://github.com/bitcoin/bitcoin/pull/18533
349 2020-04-08T16:14:45  *** bitcoin-git has left #bitcoin-core-dev
350 2020-04-08T16:16:15  *** bitcoin-git has joined #bitcoin-core-dev
351 2020-04-08T16:16:15  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4c5923637653...3410fe688739
352 2020-04-08T16:16:16  <bitcoin-git> bitcoin/master fa6a008 MarcoFalke: fuzz: Add process_messages harness
353 2020-04-08T16:16:16  <bitcoin-git> bitcoin/master 3410fe6 MarcoFalke: Merge #18521: fuzz: Add process_messages harness
354 2020-04-08T16:16:18  *** bitcoin-git has left #bitcoin-core-dev
355 2020-04-08T16:16:36  *** bitcoin-git has joined #bitcoin-core-dev
356 2020-04-08T16:16:36  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18521: fuzz: Add process_messages harness (master...2004-fuzzMsgs) https://github.com/bitcoin/bitcoin/pull/18521
357 2020-04-08T16:16:37  *** bitcoin-git has left #bitcoin-core-dev
358 2020-04-08T16:23:07  *** andrewtoth_ has joined #bitcoin-core-dev
359 2020-04-08T16:24:03  *** andrewtoth has quit IRC
360 2020-04-08T16:29:23  *** andrewtoth_ has quit IRC
361 2020-04-08T16:32:57  *** jarthur has joined #bitcoin-core-dev
362 2020-04-08T16:46:23  *** andrewtoth has joined #bitcoin-core-dev
363 2020-04-08T16:53:04  *** bitcoin-git has joined #bitcoin-core-dev
364 2020-04-08T16:53:04  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18566: test: Set -use_value_profile=1 when merging fuzz inputs (master...2004-fuzzValueProfile) https://github.com/bitcoin/bitcoin/pull/18566
365 2020-04-08T16:53:05  *** bitcoin-git has left #bitcoin-core-dev
366 2020-04-08T16:54:09  *** michaelfolkson has joined #bitcoin-core-dev
367 2020-04-08T17:07:14  *** amsudeep has joined #bitcoin-core-dev
368 2020-04-08T17:09:39  *** jarthur has quit IRC
369 2020-04-08T17:10:05  *** jarthur has joined #bitcoin-core-dev
370 2020-04-08T17:10:10  *** bitcoin-git has joined #bitcoin-core-dev
371 2020-04-08T17:10:10  <bitcoin-git> [bitcoin] luke-jr closed pull request #18469: Build: Move wallet RPCs to their own libbitcoin_walletrpcs module (master...libbitcoin_walletrpcs) https://github.com/bitcoin/bitcoin/pull/18469
372 2020-04-08T17:10:11  *** bitcoin-git has left #bitcoin-core-dev
373 2020-04-08T17:17:03  *** kristapsk has quit IRC
374 2020-04-08T17:17:16  *** kristapsk has joined #bitcoin-core-dev
375 2020-04-08T17:17:24  *** rex4539 has joined #bitcoin-core-dev
376 2020-04-08T17:33:50  <sipa> #18451
377 2020-04-08T17:33:51  <gribble> https://github.com/bitcoin/bitcoin/issues/18451 | test: shift coverage from getunconfirmedbalance to getbalances by jonatack · Pull Request #18451 · bitcoin/bitcoin · GitHub
378 2020-04-08T17:34:57  *** Krellan_ has joined #bitcoin-core-dev
379 2020-04-08T17:34:58  *** marcoagner has quit IRC
380 2020-04-08T17:36:04  *** fearbeag has joined #bitcoin-core-dev
381 2020-04-08T17:37:25  *** marcoagner has joined #bitcoin-core-dev
382 2020-04-08T17:38:36  *** rex4539 has quit IRC
383 2020-04-08T17:48:47  *** Krellan_ has quit IRC
384 2020-04-08T18:00:02  *** NS-DonaldL has quit IRC
385 2020-04-08T18:05:04  *** Kiminuo has joined #bitcoin-core-dev
386 2020-04-08T18:16:47  *** mol has quit IRC
387 2020-04-08T18:16:54  <achow101> #proposedmeetingtopic deprecating signrawtx RPCs
388 2020-04-08T18:21:10  *** kik1 has joined #bitcoin-core-dev
389 2020-04-08T18:35:17  *** michaelfolkson has quit IRC
390 2020-04-08T18:46:47  *** SiAnDoG_ has joined #bitcoin-core-dev
391 2020-04-08T18:47:08  *** bitcoin-git has joined #bitcoin-core-dev
392 2020-04-08T18:47:09  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3410fe688739...661bd5dea3d0
393 2020-04-08T18:47:09  <bitcoin-git> bitcoin/master cdfb8e7 practicalswift: tests: Add fuzzing harness for HTTPRequest, libevent's evhttp and related ...
394 2020-04-08T18:47:09  <bitcoin-git> bitcoin/master 661bd5d MarcoFalke: Merge #18363: tests: Add fuzzing harness for HTTPRequest, libevent's evhtt...
395 2020-04-08T18:47:10  *** bitcoin-git has left #bitcoin-core-dev
396 2020-04-08T18:47:28  *** bitcoin-git has joined #bitcoin-core-dev
397 2020-04-08T18:47:29  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18363: tests: Add fuzzing harness for HTTPRequest, libevent's evhttp and related functions (master...fuzzers-http_request) https://github.com/bitcoin/bitcoin/pull/18363
398 2020-04-08T18:47:40  *** bitcoin-git has left #bitcoin-core-dev
399 2020-04-08T18:49:03  *** SiAnDoG has quit IRC
400 2020-04-08T18:50:09  *** mol has joined #bitcoin-core-dev
401 2020-04-08T18:51:13  *** michaelfolkson has joined #bitcoin-core-dev
402 2020-04-08T18:55:02  <wumpus> achow101: what would you want to replace them with?
403 2020-04-08T18:55:14  <achow101> psbt
404 2020-04-08T18:55:27  <achow101> obviously we would need some more psbt rpcs
405 2020-04-08T18:56:24  <sipa> wumpus: can we not rewrite the signraw* RPCs by having them effectively wrap PSBT internally?
406 2020-04-08T18:56:34  <sipa> as in: convert to PSBT, invoke PSBT signing logic, convert back?
407 2020-04-08T18:56:49  <wumpus> I think documentation is most important in that case, to have a clear overview for people using the old raw-transactions workflow what to do now, this is going to trip up a lot of users I think
408 2020-04-08T18:56:53  <wumpus> sipa: yes, or that
409 2020-04-08T18:56:58  <achow101> sipa: I gave that some thought, but some things still don't quite make sense
410 2020-04-08T18:57:19  <achow101> wumpus: I think what it would really be is mark it as deprecated, but don't remove it for a while. we have some RPCs like that currently
411 2020-04-08T18:58:01  <achow101> so people currently using signrawtx don't get hurt, but we push new people to use psbts
412 2020-04-08T18:58:36  <wumpus> achow101: deprecated RPCs tend to be removed really quickly nowadays (like the next release), maybe call it something else then, like "did you know about this better system? here's documentation which you could consider" … then only really deprecate it much later :)
413 2020-04-08T18:59:14  <MarcoFalke> Yeah, sometimes I wish we had a deprecated RPC cycle that lasted longer than just one release
414 2020-04-08T18:59:38  <sipa> the problem is we really have no good way to reach users except the -deprecatedrpc mechanism
415 2020-04-08T19:00:04  <MarcoFalke> Something like "this is deprecated now and will be -deprecatedrpc when the release that deprecated it is EOL"
416 2020-04-08T19:00:05  <sipa> if we just say "look there is something better now" in release notes or so... probably nobody will notice
417 2020-04-08T19:00:09  <wumpus> but that's just me, every deprecation means *all* software using that API needs to be updated, and sometimes that's a pain, not all open source software gets maintained that actively and there's a large variance in versions people run
418 2020-04-08T19:00:25  <MarcoFalke> Yes, what wumpus said
419 2020-04-08T19:00:34  <sipa> yeah, in particular signraw*... i think will be a pain for people
420 2020-04-08T19:00:49  <wumpus> yes, release notes are not documentation, you can certainly point to it from there, also mention it in the help of the RPC
421 2020-04-08T19:01:01  <MarcoFalke> And if you use a library that is unmaintained for as long as it takes for a Bitcoin core  release to go EOL, maybe you shouldn't use it
422 2020-04-08T19:01:02  <sipa> so i don't know what a good solution is
423 2020-04-08T19:01:11  <wumpus> if you need other ways to reach people well I can retweet things on the @bitcoincore twitter :p
424 2020-04-08T19:01:26  <sipa> send an alert message!
425 2020-04-08T19:01:30  <sipa> oh wait
426 2020-04-08T19:01:31  <wumpus> haha
427 2020-04-08T19:01:35  <achow101> when we removed signrawtransaction itself (replaced with signrawtransactionwithkey and signrawtransactionwithwallet), was there a lot of noise?
428 2020-04-08T19:01:45  <wumpus> I still mistype that one :(
429 2020-04-08T19:01:51  *** michaelfolkson has quit IRC
430 2020-04-08T19:01:52  <MarcoFalke> autocomplete
431 2020-04-08T19:01:59  <wumpus> signrawtransactionwithwallet is soo long
432 2020-04-08T19:02:04  <sipa> achow101: moving to PSBT is a bigger workflow change though
433 2020-04-08T19:02:07  <achow101> definitely could have been named better
434 2020-04-08T19:02:10  <MarcoFalke> I use the gui :see-no-evil"
435 2020-04-08T19:02:28  <wumpus> but apart from that, no, not that much noise about it I've noticed
436 2020-04-08T19:03:30  <achow101> the main thing is that signrawtx doesn't work super well with descriptor wallets. and wrapping it with psbts pretty much results in a half-assed psbt workflow but in the context of raw transactions
437 2020-04-08T19:04:23  <sipa> achow101: what's the reason for that?
438 2020-04-08T19:04:26  <wumpus> a lot of people are aware of PSBT as a thing now, but I'm not sure they know it as potential  replacement of the raw transactions API
439 2020-04-08T19:05:15  <achow101> sipa: the main symptom is with multisig. it's because in descriptor wallets, we're getting rid of the mixed watch only and non-watchonly in a single wallet
440 2020-04-08T19:05:33  <achow101> so if you have a multisig, you have one wallet with key(s) and another wallet that has the multisig as watchonly
441 2020-04-08T19:05:48  <achow101> with signrawtx, the wallet with the keys can't sign because it doesn't know the redeemScript
442 2020-04-08T19:06:02  <sipa> achow101: but the redeemscript is in the raw tx
443 2020-04-08T19:06:08  <achow101> so you have to go the multisig watchonly, do a signrawtx which (in theory) will just drop the redeemScript into the raw tx
444 2020-04-08T19:06:15  <achow101> then you go back to the wallet with the keys to sign
445 2020-04-08T19:06:17  <sipa> so in a convert-to-and-from PSBT, that would be retained
446 2020-04-08T19:06:29  <achow101> this process is the same thing as just using psbts, but hacking things into the raw tx format
447 2020-04-08T19:07:12  <achow101> it's still workflow breaking because you can't use a single wallet for keys and multisig and just do one command that does everything
448 2020-04-08T19:07:40  <sipa> achow101: imho it should be just possible to have the keys and descriptors in the same wallet
449 2020-04-08T19:07:50  <sipa> (but possibly in separate SPKmans)
450 2020-04-08T19:08:21  <achow101> that brings back the mixed watchonly thing though
451 2020-04-08T19:08:31  <sipa> how so?
452 2020-04-08T19:08:57  <sipa> this would be a wallet that does not watch payments to the individual keys, only to the multisig descriptor
453 2020-04-08T19:09:04  <sipa> but can sign with one of the involved keys
454 2020-04-08T19:09:28  <achow101> so that would be a multisig descriptor with private keys
455 2020-04-08T19:09:32  <sipa> yes
456 2020-04-08T19:10:06  <achow101> hmm
457 2020-04-08T19:10:23  <achow101> we'd need a way to export private keys and easily construct that descriptor
458 2020-04-08T19:10:23  <sipa> just not all private keys (because what's the point of a multisig with all private keys in one place...)
459 2020-04-08T19:12:04  *** bitcoin-git has joined #bitcoin-core-dev
460 2020-04-08T19:12:04  <bitcoin-git> [bitcoin] ryanofsky opened pull request #18568: doc: Clarify developer notes about constant naming (master...pr/capconst) https://github.com/bitcoin/bitcoin/pull/18568
461 2020-04-08T19:12:05  *** bitcoin-git has left #bitcoin-core-dev
462 2020-04-08T19:15:17  <instagibbs> ideally internally everything unfinished tx related would be PSBT
463 2020-04-08T19:16:34  <achow101> sipa: that still does break existing multisig workflows as addmultisigaddress won't work anymore
464 2020-04-08T19:16:42  <achow101> but not as badly
465 2020-04-08T19:17:29  <sipa> achow101: i would hope addmultisigaddress doesn't exist for a descriptor wallet
466 2020-04-08T19:17:38  <achow101> it doesn't
467 2020-04-08T19:18:03  <achow101> i've just overloaded it in the rpc tests to be createmultisig -> impordescriptors
468 2020-04-08T19:18:12  <sipa> right
469 2020-04-08T19:33:29  *** belcher has quit IRC
470 2020-04-08T19:38:02  *** belcher has joined #bitcoin-core-dev
471 2020-04-08T19:41:05  *** vasild_ has joined #bitcoin-core-dev
472 2020-04-08T19:44:43  *** vasild has quit IRC
473 2020-04-08T19:44:44  *** vasild_ is now known as vasild
474 2020-04-08T19:52:25  *** michaelfolkson has joined #bitcoin-core-dev
475 2020-04-08T19:53:51  *** emilengler has quit IRC
476 2020-04-08T19:58:49  *** captjakk has quit IRC
477 2020-04-08T19:59:23  *** captjakk has joined #bitcoin-core-dev
478 2020-04-08T20:08:54  *** captjakk has quit IRC
479 2020-04-08T20:14:45  *** DeanWeen has quit IRC
480 2020-04-08T20:15:11  *** DeanWeen has joined #bitcoin-core-dev
481 2020-04-08T20:16:44  *** Chris_Stewart_5 has quit IRC
482 2020-04-08T20:21:01  *** michaelfolkson has quit IRC
483 2020-04-08T20:34:37  *** timothy has quit IRC
484 2020-04-08T20:55:41  *** sonofhan has joined #bitcoin-core-dev
485 2020-04-08T20:57:31  *** pinheadmz has quit IRC
486 2020-04-08T21:00:02  *** kik1 has quit IRC
487 2020-04-08T21:16:46  *** Krellan_ has joined #bitcoin-core-dev
488 2020-04-08T21:19:55  *** BusError1 has joined #bitcoin-core-dev
489 2020-04-08T21:20:11  *** fearbeag has quit IRC
490 2020-04-08T21:25:51  *** Krellan_ has quit IRC
491 2020-04-08T21:27:12  *** Chris_Stewart_5 has joined #bitcoin-core-dev
492 2020-04-08T21:35:35  *** thesonofhan has joined #bitcoin-core-dev
493 2020-04-08T21:39:13  *** sonofhan has quit IRC
494 2020-04-08T21:39:54  *** manantial has quit IRC
495 2020-04-08T21:45:13  *** thesonofhan has quit IRC
496 2020-04-08T21:46:39  *** Guyver2 has quit IRC
497 2020-04-08T22:02:15  *** bitcoin-git has joined #bitcoin-core-dev
498 2020-04-08T22:02:15  <bitcoin-git> [bitcoin] hebasto opened pull request #18569: ci: Add big endian native s390x build (master...20200326-allow-s390x) https://github.com/bitcoin/bitcoin/pull/18569
499 2020-04-08T22:02:16  *** bitcoin-git has left #bitcoin-core-dev
500 2020-04-08T22:41:54  *** Talkless has quit IRC
501 2020-04-08T22:46:15  *** ddustin has joined #bitcoin-core-dev
502 2020-04-08T22:49:12  *** ddustin_ has quit IRC
503 2020-04-08T23:14:29  *** willcl_ark has quit IRC
504 2020-04-08T23:17:27  *** justanotheruser has quit IRC
505 2020-04-08T23:19:00  *** willcl_ark has joined #bitcoin-core-dev
506 2020-04-08T23:22:34  *** filchef has quit IRC
507 2020-04-08T23:24:47  *** marcoagner has quit IRC
508 2020-04-08T23:29:43  *** justanotheruser has joined #bitcoin-core-dev
509 2020-04-08T23:31:15  *** pinheadmz has joined #bitcoin-core-dev
510 2020-04-08T23:31:46  *** owowo has quit IRC
511 2020-04-08T23:37:13  *** owowo has joined #bitcoin-core-dev
512 2020-04-08T23:37:13  *** owowo has joined #bitcoin-core-dev
513 2020-04-08T23:45:29  *** ctrlbreak_MAD has joined #bitcoin-core-dev
514 2020-04-08T23:49:00  *** ctrlbreak has quit IRC
515 2020-04-08T23:50:10  *** bitcoin-git has joined #bitcoin-core-dev
516 2020-04-08T23:50:10  <bitcoin-git> [bitcoin] brakmic opened pull request #18570: rpc: return block hash in getbalances json (master...return-blockhash-with-wallet-calls) https://github.com/bitcoin/bitcoin/pull/18570
517 2020-04-08T23:50:11  *** bitcoin-git has left #bitcoin-core-dev
518 2020-04-08T23:53:11  *** bitcoin-git has joined #bitcoin-core-dev
519 2020-04-08T23:53:11  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18571: fuzz: Disable debug log file (master...2004-testLogExtraArgs) https://github.com/bitcoin/bitcoin/pull/18571
520 2020-04-08T23:53:12  *** bitcoin-git has left #bitcoin-core-dev