12020-04-10T00:00:02  *** Guest9036 has quit IRC
  22020-04-10T00:01:25  *** ddustin has joined #bitcoin-core-dev
  32020-04-10T00:02:07  *** justanotheruser has joined #bitcoin-core-dev
  42020-04-10T00:05:52  *** ddustin has quit IRC
  52020-04-10T00:11:18  *** ddustin has joined #bitcoin-core-dev
  62020-04-10T00:22:28  *** bitcoin-git has joined #bitcoin-core-dev
  72020-04-10T00:22:28  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d486991aa59d...2b9a4a13324a
  82020-04-10T00:22:29  <bitcoin-git> bitcoin/master 478c11d Yahia Chiheb: Correct scripted-diff example link
  92020-04-10T00:22:29  <bitcoin-git> bitcoin/master 2b9a4a1 fanquake: Merge #18577: doc: Correct scripted-diff example link
 102020-04-10T00:22:31  *** bitcoin-git has left #bitcoin-core-dev
 112020-04-10T00:22:47  *** bitcoin-git has joined #bitcoin-core-dev
 122020-04-10T00:22:47  <bitcoin-git> [bitcoin] fanquake merged pull request #18577: doc: Correct scripted-diff example link (master...correct-link) https://github.com/bitcoin/bitcoin/pull/18577
 132020-04-10T00:22:48  *** bitcoin-git has left #bitcoin-core-dev
 142020-04-10T00:28:20  *** promag has quit IRC
 152020-04-10T00:36:35  *** AaronvanW has quit IRC
 162020-04-10T00:36:52  *** promag has joined #bitcoin-core-dev
 172020-04-10T00:41:42  *** promag has quit IRC
 182020-04-10T00:44:21  *** marcoagner has quit IRC
 192020-04-10T00:55:34  *** doomas has joined #bitcoin-core-dev
 202020-04-10T00:56:13  *** bitcoin-git has joined #bitcoin-core-dev
 212020-04-10T00:56:13  <bitcoin-git> [bitcoin] hebasto opened pull request #18581: ci: Print ccache stats, add pip cache, and cleanups (master...20200409-ci-plus) https://github.com/bitcoin/bitcoin/pull/18581
 222020-04-10T00:56:14  *** bitcoin-git has left #bitcoin-core-dev
 232020-04-10T00:58:34  *** owowo has quit IRC
 242020-04-10T00:59:24  *** owowo has joined #bitcoin-core-dev
 252020-04-10T01:26:57  *** ddustin has quit IRC
 262020-04-10T01:49:03  *** ddustin has joined #bitcoin-core-dev
 272020-04-10T02:00:55  *** dr-orlovsky has quit IRC
 282020-04-10T02:26:56  *** DeanGuss has joined #bitcoin-core-dev
 292020-04-10T02:27:37  *** belcher has quit IRC
 302020-04-10T02:28:49  *** amsudeep has joined #bitcoin-core-dev
 312020-04-10T02:36:49  *** molz_ has joined #bitcoin-core-dev
 322020-04-10T02:40:12  *** molly has quit IRC
 332020-04-10T02:54:35  *** captjakk has joined #bitcoin-core-dev
 342020-04-10T03:00:02  *** doomas has quit IRC
 352020-04-10T03:02:14  *** amsudeep has quit IRC
 362020-04-10T03:21:59  *** edunham1 has joined #bitcoin-core-dev
 372020-04-10T03:23:02  *** amsudeep has joined #bitcoin-core-dev
 382020-04-10T03:59:00  *** captjakk has quit IRC
 392020-04-10T03:59:15  *** molly has joined #bitcoin-core-dev
 402020-04-10T03:59:26  *** captjakk has joined #bitcoin-core-dev
 412020-04-10T04:02:31  *** molz_ has quit IRC
 422020-04-10T04:03:55  *** captjakk has quit IRC
 432020-04-10T04:10:28  *** molly has quit IRC
 442020-04-10T04:17:11  *** mol has joined #bitcoin-core-dev
 452020-04-10T04:26:27  *** amsudeep has quit IRC
 462020-04-10T04:36:44  *** amsudeep has joined #bitcoin-core-dev
 472020-04-10T04:39:23  *** DeanGuss has quit IRC
 482020-04-10T04:46:07  *** amsudeep has quit IRC
 492020-04-10T04:48:13  *** Highway61 has quit IRC
 502020-04-10T04:48:38  *** Highway61 has joined #bitcoin-core-dev
 512020-04-10T04:48:44  *** ppisati has quit IRC
 522020-04-10T04:53:35  *** molly has joined #bitcoin-core-dev
 532020-04-10T04:53:40  *** amsudeep has joined #bitcoin-core-dev
 542020-04-10T04:55:27  *** ppisati has joined #bitcoin-core-dev
 552020-04-10T04:56:23  *** mol has quit IRC
 562020-04-10T05:15:04  *** amsudeep has quit IRC
 572020-04-10T05:24:21  *** amsudeep has joined #bitcoin-core-dev
 582020-04-10T05:33:46  *** amsudeep has quit IRC
 592020-04-10T05:43:40  *** amsudeep has joined #bitcoin-core-dev
 602020-04-10T05:49:54  *** amsudeep has quit IRC
 612020-04-10T05:57:50  *** amsudeep has joined #bitcoin-core-dev
 622020-04-10T06:00:01  *** edunham1 has quit IRC
 632020-04-10T06:01:00  *** ddustin has quit IRC
 642020-04-10T06:02:19  <jonasschnelli> achow101: thanks for the writeup! Will go through it now...
 652020-04-10T06:02:56  <sipa> 
 662020-04-10T06:04:27  <gwillen> uh, assuming there is not something wrong with my IRC client, I see one line from jonasschnelli which is (presumably accidentally) written in black-on-black text, followed by a blank line from sipa
 672020-04-10T06:06:31  <achow101> gwillen: it's a space
 682020-04-10T06:07:08  <achow101> I see jonasschnelli's line fine, probably becaue I'm highlighted?
 692020-04-10T06:07:19  *** amsudeep has quit IRC
 702020-04-10T06:08:53  <sipa> oh, i didn't see jonasschnelli's at all, assuming it was an empty line
 712020-04-10T06:08:56  <sipa> sneaky.
 722020-04-10T06:13:06  *** Emcy has quit IRC
 732020-04-10T06:13:40  *** Emcy has joined #bitcoin-core-dev
 742020-04-10T06:14:20  *** manantial has joined #bitcoin-core-dev
 752020-04-10T06:14:37  <gwillen> yeah I figured that might have been what happened
 762020-04-10T06:15:36  *** amsudeep has joined #bitcoin-core-dev
 772020-04-10T06:16:31  <vasild> I see jonasschnelli's message as black-on-black too, had to copy-paste into another terminal so I can read it
 782020-04-10T06:18:38  *** glyph1 has joined #bitcoin-core-dev
 792020-04-10T06:22:01  *** wpaulino has quit IRC
 802020-04-10T06:24:14  *** Emcy has quit IRC
 812020-04-10T06:27:26  *** amsudeep has quit IRC
 822020-04-10T06:27:40  *** Emcy has joined #bitcoin-core-dev
 832020-04-10T06:36:25  *** amsudeep has joined #bitcoin-core-dev
 842020-04-10T06:49:25  *** amsudeep has quit IRC
 852020-04-10T06:55:32  *** amsudeep has joined #bitcoin-core-dev
 862020-04-10T06:58:57  <jonasschnelli> hmm... I used my mobile (iOS) irc client (via a znc bouncer). Now back on my desktop client. Better?
 872020-04-10T06:59:17  <gwillen> your text is no longer black
 882020-04-10T06:59:36  <jonasschnelli> I also have a empty line from sipa. :}
 892020-04-10T06:59:54  <jonasschnelli> maybe someone is messing with my znc
 902020-04-10T07:24:31  *** sipsorcery has joined #bitcoin-core-dev
 912020-04-10T07:25:25  *** amsudeep has quit IRC
 922020-04-10T07:26:03  *** jonatack_ has joined #bitcoin-core-dev
 932020-04-10T07:29:01  *** rh0nj has quit IRC
 942020-04-10T07:29:19  *** jonatack has quit IRC
 952020-04-10T07:30:07  *** rh0nj has joined #bitcoin-core-dev
 962020-04-10T07:30:49  *** amsudeep has joined #bitcoin-core-dev
 972020-04-10T07:41:06  *** vasild_ has joined #bitcoin-core-dev
 982020-04-10T07:44:23  *** vasild has quit IRC
 992020-04-10T07:44:24  *** vasild_ is now known as vasild
1002020-04-10T07:48:38  *** ghost43 has quit IRC
1012020-04-10T07:48:43  *** alec has quit IRC
1022020-04-10T07:48:56  *** ghost43 has joined #bitcoin-core-dev
1032020-04-10T07:54:26  *** kabaum has joined #bitcoin-core-dev
1042020-04-10T07:55:50  *** alec has joined #bitcoin-core-dev
1052020-04-10T07:58:54  *** ossifrage has quit IRC
1062020-04-10T08:06:07  *** emilengler has joined #bitcoin-core-dev
1072020-04-10T08:07:26  *** emilengler has joined #bitcoin-core-dev
1082020-04-10T08:08:32  *** kabaum has quit IRC
1092020-04-10T08:12:52  *** amsudeep has quit IRC
1102020-04-10T08:13:38  *** emilengler has quit IRC
1112020-04-10T08:14:34  *** ghost43 has quit IRC
1122020-04-10T08:14:42  *** emilengler has joined #bitcoin-core-dev
1132020-04-10T08:15:24  *** ghost43 has joined #bitcoin-core-dev
1142020-04-10T08:19:05  *** SiAnDoG_ has quit IRC
1152020-04-10T08:19:30  *** SiAnDoG_ has joined #bitcoin-core-dev
1162020-04-10T08:46:32  *** promag has joined #bitcoin-core-dev
1172020-04-10T08:48:58  *** AaronvanW has joined #bitcoin-core-dev
1182020-04-10T08:50:39  *** owowo has quit IRC
1192020-04-10T08:55:44  *** owowo has joined #bitcoin-core-dev
1202020-04-10T09:00:02  *** glyph1 has quit IRC
1212020-04-10T09:03:06  *** ghost43 has quit IRC
1222020-04-10T09:04:06  *** ghost43 has joined #bitcoin-core-dev
1232020-04-10T09:05:42  *** molly has quit IRC
1242020-04-10T09:08:42  *** Arvidt has joined #bitcoin-core-dev
1252020-04-10T09:13:41  *** marcoagner has joined #bitcoin-core-dev
1262020-04-10T09:36:45  *** mol has joined #bitcoin-core-dev
1272020-04-10T09:46:27  *** kristapsk has quit IRC
1282020-04-10T09:49:11  *** promag has quit IRC
1292020-04-10T09:52:17  *** kristapsk has joined #bitcoin-core-dev
1302020-04-10T09:53:05  *** inquis has joined #bitcoin-core-dev
1312020-04-10T10:00:44  *** ghost43 has quit IRC
1322020-04-10T10:01:17  *** ghost43 has joined #bitcoin-core-dev
1332020-04-10T10:02:57  *** mytwocentimes has joined #bitcoin-core-dev
1342020-04-10T10:03:55  *** Morton73MacGyver has joined #bitcoin-core-dev
1352020-04-10T10:08:49  *** Morton73MacGyver has quit IRC
1362020-04-10T10:23:17  *** promag has joined #bitcoin-core-dev
1372020-04-10T10:27:04  *** per has joined #bitcoin-core-dev
1382020-04-10T10:42:41  *** molly has joined #bitcoin-core-dev
1392020-04-10T10:43:38  *** EagleTM has joined #bitcoin-core-dev
1402020-04-10T10:45:34  *** mol has quit IRC
1412020-04-10T10:48:35  *** CryptoNC has joined #bitcoin-core-dev
1422020-04-10T10:50:21  *** CryptoNC has quit IRC
1432020-04-10T11:19:49  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1442020-04-10T11:39:46  *** bitcoin-git has joined #bitcoin-core-dev
1452020-04-10T11:39:46  <bitcoin-git> [bitcoin] tom19990101 opened pull request #18583: Merge pull request #1 from bitcoin/master (master...master) https://github.com/bitcoin/bitcoin/pull/18583
1462020-04-10T11:39:48  *** bitcoin-git has left #bitcoin-core-dev
1472020-04-10T11:40:36  *** bitcoin-git has joined #bitcoin-core-dev
1482020-04-10T11:40:36  <bitcoin-git> [bitcoin] fanquake closed pull request #18583: Merge pull request #1 from bitcoin/master (master...master) https://github.com/bitcoin/bitcoin/pull/18583
1492020-04-10T11:40:41  *** bitcoin-git has left #bitcoin-core-dev
1502020-04-10T11:44:42  *** promag has quit IRC
1512020-04-10T11:47:42  *** cubancorona has quit IRC
1522020-04-10T11:49:28  *** per has quit IRC
1532020-04-10T11:49:43  *** per_ has joined #bitcoin-core-dev
1542020-04-10T11:51:15  *** ddustin has joined #bitcoin-core-dev
1552020-04-10T12:00:01  *** inquis has quit IRC
1562020-04-10T12:00:14  *** EagleTM has quit IRC
1572020-04-10T12:01:17  *** cubancorona has joined #bitcoin-core-dev
1582020-04-10T12:11:06  *** jonatack_ has quit IRC
1592020-04-10T12:20:49  *** rex4539 has joined #bitcoin-core-dev
1602020-04-10T12:21:53  *** [n1x]_ has joined #bitcoin-core-dev
1612020-04-10T12:28:09  <vasild> MarcoFalke: https://github.com/bitcoin/bips/pull/907#issuecomment-611997913 -- I have just started looking into this, digesting the BIP for now.
1622020-04-10T12:30:08  *** Talkless has joined #bitcoin-core-dev
1632020-04-10T12:30:40  <MarcoFalke> Yeah, I wasn't sure if dongcarl had done the fixups as well (locally, not public)
1642020-04-10T12:38:22  *** ppisati has quit IRC
1652020-04-10T12:43:30  *** rex4539 has quit IRC
1662020-04-10T12:43:54  *** AaronvanW has quit IRC
1672020-04-10T12:45:24  *** EagleTM has joined #bitcoin-core-dev
1682020-04-10T12:50:17  *** ppisati has joined #bitcoin-core-dev
1692020-04-10T12:50:58  *** promag has joined #bitcoin-core-dev
1702020-04-10T12:54:05  *** Ralayax has joined #bitcoin-core-dev
1712020-04-10T12:56:53  *** Ralayax has quit IRC
1722020-04-10T12:59:16  *** ghost43 has quit IRC
1732020-04-10T13:00:07  *** ghost43 has joined #bitcoin-core-dev
1742020-04-10T13:05:47  *** ghost43 has quit IRC
1752020-04-10T13:07:04  *** ghost43 has joined #bitcoin-core-dev
1762020-04-10T13:10:42  *** AaronvanW has joined #bitcoin-core-dev
1772020-04-10T13:14:12  *** rex4539 has joined #bitcoin-core-dev
1782020-04-10T13:16:21  *** jonatack has joined #bitcoin-core-dev
1792020-04-10T13:16:47  *** Emcy has quit IRC
1802020-04-10T13:17:39  *** Emcy has joined #bitcoin-core-dev
1812020-04-10T13:29:53  *** ghost43 has quit IRC
1822020-04-10T13:30:39  *** ghost43 has joined #bitcoin-core-dev
1832020-04-10T13:32:56  *** bitcoin-git has joined #bitcoin-core-dev
1842020-04-10T13:32:56  <bitcoin-git> [bitcoin] hebasto closed pull request #18400: gui: Import only required Objective-C headers (master...20200321-objc-headers) https://github.com/bitcoin/bitcoin/pull/18400
1852020-04-10T13:32:57  *** bitcoin-git has left #bitcoin-core-dev
1862020-04-10T13:37:21  *** EagleTM has quit IRC
1872020-04-10T13:45:28  *** Guyver2 has joined #bitcoin-core-dev
1882020-04-10T13:51:46  *** molz_ has joined #bitcoin-core-dev
1892020-04-10T13:54:02  *** spinza has quit IRC
1902020-04-10T13:55:06  *** molly has quit IRC
1912020-04-10T13:59:54  *** sipsorcery has quit IRC
1922020-04-10T14:01:16  *** sipsorcery has joined #bitcoin-core-dev
1932020-04-10T14:06:48  *** spinza has joined #bitcoin-core-dev
1942020-04-10T14:11:24  *** ghost43 has quit IRC
1952020-04-10T14:12:17  *** ghost43 has joined #bitcoin-core-dev
1962020-04-10T14:14:27  *** bitcoin-git has joined #bitcoin-core-dev
1972020-04-10T14:14:27  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/2b9a4a13324a...29893ec8751f
1982020-04-10T14:14:28  <bitcoin-git> bitcoin/master fa47a0b MarcoFalke: net: Make addr relay mockable
1992020-04-10T14:14:28  <bitcoin-git> bitcoin/master fa1793c MarcoFalke: net: Pass connman const when relaying address
2002020-04-10T14:14:28  <bitcoin-git> bitcoin/master fa1da3d MarcoFalke: test: Add basic addr relay test
2012020-04-10T14:14:30  *** bitcoin-git has left #bitcoin-core-dev
2022020-04-10T14:14:47  *** bitcoin-git has joined #bitcoin-core-dev
2032020-04-10T14:14:47  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18454: net: Make addr relay mockable, add test (master...2003-qaAddrRelay) https://github.com/bitcoin/bitcoin/pull/18454
2042020-04-10T14:14:48  *** bitcoin-git has left #bitcoin-core-dev
2052020-04-10T14:18:23  *** filchef has joined #bitcoin-core-dev
2062020-04-10T14:23:53  *** ghost43 has quit IRC
2072020-04-10T14:24:39  *** ghost43 has joined #bitcoin-core-dev
2082020-04-10T14:27:03  *** andrewtoth has quit IRC
2092020-04-10T14:27:06  <hebasto> promag: around?
2102020-04-10T14:30:03  *** rex4539 has quit IRC
2112020-04-10T14:33:33  *** DeanGuss has joined #bitcoin-core-dev
2122020-04-10T14:49:28  *** promag_ has joined #bitcoin-core-dev
2132020-04-10T14:53:53  *** bitcoin-git has joined #bitcoin-core-dev
2142020-04-10T14:53:53  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18584: test: Check that the version message does not leak the local address (master...2003-qaAddrRelay) https://github.com/bitcoin/bitcoin/pull/18584
2152020-04-10T14:53:54  *** bitcoin-git has left #bitcoin-core-dev
2162020-04-10T15:00:02  *** [n1x]_ has quit IRC
2172020-04-10T15:02:08  *** fearbeag has joined #bitcoin-core-dev
2182020-04-10T15:08:09  *** bitcoin-git has joined #bitcoin-core-dev
2192020-04-10T15:08:09  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/29893ec8751f...3347ca48816c
2202020-04-10T15:08:10  <bitcoin-git> bitcoin/master 7fcdec0 Hennadii Stepanov: Remove PID file at the very end
2212020-04-10T15:08:10  <bitcoin-git> bitcoin/master 3347ca4 MarcoFalke: Merge #18526: Remove PID file at the very end
2222020-04-10T15:08:12  *** bitcoin-git has left #bitcoin-core-dev
2232020-04-10T15:08:29  *** bitcoin-git has joined #bitcoin-core-dev
2242020-04-10T15:08:29  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18526: Remove PID file at the very end (master...20200404-del-pid) https://github.com/bitcoin/bitcoin/pull/18526
2252020-04-10T15:08:30  *** bitcoin-git has left #bitcoin-core-dev
2262020-04-10T15:14:55  *** mol has joined #bitcoin-core-dev
2272020-04-10T15:15:52  *** justanotheruser has quit IRC
2282020-04-10T15:17:14  *** molz_ has quit IRC
2292020-04-10T15:20:31  *** r2wj has joined #bitcoin-core-dev
2302020-04-10T15:24:14  *** bitcoin-git has joined #bitcoin-core-dev
2312020-04-10T15:24:14  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3347ca48816c...a840dab2a582
2322020-04-10T15:24:14  <bitcoin-git> bitcoin/master fad691c MarcoFalke: rpc: Make verifychain default values static, not depend on global args
2332020-04-10T15:24:15  <bitcoin-git> bitcoin/master a840dab MarcoFalke: Merge #18541: rpc: Make verifychain default values static, not depend on g...
2342020-04-10T15:24:16  *** bitcoin-git has left #bitcoin-core-dev
2352020-04-10T15:24:34  *** bitcoin-git has joined #bitcoin-core-dev
2362020-04-10T15:24:34  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18541: rpc: Make verifychain default values static, not depend on global args (master...2004-rpcStaticDefaults) https://github.com/bitcoin/bitcoin/pull/18541
2372020-04-10T15:24:35  *** bitcoin-git has left #bitcoin-core-dev
2382020-04-10T15:32:24  *** justanotheruser has joined #bitcoin-core-dev
2392020-04-10T15:38:35  <instagibbs> ryanofsky, indeed looking at private keys disabled to change logic was basically a hack, moving forward with descriptor wallets we should try to do better
2402020-04-10T15:39:47  <instagibbs> I'm merely describing what will not work(and likely surprise the user) with #16528
2412020-04-10T15:39:49  <gribble> https://github.com/bitcoin/bitcoin/issues/16528 | Native Descriptor Wallets using DescriptorScriptPubKeyMan by achow101 · Pull Request #16528 · bitcoin/bitcoin · GitHub
2422020-04-10T15:46:17  *** Deacyde has joined #bitcoin-core-dev
2432020-04-10T15:48:45  *** bitcoin-git has joined #bitcoin-core-dev
2442020-04-10T15:48:45  <bitcoin-git> [bitcoin] theStack opened pull request #18585: test: use zero-argument super() shortcut (Python 3.0+) (master...20201004-test-use-python3-non-zero-arg-super) https://github.com/bitcoin/bitcoin/pull/18585
2452020-04-10T15:48:46  *** bitcoin-git has left #bitcoin-core-dev
2462020-04-10T16:15:52  <wumpus> PSA: please don't push anything to the master branch, I'm working on forking off 0.20
2472020-04-10T16:22:10  *** bitcoin-git has joined #bitcoin-core-dev
2482020-04-10T16:22:10  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to master: https://github.com/bitcoin/bitcoin/compare/a840dab2a582...d84c9aa25d8b
2492020-04-10T16:22:10  <bitcoin-git> bitcoin/master d84c9aa Wladimir J. van der Laan: build: Bump version to 0.20.99
2502020-04-10T16:22:12  *** bitcoin-git has left #bitcoin-core-dev
2512020-04-10T16:23:43  *** alec has quit IRC
2522020-04-10T16:24:20  <wumpus> ok, 0.20 branch has been created, master is free for merging for 0.21
2532020-04-10T16:25:20  <jonatack> 0.20 \o/
2542020-04-10T16:25:22  *** morcos has quit IRC
2552020-04-10T16:30:41  *** alec has joined #bitcoin-core-dev
2562020-04-10T16:31:20  *** morcos has joined #bitcoin-core-dev
2572020-04-10T16:36:15  *** TheFuzzStone[m] has quit IRC
2582020-04-10T16:36:23  *** TheFuzzStone[m] has joined #bitcoin-core-dev
2592020-04-10T16:44:19  *** promag has quit IRC
2602020-04-10T16:44:22  *** promag_ is now known as promag
2612020-04-10T16:44:32  <promag> hebasto: yup
2622020-04-10T16:44:53  *** promag_ has joined #bitcoin-core-dev
2632020-04-10T16:45:30  <promag> 0.20 \m/
2642020-04-10T16:45:46  <promag> #18578 simple leak fix btw
2652020-04-10T16:45:47  <gribble> https://github.com/bitcoin/bitcoin/issues/18578 | gui: Fix itemWalletAddress leak when not tree mode by promag · Pull Request #18578 · bitcoin/bitcoin · GitHub
2662020-04-10T16:45:53  *** sipsorcery has quit IRC
2672020-04-10T16:47:38  <hebasto> promag: mind clarifying https://github.com/bitcoin/bitcoin/pull/18452#discussion_r406780940 ?
2682020-04-10T16:48:45  <promag> ah yes, I think it's fine doing in NodeImpl::startShutdown
2692020-04-10T16:49:04  <promag> it's not a gui concern I think
2702020-04-10T16:49:54  <MarcoFalke> 0.20 'o'
2712020-04-10T16:50:40  <promag> MarcoFalke: 18578 is a fix, so I can PR for 0.20 branch right?
2722020-04-10T16:50:57  <promag> (after merging is master)
2732020-04-10T16:51:01  <promag> *in
2742020-04-10T16:52:36  *** bitcoin-git has joined #bitcoin-core-dev
2752020-04-10T16:52:37  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d84c9aa25d8b...6ab96ec5469c
2762020-04-10T16:52:37  <bitcoin-git> bitcoin/master 7501977 Jon Atack: cli -getinfo: use getbalances instead of deprecated getwalletinfo balance
2772020-04-10T16:52:38  <bitcoin-git> bitcoin/master 5df0877 Jon Atack: test: update and harden interface_bitcoin_cli tests
2782020-04-10T16:52:39  <bitcoin-git> bitcoin/master 6ab96ec MarcoFalke: Merge #18574: cli: call getbalances.ismine.trusted instead of getwalletinf...
2792020-04-10T16:52:45  *** bitcoin-git has left #bitcoin-core-dev
2802020-04-10T16:53:00  *** bitcoin-git has joined #bitcoin-core-dev
2812020-04-10T16:53:00  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18574: cli: call getbalances.ismine.trusted instead of getwalletinfo.balance (master...getinfo-call-getbalances-instead-of-getwalletinfo-balances) https://github.com/bitcoin/bitcoin/pull/18574
2822020-04-10T16:53:01  *** bitcoin-git has left #bitcoin-core-dev
2832020-04-10T16:54:15  *** bitcoin-git has joined #bitcoin-core-dev
2842020-04-10T16:54:16  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/6ab96ec5469c...4eb1eeb02c57
2852020-04-10T16:54:17  <bitcoin-git> bitcoin/master 0660119 Russell Yanofsky: Drop unintended bitcoin-tx dependency on libevent
2862020-04-10T16:54:18  <bitcoin-git> bitcoin/master 01a3392 Russell Yanofsky: Drop bitcoin-wallet dependency on libevent
2872020-04-10T16:54:19  <bitcoin-git> bitcoin/master 4eb1eeb MarcoFalke: Merge #18504: build: Drop bitcoin-tx and bitcoin-wallet dependencies on li...
2882020-04-10T16:54:20  *** bitcoin-git has left #bitcoin-core-dev
2892020-04-10T16:54:34  *** bitcoin-git has joined #bitcoin-core-dev
2902020-04-10T16:54:35  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18504: build: Drop bitcoin-tx and bitcoin-wallet dependencies on libevent (master...pr/dep-libevent) https://github.com/bitcoin/bitcoin/pull/18504
2912020-04-10T16:54:36  *** bitcoin-git has left #bitcoin-core-dev
2922020-04-10T16:56:43  <hebasto> promag: thanks
2932020-04-10T16:56:49  *** bitcoin-git has joined #bitcoin-core-dev
2942020-04-10T16:56:50  <bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/4eb1eeb02c57...1b3076136048
2952020-04-10T16:56:51  <bitcoin-git> bitcoin/master e6e44ee Russell Yanofsky: Multiprocess build changes
2962020-04-10T16:56:52  <bitcoin-git> bitcoin/master d630646 Russell Yanofsky: libmultiprocess depends build
2972020-04-10T16:56:53  <bitcoin-git> bitcoin/master 787f406 Russell Yanofsky: Set LD_LIBRARY_PATH consistently in travis tests
2982020-04-10T16:56:54  *** bitcoin-git has left #bitcoin-core-dev
2992020-04-10T16:57:55  *** bitcoin-git has joined #bitcoin-core-dev
3002020-04-10T16:57:55  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16367: Multiprocess build support (master...pr/ipc-build) https://github.com/bitcoin/bitcoin/pull/16367
3012020-04-10T16:57:56  *** bitcoin-git has left #bitcoin-core-dev
3022020-04-10T16:59:15  *** bitcoin-git has joined #bitcoin-core-dev
3032020-04-10T16:59:17  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1b3076136048...99d6a5be8bf1
3042020-04-10T16:59:17  <bitcoin-git> bitcoin/master 1dde238 Russell Yanofsky: Add ChainClient setMockTime, getWallets methods
3052020-04-10T16:59:18  <bitcoin-git> bitcoin/master 3ce16ad Russell Yanofsky: refactor: Use psbt forward declaration
3062020-04-10T16:59:19  <bitcoin-git> bitcoin/master 99d6a5b MarcoFalke: Merge #17999: refactor: Add ChainClient setMockTime, getWallets methods
3072020-04-10T16:59:21  *** bitcoin-git has left #bitcoin-core-dev
3082020-04-10T16:59:45  *** bitcoin-git has joined #bitcoin-core-dev
3092020-04-10T16:59:45  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17999: refactor: Add ChainClient setMockTime, getWallets methods (master...pr/ipc-clients) https://github.com/bitcoin/bitcoin/pull/17999
3102020-04-10T16:59:46  *** bitcoin-git has left #bitcoin-core-dev
3112020-04-10T17:01:16  *** bitcoin-git has joined #bitcoin-core-dev
3122020-04-10T17:01:16  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/99d6a5be8bf1...a9213bbe75c6
3132020-04-10T17:01:16  <bitcoin-git> bitcoin/master 14e8cf9 Pieter Wuille: [consensus] MOVEONLY: Move single-sig checking EvalScript code to EvalChec...
3142020-04-10T17:01:17  <bitcoin-git> bitcoin/master a9213bb MarcoFalke: Merge #18422: [consensus] MOVEONLY: Move single-sig checking EvalScript co...
3152020-04-10T17:01:18  *** bitcoin-git has left #bitcoin-core-dev
3162020-04-10T17:01:34  *** bitcoin-git has joined #bitcoin-core-dev
3172020-04-10T17:01:34  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18422: [consensus] MOVEONLY: Move single-sig checking EvalScript code to EvalChecksig (master...2020-03-evalchecksig) https://github.com/bitcoin/bitcoin/pull/18422
3182020-04-10T17:01:35  *** bitcoin-git has left #bitcoin-core-dev
3192020-04-10T17:03:45  *** bitcoin-git has joined #bitcoin-core-dev
3202020-04-10T17:03:47  <bitcoin-git> [bitcoin] MarcoFalke pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/a9213bbe75c6...10358a381aee
3212020-04-10T17:03:47  <bitcoin-git> bitcoin/master 8e2ecfe James O'Beirne: validation: add CChainState.m_from_snapshot_blockhash
3222020-04-10T17:03:48  <bitcoin-git> bitcoin/master 89cdf4d James O'Beirne: validation: introduce unused ChainstateManager
3232020-04-10T17:03:49  <bitcoin-git> bitcoin/master 5b690f0 James O'Beirne: refactor: move RewindBlockIndex to CChainState
3242020-04-10T17:03:51  *** bitcoin-git has left #bitcoin-core-dev
3252020-04-10T17:04:24  *** bitcoin-git has joined #bitcoin-core-dev
3262020-04-10T17:04:24  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17737: Add ChainstateManager, remove BlockManager global (master...2019-12-au.chainman) https://github.com/bitcoin/bitcoin/pull/17737
3272020-04-10T17:04:26  *** bitcoin-git has left #bitcoin-core-dev
3282020-04-10T17:10:20  <promag> MarcoFalke: Multi Merge
3292020-04-10T17:14:18  *** bitcoin-git has joined #bitcoin-core-dev
3302020-04-10T17:14:19  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/10358a381aee...51e2ce45d682
3312020-04-10T17:14:20  <bitcoin-git> bitcoin/master dcc8332 Andrew Toth: Add generateblock rpc
3322020-04-10T17:14:20  <bitcoin-git> bitcoin/master 7524b64 Andrew Toth: Add tests for generateblock
3332020-04-10T17:14:21  <bitcoin-git> bitcoin/master 51e2ce4 MarcoFalke: Merge #17693: rpc: Add generateblock to mine a custom set of transactions
3342020-04-10T17:14:30  *** bitcoin-git has left #bitcoin-core-dev
3352020-04-10T17:14:58  *** bitcoin-git has joined #bitcoin-core-dev
3362020-04-10T17:14:59  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17693: rpc: Add generateblock to mine a custom set of transactions (master...generateblock) https://github.com/bitcoin/bitcoin/pull/17693
3372020-04-10T17:14:59  *** bitcoin-git has left #bitcoin-core-dev
3382020-04-10T17:15:12  *** AaronvanW has quit IRC
3392020-04-10T17:37:34  *** lightlike has joined #bitcoin-core-dev
3402020-04-10T17:38:48  *** captjakk has joined #bitcoin-core-dev
3412020-04-10T17:47:05  <luke-jr> is the wallet meeting today or next week? :x
3422020-04-10T17:47:16  <achow101> luke-jr: today
3432020-04-10T17:47:19  <luke-jr> phew
3442020-04-10T17:48:00  *** bitcoin-git has joined #bitcoin-core-dev
3452020-04-10T17:48:00  <bitcoin-git> [bitcoin] laanwj opened pull request #18586: build: Bump gitian descriptors to 0.21 (master...2020_04_bump_descriptors) https://github.com/bitcoin/bitcoin/pull/18586
3462020-04-10T17:48:09  *** bitcoin-git has left #bitcoin-core-dev
3472020-04-10T17:49:10  *** bitcoin-git has joined #bitcoin-core-dev
3482020-04-10T17:49:10  <bitcoin-git> [bitcoin] laanwj pushed tag v0.20.0rc1: https://github.com/bitcoin/bitcoin/compare/v0.20.0rc1
3492020-04-10T17:49:11  *** bitcoin-git has left #bitcoin-core-dev
3502020-04-10T17:50:57  <achow101> \o/
3512020-04-10T17:51:47  *** Guyver2_ has joined #bitcoin-core-dev
3522020-04-10T17:53:50  *** Guyver2 has quit IRC
3532020-04-10T17:55:43  *** roconnor has quit IRC
3542020-04-10T17:59:41  *** hadjiszs has quit IRC
3552020-04-10T17:59:41  *** BlueMatt has quit IRC
3562020-04-10T17:59:41  *** GoldmanSats has quit IRC
3572020-04-10T17:59:41  *** tnaka has quit IRC
3582020-04-10T17:59:41  *** stevenroose has quit IRC
3592020-04-10T18:00:01  *** r2wj has quit IRC
3602020-04-10T18:01:39  *** EagleTM has joined #bitcoin-core-dev
3612020-04-10T18:02:12  *** theStack has quit IRC
3622020-04-10T18:03:50  *** hadjiszs has joined #bitcoin-core-dev
3632020-04-10T18:03:50  *** BlueMatt has joined #bitcoin-core-dev
3642020-04-10T18:03:50  *** GoldmanSats has joined #bitcoin-core-dev
3652020-04-10T18:03:50  *** tnaka has joined #bitcoin-core-dev
3662020-04-10T18:03:50  *** stevenroose has joined #bitcoin-core-dev
3672020-04-10T18:19:46  *** hadjiszs has quit IRC
3682020-04-10T18:20:16  *** hadjiszs has joined #bitcoin-core-dev
3692020-04-10T18:21:47  *** kest10 has joined #bitcoin-core-dev
3702020-04-10T18:30:27  *** AaronvanW has joined #bitcoin-core-dev
3712020-04-10T18:33:46  *** xavierfabric has quit IRC
3722020-04-10T18:40:47  <MarcoFalke> #proposedwalletmeetingtopic (short topic) Return last processed block in most wallet RPCs
3732020-04-10T18:45:08  *** promag has quit IRC
3742020-04-10T18:57:38  *** cubancorona has quit IRC
3752020-04-10T18:59:47  *** Dean_Guss has joined #bitcoin-core-dev
3762020-04-10T19:01:03  *** DeanGuss has quit IRC
3772020-04-10T19:01:51  <achow101> wallet meeting?
3782020-04-10T19:03:30  <achow101> #startmeeting
3792020-04-10T19:03:30  <lightningbot> Meeting started Fri Apr 10 19:03:30 2020 UTC.  The chair is achow101. Information about MeetBot at http://wiki.debian.org/MeetBot.
3802020-04-10T19:03:30  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
3812020-04-10T19:03:38  <achow101> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball ariard digi_james amiti fjahr
3822020-04-10T19:03:38  <achow101> jeremyrubin emilengler jonatack hebasto jb55
3832020-04-10T19:03:48  <jonatack> hi
3842020-04-10T19:03:50  <MarcoFalke> hi
3852020-04-10T19:04:13  <achow101> topics?
3862020-04-10T19:04:27  <MarcoFalke> mine
3872020-04-10T19:04:43  *** Dean_Guss has quit IRC
3882020-04-10T19:04:53  <achow101> I would also like to discuss watchonly descriptor wallet things
3892020-04-10T19:05:11  <achow101> #topic (short topic) Return last processed block in most wallet RPCs (MarcoFalke)
3902020-04-10T19:05:30  <MarcoFalke> In light of #17954 and generally that the wallet may fall behind on the best tip, the RPCs should return the last processed block
3912020-04-10T19:05:37  <gribble> https://github.com/bitcoin/bitcoin/issues/17954 | wallet: Remove calls to Chain::Lock methods by ryanofsky · Pull Request #17954 · bitcoin/bitcoin · GitHub
3922020-04-10T19:05:53  <MarcoFalke> This should be uncontroversial, but just making sure shouldn't hurt
3932020-04-10T19:06:25  <achow101> All the wallet RPCs?
3942020-04-10T19:06:45  <achow101> there are a bunch that don't return objects, and some that it probably doesn't matter
3952020-04-10T19:06:59  <MarcoFalke> At least the ones that report the balance or otherwise depend on the latest block processed
3962020-04-10T19:08:06  <jonatack> FWIW I've added fetching multiwallet balances client-side to -getinfo
3972020-04-10T19:08:18  <achow101> well getbalance returns just a number
3982020-04-10T19:08:34  <achow101> so you would have to make that an object, which would break a ton of things
3992020-04-10T19:08:48  <MarcoFalke> getbalances *smirk*
4002020-04-10T19:08:50  <jonatack> getbalance is superseded by getbalances anyway... could probably leave it be?
4012020-04-10T19:09:19  <achow101> yeah but who uses that?
4022020-04-10T19:10:23  <MarcoFalke> Maybe long term it makes sense to break the API
4032020-04-10T19:10:35  <MarcoFalke> getreceivedby* also returns only a plain number
4042020-04-10T19:11:00  <jonatack> if the rpc doesn't return an object i'm not sure it's worth breaking only for that
4052020-04-10T19:11:24  <jonatack> api v2 (tm)
4062020-04-10T19:12:13  <MarcoFalke> gettransaction, getbalances, getwalletinfo should be trivial to amend, since they are an object already
4072020-04-10T19:12:41  <achow101> yes
4082020-04-10T19:12:44  <MarcoFalke> jonatack: the API version is always v${VERSION_OF_BITCOIN_CORE}
4092020-04-10T19:13:20  *** michaelfolkson has joined #bitcoin-core-dev
4102020-04-10T19:13:24  *** michaelfolkson has quit IRC
4112020-04-10T19:14:21  <MarcoFalke> Anyway, that was the short topic. My issue is here: #18567
4122020-04-10T19:14:22  <gribble> https://github.com/bitcoin/bitcoin/issues/18567 | Return block hash with wallet calls · Issue #18567 · bitcoin/bitcoin · GitHub
4132020-04-10T19:14:29  <jonatack> MarcoFalke: right... bitcoin-cli -version
4142020-04-10T19:15:34  <achow101> would it be ok to just not have it returned for getbalance and getreceivedby?
4152020-04-10T19:15:48  *** Dean_Guss has joined #bitcoin-core-dev
4162020-04-10T19:16:13  <jonatack> and getunconfirmedbalance
4172020-04-10T19:16:34  <achow101> iirc those can include unconfirmed txs too so even at a given block hash, the balance can still change
4182020-04-10T19:16:59  <MarcoFalke> I suspect most clients will ignore the value anyway
4192020-04-10T19:17:08  <achow101> jonatack: I think that's the one rpc that this is completely useless for
4202020-04-10T19:17:19  <MarcoFalke> achow101: Same is true for getbalances (it can change between blocks as well)
4212020-04-10T19:17:20  <jonatack> yes
4222020-04-10T19:17:34  <achow101> MarcoFalke: sure, just trying not to cause things to explode
4232020-04-10T19:18:14  <achow101> anyways, I think we can all just comment on the issue
4242020-04-10T19:18:24  *** sipsorcery has joined #bitcoin-core-dev
4252020-04-10T19:18:57  <achow101> #topic watchonly and descriptor wallets
4262020-04-10T19:19:23  <achow101> yesterday I wrote https://gist.github.com/achow101/94d889715afd49181f8efdca1f9faa25 which describes some of the motivations, use cases, and issues for descriptor wallets
4272020-04-10T19:19:25  *** Victorsueca has quit IRC
4282020-04-10T19:19:38  *** fearbeag has quit IRC
4292020-04-10T19:20:15  <achow101> one point that has come up in discussions is watchonly, in particular handling multisigs
4302020-04-10T19:20:20  *** fearbeag has joined #bitcoin-core-dev
4312020-04-10T19:20:48  <sipa> where watchonly just means "you don't have all private keys in your wallet locally" ?
4322020-04-10T19:21:07  <achow101> I think so
4332020-04-10T19:21:39  <sipa> (i bring that up, because say in a HW wallet situation, just because the key is not in your wallet.dat, doesn't mean you don't have the ability to spend)
4342020-04-10T19:23:05  *** fearbeag has quit IRC
4352020-04-10T19:23:16  <achow101> ryanofsky suggested having some descriptors be marked as "watchonly" and others as not, independent of private keys
4362020-04-10T19:24:14  <achow101> "I wonder if in this kind of wallet, ability to mark individual descriptors watchonly or not, ability to display two balances, and ability to have RPCs that know which descriptors are intended for signing regardless of whether private keys are present might help with UX, and maybe let someone get away with just having have one bitcoin wallet instead of two and having to exporting/import between them."
4372020-04-10T19:24:40  <sipa> i'm not sure how i feel about that
4382020-04-10T19:25:19  <sipa> there really shouldn't be a descriptor in the first place for the stuff you don't care about (and turning it into a watchonly thing to separate it feels like a hack)
4392020-04-10T19:25:43  *** fearbeag has joined #bitcoin-core-dev
4402020-04-10T19:26:16  <sipa> i also don't have a better solution for how you'd go from "create single-key thing first, and then construct a multisig out of it"
4412020-04-10T19:26:43  *** Victorsueca has joined #bitcoin-core-dev
4422020-04-10T19:27:14  <achow101> instagibbs also points out that if we allow descriptors with some but not all private keys, bumpfee and PSBT GUI break
4432020-04-10T19:27:26  <sipa> how so?
4442020-04-10T19:27:34  <achow101> so having a bool on the descriptors to indicate signing-ness or something would help with that
4452020-04-10T19:27:43  <achow101> but it does feel like we're regressing to legacy wallet territory
4462020-04-10T19:27:48  <sipa> i agree
4472020-04-10T19:28:06  <achow101> sipa: they switch on disable_private_keys. so if not disable_private_keys, sign, otherwise show/copy psbt
4482020-04-10T19:28:08  *** promag has joined #bitcoin-core-dev
4492020-04-10T19:28:28  <achow101> but a multisig with some but not all privkeys is not disable_private_keys but will fail to sign
4502020-04-10T19:29:06  <sipa> wouldn't it be better to have separate RPCs for when you expect a fully-signed output vs PSBT output?
4512020-04-10T19:29:21  <sipa> and the latter would always work, and the former would just fail if not enough keys are present
4522020-04-10T19:30:06  <achow101> the other problem is that coin selection may choose to include a multisig utxo that you can't always sign for so sometimes sending will fail
4532020-04-10T19:30:14  <achow101> sipa: I think that's reasonable
4542020-04-10T19:30:38  <sipa> achow101: i think that's inherent to the no-mixed-wallet philosophy
4552020-04-10T19:31:07  <sipa> if you really want coin selection to choose directly-spendable coins over multisig ones, you should have two separate wallets
4562020-04-10T19:31:41  <sipa> the idea that you'd ever want those two mixed in the same wallet was a mistake i think, and it's what we're getting rid of?
4572020-04-10T19:31:44  <achow101> right. I don't think it's really a supported use case, but I'm not sure that we can/should block it
4582020-04-10T19:32:14  <sipa> i think to the extent possible the behavior of wallets and RPCs should not depend on whether you happen to have a private key locally
4592020-04-10T19:32:18  *** promag has quit IRC
4602020-04-10T19:33:19  <achow101> right
4612020-04-10T19:33:56  <achow101> I think the separate RPCs and buttons idea mostly solves this. we can disable the signing one when explicitly there are no private keys
4622020-04-10T19:34:16  <achow101> those functionality may also be useful even when you do have all the private keys
4632020-04-10T19:34:32  <sipa> right
4642020-04-10T19:34:53  <sipa> maybe you want to get a PSBT out even when you have all private keys, e.g. for a final auditing on a secure machine before broadcasting or so
4652020-04-10T19:35:04  <sipa> (as they retain fee information)
4662020-04-10T19:35:22  <achow101> and we should stop changing behavior based on disable_private_keys
4672020-04-10T19:36:05  <sipa> yeah
4682020-04-10T19:36:10  <achow101> any other topics?
4692020-04-10T19:36:12  <sipa> at least for descriptor wallets...
4702020-04-10T19:37:55  <jonatack> sgtm (and good doc achow101, thanks)
4712020-04-10T19:39:12  <achow101> #endmeeting
4722020-04-10T19:39:12  <lightningbot> Meeting ended Fri Apr 10 19:39:12 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
4732020-04-10T19:39:12  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-04-10-19.03.html
4742020-04-10T19:39:12  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-04-10-19.03.txt
4752020-04-10T19:39:12  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-04-10-19.03.log.html
4762020-04-10T19:41:07  *** vasild_ has joined #bitcoin-core-dev
4772020-04-10T19:41:44  <instagibbs> achow101, "just add more buttons" still would result in things semi-randomly failing though
4782020-04-10T19:42:26  <instagibbs> like, sometimes maybe the "send" button would work, sometimes not, depending on what mixture of stuff you imported
4792020-04-10T19:43:19  <achow101> instagibbs: that was discussed as "don't do it"
4802020-04-10T19:43:20  <sipa> could it be greyed out when not enough private keys are present? :p
4812020-04-10T19:43:42  <instagibbs> sipa, don't know until you do coin selection :P
4822020-04-10T19:43:56  <instagibbs> achow101, oh I might have missed the result, looking through scrollback...
4832020-04-10T19:44:20  *** bitcoin-git has joined #bitcoin-core-dev
4842020-04-10T19:44:21  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/51e2ce45d682...75917591c840
4852020-04-10T19:44:21  <bitcoin-git> bitcoin/master dabe2bb Wladimir J. van der Laan: build: Bump gitian descriptors to 0.21
4862020-04-10T19:44:22  <bitcoin-git> bitcoin/master 7591759 Wladimir J. van der Laan: Merge #18586: build: Bump gitian descriptors to 0.21
4872020-04-10T19:44:23  *** vasild has quit IRC
4882020-04-10T19:44:24  *** bitcoin-git has left #bitcoin-core-dev
4892020-04-10T19:44:24  *** vasild_ is now known as vasild
4902020-04-10T19:44:25  <sipa> instagibbs: it feels very wrong that things would depend on coin selection
4912020-04-10T19:44:37  <instagibbs> yes.
4922020-04-10T19:44:40  *** bitcoin-git has joined #bitcoin-core-dev
4932020-04-10T19:44:40  <bitcoin-git> [bitcoin] laanwj merged pull request #18586: build: Bump gitian descriptors to 0.21 (master...2020_04_bump_descriptors) https://github.com/bitcoin/bitcoin/pull/18586
4942020-04-10T19:44:41  *** bitcoin-git has left #bitcoin-core-dev
4952020-04-10T19:47:26  <instagibbs> sipa, I'm reading your comments above as supportive of the idea that sometimes it wouldn't work, if the user had imported a private key of some sort?
4962020-04-10T19:48:58  <instagibbs> oh, "don't do it" as in user doesn't do it
4972020-04-10T19:49:06  <instagibbs> got it
4982020-04-10T19:51:48  <sipa> hmm
4992020-04-10T19:52:33  <sipa> i guess the relevant property that "no private keys" is conveying is "are sign operations guaranteed to always result in a fully-signed transaction"
5002020-04-10T19:53:16  <sipa> for a descriptor wallet you could technically infer this information from the descriptors (generate an sPK from them, try signing for it)
5012020-04-10T19:53:44  *** Victorsueca has quit IRC
5022020-04-10T19:54:27  <instagibbs> i.e., if you can sign for all descriptors in wallet, magic behavior, vs "are there private keys"
5032020-04-10T19:54:49  <instagibbs> well, button greyed out at least
5042020-04-10T19:55:09  <sipa> which isn't so much "does this wallet have any private keys", but "is this a wallet that needs external stuff for signing"
5052020-04-10T19:58:10  *** mytwocentimes has quit IRC
5062020-04-10T19:58:43  *** mytwocentimes has joined #bitcoin-core-dev
5072020-04-10T19:59:30  *** promag has joined #bitcoin-core-dev
5082020-04-10T20:10:08  *** Victorsueca has joined #bitcoin-core-dev
5092020-04-10T20:18:42  *** owowo has quit IRC
5102020-04-10T20:23:23  *** owowo has joined #bitcoin-core-dev
5112020-04-10T20:36:15  *** bitcoin-git has joined #bitcoin-core-dev
5122020-04-10T20:36:16  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/75917591c840...3eb8b1c3924c
5132020-04-10T20:36:16  <bitcoin-git> bitcoin/master 96cb597 Russell Yanofsky: gui: Avoid redundant tx status updates
5142020-04-10T20:36:17  <bitcoin-git> bitcoin/master 3eb8b1c MarcoFalke: Merge #17905: gui: Avoid redundant tx status updates
5152020-04-10T20:36:25  *** bitcoin-git has left #bitcoin-core-dev
5162020-04-10T20:36:50  *** bitcoin-git has joined #bitcoin-core-dev
5172020-04-10T20:36:50  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17905: gui: Avoid redundant tx status updates (master...pr/ipc-txup) https://github.com/bitcoin/bitcoin/pull/17905
5182020-04-10T20:36:51  *** bitcoin-git has left #bitcoin-core-dev
5192020-04-10T20:40:12  <luke-jr> doh, missed it >_<
5202020-04-10T20:40:26  <luke-jr> wallet ppl still around? >.>
5212020-04-10T20:43:17  <luke-jr> After #18546, avoid-reuse wallets should be working correctly in 0.20, but remain broken in 0.19 which interprets "destdata" as a destination being non-change.
5222020-04-10T20:43:18  <achow101> luke-jr: kinda
5232020-04-10T20:43:19  <luke-jr> Since avoid-reuse was a new feature in 0.19 and doesn't affect older wallets or wallets that don't opt-in at all, we can probably get away with just saying "it's broken; upgrade or don't use it"… but this issue makes "destdata" unsafe to use for anything else.
5242020-04-10T20:43:20  <gribble> https://github.com/bitcoin/bitcoin/issues/18546 | Bugfix: Wallet: Safely deal with change in the address book [part 2] by luke-jr · Pull Request #18546 · bitcoin/bitcoin · GitHub
5252020-04-10T20:43:20  <luke-jr> #18550 instead moves/stores change "destdata" in a new key which older wallets will ignore, thereby making it safe to add new "destdata" keys even in old wallets without breaking backward compatibility.
5262020-04-10T20:43:22  <gribble> https://github.com/bitcoin/bitcoin/issues/18550 | Store destdata for change in separate key for backward compatibility by luke-jr · Pull Request #18550 · bitcoin/bitcoin · GitHub
5272020-04-10T20:43:22  <luke-jr> However, doing this in 0.21 will mean extra code to support 0.20 avoid-reuse wallets as a special case. Or we can just merge something like #18572 into 0.20 to be forward compatible.
5282020-04-10T20:43:23  <gribble> https://github.com/bitcoin/bitcoin/issues/18572 | Wallet: Accept "changedata" db key as an alias to "destdata" by luke-jr · Pull Request #18572 · bitcoin/bitcoin · GitHub
5292020-04-10T20:43:23  <luke-jr> (Once it's safe to use "destdata" again, I hope to - for an example - reimplement address reuse warnings without bloom filters.)
5302020-04-10T20:45:53  <achow101> luke-jr: maybe add a wallet flag and don't let people downgrade from 0.21 if they used avoid_reuse?
5312020-04-10T20:47:08  *** Talkless has quit IRC
5322020-04-10T20:47:15  <luke-jr> I think that would be even more complexity than the special-casing of "used" :x
5332020-04-10T20:47:32  <luke-jr> (which is about 3 LOC)
5342020-04-10T20:50:29  <achow101> why can't the change be backwards compatible?
5352020-04-10T20:50:34  <achow101> with 0.20
5362020-04-10T20:51:39  <luke-jr> that's the special casing of "used"
5372020-04-10T20:51:55  <luke-jr> for 0.20 (as is) to see it, it needs to be on a "destdata" db key, which breaks 0.19 and earlier
5382020-04-10T20:52:19  <luke-jr> for avoid-reuse, 0.19 and earlier didn't support it (or were just broken)
5392020-04-10T20:52:35  <luke-jr> but to use destdata for anything else requires fixing this for new keys
5402020-04-10T20:53:09  *** Chris_Stewart_5 has quit IRC
5412020-04-10T20:53:17  <achow101> i think i'm missing some context. I'll look at it more closely later and comment in the PR
5422020-04-10T20:54:57  <luke-jr> there isn't really much context.. ryanofsky got confused by the PRs :/
5432020-04-10T20:55:13  <luke-jr> this is basically just trying to pick up the pieces broken by avoid-reuse being prematurely merged
5442020-04-10T20:56:33  <luke-jr> (and to an extent, working toward using destdata for address reuse warnings)
5452020-04-10T20:59:48  <luke-jr> oh well, I'll try to be around to answer ?s
5462020-04-10T21:00:02  *** kest10 has quit IRC
5472020-04-10T21:03:26  *** morcos has quit IRC
5482020-04-10T21:03:41  *** morcos has joined #bitcoin-core-dev
5492020-04-10T21:13:36  *** filchef has quit IRC
5502020-04-10T21:21:56  *** Voker571 has joined #bitcoin-core-dev
5512020-04-10T21:26:36  *** emilengler has quit IRC
5522020-04-10T21:33:40  *** bitcoin-git has joined #bitcoin-core-dev
5532020-04-10T21:33:40  <bitcoin-git> [bitcoin] ryanofsky opened pull request #18587: gui: Avoid wallet tryGetBalances calls in WalletModel::pollBalanceChanged (master...pr/ipc-bal) https://github.com/bitcoin/bitcoin/pull/18587
5542020-04-10T21:33:49  *** bitcoin-git has left #bitcoin-core-dev
5552020-04-10T21:43:54  *** Chris_Stewart_5 has joined #bitcoin-core-dev
5562020-04-10T21:48:23  *** Dean_Guss has quit IRC
5572020-04-10T21:50:50  *** Guyver2_ has quit IRC
5582020-04-10T21:54:53  *** Dean_Guss has joined #bitcoin-core-dev
5592020-04-10T21:58:51  *** dongcarl has quit IRC
5602020-04-10T21:59:05  *** lightlike has quit IRC
5612020-04-10T22:01:13  *** vasild has quit IRC
5622020-04-10T22:01:28  *** vasild has joined #bitcoin-core-dev
5632020-04-10T22:09:12  *** ddustin_ has joined #bitcoin-core-dev
5642020-04-10T22:11:10  *** ddustin has quit IRC
5652020-04-10T22:16:43  *** vasild has quit IRC
5662020-04-10T22:18:50  *** vasild has joined #bitcoin-core-dev
5672020-04-10T22:28:26  *** bitcoin-git has joined #bitcoin-core-dev
5682020-04-10T22:28:26  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18322: refactor: Add params to node context (master...2003-nodeParams) https://github.com/bitcoin/bitcoin/pull/18322
5692020-04-10T22:28:27  *** bitcoin-git has left #bitcoin-core-dev
5702020-04-10T22:31:57  *** bitcoin-git has joined #bitcoin-core-dev
5712020-04-10T22:31:58  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18322: refactor: Add params to node context (master...2003-nodeParams) https://github.com/bitcoin/bitcoin/pull/18322
5722020-04-10T22:32:09  *** bitcoin-git has left #bitcoin-core-dev
5732020-04-10T22:34:37  *** filchef has joined #bitcoin-core-dev
5742020-04-10T22:35:16  *** filchef has quit IRC
5752020-04-10T22:50:02  *** manantial has quit IRC
5762020-04-10T22:54:35  *** Chris_Stewart_5 has quit IRC
5772020-04-10T23:16:58  <MarcoFalke> #proposedmeetingtopic experimental libmultiprocess, next steps for multiprocess in general (MarcoFalke, fanquake, cfields, ryanofsky)
5782020-04-10T23:27:54  *** justanotheruser has quit IRC
5792020-04-10T23:44:18  *** justanotheruser has joined #bitcoin-core-dev
5802020-04-10T23:44:58  *** bitcoin-git has joined #bitcoin-core-dev
5812020-04-10T23:44:58  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18588: Revert "Merge #16367: Multiprocess build support" (master...2004-buildMultiProcess) https://github.com/bitcoin/bitcoin/pull/18588
5822020-04-10T23:44:59  *** bitcoin-git has left #bitcoin-core-dev
5832020-04-10T23:48:14  *** Jackielove4u_ has quit IRC