1 2020-04-15T00:00:02  *** skorgon has quit IRC
  2 2020-04-15T00:06:00  *** AaronvanW has quit IRC
  3 2020-04-15T00:11:04  *** ddustin has joined #bitcoin-core-dev
  4 2020-04-15T00:15:51  *** ddustin has quit IRC
  5 2020-04-15T00:18:30  *** bitcoin-git has joined #bitcoin-core-dev
  6 2020-04-15T00:18:30  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18640: appveyor: Remove clcache (master...2004-appveyorNoSlowCache) https://github.com/bitcoin/bitcoin/pull/18640
  7 2020-04-15T00:18:36  *** bitcoin-git has left #bitcoin-core-dev
  8 2020-04-15T00:21:10  *** ecrist1 has joined #bitcoin-core-dev
  9 2020-04-15T00:21:48  *** ddustin has joined #bitcoin-core-dev
 10 2020-04-15T00:27:01  *** ddustin has quit IRC
 11 2020-04-15T00:28:07  *** ddustin has joined #bitcoin-core-dev
 12 2020-04-15T00:32:46  *** ddustin has quit IRC
 13 2020-04-15T00:34:03  *** ddustin has joined #bitcoin-core-dev
 14 2020-04-15T00:41:11  *** ddustin has quit IRC
 15 2020-04-15T01:08:38  *** bitcoin-git has joined #bitcoin-core-dev
 16 2020-04-15T01:08:38  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18641: test: Create cached blocks not in the future (master...2004-qaNoCacheFuture) https://github.com/bitcoin/bitcoin/pull/18641
 17 2020-04-15T01:08:39  *** bitcoin-git has left #bitcoin-core-dev
 18 2020-04-15T01:13:46  *** bitcoin-git has joined #bitcoin-core-dev
 19 2020-04-15T01:13:47  <bitcoin-git> [bitcoin] naumenkogs opened pull request #18642: Use std::chrono for the time to rotate destination of addr messages + tests (master...2020_04_mock_addr_rotation_time) https://github.com/bitcoin/bitcoin/pull/18642
 20 2020-04-15T01:13:47  *** bitcoin-git has left #bitcoin-core-dev
 21 2020-04-15T01:23:10  *** bitcoin-git has joined #bitcoin-core-dev
 22 2020-04-15T01:23:10  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/75fcfdaf8b4b...4d793bcfe814
 23 2020-04-15T01:23:11  <bitcoin-git> bitcoin/master fa6cb00 MarcoFalke: doc: Fix macos comments in release-notes
 24 2020-04-15T01:23:11  <bitcoin-git> bitcoin/master 4d793bc fanquake: Merge #18632: doc: Fix macos comments in release-notes
 25 2020-04-15T01:23:13  *** bitcoin-git has left #bitcoin-core-dev
 26 2020-04-15T01:23:30  *** bitcoin-git has joined #bitcoin-core-dev
 27 2020-04-15T01:23:30  <bitcoin-git> [bitcoin] fanquake merged pull request #18632: doc: Fix macos comments in release-notes (master...2004-docMacOs) https://github.com/bitcoin/bitcoin/pull/18632
 28 2020-04-15T01:23:31  *** bitcoin-git has left #bitcoin-core-dev
 29 2020-04-15T01:36:23  *** amsudeep has joined #bitcoin-core-dev
 30 2020-04-15T01:39:14  *** mol has quit IRC
 31 2020-04-15T01:44:50  *** bitcoin-git has joined #bitcoin-core-dev
 32 2020-04-15T01:44:50  <bitcoin-git> [bitcoin] dongcarl opened pull request #18644: net: Reduce `TransportDeserializer` interface to 2 methods (master...2020-04-transport-readmessages) https://github.com/bitcoin/bitcoin/pull/18644
 33 2020-04-15T01:44:52  *** bitcoin-git has left #bitcoin-core-dev
 34 2020-04-15T01:47:45  *** captjakk has quit IRC
 35 2020-04-15T01:59:51  *** bitcoin-git has joined #bitcoin-core-dev
 36 2020-04-15T01:59:51  <bitcoin-git> [bitcoin] jnewbery opened pull request #18645: [doc] Update thread information in developer docs (master...2020-04-doc-threads) https://github.com/bitcoin/bitcoin/pull/18645
 37 2020-04-15T01:59:52  *** bitcoin-git has left #bitcoin-core-dev
 38 2020-04-15T02:05:38  *** ddustin has joined #bitcoin-core-dev
 39 2020-04-15T02:06:34  *** diogorsergio has joined #bitcoin-core-dev
 40 2020-04-15T02:12:12  *** ddustin has quit IRC
 41 2020-04-15T02:14:01  *** diogorsergio has quit IRC
 42 2020-04-15T02:15:04  *** diogorsergio has joined #bitcoin-core-dev
 43 2020-04-15T02:17:03  *** jb55 has quit IRC
 44 2020-04-15T02:19:34  <sipa> Apparently Satoshi also "buried" forks: https://github.com/bitcoin/bitcoin/commit/5cbf75324d1509a1262b65c5073314a4da3f6d77
 45 2020-04-15T02:20:55  <sipa> I wasn't aware before, but the 201 opcode limit, and the 20 keys in CHECKMULTISIG limit were initially only active for blocks >84000; in it was changed to apply to every block
 46 2020-04-15T02:21:11  *** captjakk has joined #bitcoin-core-dev
 47 2020-04-15T02:27:50  <aj> block 84000 was a week away when the rule was added, and 10 days old when the rule was buried, give or take; neat
 48 2020-04-15T02:28:04  *** jb55 has joined #bitcoin-core-dev
 49 2020-04-15T02:29:19  <sipa> Yeah, best practices around timelines for these things *do* seem to have changed a bit since.
 50 2020-04-15T02:30:01  <sipa> Also, the commit message is great. "misc fixes"
 51 2020-04-15T02:31:44  <fanquake> I guess the covert change hiding commit messages have improved since then too
 52 2020-04-15T02:33:26  <sipa> i think satoshi wrote commit messages like we write release notes
 53 2020-04-15T02:33:47  <sipa> try to remember everything that changed since the last one, probably forget some parts
 54 2020-04-15T02:35:52  <midnight> satoshi hid all kinds of weird stuff that I wish he'd been more posthoc open about. :(
 55 2020-04-15T02:37:56  *** captjakk has quit IRC
 56 2020-04-15T02:38:11  *** captjakk has joined #bitcoin-core-dev
 57 2020-04-15T02:39:19  *** Jackielove4u_ has quit IRC
 58 2020-04-15T02:40:06  <sipa> midnight: i'm speculating of course, but i think he simply didn't really have an open-source minded process
 59 2020-04-15T02:40:46  <sipa> as in, i don't think he was trying to hide anything - i think he just didn't care enough to write good notes
 60 2020-04-15T02:41:45  <midnight> sipa: I felt the store-proxy-for-later-use-in-spite-of-what-the-user-wants was a bit anti-user.
 61 2020-04-15T02:42:33  <sipa> ?
 62 2020-04-15T02:42:57  <sipa> elaborate
 63 2020-04-15T02:43:52  <midnight> At one point I gave my bitcoind a proxy to connect through, which worked successfully. Later I wanted to stop using the proxy, but I hadn't correctly opened the network up on that machine. The proxy settings were stored in wallet.dat and (IIRC) the software tried to use it anyway when it couldn't connect normally. In my view this was super sneaky.
 64 2020-04-15T02:44:31  <sipa> heh, that sounds like a bug
 65 2020-04-15T02:44:33  <midnight> IMO based on his fairly mercenary attempt to force open incoming sockets for global connectivity it was a deliberate and not accidental design decision.
 66 2020-04-15T02:44:57  <sipa> at the time every setting was stored in wallet.dat
 67 2020-04-15T02:45:24  <midnight> I hope it was a bug, but..  he was pretty mercenary about incentives and user control. I hope it was buggy and not intended behaviour. :)
 68 2020-04-15T02:45:33  <sipa> of course - you may be right
 69 2020-04-15T02:45:52  <sipa> but also, don't ascribe to malice that which is adequately explained by incompetence
 70 2020-04-15T02:46:02  <midnight> He never answered my question about it. That was around the time people were bashing him a lot about code quality.
 71 2020-04-15T02:47:03  <midnight> I was trying to be polite but the avalanche of inexplicable "your code sucks" might have made me sound like them. Hope not. Maybe he just didn't get my emails. :)
 72 2020-04-15T02:47:30  *** AaronvanW has joined #bitcoin-core-dev
 73 2020-04-15T02:49:22  <midnight> I don't think it was malice. Not quite how I'd describe it. More just.. taking user control out of the picture for the good of the early network.
 74 2020-04-15T02:50:09  <sipa> to an extent that is still the case - e.g. you can't request more than 8 outgoing connections
 75 2020-04-15T02:51:18  <midnight> Yeah I was okay with it. The source was available, and of course I could just manually edit wallet.dat to remove the proxy config.
 76 2020-04-15T02:51:38  <midnight> "You must be this tall to be able to control this feature.."
 77 2020-04-15T02:53:57  <midnight> Also possible: it was so long ago I am misremembering what actually happened and it was all just something I misconstrued. lol
 78 2020-04-15T02:59:04  <sipa> :)
 79 2020-04-15T03:00:02  *** ecrist1 has quit IRC
 80 2020-04-15T03:06:09  *** jeremyrubin has quit IRC
 81 2020-04-15T03:06:12  *** Deacyde has quit IRC
 82 2020-04-15T03:10:27  *** Klox has joined #bitcoin-core-dev
 83 2020-04-15T03:18:45  *** AaronvanW has quit IRC
 84 2020-04-15T03:21:42  *** I440r has joined #bitcoin-core-dev
 85 2020-04-15T03:41:46  *** mol has joined #bitcoin-core-dev
 86 2020-04-15T03:55:47  *** lightlike_ has joined #bitcoin-core-dev
 87 2020-04-15T03:58:44  *** lightlike has quit IRC
 88 2020-04-15T04:05:55  *** jnewbery has quit IRC
 89 2020-04-15T04:10:04  *** per_ has quit IRC
 90 2020-04-15T04:10:18  *** per has joined #bitcoin-core-dev
 91 2020-04-15T04:14:56  *** tryphe_ has joined #bitcoin-core-dev
 92 2020-04-15T04:17:25  *** tryphe has quit IRC
 93 2020-04-15T04:19:39  *** tryphe_ has quit IRC
 94 2020-04-15T04:27:23  *** amsudeep has quit IRC
 95 2020-04-15T04:27:58  *** jnewbery has joined #bitcoin-core-dev
 96 2020-04-15T04:34:54  *** Highway61 has quit IRC
 97 2020-04-15T04:39:55  *** promag has joined #bitcoin-core-dev
 98 2020-04-15T04:40:58  *** afk11` has quit IRC
 99 2020-04-15T04:41:45  *** afk11` has joined #bitcoin-core-dev
100 2020-04-15T04:44:18  *** promag has quit IRC
101 2020-04-15T04:48:29  *** tryphe has joined #bitcoin-core-dev
102 2020-04-15T04:48:52  *** DeanWeen has quit IRC
103 2020-04-15T04:49:22  *** DeanWeen has joined #bitcoin-core-dev
104 2020-04-15T05:12:02  *** captjakk has quit IRC
105 2020-04-15T05:12:37  *** captjakk has joined #bitcoin-core-dev
106 2020-04-15T05:16:07  *** AaronvanW has joined #bitcoin-core-dev
107 2020-04-15T05:17:37  *** captjakk has quit IRC
108 2020-04-15T05:18:18  *** I440r has quit IRC
109 2020-04-15T05:23:24  *** tw1sted1 has joined #bitcoin-core-dev
110 2020-04-15T05:33:17  *** tw1sted1 has quit IRC
111 2020-04-15T05:48:51  *** AaronvanW has quit IRC
112 2020-04-15T05:51:17  *** captjakk has joined #bitcoin-core-dev
113 2020-04-15T05:55:47  *** captjakk has quit IRC
114 2020-04-15T05:55:51  *** greylica has joined #bitcoin-core-dev
115 2020-04-15T05:59:27  *** Highway61 has joined #bitcoin-core-dev
116 2020-04-15T06:00:02  *** greylica has quit IRC
117 2020-04-15T06:05:59  *** Kiminuo has quit IRC
118 2020-04-15T06:15:13  *** Kiminuo has joined #bitcoin-core-dev
119 2020-04-15T06:22:04  *** vexed[vexed] has joined #bitcoin-core-dev
120 2020-04-15T06:45:51  *** Guyver2 has joined #bitcoin-core-dev
121 2020-04-15T06:57:17  *** bitcoin-git has joined #bitcoin-core-dev
122 2020-04-15T06:57:17  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4d793bcfe814...903be99ee654
123 2020-04-15T06:57:18  <bitcoin-git> bitcoin/master 88884ee MarcoFalke: script: Disallow silent bool -> CScript conversion
124 2020-04-15T06:57:18  <bitcoin-git> bitcoin/master 903be99 fanquake: Merge #18621: script: Disallow silent bool -> CScript conversion
125 2020-04-15T06:57:20  *** bitcoin-git has left #bitcoin-core-dev
126 2020-04-15T06:57:38  *** bitcoin-git has joined #bitcoin-core-dev
127 2020-04-15T06:57:38  <bitcoin-git> [bitcoin] fanquake merged pull request #18621: script: Disallow silent bool -> CScript conversion (master...2004-scriptNoBool) https://github.com/bitcoin/bitcoin/pull/18621
128 2020-04-15T06:57:39  *** bitcoin-git has left #bitcoin-core-dev
129 2020-04-15T06:59:33  *** jonatack has quit IRC
130 2020-04-15T07:00:26  *** jonatack has joined #bitcoin-core-dev
131 2020-04-15T07:11:58  *** lightlike_ has quit IRC
132 2020-04-15T07:17:32  *** bitcoin-git has joined #bitcoin-core-dev
133 2020-04-15T07:17:33  <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/903be99ee654...ae486b263c22
134 2020-04-15T07:17:34  <bitcoin-git> bitcoin/master b8b050a fanquake: build: add linker optimization flags to gitian descriptors
135 2020-04-15T07:17:35  <bitcoin-git> bitcoin/master f2b5b0a fanquake: build: add linker optimization flags to guix
136 2020-04-15T07:17:36  <bitcoin-git> bitcoin/master ae486b2 fanquake: Merge #17929: build: add linker optimisation flags to gitian & guix (Linux...
137 2020-04-15T07:17:37  *** bitcoin-git has left #bitcoin-core-dev
138 2020-04-15T07:18:16  *** bitcoin-git has joined #bitcoin-core-dev
139 2020-04-15T07:18:16  <bitcoin-git> [bitcoin] fanquake merged pull request #17929: build: add linker optimisation flags to gitian & guix (Linux) (master...pass_optimizations_to_linker) https://github.com/bitcoin/bitcoin/pull/17929
140 2020-04-15T07:18:17  *** bitcoin-git has left #bitcoin-core-dev
141 2020-04-15T07:19:17  *** EagleTM has joined #bitcoin-core-dev
142 2020-04-15T07:21:03  *** vincenzopalazzo has quit IRC
143 2020-04-15T07:29:34  *** jonatack_ has joined #bitcoin-core-dev
144 2020-04-15T07:31:07  *** bitcoin-git has joined #bitcoin-core-dev
145 2020-04-15T07:31:08  <bitcoin-git> [bitcoin] fanquake closed pull request #18490: Bugfix: devtools/symbol-check: Check PE libraries case-insensitively (master...bugfix_symcheck_pe_case) https://github.com/bitcoin/bitcoin/pull/18490
146 2020-04-15T07:31:09  *** bitcoin-git has left #bitcoin-core-dev
147 2020-04-15T07:32:12  *** bitcoin-git has joined #bitcoin-core-dev
148 2020-04-15T07:32:13  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ae486b263c22...5447d57bfff9
149 2020-04-15T07:32:14  <bitcoin-git> bitcoin/master c47adf8 Stephan Oeste: Added my fingerprint Stephan Oeste (Emzy)
150 2020-04-15T07:32:14  <bitcoin-git> bitcoin/master 5447d57 fanquake: Merge #18624: Added my fingerprint Stephan Oeste (Emzy)
151 2020-04-15T07:32:16  *** bitcoin-git has left #bitcoin-core-dev
152 2020-04-15T07:32:32  *** bitcoin-git has joined #bitcoin-core-dev
153 2020-04-15T07:32:33  <bitcoin-git> [bitcoin] fanquake merged pull request #18624: Added my fingerprint Stephan Oeste (Emzy) (master...patch-1) https://github.com/bitcoin/bitcoin/pull/18624
154 2020-04-15T07:32:33  *** bitcoin-git has left #bitcoin-core-dev
155 2020-04-15T07:32:54  *** jonatack has quit IRC
156 2020-04-15T07:38:28  *** bitcoin-git has joined #bitcoin-core-dev
157 2020-04-15T07:38:28  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5447d57bfff9...e831f18b1ed3
158 2020-04-15T07:38:29  <bitcoin-git> bitcoin/master 905e2e8 Jon Atack: gitian: add jonatack gpg key fingerprint
159 2020-04-15T07:38:29  <bitcoin-git> bitcoin/master e831f18 fanquake: Merge #18619: gitian: add jonatack gpg key fingerprint
160 2020-04-15T07:38:31  *** bitcoin-git has left #bitcoin-core-dev
161 2020-04-15T07:38:48  *** bitcoin-git has joined #bitcoin-core-dev
162 2020-04-15T07:38:48  <bitcoin-git> [bitcoin] fanquake merged pull request #18619: gitian: add jonatack gpg key fingerprint (master...gitian-jonatack-gpg-key-fingerprint) https://github.com/bitcoin/bitcoin/pull/18619
163 2020-04-15T07:38:49  *** bitcoin-git has left #bitcoin-core-dev
164 2020-04-15T07:40:43  *** mol_ has joined #bitcoin-core-dev
165 2020-04-15T07:41:13  *** vasild_ has joined #bitcoin-core-dev
166 2020-04-15T07:44:23  *** vasild has quit IRC
167 2020-04-15T07:44:24  *** vasild_ is now known as vasild
168 2020-04-15T07:45:03  *** mol has quit IRC
169 2020-04-15T07:46:02  *** captjakk has joined #bitcoin-core-dev
170 2020-04-15T07:46:04  *** AaronvanW has joined #bitcoin-core-dev
171 2020-04-15T07:47:21  *** bitcoin-git has joined #bitcoin-core-dev
172 2020-04-15T07:47:22  <bitcoin-git> [bitcoin] fanquake opened pull request #18646: gui: use PACKAGE_NAME in exception message (master...use_package_name_in_exception) https://github.com/bitcoin/bitcoin/pull/18646
173 2020-04-15T07:47:22  *** bitcoin-git has left #bitcoin-core-dev
174 2020-04-15T07:50:14  *** captjakk has quit IRC
175 2020-04-15T07:56:21  *** marcoagner has joined #bitcoin-core-dev
176 2020-04-15T08:11:48  *** AaronvanW has quit IRC
177 2020-04-15T08:12:03  *** AaronvanW has joined #bitcoin-core-dev
178 2020-04-15T08:25:51  *** marcoagner has quit IRC
179 2020-04-15T08:33:28  *** promag has joined #bitcoin-core-dev
180 2020-04-15T08:40:24  *** Jackielove4u_ has joined #bitcoin-core-dev
181 2020-04-15T08:41:27  *** Jackielove4u_ has joined #bitcoin-core-dev
182 2020-04-15T08:42:01  *** Jackielove4u_ has quit IRC
183 2020-04-15T08:42:23  *** Jackielove4u has joined #bitcoin-core-dev
184 2020-04-15T08:43:52  *** Kiminuo has quit IRC
185 2020-04-15T08:43:59  *** guest534543 has joined #bitcoin-core-dev
186 2020-04-15T08:44:17  *** amsudeep has joined #bitcoin-core-dev
187 2020-04-15T08:51:17  *** Guyver2_ has joined #bitcoin-core-dev
188 2020-04-15T08:54:26  *** Guyver2 has quit IRC
189 2020-04-15T08:59:26  *** AaronvanW has quit IRC
190 2020-04-15T09:00:01  *** vexed[vexed] has quit IRC
191 2020-04-15T09:05:42  *** emilengler has joined #bitcoin-core-dev
192 2020-04-15T09:08:32  *** timothy has joined #bitcoin-core-dev
193 2020-04-15T09:13:25  *** DeanWeen has quit IRC
194 2020-04-15T09:13:46  *** DeanWeen has joined #bitcoin-core-dev
195 2020-04-15T09:14:49  *** Guyver2_ has quit IRC
196 2020-04-15T09:14:51  *** Eagle[TM] has joined #bitcoin-core-dev
197 2020-04-15T09:15:41  *** EagleTM has quit IRC
198 2020-04-15T09:22:19  *** quaid1 has joined #bitcoin-core-dev
199 2020-04-15T09:28:14  *** Eagle[TM] has quit IRC
200 2020-04-15T09:43:06  *** bitcoin-git has joined #bitcoin-core-dev
201 2020-04-15T09:43:06  <bitcoin-git> [bitcoin] brakmic opened pull request #18647: rpc: remove g_rpc_node (master...remove-global-node-ctx) https://github.com/bitcoin/bitcoin/pull/18647
202 2020-04-15T09:43:13  *** bitcoin-git has left #bitcoin-core-dev
203 2020-04-15T09:46:59  *** captjakk has joined #bitcoin-core-dev
204 2020-04-15T09:51:08  *** brakmic has joined #bitcoin-core-dev
205 2020-04-15T09:51:31  *** captjakk has quit IRC
206 2020-04-15T10:03:57  *** Yasmeen65Pouros has joined #bitcoin-core-dev
207 2020-04-15T10:08:34  *** Yasmeen65Pouros has quit IRC
208 2020-04-15T10:12:50  *** bitcoin-git has joined #bitcoin-core-dev
209 2020-04-15T10:12:50  <bitcoin-git> [bitcoin] practicalswift opened pull request #18649: tests: Add std::locale::global to list of locale dependent functions in lint-locale-dependence.sh (master...locale-dependent-functions) https://github.com/bitcoin/bitcoin/pull/18649
210 2020-04-15T10:12:51  *** bitcoin-git has left #bitcoin-core-dev
211 2020-04-15T10:13:25  *** timothy has quit IRC
212 2020-04-15T10:15:29  *** jonatack__ has joined #bitcoin-core-dev
213 2020-04-15T10:18:35  *** jonatack_ has quit IRC
214 2020-04-15T10:28:23  *** mytwocentimes has quit IRC
215 2020-04-15T10:30:30  *** mytwocentimes has joined #bitcoin-core-dev
216 2020-04-15T10:37:47  *** mytwocentimes has quit IRC
217 2020-04-15T10:38:04  *** mytwocentimes has joined #bitcoin-core-dev
218 2020-04-15T10:45:11  *** mytwocentimes has quit IRC
219 2020-04-15T10:45:45  *** mytwocentimes has joined #bitcoin-core-dev
220 2020-04-15T10:53:20  *** timothy has joined #bitcoin-core-dev
221 2020-04-15T11:00:50  *** jonatack__ has quit IRC
222 2020-04-15T11:01:25  *** jonatack__ has joined #bitcoin-core-dev
223 2020-04-15T11:02:37  *** bitcoin-git has joined #bitcoin-core-dev
224 2020-04-15T11:02:37  <bitcoin-git> [bitcoin] practicalswift opened pull request #18650: qt: Make bitcoin.ico non-executable (master...bitcoin.ico-executable-flag) https://github.com/bitcoin/bitcoin/pull/18650
225 2020-04-15T11:02:38  *** bitcoin-git has left #bitcoin-core-dev
226 2020-04-15T11:17:54  *** alec has quit IRC
227 2020-04-15T11:23:08  *** alec has joined #bitcoin-core-dev
228 2020-04-15T11:25:52  *** mytwocen_ has joined #bitcoin-core-dev
229 2020-04-15T11:27:06  *** yevaud has quit IRC
230 2020-04-15T11:27:24  *** yevaud has joined #bitcoin-core-dev
231 2020-04-15T11:28:19  *** mytwocentimes has quit IRC
232 2020-04-15T11:32:41  *** bitcoin-git has joined #bitcoin-core-dev
233 2020-04-15T11:32:41  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e831f18b1ed3...18f11fb24b47
234 2020-04-15T11:32:42  <bitcoin-git> bitcoin/master 1b04302 fanquake: gui: use PACKAGE_NAME in exception message
235 2020-04-15T11:32:42  <bitcoin-git> bitcoin/master 18f11fb MarcoFalke: Merge #18646: gui: use PACKAGE_NAME in exception message
236 2020-04-15T11:32:44  *** bitcoin-git has left #bitcoin-core-dev
237 2020-04-15T11:33:01  *** bitcoin-git has joined #bitcoin-core-dev
238 2020-04-15T11:33:01  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18646: gui: use PACKAGE_NAME in exception message (master...use_package_name_in_exception) https://github.com/bitcoin/bitcoin/pull/18646
239 2020-04-15T11:33:02  *** bitcoin-git has left #bitcoin-core-dev
240 2020-04-15T11:40:54  *** promag_ has quit IRC
241 2020-04-15T11:40:55  *** promag has quit IRC
242 2020-04-15T11:44:41  *** promag_ has joined #bitcoin-core-dev
243 2020-04-15T11:44:55  *** promag__ has joined #bitcoin-core-dev
244 2020-04-15T11:47:53  *** captjakk has joined #bitcoin-core-dev
245 2020-04-15T11:49:30  *** promag_ has quit IRC
246 2020-04-15T11:50:04  *** promag has joined #bitcoin-core-dev
247 2020-04-15T11:52:11  *** captjakk has quit IRC
248 2020-04-15T11:56:31  *** promag has quit IRC
249 2020-04-15T11:57:10  *** promag has joined #bitcoin-core-dev
250 2020-04-15T12:00:02  *** quaid1 has quit IRC
251 2020-04-15T12:03:29  *** promag has quit IRC
252 2020-04-15T12:04:15  *** promag has joined #bitcoin-core-dev
253 2020-04-15T12:05:27  *** promag has quit IRC
254 2020-04-15T12:06:16  *** promag has joined #bitcoin-core-dev
255 2020-04-15T12:06:44  *** promag has quit IRC
256 2020-04-15T12:07:26  *** promag has joined #bitcoin-core-dev
257 2020-04-15T12:09:04  *** promag has joined #bitcoin-core-dev
258 2020-04-15T12:21:51  *** gac410 has joined #bitcoin-core-dev
259 2020-04-15T12:22:16  *** gac410 is now known as Guest84865
260 2020-04-15T12:27:31  *** promag has quit IRC
261 2020-04-15T12:28:03  *** promag has joined #bitcoin-core-dev
262 2020-04-15T12:28:31  *** bitcoin-git has joined #bitcoin-core-dev
263 2020-04-15T12:28:31  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/18f11fb24b47...20c0e2e0f04f
264 2020-04-15T12:28:32  <bitcoin-git> bitcoin/master fa4c29b MarcoFalke: test: Add various low-level p2p tests
265 2020-04-15T12:28:32  <bitcoin-git> bitcoin/master 20c0e2e MarcoFalke: Merge #18628: test: Add various low-level p2p tests
266 2020-04-15T12:28:34  *** bitcoin-git has left #bitcoin-core-dev
267 2020-04-15T12:28:51  *** bitcoin-git has joined #bitcoin-core-dev
268 2020-04-15T12:28:51  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18628: test: Add various low-level p2p tests (master...2004-qaP2Pvar) https://github.com/bitcoin/bitcoin/pull/18628
269 2020-04-15T12:28:58  *** bitcoin-git has left #bitcoin-core-dev
270 2020-04-15T12:33:43  *** jonatack__ has quit IRC
271 2020-04-15T12:34:16  *** jonatack has joined #bitcoin-core-dev
272 2020-04-15T12:41:46  *** mytwocen_ has quit IRC
273 2020-04-15T12:42:00  *** mytwocentimes has joined #bitcoin-core-dev
274 2020-04-15T12:43:04  *** theStack has joined #bitcoin-core-dev
275 2020-04-15T12:44:28  *** michaelfolkson has joined #bitcoin-core-dev
276 2020-04-15T13:00:49  *** AaronvanW has joined #bitcoin-core-dev
277 2020-04-15T13:04:07  *** mol has joined #bitcoin-core-dev
278 2020-04-15T13:04:29  *** promag has quit IRC
279 2020-04-15T13:04:44  *** promag has joined #bitcoin-core-dev
280 2020-04-15T13:06:56  *** mol_ has quit IRC
281 2020-04-15T13:26:06  *** guest534543 has quit IRC
282 2020-04-15T13:26:25  *** guest534543 has joined #bitcoin-core-dev
283 2020-04-15T13:26:58  *** thunderbiscuit[m has joined #bitcoin-core-dev
284 2020-04-15T13:34:26  *** mol has quit IRC
285 2020-04-15T13:48:40  *** captjakk has joined #bitcoin-core-dev
286 2020-04-15T13:48:41  *** mol has joined #bitcoin-core-dev
287 2020-04-15T13:53:13  *** captjakk has quit IRC
288 2020-04-15T13:56:22  <jnewbery> MarcoFalke fanquake: if you're looking for more to merge, I think #18401 is ready
289 2020-04-15T13:56:25  <gribble> https://github.com/bitcoin/bitcoin/issues/18401 | Refactor: Initialize PrecomputedTransactionData in CheckInputScripts by jnewbery · Pull Request #18401 · bitcoin/bitcoin · GitHub
290 2020-04-15T13:59:19  *** mol has quit IRC
291 2020-04-15T13:59:19  *** diogorsergio has quit IRC
292 2020-04-15T14:04:14  *** mol has joined #bitcoin-core-dev
293 2020-04-15T14:10:43  *** ddustin has joined #bitcoin-core-dev
294 2020-04-15T14:13:52  *** filchef has joined #bitcoin-core-dev
295 2020-04-15T14:16:59  *** theStack has quit IRC
296 2020-04-15T14:17:17  *** theStack has joined #bitcoin-core-dev
297 2020-04-15T14:23:02  *** theStack has quit IRC
298 2020-04-15T14:25:14  *** theStack has joined #bitcoin-core-dev
299 2020-04-15T14:34:50  *** theStack has quit IRC
300 2020-04-15T14:35:59  *** guest534543 has quit IRC
301 2020-04-15T14:36:06  *** theStack has joined #bitcoin-core-dev
302 2020-04-15T14:39:39  <theStack> i'm just running the fuzz test from #17860
303 2020-04-15T14:39:41  <gribble> https://github.com/bitcoin/bitcoin/issues/17860 | fuzz: BIP 42, BIP 30, CVE-2018-17144 by MarcoFalke · Pull Request #17860 · bitcoin/bitcoin · GitHub
304 2020-04-15T14:40:02  <theStack> can anyone tell me how i know if the fuzz test found something significant? (as far as i remember the fuzz test never stops, i.e. only after receiving CTRL+C)
305 2020-04-15T14:42:57  <jonatack> theStack: you'll see a crash like https://github.com/bitcoin/bitcoin/pull/18521#issuecomment-610826738
306 2020-04-15T14:43:37  *** lucaferr has quit IRC
307 2020-04-15T14:43:58  <jonatack> (you are correct that the fuzzer runs indefinitely until halted)
308 2020-04-15T14:45:01  <jonatack> (and on encountering an error, the fuzzer halts)
309 2020-04-15T14:45:39  *** captjakk has joined #bitcoin-core-dev
310 2020-04-15T14:48:13  *** vincenzopalazzo has joined #bitcoin-core-dev
311 2020-04-15T14:49:18  <theStack> jonatack: so after this crash the fuzz test process would just stop?
312 2020-04-15T14:50:06  <jonatack> theStack: yes (this was my first question with the fuzzer, too :)
313 2020-04-15T14:50:19  *** ddustin has quit IRC
314 2020-04-15T14:50:56  <theStack> jonatack: thanks, good to know. i thought it *really* runs indefinitely in all cases and e.g. writes out a file in case of crashes
315 2020-04-15T14:51:58  *** ddustin has joined #bitcoin-core-dev
316 2020-04-15T14:54:02  <theStack> what if the error we want to trigger is not a crash? If we take BIP 42, that doesn't result in a crash, but inflation
317 2020-04-15T14:54:15  <theStack> how would the fuzzer know the condition of an, i call it "significant event"?
318 2020-04-15T14:56:25  <jonatack> theStack: the fuzzer may have an option to do that... i don't see one like that in test/fuzz/test_runner.py, but you can set -loglevel)#
319 2020-04-15T14:56:52  *** ddustin has quit IRC
320 2020-04-15T14:57:21  *** andrewtoth has joined #bitcoin-core-dev
321 2020-04-15T14:58:07  <andrewtoth> theStack that specific inflation condition is asserted here https://github.com/bitcoin/bitcoin/pull/17860/files#diff-7a6cf1c54083f72e3110c6a049e26842R77
322 2020-04-15T15:00:01  *** Guest84865 has quit IRC
323 2020-04-15T15:00:53  *** EagleTM has joined #bitcoin-core-dev
324 2020-04-15T15:01:12  <andrewtoth> so I guess the fuzz harness should consider all "significant events" and assert them
325 2020-04-15T15:01:35  *** captjakk has quit IRC
326 2020-04-15T15:01:49  <theStack> jonatack: oh, i didn't even use the fuzz test-runner yet, but rather called the binaries in src/test/fuzz/ directly
327 2020-04-15T15:02:16  <theStack> andrewtoth: ah, just by using assertions -- that makes sense
328 2020-04-15T15:02:51  *** captjakk has joined #bitcoin-core-dev
329 2020-04-15T15:03:10  <jonatack> theStack: that's probably best, i haven't got the runner to work yet and iiuc it's for the ci. was just looking in https://github.com/google/afl for more info on configurations
330 2020-04-15T15:04:18  <jonatack> theStack: calling directly like you're doing is more useful for testing PRs with new harnesses
331 2020-04-15T15:08:00  *** bitcoin-git has joined #bitcoin-core-dev
332 2020-04-15T15:08:01  <bitcoin-git> [bitcoin] jonatack opened pull request #18653:  test: add coverage for bitcoin-cli -rpcwait (master...rpcwait-test-coverage) https://github.com/bitcoin/bitcoin/pull/18653
333 2020-04-15T15:08:02  *** bitcoin-git has left #bitcoin-core-dev
334 2020-04-15T15:08:06  *** ddustin has joined #bitcoin-core-dev
335 2020-04-15T15:10:43  <theStack> jonatack: it seems like test_runner.py was mentioned in doc/fuzzing.md some weeks ago but now it's not anymore
336 2020-04-15T15:13:02  <jonatack> theStack: makes sense, i seem to recall MarcoFalke saying the runner script was really for the ci, after instagibbs and i were trying to run it unsuccessfully a couple months ago
337 2020-04-15T15:13:47  <jonatack> i was just peeking inside to see the config options
338 2020-04-15T15:14:54  <MarcoFalke> test_runner is for running over all inputs, which is useful for running against every commit
339 2020-04-15T15:15:07  <MarcoFalke> So mostly ci, not for extending fuzz coverage
340 2020-04-15T15:22:36  <theStack> jonatack: MarcoFalke: ok, so i will ignore that script for now
341 2020-04-15T15:31:01  *** justanotheruser has quit IRC
342 2020-04-15T15:35:11  *** EagleTM has quit IRC
343 2020-04-15T15:48:21  *** justanotheruser has joined #bitcoin-core-dev
344 2020-04-15T15:53:52  *** Talkless has joined #bitcoin-core-dev
345 2020-04-15T15:55:40  *** carldani has joined #bitcoin-core-dev
346 2020-04-15T15:55:50  *** diogorsergio has joined #bitcoin-core-dev
347 2020-04-15T16:06:14  *** mol has quit IRC
348 2020-04-15T16:06:50  *** as_pnn has joined #bitcoin-core-dev
349 2020-04-15T16:10:15  *** timothy has quit IRC
350 2020-04-15T16:15:23  *** kristapsk has quit IRC
351 2020-04-15T16:15:57  *** lightlike has joined #bitcoin-core-dev
352 2020-04-15T16:17:35  *** DeanWeen has quit IRC
353 2020-04-15T16:18:06  *** DeanWeen has joined #bitcoin-core-dev
354 2020-04-15T16:18:15  *** Kiminuo has joined #bitcoin-core-dev
355 2020-04-15T16:20:38  *** andrewtoth_ has joined #bitcoin-core-dev
356 2020-04-15T16:22:43  *** andrewtoth has quit IRC
357 2020-04-15T16:23:31  *** ddustin has quit IRC
358 2020-04-15T16:23:33  *** shaunsun has joined #bitcoin-core-dev
359 2020-04-15T16:23:36  *** shaunsun_ has joined #bitcoin-core-dev
360 2020-04-15T16:25:54  *** shaunsun__ has joined #bitcoin-core-dev
361 2020-04-15T16:27:38  *** andrewtoth_ has quit IRC
362 2020-04-15T16:28:20  *** shaunsun has quit IRC
363 2020-04-15T16:28:39  *** shaunsun_ has quit IRC
364 2020-04-15T16:34:52  *** marcus47 has joined #bitcoin-core-dev
365 2020-04-15T16:43:56  *** jeremyrubin has joined #bitcoin-core-dev
366 2020-04-15T16:44:34  *** fearbeag has joined #bitcoin-core-dev
367 2020-04-15T16:45:19  *** andrewtoth has joined #bitcoin-core-dev
368 2020-04-15T16:51:57  *** michaelfolkson has joined #bitcoin-core-dev
369 2020-04-15T16:59:00  *** shaunsun__ has quit IRC
370 2020-04-15T16:59:10  *** shaunsun__ has joined #bitcoin-core-dev
371 2020-04-15T17:28:40  *** marcus47 has quit IRC
372 2020-04-15T17:43:34  *** filchef has quit IRC
373 2020-04-15T17:51:10  *** IGHOR has joined #bitcoin-core-dev
374 2020-04-15T17:52:12  *** mytwocentimes has quit IRC
375 2020-04-15T17:54:08  *** captjakk has quit IRC
376 2020-04-15T18:00:02  *** carldani has quit IRC
377 2020-04-15T18:04:37  *** captjakk has joined #bitcoin-core-dev
378 2020-04-15T18:05:52  *** captjakk has quit IRC
379 2020-04-15T18:06:24  *** captjakk has joined #bitcoin-core-dev
380 2020-04-15T18:07:33  *** captjakk has quit IRC
381 2020-04-15T18:07:45  *** captjakk has joined #bitcoin-core-dev
382 2020-04-15T18:08:37  *** jarthur has joined #bitcoin-core-dev
383 2020-04-15T18:09:46  *** mol has joined #bitcoin-core-dev
384 2020-04-15T18:20:46  *** mytwocentimes has joined #bitcoin-core-dev
385 2020-04-15T18:22:05  *** Mikaela1 has joined #bitcoin-core-dev
386 2020-04-15T18:23:54  *** brianhoffman has quit IRC
387 2020-04-15T18:24:43  *** mol_ has joined #bitcoin-core-dev
388 2020-04-15T18:26:21  *** brianhoffman has joined #bitcoin-core-dev
389 2020-04-15T18:27:49  *** mol has quit IRC
390 2020-04-15T18:33:41  *** amsudeep has quit IRC
391 2020-04-15T18:35:53  *** as_pnn has quit IRC
392 2020-04-15T18:37:12  *** bitcoin-git has joined #bitcoin-core-dev
393 2020-04-15T18:37:12  <bitcoin-git> [bitcoin] theStack closed pull request #16922: net: filteradd message: update bloom filter empty/full flags after adding (master...20190919-net-update_empty_full_after_adding_filter) https://github.com/bitcoin/bitcoin/pull/16922
394 2020-04-15T18:37:13  *** bitcoin-git has left #bitcoin-core-dev
395 2020-04-15T18:39:39  *** Highway61 has quit IRC
396 2020-04-15T18:40:05  *** bitcoin-git has joined #bitcoin-core-dev
397 2020-04-15T18:40:05  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/20c0e2e0f04f...4bd6bc5cb4f3
398 2020-04-15T18:40:05  <bitcoin-git> bitcoin/master fa176e2 MarcoFalke: test: Avoid accessing free'd memory in validation_chainstatemanager_tests
399 2020-04-15T18:40:06  <bitcoin-git> bitcoin/master 4bd6bc5 MarcoFalke: Merge #18615: test: Avoid accessing free'd memory in validation_chainstate...
400 2020-04-15T18:40:07  *** bitcoin-git has left #bitcoin-core-dev
401 2020-04-15T18:40:21  *** kristapsk has joined #bitcoin-core-dev
402 2020-04-15T18:40:25  *** bitcoin-git has joined #bitcoin-core-dev
403 2020-04-15T18:40:25  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18615: test: Avoid accessing free'd memory in validation_chainstatemanager_tests (master...2004-testNoAccessFreeMem) https://github.com/bitcoin/bitcoin/pull/18615
404 2020-04-15T18:40:27  *** bitcoin-git has left #bitcoin-core-dev
405 2020-04-15T18:44:36  *** theStack has quit IRC
406 2020-04-15T18:44:57  *** fearbeag has quit IRC
407 2020-04-15T18:53:02  *** bitcoin-git has joined #bitcoin-core-dev
408 2020-04-15T18:53:03  <bitcoin-git> [bitcoin] achow101 opened pull request #18654: rpc: separate bumpfee' (master...psbtbumpfee) https://github.com/bitcoin/bitcoin/pull/18654
409 2020-04-15T18:53:04  *** bitcoin-git has left #bitcoin-core-dev
410 2020-04-15T18:55:52  *** kabaum has quit IRC
411 2020-04-15T18:58:02  *** bitcoin-git has joined #bitcoin-core-dev
412 2020-04-15T18:58:03  <bitcoin-git> [bitcoin] achow101 opened pull request #18655: gui: Add bumpFeePSBT action instead of changing normal bumpfee behavior (master...split-bumpfeeaction) https://github.com/bitcoin/bitcoin/pull/18655
413 2020-04-15T18:58:04  *** bitcoin-git has left #bitcoin-core-dev
414 2020-04-15T19:00:15  *** bitcoin-git has joined #bitcoin-core-dev
415 2020-04-15T19:00:15  <bitcoin-git> [bitcoin] achow101 opened pull request #18656: gui: Add a `Make unsigned` button next to `Send` (master...make-unsigned-button) https://github.com/bitcoin/bitcoin/pull/18656
416 2020-04-15T19:00:16  *** bitcoin-git has left #bitcoin-core-dev
417 2020-04-15T19:01:00  *** bitcoin-git has joined #bitcoin-core-dev
418 2020-04-15T19:01:00  <bitcoin-git> [bitcoin] achow101 closed pull request #18627: rpc: gui: Don't change behavior based on private keys disabled, instead add new buttons/rpcs/menu items (master...split-watchonly) https://github.com/bitcoin/bitcoin/pull/18627
419 2020-04-15T19:01:01  *** bitcoin-git has left #bitcoin-core-dev
420 2020-04-15T19:06:56  *** michaelfolkson has quit IRC
421 2020-04-15T19:07:58  *** mytwocentimes has quit IRC
422 2020-04-15T19:08:29  *** kabaum has joined #bitcoin-core-dev
423 2020-04-15T19:10:02  *** michaelfolkson has joined #bitcoin-core-dev
424 2020-04-15T19:10:44  *** michaelfolkson has quit IRC
425 2020-04-15T19:11:13  *** Highway61 has joined #bitcoin-core-dev
426 2020-04-15T19:22:11  *** EagleTM has joined #bitcoin-core-dev
427 2020-04-15T19:26:33  *** masterdonx2 has quit IRC
428 2020-04-15T19:27:04  *** MasterdonX has joined #bitcoin-core-dev
429 2020-04-15T19:28:07  *** Talkless has quit IRC
430 2020-04-15T19:29:30  *** en1on is now known as en10n
431 2020-04-15T19:35:06  *** Guyver2 has joined #bitcoin-core-dev
432 2020-04-15T19:38:35  *** DeanWeen has quit IRC
433 2020-04-15T19:38:50  *** DeanWeen has joined #bitcoin-core-dev
434 2020-04-15T19:44:23  *** vasild has quit IRC
435 2020-04-15T19:46:25  *** vasild has joined #bitcoin-core-dev
436 2020-04-15T19:52:51  *** ghost1 has joined #bitcoin-core-dev
437 2020-04-15T19:56:03  <vasild> dongcarl: If you use `-onlynet=torv3`, then there is no way that you would connect to an old node that does not understand `addrv2` because such node cannot exist - there is no way that it can advertise its `torv3` address using the old `addr` messages.
438 2020-04-15T19:56:39  <vasild> Or am I totally confused? (wrt https://github.com/bitcoin/bips/pull/766#issuecomment-614141273)
439 2020-04-15T19:59:12  *** bitcoin-git has joined #bitcoin-core-dev
440 2020-04-15T19:59:12  <bitcoin-git> [bitcoin] practicalswift opened pull request #18657: chain: Do not fill out parameters in findCommonAncestor(...) if ancestor is not found (master...out-parameters-in-findCommonAncestor) https://github.com/bitcoin/bitcoin/pull/18657
441 2020-04-15T19:59:13  *** bitcoin-git has left #bitcoin-core-dev
442 2020-04-15T20:00:14  *** owowo has quit IRC
443 2020-04-15T20:00:15  *** brianhoffman has quit IRC
444 2020-04-15T20:02:02  *** owowo has joined #bitcoin-core-dev
445 2020-04-15T20:03:09  *** jorijn has quit IRC
446 2020-04-15T20:03:43  *** vasild has quit IRC
447 2020-04-15T20:05:53  *** vasild has joined #bitcoin-core-dev
448 2020-04-15T20:11:39  *** DeanWeen has quit IRC
449 2020-04-15T20:12:31  *** DeanWeen has joined #bitcoin-core-dev
450 2020-04-15T20:18:41  <elichai2> ariard  told me there is past interaction with oss-fuzz and it was decided that the disclosure policy doesn't fit Core, is that right? I'm interested to hear about it :)
451 2020-04-15T20:19:22  <sipa> ping BlueMatt
452 2020-04-15T20:20:40  <sipa> though if i remember correctly, at the time there also was no (meaningful) fuzzers for bitcoin core, so it was mostly a philosophical point
453 2020-04-15T20:21:53  *** bitcoin-git has joined #bitcoin-core-dev
454 2020-04-15T20:21:54  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4bd6bc5cb4f3...6db8ef2431ac
455 2020-04-15T20:21:54  <bitcoin-git> bitcoin/master fac0c8d MarcoFalke: appveyor: Remove clcache
456 2020-04-15T20:21:55  <bitcoin-git> bitcoin/master 6db8ef2 MarcoFalke: Merge #18640: appveyor: Remove clcache
457 2020-04-15T20:21:56  *** bitcoin-git has left #bitcoin-core-dev
458 2020-04-15T20:22:13  *** bitcoin-git has joined #bitcoin-core-dev
459 2020-04-15T20:22:14  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18640: appveyor: Remove clcache (master...2004-appveyorNoSlowCache) https://github.com/bitcoin/bitcoin/pull/18640
460 2020-04-15T20:22:15  *** bitcoin-git has left #bitcoin-core-dev
461 2020-04-15T20:32:32  *** bitcoin-git has joined #bitcoin-core-dev
462 2020-04-15T20:32:32  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6db8ef2431ac...e84a5f000493
463 2020-04-15T20:32:33  <bitcoin-git> bitcoin/master 808ef36 John Newbery: [doc] Update thread information in developer docs
464 2020-04-15T20:32:33  <bitcoin-git> bitcoin/master e84a5f0 MarcoFalke: Merge #18645: [doc] Update thread information in developer docs
465 2020-04-15T20:32:35  *** bitcoin-git has left #bitcoin-core-dev
466 2020-04-15T20:32:52  *** bitcoin-git has joined #bitcoin-core-dev
467 2020-04-15T20:32:52  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18645: [doc] Update thread information in developer docs (master...2020-04-doc-threads) https://github.com/bitcoin/bitcoin/pull/18645
468 2020-04-15T20:32:53  *** bitcoin-git has left #bitcoin-core-dev
469 2020-04-15T20:35:15  *** dviola has joined #bitcoin-core-dev
470 2020-04-15T20:36:23  *** per has quit IRC
471 2020-04-15T20:36:43  *** per has joined #bitcoin-core-dev
472 2020-04-15T20:39:34  *** jorijn has joined #bitcoin-core-dev
473 2020-04-15T20:44:15  *** jb55 has quit IRC
474 2020-04-15T20:44:49  *** ctrlbreak_MAD is now known as ctrlbreak
475 2020-04-15T20:45:32  *** mytwocentimes has joined #bitcoin-core-dev
476 2020-04-15T20:47:18  *** diogorsergio has quit IRC
477 2020-04-15T20:58:37  *** jb55 has joined #bitcoin-core-dev
478 2020-04-15T21:00:02  *** Mikaela1 has quit IRC
479 2020-04-15T21:02:52  *** bitcoin-git has joined #bitcoin-core-dev
480 2020-04-15T21:02:52  <bitcoin-git> [bitcoin] practicalswift closed pull request #18657: chain: Do not fill out parameters in findCommonAncestor(...) if ancestor is not found (master...out-parameters-in-findCommonAncestor) https://github.com/bitcoin/bitcoin/pull/18657
481 2020-04-15T21:02:53  *** bitcoin-git has left #bitcoin-core-dev
482 2020-04-15T21:04:55  *** jonatack has quit IRC
483 2020-04-15T21:05:12  *** brianhoffman has joined #bitcoin-core-dev
484 2020-04-15T21:06:46  *** jonatack has joined #bitcoin-core-dev
485 2020-04-15T21:08:14  *** shaunsun__ has quit IRC
486 2020-04-15T21:10:57  *** bitcoin-git has joined #bitcoin-core-dev
487 2020-04-15T21:10:58  <bitcoin-git> [bitcoin] ryanofsky opened pull request #18660: test: Verify findCommonAncestor always initializes outputs (master...pr/commoninit) https://github.com/bitcoin/bitcoin/pull/18660
488 2020-04-15T21:10:59  *** bitcoin-git has left #bitcoin-core-dev
489 2020-04-15T21:19:03  <BlueMatt> elichai2: yea, oss-fuzz has some rather-strict rules about how they will disclose issues publicly after N days of reporting them.
490 2020-04-15T21:19:36  *** captjakk has quit IRC
491 2020-04-15T21:20:08  *** captjakk has joined #bitcoin-core-dev
492 2020-04-15T21:20:11  <BlueMatt> elichai2: at the time, and imo quite reasonably, we decided that was completely unacceptable for a p2p consensus system which may, depending on the type of failure, require network-wide update for something to be safe, and some rapid disclosure policy is not compatible with that
493 2020-04-15T21:20:52  <BlueMatt> elichai2: also note that oss-fuzz primarily just provides cpu hours, it doesn't do any actual implementation work for you, and getting access to a few hundred cores for bitcoin core fuzzing is rather easy :p
494 2020-04-15T21:21:12  <sipa> BlueMatt: on the other hand, we currently have fuzzers for the codebase (yay), and we can't prevent anyone from running them secretly on a massive cluster
495 2020-04-15T21:21:13  <BlueMatt> (as a reminder: lots of cpu cores are available in a few locations for those doing bitcoin open source work)
496 2020-04-15T21:21:39  <BlueMatt> sipa: sadly they're mostly all kinda boring targets :(
497 2020-04-15T21:21:55  <BlueMatt> but we *have* a few rather reasonably-sized clusters in various places...
498 2020-04-15T21:22:01  <sipa> BlueMatt: have you paid attention to the more recently added ones?
499 2020-04-15T21:22:04  <BlueMatt> dont think any are currently fuzzing core, but...
500 2020-04-15T21:22:05  *** Frost1 has joined #bitcoin-core-dev
501 2020-04-15T21:22:50  <BlueMatt> ah, marco's fuzz stuff got merged! I missed that.
502 2020-04-15T21:23:52  <sipa> so perhaps... either we keep the more delicate ones private (how?), or we're ok with having the ones we have publicly participate in oss-fuzz?
503 2020-04-15T21:23:56  <BlueMatt> well, someone should give them more cpu hours. afair marco had previously done stuff, but...
504 2020-04-15T21:24:09  <sipa> of course - we can also just increase how much cpu we spend ourselves
505 2020-04-15T21:24:13  <BlueMatt> or we could, you know, use the cluster(s) we have to get fuzz hours :)
506 2020-04-15T21:24:31  <sipa> well, or both
507 2020-04-15T21:24:37  <BlueMatt> there's probably at least 120 cpu cores lying around for such usage, just need someone to step up and write scripts
508 2020-04-15T21:24:37  *** captjakk has quit IRC
509 2020-04-15T21:26:29  <BlueMatt> i mean how many cpu hours does oss-fuzz provide? I cant imagine it is anything significantly more than the 100 cores/project full-time that we already have?
510 2020-04-15T21:26:37  <BlueMatt> and the tradeoffs for using it...kinda suck
511 2020-04-15T21:28:39  <sipa> that's a great question
512 2020-04-15T21:29:07  <BlueMatt> we could also ask osuosl if heir CI cluster has free cores: https://osuosl.org/services/hosting/details/
513 2020-04-15T21:29:09  <sipa> if it's indeed not (significantly more than) 100 cores, there isn't much to be gained from using it
514 2020-04-15T21:29:23  <BlueMatt> a few bitcoin groups gave them some funds afaiu
515 2020-04-15T21:29:41  <BlueMatt> but, you know, we should probably use our own cpus first.
516 2020-04-15T21:30:09  *** kristapsk has quit IRC
517 2020-04-15T21:30:11  *** DeanWeen has quit IRC
518 2020-04-15T21:30:33  <BlueMatt> anyway, really just need someone to step up and manage VMs that run fuzzing. I can help a bit, I have it all set up for rust-lightning and regularly pull ~100 cores for that, but I dont really have the bandwidth to manage that all the time, let alone also for core.
519 2020-04-15T21:30:39  *** kristapsk has joined #bitcoin-core-dev
520 2020-04-15T21:30:44  *** DeanWeen has joined #bitcoin-core-dev
521 2020-04-15T21:31:48  <BlueMatt> someone just let me or dongcarl know and we can get you set up with a few VMs with a bunch of cores, I presume there's soeone at blockstream who can do the same
522 2020-04-15T21:33:24  <elichai2> BlueMatt: are these bare metal? because running something like this to detect improvements/regressions can be very helpful: https://perf.rust-lang.org/
523 2020-04-15T21:34:16  <BlueMatt> kvm, but there are separate bare-metal servers intended for benchmarking cc jamesob
524 2020-04-15T21:34:31  <BlueMatt> (which are slower, but bare-metal and more 'average-grade' hardware)
525 2020-04-15T21:34:58  <elichai2> yeah but sadly you need bare metal for profiling, VMs are too dynamic for that AFAIK
526 2020-04-15T21:35:10  <BlueMatt> right, kvm just for non-benchmark things
527 2020-04-15T21:35:28  <BlueMatt> we have ~9 servers which are provisioned bare-metal for benchmarking
528 2020-04-15T21:35:42  <BlueMatt> 9 being 8-outbound-1-target for ibd benchmarking :)
529 2020-04-15T21:35:51  <BlueMatt> though you'd have to ask james as to the status of those
530 2020-04-15T21:36:09  <elichai2> I have my own PC dedicated for profiling benchmarking, trying different system wide changes to Bitcoin Core
531 2020-04-15T21:36:33  <BlueMatt> anyway, hardware/cpu resources isnt the issue, just gotta have someone write bash scripts :)
532 2020-04-15T21:36:40  <BlueMatt> well, and babysit to watch for errors
533 2020-04-15T21:38:44  <elichai2> BlueMatt: from what I looked in oss-fuzz it looks really simple, You write a simple dockerfile to compile and run and that's about it https://github.com/google/oss-fuzz/blob/master/projects/libsodium/Dockerfile
534 2020-04-15T21:39:24  <BlueMatt> well by the time you've done that much work you might as well run it on our own hardware (without the aggressive public-disclosure timelines that may put bitcoin users at risk...)
535 2020-04-15T21:39:26  <elichai2> and if I understand correctly Google will actually pay you if you integrate into oss-fuzz https://github.com/bitcoin-core/secp256k1/issues/739 "We want to stress that anyone who meets the eligibility criteria and integrates a project with OSS-Fuzz is eligible for a reward."
536 2020-04-15T21:39:59  <elichai2> BlueMatt: right. the disclosure thing is a problem, I think they're saying either 90 days from finding or 30 days from fixing
537 2020-04-15T21:40:35  <BlueMatt> lol, thats kinda obnoxious that they're auto-opening issues on open source projects.
538 2020-04-15T21:40:39  <BlueMatt> isnt that against the github tos?
539 2020-04-15T21:43:54  *** bitcoin-git has joined #bitcoin-core-dev
540 2020-04-15T21:43:54  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/e84a5f000493...544709763e1f
541 2020-04-15T21:43:54  <bitcoin-git> bitcoin/master fad4fa7 MarcoFalke: node: Add args alias for gArgs global
542 2020-04-15T21:43:55  <bitcoin-git> bitcoin/master fa0cbd4 MarcoFalke: test: Add optional extra_args to testing setup
543 2020-04-15T21:43:55  <bitcoin-git> bitcoin/master fa69f88 MarcoFalke: fuzz: Disable debug log file
544 2020-04-15T21:43:57  *** bitcoin-git has left #bitcoin-core-dev
545 2020-04-15T21:44:13  *** bitcoin-git has joined #bitcoin-core-dev
546 2020-04-15T21:44:14  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18571: fuzz: Disable debug log file (master...2004-testLogExtraArgs) https://github.com/bitcoin/bitcoin/pull/18571
547 2020-04-15T21:44:16  *** bitcoin-git has left #bitcoin-core-dev
548 2020-04-15T21:45:44  *** someone235 has quit IRC
549 2020-04-15T21:55:44  *** jonatack has quit IRC
550 2020-04-15T21:56:23  *** jonatack has joined #bitcoin-core-dev
551 2020-04-15T22:02:49  *** bitcoin-git has joined #bitcoin-core-dev
552 2020-04-15T22:02:49  <bitcoin-git> [bitcoin] mikispag opened pull request #18661: Compress PNG images with `zopflipng`. (master...master) https://github.com/bitcoin/bitcoin/pull/18661
553 2020-04-15T22:02:50  *** bitcoin-git has left #bitcoin-core-dev
554 2020-04-15T22:12:27  <fanquake> jnewbery: ok
555 2020-04-15T22:44:34  *** justanotheruser has quit IRC
556 2020-04-15T22:44:48  *** tripleslash has quit IRC
557 2020-04-15T22:45:40  *** tripleslash has joined #bitcoin-core-dev
558 2020-04-15T22:49:09  *** Guyver2_ has joined #bitcoin-core-dev
559 2020-04-15T22:49:20  *** emilengler has quit IRC
560 2020-04-15T22:50:30  *** Guyver2_ has quit IRC
561 2020-04-15T22:50:50  *** Guyver2 has quit IRC
562 2020-04-15T22:52:11  *** provoostenator has quit IRC
563 2020-04-15T22:54:07  *** provoostenator has joined #bitcoin-core-dev
564 2020-04-15T23:07:15  *** justanotheruser has joined #bitcoin-core-dev
565 2020-04-15T23:08:54  *** diogorsergio has joined #bitcoin-core-dev
566 2020-04-15T23:11:27  *** infernix has quit IRC
567 2020-04-15T23:26:22  *** bitcoin-git has joined #bitcoin-core-dev
568 2020-04-15T23:26:22  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18662: refactor: Replace gArgs with local argsman in all utility tools (master...2004-toolsArgsman) https://github.com/bitcoin/bitcoin/pull/18662
569 2020-04-15T23:26:23  *** bitcoin-git has left #bitcoin-core-dev
570 2020-04-15T23:32:54  *** brakmic has quit IRC
571 2020-04-15T23:56:32  *** captjakk has joined #bitcoin-core-dev
572 2020-04-15T23:59:39  *** captjakk has quit IRC
573 2020-04-15T23:59:52  *** captjakk has joined #bitcoin-core-dev