12020-04-15T00:00:02  *** skorgon has quit IRC
  22020-04-15T00:06:00  *** AaronvanW has quit IRC
  32020-04-15T00:11:04  *** ddustin has joined #bitcoin-core-dev
  42020-04-15T00:15:51  *** ddustin has quit IRC
  52020-04-15T00:18:30  *** bitcoin-git has joined #bitcoin-core-dev
  62020-04-15T00:18:30  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18640: appveyor: Remove clcache (master...2004-appveyorNoSlowCache) https://github.com/bitcoin/bitcoin/pull/18640
  72020-04-15T00:18:36  *** bitcoin-git has left #bitcoin-core-dev
  82020-04-15T00:21:10  *** ecrist1 has joined #bitcoin-core-dev
  92020-04-15T00:21:48  *** ddustin has joined #bitcoin-core-dev
 102020-04-15T00:27:01  *** ddustin has quit IRC
 112020-04-15T00:28:07  *** ddustin has joined #bitcoin-core-dev
 122020-04-15T00:32:46  *** ddustin has quit IRC
 132020-04-15T00:34:03  *** ddustin has joined #bitcoin-core-dev
 142020-04-15T00:41:11  *** ddustin has quit IRC
 152020-04-15T01:08:38  *** bitcoin-git has joined #bitcoin-core-dev
 162020-04-15T01:08:38  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18641: test: Create cached blocks not in the future (master...2004-qaNoCacheFuture) https://github.com/bitcoin/bitcoin/pull/18641
 172020-04-15T01:08:39  *** bitcoin-git has left #bitcoin-core-dev
 182020-04-15T01:13:46  *** bitcoin-git has joined #bitcoin-core-dev
 192020-04-15T01:13:47  <bitcoin-git> [bitcoin] naumenkogs opened pull request #18642: Use std::chrono for the time to rotate destination of addr messages + tests (master...2020_04_mock_addr_rotation_time) https://github.com/bitcoin/bitcoin/pull/18642
 202020-04-15T01:13:47  *** bitcoin-git has left #bitcoin-core-dev
 212020-04-15T01:23:10  *** bitcoin-git has joined #bitcoin-core-dev
 222020-04-15T01:23:10  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/75fcfdaf8b4b...4d793bcfe814
 232020-04-15T01:23:11  <bitcoin-git> bitcoin/master fa6cb00 MarcoFalke: doc: Fix macos comments in release-notes
 242020-04-15T01:23:11  <bitcoin-git> bitcoin/master 4d793bc fanquake: Merge #18632: doc: Fix macos comments in release-notes
 252020-04-15T01:23:13  *** bitcoin-git has left #bitcoin-core-dev
 262020-04-15T01:23:30  *** bitcoin-git has joined #bitcoin-core-dev
 272020-04-15T01:23:30  <bitcoin-git> [bitcoin] fanquake merged pull request #18632: doc: Fix macos comments in release-notes (master...2004-docMacOs) https://github.com/bitcoin/bitcoin/pull/18632
 282020-04-15T01:23:31  *** bitcoin-git has left #bitcoin-core-dev
 292020-04-15T01:36:23  *** amsudeep has joined #bitcoin-core-dev
 302020-04-15T01:39:14  *** mol has quit IRC
 312020-04-15T01:44:50  *** bitcoin-git has joined #bitcoin-core-dev
 322020-04-15T01:44:50  <bitcoin-git> [bitcoin] dongcarl opened pull request #18644: net: Reduce `TransportDeserializer` interface to 2 methods (master...2020-04-transport-readmessages) https://github.com/bitcoin/bitcoin/pull/18644
 332020-04-15T01:44:52  *** bitcoin-git has left #bitcoin-core-dev
 342020-04-15T01:47:45  *** captjakk has quit IRC
 352020-04-15T01:59:51  *** bitcoin-git has joined #bitcoin-core-dev
 362020-04-15T01:59:51  <bitcoin-git> [bitcoin] jnewbery opened pull request #18645: [doc] Update thread information in developer docs (master...2020-04-doc-threads) https://github.com/bitcoin/bitcoin/pull/18645
 372020-04-15T01:59:52  *** bitcoin-git has left #bitcoin-core-dev
 382020-04-15T02:05:38  *** ddustin has joined #bitcoin-core-dev
 392020-04-15T02:06:34  *** diogorsergio has joined #bitcoin-core-dev
 402020-04-15T02:12:12  *** ddustin has quit IRC
 412020-04-15T02:14:01  *** diogorsergio has quit IRC
 422020-04-15T02:15:04  *** diogorsergio has joined #bitcoin-core-dev
 432020-04-15T02:17:03  *** jb55 has quit IRC
 442020-04-15T02:19:34  <sipa> Apparently Satoshi also "buried" forks: https://github.com/bitcoin/bitcoin/commit/5cbf75324d1509a1262b65c5073314a4da3f6d77
 452020-04-15T02:20:55  <sipa> I wasn't aware before, but the 201 opcode limit, and the 20 keys in CHECKMULTISIG limit were initially only active for blocks >84000; in 0.3.13.5 it was changed to apply to every block
 462020-04-15T02:21:11  *** captjakk has joined #bitcoin-core-dev
 472020-04-15T02:27:50  <aj> block 84000 was a week away when the rule was added, and 10 days old when the rule was buried, give or take; neat
 482020-04-15T02:28:04  *** jb55 has joined #bitcoin-core-dev
 492020-04-15T02:29:19  <sipa> Yeah, best practices around timelines for these things *do* seem to have changed a bit since.
 502020-04-15T02:30:01  <sipa> Also, the commit message is great. "misc fixes"
 512020-04-15T02:31:44  <fanquake> I guess the covert change hiding commit messages have improved since then too
 522020-04-15T02:33:26  <sipa> i think satoshi wrote commit messages like we write release notes
 532020-04-15T02:33:47  <sipa> try to remember everything that changed since the last one, probably forget some parts
 542020-04-15T02:35:52  <midnight> satoshi hid all kinds of weird stuff that I wish he'd been more posthoc open about. :(
 552020-04-15T02:37:56  *** captjakk has quit IRC
 562020-04-15T02:38:11  *** captjakk has joined #bitcoin-core-dev
 572020-04-15T02:39:19  *** Jackielove4u_ has quit IRC
 582020-04-15T02:40:06  <sipa> midnight: i'm speculating of course, but i think he simply didn't really have an open-source minded process
 592020-04-15T02:40:46  <sipa> as in, i don't think he was trying to hide anything - i think he just didn't care enough to write good notes
 602020-04-15T02:41:45  <midnight> sipa: I felt the store-proxy-for-later-use-in-spite-of-what-the-user-wants was a bit anti-user.
 612020-04-15T02:42:33  <sipa> ?
 622020-04-15T02:42:57  <sipa> elaborate
 632020-04-15T02:43:52  <midnight> At one point I gave my bitcoind a proxy to connect through, which worked successfully. Later I wanted to stop using the proxy, but I hadn't correctly opened the network up on that machine. The proxy settings were stored in wallet.dat and (IIRC) the software tried to use it anyway when it couldn't connect normally. In my view this was super sneaky.
 642020-04-15T02:44:31  <sipa> heh, that sounds like a bug
 652020-04-15T02:44:33  <midnight> IMO based on his fairly mercenary attempt to force open incoming sockets for global connectivity it was a deliberate and not accidental design decision.
 662020-04-15T02:44:57  <sipa> at the time every setting was stored in wallet.dat
 672020-04-15T02:45:24  <midnight> I hope it was a bug, but..  he was pretty mercenary about incentives and user control. I hope it was buggy and not intended behaviour. :)
 682020-04-15T02:45:33  <sipa> of course - you may be right
 692020-04-15T02:45:52  <sipa> but also, don't ascribe to malice that which is adequately explained by incompetence
 702020-04-15T02:46:02  <midnight> He never answered my question about it. That was around the time people were bashing him a lot about code quality.
 712020-04-15T02:47:03  <midnight> I was trying to be polite but the avalanche of inexplicable "your code sucks" might have made me sound like them. Hope not. Maybe he just didn't get my emails. :)
 722020-04-15T02:47:30  *** AaronvanW has joined #bitcoin-core-dev
 732020-04-15T02:49:22  <midnight> I don't think it was malice. Not quite how I'd describe it. More just.. taking user control out of the picture for the good of the early network.
 742020-04-15T02:50:09  <sipa> to an extent that is still the case - e.g. you can't request more than 8 outgoing connections
 752020-04-15T02:51:18  <midnight> Yeah I was okay with it. The source was available, and of course I could just manually edit wallet.dat to remove the proxy config.
 762020-04-15T02:51:38  <midnight> "You must be this tall to be able to control this feature.."
 772020-04-15T02:53:57  <midnight> Also possible: it was so long ago I am misremembering what actually happened and it was all just something I misconstrued. lol
 782020-04-15T02:59:04  <sipa> :)
 792020-04-15T03:00:02  *** ecrist1 has quit IRC
 802020-04-15T03:06:09  *** jeremyrubin has quit IRC
 812020-04-15T03:06:12  *** Deacyde has quit IRC
 822020-04-15T03:10:27  *** Klox has joined #bitcoin-core-dev
 832020-04-15T03:18:45  *** AaronvanW has quit IRC
 842020-04-15T03:21:42  *** I440r has joined #bitcoin-core-dev
 852020-04-15T03:41:46  *** mol has joined #bitcoin-core-dev
 862020-04-15T03:55:47  *** lightlike_ has joined #bitcoin-core-dev
 872020-04-15T03:58:44  *** lightlike has quit IRC
 882020-04-15T04:05:55  *** jnewbery has quit IRC
 892020-04-15T04:10:04  *** per_ has quit IRC
 902020-04-15T04:10:18  *** per has joined #bitcoin-core-dev
 912020-04-15T04:14:56  *** tryphe_ has joined #bitcoin-core-dev
 922020-04-15T04:17:25  *** tryphe has quit IRC
 932020-04-15T04:19:39  *** tryphe_ has quit IRC
 942020-04-15T04:27:23  *** amsudeep has quit IRC
 952020-04-15T04:27:58  *** jnewbery has joined #bitcoin-core-dev
 962020-04-15T04:34:54  *** Highway61 has quit IRC
 972020-04-15T04:39:55  *** promag has joined #bitcoin-core-dev
 982020-04-15T04:40:58  *** afk11` has quit IRC
 992020-04-15T04:41:45  *** afk11` has joined #bitcoin-core-dev
1002020-04-15T04:44:18  *** promag has quit IRC
1012020-04-15T04:48:29  *** tryphe has joined #bitcoin-core-dev
1022020-04-15T04:48:52  *** DeanWeen has quit IRC
1032020-04-15T04:49:22  *** DeanWeen has joined #bitcoin-core-dev
1042020-04-15T05:12:02  *** captjakk has quit IRC
1052020-04-15T05:12:37  *** captjakk has joined #bitcoin-core-dev
1062020-04-15T05:16:07  *** AaronvanW has joined #bitcoin-core-dev
1072020-04-15T05:17:37  *** captjakk has quit IRC
1082020-04-15T05:18:18  *** I440r has quit IRC
1092020-04-15T05:23:24  *** tw1sted1 has joined #bitcoin-core-dev
1102020-04-15T05:33:17  *** tw1sted1 has quit IRC
1112020-04-15T05:48:51  *** AaronvanW has quit IRC
1122020-04-15T05:51:17  *** captjakk has joined #bitcoin-core-dev
1132020-04-15T05:55:47  *** captjakk has quit IRC
1142020-04-15T05:55:51  *** greylica has joined #bitcoin-core-dev
1152020-04-15T05:59:27  *** Highway61 has joined #bitcoin-core-dev
1162020-04-15T06:00:02  *** greylica has quit IRC
1172020-04-15T06:05:59  *** Kiminuo has quit IRC
1182020-04-15T06:15:13  *** Kiminuo has joined #bitcoin-core-dev
1192020-04-15T06:22:04  *** vexed[vexed] has joined #bitcoin-core-dev
1202020-04-15T06:45:51  *** Guyver2 has joined #bitcoin-core-dev
1212020-04-15T06:57:17  *** bitcoin-git has joined #bitcoin-core-dev
1222020-04-15T06:57:17  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4d793bcfe814...903be99ee654
1232020-04-15T06:57:18  <bitcoin-git> bitcoin/master 88884ee MarcoFalke: script: Disallow silent bool -> CScript conversion
1242020-04-15T06:57:18  <bitcoin-git> bitcoin/master 903be99 fanquake: Merge #18621: script: Disallow silent bool -> CScript conversion
1252020-04-15T06:57:20  *** bitcoin-git has left #bitcoin-core-dev
1262020-04-15T06:57:38  *** bitcoin-git has joined #bitcoin-core-dev
1272020-04-15T06:57:38  <bitcoin-git> [bitcoin] fanquake merged pull request #18621: script: Disallow silent bool -> CScript conversion (master...2004-scriptNoBool) https://github.com/bitcoin/bitcoin/pull/18621
1282020-04-15T06:57:39  *** bitcoin-git has left #bitcoin-core-dev
1292020-04-15T06:59:33  *** jonatack has quit IRC
1302020-04-15T07:00:26  *** jonatack has joined #bitcoin-core-dev
1312020-04-15T07:11:58  *** lightlike_ has quit IRC
1322020-04-15T07:17:32  *** bitcoin-git has joined #bitcoin-core-dev
1332020-04-15T07:17:33  <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/903be99ee654...ae486b263c22
1342020-04-15T07:17:34  <bitcoin-git> bitcoin/master b8b050a fanquake: build: add linker optimization flags to gitian descriptors
1352020-04-15T07:17:35  <bitcoin-git> bitcoin/master f2b5b0a fanquake: build: add linker optimization flags to guix
1362020-04-15T07:17:36  <bitcoin-git> bitcoin/master ae486b2 fanquake: Merge #17929: build: add linker optimisation flags to gitian & guix (Linux...
1372020-04-15T07:17:37  *** bitcoin-git has left #bitcoin-core-dev
1382020-04-15T07:18:16  *** bitcoin-git has joined #bitcoin-core-dev
1392020-04-15T07:18:16  <bitcoin-git> [bitcoin] fanquake merged pull request #17929: build: add linker optimisation flags to gitian & guix (Linux) (master...pass_optimizations_to_linker) https://github.com/bitcoin/bitcoin/pull/17929
1402020-04-15T07:18:17  *** bitcoin-git has left #bitcoin-core-dev
1412020-04-15T07:19:17  *** EagleTM has joined #bitcoin-core-dev
1422020-04-15T07:21:03  *** vincenzopalazzo has quit IRC
1432020-04-15T07:29:34  *** jonatack_ has joined #bitcoin-core-dev
1442020-04-15T07:31:07  *** bitcoin-git has joined #bitcoin-core-dev
1452020-04-15T07:31:08  <bitcoin-git> [bitcoin] fanquake closed pull request #18490: Bugfix: devtools/symbol-check: Check PE libraries case-insensitively (master...bugfix_symcheck_pe_case) https://github.com/bitcoin/bitcoin/pull/18490
1462020-04-15T07:31:09  *** bitcoin-git has left #bitcoin-core-dev
1472020-04-15T07:32:12  *** bitcoin-git has joined #bitcoin-core-dev
1482020-04-15T07:32:13  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ae486b263c22...5447d57bfff9
1492020-04-15T07:32:14  <bitcoin-git> bitcoin/master c47adf8 Stephan Oeste: Added my fingerprint Stephan Oeste (Emzy)
1502020-04-15T07:32:14  <bitcoin-git> bitcoin/master 5447d57 fanquake: Merge #18624: Added my fingerprint Stephan Oeste (Emzy)
1512020-04-15T07:32:16  *** bitcoin-git has left #bitcoin-core-dev
1522020-04-15T07:32:32  *** bitcoin-git has joined #bitcoin-core-dev
1532020-04-15T07:32:33  <bitcoin-git> [bitcoin] fanquake merged pull request #18624: Added my fingerprint Stephan Oeste (Emzy) (master...patch-1) https://github.com/bitcoin/bitcoin/pull/18624
1542020-04-15T07:32:33  *** bitcoin-git has left #bitcoin-core-dev
1552020-04-15T07:32:54  *** jonatack has quit IRC
1562020-04-15T07:38:28  *** bitcoin-git has joined #bitcoin-core-dev
1572020-04-15T07:38:28  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5447d57bfff9...e831f18b1ed3
1582020-04-15T07:38:29  <bitcoin-git> bitcoin/master 905e2e8 Jon Atack: gitian: add jonatack gpg key fingerprint
1592020-04-15T07:38:29  <bitcoin-git> bitcoin/master e831f18 fanquake: Merge #18619: gitian: add jonatack gpg key fingerprint
1602020-04-15T07:38:31  *** bitcoin-git has left #bitcoin-core-dev
1612020-04-15T07:38:48  *** bitcoin-git has joined #bitcoin-core-dev
1622020-04-15T07:38:48  <bitcoin-git> [bitcoin] fanquake merged pull request #18619: gitian: add jonatack gpg key fingerprint (master...gitian-jonatack-gpg-key-fingerprint) https://github.com/bitcoin/bitcoin/pull/18619
1632020-04-15T07:38:49  *** bitcoin-git has left #bitcoin-core-dev
1642020-04-15T07:40:43  *** mol_ has joined #bitcoin-core-dev
1652020-04-15T07:41:13  *** vasild_ has joined #bitcoin-core-dev
1662020-04-15T07:44:23  *** vasild has quit IRC
1672020-04-15T07:44:24  *** vasild_ is now known as vasild
1682020-04-15T07:45:03  *** mol has quit IRC
1692020-04-15T07:46:02  *** captjakk has joined #bitcoin-core-dev
1702020-04-15T07:46:04  *** AaronvanW has joined #bitcoin-core-dev
1712020-04-15T07:47:21  *** bitcoin-git has joined #bitcoin-core-dev
1722020-04-15T07:47:22  <bitcoin-git> [bitcoin] fanquake opened pull request #18646: gui: use PACKAGE_NAME in exception message (master...use_package_name_in_exception) https://github.com/bitcoin/bitcoin/pull/18646
1732020-04-15T07:47:22  *** bitcoin-git has left #bitcoin-core-dev
1742020-04-15T07:50:14  *** captjakk has quit IRC
1752020-04-15T07:56:21  *** marcoagner has joined #bitcoin-core-dev
1762020-04-15T08:11:48  *** AaronvanW has quit IRC
1772020-04-15T08:12:03  *** AaronvanW has joined #bitcoin-core-dev
1782020-04-15T08:25:51  *** marcoagner has quit IRC
1792020-04-15T08:33:28  *** promag has joined #bitcoin-core-dev
1802020-04-15T08:40:24  *** Jackielove4u_ has joined #bitcoin-core-dev
1812020-04-15T08:41:27  *** Jackielove4u_ has joined #bitcoin-core-dev
1822020-04-15T08:42:01  *** Jackielove4u_ has quit IRC
1832020-04-15T08:42:23  *** Jackielove4u has joined #bitcoin-core-dev
1842020-04-15T08:43:52  *** Kiminuo has quit IRC
1852020-04-15T08:43:59  *** guest534543 has joined #bitcoin-core-dev
1862020-04-15T08:44:17  *** amsudeep has joined #bitcoin-core-dev
1872020-04-15T08:51:17  *** Guyver2_ has joined #bitcoin-core-dev
1882020-04-15T08:54:26  *** Guyver2 has quit IRC
1892020-04-15T08:59:26  *** AaronvanW has quit IRC
1902020-04-15T09:00:01  *** vexed[vexed] has quit IRC
1912020-04-15T09:05:42  *** emilengler has joined #bitcoin-core-dev
1922020-04-15T09:08:32  *** timothy has joined #bitcoin-core-dev
1932020-04-15T09:13:25  *** DeanWeen has quit IRC
1942020-04-15T09:13:46  *** DeanWeen has joined #bitcoin-core-dev
1952020-04-15T09:14:49  *** Guyver2_ has quit IRC
1962020-04-15T09:14:51  *** Eagle[TM] has joined #bitcoin-core-dev
1972020-04-15T09:15:41  *** EagleTM has quit IRC
1982020-04-15T09:22:19  *** quaid1 has joined #bitcoin-core-dev
1992020-04-15T09:28:14  *** Eagle[TM] has quit IRC
2002020-04-15T09:43:06  *** bitcoin-git has joined #bitcoin-core-dev
2012020-04-15T09:43:06  <bitcoin-git> [bitcoin] brakmic opened pull request #18647: rpc: remove g_rpc_node (master...remove-global-node-ctx) https://github.com/bitcoin/bitcoin/pull/18647
2022020-04-15T09:43:13  *** bitcoin-git has left #bitcoin-core-dev
2032020-04-15T09:46:59  *** captjakk has joined #bitcoin-core-dev
2042020-04-15T09:51:08  *** brakmic has joined #bitcoin-core-dev
2052020-04-15T09:51:31  *** captjakk has quit IRC
2062020-04-15T10:03:57  *** Yasmeen65Pouros has joined #bitcoin-core-dev
2072020-04-15T10:08:34  *** Yasmeen65Pouros has quit IRC
2082020-04-15T10:12:50  *** bitcoin-git has joined #bitcoin-core-dev
2092020-04-15T10:12:50  <bitcoin-git> [bitcoin] practicalswift opened pull request #18649: tests: Add std::locale::global to list of locale dependent functions in lint-locale-dependence.sh (master...locale-dependent-functions) https://github.com/bitcoin/bitcoin/pull/18649
2102020-04-15T10:12:51  *** bitcoin-git has left #bitcoin-core-dev
2112020-04-15T10:13:25  *** timothy has quit IRC
2122020-04-15T10:15:29  *** jonatack__ has joined #bitcoin-core-dev
2132020-04-15T10:18:35  *** jonatack_ has quit IRC
2142020-04-15T10:28:23  *** mytwocentimes has quit IRC
2152020-04-15T10:30:30  *** mytwocentimes has joined #bitcoin-core-dev
2162020-04-15T10:37:47  *** mytwocentimes has quit IRC
2172020-04-15T10:38:04  *** mytwocentimes has joined #bitcoin-core-dev
2182020-04-15T10:45:11  *** mytwocentimes has quit IRC
2192020-04-15T10:45:45  *** mytwocentimes has joined #bitcoin-core-dev
2202020-04-15T10:53:20  *** timothy has joined #bitcoin-core-dev
2212020-04-15T11:00:50  *** jonatack__ has quit IRC
2222020-04-15T11:01:25  *** jonatack__ has joined #bitcoin-core-dev
2232020-04-15T11:02:37  *** bitcoin-git has joined #bitcoin-core-dev
2242020-04-15T11:02:37  <bitcoin-git> [bitcoin] practicalswift opened pull request #18650: qt: Make bitcoin.ico non-executable (master...bitcoin.ico-executable-flag) https://github.com/bitcoin/bitcoin/pull/18650
2252020-04-15T11:02:38  *** bitcoin-git has left #bitcoin-core-dev
2262020-04-15T11:17:54  *** alec has quit IRC
2272020-04-15T11:23:08  *** alec has joined #bitcoin-core-dev
2282020-04-15T11:25:52  *** mytwocen_ has joined #bitcoin-core-dev
2292020-04-15T11:27:06  *** yevaud has quit IRC
2302020-04-15T11:27:24  *** yevaud has joined #bitcoin-core-dev
2312020-04-15T11:28:19  *** mytwocentimes has quit IRC
2322020-04-15T11:32:41  *** bitcoin-git has joined #bitcoin-core-dev
2332020-04-15T11:32:41  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e831f18b1ed3...18f11fb24b47
2342020-04-15T11:32:42  <bitcoin-git> bitcoin/master 1b04302 fanquake: gui: use PACKAGE_NAME in exception message
2352020-04-15T11:32:42  <bitcoin-git> bitcoin/master 18f11fb MarcoFalke: Merge #18646: gui: use PACKAGE_NAME in exception message
2362020-04-15T11:32:44  *** bitcoin-git has left #bitcoin-core-dev
2372020-04-15T11:33:01  *** bitcoin-git has joined #bitcoin-core-dev
2382020-04-15T11:33:01  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18646: gui: use PACKAGE_NAME in exception message (master...use_package_name_in_exception) https://github.com/bitcoin/bitcoin/pull/18646
2392020-04-15T11:33:02  *** bitcoin-git has left #bitcoin-core-dev
2402020-04-15T11:40:54  *** promag_ has quit IRC
2412020-04-15T11:40:55  *** promag has quit IRC
2422020-04-15T11:44:41  *** promag_ has joined #bitcoin-core-dev
2432020-04-15T11:44:55  *** promag__ has joined #bitcoin-core-dev
2442020-04-15T11:47:53  *** captjakk has joined #bitcoin-core-dev
2452020-04-15T11:49:30  *** promag_ has quit IRC
2462020-04-15T11:50:04  *** promag has joined #bitcoin-core-dev
2472020-04-15T11:52:11  *** captjakk has quit IRC
2482020-04-15T11:56:31  *** promag has quit IRC
2492020-04-15T11:57:10  *** promag has joined #bitcoin-core-dev
2502020-04-15T12:00:02  *** quaid1 has quit IRC
2512020-04-15T12:03:29  *** promag has quit IRC
2522020-04-15T12:04:15  *** promag has joined #bitcoin-core-dev
2532020-04-15T12:05:27  *** promag has quit IRC
2542020-04-15T12:06:16  *** promag has joined #bitcoin-core-dev
2552020-04-15T12:06:44  *** promag has quit IRC
2562020-04-15T12:07:26  *** promag has joined #bitcoin-core-dev
2572020-04-15T12:09:04  *** promag has joined #bitcoin-core-dev
2582020-04-15T12:21:51  *** gac410 has joined #bitcoin-core-dev
2592020-04-15T12:22:16  *** gac410 is now known as Guest84865
2602020-04-15T12:27:31  *** promag has quit IRC
2612020-04-15T12:28:03  *** promag has joined #bitcoin-core-dev
2622020-04-15T12:28:31  *** bitcoin-git has joined #bitcoin-core-dev
2632020-04-15T12:28:31  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/18f11fb24b47...20c0e2e0f04f
2642020-04-15T12:28:32  <bitcoin-git> bitcoin/master fa4c29b MarcoFalke: test: Add various low-level p2p tests
2652020-04-15T12:28:32  <bitcoin-git> bitcoin/master 20c0e2e MarcoFalke: Merge #18628: test: Add various low-level p2p tests
2662020-04-15T12:28:34  *** bitcoin-git has left #bitcoin-core-dev
2672020-04-15T12:28:51  *** bitcoin-git has joined #bitcoin-core-dev
2682020-04-15T12:28:51  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18628: test: Add various low-level p2p tests (master...2004-qaP2Pvar) https://github.com/bitcoin/bitcoin/pull/18628
2692020-04-15T12:28:58  *** bitcoin-git has left #bitcoin-core-dev
2702020-04-15T12:33:43  *** jonatack__ has quit IRC
2712020-04-15T12:34:16  *** jonatack has joined #bitcoin-core-dev
2722020-04-15T12:41:46  *** mytwocen_ has quit IRC
2732020-04-15T12:42:00  *** mytwocentimes has joined #bitcoin-core-dev
2742020-04-15T12:43:04  *** theStack has joined #bitcoin-core-dev
2752020-04-15T12:44:28  *** michaelfolkson has joined #bitcoin-core-dev
2762020-04-15T13:00:49  *** AaronvanW has joined #bitcoin-core-dev
2772020-04-15T13:04:07  *** mol has joined #bitcoin-core-dev
2782020-04-15T13:04:29  *** promag has quit IRC
2792020-04-15T13:04:44  *** promag has joined #bitcoin-core-dev
2802020-04-15T13:06:56  *** mol_ has quit IRC
2812020-04-15T13:26:06  *** guest534543 has quit IRC
2822020-04-15T13:26:25  *** guest534543 has joined #bitcoin-core-dev
2832020-04-15T13:26:58  *** thunderbiscuit[m has joined #bitcoin-core-dev
2842020-04-15T13:34:26  *** mol has quit IRC
2852020-04-15T13:48:40  *** captjakk has joined #bitcoin-core-dev
2862020-04-15T13:48:41  *** mol has joined #bitcoin-core-dev
2872020-04-15T13:53:13  *** captjakk has quit IRC
2882020-04-15T13:56:22  <jnewbery> MarcoFalke fanquake: if you're looking for more to merge, I think #18401 is ready
2892020-04-15T13:56:25  <gribble> https://github.com/bitcoin/bitcoin/issues/18401 | Refactor: Initialize PrecomputedTransactionData in CheckInputScripts by jnewbery · Pull Request #18401 · bitcoin/bitcoin · GitHub
2902020-04-15T13:59:19  *** mol has quit IRC
2912020-04-15T13:59:19  *** diogorsergio has quit IRC
2922020-04-15T14:04:14  *** mol has joined #bitcoin-core-dev
2932020-04-15T14:10:43  *** ddustin has joined #bitcoin-core-dev
2942020-04-15T14:13:52  *** filchef has joined #bitcoin-core-dev
2952020-04-15T14:16:59  *** theStack has quit IRC
2962020-04-15T14:17:17  *** theStack has joined #bitcoin-core-dev
2972020-04-15T14:23:02  *** theStack has quit IRC
2982020-04-15T14:25:14  *** theStack has joined #bitcoin-core-dev
2992020-04-15T14:34:50  *** theStack has quit IRC
3002020-04-15T14:35:59  *** guest534543 has quit IRC
3012020-04-15T14:36:06  *** theStack has joined #bitcoin-core-dev
3022020-04-15T14:39:39  <theStack> i'm just running the fuzz test from #17860
3032020-04-15T14:39:41  <gribble> https://github.com/bitcoin/bitcoin/issues/17860 | fuzz: BIP 42, BIP 30, CVE-2018-17144 by MarcoFalke · Pull Request #17860 · bitcoin/bitcoin · GitHub
3042020-04-15T14:40:02  <theStack> can anyone tell me how i know if the fuzz test found something significant? (as far as i remember the fuzz test never stops, i.e. only after receiving CTRL+C)
3052020-04-15T14:42:57  <jonatack> theStack: you'll see a crash like https://github.com/bitcoin/bitcoin/pull/18521#issuecomment-610826738
3062020-04-15T14:43:37  *** lucaferr has quit IRC
3072020-04-15T14:43:58  <jonatack> (you are correct that the fuzzer runs indefinitely until halted)
3082020-04-15T14:45:01  <jonatack> (and on encountering an error, the fuzzer halts)
3092020-04-15T14:45:39  *** captjakk has joined #bitcoin-core-dev
3102020-04-15T14:48:13  *** vincenzopalazzo has joined #bitcoin-core-dev
3112020-04-15T14:49:18  <theStack> jonatack: so after this crash the fuzz test process would just stop?
3122020-04-15T14:50:06  <jonatack> theStack: yes (this was my first question with the fuzzer, too :)
3132020-04-15T14:50:19  *** ddustin has quit IRC
3142020-04-15T14:50:56  <theStack> jonatack: thanks, good to know. i thought it *really* runs indefinitely in all cases and e.g. writes out a file in case of crashes
3152020-04-15T14:51:58  *** ddustin has joined #bitcoin-core-dev
3162020-04-15T14:54:02  <theStack> what if the error we want to trigger is not a crash? If we take BIP 42, that doesn't result in a crash, but inflation
3172020-04-15T14:54:15  <theStack> how would the fuzzer know the condition of an, i call it "significant event"?
3182020-04-15T14:56:25  <jonatack> theStack: the fuzzer may have an option to do that... i don't see one like that in test/fuzz/test_runner.py, but you can set -loglevel)#
3192020-04-15T14:56:52  *** ddustin has quit IRC
3202020-04-15T14:57:21  *** andrewtoth has joined #bitcoin-core-dev
3212020-04-15T14:58:07  <andrewtoth> theStack that specific inflation condition is asserted here https://github.com/bitcoin/bitcoin/pull/17860/files#diff-7a6cf1c54083f72e3110c6a049e26842R77
3222020-04-15T15:00:01  *** Guest84865 has quit IRC
3232020-04-15T15:00:53  *** EagleTM has joined #bitcoin-core-dev
3242020-04-15T15:01:12  <andrewtoth> so I guess the fuzz harness should consider all "significant events" and assert them
3252020-04-15T15:01:35  *** captjakk has quit IRC
3262020-04-15T15:01:49  <theStack> jonatack: oh, i didn't even use the fuzz test-runner yet, but rather called the binaries in src/test/fuzz/ directly
3272020-04-15T15:02:16  <theStack> andrewtoth: ah, just by using assertions -- that makes sense
3282020-04-15T15:02:51  *** captjakk has joined #bitcoin-core-dev
3292020-04-15T15:03:10  <jonatack> theStack: that's probably best, i haven't got the runner to work yet and iiuc it's for the ci. was just looking in https://github.com/google/afl for more info on configurations
3302020-04-15T15:04:18  <jonatack> theStack: calling directly like you're doing is more useful for testing PRs with new harnesses
3312020-04-15T15:08:00  *** bitcoin-git has joined #bitcoin-core-dev
3322020-04-15T15:08:01  <bitcoin-git> [bitcoin] jonatack opened pull request #18653:  test: add coverage for bitcoin-cli -rpcwait (master...rpcwait-test-coverage) https://github.com/bitcoin/bitcoin/pull/18653
3332020-04-15T15:08:02  *** bitcoin-git has left #bitcoin-core-dev
3342020-04-15T15:08:06  *** ddustin has joined #bitcoin-core-dev
3352020-04-15T15:10:43  <theStack> jonatack: it seems like test_runner.py was mentioned in doc/fuzzing.md some weeks ago but now it's not anymore
3362020-04-15T15:13:02  <jonatack> theStack: makes sense, i seem to recall MarcoFalke saying the runner script was really for the ci, after instagibbs and i were trying to run it unsuccessfully a couple months ago
3372020-04-15T15:13:47  <jonatack> i was just peeking inside to see the config options
3382020-04-15T15:14:54  <MarcoFalke> test_runner is for running over all inputs, which is useful for running against every commit
3392020-04-15T15:15:07  <MarcoFalke> So mostly ci, not for extending fuzz coverage
3402020-04-15T15:22:36  <theStack> jonatack: MarcoFalke: ok, so i will ignore that script for now
3412020-04-15T15:31:01  *** justanotheruser has quit IRC
3422020-04-15T15:35:11  *** EagleTM has quit IRC
3432020-04-15T15:48:21  *** justanotheruser has joined #bitcoin-core-dev
3442020-04-15T15:53:52  *** Talkless has joined #bitcoin-core-dev
3452020-04-15T15:55:40  *** carldani has joined #bitcoin-core-dev
3462020-04-15T15:55:50  *** diogorsergio has joined #bitcoin-core-dev
3472020-04-15T16:06:14  *** mol has quit IRC
3482020-04-15T16:06:50  *** as_pnn has joined #bitcoin-core-dev
3492020-04-15T16:10:15  *** timothy has quit IRC
3502020-04-15T16:15:23  *** kristapsk has quit IRC
3512020-04-15T16:15:57  *** lightlike has joined #bitcoin-core-dev
3522020-04-15T16:17:35  *** DeanWeen has quit IRC
3532020-04-15T16:18:06  *** DeanWeen has joined #bitcoin-core-dev
3542020-04-15T16:18:15  *** Kiminuo has joined #bitcoin-core-dev
3552020-04-15T16:20:38  *** andrewtoth_ has joined #bitcoin-core-dev
3562020-04-15T16:22:43  *** andrewtoth has quit IRC
3572020-04-15T16:23:31  *** ddustin has quit IRC
3582020-04-15T16:23:33  *** shaunsun has joined #bitcoin-core-dev
3592020-04-15T16:23:36  *** shaunsun_ has joined #bitcoin-core-dev
3602020-04-15T16:25:54  *** shaunsun__ has joined #bitcoin-core-dev
3612020-04-15T16:27:38  *** andrewtoth_ has quit IRC
3622020-04-15T16:28:20  *** shaunsun has quit IRC
3632020-04-15T16:28:39  *** shaunsun_ has quit IRC
3642020-04-15T16:34:52  *** marcus47 has joined #bitcoin-core-dev
3652020-04-15T16:43:56  *** jeremyrubin has joined #bitcoin-core-dev
3662020-04-15T16:44:34  *** fearbeag has joined #bitcoin-core-dev
3672020-04-15T16:45:19  *** andrewtoth has joined #bitcoin-core-dev
3682020-04-15T16:51:57  *** michaelfolkson has joined #bitcoin-core-dev
3692020-04-15T16:59:00  *** shaunsun__ has quit IRC
3702020-04-15T16:59:10  *** shaunsun__ has joined #bitcoin-core-dev
3712020-04-15T17:28:40  *** marcus47 has quit IRC
3722020-04-15T17:43:34  *** filchef has quit IRC
3732020-04-15T17:51:10  *** IGHOR has joined #bitcoin-core-dev
3742020-04-15T17:52:12  *** mytwocentimes has quit IRC
3752020-04-15T17:54:08  *** captjakk has quit IRC
3762020-04-15T18:00:02  *** carldani has quit IRC
3772020-04-15T18:04:37  *** captjakk has joined #bitcoin-core-dev
3782020-04-15T18:05:52  *** captjakk has quit IRC
3792020-04-15T18:06:24  *** captjakk has joined #bitcoin-core-dev
3802020-04-15T18:07:33  *** captjakk has quit IRC
3812020-04-15T18:07:45  *** captjakk has joined #bitcoin-core-dev
3822020-04-15T18:08:37  *** jarthur has joined #bitcoin-core-dev
3832020-04-15T18:09:46  *** mol has joined #bitcoin-core-dev
3842020-04-15T18:20:46  *** mytwocentimes has joined #bitcoin-core-dev
3852020-04-15T18:22:05  *** Mikaela1 has joined #bitcoin-core-dev
3862020-04-15T18:23:54  *** brianhoffman has quit IRC
3872020-04-15T18:24:43  *** mol_ has joined #bitcoin-core-dev
3882020-04-15T18:26:21  *** brianhoffman has joined #bitcoin-core-dev
3892020-04-15T18:27:49  *** mol has quit IRC
3902020-04-15T18:33:41  *** amsudeep has quit IRC
3912020-04-15T18:35:53  *** as_pnn has quit IRC
3922020-04-15T18:37:12  *** bitcoin-git has joined #bitcoin-core-dev
3932020-04-15T18:37:12  <bitcoin-git> [bitcoin] theStack closed pull request #16922: net: filteradd message: update bloom filter empty/full flags after adding (master...20190919-net-update_empty_full_after_adding_filter) https://github.com/bitcoin/bitcoin/pull/16922
3942020-04-15T18:37:13  *** bitcoin-git has left #bitcoin-core-dev
3952020-04-15T18:39:39  *** Highway61 has quit IRC
3962020-04-15T18:40:05  *** bitcoin-git has joined #bitcoin-core-dev
3972020-04-15T18:40:05  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/20c0e2e0f04f...4bd6bc5cb4f3
3982020-04-15T18:40:05  <bitcoin-git> bitcoin/master fa176e2 MarcoFalke: test: Avoid accessing free'd memory in validation_chainstatemanager_tests
3992020-04-15T18:40:06  <bitcoin-git> bitcoin/master 4bd6bc5 MarcoFalke: Merge #18615: test: Avoid accessing free'd memory in validation_chainstate...
4002020-04-15T18:40:07  *** bitcoin-git has left #bitcoin-core-dev
4012020-04-15T18:40:21  *** kristapsk has joined #bitcoin-core-dev
4022020-04-15T18:40:25  *** bitcoin-git has joined #bitcoin-core-dev
4032020-04-15T18:40:25  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18615: test: Avoid accessing free'd memory in validation_chainstatemanager_tests (master...2004-testNoAccessFreeMem) https://github.com/bitcoin/bitcoin/pull/18615
4042020-04-15T18:40:27  *** bitcoin-git has left #bitcoin-core-dev
4052020-04-15T18:44:36  *** theStack has quit IRC
4062020-04-15T18:44:57  *** fearbeag has quit IRC
4072020-04-15T18:53:02  *** bitcoin-git has joined #bitcoin-core-dev
4082020-04-15T18:53:03  <bitcoin-git> [bitcoin] achow101 opened pull request #18654: rpc: separate bumpfee' (master...psbtbumpfee) https://github.com/bitcoin/bitcoin/pull/18654
4092020-04-15T18:53:04  *** bitcoin-git has left #bitcoin-core-dev
4102020-04-15T18:55:52  *** kabaum has quit IRC
4112020-04-15T18:58:02  *** bitcoin-git has joined #bitcoin-core-dev
4122020-04-15T18:58:03  <bitcoin-git> [bitcoin] achow101 opened pull request #18655: gui: Add bumpFeePSBT action instead of changing normal bumpfee behavior (master...split-bumpfeeaction) https://github.com/bitcoin/bitcoin/pull/18655
4132020-04-15T18:58:04  *** bitcoin-git has left #bitcoin-core-dev
4142020-04-15T19:00:15  *** bitcoin-git has joined #bitcoin-core-dev
4152020-04-15T19:00:15  <bitcoin-git> [bitcoin] achow101 opened pull request #18656: gui: Add a `Make unsigned` button next to `Send` (master...make-unsigned-button) https://github.com/bitcoin/bitcoin/pull/18656
4162020-04-15T19:00:16  *** bitcoin-git has left #bitcoin-core-dev
4172020-04-15T19:01:00  *** bitcoin-git has joined #bitcoin-core-dev
4182020-04-15T19:01:00  <bitcoin-git> [bitcoin] achow101 closed pull request #18627: rpc: gui: Don't change behavior based on private keys disabled, instead add new buttons/rpcs/menu items (master...split-watchonly) https://github.com/bitcoin/bitcoin/pull/18627
4192020-04-15T19:01:01  *** bitcoin-git has left #bitcoin-core-dev
4202020-04-15T19:06:56  *** michaelfolkson has quit IRC
4212020-04-15T19:07:58  *** mytwocentimes has quit IRC
4222020-04-15T19:08:29  *** kabaum has joined #bitcoin-core-dev
4232020-04-15T19:10:02  *** michaelfolkson has joined #bitcoin-core-dev
4242020-04-15T19:10:44  *** michaelfolkson has quit IRC
4252020-04-15T19:11:13  *** Highway61 has joined #bitcoin-core-dev
4262020-04-15T19:22:11  *** EagleTM has joined #bitcoin-core-dev
4272020-04-15T19:26:33  *** masterdonx2 has quit IRC
4282020-04-15T19:27:04  *** MasterdonX has joined #bitcoin-core-dev
4292020-04-15T19:28:07  *** Talkless has quit IRC
4302020-04-15T19:29:30  *** en1on is now known as en10n
4312020-04-15T19:35:06  *** Guyver2 has joined #bitcoin-core-dev
4322020-04-15T19:38:35  *** DeanWeen has quit IRC
4332020-04-15T19:38:50  *** DeanWeen has joined #bitcoin-core-dev
4342020-04-15T19:44:23  *** vasild has quit IRC
4352020-04-15T19:46:25  *** vasild has joined #bitcoin-core-dev
4362020-04-15T19:52:51  *** ghost1 has joined #bitcoin-core-dev
4372020-04-15T19:56:03  <vasild> dongcarl: If you use `-onlynet=torv3`, then there is no way that you would connect to an old node that does not understand `addrv2` because such node cannot exist - there is no way that it can advertise its `torv3` address using the old `addr` messages.
4382020-04-15T19:56:39  <vasild> Or am I totally confused? (wrt https://github.com/bitcoin/bips/pull/766#issuecomment-614141273)
4392020-04-15T19:59:12  *** bitcoin-git has joined #bitcoin-core-dev
4402020-04-15T19:59:12  <bitcoin-git> [bitcoin] practicalswift opened pull request #18657: chain: Do not fill out parameters in findCommonAncestor(...) if ancestor is not found (master...out-parameters-in-findCommonAncestor) https://github.com/bitcoin/bitcoin/pull/18657
4412020-04-15T19:59:13  *** bitcoin-git has left #bitcoin-core-dev
4422020-04-15T20:00:14  *** owowo has quit IRC
4432020-04-15T20:00:15  *** brianhoffman has quit IRC
4442020-04-15T20:02:02  *** owowo has joined #bitcoin-core-dev
4452020-04-15T20:03:09  *** jorijn has quit IRC
4462020-04-15T20:03:43  *** vasild has quit IRC
4472020-04-15T20:05:53  *** vasild has joined #bitcoin-core-dev
4482020-04-15T20:11:39  *** DeanWeen has quit IRC
4492020-04-15T20:12:31  *** DeanWeen has joined #bitcoin-core-dev
4502020-04-15T20:18:41  <elichai2> ariard  told me there is past interaction with oss-fuzz and it was decided that the disclosure policy doesn't fit Core, is that right? I'm interested to hear about it :)
4512020-04-15T20:19:22  <sipa> ping BlueMatt
4522020-04-15T20:20:40  <sipa> though if i remember correctly, at the time there also was no (meaningful) fuzzers for bitcoin core, so it was mostly a philosophical point
4532020-04-15T20:21:53  *** bitcoin-git has joined #bitcoin-core-dev
4542020-04-15T20:21:54  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4bd6bc5cb4f3...6db8ef2431ac
4552020-04-15T20:21:54  <bitcoin-git> bitcoin/master fac0c8d MarcoFalke: appveyor: Remove clcache
4562020-04-15T20:21:55  <bitcoin-git> bitcoin/master 6db8ef2 MarcoFalke: Merge #18640: appveyor: Remove clcache
4572020-04-15T20:21:56  *** bitcoin-git has left #bitcoin-core-dev
4582020-04-15T20:22:13  *** bitcoin-git has joined #bitcoin-core-dev
4592020-04-15T20:22:14  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18640: appveyor: Remove clcache (master...2004-appveyorNoSlowCache) https://github.com/bitcoin/bitcoin/pull/18640
4602020-04-15T20:22:15  *** bitcoin-git has left #bitcoin-core-dev
4612020-04-15T20:32:32  *** bitcoin-git has joined #bitcoin-core-dev
4622020-04-15T20:32:32  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6db8ef2431ac...e84a5f000493
4632020-04-15T20:32:33  <bitcoin-git> bitcoin/master 808ef36 John Newbery: [doc] Update thread information in developer docs
4642020-04-15T20:32:33  <bitcoin-git> bitcoin/master e84a5f0 MarcoFalke: Merge #18645: [doc] Update thread information in developer docs
4652020-04-15T20:32:35  *** bitcoin-git has left #bitcoin-core-dev
4662020-04-15T20:32:52  *** bitcoin-git has joined #bitcoin-core-dev
4672020-04-15T20:32:52  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18645: [doc] Update thread information in developer docs (master...2020-04-doc-threads) https://github.com/bitcoin/bitcoin/pull/18645
4682020-04-15T20:32:53  *** bitcoin-git has left #bitcoin-core-dev
4692020-04-15T20:35:15  *** dviola has joined #bitcoin-core-dev
4702020-04-15T20:36:23  *** per has quit IRC
4712020-04-15T20:36:43  *** per has joined #bitcoin-core-dev
4722020-04-15T20:39:34  *** jorijn has joined #bitcoin-core-dev
4732020-04-15T20:44:15  *** jb55 has quit IRC
4742020-04-15T20:44:49  *** ctrlbreak_MAD is now known as ctrlbreak
4752020-04-15T20:45:32  *** mytwocentimes has joined #bitcoin-core-dev
4762020-04-15T20:47:18  *** diogorsergio has quit IRC
4772020-04-15T20:58:37  *** jb55 has joined #bitcoin-core-dev
4782020-04-15T21:00:02  *** Mikaela1 has quit IRC
4792020-04-15T21:02:52  *** bitcoin-git has joined #bitcoin-core-dev
4802020-04-15T21:02:52  <bitcoin-git> [bitcoin] practicalswift closed pull request #18657: chain: Do not fill out parameters in findCommonAncestor(...) if ancestor is not found (master...out-parameters-in-findCommonAncestor) https://github.com/bitcoin/bitcoin/pull/18657
4812020-04-15T21:02:53  *** bitcoin-git has left #bitcoin-core-dev
4822020-04-15T21:04:55  *** jonatack has quit IRC
4832020-04-15T21:05:12  *** brianhoffman has joined #bitcoin-core-dev
4842020-04-15T21:06:46  *** jonatack has joined #bitcoin-core-dev
4852020-04-15T21:08:14  *** shaunsun__ has quit IRC
4862020-04-15T21:10:57  *** bitcoin-git has joined #bitcoin-core-dev
4872020-04-15T21:10:58  <bitcoin-git> [bitcoin] ryanofsky opened pull request #18660: test: Verify findCommonAncestor always initializes outputs (master...pr/commoninit) https://github.com/bitcoin/bitcoin/pull/18660
4882020-04-15T21:10:59  *** bitcoin-git has left #bitcoin-core-dev
4892020-04-15T21:19:03  <BlueMatt> elichai2: yea, oss-fuzz has some rather-strict rules about how they will disclose issues publicly after N days of reporting them.
4902020-04-15T21:19:36  *** captjakk has quit IRC
4912020-04-15T21:20:08  *** captjakk has joined #bitcoin-core-dev
4922020-04-15T21:20:11  <BlueMatt> elichai2: at the time, and imo quite reasonably, we decided that was completely unacceptable for a p2p consensus system which may, depending on the type of failure, require network-wide update for something to be safe, and some rapid disclosure policy is not compatible with that
4932020-04-15T21:20:52  <BlueMatt> elichai2: also note that oss-fuzz primarily just provides cpu hours, it doesn't do any actual implementation work for you, and getting access to a few hundred cores for bitcoin core fuzzing is rather easy :p
4942020-04-15T21:21:12  <sipa> BlueMatt: on the other hand, we currently have fuzzers for the codebase (yay), and we can't prevent anyone from running them secretly on a massive cluster
4952020-04-15T21:21:13  <BlueMatt> (as a reminder: lots of cpu cores are available in a few locations for those doing bitcoin open source work)
4962020-04-15T21:21:39  <BlueMatt> sipa: sadly they're mostly all kinda boring targets :(
4972020-04-15T21:21:55  <BlueMatt> but we *have* a few rather reasonably-sized clusters in various places...
4982020-04-15T21:22:01  <sipa> BlueMatt: have you paid attention to the more recently added ones?
4992020-04-15T21:22:04  <BlueMatt> dont think any are currently fuzzing core, but...
5002020-04-15T21:22:05  *** Frost1 has joined #bitcoin-core-dev
5012020-04-15T21:22:50  <BlueMatt> ah, marco's fuzz stuff got merged! I missed that.
5022020-04-15T21:23:52  <sipa> so perhaps... either we keep the more delicate ones private (how?), or we're ok with having the ones we have publicly participate in oss-fuzz?
5032020-04-15T21:23:56  <BlueMatt> well, someone should give them more cpu hours. afair marco had previously done stuff, but...
5042020-04-15T21:24:09  <sipa> of course - we can also just increase how much cpu we spend ourselves
5052020-04-15T21:24:13  <BlueMatt> or we could, you know, use the cluster(s) we have to get fuzz hours :)
5062020-04-15T21:24:31  <sipa> well, or both
5072020-04-15T21:24:37  <BlueMatt> there's probably at least 120 cpu cores lying around for such usage, just need someone to step up and write scripts
5082020-04-15T21:24:37  *** captjakk has quit IRC
5092020-04-15T21:26:29  <BlueMatt> i mean how many cpu hours does oss-fuzz provide? I cant imagine it is anything significantly more than the 100 cores/project full-time that we already have?
5102020-04-15T21:26:37  <BlueMatt> and the tradeoffs for using it...kinda suck
5112020-04-15T21:28:39  <sipa> that's a great question
5122020-04-15T21:29:07  <BlueMatt> we could also ask osuosl if heir CI cluster has free cores: https://osuosl.org/services/hosting/details/
5132020-04-15T21:29:09  <sipa> if it's indeed not (significantly more than) 100 cores, there isn't much to be gained from using it
5142020-04-15T21:29:23  <BlueMatt> a few bitcoin groups gave them some funds afaiu
5152020-04-15T21:29:41  <BlueMatt> but, you know, we should probably use our own cpus first.
5162020-04-15T21:30:09  *** kristapsk has quit IRC
5172020-04-15T21:30:11  *** DeanWeen has quit IRC
5182020-04-15T21:30:33  <BlueMatt> anyway, really just need someone to step up and manage VMs that run fuzzing. I can help a bit, I have it all set up for rust-lightning and regularly pull ~100 cores for that, but I dont really have the bandwidth to manage that all the time, let alone also for core.
5192020-04-15T21:30:39  *** kristapsk has joined #bitcoin-core-dev
5202020-04-15T21:30:44  *** DeanWeen has joined #bitcoin-core-dev
5212020-04-15T21:31:48  <BlueMatt> someone just let me or dongcarl know and we can get you set up with a few VMs with a bunch of cores, I presume there's soeone at blockstream who can do the same
5222020-04-15T21:33:24  <elichai2> BlueMatt: are these bare metal? because running something like this to detect improvements/regressions can be very helpful: https://perf.rust-lang.org/
5232020-04-15T21:34:16  <BlueMatt> kvm, but there are separate bare-metal servers intended for benchmarking cc jamesob
5242020-04-15T21:34:31  <BlueMatt> (which are slower, but bare-metal and more 'average-grade' hardware)
5252020-04-15T21:34:58  <elichai2> yeah but sadly you need bare metal for profiling, VMs are too dynamic for that AFAIK
5262020-04-15T21:35:10  <BlueMatt> right, kvm just for non-benchmark things
5272020-04-15T21:35:28  <BlueMatt> we have ~9 servers which are provisioned bare-metal for benchmarking
5282020-04-15T21:35:42  <BlueMatt> 9 being 8-outbound-1-target for ibd benchmarking :)
5292020-04-15T21:35:51  <BlueMatt> though you'd have to ask james as to the status of those
5302020-04-15T21:36:09  <elichai2> I have my own PC dedicated for profiling benchmarking, trying different system wide changes to Bitcoin Core
5312020-04-15T21:36:33  <BlueMatt> anyway, hardware/cpu resources isnt the issue, just gotta have someone write bash scripts :)
5322020-04-15T21:36:40  <BlueMatt> well, and babysit to watch for errors
5332020-04-15T21:38:44  <elichai2> BlueMatt: from what I looked in oss-fuzz it looks really simple, You write a simple dockerfile to compile and run and that's about it https://github.com/google/oss-fuzz/blob/master/projects/libsodium/Dockerfile
5342020-04-15T21:39:24  <BlueMatt> well by the time you've done that much work you might as well run it on our own hardware (without the aggressive public-disclosure timelines that may put bitcoin users at risk...)
5352020-04-15T21:39:26  <elichai2> and if I understand correctly Google will actually pay you if you integrate into oss-fuzz https://github.com/bitcoin-core/secp256k1/issues/739 "We want to stress that anyone who meets the eligibility criteria and integrates a project with OSS-Fuzz is eligible for a reward."
5362020-04-15T21:39:59  <elichai2> BlueMatt: right. the disclosure thing is a problem, I think they're saying either 90 days from finding or 30 days from fixing
5372020-04-15T21:40:35  <BlueMatt> lol, thats kinda obnoxious that they're auto-opening issues on open source projects.
5382020-04-15T21:40:39  <BlueMatt> isnt that against the github tos?
5392020-04-15T21:43:54  *** bitcoin-git has joined #bitcoin-core-dev
5402020-04-15T21:43:54  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/e84a5f000493...544709763e1f
5412020-04-15T21:43:54  <bitcoin-git> bitcoin/master fad4fa7 MarcoFalke: node: Add args alias for gArgs global
5422020-04-15T21:43:55  <bitcoin-git> bitcoin/master fa0cbd4 MarcoFalke: test: Add optional extra_args to testing setup
5432020-04-15T21:43:55  <bitcoin-git> bitcoin/master fa69f88 MarcoFalke: fuzz: Disable debug log file
5442020-04-15T21:43:57  *** bitcoin-git has left #bitcoin-core-dev
5452020-04-15T21:44:13  *** bitcoin-git has joined #bitcoin-core-dev
5462020-04-15T21:44:14  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18571: fuzz: Disable debug log file (master...2004-testLogExtraArgs) https://github.com/bitcoin/bitcoin/pull/18571
5472020-04-15T21:44:16  *** bitcoin-git has left #bitcoin-core-dev
5482020-04-15T21:45:44  *** someone235 has quit IRC
5492020-04-15T21:55:44  *** jonatack has quit IRC
5502020-04-15T21:56:23  *** jonatack has joined #bitcoin-core-dev
5512020-04-15T22:02:49  *** bitcoin-git has joined #bitcoin-core-dev
5522020-04-15T22:02:49  <bitcoin-git> [bitcoin] mikispag opened pull request #18661: Compress PNG images with `zopflipng`. (master...master) https://github.com/bitcoin/bitcoin/pull/18661
5532020-04-15T22:02:50  *** bitcoin-git has left #bitcoin-core-dev
5542020-04-15T22:12:27  <fanquake> jnewbery: ok
5552020-04-15T22:44:34  *** justanotheruser has quit IRC
5562020-04-15T22:44:48  *** tripleslash has quit IRC
5572020-04-15T22:45:40  *** tripleslash has joined #bitcoin-core-dev
5582020-04-15T22:49:09  *** Guyver2_ has joined #bitcoin-core-dev
5592020-04-15T22:49:20  *** emilengler has quit IRC
5602020-04-15T22:50:30  *** Guyver2_ has quit IRC
5612020-04-15T22:50:50  *** Guyver2 has quit IRC
5622020-04-15T22:52:11  *** provoostenator has quit IRC
5632020-04-15T22:54:07  *** provoostenator has joined #bitcoin-core-dev
5642020-04-15T23:07:15  *** justanotheruser has joined #bitcoin-core-dev
5652020-04-15T23:08:54  *** diogorsergio has joined #bitcoin-core-dev
5662020-04-15T23:11:27  *** infernix has quit IRC
5672020-04-15T23:26:22  *** bitcoin-git has joined #bitcoin-core-dev
5682020-04-15T23:26:22  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18662: refactor: Replace gArgs with local argsman in all utility tools (master...2004-toolsArgsman) https://github.com/bitcoin/bitcoin/pull/18662
5692020-04-15T23:26:23  *** bitcoin-git has left #bitcoin-core-dev
5702020-04-15T23:32:54  *** brakmic has quit IRC
5712020-04-15T23:56:32  *** captjakk has joined #bitcoin-core-dev
5722020-04-15T23:59:39  *** captjakk has quit IRC
5732020-04-15T23:59:52  *** captjakk has joined #bitcoin-core-dev