1 2020-04-17T00:00:01  *** [42]1 has quit IRC
  2 2020-04-17T00:04:26  *** justanotheruser has quit IRC
  3 2020-04-17T00:22:19  *** justanotheruser has joined #bitcoin-core-dev
  4 2020-04-17T00:22:20  *** kbrosnan1 has joined #bitcoin-core-dev
  5 2020-04-17T00:23:35  *** captjakk has quit IRC
  6 2020-04-17T00:24:48  *** mol has quit IRC
  7 2020-04-17T00:37:33  *** shaunsun has quit IRC
  8 2020-04-17T01:22:33  *** bitdex has quit IRC
  9 2020-04-17T01:23:10  *** promag has quit IRC
 10 2020-04-17T01:25:05  *** Chris_Stewart_5 has quit IRC
 11 2020-04-17T01:27:55  *** mol has joined #bitcoin-core-dev
 12 2020-04-17T01:33:37  *** promag has joined #bitcoin-core-dev
 13 2020-04-17T01:38:14  *** promag has quit IRC
 14 2020-04-17T02:05:23  *** bitdex has joined #bitcoin-core-dev
 15 2020-04-17T02:33:48  *** jarthur has joined #bitcoin-core-dev
 16 2020-04-17T02:36:24  *** Highway61 has quit IRC
 17 2020-04-17T03:00:01  *** kbrosnan1 has quit IRC
 18 2020-04-17T03:04:56  *** TheHoliestRoger has quit IRC
 19 2020-04-17T03:07:22  *** TheHoliestRoger has joined #bitcoin-core-dev
 20 2020-04-17T03:15:41  *** bitcoin-git has joined #bitcoin-core-dev
 21 2020-04-17T03:15:41  <bitcoin-git> [bitcoin] fanquake closed pull request #18661: Compress PNG images with `zopflipng`. (master...master) https://github.com/bitcoin/bitcoin/pull/18661
 22 2020-04-17T03:15:42  *** bitcoin-git has left #bitcoin-core-dev
 23 2020-04-17T03:22:27  *** Fare has joined #bitcoin-core-dev
 24 2020-04-17T03:22:50  *** Fare is now known as Guest44683
 25 2020-04-17T03:27:49  *** btc_thc has quit IRC
 26 2020-04-17T03:29:57  *** btc_thc has joined #bitcoin-core-dev
 27 2020-04-17T04:09:59  *** tryphe_ has joined #bitcoin-core-dev
 28 2020-04-17T04:13:13  *** tryphe has quit IRC
 29 2020-04-17T04:30:28  *** promag__ has quit IRC
 30 2020-04-17T04:33:45  *** promag has joined #bitcoin-core-dev
 31 2020-04-17T04:38:11  *** promag has quit IRC
 32 2020-04-17T04:41:21  *** mol has quit IRC
 33 2020-04-17T04:55:01  *** Talkless has joined #bitcoin-core-dev
 34 2020-04-17T04:56:03  *** Talkless has quit IRC
 35 2020-04-17T05:10:26  *** endogenic has quit IRC
 36 2020-04-17T05:10:27  *** NicolasDorier has quit IRC
 37 2020-04-17T05:10:31  *** icota[m] has quit IRC
 38 2020-04-17T05:10:31  *** mrostecki has quit IRC
 39 2020-04-17T05:10:32  *** _flow_ has quit IRC
 40 2020-04-17T05:10:32  *** jkczyz has quit IRC
 41 2020-04-17T05:10:32  *** akionak_ has quit IRC
 42 2020-04-17T05:10:32  *** thaumavorio_ has quit IRC
 43 2020-04-17T05:10:32  *** mr_burdell has quit IRC
 44 2020-04-17T05:15:04  *** endogenic has joined #bitcoin-core-dev
 45 2020-04-17T05:15:04  *** NicolasDorier has joined #bitcoin-core-dev
 46 2020-04-17T05:15:04  *** icota[m] has joined #bitcoin-core-dev
 47 2020-04-17T05:15:04  *** mrostecki has joined #bitcoin-core-dev
 48 2020-04-17T05:15:04  *** jkczyz has joined #bitcoin-core-dev
 49 2020-04-17T05:15:04  *** _flow_ has joined #bitcoin-core-dev
 50 2020-04-17T05:15:04  *** akionak_ has joined #bitcoin-core-dev
 51 2020-04-17T05:15:04  *** thaumavorio_ has joined #bitcoin-core-dev
 52 2020-04-17T05:15:04  *** mr_burdell has joined #bitcoin-core-dev
 53 2020-04-17T05:18:50  *** CubicEarth has quit IRC
 54 2020-04-17T05:20:32  *** CubicEarth has joined #bitcoin-core-dev
 55 2020-04-17T05:23:51  *** Guest44683 has quit IRC
 56 2020-04-17T05:25:14  *** DeanWeen has quit IRC
 57 2020-04-17T05:26:19  *** DeanWeen has joined #bitcoin-core-dev
 58 2020-04-17T05:30:00  *** APrOn has joined #bitcoin-core-dev
 59 2020-04-17T05:32:06  *** jarthur has quit IRC
 60 2020-04-17T05:54:10  *** DeanWeen has quit IRC
 61 2020-04-17T05:54:20  *** DeanWeen has joined #bitcoin-core-dev
 62 2020-04-17T05:57:04  *** mytwocentimes has quit IRC
 63 2020-04-17T05:57:20  *** mytwocentimes has joined #bitcoin-core-dev
 64 2020-04-17T05:59:28  *** Highway61 has joined #bitcoin-core-dev
 65 2020-04-17T06:00:02  *** APrOn has quit IRC
 66 2020-04-17T06:19:07  *** sdaftuar has quit IRC
 67 2020-04-17T06:19:08  *** SiAnDoG_ has quit IRC
 68 2020-04-17T06:19:28  *** SiAnDoG_ has joined #bitcoin-core-dev
 69 2020-04-17T06:20:53  *** sdaftuar has joined #bitcoin-core-dev
 70 2020-04-17T06:21:04  *** alorente has joined #bitcoin-core-dev
 71 2020-04-17T06:32:03  *** sdaftuar has quit IRC
 72 2020-04-17T06:37:35  *** sdaftuar has joined #bitcoin-core-dev
 73 2020-04-17T06:43:17  *** ponrpclog has joined #bitcoin-core-dev
 74 2020-04-17T06:45:04  *** ponrpclog has quit IRC
 75 2020-04-17T06:57:38  *** mol has joined #bitcoin-core-dev
 76 2020-04-17T07:03:31  *** Highway61 has quit IRC
 77 2020-04-17T07:04:43  *** sdaftuar has quit IRC
 78 2020-04-17T07:07:01  *** sdaftuar has joined #bitcoin-core-dev
 79 2020-04-17T07:16:41  *** EagleTM has joined #bitcoin-core-dev
 80 2020-04-17T07:27:03  *** bitdex has quit IRC
 81 2020-04-17T07:27:47  *** EagleTM has quit IRC
 82 2020-04-17T07:29:19  *** bitdex has joined #bitcoin-core-dev
 83 2020-04-17T07:32:36  *** jarthur has joined #bitcoin-core-dev
 84 2020-04-17T07:36:23  *** brakmic has joined #bitcoin-core-dev
 85 2020-04-17T07:36:47  *** SiAnDoG__ has joined #bitcoin-core-dev
 86 2020-04-17T07:37:00  *** SiAnDoG_ has quit IRC
 87 2020-04-17T07:37:26  *** jarthur has quit IRC
 88 2020-04-17T07:41:12  *** vasild_ has joined #bitcoin-core-dev
 89 2020-04-17T07:44:23  *** vasild has quit IRC
 90 2020-04-17T07:44:24  *** vasild_ is now known as vasild
 91 2020-04-17T08:02:45  *** mytwocentimes has quit IRC
 92 2020-04-17T08:09:13  *** jarthur has joined #bitcoin-core-dev
 93 2020-04-17T08:12:55  *** promag has joined #bitcoin-core-dev
 94 2020-04-17T08:13:26  *** jarthur has quit IRC
 95 2020-04-17T08:25:43  *** marcoagner has joined #bitcoin-core-dev
 96 2020-04-17T08:36:00  *** timothy has joined #bitcoin-core-dev
 97 2020-04-17T08:46:30  *** mytwocentimes has joined #bitcoin-core-dev
 98 2020-04-17T08:58:14  *** mol has quit IRC
 99 2020-04-17T09:00:02  *** alorente has quit IRC
100 2020-04-17T09:01:06  *** unruly247 has quit IRC
101 2020-04-17T09:01:25  *** mol has joined #bitcoin-core-dev
102 2020-04-17T09:07:04  *** promag_ has joined #bitcoin-core-dev
103 2020-04-17T09:09:19  *** jarthur has joined #bitcoin-core-dev
104 2020-04-17T09:14:10  *** jarthur has quit IRC
105 2020-04-17T09:18:50  *** emilengler has joined #bitcoin-core-dev
106 2020-04-17T09:21:27  *** icota[m] has left #bitcoin-core-dev
107 2020-04-17T09:22:05  *** jeremybennett has joined #bitcoin-core-dev
108 2020-04-17T09:22:07  *** icota[m] has joined #bitcoin-core-dev
109 2020-04-17T09:28:48  *** icota[m] has left #bitcoin-core-dev
110 2020-04-17T09:29:51  *** icota has joined #bitcoin-core-dev
111 2020-04-17T09:33:28  *** unruly247 has joined #bitcoin-core-dev
112 2020-04-17T09:42:34  *** kristapsk has quit IRC
113 2020-04-17T09:42:45  *** kristapsk has joined #bitcoin-core-dev
114 2020-04-17T09:43:59  *** icota has quit IRC
115 2020-04-17T09:44:45  *** icota[m] has joined #bitcoin-core-dev
116 2020-04-17T10:03:55  *** Eliezer30Halvors has joined #bitcoin-core-dev
117 2020-04-17T10:31:10  <hebasto> wumpus: if reasons for minimal libevent version 2.0.22 are unsure, it seems unsafe to allow build against 2.0.21, no?
118 2020-04-17T10:32:49  <wumpus> as MarcoFalke says we have already allowed it forever
119 2020-04-17T10:32:51  <wumpus> it works
120 2020-04-17T10:32:55  *** bitcoin-git has joined #bitcoin-core-dev
121 2020-04-17T10:32:56  <bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/969ee8549496...0856c1570679
122 2020-04-17T10:32:56  <bitcoin-git> bitcoin/master 9b5950d Andrew Chow: bnb: exit selection when best_waste is 0
123 2020-04-17T10:32:56  <wumpus> you are breaking it with your PR
124 2020-04-17T10:32:57  <bitcoin-git> bitcoin/master 0856c15 Samuel Dobson: Merge #18262: bnb: exit selection when best_waste is 0
125 2020-04-17T10:32:58  *** bitcoin-git has left #bitcoin-core-dev
126 2020-04-17T10:33:25  *** bitcoin-git has joined #bitcoin-core-dev
127 2020-04-17T10:33:25  <bitcoin-git> [bitcoin] meshcollider merged pull request #18262: bnb: exit selection when best_waste is 0 (master...bnb-waste-zero) https://github.com/bitcoin/bitcoin/pull/18262
128 2020-04-17T10:33:26  *** bitcoin-git has left #bitcoin-core-dev
129 2020-04-17T10:33:28  <wumpus> unless you intend to come up with a reason for that, which none of us really know for sure, that's hard to defend
130 2020-04-17T10:33:44  <hebasto> wumpus: ok, going to set minimum to 2.0.21
131 2020-04-17T10:34:14  *** Eliezer30Halvors has quit IRC
132 2020-04-17T10:34:28  <wumpus> thanks! if the fuzz test really turns out to be a problem to make compatible, you could just #ifdef it out for that version
133 2020-04-17T10:35:10  <wumpus> but I don't know the error message they get
134 2020-04-17T10:36:03  *** promag has quit IRC
135 2020-04-17T10:38:14  *** promag has joined #bitcoin-core-dev
136 2020-04-17T10:39:19  *** mytwocentimes has quit IRC
137 2020-04-17T10:41:42  <wumpus> so that's why I recommended to enable building the fuzz tests on the xenial travis run so we can see
138 2020-04-17T10:42:45  *** mytwocentimes has joined #bitcoin-core-dev
139 2020-04-17T10:44:34  <wumpus> I see I still have a xenial VM myself, will try...
140 2020-04-17T10:45:23  *** icota has joined #bitcoin-core-dev
141 2020-04-17T10:47:06  *** icota has joined #bitcoin-core-dev
142 2020-04-17T10:49:25  <icota> has anyone tried compiling libbitcoind.so since https://github.com/bitcoin/bitcoin/pull/5084 ?
143 2020-04-17T10:49:48  <icota> i'm trying to use the rdynamic trick
144 2020-04-17T10:50:06  <icota> i configure with: LDFLAGS='-rdynamic' --disable-reduce-exports --disable-tests --disable-bench --enable-debug --with-utils=no --with-gui=no --enable-shared
145 2020-04-17T10:50:15  <icota> but i can't link my hello world against the resulting binary
146 2020-04-17T10:51:05  *** bitcoin-git has joined #bitcoin-core-dev
147 2020-04-17T10:51:05  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0856c1570679...4a71c469058b
148 2020-04-17T10:51:06  <bitcoin-git> bitcoin/master 69ffddc Sebastian Falbesoner: refactor: Remove unused methods CBloomFilter::reset()/clear()
149 2020-04-17T10:51:07  <bitcoin-git> bitcoin/master 4a71c46 MarcoFalke: Merge #18670: refactor: Remove unused methods CBloomFilter::reset()/clear(...
150 2020-04-17T10:51:08  *** bitcoin-git has left #bitcoin-core-dev
151 2020-04-17T10:51:15  <theStack> ad libevent 2.0.21: the problem is that the fuzz test http_request calls functions from libevent that are not part from the API, i.e. internal functions: evhttp_parse_firstline_
152 2020-04-17T10:51:24  <emilengler> icota: Can you send a link to a pastebin with the error message?
153 2020-04-17T10:51:25  *** bitcoin-git has joined #bitcoin-core-dev
154 2020-04-17T10:51:25  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18670: refactor: Remove unused methods CBloomFilter::reset()/clear() (master...20200416-refactor-remove-unused-bloom-filter-reset) https://github.com/bitcoin/bitcoin/pull/18670
155 2020-04-17T10:51:26  *** bitcoin-git has left #bitcoin-core-dev
156 2020-04-17T10:52:05  <theStack> and those functions are named slightly different on libevent 2.0.21, the last underline is missing (at least on my system, ubuntu xenial)
157 2020-04-17T10:52:08  <icota> emilengler: sure thing, https://pastebin.com/EmKEZcuP
158 2020-04-17T10:52:20  <icota> it seems to be exporting std::cout amongst other symbols
159 2020-04-17T10:52:26  <icota> i'd like to play with this. any clever way to stop it from exporting stdlib symbols?
160 2020-04-17T10:53:21  <emilengler> icota: Can you try `LD_RUN_PATH=. g++ test.cpp -l:bitcoind -L.`
161 2020-04-17T10:53:53  <icota> emilengler: same error
162 2020-04-17T10:53:56  <emilengler> Maybe the problem is the argument order in your g++ invoke
163 2020-04-17T10:54:08  <emilengler> `LD_RUN_PATH=. g++ test.cpp -L .-l:bitcoind`
164 2020-04-17T10:54:23  <emilengler> Oh, please put a space between the dot before invoking -l
165 2020-04-17T10:54:32  <emilengler> Mistake on my side...
166 2020-04-17T10:54:53  <emilengler> Also is the colon required? I never saw a colon when invoking -l
167 2020-04-17T10:55:00  <icota> no worries
168 2020-04-17T10:55:20  <icota> colon is because the binary doesn't have a conventional name
169 2020-04-17T10:55:25  <icota> libwhatever.so
170 2020-04-17T10:55:31  <icota> it finds it, hence the erro
171 2020-04-17T10:55:32  <icota> r
172 2020-04-17T10:59:20  <meshcollider> what do we do with changes like #18466 which is API breaking
173 2020-04-17T10:59:22  <gribble> https://github.com/bitcoin/bitcoin/issues/18466 | rpc: fix invalid parameter error codes for {sign,verify}message RPCs by theStack · Pull Request #18466 · bitcoin/bitcoin · GitHub
174 2020-04-17T11:01:26  <meshcollider> The change looks correct but I also suspect we have to just keep incorrect error codes as-is
175 2020-04-17T11:08:25  *** bitcoin-git has joined #bitcoin-core-dev
176 2020-04-17T11:08:26  <bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4a71c469058b...c189bfd260ca
177 2020-04-17T11:08:26  <bitcoin-git> bitcoin/master 1abbdac Fabian Jahr: wallet: Prefer full destination groups in coin selection
178 2020-04-17T11:08:27  <bitcoin-git> bitcoin/master a2324e4 Fabian Jahr: test: Improve naming and logging of avoid_reuse tests
179 2020-04-17T11:08:28  <bitcoin-git> bitcoin/master c189bfd Samuel Dobson: Merge #17824: wallet: Prefer full destination groups in coin selection
180 2020-04-17T11:08:30  *** bitcoin-git has left #bitcoin-core-dev
181 2020-04-17T11:09:12  <wumpus> theStack: thanks, that sounds easy to work around with an ifdef at least then :)
182 2020-04-17T11:09:15  *** bitcoin-git has joined #bitcoin-core-dev
183 2020-04-17T11:09:15  <bitcoin-git> [bitcoin] meshcollider merged pull request #17824: wallet: Prefer full destination groups in coin selection (master...i17603) https://github.com/bitcoin/bitcoin/pull/17824
184 2020-04-17T11:09:17  *** bitcoin-git has left #bitcoin-core-dev
185 2020-04-17T11:09:40  <wumpus> meshcollider: if it's minor things, just mention it in the release notes
186 2020-04-17T11:10:01  *** jarthur has joined #bitcoin-core-dev
187 2020-04-17T11:11:34  <wumpus> (and in this case it is, I don't have much of an optinion on the PR itself looks like it slightly improves consistency, though, no one has written strong guidelines when to use what RPC error code)
188 2020-04-17T11:12:45  <meshcollider> Yeah, alright
189 2020-04-17T11:12:51  <theStack> wumpus: yes, a preprocessor check should solve the problem for libevent 2.0.21
190 2020-04-17T11:13:04  <meshcollider> promag: what's the status of #18471
191 2020-04-17T11:13:06  <gribble> https://github.com/bitcoin/bitcoin/issues/18471 | qa: Test shared validation interface by promag · Pull Request #18471 · bitcoin/bitcoin · GitHub
192 2020-04-17T11:13:31  <meshcollider> You asked for 0.20 milestone a while back, is it still important?
193 2020-04-17T11:14:43  *** jarthur has quit IRC
194 2020-04-17T11:15:52  <wumpus> I'm really wondering about https://github.com/bitcoin/bitcoin/issues/18652#issuecomment-614646655
195 2020-04-17T11:16:42  <wumpus> what in libc was blocking thread-local support, I have been unable to figure this out, compiled a few small C++ programs using __thread but didn't see any libc dependencies appear
196 2020-04-17T11:18:36  *** Chris_Stewart_5 has joined #bitcoin-core-dev
197 2020-04-17T11:20:31  *** unruly247 has quit IRC
198 2020-04-17T11:21:29  <wumpus> the only tls-related libc function I could find is " __tls_get_addr@GLIBC_2.3", which would suggest libc 2.3
199 2020-04-17T11:34:30  *** bitcoin-git has joined #bitcoin-core-dev
200 2020-04-17T11:34:30  <bitcoin-git> [bitcoin] laanwj opened pull request #18681: donotmerge: build: Enable thread-local with glibc compat (master...2020_04_thread_local_compat) https://github.com/bitcoin/bitcoin/pull/18681
201 2020-04-17T11:34:31  *** bitcoin-git has left #bitcoin-core-dev
202 2020-04-17T11:35:50  <fanquake> wumpus: I haven’t gone back to read the old threads, but a gitian build sounds like a good idea
203 2020-04-17T11:36:17  <wumpus> right, probably most efficient way to find out :)
204 2020-04-17T11:37:41  <fanquake> In regards to libevent 2.0.21. Also tried to find all the old discussion, my gut feeling was bugs that we were trying to avoid, maybe shutdown related. Haven’t got anything conclusive though
205 2020-04-17T11:38:39  <fanquake> It's also possible in the mean time that we've done refactorings such that those concerns are no longer relevant.
206 2020-04-17T11:39:08  <wumpus> given that everyone with xenial has been building against 2.0.21 and we got, afaik, zero complaints about that (besides the fuzzer build issue), it can't be *that* bad
207 2020-04-17T11:40:15  <wumpus> yes, that's possible too
208 2020-04-17T11:54:04  <wumpus> it highlights that it's kind of important to document *why* something is the minimum version somewhere, sure, it's always possible to find it between reams of commits and github comments, but for older projects that gets less and less efficient
209 2020-04-17T11:54:52  <wumpus> #8639 does that ofcourse for most deps
210 2020-04-17T11:54:53  <gribble> https://github.com/bitcoin/bitcoin/issues/8639 | Docs: Minimum required dependencies and current CVEs · Issue #8639 · bitcoin/bitcoin · GitHub
211 2020-04-17T11:55:36  <wumpus> and in the case of libevent i'm sure no CVE was involved
212 2020-04-17T11:58:05  *** bitcoin-git has joined #bitcoin-core-dev
213 2020-04-17T11:58:06  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c189bfd260ca...c2e53ff064df
214 2020-04-17T11:58:07  <bitcoin-git> bitcoin/master bda84a0 Fabian Jahr: rpc: Add documentation for deactivating settxfee
215 2020-04-17T11:58:07  <bitcoin-git> bitcoin/master 3867727 Fabian Jahr: rpc: settxfee respects -maxtxfee wallet setting
216 2020-04-17T11:58:08  <bitcoin-git> bitcoin/master c2e53ff MarcoFalke: Merge #18467: rpc: Improve documentation and return value of settxfee
217 2020-04-17T11:58:18  *** bitcoin-git has left #bitcoin-core-dev
218 2020-04-17T11:58:35  *** bitcoin-git has joined #bitcoin-core-dev
219 2020-04-17T11:58:36  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18467: rpc: Improve documentation and return value of settxfee (master...txfee0) https://github.com/bitcoin/bitcoin/pull/18467
220 2020-04-17T11:58:42  *** bitcoin-git has left #bitcoin-core-dev
221 2020-04-17T12:00:01  *** jeremybennett has quit IRC
222 2020-04-17T12:00:32  <hebasto> theStack: on xenial trying to replicate compiling bug for fuzzing code. Currently, configure returns error: checking whether C++ compiler accepts -fsanitize=fuzzer,address,undefined... no
223 2020-04-17T12:00:48  <hebasto> did you encounter it?
224 2020-04-17T12:01:30  <hebasto> having system clang version 3.8.0-2ubuntu4 (tags/RELEASE_380/final)
225 2020-04-17T12:07:11  <theStack> hebasto: i only tried with clang-8 so far, where the configure script didn't cause problems
226 2020-04-17T12:07:48  <hebasto> theStack: ok, going to upgrade clang :)
227 2020-04-17T12:09:05  <wumpus> clang-8 is a xenial package?
228 2020-04-17T12:10:16  <theStack> wumpus: yup, seems like that: https://packages.ubuntu.com/search?suite=xenial&keywords=clang-8
229 2020-04-17T12:11:26  *** Highway61 has joined #bitcoin-core-dev
230 2020-04-17T12:20:43  <theStack> i found out that libevent 2.1.1-alpha was the first release with internal functions renamed with underscore suffix
231 2020-04-17T12:20:46  <theStack> see upcoming PR
232 2020-04-17T12:21:01  *** cassier has joined #bitcoin-core-dev
233 2020-04-17T12:21:11  *** bitcoin-git has joined #bitcoin-core-dev
234 2020-04-17T12:21:11  <bitcoin-git> [bitcoin] theStack opened pull request #18682: fuzz: http_request workaround for libevent < 2.1.1 (master...20200417-fuzz-http-req-workaround-for-older-libevent) https://github.com/bitcoin/bitcoin/pull/18682
235 2020-04-17T12:21:13  *** bitcoin-git has left #bitcoin-core-dev
236 2020-04-17T12:43:03  <hebasto> it seems GH has connection issues. Or just for me?
237 2020-04-17T12:55:40  *** icota has quit IRC
238 2020-04-17T13:03:45  *** bitcoin-git has joined #bitcoin-core-dev
239 2020-04-17T13:03:45  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18683: ci: Disable valgrind functionl tests on forked repos to avoid timeouts (master...2004-ciTravisNoTimeout) https://github.com/bitcoin/bitcoin/pull/18683
240 2020-04-17T13:03:46  *** bitcoin-git has left #bitcoin-core-dev
241 2020-04-17T13:10:44  *** jarthur has joined #bitcoin-core-dev
242 2020-04-17T13:11:36  *** Highway61 has quit IRC
243 2020-04-17T13:12:07  *** Highway61 has joined #bitcoin-core-dev
244 2020-04-17T13:12:18  *** bitcoin-git has joined #bitcoin-core-dev
245 2020-04-17T13:12:18  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c2e53ff064df...ecc2e4e363ee
246 2020-04-17T13:12:19  <bitcoin-git> bitcoin/master eab7367 Jon Atack: fuzz: fix unused variable compiler warning
247 2020-04-17T13:12:19  <bitcoin-git> bitcoin/master ecc2e4e MarcoFalke: Merge #18664: fuzz: fix unused variable compiler warning
248 2020-04-17T13:12:21  *** bitcoin-git has left #bitcoin-core-dev
249 2020-04-17T13:12:38  *** bitcoin-git has joined #bitcoin-core-dev
250 2020-04-17T13:12:38  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18664: fuzz: fix unused variable compiler warning (master...fix-unused-variable-warning) https://github.com/bitcoin/bitcoin/pull/18664
251 2020-04-17T13:12:39  *** bitcoin-git has left #bitcoin-core-dev
252 2020-04-17T13:14:16  *** Guyver2 has joined #bitcoin-core-dev
253 2020-04-17T13:15:21  *** jarthur has quit IRC
254 2020-04-17T13:19:27  *** kljasdfvv has quit IRC
255 2020-04-17T13:19:29  <hebasto> wow! we have "Needs Guix build" label now. cool :)
256 2020-04-17T13:41:35  *** geforce04 has joined #bitcoin-core-dev
257 2020-04-17T13:43:10  *** bitcoin-git has joined #bitcoin-core-dev
258 2020-04-17T13:43:10  <bitcoin-git> [bitcoin] jnewbery closed pull request #17562: Validation: Remove ConnectTrace and PerBlockConnectTrace (master...2019-11-remove-connect-trace) https://github.com/bitcoin/bitcoin/pull/17562
259 2020-04-17T13:43:10  *** hebasto has quit IRC
260 2020-04-17T13:43:11  *** bitcoin-git has left #bitcoin-core-dev
261 2020-04-17T13:44:48  <promag> meshcollider: thanks for taking a look, needs rebase. don't worry
262 2020-04-17T13:47:04  *** hebasto has joined #bitcoin-core-dev
263 2020-04-17T13:55:22  *** mol_ has joined #bitcoin-core-dev
264 2020-04-17T13:57:33  *** molz_ has joined #bitcoin-core-dev
265 2020-04-17T13:58:34  *** mol has quit IRC
266 2020-04-17T14:00:03  *** mol_ has quit IRC
267 2020-04-17T14:02:24  *** molz_ has quit IRC
268 2020-04-17T14:14:38  *** bitcoin-git has joined #bitcoin-core-dev
269 2020-04-17T14:14:40  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/ecc2e4e363ee...54f812d9d298
270 2020-04-17T14:14:40  <bitcoin-git> bitcoin/master fac5c37 MarcoFalke: scripted-diff: Sort test includes
271 2020-04-17T14:14:41  <bitcoin-git> bitcoin/master fa488f1 MarcoFalke: scripted-diff: Bump copyright headers
272 2020-04-17T14:14:43  <bitcoin-git> bitcoin/master fa4632c MarcoFalke: test: Move boost/stdlib includes last
273 2020-04-17T14:14:44  *** bitcoin-git has quit IRC
274 2020-04-17T14:14:57  *** bitcoin-git has joined #bitcoin-core-dev
275 2020-04-17T14:14:58  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18673: scripted-diff: Sort test includes (master...2004-testSortIncludes) https://github.com/bitcoin/bitcoin/pull/18673
276 2020-04-17T14:14:59  *** bitcoin-git has left #bitcoin-core-dev
277 2020-04-17T14:26:31  *** sdaftuar has quit IRC
278 2020-04-17T14:26:52  *** sdaftuar has joined #bitcoin-core-dev
279 2020-04-17T14:32:35  *** Guyver2_ has joined #bitcoin-core-dev
280 2020-04-17T14:34:24  *** mdunnio has joined #bitcoin-core-dev
281 2020-04-17T14:35:22  *** Guyver2 has quit IRC
282 2020-04-17T14:35:42  *** Dean_Guss has joined #bitcoin-core-dev
283 2020-04-17T14:36:14  *** DeanWeen has quit IRC
284 2020-04-17T14:36:25  <MarcoFalke> Does anyone run the tests locally? Is anyone seeing failures in wallet_dump?
285 2020-04-17T14:36:50  <MarcoFalke> via the test_runner.py
286 2020-04-17T14:40:04  *** mytwocentimes has quit IRC
287 2020-04-17T14:40:32  *** bitcoin-git has joined #bitcoin-core-dev
288 2020-04-17T14:40:32  <bitcoin-git> [bitcoin] jnewbery opened pull request #18685: [validation] Simplify ConnectTrace (master...2020-04-connecttrace-simplify) https://github.com/bitcoin/bitcoin/pull/18685
289 2020-04-17T14:40:33  *** bitcoin-git has left #bitcoin-core-dev
290 2020-04-17T14:40:51  *** mytwocentimes has joined #bitcoin-core-dev
291 2020-04-17T14:43:57  *** mytwocentimes has quit IRC
292 2020-04-17T14:44:14  *** mytwocentimes has joined #bitcoin-core-dev
293 2020-04-17T14:45:45  *** someone235 has joined #bitcoin-core-dev
294 2020-04-17T14:51:00  *** grunch__ has joined #bitcoin-core-dev
295 2020-04-17T14:51:33  *** Talkless has joined #bitcoin-core-dev
296 2020-04-17T14:55:40  <jonatack> MarcoFalke: I run them locally. Rerunning now on master.
297 2020-04-17T14:56:54  <MarcoFalke> They reproducibly fail for me, so either no one is running the tests or everyone has horribly slow machines or no one reports test failures
298 2020-04-17T14:57:24  <MarcoFalke> They are broken for the last 3 days or so
299 2020-04-17T14:57:56  *** jarthur has joined #bitcoin-core-dev
300 2020-04-17T15:00:01  *** cassier has quit IRC
301 2020-04-17T15:03:48  <jonatack> yup it fails line 161
302 2020-04-17T15:04:10  <jonatack> first run both via the runner and directly calling it
303 2020-04-17T15:16:14  *** pmuir has joined #bitcoin-core-dev
304 2020-04-17T15:25:16  *** Guyver2__ has joined #bitcoin-core-dev
305 2020-04-17T15:28:25  *** Guyver2_ has quit IRC
306 2020-04-17T15:29:45  *** justanotheruser has quit IRC
307 2020-04-17T15:30:37  *** alko89 has quit IRC
308 2020-04-17T15:37:51  <MarcoFalke> Anyway, the fix is here: #18641
309 2020-04-17T15:37:52  <gribble> https://github.com/bitcoin/bitcoin/issues/18641 | test: Create cached blocks not in the future by MarcoFalke · Pull Request #18641 · bitcoin/bitcoin · GitHub
310 2020-04-17T15:43:45  *** grunch__ has quit IRC
311 2020-04-17T15:47:26  *** justanotheruser has joined #bitcoin-core-dev
312 2020-04-17T16:00:51  *** mol has joined #bitcoin-core-dev
313 2020-04-17T16:06:00  *** promag has quit IRC
314 2020-04-17T16:07:25  *** setpill has joined #bitcoin-core-dev
315 2020-04-17T16:16:26  *** promag has joined #bitcoin-core-dev
316 2020-04-17T16:17:55  <hebasto> wumpus: sipa: could block TBAALi-ros on GH ?
317 2020-04-17T16:18:55  *** bitcoin-git has joined #bitcoin-core-dev
318 2020-04-17T16:18:56  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/54f812d9d298...244daa482151
319 2020-04-17T16:18:56  <bitcoin-git> bitcoin/master fa86a4b MarcoFalke: rpc: Rename first arg of generateblock RPC to "output"
320 2020-04-17T16:18:57  <bitcoin-git> bitcoin/master fa5b1f0 MarcoFalke: rpc: Document all aliases for second arg of getblock
321 2020-04-17T16:18:57  <bitcoin-git> bitcoin/master fa168d7 MarcoFalke: rpc: Document all aliases for first arg of listtransactions
322 2020-04-17T16:18:58  *** bitcoin-git has left #bitcoin-core-dev
323 2020-04-17T16:19:15  *** bitcoin-git has joined #bitcoin-core-dev
324 2020-04-17T16:19:16  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18607: rpc: Fix named arguments in documentation (master...2004-rpcDoc) https://github.com/bitcoin/bitcoin/pull/18607
325 2020-04-17T16:19:16  *** bitcoin-git has left #bitcoin-core-dev
326 2020-04-17T16:21:10  *** promag has quit IRC
327 2020-04-17T16:26:57  *** promag has joined #bitcoin-core-dev
328 2020-04-17T16:34:14  *** promag has quit IRC
329 2020-04-17T16:36:56  *** mytwocentimes has quit IRC
330 2020-04-17T16:37:22  <dongcarl> Did we ever reach a conclusion about PPA organization?
331 2020-04-17T16:42:53  *** _andrewtoth_ has joined #bitcoin-core-dev
332 2020-04-17T16:43:23  *** andrewtoth_ has quit IRC
333 2020-04-17T16:47:03  *** _andrewtoth_ has quit IRC
334 2020-04-17T16:49:28  *** jarthur has quit IRC
335 2020-04-17T16:50:01  *** jarthur has joined #bitcoin-core-dev
336 2020-04-17T16:51:36  *** mytwocentimes has joined #bitcoin-core-dev
337 2020-04-17T16:56:03  *** mytwocentimes has quit IRC
338 2020-04-17T16:59:10  *** promag has joined #bitcoin-core-dev
339 2020-04-17T17:03:43  *** promag has quit IRC
340 2020-04-17T17:03:54  *** kinlo has quit IRC
341 2020-04-17T17:06:40  *** Highway61 has quit IRC
342 2020-04-17T17:12:26  *** mytwocentimes has joined #bitcoin-core-dev
343 2020-04-17T17:14:32  *** grunch__ has joined #bitcoin-core-dev
344 2020-04-17T17:14:47  *** bitcoin-git has joined #bitcoin-core-dev
345 2020-04-17T17:14:48  <bitcoin-git> [bitcoin] hebasto opened pull request #18686: Fix -Wsign-compare warning on ARM 32-bit (master...200417-arm-sign) https://github.com/bitcoin/bitcoin/pull/18686
346 2020-04-17T17:14:57  *** bitcoin-git has left #bitcoin-core-dev
347 2020-04-17T17:16:33  *** pinheadmz_ has joined #bitcoin-core-dev
348 2020-04-17T17:18:53  *** promag has joined #bitcoin-core-dev
349 2020-04-17T17:19:27  *** pinheadmz has quit IRC
350 2020-04-17T17:20:38  *** pinheadmz has joined #bitcoin-core-dev
351 2020-04-17T17:21:14  *** pinheadmz_ has quit IRC
352 2020-04-17T17:22:02  *** bitcoin-git has joined #bitcoin-core-dev
353 2020-04-17T17:22:03  <bitcoin-git> [bitcoin] hebasto closed pull request #18686: Fix -Wsign-compare warning on ARM 32-bit (master...200417-arm-sign) https://github.com/bitcoin/bitcoin/pull/18686
354 2020-04-17T17:22:14  *** bitcoin-git has left #bitcoin-core-dev
355 2020-04-17T17:23:40  *** promag has quit IRC
356 2020-04-17T17:26:16  *** Chris_Stewart_5 has quit IRC
357 2020-04-17T17:26:26  *** pinheadmz_ has joined #bitcoin-core-dev
358 2020-04-17T17:27:04  *** pinheadmz has quit IRC
359 2020-04-17T17:27:04  *** pinheadmz_ is now known as pinheadmz
360 2020-04-17T17:28:02  *** Chris_Stewart_5 has joined #bitcoin-core-dev
361 2020-04-17T17:40:20  *** Highway61 has joined #bitcoin-core-dev
362 2020-04-17T17:48:07  *** setpill has quit IRC
363 2020-04-17T17:57:20  *** theStack has quit IRC
364 2020-04-17T17:57:59  *** Kiminuo has quit IRC
365 2020-04-17T17:58:18  *** Kiminuo has joined #bitcoin-core-dev
366 2020-04-17T18:00:02  *** pmuir has quit IRC
367 2020-04-17T18:02:16  *** bitcoin-git has joined #bitcoin-core-dev
368 2020-04-17T18:02:16  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/244daa482151...d7bdba460cc0
369 2020-04-17T18:02:16  <bitcoin-git> bitcoin/master faceeae MarcoFalke: ci: Disable valgrind functionl tests on forked repos to avoid timeouts
370 2020-04-17T18:02:17  <bitcoin-git> bitcoin/master d7bdba4 MarcoFalke: Merge #18683: ci: Disable valgrind functionl tests on forked repos to avoi...
371 2020-04-17T18:02:18  *** bitcoin-git has left #bitcoin-core-dev
372 2020-04-17T18:02:36  *** bitcoin-git has joined #bitcoin-core-dev
373 2020-04-17T18:02:36  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18683: ci: Disable valgrind functionl tests on forked repos to avoid timeouts (master...2004-ciTravisNoTimeout) https://github.com/bitcoin/bitcoin/pull/18683
374 2020-04-17T18:02:37  *** bitcoin-git has left #bitcoin-core-dev
375 2020-04-17T18:06:41  *** bitcoin-git has joined #bitcoin-core-dev
376 2020-04-17T18:06:41  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d7bdba460cc0...c54295c1a206
377 2020-04-17T18:06:42  <bitcoin-git> bitcoin/master fa32097 MarcoFalke: test: Create cached blocks not in the future
378 2020-04-17T18:06:42  <bitcoin-git> bitcoin/master c54295c MarcoFalke: Merge #18641: test: Create cached blocks not in the future
379 2020-04-17T18:06:44  *** bitcoin-git has left #bitcoin-core-dev
380 2020-04-17T18:07:01  *** bitcoin-git has joined #bitcoin-core-dev
381 2020-04-17T18:07:01  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18641: test: Create cached blocks not in the future (master...2004-qaNoCacheFuture) https://github.com/bitcoin/bitcoin/pull/18641
382 2020-04-17T18:07:02  *** bitcoin-git has left #bitcoin-core-dev
383 2020-04-17T18:12:06  *** geforce04 has quit IRC
384 2020-04-17T18:15:25  *** commavir has quit IRC
385 2020-04-17T18:15:48  *** commavir has joined #bitcoin-core-dev
386 2020-04-17T18:27:13  <sipa> fanquake: deleted comments from and blocked jasdeep9899
387 2020-04-17T18:40:44  *** Emcy has quit IRC
388 2020-04-17T18:41:16  *** Emcy has joined #bitcoin-core-dev
389 2020-04-17T18:47:38  *** Seyaryuki has joined #bitcoin-core-dev
390 2020-04-17T18:52:15  <midnight> go sipa \o/
391 2020-04-17T19:02:17  *** Emcy has quit IRC
392 2020-04-17T19:03:25  *** EagleTM has joined #bitcoin-core-dev
393 2020-04-17T19:09:05  *** Emcy has joined #bitcoin-core-dev
394 2020-04-17T19:38:04  *** bitcoin-git has joined #bitcoin-core-dev
395 2020-04-17T19:38:04  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18688: fuzz: Merge in parallel (master...2004-fuzzPar) https://github.com/bitcoin/bitcoin/pull/18688
396 2020-04-17T19:38:05  *** bitcoin-git has left #bitcoin-core-dev
397 2020-04-17T19:40:58  *** bitcoin-git has joined #bitcoin-core-dev
398 2020-04-17T19:40:58  <bitcoin-git> [bitcoin] pierreN opened pull request #18689: rpc: allow dumptxoutset to dump human-readable data (master...feature-utxo-ascii) https://github.com/bitcoin/bitcoin/pull/18689
399 2020-04-17T19:40:59  *** bitcoin-git has left #bitcoin-core-dev
400 2020-04-17T19:41:12  *** vasild_ has joined #bitcoin-core-dev
401 2020-04-17T19:44:23  *** vasild has quit IRC
402 2020-04-17T19:44:24  *** vasild_ is now known as vasild
403 2020-04-17T20:00:15  *** kinlo has joined #bitcoin-core-dev
404 2020-04-17T20:01:54  *** pinheadmz_ has joined #bitcoin-core-dev
405 2020-04-17T20:04:56  *** pinheadmz has quit IRC
406 2020-04-17T20:04:57  *** pinheadmz_ is now known as pinheadmz
407 2020-04-17T20:14:41  *** bitcoin-git has joined #bitcoin-core-dev
408 2020-04-17T20:14:41  <bitcoin-git> [bitcoin] robot-visions opened pull request #18690: test: Check object hashes in wait_for_getdata (master...wait-for-getdata) https://github.com/bitcoin/bitcoin/pull/18690
409 2020-04-17T20:14:42  *** bitcoin-git has left #bitcoin-core-dev
410 2020-04-17T20:37:52  *** bitcoin-git has joined #bitcoin-core-dev
411 2020-04-17T20:37:53  <bitcoin-git> [bitcoin] jonatack opened pull request #18691: test: fix intermittent error in interface_bitcoin_cli (master...fix-intermittent-credentials-issue) https://github.com/bitcoin/bitcoin/pull/18691
412 2020-04-17T20:37:54  *** bitcoin-git has left #bitcoin-core-dev
413 2020-04-17T20:38:44  *** captjakk has joined #bitcoin-core-dev
414 2020-04-17T20:41:51  <captjakk> Currently the behavior of Bitcoin Core in a pruned state is to return an RPC error when a block is requested that has been pruned. I was thinking about working on a change that would allow Core to dynamically fetch a block it didn't have, and verify it against the retained headers. This ultimately implies a slight implementation change to the peer protocol, but at first glance this seems harmless and potentially very helpful
415 2020-04-17T20:41:51  <captjakk> as we get to larger numbers of applications/protocols that depend on core. Does anyone know of a reason this would be bad?
416 2020-04-17T20:43:55  <gwillen> that's kind of interesting. I'm not an expert so you should wait for one of those to chime in, but I expect this sort of thing mostly doesn't exist due to lack of demand?
417 2020-04-17T20:44:53  <gwillen> you would need a more complicated scheme for managing pruning if you have random old blocks lying around because an RPC client wanted them, you'd want some kind of cacheing or pinning scheme, presumably you'd need new RPCs to implement that (not just make it implicit, it's too expensive an operation for that I think)
418 2020-04-17T20:45:32  <captjakk> Here's why we want it. At Start9 We are building the Embassy which allows you to run a pruned node quite easily. Archives are necessary for some and helpful for everyone, but we want to make it such that running a full node that is usable by various wallets today does not necessitate full archives/txindex
419 2020-04-17T20:46:05  <gwillen> I think it's rare to want single old blocks, do you have a specific place that's coming up?
420 2020-04-17T20:46:18  <captjakk> Here's the situation
421 2020-04-17T20:46:40  <captjakk> say you have a full node synced from genesis but it's pruned to only keep 5GB of data
422 2020-04-17T20:47:25  <captjakk> if you want to add a new application, say, c-lightning, you either require a resync or it needs to be able to register itself with core to inform core to retain all blocks newer than a certain height
423 2020-04-17T20:47:31  <captjakk> OR
424 2020-04-17T20:47:42  <captjakk> it would need to be able to dynamically fetch a block that had been pruned
425 2020-04-17T20:48:01  <captjakk> my understanding is that currently pruned nodes keep ALL block headers
426 2020-04-17T20:48:09  <captjakk> even if the associated blocks have been long since purged
427 2020-04-17T20:48:31  <sipa> <opinionated mode> applications that require access to historical blocks are broken, except for debugging/emergency recovery situations
428 2020-04-17T20:48:44  <captjakk> even for new syncs?
429 2020-04-17T20:48:59  <gwillen> well "new syncs" are why I asked about "random" blocks specifically
430 2020-04-17T20:49:04  <sipa> a new wallet doesn't need access to old blocks, because its keys are new
431 2020-04-17T20:49:32  <captjakk> OK so dynamic fetching may be unnecessarily expensive here
432 2020-04-17T20:49:33  <gwillen> also, isn't "retain all blocks after a certain height" in fact already supported in RPC
433 2020-04-17T20:49:41  <sipa> that said, i see no technical reason why implementing your suggestion would be a problem
434 2020-04-17T20:49:44  <gwillen> so you might already have what you need
435 2020-04-17T20:49:46  <captjakk> it needs to support it from multiple dependents
436 2020-04-17T20:50:19  <captjakk> if I want both C-lightning and wasabi to share a full node, they need a way to deconflict the specification of which old blocks they need
437 2020-04-17T20:50:42  <sipa> captjakk: there is a recently opened issue about multiple applications being able to register they need blocks, and letting them individually declare to be done up to block X
438 2020-04-17T20:51:04  <captjakk> do you know what number? or the name of the rpc call?
439 2020-04-17T20:51:28  <captjakk> (proposed)
440 2020-04-17T20:51:30  <gwillen> for reference the mentioned issue is https://github.com/bitcoin/bitcoin/issues/18599
441 2020-04-17T20:51:47  <captjakk> This was opened by my brother, I am the other commenter :)
442 2020-04-17T20:51:57  <captjakk> captjakk == ProofOfKeags
443 2020-04-17T20:52:03  <captjakk> haven't changed my irc handle yet
444 2020-04-17T20:52:07  <gwillen> ah! hah.
445 2020-04-17T20:52:43  <captjakk> But either way, great!
446 2020-04-17T20:52:54  <captjakk> We are more than happy to develop this proposal/code it up
447 2020-04-17T20:52:58  <gwillen> this seems like it may be a "patches accepted" situation -- that is, it's probably not too hard to write 'keepheight', but you might have to do it if you want it
448 2020-04-17T20:53:14  <captjakk> I just wanted to check in to see if it may be controversial
449 2020-04-17T20:53:17  <sipa> gwillen: well there already exists manual pruning mode
450 2020-04-17T20:53:26  <sipa> where you need to issue an RPC to prune
451 2020-04-17T20:53:35  <sipa> the issue is that this is "single user"
452 2020-04-17T20:53:40  <captjakk> correct
453 2020-04-17T20:53:48  <gwillen> right, so it seems like modifying it to track multiple "pins" wouldn't be too complex
454 2020-04-17T20:53:48  <captjakk> because it pruning is done via positiva
455 2020-04-17T20:53:56  <captjakk> great
456 2020-04-17T20:54:07  <captjakk> again, we're happy to code it up
457 2020-04-17T20:54:21  *** emilengler has quit IRC
458 2020-04-17T20:54:36  <sipa> patches welcome, as far as i'm concerned
459 2020-04-17T20:54:41  <captjakk> cool!
460 2020-04-17T20:56:41  <gwillen> I don't know if you've worked in the bitcoin core tree before, but in addition to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md I highly recommend looking around under /doc/, especially /doc/productivity.md .
461 2020-04-17T20:57:20  <captjakk> This will be the first code contributions we've made
462 2020-04-17T20:57:44  <captjakk> so yes, any info on how to do this from a process standpoint is appreciated
463 2020-04-17T20:58:08  <gwillen> cool, definitely read through CONTRIBUTING.md, whatever links from it look relevant, plus productivity.md, which has some big time-saving tips in it
464 2020-04-17T20:58:35  *** captjakk is now known as proofofkeags
465 2020-04-17T20:58:49  <jonatack> good tips. also don't miss doc/developer-notes.md
466 2020-04-17T20:59:07  <gwillen> honestly the whole 'doc' folder is good to skim for stuff that appears relevant
467 2020-04-17T20:59:30  <gwillen> also I would consider fleshing out your proposed RPC interface and detailing it on the issue thread before you start coding too much, so people can comment on the design
468 2020-04-17T20:59:40  <proofofkeags> yeah I figured
469 2020-04-17T20:59:45  <gwillen> (probably come back here with a link once you have that)
470 2020-04-17T21:00:01  *** Seyaryuki has quit IRC
471 2020-04-17T21:00:06  <proofofkeags> is this something that should be detailed in the issue, or does it warrant a Bip
472 2020-04-17T21:00:17  <proofofkeags> seems that since it's limited to RPC the bip isn't necessary
473 2020-04-17T21:00:31  <proofofkeags> but I'm not sure what heuristic is used for bips
474 2020-04-17T21:01:27  <sipa> proofofkeags: BIPs == things that require cross-application standards
475 2020-04-17T21:01:37  <sipa> i don't think that's applicable here
476 2020-04-17T21:02:00  <proofofkeags> cool, makes sense
477 2020-04-17T21:02:22  *** drbonez has joined #bitcoin-core-dev
478 2020-04-17T21:02:24  <proofofkeags> so any change or addition to the peer protocol or address schemes and the like
479 2020-04-17T21:02:46  *** Guyver2__ has quit IRC
480 2020-04-17T21:03:41  *** bitcoin-git has joined #bitcoin-core-dev
481 2020-04-17T21:03:41  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18692: test: Bump timeout in wallet_import_rescan (master...2004-qaBumpTimeout) https://github.com/bitcoin/bitcoin/pull/18692
482 2020-04-17T21:03:42  <sipa> P2P protocol changes, consensus changes, address formats, but also general things like standard derivation paths for keys, ...
483 2020-04-17T21:03:42  *** bitcoin-git has left #bitcoin-core-dev
484 2020-04-17T21:03:51  <sipa> there is a BIP for the "bits" denomination
485 2020-04-17T21:04:00  <proofofkeags> lol, I suppose that's fair
486 2020-04-17T21:04:31  <sipa> changes to the BIP process itself (BIP 1, BIP 2)
487 2020-04-17T21:05:54  <proofofkeags> cool, thanks for the input y'all
488 2020-04-17T21:07:10  <yevaud> for a rare one, BIP50 is a report, not a change.
489 2020-04-17T21:08:06  <sipa> ah, indeed
490 2020-04-17T21:08:18  <yevaud> an incorrect report, but one none the less.
491 2020-04-17T21:12:06  *** bitdex has quit IRC
492 2020-04-17T21:12:36  <proofofkeags> incorrect how?
493 2020-04-17T21:13:13  *** proofofkeags has quit IRC
494 2020-04-17T21:13:26  *** proofofkeags has joined #bitcoin-core-dev
495 2020-04-17T21:16:41  <yevaud> it's conclusion is wrong, fundamentally. it suggests that the correct option was to encourage people to downgrade to 0.7, limit block size to 500KB, and increase the number of locks allowed in berkleydb.
496 2020-04-17T21:17:16  <yevaud> simply, no version of Bitcoin before 0.8 was able to maintain consensus even between nodes of the same version. realistically there's no amount of increase in berkeleydb which can allow nodes to operate properly, and the number in that document is well, well below the value required even for the time.
497 2020-04-17T21:17:47  *** bitdex has joined #bitcoin-core-dev
498 2020-04-17T21:17:52  *** bitdex has quit IRC
499 2020-04-17T21:17:55  <sipa> the document does mention "This would be an issue even if the entire network was running version 0.7.2. It is theoretically possible for one 0.7.2 node to create a block that others are unable to validate, or for 0.7.2 nodes to create block re-orgs that peers cannot validate, because the contents of each node's blkindex.dat database is not identical, and the number of locks required depends on the
500 2020-04-17T21:18:01  <sipa> exact arrangement of the blkindex.dat on...
501 2020-04-17T21:18:04  <sipa> disk (locks are acquired per-page). "
502 2020-04-17T21:18:15  *** bitdex has joined #bitcoin-core-dev
503 2020-04-17T21:19:50  *** bitcoin-git has joined #bitcoin-core-dev
504 2020-04-17T21:19:51  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c54295c1a206...895c71e53557
505 2020-04-17T21:19:51  <bitcoin-git> bitcoin/master 6f8b498 Sebastian Falbesoner: fuzz: http_request workaround for libevent < 2.1.1
506 2020-04-17T21:19:52  <bitcoin-git> bitcoin/master 895c71e MarcoFalke: Merge #18682: fuzz: http_request workaround for libevent < 2.1.1
507 2020-04-17T21:19:54  *** bitcoin-git has left #bitcoin-core-dev
508 2020-04-17T21:19:58  <yevaud> I've seen a few people argue based on BIP50 that if the locks are set to the value described, it is safe.
509 2020-04-17T21:20:10  *** bitcoin-git has joined #bitcoin-core-dev
510 2020-04-17T21:20:10  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18682: fuzz: http_request workaround for libevent < 2.1.1 (master...20200417-fuzz-http-req-workaround-for-older-libevent) https://github.com/bitcoin/bitcoin/pull/18682
511 2020-04-17T21:20:11  *** bitcoin-git has left #bitcoin-core-dev
512 2020-04-17T21:20:21  <yevaud> perhaps that's down to interpretation.
513 2020-04-17T21:20:50  <sipa> due to the way locks were grabbed for an entire reorg, arguably for any finite value of the lock limits, pre-0.8 was unable to handle arbirarily long reorgs, which is arguably a consensus failure
514 2020-04-17T21:21:27  <sipa> then again, i believe there have been plenty of other versions since 0.8 that also weren't practically capable of doing very deep (say 1000s of blocks) reorgs
515 2020-04-17T21:21:46  *** ButterflyOfFire has joined #bitcoin-core-dev
516 2020-04-17T21:22:54  <yevaud> true. in those versions reverting a UTXO change wrote back into the mempool for every block (or something close), it was excruciatingly slow.
517 2020-04-17T21:23:50  <yevaud> I've attempted to sync 0.7 with 2**32 locks, it ends up failing consensus effectively at random. it was never clear exactly why.
518 2020-04-17T21:24:05  <sipa> by unable i don't just mean infeasibly slow - i mean it'd go OOM
519 2020-04-17T21:25:49  <yevaud> right. it would be an interesting exercise to get 0.7 to sync with the modern network, but it's in the order of months of sync time, even entirely in NVMe cache.
520 2020-04-17T21:26:16  <yevaud> I'm not even confident it can process blocks fast enough to stay in sync at the head.
521 2020-04-17T21:28:03  <sipa> haha, yes
522 2020-04-17T21:28:09  <sipa> that too is arguably a consensus failure...
523 2020-04-17T21:29:13  <yevaud> presumably if we had CPUs that were orders of magnitude faster, it would be consensus compatible again. sort of stretching the definition.
524 2020-04-17T21:30:31  *** grunch__ has quit IRC
525 2020-04-17T21:34:06  <gwillen> ugh, I hate the fact that every time some fucking altcoin brings over a commit that has my name in it, I get pinged
526 2020-04-17T21:34:21  <gwillen> if anybody knows a way to prevent that I'd love to hear it
527 2020-04-17T21:35:44  <sipa> i think we have some recommendation somewhere not to put @username in commit messages
528 2020-04-17T21:35:59  <sipa> someone even suggested having a linter for it
529 2020-04-17T21:35:59  <gwillen> welp
530 2020-04-17T21:55:04  *** Kiminuo has quit IRC
531 2020-04-17T22:11:52  <fanquake> sipa: ok
532 2020-04-17T22:12:46  <sipa> fanquake: were you... asleep?
533 2020-04-17T22:13:25  <fanquake> Yes I was hah
534 2020-04-17T22:13:42  <fanquake> Can you also block amirabbaska
535 2020-04-17T22:20:01  <sipa> done
536 2020-04-17T22:30:02  *** mdunnio has quit IRC
537 2020-04-17T22:30:38  *** promag has joined #bitcoin-core-dev
538 2020-04-17T22:33:15  <achow101> fanquake sleeps? that's new :p
539 2020-04-17T22:40:26  <sipa> it must be a sporadic activity
540 2020-04-17T22:40:49  <dongcarl> achow101: You see, he has a secondary brain directly attached to an X server, which never sleeps
541 2020-04-17T22:43:28  <sipa> dongcarl: his computer?
542 2020-04-17T22:44:29  <dongcarl> XD
543 2020-04-17T22:50:53  <jonatack> :D
544 2020-04-17T23:08:33  *** bitcoin-git has joined #bitcoin-core-dev
545 2020-04-17T23:08:33  <bitcoin-git> [bitcoin] hebasto opened pull request #18695: test: Replace boost::mutex with std::mutex (master...200417-boost-mu) https://github.com/bitcoin/bitcoin/pull/18695
546 2020-04-17T23:08:34  *** bitcoin-git has left #bitcoin-core-dev
547 2020-04-17T23:16:47  *** sosthene has quit IRC
548 2020-04-17T23:17:02  *** sosthene has joined #bitcoin-core-dev
549 2020-04-17T23:24:22  *** justanotheruser has quit IRC
550 2020-04-17T23:34:37  *** justanotheruser has joined #bitcoin-core-dev
551 2020-04-17T23:36:46  *** marcoagner has quit IRC
552 2020-04-17T23:44:01  <hebasto> IIUC, it seems our unit tests ignore the case when g_parallel_script_checks=false. Is it intended?
553 2020-04-17T23:45:15  *** luke-jr has quit IRC
554 2020-04-17T23:45:42  *** luke-jr has joined #bitcoin-core-dev
555 2020-04-17T23:47:15  *** Talkless has quit IRC
556 2020-04-17T23:58:56  *** _andrewtoth_ has joined #bitcoin-core-dev