1 2020-04-29T00:00:01  *** tylerni71 has quit IRC
  2 2020-04-29T00:00:50  *** DeanGuss has joined #bitcoin-core-dev
  3 2020-04-29T00:11:00  *** shaunsun has joined #bitcoin-core-dev
  4 2020-04-29T00:11:37  *** shaunsun has quit IRC
  5 2020-04-29T00:12:41  *** Chris_Stewart_5 has joined #bitcoin-core-dev
  6 2020-04-29T00:17:33  *** jarthur_ has joined #bitcoin-core-dev
  7 2020-04-29T00:20:11  *** jarthur has quit IRC
  8 2020-04-29T00:21:16  *** jarthur_ has quit IRC
  9 2020-04-29T00:21:45  *** Nipo1 has joined #bitcoin-core-dev
 10 2020-04-29T00:24:19  *** proofofkeags has quit IRC
 11 2020-04-29T00:28:49  *** brakmic has quit IRC
 12 2020-04-29T00:40:54  *** bitcoin-git has joined #bitcoin-core-dev
 13 2020-04-29T00:40:55  <bitcoin-git> [bitcoin] jnewbery opened pull request #18808: [net processing] Drop unknown types in getdata (master...2020-04-getdata) https://github.com/bitcoin/bitcoin/pull/18808
 14 2020-04-29T00:40:55  *** bitcoin-git has left #bitcoin-core-dev
 15 2020-04-29T00:43:52  *** bitcoin-git has joined #bitcoin-core-dev
 16 2020-04-29T00:43:53  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18809: rpc: Do not advertise dumptxoutset as a way to flush the chainstate (master...2004-rpcNoFlushAdvert) https://github.com/bitcoin/bitcoin/pull/18809
 17 2020-04-29T00:43:57  *** ghost43 has quit IRC
 18 2020-04-29T00:44:04  *** bitcoin-git has left #bitcoin-core-dev
 19 2020-04-29T00:44:16  *** ghost43 has joined #bitcoin-core-dev
 20 2020-04-29T01:06:24  *** cryptoIndio has joined #bitcoin-core-dev
 21 2020-04-29T01:09:14  *** Chris_Stewart_5 has quit IRC
 22 2020-04-29T01:19:19  *** bitcoin-git has joined #bitcoin-core-dev
 23 2020-04-29T01:19:20  <bitcoin-git> [bitcoin] chrisabrams opened pull request #18810: fix: update rest info on block size and json (master...18703) https://github.com/bitcoin/bitcoin/pull/18810
 24 2020-04-29T01:19:20  *** bitcoin-git has left #bitcoin-core-dev
 25 2020-04-29T01:30:21  *** jarthur has joined #bitcoin-core-dev
 26 2020-04-29T01:57:52  *** jarthur has quit IRC
 27 2020-04-29T01:59:09  *** jarthur has joined #bitcoin-core-dev
 28 2020-04-29T02:04:47  <sipa> is boost 1.47 still the minimum supported?
 29 2020-04-29T02:05:02  *** proofofkeags has joined #bitcoin-core-dev
 30 2020-04-29T02:05:04  <fanquake> yes
 31 2020-04-29T02:05:57  *** bitcoin-git has joined #bitcoin-core-dev
 32 2020-04-29T02:05:57  <bitcoin-git> [bitcoin] xagau opened pull request #18812: Xagau 1 (master...xagau-1) https://github.com/bitcoin/bitcoin/pull/18812
 33 2020-04-29T02:05:58  *** bitcoin-git has left #bitcoin-core-dev
 34 2020-04-29T02:06:27  *** bitcoin-git has joined #bitcoin-core-dev
 35 2020-04-29T02:06:27  <bitcoin-git> [bitcoin] fanquake closed pull request #18812: Xagau 1 (master...xagau-1) https://github.com/bitcoin/bitcoin/pull/18812
 36 2020-04-29T02:06:28  *** bitcoin-git has left #bitcoin-core-dev
 37 2020-04-29T02:06:48  <sipa> would it be a problem to increase that to 1.59?
 38 2020-04-29T02:08:50  <fanquake> What's the reason for doing so? I'll recheck all the distros and see if that'd be an issue
 39 2020-04-29T02:09:12  *** Victorsueca has quit IRC
 40 2020-04-29T02:10:28  *** cryptoIndio has quit IRC
 41 2020-04-29T02:10:29  <fanquake> CentOS 7 seems to ship with 1.53
 42 2020-04-29T02:11:04  <sipa> i'm looking into using a multi_index for keeping track of tx requests, and it seems 1.59 adds "ranked indices", which would avoid the need for some separate things to keep track of
 43 2020-04-29T02:11:17  <sipa> multi_index is headers-only, so it'd only be a build dependency, not a runtime one
 44 2020-04-29T02:12:39  *** cryptoIndio has joined #bitcoin-core-dev
 45 2020-04-29T02:13:36  <fanquake> I see
 46 2020-04-29T02:14:11  <fanquake> Ubuntu 16.04 also ships with 1.58.0
 47 2020-04-29T02:17:51  <sipa> ok
 48 2020-04-29T02:18:53  *** Victorsueca has joined #bitcoin-core-dev
 49 2020-04-29T02:21:48  *** kristapsk has quit IRC
 50 2020-04-29T02:21:53  *** kristapsk_ has joined #bitcoin-core-dev
 51 2020-04-29T02:22:38  *** mytwocentimes has quit IRC
 52 2020-04-29T02:22:49  *** mytwocentimes has joined #bitcoin-core-dev
 53 2020-04-29T02:26:32  *** jarthur has quit IRC
 54 2020-04-29T02:27:02  *** jarthur has joined #bitcoin-core-dev
 55 2020-04-29T02:36:49  *** mol_ has quit IRC
 56 2020-04-29T02:58:07  *** promag_ has quit IRC
 57 2020-04-29T03:00:02  *** Nipo1 has quit IRC
 58 2020-04-29T03:12:44  *** jarthur has quit IRC
 59 2020-04-29T03:13:51  *** jarthur has joined #bitcoin-core-dev
 60 2020-04-29T03:17:28  *** jarthur has quit IRC
 61 2020-04-29T03:21:46  *** Highway61 has quit IRC
 62 2020-04-29T03:21:54  *** jarthur has joined #bitcoin-core-dev
 63 2020-04-29T03:22:03  *** b_b1 has joined #bitcoin-core-dev
 64 2020-04-29T03:24:21  *** promag has joined #bitcoin-core-dev
 65 2020-04-29T03:25:16  *** mol has joined #bitcoin-core-dev
 66 2020-04-29T03:26:22  *** dqx has quit IRC
 67 2020-04-29T03:26:55  *** jarthur has quit IRC
 68 2020-04-29T03:28:22  *** dqx has joined #bitcoin-core-dev
 69 2020-04-29T03:29:10  *** promag has quit IRC
 70 2020-04-29T03:30:24  *** jarthur has joined #bitcoin-core-dev
 71 2020-04-29T03:34:58  *** jarthur has quit IRC
 72 2020-04-29T03:38:42  *** real_or_random has quit IRC
 73 2020-04-29T03:41:10  *** real_or_random has joined #bitcoin-core-dev
 74 2020-04-29T03:54:14  *** dqx has quit IRC
 75 2020-04-29T03:54:39  *** dqx has joined #bitcoin-core-dev
 76 2020-04-29T04:20:06  *** proofofkeags has quit IRC
 77 2020-04-29T04:20:41  *** proofofkeags has joined #bitcoin-core-dev
 78 2020-04-29T04:25:10  *** proofofkeags has quit IRC
 79 2020-04-29T04:25:42  *** ppisati has quit IRC
 80 2020-04-29T04:32:24  *** ppisati has joined #bitcoin-core-dev
 81 2020-04-29T04:43:45  *** RAZM has quit IRC
 82 2020-04-29T05:01:18  *** proofofkeags has joined #bitcoin-core-dev
 83 2020-04-29T05:05:50  *** proofofkeags has quit IRC
 84 2020-04-29T05:09:22  *** Talkless has joined #bitcoin-core-dev
 85 2020-04-29T05:32:46  *** dqx has quit IRC
 86 2020-04-29T05:34:42  *** dqx has joined #bitcoin-core-dev
 87 2020-04-29T05:38:49  *** proofofkeags has joined #bitcoin-core-dev
 88 2020-04-29T05:41:14  *** yzernik has quit IRC
 89 2020-04-29T05:43:03  *** DeanGuss has quit IRC
 90 2020-04-29T05:43:06  *** proofofkeags has quit IRC
 91 2020-04-29T05:43:52  *** yzernik has joined #bitcoin-core-dev
 92 2020-04-29T05:50:20  *** yzernik has quit IRC
 93 2020-04-29T05:59:21  *** Highway61 has joined #bitcoin-core-dev
 94 2020-04-29T06:00:01  *** b_b1 has quit IRC
 95 2020-04-29T06:00:09  *** kabaum has joined #bitcoin-core-dev
 96 2020-04-29T06:21:40  *** gchaix has joined #bitcoin-core-dev
 97 2020-04-29T06:47:27  *** ghost43 has quit IRC
 98 2020-04-29T06:48:22  *** ghost43 has joined #bitcoin-core-dev
 99 2020-04-29T07:25:56  *** promag has joined #bitcoin-core-dev
100 2020-04-29T07:30:34  *** promag has quit IRC
101 2020-04-29T07:31:05  *** jonatack_ has joined #bitcoin-core-dev
102 2020-04-29T07:34:25  *** jonatack has quit IRC
103 2020-04-29T07:39:34  *** proofofkeags has joined #bitcoin-core-dev
104 2020-04-29T07:44:11  *** proofofkeags has quit IRC
105 2020-04-29T07:48:48  *** Guyver2 has joined #bitcoin-core-dev
106 2020-04-29T07:51:07  *** as_pnn has joined #bitcoin-core-dev
107 2020-04-29T07:59:59  *** ghost43 has quit IRC
108 2020-04-29T08:00:17  *** Highway61 has quit IRC
109 2020-04-29T08:00:49  *** Highway61 has joined #bitcoin-core-dev
110 2020-04-29T08:00:57  *** ghost43 has joined #bitcoin-core-dev
111 2020-04-29T08:02:30  *** bitcoin-git has joined #bitcoin-core-dev
112 2020-04-29T08:02:30  <bitcoin-git> [bitcoin] bttd opened pull request #18813: 0.20 (master...0.20) https://github.com/bitcoin/bitcoin/pull/18813
113 2020-04-29T08:02:31  *** bitcoin-git has left #bitcoin-core-dev
114 2020-04-29T08:05:41  *** mol has quit IRC
115 2020-04-29T08:06:53  *** midnight has quit IRC
116 2020-04-29T08:08:28  *** kristapsk_ has quit IRC
117 2020-04-29T08:08:50  *** kristapsk_ has joined #bitcoin-core-dev
118 2020-04-29T08:10:05  *** marcoagner has joined #bitcoin-core-dev
119 2020-04-29T08:10:43  *** bitcoin-git has joined #bitcoin-core-dev
120 2020-04-29T08:10:44  <bitcoin-git> [bitcoin] fanquake closed pull request #18813: 0.20 (master...0.20) https://github.com/bitcoin/bitcoin/pull/18813
121 2020-04-29T08:10:45  *** bitcoin-git has left #bitcoin-core-dev
122 2020-04-29T08:14:59  *** midnight has joined #bitcoin-core-dev
123 2020-04-29T08:18:06  *** dqx has quit IRC
124 2020-04-29T08:18:30  *** dqx has joined #bitcoin-core-dev
125 2020-04-29T08:27:06  *** emilengler has joined #bitcoin-core-dev
126 2020-04-29T08:30:49  *** lucaferr has joined #bitcoin-core-dev
127 2020-04-29T08:31:18  *** lucaferr has quit IRC
128 2020-04-29T08:33:04  *** bitcoin-git has joined #bitcoin-core-dev
129 2020-04-29T08:33:05  <bitcoin-git> [bitcoin] fanquake pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/ba348dbc518b...0ef0d33f7562
130 2020-04-29T08:33:06  <bitcoin-git> bitcoin/master 89eeb4a Amiti Uttarwar: [mempool] Track "unbroadcast" transactions
131 2020-04-29T08:33:07  <bitcoin-git> bitcoin/master 7e93eec Amiti Uttarwar: [util] Add method that returns random time in milliseconds
132 2020-04-29T08:33:07  <bitcoin-git> bitcoin/master e25e42f Amiti Uttarwar: [p2p] Reattempt initial send of unbroadcast transactions
133 2020-04-29T08:33:09  *** bitcoin-git has left #bitcoin-core-dev
134 2020-04-29T08:34:14  *** bitcoin-git has joined #bitcoin-core-dev
135 2020-04-29T08:34:14  <bitcoin-git> [bitcoin] fanquake merged pull request #18038: P2P: Mempool tracks locally submitted transactions to improve wallet privacy (master...2020-01-unbroadcast) https://github.com/bitcoin/bitcoin/pull/18038
136 2020-04-29T08:34:16  *** bitcoin-git has left #bitcoin-core-dev
137 2020-04-29T08:35:43  *** promag has joined #bitcoin-core-dev
138 2020-04-29T08:36:44  *** promag_ has joined #bitcoin-core-dev
139 2020-04-29T08:38:37  *** nullptr| has quit IRC
140 2020-04-29T08:40:52  *** promag_ has quit IRC
141 2020-04-29T08:41:04  *** nullptr| has joined #bitcoin-core-dev
142 2020-04-29T08:41:30  *** lucaferr has joined #bitcoin-core-dev
143 2020-04-29T08:43:04  <lucaferr> Has mempool p2p command been deprecated? The information I can find online indicates it should reply with an inv, however in integration tests it seems to disconnect. Is it only working for SPV clients as of now?
144 2020-04-29T08:49:29  *** amsudeep has joined #bitcoin-core-dev
145 2020-04-29T08:50:35  *** timothy has joined #bitcoin-core-dev
146 2020-04-29T09:00:02  *** gchaix has quit IRC
147 2020-04-29T09:08:43  *** kljasdfvv has quit IRC
148 2020-04-29T09:10:03  *** kljasdfvv has joined #bitcoin-core-dev
149 2020-04-29T09:13:07  *** mytwocentimes has quit IRC
150 2020-04-29T09:21:08  *** c9sloud has joined #bitcoin-core-dev
151 2020-04-29T09:29:02  *** mytwocentimes has joined #bitcoin-core-dev
152 2020-04-29T09:32:23  *** amsudeep has quit IRC
153 2020-04-29T09:33:37  *** sudeep_ has joined #bitcoin-core-dev
154 2020-04-29T09:36:51  *** emilengler has quit IRC
155 2020-04-29T09:37:20  *** _Francisco_ has joined #bitcoin-core-dev
156 2020-04-29T09:38:04  *** emilengler has joined #bitcoin-core-dev
157 2020-04-29T09:48:34  *** bitcoin-git has joined #bitcoin-core-dev
158 2020-04-29T09:48:34  <bitcoin-git> [bitcoin] promag opened pull request #18814: rpc: Relock wallet only if most recent callback (master...2020-04-rpc-wallet-relock) https://github.com/bitcoin/bitcoin/pull/18814
159 2020-04-29T09:48:45  *** bitcoin-git has left #bitcoin-core-dev
160 2020-04-29T09:51:48  *** sonofhan has quit IRC
161 2020-04-29T10:00:17  *** sonofhan has joined #bitcoin-core-dev
162 2020-04-29T10:01:30  *** brakmic has joined #bitcoin-core-dev
163 2020-04-29T10:07:56  *** mol has joined #bitcoin-core-dev
164 2020-04-29T10:21:18  *** mytwocentimes has quit IRC
165 2020-04-29T10:24:58  *** ccdle12_ has joined #bitcoin-core-dev
166 2020-04-29T10:25:05  *** ccdle12_ has quit IRC
167 2020-04-29T10:39:31  *** someone235 has quit IRC
168 2020-04-29T10:41:31  *** vasild_ has joined #bitcoin-core-dev
169 2020-04-29T10:44:43  *** vasild has quit IRC
170 2020-04-29T10:44:44  *** vasild_ is now known as vasild
171 2020-04-29T10:45:40  *** AaronvanW has quit IRC
172 2020-04-29T10:46:10  *** as_pnn has quit IRC
173 2020-04-29T10:47:55  *** as_pnn has joined #bitcoin-core-dev
174 2020-04-29T10:50:58  *** Chris_Stewart_5 has joined #bitcoin-core-dev
175 2020-04-29T10:58:48  *** mytwocentimes has joined #bitcoin-core-dev
176 2020-04-29T10:59:21  *** kabaum has quit IRC
177 2020-04-29T10:59:24  *** frogar has quit IRC
178 2020-04-29T11:10:33  *** mytwocentimes has quit IRC
179 2020-04-29T11:13:01  *** LuisAranguren has joined #bitcoin-core-dev
180 2020-04-29T11:30:05  *** bitcoin-git has joined #bitcoin-core-dev
181 2020-04-29T11:30:06  <bitcoin-git> [bitcoin] rebroad closed pull request #18760: Disconnect nodes with bad messages during IBD (master...IBDDisconnectBadChecksum) https://github.com/bitcoin/bitcoin/pull/18760
182 2020-04-29T11:30:06  *** bitcoin-git has left #bitcoin-core-dev
183 2020-04-29T11:34:24  *** frogar has joined #bitcoin-core-dev
184 2020-04-29T11:38:15  *** sonofhan has quit IRC
185 2020-04-29T11:41:40  *** proofofkeags has joined #bitcoin-core-dev
186 2020-04-29T11:45:56  *** as_pnn has quit IRC
187 2020-04-29T11:45:57  *** jonatack_ has quit IRC
188 2020-04-29T11:46:14  *** proofofkeags has quit IRC
189 2020-04-29T11:46:52  *** jonatack has joined #bitcoin-core-dev
190 2020-04-29T11:47:08  *** _Francisco_ has quit IRC
191 2020-04-29T11:47:08  *** jonatack has quit IRC
192 2020-04-29T11:51:43  *** promag has quit IRC
193 2020-04-29T11:53:38  *** jonatack has joined #bitcoin-core-dev
194 2020-04-29T11:55:06  *** jb55 has quit IRC
195 2020-04-29T11:57:53  *** jb55 has joined #bitcoin-core-dev
196 2020-04-29T11:58:44  *** jonatack has quit IRC
197 2020-04-29T11:59:38  *** jonatack has joined #bitcoin-core-dev
198 2020-04-29T12:00:01  *** c9sloud has quit IRC
199 2020-04-29T12:16:03  *** mol has quit IRC
200 2020-04-29T12:22:14  *** Vogone has joined #bitcoin-core-dev
201 2020-04-29T12:24:17  *** bitcoin-git has joined #bitcoin-core-dev
202 2020-04-29T12:24:18  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0ef0d33f7562...ecca2ea1d5f6
203 2020-04-29T12:24:19  <bitcoin-git> bitcoin/master fcb7261 Russell Yanofsky: Prevent valgrind false positive in rest_blockhash_by_height
204 2020-04-29T12:24:19  <bitcoin-git> bitcoin/master ecca2ea MarcoFalke: Merge #18785: Prevent valgrind false positive in rest_blockhash_by_height
205 2020-04-29T12:24:21  *** bitcoin-git has left #bitcoin-core-dev
206 2020-04-29T12:24:37  *** bitcoin-git has joined #bitcoin-core-dev
207 2020-04-29T12:24:38  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18785: Prevent valgrind false positive in rest_blockhash_by_height (master...pr/grind) https://github.com/bitcoin/bitcoin/pull/18785
208 2020-04-29T12:24:38  *** bitcoin-git has left #bitcoin-core-dev
209 2020-04-29T12:31:26  *** bitcoin-git has joined #bitcoin-core-dev
210 2020-04-29T12:31:26  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ecca2ea1d5f6...af2ec6b03745
211 2020-04-29T12:31:27  <bitcoin-git> bitcoin/master fabe44e MarcoFalke: bench: Start nodes with -nodebuglogfile
212 2020-04-29T12:31:27  <bitcoin-git> bitcoin/master af2ec6b MarcoFalke: Merge #18759: bench: Start nodes with -nodebuglogfile
213 2020-04-29T12:31:29  *** bitcoin-git has left #bitcoin-core-dev
214 2020-04-29T12:31:46  *** bitcoin-git has joined #bitcoin-core-dev
215 2020-04-29T12:31:46  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18759: bench: Start nodes with -nodebuglogfile (master...2004-benchNoDebugLog) https://github.com/bitcoin/bitcoin/pull/18759
216 2020-04-29T12:31:48  *** bitcoin-git has left #bitcoin-core-dev
217 2020-04-29T12:38:13  *** promag has joined #bitcoin-core-dev
218 2020-04-29T12:40:26  *** molakala has joined #bitcoin-core-dev
219 2020-04-29T12:41:28  *** whythat has left #bitcoin-core-dev
220 2020-04-29T12:43:25  *** promag has quit IRC
221 2020-04-29T12:53:44  *** bitcoin-git has joined #bitcoin-core-dev
222 2020-04-29T12:53:44  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18815: bench: Add logging benchmark (master...2004-benchLog) https://github.com/bitcoin/bitcoin/pull/18815
223 2020-04-29T12:53:45  *** bitcoin-git has left #bitcoin-core-dev
224 2020-04-29T12:54:50  *** promag has joined #bitcoin-core-dev
225 2020-04-29T13:01:40  *** Guyver2 has quit IRC
226 2020-04-29T13:02:57  *** promag has quit IRC
227 2020-04-29T13:08:54  *** cryptoIndio has quit IRC
228 2020-04-29T13:10:05  *** cryptoIndio has joined #bitcoin-core-dev
229 2020-04-29T13:14:37  *** cryptoIndio has quit IRC
230 2020-04-29T13:20:45  *** dqx has quit IRC
231 2020-04-29T13:27:37  *** cryptoIndio has joined #bitcoin-core-dev
232 2020-04-29T13:28:10  *** dqx has joined #bitcoin-core-dev
233 2020-04-29T13:34:23  *** vasild has quit IRC
234 2020-04-29T13:34:37  *** vasild has joined #bitcoin-core-dev
235 2020-04-29T13:35:23  *** jb55 has quit IRC
236 2020-04-29T13:36:06  *** jb55 has joined #bitcoin-core-dev
237 2020-04-29T13:42:24  *** proofofkeags has joined #bitcoin-core-dev
238 2020-04-29T13:46:46  *** proofofkeags has quit IRC
239 2020-04-29T13:55:47  *** mdunnio has joined #bitcoin-core-dev
240 2020-04-29T13:56:16  *** AaronvanW has joined #bitcoin-core-dev
241 2020-04-29T14:04:24  <vasild> wumpus: While looking at the addrv2/BIP155 wip PR #16748 I realized that in CSubNet we support netmasks that have 0-bits followed by 1-bits, e.g. /
242 2020-04-29T14:04:29  <gribble> https://github.com/bitcoin/bitcoin/issues/16748 | [WIP] Add support for addrv2 (BIP155) by dongcarl · Pull Request #16748 · bitcoin/bitcoin · GitHub
243 2020-04-29T14:05:05  <vasild> We even have test for that: https://github.com/bitcoin/bitcoin/blob/master/src/test/netbase_tests.cpp#L280-L283 which was added by you via https://github.com/bitcoin/bitcoin/pull/6315#issuecomment-115169435
244 2020-04-29T14:05:38  <dongcarl> vasild: I apologize for not responding in time to the reviews, it's on my list now :-)
245 2020-04-29T14:05:49  <vasild> I am just wondering - why do we support such strange (invalid) netmasks and can we drop that support?
246 2020-04-29T14:07:14  <vasild> dongcarl: no problem, I got distracted by the netmasks and dived into some CSubNet cleanup that would drop support for netmasks like /
247 2020-04-29T14:07:53  <dongcarl> vasild: I'm guessing you're thinking just have a uint type that specifies the prefix length?
248 2020-04-29T14:08:11  <vasild> dongcarl: you read my thoughts!
249 2020-04-29T14:09:21  <dongcarl> Hmm... well are there legitimate cases where a netmask can have 0's in the middle?
250 2020-04-29T14:09:33  <vasild> replace the `uint8_t netmask[16];` in CSubNet with `uint8_t cidr;` which can be in [0, 32] for ipv4 and [0, 128] for ipv6.
251 2020-04-29T14:11:07  <vasild> dongcarl: right, I do not know, but to me that contradicts with the idea of subnetting
252 2020-04-29T14:11:28  *** mol has joined #bitcoin-core-dev
253 2020-04-29T14:12:10  <vasild> I was thinking that this is just some unintended side effect, but then found a deliberate test cases that expect such support (above link ^), so I decided to ask :)
254 2020-04-29T14:12:59  *** cryptoIndio has quit IRC
255 2020-04-29T14:14:32  *** lucaferr has quit IRC
256 2020-04-29T14:15:18  <dongcarl> vasild: I think it'd probably be good to leave as is, mostly because the contiguous-ness is not really enforced in the RFCs, and it seems more flexible for the future. Will look into it though.
257 2020-04-29T14:15:45  <vasild> dongcarl: It is!
258 2020-04-29T14:15:58  <vasild> I read it somewhere, let me find it...
259 2020-04-29T14:16:01  *** mrwhythat has joined #bitcoin-core-dev
260 2020-04-29T14:17:08  *** mrwhythat is now known as whythat
261 2020-04-29T14:18:20  *** cryptoIndio has joined #bitcoin-core-dev
262 2020-04-29T14:19:13  *** whythat has quit IRC
263 2020-04-29T14:19:24  *** whythat has joined #bitcoin-core-dev
264 2020-04-29T14:23:00  *** cryptoIndio has quit IRC
265 2020-04-29T14:23:16  <vasild> dongcarl: https://en.wikipedia.org/wiki/Classless_Inter-Domain_Routing#Subnet_masks
266 2020-04-29T14:23:34  <vasild> "Subnet masks were allowed by RFC 950[5] to specify non-contiguous bits until RFC 4632[4]:Section 5.1 stated that the mask must be left contiguous. Given this constraint, a subnet mask and CIDR notation serve exactly the same function."
267 2020-04-29T14:26:48  <vasild> indeed https://tools.ietf.org/html/rfc4632#section-5.1 says "The only outstanding constraint is that the
268 2020-04-29T14:27:14  <vasild>    mask must be left contiguous.
269 2020-04-29T14:27:27  <wumpus> vasild: it doesn't matter too much to me, but if you have a good reason to remove that support it's OK with me
270 2020-04-29T14:27:58  <wumpus> just doing it for the sake of it seems useless, it doesn't hurt to support more than strictly expected
271 2020-04-29T14:29:07  <wumpus> I don't think it has any impact on addrv2, AFAIK we never send subnets over the P2P
272 2020-04-29T14:30:28  *** Guyver2 has joined #bitcoin-core-dev
273 2020-04-29T14:31:04  <vasild> yes, I agree - "for the sake of it" is useless. The main reason I started looking into it was that it would simplify addrv2 changes: https://github.com/bitcoin/bitcoin/pull/16748#discussion_r414663229
274 2020-04-29T14:31:35  *** bitcoin-git has joined #bitcoin-core-dev
275 2020-04-29T14:31:36  <bitcoin-git> [bitcoin] practicalswift closed pull request #17895: build: Enable Clang's -Wconditional-uninitialized to warn on potential uninitialized reads (master...continue-killing-of-uninitialized-reads) https://github.com/bitcoin/bitcoin/pull/17895
276 2020-04-29T14:31:36  *** bitcoin-git has left #bitcoin-core-dev
277 2020-04-29T14:32:31  <vasild> this modification fiddles with the `uint8_t netmask[16];` array
278 2020-04-29T14:34:14  <vasild> and having to increase that to netmask[32] would be far from perfect, given that it can be just a single byte.
279 2020-04-29T14:36:38  <dongcarl> vasild: Working on sth else right now but will take a look today. One thing that came to mind when I last looked into this: the NetMask code looks like it was written with the assumption that all CNetAddrs would be addresses in address families where netmasks made sense... With the addition of tor, that's not the case anymore
280 2020-04-29T14:39:18  *** promag has joined #bitcoin-core-dev
281 2020-04-29T14:39:21  <vasild> Right! Netmasks do not make any sense in the new types too: torv3, i2p, cjdns.
282 2020-04-29T14:40:35  *** bitcoin-git has joined #bitcoin-core-dev
283 2020-04-29T14:40:36  <bitcoin-git> [bitcoin] practicalswift closed pull request #18147: qt: Kill the locale dependency bug class by not allowing Qt to mess with LC_NUMERIC (master...kill-locale-dependency-bug-class) https://github.com/bitcoin/bitcoin/pull/18147
284 2020-04-29T14:40:36  *** bitcoin-git has left #bitcoin-core-dev
285 2020-04-29T14:42:58  *** bitcoin-git has joined #bitcoin-core-dev
286 2020-04-29T14:42:59  <bitcoin-git> [bitcoin] practicalswift closed pull request #18124: init: Clarify C and C++ locale assumptions. Add locale sanity checks to verify assumptions at run-time. (master...LocaleSanityCheck) https://github.com/bitcoin/bitcoin/pull/18124
287 2020-04-29T14:43:01  *** bitcoin-git has left #bitcoin-core-dev
288 2020-04-29T14:44:08  *** promag has quit IRC
289 2020-04-29T14:44:46  <vasild> I will leave the "uint8_t netmask[16]" -> "uint8_t cidr" change away for now. Ideally we shouldn't be using netmasks for e.g. torv3 at all, or we just use one special mask which denotes "matches just one address"
290 2020-04-29T14:45:40  *** proofofkeags has joined #bitcoin-core-dev
291 2020-04-29T14:46:15  *** mol has quit IRC
292 2020-04-29T14:46:41  <dongcarl> vasild: Sounds good, always good to explore the options :-) I'll take a closer look at your comments today
293 2020-04-29T14:49:07  <vasild> dongcarl: btw, I rebased the PR on latest master (required some non-trivial conflict resolution) and fixed the failing unit tests.
294 2020-04-29T14:49:27  <dongcarl> vasild: Oh yeah? Do you have a branch up?
295 2020-04-29T14:50:08  <vasild> dongcarl: not pushed on gh, I was wondering how to proceed with that...
296 2020-04-29T14:51:28  <wumpus> agree, netmasks make no sense for non-hierarchical addresses types
297 2020-04-29T14:51:39  <dongcarl> vasild: Well, if it's acceptable to you, you should put yourself as co-author on the commits, and push as a branch to your remote on github e.g. `vaslid/bitcoin`, and I'll get those commits into my branch/PR
298 2020-04-29T14:52:25  <wumpus> and the cidr-based notation is more compact, though it might be more expensive to match against? I'm not sure
299 2020-04-29T14:54:51  <vasild> dongcarl: makes sense, I will clean up a bit and push to gh.
300 2020-04-29T14:55:02  <dongcarl> vasild: Many thanks!
301 2020-04-29T14:55:11  <vasild> yw :)
302 2020-04-29T14:58:52  *** mol has joined #bitcoin-core-dev
303 2020-04-29T15:00:02  *** Vogone has quit IRC
304 2020-04-29T15:02:05  <vasild> wumpus: more compact and the only valid representation for ipv6, as for speed of matching - we have to compare the first `cidr` bits, I don't think it will make a difference wrt performance.
305 2020-04-29T15:04:47  <vasild> btw our current implementation https://github.com/bitcoin/bitcoin/blob/master/src/netaddress.cpp#L815 is checking all 16 bytes unnecessary - it could stop checking (break; from the loop) as soon as it finds a 0 byte in the netmask. E.g. with a netmask like / we don't need to check whether `(addr.ip[x] & netmask[x]) != network.ip[x]` is true or false for the last 3 bytes
306 2020-04-29T15:05:12  <wumpus> yes, I'm fairly sure it can be optimized to be just as fast or even faster, without converting to an and-mask inbetween
307 2020-04-29T15:05:32  <wumpus> no need for constant time matching here
308 2020-04-29T15:05:46  <vasild> this is all minor, low-priority I guess
309 2020-04-29T15:05:48  <wumpus> correct
310 2020-04-29T15:05:54  *** mol has quit IRC
311 2020-04-29T15:06:12  <wumpus> though some people have extremely large ban lists :)
312 2020-04-29T15:06:39  <vasild> how large?
313 2020-04-29T15:07:08  *** proofofkeags has quit IRC
314 2020-04-29T15:07:20  <wumpus> ~1000 entries
315 2020-04-29T15:07:21  *** proofofkeags has joined #bitcoin-core-dev
316 2020-04-29T15:08:02  <vasild> hmm
317 2020-04-29T15:08:22  <wumpus> not something any CPU capable of running a bitcoin node in the first place will have any trouble with I guess, it's only per-incoming-connection not per packet
318 2020-04-29T15:10:16  *** bitcoin-git has joined #bitcoin-core-dev
319 2020-04-29T15:10:17  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/af2ec6b03745...e302830faed0
320 2020-04-29T15:10:17  <bitcoin-git> bitcoin/master 66fe7b1 Harris: test: added test for upgradewallet RPC
321 2020-04-29T15:10:18  <bitcoin-git> bitcoin/master e302830 MarcoFalke: Merge #18774: test: added test for upgradewallet RPC
322 2020-04-29T15:10:19  *** bitcoin-git has left #bitcoin-core-dev
323 2020-04-29T15:10:32  <vasild> seems like a minor / low priority performance improvement can be done in the subnet matching code wrt that. Also the size of CSubNet would be reduced with 15 bytes, 15*1000 bytes is nothing in RAM or on disk
324 2020-04-29T15:10:36  *** bitcoin-git has joined #bitcoin-core-dev
325 2020-04-29T15:10:37  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18774: test: added test for upgradewallet RPC (master...upgradewallet-tests) https://github.com/bitcoin/bitcoin/pull/18774
326 2020-04-29T15:10:38  *** bitcoin-git has left #bitcoin-core-dev
327 2020-04-29T15:11:17  *** bitcoin-git has joined #bitcoin-core-dev
328 2020-04-29T15:11:18  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18616: refactor: Cleanup clientversion.cpp (master...20200413-version) https://github.com/bitcoin/bitcoin/pull/18616
329 2020-04-29T15:11:19  *** bitcoin-git has left #bitcoin-core-dev
330 2020-04-29T15:11:36  *** bitcoin-git has joined #bitcoin-core-dev
331 2020-04-29T15:11:37  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18616: refactor: Cleanup clientversion.cpp (master...20200413-version) https://github.com/bitcoin/bitcoin/pull/18616
332 2020-04-29T15:11:38  *** bitcoin-git has left #bitcoin-core-dev
333 2020-04-29T15:11:53  <vasild> wumpus: dongcarl: anyway, I plan to spend full time on BIP155/addrv2/torv3/i2p/cjdns, modulo distractions :)
334 2020-04-29T15:15:40  *** bitcoin-git has joined #bitcoin-core-dev
335 2020-04-29T15:15:40  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e302830faed0...ab91a0e0fc6e
336 2020-04-29T15:15:41  <bitcoin-git> bitcoin/master 45615de Hennadii Stepanov: ci: Fix default retry script usage
337 2020-04-29T15:15:41  <bitcoin-git> bitcoin/master ab91a0e MarcoFalke: Merge #18798: ci: Fix default retry script usage
338 2020-04-29T15:15:43  *** bitcoin-git has left #bitcoin-core-dev
339 2020-04-29T15:15:56  *** bitcoin-git has joined #bitcoin-core-dev
340 2020-04-29T15:15:56  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18798: ci: Fix default retry script usage (master...200428-ci-retry) https://github.com/bitcoin/bitcoin/pull/18798
341 2020-04-29T15:15:57  *** bitcoin-git has left #bitcoin-core-dev
342 2020-04-29T15:18:45  <wumpus> vasild: awesome!
343 2020-04-29T15:20:12  *** cryptoIndio has joined #bitcoin-core-dev
344 2020-04-29T15:22:12  *** Dogechain has joined #bitcoin-core-dev
345 2020-04-29T15:25:14  *** bitcoin-git has joined #bitcoin-core-dev
346 2020-04-29T15:25:15  <bitcoin-git> [bitcoin] practicalswift opened pull request #18817: doc: Document differences in bitcoind and bitcoin-qt locale handling (master...bitcoin-qt-vs-bitcoind-locale) https://github.com/bitcoin/bitcoin/pull/18817
347 2020-04-29T15:25:26  *** bitcoin-git has left #bitcoin-core-dev
348 2020-04-29T15:26:14  *** bitcoin-git has joined #bitcoin-core-dev
349 2020-04-29T15:26:15  <bitcoin-git> [bitcoin] luke-jr opened pull request #18818: Fix release tarball generated by gitian (master...fix_gitian_src_202004) https://github.com/bitcoin/bitcoin/pull/18818
350 2020-04-29T15:26:15  *** bitcoin-git has left #bitcoin-core-dev
351 2020-04-29T15:27:10  *** sonofhan has joined #bitcoin-core-dev
352 2020-04-29T15:29:46  *** sonofhan has quit IRC
353 2020-04-29T15:39:14  *** justanotheruser has quit IRC
354 2020-04-29T15:44:23  *** quixote911 has joined #bitcoin-core-dev
355 2020-04-29T15:46:43  *** quixote911 has quit IRC
356 2020-04-29T15:53:21  <luke-jr> ^ should also get tagged for 0.20
357 2020-04-29T15:54:30  *** justanotheruser has joined #bitcoin-core-dev
358 2020-04-29T16:08:28  *** bitcoin-git has joined #bitcoin-core-dev
359 2020-04-29T16:08:28  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ab91a0e0fc6e...978c5a212240
360 2020-04-29T16:08:29  <bitcoin-git> bitcoin/master 8098dea Hennadii Stepanov: test: Add mempool_updatefromblock.py
361 2020-04-29T16:08:29  <bitcoin-git> bitcoin/master 978c5a2 MarcoFalke: Merge #18485: test: Add mempool_updatefromblock.py
362 2020-04-29T16:08:31  *** bitcoin-git has left #bitcoin-core-dev
363 2020-04-29T16:09:08  *** bitcoin-git has joined #bitcoin-core-dev
364 2020-04-29T16:09:08  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18485: test: Add mempool_updatefromblock.py (master...20200331-test-mempool) https://github.com/bitcoin/bitcoin/pull/18485
365 2020-04-29T16:09:09  *** bitcoin-git has left #bitcoin-core-dev
366 2020-04-29T16:09:12  *** Highway61 has quit IRC
367 2020-04-29T16:12:16  *** Highway61 has joined #bitcoin-core-dev
368 2020-04-29T16:12:48  *** mol has joined #bitcoin-core-dev
369 2020-04-29T16:12:53  *** jarthur has joined #bitcoin-core-dev
370 2020-04-29T16:13:50  *** cryptoIndio has quit IRC
371 2020-04-29T16:15:14  *** cryptoIndio has joined #bitcoin-core-dev
372 2020-04-29T16:23:31  *** mol has quit IRC
373 2020-04-29T16:26:23  *** mol has joined #bitcoin-core-dev
374 2020-04-29T16:29:04  *** cryptoIndio has quit IRC
375 2020-04-29T16:30:34  *** Guyver2_ has joined #bitcoin-core-dev
376 2020-04-29T16:30:58  *** cryptoIndio has joined #bitcoin-core-dev
377 2020-04-29T16:33:10  *** Guyver2 has quit IRC
378 2020-04-29T16:37:23  *** michaelfolkson has joined #bitcoin-core-dev
379 2020-04-29T16:41:21  *** cryptoIndio has quit IRC
380 2020-04-29T16:46:42  *** cryptoIndio has joined #bitcoin-core-dev
381 2020-04-29T16:48:15  *** Highway61 has quit IRC
382 2020-04-29T16:51:38  *** cryptoIndio has quit IRC
383 2020-04-29T16:53:56  *** shaunsun has joined #bitcoin-core-dev
384 2020-04-29T17:06:25  *** dviola has joined #bitcoin-core-dev
385 2020-04-29T17:14:18  *** owowo has quit IRC
386 2020-04-29T17:15:40  *** pinheadmz_ has joined #bitcoin-core-dev
387 2020-04-29T17:16:43  *** whythat has quit IRC
388 2020-04-29T17:18:04  *** promag has joined #bitcoin-core-dev
389 2020-04-29T17:18:11  *** pinheadmz has quit IRC
390 2020-04-29T17:18:11  *** pinheadmz_ is now known as pinheadmz
391 2020-04-29T17:18:54  *** owowo has joined #bitcoin-core-dev
392 2020-04-29T17:29:22  *** Highway61 has joined #bitcoin-core-dev
393 2020-04-29T17:30:27  *** proofofkeags has quit IRC
394 2020-04-29T17:30:51  *** whythat has joined #bitcoin-core-dev
395 2020-04-29T17:38:03  *** whythat has quit IRC
396 2020-04-29T17:39:40  *** cryptoIndio has joined #bitcoin-core-dev
397 2020-04-29T17:41:43  *** proofofkeags has joined #bitcoin-core-dev
398 2020-04-29T17:45:14  *** Highway62 has joined #bitcoin-core-dev
399 2020-04-29T17:45:25  *** whythat has joined #bitcoin-core-dev
400 2020-04-29T17:46:45  *** Highway61 has quit IRC
401 2020-04-29T17:46:45  *** Highway62 is now known as Highway61
402 2020-04-29T17:47:16  *** jarthur has quit IRC
403 2020-04-29T17:56:23  *** whythat has quit IRC
404 2020-04-29T18:00:02  *** Dogechain has quit IRC
405 2020-04-29T18:01:40  *** mdunnio has quit IRC
406 2020-04-29T18:02:34  *** DeanGuss has joined #bitcoin-core-dev
407 2020-04-29T18:03:34  *** shaunsun has quit IRC
408 2020-04-29T18:05:46  *** whythat has joined #bitcoin-core-dev
409 2020-04-29T18:07:09  *** _andrewtoth_ has quit IRC
410 2020-04-29T18:07:22  *** andrewtoth has joined #bitcoin-core-dev
411 2020-04-29T18:08:20  *** mol_ has joined #bitcoin-core-dev
412 2020-04-29T18:11:15  *** mol has quit IRC
413 2020-04-29T18:11:36  *** mdunnio has joined #bitcoin-core-dev
414 2020-04-29T18:13:48  *** shaunsun has joined #bitcoin-core-dev
415 2020-04-29T18:17:09  *** shaunsun_ has joined #bitcoin-core-dev
416 2020-04-29T18:20:03  *** brrr has joined #bitcoin-core-dev
417 2020-04-29T18:20:06  *** shaunsun has quit IRC
418 2020-04-29T18:22:17  *** DeanGuss has quit IRC
419 2020-04-29T18:22:39  *** DeanGuss has joined #bitcoin-core-dev
420 2020-04-29T18:22:45  *** promag has quit IRC
421 2020-04-29T18:33:00  <achow101> does anyone know what nWalletMaxVersion is for? and why it's distinct from nWalletVersion
422 2020-04-29T18:33:22  <achow101> I think we should be able to consolidate these. which would also make upgradewallet less confusing
423 2020-04-29T18:38:23  *** sipa has quit IRC
424 2020-04-29T18:40:33  *** sipa has joined #bitcoin-core-dev
425 2020-04-29T18:40:46  *** promag has joined #bitcoin-core-dev
426 2020-04-29T18:44:19  *** emilengler has quit IRC
427 2020-04-29T18:45:46  *** promag has quit IRC
428 2020-04-29T18:50:21  *** Guyver2__ has joined #bitcoin-core-dev
429 2020-04-29T18:52:50  <phantomcircuit> it seems at some point in the (probably distant) past the "settings" key for the wallet db was called "setting"
430 2020-04-29T18:53:08  *** Guyver2_ has quit IRC
431 2020-04-29T18:53:20  <phantomcircuit> which is now causing the unknown key counter to go up
432 2020-04-29T18:53:43  <phantomcircuit> however i cannot find any evidence of when that was
433 2020-04-29T18:54:22  <sipa> settings like the position and dimension of the UI screen were once upon a time stored in the wallet
434 2020-04-29T18:55:54  <phantomcircuit> there's a "settings" key which is only "known" to avoid the unknown flag, but no "setting" key
435 2020-04-29T18:56:12  <phantomcircuit> sipa, interesting
436 2020-04-29T18:56:42  <phantomcircuit> this is probably irrelevant to like 99.99% of people since this wallet is a mega old testnet wallet
437 2020-04-29T18:57:01  <sipa> heh
438 2020-04-29T18:57:32  <sipa> i wonder if settings got turned into setting in some refactor and nobody ever noticed
439 2020-04-29T18:57:49  <sipa> or the other way around
440 2020-04-29T18:59:58  *** Guyver2__ is now known as Guyver2
441 2020-04-29T19:06:22  <phantomcircuit> sipa, possibly only in master and not a release even
442 2020-04-29T19:06:43  <sipa> heh
443 2020-04-29T19:13:06  <luke-jr> achow101: upgradewallet doesn't actually do the upgrade until the new features are needed
444 2020-04-29T19:14:02  *** timothy has quit IRC
445 2020-04-29T19:14:15  <luke-jr> so it increases max version immediately, and the actual version gets bumped no higher than that on demand
446 2020-04-29T19:14:55  <sipa> yes, exactly
447 2020-04-29T19:15:01  *** proofofkeags has quit IRC
448 2020-04-29T19:15:15  <achow101> luke-jr: would it be reasonable to break that with the new upgradewallet rpc? That kind of makes sense for the -upgradewallet option, but for a RPC, the upgrade is explicitly being done so bumping the version regardless seems reasonable to me
449 2020-04-29T19:15:53  <sipa> it used to be the case that upgradewallet would permit the use of compressed keys, but only once you actually created a compressed key was the wallet marked as a new version
450 2020-04-29T19:16:17  *** bitcoin-git has joined #bitcoin-core-dev
451 2020-04-29T19:16:17  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18819: net: Remove unused cs_feeFilter (master...2004-netNoRecursiveMutex) https://github.com/bitcoin/bitcoin/pull/18819
452 2020-04-29T19:16:20  *** bitcoin-git has left #bitcoin-core-dev
453 2020-04-29T19:16:24  <sipa> that mechanism wasn't used for encryption, where encrypting would automatically and immediately upgrade iirc
454 2020-04-29T19:16:31  <achow101> this nWalletMaxVersion thing is also only being applied to FEATURE_WALLETCRYPT and FEATURE_COMPRPUBKEY which were introduced ages ago
455 2020-04-29T19:17:23  <sipa> if that mechanism isn't used anymore it may make sense to get rid of it
456 2020-04-29T19:17:23  *** DeanGuss has quit IRC
457 2020-04-29T19:17:39  <sipa> compressed keys was 0.5 iirc
458 2020-04-29T19:18:27  <sipa> in 2011...
459 2020-04-29T19:18:55  <achow101> it only makes sense if you expect the user to downgrade after doing an upgradewallet. and that really doesn't make sense with upgradewallet now being a rpc as its even more explicit
460 2020-04-29T19:19:02  <luke-jr> achow101: frankly, I'm stuck on 0.13 for my wallet because I dislike the direction the wallet is going.. so I'm not sure my opinion counts.
461 2020-04-29T19:20:04  *** DeanGuss has joined #bitcoin-core-dev
462 2020-04-29T19:20:52  <luke-jr> also, our efforts to keep backward compatibility without upgradewallet have failed anyway.. so
463 2020-04-29T19:21:13  <achow101> also there seems to be a nasty bug in SetMinVersion if your wallet was older than FEATURE_WALLETCRYPT and then you encrypted it, the version would jump to the latest. That's a problem as the wallet would have the indications to be HD without actually being HD
464 2020-04-29T19:21:21  <luke-jr> (eg, inclusion of segwit txs in old wallets)
465 2020-04-29T19:21:47  <luke-jr> achow101: encrypting the wallet would make it HD tho, no?
466 2020-04-29T19:22:09  <achow101> luke-jr: maybe?
467 2020-04-29T19:22:28  <achow101> I was just looking at SetMinVersion and this looked like it could be a huge problem as it was just unconditionally jumping to FEATURE_LATEST
468 2020-04-29T19:22:41  <luke-jr> could be
469 2020-04-29T19:23:32  *** jarthur has joined #bitcoin-core-dev
470 2020-04-29T19:25:01  *** bitcoin-git has joined #bitcoin-core-dev
471 2020-04-29T19:25:02  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/978c5a212240...0f204dd3f21b
472 2020-04-29T19:25:02  <bitcoin-git> bitcoin/master 7918c1b Russell Yanofsky: test: Add CreateWalletFromFile test
473 2020-04-29T19:25:03  <bitcoin-git> bitcoin/master 0f204dd MarcoFalke: Merge #18727: test: Add CreateWalletFromFile test
474 2020-04-29T19:25:05  *** bitcoin-git has left #bitcoin-core-dev
475 2020-04-29T19:25:20  *** Highway61 has quit IRC
476 2020-04-29T19:25:21  *** bitcoin-git has joined #bitcoin-core-dev
477 2020-04-29T19:25:21  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18727: test: Add CreateWalletFromFile test (master...pr/create) https://github.com/bitcoin/bitcoin/pull/18727
478 2020-04-29T19:25:22  *** bitcoin-git has left #bitcoin-core-dev
479 2020-04-29T19:25:48  *** Highway61 has joined #bitcoin-core-dev
480 2020-04-29T19:27:55  *** jarthur has quit IRC
481 2020-04-29T19:30:28  *** brrr has quit IRC
482 2020-04-29T19:33:23  *** jonatack has quit IRC
483 2020-04-29T19:33:35  *** yzernik has joined #bitcoin-core-dev
484 2020-04-29T19:34:55  *** sonofhan has joined #bitcoin-core-dev
485 2020-04-29T19:35:09  *** Talkless has quit IRC
486 2020-04-29T19:35:56  *** jonatack has joined #bitcoin-core-dev
487 2020-04-29T19:36:02  *** sonofhan has quit IRC
488 2020-04-29T19:51:24  *** proofofkeags has joined #bitcoin-core-dev
489 2020-04-29T19:56:34  *** promag has joined #bitcoin-core-dev
490 2020-04-29T19:58:43  *** ccallahan1 has joined #bitcoin-core-dev
491 2020-04-29T20:00:48  *** kexkey has joined #bitcoin-core-dev
492 2020-04-29T20:01:03  *** kristapsk_ is now known as kristapsk
493 2020-04-29T20:02:59  *** sonofhan has joined #bitcoin-core-dev
494 2020-04-29T20:04:39  *** sonofhan has quit IRC
495 2020-04-29T20:12:31  *** proofofkeags has quit IRC
496 2020-04-29T20:14:37  *** Chris_Stewart_5 has quit IRC
497 2020-04-29T20:14:57  *** proofofkeags has joined #bitcoin-core-dev
498 2020-04-29T20:20:27  *** lightlike has joined #bitcoin-core-dev
499 2020-04-29T20:20:53  *** Chris_Stewart_5 has joined #bitcoin-core-dev
500 2020-04-29T20:31:03  *** DeanGuss has quit IRC
501 2020-04-29T20:34:31  *** brakmic_ has joined #bitcoin-core-dev
502 2020-04-29T20:34:54  *** jonatack has quit IRC
503 2020-04-29T20:36:36  *** whythat has quit IRC
504 2020-04-29T20:36:44  *** mrwhythat has joined #bitcoin-core-dev
505 2020-04-29T20:36:50  *** jb55 has quit IRC
506 2020-04-29T20:36:57  *** Krellan_ has joined #bitcoin-core-dev
507 2020-04-29T20:36:57  *** DeanGuss has joined #bitcoin-core-dev
508 2020-04-29T20:38:10  *** brakmic has quit IRC
509 2020-04-29T20:43:08  *** bitcoin-git has joined #bitcoin-core-dev
510 2020-04-29T20:43:09  <bitcoin-git> [bitcoin] dongcarl opened pull request #18820: build: Propagate well-known vars into depends (master...2020-04-improve-depends-hosts2) https://github.com/bitcoin/bitcoin/pull/18820
511 2020-04-29T20:43:09  *** bitcoin-git has left #bitcoin-core-dev
512 2020-04-29T20:46:19  *** jonatack has joined #bitcoin-core-dev
513 2020-04-29T21:00:01  *** ccallahan1 has quit IRC
514 2020-04-29T21:20:09  *** yzernik has quit IRC
515 2020-04-29T21:20:54  *** Guyver2 has quit IRC
516 2020-04-29T21:22:07  *** phyll1s_work has joined #bitcoin-core-dev
517 2020-04-29T21:24:30  *** proofofkeags has quit IRC
518 2020-04-29T21:25:05  *** proofofkeags has joined #bitcoin-core-dev
519 2020-04-29T21:29:15  *** proofofkeags has quit IRC
520 2020-04-29T21:31:33  *** proofofkeags has joined #bitcoin-core-dev
521 2020-04-29T21:32:11  *** promag_ has joined #bitcoin-core-dev
522 2020-04-29T21:32:54  *** proofofk_ has joined #bitcoin-core-dev
523 2020-04-29T21:33:15  *** molakala has quit IRC
524 2020-04-29T21:36:15  *** promag_ has quit IRC
525 2020-04-29T21:36:20  *** proofofkeags has quit IRC
526 2020-04-29T21:41:21  *** michaelfolkson has quit IRC
527 2020-04-29T21:43:52  *** michaelfolkson has joined #bitcoin-core-dev
528 2020-04-29T21:53:31  *** mrwhythat is now known as whythat
529 2020-04-29T21:56:34  *** shaunsun_ has quit IRC
530 2020-04-29T21:59:05  *** shaunsun has joined #bitcoin-core-dev
531 2020-04-29T21:59:29  *** whythat has quit IRC
532 2020-04-29T22:00:12  *** andrewtoth has quit IRC
533 2020-04-29T22:00:50  *** andrewtoth has joined #bitcoin-core-dev
534 2020-04-29T22:14:50  *** mdunnio has quit IRC
535 2020-04-29T22:15:12  *** shaunsun has quit IRC
536 2020-04-29T22:21:13  *** justanotheruser has quit IRC
537 2020-04-29T22:21:41  *** michaelfolkson has quit IRC
538 2020-04-29T22:37:03  *** DeanGuss has quit IRC
539 2020-04-29T22:37:14  *** DeanGuss has joined #bitcoin-core-dev
540 2020-04-29T22:39:39  *** soju has joined #bitcoin-core-dev
541 2020-04-29T22:41:25  *** vasild_ has joined #bitcoin-core-dev
542 2020-04-29T22:45:03  *** vasild has quit IRC
543 2020-04-29T22:45:04  *** vasild_ is now known as vasild
544 2020-04-29T22:51:22  *** marcoagner has quit IRC
545 2020-04-29T22:55:53  *** bitcoin-git has joined #bitcoin-core-dev
546 2020-04-29T22:55:53  <bitcoin-git> [bitcoin] MarcoFalke pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/0f204dd3f21b...95a9165016ec
547 2020-04-29T22:55:54  <bitcoin-git> bitcoin/master a19598c practicalswift: tests: Add fuzzing harness for functions in system.h (ArgsManager)
548 2020-04-29T22:55:54  <bitcoin-git> bitcoin/master a4e3d13 practicalswift: tests: Add fuzzing coverage for StringForFeeReason(...)
549 2020-04-29T22:55:55  <bitcoin-git> bitcoin/master 90b635e practicalswift: tests: Add fuzzing coverage for CHECK_NONFATAL(...)
550 2020-04-29T22:55:56  *** bitcoin-git has left #bitcoin-core-dev
551 2020-04-29T22:56:13  *** bitcoin-git has joined #bitcoin-core-dev
552 2020-04-29T22:56:13  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18736: test: Add fuzzing harnesses for various classes/functions in util/ (master...fuzzers-2020-04-21) https://github.com/bitcoin/bitcoin/pull/18736
553 2020-04-29T22:56:14  *** bitcoin-git has left #bitcoin-core-dev
554 2020-04-29T22:57:43  *** bitcoin-git has joined #bitcoin-core-dev
555 2020-04-29T22:57:43  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/95a9165016ec...36c0abd8f61b
556 2020-04-29T22:57:44  <bitcoin-git> bitcoin/master cd543d9 Danny Lee: test: check misbehavior more independently in p2p_filter.py
557 2020-04-29T22:57:44  <bitcoin-git> bitcoin/master 36c0abd MarcoFalke: Merge #18726: test: check misbehavior more independently in p2p_filter.py
558 2020-04-29T22:57:46  *** bitcoin-git has left #bitcoin-core-dev
559 2020-04-29T22:58:03  *** bitcoin-git has joined #bitcoin-core-dev
560 2020-04-29T22:58:04  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18726: test: check misbehavior more independently in p2p_filter.py (master...p2p-filter) https://github.com/bitcoin/bitcoin/pull/18726
561 2020-04-29T22:58:05  *** bitcoin-git has left #bitcoin-core-dev
562 2020-04-29T23:03:36  *** shaunsun has joined #bitcoin-core-dev
563 2020-04-29T23:08:38  *** justanotheruser has joined #bitcoin-core-dev
564 2020-04-29T23:10:03  *** DeanGuss has quit IRC
565 2020-04-29T23:22:39  *** DeanGuss has joined #bitcoin-core-dev
566 2020-04-29T23:24:37  *** shaunsun has quit IRC
567 2020-04-29T23:27:20  *** pinheadmz has quit IRC
568 2020-04-29T23:38:33  *** lightlike has quit IRC
569 2020-04-29T23:43:53  *** pinheadmz has joined #bitcoin-core-dev
570 2020-04-29T23:56:54  *** jb55 has joined #bitcoin-core-dev
571 2020-04-29T23:59:42  *** proofofk_ has quit IRC