1 2020-05-03T00:00:03  *** jes1 has quit IRC
  2 2020-05-03T00:01:04  *** whythat has joined #bitcoin-core-dev
  3 2020-05-03T00:02:04  *** promag has joined #bitcoin-core-dev
  4 2020-05-03T00:04:07  *** droark has quit IRC
  5 2020-05-03T00:04:29  *** droark has joined #bitcoin-core-dev
  6 2020-05-03T00:05:46  *** droark has quit IRC
  7 2020-05-03T00:06:10  *** droark has joined #bitcoin-core-dev
  8 2020-05-03T00:07:23  *** promag has quit IRC
  9 2020-05-03T00:07:38  *** droark has quit IRC
 10 2020-05-03T00:08:06  *** droark has joined #bitcoin-core-dev
 11 2020-05-03T00:12:03  *** droark has quit IRC
 12 2020-05-03T00:17:52  *** emilengler has quit IRC
 13 2020-05-03T00:22:15  *** patjameson has joined #bitcoin-core-dev
 14 2020-05-03T00:29:33  *** surja795 has joined #bitcoin-core-dev
 15 2020-05-03T00:33:02  *** surja795 has quit IRC
 16 2020-05-03T00:34:14  *** AaronvanW has joined #bitcoin-core-dev
 17 2020-05-03T00:34:57  *** surja795 has joined #bitcoin-core-dev
 18 2020-05-03T00:37:02  *** Guest35617 has quit IRC
 19 2020-05-03T00:37:09  *** Guest35617 has joined #bitcoin-core-dev
 20 2020-05-03T00:40:59  *** surja795_ has joined #bitcoin-core-dev
 21 2020-05-03T00:41:00  *** surja795 has quit IRC
 22 2020-05-03T01:03:44  *** AaronvanW has quit IRC
 23 2020-05-03T01:09:03  *** whythat has quit IRC
 24 2020-05-03T01:13:31  <hebasto> wumpus: sipa: could block nicebbs on the GH?
 25 2020-05-03T01:14:06  *** luke-jr has quit IRC
 26 2020-05-03T01:15:01  *** luke-jr has joined #bitcoin-core-dev
 27 2020-05-03T01:16:14  *** promag has joined #bitcoin-core-dev
 28 2020-05-03T01:18:38  <sipa> hebasto: i'm not convinced that's spam
 29 2020-05-03T01:20:14  <hebasto> ok, will try to translate it :D
 30 2020-05-03T01:21:53  <hebasto> sipa: sorry for false alarming
 31 2020-05-03T01:24:46  *** Nebraskka has quit IRC
 32 2020-05-03T01:24:47  <sipa> np
 33 2020-05-03T01:25:23  *** Nebraskka has joined #bitcoin-core-dev
 34 2020-05-03T01:26:44  *** brakmic has quit IRC
 35 2020-05-03T01:33:39  *** proofofkeags has quit IRC
 36 2020-05-03T01:34:14  *** proofofkeags has joined #bitcoin-core-dev
 37 2020-05-03T01:37:25  *** proofofk_ has joined #bitcoin-core-dev
 38 2020-05-03T01:41:43  *** proofofkeags has quit IRC
 39 2020-05-03T01:44:14  *** dviola has quit IRC
 40 2020-05-03T01:44:14  *** hebasto has quit IRC
 41 2020-05-03T01:44:51  <fanquake> yea I don't think that's spam either
 42 2020-05-03T01:45:23  *** hebasto has joined #bitcoin-core-dev
 43 2020-05-03T01:49:26  *** promag has quit IRC
 44 2020-05-03T02:07:44  *** dviola has joined #bitcoin-core-dev
 45 2020-05-03T02:11:35  <ossifrage> Should bitcoind be more aggressive in banning nodes that send high-hash or bad-diffbits?
 46 2020-05-03T02:18:59  *** dviola has quit IRC
 47 2020-05-03T02:20:00  *** dviola has joined #bitcoin-core-dev
 48 2020-05-03T02:28:14  *** mol_ has joined #bitcoin-core-dev
 49 2020-05-03T02:29:05  *** proofofk_ has quit IRC
 50 2020-05-03T02:29:40  *** proofofkeags has joined #bitcoin-core-dev
 51 2020-05-03T02:31:31  *** molz_ has quit IRC
 52 2020-05-03T02:34:29  *** proofofkeags has quit IRC
 53 2020-05-03T02:45:19  *** proofofkeags has joined #bitcoin-core-dev
 54 2020-05-03T02:49:54  *** proofofkeags has quit IRC
 55 2020-05-03T02:55:44  *** molz_ has joined #bitcoin-core-dev
 56 2020-05-03T02:58:16  *** proofofkeags has joined #bitcoin-core-dev
 57 2020-05-03T02:58:34  *** mol_ has quit IRC
 58 2020-05-03T02:59:29  *** proofofkeags has quit IRC
 59 2020-05-03T03:00:02  *** patjameson has quit IRC
 60 2020-05-03T03:00:05  *** proofofkeags has joined #bitcoin-core-dev
 61 2020-05-03T03:01:01  *** AaronvanW has joined #bitcoin-core-dev
 62 2020-05-03T03:04:56  *** proofofkeags has quit IRC
 63 2020-05-03T03:16:45  *** promag has joined #bitcoin-core-dev
 64 2020-05-03T03:16:48  *** promag has quit IRC
 65 2020-05-03T03:31:35  *** IGHOR has quit IRC
 66 2020-05-03T03:34:52  *** AaronvanW has quit IRC
 67 2020-05-03T03:41:29  *** IGHOR has joined #bitcoin-core-dev
 68 2020-05-03T03:46:11  *** bitcoin-git has joined #bitcoin-core-dev
 69 2020-05-03T03:46:11  <bitcoin-git> [bitcoin] achow101 opened pull request #18855: tests: feature_backwards_compatibility.py test downgrade after upgrade (master...test-backcompat-updowngrade) https://github.com/bitcoin/bitcoin/pull/18855
 70 2020-05-03T03:46:12  *** bitcoin-git has left #bitcoin-core-dev
 71 2020-05-03T03:48:54  *** OlyaAbram has joined #bitcoin-core-dev
 72 2020-05-03T03:51:21  *** OlyaAbram has quit IRC
 73 2020-05-03T03:56:22  *** keyboardsurfer has joined #bitcoin-core-dev
 74 2020-05-03T04:06:08  <luke-jr> ossifrage: no
 75 2020-05-03T04:06:13  <luke-jr> ossifrage: we're already too aggressive
 76 2020-05-03T04:06:48  <sipa> i don't see a good reason not to disconnect on invalid PoW, actually
 77 2020-05-03T04:07:22  <sipa> that's unambiguously invalid, for as long as the protocol existed
 78 2020-05-03T04:07:52  <luke-jr> disconnect != ban
 79 2020-05-03T04:08:18  <luke-jr> though having difficulty coming up with a scenario where banning would be bad
 80 2020-05-03T04:08:38  <luke-jr> oh, thought of one:
 81 2020-05-03T04:08:45  <luke-jr> a hardfork to reclaim always-zero bits in the header
 82 2020-05-03T04:09:27  <luke-jr> we'd of course reject the HF blocks, but we still want to share our best chain with such nodes
 83 2020-05-03T04:09:30  *** promag has joined #bitcoin-core-dev
 84 2020-05-03T04:09:48  <luke-jr> disconnection might be a problem there too
 85 2020-05-03T04:11:20  <sipa> i think banning is desired behavior between nodes on different sides of a HF
 86 2020-05-03T04:11:43  <sipa> to partition as quickly as possible, and not waste connection slots on either side with peers they disagree with
 87 2020-05-03T04:12:27  <luke-jr> partitioning is bad and should not happen with a HF
 88 2020-05-03T04:12:45  <sipa> ?!
 89 2020-05-03T04:12:56  <luke-jr> furthermore, it is at best a false sense of "security" since anyone can start a bridge later
 90 2020-05-03T04:13:09  <sipa> there is nothing to bridge
 91 2020-05-03T04:13:11  <luke-jr> sipa: I'm talking about real HFs, not scamcoins calling themselves HFs
 92 2020-05-03T04:13:33  <luke-jr> also HFs that *only* make invalid blocks valid
 93 2020-05-03T04:13:38  <luke-jr> in this example
 94 2020-05-03T04:13:54  <luke-jr> so the HF'd nodes would always prefer the pre-HF chain
 95 2020-05-03T04:14:00  <luke-jr> so long as they see it
 96 2020-05-03T04:14:07  *** promag has quit IRC
 97 2020-05-03T04:14:17  <luke-jr> and it's more work ofc
 98 2020-05-03T04:14:30  <sipa> as long as no such HF is defined, there is no need to accomodate ot
 99 2020-05-03T04:15:15  <sipa> right now, seeing a peer give you a block with invalid PoW is a sign that peer is, from your perspective, completely broken
100 2020-05-03T04:15:38  <luke-jr> I'm not suggesting accomidation, just not going out of the way to disconnect it..
101 2020-05-03T04:16:04  <luke-jr> outgoing connections, sure, since those are providing services to us primarily
102 2020-05-03T04:16:12  <luke-jr> but inbound connections are primarily for the sake of the other node
103 2020-05-03T04:44:04  <sipa> that's reasonable
104 2020-05-03T04:58:40  *** surja795_ has quit IRC
105 2020-05-03T04:58:59  *** surja795 has joined #bitcoin-core-dev
106 2020-05-03T05:04:27  *** surja795 has quit IRC
107 2020-05-03T05:31:50  *** AaronvanW has joined #bitcoin-core-dev
108 2020-05-03T05:50:59  *** sonofhan has joined #bitcoin-core-dev
109 2020-05-03T05:52:07  *** sonofhan has quit IRC
110 2020-05-03T06:00:01  *** keyboardsurfer has quit IRC
111 2020-05-03T06:04:02  *** AaronvanW has quit IRC
112 2020-05-03T06:05:15  *** whythat has joined #bitcoin-core-dev
113 2020-05-03T06:09:23  *** whythat has quit IRC
114 2020-05-03T06:21:37  *** ski1 has joined #bitcoin-core-dev
115 2020-05-03T07:15:57  *** AaronvanW has joined #bitcoin-core-dev
116 2020-05-03T07:46:40  *** masteringbtc has joined #bitcoin-core-dev
117 2020-05-03T08:19:35  *** AaronvanW has quit IRC
118 2020-05-03T08:36:08  *** brakmic has joined #bitcoin-core-dev
119 2020-05-03T08:37:57  *** brakmic_ has joined #bitcoin-core-dev
120 2020-05-03T08:39:08  *** brakmic__ has joined #bitcoin-core-dev
121 2020-05-03T08:40:44  *** brakmic has quit IRC
122 2020-05-03T08:42:52  *** brakmic_ has quit IRC
123 2020-05-03T09:00:02  *** ski1 has quit IRC
124 2020-05-03T09:03:52  *** promag has joined #bitcoin-core-dev
125 2020-05-03T09:08:35  *** proofofkeags has joined #bitcoin-core-dev
126 2020-05-03T09:10:11  *** marcoagner has joined #bitcoin-core-dev
127 2020-05-03T09:13:14  *** proofofkeags has quit IRC
128 2020-05-03T09:21:00  *** afb has joined #bitcoin-core-dev
129 2020-05-03T09:35:51  *** surja795 has joined #bitcoin-core-dev
130 2020-05-03T09:39:59  *** surja795 has quit IRC
131 2020-05-03T09:47:52  *** masteringbtc has quit IRC
132 2020-05-03T09:49:32  *** AaronvanW has joined #bitcoin-core-dev
133 2020-05-03T09:56:56  *** AaronvanW has quit IRC
134 2020-05-03T10:09:21  *** AaronvanW has joined #bitcoin-core-dev
135 2020-05-03T10:13:29  *** promag has quit IRC
136 2020-05-03T10:29:46  *** emilengler has joined #bitcoin-core-dev
137 2020-05-03T10:41:34  *** vasild_ has joined #bitcoin-core-dev
138 2020-05-03T10:42:10  *** dmkathayat has quit IRC
139 2020-05-03T10:44:43  *** vasild has quit IRC
140 2020-05-03T10:44:44  *** vasild_ is now known as vasild
141 2020-05-03T10:45:44  *** Dean_Guss has quit IRC
142 2020-05-03T10:45:48  *** DeanWeen has joined #bitcoin-core-dev
143 2020-05-03T11:02:34  *** surja795 has joined #bitcoin-core-dev
144 2020-05-03T11:04:26  *** mdunnio has joined #bitcoin-core-dev
145 2020-05-03T11:07:43  *** surja795 has quit IRC
146 2020-05-03T11:08:59  *** mdunnio has quit IRC
147 2020-05-03T11:16:28  *** Victor_sueca is now known as Victorsueca
148 2020-05-03T11:18:03  *** Dean_Guss has joined #bitcoin-core-dev
149 2020-05-03T11:19:23  *** DeanWeen has quit IRC
150 2020-05-03T11:52:32  *** whythat has joined #bitcoin-core-dev
151 2020-05-03T12:00:02  *** afb has quit IRC
152 2020-05-03T12:04:21  *** jonatack has quit IRC
153 2020-05-03T12:21:56  *** Nimda3 has joined #bitcoin-core-dev
154 2020-05-03T12:30:02  *** Nimda3 has quit IRC
155 2020-05-03T12:36:05  *** mol has joined #bitcoin-core-dev
156 2020-05-03T12:38:38  *** molz_ has quit IRC
157 2020-05-03T12:43:11  *** surja795 has joined #bitcoin-core-dev
158 2020-05-03T12:49:03  *** mol has quit IRC
159 2020-05-03T12:52:35  *** Nebraskka has quit IRC
160 2020-05-03T12:55:55  *** gorthx has joined #bitcoin-core-dev
161 2020-05-03T12:57:16  <yevaud> luke-jr: objectively, providing a connection to someone incoming who you know is on a different chain is a denial of service attack against them.
162 2020-05-03T12:59:21  *** Highway61 has joined #bitcoin-core-dev
163 2020-05-03T13:00:25  *** bitcoin-git has joined #bitcoin-core-dev
164 2020-05-03T13:00:26  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/68ef9523d1bc...ddc0a600b38a
165 2020-05-03T13:00:26  <bitcoin-git> bitcoin/master 2742c34 Harris: test: add factor option to adjust test timeouts
166 2020-05-03T13:00:27  <bitcoin-git> bitcoin/master ddc0a60 MarcoFalke: Merge #18617: test: add factor option to adjust test timeouts
167 2020-05-03T13:00:29  *** bitcoin-git has left #bitcoin-core-dev
168 2020-05-03T13:00:51  *** bitcoin-git has joined #bitcoin-core-dev
169 2020-05-03T13:00:51  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18617: test: add factor option to adjust test timeouts (master...test-timeouts-with-factor) https://github.com/bitcoin/bitcoin/pull/18617
170 2020-05-03T13:00:52  *** bitcoin-git has left #bitcoin-core-dev
171 2020-05-03T13:11:19  *** jonatack has joined #bitcoin-core-dev
172 2020-05-03T13:14:12  *** wullon5 has quit IRC
173 2020-05-03T13:17:11  *** masteringbtc has joined #bitcoin-core-dev
174 2020-05-03T13:18:22  *** sudeep_ has joined #bitcoin-core-dev
175 2020-05-03T13:18:56  *** amsudeep has quit IRC
176 2020-05-03T13:25:23  *** vasild has quit IRC
177 2020-05-03T13:31:23  *** whythat has quit IRC
178 2020-05-03T13:34:09  *** mol has joined #bitcoin-core-dev
179 2020-05-03T13:36:22  *** AnotherHaxker has joined #bitcoin-core-dev
180 2020-05-03T13:37:25  *** vasild has joined #bitcoin-core-dev
181 2020-05-03T13:39:16  *** whythat has joined #bitcoin-core-dev
182 2020-05-03T13:41:20  *** AnotherHaxker has quit IRC
183 2020-05-03T13:42:43  *** vasild has quit IRC
184 2020-05-03T13:44:23  *** whythat has quit IRC
185 2020-05-03T13:50:05  *** masteringbtc has quit IRC
186 2020-05-03T13:56:53  *** mol_ has joined #bitcoin-core-dev
187 2020-05-03T13:59:38  *** mol has quit IRC
188 2020-05-03T14:03:45  *** belcher has joined #bitcoin-core-dev
189 2020-05-03T14:06:23  *** jb55 has quit IRC
190 2020-05-03T14:09:51  *** vasild has joined #bitcoin-core-dev
191 2020-05-03T14:12:48  *** davec has quit IRC
192 2020-05-03T14:13:25  *** davec has joined #bitcoin-core-dev
193 2020-05-03T14:15:48  <luke-jr> yevaud: they're not on another chain in this scenario; it's *providing* a service, not denying one
194 2020-05-03T14:18:49  *** whythat has joined #bitcoin-core-dev
195 2020-05-03T14:19:39  *** bitcoin-git has joined #bitcoin-core-dev
196 2020-05-03T14:19:39  <bitcoin-git> [bitcoin] vasild opened pull request #18857: build: avoid repetitions when enabling warnings in configure.ac (master...avoid_repetitions_in_configure.ac) https://github.com/bitcoin/bitcoin/pull/18857
197 2020-05-03T14:19:50  *** bitcoin-git has left #bitcoin-core-dev
198 2020-05-03T14:20:47  *** jb55 has joined #bitcoin-core-dev
199 2020-05-03T14:23:23  *** whythat has quit IRC
200 2020-05-03T14:28:57  *** whythat has joined #bitcoin-core-dev
201 2020-05-03T14:32:12  *** bitcoin-git has joined #bitcoin-core-dev
202 2020-05-03T14:32:13  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ddc0a600b38a...cce034b02800
203 2020-05-03T14:32:13  <bitcoin-git> bitcoin/master fa8614a MarcoFalke: test: Fix intermittent p2p_segwit issue
204 2020-05-03T14:32:14  <bitcoin-git> bitcoin/master fab7ee3 MarcoFalke: test: Fix p2p_leak intermittent issue
205 2020-05-03T14:32:14  <bitcoin-git> bitcoin/master cce034b MarcoFalke: Merge #18839: test: Fix intermittent issues
206 2020-05-03T14:32:16  *** bitcoin-git has left #bitcoin-core-dev
207 2020-05-03T14:32:32  *** bitcoin-git has joined #bitcoin-core-dev
208 2020-05-03T14:32:32  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18839: test: Fix intermittent issues (master...2004-qaSegwitNoIntermittentFail) https://github.com/bitcoin/bitcoin/pull/18839
209 2020-05-03T14:32:33  *** bitcoin-git has left #bitcoin-core-dev
210 2020-05-03T14:33:23  *** whythat has quit IRC
211 2020-05-03T14:36:45  *** bitcoin-git has joined #bitcoin-core-dev
212 2020-05-03T14:36:45  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cce034b02800...2e6a16b968a9
213 2020-05-03T14:36:46  <bitcoin-git> bitcoin/master 489ebfd Andrew Chow: tests: feature_backwards_compatibility.py test downgrade after upgrade
214 2020-05-03T14:36:47  <bitcoin-git> bitcoin/master 2e6a16b MarcoFalke: Merge #18855: tests: feature_backwards_compatibility.py test downgrade aft...
215 2020-05-03T14:36:48  *** bitcoin-git has left #bitcoin-core-dev
216 2020-05-03T14:37:05  *** bitcoin-git has joined #bitcoin-core-dev
217 2020-05-03T14:37:05  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18855: tests: feature_backwards_compatibility.py test downgrade after upgrade (master...test-backcompat-updowngrade) https://github.com/bitcoin/bitcoin/pull/18855
218 2020-05-03T14:37:06  *** bitcoin-git has left #bitcoin-core-dev
219 2020-05-03T14:42:32  *** mol has joined #bitcoin-core-dev
220 2020-05-03T14:43:34  *** mol_ has quit IRC
221 2020-05-03T14:55:15  *** whythat has joined #bitcoin-core-dev
222 2020-05-03T15:00:01  *** gorthx has quit IRC
223 2020-05-03T15:00:02  *** sdaftuar has quit IRC
224 2020-05-03T15:00:24  *** sdaftuar has joined #bitcoin-core-dev
225 2020-05-03T15:08:41  *** Guyver2 has joined #bitcoin-core-dev
226 2020-05-03T15:11:04  *** whythat has quit IRC
227 2020-05-03T15:20:13  *** jedi1 has joined #bitcoin-core-dev
228 2020-05-03T15:20:33  <elichai2> jonasschnelli: Hi, I'm trying to review #18242, and I don't get something, it looks like you use AAD a lot in relation with chacha(ie encrypting the AAD), why is that? traditionally AAD is Additional Authenticated Data (meaning not encrypted) and also `CHACHA20_POLY1305_AEAD_AAD_LEN = 3` is that because the AAD is always the length which is capped at 24bits?
229 2020-05-03T15:20:37  <gribble> https://github.com/bitcoin/bitcoin/issues/18242 | Add BIP324 encrypted p2p transport de-/serializer (only used in tests) by jonasschnelli · Pull Request #18242 · bitcoin/bitcoin · GitHub
230 2020-05-03T15:24:18  *** promag has joined #bitcoin-core-dev
231 2020-05-03T15:31:08  *** brakmic__ has quit IRC
232 2020-05-03T15:31:26  *** brakmic has joined #bitcoin-core-dev
233 2020-05-03T15:31:48  *** AaronvanW has quit IRC
234 2020-05-03T15:39:23  *** vasild has quit IRC
235 2020-05-03T15:41:08  <elichai2> I read the BIP again, and maybe I understand it now. you create 2 instances of chacha, `chacha_K1` and `chacha_K2` you encrypt the length of the data with `chacha_K1` and the data with chacha_K2`, but you use the encrypted `chacha_K1` length as the AAD of `chacha_K2`+Poly1305?
236 2020-05-03T15:41:35  <elichai2> * I read the BIP again, and maybe I understand it now. you create 2 instances of chacha, `chacha_K1` and `chacha_K2` you encrypt the length of the data with `chacha_K1` and the data with `chacha_K2`, but you use the encrypted `chacha_K1` length as the AAD of `chacha_K2`+Poly1305?
237 2020-05-03T15:45:55  *** promag has quit IRC
238 2020-05-03T15:46:00  *** whythat has joined #bitcoin-core-dev
239 2020-05-03T15:48:51  *** AaronvanW has joined #bitcoin-core-dev
240 2020-05-03T15:49:59  *** mol has quit IRC
241 2020-05-03T15:51:04  *** whythat has quit IRC
242 2020-05-03T15:52:59  *** mol has joined #bitcoin-core-dev
243 2020-05-03T16:21:20  *** whythat has joined #bitcoin-core-dev
244 2020-05-03T16:25:43  *** whythat has quit IRC
245 2020-05-03T16:28:42  *** promag has joined #bitcoin-core-dev
246 2020-05-03T16:49:02  <jonasschnelli> elichai2: hi
247 2020-05-03T16:49:29  <jonasschnelli> the AD is encrypted to keep the package length confidential
248 2020-05-03T16:49:45  <jonasschnelli> it's based on the openssh chacha20poly1305 protocol
249 2020-05-03T16:49:52  <jonasschnelli> https://github.com/openssh/openssh-portable/blob/master/PROTOCOL.chacha20poly1305
250 2020-05-03T16:50:12  <jonasschnelli> and yes the AAD length is always 3 bytes.
251 2020-05-03T16:50:23  <jonasschnelli> 23bits length plus 1 bit rekey flag
252 2020-05-03T16:51:57  <jonasschnelli> with encrypted package length, it makes the stream pseudo-random... and it would allow to pad random data (to obfuscate size-based package detection, which is not in the scope of the BIP though)
253 2020-05-03T16:56:19  *** whythat has joined #bitcoin-core-dev
254 2020-05-03T16:57:22  *** promag has quit IRC
255 2020-05-03T16:59:47  <elichai2> oh, openssh does this whole encrypt the length separately?
256 2020-05-03T17:00:34  <elichai2> But do we really gain anything by encrypting the length? it will probably be really easy to see anyway
257 2020-05-03T17:03:23  *** whythat has quit IRC
258 2020-05-03T17:03:46  <elichai2> I haven't realized this is almost 100% openSSH protocol, I thought only their impl was used not the protocol itself, thanks!
259 2020-05-03T17:06:52  *** promag has joined #bitcoin-core-dev
260 2020-05-03T17:18:45  <jonasschnelli> elichai2: expect the reusing of the AAD keystream and the 3byte length, it's very much then openssh version
261 2020-05-03T17:18:51  <jonasschnelli> *except
262 2020-05-03T17:19:14  <elichai2> you mean limiting the length to constant size 3 bytes?
263 2020-05-03T17:19:32  <jonasschnelli> that and mainly not throwing a way 60 bytes per AAD chacha round
264 2020-05-03T17:30:43  *** whythat has joined #bitcoin-core-dev
265 2020-05-03T17:34:19  *** justanotheruser has quit IRC
266 2020-05-03T17:35:03  *** whythat has quit IRC
267 2020-05-03T17:35:20  *** davterra has quit IRC
268 2020-05-03T17:41:13  *** emilengler has quit IRC
269 2020-05-03T17:49:31  *** justanotheruser has joined #bitcoin-core-dev
270 2020-05-03T18:00:02  *** jedi1 has quit IRC
271 2020-05-03T18:20:55  *** bitcoin-git has joined #bitcoin-core-dev
272 2020-05-03T18:20:56  <bitcoin-git> [bitcoin] practicalswift opened pull request #18859: Remove CCoinsViewCache::GetValueIn(...) (master...GetValueIn) https://github.com/bitcoin/bitcoin/pull/18859
273 2020-05-03T18:20:57  *** bitcoin-git has left #bitcoin-core-dev
274 2020-05-03T18:21:10  *** paxed1 has joined #bitcoin-core-dev
275 2020-05-03T18:26:09  *** vasild has joined #bitcoin-core-dev
276 2020-05-03T18:28:25  *** kristapsk has joined #bitcoin-core-dev
277 2020-05-03T18:30:39  *** Talkless has joined #bitcoin-core-dev
278 2020-05-03T18:42:35  <vasild> sipa: wrt https://github.com/bitcoin/bitcoin/pull/18843#issuecomment-623158435 -- what would the current inline assembly do on a system that doesn't have that instruction? I guess it will cause SIGILL (illegal instruction) at runtime?
279 2020-05-03T18:43:28  <sipa> yeah
280 2020-05-03T18:43:53  <sipa> i would be very surprised that the compiler emits an rdrand instruction anywhere without invoking a corresponding intrinsic, though
281 2020-05-03T18:44:35  <sipa> but that's specific to rdrand... e.g. the compiler will happily emit sse4 instructions for normal non-intrinsic c code when you compile with -msse4
282 2020-05-03T18:45:37  <sipa> so in general, you always want to move code that needs certain hardware assumptions to a separate module that gets compiled with those flags, and only invoke its functions after testing at runtime the feature is available
283 2020-05-03T18:46:59  <vasild> so there is room for improvement wrt the current inline assembly which assumes the instruction is present and if not would crash at runtime
284 2020-05-03T18:47:51  <vasild> although I guess the instruction is available on all platforms where bitcoin core is being run, otherwise somebody would have reported the crash
285 2020-05-03T18:48:42  <sipa> the current code is fine
286 2020-05-03T18:49:37  <sipa> InitHardwareRand checks whether the instruction is available at runtime, and GetRdRand is only called if it reports true in g_rdrand_supported
287 2020-05-03T18:49:59  <vasild> ah
288 2020-05-03T18:50:15  <vasild> I was looking at GetRdRand() in isolation
289 2020-05-03T18:50:42  <sipa> but if we'd compile the entirety of random.cpp with -mrdrnd, the compiler might also emit rdrand instructions in other functions (though i would be surprised if it did)
290 2020-05-03T18:51:13  <sipa> there are compiler-specific extensions that let you compile just one function with different hardware assumptions, but i'm not sure they exist for all compilers we support
291 2020-05-03T18:52:12  <vasild> "emit rdrand instructions in other functions" -- I don't get this, which other functions?
292 2020-05-03T18:52:44  <sipa> literally anything
293 2020-05-03T18:53:06  <vasild> if you have a function like `int f(int x) { return x * 2; }`?
294 2020-05-03T18:53:21  <sipa> if you compile a module with -mrdrnd it means the compiler assumes all code in that module will be run on hardware that supports the rdrand instruction
295 2020-05-03T18:53:34  <vasild> right
296 2020-05-03T18:54:11  <sipa> as i said, i wouldn't expect a compiler to do that for rdrand... it's a very specific purpose instruction that likely wouldn't be used unless you explicitly invoke it using an intrinsic
297 2020-05-03T18:54:34  <vasild> hmm, I see your point now
298 2020-05-03T18:54:36  <sipa> but for other target flags it absolutely will
299 2020-05-03T18:55:08  <sipa> this was the cause of #18456, btw
300 2020-05-03T18:55:10  <gribble> https://github.com/bitcoin/bitcoin/issues/18456 | bitcoin-qt/bitcoind crashes upon startup of crypto/sha256_shani. Illegal instruction · Issue #18456 · bitcoin/bitcoin · GitHub
301 2020-05-03T18:55:29  <sipa> sort of
302 2020-05-03T18:55:32  <vasild> and even if we do a runtime check before using it, that instruction may be sneaked somewhere else where the code does not do a runtime check
303 2020-05-03T18:55:40  <sipa> right
304 2020-05-03T18:56:44  <elichai2>  #18456 was even worse imo, because it generated sse instructions in the global initialization function
305 2020-05-03T18:56:46  <gribble> https://github.com/bitcoin/bitcoin/issues/18456 | bitcoin-qt/bitcoind crashes upon startup of crypto/sha256_shani. Illegal instruction · Issue #18456 · bitcoin/bitcoin · GitHub
306 2020-05-03T18:57:00  <sipa> elichai2: which arguably we told it it was fine to do
307 2020-05-03T18:57:41  <elichai2> right. but it's also a limitation of C and C++ that you can't always know what will be constantly evaluated and what will be in the global init
308 2020-05-03T18:57:55  <sipa> you totally can; constexpr keyword
309 2020-05-03T18:58:05  <sipa> only it doesn't work for vector registers :p
310 2020-05-03T18:58:24  <vasild> sipa: ok, thanks for the patience with explanations. I catch up slowly, but otoh tend to forget quickly...
311 2020-05-03T18:59:16  <sipa> np
312 2020-05-03T18:59:24  <elichai2> hehe yeah, we have constexpr now
313 2020-05-03T19:00:53  *** whythat has joined #bitcoin-core-dev
314 2020-05-03T19:11:31  *** vasild_ has joined #bitcoin-core-dev
315 2020-05-03T19:12:03  *** vasild has quit IRC
316 2020-05-03T19:12:04  *** vasild_ is now known as vasild
317 2020-05-03T19:15:13  *** Talkless has quit IRC
318 2020-05-03T19:25:02  *** surja795 has quit IRC
319 2020-05-03T19:40:23  *** whythat has quit IRC
320 2020-05-03T19:43:35  *** surja795 has joined #bitcoin-core-dev
321 2020-05-03T20:15:52  *** surja795 has quit IRC
322 2020-05-03T20:16:28  *** whythat has joined #bitcoin-core-dev
323 2020-05-03T20:21:38  *** promag has quit IRC
324 2020-05-03T20:49:35  *** bitcoin-git has joined #bitcoin-core-dev
325 2020-05-03T20:49:35  <bitcoin-git> [bitcoin] practicalswift closed pull request #18859: Remove CCoinsViewCache::GetValueIn(...) (master...GetValueIn) https://github.com/bitcoin/bitcoin/pull/18859
326 2020-05-03T20:49:36  *** bitcoin-git has left #bitcoin-core-dev
327 2020-05-03T20:50:00  *** surja795 has joined #bitcoin-core-dev
328 2020-05-03T20:53:51  *** Guyver2_ has joined #bitcoin-core-dev
329 2020-05-03T20:56:50  *** Guyver2 has quit IRC
330 2020-05-03T20:57:19  *** promag has joined #bitcoin-core-dev
331 2020-05-03T21:00:02  *** paxed1 has quit IRC
332 2020-05-03T21:12:31  *** surja795 has quit IRC
333 2020-05-03T21:17:01  *** bitcoin-git has joined #bitcoin-core-dev
334 2020-05-03T21:17:01  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18859: Remove CCoinsViewCache::GetValueIn(...) (master...GetValueIn) https://github.com/bitcoin/bitcoin/pull/18859
335 2020-05-03T21:17:02  *** bitcoin-git has left #bitcoin-core-dev
336 2020-05-03T21:22:16  *** DarTar has joined #bitcoin-core-dev
337 2020-05-03T21:33:23  *** whythat has quit IRC
338 2020-05-03T21:39:22  *** davterra has joined #bitcoin-core-dev
339 2020-05-03T22:09:59  *** whythat has joined #bitcoin-core-dev
340 2020-05-03T22:11:54  *** justanotheruser has quit IRC
341 2020-05-03T22:14:23  *** whythat has quit IRC
342 2020-05-03T22:28:21  *** justanotheruser has joined #bitcoin-core-dev
343 2020-05-03T22:28:39  *** Guyver2_ has quit IRC
344 2020-05-03T22:31:36  *** thomasb06 has joined #bitcoin-core-dev
345 2020-05-03T22:32:56  <thomasb06> Is it possible to participate writing python test scripts without installing 200Gb?
346 2020-05-03T22:36:43  <sipa> sure
347 2020-05-03T22:37:03  <sipa> you don't need to run mainnet bitcoind to run or develop tests
348 2020-05-03T22:41:14  <thomasb06> sipa: hey.
349 2020-05-03T22:42:40  <thomasb06> would you have the link on the website, until now I only found instructions to run a node?
350 2020-05-03T22:43:29  <sipa> i don't know what instructions you need
351 2020-05-03T22:43:41  <sipa> you can submit pull requests without running anything
352 2020-05-03T22:44:28  <thomasb06> well, that would be even better: my disk is 60Gb...
353 2020-05-03T22:44:49  <sipa> that's no problem
354 2020-05-03T22:44:54  <sipa> just don't run bitcoind
355 2020-05-03T22:45:04  *** surja795 has joined #bitcoin-core-dev
356 2020-05-03T22:45:11  <sipa> or you can run it in pruning mode which only needs a few GB
357 2020-05-03T22:45:24  <sipa> but neither is relevant for the python tests
358 2020-05-03T22:45:55  <thomasb06> cool... Promised I won't, even in pruning (I'm a student)
359 2020-05-03T22:46:45  <thomasb06> how can I find what tests are needed?
360 2020-05-03T22:47:59  <fanquake> thomasb06: If you want to start contributing, look at the "Good first issue" list: https://github.com/bitcoin/bitcoin/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
361 2020-05-03T22:50:17  *** surja795 has quit IRC
362 2020-05-03T22:50:51  <thomasb06> fanquake: thanks. Any advice?
363 2020-05-03T22:53:02  <fanquake> thomasb06: read https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md if you haven't already
364 2020-05-03T22:55:07  *** surja795_ has joined #bitcoin-core-dev
365 2020-05-03T22:56:56  <thomasb06> I just started. Is there an issue or a category among those flaged "Good
366 2020-05-03T22:56:56  <thomasb06> 	   first issue" I should privilege, or I can pick on randomly?
367 2020-05-03T22:59:22  *** surja795_ has quit IRC
368 2020-05-03T23:01:06  *** whythat has joined #bitcoin-core-dev
369 2020-05-03T23:05:23  *** whythat has quit IRC
370 2020-05-03T23:11:15  *** marcoagner has quit IRC
371 2020-05-03T23:19:23  *** Dean_Guss has quit IRC
372 2020-05-03T23:20:09  *** brakmic has quit IRC
373 2020-05-03T23:28:06  *** Nebraskka has joined #bitcoin-core-dev
374 2020-05-03T23:30:40  *** michaelfolkson has joined #bitcoin-core-dev
375 2020-05-03T23:37:04  *** sosthene has quit IRC
376 2020-05-03T23:38:54  *** Nebraskka has quit IRC
377 2020-05-03T23:53:05  *** Nebraskka has joined #bitcoin-core-dev
378 2020-05-03T23:58:51  *** thomasb06 has quit IRC