12020-05-04T00:00:01 *** DarTar has quit IRC
22020-05-04T00:00:08 *** jarthur has joined #bitcoin-core-dev
32020-05-04T00:00:27 *** jarthur has joined #bitcoin-core-dev
42020-05-04T00:01:31 *** jarthur has quit IRC
52020-05-04T00:01:41 *** jarthur has joined #bitcoin-core-dev
62020-05-04T00:07:39 *** jb55 has quit IRC
72020-05-04T00:22:05 *** b_b1 has joined #bitcoin-core-dev
82020-05-04T00:29:32 *** promag has quit IRC
92020-05-04T00:31:04 *** AaronvanW has quit IRC
102020-05-04T00:58:49 *** promag_ has quit IRC
112020-05-04T01:00:42 *** surja795 has joined #bitcoin-core-dev
122020-05-04T01:04:35 *** jb55 has joined #bitcoin-core-dev
132020-05-04T01:06:16 *** davterra has quit IRC
142020-05-04T01:10:12 *** davterra has joined #bitcoin-core-dev
152020-05-04T01:16:04 *** promag has joined #bitcoin-core-dev
162020-05-04T01:24:42 *** surja795 has quit IRC
172020-05-04T01:25:31 *** davterra has quit IRC
182020-05-04T01:29:02 *** sudeep_ has quit IRC
192020-05-04T01:29:50 *** Emcy has quit IRC
202020-05-04T01:34:31 *** promag has quit IRC
212020-05-04T01:42:46 *** Emcy has joined #bitcoin-core-dev
222020-05-04T01:55:11 *** mol_ has joined #bitcoin-core-dev
232020-05-04T01:58:17 *** mol has quit IRC
242020-05-04T02:09:25 *** proofofkeags has joined #bitcoin-core-dev
252020-05-04T02:29:10 *** surja795 has joined #bitcoin-core-dev
262020-05-04T02:56:54 *** surja795_ has joined #bitcoin-core-dev
272020-05-04T02:59:40 *** surja795 has quit IRC
282020-05-04T03:00:01 *** b_b1 has quit IRC
292020-05-04T03:01:14 *** surja795_ has quit IRC
302020-05-04T03:21:57 *** Wolfy87 has joined #bitcoin-core-dev
312020-05-04T03:50:58 *** proofofkeags has quit IRC
322020-05-04T03:56:33 *** commavir has quit IRC
332020-05-04T03:56:59 *** commavir has joined #bitcoin-core-dev
342020-05-04T03:58:55 *** jarthur has quit IRC
352020-05-04T04:07:09 *** proofofkeags has joined #bitcoin-core-dev
362020-05-04T04:11:49 *** proofofkeags has quit IRC
372020-05-04T04:19:53 *** vasild_ has joined #bitcoin-core-dev
382020-05-04T04:22:43 *** vasild has quit IRC
392020-05-04T04:22:44 *** vasild_ is now known as vasild
402020-05-04T04:39:22 *** proofofkeags has joined #bitcoin-core-dev
412020-05-04T04:47:15 *** proofofkeags has quit IRC
422020-05-04T04:53:32 *** TheHoliestRoger has quit IRC
432020-05-04T04:54:02 *** rh0nj has quit IRC
442020-05-04T04:54:22 *** TheHoliestRoger has joined #bitcoin-core-dev
452020-05-04T04:55:08 *** rh0nj has joined #bitcoin-core-dev
462020-05-04T05:04:16 *** whythat has joined #bitcoin-core-dev
472020-05-04T05:05:08 *** owowo has quit IRC
482020-05-04T05:05:44 *** owowo has joined #bitcoin-core-dev
492020-05-04T05:08:23 *** whythat has quit IRC
502020-05-04T05:10:04 *** mol has joined #bitcoin-core-dev
512020-05-04T05:12:36 *** mol_ has quit IRC
522020-05-04T05:15:00 *** proofofkeags has joined #bitcoin-core-dev
532020-05-04T05:15:55 *** Talkless has joined #bitcoin-core-dev
542020-05-04T05:20:59 *** ricky35 has joined #bitcoin-core-dev
552020-05-04T05:22:39 *** proofofkeags has quit IRC
562020-05-04T05:23:06 *** whythat has joined #bitcoin-core-dev
572020-05-04T05:30:23 *** whythat has quit IRC
582020-05-04T05:58:27 *** Homelander has joined #bitcoin-core-dev
592020-05-04T05:59:56 *** whythat has joined #bitcoin-core-dev
602020-05-04T06:00:02 *** Wolfy87 has quit IRC
612020-05-04T06:00:04 *** Dean_Guss has joined #bitcoin-core-dev
622020-05-04T06:04:23 *** whythat has quit IRC
632020-05-04T06:04:37 *** ricky35 has quit IRC
642020-05-04T06:21:56 *** hack_bot has joined #bitcoin-core-dev
652020-05-04T06:36:39 *** whythat has joined #bitcoin-core-dev
662020-05-04T06:41:03 *** whythat has quit IRC
672020-05-04T07:02:45 *** emilengler has joined #bitcoin-core-dev
682020-05-04T07:20:50 *** bitcoin-git has joined #bitcoin-core-dev
692020-05-04T07:20:50 <bitcoin-git> [bitcoin] sipa opened pull request #18861: Do not answer GETDATA for to-be-announced tx (master...202004_private_getdata) https://github.com/bitcoin/bitcoin/pull/18861
702020-05-04T07:20:51 *** bitcoin-git has left #bitcoin-core-dev
712020-05-04T07:24:08 *** spinza has quit IRC
722020-05-04T07:30:39 *** manantial has joined #bitcoin-core-dev
732020-05-04T07:38:06 *** spinza has joined #bitcoin-core-dev
742020-05-04T07:51:15 *** whythat has joined #bitcoin-core-dev
752020-05-04T08:01:52 *** Highway61 has quit IRC
762020-05-04T08:01:58 *** Highway62 has joined #bitcoin-core-dev
772020-05-04T08:04:18 *** Highway62 is now known as Highway61
782020-05-04T08:06:38 *** davterra has joined #bitcoin-core-dev
792020-05-04T08:14:24 *** davterra has quit IRC
802020-05-04T08:14:55 *** marcoagner has joined #bitcoin-core-dev
812020-05-04T08:15:26 *** davterra has joined #bitcoin-core-dev
822020-05-04T08:16:40 *** Guyver2 has joined #bitcoin-core-dev
832020-05-04T08:16:50 *** IGHOR has quit IRC
842020-05-04T08:18:19 *** IGHOR has joined #bitcoin-core-dev
852020-05-04T08:42:33 *** marcoagner has quit IRC
862020-05-04T08:44:05 *** bitcoin-git has joined #bitcoin-core-dev
872020-05-04T08:44:05 <bitcoin-git> [bitcoin] fanquake opened pull request #18862: Remove fdelt_chk back-compat code and sanity check (master...remove_fdelt_chk_back_compat) https://github.com/bitcoin/bitcoin/pull/18862
882020-05-04T08:44:06 *** bitcoin-git has left #bitcoin-core-dev
892020-05-04T08:44:36 *** brakmic has joined #bitcoin-core-dev
902020-05-04T08:47:09 *** Krellan_ has quit IRC
912020-05-04T08:48:03 *** whythat has quit IRC
922020-05-04T08:54:57 *** Kirk28Emmerich has joined #bitcoin-core-dev
932020-05-04T09:00:02 *** hack_bot has quit IRC
942020-05-04T09:01:35 *** promag has joined #bitcoin-core-dev
952020-05-04T09:05:17 *** emilengler has quit IRC
962020-05-04T09:07:17 *** emilengler has joined #bitcoin-core-dev
972020-05-04T09:10:07 *** Kirk28Emmerich has quit IRC
982020-05-04T09:10:32 *** ghostlaptop has joined #bitcoin-core-dev
992020-05-04T09:18:39 *** ghostlaptop has quit IRC
1002020-05-04T09:20:17 *** whythat has joined #bitcoin-core-dev
1012020-05-04T09:21:19 *** vancoder has joined #bitcoin-core-dev
1022020-05-04T09:33:33 *** AaronvanW has joined #bitcoin-core-dev
1032020-05-04T09:37:00 *** shigeya has quit IRC
1042020-05-04T09:38:35 *** shigeya has joined #bitcoin-core-dev
1052020-05-04T09:42:56 *** wullon5 has joined #bitcoin-core-dev
1062020-05-04T09:54:27 *** bitcoin-git has joined #bitcoin-core-dev
1072020-05-04T09:54:27 <bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2e6a16b968a9...afa577c323dc
1082020-05-04T09:54:28 <bitcoin-git> bitcoin/master f5a3a5b Miguel Herranz: gui: Add close window shortcut
1092020-05-04T09:54:28 <bitcoin-git> bitcoin/master afa577c Jonas Schnelli: Merge #15768: gui: Add close window shortcut
1102020-05-04T09:54:30 *** bitcoin-git has left #bitcoin-core-dev
1112020-05-04T09:55:52 *** jonatack has quit IRC
1122020-05-04T09:55:57 *** bitcoin-git has joined #bitcoin-core-dev
1132020-05-04T09:55:57 <bitcoin-git> [bitcoin] jonasschnelli merged pull request #15768: gui: Add close window shortcut (master...add_cmd_w_support_in_macos) https://github.com/bitcoin/bitcoin/pull/15768
1142020-05-04T09:56:00 *** bitcoin-git has left #bitcoin-core-dev
1152020-05-04T10:06:35 *** bitcoin-git has joined #bitcoin-core-dev
1162020-05-04T10:06:36 <bitcoin-git> [bitcoin] promag opened pull request #18863: refactor: Drop unused CScriptVisitor return type (master...2020-04-cscript-visitor) https://github.com/bitcoin/bitcoin/pull/18863
1172020-05-04T10:06:37 *** bitcoin-git has left #bitcoin-core-dev
1182020-05-04T10:07:20 *** jonatack has joined #bitcoin-core-dev
1192020-05-04T10:25:34 *** promag has quit IRC
1202020-05-04T10:27:20 *** surja795 has joined #bitcoin-core-dev
1212020-05-04T10:33:37 *** Homelander has quit IRC
1222020-05-04T10:34:57 *** surja795 has quit IRC
1232020-05-04T10:35:25 *** surja795 has joined #bitcoin-core-dev
1242020-05-04T10:37:06 *** surja795 has quit IRC
1252020-05-04T10:38:04 *** surja795 has joined #bitcoin-core-dev
1262020-05-04T10:39:58 <elichai2> Is practicalswift on IRC?
1272020-05-04T10:42:53 *** surja795 has quit IRC
1282020-05-04T10:44:05 <elichai2> I'm trying to figure out some fuzzing best practices, is it ok to reuse the same fuzzing input on multiple functions or should I "pull" more data for each function I call? (cc BlueMatt ) should I minimize the amount of fuzzing input I'm using or maximize it?
1292020-05-04T10:45:10 <jonasschnelli> elichai2: he is sometimes. But no bouncer I guess.
1302020-05-04T11:03:00 *** promag has joined #bitcoin-core-dev
1312020-05-04T11:03:49 *** promag has quit IRC
1322020-05-04T11:04:00 *** promag has joined #bitcoin-core-dev
1332020-05-04T11:07:32 *** ctrlbreak_MAD has joined #bitcoin-core-dev
1342020-05-04T11:08:20 *** surja795 has joined #bitcoin-core-dev
1352020-05-04T11:10:25 *** ctrlbreak has quit IRC
1362020-05-04T11:12:50 *** surja795 has quit IRC
1372020-05-04T11:18:24 *** DeanWeen has joined #bitcoin-core-dev
1382020-05-04T11:19:23 *** Dean_Guss has quit IRC
1392020-05-04T11:27:32 *** surja795 has joined #bitcoin-core-dev
1402020-05-04T11:29:52 *** surja795 has quit IRC
1412020-05-04T11:30:20 *** surja795 has joined #bitcoin-core-dev
1422020-05-04T11:34:34 *** surja795 has quit IRC
1432020-05-04T11:34:56 *** timothy has joined #bitcoin-core-dev
1442020-05-04T11:41:42 *** bitcoin-git has joined #bitcoin-core-dev
1452020-05-04T11:41:43 <bitcoin-git> [bitcoin] Sjors opened pull request #18864: Add v0.16.3 backwards compatibility test, bump v0.19.0.1 to v0.19.1 (master...2020/05/backwards_compat) https://github.com/bitcoin/bitcoin/pull/18864
1462020-05-04T11:41:44 *** bitcoin-git has left #bitcoin-core-dev
1472020-05-04T11:43:00 *** surja795 has joined #bitcoin-core-dev
1482020-05-04T11:45:05 *** per has quit IRC
1492020-05-04T11:45:19 *** per has joined #bitcoin-core-dev
1502020-05-04T11:45:48 *** jonatack has quit IRC
1512020-05-04T11:47:29 *** surja795 has quit IRC
1522020-05-04T11:48:49 *** jonatack has joined #bitcoin-core-dev
1532020-05-04T11:50:15 <elichai2> I'm looking here: https://github.com/bitcoin/bitcoin/blob/master/src/test/fuzz/netaddress.cpp#L27 and if I understand https://github.com/bitcoin/bitcoin/blob/master/src/test/fuzz/FuzzedDataProvider.h#L41 correctly then it might not always return 16 bytes
1542020-05-04T11:50:22 *** bitcoin-git has joined #bitcoin-core-dev
1552020-05-04T11:50:22 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/afa577c323dc...74a1152f2581
1562020-05-04T11:50:23 <bitcoin-git> bitcoin/master b56607a practicalswift: Remove CCoinsViewCache::GetValueIn(...)
1572020-05-04T11:50:23 <bitcoin-git> bitcoin/master 74a1152 MarcoFalke: Merge #18859: Remove CCoinsViewCache::GetValueIn(...)
1582020-05-04T11:50:25 *** bitcoin-git has left #bitcoin-core-dev
1592020-05-04T11:50:42 *** bitcoin-git has joined #bitcoin-core-dev
1602020-05-04T11:50:42 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18859: Remove CCoinsViewCache::GetValueIn(...) (master...GetValueIn) https://github.com/bitcoin/bitcoin/pull/18859
1612020-05-04T11:50:53 *** bitcoin-git has left #bitcoin-core-dev
1622020-05-04T11:58:43 *** surja795 has joined #bitcoin-core-dev
1632020-05-04T12:00:02 *** vancoder has quit IRC
1642020-05-04T12:01:20 *** bitcoin-git has joined #bitcoin-core-dev
1652020-05-04T12:01:20 <bitcoin-git> [bitcoin] promag opened pull request #18865: gui: Refactor WalletFrame to extend QStackView (master...2020-05-walletframe) https://github.com/bitcoin/bitcoin/pull/18865
1662020-05-04T12:01:21 *** bitcoin-git has left #bitcoin-core-dev
1672020-05-04T12:02:07 *** promag has quit IRC
1682020-05-04T12:06:07 *** surja795 has quit IRC
1692020-05-04T12:20:38 *** chmac has joined #bitcoin-core-dev
1702020-05-04T12:25:39 *** Deacydal has joined #bitcoin-core-dev
1712020-05-04T12:28:07 *** Deacyde has quit IRC
1722020-05-04T12:34:01 *** promag has joined #bitcoin-core-dev
1732020-05-04T12:35:03 *** DeanWeen has quit IRC
1742020-05-04T12:37:01 *** Deacyded has joined #bitcoin-core-dev
1752020-05-04T12:37:09 *** surja795 has joined #bitcoin-core-dev
1762020-05-04T12:38:23 *** promag has quit IRC
1772020-05-04T12:40:26 *** Deacydal has quit IRC
1782020-05-04T12:42:55 *** surja795 has quit IRC
1792020-05-04T12:51:46 *** mol has quit IRC
1802020-05-04T12:52:01 *** mol has joined #bitcoin-core-dev
1812020-05-04T12:57:00 *** bitcoin-git has joined #bitcoin-core-dev
1822020-05-04T12:57:01 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18866: test: Fix verack race to avoid intermittent test failures (master...2005-qaVerackRace) https://github.com/bitcoin/bitcoin/pull/18866
1832020-05-04T12:57:01 *** bitcoin-git has left #bitcoin-core-dev
1842020-05-04T13:00:16 *** Deacydal has joined #bitcoin-core-dev
1852020-05-04T13:03:04 *** surja795 has joined #bitcoin-core-dev
1862020-05-04T13:03:29 *** promag has joined #bitcoin-core-dev
1872020-05-04T13:03:30 *** drizztbsd has joined #bitcoin-core-dev
1882020-05-04T13:03:38 *** timothy has quit IRC
1892020-05-04T13:03:40 *** drizztbsd is now known as timothy
1902020-05-04T13:03:46 *** promag has quit IRC
1912020-05-04T13:04:02 *** promag has joined #bitcoin-core-dev
1922020-05-04T13:04:05 *** Deacyded has quit IRC
1932020-05-04T13:04:23 *** bitcoin-git has joined #bitcoin-core-dev
1942020-05-04T13:04:23 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/74a1152f2581...0a729b0e42fa
1952020-05-04T13:04:23 <bitcoin-git> bitcoin/master 38e49de practicalswift: tests: Add fuzzing harness for MessageSign, MessageVerify and other functi...
1962020-05-04T13:04:24 <bitcoin-git> bitcoin/master 0a729b0 MarcoFalke: Merge #18783: tests: Add fuzzing harness for MessageSign, MessageVerify an...
1972020-05-04T13:04:26 *** promag_ has joined #bitcoin-core-dev
1982020-05-04T13:04:31 *** bitcoin-git has left #bitcoin-core-dev
1992020-05-04T13:04:48 *** bitcoin-git has joined #bitcoin-core-dev
2002020-05-04T13:04:48 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18783: tests: Add fuzzing harness for MessageSign, MessageVerify and other functions in util/message.h (master...fuzzers-message) https://github.com/bitcoin/bitcoin/pull/18783
2012020-05-04T13:04:59 *** bitcoin-git has left #bitcoin-core-dev
2022020-05-04T13:06:50 *** bitcoin-git has joined #bitcoin-core-dev
2032020-05-04T13:06:50 <bitcoin-git> [bitcoin] practicalswift opened pull request #18867: tests: Add fuzzing harness for CCoinsViewCache (master...fuzzers-coins_view) https://github.com/bitcoin/bitcoin/pull/18867
2042020-05-04T13:06:51 *** bitcoin-git has left #bitcoin-core-dev
2052020-05-04T13:07:59 *** surja795 has quit IRC
2062020-05-04T13:09:44 *** promag_ has quit IRC
2072020-05-04T13:15:43 *** davterra has quit IRC
2082020-05-04T13:15:50 *** smolakala has joined #bitcoin-core-dev
2092020-05-04T13:16:36 *** davterra has joined #bitcoin-core-dev
2102020-05-04T13:18:41 <wumpus> so apparently I wasted my time with #18851 :/
2112020-05-04T13:18:45 <gribble> https://github.com/bitcoin/bitcoin/issues/18851 | refactor: Replace thread_local use with a mutex-protected map by laanwj · Pull Request #18851 · bitcoin/bitcoin · GitHub
2122020-05-04T13:23:14 *** Guest35617 has quit IRC
2132020-05-04T13:28:04 *** surja795 has joined #bitcoin-core-dev
2142020-05-04T13:30:18 *** Deacydal has quit IRC
2152020-05-04T13:32:57 *** surja795 has quit IRC
2162020-05-04T13:38:03 <willcl_ark> Wondering if #7601 ever got picked up by anyone after close?
2172020-05-04T13:38:06 <gribble> https://github.com/bitcoin/bitcoin/issues/7601 | [WIP] HTLC implementation in the wallet by ebfull · Pull Request #7601 · bitcoin/bitcoin · GitHub
2182020-05-04T13:43:13 <wumpus> I don't think so, feel free to pick it up
2192020-05-04T13:51:57 <willcl_ark> thanks wumpus
2202020-05-04T13:54:30 *** Deacyde has joined #bitcoin-core-dev
2212020-05-04T13:59:03 <promag> is there a way to know what variables could be made const?
2222020-05-04T14:03:58 *** AaronvanW has quit IRC
2232020-05-04T14:05:36 *** bitcoin-git has joined #bitcoin-core-dev
2242020-05-04T14:05:36 <bitcoin-git> [bitcoin] laanwj closed pull request #18851: refactor: Replace thread_local use with a mutex-protected map (master...2020_05_replace_threadlocal) https://github.com/bitcoin/bitcoin/pull/18851
2252020-05-04T14:05:38 *** bitcoin-git has left #bitcoin-core-dev
2262020-05-04T14:05:45 *** AaronvanW has joined #bitcoin-core-dev
2272020-05-04T14:06:51 *** Guyver2_ has joined #bitcoin-core-dev
2282020-05-04T14:07:21 *** bitcoin-git has joined #bitcoin-core-dev
2292020-05-04T14:07:21 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0a729b0e42fa...42fd5038197d
2302020-05-04T14:07:22 <bitcoin-git> bitcoin/master faec3dc MarcoFalke: init: Remove boost from ThreadImport
2312020-05-04T14:07:22 <bitcoin-git> bitcoin/master 42fd503 Wladimir J. van der Laan: Merge #18786: init: Remove boost from ThreadImport
2322020-05-04T14:07:24 *** bitcoin-git has left #bitcoin-core-dev
2332020-05-04T14:07:41 *** bitcoin-git has joined #bitcoin-core-dev
2342020-05-04T14:07:41 <bitcoin-git> [bitcoin] laanwj merged pull request #18786: init: Remove boost from ThreadImport (master...2004-noBoostInitThreadImport) https://github.com/bitcoin/bitcoin/pull/18786
2352020-05-04T14:07:42 *** bitcoin-git has left #bitcoin-core-dev
2362020-05-04T14:08:02 <wumpus> promag: try to make them const and see if it still compiles?
2372020-05-04T14:08:24 *** mdunnio has joined #bitcoin-core-dev
2382020-05-04T14:08:44 *** Guyver2 has quit IRC
2392020-05-04T14:08:55 <promag> wumpus: ok, see you next year :D
2402020-05-04T14:10:14 <wumpus> what are you trying to do in the first place? while writing the code you have an idea what could be const and what not I guess?
2412020-05-04T14:10:29 <promag> no compiler flag? no smartass tool? just curious
2422020-05-04T14:11:33 <promag> nothing in particular, lots of variables could be made const and that's a good practice no?
2432020-05-04T14:11:36 <wumpus> please don't make a "make everything const that can be const for const's sake" PR
2442020-05-04T14:11:50 <promag> wumpus: nope I promise
2452020-05-04T14:12:26 *** Highway61 has quit IRC
2462020-05-04T14:12:55 <promag> just came across https://dev.to/fenbf/please-declare-your-variables-as-const
2472020-05-04T14:14:37 *** promag_ has joined #bitcoin-core-dev
2482020-05-04T14:14:48 *** promag_ has quit IRC
2492020-05-04T14:19:13 *** proofofkeags has joined #bitcoin-core-dev
2502020-05-04T14:23:48 *** proofofkeags has quit IRC
2512020-05-04T14:26:53 *** Guyver2_ is now known as Guyver2
2522020-05-04T14:29:49 *** bitcoin-git has joined #bitcoin-core-dev
2532020-05-04T14:29:50 <bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/42fd5038197d...23c926d859c6
2542020-05-04T14:29:51 <bitcoin-git> bitcoin/master fae51a5 MarcoFalke: wallet: Avoid translating RPC errors when loading wallets
2552020-05-04T14:29:52 <bitcoin-git> bitcoin/master fae7776 MarcoFalke: wallet: Avoid translating RPC errors when creating txs
2562020-05-04T14:29:53 <bitcoin-git> bitcoin/master fa59cc1 MarcoFalke: wallet: Report full error message in wallettool
2572020-05-04T14:29:54 *** bitcoin-git has left #bitcoin-core-dev
2582020-05-04T14:30:10 *** bitcoin-git has joined #bitcoin-core-dev
2592020-05-04T14:30:11 <bitcoin-git> [bitcoin] laanwj merged pull request #18699: wallet: Avoid translating RPC errors (master...1908-walletErrorSegfault) https://github.com/bitcoin/bitcoin/pull/18699
2602020-05-04T14:30:12 *** bitcoin-git has left #bitcoin-core-dev
2612020-05-04T14:31:34 *** bitcoin-git has joined #bitcoin-core-dev
2622020-05-04T14:31:35 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/23c926d859c6...b549cb1bd2cc
2632020-05-04T14:31:36 <bitcoin-git> bitcoin/master f852030 Vasil Dimov: lockedpool: avoid sensitive data in core files (FreeBSD)
2642020-05-04T14:31:36 <bitcoin-git> bitcoin/master b549cb1 Wladimir J. van der Laan: Merge #18443: lockedpool: avoid sensitive data in core files (FreeBSD)
2652020-05-04T14:31:39 *** bitcoin-git has left #bitcoin-core-dev
2662020-05-04T14:32:04 *** bitcoin-git has joined #bitcoin-core-dev
2672020-05-04T14:32:05 <bitcoin-git> [bitcoin] laanwj merged pull request #18443: lockedpool: avoid sensitive data in core files (FreeBSD) (master...madvise) https://github.com/bitcoin/bitcoin/pull/18443
2682020-05-04T14:32:06 *** bitcoin-git has left #bitcoin-core-dev
2692020-05-04T14:32:24 <elichai2> promag: wumpus adding `const` and checking if compiling won't work if anyone is casting const away anywhere
2702020-05-04T14:32:52 <elichai2> Look at the output and try removing the const qualifier from `a` https://godbolt.org/z/VZXfVJ
2712020-05-04T14:32:55 <promag> elichai2: true
2722020-05-04T14:53:30 <wumpus> elichai2: correct, const is always advisory in c++ anyway
2732020-05-04T14:53:53 <elichai2> wumpus: you mean as function input, not variable declaration, right?
2742020-05-04T14:54:15 <elichai2> (or as pointer qualifier or however you want to call that hehe)
2752020-05-04T14:54:20 <wumpus> I mean in general, you can always cast it away (of course it's a bad idea)
2762020-05-04T15:00:02 *** chmac has quit IRC
2772020-05-04T15:00:44 *** proofofkeags has joined #bitcoin-core-dev
2782020-05-04T15:07:42 *** cryptapus has quit IRC
2792020-05-04T15:08:40 *** bitcoin-git has joined #bitcoin-core-dev
2802020-05-04T15:08:40 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18863: refactor: Drop unused CScriptVisitor return type (master...2020-04-cscript-visitor) https://github.com/bitcoin/bitcoin/pull/18863
2812020-05-04T15:08:41 *** bitcoin-git has left #bitcoin-core-dev
2822020-05-04T15:09:00 *** bitcoin-git has joined #bitcoin-core-dev
2832020-05-04T15:09:00 <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18863: refactor: Drop unused CScriptVisitor return type (master...2020-04-cscript-visitor) https://github.com/bitcoin/bitcoin/pull/18863
2842020-05-04T15:09:01 *** bitcoin-git has left #bitcoin-core-dev
2852020-05-04T15:10:07 *** cryptapus has joined #bitcoin-core-dev
2862020-05-04T15:10:07 *** cryptapus has quit IRC
2872020-05-04T15:10:07 *** cryptapus has joined #bitcoin-core-dev
2882020-05-04T15:21:24 *** whythat has quit IRC
2892020-05-04T15:22:16 *** Shabbypenguin has joined #bitcoin-core-dev
2902020-05-04T15:23:03 *** proofofkeags has quit IRC
2912020-05-04T15:27:14 *** surja795 has joined #bitcoin-core-dev
2922020-05-04T15:32:01 *** surja795 has quit IRC
2932020-05-04T15:32:18 *** whythat has joined #bitcoin-core-dev
2942020-05-04T15:34:34 *** mol has quit IRC
2952020-05-04T15:34:49 *** justanotheruser has quit IRC
2962020-05-04T15:35:17 <luke-jr> wumpus: I'm not sure you are guaranteed that?
2972020-05-04T15:35:29 <luke-jr> IIRC string literals at least can't just be cast away constness
2982020-05-04T15:40:57 <BlueMatt> elichai2: its mostly a chance-of-crash per input bit thing - the fuzzer can only try X input bits per time, so if you get more of a chance of a crash from being less verbose, do it (of course it also depends on the type of input - i have a bunch of fuzz targets that don't do well with fuzzer's traditional input bit permutations that focus on arithmetic etc)
2992020-05-04T15:49:59 *** justanotheruser has joined #bitcoin-core-dev
3002020-05-04T15:51:39 *** proofofkeags has joined #bitcoin-core-dev
3012020-05-04T15:56:19 *** proofofkeags has quit IRC
3022020-05-04T15:56:35 *** proofofkeags has joined #bitcoin-core-dev
3032020-05-04T15:57:48 *** enasigurd has joined #bitcoin-core-dev
3042020-05-04T16:08:09 *** surja795 has joined #bitcoin-core-dev
3052020-05-04T16:12:50 *** surja795 has quit IRC
3062020-05-04T16:17:03 *** whythat has quit IRC
3072020-05-04T16:19:57 *** vasild_ has joined #bitcoin-core-dev
3082020-05-04T16:22:30 *** whythat has joined #bitcoin-core-dev
3092020-05-04T16:23:23 *** vasild has quit IRC
3102020-05-04T16:23:26 *** vasild_ is now known as vasild
3112020-05-04T16:24:53 *** Highway61 has joined #bitcoin-core-dev
3122020-05-04T16:36:38 *** Sentineo has quit IRC
3132020-05-04T16:43:12 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3142020-05-04T16:45:29 *** brakmic has quit IRC
3152020-05-04T16:45:43 *** brakmic has joined #bitcoin-core-dev
3162020-05-04T16:46:12 *** brakmic has quit IRC
3172020-05-04T16:46:17 *** Sentineo has joined #bitcoin-core-dev
3182020-05-04T16:46:27 *** Highway61 has quit IRC
3192020-05-04T16:46:42 *** brakmic has joined #bitcoin-core-dev
3202020-05-04T16:53:52 *** rockhouse has quit IRC
3212020-05-04T16:53:52 *** victorSN has quit IRC
3222020-05-04T16:59:25 *** rockhouse has joined #bitcoin-core-dev
3232020-05-04T16:59:46 *** victorSN has joined #bitcoin-core-dev
3242020-05-04T17:05:37 *** brakmic_ has joined #bitcoin-core-dev
3252020-05-04T17:07:07 *** jarthur has joined #bitcoin-core-dev
3262020-05-04T17:08:54 *** brakmic has quit IRC
3272020-05-04T17:17:08 *** lightlike has joined #bitcoin-core-dev
3282020-05-04T17:18:23 *** whythat has quit IRC
3292020-05-04T17:26:09 *** whythat has joined #bitcoin-core-dev
3302020-05-04T17:28:48 *** manantial has quit IRC
3312020-05-04T17:29:44 *** brakmic has joined #bitcoin-core-dev
3322020-05-04T17:32:03 *** whythat has quit IRC
3332020-05-04T17:33:23 *** brakmic_ has quit IRC
3342020-05-04T17:33:49 *** surja795 has joined #bitcoin-core-dev
3352020-05-04T17:35:20 *** whythat has joined #bitcoin-core-dev
3362020-05-04T17:38:10 *** surja795 has quit IRC
3372020-05-04T17:46:40 <wumpus> did we change anything to linking of the tests recently? re #18869
3382020-05-04T17:46:42 <gribble> https://github.com/bitcoin/bitcoin/issues/18869 | Build of tests fails on FreeBSD · Issue #18869 · bitcoin/bitcoin · GitHub
3392020-05-04T17:46:54 *** mol has joined #bitcoin-core-dev
3402020-05-04T17:50:37 <wumpus> luke-jr: my point wasn't that it would be safe to do so
3412020-05-04T17:52:21 <sipa> wumpus: const is not always advisory in C++
3422020-05-04T17:52:37 <wumpus> okay
3432020-05-04T17:52:44 <sipa> if you have a const-declared variable (not just a const reference/pointer to it), then modifying it is UB
3442020-05-04T17:53:12 <wumpus> I wasn't planning to do anything like that
3452020-05-04T17:53:34 <sipa> i believe the spec says that modifying through a const pointer/reference is legal only if you know something else in the program holds a non-const reference to the variable
3462020-05-04T17:54:03 <wumpus> I'm aware the compiler can make all kinds of optimizations based on const
3472020-05-04T17:54:17 <sipa> usually it can't, actually
3482020-05-04T17:54:28 <luke-jr> sipa: interesting, so a compiler that tagged const references and aborted if you tried to remove the constness, would be non-compliant?
3492020-05-04T17:55:22 <sipa> luke-jr: removing the constness is always fine; modifying through a const-reference casted to non-const is UB if no other non-const references exist
3502020-05-04T17:56:07 <sipa> but say you have a struct X { const int c; X(int v) : c(v) {} };... then modifying c would always be UB
3512020-05-04T17:56:57 <wumpus> so does anyone have an idea about the link issue?
3522020-05-04T17:57:04 <sipa> sorry, no :)
3532020-05-04T18:00:02 *** Shabbypenguin has quit IRC
3542020-05-04T18:01:18 <wumpus> bisect time then :)
3552020-05-04T18:06:03 *** whythat has quit IRC
3562020-05-04T18:15:38 *** shigeya has quit IRC
3572020-05-04T18:21:45 *** torax has joined #bitcoin-core-dev
3582020-05-04T18:23:14 *** brakmic_ has joined #bitcoin-core-dev
3592020-05-04T18:25:54 *** brakmic has quit IRC
3602020-05-04T18:29:09 *** Highway61 has joined #bitcoin-core-dev
3612020-05-04T18:31:00 *** bitcoin-git has joined #bitcoin-core-dev
3622020-05-04T18:31:01 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18730: wallet: Remove -upgradewallet from dummywallet (master...2004-walletNoUpgrade) https://github.com/bitcoin/bitcoin/pull/18730
3632020-05-04T18:31:02 *** bitcoin-git has left #bitcoin-core-dev
3642020-05-04T18:48:18 *** Talkless has quit IRC
3652020-05-04T18:48:54 *** surja795 has joined #bitcoin-core-dev
3662020-05-04T18:49:07 *** shigeya has joined #bitcoin-core-dev
3672020-05-04T18:53:17 *** surja795 has quit IRC
3682020-05-04T19:04:29 *** proofofk_ has joined #bitcoin-core-dev
3692020-05-04T19:08:21 *** proofofkeags has quit IRC
3702020-05-04T19:14:02 *** emilengler has quit IRC
3712020-05-04T19:15:07 *** bitcoin-git has joined #bitcoin-core-dev
3722020-05-04T19:15:07 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18853: wallet: Fix typo in assert that is compile-time true (master...2004-walletAssertAlwaysTrue) https://github.com/bitcoin/bitcoin/pull/18853
3732020-05-04T19:15:08 *** bitcoin-git has left #bitcoin-core-dev
3742020-05-04T19:15:40 *** bitcoin-git has joined #bitcoin-core-dev
3752020-05-04T19:15:40 <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18853: wallet: Fix typo in assert that is compile-time true (master...2004-walletAssertAlwaysTrue) https://github.com/bitcoin/bitcoin/pull/18853
3762020-05-04T19:15:41 *** bitcoin-git has left #bitcoin-core-dev
3772020-05-04T19:18:09 *** jarthur_ has joined #bitcoin-core-dev
3782020-05-04T19:20:43 *** jarthur has quit IRC
3792020-05-04T19:35:37 <provoostenator> Github lets you mark an exiting pull request as draft now.
3802020-05-04T19:39:45 <jb55> ohhh awesome that was super annoying
3812020-05-04T19:45:46 *** brakmic_ has quit IRC
3822020-05-04T19:46:08 *** brakmic has joined #bitcoin-core-dev
3832020-05-04T19:57:53 *** go11111111111 has joined #bitcoin-core-dev
3842020-05-04T20:00:24 *** go121212 has quit IRC
3852020-05-04T20:07:09 *** jonatack has quit IRC
3862020-05-04T20:09:08 *** jonatack has joined #bitcoin-core-dev
3872020-05-04T20:12:48 *** jarthur_ is now known as jarthur
3882020-05-04T20:20:56 *** surja795 has joined #bitcoin-core-dev
3892020-05-04T20:28:45 *** justanotheruser has quit IRC
3902020-05-04T20:29:07 *** justanotheruser has joined #bitcoin-core-dev
3912020-05-04T20:29:35 *** IPGlider has joined #bitcoin-core-dev
3922020-05-04T20:36:30 *** dr-orlovsky has joined #bitcoin-core-dev
3932020-05-04T20:36:42 <jeremyrubin> luke-jr: you may want to chime in on https://github.com/bitcoin/bitcoin/issues/12248#issuecomment-622270497 if you're looking at RPC whitelist/permissions for core
3942020-05-04T20:37:14 <jeremyrubin> I think it looks like maybe there is disagreement on utility in core but maybe could be something to build for knots and then roll into core if it works well
3952020-05-04T20:37:14 *** bitcoin-git has joined #bitcoin-core-dev
3962020-05-04T20:37:14 <bitcoin-git> [bitcoin] achow101 opened pull request #18870: build: Allow BDB between 4.7 and 5.3 without --with-incompatible-bdb (master...allow-other-bdb) https://github.com/bitcoin/bitcoin/pull/18870
3972020-05-04T20:37:15 *** bitcoin-git has left #bitcoin-core-dev
3982020-05-04T20:38:18 *** dr-orlovsky has quit IRC
3992020-05-04T20:55:30 *** proofofk_ has quit IRC
4002020-05-04T20:55:46 *** proofofkeags has joined #bitcoin-core-dev
4012020-05-04T20:57:23 <luke-jr> jeremyrubin: I tend to agree it sounds like overkill - but if you want to maintain it for Knots, I guess there's no hurt experimenting
4022020-05-04T21:00:01 *** torax has quit IRC
4032020-05-04T21:02:11 *** surja795_ has joined #bitcoin-core-dev
4042020-05-04T21:04:18 *** surja795_ has joined #bitcoin-core-dev
4052020-05-04T21:06:12 *** surja795 has quit IRC
4062020-05-04T21:07:56 *** surja795 has joined #bitcoin-core-dev
4072020-05-04T21:08:05 *** surja795_ has quit IRC
4082020-05-04T21:12:35 *** surja795 has quit IRC
4092020-05-04T21:17:41 *** jarthur has quit IRC
4102020-05-04T21:18:08 *** jarthur has joined #bitcoin-core-dev
4112020-05-04T21:22:03 *** fredy1 has joined #bitcoin-core-dev
4122020-05-04T21:41:17 *** timothy has quit IRC
4132020-05-04T21:46:07 *** smolakala has quit IRC
4142020-05-04T21:51:39 *** mol has quit IRC
4152020-05-04T21:52:00 *** mol has joined #bitcoin-core-dev
4162020-05-04T22:08:17 *** Guyver2 has quit IRC
4172020-05-04T22:16:27 *** bitcoin-git has joined #bitcoin-core-dev
4182020-05-04T22:16:27 <bitcoin-git> [bitcoin] brakmic opened pull request #18871: rpc: prevent circular deps by extracting into separate include (master...prevent-circular-deps) https://github.com/bitcoin/bitcoin/pull/18871
4192020-05-04T22:16:28 *** bitcoin-git has left #bitcoin-core-dev
4202020-05-04T22:18:13 *** Highway61 has quit IRC
4212020-05-04T22:22:04 *** surja795 has joined #bitcoin-core-dev
4222020-05-04T22:24:59 *** DeanWeen has joined #bitcoin-core-dev
4232020-05-04T22:25:39 *** mol has quit IRC
4242020-05-04T22:26:17 *** mol has joined #bitcoin-core-dev
4252020-05-04T22:26:51 *** surja795 has quit IRC
4262020-05-04T22:38:36 *** bitcoin-git has joined #bitcoin-core-dev
4272020-05-04T22:38:36 <bitcoin-git> [bitcoin] achow101 closed pull request #18844: wallet: build: Don't write BDB logs and bump BDB to 5.3 (master...bdb-5.3) https://github.com/bitcoin/bitcoin/pull/18844
4282020-05-04T22:38:37 *** bitcoin-git has left #bitcoin-core-dev
4292020-05-04T22:53:10 *** lightlike has quit IRC
4302020-05-04T22:58:34 *** jonatack has quit IRC
4312020-05-04T22:58:50 *** mol_ has joined #bitcoin-core-dev
4322020-05-04T23:01:13 *** jonatack has joined #bitcoin-core-dev
4332020-05-04T23:01:26 *** surja795 has joined #bitcoin-core-dev
4342020-05-04T23:01:43 *** mol has quit IRC
4352020-05-04T23:03:35 *** brakmic has quit IRC
4362020-05-04T23:05:54 *** surja795 has quit IRC
4372020-05-04T23:07:03 *** braydonf has quit IRC
4382020-05-04T23:09:45 *** braydonf has joined #bitcoin-core-dev
4392020-05-04T23:18:43 *** justanotheruser has quit IRC
4402020-05-04T23:19:23 *** DeanWeen has quit IRC
4412020-05-04T23:28:43 *** braydonf has quit IRC
4422020-05-04T23:32:06 *** braydonf has joined #bitcoin-core-dev
4432020-05-04T23:34:58 *** justanotheruser has joined #bitcoin-core-dev
4442020-05-04T23:42:25 *** DeanWeen has joined #bitcoin-core-dev
4452020-05-04T23:43:14 *** mdunnio has quit IRC
4462020-05-04T23:44:57 *** bitcoin-git has joined #bitcoin-core-dev
4472020-05-04T23:44:58 <bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/b549cb1bd2cc...e727c2bdcab3
4482020-05-04T23:44:59 <bitcoin-git> bitcoin/master 5d49999 DesWurstes: prevector: Avoid unnamed struct, which is a GNU extension
4492020-05-04T23:44:59 <bitcoin-git> bitcoin/master 49f6178 Ben Woosley: Drop unused LOG_TIME_MICROS helper
4502020-05-04T23:45:00 <bitcoin-git> bitcoin/master 3a0fd77 Ben Woosley: Remove use of non-standard zero variadic macros
4512020-05-04T23:45:01 *** bitcoin-git has left #bitcoin-core-dev
4522020-05-04T23:45:42 *** bitcoin-git has joined #bitcoin-core-dev
4532020-05-04T23:45:43 <bitcoin-git> [bitcoin] fanquake merged pull request #18088: build: ensure we aren't using GNU extensions (master...no_gnu_extensions) https://github.com/bitcoin/bitcoin/pull/18088
4542020-05-04T23:45:44 *** bitcoin-git has left #bitcoin-core-dev
4552020-05-04T23:48:38 *** mdunnio has joined #bitcoin-core-dev
4562020-05-04T23:48:52 *** bitcoin-git has joined #bitcoin-core-dev
4572020-05-04T23:48:53 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18873: test: Fix intermittent sync_blocks failures (master...2005-testSyncBlocks) https://github.com/bitcoin/bitcoin/pull/18873
4582020-05-04T23:48:54 *** bitcoin-git has left #bitcoin-core-dev
4592020-05-04T23:53:07 *** mdunnio has quit IRC