1 2020-05-04T00:00:01  *** DarTar has quit IRC
  2 2020-05-04T00:00:08  *** jarthur has joined #bitcoin-core-dev
  3 2020-05-04T00:00:27  *** jarthur has joined #bitcoin-core-dev
  4 2020-05-04T00:01:31  *** jarthur has quit IRC
  5 2020-05-04T00:01:41  *** jarthur has joined #bitcoin-core-dev
  6 2020-05-04T00:07:39  *** jb55 has quit IRC
  7 2020-05-04T00:22:05  *** b_b1 has joined #bitcoin-core-dev
  8 2020-05-04T00:29:32  *** promag has quit IRC
  9 2020-05-04T00:31:04  *** AaronvanW has quit IRC
 10 2020-05-04T00:58:49  *** promag_ has quit IRC
 11 2020-05-04T01:00:42  *** surja795 has joined #bitcoin-core-dev
 12 2020-05-04T01:04:35  *** jb55 has joined #bitcoin-core-dev
 13 2020-05-04T01:06:16  *** davterra has quit IRC
 14 2020-05-04T01:10:12  *** davterra has joined #bitcoin-core-dev
 15 2020-05-04T01:16:04  *** promag has joined #bitcoin-core-dev
 16 2020-05-04T01:24:42  *** surja795 has quit IRC
 17 2020-05-04T01:25:31  *** davterra has quit IRC
 18 2020-05-04T01:29:02  *** sudeep_ has quit IRC
 19 2020-05-04T01:29:50  *** Emcy has quit IRC
 20 2020-05-04T01:34:31  *** promag has quit IRC
 21 2020-05-04T01:42:46  *** Emcy has joined #bitcoin-core-dev
 22 2020-05-04T01:55:11  *** mol_ has joined #bitcoin-core-dev
 23 2020-05-04T01:58:17  *** mol has quit IRC
 24 2020-05-04T02:09:25  *** proofofkeags has joined #bitcoin-core-dev
 25 2020-05-04T02:29:10  *** surja795 has joined #bitcoin-core-dev
 26 2020-05-04T02:56:54  *** surja795_ has joined #bitcoin-core-dev
 27 2020-05-04T02:59:40  *** surja795 has quit IRC
 28 2020-05-04T03:00:01  *** b_b1 has quit IRC
 29 2020-05-04T03:01:14  *** surja795_ has quit IRC
 30 2020-05-04T03:21:57  *** Wolfy87 has joined #bitcoin-core-dev
 31 2020-05-04T03:50:58  *** proofofkeags has quit IRC
 32 2020-05-04T03:56:33  *** commavir has quit IRC
 33 2020-05-04T03:56:59  *** commavir has joined #bitcoin-core-dev
 34 2020-05-04T03:58:55  *** jarthur has quit IRC
 35 2020-05-04T04:07:09  *** proofofkeags has joined #bitcoin-core-dev
 36 2020-05-04T04:11:49  *** proofofkeags has quit IRC
 37 2020-05-04T04:19:53  *** vasild_ has joined #bitcoin-core-dev
 38 2020-05-04T04:22:43  *** vasild has quit IRC
 39 2020-05-04T04:22:44  *** vasild_ is now known as vasild
 40 2020-05-04T04:39:22  *** proofofkeags has joined #bitcoin-core-dev
 41 2020-05-04T04:47:15  *** proofofkeags has quit IRC
 42 2020-05-04T04:53:32  *** TheHoliestRoger has quit IRC
 43 2020-05-04T04:54:02  *** rh0nj has quit IRC
 44 2020-05-04T04:54:22  *** TheHoliestRoger has joined #bitcoin-core-dev
 45 2020-05-04T04:55:08  *** rh0nj has joined #bitcoin-core-dev
 46 2020-05-04T05:04:16  *** whythat has joined #bitcoin-core-dev
 47 2020-05-04T05:05:08  *** owowo has quit IRC
 48 2020-05-04T05:05:44  *** owowo has joined #bitcoin-core-dev
 49 2020-05-04T05:08:23  *** whythat has quit IRC
 50 2020-05-04T05:10:04  *** mol has joined #bitcoin-core-dev
 51 2020-05-04T05:12:36  *** mol_ has quit IRC
 52 2020-05-04T05:15:00  *** proofofkeags has joined #bitcoin-core-dev
 53 2020-05-04T05:15:55  *** Talkless has joined #bitcoin-core-dev
 54 2020-05-04T05:20:59  *** ricky35 has joined #bitcoin-core-dev
 55 2020-05-04T05:22:39  *** proofofkeags has quit IRC
 56 2020-05-04T05:23:06  *** whythat has joined #bitcoin-core-dev
 57 2020-05-04T05:30:23  *** whythat has quit IRC
 58 2020-05-04T05:58:27  *** Homelander has joined #bitcoin-core-dev
 59 2020-05-04T05:59:56  *** whythat has joined #bitcoin-core-dev
 60 2020-05-04T06:00:02  *** Wolfy87 has quit IRC
 61 2020-05-04T06:00:04  *** Dean_Guss has joined #bitcoin-core-dev
 62 2020-05-04T06:04:23  *** whythat has quit IRC
 63 2020-05-04T06:04:37  *** ricky35 has quit IRC
 64 2020-05-04T06:21:56  *** hack_bot has joined #bitcoin-core-dev
 65 2020-05-04T06:36:39  *** whythat has joined #bitcoin-core-dev
 66 2020-05-04T06:41:03  *** whythat has quit IRC
 67 2020-05-04T07:02:45  *** emilengler has joined #bitcoin-core-dev
 68 2020-05-04T07:20:50  *** bitcoin-git has joined #bitcoin-core-dev
 69 2020-05-04T07:20:50  <bitcoin-git> [bitcoin] sipa opened pull request #18861: Do not answer GETDATA for to-be-announced tx (master...202004_private_getdata) https://github.com/bitcoin/bitcoin/pull/18861
 70 2020-05-04T07:20:51  *** bitcoin-git has left #bitcoin-core-dev
 71 2020-05-04T07:24:08  *** spinza has quit IRC
 72 2020-05-04T07:30:39  *** manantial has joined #bitcoin-core-dev
 73 2020-05-04T07:38:06  *** spinza has joined #bitcoin-core-dev
 74 2020-05-04T07:51:15  *** whythat has joined #bitcoin-core-dev
 75 2020-05-04T08:01:52  *** Highway61 has quit IRC
 76 2020-05-04T08:01:58  *** Highway62 has joined #bitcoin-core-dev
 77 2020-05-04T08:04:18  *** Highway62 is now known as Highway61
 78 2020-05-04T08:06:38  *** davterra has joined #bitcoin-core-dev
 79 2020-05-04T08:14:24  *** davterra has quit IRC
 80 2020-05-04T08:14:55  *** marcoagner has joined #bitcoin-core-dev
 81 2020-05-04T08:15:26  *** davterra has joined #bitcoin-core-dev
 82 2020-05-04T08:16:40  *** Guyver2 has joined #bitcoin-core-dev
 83 2020-05-04T08:16:50  *** IGHOR has quit IRC
 84 2020-05-04T08:18:19  *** IGHOR has joined #bitcoin-core-dev
 85 2020-05-04T08:42:33  *** marcoagner has quit IRC
 86 2020-05-04T08:44:05  *** bitcoin-git has joined #bitcoin-core-dev
 87 2020-05-04T08:44:05  <bitcoin-git> [bitcoin] fanquake opened pull request #18862: Remove fdelt_chk back-compat code and sanity check (master...remove_fdelt_chk_back_compat) https://github.com/bitcoin/bitcoin/pull/18862
 88 2020-05-04T08:44:06  *** bitcoin-git has left #bitcoin-core-dev
 89 2020-05-04T08:44:36  *** brakmic has joined #bitcoin-core-dev
 90 2020-05-04T08:47:09  *** Krellan_ has quit IRC
 91 2020-05-04T08:48:03  *** whythat has quit IRC
 92 2020-05-04T08:54:57  *** Kirk28Emmerich has joined #bitcoin-core-dev
 93 2020-05-04T09:00:02  *** hack_bot has quit IRC
 94 2020-05-04T09:01:35  *** promag has joined #bitcoin-core-dev
 95 2020-05-04T09:05:17  *** emilengler has quit IRC
 96 2020-05-04T09:07:17  *** emilengler has joined #bitcoin-core-dev
 97 2020-05-04T09:10:07  *** Kirk28Emmerich has quit IRC
 98 2020-05-04T09:10:32  *** ghostlaptop has joined #bitcoin-core-dev
 99 2020-05-04T09:18:39  *** ghostlaptop has quit IRC
100 2020-05-04T09:20:17  *** whythat has joined #bitcoin-core-dev
101 2020-05-04T09:21:19  *** vancoder has joined #bitcoin-core-dev
102 2020-05-04T09:33:33  *** AaronvanW has joined #bitcoin-core-dev
103 2020-05-04T09:37:00  *** shigeya has quit IRC
104 2020-05-04T09:38:35  *** shigeya has joined #bitcoin-core-dev
105 2020-05-04T09:42:56  *** wullon5 has joined #bitcoin-core-dev
106 2020-05-04T09:54:27  *** bitcoin-git has joined #bitcoin-core-dev
107 2020-05-04T09:54:27  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2e6a16b968a9...afa577c323dc
108 2020-05-04T09:54:28  <bitcoin-git> bitcoin/master f5a3a5b Miguel Herranz: gui: Add close window shortcut
109 2020-05-04T09:54:28  <bitcoin-git> bitcoin/master afa577c Jonas Schnelli: Merge #15768: gui: Add close window shortcut
110 2020-05-04T09:54:30  *** bitcoin-git has left #bitcoin-core-dev
111 2020-05-04T09:55:52  *** jonatack has quit IRC
112 2020-05-04T09:55:57  *** bitcoin-git has joined #bitcoin-core-dev
113 2020-05-04T09:55:57  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #15768: gui: Add close window shortcut (master...add_cmd_w_support_in_macos) https://github.com/bitcoin/bitcoin/pull/15768
114 2020-05-04T09:56:00  *** bitcoin-git has left #bitcoin-core-dev
115 2020-05-04T10:06:35  *** bitcoin-git has joined #bitcoin-core-dev
116 2020-05-04T10:06:36  <bitcoin-git> [bitcoin] promag opened pull request #18863: refactor: Drop unused CScriptVisitor return type (master...2020-04-cscript-visitor) https://github.com/bitcoin/bitcoin/pull/18863
117 2020-05-04T10:06:37  *** bitcoin-git has left #bitcoin-core-dev
118 2020-05-04T10:07:20  *** jonatack has joined #bitcoin-core-dev
119 2020-05-04T10:25:34  *** promag has quit IRC
120 2020-05-04T10:27:20  *** surja795 has joined #bitcoin-core-dev
121 2020-05-04T10:33:37  *** Homelander has quit IRC
122 2020-05-04T10:34:57  *** surja795 has quit IRC
123 2020-05-04T10:35:25  *** surja795 has joined #bitcoin-core-dev
124 2020-05-04T10:37:06  *** surja795 has quit IRC
125 2020-05-04T10:38:04  *** surja795 has joined #bitcoin-core-dev
126 2020-05-04T10:39:58  <elichai2> Is practicalswift on IRC?
127 2020-05-04T10:42:53  *** surja795 has quit IRC
128 2020-05-04T10:44:05  <elichai2> I'm trying to figure out some fuzzing best practices, is it ok to reuse the same fuzzing input on multiple functions or should I "pull" more data for each function I call? (cc BlueMatt ) should I minimize the amount of fuzzing input I'm using or maximize it?
129 2020-05-04T10:45:10  <jonasschnelli> elichai2: he is sometimes. But no bouncer I guess.
130 2020-05-04T11:03:00  *** promag has joined #bitcoin-core-dev
131 2020-05-04T11:03:49  *** promag has quit IRC
132 2020-05-04T11:04:00  *** promag has joined #bitcoin-core-dev
133 2020-05-04T11:07:32  *** ctrlbreak_MAD has joined #bitcoin-core-dev
134 2020-05-04T11:08:20  *** surja795 has joined #bitcoin-core-dev
135 2020-05-04T11:10:25  *** ctrlbreak has quit IRC
136 2020-05-04T11:12:50  *** surja795 has quit IRC
137 2020-05-04T11:18:24  *** DeanWeen has joined #bitcoin-core-dev
138 2020-05-04T11:19:23  *** Dean_Guss has quit IRC
139 2020-05-04T11:27:32  *** surja795 has joined #bitcoin-core-dev
140 2020-05-04T11:29:52  *** surja795 has quit IRC
141 2020-05-04T11:30:20  *** surja795 has joined #bitcoin-core-dev
142 2020-05-04T11:34:34  *** surja795 has quit IRC
143 2020-05-04T11:34:56  *** timothy has joined #bitcoin-core-dev
144 2020-05-04T11:41:42  *** bitcoin-git has joined #bitcoin-core-dev
145 2020-05-04T11:41:43  <bitcoin-git> [bitcoin] Sjors opened pull request #18864: Add v0.16.3 backwards compatibility test, bump v0.19.0.1 to v0.19.1 (master...2020/05/backwards_compat) https://github.com/bitcoin/bitcoin/pull/18864
146 2020-05-04T11:41:44  *** bitcoin-git has left #bitcoin-core-dev
147 2020-05-04T11:43:00  *** surja795 has joined #bitcoin-core-dev
148 2020-05-04T11:45:05  *** per has quit IRC
149 2020-05-04T11:45:19  *** per has joined #bitcoin-core-dev
150 2020-05-04T11:45:48  *** jonatack has quit IRC
151 2020-05-04T11:47:29  *** surja795 has quit IRC
152 2020-05-04T11:48:49  *** jonatack has joined #bitcoin-core-dev
153 2020-05-04T11:50:15  <elichai2> I'm looking here: https://github.com/bitcoin/bitcoin/blob/master/src/test/fuzz/netaddress.cpp#L27 and if I understand https://github.com/bitcoin/bitcoin/blob/master/src/test/fuzz/FuzzedDataProvider.h#L41 correctly then it might not always return 16 bytes
154 2020-05-04T11:50:22  *** bitcoin-git has joined #bitcoin-core-dev
155 2020-05-04T11:50:22  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/afa577c323dc...74a1152f2581
156 2020-05-04T11:50:23  <bitcoin-git> bitcoin/master b56607a practicalswift: Remove CCoinsViewCache::GetValueIn(...)
157 2020-05-04T11:50:23  <bitcoin-git> bitcoin/master 74a1152 MarcoFalke: Merge #18859: Remove CCoinsViewCache::GetValueIn(...)
158 2020-05-04T11:50:25  *** bitcoin-git has left #bitcoin-core-dev
159 2020-05-04T11:50:42  *** bitcoin-git has joined #bitcoin-core-dev
160 2020-05-04T11:50:42  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18859: Remove CCoinsViewCache::GetValueIn(...) (master...GetValueIn) https://github.com/bitcoin/bitcoin/pull/18859
161 2020-05-04T11:50:53  *** bitcoin-git has left #bitcoin-core-dev
162 2020-05-04T11:58:43  *** surja795 has joined #bitcoin-core-dev
163 2020-05-04T12:00:02  *** vancoder has quit IRC
164 2020-05-04T12:01:20  *** bitcoin-git has joined #bitcoin-core-dev
165 2020-05-04T12:01:20  <bitcoin-git> [bitcoin] promag opened pull request #18865: gui: Refactor WalletFrame to extend QStackView (master...2020-05-walletframe) https://github.com/bitcoin/bitcoin/pull/18865
166 2020-05-04T12:01:21  *** bitcoin-git has left #bitcoin-core-dev
167 2020-05-04T12:02:07  *** promag has quit IRC
168 2020-05-04T12:06:07  *** surja795 has quit IRC
169 2020-05-04T12:20:38  *** chmac has joined #bitcoin-core-dev
170 2020-05-04T12:25:39  *** Deacydal has joined #bitcoin-core-dev
171 2020-05-04T12:28:07  *** Deacyde has quit IRC
172 2020-05-04T12:34:01  *** promag has joined #bitcoin-core-dev
173 2020-05-04T12:35:03  *** DeanWeen has quit IRC
174 2020-05-04T12:37:01  *** Deacyded has joined #bitcoin-core-dev
175 2020-05-04T12:37:09  *** surja795 has joined #bitcoin-core-dev
176 2020-05-04T12:38:23  *** promag has quit IRC
177 2020-05-04T12:40:26  *** Deacydal has quit IRC
178 2020-05-04T12:42:55  *** surja795 has quit IRC
179 2020-05-04T12:51:46  *** mol has quit IRC
180 2020-05-04T12:52:01  *** mol has joined #bitcoin-core-dev
181 2020-05-04T12:57:00  *** bitcoin-git has joined #bitcoin-core-dev
182 2020-05-04T12:57:01  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18866: test: Fix verack race to avoid intermittent test failures (master...2005-qaVerackRace) https://github.com/bitcoin/bitcoin/pull/18866
183 2020-05-04T12:57:01  *** bitcoin-git has left #bitcoin-core-dev
184 2020-05-04T13:00:16  *** Deacydal has joined #bitcoin-core-dev
185 2020-05-04T13:03:04  *** surja795 has joined #bitcoin-core-dev
186 2020-05-04T13:03:29  *** promag has joined #bitcoin-core-dev
187 2020-05-04T13:03:30  *** drizztbsd has joined #bitcoin-core-dev
188 2020-05-04T13:03:38  *** timothy has quit IRC
189 2020-05-04T13:03:40  *** drizztbsd is now known as timothy
190 2020-05-04T13:03:46  *** promag has quit IRC
191 2020-05-04T13:04:02  *** promag has joined #bitcoin-core-dev
192 2020-05-04T13:04:05  *** Deacyded has quit IRC
193 2020-05-04T13:04:23  *** bitcoin-git has joined #bitcoin-core-dev
194 2020-05-04T13:04:23  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/74a1152f2581...0a729b0e42fa
195 2020-05-04T13:04:23  <bitcoin-git> bitcoin/master 38e49de practicalswift: tests: Add fuzzing harness for MessageSign, MessageVerify and other functi...
196 2020-05-04T13:04:24  <bitcoin-git> bitcoin/master 0a729b0 MarcoFalke: Merge #18783: tests: Add fuzzing harness for MessageSign, MessageVerify an...
197 2020-05-04T13:04:26  *** promag_ has joined #bitcoin-core-dev
198 2020-05-04T13:04:31  *** bitcoin-git has left #bitcoin-core-dev
199 2020-05-04T13:04:48  *** bitcoin-git has joined #bitcoin-core-dev
200 2020-05-04T13:04:48  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18783: tests: Add fuzzing harness for MessageSign, MessageVerify and other functions in util/message.h (master...fuzzers-message) https://github.com/bitcoin/bitcoin/pull/18783
201 2020-05-04T13:04:59  *** bitcoin-git has left #bitcoin-core-dev
202 2020-05-04T13:06:50  *** bitcoin-git has joined #bitcoin-core-dev
203 2020-05-04T13:06:50  <bitcoin-git> [bitcoin] practicalswift opened pull request #18867: tests: Add fuzzing harness for CCoinsViewCache (master...fuzzers-coins_view) https://github.com/bitcoin/bitcoin/pull/18867
204 2020-05-04T13:06:51  *** bitcoin-git has left #bitcoin-core-dev
205 2020-05-04T13:07:59  *** surja795 has quit IRC
206 2020-05-04T13:09:44  *** promag_ has quit IRC
207 2020-05-04T13:15:43  *** davterra has quit IRC
208 2020-05-04T13:15:50  *** smolakala has joined #bitcoin-core-dev
209 2020-05-04T13:16:36  *** davterra has joined #bitcoin-core-dev
210 2020-05-04T13:18:41  <wumpus> so apparently I wasted my time with #18851 :/
211 2020-05-04T13:18:45  <gribble> https://github.com/bitcoin/bitcoin/issues/18851 | refactor: Replace thread_local use with a mutex-protected map by laanwj · Pull Request #18851 · bitcoin/bitcoin · GitHub
212 2020-05-04T13:23:14  *** Guest35617 has quit IRC
213 2020-05-04T13:28:04  *** surja795 has joined #bitcoin-core-dev
214 2020-05-04T13:30:18  *** Deacydal has quit IRC
215 2020-05-04T13:32:57  *** surja795 has quit IRC
216 2020-05-04T13:38:03  <willcl_ark> Wondering if #7601 ever got picked up by anyone after close?
217 2020-05-04T13:38:06  <gribble> https://github.com/bitcoin/bitcoin/issues/7601 | [WIP] HTLC implementation in the wallet by ebfull · Pull Request #7601 · bitcoin/bitcoin · GitHub
218 2020-05-04T13:43:13  <wumpus> I don't think so, feel free to pick it up
219 2020-05-04T13:51:57  <willcl_ark> thanks wumpus
220 2020-05-04T13:54:30  *** Deacyde has joined #bitcoin-core-dev
221 2020-05-04T13:59:03  <promag> is there a way to know what variables could be made const?
222 2020-05-04T14:03:58  *** AaronvanW has quit IRC
223 2020-05-04T14:05:36  *** bitcoin-git has joined #bitcoin-core-dev
224 2020-05-04T14:05:36  <bitcoin-git> [bitcoin] laanwj closed pull request #18851: refactor: Replace thread_local use with a mutex-protected map (master...2020_05_replace_threadlocal) https://github.com/bitcoin/bitcoin/pull/18851
225 2020-05-04T14:05:38  *** bitcoin-git has left #bitcoin-core-dev
226 2020-05-04T14:05:45  *** AaronvanW has joined #bitcoin-core-dev
227 2020-05-04T14:06:51  *** Guyver2_ has joined #bitcoin-core-dev
228 2020-05-04T14:07:21  *** bitcoin-git has joined #bitcoin-core-dev
229 2020-05-04T14:07:21  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0a729b0e42fa...42fd5038197d
230 2020-05-04T14:07:22  <bitcoin-git> bitcoin/master faec3dc MarcoFalke: init: Remove boost from ThreadImport
231 2020-05-04T14:07:22  <bitcoin-git> bitcoin/master 42fd503 Wladimir J. van der Laan: Merge #18786: init: Remove boost from ThreadImport
232 2020-05-04T14:07:24  *** bitcoin-git has left #bitcoin-core-dev
233 2020-05-04T14:07:41  *** bitcoin-git has joined #bitcoin-core-dev
234 2020-05-04T14:07:41  <bitcoin-git> [bitcoin] laanwj merged pull request #18786: init: Remove boost from ThreadImport (master...2004-noBoostInitThreadImport) https://github.com/bitcoin/bitcoin/pull/18786
235 2020-05-04T14:07:42  *** bitcoin-git has left #bitcoin-core-dev
236 2020-05-04T14:08:02  <wumpus> promag: try to make them const and see if it still compiles?
237 2020-05-04T14:08:24  *** mdunnio has joined #bitcoin-core-dev
238 2020-05-04T14:08:44  *** Guyver2 has quit IRC
239 2020-05-04T14:08:55  <promag> wumpus: ok, see you next year :D
240 2020-05-04T14:10:14  <wumpus> what are you trying to do in the first place? while writing the code you have an idea what could be const and what not I guess?
241 2020-05-04T14:10:29  <promag> no compiler flag? no smartass tool? just curious
242 2020-05-04T14:11:33  <promag> nothing in particular, lots of variables could be made const and that's a good practice no?
243 2020-05-04T14:11:36  <wumpus> please don't make a "make everything const that can be const for const's sake" PR
244 2020-05-04T14:11:50  <promag> wumpus: nope I promise
245 2020-05-04T14:12:26  *** Highway61 has quit IRC
246 2020-05-04T14:12:55  <promag> just came across https://dev.to/fenbf/please-declare-your-variables-as-const
247 2020-05-04T14:14:37  *** promag_ has joined #bitcoin-core-dev
248 2020-05-04T14:14:48  *** promag_ has quit IRC
249 2020-05-04T14:19:13  *** proofofkeags has joined #bitcoin-core-dev
250 2020-05-04T14:23:48  *** proofofkeags has quit IRC
251 2020-05-04T14:26:53  *** Guyver2_ is now known as Guyver2
252 2020-05-04T14:29:49  *** bitcoin-git has joined #bitcoin-core-dev
253 2020-05-04T14:29:50  <bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/42fd5038197d...23c926d859c6
254 2020-05-04T14:29:51  <bitcoin-git> bitcoin/master fae51a5 MarcoFalke: wallet: Avoid translating RPC errors when loading wallets
255 2020-05-04T14:29:52  <bitcoin-git> bitcoin/master fae7776 MarcoFalke: wallet: Avoid translating RPC errors when creating txs
256 2020-05-04T14:29:53  <bitcoin-git> bitcoin/master fa59cc1 MarcoFalke: wallet: Report full error message in wallettool
257 2020-05-04T14:29:54  *** bitcoin-git has left #bitcoin-core-dev
258 2020-05-04T14:30:10  *** bitcoin-git has joined #bitcoin-core-dev
259 2020-05-04T14:30:11  <bitcoin-git> [bitcoin] laanwj merged pull request #18699: wallet: Avoid translating RPC errors (master...1908-walletErrorSegfault) https://github.com/bitcoin/bitcoin/pull/18699
260 2020-05-04T14:30:12  *** bitcoin-git has left #bitcoin-core-dev
261 2020-05-04T14:31:34  *** bitcoin-git has joined #bitcoin-core-dev
262 2020-05-04T14:31:35  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/23c926d859c6...b549cb1bd2cc
263 2020-05-04T14:31:36  <bitcoin-git> bitcoin/master f852030 Vasil Dimov: lockedpool: avoid sensitive data in core files (FreeBSD)
264 2020-05-04T14:31:36  <bitcoin-git> bitcoin/master b549cb1 Wladimir J. van der Laan: Merge #18443: lockedpool: avoid sensitive data in core files (FreeBSD)
265 2020-05-04T14:31:39  *** bitcoin-git has left #bitcoin-core-dev
266 2020-05-04T14:32:04  *** bitcoin-git has joined #bitcoin-core-dev
267 2020-05-04T14:32:05  <bitcoin-git> [bitcoin] laanwj merged pull request #18443: lockedpool: avoid sensitive data in core files (FreeBSD) (master...madvise) https://github.com/bitcoin/bitcoin/pull/18443
268 2020-05-04T14:32:06  *** bitcoin-git has left #bitcoin-core-dev
269 2020-05-04T14:32:24  <elichai2> promag: wumpus  adding `const` and checking if compiling won't work if anyone is casting const away anywhere
270 2020-05-04T14:32:52  <elichai2> Look at the output and try removing the const qualifier from `a` https://godbolt.org/z/VZXfVJ
271 2020-05-04T14:32:55  <promag> elichai2: true
272 2020-05-04T14:53:30  <wumpus> elichai2: correct, const is always advisory in c++ anyway
273 2020-05-04T14:53:53  <elichai2> wumpus: you mean as function input, not variable declaration, right?
274 2020-05-04T14:54:15  <elichai2> (or as pointer qualifier or however you want to call that hehe)
275 2020-05-04T14:54:20  <wumpus> I mean in general, you can always cast it away (of course it's a bad idea)
276 2020-05-04T15:00:02  *** chmac has quit IRC
277 2020-05-04T15:00:44  *** proofofkeags has joined #bitcoin-core-dev
278 2020-05-04T15:07:42  *** cryptapus has quit IRC
279 2020-05-04T15:08:40  *** bitcoin-git has joined #bitcoin-core-dev
280 2020-05-04T15:08:40  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18863: refactor: Drop unused CScriptVisitor return type (master...2020-04-cscript-visitor) https://github.com/bitcoin/bitcoin/pull/18863
281 2020-05-04T15:08:41  *** bitcoin-git has left #bitcoin-core-dev
282 2020-05-04T15:09:00  *** bitcoin-git has joined #bitcoin-core-dev
283 2020-05-04T15:09:00  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18863: refactor: Drop unused CScriptVisitor return type (master...2020-04-cscript-visitor) https://github.com/bitcoin/bitcoin/pull/18863
284 2020-05-04T15:09:01  *** bitcoin-git has left #bitcoin-core-dev
285 2020-05-04T15:10:07  *** cryptapus has joined #bitcoin-core-dev
286 2020-05-04T15:10:07  *** cryptapus has quit IRC
287 2020-05-04T15:10:07  *** cryptapus has joined #bitcoin-core-dev
288 2020-05-04T15:21:24  *** whythat has quit IRC
289 2020-05-04T15:22:16  *** Shabbypenguin has joined #bitcoin-core-dev
290 2020-05-04T15:23:03  *** proofofkeags has quit IRC
291 2020-05-04T15:27:14  *** surja795 has joined #bitcoin-core-dev
292 2020-05-04T15:32:01  *** surja795 has quit IRC
293 2020-05-04T15:32:18  *** whythat has joined #bitcoin-core-dev
294 2020-05-04T15:34:34  *** mol has quit IRC
295 2020-05-04T15:34:49  *** justanotheruser has quit IRC
296 2020-05-04T15:35:17  <luke-jr> wumpus: I'm not sure you are guaranteed that?
297 2020-05-04T15:35:29  <luke-jr> IIRC string literals at least can't just be cast away constness
298 2020-05-04T15:40:57  <BlueMatt> elichai2: its mostly a chance-of-crash per input bit thing - the fuzzer can only try X input bits per time, so if you get more of a chance of a crash from being less verbose, do it (of course it also depends on the type of input - i have a bunch of fuzz targets that don't do well with fuzzer's traditional input bit permutations that focus on arithmetic etc)
299 2020-05-04T15:49:59  *** justanotheruser has joined #bitcoin-core-dev
300 2020-05-04T15:51:39  *** proofofkeags has joined #bitcoin-core-dev
301 2020-05-04T15:56:19  *** proofofkeags has quit IRC
302 2020-05-04T15:56:35  *** proofofkeags has joined #bitcoin-core-dev
303 2020-05-04T15:57:48  *** enasigurd has joined #bitcoin-core-dev
304 2020-05-04T16:08:09  *** surja795 has joined #bitcoin-core-dev
305 2020-05-04T16:12:50  *** surja795 has quit IRC
306 2020-05-04T16:17:03  *** whythat has quit IRC
307 2020-05-04T16:19:57  *** vasild_ has joined #bitcoin-core-dev
308 2020-05-04T16:22:30  *** whythat has joined #bitcoin-core-dev
309 2020-05-04T16:23:23  *** vasild has quit IRC
310 2020-05-04T16:23:26  *** vasild_ is now known as vasild
311 2020-05-04T16:24:53  *** Highway61 has joined #bitcoin-core-dev
312 2020-05-04T16:36:38  *** Sentineo has quit IRC
313 2020-05-04T16:43:12  *** Chris_Stewart_5 has joined #bitcoin-core-dev
314 2020-05-04T16:45:29  *** brakmic has quit IRC
315 2020-05-04T16:45:43  *** brakmic has joined #bitcoin-core-dev
316 2020-05-04T16:46:12  *** brakmic has quit IRC
317 2020-05-04T16:46:17  *** Sentineo has joined #bitcoin-core-dev
318 2020-05-04T16:46:27  *** Highway61 has quit IRC
319 2020-05-04T16:46:42  *** brakmic has joined #bitcoin-core-dev
320 2020-05-04T16:53:52  *** rockhouse has quit IRC
321 2020-05-04T16:53:52  *** victorSN has quit IRC
322 2020-05-04T16:59:25  *** rockhouse has joined #bitcoin-core-dev
323 2020-05-04T16:59:46  *** victorSN has joined #bitcoin-core-dev
324 2020-05-04T17:05:37  *** brakmic_ has joined #bitcoin-core-dev
325 2020-05-04T17:07:07  *** jarthur has joined #bitcoin-core-dev
326 2020-05-04T17:08:54  *** brakmic has quit IRC
327 2020-05-04T17:17:08  *** lightlike has joined #bitcoin-core-dev
328 2020-05-04T17:18:23  *** whythat has quit IRC
329 2020-05-04T17:26:09  *** whythat has joined #bitcoin-core-dev
330 2020-05-04T17:28:48  *** manantial has quit IRC
331 2020-05-04T17:29:44  *** brakmic has joined #bitcoin-core-dev
332 2020-05-04T17:32:03  *** whythat has quit IRC
333 2020-05-04T17:33:23  *** brakmic_ has quit IRC
334 2020-05-04T17:33:49  *** surja795 has joined #bitcoin-core-dev
335 2020-05-04T17:35:20  *** whythat has joined #bitcoin-core-dev
336 2020-05-04T17:38:10  *** surja795 has quit IRC
337 2020-05-04T17:46:40  <wumpus> did we change anything to linking of the tests recently? re #18869
338 2020-05-04T17:46:42  <gribble> https://github.com/bitcoin/bitcoin/issues/18869 | Build of tests fails on FreeBSD · Issue #18869 · bitcoin/bitcoin · GitHub
339 2020-05-04T17:46:54  *** mol has joined #bitcoin-core-dev
340 2020-05-04T17:50:37  <wumpus> luke-jr: my point wasn't that it would be safe to do so
341 2020-05-04T17:52:21  <sipa> wumpus: const is not always advisory in C++
342 2020-05-04T17:52:37  <wumpus> okay
343 2020-05-04T17:52:44  <sipa> if you have a const-declared variable (not just a const reference/pointer to it), then modifying it is UB
344 2020-05-04T17:53:12  <wumpus> I wasn't planning to do anything like that
345 2020-05-04T17:53:34  <sipa> i believe the spec says that modifying through a const pointer/reference is legal only if you know something else in the program holds a non-const reference to the variable
346 2020-05-04T17:54:03  <wumpus> I'm aware the compiler can make all kinds of optimizations based on const
347 2020-05-04T17:54:17  <sipa> usually it can't, actually
348 2020-05-04T17:54:28  <luke-jr> sipa: interesting, so a compiler that tagged const references and aborted if you tried to remove the constness, would be non-compliant?
349 2020-05-04T17:55:22  <sipa> luke-jr: removing the constness is always fine; modifying through a const-reference casted to non-const is UB if no other non-const references exist
350 2020-05-04T17:56:07  <sipa> but say you have a struct X { const int c; X(int v) : c(v) {} };... then modifying c would always be UB
351 2020-05-04T17:56:57  <wumpus> so does anyone have an idea about the link issue?
352 2020-05-04T17:57:04  <sipa> sorry, no :)
353 2020-05-04T18:00:02  *** Shabbypenguin has quit IRC
354 2020-05-04T18:01:18  <wumpus> bisect time then :)
355 2020-05-04T18:06:03  *** whythat has quit IRC
356 2020-05-04T18:15:38  *** shigeya has quit IRC
357 2020-05-04T18:21:45  *** torax has joined #bitcoin-core-dev
358 2020-05-04T18:23:14  *** brakmic_ has joined #bitcoin-core-dev
359 2020-05-04T18:25:54  *** brakmic has quit IRC
360 2020-05-04T18:29:09  *** Highway61 has joined #bitcoin-core-dev
361 2020-05-04T18:31:00  *** bitcoin-git has joined #bitcoin-core-dev
362 2020-05-04T18:31:01  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18730: wallet: Remove -upgradewallet from dummywallet (master...2004-walletNoUpgrade) https://github.com/bitcoin/bitcoin/pull/18730
363 2020-05-04T18:31:02  *** bitcoin-git has left #bitcoin-core-dev
364 2020-05-04T18:48:18  *** Talkless has quit IRC
365 2020-05-04T18:48:54  *** surja795 has joined #bitcoin-core-dev
366 2020-05-04T18:49:07  *** shigeya has joined #bitcoin-core-dev
367 2020-05-04T18:53:17  *** surja795 has quit IRC
368 2020-05-04T19:04:29  *** proofofk_ has joined #bitcoin-core-dev
369 2020-05-04T19:08:21  *** proofofkeags has quit IRC
370 2020-05-04T19:14:02  *** emilengler has quit IRC
371 2020-05-04T19:15:07  *** bitcoin-git has joined #bitcoin-core-dev
372 2020-05-04T19:15:07  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18853: wallet: Fix typo in assert that is compile-time true (master...2004-walletAssertAlwaysTrue) https://github.com/bitcoin/bitcoin/pull/18853
373 2020-05-04T19:15:08  *** bitcoin-git has left #bitcoin-core-dev
374 2020-05-04T19:15:40  *** bitcoin-git has joined #bitcoin-core-dev
375 2020-05-04T19:15:40  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18853: wallet: Fix typo in assert that is compile-time true (master...2004-walletAssertAlwaysTrue) https://github.com/bitcoin/bitcoin/pull/18853
376 2020-05-04T19:15:41  *** bitcoin-git has left #bitcoin-core-dev
377 2020-05-04T19:18:09  *** jarthur_ has joined #bitcoin-core-dev
378 2020-05-04T19:20:43  *** jarthur has quit IRC
379 2020-05-04T19:35:37  <provoostenator> Github lets you mark an exiting pull request as draft now.
380 2020-05-04T19:39:45  <jb55> ohhh awesome that was super annoying
381 2020-05-04T19:45:46  *** brakmic_ has quit IRC
382 2020-05-04T19:46:08  *** brakmic has joined #bitcoin-core-dev
383 2020-05-04T19:57:53  *** go11111111111 has joined #bitcoin-core-dev
384 2020-05-04T20:00:24  *** go121212 has quit IRC
385 2020-05-04T20:07:09  *** jonatack has quit IRC
386 2020-05-04T20:09:08  *** jonatack has joined #bitcoin-core-dev
387 2020-05-04T20:12:48  *** jarthur_ is now known as jarthur
388 2020-05-04T20:20:56  *** surja795 has joined #bitcoin-core-dev
389 2020-05-04T20:28:45  *** justanotheruser has quit IRC
390 2020-05-04T20:29:07  *** justanotheruser has joined #bitcoin-core-dev
391 2020-05-04T20:29:35  *** IPGlider has joined #bitcoin-core-dev
392 2020-05-04T20:36:30  *** dr-orlovsky has joined #bitcoin-core-dev
393 2020-05-04T20:36:42  <jeremyrubin> luke-jr: you may want to chime in on https://github.com/bitcoin/bitcoin/issues/12248#issuecomment-622270497 if you're looking at RPC whitelist/permissions for core
394 2020-05-04T20:37:14  <jeremyrubin> I think it looks like maybe there is disagreement on utility in core but maybe could be something to build for knots and then roll into core if it works well
395 2020-05-04T20:37:14  *** bitcoin-git has joined #bitcoin-core-dev
396 2020-05-04T20:37:14  <bitcoin-git> [bitcoin] achow101 opened pull request #18870: build: Allow BDB between 4.7 and 5.3 without --with-incompatible-bdb (master...allow-other-bdb) https://github.com/bitcoin/bitcoin/pull/18870
397 2020-05-04T20:37:15  *** bitcoin-git has left #bitcoin-core-dev
398 2020-05-04T20:38:18  *** dr-orlovsky has quit IRC
399 2020-05-04T20:55:30  *** proofofk_ has quit IRC
400 2020-05-04T20:55:46  *** proofofkeags has joined #bitcoin-core-dev
401 2020-05-04T20:57:23  <luke-jr> jeremyrubin: I tend to agree it sounds like overkill - but if you want to maintain it for Knots, I guess there's no hurt experimenting
402 2020-05-04T21:00:01  *** torax has quit IRC
403 2020-05-04T21:02:11  *** surja795_ has joined #bitcoin-core-dev
404 2020-05-04T21:04:18  *** surja795_ has joined #bitcoin-core-dev
405 2020-05-04T21:06:12  *** surja795 has quit IRC
406 2020-05-04T21:07:56  *** surja795 has joined #bitcoin-core-dev
407 2020-05-04T21:08:05  *** surja795_ has quit IRC
408 2020-05-04T21:12:35  *** surja795 has quit IRC
409 2020-05-04T21:17:41  *** jarthur has quit IRC
410 2020-05-04T21:18:08  *** jarthur has joined #bitcoin-core-dev
411 2020-05-04T21:22:03  *** fredy1 has joined #bitcoin-core-dev
412 2020-05-04T21:41:17  *** timothy has quit IRC
413 2020-05-04T21:46:07  *** smolakala has quit IRC
414 2020-05-04T21:51:39  *** mol has quit IRC
415 2020-05-04T21:52:00  *** mol has joined #bitcoin-core-dev
416 2020-05-04T22:08:17  *** Guyver2 has quit IRC
417 2020-05-04T22:16:27  *** bitcoin-git has joined #bitcoin-core-dev
418 2020-05-04T22:16:27  <bitcoin-git> [bitcoin] brakmic opened pull request #18871: rpc: prevent circular deps by extracting into separate include (master...prevent-circular-deps) https://github.com/bitcoin/bitcoin/pull/18871
419 2020-05-04T22:16:28  *** bitcoin-git has left #bitcoin-core-dev
420 2020-05-04T22:18:13  *** Highway61 has quit IRC
421 2020-05-04T22:22:04  *** surja795 has joined #bitcoin-core-dev
422 2020-05-04T22:24:59  *** DeanWeen has joined #bitcoin-core-dev
423 2020-05-04T22:25:39  *** mol has quit IRC
424 2020-05-04T22:26:17  *** mol has joined #bitcoin-core-dev
425 2020-05-04T22:26:51  *** surja795 has quit IRC
426 2020-05-04T22:38:36  *** bitcoin-git has joined #bitcoin-core-dev
427 2020-05-04T22:38:36  <bitcoin-git> [bitcoin] achow101 closed pull request #18844: wallet: build: Don't write BDB logs and bump BDB to 5.3 (master...bdb-5.3) https://github.com/bitcoin/bitcoin/pull/18844
428 2020-05-04T22:38:37  *** bitcoin-git has left #bitcoin-core-dev
429 2020-05-04T22:53:10  *** lightlike has quit IRC
430 2020-05-04T22:58:34  *** jonatack has quit IRC
431 2020-05-04T22:58:50  *** mol_ has joined #bitcoin-core-dev
432 2020-05-04T23:01:13  *** jonatack has joined #bitcoin-core-dev
433 2020-05-04T23:01:26  *** surja795 has joined #bitcoin-core-dev
434 2020-05-04T23:01:43  *** mol has quit IRC
435 2020-05-04T23:03:35  *** brakmic has quit IRC
436 2020-05-04T23:05:54  *** surja795 has quit IRC
437 2020-05-04T23:07:03  *** braydonf has quit IRC
438 2020-05-04T23:09:45  *** braydonf has joined #bitcoin-core-dev
439 2020-05-04T23:18:43  *** justanotheruser has quit IRC
440 2020-05-04T23:19:23  *** DeanWeen has quit IRC
441 2020-05-04T23:28:43  *** braydonf has quit IRC
442 2020-05-04T23:32:06  *** braydonf has joined #bitcoin-core-dev
443 2020-05-04T23:34:58  *** justanotheruser has joined #bitcoin-core-dev
444 2020-05-04T23:42:25  *** DeanWeen has joined #bitcoin-core-dev
445 2020-05-04T23:43:14  *** mdunnio has quit IRC
446 2020-05-04T23:44:57  *** bitcoin-git has joined #bitcoin-core-dev
447 2020-05-04T23:44:58  <bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/b549cb1bd2cc...e727c2bdcab3
448 2020-05-04T23:44:59  <bitcoin-git> bitcoin/master 5d49999 DesWurstes: prevector: Avoid unnamed struct, which is a GNU extension
449 2020-05-04T23:44:59  <bitcoin-git> bitcoin/master 49f6178 Ben Woosley: Drop unused LOG_TIME_MICROS helper
450 2020-05-04T23:45:00  <bitcoin-git> bitcoin/master 3a0fd77 Ben Woosley: Remove use of non-standard zero variadic macros
451 2020-05-04T23:45:01  *** bitcoin-git has left #bitcoin-core-dev
452 2020-05-04T23:45:42  *** bitcoin-git has joined #bitcoin-core-dev
453 2020-05-04T23:45:43  <bitcoin-git> [bitcoin] fanquake merged pull request #18088: build: ensure we aren't using GNU extensions (master...no_gnu_extensions) https://github.com/bitcoin/bitcoin/pull/18088
454 2020-05-04T23:45:44  *** bitcoin-git has left #bitcoin-core-dev
455 2020-05-04T23:48:38  *** mdunnio has joined #bitcoin-core-dev
456 2020-05-04T23:48:52  *** bitcoin-git has joined #bitcoin-core-dev
457 2020-05-04T23:48:53  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18873: test: Fix intermittent sync_blocks failures (master...2005-testSyncBlocks) https://github.com/bitcoin/bitcoin/pull/18873
458 2020-05-04T23:48:54  *** bitcoin-git has left #bitcoin-core-dev
459 2020-05-04T23:53:07  *** mdunnio has quit IRC