1 2020-05-05T00:00:01  *** fredy1 has quit IRC
  2 2020-05-05T00:00:15  *** surja795 has joined #bitcoin-core-dev
  3 2020-05-05T00:00:24  *** bitcoin-git has joined #bitcoin-core-dev
  4 2020-05-05T00:00:24  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18875: fuzz: Stop nodes in process_message* fuzzers (master...2005-fuzzStopNodes) https://github.com/bitcoin/bitcoin/pull/18875
  5 2020-05-05T00:00:25  *** bitcoin-git has left #bitcoin-core-dev
  6 2020-05-05T00:21:43  *** unknown1 has joined #bitcoin-core-dev
  7 2020-05-05T00:37:12  *** mol has joined #bitcoin-core-dev
  8 2020-05-05T00:39:49  *** mol_ has quit IRC
  9 2020-05-05T00:40:37  *** mdunnio has joined #bitcoin-core-dev
 10 2020-05-05T00:46:46  *** mol has quit IRC
 11 2020-05-05T00:47:03  *** smolakala has joined #bitcoin-core-dev
 12 2020-05-05T00:52:00  *** mol has joined #bitcoin-core-dev
 13 2020-05-05T00:52:42  *** Chris_Stewart_5 has quit IRC
 14 2020-05-05T00:56:52  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 15 2020-05-05T01:00:10  *** mol has quit IRC
 16 2020-05-05T01:07:33  *** Highway61 has joined #bitcoin-core-dev
 17 2020-05-05T01:14:16  *** AaronvanW has quit IRC
 18 2020-05-05T01:21:04  *** surja795 has quit IRC
 19 2020-05-05T01:22:11  *** surja795 has joined #bitcoin-core-dev
 20 2020-05-05T01:22:43  *** Technoprenerd has quit IRC
 21 2020-05-05T01:32:46  *** Technoprenerd has joined #bitcoin-core-dev
 22 2020-05-05T01:39:58  *** proofofkeags has quit IRC
 23 2020-05-05T01:40:43  *** proofofkeags has joined #bitcoin-core-dev
 24 2020-05-05T01:45:02  *** mol has joined #bitcoin-core-dev
 25 2020-05-05T01:46:48  *** mol_ has joined #bitcoin-core-dev
 26 2020-05-05T01:47:36  *** Technoprenerd has quit IRC
 27 2020-05-05T01:48:03  *** Technoprenerd has joined #bitcoin-core-dev
 28 2020-05-05T01:48:23  *** Chris_Stewart_5 has quit IRC
 29 2020-05-05T01:50:06  *** mol has quit IRC
 30 2020-05-05T02:09:34  *** Technoprenerd has quit IRC
 31 2020-05-05T02:11:55  *** Technoprenerd has joined #bitcoin-core-dev
 32 2020-05-05T02:11:57  *** mdunnio has quit IRC
 33 2020-05-05T02:29:56  *** mol_ has quit IRC
 34 2020-05-05T02:34:29  <meshcollider> maybe #9381 should go on high priority just to get it in finally, it has been sitting around for years with some decent review between rebases, if a few people reviewed it this week before it requires rebase again, it could definitely go in
 35 2020-05-05T02:34:34  <gribble> https://github.com/bitcoin/bitcoin/issues/9381 | Remove CWalletTx merging logic from AddToWallet by ryanofsky · Pull Request #9381 · bitcoin/bitcoin · GitHub
 36 2020-05-05T02:34:38  <meshcollider> at least, review beg ^
 37 2020-05-05T02:34:58  *** proofofkeags has quit IRC
 38 2020-05-05T02:35:32  *** proofofkeags has joined #bitcoin-core-dev
 39 2020-05-05T02:35:39  *** mol has joined #bitcoin-core-dev
 40 2020-05-05T02:37:45  *** _Francisco_ has joined #bitcoin-core-dev
 41 2020-05-05T02:40:02  *** proofofkeags has quit IRC
 42 2020-05-05T02:40:04  *** mol_ has joined #bitcoin-core-dev
 43 2020-05-05T02:43:46  *** mol has quit IRC
 44 2020-05-05T02:47:58  *** surja795 has quit IRC
 45 2020-05-05T02:52:07  *** surja795 has joined #bitcoin-core-dev
 46 2020-05-05T02:53:51  *** mol has joined #bitcoin-core-dev
 47 2020-05-05T02:55:11  *** bitcoin-git has joined #bitcoin-core-dev
 48 2020-05-05T02:55:11  <bitcoin-git> [bitcoin] jnewbery opened pull request #18876: Serve BIP 157 compact filters (master...pr16442.3) https://github.com/bitcoin/bitcoin/pull/18876
 49 2020-05-05T02:55:12  *** bitcoin-git has left #bitcoin-core-dev
 50 2020-05-05T02:56:14  *** mol_ has quit IRC
 51 2020-05-05T02:58:44  *** bitcoin-git has joined #bitcoin-core-dev
 52 2020-05-05T02:58:45  <bitcoin-git> [bitcoin] jnewbery opened pull request #18877: Serve cfcheckpt requests (master...2020-04-serve-getcfcheckpt) https://github.com/bitcoin/bitcoin/pull/18877
 53 2020-05-05T02:58:46  *** bitcoin-git has left #bitcoin-core-dev
 54 2020-05-05T03:00:02  *** unknown1 has quit IRC
 55 2020-05-05T03:03:40  *** smolakala has quit IRC
 56 2020-05-05T03:09:05  *** bitcoin-git has joined #bitcoin-core-dev
 57 2020-05-05T03:09:05  <bitcoin-git> [bitcoin] fanquake closed pull request #16442: Serve BIP 157 compact filters (master...bip157-net) https://github.com/bitcoin/bitcoin/pull/16442
 58 2020-05-05T03:09:07  *** bitcoin-git has left #bitcoin-core-dev
 59 2020-05-05T03:09:36  *** surja795 has quit IRC
 60 2020-05-05T03:11:22  *** go121212 has joined #bitcoin-core-dev
 61 2020-05-05T03:14:01  *** go11111111111 has quit IRC
 62 2020-05-05T03:20:38  *** surja795 has joined #bitcoin-core-dev
 63 2020-05-05T03:21:04  *** bitcoin-git has joined #bitcoin-core-dev
 64 2020-05-05T03:21:04  <bitcoin-git> [bitcoin] ryanofsky opened pull request #18878: test: Add test for conflicted wallet tx notifications (master...pr/nonot) https://github.com/bitcoin/bitcoin/pull/18878
 65 2020-05-05T03:21:05  *** bitcoin-git has left #bitcoin-core-dev
 66 2020-05-05T03:21:20  *** davterra has quit IRC
 67 2020-05-05T03:21:43  *** davterra has joined #bitcoin-core-dev
 68 2020-05-05T03:22:02  *** ironmarx has joined #bitcoin-core-dev
 69 2020-05-05T03:25:18  *** surja795 has quit IRC
 70 2020-05-05T03:34:00  *** bitcoin-git has joined #bitcoin-core-dev
 71 2020-05-05T03:34:00  <bitcoin-git> [bitcoin] fanquake opened pull request #18879: valgrind: remove outdated suppressions (master...remove_outdated_supp) https://github.com/bitcoin/bitcoin/pull/18879
 72 2020-05-05T03:34:01  *** bitcoin-git has left #bitcoin-core-dev
 73 2020-05-05T03:51:53  *** tryphe_ has joined #bitcoin-core-dev
 74 2020-05-05T03:55:03  *** tryphe has quit IRC
 75 2020-05-05T03:56:33  *** bitcoin-git has joined #bitcoin-core-dev
 76 2020-05-05T03:56:34  <bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e727c2bdcab3...ec79b5f86b22
 77 2020-05-05T03:56:34  <bitcoin-git> bitcoin/master ff046ae practicalswift: wallet: Make sure no DescriptorScriptPubKeyMan members are uninitialized a...
 78 2020-05-05T03:56:35  <bitcoin-git> bitcoin/master 2a78098 practicalswift: wallet: Make sure no WalletDescriptor members are uninitialized after cons...
 79 2020-05-05T03:56:35  <bitcoin-git> bitcoin/master ec79b5f Samuel Dobson: Merge #18782: wallet: Make sure no DescriptorScriptPubKeyMan or WalletDesc...
 80 2020-05-05T03:56:36  *** bitcoin-git has left #bitcoin-core-dev
 81 2020-05-05T03:56:53  *** bitcoin-git has joined #bitcoin-core-dev
 82 2020-05-05T03:56:54  <bitcoin-git> [bitcoin] meshcollider merged pull request #18782: wallet: Make sure no DescriptorScriptPubKeyMan or WalletDescriptor members are left uninitialized after construction (master...uninitialized-members) https://github.com/bitcoin/bitcoin/pull/18782
 83 2020-05-05T03:56:55  *** bitcoin-git has left #bitcoin-core-dev
 84 2020-05-05T04:00:24  *** tryphe__ has joined #bitcoin-core-dev
 85 2020-05-05T04:03:23  *** tryphe_ has quit IRC
 86 2020-05-05T04:08:06  *** AaronvanW has joined #bitcoin-core-dev
 87 2020-05-05T04:09:29  *** bitcoin-git has joined #bitcoin-core-dev
 88 2020-05-05T04:09:30  <bitcoin-git> [bitcoin] luke-jr opened pull request #18880: [0.20] wallet: Add BlockUntilSyncedToCurrentChain to dumpwallet (0.20...pr18671-0.20) https://github.com/bitcoin/bitcoin/pull/18880
 89 2020-05-05T04:09:30  *** bitcoin-git has left #bitcoin-core-dev
 90 2020-05-05T04:16:23  *** morcos has quit IRC
 91 2020-05-05T04:16:46  *** ppisati has quit IRC
 92 2020-05-05T04:16:48  *** morcos has joined #bitcoin-core-dev
 93 2020-05-05T04:19:53  *** vasild_ has joined #bitcoin-core-dev
 94 2020-05-05T04:22:43  *** vasild has quit IRC
 95 2020-05-05T04:22:44  *** vasild_ is now known as vasild
 96 2020-05-05T04:23:25  *** ppisati has joined #bitcoin-core-dev
 97 2020-05-05T04:28:17  *** kristapsk has quit IRC
 98 2020-05-05T04:29:03  *** kristapsk has joined #bitcoin-core-dev
 99 2020-05-05T04:38:25  *** AaronvanW has quit IRC
100 2020-05-05T04:42:04  <achow101> #proposedwalletmeetingtopic Moving to a new storage database for descriptor wallets
101 2020-05-05T04:44:14  <sipa> reviving #5686?
102 2020-05-05T04:44:18  <gribble> https://github.com/bitcoin/bitcoin/issues/5686 | [Wallet] replace BDB with internal append only (logdb) backend by jonasschnelli · Pull Request #5686 · bitcoin/bitcoin · GitHub
103 2020-05-05T04:45:34  <achow101> possibly
104 2020-05-05T04:45:47  <achow101> or something else entirely. that's for us to discuss/bikeshed I guess
105 2020-05-05T04:47:34  *** _Francisco_ has quit IRC
106 2020-05-05T04:47:58  <sipa> sqlite has been suggested as well before
107 2020-05-05T04:48:33  <achow101> that was one option I was looking at
108 2020-05-05T04:48:39  <achow101> another was lmdb
109 2020-05-05T04:53:15  <sipa> lmdb is very performant, but has an architecture-dependent format
110 2020-05-05T04:53:26  <sipa> also, all of this is overkill - we don't need a database
111 2020-05-05T04:53:51  <sipa> just a list of key value pairs that are loaded at startup and occasionally overwritten
112 2020-05-05T04:54:01  <achow101> yeah but I don't want to write/review something from scratch
113 2020-05-05T04:54:08  <sipa> so it's not worth making many convenience compromises for
114 2020-05-05T04:54:17  <sipa> that's very reasonable
115 2020-05-05T04:55:03  <achow101> one thing that I would like to do is to have each ScriptPubKeyMan manage its own storage. and that would be achievable through giving each a table or subdatabase (that's a think in bdb and lmdb)
116 2020-05-05T04:55:16  <sipa> why?
117 2020-05-05T04:55:29  <sipa> as in separate files?
118 2020-05-05T04:55:39  <achow101> no in the same file
119 2020-05-05T04:55:59  <sipa> what does that mean/accomplish?
120 2020-05-05T04:56:08  <achow101> but the specifics of how stuff is stored and what is stored is self contained within a ScriptPubKeyMan's module
121 2020-05-05T04:56:35  <achow101> i guess it's bringing the encapsulation of the code to the storage layer as well
122 2020-05-05T04:56:46  <sipa> that could be done by just giving each a unique prefix for its keys
123 2020-05-05T04:58:27  <achow101> i guess...
124 2020-05-05T04:58:55  <sipa> i meam, if the db system used exposes a feature to do this more natively, sure use it
125 2020-05-05T04:59:27  <sipa> but i don't think it's worth picking one db system over another for, or at least not if it comes with other compromises
126 2020-05-05T04:59:39  <sipa> compatibility of wallet files i think would be a dealbreaker for lmdb
127 2020-05-05T04:59:43  <achow101> right
128 2020-05-05T05:00:15  <achow101> i've been primarily looking for things that are self contained single files, platform independent, and not likely to have changing formtas
129 2020-05-05T05:00:40  <sipa> sqlite seems to match that
130 2020-05-05T05:00:55  <achow101> lmdb has some build options that make it independent of bitness, but not endianness
131 2020-05-05T05:00:55  <sipa> or text files ;)
132 2020-05-05T05:01:36  <achow101> apparently monero uses lmdb for something and the guy that wrote/writes/maintains lmdb contributes there
133 2020-05-05T05:01:53  <sipa> yes
134 2020-05-05T05:02:09  <sipa> but lmdb is very focused on performance
135 2020-05-05T05:02:18  <sipa> for the wallet we couldn't care less about that
136 2020-05-05T05:02:40  <achow101> well I'd like to care about performace :)
137 2020-05-05T05:02:59  <sipa> why?
138 2020-05-05T05:03:13  *** Talkless has joined #bitcoin-core-dev
139 2020-05-05T05:03:20  <achow101> there was that one time importmulti would take so long writing everthing to disk that the RPC would timeout before it finished
140 2020-05-05T05:04:07  <sipa> that was just due to silliness of flushing in between any two records writte
141 2020-05-05T05:04:12  <sipa> no.
142 2020-05-05T05:04:14  <sipa> ?
143 2020-05-05T05:04:51  <sipa> if writing a few kb takes more than milliseconds it's not a fault of the db system
144 2020-05-05T05:05:02  <achow101> it was. but a performant db system means I can do dumb things like that and not have a noticeable impact on the user experince :p
145 2020-05-05T05:06:03  <sipa> no
146 2020-05-05T05:06:25  <sipa> this is literally not something any db system could make reasnable
147 2020-05-05T05:06:29  <achow101> I was really only looking at lmdb since it seemed to be almost a drop in replacement for bdb
148 2020-05-05T05:06:45  <achow101> yeah, i know. i'm just trolling you
149 2020-05-05T05:07:31  <sipa> okay :D
150 2020-05-05T05:10:54  <achow101> i'm not sure that a key-value store is really what we want though. what we have now just feels like jamming separate values to fit into a key-value store. we have a bunch of records that are multiple values that could fit better into table
151 2020-05-05T05:11:08  <achow101> although I would agree with a relation db system is way overkill
152 2020-05-05T05:11:36  <sipa> well, you're right that it's not quite exactly a key-value store
153 2020-05-05T05:11:44  <sipa> but it is how it works now
154 2020-05-05T05:12:11  <sipa> changing the organization of the data as well as the backend storage is a way bigger change
155 2020-05-05T05:12:51  <achow101> that was part of the plan
156 2020-05-05T05:12:52  <sipa> even things like google's bigtable is effectively leveldb but with keys that are sort of a hierarchy of fields
157 2020-05-05T05:12:57  <sipa> ugh :)
158 2020-05-05T05:13:12  <sipa> seems unnecesary
159 2020-05-05T05:16:13  <achow101> I would like to do some things like consolidated address book data and changing unenecrypted privkey storage format that would make it diverge from what we currently have
160 2020-05-05T05:17:03  *** tryphe__ has quit IRC
161 2020-05-05T05:17:19  *** tryphe__ has joined #bitcoin-core-dev
162 2020-05-05T05:17:41  <sipa> you can do that without changing the organization or the storage format
163 2020-05-05T05:18:58  <achow101> address book stuff would be different records entirely so that's changing the organization
164 2020-05-05T05:19:25  <sipa> i mean: it doesn't require moving away from a key-value store
165 2020-05-05T05:20:39  <achow101> nothing strictly requires one or the other so it's just a function of how much work you want to do
166 2020-05-05T05:20:55  <sipa> as little as possible :)
167 2020-05-05T05:21:20  *** tryphe_ has joined #bitcoin-core-dev
168 2020-05-05T05:21:33  *** enasigurd has quit IRC
169 2020-05-05T05:21:42  *** enasigurd has joined #bitcoin-core-dev
170 2020-05-05T05:24:28  *** tryphe__ has quit IRC
171 2020-05-05T06:00:02  *** ironmarx has quit IRC
172 2020-05-05T06:05:51  *** bitcoin-git has joined #bitcoin-core-dev
173 2020-05-05T06:05:51  <bitcoin-git> [bitcoin] hebasto opened pull request #18881: Prevent UB in DeleteLock() function (master...200505-cofu) https://github.com/bitcoin/bitcoin/pull/18881
174 2020-05-05T06:05:52  *** bitcoin-git has left #bitcoin-core-dev
175 2020-05-05T06:16:49  *** jarthur_ has joined #bitcoin-core-dev
176 2020-05-05T06:20:28  *** jarthur has quit IRC
177 2020-05-05T06:21:51  *** jarthur_ has quit IRC
178 2020-05-05T06:22:26  *** silvers- has joined #bitcoin-core-dev
179 2020-05-05T06:25:49  *** Landryl4 has joined #bitcoin-core-dev
180 2020-05-05T06:26:20  *** Landryl has quit IRC
181 2020-05-05T06:26:21  *** Landryl4 is now known as Landryl
182 2020-05-05T06:31:23  *** jarthur has joined #bitcoin-core-dev
183 2020-05-05T06:35:57  *** AaronvanW has joined #bitcoin-core-dev
184 2020-05-05T06:45:11  <jonasschnelli> achow101: what would speak against a simple append only file-format? Keep all the wallets in memory for fast performance. And if memory gets a concern, load the transactions when required.
185 2020-05-05T06:45:21  <jonasschnelli> I'd say even for large wallets, that should be reasonable fast.
186 2020-05-05T06:46:51  <achow101> jonasschnelli: i don't think we should do append only. we currently do things that would not work well with append only and it seems reasonable that we would do things similarly in the future
187 2020-05-05T06:47:17  <achow101> for example UpgradeKeyMetadata modifies CKeyMetadata and doing this in an append only format would not be ideal
188 2020-05-05T06:47:19  <jonasschnelli> If one wants to increase the performance of tx loading / decomposing, one could implement kinda subtotals... which would reduce the balance algorithms to not always scan the whole tx database
189 2020-05-05T06:47:51  <jonasschnelli> achow101: just write the new records as append only,... which would internally overwrite the old recods...
190 2020-05-05T06:47:59  <jonasschnelli> just disk size and loading time would increase
191 2020-05-05T06:48:14  <jonasschnelli> until one performs a compact-save (write 100% again)
192 2020-05-05T06:48:26  <achow101> well yeah, that's the problem
193 2020-05-05T06:48:36  <jonasschnelli> what? the compact write?
194 2020-05-05T06:48:50  <achow101> the duplicate records which impacts disk size and loading times
195 2020-05-05T06:48:55  <jonasschnelli> or the disk size?
196 2020-05-05T06:49:04  <jonasschnelli> who cares about disk size if you have 300GB+ blockchain data? :-)
197 2020-05-05T06:49:09  <jonasschnelli> and if you care, do a compact-save
198 2020-05-05T06:49:21  <jonasschnelli> (optimizewallet call or so)
199 2020-05-05T06:49:43  <jonasschnelli> and you could write special "overwrite" records for things that happen often and use little space.
200 2020-05-05T06:49:54  <jonasschnelli> Not often. but take abandontransaction as example.
201 2020-05-05T06:50:18  <jonasschnelli> just write a special record type that abandons a tx id rather than stroing the whole tx stucture again.
202 2020-05-05T06:50:33  <jonasschnelli> (would only be required if you care about disk size though)
203 2020-05-05T06:51:06  <achow101> a compact save seems like a possibility to lose data
204 2020-05-05T06:51:19  <achow101> and I don't really want the user to have to manually initiate one, doesn't feel like good ux
205 2020-05-05T06:51:41  <jonasschnelli> achow101: not if done right... compact write to a second file, validate integrity, atomic swap
206 2020-05-05T06:52:02  <jonasschnelli> achow101: you could calculate the % overhead on each load,.. if to large, compact save.
207 2020-05-05T06:52:12  <jonasschnelli> is matters of milliseconds.
208 2020-05-05T06:52:19  <jonasschnelli> integrity can be guaranteed if done right
209 2020-05-05T06:52:35  <jonasschnelli> no external dependencies....
210 2020-05-05T06:52:55  <jonasschnelli> sha256 hash per record to have a database "made" for secrets
211 2020-05-05T06:53:31  <sipa> yeah, that's what logdb did
212 2020-05-05T06:53:38  <jonasschnelli> I would avoid getting caught in sqlite3 or lmdb pitfalls
213 2020-05-05T06:53:48  <jonasschnelli> sipa: exactly
214 2020-05-05T06:54:23  <jonasschnelli> the only question for me is, if it is acceptable to have everything in memory and if not, how hard it would be to have a disk based tx decomposer
215 2020-05-05T06:54:28  <sipa> i'd be ok with sqlite
216 2020-05-05T06:54:57  <jonasschnelli> yeah,... for the tx history,... but just for the keys, scripts, it seems to be an overkill
217 2020-05-05T06:55:07  <sipa> it's absolutely overkill
218 2020-05-05T06:55:15  <achow101> jonasschnelli: it's slightly difficult for right now to not have all the txs in memory
219 2020-05-05T06:55:24  <achow101> bunch of gui stuff relies on that fact
220 2020-05-05T06:55:37  <achow101> i have a branch that attempted to load txs on demand and it was kinda awful
221 2020-05-05T06:55:49  <sipa> but it's also a well-tested existing standalone library that does what we need - and a lot we don't need
222 2020-05-05T06:55:51  <jonasschnelli> achow101: indeed. Optimizing performance would require some sub-total (balance-up-to-this-tx) cache
223 2020-05-05T06:56:00  *** _Francisco_ has joined #bitcoin-core-dev
224 2020-05-05T06:56:21  <sipa> i would avoid lmdb, it seems designed for very different goals
225 2020-05-05T06:56:32  <jonasschnelli> Yes. Makes little sense for a wallet IMO
226 2020-05-05T06:57:04  <achow101> IIRC Armory is using/was going to use lmdb for the wallet. dunno how far that got
227 2020-05-05T06:57:25  <achow101> but yeah, after looking at lmdb, it doesn't seem like a good fit, particularly the arch dependent format
228 2020-05-05T06:59:37  <achow101> bikeshedding over what format to use can come later though. I first want to know if trying to do this now will even get anywhere
229 2020-05-05T06:59:59  <jonasschnelli> first it would be good to layer out bdb...
230 2020-05-05T07:00:36  <achow101> one of my concerns is whether we should even try to do this for descriptor wallets now
231 2020-05-05T07:00:40  <jonasschnelli> the code needs to be ready to support both formats
232 2020-05-05T07:00:43  <achow101> or if it's too late
233 2020-05-05T07:00:55  <jonasschnelli> since you dont want to abandon old wallets
234 2020-05-05T07:01:01  <sipa> achow101: you mean *only* for descriptor wallets?
235 2020-05-05T07:01:06  <achow101> jonasschnelli: my idea was to make it a descriptor wallets only thing
236 2020-05-05T07:01:14  <jonasschnelli> yeah. that would be an ideal time
237 2020-05-05T07:01:17  <sipa> i think that's crazy
238 2020-05-05T07:01:38  <achow101> the reasoning being that since descriptor wallets is a wholly new thing, might be a good time to also bring in a new disk format
239 2020-05-05T07:02:03  *** per has quit IRC
240 2020-05-05T07:02:09  <sipa> if will complicate maintaining support for legacy wallets, by duplicating all storage level stuff work now for bdb and whatever is chosen
241 2020-05-05T07:02:28  <sipa> imo it's something to do completely orthogonally
242 2020-05-05T07:02:41  <jonasschnelli> sipa: but you have to support both storage backends anyways. right?
243 2020-05-05T07:02:43  <achow101> sipa: how so?
244 2020-05-05T07:02:56  <achow101> the thought was that legacy wallets would only use bdb, and descriptor wallets only the new thing
245 2020-05-05T07:03:06  <achow101> then whenver we get around to killing legacy wallets, bdb goes with it
246 2020-05-05T07:03:08  <sipa> achow101: yeah, i think that's crazy
247 2020-05-05T07:03:21  <sipa> you'll need two walletdb
248 2020-05-05T07:03:25  <jonasschnelli> If an storage upgrade is required for legacy wallets (which would be a no-go IMO), it could go over bitcoin-wallet (where we still need both storage backend in the code)
249 2020-05-05T07:03:26  <sipa> you'll need two walletdb.cpp's
250 2020-05-05T07:03:41  <jonasschnelli> yes.
251 2020-05-05T07:03:58  <sipa> and you'll duplicate work for all improvements that aren't specific to descriptor wallets
252 2020-05-05T07:03:59  *** chjj has quit IRC
253 2020-05-05T07:03:59  <jonasschnelli> I once tried to make the storage backend flexible, changable,... not very easy
254 2020-05-05T07:04:01  <achow101> but you need that already
255 2020-05-05T07:04:08  <sipa> and it seems completely unnecessary
256 2020-05-05T07:04:45  <sipa> as long as what is exposed is a key-value store, the choice of storage format can be independent of what the keys in it meam
257 2020-05-05T07:04:58  <sipa> and sure, descriptor walleta would by default by the new thing
258 2020-05-05T07:05:00  <jonasschnelli> yes. it needs a new layers.
259 2020-05-05T07:05:06  <sipa> and.old wallets would generally be the old thing
260 2020-05-05T07:05:13  <achow101> sipa: I think you could still get it to be shared even with different db backends
261 2020-05-05T07:05:21  *** Anduck_ has joined #bitcoin-core-dev
262 2020-05-05T07:05:31  <sipa> achow101: yes, if the ly're orthogonal
263 2020-05-05T07:05:42  <achow101> i get that the separation doesn't make sense technically. but i'm also trying to make it a logical separation to
264 2020-05-05T07:06:25  <sipa> i think you shouldn't try to make this a descriptor-wallet-only thing
265 2020-05-05T07:06:41  <sipa> that risks huge compatibility problems if it doesn't get in by 0.21
266 2020-05-05T07:07:35  <achow101> and that's the other problem
267 2020-05-05T07:08:02  <sipa> and there's no need, i think - you'll want to abstract out the storage layer, amlnd if that's done cleanly, there should be no reason why you couldn't supoort a legacy new-format wallet or a descriptor bdb wallet
268 2020-05-05T07:08:40  <sipa> (perhaps you wouldn't want to support creating such things through RPC or whatever - but i think internally you want things separated that way)
269 2020-05-05T07:09:26  <achow101> well yeah, that was kind of the idea. that in theory you could write a legacy wallet to the new storage, but we just wouldn't allow it
270 2020-05-05T07:09:46  <sipa> right, but the decision on what to allow can come late
271 2020-05-05T07:09:46  *** jarthur has quit IRC
272 2020-05-05T07:09:47  *** mol has quit IRC
273 2020-05-05T07:09:47  *** TheHoliestRoger has quit IRC
274 2020-05-05T07:09:47  *** justinmoon has quit IRC
275 2020-05-05T07:09:47  *** votesmith has quit IRC
276 2020-05-05T07:09:47  *** frogar has quit IRC
277 2020-05-05T07:09:47  *** roasbeef has quit IRC
278 2020-05-05T07:09:48  *** aj has quit IRC
279 2020-05-05T07:09:48  *** jeremyrubin has quit IRC
280 2020-05-05T07:09:48  *** tripleslash has quit IRC
281 2020-05-05T07:09:48  *** wraithm has quit IRC
282 2020-05-05T07:09:48  *** Anduck has quit IRC
283 2020-05-05T07:09:58  *** AaronvanW has quit IRC
284 2020-05-05T07:10:09  <sipa> if things are in by 0.21 you could indeed say descriptor wallets only in the new format
285 2020-05-05T07:10:12  <achow101> i suppose so
286 2020-05-05T07:10:31  <sipa> but i think you'll want support for legacy new-format wallets in any caze too
287 2020-05-05T07:10:58  <sipa> eventually someone may want to run a convert tool to convert a bdb wallet to a new format wallet
288 2020-05-05T07:11:05  <sipa> if bdb gets dropped
289 2020-05-05T07:11:18  <sipa> but that process can't convert a legacy wallet into a descriptor wallet
290 2020-05-05T07:11:30  <achow101> right
291 2020-05-05T07:12:49  *** CubicEarth has quit IRC
292 2020-05-05T07:13:25  <jonasschnelli> I think the bdb support can't be drop in near and longterm future.
293 2020-05-05T07:14:14  <jonasschnelli> If an "tool" (like bitcoin-wallet) would allow the migration from bdb-storage to new-storage, we still would require the bdb support
294 2020-05-05T07:14:20  <achow101> so bdb's file format isn't that hard to parse so it wouldn't be all that hard to move to new storage
295 2020-05-05T07:14:27  <jonasschnelli> an it would be foolish to tell people to use a third party tool for that
296 2020-05-05T07:14:32  *** CubicEarth has joined #bitcoin-core-dev
297 2020-05-05T07:15:29  <jonasschnelli> achow101: you mean a simple record by record migration... yeah. maybe. Still would required the bdb dependency... and some parts of our bdb db.cpp code
298 2020-05-05T07:15:58  *** jarthur has joined #bitcoin-core-dev
299 2020-05-05T07:15:58  *** mol has joined #bitcoin-core-dev
300 2020-05-05T07:15:58  *** TheHoliestRoger has joined #bitcoin-core-dev
301 2020-05-05T07:15:58  *** justinmoon has joined #bitcoin-core-dev
302 2020-05-05T07:15:58  *** votesmith has joined #bitcoin-core-dev
303 2020-05-05T07:15:58  *** frogar has joined #bitcoin-core-dev
304 2020-05-05T07:15:58  *** roasbeef has joined #bitcoin-core-dev
305 2020-05-05T07:15:58  *** aj has joined #bitcoin-core-dev
306 2020-05-05T07:15:58  *** jeremyrubin has joined #bitcoin-core-dev
307 2020-05-05T07:15:58  *** tripleslash has joined #bitcoin-core-dev
308 2020-05-05T07:15:58  *** wraithm has joined #bitcoin-core-dev
309 2020-05-05T07:16:02  <jonasschnelli> which makes me think supporting both storage backends in the long term future is easier and unavoidable
310 2020-05-05T07:16:43  <achow101> jonasschnelli: #18836 has a pure python deserializer for bdb files. That with python3's sqlite lib should make a python script that can do a record for record conversion in <200 LOC
311 2020-05-05T07:16:49  <gribble> https://github.com/bitcoin/bitcoin/issues/18836 | wallet: upgradewallet fixes and additional tests by achow101 · Pull Request #18836 · bitcoin/bitcoin · GitHub
312 2020-05-05T07:17:41  <achow101> (the python deserializer is to inspect wallet files to make sure that records are being updated by upgradedwallet)
313 2020-05-05T07:17:54  <sipa> achow101: wow.
314 2020-05-05T07:18:04  <jonasschnelli> achow101: I think only python scripts is not an adequate option to a must-migrate approach
315 2020-05-05T07:18:08  <sipa> i'm surprised and impressed that it's so simple
316 2020-05-05T07:18:11  <jonasschnelli> Think of the novice gui only windows users
317 2020-05-05T07:18:42  *** chjj has joined #bitcoin-core-dev
318 2020-05-05T07:18:48  <achow101> jonasschnelli: right. my point is that it wouldn't be that hard to do add a function within bitcoind itself and it doesn't require bdb
319 2020-05-05T07:18:54  <jonasschnelli> also,.. I think it would be non-ideal to tell people to use third party libraries (python stack) to migrate their most crucial database
320 2020-05-05T07:19:06  <jonasschnelli> achow101: ah. I see. Yes. Thats a good point.
321 2020-05-05T07:19:54  <jonasschnelli> Just; we where really careful to not force walletupgrade for things like HD, etc. Then we suddenly force people to upgrade due to a storage engine change?
322 2020-05-05T07:20:12  <jonasschnelli> I'd rather support both storage backends long term
323 2020-05-05T07:21:00  <achow101> same. I think supporting both would be required for quite a while. then the super long term solution is an upgrade with a minimal tool/function
324 2020-05-05T07:21:18  <jonasschnelli> achow101: yes.
325 2020-05-05T07:21:22  <sipa> that's starting to look much more reasonable now
326 2020-05-05T07:21:30  <sipa> given how simple bdb is to read
327 2020-05-05T07:21:38  <sipa> not short or medium term
328 2020-05-05T07:21:45  <sipa> but perhaps long term
329 2020-05-05T07:22:10  <achow101> sipa: I was surprised too. Unfortunately none of this was documented anywhere and it required rooting around in the source code for a while. at least all the things were in structs in one file in their source tarball
330 2020-05-05T07:22:21  <jonasschnelli> At one point, bdb depdency could be optional / disabled by default, leaving only the internal conversion tool.
331 2020-05-05T07:22:55  <jonasschnelli> later, the bdb dependency will be removed and users are forced to upgrade (long long term)
332 2020-05-05T07:23:19  <achow101> sipa: part of the simplicity is also that we don't use advanced feature of bdb so the page layout is also very predictable
333 2020-05-05T07:23:27  <sipa> right
334 2020-05-05T07:24:34  <sipa> sqlite3 is very well defined apparently; all releases back 3.0 can read/write those filss
335 2020-05-05T07:25:28  <sipa> ah, not perfectly forward compatible :(
336 2020-05-05T07:26:01  <jonasschnelli> sqlite3 would have some nice benefits for large (many tx) wallets allowing some nice queries
337 2020-05-05T07:26:02  <sipa> i also like that it's just a single file
338 2020-05-05T07:26:22  <jonasschnelli> Though I wonder how much of a concern it will be in 10 years and if we would not end up at the same point as we are now with bdb
339 2020-05-05T07:27:03  * midnight would cheer if bdb went away
340 2020-05-05T07:27:53  <achow101> i think that bdb isn't that bad of a choice for a wallet file format. my main gripe is that we're using a version that's now more than 10 years old. and also oracle messing with the licensing
341 2020-05-05T07:28:10  <sipa> achow101: my... experience is different
342 2020-05-05T07:29:33  <achow101> i'm sure it is :) I know there were a lot of consistency and corruption issues before, but I haven't seen a lot of those recently
343 2020-05-05T07:29:43  <jonasschnelli> achow101: Yes. And how big would be the risk of repeating that when using another library like sqlite?
344 2020-05-05T07:30:09  <sipa> my impression is that bdb was origonally designed for large multi-process databases, where there was a dedicated and competent database mantainer who would manually perform tweaking, and upgrades
345 2020-05-05T07:30:40  <sipa> rather than as an application storage format
346 2020-05-05T07:30:55  <jonasschnelli> *just send me your wallets, i'm a competent database maintainer.*
347 2020-05-05T07:31:34  *** bitcoin-git has joined #bitcoin-core-dev
348 2020-05-05T07:31:34  <bitcoin-git> [bitcoin] fanquake opened pull request #18882: build: fix -Wformat-security check when compiling with GCC (master...fix_gcc_wformat_security) https://github.com/bitcoin/bitcoin/pull/18882
349 2020-05-05T07:31:35  *** bitcoin-git has left #bitcoin-core-dev
350 2020-05-05T07:32:10  *** lio17 has quit IRC
351 2020-05-05T07:32:14  *** luke-jr has quit IRC
352 2020-05-05T07:32:23  *** vasild has quit IRC
353 2020-05-05T07:33:02  <achow101> jonasschnelli: with sqlite itself, I would expect there to be few to no compatibility or licensing issues. For consistency and corruption, i'd trust it more than a homegrown format tbh
354 2020-05-05T07:33:19  *** lio17 has joined #bitcoin-core-dev
355 2020-05-05T07:33:31  <jonasschnelli> Maybe. Yes.
356 2020-05-05T07:33:48  <sipa> i believe sqlite is very well tested
357 2020-05-05T07:34:23  <jonasschnelli> Also,.. it would allow better handling of larger wallets
358 2020-05-05T07:34:32  <sipa> how so?
359 2020-05-05T07:34:38  <jonasschnelli> (without more homegrown code)
360 2020-05-05T07:34:58  <jonasschnelli> A decent option to query stuff if we use not just k/v storage
361 2020-05-05T07:35:19  *** luke-jr has joined #bitcoin-core-dev
362 2020-05-05T07:35:48  <jonasschnelli> right now,.. all txns are in memory... assume you just want to show the first page of txns (the most recent 10)
363 2020-05-05T07:35:49  <sipa> i think that's just asking for problems again
364 2020-05-05T07:36:07  <sipa> if we want a chance of.doing this, it can't be tied to any other changes
365 2020-05-05T07:36:46  <sipa> and should be just a straight change from one storage format to another (i.e. remain a k/v store, with the same keys and the same meaning)
366 2020-05-05T07:37:26  <sipa> maybe later (much later...) you could start using other features, but i'm unconvinced that's even worth it
367 2020-05-05T07:38:25  *** vasild has joined #bitcoin-core-dev
368 2020-05-05T07:52:48  *** jarthur has quit IRC
369 2020-05-05T07:52:52  *** marcoagner has joined #bitcoin-core-dev
370 2020-05-05T08:05:33  *** Guyver2 has joined #bitcoin-core-dev
371 2020-05-05T08:19:15  *** mol_ has joined #bitcoin-core-dev
372 2020-05-05T08:21:06  *** mol has quit IRC
373 2020-05-05T08:21:10  *** molz_ has joined #bitcoin-core-dev
374 2020-05-05T08:21:38  *** molz_ has quit IRC
375 2020-05-05T08:21:56  *** molz_ has joined #bitcoin-core-dev
376 2020-05-05T08:24:49  *** mol_ has quit IRC
377 2020-05-05T08:28:24  *** tryphe_ is now known as tryphe
378 2020-05-05T08:31:11  *** AaronvanW has joined #bitcoin-core-dev
379 2020-05-05T08:32:13  *** promag_ has joined #bitcoin-core-dev
380 2020-05-05T08:37:37  *** AaronvanW has quit IRC
381 2020-05-05T08:37:53  *** AaronvanW has joined #bitcoin-core-dev
382 2020-05-05T08:47:36  *** timothy has joined #bitcoin-core-dev
383 2020-05-05T08:54:28  *** bitcoin-git has joined #bitcoin-core-dev
384 2020-05-05T08:54:28  <bitcoin-git> [bitcoin] hebasto opened pull request #18883: qt: Fix OpenWalletActivity::open() (master...200505-fix-win) https://github.com/bitcoin/bitcoin/pull/18883
385 2020-05-05T08:54:37  *** bitcoin-git has left #bitcoin-core-dev
386 2020-05-05T08:56:42  *** emilengler has joined #bitcoin-core-dev
387 2020-05-05T08:59:51  *** Chris_Stewart_5 has joined #bitcoin-core-dev
388 2020-05-05T09:00:02  *** silvers- has quit IRC
389 2020-05-05T09:05:47  *** _Francisco_ has quit IRC
390 2020-05-05T09:21:25  *** ironmarx has joined #bitcoin-core-dev
391 2020-05-05T09:23:22  *** Chris_Stewart_5 has quit IRC
392 2020-05-05T09:27:37  *** promag_ has quit IRC
393 2020-05-05T09:28:44  *** promag_ has joined #bitcoin-core-dev
394 2020-05-05T10:17:51  *** promag__ has joined #bitcoin-core-dev
395 2020-05-05T10:17:51  *** promag has quit IRC
396 2020-05-05T10:17:52  *** promag_ has quit IRC
397 2020-05-05T10:17:56  *** emilengler has quit IRC
398 2020-05-05T10:17:57  *** promag___ has joined #bitcoin-core-dev
399 2020-05-05T10:20:36  *** emilengler has joined #bitcoin-core-dev
400 2020-05-05T10:22:13  *** surja795 has joined #bitcoin-core-dev
401 2020-05-05T10:23:32  *** devindia has joined #bitcoin-core-dev
402 2020-05-05T10:24:25  *** per has joined #bitcoin-core-dev
403 2020-05-05T10:27:23  *** cltrbreak_MAD2 has joined #bitcoin-core-dev
404 2020-05-05T10:28:50  *** TheRec has quit IRC
405 2020-05-05T10:29:02  *** Technoprenerd has quit IRC
406 2020-05-05T10:29:06  *** cryptapus_ has joined #bitcoin-core-dev
407 2020-05-05T10:29:06  *** cryptapus_ has quit IRC
408 2020-05-05T10:29:06  *** cryptapus_ has joined #bitcoin-core-dev
409 2020-05-05T10:29:08  *** cryptapus has quit IRC
410 2020-05-05T10:29:14  *** rockhouse1 has joined #bitcoin-core-dev
411 2020-05-05T10:29:23  *** TheRec has joined #bitcoin-core-dev
412 2020-05-05T10:29:33  *** Technoprenerd has joined #bitcoin-core-dev
413 2020-05-05T10:30:32  *** rockhouse has quit IRC
414 2020-05-05T10:30:32  *** so has quit IRC
415 2020-05-05T10:30:32  *** rockhouse1 is now known as rockhouse
416 2020-05-05T10:30:50  *** ctrlbreak_MAD has quit IRC
417 2020-05-05T10:32:51  *** so has joined #bitcoin-core-dev
418 2020-05-05T10:55:32  *** jonatack_ has joined #bitcoin-core-dev
419 2020-05-05T10:55:49  *** frogar has quit IRC
420 2020-05-05T10:58:28  *** frogar has joined #bitcoin-core-dev
421 2020-05-05T10:58:43  *** jonatack has quit IRC
422 2020-05-05T11:00:43  *** cryptapus_ is now known as cryptapus
423 2020-05-05T11:02:34  *** Chris_Stewart_5 has joined #bitcoin-core-dev
424 2020-05-05T11:04:16  *** IGHOR has quit IRC
425 2020-05-05T11:05:36  *** IGHOR has joined #bitcoin-core-dev
426 2020-05-05T11:11:17  *** AaronvanW has quit IRC
427 2020-05-05T11:13:14  *** frogar has quit IRC
428 2020-05-05T11:13:23  *** AaronvanW has joined #bitcoin-core-dev
429 2020-05-05T11:17:30  *** Dean_Guss has joined #bitcoin-core-dev
430 2020-05-05T11:19:23  *** DeanWeen has quit IRC
431 2020-05-05T11:30:40  *** bitcoin-git has joined #bitcoin-core-dev
432 2020-05-05T11:30:40  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18885: contrib: Move optimize-pngs.py script to the maintainer repo (master...2005-noOptPng) https://github.com/bitcoin/bitcoin/pull/18885
433 2020-05-05T11:30:40  *** frogar has joined #bitcoin-core-dev
434 2020-05-05T11:30:41  *** bitcoin-git has left #bitcoin-core-dev
435 2020-05-05T11:36:45  *** devindia has quit IRC
436 2020-05-05T11:38:05  *** Technoprenerd has quit IRC
437 2020-05-05T11:42:15  *** Technoprenerd has joined #bitcoin-core-dev
438 2020-05-05T12:00:01  *** ironmarx has quit IRC
439 2020-05-05T12:04:04  *** promag__ has quit IRC
440 2020-05-05T12:12:10  *** Homelander has joined #bitcoin-core-dev
441 2020-05-05T12:33:20  *** Highway62 has joined #bitcoin-core-dev
442 2020-05-05T12:33:28  *** bitcoin-git has joined #bitcoin-core-dev
443 2020-05-05T12:33:29  <bitcoin-git> [bitcoin] luke-jr closed pull request #18880: [0.20] wallet: Add BlockUntilSyncedToCurrentChain to dumpwallet (0.20...pr18671-0.20) https://github.com/bitcoin/bitcoin/pull/18880
444 2020-05-05T12:33:30  *** bitcoin-git has left #bitcoin-core-dev
445 2020-05-05T12:33:35  *** molakala has joined #bitcoin-core-dev
446 2020-05-05T12:33:57  *** dviola has quit IRC
447 2020-05-05T12:34:01  *** Highway62 has quit IRC
448 2020-05-05T12:34:15  *** Highway61 has quit IRC
449 2020-05-05T12:34:55  *** Highway61 has joined #bitcoin-core-dev
450 2020-05-05T12:37:40  *** promag has joined #bitcoin-core-dev
451 2020-05-05T12:42:05  *** Homelander has quit IRC
452 2020-05-05T12:42:08  *** promag has quit IRC
453 2020-05-05T12:51:57  *** bitcoin-git has joined #bitcoin-core-dev
454 2020-05-05T12:51:57  <bitcoin-git> [bitcoin] vasild opened pull request #18887: build: enable -Werror=gnu (master...add_Werror_gnu) https://github.com/bitcoin/bitcoin/pull/18887
455 2020-05-05T12:51:58  *** bitcoin-git has left #bitcoin-core-dev
456 2020-05-05T12:55:45  *** josef641 has joined #bitcoin-core-dev
457 2020-05-05T13:05:28  *** brakmic has joined #bitcoin-core-dev
458 2020-05-05T13:35:22  *** jonatack_ has quit IRC
459 2020-05-05T13:35:49  *** jonatack has joined #bitcoin-core-dev
460 2020-05-05T13:51:21  *** promag___ is now known as promag
461 2020-05-05T13:51:28  <promag> sipa: mind taking a look at #18863?
462 2020-05-05T13:51:30  <gribble> https://github.com/bitcoin/bitcoin/issues/18863 | refactor: Drop unused CScriptVisitor return type by promag · Pull Request #18863 · bitcoin/bitcoin · GitHub
463 2020-05-05T13:54:13  *** bitcoin-git has joined #bitcoin-core-dev
464 2020-05-05T13:54:13  <bitcoin-git> [bitcoin] promag closed pull request #18246: wip: gui: Drop connectSlotsByName usage (master...2020-03-drop-connectslotsbyName) https://github.com/bitcoin/bitcoin/pull/18246
465 2020-05-05T13:54:25  *** bitcoin-git has left #bitcoin-core-dev
466 2020-05-05T14:04:10  *** kristapsk has quit IRC
467 2020-05-05T14:04:35  *** kristapsk has joined #bitcoin-core-dev
468 2020-05-05T14:08:11  *** bitcoin-git has joined #bitcoin-core-dev
469 2020-05-05T14:08:13  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ec79b5f86b22...52ce396b2a47
470 2020-05-05T14:08:13  <bitcoin-git> bitcoin/master 708e3c7 fanquake: valgrind: remove rest_blockhash_by_height suppression
471 2020-05-05T14:08:14  <bitcoin-git> bitcoin/master d7120f7 fanquake: valgrind : remove duplicate BCLog::Logger suppression
472 2020-05-05T14:08:15  <bitcoin-git> bitcoin/master 52ce396 MarcoFalke: Merge #18879: valgrind: remove outdated suppressions
473 2020-05-05T14:08:17  *** bitcoin-git has left #bitcoin-core-dev
474 2020-05-05T14:08:28  *** Landryl has quit IRC
475 2020-05-05T14:08:31  *** bitcoin-git has joined #bitcoin-core-dev
476 2020-05-05T14:08:31  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18879: valgrind: remove outdated suppressions (master...remove_outdated_supp) https://github.com/bitcoin/bitcoin/pull/18879
477 2020-05-05T14:08:32  *** bitcoin-git has left #bitcoin-core-dev
478 2020-05-05T14:10:05  *** mdunnio has joined #bitcoin-core-dev
479 2020-05-05T14:10:15  *** Landryl has joined #bitcoin-core-dev
480 2020-05-05T14:15:41  *** Daisy5Parker has joined #bitcoin-core-dev
481 2020-05-05T14:22:14  *** Daisy5Parker has quit IRC
482 2020-05-05T14:26:27  *** grubles has quit IRC
483 2020-05-05T14:26:31  *** go121212 has quit IRC
484 2020-05-05T14:31:01  *** go1111111 has joined #bitcoin-core-dev
485 2020-05-05T14:40:26  *** Chris_Stewart_5 has quit IRC
486 2020-05-05T14:41:42  *** Chris_Stewart_5 has joined #bitcoin-core-dev
487 2020-05-05T14:42:08  *** bitcoin-git has joined #bitcoin-core-dev
488 2020-05-05T14:42:08  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/52ce396b2a47...fbd522721cb8
489 2020-05-05T14:42:08  <bitcoin-git> bitcoin/master fa13090 MarcoFalke: contrib: Remove optimize-pngs.py script, which lives in the maintainer rep...
490 2020-05-05T14:42:09  <bitcoin-git> bitcoin/master fbd5227 MarcoFalke: Merge #18885: contrib: Move optimize-pngs.py script to the maintainer repo...
491 2020-05-05T14:42:19  *** bitcoin-git has left #bitcoin-core-dev
492 2020-05-05T14:42:38  *** bitcoin-git has joined #bitcoin-core-dev
493 2020-05-05T14:42:38  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18885: contrib: Move optimize-pngs.py script to the maintainer repo (master...2005-noOptPng) https://github.com/bitcoin/bitcoin/pull/18885
494 2020-05-05T14:42:39  *** bitcoin-git has left #bitcoin-core-dev
495 2020-05-05T14:53:06  *** emilengler has quit IRC
496 2020-05-05T15:00:02  *** josef641 has quit IRC
497 2020-05-05T15:02:17  *** michaelfolkson has joined #bitcoin-core-dev
498 2020-05-05T15:21:11  *** geek00l has joined #bitcoin-core-dev
499 2020-05-05T15:25:34  *** promag_ has joined #bitcoin-core-dev
500 2020-05-05T15:27:38  *** justanotheruser has quit IRC
501 2020-05-05T15:27:38  *** Deacyde has quit IRC
502 2020-05-05T15:29:54  *** promag_ has quit IRC
503 2020-05-05T15:30:47  *** bitcoin-git has joined #bitcoin-core-dev
504 2020-05-05T15:30:47  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18888: test: Remove RPCOverloadWrapper boilerplate (master...2005-testNoBoilerplate) https://github.com/bitcoin/bitcoin/pull/18888
505 2020-05-05T15:30:48  *** bitcoin-git has left #bitcoin-core-dev
506 2020-05-05T15:43:36  *** Deacyde has joined #bitcoin-core-dev
507 2020-05-05T15:44:10  *** justanotheruser has joined #bitcoin-core-dev
508 2020-05-05T15:51:43  *** Daren32Bruen has joined #bitcoin-core-dev
509 2020-05-05T15:53:23  *** michaelfolkson has quit IRC
510 2020-05-05T15:57:41  *** proofofkeags has joined #bitcoin-core-dev
511 2020-05-05T16:02:21  *** Daren32Bruen has quit IRC
512 2020-05-05T16:03:31  *** Jalon40Moore has joined #bitcoin-core-dev
513 2020-05-05T16:09:14  *** michaelfolkson has joined #bitcoin-core-dev
514 2020-05-05T16:10:14  *** Jalon40Moore has quit IRC
515 2020-05-05T16:19:51  *** vasild_ has joined #bitcoin-core-dev
516 2020-05-05T16:23:03  *** vasild has quit IRC
517 2020-05-05T16:23:04  *** vasild_ is now known as vasild
518 2020-05-05T16:29:56  *** emilengler has joined #bitcoin-core-dev
519 2020-05-05T16:43:54  *** molz_ has quit IRC
520 2020-05-05T16:55:16  *** promag_ has joined #bitcoin-core-dev
521 2020-05-05T16:59:34  *** promag_ has quit IRC
522 2020-05-05T17:05:09  *** mol has joined #bitcoin-core-dev
523 2020-05-05T17:08:37  *** geek00l has quit IRC
524 2020-05-05T17:11:16  *** promag_ has joined #bitcoin-core-dev
525 2020-05-05T17:30:39  *** mol has quit IRC
526 2020-05-05T17:33:16  *** mol has joined #bitcoin-core-dev
527 2020-05-05T17:50:12  *** tryphe_ has joined #bitcoin-core-dev
528 2020-05-05T17:52:14  *** tryphe has quit IRC
529 2020-05-05T17:54:43  *** vasild has quit IRC
530 2020-05-05T17:57:04  *** vasild has joined #bitcoin-core-dev
531 2020-05-05T18:00:01  *** bitcoin-git has joined #bitcoin-core-dev
532 2020-05-05T18:00:01  <bitcoin-git> [bitcoin] robot-visions opened pull request #18890: test: disconnect_nodes should warn if nodes were already disconnected (master...disconnect-nodes) https://github.com/bitcoin/bitcoin/pull/18890
533 2020-05-05T18:00:12  *** bitcoin-git has left #bitcoin-core-dev
534 2020-05-05T18:19:56  *** promag_ has quit IRC
535 2020-05-05T18:21:59  *** dougvann has joined #bitcoin-core-dev
536 2020-05-05T18:33:10  *** Technoprenerd has quit IRC
537 2020-05-05T18:34:46  *** Technoprenerd has joined #bitcoin-core-dev
538 2020-05-05T18:43:42  *** emilengler has quit IRC
539 2020-05-05T18:53:54  *** AaronvanW has quit IRC
540 2020-05-05T19:20:37  *** lightlike has joined #bitcoin-core-dev
541 2020-05-05T19:22:29  *** AaronvanW has joined #bitcoin-core-dev
542 2020-05-05T19:28:03  *** Talkless has quit IRC
543 2020-05-05T19:34:04  *** u0_a180 has joined #bitcoin-core-dev
544 2020-05-05T19:35:07  *** u0_a180 has quit IRC
545 2020-05-05T20:01:26  *** michaelfolkson has quit IRC
546 2020-05-05T20:06:03  <luke-jr> anyone ever seen this before? /usr/include/db4.8/db_cxx.h:59:10: fatal error: iostream.h: No such file or directory
547 2020-05-05T20:07:18  *** robot-visions has joined #bitcoin-core-dev
548 2020-05-05T20:09:15  *** dgenr8 has quit IRC
549 2020-05-05T20:09:46  *** Chris_Stewart_5 has quit IRC
550 2020-05-05T20:16:31  *** promag_ has joined #bitcoin-core-dev
551 2020-05-05T20:17:29  *** harrigan has joined #bitcoin-core-dev
552 2020-05-05T20:19:50  *** Chris_Stewart_5 has joined #bitcoin-core-dev
553 2020-05-05T20:22:14  *** dgenr8 has joined #bitcoin-core-dev
554 2020-05-05T20:30:43  *** braydonf has quit IRC
555 2020-05-05T20:32:25  *** Highway62 has joined #bitcoin-core-dev
556 2020-05-05T20:32:37  *** Highway61 has quit IRC
557 2020-05-05T20:32:38  *** Highway62 is now known as Highway61
558 2020-05-05T20:32:53  *** mol has quit IRC
559 2020-05-05T20:33:51  *** Highway61 has quit IRC
560 2020-05-05T20:34:19  *** Highway61 has joined #bitcoin-core-dev
561 2020-05-05T20:35:25  *** mol has joined #bitcoin-core-dev
562 2020-05-05T20:36:33  *** braydonf has joined #bitcoin-core-dev
563 2020-05-05T20:37:49  <jonatack> luke-jr: i may have seen that once or twice...
564 2020-05-05T20:38:07  <luke-jr> hmm, looks like bdb got installed without C++ support, yet still installs the header :x
565 2020-05-05T20:38:40  <jonatack> testing #18870 rn with bdb 5.3
566 2020-05-05T20:38:43  <gribble> https://github.com/bitcoin/bitcoin/issues/18870 | build: Allow BDB between 4.7 and 5.3 without --with-incompatible-bdb by achow101 · Pull Request #18870 · bitcoin/bitcoin · GitHub
567 2020-05-05T21:00:01  *** dougvann has quit IRC
568 2020-05-05T21:01:18  *** roconnor has joined #bitcoin-core-dev
569 2020-05-05T21:08:15  *** hsmiths has quit IRC
570 2020-05-05T21:18:53  *** nielsonm has joined #bitcoin-core-dev
571 2020-05-05T21:21:49  *** davec has quit IRC
572 2020-05-05T21:29:13  *** Zenton has quit IRC
573 2020-05-05T21:32:52  *** promag_ has quit IRC
574 2020-05-05T21:33:27  *** Zenton has joined #bitcoin-core-dev
575 2020-05-05T21:34:10  *** promag_ has joined #bitcoin-core-dev
576 2020-05-05T21:52:56  *** davec has joined #bitcoin-core-dev
577 2020-05-05T22:03:36  *** promag_ has quit IRC
578 2020-05-05T22:08:05  *** promag_ has joined #bitcoin-core-dev
579 2020-05-05T22:08:59  *** mol_ has joined #bitcoin-core-dev
580 2020-05-05T22:10:49  *** promag_ has quit IRC
581 2020-05-05T22:11:50  *** mol has quit IRC
582 2020-05-05T22:13:01  *** promag_ has joined #bitcoin-core-dev
583 2020-05-05T22:18:36  *** kristapsk_ has joined #bitcoin-core-dev
584 2020-05-05T22:20:52  *** kristapsk has quit IRC
585 2020-05-05T22:45:53  *** go11111111111 has joined #bitcoin-core-dev
586 2020-05-05T22:48:14  *** go1111111 has quit IRC
587 2020-05-05T22:51:21  *** dfmb has joined #bitcoin-core-dev
588 2020-05-05T22:53:11  *** brakmic has quit IRC
589 2020-05-05T22:54:23  *** Emcy has quit IRC
590 2020-05-05T22:55:00  *** Guyver2 has quit IRC
591 2020-05-05T22:56:33  *** Emcy has joined #bitcoin-core-dev
592 2020-05-05T23:00:16  *** promag_ has quit IRC
593 2020-05-05T23:00:27  *** Anduck_ is now known as Anduck
594 2020-05-05T23:00:48  *** promag_ has joined #bitcoin-core-dev
595 2020-05-05T23:05:47  *** promag_ has quit IRC
596 2020-05-05T23:06:13  *** justanotheruser has quit IRC
597 2020-05-05T23:10:51  *** promag_ has joined #bitcoin-core-dev
598 2020-05-05T23:19:23  *** Dean_Guss has quit IRC
599 2020-05-05T23:21:26  *** Dean_Guss has joined #bitcoin-core-dev
600 2020-05-05T23:21:29  *** justanotheruser has joined #bitcoin-core-dev
601 2020-05-05T23:26:08  *** surja795_ has joined #bitcoin-core-dev
602 2020-05-05T23:27:56  *** bitcoin-git has joined #bitcoin-core-dev
603 2020-05-05T23:27:57  <bitcoin-git> [bitcoin] promag opened pull request #18894: gui: Fix manual coin control with multiple wallets loaded (master...2019-11-fix-15725.2) https://github.com/bitcoin/bitcoin/pull/18894
604 2020-05-05T23:28:08  *** bitcoin-git has left #bitcoin-core-dev
605 2020-05-05T23:28:55  *** surja795 has quit IRC
606 2020-05-05T23:29:29  *** aj has quit IRC
607 2020-05-05T23:29:36  *** aj has joined #bitcoin-core-dev
608 2020-05-05T23:31:31  *** bitcoin-git has joined #bitcoin-core-dev
609 2020-05-05T23:31:32  <bitcoin-git> [bitcoin] promag closed pull request #17457: gui: Fix manual coin control with multiple wallets loaded (master...2019-11-fix-15725) https://github.com/bitcoin/bitcoin/pull/17457
610 2020-05-05T23:31:33  *** bitcoin-git has left #bitcoin-core-dev
611 2020-05-05T23:31:39  *** marcoagner has quit IRC
612 2020-05-05T23:34:43  *** molakala has quit IRC
613 2020-05-05T23:37:38  *** bitcoin-git has joined #bitcoin-core-dev
614 2020-05-05T23:37:39  <bitcoin-git> [bitcoin] meshcollider pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/fbd522721cb8...60091d20f9bb
615 2020-05-05T23:37:41  <bitcoin-git> bitcoin/master 2b9cba2 Russell Yanofsky: Remove CWalletTx merging logic from AddToWallet
616 2020-05-05T23:37:42  <bitcoin-git> bitcoin/master bd2fbc7 Russell Yanofsky: Get rid of unneeded CWalletTx::Init parameter
617 2020-05-05T23:37:42  <bitcoin-git> bitcoin/master 65b9d8f Russell Yanofsky: Avoid copying CWalletTx in LoadToWallet
618 2020-05-05T23:37:43  *** bitcoin-git has left #bitcoin-core-dev
619 2020-05-05T23:39:44  *** bitcoin-git has joined #bitcoin-core-dev
620 2020-05-05T23:39:44  <bitcoin-git> [bitcoin] meshcollider merged pull request #9381: Remove CWalletTx merging logic from AddToWallet (master...pr/atw-nomerge) https://github.com/bitcoin/bitcoin/pull/9381
621 2020-05-05T23:39:45  *** bitcoin-git has left #bitcoin-core-dev
622 2020-05-05T23:42:46  *** promag_ has quit IRC
623 2020-05-05T23:46:13  *** surja795_ has quit IRC
624 2020-05-05T23:46:34  *** surja795 has joined #bitcoin-core-dev
625 2020-05-05T23:47:44  *** timothy has quit IRC
626 2020-05-05T23:48:36  *** lightlike has quit IRC
627 2020-05-05T23:51:07  *** mdunnio has quit IRC
628 2020-05-05T23:53:37  *** jonatack has quit IRC
629 2020-05-05T23:55:33  *** jonatack has joined #bitcoin-core-dev