1 2020-05-11T00:00:02  *** mrdocs has quit IRC
  2 2020-05-11T00:00:10  *** jarthur has quit IRC
  3 2020-05-11T00:00:50  *** jarthur has joined #bitcoin-core-dev
  4 2020-05-11T00:07:17  *** dfmb_ has joined #bitcoin-core-dev
  5 2020-05-11T00:13:42  *** Chris_Stewart_5 has joined #bitcoin-core-dev
  6 2020-05-11T00:17:19  *** surja795_ has joined #bitcoin-core-dev
  7 2020-05-11T00:17:20  *** surja795 has quit IRC
  8 2020-05-11T00:22:17  *** mmf has joined #bitcoin-core-dev
  9 2020-05-11T00:23:49  *** jarthur has quit IRC
 10 2020-05-11T00:31:32  *** dfmb_ has quit IRC
 11 2020-05-11T00:35:37  *** manantial has quit IRC
 12 2020-05-11T00:36:58  *** bitcoin-git has joined #bitcoin-core-dev
 13 2020-05-11T00:36:58  <bitcoin-git> [bitcoin] theStack opened pull request #18940: miner: fix off-by-ones in BlockAssembler::TestPackage (master...20200511-miner-fix-off-by-one-in-test-package) https://github.com/bitcoin/bitcoin/pull/18940
 14 2020-05-11T00:37:09  *** bitcoin-git has left #bitcoin-core-dev
 15 2020-05-11T00:41:13  *** proofofkeags has quit IRC
 16 2020-05-11T00:55:41  *** mdunnio has joined #bitcoin-core-dev
 17 2020-05-11T00:58:59  *** mdunnio has quit IRC
 18 2020-05-11T01:01:19  *** Chris_Stewart_5 has quit IRC
 19 2020-05-11T01:04:06  *** Bullit has joined #bitcoin-core-dev
 20 2020-05-11T01:11:50  *** promag has quit IRC
 21 2020-05-11T01:12:04  *** promag has joined #bitcoin-core-dev
 22 2020-05-11T01:12:19  *** promag_ has joined #bitcoin-core-dev
 23 2020-05-11T01:15:53  *** promag has quit IRC
 24 2020-05-11T01:16:38  *** promag has joined #bitcoin-core-dev
 25 2020-05-11T01:18:30  *** proofofkeags has joined #bitcoin-core-dev
 26 2020-05-11T01:23:03  <yevaud> fanquake: I'd suggest someone well known reaches out to them, and amitiuttarwar is removed from the repo.
 27 2020-05-11T01:24:12  <yevaud> there's really no place for someone being told to stop contributing.
 28 2020-05-11T01:25:22  <phantomcircuit> have to agree
 29 2020-05-11T01:26:12  *** proofofkeags has quit IRC
 30 2020-05-11T01:26:48  <sipa> i don't interpret it that way; just as an encouragement to focus on more things than just "good first issue" tagged ones
 31 2020-05-11T01:33:04  *** proofofkeags has joined #bitcoin-core-dev
 32 2020-05-11T01:36:37  <luke-jr> yevaud: that's going too far… let's just make it clear we don't agree with that attitude?
 33 2020-05-11T01:39:30  <yevaud> luke-jr: perhaps. objectively the project has lost one of the very few people who have turned up and are prepared to review.
 34 2020-05-11T01:39:56  <luke-jr> yevaud: hopefully he will reconsider when he learns it was just one guy
 35 2020-05-11T01:41:27  *** promag has quit IRC
 36 2020-05-11T01:41:41  *** promag has joined #bitcoin-core-dev
 37 2020-05-11T01:41:45  *** promag_ has joined #bitcoin-core-dev
 38 2020-05-11T01:51:44  *** geeker has joined #bitcoin-core-dev
 39 2020-05-11T01:52:59  *** geeker has quit IRC
 40 2020-05-11T01:53:15  *** geeker has joined #bitcoin-core-dev
 41 2020-05-11T01:53:21  <luke-jr> I still wonder to date what happened to Diapolo :/
 42 2020-05-11T01:54:11  *** proofofkeags has quit IRC
 43 2020-05-11T01:56:17  <phantomcircuit> is the IsMineInner function still being used?
 44 2020-05-11T01:58:25  <sipa> phantomcircuit: in legacy wallets yes
 45 2020-05-11T02:13:47  *** promag_ has quit IRC
 46 2020-05-11T02:14:50  *** bitcoin-git has joined #bitcoin-core-dev
 47 2020-05-11T02:14:51  <bitcoin-git> [bitcoin] andrewtoth closed pull request #18936: validation: Persist coins cache to disk and load on startup (master...persist-coinscache) https://github.com/bitcoin/bitcoin/pull/18936
 48 2020-05-11T02:14:52  *** bitcoin-git has left #bitcoin-core-dev
 49 2020-05-11T02:24:17  <phantomcircuit> sipa, it's not feasible to generate a list of scriptpubkeys for a LegacyScriptPubKeyMan is it
 50 2020-05-11T02:27:24  <sipa> phantomcircuit: it's possible but nontrivial; for all privkeys you need P2PK, P2PKH, P2WPKH, P2SH-P2WPKH versions of it; and then add all known scripts and watch-only scripts, and filter the whole list with IsMine
 51 2020-05-11T02:27:38  <sipa> i wrote code for that once, not sure where it is
 52 2020-05-11T02:29:04  <sipa> also P2SH and P2WSH versions of all scripts, presumably
 53 2020-05-11T02:29:08  <phantomcircuit> sipa, the one i got kind of stuck (thinking about not doing) is the original multisig support
 54 2020-05-11T02:29:20  <phantomcircuit> cause we don't know the other keys in advance
 55 2020-05-11T02:29:49  <sipa> oh if you support raw multisig it's nontractible (cubic in the number of keys...)
 56 2020-05-11T02:33:23  <phantomcircuit> sipa, yeah ok thanks
 57 2020-05-11T02:39:35  *** amsudeep has quit IRC
 58 2020-05-11T02:41:24  *** mol has quit IRC
 59 2020-05-11T02:41:48  *** Highway61 has quit IRC
 60 2020-05-11T02:43:27  *** mol has joined #bitcoin-core-dev
 61 2020-05-11T02:47:10  *** bitcoin-git has joined #bitcoin-core-dev
 62 2020-05-11T02:47:11  <bitcoin-git> [bitcoin] andrewtoth opened pull request #18941: validation: Persist coins cache to disk and load on startup (master...persist-coinscache) https://github.com/bitcoin/bitcoin/pull/18941
 63 2020-05-11T02:47:12  *** bitcoin-git has left #bitcoin-core-dev
 64 2020-05-11T03:00:01  *** mmf has quit IRC
 65 2020-05-11T03:04:31  *** proofofkeags has joined #bitcoin-core-dev
 66 2020-05-11T03:08:07  *** Highway61 has joined #bitcoin-core-dev
 67 2020-05-11T03:08:59  *** surja795_ has quit IRC
 68 2020-05-11T03:21:39  *** patryk1 has joined #bitcoin-core-dev
 69 2020-05-11T03:27:05  *** sipa has quit IRC
 70 2020-05-11T04:00:08  *** Dean_Guss has quit IRC
 71 2020-05-11T04:00:11  *** DeanWeen has joined #bitcoin-core-dev
 72 2020-05-11T04:03:56  *** sipa has joined #bitcoin-core-dev
 73 2020-05-11T04:19:56  *** vasild_ has joined #bitcoin-core-dev
 74 2020-05-11T04:21:11  *** bitcoin-git has joined #bitcoin-core-dev
 75 2020-05-11T04:21:11  <bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/88d8b4e182bf...ec4d27fa8bdc
 76 2020-05-11T04:21:12  <bitcoin-git> bitcoin/master df37377 Ben Woosley: test: Fix outstanding -Wsign-compare errors
 77 2020-05-11T04:21:13  <bitcoin-git> bitcoin/master eac6a30 Ben Woosley: refactor: Rework asmap Interpret to avoid ptrdiff_t
 78 2020-05-11T04:21:13  <bitcoin-git> bitcoin/master 6853727 Ben Woosley: build: Enable -Werror=sign-compare
 79 2020-05-11T04:21:14  *** bitcoin-git has left #bitcoin-core-dev
 80 2020-05-11T04:21:36  *** proofofkeags has quit IRC
 81 2020-05-11T04:21:50  *** bitcoin-git has joined #bitcoin-core-dev
 82 2020-05-11T04:21:51  <bitcoin-git> [bitcoin] fanquake merged pull request #18216: test, build: Enable -Werror=sign-compare (master...2020-02-sign-compare) https://github.com/bitcoin/bitcoin/pull/18216
 83 2020-05-11T04:21:51  *** bitcoin-git has left #bitcoin-core-dev
 84 2020-05-11T04:23:43  *** vasild has quit IRC
 85 2020-05-11T04:23:44  *** vasild_ is now known as vasild
 86 2020-05-11T04:25:15  *** achow101 has quit IRC
 87 2020-05-11T04:26:35  *** achow101 has joined #bitcoin-core-dev
 88 2020-05-11T04:30:11  *** AaronvanW has quit IRC
 89 2020-05-11T04:36:00  *** mol_ has joined #bitcoin-core-dev
 90 2020-05-11T04:39:06  *** mol has quit IRC
 91 2020-05-11T04:58:27  *** proofofkeags has joined #bitcoin-core-dev
 92 2020-05-11T05:00:55  *** sipa has quit IRC
 93 2020-05-11T05:03:14  *** proofofkeags has quit IRC
 94 2020-05-11T05:06:11  *** sipa has joined #bitcoin-core-dev
 95 2020-05-11T05:11:10  *** theStack has joined #bitcoin-core-dev
 96 2020-05-11T05:12:32  *** justanotheruser has quit IRC
 97 2020-05-11T05:12:33  *** Mercury_Vapor has quit IRC
 98 2020-05-11T05:13:18  *** Mercury_Vapor has joined #bitcoin-core-dev
 99 2020-05-11T05:15:02  *** promag_ has joined #bitcoin-core-dev
100 2020-05-11T05:20:01  *** promag_ has quit IRC
101 2020-05-11T05:39:06  *** molz_ has joined #bitcoin-core-dev
102 2020-05-11T05:42:25  *** mol_ has quit IRC
103 2020-05-11T05:42:35  *** jeremyrubin has joined #bitcoin-core-dev
104 2020-05-11T06:00:01  *** patryk1 has quit IRC
105 2020-05-11T06:02:18  *** mol_ has joined #bitcoin-core-dev
106 2020-05-11T06:05:05  *** molz_ has quit IRC
107 2020-05-11T06:14:46  *** TheHoliestRoger has quit IRC
108 2020-05-11T06:15:40  *** TheHoliestRoger has joined #bitcoin-core-dev
109 2020-05-11T06:20:08  *** molz_ has joined #bitcoin-core-dev
110 2020-05-11T06:21:59  *** SRV_DW20 has joined #bitcoin-core-dev
111 2020-05-11T06:23:21  *** mol_ has quit IRC
112 2020-05-11T06:28:43  *** proofofkeags has joined #bitcoin-core-dev
113 2020-05-11T06:32:28  *** promag_ has joined #bitcoin-core-dev
114 2020-05-11T06:33:34  *** proofofkeags has quit IRC
115 2020-05-11T06:34:01  *** manantial has joined #bitcoin-core-dev
116 2020-05-11T06:37:08  *** promag_ has quit IRC
117 2020-05-11T07:03:33  *** justanotheruser has joined #bitcoin-core-dev
118 2020-05-11T07:46:10  *** marcoagner has joined #bitcoin-core-dev
119 2020-05-11T07:50:39  *** bitcoin-git has joined #bitcoin-core-dev
120 2020-05-11T07:50:39  <bitcoin-git> [bitcoin] fanquake opened pull request #18942: doc: Increase minimum required GCC to 5.1 (master...gcc_5_1_for_codecvt) https://github.com/bitcoin/bitcoin/pull/18942
121 2020-05-11T07:50:40  *** bitcoin-git has left #bitcoin-core-dev
122 2020-05-11T07:57:06  *** Guyver2 has joined #bitcoin-core-dev
123 2020-05-11T08:05:05  *** promag_ has joined #bitcoin-core-dev
124 2020-05-11T08:05:34  *** CubicEarth has quit IRC
125 2020-05-11T08:08:11  *** promag has quit IRC
126 2020-05-11T08:08:20  *** CubicEarth has joined #bitcoin-core-dev
127 2020-05-11T08:09:38  *** tynes_ has joined #bitcoin-core-dev
128 2020-05-11T08:09:44  *** promag_ has quit IRC
129 2020-05-11T08:09:48  *** da2ce7_ has joined #bitcoin-core-dev
130 2020-05-11T08:10:26  *** MarcoFalke_2 has joined #bitcoin-core-dev
131 2020-05-11T08:10:26  *** molz_ has quit IRC
132 2020-05-11T08:10:39  *** bzb has joined #bitcoin-core-dev
133 2020-05-11T08:10:48  *** molz_ has joined #bitcoin-core-dev
134 2020-05-11T08:11:28  *** nehan_ has joined #bitcoin-core-dev
135 2020-05-11T08:11:32  *** tecnovert has joined #bitcoin-core-dev
136 2020-05-11T08:11:56  *** bzb has quit IRC
137 2020-05-11T08:12:35  *** Henry151_ has joined #bitcoin-core-dev
138 2020-05-11T08:13:21  *** mol has joined #bitcoin-core-dev
139 2020-05-11T08:14:22  *** waxwing_ has joined #bitcoin-core-dev
140 2020-05-11T08:14:34  *** TD--Linux has joined #bitcoin-core-dev
141 2020-05-11T08:15:30  *** murr5y has joined #bitcoin-core-dev
142 2020-05-11T08:15:47  *** molz_ has quit IRC
143 2020-05-11T08:15:53  *** nehan has quit IRC
144 2020-05-11T08:15:53  *** murr4y has quit IRC
145 2020-05-11T08:15:53  *** MarcoFalke has quit IRC
146 2020-05-11T08:15:53  *** tecnover1 has quit IRC
147 2020-05-11T08:15:53  *** nsh has quit IRC
148 2020-05-11T08:15:53  *** Henry151 has quit IRC
149 2020-05-11T08:15:53  *** cornfeedhobo has quit IRC
150 2020-05-11T08:15:53  *** tynes has quit IRC
151 2020-05-11T08:15:53  *** waxwing has quit IRC
152 2020-05-11T08:15:53  *** TD-Linux has quit IRC
153 2020-05-11T08:15:53  *** da2ce7 has quit IRC
154 2020-05-11T08:21:04  *** nsh has joined #bitcoin-core-dev
155 2020-05-11T08:21:29  *** cornfeedhobo has joined #bitcoin-core-dev
156 2020-05-11T08:22:33  *** Talkless has joined #bitcoin-core-dev
157 2020-05-11T08:29:41  *** proofofkeags has joined #bitcoin-core-dev
158 2020-05-11T08:31:51  *** dfmb_ has joined #bitcoin-core-dev
159 2020-05-11T08:34:46  *** proofofkeags has quit IRC
160 2020-05-11T08:38:01  *** kljasdfvv has joined #bitcoin-core-dev
161 2020-05-11T08:39:48  *** nsh has quit IRC
162 2020-05-11T08:39:48  *** nsh has joined #bitcoin-core-dev
163 2020-05-11T08:40:40  *** Guyver2_ has joined #bitcoin-core-dev
164 2020-05-11T08:43:20  *** Guyver2 has quit IRC
165 2020-05-11T08:43:51  *** timothy has joined #bitcoin-core-dev
166 2020-05-11T08:47:04  *** manantial has quit IRC
167 2020-05-11T08:47:57  *** promag has joined #bitcoin-core-dev
168 2020-05-11T08:50:12  *** promag_ has joined #bitcoin-core-dev
169 2020-05-11T09:00:02  *** SRV_DW20 has quit IRC
170 2020-05-11T09:06:53  *** murr5y has left #bitcoin-core-dev
171 2020-05-11T09:08:13  *** murr4y has joined #bitcoin-core-dev
172 2020-05-11T09:12:53  *** manantial has joined #bitcoin-core-dev
173 2020-05-11T09:22:17  *** andrea has joined #bitcoin-core-dev
174 2020-05-11T09:22:42  *** andrea is now known as Guest85500
175 2020-05-11T09:23:13  *** per has joined #bitcoin-core-dev
176 2020-05-11T09:29:43  *** promag_ has quit IRC
177 2020-05-11T09:36:40  *** promag_ has joined #bitcoin-core-dev
178 2020-05-11T09:41:38  *** emilengler has joined #bitcoin-core-dev
179 2020-05-11T09:47:51  *** proofofkeags has joined #bitcoin-core-dev
180 2020-05-11T09:49:30  *** kljasdfvv has quit IRC
181 2020-05-11T09:50:45  *** kljasdfvv has joined #bitcoin-core-dev
182 2020-05-11T09:52:19  *** proofofkeags has quit IRC
183 2020-05-11T10:02:36  *** kljasdfvv has quit IRC
184 2020-05-11T10:03:54  *** kljasdfvv has joined #bitcoin-core-dev
185 2020-05-11T10:04:21  *** waxwing_ has left #bitcoin-core-dev
186 2020-05-11T10:04:58  *** waxwing has joined #bitcoin-core-dev
187 2020-05-11T10:10:37  *** Zenton has quit IRC
188 2020-05-11T10:10:58  *** Zenton has joined #bitcoin-core-dev
189 2020-05-11T10:11:01  *** surja795 has joined #bitcoin-core-dev
190 2020-05-11T10:23:31  *** bitdex has quit IRC
191 2020-05-11T10:24:02  *** bitdex has joined #bitcoin-core-dev
192 2020-05-11T10:25:14  *** surja795 has quit IRC
193 2020-05-11T10:25:50  *** surja795 has joined #bitcoin-core-dev
194 2020-05-11T10:30:12  *** surja795 has quit IRC
195 2020-05-11T11:01:36  *** Chris_Stewart_5 has joined #bitcoin-core-dev
196 2020-05-11T11:02:00  *** Mercury_Vapor has quit IRC
197 2020-05-11T11:02:26  *** Mercury_Vapor has joined #bitcoin-core-dev
198 2020-05-11T11:17:44  *** Dean_Guss has joined #bitcoin-core-dev
199 2020-05-11T11:19:23  *** DeanWeen has quit IRC
200 2020-05-11T11:23:09  *** TD--Linux has quit IRC
201 2020-05-11T11:23:10  *** TD--Linux has joined #bitcoin-core-dev
202 2020-05-11T11:23:16  *** TD--Linux is now known as TD-Linux
203 2020-05-11T11:24:05  *** surja795 has joined #bitcoin-core-dev
204 2020-05-11T11:28:47  *** surja795 has quit IRC
205 2020-05-11T11:29:09  *** Dean_Guss has quit IRC
206 2020-05-11T11:39:44  *** promag has quit IRC
207 2020-05-11T11:46:30  *** kristapsk has quit IRC
208 2020-05-11T11:47:29  *** kristapsk has joined #bitcoin-core-dev
209 2020-05-11T11:48:47  *** promag has joined #bitcoin-core-dev
210 2020-05-11T11:48:52  *** proofofkeags has joined #bitcoin-core-dev
211 2020-05-11T11:52:54  *** proofofkeags has quit IRC
212 2020-05-11T11:53:07  *** promag has quit IRC
213 2020-05-11T11:54:31  *** Motorka has joined #bitcoin-core-dev
214 2020-05-11T11:54:32  <wumpus> FWIW I completely agree with amit
215 2020-05-11T11:55:33  <wumpus> she's not telling to stop contributing, just that at some point you might want to move on from 'good first issues' and give new users a chance at them
216 2020-05-11T11:55:56  <wumpus> it definitely wasn't worded in a mean or harmful way
217 2020-05-11T11:56:57  *** Motorka has left #bitcoin-core-dev
218 2020-05-11T11:57:56  <wumpus> that brakmic interpreted it the wrong way sucks though, but, calling for "removing people from the repository" for this really goes too far
219 2020-05-11T11:58:35  *** AaronvanW has joined #bitcoin-core-dev
220 2020-05-11T11:59:11  <wumpus> please leave the project yourself if you want things to work that way
221 2020-05-11T12:00:01  *** Guest85500 has quit IRC
222 2020-05-11T12:03:19  *** Aaronvan_ has joined #bitcoin-core-dev
223 2020-05-11T12:06:46  *** AaronvanW has quit IRC
224 2020-05-11T12:10:45  *** surja795 has joined #bitcoin-core-dev
225 2020-05-11T12:15:27  *** surja795 has quit IRC
226 2020-05-11T12:18:45  <wumpus> I really want to push forward with 0.20.0 so I'm going to triage things labeled 0.20.0 somewhat more strictly
227 2020-05-11T12:22:24  *** LaserShark has joined #bitcoin-core-dev
228 2020-05-11T12:29:32  *** AaronvanW has joined #bitcoin-core-dev
229 2020-05-11T12:29:42  *** promag has joined #bitcoin-core-dev
230 2020-05-11T12:29:58  *** ctrlbreak has quit IRC
231 2020-05-11T12:30:25  *** ctrlbreak has joined #bitcoin-core-dev
232 2020-05-11T12:32:33  *** surja795 has joined #bitcoin-core-dev
233 2020-05-11T12:32:36  *** Aaronvan_ has quit IRC
234 2020-05-11T12:34:26  *** promag has quit IRC
235 2020-05-11T12:35:09  *** mol_ has joined #bitcoin-core-dev
236 2020-05-11T12:35:47  *** Motorka has joined #bitcoin-core-dev
237 2020-05-11T12:35:58  *** Motorka has left #bitcoin-core-dev
238 2020-05-11T12:37:21  *** surja795 has quit IRC
239 2020-05-11T12:37:25  *** mol has quit IRC
240 2020-05-11T12:39:07  <jonatack> I passed a similar message to brakmic a couple of weeks ago by private IRC discussion. It went very well and he came out of it with a noticeable commitment to reviewing other contributors' work, where he was seeing new opportunities to contribute off the beaten path. I reckon one further private discussion would have resolved this completely and wish I had done that.
241 2020-05-11T12:41:50  <fjahr> That's a great approach jonatack
242 2020-05-11T12:41:56  <fjahr> Amiti's intentions were only positive, absolutely, and removing her from the repo is out of the question. But I have to say I can also feel for brakmic that this must have been demoralizing because he did other things like reviews as jon said and most of his "good first issue" PRs were ~6 months old. If nobody took them by then I think it's fair to assume that maybe they were not so beginner friendly? Amiti's
243 2020-05-11T12:41:56  <fjahr> post also got a lot of positive reactions, so he must have felt isolated at that moment.
244 2020-05-11T12:42:09  <fjahr> I think more or less what Marco said in the issue: If beginners think there are not enough "good first issue" issues then we just need to create more. It's not like there is a lack of opportunities in the codebase, beginners just need guidance to find them. I also think we should encourage reviewing more as a way to get started. Traditionally reviewing tickets is more a "senior dev" thing and so many beginners
245 2020-05-11T12:42:09  <fjahr> seem to think they need to get something merged first before they can be a reviewer. We can see it in the review club too: people say they reviewed the PR and can participate in the discussion, yet don't seem to have the courage to give a Concept ACK.
246 2020-05-11T12:50:50  *** fox2p has joined #bitcoin-core-dev
247 2020-05-11T12:52:11  <wumpus> I think it's good to reach out to brakmic in any case
248 2020-05-11T12:52:21  *** fox2p has quit IRC
249 2020-05-11T12:52:38  *** foxp2 has joined #bitcoin-core-dev
250 2020-05-11T12:55:11  <wumpus> I very much understand how stressful it is to do PRs to bitcoin core in the first place, and this was probably the last straw for him
251 2020-05-11T12:59:14  *** geeker has quit IRC
252 2020-05-11T12:59:25  *** bitcoin-git has joined #bitcoin-core-dev
253 2020-05-11T12:59:25  <bitcoin-git> [bitcoin] laanwj merged pull request #18748: [0.20] rc2 Backports (0.20...0_20_rc2_backports) https://github.com/bitcoin/bitcoin/pull/18748
254 2020-05-11T12:59:27  *** bitcoin-git has left #bitcoin-core-dev
255 2020-05-11T12:59:50  *** geeker has joined #bitcoin-core-dev
256 2020-05-11T13:00:18  *** foxp2 has quit IRC
257 2020-05-11T13:04:25  *** geeker has quit IRC
258 2020-05-11T13:08:53  *** promag__ has joined #bitcoin-core-dev
259 2020-05-11T13:08:54  *** promag_ has quit IRC
260 2020-05-11T13:09:51  *** molakala has joined #bitcoin-core-dev
261 2020-05-11T13:12:12  *** bitcoin-git has joined #bitcoin-core-dev
262 2020-05-11T13:12:13  <bitcoin-git> [bitcoin] laanwj opened pull request #18945: build: Ensure source tarball has leading directory name (0.20...2020_11_0.20_tarball_prefix) https://github.com/bitcoin/bitcoin/pull/18945
263 2020-05-11T13:12:13  *** bitcoin-git has left #bitcoin-core-dev
264 2020-05-11T13:15:39  *** foxp2 has joined #bitcoin-core-dev
265 2020-05-11T13:15:55  *** foxp2 has quit IRC
266 2020-05-11T13:19:37  <instagibbs> She knows full well how it is to be a new contributor, I'm certain it's miscommunication. Let's be extra sensitive to newcomers!
267 2020-05-11T13:19:59  *** foxp2 has joined #bitcoin-core-dev
268 2020-05-11T13:30:39  *** promag has joined #bitcoin-core-dev
269 2020-05-11T13:30:46  *** surja795 has joined #bitcoin-core-dev
270 2020-05-11T13:31:55  *** LaserShark has quit IRC
271 2020-05-11T13:33:54  <wumpus> agreed
272 2020-05-11T13:35:37  *** surja795 has quit IRC
273 2020-05-11T13:37:51  *** foxp2 has quit IRC
274 2020-05-11T13:40:48  *** foxp2 has joined #bitcoin-core-dev
275 2020-05-11T13:41:43  *** afk11` has quit IRC
276 2020-05-11T13:42:31  *** afk11` has joined #bitcoin-core-dev
277 2020-05-11T13:48:30  *** tss1 has joined #bitcoin-core-dev
278 2020-05-11T13:49:41  *** proofofkeags has joined #bitcoin-core-dev
279 2020-05-11T13:53:08  <jonatack> reached out via keybase
280 2020-05-11T13:54:09  *** proofofkeags has quit IRC
281 2020-05-11T13:54:35  *** dviola has joined #bitcoin-core-dev
282 2020-05-11T13:58:45  *** mdunnio has joined #bitcoin-core-dev
283 2020-05-11T14:01:26  *** mdunnio has quit IRC
284 2020-05-11T14:01:42  *** bitcoin-git has joined #bitcoin-core-dev
285 2020-05-11T14:01:43  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18946: rpcwallet: Replace boost::optional<T>::emplace with simple assignment of T{} (master...2005-rpcWalletOptional) https://github.com/bitcoin/bitcoin/pull/18946
286 2020-05-11T14:01:43  *** bitcoin-git has left #bitcoin-core-dev
287 2020-05-11T14:02:03  *** mdunnio has joined #bitcoin-core-dev
288 2020-05-11T14:11:02  *** bitcoin-git has joined #bitcoin-core-dev
289 2020-05-11T14:11:03  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ec4d27fa8bdc...f71a3a882974
290 2020-05-11T14:11:03  <bitcoin-git> bitcoin/master 872aa25 Martin Zumsande: doc: add c++17-enable to fuzzing instructions
291 2020-05-11T14:11:04  <bitcoin-git> bitcoin/master f71a3a8 MarcoFalke: Merge #18939: doc: add c++17-enable flag to fuzzing instructions
292 2020-05-11T14:11:05  *** bitcoin-git has left #bitcoin-core-dev
293 2020-05-11T14:11:22  *** bitcoin-git has joined #bitcoin-core-dev
294 2020-05-11T14:11:23  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18939: doc: add c++17-enable flag to fuzzing instructions (master...202005_fuzz_doc) https://github.com/bitcoin/bitcoin/pull/18939
295 2020-05-11T14:11:24  *** bitcoin-git has left #bitcoin-core-dev
296 2020-05-11T14:20:23  *** promag__ has quit IRC
297 2020-05-11T14:22:22  *** promag_ has joined #bitcoin-core-dev
298 2020-05-11T14:23:34  <provoostenator> It's a pain to navigate to a milestone in Github, so I'll just spam this link, also a reminder to self: https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.20.0
299 2020-05-11T14:24:46  <wumpus> what i tend to do is click the "0.20.0" next to a PR, though that ends up here (both issues and PRs view): https://github.com/bitcoin/bitcoin/milestone/42
300 2020-05-11T14:30:02  *** mol_ has quit IRC
301 2020-05-11T14:30:54  *** promag has quit IRC
302 2020-05-11T14:32:13  <theStack> Talking from the perspective of someone who also started contributing to core not too long ago, I can confirm that in the very beginning
303 2020-05-11T14:32:16  <theStack> 1) it can be quite frustrating to repeatedly see that an new interesting looking "good first issue" is taken fast; those are really
304 2020-05-11T14:32:19  <theStack> _awesome_ onboarding instruments, and it kind of feels disappointing and is against its basic idea of educating if they are tackled
305 2020-05-11T14:32:22  <theStack> by people which are already way more advanced (not talking about the many months old ones issues here though)
306 2020-05-11T14:32:28  <theStack> 2) there is a strong mindset of "i have to contribute first before i do anything else", as one might feel the need to
307 2020-05-11T14:32:31  <theStack> first get some reputation, as otherwise one may isn't taken seriously; that's why maybe even more people were kind of
308 2020-05-11T14:32:34  <theStack> waiting for new "good first issues" (there is even a twitter bot for it!) and Amiti's post did get so many thumbs up.
309 2020-05-11T14:32:37  <theStack> I think that this was in no way meant rude by Amiti. I'd even go so far and say it can be seen as a compliment,
310 2020-05-11T14:32:40  <theStack> like "you have advanced to a level where good first issues are too easy for you".
311 2020-05-11T14:32:54  <theStack> I'm glad to see how fast the reactions were and how everyone tries to clear the issue. A sign for a strong
312 2020-05-11T14:32:57  <theStack> community actually. Of course, I also hope brakmic comes back soon.
313 2020-05-11T14:34:46  *** surja795 has joined #bitcoin-core-dev
314 2020-05-11T14:34:49  <provoostenator> I must say I never picked a "good first issue" when I started out. Not saying that was smart of me, but just to add a data point.
315 2020-05-11T14:35:21  <provoostenator> I just picked something that bothered me and apparently didn't bother anyone else enough to deal with it first :-)
316 2020-05-11T14:35:39  <provoostenator> But my first PR took several months to get merged, so...
317 2020-05-11T14:38:13  *** promag_ has quit IRC
318 2020-05-11T14:38:27  <wumpus> thanks for weighing in; I think having contributed *something* is good before starting to review, unless you can somehow start reviewing at a deep technical level without having written any code for bitcoin core (e.g. contributor to a similar or adjacent project), but that's rare
319 2020-05-11T14:38:49  *** promag has joined #bitcoin-core-dev
320 2020-05-11T14:39:25  <wumpus> though it's always 'taken seriously' if you point out problems in review, to be clear
321 2020-05-11T14:39:49  *** surja795 has quit IRC
322 2020-05-11T14:40:11  *** bitcoin-git has joined #bitcoin-core-dev
323 2020-05-11T14:40:11  <bitcoin-git> [bitcoin] hebasto opened pull request #18948:  qt: Do not call setParent() for WalletModel instances (master...200511-qt-assert) https://github.com/bitcoin/bitcoin/pull/18948
324 2020-05-11T14:40:13  *** bitcoin-git has left #bitcoin-core-dev
325 2020-05-11T14:40:46  *** bitcoin-git has joined #bitcoin-core-dev
326 2020-05-11T14:40:46  <bitcoin-git> [bitcoin] hebasto closed pull request #18883: qt: Fix OpenWalletActivity::open() (master...200505-fix-win) https://github.com/bitcoin/bitcoin/pull/18883
327 2020-05-11T14:40:50  *** bitcoin-git has left #bitcoin-core-dev
328 2020-05-11T14:41:26  *** promag has quit IRC
329 2020-05-11T14:41:40  *** promag has joined #bitcoin-core-dev
330 2020-05-11T14:41:42  <provoostenator> When I'm unfamiliar with the code during a review, the first thing I try is to break stuff. Then I can report that, and feel like I at least got something useful done.
331 2020-05-11T14:42:23  <provoostenator> Though if you're very new to the project you may just find an existing bug, so it's important to compare to master.
332 2020-05-11T14:45:20  <theStack> provoostenator: for me personally grep-ing for TODOs was quite a good strategy, besides of 'good first issues'
333 2020-05-11T14:49:05  *** geeker has joined #bitcoin-core-dev
334 2020-05-11T14:49:42  <theStack> wumpus: definitely agree to both of your points; there are also very good beginners resources out there (e.g. by jimmy song, jonatack, amiti...) that make clear how important reviewing is and that every opinion is considered worthy
335 2020-05-11T14:49:53  *** someone235 has quit IRC
336 2020-05-11T14:53:46  *** geeker has quit IRC
337 2020-05-11T14:53:47  *** promag has quit IRC
338 2020-05-11T14:53:51  *** promag_ has joined #bitcoin-core-dev
339 2020-05-11T14:54:11  <jonatack> thanks theStack. this is in no way directed at you or anyone, but i feel the phrase itself "i have to contribute first before i do anything else" reveals something.
340 2020-05-11T14:54:36  *** promag has joined #bitcoin-core-dev
341 2020-05-11T14:54:40  <wumpus> the only possible situation I can imagine where someone is not taken seriously is when a new person starts commenting on things like source organization or aggressively pushing their code style preferences
342 2020-05-11T14:55:14  <jonatack> the definition of "contribute" itself does not necessarily mean opening PRs
343 2020-05-11T14:55:56  <jonatack> yet for a majority of new contributors it seems to be seen as exactly that: opening PRs
344 2020-05-11T14:56:44  <jonatack> when one enters a new project repo (this one or another) and sees *hundreds* of open issues and PRs
345 2020-05-11T14:58:52  <jonatack> it may be a bit ironic that the reflex is "i need to open PRs here!" ... idk how to improve this but am working on it
346 2020-05-11T14:59:19  *** promag has quit IRC
347 2020-05-11T15:00:02  *** tss1 has quit IRC
348 2020-05-11T15:00:03  *** nothingmuch has joined #bitcoin-core-dev
349 2020-05-11T15:00:08  <jonatack> it's not easy to strike a good balance
350 2020-05-11T15:00:17  *** promag_ has quit IRC
351 2020-05-11T15:01:21  <luke-jr> reviewing is one of the best ways to start contributing
352 2020-05-11T15:01:32  *** proofofkeags has joined #bitcoin-core-dev
353 2020-05-11T15:01:40  <luke-jr> not only are we bottlenecked on review, it helps you learn the code, expectations, etc
354 2020-05-11T15:02:08  *** ghost43 has quit IRC
355 2020-05-11T15:02:24  *** ghost43 has joined #bitcoin-core-dev
356 2020-05-11T15:02:31  <luke-jr> (another good way is to write tests, but test-writing isn't a skill everyone has)
357 2020-05-11T15:03:26  <theStack> jonatack: yes, mostly people tend to equate "contributing" only to "opening a PR"; the longer i am here the more i think that the most important contribution is actually reviewing
358 2020-05-11T15:03:44  <jonatack> :love: :D
359 2020-05-11T15:07:18  *** ghost43 has quit IRC
360 2020-05-11T15:07:35  *** ghost43 has joined #bitcoin-core-dev
361 2020-05-11T15:08:26  <jonatack> the challenge for me is to get faster at reviewing; all those PRs needing love are a bottleneck, so i don't allocate time to coding... < 5%, certainly... not sure what to do except get faster at reviewing.
362 2020-05-11T15:09:04  *** geeker has joined #bitcoin-core-dev
363 2020-05-11T15:10:16  <jonatack> luke-jr: +1
364 2020-05-11T15:11:50  <luke-jr> MarcoFalke_2: I doubt we'll see the end of boost any time soon… There's no C++ standard alternative to Boost::Process in any version, right?
365 2020-05-11T15:12:54  <jonatack> (but can't become complacent about reviewing either, or a vulnerability gets through)
366 2020-05-11T15:13:33  <luke-jr> I've seen quite a few serious issues get through recently, but I don't want to scare off reviewing/merging either :/
367 2020-05-11T15:14:09  <jonatack> yes, this is a fundamental tension
368 2020-05-11T15:14:24  <yevaud> reviewing almost always has no real "output", which is obviously offputting.
369 2020-05-11T15:14:57  <luke-jr> <MarcoFalke_2> luke-jr: At least we can drop the majority of boost. Keeping one or two boost modules might be fine.
370 2020-05-11T15:15:00  <luke-jr> (he can't speak)
371 2020-05-11T15:15:37  <sipa> i feel the most rewarding output of review is when both author and reviewer agree that the PR is in a better state due to the reviewers' comments
372 2020-05-11T15:16:03  *** jb55 has quit IRC
373 2020-05-11T15:19:38  *** jb55 has joined #bitcoin-core-dev
374 2020-05-11T15:21:34  *** JackSparrow has joined #bitcoin-core-dev
375 2020-05-11T15:22:56  *** theStack has quit IRC
376 2020-05-11T15:25:02  <instagibbs> reviewing can be more of a fine art than throwing a PR out there
377 2020-05-11T15:25:42  <instagibbs> need to know when to when not to nit, etc
378 2020-05-11T15:32:33  <aj> what, why are my ears burning?
379 2020-05-11T15:33:02  <jonatack> i see the whole project as a garden or farm... we are gardeners/farmers... the releases are the seasonal harvest
380 2020-05-11T15:33:15  <jonatack> aj: nah, it was for me :)
381 2020-05-11T15:33:46  <instagibbs> a seasoned PR writer knows when to ignore and let ACKs stack :P
382 2020-05-11T15:34:03  <aj> don't stack sats, stack ACKs
383 2020-05-11T15:34:12  <sipa> stACKs
384 2020-05-11T15:34:30  *** Caralie has joined #bitcoin-core-dev
385 2020-05-11T15:38:43  *** kristapsk has quit IRC
386 2020-05-11T15:41:18  *** justanotheruser has quit IRC
387 2020-05-11T15:41:49  *** MarcoFalke_2 has quit IRC
388 2020-05-11T15:42:14  *** bitcoin-git has joined #bitcoin-core-dev
389 2020-05-11T15:42:14  <bitcoin-git> [bitcoin] adamjonas opened pull request #18949: doc: Add CODEOWNERS file to automatically nominate PR reviewers (master...2020-5-add-codeowners) https://github.com/bitcoin/bitcoin/pull/18949
390 2020-05-11T15:42:15  *** bitcoin-git has left #bitcoin-core-dev
391 2020-05-11T15:43:38  *** MarcoFalke has joined #bitcoin-core-dev
392 2020-05-11T15:44:08  <MarcoFalke> test
393 2020-05-11T15:44:37  <sipa> fail
394 2020-05-11T15:45:11  <MarcoFalke> [11:37] [435] MarcoFalke_2 MarcoFalke #bitcoin-core-dev Cannot change nickname while banned/quieted on channel
395 2020-05-11T15:47:38  <MarcoFalke> I need a new IRC setup
396 2020-05-11T15:48:17  <MarcoFalke> https://twitter.com/pwuille/status/1171669782065795072
397 2020-05-11T15:48:43  <sipa> ha
398 2020-05-11T15:50:54  *** surja795 has joined #bitcoin-core-dev
399 2020-05-11T15:51:43  *** morcos has quit IRC
400 2020-05-11T15:52:31  <phantomcircuit> gwillen, the way we use bdb is already comically paranoid, iirc every operation results in a complete flush
401 2020-05-11T15:52:51  *** morcos has joined #bitcoin-core-dev
402 2020-05-11T15:54:12  <MarcoFalke> [22:09] <luke-jr> [23:47:07] <sipa> MarcoFalke: i don't think issues should be closed because nobody is working on them <-- indeed, some look like "good first issue" material
403 2020-05-11T15:54:37  <MarcoFalke> Just saw this and I think if someone proposed a gui improvement in 2016 or 2014, and no one has been working on it since, it should be fine to close
404 2020-05-11T15:55:05  <MarcoFalke> We can't keep every feature request open indef
405 2020-05-11T15:55:35  *** surja795 has quit IRC
406 2020-05-11T15:56:30  <MarcoFalke> For bugs that are reproducible, maybe yes, but for improvements we need to cut them off at some point
407 2020-05-11T15:57:36  <MarcoFalke> Btw ajonas has been helping me go through all issues. So I might do a second run to pick up those that qualify as "good first issues"
408 2020-05-11T15:58:17  <sipa> MarcoFalke: if there was a better way to classify/keep track of issues, maybe there wouldn't be as much a desire to keep the issue list clean
409 2020-05-11T15:58:25  *** dviola has quit IRC
410 2020-05-11T15:58:58  <sipa> i agree with the sentiment; i think many issues are opened once, and then pretty much never looked at... making it useless and cluttering to keep them open
411 2020-05-11T15:59:12  <aj> i thought the recent issue cleanups were good
412 2020-05-11T15:59:32  <MarcoFalke> A few of the issues had been fixed long ago, but no one noticed. So I am thinkging that no one is wading through the issues in either case, so I wonder if closing them makes a difference at all
413 2020-05-11T15:59:40  <MarcoFalke> They can still be searched through and commented on
414 2020-05-11T15:59:48  <aj> it's good to have IDEAS pages and stuff (like gmaxwell's wiki things) but they don't need to be issues?
415 2020-05-11T16:01:01  *** mol has joined #bitcoin-core-dev
416 2020-05-11T16:01:14  <MarcoFalke> Sometimes it is good to create an issue to have an URL to point to when the topic comes up again. This is harder to to with IRC threads
417 2020-05-11T16:02:44  <jb55> if we had encouraged more people to use codetriage it might help with the issue backlog. I'm not a fan of autoclosing personally.
418 2020-05-11T16:03:58  *** proofofkeags has quit IRC
419 2020-05-11T16:04:37  *** dviola has joined #bitcoin-core-dev
420 2020-05-11T16:05:58  *** proofofkeags has joined #bitcoin-core-dev
421 2020-05-11T16:07:05  *** foxp2 has quit IRC
422 2020-05-11T16:08:41  *** justanotheruser has joined #bitcoin-core-dev
423 2020-05-11T16:08:49  <luke-jr> MarcoFalke: I was thinking more of getting rid of the univalue fork
424 2020-05-11T16:10:30  *** foxp2 has joined #bitcoin-core-dev
425 2020-05-11T16:13:10  *** andrewtoth_ has joined #bitcoin-core-dev
426 2020-05-11T16:13:43  *** _andrewtoth_ has quit IRC
427 2020-05-11T16:14:53  *** andrewtoth_ has quit IRC
428 2020-05-11T16:17:26  <MarcoFalke> The decision to close issues is subjective. When an issue has already been solved, or partially solved, but stale for a long time, or I haven't seen a way that something is going to be addressed any time soon or ever, I closed it.
429 2020-05-11T16:18:30  <MarcoFalke> jb55: How is "codetriage" different from "good first issue" (the tag)?
430 2020-05-11T16:23:23  *** vasild has quit IRC
431 2020-05-11T16:24:58  *** vasild has joined #bitcoin-core-dev
432 2020-05-11T16:26:42  *** Cavaleiro_R221 has joined #bitcoin-core-dev
433 2020-05-11T16:29:11  *** vasild has quit IRC
434 2020-05-11T16:31:48  *** geeker has quit IRC
435 2020-05-11T16:32:24  *** geeker has joined #bitcoin-core-dev
436 2020-05-11T16:35:22  <jb55> MarcoFalke: its tangentially related. I was just commenting on the growing backlog issue. you can subscribe and it sends periodic emails for stale issues to triage. the more people doing it the better.
437 2020-05-11T16:35:28  *** dviola has quit IRC
438 2020-05-11T16:35:58  *** dviola has joined #bitcoin-core-dev
439 2020-05-11T16:36:20  <jb55> usually along the lines of "hey, whats the status of this?" "can this be closed" from there perhaps users can triage old issues into "good first issues".
440 2020-05-11T16:37:22  *** geeker has quit IRC
441 2020-05-11T16:37:48  *** kristapsk has joined #bitcoin-core-dev
442 2020-05-11T16:47:10  *** bitbee has quit IRC
443 2020-05-11T16:47:57  *** bitbee has joined #bitcoin-core-dev
444 2020-05-11T16:48:17  *** foxp2 has quit IRC
445 2020-05-11T16:48:42  *** ccc2 has joined #bitcoin-core-dev
446 2020-05-11T16:51:05  *** promag has joined #bitcoin-core-dev
447 2020-05-11T16:51:06  *** ccc2 has quit IRC
448 2020-05-11T16:55:27  *** promag has quit IRC
449 2020-05-11T17:08:17  *** surja795 has joined #bitcoin-core-dev
450 2020-05-11T17:08:43  *** Caralie has quit IRC
451 2020-05-11T17:09:17  *** foxp2 has joined #bitcoin-core-dev
452 2020-05-11T17:12:46  *** surja795 has quit IRC
453 2020-05-11T17:15:45  *** promag has joined #bitcoin-core-dev
454 2020-05-11T17:17:09  *** Dean_Guss has joined #bitcoin-core-dev
455 2020-05-11T17:19:55  *** geeker has joined #bitcoin-core-dev
456 2020-05-11T17:23:33  *** lightlike has joined #bitcoin-core-dev
457 2020-05-11T17:24:36  *** geeker has quit IRC
458 2020-05-11T17:29:43  *** AaronvanW has quit IRC
459 2020-05-11T17:32:27  *** AaronvanW has joined #bitcoin-core-dev
460 2020-05-11T17:36:20  *** promag_ has joined #bitcoin-core-dev
461 2020-05-11T17:37:12  *** bitcoin-git has joined #bitcoin-core-dev
462 2020-05-11T17:37:13  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f71a3a882974...eb2ffbb7c134
463 2020-05-11T17:37:13  <bitcoin-git> bitcoin/master 1551cea Hennadii Stepanov: refactor: Use override for non-final overriders
464 2020-05-11T17:37:14  <bitcoin-git> bitcoin/master d044e0e Hennadii Stepanov: refactor: Remove override for final overriders
465 2020-05-11T17:37:14  <bitcoin-git> bitcoin/master eb2ffbb MarcoFalke: Merge #18914: refactor: Apply override specifier consistently
466 2020-05-11T17:37:16  *** bitcoin-git has left #bitcoin-core-dev
467 2020-05-11T17:37:32  *** bitcoin-git has joined #bitcoin-core-dev
468 2020-05-11T17:37:32  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18914: refactor: Apply override specifier consistently (master...200508-override) https://github.com/bitcoin/bitcoin/pull/18914
469 2020-05-11T17:37:35  *** bitcoin-git has left #bitcoin-core-dev
470 2020-05-11T17:38:15  *** Cavaleiro_R221 has quit IRC
471 2020-05-11T17:41:31  *** Highway61 has quit IRC
472 2020-05-11T17:41:45  *** promag_ has quit IRC
473 2020-05-11T17:51:12  *** geeker has joined #bitcoin-core-dev
474 2020-05-11T17:51:13  *** owowo has quit IRC
475 2020-05-11T17:52:18  *** proofofk_ has joined #bitcoin-core-dev
476 2020-05-11T17:54:43  *** proofof__ has joined #bitcoin-core-dev
477 2020-05-11T17:55:19  *** proofofkeags has quit IRC
478 2020-05-11T17:55:30  *** geeker has quit IRC
479 2020-05-11T17:57:32  *** proofofk_ has quit IRC
480 2020-05-11T17:59:08  *** owowo has joined #bitcoin-core-dev
481 2020-05-11T17:59:09  *** timothy has quit IRC
482 2020-05-11T18:00:02  *** JackSparrow has quit IRC
483 2020-05-11T18:05:24  *** bitbee has quit IRC
484 2020-05-11T18:06:20  *** Highway61 has joined #bitcoin-core-dev
485 2020-05-11T18:08:33  *** rabidus has joined #bitcoin-core-dev
486 2020-05-11T18:17:08  *** surja795 has joined #bitcoin-core-dev
487 2020-05-11T18:17:20  *** jkakar has joined #bitcoin-core-dev
488 2020-05-11T18:21:40  *** surja795 has quit IRC
489 2020-05-11T18:24:44  *** jorijn has quit IRC
490 2020-05-11T18:26:59  *** aerth has left #bitcoin-core-dev
491 2020-05-11T18:27:51  <gwillen> phantomcircuit: that makes sense and I'm really glad to hear it
492 2020-05-11T18:31:57  <sipa> our bdb code went through several random mutations as long as problem reports were frequent
493 2020-05-11T18:32:25  <sipa> and then stopped mutating once those problems went away... so we probably ended up in a very stable (but possible overly caution) way of using it
494 2020-05-11T18:34:23  *** jeremyrubin has quit IRC
495 2020-05-11T18:36:42  <gwillen> that doesn't necessarily seem like a reliable way to get correct behavior
496 2020-05-11T18:36:56  <gwillen> but it's a reliable way to get almost-always-correct behavior I guess :-)
497 2020-05-11T18:38:39  <sipa> yes, it's why i don't want to touch bdb with a ten-foot pole
498 2020-05-11T18:38:59  <sipa> maybe an 11-foot pole is ok, though
499 2020-05-11T18:40:05  <gwillen> hahaha
500 2020-05-11T18:40:26  *** Guyver2_ is now known as Guyver2
501 2020-05-11T18:40:37  <gwillen> I think many things work better if you fsync() constantly
502 2020-05-11T18:40:46  <gwillen> but it makes them very slow
503 2020-05-11T18:40:53  *** promag has quit IRC
504 2020-05-11T18:41:37  *** promag has joined #bitcoin-core-dev
505 2020-05-11T18:43:26  <jb55> so we're replacing it with sqlite right :D
506 2020-05-11T18:44:02  <sipa> i think it's worth considering
507 2020-05-11T18:46:34  <cfields> gwillen: which is why macOS's fsync doesn't really fully sync. Flushing is annoyingly platform-specific :\
508 2020-05-11T18:46:53  *** tryphe_ has joined #bitcoin-core-dev
509 2020-05-11T18:48:12  *** michaelfolkson has joined #bitcoin-core-dev
510 2020-05-11T18:49:50  *** jorijn has joined #bitcoin-core-dev
511 2020-05-11T18:49:54  *** tryphe has quit IRC
512 2020-05-11T18:50:29  *** theStack has joined #bitcoin-core-dev
513 2020-05-11T18:52:27  *** tryphe_ is now known as tryphe
514 2020-05-11T18:55:09  *** proofofkeags has joined #bitcoin-core-dev
515 2020-05-11T18:55:51  <theStack> we are 3 blocks away from the halving <3
516 2020-05-11T18:58:10  *** proofof__ has quit IRC
517 2020-05-11T19:02:24  *** vasild has joined #bitcoin-core-dev
518 2020-05-11T19:03:54  *** bobbydobalina has joined #bitcoin-core-dev
519 2020-05-11T19:08:57  <reardencode> 2 blocks!
520 2020-05-11T19:09:53  <reardencode> nope, this countdown lies: https://www.bitcoinsensus.com/bitcoin-halving-countdown/
521 2020-05-11T19:10:20  <instagibbs> was about to say hash or GTFO :P
522 2020-05-11T19:10:30  <sipa> depending on whether you see 629999 or 630000 as the halvening time point, 2 or 3 blocks left
523 2020-05-11T19:10:55  *** michaelfolkson has quit IRC
524 2020-05-11T19:11:11  <MarcoFalke> If you run the bdb with eatmydata, it will be fast
525 2020-05-11T19:11:16  <MarcoFalke> (don't do this at home)
526 2020-05-11T19:11:36  <owowo> sounds like COVID-19, depending how you look at it, it's different :P
527 2020-05-11T19:13:25  <reardencode> 000000000000000000030684c158973dafb512dc91f90420e6811e3f6a2ca79b for real now :)
528 2020-05-11T19:15:33  <CubicEarth> sipa: 630000 is the first @ 6.25 ?
529 2020-05-11T19:15:46  <sipa> CubicEarth: correct
530 2020-05-11T19:16:06  <sipa> (but miners start working on that block as soon as 629999 happens...)
531 2020-05-11T19:16:14  <sipa> or shortly after at least
532 2020-05-11T19:16:41  <CubicEarth> So we might be waiting longer than normal for 630000 itself ;)
533 2020-05-11T19:17:18  <CubicEarth> depending on how fast low margin miners turn off their rigs
534 2020-05-11T19:18:09  <instagibbs> bragging rights, they'll keep rigs on one block longer ;)
535 2020-05-11T19:18:21  <theStack> what? isn't the price instantly doubling on 630000? xD
536 2020-05-11T19:19:17  *** meshcollider has quit IRC
537 2020-05-11T19:20:09  <fjahr> miners should mine block 630k with 12.5 until one gets rejected just to make sure validation still works :p
538 2020-05-11T19:20:39  <CubicEarth> theStack: Of course it will. Have some faith.
539 2020-05-11T19:21:04  <jonatack> buy the rumor, sell the news... :p
540 2020-05-11T19:22:17  <owowo> yay, my node finished to sync before halving
541 2020-05-11T19:22:29  <theStack> fjahr: that would be quite some costly test :p
542 2020-05-11T19:23:50  *** geeker has joined #bitcoin-core-dev
543 2020-05-11T19:24:13  <sipa> 629999!
544 2020-05-11T19:24:16  <owowo> 1!
545 2020-05-11T19:24:20  <theStack> \o/
546 2020-05-11T19:24:49  <owowo> !!!
547 2020-05-11T19:24:49  <lightningbot> owowo: Error: "!" is not a valid command.
548 2020-05-11T19:24:49  <gribble> Error: "!!" is not a valid command.
549 2020-05-11T19:25:01  <owowo> 630000!
550 2020-05-11T19:25:02  <CubicEarth> 630000000000
551 2020-05-11T19:25:24  <owowo> 000000000000000000024bead8df69990852c202db0e0097c1a12ea637d7e96d
552 2020-05-11T19:25:36  *** surja795 has joined #bitcoin-core-dev
553 2020-05-11T19:25:37  <theStack> owowo: +1
554 2020-05-11T19:25:59  <reardencode> !! AntPool!
555 2020-05-11T19:25:59  <lightningbot> reardencode: Error: "AntPool!" is not a valid command.
556 2020-05-11T19:26:00  <gribble> Error: "!" is not a valid command.
557 2020-05-11T19:26:05  * owowo waits for the doubling of price, any moment now
558 2020-05-11T19:27:06  *** danielyin has joined #bitcoin-core-dev
559 2020-05-11T19:27:43  <owowo> ok, history made, good night, l0ve you all :)
560 2020-05-11T19:28:15  <CubicEarth> Just 209,999 more blocks to go until the havening!
561 2020-05-11T19:28:19  *** danielyi1 has joined #bitcoin-core-dev
562 2020-05-11T19:28:25  *** geeker has quit IRC
563 2020-05-11T19:28:34  <CubicEarth> 3.125 - here we come!
564 2020-05-11T19:30:18  *** surja795 has quit IRC
565 2020-05-11T19:30:48  *** meshcollider has joined #bitcoin-core-dev
566 2020-05-11T19:31:41  <theStack> the yearly inflation rate has now lowered to <1,8% (if i'm calculating correctly)
567 2020-05-11T19:34:02  *** sdaftuar has quit IRC
568 2020-05-11T19:34:52  *** sdaftuar has joined #bitcoin-core-dev
569 2020-05-11T19:39:37  *** nehan_ has quit IRC
570 2020-05-11T19:41:26  *** nehan has joined #bitcoin-core-dev
571 2020-05-11T19:42:31  *** EagleTM has joined #bitcoin-core-dev
572 2020-05-11T20:10:49  *** SiAnDoG has quit IRC
573 2020-05-11T20:10:57  *** SiAnDoG has joined #bitcoin-core-dev
574 2020-05-11T20:13:14  *** surja795 has joined #bitcoin-core-dev
575 2020-05-11T20:13:49  *** lightlike has quit IRC
576 2020-05-11T20:15:45  *** jorijn_ has joined #bitcoin-core-dev
577 2020-05-11T20:15:52  *** jorijn has quit IRC
578 2020-05-11T20:16:45  *** promag has quit IRC
579 2020-05-11T20:17:01  *** promag has joined #bitcoin-core-dev
580 2020-05-11T20:19:15  *** bobbydobalina has quit IRC
581 2020-05-11T20:25:33  <amiti> hey all, I read through the message history of the last ~day and I’d like to share some thoughts
582 2020-05-11T20:25:40  <amiti> I feel really sad that I created feelings of an unwelcoming environment for brakmic. That was exactly the opposite of my intent. I was trying to help create space for even more people to ramp up onto the project, but clearly that wasn’t the message that came across and that really sucks. In no way did I intend to discourage him.
583 2020-05-11T20:25:55  <amiti> I was actually working on a follow up comment to try to brainstorm some good places to search for more work (like looking at up-for-grabs closed issues), but was taken off guard by his response, and spent the rest of the day away from the keyboard. Obviously I’m pretty new around here myself, and oof, good communication is much harder than C++
584 2020-05-11T20:26:04  <amiti> I wrote some explanation on the issue trying to share where I was coming from. I’m going to repeat some of it here, and share a bit more..
585 2020-05-11T20:26:11  <amiti> I feel deeply grateful to get to work on bitcoin core on a daily basis. I 100% do not think I would be here if it weren’t for the many of you who have believed in me & taught me so much, even when I doubt myself. I’ve found the bitcoin core community to be welcoming & supportive, and I wish to share that with others who feel intimidated but interested
586 2020-05-11T20:26:27  <amiti> Several people have been reaching out to me lately about trying to figure out how to onboard, probably because of the different outreach stuff I’ve been doing. Some new contributors drew my attention to this pattern, leading to me leaving the comment. I figured most people who are contributing to the project don’t realize that there are people lurking and searching for an issue to tackle, so I was trying to
587 2020-05-11T20:26:28  <amiti> share that perspective and make a request. I really didn’t realize my comment could come off so negatively.
588 2020-05-11T20:26:35  <amiti> In terms of onboarding newcomers, I agree that review is super important, and also that it’s really hard. One barrier to this for newcomers is they see a huge backlog and they don’t know where to start. So something I’ve started doing is choosing test PRs and trying to directly hand them out. Maybe a possible idea here is to create a similar label along the lines of “good first review”.
589 2020-05-11T20:26:42  <amiti> And another thing that’s becoming more apparent to me is that even after the first issues & first reviews, it can also be tricky to figure out what’s next. I know many people feel like too-much-to-do-too-little-time, but on the other hand there are people looking for work that’s within their skillset and would be helpful. I wonder how we as a community could help better match these together.
590 2020-05-11T20:26:47  <amiti> This whole interaction has really surprised me with how it’s played out. The nice part of it has been seeing in action how much you all care about creating a supportive environment.
591 2020-05-11T20:26:48  *** michaelfolkson has joined #bitcoin-core-dev
592 2020-05-11T20:26:52  <amiti> I’m learning a lot and I appreciate your patience with me along the way. Its an honor to work with you all on bitcoin core <3
593 2020-05-11T20:26:58  <amiti> fin
594 2020-05-11T20:31:53  *** bitcoin-git has joined #bitcoin-core-dev
595 2020-05-11T20:31:54  <bitcoin-git> [bitcoin] fametrano opened pull request #18952: avoided os-dependant path (master...patch-2) https://github.com/bitcoin/bitcoin/pull/18952
596 2020-05-11T20:31:55  *** bitcoin-git has left #bitcoin-core-dev
597 2020-05-11T20:33:09  *** promag_ has joined #bitcoin-core-dev
598 2020-05-11T20:33:09  *** promag has quit IRC
599 2020-05-11T20:33:35  *** targon has joined #bitcoin-core-dev
600 2020-05-11T20:36:25  *** michaelfolkson has quit IRC
601 2020-05-11T20:38:27  *** promag_ has quit IRC
602 2020-05-11T20:39:04  *** promag has joined #bitcoin-core-dev
603 2020-05-11T20:44:29  *** promag_ has joined #bitcoin-core-dev
604 2020-05-11T20:50:04  *** danielyin has quit IRC
605 2020-05-11T20:50:05  *** danielyi1 has quit IRC
606 2020-05-11T20:54:49  *** Chris_Stewart_5 has quit IRC
607 2020-05-11T21:00:02  *** jkakar has quit IRC
608 2020-05-11T21:02:31  <jb55> it's all good sounds like it was just some miscommunication
609 2020-05-11T21:02:31  *** jarthur has joined #bitcoin-core-dev
610 2020-05-11T21:06:57  *** geeker has joined #bitcoin-core-dev
611 2020-05-11T21:09:59  *** mol has quit IRC
612 2020-05-11T21:10:55  *** foxp2 has quit IRC
613 2020-05-11T21:11:36  *** geeker has quit IRC
614 2020-05-11T21:20:00  *** wright has joined #bitcoin-core-dev
615 2020-05-11T21:31:26  <sipa> amiti: communication is hard
616 2020-05-11T21:39:32  *** promag_ has quit IRC
617 2020-05-11T21:40:11  *** mol has joined #bitcoin-core-dev
618 2020-05-11T21:40:16  *** promag_ has joined #bitcoin-core-dev
619 2020-05-11T21:51:48  *** Pavlenex has joined #bitcoin-core-dev
620 2020-05-11T21:53:06  *** targon has quit IRC
621 2020-05-11T21:53:34  <Pavlenex> Hey. Who's in charge of Transifex? Translated 0.20 in Serbian from scratch but there's no moderator for the language, so it can't be reviewed. Can anybody provide me with a reviewer access so we can proceed? Thanks.
622 2020-05-11T21:54:31  *** theStack has quit IRC
623 2020-05-11T21:57:32  *** molakala has quit IRC
624 2020-05-11T21:59:50  *** bitcoin-git has joined #bitcoin-core-dev
625 2020-05-11T21:59:50  <bitcoin-git> [bitcoin] andrewtoth closed pull request #18941: validation: Persist coins cache to disk and load on startup (master...persist-coinscache) https://github.com/bitcoin/bitcoin/pull/18941
626 2020-05-11T21:59:51  *** bitcoin-git has left #bitcoin-core-dev
627 2020-05-11T22:04:11  *** EagleTM has quit IRC
628 2020-05-11T22:09:44  *** surja795 has quit IRC
629 2020-05-11T22:10:47  *** Pavlenex has quit IRC
630 2020-05-11T22:13:59  *** pandito has joined #bitcoin-core-dev
631 2020-05-11T22:14:56  *** pandito has quit IRC
632 2020-05-11T22:18:44  *** marcoagner has quit IRC
633 2020-05-11T22:20:01  *** promag_ has quit IRC
634 2020-05-11T22:20:20  *** promag_ has joined #bitcoin-core-dev
635 2020-05-11T22:22:24  *** Guyver2 has quit IRC
636 2020-05-11T22:27:19  *** Chris_Stewart_5 has joined #bitcoin-core-dev
637 2020-05-11T22:36:36  *** emilengler has quit IRC
638 2020-05-11T22:36:58  *** Pavlenex has joined #bitcoin-core-dev
639 2020-05-11T22:41:25  *** vasild has quit IRC
640 2020-05-11T22:41:40  *** vasild has joined #bitcoin-core-dev
641 2020-05-11T22:41:51  *** RikAinSoph has joined #bitcoin-core-dev
642 2020-05-11T22:45:13  *** filchef has joined #bitcoin-core-dev
643 2020-05-11T22:45:41  *** dviola has quit IRC
644 2020-05-11T22:46:45  *** filchef has quit IRC
645 2020-05-11T22:47:43  *** foxp2 has joined #bitcoin-core-dev
646 2020-05-11T22:53:51  *** promag_ has quit IRC
647 2020-05-11T22:55:48  *** promag_ has joined #bitcoin-core-dev
648 2020-05-11T22:58:26  *** manantial has quit IRC
649 2020-05-11T23:00:17  *** Pavlenex has quit IRC
650 2020-05-11T23:04:08  *** mdunnio has quit IRC
651 2020-05-11T23:10:12  *** geeker has joined #bitcoin-core-dev
652 2020-05-11T23:10:45  *** RikAinSoph has quit IRC
653 2020-05-11T23:11:18  *** mdunnio has joined #bitcoin-core-dev
654 2020-05-11T23:15:13  *** geeker has quit IRC
655 2020-05-11T23:16:06  *** mdunnio has quit IRC
656 2020-05-11T23:17:31  *** DeanWeen has joined #bitcoin-core-dev
657 2020-05-11T23:18:11  *** surja795 has joined #bitcoin-core-dev
658 2020-05-11T23:18:35  <gleb> I was very happy to find "bitpeers" today, the go tool which parses peers.dat in various ways. Not sure people here are aware of it, just wanted to share :)
659 2020-05-11T23:19:23  *** Dean_Guss has quit IRC
660 2020-05-11T23:20:41  *** AaronvanW has quit IRC
661 2020-05-11T23:23:13  *** promag_ has quit IRC
662 2020-05-11T23:23:18  *** pinheadmz has quit IRC
663 2020-05-11T23:25:27  *** pinheadmz has joined #bitcoin-core-dev
664 2020-05-11T23:30:24  *** pinheadmz_ has joined #bitcoin-core-dev
665 2020-05-11T23:31:50  *** pinheadmz_ has quit IRC
666 2020-05-11T23:33:19  *** pinheadmz_ has joined #bitcoin-core-dev
667 2020-05-11T23:34:32  *** EagleTM has joined #bitcoin-core-dev
668 2020-05-11T23:35:24  *** pinheadmz_ has quit IRC
669 2020-05-11T23:42:56  *** Dean_Guss has joined #bitcoin-core-dev
670 2020-05-11T23:43:43  *** DeanWeen has quit IRC
671 2020-05-11T23:47:18  *** pinheadmz has quit IRC
672 2020-05-11T23:47:45  *** pinheadmz has joined #bitcoin-core-dev
673 2020-05-11T23:50:01  *** Chris_Stewart_5 has quit IRC
674 2020-05-11T23:50:25  *** foxp2 has quit IRC
675 2020-05-11T23:50:59  *** geeker has joined #bitcoin-core-dev
676 2020-05-11T23:52:33  *** pinheadmz has quit IRC
677 2020-05-11T23:52:46  *** pinheadmz has joined #bitcoin-core-dev
678 2020-05-11T23:53:31  *** pinheadmz_ has joined #bitcoin-core-dev
679 2020-05-11T23:53:45  *** pinheadmz_ has quit IRC
680 2020-05-11T23:54:09  *** foxp2 has joined #bitcoin-core-dev
681 2020-05-11T23:55:16  *** geeker has quit IRC
682 2020-05-11T23:56:50  *** foxp2 has quit IRC