12020-05-11T00:00:02 *** mrdocs has quit IRC
22020-05-11T00:00:10 *** jarthur has quit IRC
32020-05-11T00:00:50 *** jarthur has joined #bitcoin-core-dev
42020-05-11T00:07:17 *** dfmb_ has joined #bitcoin-core-dev
52020-05-11T00:13:42 *** Chris_Stewart_5 has joined #bitcoin-core-dev
62020-05-11T00:17:19 *** surja795_ has joined #bitcoin-core-dev
72020-05-11T00:17:20 *** surja795 has quit IRC
82020-05-11T00:22:17 *** mmf has joined #bitcoin-core-dev
92020-05-11T00:23:49 *** jarthur has quit IRC
102020-05-11T00:31:32 *** dfmb_ has quit IRC
112020-05-11T00:35:37 *** manantial has quit IRC
122020-05-11T00:36:58 *** bitcoin-git has joined #bitcoin-core-dev
132020-05-11T00:36:58 <bitcoin-git> [bitcoin] theStack opened pull request #18940: miner: fix off-by-ones in BlockAssembler::TestPackage (master...20200511-miner-fix-off-by-one-in-test-package) https://github.com/bitcoin/bitcoin/pull/18940
142020-05-11T00:37:09 *** bitcoin-git has left #bitcoin-core-dev
152020-05-11T00:41:13 *** proofofkeags has quit IRC
162020-05-11T00:55:41 *** mdunnio has joined #bitcoin-core-dev
172020-05-11T00:58:59 *** mdunnio has quit IRC
182020-05-11T01:01:19 *** Chris_Stewart_5 has quit IRC
192020-05-11T01:04:06 *** Bullit has joined #bitcoin-core-dev
202020-05-11T01:11:50 *** promag has quit IRC
212020-05-11T01:12:04 *** promag has joined #bitcoin-core-dev
222020-05-11T01:12:19 *** promag_ has joined #bitcoin-core-dev
232020-05-11T01:15:53 *** promag has quit IRC
242020-05-11T01:16:38 *** promag has joined #bitcoin-core-dev
252020-05-11T01:18:30 *** proofofkeags has joined #bitcoin-core-dev
262020-05-11T01:23:03 <yevaud> fanquake: I'd suggest someone well known reaches out to them, and amitiuttarwar is removed from the repo.
272020-05-11T01:24:12 <yevaud> there's really no place for someone being told to stop contributing.
282020-05-11T01:25:22 <phantomcircuit> have to agree
292020-05-11T01:26:12 *** proofofkeags has quit IRC
302020-05-11T01:26:48 <sipa> i don't interpret it that way; just as an encouragement to focus on more things than just "good first issue" tagged ones
312020-05-11T01:33:04 *** proofofkeags has joined #bitcoin-core-dev
322020-05-11T01:36:37 <luke-jr> yevaud: that's going too far⦠let's just make it clear we don't agree with that attitude?
332020-05-11T01:39:30 <yevaud> luke-jr: perhaps. objectively the project has lost one of the very few people who have turned up and are prepared to review.
342020-05-11T01:39:56 <luke-jr> yevaud: hopefully he will reconsider when he learns it was just one guy
352020-05-11T01:41:27 *** promag has quit IRC
362020-05-11T01:41:41 *** promag has joined #bitcoin-core-dev
372020-05-11T01:41:45 *** promag_ has joined #bitcoin-core-dev
382020-05-11T01:51:44 *** geeker has joined #bitcoin-core-dev
392020-05-11T01:52:59 *** geeker has quit IRC
402020-05-11T01:53:15 *** geeker has joined #bitcoin-core-dev
412020-05-11T01:53:21 <luke-jr> I still wonder to date what happened to Diapolo :/
422020-05-11T01:54:11 *** proofofkeags has quit IRC
432020-05-11T01:56:17 <phantomcircuit> is the IsMineInner function still being used?
442020-05-11T01:58:25 <sipa> phantomcircuit: in legacy wallets yes
452020-05-11T02:13:47 *** promag_ has quit IRC
462020-05-11T02:14:50 *** bitcoin-git has joined #bitcoin-core-dev
472020-05-11T02:14:51 <bitcoin-git> [bitcoin] andrewtoth closed pull request #18936: validation: Persist coins cache to disk and load on startup (master...persist-coinscache) https://github.com/bitcoin/bitcoin/pull/18936
482020-05-11T02:14:52 *** bitcoin-git has left #bitcoin-core-dev
492020-05-11T02:24:17 <phantomcircuit> sipa, it's not feasible to generate a list of scriptpubkeys for a LegacyScriptPubKeyMan is it
502020-05-11T02:27:24 <sipa> phantomcircuit: it's possible but nontrivial; for all privkeys you need P2PK, P2PKH, P2WPKH, P2SH-P2WPKH versions of it; and then add all known scripts and watch-only scripts, and filter the whole list with IsMine
512020-05-11T02:27:38 <sipa> i wrote code for that once, not sure where it is
522020-05-11T02:29:04 <sipa> also P2SH and P2WSH versions of all scripts, presumably
532020-05-11T02:29:08 <phantomcircuit> sipa, the one i got kind of stuck (thinking about not doing) is the original multisig support
542020-05-11T02:29:20 <phantomcircuit> cause we don't know the other keys in advance
552020-05-11T02:29:49 <sipa> oh if you support raw multisig it's nontractible (cubic in the number of keys...)
562020-05-11T02:33:23 <phantomcircuit> sipa, yeah ok thanks
572020-05-11T02:39:35 *** amsudeep has quit IRC
582020-05-11T02:41:24 *** mol has quit IRC
592020-05-11T02:41:48 *** Highway61 has quit IRC
602020-05-11T02:43:27 *** mol has joined #bitcoin-core-dev
612020-05-11T02:47:10 *** bitcoin-git has joined #bitcoin-core-dev
622020-05-11T02:47:11 <bitcoin-git> [bitcoin] andrewtoth opened pull request #18941: validation: Persist coins cache to disk and load on startup (master...persist-coinscache) https://github.com/bitcoin/bitcoin/pull/18941
632020-05-11T02:47:12 *** bitcoin-git has left #bitcoin-core-dev
642020-05-11T03:00:01 *** mmf has quit IRC
652020-05-11T03:04:31 *** proofofkeags has joined #bitcoin-core-dev
662020-05-11T03:08:07 *** Highway61 has joined #bitcoin-core-dev
672020-05-11T03:08:59 *** surja795_ has quit IRC
682020-05-11T03:21:39 *** patryk1 has joined #bitcoin-core-dev
692020-05-11T03:27:05 *** sipa has quit IRC
702020-05-11T04:00:08 *** Dean_Guss has quit IRC
712020-05-11T04:00:11 *** DeanWeen has joined #bitcoin-core-dev
722020-05-11T04:03:56 *** sipa has joined #bitcoin-core-dev
732020-05-11T04:19:56 *** vasild_ has joined #bitcoin-core-dev
742020-05-11T04:21:11 *** bitcoin-git has joined #bitcoin-core-dev
752020-05-11T04:21:11 <bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/88d8b4e182bf...ec4d27fa8bdc
762020-05-11T04:21:12 <bitcoin-git> bitcoin/master df37377 Ben Woosley: test: Fix outstanding -Wsign-compare errors
772020-05-11T04:21:13 <bitcoin-git> bitcoin/master eac6a30 Ben Woosley: refactor: Rework asmap Interpret to avoid ptrdiff_t
782020-05-11T04:21:13 <bitcoin-git> bitcoin/master 6853727 Ben Woosley: build: Enable -Werror=sign-compare
792020-05-11T04:21:14 *** bitcoin-git has left #bitcoin-core-dev
802020-05-11T04:21:36 *** proofofkeags has quit IRC
812020-05-11T04:21:50 *** bitcoin-git has joined #bitcoin-core-dev
822020-05-11T04:21:51 <bitcoin-git> [bitcoin] fanquake merged pull request #18216: test, build: Enable -Werror=sign-compare (master...2020-02-sign-compare) https://github.com/bitcoin/bitcoin/pull/18216
832020-05-11T04:21:51 *** bitcoin-git has left #bitcoin-core-dev
842020-05-11T04:23:43 *** vasild has quit IRC
852020-05-11T04:23:44 *** vasild_ is now known as vasild
862020-05-11T04:25:15 *** achow101 has quit IRC
872020-05-11T04:26:35 *** achow101 has joined #bitcoin-core-dev
882020-05-11T04:30:11 *** AaronvanW has quit IRC
892020-05-11T04:36:00 *** mol_ has joined #bitcoin-core-dev
902020-05-11T04:39:06 *** mol has quit IRC
912020-05-11T04:58:27 *** proofofkeags has joined #bitcoin-core-dev
922020-05-11T05:00:55 *** sipa has quit IRC
932020-05-11T05:03:14 *** proofofkeags has quit IRC
942020-05-11T05:06:11 *** sipa has joined #bitcoin-core-dev
952020-05-11T05:11:10 *** theStack has joined #bitcoin-core-dev
962020-05-11T05:12:32 *** justanotheruser has quit IRC
972020-05-11T05:12:33 *** Mercury_Vapor has quit IRC
982020-05-11T05:13:18 *** Mercury_Vapor has joined #bitcoin-core-dev
992020-05-11T05:15:02 *** promag_ has joined #bitcoin-core-dev
1002020-05-11T05:20:01 *** promag_ has quit IRC
1012020-05-11T05:39:06 *** molz_ has joined #bitcoin-core-dev
1022020-05-11T05:42:25 *** mol_ has quit IRC
1032020-05-11T05:42:35 *** jeremyrubin has joined #bitcoin-core-dev
1042020-05-11T06:00:01 *** patryk1 has quit IRC
1052020-05-11T06:02:18 *** mol_ has joined #bitcoin-core-dev
1062020-05-11T06:05:05 *** molz_ has quit IRC
1072020-05-11T06:14:46 *** TheHoliestRoger has quit IRC
1082020-05-11T06:15:40 *** TheHoliestRoger has joined #bitcoin-core-dev
1092020-05-11T06:20:08 *** molz_ has joined #bitcoin-core-dev
1102020-05-11T06:21:59 *** SRV_DW20 has joined #bitcoin-core-dev
1112020-05-11T06:23:21 *** mol_ has quit IRC
1122020-05-11T06:28:43 *** proofofkeags has joined #bitcoin-core-dev
1132020-05-11T06:32:28 *** promag_ has joined #bitcoin-core-dev
1142020-05-11T06:33:34 *** proofofkeags has quit IRC
1152020-05-11T06:34:01 *** manantial has joined #bitcoin-core-dev
1162020-05-11T06:37:08 *** promag_ has quit IRC
1172020-05-11T07:03:33 *** justanotheruser has joined #bitcoin-core-dev
1182020-05-11T07:46:10 *** marcoagner has joined #bitcoin-core-dev
1192020-05-11T07:50:39 *** bitcoin-git has joined #bitcoin-core-dev
1202020-05-11T07:50:39 <bitcoin-git> [bitcoin] fanquake opened pull request #18942: doc: Increase minimum required GCC to 5.1 (master...gcc_5_1_for_codecvt) https://github.com/bitcoin/bitcoin/pull/18942
1212020-05-11T07:50:40 *** bitcoin-git has left #bitcoin-core-dev
1222020-05-11T07:57:06 *** Guyver2 has joined #bitcoin-core-dev
1232020-05-11T08:05:05 *** promag_ has joined #bitcoin-core-dev
1242020-05-11T08:05:34 *** CubicEarth has quit IRC
1252020-05-11T08:08:11 *** promag has quit IRC
1262020-05-11T08:08:20 *** CubicEarth has joined #bitcoin-core-dev
1272020-05-11T08:09:38 *** tynes_ has joined #bitcoin-core-dev
1282020-05-11T08:09:44 *** promag_ has quit IRC
1292020-05-11T08:09:48 *** da2ce7_ has joined #bitcoin-core-dev
1302020-05-11T08:10:26 *** MarcoFalke_2 has joined #bitcoin-core-dev
1312020-05-11T08:10:26 *** molz_ has quit IRC
1322020-05-11T08:10:39 *** bzb has joined #bitcoin-core-dev
1332020-05-11T08:10:48 *** molz_ has joined #bitcoin-core-dev
1342020-05-11T08:11:28 *** nehan_ has joined #bitcoin-core-dev
1352020-05-11T08:11:32 *** tecnovert has joined #bitcoin-core-dev
1362020-05-11T08:11:56 *** bzb has quit IRC
1372020-05-11T08:12:35 *** Henry151_ has joined #bitcoin-core-dev
1382020-05-11T08:13:21 *** mol has joined #bitcoin-core-dev
1392020-05-11T08:14:22 *** waxwing_ has joined #bitcoin-core-dev
1402020-05-11T08:14:34 *** TD--Linux has joined #bitcoin-core-dev
1412020-05-11T08:15:30 *** murr5y has joined #bitcoin-core-dev
1422020-05-11T08:15:47 *** molz_ has quit IRC
1432020-05-11T08:15:53 *** nehan has quit IRC
1442020-05-11T08:15:53 *** murr4y has quit IRC
1452020-05-11T08:15:53 *** MarcoFalke has quit IRC
1462020-05-11T08:15:53 *** tecnover1 has quit IRC
1472020-05-11T08:15:53 *** nsh has quit IRC
1482020-05-11T08:15:53 *** Henry151 has quit IRC
1492020-05-11T08:15:53 *** cornfeedhobo has quit IRC
1502020-05-11T08:15:53 *** tynes has quit IRC
1512020-05-11T08:15:53 *** waxwing has quit IRC
1522020-05-11T08:15:53 *** TD-Linux has quit IRC
1532020-05-11T08:15:53 *** da2ce7 has quit IRC
1542020-05-11T08:21:04 *** nsh has joined #bitcoin-core-dev
1552020-05-11T08:21:29 *** cornfeedhobo has joined #bitcoin-core-dev
1562020-05-11T08:22:33 *** Talkless has joined #bitcoin-core-dev
1572020-05-11T08:29:41 *** proofofkeags has joined #bitcoin-core-dev
1582020-05-11T08:31:51 *** dfmb_ has joined #bitcoin-core-dev
1592020-05-11T08:34:46 *** proofofkeags has quit IRC
1602020-05-11T08:38:01 *** kljasdfvv has joined #bitcoin-core-dev
1612020-05-11T08:39:48 *** nsh has quit IRC
1622020-05-11T08:39:48 *** nsh has joined #bitcoin-core-dev
1632020-05-11T08:40:40 *** Guyver2_ has joined #bitcoin-core-dev
1642020-05-11T08:43:20 *** Guyver2 has quit IRC
1652020-05-11T08:43:51 *** timothy has joined #bitcoin-core-dev
1662020-05-11T08:47:04 *** manantial has quit IRC
1672020-05-11T08:47:57 *** promag has joined #bitcoin-core-dev
1682020-05-11T08:50:12 *** promag_ has joined #bitcoin-core-dev
1692020-05-11T09:00:02 *** SRV_DW20 has quit IRC
1702020-05-11T09:06:53 *** murr5y has left #bitcoin-core-dev
1712020-05-11T09:08:13 *** murr4y has joined #bitcoin-core-dev
1722020-05-11T09:12:53 *** manantial has joined #bitcoin-core-dev
1732020-05-11T09:22:17 *** andrea has joined #bitcoin-core-dev
1742020-05-11T09:22:42 *** andrea is now known as Guest85500
1752020-05-11T09:23:13 *** per has joined #bitcoin-core-dev
1762020-05-11T09:29:43 *** promag_ has quit IRC
1772020-05-11T09:36:40 *** promag_ has joined #bitcoin-core-dev
1782020-05-11T09:41:38 *** emilengler has joined #bitcoin-core-dev
1792020-05-11T09:47:51 *** proofofkeags has joined #bitcoin-core-dev
1802020-05-11T09:49:30 *** kljasdfvv has quit IRC
1812020-05-11T09:50:45 *** kljasdfvv has joined #bitcoin-core-dev
1822020-05-11T09:52:19 *** proofofkeags has quit IRC
1832020-05-11T10:02:36 *** kljasdfvv has quit IRC
1842020-05-11T10:03:54 *** kljasdfvv has joined #bitcoin-core-dev
1852020-05-11T10:04:21 *** waxwing_ has left #bitcoin-core-dev
1862020-05-11T10:04:58 *** waxwing has joined #bitcoin-core-dev
1872020-05-11T10:10:37 *** Zenton has quit IRC
1882020-05-11T10:10:58 *** Zenton has joined #bitcoin-core-dev
1892020-05-11T10:11:01 *** surja795 has joined #bitcoin-core-dev
1902020-05-11T10:23:31 *** bitdex has quit IRC
1912020-05-11T10:24:02 *** bitdex has joined #bitcoin-core-dev
1922020-05-11T10:25:14 *** surja795 has quit IRC
1932020-05-11T10:25:50 *** surja795 has joined #bitcoin-core-dev
1942020-05-11T10:30:12 *** surja795 has quit IRC
1952020-05-11T11:01:36 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1962020-05-11T11:02:00 *** Mercury_Vapor has quit IRC
1972020-05-11T11:02:26 *** Mercury_Vapor has joined #bitcoin-core-dev
1982020-05-11T11:17:44 *** Dean_Guss has joined #bitcoin-core-dev
1992020-05-11T11:19:23 *** DeanWeen has quit IRC
2002020-05-11T11:23:09 *** TD--Linux has quit IRC
2012020-05-11T11:23:10 *** TD--Linux has joined #bitcoin-core-dev
2022020-05-11T11:23:16 *** TD--Linux is now known as TD-Linux
2032020-05-11T11:24:05 *** surja795 has joined #bitcoin-core-dev
2042020-05-11T11:28:47 *** surja795 has quit IRC
2052020-05-11T11:29:09 *** Dean_Guss has quit IRC
2062020-05-11T11:39:44 *** promag has quit IRC
2072020-05-11T11:46:30 *** kristapsk has quit IRC
2082020-05-11T11:47:29 *** kristapsk has joined #bitcoin-core-dev
2092020-05-11T11:48:47 *** promag has joined #bitcoin-core-dev
2102020-05-11T11:48:52 *** proofofkeags has joined #bitcoin-core-dev
2112020-05-11T11:52:54 *** proofofkeags has quit IRC
2122020-05-11T11:53:07 *** promag has quit IRC
2132020-05-11T11:54:31 *** Motorka has joined #bitcoin-core-dev
2142020-05-11T11:54:32 <wumpus> FWIW I completely agree with amit
2152020-05-11T11:55:33 <wumpus> she's not telling to stop contributing, just that at some point you might want to move on from 'good first issues' and give new users a chance at them
2162020-05-11T11:55:56 <wumpus> it definitely wasn't worded in a mean or harmful way
2172020-05-11T11:56:57 *** Motorka has left #bitcoin-core-dev
2182020-05-11T11:57:56 <wumpus> that brakmic interpreted it the wrong way sucks though, but, calling for "removing people from the repository" for this really goes too far
2192020-05-11T11:58:35 *** AaronvanW has joined #bitcoin-core-dev
2202020-05-11T11:59:11 <wumpus> please leave the project yourself if you want things to work that way
2212020-05-11T12:00:01 *** Guest85500 has quit IRC
2222020-05-11T12:03:19 *** Aaronvan_ has joined #bitcoin-core-dev
2232020-05-11T12:06:46 *** AaronvanW has quit IRC
2242020-05-11T12:10:45 *** surja795 has joined #bitcoin-core-dev
2252020-05-11T12:15:27 *** surja795 has quit IRC
2262020-05-11T12:18:45 <wumpus> I really want to push forward with 0.20.0 so I'm going to triage things labeled 0.20.0 somewhat more strictly
2272020-05-11T12:22:24 *** LaserShark has joined #bitcoin-core-dev
2282020-05-11T12:29:32 *** AaronvanW has joined #bitcoin-core-dev
2292020-05-11T12:29:42 *** promag has joined #bitcoin-core-dev
2302020-05-11T12:29:58 *** ctrlbreak has quit IRC
2312020-05-11T12:30:25 *** ctrlbreak has joined #bitcoin-core-dev
2322020-05-11T12:32:33 *** surja795 has joined #bitcoin-core-dev
2332020-05-11T12:32:36 *** Aaronvan_ has quit IRC
2342020-05-11T12:34:26 *** promag has quit IRC
2352020-05-11T12:35:09 *** mol_ has joined #bitcoin-core-dev
2362020-05-11T12:35:47 *** Motorka has joined #bitcoin-core-dev
2372020-05-11T12:35:58 *** Motorka has left #bitcoin-core-dev
2382020-05-11T12:37:21 *** surja795 has quit IRC
2392020-05-11T12:37:25 *** mol has quit IRC
2402020-05-11T12:39:07 <jonatack> I passed a similar message to brakmic a couple of weeks ago by private IRC discussion. It went very well and he came out of it with a noticeable commitment to reviewing other contributors' work, where he was seeing new opportunities to contribute off the beaten path. I reckon one further private discussion would have resolved this completely and wish I had done that.
2412020-05-11T12:41:50 <fjahr> That's a great approach jonatack
2422020-05-11T12:41:56 <fjahr> Amiti's intentions were only positive, absolutely, and removing her from the repo is out of the question. But I have to say I can also feel for brakmic that this must have been demoralizing because he did other things like reviews as jon said and most of his "good first issue" PRs were ~6 months old. If nobody took them by then I think it's fair to assume that maybe they were not so beginner friendly? Amiti's
2432020-05-11T12:41:56 <fjahr> post also got a lot of positive reactions, so he must have felt isolated at that moment.
2442020-05-11T12:42:09 <fjahr> I think more or less what Marco said in the issue: If beginners think there are not enough "good first issue" issues then we just need to create more. It's not like there is a lack of opportunities in the codebase, beginners just need guidance to find them. I also think we should encourage reviewing more as a way to get started. Traditionally reviewing tickets is more a "senior dev" thing and so many beginners
2452020-05-11T12:42:09 <fjahr> seem to think they need to get something merged first before they can be a reviewer. We can see it in the review club too: people say they reviewed the PR and can participate in the discussion, yet don't seem to have the courage to give a Concept ACK.
2462020-05-11T12:50:50 *** fox2p has joined #bitcoin-core-dev
2472020-05-11T12:52:11 <wumpus> I think it's good to reach out to brakmic in any case
2482020-05-11T12:52:21 *** fox2p has quit IRC
2492020-05-11T12:52:38 *** foxp2 has joined #bitcoin-core-dev
2502020-05-11T12:55:11 <wumpus> I very much understand how stressful it is to do PRs to bitcoin core in the first place, and this was probably the last straw for him
2512020-05-11T12:59:14 *** geeker has quit IRC
2522020-05-11T12:59:25 *** bitcoin-git has joined #bitcoin-core-dev
2532020-05-11T12:59:25 <bitcoin-git> [bitcoin] laanwj merged pull request #18748: [0.20] rc2 Backports (0.20...0_20_rc2_backports) https://github.com/bitcoin/bitcoin/pull/18748
2542020-05-11T12:59:27 *** bitcoin-git has left #bitcoin-core-dev
2552020-05-11T12:59:50 *** geeker has joined #bitcoin-core-dev
2562020-05-11T13:00:18 *** foxp2 has quit IRC
2572020-05-11T13:04:25 *** geeker has quit IRC
2582020-05-11T13:08:53 *** promag__ has joined #bitcoin-core-dev
2592020-05-11T13:08:54 *** promag_ has quit IRC
2602020-05-11T13:09:51 *** molakala has joined #bitcoin-core-dev
2612020-05-11T13:12:12 *** bitcoin-git has joined #bitcoin-core-dev
2622020-05-11T13:12:13 <bitcoin-git> [bitcoin] laanwj opened pull request #18945: build: Ensure source tarball has leading directory name (0.20...2020_11_0.20_tarball_prefix) https://github.com/bitcoin/bitcoin/pull/18945
2632020-05-11T13:12:13 *** bitcoin-git has left #bitcoin-core-dev
2642020-05-11T13:15:39 *** foxp2 has joined #bitcoin-core-dev
2652020-05-11T13:15:55 *** foxp2 has quit IRC
2662020-05-11T13:19:37 <instagibbs> She knows full well how it is to be a new contributor, I'm certain it's miscommunication. Let's be extra sensitive to newcomers!
2672020-05-11T13:19:59 *** foxp2 has joined #bitcoin-core-dev
2682020-05-11T13:30:39 *** promag has joined #bitcoin-core-dev
2692020-05-11T13:30:46 *** surja795 has joined #bitcoin-core-dev
2702020-05-11T13:31:55 *** LaserShark has quit IRC
2712020-05-11T13:33:54 <wumpus> agreed
2722020-05-11T13:35:37 *** surja795 has quit IRC
2732020-05-11T13:37:51 *** foxp2 has quit IRC
2742020-05-11T13:40:48 *** foxp2 has joined #bitcoin-core-dev
2752020-05-11T13:41:43 *** afk11` has quit IRC
2762020-05-11T13:42:31 *** afk11` has joined #bitcoin-core-dev
2772020-05-11T13:48:30 *** tss1 has joined #bitcoin-core-dev
2782020-05-11T13:49:41 *** proofofkeags has joined #bitcoin-core-dev
2792020-05-11T13:53:08 <jonatack> reached out via keybase
2802020-05-11T13:54:09 *** proofofkeags has quit IRC
2812020-05-11T13:54:35 *** dviola has joined #bitcoin-core-dev
2822020-05-11T13:58:45 *** mdunnio has joined #bitcoin-core-dev
2832020-05-11T14:01:26 *** mdunnio has quit IRC
2842020-05-11T14:01:42 *** bitcoin-git has joined #bitcoin-core-dev
2852020-05-11T14:01:43 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18946: rpcwallet: Replace boost::optional<T>::emplace with simple assignment of T{} (master...2005-rpcWalletOptional) https://github.com/bitcoin/bitcoin/pull/18946
2862020-05-11T14:01:43 *** bitcoin-git has left #bitcoin-core-dev
2872020-05-11T14:02:03 *** mdunnio has joined #bitcoin-core-dev
2882020-05-11T14:11:02 *** bitcoin-git has joined #bitcoin-core-dev
2892020-05-11T14:11:03 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ec4d27fa8bdc...f71a3a882974
2902020-05-11T14:11:03 <bitcoin-git> bitcoin/master 872aa25 Martin Zumsande: doc: add c++17-enable to fuzzing instructions
2912020-05-11T14:11:04 <bitcoin-git> bitcoin/master f71a3a8 MarcoFalke: Merge #18939: doc: add c++17-enable flag to fuzzing instructions
2922020-05-11T14:11:05 *** bitcoin-git has left #bitcoin-core-dev
2932020-05-11T14:11:22 *** bitcoin-git has joined #bitcoin-core-dev
2942020-05-11T14:11:23 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18939: doc: add c++17-enable flag to fuzzing instructions (master...202005_fuzz_doc) https://github.com/bitcoin/bitcoin/pull/18939
2952020-05-11T14:11:24 *** bitcoin-git has left #bitcoin-core-dev
2962020-05-11T14:20:23 *** promag__ has quit IRC
2972020-05-11T14:22:22 *** promag_ has joined #bitcoin-core-dev
2982020-05-11T14:23:34 <provoostenator> It's a pain to navigate to a milestone in Github, so I'll just spam this link, also a reminder to self: https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.20.0
2992020-05-11T14:24:46 <wumpus> what i tend to do is click the "0.20.0" next to a PR, though that ends up here (both issues and PRs view): https://github.com/bitcoin/bitcoin/milestone/42
3002020-05-11T14:30:02 *** mol_ has quit IRC
3012020-05-11T14:30:54 *** promag has quit IRC
3022020-05-11T14:32:13 <theStack> Talking from the perspective of someone who also started contributing to core not too long ago, I can confirm that in the very beginning
3032020-05-11T14:32:16 <theStack> 1) it can be quite frustrating to repeatedly see that an new interesting looking "good first issue" is taken fast; those are really
3042020-05-11T14:32:19 <theStack> _awesome_ onboarding instruments, and it kind of feels disappointing and is against its basic idea of educating if they are tackled
3052020-05-11T14:32:22 <theStack> by people which are already way more advanced (not talking about the many months old ones issues here though)
3062020-05-11T14:32:28 <theStack> 2) there is a strong mindset of "i have to contribute first before i do anything else", as one might feel the need to
3072020-05-11T14:32:31 <theStack> first get some reputation, as otherwise one may isn't taken seriously; that's why maybe even more people were kind of
3082020-05-11T14:32:34 <theStack> waiting for new "good first issues" (there is even a twitter bot for it!) and Amiti's post did get so many thumbs up.
3092020-05-11T14:32:37 <theStack> I think that this was in no way meant rude by Amiti. I'd even go so far and say it can be seen as a compliment,
3102020-05-11T14:32:40 <theStack> like "you have advanced to a level where good first issues are too easy for you".
3112020-05-11T14:32:54 <theStack> I'm glad to see how fast the reactions were and how everyone tries to clear the issue. A sign for a strong
3122020-05-11T14:32:57 <theStack> community actually. Of course, I also hope brakmic comes back soon.
3132020-05-11T14:34:46 *** surja795 has joined #bitcoin-core-dev
3142020-05-11T14:34:49 <provoostenator> I must say I never picked a "good first issue" when I started out. Not saying that was smart of me, but just to add a data point.
3152020-05-11T14:35:21 <provoostenator> I just picked something that bothered me and apparently didn't bother anyone else enough to deal with it first :-)
3162020-05-11T14:35:39 <provoostenator> But my first PR took several months to get merged, so...
3172020-05-11T14:38:13 *** promag_ has quit IRC
3182020-05-11T14:38:27 <wumpus> thanks for weighing in; I think having contributed *something* is good before starting to review, unless you can somehow start reviewing at a deep technical level without having written any code for bitcoin core (e.g. contributor to a similar or adjacent project), but that's rare
3192020-05-11T14:38:49 *** promag has joined #bitcoin-core-dev
3202020-05-11T14:39:25 <wumpus> though it's always 'taken seriously' if you point out problems in review, to be clear
3212020-05-11T14:39:49 *** surja795 has quit IRC
3222020-05-11T14:40:11 *** bitcoin-git has joined #bitcoin-core-dev
3232020-05-11T14:40:11 <bitcoin-git> [bitcoin] hebasto opened pull request #18948: qt: Do not call setParent() for WalletModel instances (master...200511-qt-assert) https://github.com/bitcoin/bitcoin/pull/18948
3242020-05-11T14:40:13 *** bitcoin-git has left #bitcoin-core-dev
3252020-05-11T14:40:46 *** bitcoin-git has joined #bitcoin-core-dev
3262020-05-11T14:40:46 <bitcoin-git> [bitcoin] hebasto closed pull request #18883: qt: Fix OpenWalletActivity::open() (master...200505-fix-win) https://github.com/bitcoin/bitcoin/pull/18883
3272020-05-11T14:40:50 *** bitcoin-git has left #bitcoin-core-dev
3282020-05-11T14:41:26 *** promag has quit IRC
3292020-05-11T14:41:40 *** promag has joined #bitcoin-core-dev
3302020-05-11T14:41:42 <provoostenator> When I'm unfamiliar with the code during a review, the first thing I try is to break stuff. Then I can report that, and feel like I at least got something useful done.
3312020-05-11T14:42:23 <provoostenator> Though if you're very new to the project you may just find an existing bug, so it's important to compare to master.
3322020-05-11T14:45:20 <theStack> provoostenator: for me personally grep-ing for TODOs was quite a good strategy, besides of 'good first issues'
3332020-05-11T14:49:05 *** geeker has joined #bitcoin-core-dev
3342020-05-11T14:49:42 <theStack> wumpus: definitely agree to both of your points; there are also very good beginners resources out there (e.g. by jimmy song, jonatack, amiti...) that make clear how important reviewing is and that every opinion is considered worthy
3352020-05-11T14:49:53 *** someone235 has quit IRC
3362020-05-11T14:53:46 *** geeker has quit IRC
3372020-05-11T14:53:47 *** promag has quit IRC
3382020-05-11T14:53:51 *** promag_ has joined #bitcoin-core-dev
3392020-05-11T14:54:11 <jonatack> thanks theStack. this is in no way directed at you or anyone, but i feel the phrase itself "i have to contribute first before i do anything else" reveals something.
3402020-05-11T14:54:36 *** promag has joined #bitcoin-core-dev
3412020-05-11T14:54:40 <wumpus> the only possible situation I can imagine where someone is not taken seriously is when a new person starts commenting on things like source organization or aggressively pushing their code style preferences
3422020-05-11T14:55:14 <jonatack> the definition of "contribute" itself does not necessarily mean opening PRs
3432020-05-11T14:55:56 <jonatack> yet for a majority of new contributors it seems to be seen as exactly that: opening PRs
3442020-05-11T14:56:44 <jonatack> when one enters a new project repo (this one or another) and sees *hundreds* of open issues and PRs
3452020-05-11T14:58:52 <jonatack> it may be a bit ironic that the reflex is "i need to open PRs here!" ... idk how to improve this but am working on it
3462020-05-11T14:59:19 *** promag has quit IRC
3472020-05-11T15:00:02 *** tss1 has quit IRC
3482020-05-11T15:00:03 *** nothingmuch has joined #bitcoin-core-dev
3492020-05-11T15:00:08 <jonatack> it's not easy to strike a good balance
3502020-05-11T15:00:17 *** promag_ has quit IRC
3512020-05-11T15:01:21 <luke-jr> reviewing is one of the best ways to start contributing
3522020-05-11T15:01:32 *** proofofkeags has joined #bitcoin-core-dev
3532020-05-11T15:01:40 <luke-jr> not only are we bottlenecked on review, it helps you learn the code, expectations, etc
3542020-05-11T15:02:08 *** ghost43 has quit IRC
3552020-05-11T15:02:24 *** ghost43 has joined #bitcoin-core-dev
3562020-05-11T15:02:31 <luke-jr> (another good way is to write tests, but test-writing isn't a skill everyone has)
3572020-05-11T15:03:26 <theStack> jonatack: yes, mostly people tend to equate "contributing" only to "opening a PR"; the longer i am here the more i think that the most important contribution is actually reviewing
3582020-05-11T15:03:44 <jonatack> :love: :D
3592020-05-11T15:07:18 *** ghost43 has quit IRC
3602020-05-11T15:07:35 *** ghost43 has joined #bitcoin-core-dev
3612020-05-11T15:08:26 <jonatack> the challenge for me is to get faster at reviewing; all those PRs needing love are a bottleneck, so i don't allocate time to coding... < 5%, certainly... not sure what to do except get faster at reviewing.
3622020-05-11T15:09:04 *** geeker has joined #bitcoin-core-dev
3632020-05-11T15:10:16 <jonatack> luke-jr: +1
3642020-05-11T15:11:50 <luke-jr> MarcoFalke_2: I doubt we'll see the end of boost any time soon⦠There's no C++ standard alternative to Boost::Process in any version, right?
3652020-05-11T15:12:54 <jonatack> (but can't become complacent about reviewing either, or a vulnerability gets through)
3662020-05-11T15:13:33 <luke-jr> I've seen quite a few serious issues get through recently, but I don't want to scare off reviewing/merging either :/
3672020-05-11T15:14:09 <jonatack> yes, this is a fundamental tension
3682020-05-11T15:14:24 <yevaud> reviewing almost always has no real "output", which is obviously offputting.
3692020-05-11T15:14:57 <luke-jr> <MarcoFalke_2> luke-jr: At least we can drop the majority of boost. Keeping one or two boost modules might be fine.
3702020-05-11T15:15:00 <luke-jr> (he can't speak)
3712020-05-11T15:15:37 <sipa> i feel the most rewarding output of review is when both author and reviewer agree that the PR is in a better state due to the reviewers' comments
3722020-05-11T15:16:03 *** jb55 has quit IRC
3732020-05-11T15:19:38 *** jb55 has joined #bitcoin-core-dev
3742020-05-11T15:21:34 *** JackSparrow has joined #bitcoin-core-dev
3752020-05-11T15:22:56 *** theStack has quit IRC
3762020-05-11T15:25:02 <instagibbs> reviewing can be more of a fine art than throwing a PR out there
3772020-05-11T15:25:42 <instagibbs> need to know when to when not to nit, etc
3782020-05-11T15:32:33 <aj> what, why are my ears burning?
3792020-05-11T15:33:02 <jonatack> i see the whole project as a garden or farm... we are gardeners/farmers... the releases are the seasonal harvest
3802020-05-11T15:33:15 <jonatack> aj: nah, it was for me :)
3812020-05-11T15:33:46 <instagibbs> a seasoned PR writer knows when to ignore and let ACKs stack :P
3822020-05-11T15:34:03 <aj> don't stack sats, stack ACKs
3832020-05-11T15:34:12 <sipa> stACKs
3842020-05-11T15:34:30 *** Caralie has joined #bitcoin-core-dev
3852020-05-11T15:38:43 *** kristapsk has quit IRC
3862020-05-11T15:41:18 *** justanotheruser has quit IRC
3872020-05-11T15:41:49 *** MarcoFalke_2 has quit IRC
3882020-05-11T15:42:14 *** bitcoin-git has joined #bitcoin-core-dev
3892020-05-11T15:42:14 <bitcoin-git> [bitcoin] adamjonas opened pull request #18949: doc: Add CODEOWNERS file to automatically nominate PR reviewers (master...2020-5-add-codeowners) https://github.com/bitcoin/bitcoin/pull/18949
3902020-05-11T15:42:15 *** bitcoin-git has left #bitcoin-core-dev
3912020-05-11T15:43:38 *** MarcoFalke has joined #bitcoin-core-dev
3922020-05-11T15:44:08 <MarcoFalke> test
3932020-05-11T15:44:37 <sipa> fail
3942020-05-11T15:45:11 <MarcoFalke> [11:37] [435] MarcoFalke_2 MarcoFalke #bitcoin-core-dev Cannot change nickname while banned/quieted on channel
3952020-05-11T15:47:38 <MarcoFalke> I need a new IRC setup
3962020-05-11T15:48:17 <MarcoFalke> https://twitter.com/pwuille/status/1171669782065795072
3972020-05-11T15:48:43 <sipa> ha
3982020-05-11T15:50:54 *** surja795 has joined #bitcoin-core-dev
3992020-05-11T15:51:43 *** morcos has quit IRC
4002020-05-11T15:52:31 <phantomcircuit> gwillen, the way we use bdb is already comically paranoid, iirc every operation results in a complete flush
4012020-05-11T15:52:51 *** morcos has joined #bitcoin-core-dev
4022020-05-11T15:54:12 <MarcoFalke> [22:09] <luke-jr> [23:47:07] <sipa> MarcoFalke: i don't think issues should be closed because nobody is working on them <-- indeed, some look like "good first issue" material
4032020-05-11T15:54:37 <MarcoFalke> Just saw this and I think if someone proposed a gui improvement in 2016 or 2014, and no one has been working on it since, it should be fine to close
4042020-05-11T15:55:05 <MarcoFalke> We can't keep every feature request open indef
4052020-05-11T15:55:35 *** surja795 has quit IRC
4062020-05-11T15:56:30 <MarcoFalke> For bugs that are reproducible, maybe yes, but for improvements we need to cut them off at some point
4072020-05-11T15:57:36 <MarcoFalke> Btw ajonas has been helping me go through all issues. So I might do a second run to pick up those that qualify as "good first issues"
4082020-05-11T15:58:17 <sipa> MarcoFalke: if there was a better way to classify/keep track of issues, maybe there wouldn't be as much a desire to keep the issue list clean
4092020-05-11T15:58:25 *** dviola has quit IRC
4102020-05-11T15:58:58 <sipa> i agree with the sentiment; i think many issues are opened once, and then pretty much never looked at... making it useless and cluttering to keep them open
4112020-05-11T15:59:12 <aj> i thought the recent issue cleanups were good
4122020-05-11T15:59:32 <MarcoFalke> A few of the issues had been fixed long ago, but no one noticed. So I am thinkging that no one is wading through the issues in either case, so I wonder if closing them makes a difference at all
4132020-05-11T15:59:40 <MarcoFalke> They can still be searched through and commented on
4142020-05-11T15:59:48 <aj> it's good to have IDEAS pages and stuff (like gmaxwell's wiki things) but they don't need to be issues?
4152020-05-11T16:01:01 *** mol has joined #bitcoin-core-dev
4162020-05-11T16:01:14 <MarcoFalke> Sometimes it is good to create an issue to have an URL to point to when the topic comes up again. This is harder to to with IRC threads
4172020-05-11T16:02:44 <jb55> if we had encouraged more people to use codetriage it might help with the issue backlog. I'm not a fan of autoclosing personally.
4182020-05-11T16:03:58 *** proofofkeags has quit IRC
4192020-05-11T16:04:37 *** dviola has joined #bitcoin-core-dev
4202020-05-11T16:05:58 *** proofofkeags has joined #bitcoin-core-dev
4212020-05-11T16:07:05 *** foxp2 has quit IRC
4222020-05-11T16:08:41 *** justanotheruser has joined #bitcoin-core-dev
4232020-05-11T16:08:49 <luke-jr> MarcoFalke: I was thinking more of getting rid of the univalue fork
4242020-05-11T16:10:30 *** foxp2 has joined #bitcoin-core-dev
4252020-05-11T16:13:10 *** andrewtoth_ has joined #bitcoin-core-dev
4262020-05-11T16:13:43 *** _andrewtoth_ has quit IRC
4272020-05-11T16:14:53 *** andrewtoth_ has quit IRC
4282020-05-11T16:17:26 <MarcoFalke> The decision to close issues is subjective. When an issue has already been solved, or partially solved, but stale for a long time, or I haven't seen a way that something is going to be addressed any time soon or ever, I closed it.
4292020-05-11T16:18:30 <MarcoFalke> jb55: How is "codetriage" different from "good first issue" (the tag)?
4302020-05-11T16:23:23 *** vasild has quit IRC
4312020-05-11T16:24:58 *** vasild has joined #bitcoin-core-dev
4322020-05-11T16:26:42 *** Cavaleiro_R221 has joined #bitcoin-core-dev
4332020-05-11T16:29:11 *** vasild has quit IRC
4342020-05-11T16:31:48 *** geeker has quit IRC
4352020-05-11T16:32:24 *** geeker has joined #bitcoin-core-dev
4362020-05-11T16:35:22 <jb55> MarcoFalke: its tangentially related. I was just commenting on the growing backlog issue. you can subscribe and it sends periodic emails for stale issues to triage. the more people doing it the better.
4372020-05-11T16:35:28 *** dviola has quit IRC
4382020-05-11T16:35:58 *** dviola has joined #bitcoin-core-dev
4392020-05-11T16:36:20 <jb55> usually along the lines of "hey, whats the status of this?" "can this be closed" from there perhaps users can triage old issues into "good first issues".
4402020-05-11T16:37:22 *** geeker has quit IRC
4412020-05-11T16:37:48 *** kristapsk has joined #bitcoin-core-dev
4422020-05-11T16:47:10 *** bitbee has quit IRC
4432020-05-11T16:47:57 *** bitbee has joined #bitcoin-core-dev
4442020-05-11T16:48:17 *** foxp2 has quit IRC
4452020-05-11T16:48:42 *** ccc2 has joined #bitcoin-core-dev
4462020-05-11T16:51:05 *** promag has joined #bitcoin-core-dev
4472020-05-11T16:51:06 *** ccc2 has quit IRC
4482020-05-11T16:55:27 *** promag has quit IRC
4492020-05-11T17:08:17 *** surja795 has joined #bitcoin-core-dev
4502020-05-11T17:08:43 *** Caralie has quit IRC
4512020-05-11T17:09:17 *** foxp2 has joined #bitcoin-core-dev
4522020-05-11T17:12:46 *** surja795 has quit IRC
4532020-05-11T17:15:45 *** promag has joined #bitcoin-core-dev
4542020-05-11T17:17:09 *** Dean_Guss has joined #bitcoin-core-dev
4552020-05-11T17:19:55 *** geeker has joined #bitcoin-core-dev
4562020-05-11T17:23:33 *** lightlike has joined #bitcoin-core-dev
4572020-05-11T17:24:36 *** geeker has quit IRC
4582020-05-11T17:29:43 *** AaronvanW has quit IRC
4592020-05-11T17:32:27 *** AaronvanW has joined #bitcoin-core-dev
4602020-05-11T17:36:20 *** promag_ has joined #bitcoin-core-dev
4612020-05-11T17:37:12 *** bitcoin-git has joined #bitcoin-core-dev
4622020-05-11T17:37:13 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f71a3a882974...eb2ffbb7c134
4632020-05-11T17:37:13 <bitcoin-git> bitcoin/master 1551cea Hennadii Stepanov: refactor: Use override for non-final overriders
4642020-05-11T17:37:14 <bitcoin-git> bitcoin/master d044e0e Hennadii Stepanov: refactor: Remove override for final overriders
4652020-05-11T17:37:14 <bitcoin-git> bitcoin/master eb2ffbb MarcoFalke: Merge #18914: refactor: Apply override specifier consistently
4662020-05-11T17:37:16 *** bitcoin-git has left #bitcoin-core-dev
4672020-05-11T17:37:32 *** bitcoin-git has joined #bitcoin-core-dev
4682020-05-11T17:37:32 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18914: refactor: Apply override specifier consistently (master...200508-override) https://github.com/bitcoin/bitcoin/pull/18914
4692020-05-11T17:37:35 *** bitcoin-git has left #bitcoin-core-dev
4702020-05-11T17:38:15 *** Cavaleiro_R221 has quit IRC
4712020-05-11T17:41:31 *** Highway61 has quit IRC
4722020-05-11T17:41:45 *** promag_ has quit IRC
4732020-05-11T17:51:12 *** geeker has joined #bitcoin-core-dev
4742020-05-11T17:51:13 *** owowo has quit IRC
4752020-05-11T17:52:18 *** proofofk_ has joined #bitcoin-core-dev
4762020-05-11T17:54:43 *** proofof__ has joined #bitcoin-core-dev
4772020-05-11T17:55:19 *** proofofkeags has quit IRC
4782020-05-11T17:55:30 *** geeker has quit IRC
4792020-05-11T17:57:32 *** proofofk_ has quit IRC
4802020-05-11T17:59:08 *** owowo has joined #bitcoin-core-dev
4812020-05-11T17:59:09 *** timothy has quit IRC
4822020-05-11T18:00:02 *** JackSparrow has quit IRC
4832020-05-11T18:05:24 *** bitbee has quit IRC
4842020-05-11T18:06:20 *** Highway61 has joined #bitcoin-core-dev
4852020-05-11T18:08:33 *** rabidus has joined #bitcoin-core-dev
4862020-05-11T18:17:08 *** surja795 has joined #bitcoin-core-dev
4872020-05-11T18:17:20 *** jkakar has joined #bitcoin-core-dev
4882020-05-11T18:21:40 *** surja795 has quit IRC
4892020-05-11T18:24:44 *** jorijn has quit IRC
4902020-05-11T18:26:59 *** aerth has left #bitcoin-core-dev
4912020-05-11T18:27:51 <gwillen> phantomcircuit: that makes sense and I'm really glad to hear it
4922020-05-11T18:31:57 <sipa> our bdb code went through several random mutations as long as problem reports were frequent
4932020-05-11T18:32:25 <sipa> and then stopped mutating once those problems went away... so we probably ended up in a very stable (but possible overly caution) way of using it
4942020-05-11T18:34:23 *** jeremyrubin has quit IRC
4952020-05-11T18:36:42 <gwillen> that doesn't necessarily seem like a reliable way to get correct behavior
4962020-05-11T18:36:56 <gwillen> but it's a reliable way to get almost-always-correct behavior I guess :-)
4972020-05-11T18:38:39 <sipa> yes, it's why i don't want to touch bdb with a ten-foot pole
4982020-05-11T18:38:59 <sipa> maybe an 11-foot pole is ok, though
4992020-05-11T18:40:05 <gwillen> hahaha
5002020-05-11T18:40:26 *** Guyver2_ is now known as Guyver2
5012020-05-11T18:40:37 <gwillen> I think many things work better if you fsync() constantly
5022020-05-11T18:40:46 <gwillen> but it makes them very slow
5032020-05-11T18:40:53 *** promag has quit IRC
5042020-05-11T18:41:37 *** promag has joined #bitcoin-core-dev
5052020-05-11T18:43:26 <jb55> so we're replacing it with sqlite right :D
5062020-05-11T18:44:02 <sipa> i think it's worth considering
5072020-05-11T18:46:34 <cfields> gwillen: which is why macOS's fsync doesn't really fully sync. Flushing is annoyingly platform-specific :\
5082020-05-11T18:46:53 *** tryphe_ has joined #bitcoin-core-dev
5092020-05-11T18:48:12 *** michaelfolkson has joined #bitcoin-core-dev
5102020-05-11T18:49:50 *** jorijn has joined #bitcoin-core-dev
5112020-05-11T18:49:54 *** tryphe has quit IRC
5122020-05-11T18:50:29 *** theStack has joined #bitcoin-core-dev
5132020-05-11T18:52:27 *** tryphe_ is now known as tryphe
5142020-05-11T18:55:09 *** proofofkeags has joined #bitcoin-core-dev
5152020-05-11T18:55:51 <theStack> we are 3 blocks away from the halving <3
5162020-05-11T18:58:10 *** proofof__ has quit IRC
5172020-05-11T19:02:24 *** vasild has joined #bitcoin-core-dev
5182020-05-11T19:03:54 *** bobbydobalina has joined #bitcoin-core-dev
5192020-05-11T19:08:57 <reardencode> 2 blocks!
5202020-05-11T19:09:53 <reardencode> nope, this countdown lies: https://www.bitcoinsensus.com/bitcoin-halving-countdown/
5212020-05-11T19:10:20 <instagibbs> was about to say hash or GTFO :P
5222020-05-11T19:10:30 <sipa> depending on whether you see 629999 or 630000 as the halvening time point, 2 or 3 blocks left
5232020-05-11T19:10:55 *** michaelfolkson has quit IRC
5242020-05-11T19:11:11 <MarcoFalke> If you run the bdb with eatmydata, it will be fast
5252020-05-11T19:11:16 <MarcoFalke> (don't do this at home)
5262020-05-11T19:11:36 <owowo> sounds like COVID-19, depending how you look at it, it's different :P
5272020-05-11T19:13:25 <reardencode> 000000000000000000030684c158973dafb512dc91f90420e6811e3f6a2ca79b for real now :)
5282020-05-11T19:15:33 <CubicEarth> sipa: 630000 is the first @ 6.25 ?
5292020-05-11T19:15:46 <sipa> CubicEarth: correct
5302020-05-11T19:16:06 <sipa> (but miners start working on that block as soon as 629999 happens...)
5312020-05-11T19:16:14 <sipa> or shortly after at least
5322020-05-11T19:16:41 <CubicEarth> So we might be waiting longer than normal for 630000 itself ;)
5332020-05-11T19:17:18 <CubicEarth> depending on how fast low margin miners turn off their rigs
5342020-05-11T19:18:09 <instagibbs> bragging rights, they'll keep rigs on one block longer ;)
5352020-05-11T19:18:21 <theStack> what? isn't the price instantly doubling on 630000? xD
5362020-05-11T19:19:17 *** meshcollider has quit IRC
5372020-05-11T19:20:09 <fjahr> miners should mine block 630k with 12.5 until one gets rejected just to make sure validation still works :p
5382020-05-11T19:20:39 <CubicEarth> theStack: Of course it will. Have some faith.
5392020-05-11T19:21:04 <jonatack> buy the rumor, sell the news... :p
5402020-05-11T19:22:17 <owowo> yay, my node finished to sync before halving
5412020-05-11T19:22:29 <theStack> fjahr: that would be quite some costly test :p
5422020-05-11T19:23:50 *** geeker has joined #bitcoin-core-dev
5432020-05-11T19:24:13 <sipa> 629999!
5442020-05-11T19:24:16 <owowo> 1!
5452020-05-11T19:24:20 <theStack> \o/
5462020-05-11T19:24:49 <owowo> !!!
5472020-05-11T19:24:49 <lightningbot> owowo: Error: "!" is not a valid command.
5482020-05-11T19:24:49 <gribble> Error: "!!" is not a valid command.
5492020-05-11T19:25:01 <owowo> 630000!
5502020-05-11T19:25:02 <CubicEarth> 630000000000
5512020-05-11T19:25:24 <owowo> 000000000000000000024bead8df69990852c202db0e0097c1a12ea637d7e96d
5522020-05-11T19:25:36 *** surja795 has joined #bitcoin-core-dev
5532020-05-11T19:25:37 <theStack> owowo: +1
5542020-05-11T19:25:59 <reardencode> !! AntPool!
5552020-05-11T19:25:59 <lightningbot> reardencode: Error: "AntPool!" is not a valid command.
5562020-05-11T19:26:00 <gribble> Error: "!" is not a valid command.
5572020-05-11T19:26:05 * owowo waits for the doubling of price, any moment now
5582020-05-11T19:27:06 *** danielyin has joined #bitcoin-core-dev
5592020-05-11T19:27:43 <owowo> ok, history made, good night, l0ve you all :)
5602020-05-11T19:28:15 <CubicEarth> Just 209,999 more blocks to go until the havening!
5612020-05-11T19:28:19 *** danielyi1 has joined #bitcoin-core-dev
5622020-05-11T19:28:25 *** geeker has quit IRC
5632020-05-11T19:28:34 <CubicEarth> 3.125 - here we come!
5642020-05-11T19:30:18 *** surja795 has quit IRC
5652020-05-11T19:30:48 *** meshcollider has joined #bitcoin-core-dev
5662020-05-11T19:31:41 <theStack> the yearly inflation rate has now lowered to <1,8% (if i'm calculating correctly)
5672020-05-11T19:34:02 *** sdaftuar has quit IRC
5682020-05-11T19:34:52 *** sdaftuar has joined #bitcoin-core-dev
5692020-05-11T19:39:37 *** nehan_ has quit IRC
5702020-05-11T19:41:26 *** nehan has joined #bitcoin-core-dev
5712020-05-11T19:42:31 *** EagleTM has joined #bitcoin-core-dev
5722020-05-11T20:10:49 *** SiAnDoG has quit IRC
5732020-05-11T20:10:57 *** SiAnDoG has joined #bitcoin-core-dev
5742020-05-11T20:13:14 *** surja795 has joined #bitcoin-core-dev
5752020-05-11T20:13:49 *** lightlike has quit IRC
5762020-05-11T20:15:45 *** jorijn_ has joined #bitcoin-core-dev
5772020-05-11T20:15:52 *** jorijn has quit IRC
5782020-05-11T20:16:45 *** promag has quit IRC
5792020-05-11T20:17:01 *** promag has joined #bitcoin-core-dev
5802020-05-11T20:19:15 *** bobbydobalina has quit IRC
5812020-05-11T20:25:33 <amiti> hey all, I read through the message history of the last ~day and Iâd like to share some thoughts
5822020-05-11T20:25:40 <amiti> I feel really sad that I created feelings of an unwelcoming environment for brakmic. That was exactly the opposite of my intent. I was trying to help create space for even more people to ramp up onto the project, but clearly that wasnât the message that came across and that really sucks. In no way did I intend to discourage him.
5832020-05-11T20:25:55 <amiti> I was actually working on a follow up comment to try to brainstorm some good places to search for more work (like looking at up-for-grabs closed issues), but was taken off guard by his response, and spent the rest of the day away from the keyboard. Obviously Iâm pretty new around here myself, and oof, good communication is much harder than C++
5842020-05-11T20:26:04 <amiti> I wrote some explanation on the issue trying to share where I was coming from. Iâm going to repeat some of it here, and share a bit more..
5852020-05-11T20:26:11 <amiti> I feel deeply grateful to get to work on bitcoin core on a daily basis. I 100% do not think I would be here if it werenât for the many of you who have believed in me & taught me so much, even when I doubt myself. Iâve found the bitcoin core community to be welcoming & supportive, and I wish to share that with others who feel intimidated but interested
5862020-05-11T20:26:27 <amiti> Several people have been reaching out to me lately about trying to figure out how to onboard, probably because of the different outreach stuff Iâve been doing. Some new contributors drew my attention to this pattern, leading to me leaving the comment. I figured most people who are contributing to the project donât realize that there are people lurking and searching for an issue to tackle, so I was trying to
5872020-05-11T20:26:28 <amiti> share that perspective and make a request. I really didnât realize my comment could come off so negatively.
5882020-05-11T20:26:35 <amiti> In terms of onboarding newcomers, I agree that review is super important, and also that itâs really hard. One barrier to this for newcomers is they see a huge backlog and they donât know where to start. So something Iâve started doing is choosing test PRs and trying to directly hand them out. Maybe a possible idea here is to create a similar label along the lines of âgood first reviewâ.
5892020-05-11T20:26:42 <amiti> And another thing thatâs becoming more apparent to me is that even after the first issues & first reviews, it can also be tricky to figure out whatâs next. I know many people feel like too-much-to-do-too-little-time, but on the other hand there are people looking for work thatâs within their skillset and would be helpful. I wonder how we as a community could help better match these together.
5902020-05-11T20:26:47 <amiti> This whole interaction has really surprised me with how itâs played out. The nice part of it has been seeing in action how much you all care about creating a supportive environment.
5912020-05-11T20:26:48 *** michaelfolkson has joined #bitcoin-core-dev
5922020-05-11T20:26:52 <amiti> Iâm learning a lot and I appreciate your patience with me along the way. Its an honor to work with you all on bitcoin core <3
5932020-05-11T20:26:58 <amiti> fin
5942020-05-11T20:31:53 *** bitcoin-git has joined #bitcoin-core-dev
5952020-05-11T20:31:54 <bitcoin-git> [bitcoin] fametrano opened pull request #18952: avoided os-dependant path (master...patch-2) https://github.com/bitcoin/bitcoin/pull/18952
5962020-05-11T20:31:55 *** bitcoin-git has left #bitcoin-core-dev
5972020-05-11T20:33:09 *** promag_ has joined #bitcoin-core-dev
5982020-05-11T20:33:09 *** promag has quit IRC
5992020-05-11T20:33:35 *** targon has joined #bitcoin-core-dev
6002020-05-11T20:36:25 *** michaelfolkson has quit IRC
6012020-05-11T20:38:27 *** promag_ has quit IRC
6022020-05-11T20:39:04 *** promag has joined #bitcoin-core-dev
6032020-05-11T20:44:29 *** promag_ has joined #bitcoin-core-dev
6042020-05-11T20:50:04 *** danielyin has quit IRC
6052020-05-11T20:50:05 *** danielyi1 has quit IRC
6062020-05-11T20:54:49 *** Chris_Stewart_5 has quit IRC
6072020-05-11T21:00:02 *** jkakar has quit IRC
6082020-05-11T21:02:31 <jb55> it's all good sounds like it was just some miscommunication
6092020-05-11T21:02:31 *** jarthur has joined #bitcoin-core-dev
6102020-05-11T21:06:57 *** geeker has joined #bitcoin-core-dev
6112020-05-11T21:09:59 *** mol has quit IRC
6122020-05-11T21:10:55 *** foxp2 has quit IRC
6132020-05-11T21:11:36 *** geeker has quit IRC
6142020-05-11T21:20:00 *** wright has joined #bitcoin-core-dev
6152020-05-11T21:31:26 <sipa> amiti: communication is hard
6162020-05-11T21:39:32 *** promag_ has quit IRC
6172020-05-11T21:40:11 *** mol has joined #bitcoin-core-dev
6182020-05-11T21:40:16 *** promag_ has joined #bitcoin-core-dev
6192020-05-11T21:51:48 *** Pavlenex has joined #bitcoin-core-dev
6202020-05-11T21:53:06 *** targon has quit IRC
6212020-05-11T21:53:34 <Pavlenex> Hey. Who's in charge of Transifex? Translated 0.20 in Serbian from scratch but there's no moderator for the language, so it can't be reviewed. Can anybody provide me with a reviewer access so we can proceed? Thanks.
6222020-05-11T21:54:31 *** theStack has quit IRC
6232020-05-11T21:57:32 *** molakala has quit IRC
6242020-05-11T21:59:50 *** bitcoin-git has joined #bitcoin-core-dev
6252020-05-11T21:59:50 <bitcoin-git> [bitcoin] andrewtoth closed pull request #18941: validation: Persist coins cache to disk and load on startup (master...persist-coinscache) https://github.com/bitcoin/bitcoin/pull/18941
6262020-05-11T21:59:51 *** bitcoin-git has left #bitcoin-core-dev
6272020-05-11T22:04:11 *** EagleTM has quit IRC
6282020-05-11T22:09:44 *** surja795 has quit IRC
6292020-05-11T22:10:47 *** Pavlenex has quit IRC
6302020-05-11T22:13:59 *** pandito has joined #bitcoin-core-dev
6312020-05-11T22:14:56 *** pandito has quit IRC
6322020-05-11T22:18:44 *** marcoagner has quit IRC
6332020-05-11T22:20:01 *** promag_ has quit IRC
6342020-05-11T22:20:20 *** promag_ has joined #bitcoin-core-dev
6352020-05-11T22:22:24 *** Guyver2 has quit IRC
6362020-05-11T22:27:19 *** Chris_Stewart_5 has joined #bitcoin-core-dev
6372020-05-11T22:36:36 *** emilengler has quit IRC
6382020-05-11T22:36:58 *** Pavlenex has joined #bitcoin-core-dev
6392020-05-11T22:41:25 *** vasild has quit IRC
6402020-05-11T22:41:40 *** vasild has joined #bitcoin-core-dev
6412020-05-11T22:41:51 *** RikAinSoph has joined #bitcoin-core-dev
6422020-05-11T22:45:13 *** filchef has joined #bitcoin-core-dev
6432020-05-11T22:45:41 *** dviola has quit IRC
6442020-05-11T22:46:45 *** filchef has quit IRC
6452020-05-11T22:47:43 *** foxp2 has joined #bitcoin-core-dev
6462020-05-11T22:53:51 *** promag_ has quit IRC
6472020-05-11T22:55:48 *** promag_ has joined #bitcoin-core-dev
6482020-05-11T22:58:26 *** manantial has quit IRC
6492020-05-11T23:00:17 *** Pavlenex has quit IRC
6502020-05-11T23:04:08 *** mdunnio has quit IRC
6512020-05-11T23:10:12 *** geeker has joined #bitcoin-core-dev
6522020-05-11T23:10:45 *** RikAinSoph has quit IRC
6532020-05-11T23:11:18 *** mdunnio has joined #bitcoin-core-dev
6542020-05-11T23:15:13 *** geeker has quit IRC
6552020-05-11T23:16:06 *** mdunnio has quit IRC
6562020-05-11T23:17:31 *** DeanWeen has joined #bitcoin-core-dev
6572020-05-11T23:18:11 *** surja795 has joined #bitcoin-core-dev
6582020-05-11T23:18:35 <gleb> I was very happy to find "bitpeers" today, the go tool which parses peers.dat in various ways. Not sure people here are aware of it, just wanted to share :)
6592020-05-11T23:19:23 *** Dean_Guss has quit IRC
6602020-05-11T23:20:41 *** AaronvanW has quit IRC
6612020-05-11T23:23:13 *** promag_ has quit IRC
6622020-05-11T23:23:18 *** pinheadmz has quit IRC
6632020-05-11T23:25:27 *** pinheadmz has joined #bitcoin-core-dev
6642020-05-11T23:30:24 *** pinheadmz_ has joined #bitcoin-core-dev
6652020-05-11T23:31:50 *** pinheadmz_ has quit IRC
6662020-05-11T23:33:19 *** pinheadmz_ has joined #bitcoin-core-dev
6672020-05-11T23:34:32 *** EagleTM has joined #bitcoin-core-dev
6682020-05-11T23:35:24 *** pinheadmz_ has quit IRC
6692020-05-11T23:42:56 *** Dean_Guss has joined #bitcoin-core-dev
6702020-05-11T23:43:43 *** DeanWeen has quit IRC
6712020-05-11T23:47:18 *** pinheadmz has quit IRC
6722020-05-11T23:47:45 *** pinheadmz has joined #bitcoin-core-dev
6732020-05-11T23:50:01 *** Chris_Stewart_5 has quit IRC
6742020-05-11T23:50:25 *** foxp2 has quit IRC
6752020-05-11T23:50:59 *** geeker has joined #bitcoin-core-dev
6762020-05-11T23:52:33 *** pinheadmz has quit IRC
6772020-05-11T23:52:46 *** pinheadmz has joined #bitcoin-core-dev
6782020-05-11T23:53:31 *** pinheadmz_ has joined #bitcoin-core-dev
6792020-05-11T23:53:45 *** pinheadmz_ has quit IRC
6802020-05-11T23:54:09 *** foxp2 has joined #bitcoin-core-dev
6812020-05-11T23:55:16 *** geeker has quit IRC
6822020-05-11T23:56:50 *** foxp2 has quit IRC