1 2020-05-13T00:00:02  *** cassier has quit IRC
  2 2020-05-13T00:00:54  *** dfmb_ has quit IRC
  3 2020-05-13T00:06:10  *** tryphe__ has joined #bitcoin-core-dev
  4 2020-05-13T00:06:37  *** tryphe_ has quit IRC
  5 2020-05-13T00:08:31  *** lightlike has quit IRC
  6 2020-05-13T00:10:56  *** Luke has joined #bitcoin-core-dev
  7 2020-05-13T00:13:04  *** promag has quit IRC
  8 2020-05-13T00:22:09  *** bstarr has joined #bitcoin-core-dev
  9 2020-05-13T00:40:58  *** proofofkeags has quit IRC
 10 2020-05-13T00:41:33  *** proofofkeags has joined #bitcoin-core-dev
 11 2020-05-13T00:44:18  *** mol has quit IRC
 12 2020-05-13T00:44:32  *** promag has joined #bitcoin-core-dev
 13 2020-05-13T00:46:21  *** proofofkeags has quit IRC
 14 2020-05-13T00:46:26  *** surja795 has joined #bitcoin-core-dev
 15 2020-05-13T00:57:14  *** promag has quit IRC
 16 2020-05-13T01:00:54  *** AaronvanW has quit IRC
 17 2020-05-13T01:02:17  *** Luke has quit IRC
 18 2020-05-13T01:09:27  *** tryphe__ is now known as tryphe
 19 2020-05-13T01:11:10  *** proofofkeags has joined #bitcoin-core-dev
 20 2020-05-13T01:25:28  *** Highway61 has quit IRC
 21 2020-05-13T01:48:57  *** mol_ has joined #bitcoin-core-dev
 22 2020-05-13T02:03:33  *** bitdex has joined #bitcoin-core-dev
 23 2020-05-13T02:15:23  *** bitcoin-git has joined #bitcoin-core-dev
 24 2020-05-13T02:15:23  <bitcoin-git> [bitcoin] 10xcryptodev opened pull request #18965: tests: implement base58_decode (master...tests_base58decode) https://github.com/bitcoin/bitcoin/pull/18965
 25 2020-05-13T02:15:25  *** bitcoin-git has left #bitcoin-core-dev
 26 2020-05-13T02:26:12  *** geeker has quit IRC
 27 2020-05-13T02:37:43  *** shesek has quit IRC
 28 2020-05-13T02:38:11  *** shesek has joined #bitcoin-core-dev
 29 2020-05-13T02:38:11  *** promag_ has quit IRC
 30 2020-05-13T02:38:11  *** shesek has quit IRC
 31 2020-05-13T02:38:11  *** shesek has joined #bitcoin-core-dev
 32 2020-05-13T02:38:41  *** promag has joined #bitcoin-core-dev
 33 2020-05-13T02:39:21  *** promag has joined #bitcoin-core-dev
 34 2020-05-13T02:41:09  *** Chris_Stewart_5 has quit IRC
 35 2020-05-13T02:42:03  *** jarthur has quit IRC
 36 2020-05-13T02:53:12  *** molz_ has joined #bitcoin-core-dev
 37 2020-05-13T02:56:58  *** mol_ has quit IRC
 38 2020-05-13T03:00:02  *** bstarr has quit IRC
 39 2020-05-13T03:05:48  *** Eagle[TM] has joined #bitcoin-core-dev
 40 2020-05-13T03:06:18  *** EagleTM has quit IRC
 41 2020-05-13T03:18:51  *** Xing`1 has joined #bitcoin-core-dev
 42 2020-05-13T03:25:26  *** surja795 has quit IRC
 43 2020-05-13T03:30:44  *** tryphe_ has joined #bitcoin-core-dev
 44 2020-05-13T03:31:15  *** tryphe has quit IRC
 45 2020-05-13T03:32:31  *** surja795 has joined #bitcoin-core-dev
 46 2020-05-13T03:35:43  *** tryphe_ has quit IRC
 47 2020-05-13T03:37:15  *** surja795 has quit IRC
 48 2020-05-13T04:16:08  *** jnewbery has quit IRC
 49 2020-05-13T04:16:45  *** proofofkeags has quit IRC
 50 2020-05-13T04:17:21  *** proofofkeags has joined #bitcoin-core-dev
 51 2020-05-13T04:19:58  *** vasild_ has joined #bitcoin-core-dev
 52 2020-05-13T04:21:44  *** proofofkeags has quit IRC
 53 2020-05-13T04:23:03  *** vasild has quit IRC
 54 2020-05-13T04:23:04  *** vasild_ is now known as vasild
 55 2020-05-13T04:32:33  *** jnewbery has joined #bitcoin-core-dev
 56 2020-05-13T04:34:07  *** ppisati has quit IRC
 57 2020-05-13T04:40:48  *** ppisati has joined #bitcoin-core-dev
 58 2020-05-13T04:58:52  *** mol_ has joined #bitcoin-core-dev
 59 2020-05-13T05:01:47  *** molz_ has quit IRC
 60 2020-05-13T05:10:10  *** proofofkeags has joined #bitcoin-core-dev
 61 2020-05-13T05:14:43  *** proofofkeags has quit IRC
 62 2020-05-13T05:33:09  *** mol_ has quit IRC
 63 2020-05-13T05:33:31  *** mol_ has joined #bitcoin-core-dev
 64 2020-05-13T05:59:21  *** Highway61 has joined #bitcoin-core-dev
 65 2020-05-13T06:00:02  *** Xing`1 has quit IRC
 66 2020-05-13T06:01:14  *** manantial has joined #bitcoin-core-dev
 67 2020-05-13T06:17:23  *** Greedi has joined #bitcoin-core-dev
 68 2020-05-13T06:24:38  *** promag_ has joined #bitcoin-core-dev
 69 2020-05-13T06:24:42  *** promag has quit IRC
 70 2020-05-13T06:25:54  *** promag has joined #bitcoin-core-dev
 71 2020-05-13T06:25:54  *** promag_ has quit IRC
 72 2020-05-13T06:27:09  *** Guyver2 has joined #bitcoin-core-dev
 73 2020-05-13T06:28:19  *** vasild has quit IRC
 74 2020-05-13T06:28:31  *** vasild has joined #bitcoin-core-dev
 75 2020-05-13T06:41:01  *** tmoc has joined #bitcoin-core-dev
 76 2020-05-13T07:08:07  *** harrigan has quit IRC
 77 2020-05-13T07:10:47  *** harrigan has joined #bitcoin-core-dev
 78 2020-05-13T07:18:34  *** exhoplex1 has quit IRC
 79 2020-05-13T07:18:42  *** Guyver2 has quit IRC
 80 2020-05-13T07:19:27  *** exhoplex has quit IRC
 81 2020-05-13T07:19:36  *** bitcoin-git has joined #bitcoin-core-dev
 82 2020-05-13T07:19:38  <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/8da1e43b63cb...219c55da752d
 83 2020-05-13T07:19:38  <bitcoin-git> bitcoin/master de5e91c Hennadii Stepanov: refactor: Add BerkeleyDatabaseVersion() function
 84 2020-05-13T07:19:39  <bitcoin-git> bitcoin/master 839add1 Hennadii Stepanov: build: Enable -Wsuggest-override
 85 2020-05-13T07:19:39  <bitcoin-git> bitcoin/master 219c55d fanquake: Merge #16710: build: Enable -Wsuggest-override if available
 86 2020-05-13T07:19:40  *** bitcoin-git has left #bitcoin-core-dev
 87 2020-05-13T07:20:58  *** bitcoin-git has joined #bitcoin-core-dev
 88 2020-05-13T07:20:58  <bitcoin-git> [bitcoin] fanquake merged pull request #16710: build: Enable -Wsuggest-override if available (master...20190824-consistent-override) https://github.com/bitcoin/bitcoin/pull/16710
 89 2020-05-13T07:20:59  *** bitcoin-git has left #bitcoin-core-dev
 90 2020-05-13T07:36:51  *** emilengler has joined #bitcoin-core-dev
 91 2020-05-13T07:40:14  *** luke-jr has quit IRC
 92 2020-05-13T07:43:25  *** Eagle[TM] has quit IRC
 93 2020-05-13T07:46:49  *** tmoc has quit IRC
 94 2020-05-13T07:50:35  *** marcoagner has joined #bitcoin-core-dev
 95 2020-05-13T08:00:51  *** luke-jr has joined #bitcoin-core-dev
 96 2020-05-13T08:05:54  *** luke-jr has quit IRC
 97 2020-05-13T08:07:20  *** go121212 has joined #bitcoin-core-dev
 98 2020-05-13T08:10:02  *** go11111111111 has quit IRC
 99 2020-05-13T08:13:50  *** bitcoin-git has joined #bitcoin-core-dev
100 2020-05-13T08:13:50  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/219c55da752d...8d17f8dc1773
101 2020-05-13T08:13:51  <bitcoin-git> bitcoin/master e8123ea João Barbosa: gui: Fix itemWalletAddress leak when not tree mode
102 2020-05-13T08:13:51  <bitcoin-git> bitcoin/master 8d17f8d Jonas Schnelli: Merge #18578: gui: Fix leak in CoinControlDialog::updateView
103 2020-05-13T08:13:53  *** bitcoin-git has left #bitcoin-core-dev
104 2020-05-13T08:14:25  *** bitcoin-git has joined #bitcoin-core-dev
105 2020-05-13T08:14:25  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #18578: gui: Fix leak in CoinControlDialog::updateView (master...2020-fix-coincontroldialog-leak) https://github.com/bitcoin/bitcoin/pull/18578
106 2020-05-13T08:14:26  *** bitcoin-git has left #bitcoin-core-dev
107 2020-05-13T08:16:12  *** bitcoin-git has joined #bitcoin-core-dev
108 2020-05-13T08:16:12  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8d17f8dc1773...246e878e7845
109 2020-05-13T08:16:13  <bitcoin-git> bitcoin/master a8b5f1b João Barbosa: gui: Fix manual coin control with multiple wallets loaded
110 2020-05-13T08:16:13  <bitcoin-git> bitcoin/master 246e878 Jonas Schnelli: Merge #18894: gui: Fix manual coin control with multiple wallets loaded
111 2020-05-13T08:16:14  *** bitcoin-git has left #bitcoin-core-dev
112 2020-05-13T08:16:32  *** bitcoin-git has joined #bitcoin-core-dev
113 2020-05-13T08:16:32  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #18894: gui: Fix manual coin control with multiple wallets loaded (master...2019-11-fix-15725.2) https://github.com/bitcoin/bitcoin/pull/18894
114 2020-05-13T08:16:34  *** bitcoin-git has left #bitcoin-core-dev
115 2020-05-13T08:27:55  *** promag_ has joined #bitcoin-core-dev
116 2020-05-13T08:27:56  *** emilengler has joined #bitcoin-core-dev
117 2020-05-13T08:28:09  *** luke-jr has joined #bitcoin-core-dev
118 2020-05-13T08:48:37  *** timothy has joined #bitcoin-core-dev
119 2020-05-13T08:57:51  *** promag_ has quit IRC
120 2020-05-13T09:00:01  *** Greedi has quit IRC
121 2020-05-13T09:05:52  *** promag has quit IRC
122 2020-05-13T09:06:08  *** promag has joined #bitcoin-core-dev
123 2020-05-13T09:10:54  *** promag has quit IRC
124 2020-05-13T09:11:30  *** promag has joined #bitcoin-core-dev
125 2020-05-13T09:12:01  *** mol_ has quit IRC
126 2020-05-13T09:21:38  *** fajro has joined #bitcoin-core-dev
127 2020-05-13T09:34:05  *** Victorsueca has quit IRC
128 2020-05-13T09:36:37  *** bitcoin-git has joined #bitcoin-core-dev
129 2020-05-13T09:36:38  <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/246e878e7845...a33901cb6d82
130 2020-05-13T09:36:38  <bitcoin-git> bitcoin/master a2e6db5 João Barbosa: rpc: Add mutex to guard deadlineTimers
131 2020-05-13T09:36:38  <bitcoin-git> bitcoin/master 9f59dde João Barbosa: rpc: Relock wallet only if most recent callback
132 2020-05-13T09:36:39  <bitcoin-git> bitcoin/master a33901c fanquake: Merge #18814: rpc: Relock wallet only if most recent callback
133 2020-05-13T09:36:41  *** bitcoin-git has left #bitcoin-core-dev
134 2020-05-13T09:36:56  *** bitcoin-git has joined #bitcoin-core-dev
135 2020-05-13T09:36:56  <bitcoin-git> [bitcoin] fanquake merged pull request #18814: rpc: Relock wallet only if most recent callback (master...2020-04-rpc-wallet-relock) https://github.com/bitcoin/bitcoin/pull/18814
136 2020-05-13T09:37:07  *** bitcoin-git has left #bitcoin-core-dev
137 2020-05-13T09:52:53  *** cataly5m7 has quit IRC
138 2020-05-13T09:53:17  *** cataly5m has joined #bitcoin-core-dev
139 2020-05-13T09:54:20  *** promag has quit IRC
140 2020-05-13T09:54:34  *** promag has joined #bitcoin-core-dev
141 2020-05-13T10:01:42  *** cataly5m is now known as m1rror
142 2020-05-13T10:02:42  *** braydonf has quit IRC
143 2020-05-13T10:03:11  *** braydonf has joined #bitcoin-core-dev
144 2020-05-13T10:09:29  <midnight> sipa: I'm getting a kick out of how you're just did it in Perl and C.
145 2020-05-13T10:14:16  *** promag_ has joined #bitcoin-core-dev
146 2020-05-13T10:14:16  *** promag has quit IRC
147 2020-05-13T10:15:39  *** AaronvanW has joined #bitcoin-core-dev
148 2020-05-13T10:21:45  *** EagleTM has joined #bitcoin-core-dev
149 2020-05-13T10:27:53  *** Rikudouainsoph has joined #bitcoin-core-dev
150 2020-05-13T10:42:07  *** AaronvanW has quit IRC
151 2020-05-13T10:43:03  *** jb55 has quit IRC
152 2020-05-13T10:45:15  *** surja795 has joined #bitcoin-core-dev
153 2020-05-13T10:55:17  *** jb55 has joined #bitcoin-core-dev
154 2020-05-13T11:00:56  *** jb55 has quit IRC
155 2020-05-13T11:02:10  *** Chris_Stewart_5 has joined #bitcoin-core-dev
156 2020-05-13T11:05:05  *** EagleTM has quit IRC
157 2020-05-13T11:06:05  *** jb55 has joined #bitcoin-core-dev
158 2020-05-13T11:07:38  *** IGHOR has quit IRC
159 2020-05-13T11:13:41  *** IGHOR has joined #bitcoin-core-dev
160 2020-05-13T11:16:03  *** jb55 has quit IRC
161 2020-05-13T11:18:09  *** Dean_Guss has joined #bitcoin-core-dev
162 2020-05-13T11:19:23  *** DeanWeen has quit IRC
163 2020-05-13T11:20:39  *** Izl has joined #bitcoin-core-dev
164 2020-05-13T11:21:14  *** mol has joined #bitcoin-core-dev
165 2020-05-13T11:24:21  *** jb55 has joined #bitcoin-core-dev
166 2020-05-13T11:39:06  *** bitdex has quit IRC
167 2020-05-13T11:48:29  *** mol has quit IRC
168 2020-05-13T11:52:55  *** Dean_Guss has quit IRC
169 2020-05-13T11:53:04  *** DeanWeen has joined #bitcoin-core-dev
170 2020-05-13T11:56:32  *** promag_ has quit IRC
171 2020-05-13T11:57:07  *** promag has joined #bitcoin-core-dev
172 2020-05-13T12:00:02  *** fajro has quit IRC
173 2020-05-13T12:02:10  *** Rikudouainsoph has quit IRC
174 2020-05-13T12:05:11  *** thanks has joined #bitcoin-core-dev
175 2020-05-13T12:07:43  *** thanks has quit IRC
176 2020-05-13T12:09:11  *** proofofkeags has joined #bitcoin-core-dev
177 2020-05-13T12:11:25  *** dfmb_ has joined #bitcoin-core-dev
178 2020-05-13T12:13:56  *** EagleTM has joined #bitcoin-core-dev
179 2020-05-13T12:14:01  *** proofofkeags has quit IRC
180 2020-05-13T12:21:55  *** kierra has joined #bitcoin-core-dev
181 2020-05-13T12:22:14  *** kierra is now known as Guest67738
182 2020-05-13T12:22:51  *** mol has joined #bitcoin-core-dev
183 2020-05-13T12:26:32  *** AaronvanW has joined #bitcoin-core-dev
184 2020-05-13T12:34:57  *** Rikudouainsoph has joined #bitcoin-core-dev
185 2020-05-13T12:35:48  *** luke-jr has quit IRC
186 2020-05-13T12:42:17  *** luke-jr has joined #bitcoin-core-dev
187 2020-05-13T12:50:03  *** afk11` has quit IRC
188 2020-05-13T12:50:29  *** afk11` has joined #bitcoin-core-dev
189 2020-05-13T12:52:14  *** EagleTM has quit IRC
190 2020-05-13T12:53:15  <wumpus> meshcollider: I think the run-time "is this WSL" detection raised a few eyebrows
191 2020-05-13T13:02:27  <jonasschnelli> Wasn't #18877 rather a quick merge for a impactful p2p change? Just a 7 day window?
192 2020-05-13T13:02:30  <gribble> https://github.com/bitcoin/bitcoin/issues/18877 | Serve cfcheckpt requests by jnewbery · Pull Request #18877 · bitcoin/bitcoin · GitHub
193 2020-05-13T13:03:09  <wumpus> it's a fast turnaround for sure
194 2020-05-13T13:03:30  <wumpus> though otoh it did get a lot of review, and it's an optional thing disabled by default
195 2020-05-13T13:04:26  <jonasschnelli> Yes. I agree. Just it looks like there is no clear conceptual ACK on serving filters after BIP157 (don't get me wrong, I'm all for serving BIP157).
196 2020-05-13T13:04:50  <jonasschnelli> I just think 6 days was to short for a reasonable discussion
197 2020-05-13T13:05:30  *** Rikudouainsoph has quit IRC
198 2020-05-13T13:05:49  <wumpus> but it's sure very fast given that we're kind of in slow times
199 2020-05-13T13:08:24  <fanquake> 🏎️
200 2020-05-13T13:09:22  <fanquake> One thing that's not getting faster is how long it takes to run all 160 tests of the functional test suite
201 2020-05-13T13:09:36  <wumpus> luke-jr: look, I disagree, personally I'd prefer not to include to autogenerated cruft at all, and there's more people that don't, so I don't see it as a regression. Spliting up the PR makes sure there is at least progress on parts that we do agree on. IF that isn't a positive thing I honestly don't know.
202 2020-05-13T13:10:27  *** Highway61 has quit IRC
203 2020-05-13T13:10:32  <jonasschnelli> 🐌🔑
204 2020-05-13T13:11:21  <jonatack> jonasschnelli: the conceptual discussion is ongoing (at least for me) on bip157, but the changes in that PR didn't seem dangerous on their own after reviewing them, and reversible before the next release
205 2020-05-13T13:12:05  <jonasschnelli> jonatack: I agree. Though an progressive merge behaviour is usually not the mode the project has worked in the past
206 2020-05-13T13:12:14  *** sipa has quit IRC
207 2020-05-13T13:12:16  <wumpus> this is not very welcoming to new contributors: https://github.com/bitcoin/bitcoin/pull/18965#issuecomment-627972210   please make sure that TODOs in the code are actual TODOs
208 2020-05-13T13:13:19  <wumpus> I think maybe we shouldn't include TODOs in the code at all and open a github issue instead, this is easier to manage
209 2020-05-13T13:13:37  <jonatack> jonasschnelli: i can understand that. there is also an opportunity cost in review resources.
210 2020-05-13T13:13:48  *** molakala has joined #bitcoin-core-dev
211 2020-05-13T13:14:27  <jonasschnelli> jonatack: Yes. Agree. I just think leaving it open for a while would not have had an big impact on resources.
212 2020-05-13T13:14:51  <jonasschnelli> (have more feedback, improve quality and get a conceptual agreement)
213 2020-05-13T13:15:12  <fanquake> wumpus: Could do. Although looks like most are in validation & net processing, so might not be great as "good first issues"
214 2020-05-13T13:16:03  <wumpus> fanquake: they don't strictly need to be "good first issues", usually it's just a way to mark technical debt I guess :)
215 2020-05-13T13:16:15  <jonatack> jonasschnelli: can't disagree with that. and at some point the conceptual issuens need to be addressed. belcher's ML post about it today is interesting.
216 2020-05-13T13:16:28  <wumpus> it's fine to have them if they're actually TODOs but such opinions tend to change over time, while they languish in the source code
217 2020-05-13T13:16:59  <wumpus> (e.g. it was an opinion of one developer that it was a TODO at the time the code was originally written)
218 2020-05-13T13:17:26  <fanquake> heh. There are definitely opinionated TODOs
219 2020-05-13T13:17:28  <fanquake> "// TODO: Handle this much more gracefully (10 DoS points is super arbitrary)"
220 2020-05-13T13:17:35  *** bitcoin-git has joined #bitcoin-core-dev
221 2020-05-13T13:17:36  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a33901cb6d82...6c647c89db28
222 2020-05-13T13:17:37  <bitcoin-git> bitcoin/master 0c63f80 Hennadii Stepanov: build: Suppress -Wdeprecated-copy warnings
223 2020-05-13T13:17:37  <bitcoin-git> bitcoin/master 6c647c8 fanquake: Merge #18738: build: Suppress -Wdeprecated-copy warnings
224 2020-05-13T13:17:38  *** bitcoin-git has left #bitcoin-core-dev
225 2020-05-13T13:17:56  *** bitcoin-git has joined #bitcoin-core-dev
226 2020-05-13T13:17:56  <bitcoin-git> [bitcoin] fanquake merged pull request #18738: build: Suppress -Wdeprecated-copy warnings (master...200422-qt-warn) https://github.com/bitcoin/bitcoin/pull/18738
227 2020-05-13T13:17:57  *** bitcoin-git has left #bitcoin-core-dev
228 2020-05-13T13:18:14  *** sipa has joined #bitcoin-core-dev
229 2020-05-13T13:19:15  <wumpus> I think that's an okay one, it could be written as "This could be handlded much more gracefully" without losing it's meaning, it's not like the one in the tests a fragment "todo: def base58 decoding" *why*
230 2020-05-13T13:25:41  *** EagleTM has joined #bitcoin-core-dev
231 2020-05-13T13:37:32  <jnewbery> jonasschnelli: 18877 is the first 3 commits from 16442, which has been open for almost a year. It had 7 ACKs + 2 implicit ACKs from jimpo and me + 6 concept ACKs. How can one year and 15 [concept] ACKs possibly be considered too short or not enough discussion?
232 2020-05-13T13:38:56  *** EagleTM has quit IRC
233 2020-05-13T13:41:51  *** per has joined #bitcoin-core-dev
234 2020-05-13T13:46:01  *** fearbeag has joined #bitcoin-core-dev
235 2020-05-13T13:47:56  *** proofofkeags has joined #bitcoin-core-dev
236 2020-05-13T13:51:35  *** cryptoIndio has quit IRC
237 2020-05-13T13:53:32  *** bitcoin-git has joined #bitcoin-core-dev
238 2020-05-13T13:53:33  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6c647c89db28...99c03728c07c
239 2020-05-13T13:53:34  <bitcoin-git> bitcoin/master f963a68 Russell Yanofsky: test: Add test for conflicted wallet tx notifications
240 2020-05-13T13:53:34  <bitcoin-git> bitcoin/master 99c0372 Wladimir J. van der Laan: Merge #18878: test: Add test for conflicted wallet tx notifications
241 2020-05-13T13:53:36  *** bitcoin-git has left #bitcoin-core-dev
242 2020-05-13T13:53:51  *** jonatack has quit IRC
243 2020-05-13T13:53:52  *** bitcoin-git has joined #bitcoin-core-dev
244 2020-05-13T13:53:53  <bitcoin-git> [bitcoin] laanwj merged pull request #18878: test: Add test for conflicted wallet tx notifications (master...pr/nonot) https://github.com/bitcoin/bitcoin/pull/18878
245 2020-05-13T13:54:04  *** bitcoin-git has left #bitcoin-core-dev
246 2020-05-13T13:58:40  <jonasschnelli> jnewbery: good point. The PR description was not refering to 16442. I missed that. I just think we need to make sure everyone has been heard and ideally agrees on the concept.
247 2020-05-13T13:58:40  *** promag has quit IRC
248 2020-05-13T13:59:02  *** promag has joined #bitcoin-core-dev
249 2020-05-13T13:59:23  <jonasschnelli> Dont get me wrong. I’m totally pro BIP157.
250 2020-05-13T13:59:31  *** promag has quit IRC
251 2020-05-13T13:59:52  *** promag has joined #bitcoin-core-dev
252 2020-05-13T14:00:58  *** Guest67738 has quit IRC
253 2020-05-13T14:03:59  <wumpus> psa: please do not add anything to the 0.20.0 milestone anymore unless it's a critical bugfix for a regression, at this pace we're noever going to be able to do rc2 let alone a release
254 2020-05-13T14:05:23  <wumpus> everything else (if it needs to go into 0.20 at all) can go into 0.20.1
255 2020-05-13T14:05:32  <instagibbs> unless it's a weird concept or lots of code I see no harm in the base58_decode PR :shrug:
256 2020-05-13T14:05:55  <instagibbs> agree in general TODOs need to be motivated
257 2020-05-13T14:05:58  <wumpus> no harm but also no gain unless you see a use case?
258 2020-05-13T14:06:41  <wumpus> we shouldn't just randomly add functions, it needs to be motivated
259 2020-05-13T14:07:11  <instagibbs> i kind of disagree, unless you think there's just no useful test to write with it
260 2020-05-13T14:07:20  <wumpus> that's not the point
261 2020-05-13T14:07:21  <instagibbs> (maybe not!)
262 2020-05-13T14:07:29  <wumpus> it can be added when a test needs it
263 2020-05-13T14:07:58  *** mdunnio has joined #bitcoin-core-dev
264 2020-05-13T14:07:59  <wumpus> the library is wholly to support our own use case, there shouldn't be anything 'just in case' in there
265 2020-05-13T14:08:37  <wumpus> I mean, otherwise I'm sure in half a year or less someone will go through it and helpfully remove unused functions and we're round
266 2020-05-13T14:08:48  <wumpus> in any case if *you* need it for a test it's good to add it
267 2020-05-13T14:09:47  <instagibbs> tell him to add a test then? :)
268 2020-05-13T14:09:48  <instagibbs> I did
269 2020-05-13T14:10:11  <wumpus> a test for bitcoind that uses it, to be clear, not just a test for the function itself :)
270 2020-05-13T14:11:20  <instagibbs> anyways, if I ever need it I'll just try to remember the future-ly closed PR and cherry-pick
271 2020-05-13T14:12:18  <wumpus> fair enough
272 2020-05-13T14:12:19  <ryanofsky> i definitely think #18965 is useful in its current form, even without a round trip test, though a round trip test would be useful
273 2020-05-13T14:12:21  <gribble> https://github.com/bitcoin/bitcoin/issues/18965 | tests: implement base58_decode by 10xcryptodev · Pull Request #18965 · bitcoin/bitcoin · GitHub
274 2020-05-13T14:13:28  <ryanofsky> i spent an embarrasing amount of time trying to debug byte_to_base58 recently for what turned out to be a byte order issue in #18878
275 2020-05-13T14:13:30  <gribble> https://github.com/bitcoin/bitcoin/issues/18878 | test: Add test for conflicted wallet tx notifications by ryanofsky · Pull Request #18878 · bitcoin/bitcoin · GitHub
276 2020-05-13T14:14:18  <ryanofsky> having a decode function could have saved me going that that rabbit hole
277 2020-05-13T14:15:28  <theStack> given that base58_decoded is needed, for me it seems kind of nonsensical to reinvent the wheel and manually code it out again; that's as absurd as if someone would implemented sha256 by hand in the test suite
278 2020-05-13T14:15:33  <theStack> of course base58 is not part of the python standard library, but i'd either use a tested widespread library, or (if we
279 2020-05-13T14:15:36  <theStack> don't want dependencies) copy it from that library
280 2020-05-13T14:30:13  <jnewbery> jonasschnelli: ah, you're right. I should have linked back to the full PR in 18877. The last comment before merge lists out all the places that people have [concept] ACKed.
281 2020-05-13T14:30:41  *** mol_ has joined #bitcoin-core-dev
282 2020-05-13T14:33:20  *** mol has quit IRC
283 2020-05-13T14:35:36  *** mol_ has quit IRC
284 2020-05-13T14:54:46  <promag> MarcoFalke: 18964 is not for 0.20 is it?
285 2020-05-13T15:03:14  *** Highway61 has joined #bitcoin-core-dev
286 2020-05-13T15:04:28  <jnewbery> I don't think it's unreasonable to add a decode function if the encode function is there. At least that means we can test the encoder with round-trips.
287 2020-05-13T15:05:13  <jnewbery> (but agree that we should remove TODOs if they're of only marginal benefit to the project. The issue system seems like a more appropriate place for those)
288 2020-05-13T15:06:06  *** proofofkeags has quit IRC
289 2020-05-13T15:08:24  *** proofofkeags has joined #bitcoin-core-dev
290 2020-05-13T15:10:44  *** proofofk_ has joined #bitcoin-core-dev
291 2020-05-13T15:11:29  *** proofofk_ has quit IRC
292 2020-05-13T15:11:53  *** proofofkeags has quit IRC
293 2020-05-13T15:11:58  *** proofofk_ has joined #bitcoin-core-dev
294 2020-05-13T15:14:56  *** proofofk_ has quit IRC
295 2020-05-13T15:15:10  *** proofofkeags has joined #bitcoin-core-dev
296 2020-05-13T15:20:13  *** veleiro has joined #bitcoin-core-dev
297 2020-05-13T15:21:05  *** ThunderChicken1 has joined #bitcoin-core-dev
298 2020-05-13T15:23:26  *** rmoura has joined #bitcoin-core-dev
299 2020-05-13T15:23:46  *** morcos has quit IRC
300 2020-05-13T15:24:03  *** morcos has joined #bitcoin-core-dev
301 2020-05-13T15:24:49  *** rmoura has quit IRC
302 2020-05-13T15:27:30  *** rmoura has joined #bitcoin-core-dev
303 2020-05-13T15:30:27  *** EagleTM has joined #bitcoin-core-dev
304 2020-05-13T15:36:59  *** veleiro` has joined #bitcoin-core-dev
305 2020-05-13T15:38:47  *** veleiro has quit IRC
306 2020-05-13T15:42:47  *** jonatack has joined #bitcoin-core-dev
307 2020-05-13T15:43:17  *** justanotheruser has quit IRC
308 2020-05-13T15:44:47  *** EagleTM has quit IRC
309 2020-05-13T15:45:04  *** EagleTM has joined #bitcoin-core-dev
310 2020-05-13T15:50:45  *** proofofkeags has quit IRC
311 2020-05-13T15:51:21  *** proofofkeags has joined #bitcoin-core-dev
312 2020-05-13T15:52:47  *** mol has joined #bitcoin-core-dev
313 2020-05-13T15:52:55  *** proofofkeags has quit IRC
314 2020-05-13T15:53:01  *** proofofk_ has joined #bitcoin-core-dev
315 2020-05-13T15:57:38  *** proofofk_ has quit IRC
316 2020-05-13T15:57:55  *** proofofkeags has joined #bitcoin-core-dev
317 2020-05-13T16:10:40  *** promag has quit IRC
318 2020-05-13T16:11:03  *** shaunsun has joined #bitcoin-core-dev
319 2020-05-13T16:11:16  *** promag has joined #bitcoin-core-dev
320 2020-05-13T16:12:22  *** kristapsk has joined #bitcoin-core-dev
321 2020-05-13T16:13:43  *** EagleTM is now known as Eagle[TM]
322 2020-05-13T16:14:19  *** Eagle[TM] is now known as EagleTM
323 2020-05-13T16:15:41  *** EagleTM has joined #bitcoin-core-dev
324 2020-05-13T16:19:43  *** nehan has quit IRC
325 2020-05-13T16:20:00  *** vasild_ has joined #bitcoin-core-dev
326 2020-05-13T16:20:01  *** nehan has joined #bitcoin-core-dev
327 2020-05-13T16:20:16  *** pinheadm_ has joined #bitcoin-core-dev
328 2020-05-13T16:20:36  *** ghost43 has quit IRC
329 2020-05-13T16:20:42  *** per has quit IRC
330 2020-05-13T16:20:59  *** pinheadm_ has quit IRC
331 2020-05-13T16:21:01  *** pinheadmz has quit IRC
332 2020-05-13T16:21:25  *** ghost43 has joined #bitcoin-core-dev
333 2020-05-13T16:21:51  *** dongcarl has quit IRC
334 2020-05-13T16:22:00  *** dongcarl has joined #bitcoin-core-dev
335 2020-05-13T16:22:42  *** pinheadmz has joined #bitcoin-core-dev
336 2020-05-13T16:23:23  *** vasild has quit IRC
337 2020-05-13T16:23:24  *** vasild_ is now known as vasild
338 2020-05-13T16:25:06  *** per has joined #bitcoin-core-dev
339 2020-05-13T16:25:59  *** tryphe has joined #bitcoin-core-dev
340 2020-05-13T16:26:54  *** lightlike has joined #bitcoin-core-dev
341 2020-05-13T16:29:51  *** justanotheruser has joined #bitcoin-core-dev
342 2020-05-13T16:38:34  *** proofofkeags has quit IRC
343 2020-05-13T16:39:30  *** troygiorshev has joined #bitcoin-core-dev
344 2020-05-13T16:42:15  *** veleiro`` has joined #bitcoin-core-dev
345 2020-05-13T16:43:53  *** veleiro` has quit IRC
346 2020-05-13T16:45:50  *** proofofkeags has joined #bitcoin-core-dev
347 2020-05-13T16:46:21  *** veleiro`` has left #bitcoin-core-dev
348 2020-05-13T16:47:13  *** veleiro has joined #bitcoin-core-dev
349 2020-05-13T16:48:43  *** EagleTM has quit IRC
350 2020-05-13T16:50:08  *** michaelfolkson has joined #bitcoin-core-dev
351 2020-05-13T16:52:54  *** b10c has joined #bitcoin-core-dev
352 2020-05-13T16:55:55  *** kristapsk has quit IRC
353 2020-05-13T16:56:17  *** kristapsk has joined #bitcoin-core-dev
354 2020-05-13T16:57:30  *** veleiro` has joined #bitcoin-core-dev
355 2020-05-13T16:59:36  *** veleiro has quit IRC
356 2020-05-13T17:00:06  *** Processus42 has quit IRC
357 2020-05-13T17:00:20  *** andrewtoth has joined #bitcoin-core-dev
358 2020-05-13T17:00:52  *** Processus42 has joined #bitcoin-core-dev
359 2020-05-13T17:03:46  *** r251d has joined #bitcoin-core-dev
360 2020-05-13T17:04:13  *** michaelf_ has joined #bitcoin-core-dev
361 2020-05-13T17:05:30  *** michaelfolkson has quit IRC
362 2020-05-13T17:05:36  *** michaelf_ has quit IRC
363 2020-05-13T17:06:08  *** michaelfolkson has joined #bitcoin-core-dev
364 2020-05-13T17:09:59  *** jarthur has joined #bitcoin-core-dev
365 2020-05-13T17:13:07  *** michaelf_ has joined #bitcoin-core-dev
366 2020-05-13T17:15:15  *** michaelfolkson has quit IRC
367 2020-05-13T17:16:31  *** michaelf_ has quit IRC
368 2020-05-13T17:17:06  *** michaelfolkson has joined #bitcoin-core-dev
369 2020-05-13T17:25:57  *** michaelf_ has joined #bitcoin-core-dev
370 2020-05-13T17:26:37  *** michaelfolkson has quit IRC
371 2020-05-13T17:28:47  *** michaelf_ has quit IRC
372 2020-05-13T17:29:17  *** michaelfolkson has joined #bitcoin-core-dev
373 2020-05-13T17:29:29  *** michaelfolkson is now known as michaelfolkson2
374 2020-05-13T17:31:43  *** Guyver2 has joined #bitcoin-core-dev
375 2020-05-13T17:32:10  *** michaelfolkson2 is now known as michaelfolkson
376 2020-05-13T17:36:05  *** bitcoin-git has joined #bitcoin-core-dev
377 2020-05-13T17:36:07  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/99c03728c07c...5d18c0ae1827
378 2020-05-13T17:36:07  <bitcoin-git> bitcoin/master 8bf1540 fanquake: build: remove fdelt_chk backwards compatibility code
379 2020-05-13T17:36:08  <bitcoin-git> bitcoin/master df6bde0 fanquake: test: remove glibc fdelt sanity check
380 2020-05-13T17:36:09  <bitcoin-git> bitcoin/master 5d18c0a Wladimir J. van der Laan: Merge #18862: Remove fdelt_chk back-compat code and sanity check
381 2020-05-13T17:36:11  *** bitcoin-git has left #bitcoin-core-dev
382 2020-05-13T17:36:25  *** bitcoin-git has joined #bitcoin-core-dev
383 2020-05-13T17:36:25  <bitcoin-git> [bitcoin] laanwj merged pull request #18862: Remove fdelt_chk back-compat code and sanity check (master...remove_fdelt_chk_back_compat) https://github.com/bitcoin/bitcoin/pull/18862
384 2020-05-13T17:36:26  *** bitcoin-git has left #bitcoin-core-dev
385 2020-05-13T17:38:18  *** rmoura has quit IRC
386 2020-05-13T17:40:35  *** promag_ has joined #bitcoin-core-dev
387 2020-05-13T17:40:36  *** promag has quit IRC
388 2020-05-13T17:41:48  *** promag has joined #bitcoin-core-dev
389 2020-05-13T17:41:48  *** promag_ has quit IRC
390 2020-05-13T17:55:11  *** rmoura has joined #bitcoin-core-dev
391 2020-05-13T17:59:41  *** bitcoin-git has joined #bitcoin-core-dev
392 2020-05-13T17:59:41  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18968: doc: noban precludes maxuploadtarget disconnects (master...2005-docMaxuploadtarget) https://github.com/bitcoin/bitcoin/pull/18968
393 2020-05-13T17:59:42  *** bitcoin-git has left #bitcoin-core-dev
394 2020-05-13T18:00:02  *** ThunderChicken1 has quit IRC
395 2020-05-13T18:03:02  *** r251d has quit IRC
396 2020-05-13T18:04:37  *** timothy has quit IRC
397 2020-05-13T18:09:48  *** theStack has quit IRC
398 2020-05-13T18:15:21  *** bitcoin-git has joined #bitcoin-core-dev
399 2020-05-13T18:15:21  <bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/5d18c0ae1827...fc895d7700f9
400 2020-05-13T18:15:22  <bitcoin-git> bitcoin/master 1e06bb6 Hennadii Stepanov: Drop unused CLIENT_VERSION_SUFFIX macro
401 2020-05-13T18:15:22  <bitcoin-git> bitcoin/master dc1fba9 Hennadii Stepanov: scripted-diff: Rename share/genbuild.sh macros to more meaningful ones
402 2020-05-13T18:15:23  <bitcoin-git> bitcoin/master 35f1189 Hennadii Stepanov: build: Rename BUILD_* macros and the code self-descriptive
403 2020-05-13T18:15:24  *** bitcoin-git has left #bitcoin-core-dev
404 2020-05-13T18:15:45  *** bitcoin-git has joined #bitcoin-core-dev
405 2020-05-13T18:15:46  <bitcoin-git> [bitcoin] laanwj merged pull request #18616: refactor: Cleanup clientversion.cpp (master...20200413-version) https://github.com/bitcoin/bitcoin/pull/18616
406 2020-05-13T18:15:46  *** bitcoin-git has left #bitcoin-core-dev
407 2020-05-13T18:22:43  *** andrewtoth has quit IRC
408 2020-05-13T18:31:06  *** bitcoin-git has joined #bitcoin-core-dev
409 2020-05-13T18:31:07  <bitcoin-git> [bitcoin] jonasschnelli pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/fc895d7700f9...51825aea7fa0
410 2020-05-13T18:31:07  <bitcoin-git> bitcoin/master fe05dd0 Hennadii Stepanov: util: Enhance bilingual_str
411 2020-05-13T18:31:08  <bitcoin-git> bitcoin/master 4c9b9a4 Hennadii Stepanov: util: Enhance Join()
412 2020-05-13T18:31:08  <bitcoin-git> bitcoin/master da16f95 Hennadii Stepanov: gui: Do not translate InitWarning messages in debug.log
413 2020-05-13T18:31:09  *** bitcoin-git has left #bitcoin-core-dev
414 2020-05-13T18:31:25  *** bitcoin-git has joined #bitcoin-core-dev
415 2020-05-13T18:31:26  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #18922: gui: Do not translate InitWarning messages in debug.log (master...200509-initwarn) https://github.com/bitcoin/bitcoin/pull/18922
416 2020-05-13T18:31:26  *** bitcoin-git has left #bitcoin-core-dev
417 2020-05-13T18:40:20  <MarcoFalke> [23:19] <luke-jr> would be nice if Travis sent an email to the PR creator when it failed :x
418 2020-05-13T18:40:30  <MarcoFalke> You can enable travis in your own repo to get emails
419 2020-05-13T18:53:46  *** ecrist1 has joined #bitcoin-core-dev
420 2020-05-13T18:56:51  <MarcoFalke> Btw, I have a lot of good first issues to work on. If someone is out there that wants them, please contact me. If I don't hear back, I will put them on the main repo maybe next week.
421 2020-05-13T18:59:08  <shesek> how do conflicting transactions fit into the most recent sorting of listttransactions? do they get sorted as the most recent like the negative confirmations number might imply? or at their original height? also, are there any guarantees for the ordering of unconfirmed transactions among themselves?
422 2020-05-13T19:12:52  *** tryphe_ has joined #bitcoin-core-dev
423 2020-05-13T19:15:06  *** tryphe has quit IRC
424 2020-05-13T19:30:49  *** owowo has quit IRC
425 2020-05-13T19:35:16  *** owowo has joined #bitcoin-core-dev
426 2020-05-13T19:38:14  *** bitcoin-git has joined #bitcoin-core-dev
427 2020-05-13T19:38:14  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/51825aea7fa0...a9a6d946e41b
428 2020-05-13T19:38:15  <bitcoin-git> bitcoin/master faa26d3 MarcoFalke: test: Remove RPCOverloadWrapper boilerplate
429 2020-05-13T19:38:15  <bitcoin-git> bitcoin/master a9a6d94 MarcoFalke: Merge #18888: test: Remove RPCOverloadWrapper boilerplate
430 2020-05-13T19:38:17  *** bitcoin-git has left #bitcoin-core-dev
431 2020-05-13T19:38:34  *** bitcoin-git has joined #bitcoin-core-dev
432 2020-05-13T19:38:34  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18888: test: Remove RPCOverloadWrapper boilerplate (master...2005-testNoBoilerplate) https://github.com/bitcoin/bitcoin/pull/18888
433 2020-05-13T19:38:35  *** bitcoin-git has left #bitcoin-core-dev
434 2020-05-13T19:40:34  *** b10c has quit IRC
435 2020-05-13T19:48:17  *** Kiminuo has joined #bitcoin-core-dev
436 2020-05-13T20:00:50  <MarcoFalke> begging for one or two more ACKs on #18742 . I think we should make some progress on rc2
437 2020-05-13T20:00:54  <gribble> https://github.com/bitcoin/bitcoin/issues/18742 | miner: Avoid stack-use-after-return in validationinterface by MarcoFalke · Pull Request #18742 · bitcoin/bitcoin · GitHub
438 2020-05-13T20:12:52  *** michaelfolkson has quit IRC
439 2020-05-13T20:15:23  *** michaelfolkson has joined #bitcoin-core-dev
440 2020-05-13T20:20:46  *** bitcoin-git has joined #bitcoin-core-dev
441 2020-05-13T20:20:47  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a9a6d946e41b...04c09553d898
442 2020-05-13T20:20:48  <bitcoin-git> bitcoin/master a30b0a2 Vasil Dimov: build: enable -Werror=gnu
443 2020-05-13T20:20:49  <bitcoin-git> bitcoin/master 04c0955 Wladimir J. van der Laan: Merge #18887: build: enable -Werror=gnu
444 2020-05-13T20:20:58  *** bitcoin-git has left #bitcoin-core-dev
445 2020-05-13T20:21:16  *** bitcoin-git has joined #bitcoin-core-dev
446 2020-05-13T20:21:17  <bitcoin-git> [bitcoin] laanwj merged pull request #18887: build: enable -Werror=gnu (master...add_Werror_gnu) https://github.com/bitcoin/bitcoin/pull/18887
447 2020-05-13T20:21:28  *** bitcoin-git has left #bitcoin-core-dev
448 2020-05-13T20:40:15  *** michaelfolkson has quit IRC
449 2020-05-13T20:40:42  *** michaelfolkson has joined #bitcoin-core-dev
450 2020-05-13T20:43:39  *** michaelfolkson has quit IRC
451 2020-05-13T20:47:26  *** ghost43 has quit IRC
452 2020-05-13T20:47:43  *** ghost43 has joined #bitcoin-core-dev
453 2020-05-13T20:47:48  *** michaelfolkson has joined #bitcoin-core-dev
454 2020-05-13T20:49:59  *** michaelf_ has joined #bitcoin-core-dev
455 2020-05-13T20:50:02  *** dviola has joined #bitcoin-core-dev
456 2020-05-13T20:51:46  *** fearbeag has quit IRC
457 2020-05-13T20:55:47  *** michaelf_ has quit IRC
458 2020-05-13T20:57:42  *** michaelf_ has joined #bitcoin-core-dev
459 2020-05-13T20:57:57  *** Kiminuo has quit IRC
460 2020-05-13T21:00:02  *** ecrist1 has quit IRC
461 2020-05-13T21:03:12  *** Guyver2 has quit IRC
462 2020-05-13T21:04:18  *** michaelf_ has quit IRC
463 2020-05-13T21:04:24  *** nubescaeli has joined #bitcoin-core-dev
464 2020-05-13T21:04:44  *** michaelf_ has joined #bitcoin-core-dev
465 2020-05-13T21:07:31  *** michaelf_ has quit IRC
466 2020-05-13T21:08:00  *** michaelf_ has joined #bitcoin-core-dev
467 2020-05-13T21:08:50  *** manantial has quit IRC
468 2020-05-13T21:11:10  *** michaelf_ has quit IRC
469 2020-05-13T21:11:35  *** michaelf_ has joined #bitcoin-core-dev
470 2020-05-13T21:13:07  *** michaelf_ has quit IRC
471 2020-05-13T21:13:33  *** michaelf_ has joined #bitcoin-core-dev
472 2020-05-13T21:17:06  *** emilengler has quit IRC
473 2020-05-13T21:18:12  *** Steini- has joined #bitcoin-core-dev
474 2020-05-13T21:20:12  *** michaelf_ has quit IRC
475 2020-05-13T21:20:47  *** michaelf_ has joined #bitcoin-core-dev
476 2020-05-13T21:22:02  *** Izl has quit IRC
477 2020-05-13T21:23:09  *** promag has quit IRC
478 2020-05-13T21:23:25  *** promag has joined #bitcoin-core-dev
479 2020-05-13T21:24:11  *** Kiminuo has joined #bitcoin-core-dev
480 2020-05-13T21:24:12  *** troygiorshev has quit IRC
481 2020-05-13T21:26:21  *** molakala has quit IRC
482 2020-05-13T21:27:15  *** promag_ has joined #bitcoin-core-dev
483 2020-05-13T21:27:17  *** promag has quit IRC
484 2020-05-13T21:29:19  *** michaelf_ has quit IRC
485 2020-05-13T21:29:56  *** michaelf_ has joined #bitcoin-core-dev
486 2020-05-13T21:41:39  *** michaelf_ has quit IRC
487 2020-05-13T21:46:01  *** jeremyrubin has joined #bitcoin-core-dev
488 2020-05-13T21:49:31  *** michaelf_ has joined #bitcoin-core-dev
489 2020-05-13T21:53:02  *** surja795 has quit IRC
490 2020-05-13T21:53:59  *** surja795 has joined #bitcoin-core-dev
491 2020-05-13T21:58:26  *** michaelf_ has quit IRC
492 2020-05-13T21:59:08  *** surja795 has quit IRC
493 2020-05-13T22:00:50  *** veleiro`` has joined #bitcoin-core-dev
494 2020-05-13T22:01:23  *** michaelf_ has joined #bitcoin-core-dev
495 2020-05-13T22:04:11  *** veleiro` has quit IRC
496 2020-05-13T22:05:21  *** Livestradamus has quit IRC
497 2020-05-13T22:05:34  *** warren has quit IRC
498 2020-05-13T22:05:39  *** Livestradamus has joined #bitcoin-core-dev
499 2020-05-13T22:06:31  *** warren has joined #bitcoin-core-dev
500 2020-05-13T22:07:29  *** Anduck has quit IRC
501 2020-05-13T22:08:05  *** Anduck has joined #bitcoin-core-dev
502 2020-05-13T22:20:53  *** tmoc has joined #bitcoin-core-dev
503 2020-05-13T22:22:17  *** justanotheruser has quit IRC
504 2020-05-13T22:22:36  *** justanotheruser has joined #bitcoin-core-dev
505 2020-05-13T22:34:00  *** michael__ has joined #bitcoin-core-dev
506 2020-05-13T22:34:37  *** michaelf_ has quit IRC
507 2020-05-13T22:38:20  *** michael__ has quit IRC
508 2020-05-13T22:47:56  *** bitcoin-git has joined #bitcoin-core-dev
509 2020-05-13T22:47:56  <bitcoin-git> [bitcoin] promag closed pull request #18791: wip: Only support shared validation interfaces (master...2020-04-only-shared-validation-interface) https://github.com/bitcoin/bitcoin/pull/18791
510 2020-05-13T22:47:57  *** bitcoin-git has left #bitcoin-core-dev
511 2020-05-13T22:55:58  *** marcoagner has quit IRC
512 2020-05-13T22:58:31  *** dfmb_ has quit IRC
513 2020-05-13T23:14:41  *** mdunnio has quit IRC
514 2020-05-13T23:19:23  *** DeanWeen has quit IRC
515 2020-05-13T23:30:14  *** bitdex has joined #bitcoin-core-dev
516 2020-05-13T23:31:58  *** DeanWeen has joined #bitcoin-core-dev
517 2020-05-13T23:36:43  *** shaunsun has quit IRC
518 2020-05-13T23:37:19  *** lightlike has quit IRC
519 2020-05-13T23:38:40  *** niska has quit IRC
520 2020-05-13T23:44:05  *** justanotheruser has quit IRC
521 2020-05-13T23:56:26  *** IGHOR has quit IRC
522 2020-05-13T23:58:17  *** tryphe_ is now known as tryphe