1 2020-05-14T00:00:01  *** Steini- has quit IRC
  2 2020-05-14T00:02:26  *** surja795 has joined #bitcoin-core-dev
  3 2020-05-14T00:02:35  *** IGHOR has joined #bitcoin-core-dev
  4 2020-05-14T00:03:22  *** Guest75362 has joined #bitcoin-core-dev
  5 2020-05-14T00:04:33  *** bitcoin-git has joined #bitcoin-core-dev
  6 2020-05-14T00:04:34  <bitcoin-git> [bitcoin] achow101 opened pull request #18971: wallet: Refactor the classes in wallet/db.{cpp/h} (master...refactor-storage) https://github.com/bitcoin/bitcoin/pull/18971
  7 2020-05-14T00:04:35  *** bitcoin-git has left #bitcoin-core-dev
  8 2020-05-14T00:07:26  *** surja795 has quit IRC
  9 2020-05-14T00:08:21  *** niska has joined #bitcoin-core-dev
 10 2020-05-14T00:09:43  *** veleiro`` has left #bitcoin-core-dev
 11 2020-05-14T00:10:01  *** veleiro has joined #bitcoin-core-dev
 12 2020-05-14T00:20:21  *** jden has joined #bitcoin-core-dev
 13 2020-05-14T00:25:26  *** promag_ has quit IRC
 14 2020-05-14T00:26:03  *** promag has joined #bitcoin-core-dev
 15 2020-05-14T00:28:39  *** veleiro` has joined #bitcoin-core-dev
 16 2020-05-14T00:32:29  *** veleiro has quit IRC
 17 2020-05-14T00:34:01  *** surja795 has joined #bitcoin-core-dev
 18 2020-05-14T00:35:24  *** AaronvanW has quit IRC
 19 2020-05-14T00:36:07  *** Highway61 has quit IRC
 20 2020-05-14T00:42:39  *** EagleTM has joined #bitcoin-core-dev
 21 2020-05-14T00:45:25  *** promag has quit IRC
 22 2020-05-14T00:45:38  *** promag has joined #bitcoin-core-dev
 23 2020-05-14T00:48:43  *** ghost43_ has joined #bitcoin-core-dev
 24 2020-05-14T00:49:23  *** ghost43 has quit IRC
 25 2020-05-14T01:22:35  *** EagleTM has quit IRC
 26 2020-05-14T01:32:05  *** bitcoin-git has joined #bitcoin-core-dev
 27 2020-05-14T01:32:05  <bitcoin-git> [bitcoin] luke-jr opened pull request #18972: WIP: net: Add blockfilters white{bind,list} permission flag (master...neutrino_whitelist) https://github.com/bitcoin/bitcoin/pull/18972
 28 2020-05-14T01:32:06  *** bitcoin-git has left #bitcoin-core-dev
 29 2020-05-14T01:42:08  *** spinza has quit IRC
 30 2020-05-14T01:43:18  *** Guest75362 has quit IRC
 31 2020-05-14T01:44:24  *** spinza has joined #bitcoin-core-dev
 32 2020-05-14T01:46:57  *** Guest75362 has joined #bitcoin-core-dev
 33 2020-05-14T02:12:37  *** promag has quit IRC
 34 2020-05-14T02:18:03  *** desperad0 has joined #bitcoin-core-dev
 35 2020-05-14T02:30:03  *** sdaftuar has quit IRC
 36 2020-05-14T02:32:36  *** sdaftuar has joined #bitcoin-core-dev
 37 2020-05-14T02:37:46  *** shesek has quit IRC
 38 2020-05-14T02:38:11  *** shesek has joined #bitcoin-core-dev
 39 2020-05-14T02:38:11  *** shesek has joined #bitcoin-core-dev
 40 2020-05-14T02:47:40  *** Pasha is now known as Cory
 41 2020-05-14T03:00:02  *** jden has quit IRC
 42 2020-05-14T03:03:43  *** surja795 has quit IRC
 43 2020-05-14T03:19:43  *** Kiminuo has quit IRC
 44 2020-05-14T03:24:11  *** Kiminuo has joined #bitcoin-core-dev
 45 2020-05-14T03:40:07  *** proofofkeags has quit IRC
 46 2020-05-14T03:40:40  *** proofofkeags has joined #bitcoin-core-dev
 47 2020-05-14T03:40:56  *** dviola has quit IRC
 48 2020-05-14T03:45:20  *** proofofkeags has quit IRC
 49 2020-05-14T03:53:26  *** greynix has joined #bitcoin-core-dev
 50 2020-05-14T03:55:12  *** mol_ has joined #bitcoin-core-dev
 51 2020-05-14T03:55:26  *** mol has quit IRC
 52 2020-05-14T03:55:27  *** go11111111111 has joined #bitcoin-core-dev
 53 2020-05-14T03:58:25  *** go121212 has quit IRC
 54 2020-05-14T04:19:58  *** vasild_ has joined #bitcoin-core-dev
 55 2020-05-14T04:23:03  *** vasild has quit IRC
 56 2020-05-14T04:23:04  *** vasild_ is now known as vasild
 57 2020-05-14T04:32:42  *** Guest75362 is now known as justanotheruser
 58 2020-05-14T04:37:57  *** bitcoin-git has joined #bitcoin-core-dev
 59 2020-05-14T04:37:57  <bitcoin-git> [bitcoin] fanquake opened pull request #18973: [0.20] Final backports for rc2 (0.20...0_20_0rc2_final_backports) https://github.com/bitcoin/bitcoin/pull/18973
 60 2020-05-14T04:37:58  *** bitcoin-git has left #bitcoin-core-dev
 61 2020-05-14T05:58:15  *** Kiminuo has quit IRC
 62 2020-05-14T06:00:02  *** greynix has quit IRC
 63 2020-05-14T06:03:24  *** manantial has joined #bitcoin-core-dev
 64 2020-05-14T06:05:06  *** _Francisco_ has joined #bitcoin-core-dev
 65 2020-05-14T06:18:09  *** Kiminuo has joined #bitcoin-core-dev
 66 2020-05-14T06:20:07  *** MarconM has joined #bitcoin-core-dev
 67 2020-05-14T06:28:30  *** rjected has quit IRC
 68 2020-05-14T06:29:07  *** MarconM has quit IRC
 69 2020-05-14T06:36:31  *** rjected has joined #bitcoin-core-dev
 70 2020-05-14T06:37:48  *** Kiminuo has quit IRC
 71 2020-05-14T06:46:31  *** bitcoin-git has joined #bitcoin-core-dev
 72 2020-05-14T06:46:31  <bitcoin-git> [bitcoin] elichai closed pull request #17953: refactor: Abstract boost::variant out (master...2020-01-variant) https://github.com/bitcoin/bitcoin/pull/17953
 73 2020-05-14T06:46:32  *** bitcoin-git has left #bitcoin-core-dev
 74 2020-05-14T06:48:45  *** Cory is now known as Pasha
 75 2020-05-14T06:49:46  *** Pasha has quit IRC
 76 2020-05-14T06:53:50  *** OneFixt has joined #bitcoin-core-dev
 77 2020-05-14T06:57:40  *** Cory has joined #bitcoin-core-dev
 78 2020-05-14T07:13:41  *** luke-jr has quit IRC
 79 2020-05-14T07:16:01  *** nubescaeli has quit IRC
 80 2020-05-14T07:30:22  *** luke-jr has joined #bitcoin-core-dev
 81 2020-05-14T07:35:22  *** DeanWeen has quit IRC
 82 2020-05-14T07:35:31  *** DeanWeen has joined #bitcoin-core-dev
 83 2020-05-14T07:54:12  *** marcoagner has joined #bitcoin-core-dev
 84 2020-05-14T08:00:52  *** Cory has quit IRC
 85 2020-05-14T08:00:53  *** Cory has joined #bitcoin-core-dev
 86 2020-05-14T08:13:42  *** Guyver2 has joined #bitcoin-core-dev
 87 2020-05-14T08:14:52  *** _Francisco_ has quit IRC
 88 2020-05-14T08:17:28  *** tmoc has quit IRC
 89 2020-05-14T08:43:14  *** AaronvanW has joined #bitcoin-core-dev
 90 2020-05-14T08:43:29  *** goatpig has joined #bitcoin-core-dev
 91 2020-05-14T08:43:41  <goatpig> hi
 92 2020-05-14T08:43:54  <goatpig> would a transaction with no outputs be valid?
 93 2020-05-14T09:00:02  *** OneFixt has quit IRC
 94 2020-05-14T09:00:38  <aj> goatpig: https://github.com/bitcoin/bitcoin/blob/master/src/consensus/tx_check.cpp#L15
 95 2020-05-14T09:00:52  <goatpig> thanks
 96 2020-05-14T09:03:22  *** mol_ has quit IRC
 97 2020-05-14T09:05:06  *** theStack has joined #bitcoin-core-dev
 98 2020-05-14T09:15:32  *** desperad0 has quit IRC
 99 2020-05-14T09:17:52  *** dfmb_ has joined #bitcoin-core-dev
100 2020-05-14T09:18:06  *** tty11 has joined #bitcoin-core-dev
101 2020-05-14T09:21:12  *** _Francisco_ has joined #bitcoin-core-dev
102 2020-05-14T09:25:31  *** DeanWeen has quit IRC
103 2020-05-14T09:25:53  *** DeanWeen has joined #bitcoin-core-dev
104 2020-05-14T09:25:54  *** promag has joined #bitcoin-core-dev
105 2020-05-14T09:27:26  *** timothy has joined #bitcoin-core-dev
106 2020-05-14T09:56:09  *** surja795 has joined #bitcoin-core-dev
107 2020-05-14T09:58:27  *** milieu__ has joined #bitcoin-core-dev
108 2020-05-14T09:58:43  *** SiAnDoG_ has quit IRC
109 2020-05-14T10:00:51  *** Highway61 has joined #bitcoin-core-dev
110 2020-05-14T10:01:25  *** filchef has joined #bitcoin-core-dev
111 2020-05-14T10:19:06  *** jarthur has quit IRC
112 2020-05-14T10:19:35  *** braydonf has quit IRC
113 2020-05-14T10:22:00  *** braydonf has joined #bitcoin-core-dev
114 2020-05-14T10:32:24  *** surja795 has quit IRC
115 2020-05-14T10:33:47  *** Victorsueca has joined #bitcoin-core-dev
116 2020-05-14T10:39:50  *** surja795 has joined #bitcoin-core-dev
117 2020-05-14T10:44:23  *** surja795 has quit IRC
118 2020-05-14T10:54:57  *** milieu__ has quit IRC
119 2020-05-14T10:55:19  *** milieu__ has joined #bitcoin-core-dev
120 2020-05-14T11:04:18  *** ghost43_ has quit IRC
121 2020-05-14T11:04:36  *** ghost43 has joined #bitcoin-core-dev
122 2020-05-14T11:19:23  *** DeanWeen has quit IRC
123 2020-05-14T11:24:52  *** _Francisco_ has quit IRC
124 2020-05-14T11:30:55  *** Izl has joined #bitcoin-core-dev
125 2020-05-14T11:34:56  <theStack> has anyone ever used the functional test framework to interact with an already running full node? for some (performance) tests it would make sense to use the mainnet i think
126 2020-05-14T11:42:18  <fjahr> theStack: have you seen the TestShell class from James Chiang? It is used in the jupyter notebooks for the optech Taproot course, that might be helpful for you.
127 2020-05-14T11:42:28  *** bitdex has quit IRC
128 2020-05-14T11:42:31  <fjahr> https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/test_shell.py
129 2020-05-14T11:42:50  *** owowo has quit IRC
130 2020-05-14T11:44:35  <theStack> fjahr: thanks for the hint, will take a look at it!
131 2020-05-14T11:44:59  <fjahr> I am not sure about the already running part though. Should probably work if you just change the pid? But I have not tried it.
132 2020-05-14T11:52:18  *** luke-jr has quit IRC
133 2020-05-14T11:55:43  *** vasild has quit IRC
134 2020-05-14T11:57:47  *** vasild has joined #bitcoin-core-dev
135 2020-05-14T11:58:56  *** andytoshi has quit IRC
136 2020-05-14T12:00:01  *** tty11 has quit IRC
137 2020-05-14T12:08:21  *** luke-jr has joined #bitcoin-core-dev
138 2020-05-14T12:12:42  *** mol has joined #bitcoin-core-dev
139 2020-05-14T12:13:02  *** luke-jr has quit IRC
140 2020-05-14T12:15:56  *** luke-jr has joined #bitcoin-core-dev
141 2020-05-14T12:19:46  *** gonemad3 has joined #bitcoin-core-dev
142 2020-05-14T12:20:45  *** andytoshi has joined #bitcoin-core-dev
143 2020-05-14T12:20:45  *** andytoshi has quit IRC
144 2020-05-14T12:20:45  *** andytoshi has joined #bitcoin-core-dev
145 2020-05-14T12:23:14  *** promag has quit IRC
146 2020-05-14T12:23:49  *** promag has joined #bitcoin-core-dev
147 2020-05-14T12:31:22  *** shaunsun has joined #bitcoin-core-dev
148 2020-05-14T12:32:06  *** molakala has joined #bitcoin-core-dev
149 2020-05-14T12:33:11  *** shaunsun_ has joined #bitcoin-core-dev
150 2020-05-14T12:35:45  *** Guyver2 has quit IRC
151 2020-05-14T12:36:02  *** shaunsun has quit IRC
152 2020-05-14T12:38:25  *** bitcoin-git has joined #bitcoin-core-dev
153 2020-05-14T12:38:25  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18974: test: Check that invalid witness destinations can not be imported (master...2005-testInvalidWitnessDestination) https://github.com/bitcoin/bitcoin/pull/18974
154 2020-05-14T12:38:25  *** bitcoin-git has left #bitcoin-core-dev
155 2020-05-14T12:39:19  <fanquake> promag: can you check the coin control backports in #18973
156 2020-05-14T12:39:21  <gribble> https://github.com/bitcoin/bitcoin/issues/18973 | [0.20] Final backports for rc2 by fanquake · Pull Request #18973 · bitcoin/bitcoin · GitHub
157 2020-05-14T12:41:22  *** bitcoin-git has joined #bitcoin-core-dev
158 2020-05-14T12:41:23  <bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/04c09553d898...b9c504cbc4ba
159 2020-05-14T12:41:23  <bitcoin-git> bitcoin/master fab6d06 MarcoFalke: test: Add unregister_validation_interface_race test
160 2020-05-14T12:41:24  <bitcoin-git> bitcoin/master fa770ce MarcoFalke: validationinterface: Rework documentation, Rename pwalletIn to callbacks
161 2020-05-14T12:41:25  <bitcoin-git> bitcoin/master fa5ceb2 MarcoFalke: test: Remove UninterruptibleSleep from test and replace it by SyncWithVali...
162 2020-05-14T12:41:26  *** bitcoin-git has left #bitcoin-core-dev
163 2020-05-14T12:41:47  *** bitcoin-git has joined #bitcoin-core-dev
164 2020-05-14T12:41:47  <bitcoin-git> [bitcoin] fanquake merged pull request #18742: miner: Avoid stack-use-after-return in validationinterface (master...2004-minerNoCrash) https://github.com/bitcoin/bitcoin/pull/18742
165 2020-05-14T12:41:48  *** bitcoin-git has left #bitcoin-core-dev
166 2020-05-14T12:41:51  *** ghost43 has quit IRC
167 2020-05-14T12:42:37  *** ghost43 has joined #bitcoin-core-dev
168 2020-05-14T12:43:20  *** fearbeag has joined #bitcoin-core-dev
169 2020-05-14T12:43:22  <theStack> fjahr: the interesting part for me would be that it doesn't start a new chain from scratch; if i need 100000s of blocks for performance tests starting a new regtest chain is not an option
170 2020-05-14T12:44:30  <theStack> creating a TestNode() instance with right parameters could maybe work
171 2020-05-14T12:45:02  *** mol_ has joined #bitcoin-core-dev
172 2020-05-14T12:46:42  *** shaunsun_ has quit IRC
173 2020-05-14T12:48:36  *** mol has quit IRC
174 2020-05-14T12:48:37  <jnewbery> theStack: I made some modifications to test_shell to connect to a running full node: https://github.com/jnewbery/bitcoin/tree/node-shell YMMV
175 2020-05-14T12:49:45  <jnewbery> were you planning to do some perf testing for 18960?
176 2020-05-14T12:52:36  <fanquake> MarcoFalke: is there anything obvious to backport into the 0.20 branch to fix the test failures in 18973. Looks like it's mostly in the valgrind builds
177 2020-05-14T12:53:16  <theStack> jnewbery: sounds like exactly what i need, will take a look. thanks!
178 2020-05-14T12:53:52  <jnewbery> fanquake: #18899 removes the valgrind build from travis because it was timing out jobs
179 2020-05-14T12:53:54  <gribble> https://github.com/bitcoin/bitcoin/issues/18899 | travis: Remove valgrind by MarcoFalke · Pull Request #18899 · bitcoin/bitcoin · GitHub
180 2020-05-14T12:54:11  <theStack> jnewbery: yes indeed i was planning to repeatedly fetch the bip 157 checkpoint headers, comparing how long it takes in master and 18960 branches
181 2020-05-14T12:55:26  <theStack> (maybe also compare it with the original proposed solutions by jimpo)
182 2020-05-14T12:55:41  <fanquake> jnewbery: guess that might be worth backporting as  well then
183 2020-05-14T12:56:13  <jnewbery> theStack: great. Thanks! The first time you send a getcfcheckpt, it's reading the values from disk, so it should be slower than the second and subsequent requests
184 2020-05-14T12:57:35  <jnewbery> fanquake: as long as it's not hiding and actual bugs that need to be backported. https://travis-ci.org/github/bitcoin/bitcoin/builds/686857580 do actually look like actual test failures rather than timeouts.
185 2020-05-14T12:59:08  *** promag has quit IRC
186 2020-05-14T12:59:22  *** promag has joined #bitcoin-core-dev
187 2020-05-14T13:11:11  <fanquake> jnewbery: if you've got test backport suggestions I'm all ears. I see some process_message related in the fuzzer, which I assume we've fixed.
188 2020-05-14T13:13:16  <fanquake> I'm going to untag #18287 for 0.20.0. Only myself and sipsorcery have tested it, and neither of us could verify that the change is fixing the actual problem. The patch does fix libevents getaddrinfo detection, but Core still doesn't behave as expected; so I think this needs further testing, and shouldn't be bundled in last minute.
189 2020-05-14T13:13:18  <gribble> https://github.com/bitcoin/bitcoin/issues/18287 | depends: Patch libevent build to fix IPv6 -rpcbind on Windows by luke-jr · Pull Request #18287 · bitcoin/bitcoin · GitHub
190 2020-05-14T13:14:45  <theStack> jnewbery: do you think that is also true for the version without the cache implementation (i.e. master branch)? i don't know if BDB does caching internally (or maybe even the OS?), but there must be something as some people have expressed their doubt if the cache implementation is really improving anything
191 2020-05-14T13:14:53  <theStack> but anyways, i will hopefully find out soon through the benchmarks :)
192 2020-05-14T13:19:50  *** davterra has joined #bitcoin-core-dev
193 2020-05-14T13:28:59  <jnewbery> theStack: perhaps. It's worth testing.
194 2020-05-14T13:29:30  <jnewbery> (the block filter index uses leveldb, not bdb. bdb is only used in the wallet)
195 2020-05-14T13:29:51  *** sipsorcery has joined #bitcoin-core-dev
196 2020-05-14T13:44:37  <jnewbery> fanquake: looks like you'll need #18757 to avoid those false fuzzing failures
197 2020-05-14T13:44:39  <gribble> https://github.com/bitcoin/bitcoin/issues/18757 | test: Remove enumeration of expected deserialization exceptions in ProcessMessage(...) fuzzer by practicalswift · Pull Request #18757 · bitcoin/bitcoin · GitHub
198 2020-05-14T13:53:11  *** troygiorshev has joined #bitcoin-core-dev
199 2020-05-14T14:07:46  *** mdunnio has joined #bitcoin-core-dev
200 2020-05-14T14:09:13  *** per has quit IRC
201 2020-05-14T14:14:37  *** per has joined #bitcoin-core-dev
202 2020-05-14T14:18:48  *** Guyver2 has joined #bitcoin-core-dev
203 2020-05-14T14:21:57  *** Kiminuo has joined #bitcoin-core-dev
204 2020-05-14T14:29:24  *** Kiminuo has quit IRC
205 2020-05-14T14:31:21  *** emilengler has joined #bitcoin-core-dev
206 2020-05-14T14:31:58  *** jonatack has quit IRC
207 2020-05-14T14:33:09  *** molz_ has joined #bitcoin-core-dev
208 2020-05-14T14:33:32  *** bitcoin-git has joined #bitcoin-core-dev
209 2020-05-14T14:33:32  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18968: doc: noban precludes maxuploadtarget disconnects (master...2005-docMaxuploadtarget) https://github.com/bitcoin/bitcoin/pull/18968
210 2020-05-14T14:33:33  *** bitcoin-git has left #bitcoin-core-dev
211 2020-05-14T14:33:52  *** bitcoin-git has joined #bitcoin-core-dev
212 2020-05-14T14:33:52  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18968: doc: noban precludes maxuploadtarget disconnects (master...2005-docMaxuploadtarget) https://github.com/bitcoin/bitcoin/pull/18968
213 2020-05-14T14:33:53  *** bitcoin-git has left #bitcoin-core-dev
214 2020-05-14T14:35:54  *** mol_ has quit IRC
215 2020-05-14T14:37:39  *** promag has quit IRC
216 2020-05-14T14:38:15  *** promag has joined #bitcoin-core-dev
217 2020-05-14T14:46:08  *** proofofkeags has joined #bitcoin-core-dev
218 2020-05-14T14:48:44  <vasild> ResolveSubNet("::/0").Match(ResolveIP("")) -- is true
219 2020-05-14T14:48:53  <vasild> ResolveSubNet("::AAAA:0:0/80").Match(ResolveIP("")) -- is true
220 2020-05-14T14:49:06  <vasild> but
221 2020-05-14T14:49:10  <vasild> ResolveSubNet("::FFFF:0:0/96").Match(ResolveIP("")) -- is false
222 2020-05-14T14:49:37  <vasild> is this a bug?
223 2020-05-14T14:51:46  <vasild> I think it is strange to match IPv4 addresses as belonging to some IPv6 network, so IMO all should be false. But if I accept that we should, for some reason, match IPv4 addresses as belonging to some IPv6 networks, then also the last one should be true.
224 2020-05-14T14:53:52  <vasild> It is not true because "::FFFF:0:0" is interpreted as an IPv4 address ( and the netmask /96 bricks it. It is the same as "".
225 2020-05-14T14:54:45  <wumpus> it's somewhat strange, but it's a by-effect of IPv4 addresses have always been encoded as a kind of IPv6 address in bitcoin
226 2020-05-14T14:55:14  <wumpus> not sure this should affect anything in practice
227 2020-05-14T14:56:54  <vasild> What about stopping to accept IPv4 as IPv6 addresses? That is - all of the above return false?
228 2020-05-14T14:57:16  <vasild> Sorry, "stopping to accept IPv4 as belonging to some IPv6 networks"
229 2020-05-14T14:59:45  <vasild> I am modifying this code wrt ADDRv2 and the new code would return false for all of the above 3 tests. So I wonder if this change in behavior would be ok. In order to mimic the current (strange) behavor a few twists and tweaks would have to be made to the new code, making it less straight forward and a bit more difficult to review.
230 2020-05-14T15:00:02  *** gonemad3 has quit IRC
231 2020-05-14T15:11:27  <vasild> I will go for "no change in behavior" (+some twists in the patch). If it turns out that we don't need to accept IPv4 as part of IPv6 networks (e.g. `::/0`), then the patch can be simplified.
232 2020-05-14T15:16:06  *** maxfragg1 has joined #bitcoin-core-dev
233 2020-05-14T15:17:18  <wumpus> I think that's fine, I don't think it'll affect anything in practice
234 2020-05-14T15:17:35  <wumpus> there's no reason to do mixed IPv6 IPv4 subnet matching
235 2020-05-14T15:18:19  <wumpus> so having it always return false if someone tries seems ok to me
236 2020-05-14T15:19:23  *** Izl has quit IRC
237 2020-05-14T15:19:58  <vasild> ah, excellent!
238 2020-05-14T15:23:16  *** Brenna40Balistre has joined #bitcoin-core-dev
239 2020-05-14T15:24:41  *** DeanGuss has joined #bitcoin-core-dev
240 2020-05-14T15:26:01  *** Brenna40Balistre has quit IRC
241 2020-05-14T15:27:08  *** Kelsi26Mitchell has joined #bitcoin-core-dev
242 2020-05-14T15:29:19  *** proofofkeags has quit IRC
243 2020-05-14T15:29:49  *** Leonie66Hegmann has joined #bitcoin-core-dev
244 2020-05-14T15:29:54  *** proofofkeags has joined #bitcoin-core-dev
245 2020-05-14T15:32:01  *** russo has joined #bitcoin-core-dev
246 2020-05-14T15:33:12  *** goatpig has quit IRC
247 2020-05-14T15:34:12  *** proofofkeags has quit IRC
248 2020-05-14T15:35:12  *** proofofkeags has joined #bitcoin-core-dev
249 2020-05-14T15:39:51  *** brianhoffman has joined #bitcoin-core-dev
250 2020-05-14T15:43:07  *** Pavlenex has joined #bitcoin-core-dev
251 2020-05-14T15:43:50  *** Leonie66Hegmann has quit IRC
252 2020-05-14T15:44:39  <Pavlenex> Hello. I've asked before but got no reply. Serbian translation for 0.20 is ready, it was translated from scratch basically as the language never got much translators. However the language does not have a coordinator or reviewer so it can't be pushed as complete. Who is in charge of Transifex that can provide me with an access so we can proceed? Thanks.
253 2020-05-14T15:53:00  <wumpus> Pavlenex: I should be able to set someone as coordinator
254 2020-05-14T15:54:14  <Pavlenex> wumpus: Hey! https://www.transifex.com/user/profile/nedved/ is my transifex username. However if you want to set somebody else from that team instead, it's fine as long as we can proceed with a review.
255 2020-05-14T15:55:49  *** justanotheruser has quit IRC
256 2020-05-14T15:56:50  <Pavlenex> If I can suggest alternative member that would be  casperBGD, he continued on my initial efforts and completed the translations. Thanks in advance.
257 2020-05-14T15:56:54  *** bitcoin-git has joined #bitcoin-core-dev
258 2020-05-14T15:56:55  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.20: https://github.com/bitcoin/bitcoin/compare/5747c4ca1bf8...7d87ba0e0227
259 2020-05-14T15:56:55  <bitcoin-git> bitcoin/0.20 7d87ba0 MarcoFalke: travis: Remove valgrind
260 2020-05-14T15:56:57  *** bitcoin-git has left #bitcoin-core-dev
261 2020-05-14T15:57:28  *** bitcoin-git has joined #bitcoin-core-dev
262 2020-05-14T15:57:29  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.20: https://github.com/bitcoin/bitcoin/compare/7d87ba0e0227...aa7c6858e6e4
263 2020-05-14T15:57:29  <bitcoin-git> bitcoin/0.20 aa7c685 MarcoFalke: travis: Remove s390x
264 2020-05-14T15:57:31  *** bitcoin-git has left #bitcoin-core-dev
265 2020-05-14T15:57:37  <wumpus> Pavlenex: okay! let me see
266 2020-05-14T16:01:09  <wumpus> Pavlenex: I added you as coordinator for all the Serbian languages, I think you should be able to add other reviewers now
267 2020-05-14T16:02:03  <Pavlenex> wumpus:  Yup, just got the notification. Thanks. I'll try to begin the review process asap.
268 2020-05-14T16:02:20  <wumpus> thank you!
269 2020-05-14T16:03:14  *** molz_ has quit IRC
270 2020-05-14T16:05:45  *** geeker has joined #bitcoin-core-dev
271 2020-05-14T16:10:45  *** promag has quit IRC
272 2020-05-14T16:12:45  *** justanotheruser has joined #bitcoin-core-dev
273 2020-05-14T16:23:23  *** vasild has quit IRC
274 2020-05-14T16:26:39  *** lightlike has joined #bitcoin-core-dev
275 2020-05-14T16:30:46  *** bitcoin-git has joined #bitcoin-core-dev
276 2020-05-14T16:30:46  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18973: [0.20] Final backports for rc2 (0.20...0_20_0rc2_final_backports) https://github.com/bitcoin/bitcoin/pull/18973
277 2020-05-14T16:30:47  *** bitcoin-git has left #bitcoin-core-dev
278 2020-05-14T16:31:06  *** bitcoin-git has joined #bitcoin-core-dev
279 2020-05-14T16:31:06  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18973: [0.20] Final backports for rc2 (0.20...0_20_0rc2_final_backports) https://github.com/bitcoin/bitcoin/pull/18973
280 2020-05-14T16:31:07  *** bitcoin-git has left #bitcoin-core-dev
281 2020-05-14T16:32:35  *** jb55 has quit IRC
282 2020-05-14T16:32:50  *** mol has joined #bitcoin-core-dev
283 2020-05-14T16:35:00  *** vasild has joined #bitcoin-core-dev
284 2020-05-14T16:35:57  *** jb55 has joined #bitcoin-core-dev
285 2020-05-14T16:42:13  *** jonatack has joined #bitcoin-core-dev
286 2020-05-14T16:42:27  *** bitcoin-git has joined #bitcoin-core-dev
287 2020-05-14T16:42:27  <bitcoin-git> [bitcoin] laanwj opened pull request #18975: test: Remove const to work around compiler error on xenial (master...2020_05_xenial_compile_issue) https://github.com/bitcoin/bitcoin/pull/18975
288 2020-05-14T16:42:29  *** bitcoin-git has left #bitcoin-core-dev
289 2020-05-14T16:43:52  *** bitcoin-git has joined #bitcoin-core-dev
290 2020-05-14T16:43:52  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18976: test: Add {} to force default initialization (master...2005-testDefaultInit) https://github.com/bitcoin/bitcoin/pull/18976
291 2020-05-14T16:43:53  *** bitcoin-git has left #bitcoin-core-dev
292 2020-05-14T16:48:29  *** andrewtoth has joined #bitcoin-core-dev
293 2020-05-14T16:53:47  *** molakala has quit IRC
294 2020-05-14T16:58:08  *** bitcoin-git has joined #bitcoin-core-dev
295 2020-05-14T16:58:09  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18976: test: Add {} to force default initialization (master...2005-testDefaultInit) https://github.com/bitcoin/bitcoin/pull/18976
296 2020-05-14T16:58:10  *** bitcoin-git has left #bitcoin-core-dev
297 2020-05-14T17:00:07  <theStack> jnewbery: i posted the results of my getcfcheckpt cache (#18960) research in the PR thread, with a link to the script; there doesn't seem to be any difference, any request up to block 630000 takes 50ms on my machine
298 2020-05-14T17:00:09  <gribble> https://github.com/bitcoin/bitcoin/issues/18960 | [indexes] Add compact block filter headers cache by jnewbery · Pull Request #18960 · bitcoin/bitcoin · GitHub
299 2020-05-14T17:03:52  *** promag has joined #bitcoin-core-dev
300 2020-05-14T17:04:13  *** promag_ has joined #bitcoin-core-dev
301 2020-05-14T17:07:24  *** timothy has quit IRC
302 2020-05-14T17:08:36  <MarcoFalke> hi, I won't make it to today's meeting, but I'd like to put something up for high prio
303 2020-05-14T17:08:38  <MarcoFalke> #proposedmeetingtopic Add #18638 to high prio (MarcoFalke, not actually a topic)
304 2020-05-14T17:08:40  <gribble> https://github.com/bitcoin/bitcoin/issues/18638 | net: Use mockable time for ping/pong, add tests by MarcoFalke · Pull Request #18638 · bitcoin/bitcoin · GitHub
305 2020-05-14T17:16:36  *** tmoc has joined #bitcoin-core-dev
306 2020-05-14T17:17:46  *** Kiminuo has joined #bitcoin-core-dev
307 2020-05-14T17:22:33  *** russo_ has joined #bitcoin-core-dev
308 2020-05-14T17:24:12  *** russo has quit IRC
309 2020-05-14T17:26:49  *** bitcoin-git has joined #bitcoin-core-dev
310 2020-05-14T17:26:50  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b9c504cbc4ba...4dd2e5255a7f
311 2020-05-14T17:26:51  <bitcoin-git> bitcoin/master fa182a8 MarcoFalke: rpcwallet: Replace boost::optional<T>::emplace with simple assignment of T...
312 2020-05-14T17:26:51  <bitcoin-git> bitcoin/master fa1f840 MarcoFalke: rpcwallet: Replace pwallet-> with wallet.
313 2020-05-14T17:26:52  <bitcoin-git> bitcoin/master 4dd2e52 Wladimir J. van der Laan: Merge #18946: rpcwallet: Replace boost::optional<T>::emplace with simple a...
314 2020-05-14T17:26:53  *** bitcoin-git has left #bitcoin-core-dev
315 2020-05-14T17:27:09  *** bitcoin-git has joined #bitcoin-core-dev
316 2020-05-14T17:27:10  <bitcoin-git> [bitcoin] laanwj merged pull request #18946: rpcwallet: Replace boost::optional<T>::emplace with simple assignment of T{} (master...2005-rpcWalletOptional) https://github.com/bitcoin/bitcoin/pull/18946
317 2020-05-14T17:27:11  *** bitcoin-git has left #bitcoin-core-dev
318 2020-05-14T17:34:25  *** russo_ has quit IRC
319 2020-05-14T17:38:38  *** Sentineo has quit IRC
320 2020-05-14T17:41:49  *** gzhao408 has joined #bitcoin-core-dev
321 2020-05-14T17:48:44  *** Sentineo has joined #bitcoin-core-dev
322 2020-05-14T17:51:28  *** Pavlenex has quit IRC
323 2020-05-14T17:53:17  *** gzhao408 has quit IRC
324 2020-05-14T18:00:02  *** maxfragg1 has quit IRC
325 2020-05-14T18:00:50  *** Kiminuo has quit IRC
326 2020-05-14T18:00:51  *** bitcoin-git has joined #bitcoin-core-dev
327 2020-05-14T18:00:52  <bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/4dd2e5255a7f...2d7489be8f77
328 2020-05-14T18:00:52  <bitcoin-git> bitcoin/master 061acf6 fanquake: scripts: no-longer check for 32 bit windows in security-check.py
329 2020-05-14T18:00:53  <bitcoin-git> bitcoin/master 13f606b fanquake: scripts: remove NONFATAL from security-check.py
330 2020-05-14T18:00:53  <bitcoin-git> bitcoin/master 83d063e fanquake: scripts: add run_command to security-check.py
331 2020-05-14T18:00:55  *** bitcoin-git has left #bitcoin-core-dev
332 2020-05-14T18:01:11  *** bitcoin-git has joined #bitcoin-core-dev
333 2020-05-14T18:01:11  <bitcoin-git> [bitcoin] laanwj merged pull request #18796: scripts: security-check.py refactors (master...security_check_no_more_32bit) https://github.com/bitcoin/bitcoin/pull/18796
334 2020-05-14T18:01:12  *** bitcoin-git has left #bitcoin-core-dev
335 2020-05-14T18:18:49  *** owowo has joined #bitcoin-core-dev
336 2020-05-14T18:19:21  *** kik1 has joined #bitcoin-core-dev
337 2020-05-14T18:27:37  *** pinheadmz has quit IRC
338 2020-05-14T18:31:16  *** molakala has joined #bitcoin-core-dev
339 2020-05-14T18:32:54  *** geeker has quit IRC
340 2020-05-14T18:32:58  *** tryphe has quit IRC
341 2020-05-14T18:33:11  *** tryphe has joined #bitcoin-core-dev
342 2020-05-14T18:33:53  *** pinheadmz has joined #bitcoin-core-dev
343 2020-05-14T18:42:31  *** theStack has quit IRC
344 2020-05-14T18:43:11  *** promag has quit IRC
345 2020-05-14T18:43:45  *** promag has joined #bitcoin-core-dev
346 2020-05-14T18:44:22  *** bitcoin-git has joined #bitcoin-core-dev
347 2020-05-14T18:44:22  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2d7489be8f77...553bb3fc3d95
348 2020-05-14T18:44:23  <bitcoin-git> bitcoin/master 7467366 John Newbery: [net processing] Only send a getheaders for one block in an INV
349 2020-05-14T18:44:24  <bitcoin-git> bitcoin/master 553bb3f Wladimir J. van der Laan: Merge #18962: net processing: Only send a getheaders for one block in an I...
350 2020-05-14T18:44:25  *** bitcoin-git has left #bitcoin-core-dev
351 2020-05-14T18:44:42  *** bitcoin-git has joined #bitcoin-core-dev
352 2020-05-14T18:44:42  <bitcoin-git> [bitcoin] laanwj merged pull request #18962: net processing: Only send a getheaders for one block in an INV (master...2020-05-limit-block-inv) https://github.com/bitcoin/bitcoin/pull/18962
353 2020-05-14T18:44:43  *** bitcoin-git has left #bitcoin-core-dev
354 2020-05-14T18:46:30  *** ctrlbreak has quit IRC
355 2020-05-14T18:46:56  *** ctrlbreak has joined #bitcoin-core-dev
356 2020-05-14T18:56:01  *** Kiminuo has joined #bitcoin-core-dev
357 2020-05-14T18:57:48  *** dgenr8 has quit IRC
358 2020-05-14T19:00:31  <wumpus> #startmeeting
359 2020-05-14T19:00:31  <lightningbot> Meeting started Thu May 14 19:00:31 2020 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
360 2020-05-14T19:00:31  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
361 2020-05-14T19:00:38  <kanzure> hi
362 2020-05-14T19:00:44  <sipsorcery>  hi
363 2020-05-14T19:00:53  <elichai2> Hi
364 2020-05-14T19:00:55  <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr
365 2020-05-14T19:00:57  <wumpus> jeremyrubin lightlike emilengler jonatack hebasto jb55
366 2020-05-14T19:01:00  <jonasschnelli> Hi
367 2020-05-14T19:01:03  *** per has quit IRC
368 2020-05-14T19:01:04  <hebasto> hi
369 2020-05-14T19:01:05  <jnewbery> hi
370 2020-05-14T19:01:08  <fjahr> hi
371 2020-05-14T19:01:10  <jkczyz> hi
372 2020-05-14T19:01:33  <meshcollider> hi
373 2020-05-14T19:01:35  <aj> hi
374 2020-05-14T19:01:48  <jeremyrubin> hola
375 2020-05-14T19:02:07  <wumpus> no proposed meeting topics in http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt (only a suggestion for high prio for review)
376 2020-05-14T19:02:48  <achow101> hi
377 2020-05-14T19:03:04  <jeremyrubin> w.r.t. hi prio, i'd like to get the mempool project back on track it's review blocked
378 2020-05-14T19:03:15  <sipa> i have a topic: ok to update to boost 1.59? and if so, when?
379 2020-05-14T19:03:19  <wumpus> any any last minute proposals?
380 2020-05-14T19:03:51  <wumpus> sipa: sgtm (though I'm not sure everyone is here wrt that discussion)
381 2020-05-14T19:04:01  <wumpus> #topic High priority for review
382 2020-05-14T19:04:35  <wumpus> Add #18638 to high prio (MarcoFalke, not actually a topic)
383 2020-05-14T19:04:37  <gribble> https://github.com/bitcoin/bitcoin/issues/18638 | net: Use mockable time for ping/pong, add tests by MarcoFalke · Pull Request #18638 · bitcoin/bitcoin · GitHub
384 2020-05-14T19:05:01  <jnewbery> Could we add #18960 as a blocker?
385 2020-05-14T19:05:02  <gribble> https://github.com/bitcoin/bitcoin/issues/18960 | [indexes] Add compact block filter headers cache by jnewbery · Pull Request #18960 · bitcoin/bitcoin · GitHub
386 2020-05-14T19:05:23  *** sdaftuar has quit IRC
387 2020-05-14T19:05:26  <wumpus> sure
388 2020-05-14T19:05:59  <wumpus> added
389 2020-05-14T19:06:06  <jnewbery> thanks!
390 2020-05-14T19:06:06  *** sdaftuar has joined #bitcoin-core-dev
391 2020-05-14T19:06:58  <wumpus> https://github.com/bitcoin/bitcoin/projects/8   6 blockers, 1 bugfix, 4 chasing concept ACK now
392 2020-05-14T19:07:21  <jeremyrubin> Can we add https://github.com/bitcoin/bitcoin/pull/18191?
393 2020-05-14T19:07:24  <wumpus> jeremyrubin: do you have any specific suggestions wrt prs?
394 2020-05-14T19:07:28  <wumpus> ah thanks
395 2020-05-14T19:08:12  <wumpus> added
396 2020-05-14T19:09:28  <wumpus> #topic required boost to 1.59 (sipa)
397 2020-05-14T19:09:50  <sipa> hi
398 2020-05-14T19:10:04  <wumpus> see also  #8875
399 2020-05-14T19:10:04  <sipa> i'm considering various approaches to improving to some of the p2p tx download logic
400 2020-05-14T19:10:05  <gribble> https://github.com/bitcoin/bitcoin/issues/8875 | Bump minimum required Boost version · Issue #8875 · bitcoin/bitcoin · GitHub
401 2020-05-14T19:10:51  <sipa> and one of them would rely on boost multi_index's ranked indexes
402 2020-05-14T19:11:00  <sipa> which were added in boost 1.59
403 2020-05-14T19:11:14  <sipa> so i was wondering if that's a possibility for 0.21
404 2020-05-14T19:11:23  <sipa> or if i should consider other options (which i may do anyway)
405 2020-05-14T19:11:24  <wumpus> that seems a fair enough reason
406 2020-05-14T19:11:42  * luke-jr grumbles about RHEL/CentOS packages being hard to search
407 2020-05-14T19:11:49  <wumpus> I think the most important thing to check is the versions in currently supported linux distros for building
408 2020-05-14T19:12:14  <wumpus> "Version 1.59.0  August 13th, 2015 15:23 GMT" that sounds old enough, but knowing what old crap some distros ship with, it doesn't say everything
409 2020-05-14T19:12:42  <sipa> well if we're going to be building with c++17, it seems we'd be relying on compilers newer than that anyway
410 2020-05-14T19:13:01  <hebasto> https://github.com/bitcoin/bitcoin/pull/16381#issuecomment-511277755
411 2020-05-14T19:13:03  <wumpus> yes
412 2020-05-14T19:13:16  <jeremyrubin> sipa: ranked indexes look pretty cool
413 2020-05-14T19:13:21  <sipa> they're very cool
414 2020-05-14T19:13:32  <luke-jr> sounds like RHEL/CentOS 8 has boost 1.66
415 2020-05-14T19:13:56  <wumpus> sipa: the dumbest way to find out would be to do a PR that uses that feature and see if it passes travis :)
416 2020-05-14T19:14:14  <wumpus> luke-jr: oh! that's surprisingly new
417 2020-05-14T19:14:14  <luke-jr> Debian has 1.67
418 2020-05-14T19:14:40  <sipa> ok, will try opening a dummy PR and see what happens
419 2020-05-14T19:14:43  <sipa> good enough for me
420 2020-05-14T19:14:48  <jeremyrubin> does it make sense to do a minimum bump for feature or to bump to the highest minimum target we support?
421 2020-05-14T19:14:51  <luke-jr> wumpus: not 100% sure
422 2020-05-14T19:15:07  <wumpus> well sipa has a good reason now
423 2020-05-14T19:15:08  <jeremyrubin> sipa: maybe check there's no bug-fixes to that new functionality in newer versions?
424 2020-05-14T19:15:22  <wumpus> the reason #16381 was closed is that it wasn't important/urgent at the time
425 2020-05-14T19:15:23  <gribble> https://github.com/bitcoin/bitcoin/issues/16381 | Set minimum required Boost to 1.53.0 by hebasto · Pull Request #16381 · bitcoin/bitcoin · GitHub
426 2020-05-14T19:15:36  <sipa> 1.64 has a bug fix related to ranked indices
427 2020-05-14T19:15:48  *** Pavlenex has joined #bitcoin-core-dev
428 2020-05-14T19:15:56  <jeremyrubin> sipa: how severe?
429 2020-05-14T19:15:58  <sipa> but the bug is just something that doesn't compile, which should
430 2020-05-14T19:16:01  <sipa> so not severe at all
431 2020-05-14T19:16:21  <wumpus> "it's eight years old" isn't enough to bump a minimum version, "I need this new data structure" well might be
432 2020-05-14T19:16:58  <luke-jr> https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html-single/8.0_release_notes/index "Boost updated to version 1.66"
433 2020-05-14T19:17:08  <wumpus> we already use boost 1.70 in depends so that's definitely new enough
434 2020-05-14T19:17:15  <sipa> oh!
435 2020-05-14T19:17:16  <sipa> ok
436 2020-05-14T19:17:38  <wumpus> so yeah the current version used for gitian builds doesn't need to be bumped, only the minimum version
437 2020-05-14T19:17:43  <sipa> that's enough for my topic
438 2020-05-14T19:17:45  <jeremyrubin> sipa: are you adding this to mempool or to a diff data structure?
439 2020-05-14T19:17:48  <wumpus> (supported at all)
440 2020-05-14T19:18:07  <luke-jr> Ubuntu LTS is at 1.71
441 2020-05-14T19:18:14  <luke-jr> Arch has 1.72
442 2020-05-14T19:18:15  <jeremyrubin> Just worried that if it goes to mempool multiindex it looks like there's a non-trivial perfromance overhead on all erases
443 2020-05-14T19:18:24  <luke-jr> Gentoo stablre is 1.72
444 2020-05-14T19:18:25  <wumpus> if luke-jr  is right it's complely uncontroversial to bump the minimum to 1.59
445 2020-05-14T19:18:28  <jeremyrubin> but this is less build systemy and more about how you're using it
446 2020-05-14T19:18:46  <wumpus> (it likely depends on CenOS which is alwasys slowest)
447 2020-05-14T19:19:18  <luke-jr> SuSE is 1.66
448 2020-05-14T19:19:25  <sipa> jeremyrubin: no, this is unrelated to mempool
449 2020-05-14T19:19:29  <luke-jr> any other popular distros these days?
450 2020-05-14T19:19:40  <sipa> it's in net processing
451 2020-05-14T19:19:57  <jeremyrubin> cool looking forward to seeing it.
452 2020-05-14T19:20:48  <jeremyrubin> use might actually have some speedups for mempool come to think of it for the eviction logic & mining logic. will noodle on that.
453 2020-05-14T19:21:50  <wumpus> any other topics for this week?
454 2020-05-14T19:21:59  <wumpus> PSA: we're wrapping up 0.20.0rc2 at the moment
455 2020-05-14T19:22:05  <sipa> they add 1 pointer memory usage per entry, fwiw (compared to ordered_index)
456 2020-05-14T19:22:11  <luke-jr> wumpus: do you want me to try to reduce the size of my 0.20 release tarball fixes PR?
457 2020-05-14T19:22:17  <wumpus> #18973
458 2020-05-14T19:22:19  <gribble> https://github.com/bitcoin/bitcoin/issues/18973 | [0.20] Final backports for rc2 by fanquake · Pull Request #18973 · bitcoin/bitcoin · GitHub
459 2020-05-14T19:22:22  <wumpus> (finally)
460 2020-05-14T19:22:24  <jeremyrubin> sipa: it's the log n erase that's more worrisome
461 2020-05-14T19:22:46  <wumpus> luke-jr: sure, but we're not going to hold up the rc on it
462 2020-05-14T19:23:37  <luke-jr> wumpus: it's a security violation for users who build from source
463 2020-05-14T19:23:44  *** tryphe_ has joined #bitcoin-core-dev
464 2020-05-14T19:23:45  <luke-jr> to answer how relevant it is
465 2020-05-14T19:24:08  <wumpus> how so?
466 2020-05-14T19:24:11  <luke-jr> and can result in leaking user private info to the network
467 2020-05-14T19:24:25  <luke-jr> wumpus: it's looking at every parent directory to the source code for a git repo
468 2020-05-14T19:24:33  <wumpus> I mean, it's been absurd how long it's taking to roll this release
469 2020-05-14T19:24:33  <luke-jr> and taking whatever HEAD hash it finds into the version number
470 2020-05-14T19:25:03  <luke-jr> pulling a hash out of an unrelated git repo the user might have, and publishing it, isn't very nice
471 2020-05-14T19:25:16  <wumpus> I agree
472 2020-05-14T19:25:19  <sipa> that sounds like something we should fix
473 2020-05-14T19:25:29  <luke-jr> (Gentoo will kill the build instead)
474 2020-05-14T19:26:01  <wumpus> but honestly we should cut a release at some point, there's aalways some edge case
475 2020-05-14T19:26:13  <luke-jr> this is a regression, too
476 2020-05-14T19:27:16  <wumpus> also #18902 rewrites a large part of the gitian descriptor and changes 6 files, can't this be fixed with some small patch?
477 2020-05-14T19:27:18  <gribble> https://github.com/bitcoin/bitcoin/issues/18902 | Bugfix: Only use git for build info if the repository is actually the right one by luke-jr · Pull Request #18902 · bitcoin/bitcoin · GitHub
478 2020-05-14T19:27:21  *** tryphe has quit IRC
479 2020-05-14T19:27:32  <luke-jr> probably
480 2020-05-14T19:27:55  <luke-jr> I was trying to avoid conflicts with the autogen fix, but I guess we're missing that?
481 2020-05-14T19:28:04  <wumpus> in any case: I agree it should be fixed, but I don't think it's terribly urgent
482 2020-05-14T19:28:39  <hebasto> as a workaround a user could use BITCOIN_GENBUILD_NO_GIT variable
483 2020-05-14T19:28:59  <luke-jr> maybe a release notes mention of the known issues
484 2020-05-14T19:29:07  <wumpus> yes
485 2020-05-14T19:29:21  <wumpus> I think that's fine
486 2020-05-14T19:31:11  <luke-jr> current draft is in wiki still? or git?
487 2020-05-14T19:31:56  <wumpus> wiki https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.20.0-Release-Notes-Draft
488 2020-05-14T19:32:09  *** dongcarl has quit IRC
489 2020-05-14T19:32:15  <luke-jr> k, I'll see about writing something up for that
490 2020-05-14T19:32:22  <wumpus> thanks!
491 2020-05-14T19:32:56  <luke-jr> should I reduce the footprint of #18902 and/or #18909 also?
492 2020-05-14T19:32:58  <gribble> https://github.com/bitcoin/bitcoin/issues/18902 | Bugfix: Only use git for build info if the repository is actually the right one by luke-jr · Pull Request #18902 · bitcoin/bitcoin · GitHub
493 2020-05-14T19:32:59  <gribble> https://github.com/bitcoin/bitcoin/issues/18909 | [0.20] Fix release tarball by luke-jr · Pull Request #18909 · bitcoin/bitcoin · GitHub
494 2020-05-14T19:33:58  <luke-jr> would be nice to just get 18902 merged to master as-is to fix all the issues at once :x   but maybe reducing 18909 makes more sense
495 2020-05-14T19:35:30  <wumpus> fwiw the git_check_in_repo() check looks straightforward enough
496 2020-05-14T19:35:42  <wumpus> why isn't that enough?
497 2020-05-14T19:36:25  <wumpus> (or alternatively, check if a .git is in the top level of the source directory)
498 2020-05-14T19:37:11  <wumpus> besides that change in genbuild.sh, are any other changes needed to fix this?
499 2020-05-14T19:37:57  <hebasto> it is all about "version hack"
500 2020-05-14T19:38:18  <hebasto> in gitian builds
501 2020-05-14T19:38:28  <luke-jr> wumpus: we'd need to restore the "version hack"
502 2020-05-14T19:38:38  <wumpus> luke-jr talks about a security vulnerability importing data from a git repository above the bitcoin one, this can be avoided by checking in genbuild that we're really in a git repo right?
503 2020-05-14T19:38:40  <luke-jr> the genbuild changes in 18902 are a proper fix for that
504 2020-05-14T19:39:03  <wumpus> (I mean, in the right git repo)
505 2020-05-14T19:39:22  <wumpus> yes my question is why isn't that the only change needed?
506 2020-05-14T19:40:16  <wumpus> hebasto: so we can fix this by reverting a change too?
507 2020-05-14T19:40:23  <hebasto> #18349 probably has simpler approach
508 2020-05-14T19:40:24  <luke-jr> those are the only commits specific to 18902 - the other 3 are inherited from 18818
509 2020-05-14T19:40:25  <gribble> https://github.com/bitcoin/bitcoin/issues/18349 | build: Fix quick hack for version string in releases by hebasto · Pull Request #18349 · bitcoin/bitcoin · GitHub
510 2020-05-14T19:40:30  <wumpus> (at least in 0.20)
511 2020-05-14T19:41:04  <hebasto> wumpus: not sure
512 2020-05-14T19:41:44  <luke-jr> reverting a change would be the first commit of 18902 + restoring the "version hack"
513 2020-05-14T19:42:05  <wumpus> ok
514 2020-05-14T19:42:10  <luke-jr> (to literally revert, would be undoing all of the git-archive stuff)
515 2020-05-14T19:42:18  <wumpus> so it's much more complex than I thought
516 2020-05-14T19:42:38  <luke-jr> wumpus: it can be simplified with a few hours I suspect
517 2020-05-14T19:42:41  <wumpus> let's just add a note to the release notes then
518 2020-05-14T19:42:50  <wumpus> any other topics?
519 2020-05-14T19:44:05  <wumpus> #endmeeting
520 2020-05-14T19:44:05  <lightningbot> Meeting ended Thu May 14 19:44:05 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
521 2020-05-14T19:44:05  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-05-14-19.00.html
522 2020-05-14T19:44:05  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-05-14-19.00.txt
523 2020-05-14T19:44:05  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-05-14-19.00.log.html
524 2020-05-14T19:46:26  <luke-jr> https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.20.0-Release-Notes-Draft#known-bugs
525 2020-05-14T19:46:52  *** TheRec has quit IRC
526 2020-05-14T19:48:51  *** TheRec has joined #bitcoin-core-dev
527 2020-05-14T19:48:51  *** TheRec has joined #bitcoin-core-dev
528 2020-05-14T19:50:45  <wumpus> it really looks like the only build configuration used and supported in practice is building from git, everything else is fragile at most
529 2020-05-14T19:54:02  <wumpus> FWIW for releases *and RCs all the version information in in configure.ac
530 2020-05-14T19:54:19  <wumpus> I'm not sure what it gets from git at all
531 2020-05-14T19:55:11  <sipa> random brainstorming (and highly unsure it's worth spending time on): what if we create a file that contains a list of (sha512 tree hash, version string) pairs, and at build time we compare the tree with that file, and use its name if found, tree hash otherwise
532 2020-05-14T19:55:23  <sipa> that would disentangle version naming entirely from git
533 2020-05-14T19:56:30  <wumpus> that's pretty much what git tags are
534 2020-05-14T19:57:19  <wumpus> I mean all the version information is in configure.ac. My point is I don't see why any external information is needed.
535 2020-05-14T19:57:31  <wumpus> neither from git tags nor any external file
536 2020-05-14T19:57:50  <sipa> fair
537 2020-05-14T19:58:27  <wumpus> this used to be differnt, to be clear, at some point the build process derives the rcX from the git tag
538 2020-05-14T19:58:47  <wumpus> but we've already made everything explicit now
539 2020-05-14T19:58:53  <sipa> oh, ok
540 2020-05-14T19:58:55  <wumpus> derived*
541 2020-05-14T19:58:57  <sipa> i was not aware of that
542 2020-05-14T19:59:21  *** promag has quit IRC
543 2020-05-14T19:59:31  *** fearbeag has quit IRC
544 2020-05-14T19:59:37  *** promag has joined #bitcoin-core-dev
545 2020-05-14T20:00:31  *** Pavlenex has quit IRC
546 2020-05-14T20:00:59  <wumpus> no worries, I don't have a full grasp in the version logic actually used either :)
547 2020-05-14T20:02:23  <luke-jr> wumpus: but then we can't build non-releases with correct version info?
548 2020-05-14T20:03:06  <wumpus> luke-jr: what is 'correct version info' in that case anyway?
549 2020-05-14T20:03:13  <luke-jr> [19:50:46] <wumpus> it really looks like the only build configuration used and supported in practice is building from git, everything else is fragile at most <-- I suppose we could just not publish the tarball
550 2020-05-14T20:03:22  <luke-jr> wumpus: a commit hash abbreviation seems fine
551 2020-05-14T20:03:53  <wumpus> well the tarballs are fine, they are for releases and thus contain correct version info
552 2020-05-14T20:04:07  <luke-jr> something like git-describe
553 2020-05-14T20:04:09  <wumpus> they don't need *any* reference to git
554 2020-05-14T20:04:21  <luke-jr> wumpus: currently, they don't..
555 2020-05-14T20:04:23  *** promag has quit IRC
556 2020-05-14T20:04:34  <wumpus> luke-jr: they contain configure.ac, which has all the version info
557 2020-05-14T20:04:50  <wumpus> including rc level
558 2020-05-14T20:05:00  *** promag has joined #bitcoin-core-dev
559 2020-05-14T20:06:21  <wumpus> I know this because I have to set this every time before a rc
560 2020-05-14T20:06:31  <luke-jr> hmm
561 2020-05-14T20:10:11  *** sipsorcery has quit IRC
562 2020-05-14T20:27:15  *** promag has quit IRC
563 2020-05-14T20:27:31  *** promag has joined #bitcoin-core-dev
564 2020-05-14T20:28:12  *** surja795 has joined #bitcoin-core-dev
565 2020-05-14T20:32:36  *** promag has quit IRC
566 2020-05-14T20:33:12  *** promag has joined #bitcoin-core-dev
567 2020-05-14T20:35:20  *** tryphe_ is now known as tryphe
568 2020-05-14T20:46:27  *** emilengler has quit IRC
569 2020-05-14T21:00:02  *** kik1 has quit IRC
570 2020-05-14T21:00:59  *** Kiminuo has quit IRC
571 2020-05-14T21:04:34  *** Chris_Stewart_5 has quit IRC
572 2020-05-14T21:05:12  *** molakala has quit IRC
573 2020-05-14T21:11:37  *** CubicEarth has quit IRC
574 2020-05-14T21:17:06  *** Highway61 has quit IRC
575 2020-05-14T21:17:59  *** alexsuraci has joined #bitcoin-core-dev
576 2020-05-14T21:22:09  *** manantial has quit IRC
577 2020-05-14T21:22:14  *** _Francisco_ has joined #bitcoin-core-dev
578 2020-05-14T21:23:54  *** CubicEarth has joined #bitcoin-core-dev
579 2020-05-14T21:25:14  *** Guyver2 has quit IRC
580 2020-05-14T21:33:28  *** surja795 has quit IRC
581 2020-05-14T21:34:02  *** surja795 has joined #bitcoin-core-dev
582 2020-05-14T21:35:26  *** shesek has quit IRC
583 2020-05-14T21:37:23  *** shesek has joined #bitcoin-core-dev
584 2020-05-14T21:37:23  *** shesek has joined #bitcoin-core-dev
585 2020-05-14T21:38:39  *** surja795 has quit IRC
586 2020-05-14T21:41:12  *** promag_ has quit IRC
587 2020-05-14T21:42:12  *** shesek has quit IRC
588 2020-05-14T21:43:23  *** mol has quit IRC
589 2020-05-14T21:44:37  *** troygiorshev has quit IRC
590 2020-05-14T21:46:07  *** Highway61 has joined #bitcoin-core-dev
591 2020-05-14T21:46:33  *** mol has joined #bitcoin-core-dev
592 2020-05-14T21:49:13  *** filchef has quit IRC
593 2020-05-14T22:05:55  *** dfmbbtc has joined #bitcoin-core-dev
594 2020-05-14T22:09:28  *** dfmb_ has quit IRC
595 2020-05-14T22:20:50  *** troygiorshev has joined #bitcoin-core-dev
596 2020-05-14T22:27:40  *** dfmbbtc has quit IRC
597 2020-05-14T22:38:07  *** marcoagner has quit IRC
598 2020-05-14T22:45:14  *** bitcoin-git has joined #bitcoin-core-dev
599 2020-05-14T22:45:15  <bitcoin-git> [bitcoin] sipa opened pull request #18977: Test ranked_index (master...202005_try_ranked) https://github.com/bitcoin/bitcoin/pull/18977
600 2020-05-14T22:45:15  *** bitcoin-git has left #bitcoin-core-dev
601 2020-05-14T22:50:22  *** troygiorshev has quit IRC
602 2020-05-14T22:50:28  *** jarthur has joined #bitcoin-core-dev
603 2020-05-14T22:59:17  *** tryphe_ has joined #bitcoin-core-dev
604 2020-05-14T22:59:30  *** tryphe has quit IRC
605 2020-05-14T23:00:01  *** andrewtoth has quit IRC
606 2020-05-14T23:06:46  *** mdunnio has quit IRC
607 2020-05-14T23:10:37  <sipa> it seems xenial only have boost 1.58
608 2020-05-14T23:11:47  <jeremyrubin> so.... not till 2021 then?
609 2020-05-14T23:12:27  <jeremyrubin> (Xenial is 16.04 LTS, which goes out of mantenance and to security only in 2021
610 2020-05-14T23:13:13  <jeremyrubin> Personally I think it's probably OK given that it's 4 LTS's old, but it is still in maintenance so conceivable someone is relying on it still...
611 2020-05-14T23:14:21  <jeremyrubin> err 3 LTS's old, not 4 (or 2 depending on how you count the current one)
612 2020-05-14T23:14:22  <MarcoFalke> copy the hpp to our repo? I wanted to remove boost for 0.22.0
613 2020-05-14T23:14:40  <sipa> remove boost? how are you going to do that?
614 2020-05-14T23:14:55  <jeremyrubin> MarcoFalke: IDK if it's feasible givent that multiindex uses like all of boost internally.
615 2020-05-14T23:14:57  <MarcoFalke> Switch to c++17 ;)
616 2020-05-14T23:15:21  <MarcoFalke> If we need a single boost file we could subtree that single file?
617 2020-05-14T23:15:25  <sipa> we're not going to start maintaining our own copy of boost to get around depending on boost
618 2020-05-14T23:15:41  <sipa> it's a zillion .hpp files
619 2020-05-14T23:15:46  <sipa> across various boost packages
620 2020-05-14T23:15:51  <jeremyrubin>  MarcoFalke: I don't think that's feasible, you can try bcp'ing multiindex out and it's big
621 2020-05-14T23:16:11  <MarcoFalke> Ok, didn't know how big it is
622 2020-05-14T23:16:50  <sipa> $ find /usr/include/boost/multi_index* -type f | sort | uniq | wc -l
623 2020-05-14T23:16:51  <sipa> we're not going to start maintaining our own copy of boost to get around depending on boost
624 2020-05-14T23:16:54  <sipa> heh
625 2020-05-14T23:16:58  <sipa> $ find /usr/include/boost/multi_index* -type f | sort | uniq | wc -l
626 2020-05-14T23:17:01  <sipa> 78
627 2020-05-14T23:17:08  <MarcoFalke> ouch
628 2020-05-14T23:17:21  <jeremyrubin> Oh 78? I thought surely it was more than 80, so let's do it!
629 2020-05-14T23:17:39  <sipa> which depends on boost mpl, boost move, a bunch of shared boost utility stuff, ...
630 2020-05-14T23:18:00  <MarcoFalke> fanquake: Looks like you can do your bump ^
631 2020-05-14T23:18:06  <jeremyrubin> MarcoFalke: OTOH rewriting multiindex for our specific use cases seems doable.
632 2020-05-14T23:18:09  <sipa> boost mpl is 1045 files...
633 2020-05-14T23:18:22  <fanquake> 👀
634 2020-05-14T23:18:42  <MarcoFalke> jeremyrubin: Can you write one in less than 100 LOC (clang-formatted)?
635 2020-05-14T23:18:47  <sipa> lol
636 2020-05-14T23:19:04  <sipa> i do not want to write and maintain a copy of multi_index
637 2020-05-14T23:19:10  <jeremyrubin> You can't even define a concrete type for the one we have in less than 100 LOC
638 2020-05-14T23:19:17  <sipa> wahaha
639 2020-05-14T23:19:23  *** DeanGuss has quit IRC
640 2020-05-14T23:20:00  <jeremyrubin> sipa: I think it wouldn't be writing a custom one, but writing a non template concrete impl for the one that we currently use.
641 2020-05-14T23:20:23  <sipa> jeremyrubin: i spent 2 weeks trying to design a custom data structure for the thing i want :)
642 2020-05-14T23:20:26  <sipa> and gave up
643 2020-05-14T23:20:43  <jeremyrubin> Yeah. I'm just prodding MarcoFalke if he wants to ever get rid of boost
644 2020-05-14T23:21:19  <sipa> i mean, it obviously could be done
645 2020-05-14T23:21:46  <sipa> but it'd be far harder to review, and a properly abstracted version would like tend to have some minimal multi_index like reimplementation anyway
646 2020-05-14T23:22:24  <luke-jr> sipa: jeremyrubin: since when do we support anything more than the latest LTS?
647 2020-05-14T23:22:38  <sipa> MarcoFalke: i think as an intermediate goal maybe it's worth trying to only have header-only boost dependencies
648 2020-05-14T23:22:42  <luke-jr> MarcoFalke: copying the hpp is strictly worse than depending on boost
649 2020-05-14T23:22:50  <luke-jr> removing boost doesn't seem like a goal
650 2020-05-14T23:22:58  <luke-jr> just using C++11 (or C++17 eventually) instead
651 2020-05-14T23:23:13  <sipa> i think replacing boost with standard replacements when they're appropriate is great
652 2020-05-14T23:23:19  <sipa> removing boost at all costs seems counter-productive
653 2020-05-14T23:23:24  <luke-jr> exactly
654 2020-05-14T23:23:41  <luke-jr> and we want to add boost::process soon for several things
655 2020-05-14T23:23:53  <luke-jr> which AFAIK there is no C++ std alternative to
656 2020-05-14T23:24:00  <sipa> what for?
657 2020-05-14T23:24:02  <sipa> (just curous)
658 2020-05-14T23:24:12  <jeremyrubin> smooth brain: replacing boost multiindex; galaxy brain: getting multiindex into c++next std
659 2020-05-14T23:24:25  <luke-jr> sipa: HWI, Tor, IIRC there were a few others
660 2020-05-14T23:24:39  <sipa> jeremyrubin: great, let's switch to C++29
661 2020-05-14T23:24:47  <MarcoFalke> ACK
662 2020-05-14T23:25:36  <jeremyrubin> TBH capnproto sounds like a better step to do than boost::process
663 2020-05-14T23:25:40  *** DeanGuss has joined #bitcoin-core-dev
664 2020-05-14T23:25:59  <jeremyrubin> Should be able to handle similar use cases?
665 2020-05-14T23:26:18  <sipa> ?
666 2020-05-14T23:26:30  <sipa> i don't see how they're related
667 2020-05-14T23:27:03  <luke-jr> jeremyrubin: totally different things..
668 2020-05-14T23:27:13  <jeremyrubin> Isn't boost::process just some inter-process glue stuff? IIRC capnproto allows you to setup similar constructs but I could be off.
669 2020-05-14T23:27:28  <luke-jr> boost::process lets us manage running other processes
670 2020-05-14T23:27:29  <sipa> jeremyrubin: that's like saying JSON can replace TCP-IP
671 2020-05-14T23:28:06  <jeremyrubin> gotcha, I just glanced at boost::process and saw that it was talking about IPC stuff
672 2020-05-14T23:28:46  <sipa> i'm not convinced we need boost::process btw, but i haven't thought hard about it
673 2020-05-14T23:32:02  *** _Francisco_ has quit IRC
674 2020-05-14T23:32:15  *** gzhao408 has joined #bitcoin-core-dev
675 2020-05-14T23:32:51  <MarcoFalke> If we require boost::process, we also need to ditch bionic
676 2020-05-14T23:34:04  <fanquake> Just require Debian sid from here on out
677 2020-05-14T23:36:44  <MarcoFalke> At least the switch to C++20 will be included for free /s
678 2020-05-14T23:37:35  <luke-jr> latest stable Ubuntu is focal
679 2020-05-14T23:37:58  <luke-jr> anything older is not guaranteed supported
680 2020-05-14T23:38:26  <luke-jr> also, boost::process can/will probably be optional at first?
681 2020-05-14T23:39:14  *** justanotheruser has quit IRC
682 2020-05-14T23:40:50  *** bitcoin-git has joined #bitcoin-core-dev
683 2020-05-14T23:40:50  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18973: [0.20] Final backports for rc2 (0.20...0_20_0rc2_final_backports) https://github.com/bitcoin/bitcoin/pull/18973
684 2020-05-14T23:40:51  *** bitcoin-git has left #bitcoin-core-dev
685 2020-05-14T23:41:10  *** bitcoin-git has joined #bitcoin-core-dev
686 2020-05-14T23:41:10  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18973: [0.20] Final backports for rc2 (0.20...0_20_0rc2_final_backports) https://github.com/bitcoin/bitcoin/pull/18973
687 2020-05-14T23:41:11  *** bitcoin-git has left #bitcoin-core-dev
688 2020-05-14T23:42:42  *** fearbeag has joined #bitcoin-core-dev
689 2020-05-14T23:45:10  <MarcoFalke> And in reply to "removing boost should not be a goal". I think I disagree. Most of boost seems unmaintained at this point. For example the bug that crashed Bitcoin Core was reported to upstream with steps to reproduce and even a fix. I am still waiting for a reply...
690 2020-05-14T23:45:27  <sipa> which bug?
691 2020-05-14T23:45:30  <MarcoFalke> https://github.com/boostorg/thread/issues/308
692 2020-05-14T23:45:46  <sipa> ha
693 2020-05-14T23:45:55  *** lightlike has quit IRC
694 2020-05-14T23:46:03  <sipa> i think the quality differs a lot between boost libraries
695 2020-05-14T23:46:46  <sipa> and for every goal, we should find the right solution
696 2020-05-14T23:46:59  <sipa> whether that's boost or something else
697 2020-05-14T23:47:29  <sipa> like... boost filesystem and boost shared_ptr effectively turned into c++ stl
698 2020-05-14T23:47:44  <jeremyrubin> Well I think to MarcoFalke's point, if something like multiindex is thousands of files/78 modules
699 2020-05-14T23:47:57  <sipa> yes, and it's great
700 2020-05-14T23:48:03  <sipa> i know nothing that compares to it
701 2020-05-14T23:48:14  <MarcoFalke> Just saying we should be cautious about pulling in dependencies
702 2020-05-14T23:48:22  <sipa> MarcoFalke: absolutely
703 2020-05-14T23:48:26  <jeremyrubin> I think MarcoFalke point is more around security than on features
704 2020-05-14T23:48:35  *** troygiorshev has joined #bitcoin-core-dev
705 2020-05-14T23:48:38  <sipa> but "it's boost" on itself is not a point against a particular solution
706 2020-05-14T23:48:45  <sipa> "it's unmaintained" is
707 2020-05-14T23:49:07  <sipa> or "it's a logistical pain for our build system" is
708 2020-05-14T23:49:20  <fanquake> MarcoFalke: did you save the log that you wanted. I'm about to push more commits
709 2020-05-14T23:49:45  <MarcoFalke> fanquake: I reset the build, which archives the log. Go ahead!
710 2020-05-14T23:50:10  <MarcoFalke> Let's pray the issue is just a race in the test
711 2020-05-14T23:50:26  <MarcoFalke> At least it is not a regression
712 2020-05-14T23:51:48  <MarcoFalke> sipa: I guess your feature wouldn't make sense if it was enabled conditionally on boost multi_index being available?
713 2020-05-14T23:52:21  <MarcoFalke> So xenial users can still compile, but wouldn't get your feature
714 2020-05-14T23:52:47  <sipa> MarcoFalke: it can be worked around with O(n) complexity instead of O(log n)
715 2020-05-14T23:53:32  <sipa> which is probably not terrible in practice, but harder to guarantee no remotely-triggerable extreme conditions that become very slow
716 2020-05-14T23:54:12  *** AaronvanW has quit IRC
717 2020-05-14T23:55:45  *** justanotheruser has joined #bitcoin-core-dev
718 2020-05-14T23:56:42  <jeremyrubin> sipa: Out of curiosity for the design you're making, wouldn't you have to take an action for everything in that rank group anyways?
719 2020-05-14T23:57:18  *** troygiorshev has quit IRC
720 2020-05-14T23:57:38  <jeremyrubin> e.g., isn't this fundamentally O(N)?
721 2020-05-14T23:57:42  <jeremyrubin> *ie
722 2020-05-14T23:59:24  <sipa> jeremyrubin: no