1 2020-05-15T00:00:01  *** alexsuraci has quit IRC
  2 2020-05-15T00:00:23  *** surja795 has joined #bitcoin-core-dev
  3 2020-05-15T00:00:48  <sipa> jeremyrubin: specifically, in a ranked index you can count how many set/index elements have a certain property, and then pick a uniformly random one in O(log n) time
  4 2020-05-15T00:01:11  <sipa> in an ordered index those are O(n) in the number of matching elements
  5 2020-05-15T00:02:32  <jeremyrubin> Gotcha. So some cached property or ordered predicate, you can see how many things satisfy in O(log(N)) and then pick  in O(1) time from that?
  6 2020-05-15T00:04:17  <sipa> picking is still O(log n) in the size of the index in a ranked_index
  7 2020-05-15T00:04:39  <sipa> and counting too
  8 2020-05-15T00:04:51  <jeremyrubin> sipa: interesting. So every query is log(n) for that, (e.g., n queries cost n log n not n)
  9 2020-05-15T00:04:58  <sipa> indeed
 10 2020-05-15T00:05:03  <sipa> well, no
 11 2020-05-15T00:05:14  <sipa> say n is the total index size and m is the number of matching elements
 12 2020-05-15T00:05:22  <jeremyrubin> was just going to ask
 13 2020-05-15T00:05:32  <sipa> then finding the number of matching elements is O(log n)
 14 2020-05-15T00:05:42  <sipa> picking one of them randomly is O(log m)
 15 2020-05-15T00:06:08  <sipa> hmm, in theory - not sure that's implemented though
 16 2020-05-15T00:06:16  <sipa> it may be O(log n) still
 17 2020-05-15T00:06:20  *** bitcoin-git has joined #bitcoin-core-dev
 18 2020-05-15T00:06:21  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/553bb3fc3d95...e2f6866cca3e
 19 2020-05-15T00:06:22  <bitcoin-git> bitcoin/master 050e2ee Wladimir J. van der Laan: test: Remove const to work around compiler error on xenial
 20 2020-05-15T00:06:22  <jeremyrubin> Interesting
 21 2020-05-15T00:06:23  <bitcoin-git> bitcoin/master e2f6866 fanquake: Merge #18975: test: Remove const to work around compiler error on xenial
 22 2020-05-15T00:06:24  *** bitcoin-git has left #bitcoin-core-dev
 23 2020-05-15T00:06:39  <jeremyrubin> Because there are algorithms where you pick your rank M so that log(m) is small
 24 2020-05-15T00:06:40  *** bitcoin-git has joined #bitcoin-core-dev
 25 2020-05-15T00:06:41  <bitcoin-git> [bitcoin] fanquake merged pull request #18975: test: Remove const to work around compiler error on xenial (master...2020_05_xenial_compile_issue) https://github.com/bitcoin/bitcoin/pull/18975
 26 2020-05-15T00:06:42  *** bitcoin-git has left #bitcoin-core-dev
 27 2020-05-15T00:07:11  <jeremyrubin> But the interesting point is you only see a benefit on repeated queries if you're making a few queries to it
 28 2020-05-15T00:07:33  <jeremyrubin> Otherwise you may as well do O(n) to make a new filter, then have O(1) uniform drawing
 29 2020-05-15T00:07:59  <sipa> i don't understand
 30 2020-05-15T00:08:14  <sipa> you cannot pick an element in O(1) time in a tree structure
 31 2020-05-15T00:08:23  <sipa> you need something like a vector for that
 32 2020-05-15T00:08:24  <jeremyrubin> No you're missing what I'm saying
 33 2020-05-15T00:08:39  <jeremyrubin> new filter == make a vector that is the filtered things to match predicate
 34 2020-05-15T00:08:57  <sipa> ok, but that's O(m)
 35 2020-05-15T00:09:22  <jeremyrubin> Depending on the underlying container, O(m) or O(n)
 36 2020-05-15T00:09:32  <jeremyrubin> O(n) if the property isn't already sorted
 37 2020-05-15T00:09:39  <sipa> (no need for a new vector though; you can just do repeated iterator operations, which is always O(m))
 38 2020-05-15T00:09:47  <jeremyrubin> Nope!
 39 2020-05-15T00:09:52  <sipa> picking a random element doesn't require an order
 40 2020-05-15T00:09:54  <jeremyrubin> The vector lets you index in O(1)
 41 2020-05-15T00:10:01  <jeremyrubin> WHich if you're drawing multiple times
 42 2020-05-15T00:10:04  <jeremyrubin> is a speedup.
 43 2020-05-15T00:10:05  <sipa> yes but constructing is at least O(m)
 44 2020-05-15T00:10:07  <sipa> ah
 45 2020-05-15T00:10:12  <jeremyrubin> That's why I asked :)
 46 2020-05-15T00:10:17  <sipa> i only need to pick a random one once
 47 2020-05-15T00:10:29  <sipa> the next time a random element gets picked, the set may have changex
 48 2020-05-15T00:10:46  <jeremyrubin> gotcha.
 49 2020-05-15T00:11:02  <jeremyrubin> So kinda "pick random thing newer than last reconnect"
 50 2020-05-15T00:11:12  <jeremyrubin> *disconnect
 51 2020-05-15T00:12:41  <jeremyrubin> sipa: do you query the property in different ways?
 52 2020-05-15T00:12:47  <jeremyrubin> Or is it just one query
 53 2020-05-15T00:13:07  <jeremyrubin> E.g., top 15% known statically?
 54 2020-05-15T00:13:22  <jeremyrubin> Or is it some per-node %
 55 2020-05-15T00:13:54  <jeremyrubin> also if you have code happy to just look at that
 56 2020-05-15T00:16:43  <sipa> jeremyrubin: i'm stl considering several other approaches
 57 2020-05-15T00:16:50  <sipa> will show code when i have something to show
 58 2020-05-15T00:17:29  <sipa> jeremyrubin: and no, it's not a percentage, it's just to be able to pick uniformly random elements
 59 2020-05-15T00:17:42  <jeremyrubin> over the whole range?
 60 2020-05-15T00:18:09  <jeremyrubin> ah is it also picking uniformly over the range of values? Not just their indexes?
 61 2020-05-15T00:18:25  <sipa> within a subset with some property, which has an index over it
 62 2020-05-15T00:18:36  <sipa> so you find the first index entry with that property, and the last
 63 2020-05-15T00:18:40  <sipa> compute the rank of both
 64 2020-05-15T00:18:50  <sipa> subtract them to count them
 65 2020-05-15T00:18:58  <sipa> pick a uniformly random entry in that range
 66 2020-05-15T00:19:09  <sipa> and then use nth to map that rank to the index entry
 67 2020-05-15T00:19:21  *** wright has joined #bitcoin-core-dev
 68 2020-05-15T00:25:34  *** Highway61 has quit IRC
 69 2020-05-15T00:40:17  *** proofofkeags has quit IRC
 70 2020-05-15T00:40:37  *** proofofkeags has joined #bitcoin-core-dev
 71 2020-05-15T00:41:21  *** tryphe_ has quit IRC
 72 2020-05-15T00:42:02  *** tryphe has joined #bitcoin-core-dev
 73 2020-05-15T00:46:09  *** tryphe_ has joined #bitcoin-core-dev
 74 2020-05-15T00:48:46  *** tryphe has quit IRC
 75 2020-05-15T01:02:52  *** troygiorshev has joined #bitcoin-core-dev
 76 2020-05-15T01:13:08  *** jarthur has quit IRC
 77 2020-05-15T01:14:15  *** promag_ has joined #bitcoin-core-dev
 78 2020-05-15T01:14:51  *** geeker has joined #bitcoin-core-dev
 79 2020-05-15T01:20:35  *** promag_ has quit IRC
 80 2020-05-15T01:21:51  *** promag_ has joined #bitcoin-core-dev
 81 2020-05-15T01:23:55  *** gzhao408 has quit IRC
 82 2020-05-15T01:30:39  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 83 2020-05-15T01:33:33  *** promag_ has quit IRC
 84 2020-05-15T01:37:34  *** Chris_Stewart_5 has quit IRC
 85 2020-05-15T01:48:05  *** gleb has quit IRC
 86 2020-05-15T01:49:46  *** proofofkeags has quit IRC
 87 2020-05-15T01:56:06  *** veleiro`` has joined #bitcoin-core-dev
 88 2020-05-15T01:59:35  *** veleiro` has quit IRC
 89 2020-05-15T02:00:46  *** DeanGuss has quit IRC
 90 2020-05-15T02:01:01  *** DeanGuss has joined #bitcoin-core-dev
 91 2020-05-15T02:05:42  *** proofofkeags has joined #bitcoin-core-dev
 92 2020-05-15T02:10:34  *** proofofkeags has quit IRC
 93 2020-05-15T02:17:57  *** SiAnDoG_ has joined #bitcoin-core-dev
 94 2020-05-15T02:20:10  *** milieu__ has quit IRC
 95 2020-05-15T02:34:41  *** surja795 has quit IRC
 96 2020-05-15T02:35:55  *** surja795 has joined #bitcoin-core-dev
 97 2020-05-15T02:38:15  *** bitdex has joined #bitcoin-core-dev
 98 2020-05-15T02:48:31  *** proofofkeags has joined #bitcoin-core-dev
 99 2020-05-15T02:58:19  *** troygiorshev has quit IRC
100 2020-05-15T03:00:01  *** wright has quit IRC
101 2020-05-15T03:00:28  *** surja795 has quit IRC
102 2020-05-15T03:07:32  *** surja795 has joined #bitcoin-core-dev
103 2020-05-15T03:11:54  *** surja795 has quit IRC
104 2020-05-15T03:13:55  *** troygiorshev has joined #bitcoin-core-dev
105 2020-05-15T03:20:30  *** troygiorshev has quit IRC
106 2020-05-15T03:43:01  *** aowi has joined #bitcoin-core-dev
107 2020-05-15T03:59:23  *** vasild has quit IRC
108 2020-05-15T04:01:31  *** vasild has joined #bitcoin-core-dev
109 2020-05-15T04:07:41  *** davterra has quit IRC
110 2020-05-15T04:08:38  *** Emcy has quit IRC
111 2020-05-15T04:09:09  *** Emcy has joined #bitcoin-core-dev
112 2020-05-15T04:09:22  *** tryphe__ has joined #bitcoin-core-dev
113 2020-05-15T04:12:28  *** tryphe_ has quit IRC
114 2020-05-15T04:19:24  *** proofofkeags has quit IRC
115 2020-05-15T04:23:03  *** vasild has quit IRC
116 2020-05-15T04:24:58  *** vasild has joined #bitcoin-core-dev
117 2020-05-15T04:51:32  *** proofofkeags has joined #bitcoin-core-dev
118 2020-05-15T05:05:02  *** bitdex has quit IRC
119 2020-05-15T05:05:25  *** bitdex has joined #bitcoin-core-dev
120 2020-05-15T05:16:08  *** proofofkeags has quit IRC
121 2020-05-15T05:51:51  *** jonatack has quit IRC
122 2020-05-15T05:55:26  *** manantial has joined #bitcoin-core-dev
123 2020-05-15T06:00:02  *** aowi has quit IRC
124 2020-05-15T06:01:40  *** jonatack has joined #bitcoin-core-dev
125 2020-05-15T06:07:17  *** ctrlbreak has quit IRC
126 2020-05-15T06:07:43  *** ctrlbreak has joined #bitcoin-core-dev
127 2020-05-15T06:16:30  <fanquake> Looking for opinions on just removing the remaining fuzz job for the 0.20 branch. It's not going to pass in Travis without even more backporting: https://github.com/bitcoin/bitcoin/pull/18973#issuecomment-629050088
128 2020-05-15T06:17:04  <fanquake> I think having the fuzzers / valgrind /*san etc just running on master is ok
129 2020-05-15T06:19:20  <luke-jr> without knowing the detail, I'm not sure I'm comfortable with forgoing the valgrind/*san stuff.. if those don't pass, surely we ought to fix them?
130 2020-05-15T06:20:27  <fanquake> The issues are fixed in master, but unless you want to start backporting even more to 0.20.0, like #18413, they are always going to fail on that branch
131 2020-05-15T06:20:30  <gribble> https://github.com/bitcoin/bitcoin/issues/18413 | script: prevent UB when computing abs value for num opcode serialize by pierreN · Pull Request #18413 · bitcoin/bitcoin · GitHub
132 2020-05-15T06:21:30  <fanquake> The valgrind and s390x jobs have already been removed from 0.20.0 in https://github.com/bitcoin/bitcoin/commit/7d87ba0e022796b42d6c17b59bb735c94dd6e045 and https://github.com/bitcoin/bitcoin/commit/aa7c6858e6e480eb841195bdaf2ee0185f17f9a7
133 2020-05-15T06:22:01  *** defnordic has joined #bitcoin-core-dev
134 2020-05-15T06:33:22  *** per has joined #bitcoin-core-dev
135 2020-05-15T06:43:33  <wumpus> fanquake: I think I'd prefer disabling the particular tests that fail for now, instead of disabling fuzzing on the 0.20 branch wholesale
136 2020-05-15T06:43:54  <wumpus> I disabled valgrind and s390x to be on the same basis as master at least
137 2020-05-15T06:44:27  <wumpus> but I do think some of the fuzz testing on the release branch is good, I mean it could uncover e.g. faulty backports
138 2020-05-15T06:44:31  *** bitcoin-git has joined #bitcoin-core-dev
139 2020-05-15T06:44:31  <bitcoin-git> [bitcoin] hebasto opened pull request #18980: build: Decouple clientversion.cpp from the git repo (master...0515-decouple) https://github.com/bitcoin/bitcoin/pull/18980
140 2020-05-15T06:44:32  *** bitcoin-git has left #bitcoin-core-dev
141 2020-05-15T06:46:43  <fanquake> wumpus: ok. I’ll revert the last backport abd disable the scriptnum_ops fuzz test. Will see if anything else fails
142 2020-05-15T06:56:11  *** Emcy has quit IRC
143 2020-05-15T06:56:47  *** Emcy has joined #bitcoin-core-dev
144 2020-05-15T07:13:08  *** yojoots has joined #bitcoin-core-dev
145 2020-05-15T07:16:43  *** yojoots has quit IRC
146 2020-05-15T07:26:32  *** bitcoin-git has joined #bitcoin-core-dev
147 2020-05-15T07:26:32  <bitcoin-git> [bitcoin] fanquake closed pull request #15706: build: Check QT library version (master...check-qt-version) https://github.com/bitcoin/bitcoin/pull/15706
148 2020-05-15T07:26:43  *** bitcoin-git has left #bitcoin-core-dev
149 2020-05-15T07:27:10  *** marcoagner has joined #bitcoin-core-dev
150 2020-05-15T07:41:13  *** emilengler has joined #bitcoin-core-dev
151 2020-05-15T07:49:01  *** bitcoin-git has joined #bitcoin-core-dev
152 2020-05-15T07:49:02  <bitcoin-git> [bitcoin] kallewoof opened pull request #18981: doc: add note about preferring issues over TODO source code comments (master...202005-no-todo) https://github.com/bitcoin/bitcoin/pull/18981
153 2020-05-15T07:49:03  *** bitcoin-git has left #bitcoin-core-dev
154 2020-05-15T07:50:36  *** IGHOR has quit IRC
155 2020-05-15T07:51:45  *** IGHOR has joined #bitcoin-core-dev
156 2020-05-15T07:52:43  *** Pavlenex has joined #bitcoin-core-dev
157 2020-05-15T08:15:49  *** promag has quit IRC
158 2020-05-15T08:16:06  *** promag_ has joined #bitcoin-core-dev
159 2020-05-15T08:16:15  *** promag has joined #bitcoin-core-dev
160 2020-05-15T08:17:22  *** promag has quit IRC
161 2020-05-15T08:26:30  *** emilengler has quit IRC
162 2020-05-15T08:30:43  *** promag_ has quit IRC
163 2020-05-15T08:31:22  *** promag has joined #bitcoin-core-dev
164 2020-05-15T08:32:51  *** promag has joined #bitcoin-core-dev
165 2020-05-15T08:35:22  *** promag_ has joined #bitcoin-core-dev
166 2020-05-15T08:36:05  *** promag_ has joined #bitcoin-core-dev
167 2020-05-15T08:45:02  *** AaronvanW has joined #bitcoin-core-dev
168 2020-05-15T08:49:34  *** ongo has quit IRC
169 2020-05-15T08:49:47  *** _Francisco_ has joined #bitcoin-core-dev
170 2020-05-15T08:53:19  *** EagleTM has joined #bitcoin-core-dev
171 2020-05-15T09:00:01  *** defnordic has quit IRC
172 2020-05-15T09:01:19  *** timothy has joined #bitcoin-core-dev
173 2020-05-15T09:06:59  *** promag_ has quit IRC
174 2020-05-15T09:12:39  *** tmoc has quit IRC
175 2020-05-15T09:21:12  *** Rennex1 has joined #bitcoin-core-dev
176 2020-05-15T09:31:53  *** promag has quit IRC
177 2020-05-15T09:32:29  *** promag has joined #bitcoin-core-dev
178 2020-05-15T09:44:46  *** promag_ has joined #bitcoin-core-dev
179 2020-05-15T09:49:37  *** promag_ has quit IRC
180 2020-05-15T10:01:09  <jonasschnelli> would it make sense to support BIP39 mnemonics in descriptors?
181 2020-05-15T10:02:36  <jonasschnelli> it could work very much the same as xpriv
182 2020-05-15T10:03:21  *** Leo2Schmeler has joined #bitcoin-core-dev
183 2020-05-15T10:04:25  *** surja795 has joined #bitcoin-core-dev
184 2020-05-15T10:04:36  *** dfmb_ has joined #bitcoin-core-dev
185 2020-05-15T10:10:27  *** Leo2Schmeler has quit IRC
186 2020-05-15T10:14:49  *** Pavlenex has quit IRC
187 2020-05-15T10:29:13  *** surja795 has quit IRC
188 2020-05-15T10:30:08  *** Pavlenex has joined #bitcoin-core-dev
189 2020-05-15T10:30:11  *** surja795 has joined #bitcoin-core-dev
190 2020-05-15T10:35:01  *** surja795 has quit IRC
191 2020-05-15T10:48:49  *** theStack has joined #bitcoin-core-dev
192 2020-05-15T10:53:54  *** promag_ has joined #bitcoin-core-dev
193 2020-05-15T10:58:14  *** promag_ has quit IRC
194 2020-05-15T10:59:31  *** _Francisco_ has quit IRC
195 2020-05-15T11:00:50  *** emilengler has joined #bitcoin-core-dev
196 2020-05-15T11:03:25  *** surja795 has joined #bitcoin-core-dev
197 2020-05-15T11:08:54  *** surja795 has quit IRC
198 2020-05-15T11:10:22  *** Chris_Stewart_5 has joined #bitcoin-core-dev
199 2020-05-15T11:17:53  *** Pavlenex has quit IRC
200 2020-05-15T11:18:26  *** Dean_Guss has joined #bitcoin-core-dev
201 2020-05-15T11:19:23  *** DeanGuss has quit IRC
202 2020-05-15T11:22:32  *** Pavlenex has joined #bitcoin-core-dev
203 2020-05-15T11:32:54  *** Highway61 has joined #bitcoin-core-dev
204 2020-05-15T11:49:10  *** surja795 has joined #bitcoin-core-dev
205 2020-05-15T11:52:19  *** sipa has quit IRC
206 2020-05-15T11:52:53  *** Mercury_Vapor has quit IRC
207 2020-05-15T11:53:13  *** sipa has joined #bitcoin-core-dev
208 2020-05-15T11:54:15  *** surja795 has quit IRC
209 2020-05-15T11:55:23  *** bitcoin-git has joined #bitcoin-core-dev
210 2020-05-15T11:55:25  <bitcoin-git> [bitcoin] MarcoFalke pushed 16 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/aa7c6858e6e4...17bdf2afaee0
211 2020-05-15T11:55:26  <bitcoin-git> bitcoin/0.20 315ae14 João Barbosa: gui: Fix itemWalletAddress leak when not tree mode
212 2020-05-15T11:55:27  <bitcoin-git> bitcoin/0.20 fb82173 Amiti Uttarwar: [net processing] ignore tx GETDATA from blocks-only peers
213 2020-05-15T11:55:28  <bitcoin-git> bitcoin/0.20 1e73d72 Amiti Uttarwar: [net processing] ignore unknown INV types in GETDATA messages
214 2020-05-15T11:55:30  *** bitcoin-git has left #bitcoin-core-dev
215 2020-05-15T11:55:47  *** bitcoin-git has joined #bitcoin-core-dev
216 2020-05-15T11:55:47  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18973: [0.20] Final backports for rc2 (0.20...0_20_0rc2_final_backports) https://github.com/bitcoin/bitcoin/pull/18973
217 2020-05-15T11:55:49  <MarcoFalke> ship it? 🤔
218 2020-05-15T11:55:52  *** bitcoin-git has left #bitcoin-core-dev
219 2020-05-15T11:57:55  <MarcoFalke> https://github.com/bitcoin/bitcoin/milestone/42
220 2020-05-15T11:58:31  <MarcoFalke> The only things left is a shutdown bug (not a regression, doesn't have a fix anyway) and the wallet fix, which is tagged "waiting for author"
221 2020-05-15T12:00:02  *** Rennex1 has quit IRC
222 2020-05-15T12:00:30  <MarcoFalke> the wallet bug is not a regression either, right?
223 2020-05-15T12:03:24  <MarcoFalke> Moved back: https://github.com/bitcoin/bitcoin/issues/18325#issuecomment-629196468
224 2020-05-15T12:12:41  <wumpus> yep
225 2020-05-15T12:15:52  *** promag_ has joined #bitcoin-core-dev
226 2020-05-15T12:17:22  *** manantial has quit IRC
227 2020-05-15T12:19:36  <wumpus> doing last minute things for rc2 now
228 2020-05-15T12:19:49  *** bitcoin-git has joined #bitcoin-core-dev
229 2020-05-15T12:19:50  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/17bdf2afaee0...6f7f94a27687
230 2020-05-15T12:19:50  <bitcoin-git> bitcoin/0.20 0793eca Wladimir J. van der Laan: qt: Pre-rc2 translations update
231 2020-05-15T12:19:51  <bitcoin-git> bitcoin/0.20 6f7f94a Wladimir J. van der Laan: build: Bump RC to rc2
232 2020-05-15T12:19:53  *** bitcoin-git has left #bitcoin-core-dev
233 2020-05-15T12:20:08  *** promag_ has quit IRC
234 2020-05-15T12:20:27  *** Arthimus has joined #bitcoin-core-dev
235 2020-05-15T12:20:30  *** geeker has quit IRC
236 2020-05-15T12:20:48  *** bitcoin-git has joined #bitcoin-core-dev
237 2020-05-15T12:20:48  <bitcoin-git> [bitcoin] laanwj pushed tag v0.20.0rc2: https://github.com/bitcoin/bitcoin/compare/v0.20.0rc2
238 2020-05-15T12:20:49  *** bitcoin-git has left #bitcoin-core-dev
239 2020-05-15T12:21:17  <wumpus> woohoooo!!!
240 2020-05-15T12:21:31  <fanquake> 🚀
241 2020-05-15T12:21:43  <fanquake> We made it
242 2020-05-15T12:25:04  <wumpus> about time hehe
243 2020-05-15T12:25:23  <wumpus> thanks for all your help
244 2020-05-15T12:25:29  *** ctrlbreak has quit IRC
245 2020-05-15T12:25:45  *** setpill has joined #bitcoin-core-dev
246 2020-05-15T12:25:56  *** ctrlbreak has joined #bitcoin-core-dev
247 2020-05-15T12:27:45  <MarcoFalke> 🚢
248 2020-05-15T12:27:50  *** Pavlenex has quit IRC
249 2020-05-15T12:30:25  *** geeker has joined #bitcoin-core-dev
250 2020-05-15T12:31:17  <jonasschnelli> Nice!
251 2020-05-15T12:34:12  *** Mercury_Vapor has joined #bitcoin-core-dev
252 2020-05-15T12:34:42  *** geeker has quit IRC
253 2020-05-15T12:45:50  *** troygiorshev has joined #bitcoin-core-dev
254 2020-05-15T12:53:08  *** promag_ has joined #bitcoin-core-dev
255 2020-05-15T12:55:01  *** manantial has joined #bitcoin-core-dev
256 2020-05-15T12:57:56  *** promag_ has quit IRC
257 2020-05-15T13:00:52  *** bitcoin-git has joined #bitcoin-core-dev
258 2020-05-15T13:00:53  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e2f6866cca3e...951870807ea2
259 2020-05-15T13:00:53  <bitcoin-git> bitcoin/master fa0e5b8 MarcoFalke: Add templated GetRandomDuration<>
260 2020-05-15T13:00:54  <bitcoin-git> bitcoin/master 0000ea3 MarcoFalke: test: Add test for GetRandMillis and GetRandMicros
261 2020-05-15T13:00:54  <bitcoin-git> bitcoin/master 9518708 MarcoFalke: Merge #18781: Add templated GetRandDuration<>
262 2020-05-15T13:00:56  *** bitcoin-git has left #bitcoin-core-dev
263 2020-05-15T13:01:17  *** bitcoin-git has joined #bitcoin-core-dev
264 2020-05-15T13:01:17  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18781: Add templated GetRandDuration<> (master...2004-randDur) https://github.com/bitcoin/bitcoin/pull/18781
265 2020-05-15T13:01:25  *** bitcoin-git has left #bitcoin-core-dev
266 2020-05-15T13:08:06  *** seanicide has joined #bitcoin-core-dev
267 2020-05-15T13:19:42  *** setpill has quit IRC
268 2020-05-15T13:22:33  *** dfmb_ has quit IRC
269 2020-05-15T13:34:27  *** surja795 has joined #bitcoin-core-dev
270 2020-05-15T13:38:54  *** surja795 has quit IRC
271 2020-05-15T13:42:02  *** bitcoin-git has joined #bitcoin-core-dev
272 2020-05-15T13:42:02  <bitcoin-git> [bitcoin] ryanofsky opened pull request #18982: wallet: Minimal fix to restore conflicted transaction notifications (master...pr/cblock) https://github.com/bitcoin/bitcoin/pull/18982
273 2020-05-15T13:42:03  *** bitcoin-git has left #bitcoin-core-dev
274 2020-05-15T13:43:09  *** promag has quit IRC
275 2020-05-15T13:43:26  *** promag has joined #bitcoin-core-dev
276 2020-05-15T13:51:06  *** filchef has joined #bitcoin-core-dev
277 2020-05-15T13:53:51  *** mdunnio has joined #bitcoin-core-dev
278 2020-05-15T13:54:11  *** mol has quit IRC
279 2020-05-15T13:55:48  *** mol has joined #bitcoin-core-dev
280 2020-05-15T13:58:52  *** promag_ has joined #bitcoin-core-dev
281 2020-05-15T14:00:57  *** TheRec has quit IRC
282 2020-05-15T14:03:03  *** TheRec has joined #bitcoin-core-dev
283 2020-05-15T14:03:50  *** promag_ has quit IRC
284 2020-05-15T14:16:03  *** dfmb_ has joined #bitcoin-core-dev
285 2020-05-15T14:22:27  *** Pavlenex has joined #bitcoin-core-dev
286 2020-05-15T14:25:28  *** Guyver2 has joined #bitcoin-core-dev
287 2020-05-15T14:33:59  *** mol_ has joined #bitcoin-core-dev
288 2020-05-15T14:37:26  *** mol has quit IRC
289 2020-05-15T14:39:47  *** mol has joined #bitcoin-core-dev
290 2020-05-15T14:42:55  *** mol_ has quit IRC
291 2020-05-15T14:45:50  *** geeker has joined #bitcoin-core-dev
292 2020-05-15T14:50:08  *** geeker has quit IRC
293 2020-05-15T14:52:06  *** Highway61 has quit IRC
294 2020-05-15T15:00:01  *** Arthimus has quit IRC
295 2020-05-15T15:00:51  *** drizztbsd has joined #bitcoin-core-dev
296 2020-05-15T15:01:11  *** timothy has quit IRC
297 2020-05-15T15:02:24  *** kljasdfvv has quit IRC
298 2020-05-15T15:03:35  *** Highway61 has joined #bitcoin-core-dev
299 2020-05-15T15:05:21  *** meshcollider has quit IRC
300 2020-05-15T15:06:59  *** meshcollider has joined #bitcoin-core-dev
301 2020-05-15T15:08:07  *** Highway61 has quit IRC
302 2020-05-15T15:08:08  *** Highway62 has joined #bitcoin-core-dev
303 2020-05-15T15:10:28  *** Highway62 is now known as Highway61
304 2020-05-15T15:15:28  *** geeker has joined #bitcoin-core-dev
305 2020-05-15T15:16:21  *** vhuffst has joined #bitcoin-core-dev
306 2020-05-15T15:19:02  <theStack> does anyone know what happened to bitcoinacks.com?
307 2020-05-15T15:20:06  *** patryk1 has joined #bitcoin-core-dev
308 2020-05-15T15:21:43  <instagibbs> theStack, pierre_rochard isn't maintaining it anymore but I think the source is all there
309 2020-05-15T15:22:36  <fanquake> https://github.com/PierreRochard/bitcoin-acks
310 2020-05-15T15:23:04  <theStack> instagibbs: fanquake: thanks! will try to run it locally, seems like a great project
311 2020-05-15T15:27:24  <theStack> a pity though that there is no official site hosting this anymore, i guess almost one is running this locally, and it maybe is also a great help for new contributors
312 2020-05-15T15:27:40  <theStack> s/one/no-one/
313 2020-05-15T15:28:26  *** promag has quit IRC
314 2020-05-15T15:29:06  *** promag has joined #bitcoin-core-dev
315 2020-05-15T15:32:47  *** theStack has quit IRC
316 2020-05-15T15:34:55  *** justanotheruser has quit IRC
317 2020-05-15T15:37:06  <jonatack> one project that is slowly beginning to have some utility is https://cli.github.com... it's not quite there yet but i'm starting to use it, for instance, to filter and list PRs by label or assignee
318 2020-05-15T15:37:31  <jonatack> same for issues
319 2020-05-15T15:37:31  *** lightlike has joined #bitcoin-core-dev
320 2020-05-15T15:51:28  *** justanotheruser has joined #bitcoin-core-dev
321 2020-05-15T15:54:02  *** manantial has quit IRC
322 2020-05-15T15:55:38  *** Pavlenex has quit IRC
323 2020-05-15T16:00:56  <michaelfolkson> I wonder how much it work it would be to get bitcoinacks.com back up and maintain it. I should ask Pierre
324 2020-05-15T16:01:12  <michaelfolkson> Did people get much use out of it?
325 2020-05-15T16:01:41  <michaelfolkson> I don't know if the long term contributors used it as part of their decision making process for what to review or not
326 2020-05-15T16:02:30  <michaelfolkson> For ACKs that GitHub utility tool you link to won't pick them up jonatack
327 2020-05-15T16:05:58  *** tryphe__ is now known as tryphe
328 2020-05-15T16:13:17  *** jonatack has quit IRC
329 2020-05-15T16:17:12  *** Highway61 has quit IRC
330 2020-05-15T16:17:34  *** Highway61 has joined #bitcoin-core-dev
331 2020-05-15T16:18:08  *** proofofkeags has joined #bitcoin-core-dev
332 2020-05-15T16:18:09  *** jonatack has joined #bitcoin-core-dev
333 2020-05-15T16:18:20  *** Pavlenex has joined #bitcoin-core-dev
334 2020-05-15T16:22:51  *** millerti has joined #bitcoin-core-dev
335 2020-05-15T16:22:52  <jonatack> michaelfolkson: idk how much the maintainers used it. i noticed that sometimes it didn't detect acks properly and needed updating.
336 2020-05-15T16:23:03  *** vasild has quit IRC
337 2020-05-15T16:24:57  *** vasild has joined #bitcoin-core-dev
338 2020-05-15T16:25:15  <jonatack> it was helpful for seeing activity and filtering per author (and it reacted faster than github, for me), i liked it better than the github notifications
339 2020-05-15T16:25:26  <michaelfolkson> jonatack: Really? I can't imagine it would be hard to pick up "Concept ACK" or "ACK" reliably... Maybe there is something I'm missing. People weren't following the guidance on how to communicate ACKs maybe?
340 2020-05-15T16:26:07  <michaelfolkson> Have to be pretty militant on following the ACK communication guidance
341 2020-05-15T16:29:34  <jonatack> michaelfolkson: i don't recall the exceptions, but you had tested ack, tACK, utACK, code review ACK, and the protocol changed a bit last june iirc, adding implementation ack and ACKing with context, the bitcoinacks code needed to keep up with the changes
342 2020-05-15T16:31:34  *** vhuffst has quit IRC
343 2020-05-15T16:33:58  <michaelfolkson> Yeah it did. But it looks like Pierre was still maintaining it up until January of this year
344 2020-05-15T16:34:26  *** promag has quit IRC
345 2020-05-15T16:34:43  *** promag has joined #bitcoin-core-dev
346 2020-05-15T16:39:27  *** promag has quit IRC
347 2020-05-15T16:40:02  *** promag has joined #bitcoin-core-dev
348 2020-05-15T16:43:21  *** troygiorshev has quit IRC
349 2020-05-15T16:46:56  *** kristapsk has quit IRC
350 2020-05-15T16:48:34  *** ghost43 has quit IRC
351 2020-05-15T16:48:35  *** SiAnDoG_ has quit IRC
352 2020-05-15T16:48:36  *** kristapsk has joined #bitcoin-core-dev
353 2020-05-15T16:49:00  *** SiAnDoG_ has joined #bitcoin-core-dev
354 2020-05-15T16:49:20  *** ghost43 has joined #bitcoin-core-dev
355 2020-05-15T16:51:50  *** troygiorshev has joined #bitcoin-core-dev
356 2020-05-15T16:56:16  *** kristapsk has quit IRC
357 2020-05-15T17:04:35  *** geeker has quit IRC
358 2020-05-15T17:11:25  *** ctrlbreak has quit IRC
359 2020-05-15T17:11:53  *** ctrlbreak has joined #bitcoin-core-dev
360 2020-05-15T17:14:32  *** geeker has joined #bitcoin-core-dev
361 2020-05-15T17:14:34  *** kristapsk has joined #bitcoin-core-dev
362 2020-05-15T17:14:54  *** drizztbsd has quit IRC
363 2020-05-15T17:14:55  *** proofofkeags has quit IRC
364 2020-05-15T17:15:26  *** geeker has quit IRC
365 2020-05-15T17:15:47  *** proofofk_ has joined #bitcoin-core-dev
366 2020-05-15T17:15:48  *** geeker has joined #bitcoin-core-dev
367 2020-05-15T17:24:22  <wumpus> I liked bitcoinacks.com and did use it, was kind of disappointed that it went offline, but don't have time to maintain it myself either
368 2020-05-15T17:30:13  <wumpus> even if the ACK counts weren't always exact, it was useful to see which PRs were getting attention from reviewers and could be considered for merge
369 2020-05-15T17:32:49  <wumpus> AFAIK bitcoinacks consists of two parts, one that runs in the background and updates the database, and a web part (I happen to run the first part for x0f.org because it's also used for the x0f mastodon/twitter notifications bot), I don't know how the web part works
370 2020-05-15T17:36:51  *** Pavlenex1 has joined #bitcoin-core-dev
371 2020-05-15T17:37:52  *** Pavlenex has quit IRC
372 2020-05-15T17:37:52  *** Pavlenex1 is now known as Pavlenex
373 2020-05-15T17:56:47  *** promag has quit IRC
374 2020-05-15T17:57:00  *** promag has joined #bitcoin-core-dev
375 2020-05-15T18:00:02  *** patryk1 has quit IRC
376 2020-05-15T18:01:48  *** promag has quit IRC
377 2020-05-15T18:02:28  *** promag has joined #bitcoin-core-dev
378 2020-05-15T18:10:08  *** bitcoin-git has joined #bitcoin-core-dev
379 2020-05-15T18:10:08  <bitcoin-git> [bitcoin] tarboss closed pull request #18961: gui: remove assert in walletcontroller & run setparent in gui-qt main thread (master...master) https://github.com/bitcoin/bitcoin/pull/18961
380 2020-05-15T18:10:09  *** bitcoin-git has left #bitcoin-core-dev
381 2020-05-15T18:16:16  *** surja795 has joined #bitcoin-core-dev
382 2020-05-15T18:19:23  *** alct has joined #bitcoin-core-dev
383 2020-05-15T18:20:46  <jonatack> I wonder if it would make any sense to bring bitcoinacks, with pierre_rochard's permission of course, into https://github.com/bitcoin-core/ to see more attention
384 2020-05-15T18:21:32  * jonatack (ducking if that's a bad idea)
385 2020-05-15T18:22:19  <sipa> i never used it much, but no objection from me
386 2020-05-15T18:24:18  *** jarthur has joined #bitcoin-core-dev
387 2020-05-15T18:25:05  *** mdunnio has quit IRC
388 2020-05-15T18:34:27  *** mdunnio has joined #bitcoin-core-dev
389 2020-05-15T18:56:57  *** ctrlbreak has quit IRC
390 2020-05-15T18:57:26  *** ctrlbreak has joined #bitcoin-core-dev
391 2020-05-15T18:58:47  *** proofofk_ has quit IRC
392 2020-05-15T19:00:50  *** mol_ has joined #bitcoin-core-dev
393 2020-05-15T19:03:51  *** mol has quit IRC
394 2020-05-15T19:04:49  *** Pavlenex has quit IRC
395 2020-05-15T19:08:51  *** proofofkeags has joined #bitcoin-core-dev
396 2020-05-15T19:17:03  *** owowo has quit IRC
397 2020-05-15T19:19:25  *** surja795 has quit IRC
398 2020-05-15T19:21:38  *** owowo has joined #bitcoin-core-dev
399 2020-05-15T19:21:42  *** ctrlbreak has quit IRC
400 2020-05-15T19:22:07  *** ctrlbreak has joined #bitcoin-core-dev
401 2020-05-15T19:23:17  *** fearbeag has quit IRC
402 2020-05-15T19:24:57  *** Pavlenex has joined #bitcoin-core-dev
403 2020-05-15T19:26:20  *** bitcoin-git has joined #bitcoin-core-dev
404 2020-05-15T19:26:21  <bitcoin-git> [bitcoin] dgenr8 opened pull request #18984: Remove unnecessary input blockfile SetPos (master...patch-1) https://github.com/bitcoin/bitcoin/pull/18984
405 2020-05-15T19:26:21  *** bitcoin-git has left #bitcoin-core-dev
406 2020-05-15T19:28:14  *** gleb has joined #bitcoin-core-dev
407 2020-05-15T19:29:02  *** troygiorshev has quit IRC
408 2020-05-15T19:35:11  *** Pavlenex has quit IRC
409 2020-05-15T19:43:14  *** seanicide has quit IRC
410 2020-05-15T19:44:05  *** Highway61 has quit IRC
411 2020-05-15T19:44:34  *** Highway61 has joined #bitcoin-core-dev
412 2020-05-15T19:47:40  *** surja795 has joined #bitcoin-core-dev
413 2020-05-15T20:22:32  *** Technoprenerd has quit IRC
414 2020-05-15T20:24:26  *** Technoprenerd has joined #bitcoin-core-dev
415 2020-05-15T20:43:51  *** proofofkeags has quit IRC
416 2020-05-15T20:48:43  *** kristapsk_ has joined #bitcoin-core-dev
417 2020-05-15T20:49:24  *** Technoprenerd has quit IRC
418 2020-05-15T20:51:33  *** kristapsk has quit IRC
419 2020-05-15T20:55:20  *** proofofkeags has joined #bitcoin-core-dev
420 2020-05-15T21:00:01  *** alct has quit IRC
421 2020-05-15T21:00:21  *** Technoprenerd has joined #bitcoin-core-dev
422 2020-05-15T21:00:28  *** kristapsk_ is now known as kristapsk
423 2020-05-15T21:01:11  *** Guyver2 has quit IRC
424 2020-05-15T21:04:50  *** EagleTM has quit IRC
425 2020-05-15T21:17:40  *** filchef has quit IRC
426 2020-05-15T21:19:49  *** flound1129 has joined #bitcoin-core-dev
427 2020-05-15T21:23:54  *** Chris_Stewart_5 has quit IRC
428 2020-05-15T21:27:01  *** EagleTM has joined #bitcoin-core-dev
429 2020-05-15T21:40:02  *** justanotheruser has quit IRC
430 2020-05-15T21:51:34  *** Highway61 has quit IRC
431 2020-05-15T21:51:43  *** Highway61 has joined #bitcoin-core-dev
432 2020-05-15T21:56:38  *** justanotheruser has joined #bitcoin-core-dev
433 2020-05-15T22:01:07  *** emilengler has quit IRC
434 2020-05-15T22:06:38  *** Highway62 has joined #bitcoin-core-dev
435 2020-05-15T22:07:05  *** Highway61 has quit IRC
436 2020-05-15T22:07:06  *** Highway62 is now known as Highway61
437 2020-05-15T22:10:23  *** mol_ has quit IRC
438 2020-05-15T22:10:32  *** mdunnio has quit IRC
439 2020-05-15T22:16:58  *** Chris_Stewart_5 has joined #bitcoin-core-dev
440 2020-05-15T22:33:26  *** marcoagner has quit IRC
441 2020-05-15T22:36:57  *** Relis has joined #bitcoin-core-dev
442 2020-05-15T22:45:33  *** proofofkeags has quit IRC
443 2020-05-15T22:45:44  *** proofofkeags has joined #bitcoin-core-dev
444 2020-05-15T22:47:20  *** Chris_Stewart_5 has quit IRC
445 2020-05-15T22:53:12  *** Chris_Stewart_5 has joined #bitcoin-core-dev
446 2020-05-15T23:02:41  *** lightlike has quit IRC
447 2020-05-15T23:09:44  *** dfmb_ has quit IRC
448 2020-05-15T23:11:28  *** EagleTM has quit IRC
449 2020-05-15T23:12:07  *** proofofkeags has quit IRC
450 2020-05-15T23:12:38  *** proofofkeags has joined #bitcoin-core-dev
451 2020-05-15T23:15:03  *** braydonf has quit IRC
452 2020-05-15T23:17:09  *** proofofkeags has quit IRC
453 2020-05-15T23:18:07  *** DeanWeen has joined #bitcoin-core-dev
454 2020-05-15T23:19:23  *** Dean_Guss has quit IRC
455 2020-05-15T23:19:55  *** Chris_Stewart_5 has quit IRC
456 2020-05-15T23:24:35  *** mol has joined #bitcoin-core-dev
457 2020-05-15T23:28:35  *** braydonf has joined #bitcoin-core-dev
458 2020-05-15T23:50:07  *** Jackielove4u has quit IRC