1 2020-05-18T00:00:01  *** IOMonster1 has quit IRC
  2 2020-05-18T00:00:59  <shesek> I'm afraid that I'm probably not the the right person for the job, but I will happily help with testing. :) but yes, sorry, I know that making these requests without offering any help implementing them is not very useful. bitcoin core has plenty of features that could be added if someone with the expertise and time prioritized them
  3 2020-05-18T00:02:26  *** proofofkeags has quit IRC
  4 2020-05-18T00:05:04  *** SiAnDoG_ has quit IRC
  5 2020-05-18T00:05:14  <shesek> and to make yet another not very useful request: it is somewhat annoying that `listtransactions` doesn't list the block height directly, but only the block hash and number of confirmations. it would typically mean that you'll need an extra rpc request per transaction to figure the height out (that's what electrum-personal-server does for example)
  6 2020-05-18T00:05:23  <shesek> I hacked around it in a different way - I first check the tip, then fetch `listtransactions`, then make sure the tip hasn't moved in the meanwhile (and retry if it did), then calculate the block height is tip_height-confirmations+1. which isn't very ideal either :)
  7 2020-05-18T00:05:26  *** SiAnDoG_ has joined #bitcoin-core-dev
  8 2020-05-18T00:20:50  *** proofofkeags has joined #bitcoin-core-dev
  9 2020-05-18T00:22:09  *** dhaumann has joined #bitcoin-core-dev
 10 2020-05-18T00:28:31  *** mol_ has quit IRC
 11 2020-05-18T00:31:27  *** mol has joined #bitcoin-core-dev
 12 2020-05-18T00:38:44  <luke-jr> sipa: it might make sense to show the sum of fees pushing for unconfirmed transactions
 13 2020-05-18T00:38:51  <luke-jr> ie, including descendants in it
 14 2020-05-18T00:39:10  *** rottensox has joined #bitcoin-core-dev
 15 2020-05-18T00:39:27  *** rottensox has left #bitcoin-core-dev
 16 2020-05-18T00:43:00  *** surja795 has quit IRC
 17 2020-05-18T00:44:05  *** surja795 has joined #bitcoin-core-dev
 18 2020-05-18T01:16:13  *** proofofkeags has quit IRC
 19 2020-05-18T01:16:50  *** proofofkeags has joined #bitcoin-core-dev
 20 2020-05-18T01:21:12  *** Relis has quit IRC
 21 2020-05-18T01:22:38  *** proofofkeags has quit IRC
 22 2020-05-18T01:22:59  *** Relis has joined #bitcoin-core-dev
 23 2020-05-18T01:24:13  *** justanotheruser has quit IRC
 24 2020-05-18T01:24:16  <kanzure> shesek: document in a ticket
 25 2020-05-18T01:28:03  *** per has quit IRC
 26 2020-05-18T01:36:28  *** go11111111111 has joined #bitcoin-core-dev
 27 2020-05-18T01:39:10  *** go121212 has quit IRC
 28 2020-05-18T01:41:51  *** go121212 has joined #bitcoin-core-dev
 29 2020-05-18T01:44:26  *** go11111111111 has quit IRC
 30 2020-05-18T01:48:21  *** proofofkeags has joined #bitcoin-core-dev
 31 2020-05-18T01:53:52  *** geeker has joined #bitcoin-core-dev
 32 2020-05-18T01:54:10  *** geeker has joined #bitcoin-core-dev
 33 2020-05-18T01:54:28  *** justanotheruser has joined #bitcoin-core-dev
 34 2020-05-18T01:56:52  *** bitcoin-git has joined #bitcoin-core-dev
 35 2020-05-18T01:56:52  <bitcoin-git> [bitcoin] shesek opened pull request #19002: docs: Document that 'fee' is unavailable when there are non-wallet inputs (master...202005-docs-fee) https://github.com/bitcoin/bitcoin/pull/19002
 36 2020-05-18T01:56:53  *** bitcoin-git has left #bitcoin-core-dev
 37 2020-05-18T01:56:59  <shesek> kanzure, ^
 38 2020-05-18T02:31:45  *** mol has quit IRC
 39 2020-05-18T02:34:57  *** mol has joined #bitcoin-core-dev
 40 2020-05-18T02:37:57  *** shesek has quit IRC
 41 2020-05-18T02:38:25  *** shesek has joined #bitcoin-core-dev
 42 2020-05-18T02:38:25  *** shesek has joined #bitcoin-core-dev
 43 2020-05-18T02:52:34  *** surja795 has quit IRC
 44 2020-05-18T03:00:02  *** dhaumann has quit IRC
 45 2020-05-18T03:17:14  *** belcher has quit IRC
 46 2020-05-18T03:20:36  *** jeremyb has joined #bitcoin-core-dev
 47 2020-05-18T03:21:00  *** jeremyb is now known as Guest18050
 48 2020-05-18T03:31:12  *** mol has quit IRC
 49 2020-05-18T03:38:11  *** Relis has quit IRC
 50 2020-05-18T03:57:39  *** Eagle[TM] has joined #bitcoin-core-dev
 51 2020-05-18T03:59:43  *** EagleTM has quit IRC
 52 2020-05-18T04:07:03  * luke-jr prods people to review #17946 <.<
 53 2020-05-18T04:07:04  <gribble> https://github.com/bitcoin/bitcoin/issues/17946 | Fix GBT: Restore "!segwit" and "csv" to "rules" key by luke-jr · Pull Request #17946 · bitcoin/bitcoin · GitHub
 54 2020-05-18T04:08:05  <luke-jr> (apparently this bug is causing segwit transactions to not get mined)
 55 2020-05-18T04:12:15  *** proofofkeags has quit IRC
 56 2020-05-18T04:12:30  *** morcos has quit IRC
 57 2020-05-18T04:12:46  *** morcos has joined #bitcoin-core-dev
 58 2020-05-18T04:12:50  *** proofofkeags has joined #bitcoin-core-dev
 59 2020-05-18T04:15:02  *** morcos has quit IRC
 60 2020-05-18T04:15:15  *** morcos has joined #bitcoin-core-dev
 61 2020-05-18T04:17:36  *** proofofkeags has quit IRC
 62 2020-05-18T04:20:00  *** vasild_ has joined #bitcoin-core-dev
 63 2020-05-18T04:23:23  *** vasild has quit IRC
 64 2020-05-18T04:23:24  *** vasild_ is now known as vasild
 65 2020-05-18T04:27:19  *** go11111111111 has joined #bitcoin-core-dev
 66 2020-05-18T04:29:47  *** go121212 has quit IRC
 67 2020-05-18T04:31:40  *** bitdex has quit IRC
 68 2020-05-18T04:32:25  *** bitdex has joined #bitcoin-core-dev
 69 2020-05-18T04:53:23  *** TheHoliestRoger has quit IRC
 70 2020-05-18T04:54:13  *** TheHoliestRoger has joined #bitcoin-core-dev
 71 2020-05-18T04:59:40  <shesek> luke-jr, you helped convince me to avoid reporting a fee for incoming payments altogether, this is indeed pretty useless without taking parent and child fees into account as well. saved me a bunch work, thanks :p
 72 2020-05-18T05:02:47  *** Dean_Guss has joined #bitcoin-core-dev
 73 2020-05-18T05:05:05  *** tmoc has quit IRC
 74 2020-05-18T05:06:00  *** tmoc has joined #bitcoin-core-dev
 75 2020-05-18T05:06:47  *** mol has joined #bitcoin-core-dev
 76 2020-05-18T05:12:05  *** Talkless has joined #bitcoin-core-dev
 77 2020-05-18T05:19:05  *** mol has quit IRC
 78 2020-05-18T05:23:38  *** davec has quit IRC
 79 2020-05-18T05:32:07  *** davec has joined #bitcoin-core-dev
 80 2020-05-18T05:38:18  *** mol has joined #bitcoin-core-dev
 81 2020-05-18T05:47:32  *** cryptapus has quit IRC
 82 2020-05-18T06:00:02  *** Guest18050 has quit IRC
 83 2020-05-18T06:12:33  <hebasto> wumpus: kindly reminder -- is it time to upload rc2 to https://bitcoincore.org/bin/bitcoin-core-0.20.0/ ?
 84 2020-05-18T06:15:39  *** EagleTM has joined #bitcoin-core-dev
 85 2020-05-18T06:17:59  *** Eagle[TM] has quit IRC
 86 2020-05-18T06:19:36  *** dfmb_ has joined #bitcoin-core-dev
 87 2020-05-18T06:19:59  *** daim2k5 has joined #bitcoin-core-dev
 88 2020-05-18T06:49:50  *** Guyver2 has joined #bitcoin-core-dev
 89 2020-05-18T07:08:43  <shesek> sipa, getmempoolentry is useful indeed, not sure why I haven't considered it (I do ideally need this for confirmed transactions too, but its not as important). thanks.
 90 2020-05-18T07:09:37  <shesek> but now I'm no longer sure that I should be providing raw feerate info for incoming transactions. what would be a sensible way to display fee information that takes ancestors/descendants into account to a user? ideally I'm thinking of a metric that says "if the miner clears transactions paying X sat/vB, this transaction should get included"
 91 2020-05-18T07:11:17  *** tmoc has quit IRC
 92 2020-05-18T07:11:56  <shesek> taking ancestors into account seems easy enough - total fees divided by total vsize. but descendants are more tricky because you only need to take the ones that increase the combined feerate into account, right?
 93 2020-05-18T07:12:41  *** tmoc has joined #bitcoin-core-dev
 94 2020-05-18T07:12:42  <shesek> I guess that means recursively iterating over `spentby` and figuring it out?
 95 2020-05-18T07:13:13  <sipa> shesek: if you want to make a guess for inclusion... run getblocktemplate
 96 2020-05-18T07:14:17  <sipa> perhaps we could expose a way that uses the same algorithm, but without the block weight/sigops restrictions, to have an idea how far down every transaction gets included
 97 2020-05-18T07:15:51  <shesek> I'm not trying to determine the feerate needed to get included in the next block, I'm trying to tell how low the feerate has to be in order for the transaction package to get included
 98 2020-05-18T07:17:02  <sipa> yeah, i know
 99 2020-05-18T07:17:31  <shesek> oh, sorry. I misunderstood you. how can I use getblocktemplate for that?
100 2020-05-18T07:18:08  <sipa> the current algorithm that GBT uses (but this is an implementation detail and subject to change) basically includes transactions in feerate order
101 2020-05-18T07:18:19  <sipa> (package feerate)
102 2020-05-18T07:18:56  <sipa> so you can see how far down in the GBT result you are, to see how many kB worth of block spaces goes to other transactions before it
103 2020-05-18T07:19:03  <sipa> of course, that is restricted to 1 block
104 2020-05-18T07:19:25  <sipa> but it's not too hard to modify things to have a (non-GBT) way to computing the same thing for more than just 1 block
105 2020-05-18T07:24:59  <shesek> so basically make larger and larger blocks until I see the transaction is able to get in? clever, but terribly inefficient :)
106 2020-05-18T07:26:09  <shesek> I guess there's no --bitcoin-unlimited parameter that would easily let me make blocks that are larger than the weight limit, right? :p
107 2020-05-18T07:27:16  <shesek> but it wouldn't be relevant for my purposes anyway, its aimed for personal use on a low-resource environment
108 2020-05-18T07:27:43  <sipa> not larger and larger; just once for a huge size, and keep track of the order
109 2020-05-18T07:28:58  <shesek> assuming a very large mempool and a transaction that's paying a high fee rate relative to others, it could be quite wasteful. like, maybe it would've been enough to create a 10kb block, but you're creating a 50mb one instead anyway
110 2020-05-18T07:29:58  <shesek> so hmm, how about I simply use `ancestorfees/ancestorsize`? this would at least take low feerate ancestors into account, making the feerate less misleading. it still won't take cpfp into account, but still better than just the raw feerate
111 2020-05-18T07:31:46  <shesek> thanks for all the help and your time btw, its very appreciated
112 2020-05-18T07:35:40  *** marcoagner has joined #bitcoin-core-dev
113 2020-05-18T07:47:20  *** Pavlenex has joined #bitcoin-core-dev
114 2020-05-18T08:00:59  *** kljasdfvv has joined #bitcoin-core-dev
115 2020-05-18T08:03:19  *** marcoagner has quit IRC
116 2020-05-18T08:30:33  *** promag has quit IRC
117 2020-05-18T08:30:50  *** promag has joined #bitcoin-core-dev
118 2020-05-18T08:35:34  *** promag has quit IRC
119 2020-05-18T08:36:10  *** promag has joined #bitcoin-core-dev
120 2020-05-18T08:43:27  *** manantial has joined #bitcoin-core-dev
121 2020-05-18T08:50:36  *** DeanWeen has joined #bitcoin-core-dev
122 2020-05-18T08:52:43  *** Dean_Guss has quit IRC
123 2020-05-18T09:00:01  *** daim2k5 has quit IRC
124 2020-05-18T09:07:55  *** bitcoin-git has joined #bitcoin-core-dev
125 2020-05-18T09:07:55  <bitcoin-git> [bitcoin] kcalvinalvin opened pull request #19004: script: Replace const char* to std::string (master...replace-char-with-string) https://github.com/bitcoin/bitcoin/pull/19004
126 2020-05-18T09:08:06  *** bitcoin-git has left #bitcoin-core-dev
127 2020-05-18T09:10:22  *** timothy has joined #bitcoin-core-dev
128 2020-05-18T09:12:03  *** Guyver2 has quit IRC
129 2020-05-18T09:14:31  *** AaronvanW has joined #bitcoin-core-dev
130 2020-05-18T09:19:02  *** tmoc has quit IRC
131 2020-05-18T09:22:26  *** nitind1 has joined #bitcoin-core-dev
132 2020-05-18T09:26:32  *** promag has quit IRC
133 2020-05-18T09:26:48  *** promag has joined #bitcoin-core-dev
134 2020-05-18T09:32:13  *** belcher has joined #bitcoin-core-dev
135 2020-05-18T09:32:33  *** Relis has joined #bitcoin-core-dev
136 2020-05-18T09:35:43  <harding> I'm not sure knowing how deep a transaction is in the package-feerate sorted mempool is useful to normal users.  E.g., knowing that a transaction is 3 block candidates deep in the mempool doesn't mean it's likely to be mined three blocks from now---during active periods, it's likely to be mined much later than that as additional relayed transactions arrive paying next-block and second-to-next-block feerates.  If you want to give
137 2020-05-18T09:35:43  <harding> useful information to the use, I think you want to (1) use getmempoolentry recursively to enumerate all of its descendents (this is limited to 25 by default), (2) find whichever one of those descendents has the highest package feerate (ancestorfees / ancestorsize), (3) loop over the estimatesmartfee estimates for the closest feerate match and report to the user something like "estimated to confirm within 30 blocks".
138 2020-05-18T09:40:10  <aj> harding: i think getblocktemplate is useful for the case where you have P at 1kB + 1000sat, A spending P:0 at 200B, 6000sat, and B spending P:1 at 200B, 800 sat -- gbt will include P+A at 5sat/byte, then B at 4sat/byte, even though B's ancestor fee rate is only 1.5sat/byte
139 2020-05-18T09:42:40  <harding> aj: which of those transactions is the one affecting the user's wallet?
140 2020-05-18T09:43:11  <harding> The one the user wants to know whether it needs to be fee bumped?
141 2020-05-18T09:43:19  <aj> harding: B
142 2020-05-18T09:44:34  *** EagleTM has quit IRC
143 2020-05-18T09:49:21  <harding> Hmm.  That's a good point, but I think it means that both methods might suck for anything that's not in the next-block top of the mempool.  If P+A gets mined without B, then B drops much further down in the mempool.
144 2020-05-18T09:51:17  *** Pavlenex has quit IRC
145 2020-05-18T09:51:45  *** afk11` has quit IRC
146 2020-05-18T09:52:00  <aj> harding: no, 4sat/byte is B's fee rate on its own, it won't move lower
147 2020-05-18T09:52:09  *** afk11` has joined #bitcoin-core-dev
148 2020-05-18T09:52:11  <harding> Yeah, sorry.
149 2020-05-18T09:52:34  <aj> harding: otherwise, yeah
150 2020-05-18T10:13:21  *** Marie20Altenwert has joined #bitcoin-core-dev
151 2020-05-18T10:20:26  *** Marie20Altenwert has quit IRC
152 2020-05-18T10:21:52  *** Pavlenex has joined #bitcoin-core-dev
153 2020-05-18T10:28:25  *** promag_ has joined #bitcoin-core-dev
154 2020-05-18T10:30:02  *** Pavlenex has joined #bitcoin-core-dev
155 2020-05-18T10:30:30  *** surja795 has joined #bitcoin-core-dev
156 2020-05-18T10:33:15  *** promag_ has quit IRC
157 2020-05-18T10:35:26  *** surja795 has quit IRC
158 2020-05-18T10:41:08  *** qubenix has quit IRC
159 2020-05-18T10:46:37  *** qubenix has joined #bitcoin-core-dev
160 2020-05-18T10:53:13  <wumpus> PSA rc2 binaries up https://bitcoincore.org/bin/bitcoin-core-0.20.0/test.rc2/
161 2020-05-18T10:54:23  *** morcos has quit IRC
162 2020-05-18T10:58:31  *** Chris_Stewart_5 has joined #bitcoin-core-dev
163 2020-05-18T11:01:15  <wumpus> hebasto: yes, thanks for the reminder, didn't get around to it in the weekend
164 2020-05-18T11:03:54  *** berndj has quit IRC
165 2020-05-18T11:03:58  <hebasto> \o/
166 2020-05-18T11:05:42  *** berndj has joined #bitcoin-core-dev
167 2020-05-18T11:07:01  <hebasto> downloaded rc2 source archive looks nice :)
168 2020-05-18T11:11:39  *** surja795 has joined #bitcoin-core-dev
169 2020-05-18T11:16:21  *** surja795 has quit IRC
170 2020-05-18T11:18:07  *** Dean_Guss has joined #bitcoin-core-dev
171 2020-05-18T11:19:23  *** DeanWeen has quit IRC
172 2020-05-18T11:21:36  *** theStack has joined #bitcoin-core-dev
173 2020-05-18T11:31:31  *** Pavlenex has joined #bitcoin-core-dev
174 2020-05-18T11:41:34  *** cryptapus has joined #bitcoin-core-dev
175 2020-05-18T11:41:34  *** cryptapus has quit IRC
176 2020-05-18T11:41:34  *** cryptapus has joined #bitcoin-core-dev
177 2020-05-18T11:44:33  *** Pavlenex has quit IRC
178 2020-05-18T11:45:33  *** bitdex has quit IRC
179 2020-05-18T11:50:33  *** surja795 has joined #bitcoin-core-dev
180 2020-05-18T11:55:41  *** surja795 has quit IRC
181 2020-05-18T12:00:02  *** nitind1 has quit IRC
182 2020-05-18T12:01:02  *** surja795 has joined #bitcoin-core-dev
183 2020-05-18T12:22:19  *** justMaD has joined #bitcoin-core-dev
184 2020-05-18T12:25:15  *** bitcoin-git has joined #bitcoin-core-dev
185 2020-05-18T12:25:15  <bitcoin-git> [bitcoin] kcalvinalvin opened pull request #19005: doc: Add documentation for 'checklevel' argument in 'verifychain' RPC… (master...add-documentation-for-verifychain) https://github.com/bitcoin/bitcoin/pull/19005
186 2020-05-18T12:25:23  *** Eliz has joined #bitcoin-core-dev
187 2020-05-18T12:25:26  *** bitcoin-git has left #bitcoin-core-dev
188 2020-05-18T12:25:46  *** Eliz is now known as Guest30063
189 2020-05-18T12:27:35  *** rmoura has quit IRC
190 2020-05-18T12:39:50  *** troygiorshev has joined #bitcoin-core-dev
191 2020-05-18T12:40:19  *** troygiorshev has joined #bitcoin-core-dev
192 2020-05-18T12:45:44  *** justMaD has quit IRC
193 2020-05-18T12:48:48  *** EagleTM has joined #bitcoin-core-dev
194 2020-05-18T13:04:16  *** surja795 has quit IRC
195 2020-05-18T13:12:08  *** bitcoin-git has joined #bitcoin-core-dev
196 2020-05-18T13:12:08  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19006: http: Avoid crash when g_thread_http was never started (master...2005-httpNoCrash) https://github.com/bitcoin/bitcoin/pull/19006
197 2020-05-18T13:12:09  *** bitcoin-git has left #bitcoin-core-dev
198 2020-05-18T13:13:10  *** surja795 has joined #bitcoin-core-dev
199 2020-05-18T13:14:38  *** bowfin has joined #bitcoin-core-dev
200 2020-05-18T13:16:26  *** bowfin has left #bitcoin-core-dev
201 2020-05-18T13:17:58  *** surja795 has quit IRC
202 2020-05-18T13:18:34  *** surja795 has joined #bitcoin-core-dev
203 2020-05-18T13:20:07  *** dgenr8 has joined #bitcoin-core-dev
204 2020-05-18T13:23:08  *** surja795 has quit IRC
205 2020-05-18T13:40:42  *** filchef has joined #bitcoin-core-dev
206 2020-05-18T13:54:13  *** timothy has quit IRC
207 2020-05-18T13:59:07  <jonasschnelli> ugh. #12783 introduced a nasty mac only GUI blocking issue
208 2020-05-18T13:59:10  <gribble> https://github.com/bitcoin/bitcoin/issues/12783 | macOS: disable AppNap during sync by krab · Pull Request #12783 · bitcoin/bitcoin · GitHub
209 2020-05-18T14:01:39  *** AimHere1 has joined #bitcoin-core-dev
210 2020-05-18T14:14:02  *** Pavlenex has joined #bitcoin-core-dev
211 2020-05-18T14:19:32  *** Pavlenex has quit IRC
212 2020-05-18T14:34:57  *** bitcoin-git has joined #bitcoin-core-dev
213 2020-05-18T14:34:57  <bitcoin-git> [bitcoin] jonasschnelli opened pull request #19007: relax GUI locks: avoid unnecesarry calls to ::ChainstateActive().IsInitialBlockDownload (master...2020/05/fix_macguilock) https://github.com/bitcoin/bitcoin/pull/19007
214 2020-05-18T14:34:58  *** bitcoin-git has left #bitcoin-core-dev
215 2020-05-18T14:35:52  *** emilengler has joined #bitcoin-core-dev
216 2020-05-18T14:38:27  *** surja795 has joined #bitcoin-core-dev
217 2020-05-18T14:43:02  *** surja795 has quit IRC
218 2020-05-18T14:43:27  *** mdunnio has joined #bitcoin-core-dev
219 2020-05-18T14:44:57  *** surja795 has joined #bitcoin-core-dev
220 2020-05-18T14:45:12  *** Relis has quit IRC
221 2020-05-18T14:49:17  *** surja795 has quit IRC
222 2020-05-18T14:57:37  *** Relis has joined #bitcoin-core-dev
223 2020-05-18T15:00:02  *** AimHere1 has quit IRC
224 2020-05-18T15:04:09  *** Guyver2 has joined #bitcoin-core-dev
225 2020-05-18T15:04:48  *** Pavlenex has joined #bitcoin-core-dev
226 2020-05-18T15:05:09  *** promag has quit IRC
227 2020-05-18T15:05:50  *** promag has joined #bitcoin-core-dev
228 2020-05-18T15:06:42  *** promag has quit IRC
229 2020-05-18T15:06:56  *** promag has joined #bitcoin-core-dev
230 2020-05-18T15:14:27  *** surja795 has joined #bitcoin-core-dev
231 2020-05-18T15:14:30  *** promag has quit IRC
232 2020-05-18T15:14:56  *** promag has joined #bitcoin-core-dev
233 2020-05-18T15:16:06  *** troygiorshev has quit IRC
234 2020-05-18T15:18:39  *** promag_ has joined #bitcoin-core-dev
235 2020-05-18T15:18:39  *** promag has quit IRC
236 2020-05-18T15:19:17  *** surja795 has quit IRC
237 2020-05-18T15:20:55  *** surja795 has joined #bitcoin-core-dev
238 2020-05-18T15:21:33  *** sirkitree has joined #bitcoin-core-dev
239 2020-05-18T15:25:31  *** surja795 has quit IRC
240 2020-05-18T15:26:54  *** troygiorshev has joined #bitcoin-core-dev
241 2020-05-18T15:27:51  *** troygiorshev has joined #bitcoin-core-dev
242 2020-05-18T15:28:47  *** Pavlenex has quit IRC
243 2020-05-18T15:28:50  *** promag_ has quit IRC
244 2020-05-18T15:30:18  *** troygiorshev has joined #bitcoin-core-dev
245 2020-05-18T15:30:38  *** justanotheruser has quit IRC
246 2020-05-18T15:35:17  *** surja795 has joined #bitcoin-core-dev
247 2020-05-18T15:35:43  *** troygiorshev has quit IRC
248 2020-05-18T15:35:57  *** troygiorshev has joined #bitcoin-core-dev
249 2020-05-18T15:36:05  *** Pavlenex has joined #bitcoin-core-dev
250 2020-05-18T15:36:47  *** promag has joined #bitcoin-core-dev
251 2020-05-18T15:39:34  *** surja795 has quit IRC
252 2020-05-18T15:40:21  *** promag has quit IRC
253 2020-05-18T15:40:27  *** promag has joined #bitcoin-core-dev
254 2020-05-18T15:44:32  *** troygiorshev has quit IRC
255 2020-05-18T15:44:48  *** troygiorshev has joined #bitcoin-core-dev
256 2020-05-18T15:47:19  *** justanotheruser has joined #bitcoin-core-dev
257 2020-05-18T15:51:07  *** promag has quit IRC
258 2020-05-18T15:51:43  *** promag has joined #bitcoin-core-dev
259 2020-05-18T15:59:32  *** brianhoffman has quit IRC
260 2020-05-18T16:00:47  *** proofofkeags has joined #bitcoin-core-dev
261 2020-05-18T16:02:23  *** brianhoffman has joined #bitcoin-core-dev
262 2020-05-18T16:02:39  *** proofofkeags has quit IRC
263 2020-05-18T16:03:12  *** proofofkeags has joined #bitcoin-core-dev
264 2020-05-18T16:05:08  *** promag_ has joined #bitcoin-core-dev
265 2020-05-18T16:08:02  *** proofofkeags has quit IRC
266 2020-05-18T16:18:52  *** surja795 has joined #bitcoin-core-dev
267 2020-05-18T16:20:10  *** vasild_ has joined #bitcoin-core-dev
268 2020-05-18T16:23:03  *** vasild has quit IRC
269 2020-05-18T16:23:04  *** vasild_ is now known as vasild
270 2020-05-18T16:23:30  *** Pavlenex has quit IRC
271 2020-05-18T16:23:37  *** surja795 has quit IRC
272 2020-05-18T16:26:29  *** promag_ has quit IRC
273 2020-05-18T16:28:43  *** proofofkeags has joined #bitcoin-core-dev
274 2020-05-18T16:33:31  *** proofofkeags has quit IRC
275 2020-05-18T16:40:35  *** real_or_random has quit IRC
276 2020-05-18T16:41:43  *** real_or_random has joined #bitcoin-core-dev
277 2020-05-18T16:42:26  *** Guest30063 has quit IRC
278 2020-05-18T16:59:57  *** proofofkeags has joined #bitcoin-core-dev
279 2020-05-18T17:04:08  *** EagleTM has quit IRC
280 2020-05-18T17:19:09  *** Pavlenex has joined #bitcoin-core-dev
281 2020-05-18T17:30:59  *** bitcoin-git has joined #bitcoin-core-dev
282 2020-05-18T17:31:00  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19008: ci: tsan on focal (master...2005-ciTsanFocal) https://github.com/bitcoin/bitcoin/pull/19008
283 2020-05-18T17:31:00  *** bitcoin-git has left #bitcoin-core-dev
284 2020-05-18T17:39:06  *** bitcoin-git has joined #bitcoin-core-dev
285 2020-05-18T17:39:06  <bitcoin-git> [bitcoin] h2o10 opened pull request #19009: Print "verifychain" progress every 1 step if user verifies whole blockchain. (master...patch-3) https://github.com/bitcoin/bitcoin/pull/19009
286 2020-05-18T17:39:07  *** bitcoin-git has left #bitcoin-core-dev
287 2020-05-18T17:53:57  *** troygiorshev has quit IRC
288 2020-05-18T18:00:02  *** sirkitree has quit IRC
289 2020-05-18T18:01:37  *** nickler is now known as nix-bitcoin
290 2020-05-18T18:01:53  *** nix-bitcoin is now known as nickler
291 2020-05-18T18:06:06  *** Pavlenex has quit IRC
292 2020-05-18T18:10:24  *** Pavlenex has joined #bitcoin-core-dev
293 2020-05-18T18:13:12  *** marcoagner has joined #bitcoin-core-dev
294 2020-05-18T18:17:41  *** ironhelix has joined #bitcoin-core-dev
295 2020-05-18T18:22:06  *** MasterGruntR75 has joined #bitcoin-core-dev
296 2020-05-18T18:29:20  *** EagleTM has joined #bitcoin-core-dev
297 2020-05-18T18:41:24  *** proofofkeags has quit IRC
298 2020-05-18T18:41:57  *** proofofkeags has joined #bitcoin-core-dev
299 2020-05-18T18:46:29  *** go121212 has joined #bitcoin-core-dev
300 2020-05-18T18:46:38  *** proofofkeags has quit IRC
301 2020-05-18T18:49:10  *** go11111111111 has quit IRC
302 2020-05-18T18:52:35  *** DeanWeen has joined #bitcoin-core-dev
303 2020-05-18T18:52:37  *** Dean_Guss has quit IRC
304 2020-05-18T18:53:03  *** owowo has quit IRC
305 2020-05-18T18:57:58  *** owowo has joined #bitcoin-core-dev
306 2020-05-18T18:58:38  *** bitcoin-git has joined #bitcoin-core-dev
307 2020-05-18T18:58:38  <bitcoin-git> [bitcoin] jnewbery opened pull request #19010: net processing: Add support for getcfheaders (master...2020-05-cfheaders) https://github.com/bitcoin/bitcoin/pull/19010
308 2020-05-18T18:58:46  *** bitcoin-git has left #bitcoin-core-dev
309 2020-05-18T19:07:55  *** proofofkeags has joined #bitcoin-core-dev
310 2020-05-18T19:10:20  *** promag_ has joined #bitcoin-core-dev
311 2020-05-18T19:12:37  *** proofofkeags has quit IRC
312 2020-05-18T19:13:38  *** promag_ has quit IRC
313 2020-05-18T19:14:32  *** Talkless has quit IRC
314 2020-05-18T19:19:24  *** promag_ has joined #bitcoin-core-dev
315 2020-05-18T19:21:14  *** emilengler has quit IRC
316 2020-05-18T19:29:02  *** troygiorshev has joined #bitcoin-core-dev
317 2020-05-18T19:30:03  *** MrSquanchee has joined #bitcoin-core-dev
318 2020-05-18T19:30:19  *** EagleTM has quit IRC
319 2020-05-18T19:33:39  *** troygiorshev has quit IRC
320 2020-05-18T19:40:05  *** dfmb_ has quit IRC
321 2020-05-18T19:45:02  *** kristapsk_ has quit IRC
322 2020-05-18T19:47:17  *** EagleTM has joined #bitcoin-core-dev
323 2020-05-18T19:47:51  <pierre_rochard> For those interested, https://bitcoinacks.com is back up, feel free to send pull requests / feature ideas
324 2020-05-18T19:47:53  *** promag_ has quit IRC
325 2020-05-18T19:52:10  *** MrSquanchee has left #bitcoin-core-dev
326 2020-05-18T19:52:16  <michaelfolkson> Awesome. I'm assuming from the above you have the time to maintain it pierre_rochard going forward?
327 2020-05-18T19:53:35  <pierre_rochard> Yes for the foreseeable future, if that changes I'll notify here and hand it over if there are users.
328 2020-05-18T19:54:03  <michaelfolkson> Cool, that's great. Thanks
329 2020-05-18T20:03:21  <harding> pierre_rochard: thanks!
330 2020-05-18T20:05:44  *** MasterGruntR75 has quit IRC
331 2020-05-18T20:14:35  *** bitcoin-git has joined #bitcoin-core-dev
332 2020-05-18T20:14:35  <bitcoin-git> [bitcoin] jonasschnelli opened pull request #19011: Reduce cs_main lock accumulation during GUI startup (master...2020/05/guilocks) https://github.com/bitcoin/bitcoin/pull/19011
333 2020-05-18T20:14:36  *** bitcoin-git has left #bitcoin-core-dev
334 2020-05-18T20:14:52  <tryphe> is there any way to resolve these review comments? i guess i've selected the wrong review type but it looks ugly to see all of my comments expanded: https://github.com/bitcoin/bitcoin/pull/19004#pullrequestreview-413807305
335 2020-05-18T20:15:09  <tryphe> or maybe i can't and will have to select the right one in the future
336 2020-05-18T20:16:23  *** proofofkeags has joined #bitcoin-core-dev
337 2020-05-18T20:18:53  <jonasschnelli> tryphe: don't you have a "Resolve conversation" button?
338 2020-05-18T20:18:56  <sipa> tryphe: i marked them resolved for you
339 2020-05-18T20:19:11  <jonasschnelli> (or is that an admin thing?)
340 2020-05-18T20:19:23  <tryphe> sipa, thanks
341 2020-05-18T20:19:34  <tryphe> jonasschnelli, i had selected the first type of review, something like "general comments"
342 2020-05-18T20:19:48  <sipa> tryphe: not sure what you mean by review type
343 2020-05-18T20:19:49  <tryphe> i guess the resolve button is only available for the other 2 choices
344 2020-05-18T20:20:44  *** promag has quit IRC
345 2020-05-18T20:21:00  *** promag has joined #bitcoin-core-dev
346 2020-05-18T20:21:48  <tryphe> sipa, when you press "start a review" there's multiple choices, and i wasn't able to unexpand my comments from showing up in the default thread without you doing it
347 2020-05-18T20:22:26  <tryphe> will use the other ones in the future
348 2020-05-18T20:25:20  <tryphe> i guess maybe only the author and admins can resolve the conversation?
349 2020-05-18T20:25:55  <tryphe> author/PR author
350 2020-05-18T20:26:42  <sipa> huh, never seen that
351 2020-05-18T20:27:18  <tryphe> yeah i had figured i could resolve it, but honestly i don't do much review and didn't know which review type to select
352 2020-05-18T20:33:09  *** aqu4 has joined #bitcoin-core-dev
353 2020-05-18T20:34:23  *** kristapsk has joined #bitcoin-core-dev
354 2020-05-18T20:37:56  *** promag has quit IRC
355 2020-05-18T20:52:13  *** surja795 has joined #bitcoin-core-dev
356 2020-05-18T20:52:50  *** EagleTM has quit IRC
357 2020-05-18T20:53:17  *** filchef has quit IRC
358 2020-05-18T21:00:02  *** aqu4 has quit IRC
359 2020-05-18T21:04:47  *** kristapsk has quit IRC
360 2020-05-18T21:06:20  *** Guyver2 has quit IRC
361 2020-05-18T21:13:12  *** kristapsk has joined #bitcoin-core-dev
362 2020-05-18T21:21:47  *** r2wj has joined #bitcoin-core-dev
363 2020-05-18T21:26:03  *** mrostecki has quit IRC
364 2020-05-18T21:32:38  *** Pavlenex has quit IRC
365 2020-05-18T21:34:16  *** Chris_Stewart_5 has quit IRC
366 2020-05-18T21:36:12  *** promag has joined #bitcoin-core-dev
367 2020-05-18T21:38:23  *** DeanWeen has quit IRC
368 2020-05-18T21:38:58  *** Manats has joined #bitcoin-core-dev
369 2020-05-18T21:40:03  *** Manats has quit IRC
370 2020-05-18T21:40:22  *** Chris_Stewart_5 has joined #bitcoin-core-dev
371 2020-05-18T21:42:58  *** mrostecki has joined #bitcoin-core-dev
372 2020-05-18T21:44:01  *** shesek has quit IRC
373 2020-05-18T21:47:32  *** shesek has joined #bitcoin-core-dev
374 2020-05-18T21:47:32  *** shesek has joined #bitcoin-core-dev
375 2020-05-18T21:47:51  *** manantial has quit IRC
376 2020-05-18T21:54:13  *** shesek has quit IRC
377 2020-05-18T21:55:23  *** shesek has joined #bitcoin-core-dev
378 2020-05-18T21:55:23  *** shesek has joined #bitcoin-core-dev
379 2020-05-18T21:56:27  *** mdunnio has quit IRC
380 2020-05-18T21:59:58  *** shesek has quit IRC
381 2020-05-18T22:00:42  *** proofofkeags has quit IRC
382 2020-05-18T22:01:08  *** proofofkeags has joined #bitcoin-core-dev
383 2020-05-18T22:04:01  *** shesek has joined #bitcoin-core-dev
384 2020-05-18T22:04:01  *** shesek has joined #bitcoin-core-dev
385 2020-05-18T22:05:43  *** proofofkeags has quit IRC
386 2020-05-18T22:11:00  *** promag has quit IRC
387 2020-05-18T22:18:14  *** roconnor has quit IRC
388 2020-05-18T22:21:26  *** marcoagner has quit IRC
389 2020-05-18T22:22:11  *** roconnor has joined #bitcoin-core-dev
390 2020-05-18T22:28:02  *** troygiorshev has joined #bitcoin-core-dev
391 2020-05-18T22:28:20  *** promag has joined #bitcoin-core-dev
392 2020-05-18T22:34:15  *** pinheadmz has quit IRC
393 2020-05-18T22:34:59  *** pinheadmz has joined #bitcoin-core-dev
394 2020-05-18T22:35:04  *** troygiorshev has quit IRC
395 2020-05-18T23:00:31  *** mrostecki has quit IRC
396 2020-05-18T23:10:41  *** mrostecki has joined #bitcoin-core-dev
397 2020-05-18T23:26:43  *** vasild has quit IRC
398 2020-05-18T23:26:58  *** vasild has joined #bitcoin-core-dev
399 2020-05-18T23:31:55  *** promag has quit IRC
400 2020-05-18T23:37:34  *** justanotheruser has quit IRC
401 2020-05-18T23:52:29  *** niklas54 has joined #bitcoin-core-dev
402 2020-05-18T23:54:07  *** justanotheruser has joined #bitcoin-core-dev