1 2020-05-22T00:00:02  *** jtk has quit IRC
  2 2020-05-22T00:13:21  *** AaronvanW has joined #bitcoin-core-dev
  3 2020-05-22T00:18:13  *** AaronvanW has quit IRC
  4 2020-05-22T00:20:27  *** CubicEarth has quit IRC
  5 2020-05-22T00:21:08  *** vladan1 has joined #bitcoin-core-dev
  6 2020-05-22T00:22:33  *** CubicEarth has joined #bitcoin-core-dev
  7 2020-05-22T00:23:39  *** proofofkeags has joined #bitcoin-core-dev
  8 2020-05-22T00:27:56  *** proofofkeags has quit IRC
  9 2020-05-22T00:33:42  *** braydonf has quit IRC
 10 2020-05-22T00:39:09  *** braydonf has joined #bitcoin-core-dev
 11 2020-05-22T00:47:02  *** braydonf has quit IRC
 12 2020-05-22T01:01:36  *** proofofkeags has joined #bitcoin-core-dev
 13 2020-05-22T01:06:19  *** proofofkeags has quit IRC
 14 2020-05-22T01:23:54  *** RamdonEstimate has joined #bitcoin-core-dev
 15 2020-05-22T01:40:13  *** proofofkeags has joined #bitcoin-core-dev
 16 2020-05-22T01:44:32  *** proofofkeags has quit IRC
 17 2020-05-22T01:49:11  *** bitcoin-git has joined #bitcoin-core-dev
 18 2020-05-22T01:49:13  <bitcoin-git> [bitcoin] meshcollider pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/ad3a61c5f5c9...ccd85b57af60
 19 2020-05-22T01:49:13  <bitcoin-git> bitcoin/master b59b450 Andrew Chow: have GenerateNewKey and DeriveNewChildKey take a CHDChain as an argument
 20 2020-05-22T01:49:13  <bitcoin-git> bitcoin/master 45f2f6a Andrew Chow: Determine inactive HD seeds from key metadata and track them in LegacyScri...
 21 2020-05-22T01:49:14  <bitcoin-git> bitcoin/master c93082e Andrew Chow: Generate new keys for inactive seeds after marking used
 22 2020-05-22T01:49:15  *** bitcoin-git has left #bitcoin-core-dev
 23 2020-05-22T01:50:06  *** bitcoin-git has joined #bitcoin-core-dev
 24 2020-05-22T01:50:07  <bitcoin-git> [bitcoin] meshcollider merged pull request #17681: wallet: Keep inactive seeds after sethdseed and derive keys from them as needed (master...keep-inactive-seeds) https://github.com/bitcoin/bitcoin/pull/17681
 25 2020-05-22T01:50:07  *** bitcoin-git has left #bitcoin-core-dev
 26 2020-05-22T02:09:40  *** ransua has quit IRC
 27 2020-05-22T02:22:46  *** bitcoin-git has joined #bitcoin-core-dev
 28 2020-05-22T02:22:47  <bitcoin-git> [bitcoin] meshcollider pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/ccd85b57af60...df303ceb6505
 29 2020-05-22T02:22:47  <bitcoin-git> bitcoin/master 610030d Andrew Chow: docs: Add release notes for descriptor wallets
 30 2020-05-22T02:22:48  <bitcoin-git> bitcoin/master b9073c8 Andrew Chow: rpc: createwallet warning that descriptor wallets are experimental
 31 2020-05-22T02:22:48  <bitcoin-git> bitcoin/master 89b1ce1 Andrew Chow: Remove unimplemented SetCrypted from DescriptorScriptPubKeyMan
 32 2020-05-22T02:22:49  *** bitcoin-git has left #bitcoin-core-dev
 33 2020-05-22T02:23:06  *** bitcoin-git has joined #bitcoin-core-dev
 34 2020-05-22T02:23:07  <bitcoin-git> [bitcoin] meshcollider merged pull request #18787: wallet: descriptor wallet release notes and cleanups (master...desc-wallet-followup) https://github.com/bitcoin/bitcoin/pull/18787
 35 2020-05-22T02:23:07  *** bitcoin-git has left #bitcoin-core-dev
 36 2020-05-22T02:45:30  *** RamdonEstimate has quit IRC
 37 2020-05-22T03:00:02  *** vladan1 has quit IRC
 38 2020-05-22T03:01:03  *** surja795 has quit IRC
 39 2020-05-22T03:02:25  *** asoltys has joined #bitcoin-core-dev
 40 2020-05-22T03:05:55  *** surja795 has joined #bitcoin-core-dev
 41 2020-05-22T03:10:46  *** surja795 has quit IRC
 42 2020-05-22T03:17:12  *** proofofkeags has joined #bitcoin-core-dev
 43 2020-05-22T03:21:38  *** |Kin| has joined #bitcoin-core-dev
 44 2020-05-22T03:22:12  *** proofofkeags has quit IRC
 45 2020-05-22T03:34:08  *** bitcoin-git has joined #bitcoin-core-dev
 46 2020-05-22T03:34:08  <bitcoin-git> [bitcoin] achow101 opened pull request #19046: Replace CWallet::Set* functions that use memonly with Add/Load variants (master...rm-load-memonly) https://github.com/bitcoin/bitcoin/pull/19046
 47 2020-05-22T03:34:09  *** bitcoin-git has left #bitcoin-core-dev
 48 2020-05-22T03:50:01  *** troygiorshev has quit IRC
 49 2020-05-22T04:03:13  *** Highway61 has quit IRC
 50 2020-05-22T04:15:08  *** AaronvanW has joined #bitcoin-core-dev
 51 2020-05-22T04:20:11  *** vasild_ has joined #bitcoin-core-dev
 52 2020-05-22T04:20:12  *** AaronvanW has quit IRC
 53 2020-05-22T04:24:03  *** vasild has quit IRC
 54 2020-05-22T04:24:04  *** vasild_ is now known as vasild
 55 2020-05-22T04:30:44  *** mol_ has joined #bitcoin-core-dev
 56 2020-05-22T04:33:48  *** molz_ has quit IRC
 57 2020-05-22T04:53:03  *** proofofkeags has joined #bitcoin-core-dev
 58 2020-05-22T04:58:05  *** proofofkeags has quit IRC
 59 2020-05-22T05:00:16  *** dfmb_ has quit IRC
 60 2020-05-22T05:00:49  *** Talkless has joined #bitcoin-core-dev
 61 2020-05-22T05:06:29  *** soju has joined #bitcoin-core-dev
 62 2020-05-22T05:07:26  *** sipsorcery has quit IRC
 63 2020-05-22T05:31:33  *** Relis has quit IRC
 64 2020-05-22T05:48:21  *** Relis has joined #bitcoin-core-dev
 65 2020-05-22T05:50:05  *** PaulTroon has joined #bitcoin-core-dev
 66 2020-05-22T05:51:09  *** Relis has quit IRC
 67 2020-05-22T05:54:50  *** PaulTroon has quit IRC
 68 2020-05-22T05:57:14  *** Relis has joined #bitcoin-core-dev
 69 2020-05-22T06:00:02  *** |Kin| has quit IRC
 70 2020-05-22T06:03:15  *** sipsorcery has joined #bitcoin-core-dev
 71 2020-05-22T06:16:39  *** net| has joined #bitcoin-core-dev
 72 2020-05-22T06:18:09  <net|> https://github.com/tecan/EcoCoin/tree/master/qtCoin  new screenshots  i made a new theme editor you guys might like https://github.com/tecan/QT-ThemeEditor
 73 2020-05-22T06:18:44  <net|> also this https://github.com/tecan/qtBarcode has a nice detector for qrcodes
 74 2020-05-22T06:22:13  *** sunweaver1 has joined #bitcoin-core-dev
 75 2020-05-22T06:23:06  *** jb55 has quit IRC
 76 2020-05-22T06:23:38  *** jb55 has joined #bitcoin-core-dev
 77 2020-05-22T06:24:50  *** dfmb_ has joined #bitcoin-core-dev
 78 2020-05-22T06:37:20  *** sipsorcery has quit IRC
 79 2020-05-22T06:40:40  *** Randolf has joined #bitcoin-core-dev
 80 2020-05-22T06:46:49  *** PaulTroon has joined #bitcoin-core-dev
 81 2020-05-22T06:50:57  *** marcoagner has joined #bitcoin-core-dev
 82 2020-05-22T07:02:18  *** Relis has quit IRC
 83 2020-05-22T07:18:15  *** reardencode has joined #bitcoin-core-dev
 84 2020-05-22T07:20:12  *** sipsorcery has joined #bitcoin-core-dev
 85 2020-05-22T07:29:20  *** proofofkeags has joined #bitcoin-core-dev
 86 2020-05-22T07:30:40  *** AaronvanW has joined #bitcoin-core-dev
 87 2020-05-22T07:33:29  *** proofofkeags has quit IRC
 88 2020-05-22T07:35:39  *** jb55 has quit IRC
 89 2020-05-22T07:35:40  *** vasild has quit IRC
 90 2020-05-22T07:35:40  *** sipa has quit IRC
 91 2020-05-22T07:35:40  *** afk11` has quit IRC
 92 2020-05-22T07:35:40  *** ghost43 has quit IRC
 93 2020-05-22T07:35:40  *** SiAnDoG has quit IRC
 94 2020-05-22T07:35:40  *** sdaftuar has quit IRC
 95 2020-05-22T07:35:40  *** kristapsk has quit IRC
 96 2020-05-22T07:35:40  *** mrostecki has quit IRC
 97 2020-05-22T07:35:40  *** Dean_Guss has quit IRC
 98 2020-05-22T07:35:40  *** bitdex has quit IRC
 99 2020-05-22T07:36:20  *** jb55 has joined #bitcoin-core-dev
100 2020-05-22T07:37:27  *** dongcarl has quit IRC
101 2020-05-22T07:38:33  *** Pavlenex has joined #bitcoin-core-dev
102 2020-05-22T07:40:51  *** mrostecki has joined #bitcoin-core-dev
103 2020-05-22T07:41:09  *** afk11` has joined #bitcoin-core-dev
104 2020-05-22T07:45:51  *** vasild has joined #bitcoin-core-dev
105 2020-05-22T07:50:10  *** bitcoin-git has joined #bitcoin-core-dev
106 2020-05-22T07:50:10  <bitcoin-git> [bitcoin] rajarshimaitra opened pull request #19048: test: changing signature of wait_until(). (master...fixing-waituntil) https://github.com/bitcoin/bitcoin/pull/19048
107 2020-05-22T07:50:21  *** bitcoin-git has left #bitcoin-core-dev
108 2020-05-22T07:52:43  *** ghost43 has joined #bitcoin-core-dev
109 2020-05-22T07:56:48  *** bitdex has joined #bitcoin-core-dev
110 2020-05-22T08:06:07  *** sipa has joined #bitcoin-core-dev
111 2020-05-22T08:08:05  *** SiAnDoG has joined #bitcoin-core-dev
112 2020-05-22T08:10:55  *** sdaftuar has joined #bitcoin-core-dev
113 2020-05-22T08:13:07  *** promag has joined #bitcoin-core-dev
114 2020-05-22T08:15:01  *** EagleTM has joined #bitcoin-core-dev
115 2020-05-22T08:20:28  *** afk11` has quit IRC
116 2020-05-22T08:20:53  *** afk11` has joined #bitcoin-core-dev
117 2020-05-22T08:21:01  *** SiAnDoG has quit IRC
118 2020-05-22T08:21:26  *** SiAnDoG has joined #bitcoin-core-dev
119 2020-05-22T08:24:08  *** kristapsk has joined #bitcoin-core-dev
120 2020-05-22T08:30:24  *** Talkless has quit IRC
121 2020-05-22T08:34:15  *** timothy has joined #bitcoin-core-dev
122 2020-05-22T08:34:18  *** AaronvanW has quit IRC
123 2020-05-22T08:52:57  <fanquake> "what we're not going to do: include it all into the repository, or dynamic library based plugin mechanisms" <-- Also agree
124 2020-05-22T08:53:07  *** AaronvanW has joined #bitcoin-core-dev
125 2020-05-22T08:59:14  *** emilengler has joined #bitcoin-core-dev
126 2020-05-22T09:00:02  *** sunweaver1 has quit IRC
127 2020-05-22T09:07:09  *** sipsorcery has quit IRC
128 2020-05-22T09:07:33  *** sipsorcery has joined #bitcoin-core-dev
129 2020-05-22T09:11:50  *** EagleTM has quit IRC
130 2020-05-22T09:21:06  *** Pavlenex has quit IRC
131 2020-05-22T09:21:50  *** ggainey1 has joined #bitcoin-core-dev
132 2020-05-22T09:26:18  *** dfmb_ has quit IRC
133 2020-05-22T09:30:17  *** proofofkeags has joined #bitcoin-core-dev
134 2020-05-22T09:34:19  *** EagleTM has joined #bitcoin-core-dev
135 2020-05-22T09:34:59  *** proofofkeags has quit IRC
136 2020-05-22T09:49:55  *** promag has quit IRC
137 2020-05-22T10:01:42  *** surja795 has joined #bitcoin-core-dev
138 2020-05-22T10:02:22  *** EagleTM has quit IRC
139 2020-05-22T10:03:22  *** Abbigail14Bartol has joined #bitcoin-core-dev
140 2020-05-22T10:05:53  *** dfmb_ has joined #bitcoin-core-dev
141 2020-05-22T10:10:46  *** Abbigail14Bartol has quit IRC
142 2020-05-22T10:12:09  *** promag has joined #bitcoin-core-dev
143 2020-05-22T10:30:18  *** surja795 has quit IRC
144 2020-05-22T10:31:30  *** surja795 has joined #bitcoin-core-dev
145 2020-05-22T10:31:31  *** dfhfhfh has joined #bitcoin-core-dev
146 2020-05-22T10:32:23  *** bitcoin-git has joined #bitcoin-core-dev
147 2020-05-22T10:32:23  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/df303ceb6505...b5c423c48e09
148 2020-05-22T10:32:24  <bitcoin-git> bitcoin/master faf1c3c MarcoFalke: test: Replace TEST_PREVIOUS_RELEASES env var with test_framework option
149 2020-05-22T10:32:24  <bitcoin-git> bitcoin/master fad798b MarcoFalke: test: Default --previous-releases to false if dir is empty
150 2020-05-22T10:32:25  <bitcoin-git> bitcoin/master b5c423c MarcoFalke: Merge #19014: test: Replace TEST_PREVIOUS_RELEASES env var with test_frame...
151 2020-05-22T10:32:26  *** bitcoin-git has left #bitcoin-core-dev
152 2020-05-22T10:32:43  *** bitcoin-git has joined #bitcoin-core-dev
153 2020-05-22T10:32:43  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19014: test: Replace TEST_PREVIOUS_RELEASES env var with test_framework option (master...2005-testPrevReleases) https://github.com/bitcoin/bitcoin/pull/19014
154 2020-05-22T10:32:44  *** bitcoin-git has left #bitcoin-core-dev
155 2020-05-22T10:36:54  *** surja795 has quit IRC
156 2020-05-22T10:44:01  *** promag has quit IRC
157 2020-05-22T10:55:16  *** theStack has joined #bitcoin-core-dev
158 2020-05-22T10:59:20  *** dfhfhfh has quit IRC
159 2020-05-22T11:04:02  <theStack> does anyone know why we tend to store hashes/tx-ids as integers within the functional test framework, rather thany bytes(trings)? i wouldn't know that an integer operation on a hash ever makes sense, and the reoccuring conversions via int(..., 16) are also annoying
160 2020-05-22T11:05:14  *** mol_ has quit IRC
161 2020-05-22T11:28:41  *** surja795 has joined #bitcoin-core-dev
162 2020-05-22T11:33:08  *** surja795 has quit IRC
163 2020-05-22T12:00:01  *** ggainey1 has quit IRC
164 2020-05-22T12:06:55  *** surja795 has joined #bitcoin-core-dev
165 2020-05-22T12:06:58  *** filchef has joined #bitcoin-core-dev
166 2020-05-22T12:08:00  *** filchef has quit IRC
167 2020-05-22T12:11:41  *** surja795 has quit IRC
168 2020-05-22T12:21:00  *** kensanata has joined #bitcoin-core-dev
169 2020-05-22T12:33:50  *** mol has joined #bitcoin-core-dev
170 2020-05-22T12:39:51  *** troygiorshev has joined #bitcoin-core-dev
171 2020-05-22T12:43:00  *** troygiorshev has quit IRC
172 2020-05-22T12:43:16  *** troygiorshev has joined #bitcoin-core-dev
173 2020-05-22T12:44:41  *** promag has joined #bitcoin-core-dev
174 2020-05-22T12:49:20  *** promag has quit IRC
175 2020-05-22T12:58:44  *** promag has joined #bitcoin-core-dev
176 2020-05-22T12:59:39  *** Dean_Guss has joined #bitcoin-core-dev
177 2020-05-22T13:05:15  *** justanotheruser has quit IRC
178 2020-05-22T13:14:50  *** troygiorshev has quit IRC
179 2020-05-22T13:16:04  *** troygiorshev has joined #bitcoin-core-dev
180 2020-05-22T13:20:25  *** PaulTroon has quit IRC
181 2020-05-22T13:21:07  *** PaulTroon has joined #bitcoin-core-dev
182 2020-05-22T13:22:50  *** proofofkeags has joined #bitcoin-core-dev
183 2020-05-22T13:28:19  *** proofofkeags has quit IRC
184 2020-05-22T13:29:53  *** net| has left #bitcoin-core-dev
185 2020-05-22T13:33:57  *** gribble has quit IRC
186 2020-05-22T13:34:17  *** andytoshi has quit IRC
187 2020-05-22T13:34:48  *** gribble has joined #bitcoin-core-dev
188 2020-05-22T13:34:55  *** midnight has quit IRC
189 2020-05-22T13:35:10  *** andytoshi has joined #bitcoin-core-dev
190 2020-05-22T13:35:10  *** andytoshi has quit IRC
191 2020-05-22T13:35:10  *** andytoshi has joined #bitcoin-core-dev
192 2020-05-22T13:35:50  *** EagleTM has joined #bitcoin-core-dev
193 2020-05-22T13:41:02  *** kljasdfvv has quit IRC
194 2020-05-22T13:45:04  *** mdunnio has joined #bitcoin-core-dev
195 2020-05-22T13:46:53  *** Eagle[TM] has joined #bitcoin-core-dev
196 2020-05-22T13:47:26  *** EagleTM has quit IRC
197 2020-05-22T13:50:42  *** d_t has joined #bitcoin-core-dev
198 2020-05-22T13:54:07  *** midnight has joined #bitcoin-core-dev
199 2020-05-22T13:55:23  *** d_t has quit IRC
200 2020-05-22T13:55:49  *** ctrlbreak_MAD has quit IRC
201 2020-05-22T13:56:17  *** ctrlbreak_MAD has joined #bitcoin-core-dev
202 2020-05-22T14:03:58  *** Highway61 has joined #bitcoin-core-dev
203 2020-05-22T14:13:17  *** Randolf has quit IRC
204 2020-05-22T14:17:31  *** EagleTM has joined #bitcoin-core-dev
205 2020-05-22T14:17:42  *** Eagle[TM] has quit IRC
206 2020-05-22T14:19:48  *** bitcoin-git has joined #bitcoin-core-dev
207 2020-05-22T14:19:49  <bitcoin-git> [bitcoin] fjahr opened pull request #19050: doc: Add warning for rest interface limitation (master...rest_fd) https://github.com/bitcoin/bitcoin/pull/19050
208 2020-05-22T14:19:50  *** bitcoin-git has left #bitcoin-core-dev
209 2020-05-22T14:20:00  *** Eagle[TM] has joined #bitcoin-core-dev
210 2020-05-22T14:22:27  *** EagleTM has quit IRC
211 2020-05-22T14:24:23  *** sdaftuar has quit IRC
212 2020-05-22T14:25:20  *** Relis has joined #bitcoin-core-dev
213 2020-05-22T14:29:17  *** sdaftuar has joined #bitcoin-core-dev
214 2020-05-22T14:39:17  *** Talkless has joined #bitcoin-core-dev
215 2020-05-22T14:41:54  *** mol has quit IRC
216 2020-05-22T14:45:01  *** Guyver2 has joined #bitcoin-core-dev
217 2020-05-22T14:54:30  *** Eagle[TM] has quit IRC
218 2020-05-22T14:55:36  *** PaulTroon has quit IRC
219 2020-05-22T15:00:01  *** kensanata has quit IRC
220 2020-05-22T15:09:47  *** promag has quit IRC
221 2020-05-22T15:10:30  *** promag has joined #bitcoin-core-dev
222 2020-05-22T15:12:38  *** jonatack has quit IRC
223 2020-05-22T15:14:47  *** promag has quit IRC
224 2020-05-22T15:17:57  *** EagleTM has joined #bitcoin-core-dev
225 2020-05-22T15:21:40  *** Nipo1 has joined #bitcoin-core-dev
226 2020-05-22T15:24:32  *** bitcoin-git has joined #bitcoin-core-dev
227 2020-05-22T15:24:32  <bitcoin-git> [bitcoin] practicalswift opened pull request #19052: tests: Don't limit fuzzing inputs to 1 MB for afl-fuzz (now: ∞ ∀ fuzzers) (master...remove-afl-limit) https://github.com/bitcoin/bitcoin/pull/19052
228 2020-05-22T15:24:33  *** bitcoin-git has left #bitcoin-core-dev
229 2020-05-22T15:24:50  *** EagleTM has quit IRC
230 2020-05-22T15:25:29  *** cryptoIndio has joined #bitcoin-core-dev
231 2020-05-22T15:31:03  *** cryptoIndio has quit IRC
232 2020-05-22T15:35:37  *** Talkless has quit IRC
233 2020-05-22T15:44:40  *** ctrlbreak_MAD has quit IRC
234 2020-05-22T15:45:06  *** PaulTroon has joined #bitcoin-core-dev
235 2020-05-22T15:45:08  *** ctrlbreak_MAD has joined #bitcoin-core-dev
236 2020-05-22T15:46:41  *** promag has joined #bitcoin-core-dev
237 2020-05-22T15:50:54  *** promag has quit IRC
238 2020-05-22T15:54:07  *** mol has joined #bitcoin-core-dev
239 2020-05-22T15:55:54  *** Highway61 has quit IRC
240 2020-05-22T15:58:08  *** justanotheruser has joined #bitcoin-core-dev
241 2020-05-22T15:58:57  *** IGHOR has quit IRC
242 2020-05-22T16:01:45  *** QuantumLogic has joined #bitcoin-core-dev
243 2020-05-22T16:02:23  *** ctrlbreak_MAD has quit IRC
244 2020-05-22T16:02:51  *** ctrlbreak_MAD has joined #bitcoin-core-dev
245 2020-05-22T16:06:43  *** Highway61 has joined #bitcoin-core-dev
246 2020-05-22T16:13:20  *** kristapsk_ has joined #bitcoin-core-dev
247 2020-05-22T16:14:16  *** kristapsk has quit IRC
248 2020-05-22T16:17:32  *** bitcoin-git has joined #bitcoin-core-dev
249 2020-05-22T16:17:32  <bitcoin-git> [bitcoin] theStack opened pull request #19053: refactor: replace CNode pointers by references within net_processing.{h,cpp} (master...20200522-refactor-use-cnode-references-within-net_processing) https://github.com/bitcoin/bitcoin/pull/19053
250 2020-05-22T16:17:32  *** bitcoin-git has left #bitcoin-core-dev
251 2020-05-22T16:23:23  *** vasild has quit IRC
252 2020-05-22T16:25:10  *** vasild has joined #bitcoin-core-dev
253 2020-05-22T16:28:11  *** Chris_Stewart_5 has quit IRC
254 2020-05-22T16:28:52  *** jonatack has joined #bitcoin-core-dev
255 2020-05-22T16:50:44  *** Pavlenex has joined #bitcoin-core-dev
256 2020-05-22T16:51:27  *** ctrlbreak_MAD has quit IRC
257 2020-05-22T16:51:51  *** ctrlbreak_MAD has joined #bitcoin-core-dev
258 2020-05-22T17:00:17  *** Dean_Guss has quit IRC
259 2020-05-22T17:04:39  *** PaulTroon has quit IRC
260 2020-05-22T17:15:29  *** timothy has quit IRC
261 2020-05-22T17:17:46  *** Dean_Guss has joined #bitcoin-core-dev
262 2020-05-22T17:18:55  *** proofofkeags has joined #bitcoin-core-dev
263 2020-05-22T17:19:23  *** jarthur has joined #bitcoin-core-dev
264 2020-05-22T17:21:48  *** PaulTroon has joined #bitcoin-core-dev
265 2020-05-22T17:24:06  *** Pavlenex has joined #bitcoin-core-dev
266 2020-05-22T17:25:27  *** LucasNickle_ has joined #bitcoin-core-dev
267 2020-05-22T17:26:11  *** LucasNickle has quit IRC
268 2020-05-22T17:26:43  *** afk11` has quit IRC
269 2020-05-22T17:28:54  *** afk11` has joined #bitcoin-core-dev
270 2020-05-22T17:42:45  *** tryphe_ has joined #bitcoin-core-dev
271 2020-05-22T17:43:27  *** tryphe has quit IRC
272 2020-05-22T17:44:05  *** bitcoin-git has joined #bitcoin-core-dev
273 2020-05-22T17:44:05  <bitcoin-git> [bitcoin] achow101 opened pull request #19054: wallet: Skip hdKeypath of 'm' when determining inactive hd seeds (master...inactive-seed-skip-m) https://github.com/bitcoin/bitcoin/pull/19054
274 2020-05-22T17:44:06  *** bitcoin-git has left #bitcoin-core-dev
275 2020-05-22T17:44:16  *** QuantumLogic has quit IRC
276 2020-05-22T17:44:49  *** owowo has quit IRC
277 2020-05-22T17:49:16  *** owowo has joined #bitcoin-core-dev
278 2020-05-22T18:00:01  *** Nipo1 has quit IRC
279 2020-05-22T18:00:14  *** dongcarl has joined #bitcoin-core-dev
280 2020-05-22T18:07:23  *** afk11` has quit IRC
281 2020-05-22T18:08:08  *** afk11` has joined #bitcoin-core-dev
282 2020-05-22T18:16:56  *** Highway62 has joined #bitcoin-core-dev
283 2020-05-22T18:18:00  *** Highway61 has quit IRC
284 2020-05-22T18:18:00  *** Highway62 is now known as Highway61
285 2020-05-22T18:21:18  *** tryphe__ has joined #bitcoin-core-dev
286 2020-05-22T18:21:32  *** tryphe_ has quit IRC
287 2020-05-22T18:22:20  *** IAm_thor3 has joined #bitcoin-core-dev
288 2020-05-22T18:22:38  *** tryphe_ has joined #bitcoin-core-dev
289 2020-05-22T18:24:41  *** Highway61 has quit IRC
290 2020-05-22T18:26:02  *** tryphe__ has quit IRC
291 2020-05-22T18:29:09  *** Highway61 has joined #bitcoin-core-dev
292 2020-05-22T18:33:20  *** LucasNickle has joined #bitcoin-core-dev
293 2020-05-22T18:34:15  *** LucasNickle_ has quit IRC
294 2020-05-22T18:34:54  *** Pavlenex has quit IRC
295 2020-05-22T18:41:28  *** theStack has quit IRC
296 2020-05-22T18:52:06  *** Highway61 has quit IRC
297 2020-05-22T18:52:26  *** Highway61 has joined #bitcoin-core-dev
298 2020-05-22T18:58:59  *** IGHOR has joined #bitcoin-core-dev
299 2020-05-22T19:00:16  <meshcollider> #startmeeting
300 2020-05-22T19:00:16  <lightningbot> Meeting started Fri May 22 19:00:16 2020 UTC.  The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot.
301 2020-05-22T19:00:16  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
302 2020-05-22T19:00:24  <meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball ariard digi_james amiti fjahr
303 2020-05-22T19:00:24  <meshcollider> jeremyrubin emilengler jonatack hebasto jb55
304 2020-05-22T19:00:28  <achow101> hi
305 2020-05-22T19:00:45  <meshcollider> Topics? High priority changes since yesterday?
306 2020-05-22T19:01:06  <jonatack> hi
307 2020-05-22T19:01:17  <jnewbery> hi
308 2020-05-22T19:01:25  <sipa>     hi
309 2020-05-22T19:01:50  <instagibbs> hi
310 2020-05-22T19:01:51  <achow101> #18787 was merged yesterday, so replace that with #18918 on hi prio pls
311 2020-05-22T19:01:53  <gribble> https://github.com/bitcoin/bitcoin/issues/18787 | wallet: descriptor wallet release notes and cleanups by achow101 · Pull Request #18787 · bitcoin/bitcoin · GitHub
312 2020-05-22T19:01:56  <gribble> https://github.com/bitcoin/bitcoin/issues/18918 | wallet: Move salvagewallet into wallettool by achow101 · Pull Request #18918 · bitcoin/bitcoin · GitHub
313 2020-05-22T19:02:08  <instagibbs> mmm savagewallet
314 2020-05-22T19:02:52  <jnewbery> thank you for justifying your entrance sipa
315 2020-05-22T19:04:15  <meshcollider> achow101: done
316 2020-05-22T19:04:52  <jonatack> meshcollider: #18594 should be RFM (or close), acks by jnewbery and promag (and several earlier ones) and review from luke-jr
317 2020-05-22T19:04:54  <gribble> https://github.com/bitcoin/bitcoin/issues/18594 | cli: display multiwallet balances in -getinfo by jonatack · Pull Request #18594 · bitcoin/bitcoin · GitHub
318 2020-05-22T19:04:58  <instagibbs> gwillen, I offered to taking on the offline signing PR if you don't have the time to champion it
319 2020-05-22T19:05:10  <fjahr> hi
320 2020-05-22T19:05:20  <jonatack> unsure if it's wallet territory
321 2020-05-22T19:05:43  <meshcollider> jonatack: sounds good, I'll have a look after the meeting
322 2020-05-22T19:07:17  <meshcollider> No topics?
323 2020-05-22T19:07:30  *** emilengler has quit IRC
324 2020-05-22T19:07:54  *** Highway61 has quit IRC
325 2020-05-22T19:08:02  <meshcollider> Short meeting then!
326 2020-05-22T19:08:16  <achow101> very short
327 2020-05-22T19:08:17  *** tryphe has joined #bitcoin-core-dev
328 2020-05-22T19:08:18  <jnewbery> short meetings are good meetings
329 2020-05-22T19:08:24  <instagibbs> provoostenator_, any motion on hww signer stuff? what's next? Still debating boost?
330 2020-05-22T19:09:57  <jonatack> fwiw i've been looking at some BDB issues with undesired writes on what should be read-only operations
331 2020-05-22T19:10:14  *** tryphe_ has quit IRC
332 2020-05-22T19:10:22  *** mdunnio has quit IRC
333 2020-05-22T19:10:30  <jonatack> and breaking when wallet file permissions are set to read-only
334 2020-05-22T19:10:38  <jonatack> not sure yet if it's a fool's errand
335 2020-05-22T19:10:47  *** tryphe has quit IRC
336 2020-05-22T19:10:56  *** tryphe_ has joined #bitcoin-core-dev
337 2020-05-22T19:10:58  *** mdunnio has joined #bitcoin-core-dev
338 2020-05-22T19:11:22  <meshcollider> Sounds interesting at least
339 2020-05-22T19:11:25  <jonatack> e.g. fixing the TODOs in toolwallet.py... might reach out to people for help
340 2020-05-22T19:11:42  <meshcollider> achow101 might be interested because he's reworking the bdb code atm
341 2020-05-22T19:12:13  *** tryphe__ has joined #bitcoin-core-dev
342 2020-05-22T19:12:32  *** tryphe_ has quit IRC
343 2020-05-22T19:12:54  <jonatack> his refactoring looks like it might make things easier. the minimum start to a solution involves setting different nflag values in BDB batch
344 2020-05-22T19:13:06  <jonatack> but there are other issues
345 2020-05-22T19:13:31  <achow101> I can certainly help with that
346 2020-05-22T19:13:47  <achow101> although it feels a little weird to work on legacy wallets and bdb after we've basically decided to deprecate them
347 2020-05-22T19:14:17  <instagibbs> legacy wallets aren't close ot deprecated yet :)
348 2020-05-22T19:14:19  <meshcollider> We are still going to have them for a while :p
349 2020-05-22T19:14:28  <instagibbs> i read your release notes!
350 2020-05-22T19:14:30  <achow101> unfortunately
351 2020-05-22T19:15:42  <jonatack> achow101: ty, will ping on irc if/when blocked :)
352 2020-05-22T19:15:58  <meshcollider> Alright let's wrap it up for today :)
353 2020-05-22T19:16:02  <meshcollider> #endmeeting
354 2020-05-22T19:16:02  <lightningbot> Meeting ended Fri May 22 19:16:02 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
355 2020-05-22T19:16:02  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-05-22-19.00.html
356 2020-05-22T19:16:02  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-05-22-19.00.txt
357 2020-05-22T19:16:02  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-05-22-19.00.log.html
358 2020-05-22T19:16:24  <phantomcircuit> i've been looking at using the GCS filter indexes to improve rescan performance; i've gotten to the point of wanting to generate all the possible scriptPubKey's to make the search possible; sipa suggested i ask achow101 if putting them in mapScripts made sense
359 2020-05-22T19:16:45  <phantomcircuit> i feel like you probably answered and i lost the scrollback
360 2020-05-22T19:16:55  *** EagleTM has joined #bitcoin-core-dev
361 2020-05-22T19:17:07  <achow101> phantomcircuit: that doesn't make sense as I don't think mapScripts is used to check bare scriptPubKeys
362 2020-05-22T19:17:09  <instagibbs> didnt someone already implement that?
363 2020-05-22T19:18:05  <phantomcircuit> instagibbs, it's currently doing the very old logic of just walking every transaction output in every block and calling IsMine
364 2020-05-22T19:18:26  <sipa> phantomcircuit: i think you can just generate the set of all sPKs to watch for at rescan time?
365 2020-05-22T19:18:30  <instagibbs> likely misremembering, carry on
366 2020-05-22T19:18:33  <sipa> rather than modifying wallet data structures
367 2020-05-22T19:18:40  <achow101> it's also not clear to me if generating all scriptPubKeys is possible
368 2020-05-22T19:18:44  *** promag has joined #bitcoin-core-dev
369 2020-05-22T19:18:44  <sipa> achow101: it is
370 2020-05-22T19:18:57  <phantomcircuit> sipa, the mapScripts is in memory entirely, some of it is from things saved to the wallet but not all
371 2020-05-22T19:19:07  <sipa> phantomcircuit: i'm aware
372 2020-05-22T19:19:08  <achow101> phantomcircuit: mapScripts is only used for p2sh
373 2020-05-22T19:19:32  <sipa> but it still feels scary to modify it in an operation that shouldn't be modifying it
374 2020-05-22T19:19:33  <phantomcircuit> for clarity i wasn't suggesting saving anything to the wallet database
375 2020-05-22T19:20:17  <sipa> phantomcircuit: if you mean permanently, at all times, keep track of all sPKs to watch for... that's hard to make efficient
376 2020-05-22T19:20:17  <jonatack> instagibbs: good question about provoostenator_... i see he updated #15382 today
377 2020-05-22T19:20:20  <gribble> https://github.com/bitcoin/bitcoin/issues/15382 | util: add runCommandParseJSON by Sjors · Pull Request #15382 · bitcoin/bitcoin · GitHub
378 2020-05-22T19:20:20  <achow101> i agree with sipa, you can just generate it at rescan time
379 2020-05-22T19:20:21  <sipa> due to recursion
380 2020-05-22T19:21:14  <sipa> like you add a private key and suddenly a previously-imported P2SH-P2WSH multisig script becomes watched
381 2020-05-22T19:21:21  <achow101> even if generating it each time takes a while, it'll still be faster than what we currently do for rescan
382 2020-05-22T19:21:28  <sipa> it'd be seconds at most
383 2020-05-22T19:21:29  <phantomcircuit> sipa, no i meant only adding them to the map when a rescan was requested, i could also create a new map or list or something that contains them all
384 2020-05-22T19:21:59  <sipa> phantomcircuit: i think that's better (that also lets you optimize the datastructure better... say use an unordered_map or a GCSFilter or whatever)
385 2020-05-22T19:22:02  *** mdunnio has quit IRC
386 2020-05-22T19:22:43  *** mdunnio has joined #bitcoin-core-dev
387 2020-05-22T19:22:49  <phantomcircuit> sipa, there's broadly two options for handling this, use the gcs filter indexes or generate a filter for all of the scriptPubKeys and walk the entire chain as we do now
388 2020-05-22T19:23:15  *** promag has quit IRC
389 2020-05-22T19:23:20  <phantomcircuit> the main issue with walking the chain now is confirming the merkle root is correct everytime we load a block
390 2020-05-22T19:23:54  <achow101> phantomcircuit: do both approaches require enumerating all scriptPubKeys?
391 2020-05-22T19:23:54  <phantomcircuit> (or at least that's what it seems to be im not actually 100% sure, but it's definitely some use of sha256)
392 2020-05-22T19:24:02  <sipa> achow101: yes
393 2020-05-22T19:24:39  <phantomcircuit> achow101, yes they do
394 2020-05-22T19:24:53  <sipa> phantomcircuit: loading blocks is slow; there is SHA256, but also just all the dynamic memory for all the transactions/inputs/outputs/scripts
395 2020-05-22T19:24:58  <phantomcircuit> im really not sure which will be faster, but it *feels* like using the gcs filter index should be
396 2020-05-22T19:26:35  <sipa> would be interesting to find out
397 2020-05-22T19:27:13  *** Sentineo has quit IRC
398 2020-05-22T19:28:28  <instagibbs> jonatack, ah yeah, that PR has boost::process :)
399 2020-05-22T19:34:18  *** Sentineo has joined #bitcoin-core-dev
400 2020-05-22T19:37:20  <phantomcircuit> well either way i need to generate all the scriptPubKeys, once that's done i can try both ways relatively easily
401 2020-05-22T19:37:57  *** bitcoin-git has joined #bitcoin-core-dev
402 2020-05-22T19:37:57  <bitcoin-git> [bitcoin] fjahr opened pull request #19055: Calculate UTXO set hash using Muhash (master...csi-1-muhash) https://github.com/bitcoin/bitcoin/pull/19055
403 2020-05-22T19:37:59  *** bitcoin-git has left #bitcoin-core-dev
404 2020-05-22T19:49:13  *** PaulTroon has quit IRC
405 2020-05-22T19:49:54  *** Emcy has quit IRC
406 2020-05-22T19:50:05  *** bitcoin-git has joined #bitcoin-core-dev
407 2020-05-22T19:50:06  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19056: rpc: Make gettxoutsetinfo/GetUTXOStats interruptible (master...2005-rpcInterrupt) https://github.com/bitcoin/bitcoin/pull/19056
408 2020-05-22T19:50:07  *** bitcoin-git has left #bitcoin-core-dev
409 2020-05-22T19:50:31  *** Emcy has joined #bitcoin-core-dev
410 2020-05-22T19:56:14  *** surja795 has joined #bitcoin-core-dev
411 2020-05-22T20:01:41  *** proofofkeags has quit IRC
412 2020-05-22T20:06:34  *** surja795 has quit IRC
413 2020-05-22T20:06:47  *** surja795 has joined #bitcoin-core-dev
414 2020-05-22T20:27:32  <instagibbs> provoostenator_, fjahr meshcollider I'd like to point people's attention to trying to get #17331(and it's parent PR) merged sometime soon. It's a prereq for some more interesting fee bumping work I'd like to do
415 2020-05-22T20:27:34  <gribble> https://github.com/bitcoin/bitcoin/issues/17331 | Use effective values throughout coin selection by achow101 · Pull Request #17331 · bitcoin/bitcoin · GitHub
416 2020-05-22T20:29:51  *** mdunnio has quit IRC
417 2020-05-22T20:30:10  <fjahr> instagibbs: sure, will take a look soon!
418 2020-05-22T20:31:52  *** kristapsk___ has joined #bitcoin-core-dev
419 2020-05-22T20:36:03  *** kristapsk_ has quit IRC
420 2020-05-22T20:40:33  *** proofofkeags has joined #bitcoin-core-dev
421 2020-05-22T20:48:27  *** kristapsk___ is now known as kristapsk
422 2020-05-22T20:50:46  *** PaulTroon has joined #bitcoin-core-dev
423 2020-05-22T20:59:00  <jonatack> instagibbs: good show, looks like that PR dropped through the cracks. queuing it up for the coming week.
424 2020-05-22T21:00:01  *** IAm_thor3 has quit IRC
425 2020-05-22T21:04:43  *** promag has joined #bitcoin-core-dev
426 2020-05-22T21:06:13  *** achow101 has quit IRC
427 2020-05-22T21:11:30  *** promag has quit IRC
428 2020-05-22T21:15:15  *** jarthur_ has joined #bitcoin-core-dev
429 2020-05-22T21:19:17  *** jarthur has quit IRC
430 2020-05-22T21:19:52  *** jarthur_ has quit IRC
431 2020-05-22T21:21:33  *** DarTar has joined #bitcoin-core-dev
432 2020-05-22T21:26:06  *** Talkless has joined #bitcoin-core-dev
433 2020-05-22T21:32:53  *** bitdex has quit IRC
434 2020-05-22T21:33:21  *** bitdex has joined #bitcoin-core-dev
435 2020-05-22T21:41:49  *** Guyver2 has quit IRC
436 2020-05-22T21:42:57  *** troygiorshev has quit IRC
437 2020-05-22T21:44:20  *** jarthur has joined #bitcoin-core-dev
438 2020-05-22T21:45:47  *** bitcoin-git has joined #bitcoin-core-dev
439 2020-05-22T21:45:47  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b5c423c48e09...fa3288cda125
440 2020-05-22T21:45:47  <bitcoin-git> bitcoin/master 6a239e7 practicalswift: tests: Don't limit fuzzing inputs to 1 MB for afl-fuzz (now: ∞ ∀ fuzzers)
441 2020-05-22T21:45:48  <bitcoin-git> bitcoin/master fa3288c MarcoFalke: Merge #19052: tests: Don't limit fuzzing inputs to 1 MB for afl-fuzz (now:...
442 2020-05-22T21:45:49  *** bitcoin-git has left #bitcoin-core-dev
443 2020-05-22T21:46:07  *** bitcoin-git has joined #bitcoin-core-dev
444 2020-05-22T21:46:07  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19052: tests: Don't limit fuzzing inputs to 1 MB for afl-fuzz (now: ∞ ∀ fuzzers) (master...remove-afl-limit) https://github.com/bitcoin/bitcoin/pull/19052
445 2020-05-22T21:46:07  *** bitcoin-git has left #bitcoin-core-dev
446 2020-05-22T21:47:06  *** jarthur has quit IRC
447 2020-05-22T22:01:44  *** achow101 has joined #bitcoin-core-dev
448 2020-05-22T22:16:06  *** marcoagner has quit IRC
449 2020-05-22T22:23:29  *** CubicEarth has quit IRC
450 2020-05-22T22:24:07  *** ryzeb has quit IRC
451 2020-05-22T22:24:43  *** ryzeb has joined #bitcoin-core-dev
452 2020-05-22T22:29:12  *** CubicEarth has joined #bitcoin-core-dev
453 2020-05-22T22:33:10  *** jarthur has joined #bitcoin-core-dev
454 2020-05-22T22:33:40  *** AaronvanW has quit IRC
455 2020-05-22T22:36:29  *** jarthur has quit IRC
456 2020-05-22T22:37:48  *** ghost43_ has joined #bitcoin-core-dev
457 2020-05-22T22:38:23  *** ghost43 has quit IRC
458 2020-05-22T22:39:45  *** Talkless has quit IRC
459 2020-05-22T22:44:44  *** jarthur has joined #bitcoin-core-dev
460 2020-05-22T22:53:56  *** promag has joined #bitcoin-core-dev
461 2020-05-22T22:59:11  *** PaulTroon has quit IRC
462 2020-05-22T23:05:31  *** ghost43_ has quit IRC
463 2020-05-22T23:05:47  *** ghost43 has joined #bitcoin-core-dev
464 2020-05-22T23:09:17  *** AaronvanW has joined #bitcoin-core-dev
465 2020-05-22T23:14:01  *** AaronvanW has quit IRC
466 2020-05-22T23:19:23  *** Dean_Guss has quit IRC
467 2020-05-22T23:20:53  *** Zenton has quit IRC
468 2020-05-22T23:25:05  *** Zenton has joined #bitcoin-core-dev
469 2020-05-22T23:26:14  *** justanotheruser has quit IRC
470 2020-05-22T23:27:33  *** Zenton has quit IRC
471 2020-05-22T23:28:28  *** Zenton has joined #bitcoin-core-dev
472 2020-05-22T23:35:03  *** Zenton has quit IRC
473 2020-05-22T23:35:44  *** proofofkeags has quit IRC
474 2020-05-22T23:42:46  *** justanotheruser has joined #bitcoin-core-dev
475 2020-05-22T23:45:34  *** EagleTM has quit IRC
476 2020-05-22T23:46:59  *** Zenton has joined #bitcoin-core-dev
477 2020-05-22T23:51:34  *** proofofkeags has joined #bitcoin-core-dev
478 2020-05-22T23:56:02  *** proofofkeags has quit IRC