1 2020-05-29T00:00:01  *** JesusFreke has quit IRC
  2 2020-05-29T00:05:00  *** cltrbreak_MAD2 has quit IRC
  3 2020-05-29T00:05:26  *** cltrbreak_MAD2 has joined #bitcoin-core-dev
  4 2020-05-29T00:09:52  *** promag has quit IRC
  5 2020-05-29T00:11:50  *** ghost43 has quit IRC
  6 2020-05-29T00:12:07  *** ghost43 has joined #bitcoin-core-dev
  7 2020-05-29T00:16:24  *** IGHOR has quit IRC
  8 2020-05-29T00:16:57  *** langseth1 has joined #bitcoin-core-dev
  9 2020-05-29T00:17:39  *** troygiorshev has quit IRC
 10 2020-05-29T00:18:02  *** IGHOR has joined #bitcoin-core-dev
 11 2020-05-29T00:21:42  *** proofofkeags has quit IRC
 12 2020-05-29T00:31:47  *** Relis has quit IRC
 13 2020-05-29T00:32:10  *** Relis has joined #bitcoin-core-dev
 14 2020-05-29T00:37:37  <jamesob> fanquake: roger that, will queue. Expect some bitcoinperf developments soon
 15 2020-05-29T00:42:10  *** AaronvanW has quit IRC
 16 2020-05-29T00:43:34  *** bitcoin-git has joined #bitcoin-core-dev
 17 2020-05-29T00:43:35  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ea3e9e0b84c5...fc1fb4dd7c05
 18 2020-05-29T00:43:35  <bitcoin-git> bitcoin/master 399d84d Wladimir J. van der Laan: build: Only allow ASCII identifiers
 19 2020-05-29T00:43:36  <bitcoin-git> bitcoin/master fc1fb4d fanquake: Merge #19094: build: Only allow ASCII identifiers
 20 2020-05-29T00:43:38  *** bitcoin-git has left #bitcoin-core-dev
 21 2020-05-29T00:43:54  *** bitcoin-git has joined #bitcoin-core-dev
 22 2020-05-29T00:43:54  <bitcoin-git> [bitcoin] fanquake merged pull request #19094: build: Only allow ASCII identifiers (master...2020_05_no_extended_identifiers) https://github.com/bitcoin/bitcoin/pull/19094
 23 2020-05-29T00:43:55  *** bitcoin-git has left #bitcoin-core-dev
 24 2020-05-29T00:51:53  *** jarthur has joined #bitcoin-core-dev
 25 2020-05-29T00:54:14  *** troygiorshev has joined #bitcoin-core-dev
 26 2020-05-29T00:54:47  *** EagleTM has quit IRC
 27 2020-05-29T01:02:49  *** proofofkeags has joined #bitcoin-core-dev
 28 2020-05-29T01:07:38  *** proofofkeags has quit IRC
 29 2020-05-29T01:09:30  *** jarthur has quit IRC
 30 2020-05-29T01:09:53  *** Chris_Stewart_5 has quit IRC
 31 2020-05-29T01:10:14  *** jarthur has joined #bitcoin-core-dev
 32 2020-05-29T01:14:55  *** filchef has joined #bitcoin-core-dev
 33 2020-05-29T01:17:54  *** troygiorshev has quit IRC
 34 2020-05-29T01:19:56  *** troygiorshev has joined #bitcoin-core-dev
 35 2020-05-29T01:27:43  *** troygiorshev has quit IRC
 36 2020-05-29T01:28:03  *** bitcoin-git has joined #bitcoin-core-dev
 37 2020-05-29T01:28:04  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fc1fb4dd7c05...adc143fc2b9a
 38 2020-05-29T01:28:04  <bitcoin-git> bitcoin/master 79b0a69 Andrew Chow: Add missing QPainterPath include
 39 2020-05-29T01:28:05  <bitcoin-git> bitcoin/master adc143f fanquake: Merge #19097: qt: Add missing QPainterPath include
 40 2020-05-29T01:28:07  *** bitcoin-git has left #bitcoin-core-dev
 41 2020-05-29T01:28:23  *** bitcoin-git has joined #bitcoin-core-dev
 42 2020-05-29T01:28:23  <bitcoin-git> [bitcoin] fanquake merged pull request #19097: qt: Add missing QPainterPath include (master...qpainterpath-include) https://github.com/bitcoin/bitcoin/pull/19097
 43 2020-05-29T01:28:24  *** bitcoin-git has left #bitcoin-core-dev
 44 2020-05-29T01:29:05  <fanquake> jamesob: sounds good
 45 2020-05-29T01:29:52  *** troygiorshev has joined #bitcoin-core-dev
 46 2020-05-29T01:38:03  *** troygiorshev has quit IRC
 47 2020-05-29T01:46:22  *** jarthur has quit IRC
 48 2020-05-29T01:48:01  *** proofofkeags has joined #bitcoin-core-dev
 49 2020-05-29T01:48:34  *** jarthur has joined #bitcoin-core-dev
 50 2020-05-29T01:53:57  *** troygiorshev has joined #bitcoin-core-dev
 51 2020-05-29T02:42:15  *** surja795 has quit IRC
 52 2020-05-29T02:49:57  *** surja795 has joined #bitcoin-core-dev
 53 2020-05-29T02:57:40  *** surja795 has quit IRC
 54 2020-05-29T02:58:56  *** surja795 has joined #bitcoin-core-dev
 55 2020-05-29T03:00:02  *** langseth1 has quit IRC
 56 2020-05-29T03:02:23  *** kristapsk has quit IRC
 57 2020-05-29T03:02:31  *** kristapsk_ has joined #bitcoin-core-dev
 58 2020-05-29T03:10:50  <luke-jr> I wonder if #19097 warrants a rc3 :x
 59 2020-05-29T03:10:52  <gribble> https://github.com/bitcoin/bitcoin/issues/19097 | qt: Add missing QPainterPath include by achow101 · Pull Request #19097 · bitcoin/bitcoin · GitHub
 60 2020-05-29T03:11:46  <luke-jr> certainly could use a backport at least
 61 2020-05-29T03:12:15  <fanquake> Given that 5.15 only came out 3  days ago, I don't think there's any need to delay 0.20.0
 62 2020-05-29T03:12:19  <fanquake> Can backport into 0.20.1
 63 2020-05-29T03:13:26  <luke-jr> lots of other sw needs fixing too, so at least we're not that unusual in this
 64 2020-05-29T03:13:44  <luke-jr> (been idly noticing it dealt with as Gentoo rolls it out)
 65 2020-05-29T03:21:43  *** hoobop1 has joined #bitcoin-core-dev
 66 2020-05-29T03:31:07  *** surja795 has quit IRC
 67 2020-05-29T03:36:12  *** surja795 has joined #bitcoin-core-dev
 68 2020-05-29T03:41:01  *** surja795 has quit IRC
 69 2020-05-29T03:51:53  *** proofofkeags has quit IRC
 70 2020-05-29T03:52:26  *** proofofkeags has joined #bitcoin-core-dev
 71 2020-05-29T03:55:56  *** Lessie75Barton has joined #bitcoin-core-dev
 72 2020-05-29T03:56:34  *** proofofkeags has quit IRC
 73 2020-05-29T04:01:01  *** Relis has quit IRC
 74 2020-05-29T04:02:52  *** vasild has quit IRC
 75 2020-05-29T04:03:05  *** vasild has joined #bitcoin-core-dev
 76 2020-05-29T04:23:23  *** vasild has quit IRC
 77 2020-05-29T04:29:58  *** Lessie75Barton has quit IRC
 78 2020-05-29T04:30:12  *** vasild has joined #bitcoin-core-dev
 79 2020-05-29T04:34:03  *** joerodgers has quit IRC
 80 2020-05-29T04:43:32  *** luke-jr has quit IRC
 81 2020-05-29T04:44:00  *** luke-jr has joined #bitcoin-core-dev
 82 2020-05-29T04:48:13  *** mrostecki has quit IRC
 83 2020-05-29T04:48:30  *** mrostecki has joined #bitcoin-core-dev
 84 2020-05-29T04:54:40  *** mazout has joined #bitcoin-core-dev
 85 2020-05-29T04:55:32  *** mazout has left #bitcoin-core-dev
 86 2020-05-29T05:26:54  *** ineedhelp has joined #bitcoin-core-dev
 87 2020-05-29T05:34:12  *** marcoagner has joined #bitcoin-core-dev
 88 2020-05-29T05:59:20  *** Highway61 has joined #bitcoin-core-dev
 89 2020-05-29T06:00:02  *** hoobop1 has quit IRC
 90 2020-05-29T06:09:28  *** jarthur has quit IRC
 91 2020-05-29T06:10:01  *** jarthur has joined #bitcoin-core-dev
 92 2020-05-29T06:17:10  *** ineedhelp has quit IRC
 93 2020-05-29T06:22:20  *** Antonet has joined #bitcoin-core-dev
 94 2020-05-29T06:26:18  *** troygiorshev has quit IRC
 95 2020-05-29T06:27:27  *** jarthur_ has joined #bitcoin-core-dev
 96 2020-05-29T06:29:21  *** jarthur has quit IRC
 97 2020-05-29T06:34:21  *** morcos has quit IRC
 98 2020-05-29T06:35:10  *** morcos has joined #bitcoin-core-dev
 99 2020-05-29T06:55:53  *** bitcoin-git has joined #bitcoin-core-dev
100 2020-05-29T06:55:54  <bitcoin-git> [bitcoin] jonasschnelli pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/adc143fc2b9a...5f75c5e7df14
101 2020-05-29T06:55:54  <bitcoin-git> bitcoin/master 73d8ef7 Hennadii Stepanov: qt: Add BitcoinUnits::formatWithPrivacy() function
102 2020-05-29T06:55:55  <bitcoin-git> bitcoin/master 8d75115 Hennadii Stepanov: qt: Add privacy feature to Overview page
103 2020-05-29T06:55:55  <bitcoin-git> bitcoin/master 5f75c5e Jonas Schnelli: Merge #16432: qt: Add privacy to the Overview page
104 2020-05-29T06:55:57  *** bitcoin-git has left #bitcoin-core-dev
105 2020-05-29T06:57:23  *** bitcoin-git has joined #bitcoin-core-dev
106 2020-05-29T06:57:23  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #16432: qt: Add privacy to the Overview page (master...20190721-privacy) https://github.com/bitcoin/bitcoin/pull/16432
107 2020-05-29T06:57:24  *** bitcoin-git has left #bitcoin-core-dev
108 2020-05-29T07:00:51  *** bitcoin-git has joined #bitcoin-core-dev
109 2020-05-29T07:00:52  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #12833: [qt] move QSettings to bitcoin_rw.conf where possible (master...2018/03/bitcoin-conf-rw) https://github.com/bitcoin/bitcoin/pull/12833
110 2020-05-29T07:00:53  *** bitcoin-git has left #bitcoin-core-dev
111 2020-05-29T07:17:40  *** bitcoin-git has joined #bitcoin-core-dev
112 2020-05-29T07:17:40  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #14988: wallet: Fix for confirmed column in csv export for payment to self transactions (master...confirmations_in_csv_export) https://github.com/bitcoin/bitcoin/pull/14988
113 2020-05-29T07:17:41  *** bitcoin-git has left #bitcoin-core-dev
114 2020-05-29T07:22:37  <jonasschnelli> promag_: #15202 could use a rebase
115 2020-05-29T07:22:39  <gribble> https://github.com/bitcoin/bitcoin/issues/15202 | gui: Add Close All Wallets action by promag · Pull Request #15202 · bitcoin/bitcoin · GitHub
116 2020-05-29T07:24:02  *** bitcoin-git has joined #bitcoin-core-dev
117 2020-05-29T07:24:03  <bitcoin-git> [bitcoin] rajarshimaitra closed pull request #19093: RPC: testmempoolaccept returns transaction fee (master...fee-trial3) https://github.com/bitcoin/bitcoin/pull/19093
118 2020-05-29T07:24:03  *** bitcoin-git has left #bitcoin-core-dev
119 2020-05-29T07:25:12  *** bitcoin-git has joined #bitcoin-core-dev
120 2020-05-29T07:25:13  <bitcoin-git> [bitcoin] rajarshimaitra reopened pull request #19093: RPC: testmempoolaccept returns transaction fee (master...fee-trial3) https://github.com/bitcoin/bitcoin/pull/19093
121 2020-05-29T07:25:14  *** bitcoin-git has left #bitcoin-core-dev
122 2020-05-29T07:29:25  <jonasschnelli> ryanofsky: I guess #15935 could be taken out of draft
123 2020-05-29T07:29:27  <gribble> https://github.com/bitcoin/bitcoin/issues/15935 | WIP: Add /settings.json persistent settings storage by ryanofsky · Pull Request #15935 · bitcoin/bitcoin · GitHub
124 2020-05-29T07:30:56  *** lehnberg has joined #bitcoin-core-dev
125 2020-05-29T07:32:51  *** Guyver2 has joined #bitcoin-core-dev
126 2020-05-29T07:33:02  *** bitcoin-git has joined #bitcoin-core-dev
127 2020-05-29T07:33:03  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #16876: gui: Drop calls to QCoreApplication::processEvents (master...2019-09-drop-processevents) https://github.com/bitcoin/bitcoin/pull/16876
128 2020-05-29T07:33:04  *** bitcoin-git has left #bitcoin-core-dev
129 2020-05-29T07:40:45  *** EagleTM has joined #bitcoin-core-dev
130 2020-05-29T07:41:45  *** as_pnn has quit IRC
131 2020-05-29T07:44:10  *** as_pnn has joined #bitcoin-core-dev
132 2020-05-29T07:45:32  <jonasschnelli> MarcoFalke: can you ack/nack/comment on #17227 (contains [squashes]commits of yours)
133 2020-05-29T07:45:35  <gribble> https://github.com/bitcoin/bitcoin/issues/17227 | Qt: Add Android packaging support by icota · Pull Request #17227 · bitcoin/bitcoin · GitHub
134 2020-05-29T08:02:55  *** Highway61 has quit IRC
135 2020-05-29T08:03:02  *** bitcoin-git has joined #bitcoin-core-dev
136 2020-05-29T08:03:03  <bitcoin-git> [bitcoin] jonasschnelli pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5f75c5e7df14...343169998193
137 2020-05-29T08:03:03  <bitcoin-git> bitcoin/master 68288ef Hennadii Stepanov: qt: Overhaul ReceiveRequestDialog
138 2020-05-29T08:03:04  <bitcoin-git> bitcoin/master 73529f0 Hennadii Stepanov: qt: Rename slot to updateDisplayUnit()
139 2020-05-29T08:03:05  <bitcoin-git> bitcoin/master 3431699 Jonas Schnelli: Merge #17597: qt: Fix height of QR-less ReceiveRequestDialog
140 2020-05-29T08:03:07  *** bitcoin-git has left #bitcoin-core-dev
141 2020-05-29T08:03:11  *** Highway61 has joined #bitcoin-core-dev
142 2020-05-29T08:04:07  *** bitcoin-git has joined #bitcoin-core-dev
143 2020-05-29T08:04:07  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #17597: qt: Fix height of QR-less ReceiveRequestDialog (master...20191125-height-without-qr) https://github.com/bitcoin/bitcoin/pull/17597
144 2020-05-29T08:04:08  *** bitcoin-git has left #bitcoin-core-dev
145 2020-05-29T08:07:03  *** mrostecki has quit IRC
146 2020-05-29T08:12:14  *** mrostecki has joined #bitcoin-core-dev
147 2020-05-29T08:20:17  *** bitcoin-git has joined #bitcoin-core-dev
148 2020-05-29T08:20:17  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/343169998193...c2c15ea54eb1
149 2020-05-29T08:20:17  <bitcoin-git> bitcoin/master 1122817 Hennadii Stepanov: qt: Remove QFont warnings with QPA=minimal
150 2020-05-29T08:20:18  <bitcoin-git> bitcoin/master c2c15ea Jonas Schnelli: Merge #17908: qt: Remove QFont warnings with QT_QPA_PLATFORM=minimal
151 2020-05-29T08:20:20  *** bitcoin-git has left #bitcoin-core-dev
152 2020-05-29T08:21:14  *** kristapsk_ is now known as kristapsk
153 2020-05-29T08:21:17  *** bitcoin-git has joined #bitcoin-core-dev
154 2020-05-29T08:21:17  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #17908: qt: Remove QFont warnings with QT_QPA_PLATFORM=minimal (master...20200111-qttest-minimal-warn) https://github.com/bitcoin/bitcoin/pull/17908
155 2020-05-29T08:21:18  *** bitcoin-git has left #bitcoin-core-dev
156 2020-05-29T08:23:32  *** bitcoin-git has joined #bitcoin-core-dev
157 2020-05-29T08:23:33  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c2c15ea54eb1...a9024a42fcec
158 2020-05-29T08:23:33  <bitcoin-git> bitcoin/master c4ea501 Emil Engler: qt: Hide non PKHash-Addresses in signing address book
159 2020-05-29T08:23:34  <bitcoin-git> bitcoin/master a9024a4 Jonas Schnelli: Merge #17918: qt: Hide non PKHash-Addresses in signing address book
160 2020-05-29T08:23:35  *** bitcoin-git has left #bitcoin-core-dev
161 2020-05-29T08:24:27  *** bitcoin-git has joined #bitcoin-core-dev
162 2020-05-29T08:24:28  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #17918: qt: Hide non PKHash-Addresses in signing address book (master...2020-01-hide-non-pkhash-addresses) https://github.com/bitcoin/bitcoin/pull/17918
163 2020-05-29T08:24:28  *** bitcoin-git has left #bitcoin-core-dev
164 2020-05-29T08:25:15  *** promag has joined #bitcoin-core-dev
165 2020-05-29T08:29:43  *** bitcoin-git has joined #bitcoin-core-dev
166 2020-05-29T08:29:44  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a9024a42fcec...0d5c18204b73
167 2020-05-29T08:29:44  <bitcoin-git> bitcoin/master 2b18fd2 Kristaps Kaupe: Disable unavailable context menu items in transactions tab
168 2020-05-29T08:29:44  <bitcoin-git> bitcoin/master 0d5c182 Jonas Schnelli: Merge #17956: gui: Disable unavailable context menu items in transactions ...
169 2020-05-29T08:29:46  *** bitcoin-git has left #bitcoin-core-dev
170 2020-05-29T08:30:40  *** bitcoin-git has joined #bitcoin-core-dev
171 2020-05-29T08:30:40  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #17956: gui: Disable unavailable context menu items in transactions tab (master...tx-menu-disable) https://github.com/bitcoin/bitcoin/pull/17956
172 2020-05-29T08:30:41  *** bitcoin-git has left #bitcoin-core-dev
173 2020-05-29T08:30:59  *** bitcoin-git has joined #bitcoin-core-dev
174 2020-05-29T08:30:59  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0d5c18204b73...beb3844c45c5
175 2020-05-29T08:30:59  <bitcoin-git> bitcoin/master 4fc1df4 Hennadii Stepanov: qt: Track QEvent::Resize during animation
176 2020-05-29T08:31:00  <bitcoin-git> bitcoin/master beb3844 Jonas Schnelli: Merge #17968: qt: Ensure that ModalOverlay is resized properly
177 2020-05-29T08:31:07  *** bitcoin-git has left #bitcoin-core-dev
178 2020-05-29T08:31:54  *** bitcoin-git has joined #bitcoin-core-dev
179 2020-05-29T08:31:54  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #17968: qt: Ensure that ModalOverlay is resized properly (master...20200120-fix-modaloverlay) https://github.com/bitcoin/bitcoin/pull/17968
180 2020-05-29T08:31:55  *** bitcoin-git has left #bitcoin-core-dev
181 2020-05-29T08:32:33  *** jarthur_ has quit IRC
182 2020-05-29T08:54:25  *** Relis has joined #bitcoin-core-dev
183 2020-05-29T08:55:38  *** provoostenator_ has joined #bitcoin-core-dev
184 2020-05-29T08:59:01  *** provoostenator has quit IRC
185 2020-05-29T08:59:41  *** promag has quit IRC
186 2020-05-29T09:00:02  *** Antonet has quit IRC
187 2020-05-29T09:00:03  *** promag_ is now known as promag
188 2020-05-29T09:00:16  <promag> jonasschnelli: +1
189 2020-05-29T09:00:28  <jonasschnelli> spring cleaning...
190 2020-05-29T09:00:29  *** Relis has quit IRC
191 2020-05-29T09:00:30  *** promag_ has joined #bitcoin-core-dev
192 2020-05-29T09:00:50  <promag> jonasschnelli: \o/
193 2020-05-29T09:01:21  <promag> #17355 needs rebase
194 2020-05-29T09:01:23  <gribble> https://github.com/bitcoin/bitcoin/issues/17355 | gui: grey out used address in address book by za-kk · Pull Request #17355 · bitcoin/bitcoin · GitHub
195 2020-05-29T09:01:36  *** bitcoin-git has joined #bitcoin-core-dev
196 2020-05-29T09:01:37  <bitcoin-git> [bitcoin] jonasschnelli pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/beb3844c45c5...f4b603cff63a
197 2020-05-29T09:01:37  <bitcoin-git> bitcoin/master 2f86720 furszy: Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals.
198 2020-05-29T09:01:38  <bitcoin-git> bitcoin/master a06e845 furszy: BlockTip struct created and connected to notifyHeaderTip and notifyBlockTi...
199 2020-05-29T09:01:39  <bitcoin-git> bitcoin/master f4b603c Jonas Schnelli: Merge #17993: gui: Balance/TxStatus polling update based on last block has...
200 2020-05-29T09:01:40  *** bitcoin-git has left #bitcoin-core-dev
201 2020-05-29T09:02:31  *** bitcoin-git has joined #bitcoin-core-dev
202 2020-05-29T09:02:31  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #17993: gui: Balance/TxStatus polling update based on last block hash. (master...2020_avoid_unnecessary_lock_in_balance_polling) https://github.com/bitcoin/bitcoin/pull/17993
203 2020-05-29T09:02:35  *** bitcoin-git has left #bitcoin-core-dev
204 2020-05-29T09:06:31  *** bitcoin-git has joined #bitcoin-core-dev
205 2020-05-29T09:06:32  <bitcoin-git> [bitcoin] jonasschnelli pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f4b603cff63a...de369c7ea577
206 2020-05-29T09:06:33  <bitcoin-git> bitcoin/master cea91a1 Luke Dashjr: Bugfix: GUI: Use unsigned long long type to avoid implicit conversion of M...
207 2020-05-29T09:06:33  <bitcoin-git> bitcoin/master c31bc5b Luke Dashjr: Consolidate service flag bit-to-name conversion to a shared serviceFlagToS...
208 2020-05-29T09:06:34  <bitcoin-git> bitcoin/master de369c7 Jonas Schnelli: Merge #18165: Consolidate service flag bit-to-name conversion to a shared ...
209 2020-05-29T09:06:34  *** bitcoin-git has left #bitcoin-core-dev
210 2020-05-29T09:07:22  *** bitcoin-git has joined #bitcoin-core-dev
211 2020-05-29T09:07:22  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #18165: Consolidate service flag bit-to-name conversion to a shared serviceFlagToStr function (master...svcflags2str) https://github.com/bitcoin/bitcoin/pull/18165
212 2020-05-29T09:07:30  *** bitcoin-git has left #bitcoin-core-dev
213 2020-05-29T09:08:59  *** bitcoin-git has joined #bitcoin-core-dev
214 2020-05-29T09:09:00  <bitcoin-git> [bitcoin] promag opened pull request #19104: gui, test: Fix Cannot queue arguments of type size_t (master...2020-05-register-metatypes) https://github.com/bitcoin/bitcoin/pull/19104
215 2020-05-29T09:09:01  *** bitcoin-git has left #bitcoin-core-dev
216 2020-05-29T09:09:33  *** bitcoin-git has joined #bitcoin-core-dev
217 2020-05-29T09:09:34  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/de369c7ea577...d7f5e01e3093
218 2020-05-29T09:09:34  <bitcoin-git> bitcoin/master 8e08d00 Hennadii Stepanov: qt: Use parent-child relation to manage lifetime of OptionsModel object
219 2020-05-29T09:09:35  <bitcoin-git> bitcoin/master d7f5e01 Jonas Schnelli: Merge #18424: qt: Use parent-child relation to manage lifetime of OptionsM...
220 2020-05-29T09:09:36  *** bitcoin-git has left #bitcoin-core-dev
221 2020-05-29T09:10:13  *** bitcoin-git has joined #bitcoin-core-dev
222 2020-05-29T09:10:14  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #18424: qt: Use parent-child relation to manage lifetime of OptionsModel object (master...20200324-options-model) https://github.com/bitcoin/bitcoin/pull/18424
223 2020-05-29T09:10:15  *** bitcoin-git has left #bitcoin-core-dev
224 2020-05-29T09:14:10  *** |Kin| has joined #bitcoin-core-dev
225 2020-05-29T09:14:56  <hebasto> jonasschnelli: mind looking into ##17127 which is alternative to #13389 ?
226 2020-05-29T09:14:58  <gribble> https://github.com/bitcoin/bitcoin/issues/17127 | util: Correct permissions for datadir and wallets subdir by hebasto · Pull Request #17127 · bitcoin/bitcoin · GitHub
227 2020-05-29T09:15:01  <gribble> https://github.com/bitcoin/bitcoin/issues/13389 | Utils and libraries: Fix #13371 - move umask operation earlier in AppInit() by n2yen · Pull Request #13389 · bitcoin/bitcoin · GitHub
228 2020-05-29T09:17:19  <jonasschnelli> hebasto: thanks for pointing that to me. Since this is not GUI only,... it needs more review before we can merge this.
229 2020-05-29T09:17:48  <hebasto> jonasschnelli: sure
230 2020-05-29T09:18:16  <jonasschnelli> hebasto, promag: maybe interested to fix #19103?
231 2020-05-29T09:18:17  <gribble> https://github.com/bitcoin/bitcoin/issues/19103 | QRCode address in image is not readable · Issue #19103 · bitcoin/bitcoin · GitHub
232 2020-05-29T09:18:21  <jonasschnelli> Make sure it respects HiDPI
233 2020-05-29T09:18:49  <promag> I was going to see if changing font fixes it
234 2020-05-29T09:19:11  *** Relis has joined #bitcoin-core-dev
235 2020-05-29T09:19:36  <hebasto> jonasschnelli: not sure if I could test on my equipment
236 2020-05-29T09:21:46  *** belcher has quit IRC
237 2020-05-29T09:31:01  *** provoostenator_ has quit IRC
238 2020-05-29T09:31:10  <jonasschnelli> hebasto: good point. I wonder if the issue is also present on HiDPI ubuntu
239 2020-05-29T09:32:41  *** provoostenator has joined #bitcoin-core-dev
240 2020-05-29T09:36:07  *** Chris_Stewart_5 has joined #bitcoin-core-dev
241 2020-05-29T09:43:52  *** Relis has quit IRC
242 2020-05-29T09:44:17  <promag> jonasschnelli: I can test that
243 2020-05-29T09:45:31  <promag> I'm getting
244 2020-05-29T09:45:31  <promag> CoreText note: Client requested name ".SFNSMono-Regular", it will get Times-Roman rather than the intended font. All system UI font access should be through proper APIs such as CTFontCreateUIFontForLanguage() or +[NSFont systemFontOfSize:].
245 2020-05-29T09:51:13  *** AaronvanW has joined #bitcoin-core-dev
246 2020-05-29T10:03:20  *** Jany7Nader has joined #bitcoin-core-dev
247 2020-05-29T10:10:20  *** Jany7Nader has quit IRC
248 2020-05-29T10:15:38  *** surja795 has joined #bitcoin-core-dev
249 2020-05-29T10:16:47  *** shaunsun_ has joined #bitcoin-core-dev
250 2020-05-29T10:16:49  *** belcher has joined #bitcoin-core-dev
251 2020-05-29T10:18:01  *** Relis has joined #bitcoin-core-dev
252 2020-05-29T10:18:42  *** shaunsun__ has joined #bitcoin-core-dev
253 2020-05-29T10:19:26  *** thunderbiscuit[m has left #bitcoin-core-dev
254 2020-05-29T10:21:15  *** shaunsun_ has quit IRC
255 2020-05-29T10:24:45  *** bitcoin-git has joined #bitcoin-core-dev
256 2020-05-29T10:24:46  <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d7f5e01e3093...73407ff65cef
257 2020-05-29T10:24:47  <bitcoin-git> bitcoin/master fa5894f Anthony Towns: DNS seeds: wait for 5m instead of 11s if 1000+ peers are known
258 2020-05-29T10:24:48  <bitcoin-git> bitcoin/master 96954d1 Anthony Towns: DNS seeds: don't query DNS while network is inactive
259 2020-05-29T10:24:49  <bitcoin-git> bitcoin/master 73407ff fanquake: Merge #16939: p2p: Delay querying DNS seeds
260 2020-05-29T10:24:57  *** bitcoin-git has left #bitcoin-core-dev
261 2020-05-29T10:26:00  *** bitcoin-git has joined #bitcoin-core-dev
262 2020-05-29T10:26:01  <bitcoin-git> [bitcoin] fanquake merged pull request #16939: p2p: Delay querying DNS seeds (master...201909-avoid-dns-if-addrman-populated) https://github.com/bitcoin/bitcoin/pull/16939
263 2020-05-29T10:26:02  *** bitcoin-git has left #bitcoin-core-dev
264 2020-05-29T10:31:34  *** IGHOR has quit IRC
265 2020-05-29T10:33:06  *** jarthur has joined #bitcoin-core-dev
266 2020-05-29T10:34:03  *** IGHOR has joined #bitcoin-core-dev
267 2020-05-29T10:35:56  *** timothy has joined #bitcoin-core-dev
268 2020-05-29T10:36:03  *** timothy has joined #bitcoin-core-dev
269 2020-05-29T10:36:50  *** timothy has quit IRC
270 2020-05-29T10:37:53  *** jarthur has quit IRC
271 2020-05-29T10:38:43  *** kristapsk has quit IRC
272 2020-05-29T10:53:38  *** shaunsun__ has quit IRC
273 2020-05-29T11:08:23  *** Pavlenex has joined #bitcoin-core-dev
274 2020-05-29T11:23:49  *** timothy has joined #bitcoin-core-dev
275 2020-05-29T11:31:15  *** cltrbreak_MAD2 has quit IRC
276 2020-05-29T11:31:42  *** cltrbreak_MAD2 has joined #bitcoin-core-dev
277 2020-05-29T11:34:05  *** bitdex has quit IRC
278 2020-05-29T11:34:50  *** bitdex has joined #bitcoin-core-dev
279 2020-05-29T11:41:50  *** Pavlenex has quit IRC
280 2020-05-29T11:58:15  *** bitcoin-git has joined #bitcoin-core-dev
281 2020-05-29T11:58:16  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #17355: gui: grey out used address in address book (master...oct-19-17174) https://github.com/bitcoin/bitcoin/pull/17355
282 2020-05-29T11:58:17  *** bitcoin-git has left #bitcoin-core-dev
283 2020-05-29T11:58:35  *** bitcoin-git has joined #bitcoin-core-dev
284 2020-05-29T11:58:36  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #17355: gui: grey out used address in address book (master...oct-19-17174) https://github.com/bitcoin/bitcoin/pull/17355
285 2020-05-29T11:58:36  *** bitcoin-git has left #bitcoin-core-dev
286 2020-05-29T12:00:02  *** |Kin| has quit IRC
287 2020-05-29T12:06:44  *** bitcoin-git has joined #bitcoin-core-dev
288 2020-05-29T12:06:44  <bitcoin-git> [bitcoin] fjahr opened pull request #19105: Add Muhash3072 implementation in Python (master...csi-2-muhash-py) https://github.com/bitcoin/bitcoin/pull/19105
289 2020-05-29T12:06:45  *** bitcoin-git has left #bitcoin-core-dev
290 2020-05-29T12:15:01  *** troygiorshev has joined #bitcoin-core-dev
291 2020-05-29T12:18:28  *** boily has joined #bitcoin-core-dev
292 2020-05-29T12:35:16  *** provoostenator has quit IRC
293 2020-05-29T12:36:39  *** provoostenator has joined #bitcoin-core-dev
294 2020-05-29T12:42:41  *** bitcoin-git has joined #bitcoin-core-dev
295 2020-05-29T12:42:41  <bitcoin-git> [bitcoin] jonasschnelli reopened pull request #14988: wallet: Fix for confirmed column in csv export for payment to self transactions (master...confirmations_in_csv_export) https://github.com/bitcoin/bitcoin/pull/14988
296 2020-05-29T12:42:43  *** bitcoin-git has left #bitcoin-core-dev
297 2020-05-29T12:43:26  *** bitcoin-git has joined #bitcoin-core-dev
298 2020-05-29T12:43:26  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/73407ff65cef...f2e2c5ebcccf
299 2020-05-29T12:43:26  <bitcoin-git> bitcoin/master 9760293 Ben Carman: wallet: Fix for exported confirmation field in payment to self transactions
300 2020-05-29T12:43:26  <bitcoin-git> bitcoin/master f2e2c5e Jonas Schnelli: Merge #14988: wallet: Fix for confirmed column in csv export for payment t...
301 2020-05-29T12:43:28  *** bitcoin-git has left #bitcoin-core-dev
302 2020-05-29T12:45:00  *** bitcoin-git has joined #bitcoin-core-dev
303 2020-05-29T12:45:00  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #14988: wallet: Fix for confirmed column in csv export for payment to self transactions (master...confirmations_in_csv_export) https://github.com/bitcoin/bitcoin/pull/14988
304 2020-05-29T12:45:02  *** bitcoin-git has left #bitcoin-core-dev
305 2020-05-29T12:46:39  *** provoostenator has quit IRC
306 2020-05-29T13:30:13  *** Highway61 has quit IRC
307 2020-05-29T13:37:18  *** joerodgers has joined #bitcoin-core-dev
308 2020-05-29T13:42:41  *** igr has joined #bitcoin-core-dev
309 2020-05-29T13:48:48  *** mdunnio has joined #bitcoin-core-dev
310 2020-05-29T13:50:19  *** bitcoin-git has joined #bitcoin-core-dev
311 2020-05-29T13:50:19  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f2e2c5ebcccf...e4bfd51acc11
312 2020-05-29T13:50:19  <bitcoin-git> bitcoin/master da73f15 Hennadii Stepanov: qt: Fix shutdown when waitfor* cmds are called from RPC console
313 2020-05-29T13:50:20  <bitcoin-git> bitcoin/master e4bfd51 Jonas Schnelli: Merge #18452: qt: Fix shutdown when waitfor* cmds are called from RPC cons...
314 2020-05-29T13:50:28  *** bitcoin-git has left #bitcoin-core-dev
315 2020-05-29T13:50:53  *** d_t has joined #bitcoin-core-dev
316 2020-05-29T13:50:59  *** bitcoin-git has joined #bitcoin-core-dev
317 2020-05-29T13:50:59  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #18452: qt: Fix shutdown when waitfor* cmds are called from RPC console (master...20200327-waitfor) https://github.com/bitcoin/bitcoin/pull/18452
318 2020-05-29T13:51:08  *** bitcoin-git has left #bitcoin-core-dev
319 2020-05-29T13:52:41  *** waxwing_ has left #bitcoin-core-dev
320 2020-05-29T13:53:27  *** waxwing has joined #bitcoin-core-dev
321 2020-05-29T13:57:31  *** bitcoin-git has joined #bitcoin-core-dev
322 2020-05-29T13:57:31  <bitcoin-git> [bitcoin] vasild opened pull request #19106: util: simplify the interface of serviceFlagToStr() (master...serviceFlagToStr) https://github.com/bitcoin/bitcoin/pull/19106
323 2020-05-29T13:57:32  *** bitcoin-git has left #bitcoin-core-dev
324 2020-05-29T14:00:53  *** timothy has quit IRC
325 2020-05-29T14:01:28  *** timothy has joined #bitcoin-core-dev
326 2020-05-29T14:04:56  <instagibbs> oh hey I can restart travis jobs again
327 2020-05-29T14:12:10  *** igr has quit IRC
328 2020-05-29T14:27:07  *** proofofkeags has joined #bitcoin-core-dev
329 2020-05-29T14:27:34  *** Highway61 has joined #bitcoin-core-dev
330 2020-05-29T14:30:25  *** d_t has quit IRC
331 2020-05-29T14:30:39  *** kexkey has joined #bitcoin-core-dev
332 2020-05-29T14:33:34  *** jarthur has joined #bitcoin-core-dev
333 2020-05-29T14:37:57  *** jarthur has quit IRC
334 2020-05-29T14:39:19  *** proofofkeags has quit IRC
335 2020-05-29T14:39:54  *** proofofkeags has joined #bitcoin-core-dev
336 2020-05-29T14:44:13  *** proofofkeags has quit IRC
337 2020-05-29T14:55:05  *** Landryl has quit IRC
338 2020-05-29T15:00:02  *** boily has quit IRC
339 2020-05-29T15:02:29  *** kljasdfvv has quit IRC
340 2020-05-29T15:12:06  *** kristapsk has joined #bitcoin-core-dev
341 2020-05-29T15:16:20  *** maop has joined #bitcoin-core-dev
342 2020-05-29T15:18:29  *** timothy has quit IRC
343 2020-05-29T15:18:54  *** timothy has joined #bitcoin-core-dev
344 2020-05-29T15:21:04  *** provoostenator has joined #bitcoin-core-dev
345 2020-05-29T15:21:30  *** provoostenator has quit IRC
346 2020-05-29T15:25:19  *** Pavlenex has joined #bitcoin-core-dev
347 2020-05-29T15:29:13  *** bitcoin-git has joined #bitcoin-core-dev
348 2020-05-29T15:29:14  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e4bfd51acc11...c19fd96694d1
349 2020-05-29T15:29:15  <bitcoin-git> bitcoin/master fa2ca0c MarcoFalke: test: Fix intermittent failure in feature_dbcrash
350 2020-05-29T15:29:15  <bitcoin-git> bitcoin/master c19fd96 MarcoFalke: Merge #19022: test: Fix intermittent failure in feature_dbcrash
351 2020-05-29T15:29:22  *** bitcoin-git has left #bitcoin-core-dev
352 2020-05-29T15:29:38  *** bitcoin-git has joined #bitcoin-core-dev
353 2020-05-29T15:29:39  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19022: test: Fix intermittent failure in feature_dbcrash (master...2005-testFixIntermittentFailDbCrash) https://github.com/bitcoin/bitcoin/pull/19022
354 2020-05-29T15:29:40  *** bitcoin-git has left #bitcoin-core-dev
355 2020-05-29T15:32:17  *** provoostenator has joined #bitcoin-core-dev
356 2020-05-29T15:36:45  *** owowo has quit IRC
357 2020-05-29T15:41:43  *** owowo has joined #bitcoin-core-dev
358 2020-05-29T15:41:43  *** owowo has joined #bitcoin-core-dev
359 2020-05-29T15:46:52  *** provoostenator has quit IRC
360 2020-05-29T15:54:07  *** bitcoin-git has joined #bitcoin-core-dev
361 2020-05-29T15:54:07  <bitcoin-git> [bitcoin] troygiorshev opened pull request #19107: p2p: Refactor, move all header verification into the network layer, without changing behavior (master...p2p-refactor-header) https://github.com/bitcoin/bitcoin/pull/19107
362 2020-05-29T15:54:08  *** bitcoin-git has left #bitcoin-core-dev
363 2020-05-29T15:56:01  *** Highway61 has quit IRC
364 2020-05-29T15:58:32  *** Highway61 has joined #bitcoin-core-dev
365 2020-05-29T16:05:04  *** MarcoFalke has quit IRC
366 2020-05-29T16:08:47  *** provoostenator has joined #bitcoin-core-dev
367 2020-05-29T16:09:52  *** Talkless has joined #bitcoin-core-dev
368 2020-05-29T16:15:01  *** Guest7387 has joined #bitcoin-core-dev
369 2020-05-29T16:16:04  *** Pavlenex has quit IRC
370 2020-05-29T16:20:24  *** vasild_ has joined #bitcoin-core-dev
371 2020-05-29T16:24:03  *** vasild has quit IRC
372 2020-05-29T16:24:04  *** vasild_ is now known as vasild
373 2020-05-29T16:24:21  *** justanotheruser has quit IRC
374 2020-05-29T16:28:06  *** proofofkeags has joined #bitcoin-core-dev
375 2020-05-29T16:40:11  *** Victorsueca has joined #bitcoin-core-dev
376 2020-05-29T16:41:04  *** justanotheruser has joined #bitcoin-core-dev
377 2020-05-29T16:44:10  *** Elsie85Block has joined #bitcoin-core-dev
378 2020-05-29T16:48:59  *** Elsie85Block has quit IRC
379 2020-05-29T16:52:45  *** kristapsk_ has joined #bitcoin-core-dev
380 2020-05-29T16:54:12  *** drizztbsd has joined #bitcoin-core-dev
381 2020-05-29T16:54:44  *** bitdex has quit IRC
382 2020-05-29T16:54:44  *** mrostecki has quit IRC
383 2020-05-29T16:55:03  *** vasild has quit IRC
384 2020-05-29T16:55:04  *** timothy has quit IRC
385 2020-05-29T16:56:00  *** bitdex has joined #bitcoin-core-dev
386 2020-05-29T16:59:03  *** kristapsk has quit IRC
387 2020-05-29T17:04:53  *** bitdex has quit IRC
388 2020-05-29T17:05:18  *** bitdex has joined #bitcoin-core-dev
389 2020-05-29T17:05:41  *** mrostecki has joined #bitcoin-core-dev
390 2020-05-29T17:05:45  *** vasild has joined #bitcoin-core-dev
391 2020-05-29T17:09:07  *** drizztbsd is now known as timothy
392 2020-05-29T17:12:57  *** troygiorshev has quit IRC
393 2020-05-29T17:21:06  *** troygiorshev has joined #bitcoin-core-dev
394 2020-05-29T17:22:02  *** mol_ has joined #bitcoin-core-dev
395 2020-05-29T17:24:04  *** mol has quit IRC
396 2020-05-29T17:32:27  *** Zenton has joined #bitcoin-core-dev
397 2020-05-29T17:32:33  *** bitcoin-git has joined #bitcoin-core-dev
398 2020-05-29T17:32:34  <bitcoin-git> [bitcoin] hebasto opened pull request #19108: qt, refactor: Drop unneeded Q_DECLARE_METATYPE (master...200529-metatype) https://github.com/bitcoin/bitcoin/pull/19108
399 2020-05-29T17:32:35  *** bitcoin-git has left #bitcoin-core-dev
400 2020-05-29T17:36:07  *** jarthur has joined #bitcoin-core-dev
401 2020-05-29T17:39:33  *** Pavlenex has joined #bitcoin-core-dev
402 2020-05-29T17:43:39  *** bitcoin-git has joined #bitcoin-core-dev
403 2020-05-29T17:43:41  <bitcoin-git> [bitcoin] jonasschnelli pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c19fd96694d1...8ad5f1c376fe
404 2020-05-29T17:43:42  <bitcoin-git> bitcoin/master fbacad1 Vasil Dimov: util: simplify the interface of serviceFlagToStr()
405 2020-05-29T17:43:42  <bitcoin-git> bitcoin/master 189ae0c Vasil Dimov: util: dedup code in callers of serviceFlagToStr()
406 2020-05-29T17:43:43  <bitcoin-git> bitcoin/master 8ad5f1c Jonas Schnelli: Merge #19106: util: simplify the interface of serviceFlagToStr()
407 2020-05-29T17:43:45  *** bitcoin-git has left #bitcoin-core-dev
408 2020-05-29T17:43:59  *** bitcoin-git has joined #bitcoin-core-dev
409 2020-05-29T17:44:00  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #19106: util: simplify the interface of serviceFlagToStr() (master...serviceFlagToStr) https://github.com/bitcoin/bitcoin/pull/19106
410 2020-05-29T17:44:11  *** bitcoin-git has left #bitcoin-core-dev
411 2020-05-29T17:53:50  *** troygiorshev has quit IRC
412 2020-05-29T17:54:30  *** troygiorshev has joined #bitcoin-core-dev
413 2020-05-29T18:00:09  *** maop has quit IRC
414 2020-05-29T18:01:37  *** mdunnio has quit IRC
415 2020-05-29T18:18:01  *** Windurr has joined #bitcoin-core-dev
416 2020-05-29T18:18:31  *** troygiorshev has quit IRC
417 2020-05-29T18:24:56  *** ryzeb has quit IRC
418 2020-05-29T18:25:16  *** bitcoin-git has joined #bitcoin-core-dev
419 2020-05-29T18:25:18  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/8ad5f1c376fe...cb88de3e3d37
420 2020-05-29T18:25:19  <bitcoin-git> bitcoin/master 357f02b glowang: Create a local class inherited from BasicTestingSetup with a localized arg...
421 2020-05-29T18:25:19  <bitcoin-git> bitcoin/master f871f15 glowang: scripted-diff: replace gArgs with argsman
422 2020-05-29T18:25:20  <bitcoin-git> bitcoin/master cb88de3 MarcoFalke: Merge #18926: test: Pass ArgsManager into getarg_tests
423 2020-05-29T18:25:22  *** bitcoin-git has left #bitcoin-core-dev
424 2020-05-29T18:25:42  *** bitcoin-git has joined #bitcoin-core-dev
425 2020-05-29T18:25:42  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18926: test: Pass ArgsManager into getarg_tests (master...replace_global_gArgs_with_local_argsman) https://github.com/bitcoin/bitcoin/pull/18926
426 2020-05-29T18:25:43  *** bitcoin-git has left #bitcoin-core-dev
427 2020-05-29T18:27:04  *** lehnberg has quit IRC
428 2020-05-29T18:32:06  *** mdunnio has joined #bitcoin-core-dev
429 2020-05-29T18:33:58  *** kristapsk_ is now known as kristapsk
430 2020-05-29T18:34:00  *** lehnberg has joined #bitcoin-core-dev
431 2020-05-29T18:35:42  *** justanotheruser has quit IRC
432 2020-05-29T18:38:20  *** troygiorshev has joined #bitcoin-core-dev
433 2020-05-29T18:38:48  *** lehnberg has quit IRC
434 2020-05-29T18:39:21  *** lehnberg has joined #bitcoin-core-dev
435 2020-05-29T18:42:22  *** justanotheruser has joined #bitcoin-core-dev
436 2020-05-29T18:42:55  *** MarcoFalke has joined #bitcoin-core-dev
437 2020-05-29T18:52:30  *** lehnberg has quit IRC
438 2020-05-29T18:54:36  *** Pavlenex has quit IRC
439 2020-05-29T18:55:09  *** lehnberg has joined #bitcoin-core-dev
440 2020-05-29T18:55:32  *** kristapsk has quit IRC
441 2020-05-29T18:55:47  *** kristapsk has joined #bitcoin-core-dev
442 2020-05-29T19:01:22  *** bitcoin-git has joined #bitcoin-core-dev
443 2020-05-29T19:01:22  <bitcoin-git> [bitcoin] sipa opened pull request #19109: Only allow getdata of recently announced invs (master...202005_bloom_relay) https://github.com/bitcoin/bitcoin/pull/19109
444 2020-05-29T19:01:23  *** bitcoin-git has left #bitcoin-core-dev
445 2020-05-29T19:04:48  *** tylerdmace has quit IRC
446 2020-05-29T19:05:48  *** lehnberg has quit IRC
447 2020-05-29T19:06:44  *** cltrbreak_MAD2 has quit IRC
448 2020-05-29T19:07:09  *** cltrbreak_MAD2 has joined #bitcoin-core-dev
449 2020-05-29T19:07:23  <vasild> Assertion failed: detected inconsistent lock order at /home/vd/gh/bitcoin/bitcoin/src/sync.cpp:128, details in debug log.
450 2020-05-29T19:07:26  <vasild> Abort trap (core dumped)
451 2020-05-29T19:07:28  <vasild> hmm
452 2020-05-29T19:07:32  *** troygiorshev has quit IRC
453 2020-05-29T19:07:46  *** lehnberg has joined #bitcoin-core-dev
454 2020-05-29T19:09:37  *** troygiorshev has joined #bitcoin-core-dev
455 2020-05-29T19:10:25  *** timothy has quit IRC
456 2020-05-29T19:11:02  *** troygiorshev has joined #bitcoin-core-dev
457 2020-05-29T19:11:06  *** tylerdmace has joined #bitcoin-core-dev
458 2020-05-29T19:15:24  *** lehnberg has quit IRC
459 2020-05-29T19:15:49  *** kristapsk_ has joined #bitcoin-core-dev
460 2020-05-29T19:15:55  *** kristapsk has quit IRC
461 2020-05-29T19:16:15  *** bitdex has quit IRC
462 2020-05-29T19:18:16  *** lehnberg has joined #bitcoin-core-dev
463 2020-05-29T19:19:37  *** kristapsk_ is now known as kristapsk
464 2020-05-29T19:25:10  <dongcarl> Hey jonasschnelli, I wanted to confirm my overall understanding of the topology of the open PRs related to BIP324. Here?s my understanding:
465 2020-05-29T19:25:10  <dongcarl> - #14032 is an old PR that has many of its changes already merged, is superseded by jonasschnelli:2019/08/net_v2, and could potentially be closed. Question here: is there anything there that isn?t in jonasschnelli:2019/08/net_v2?
466 2020-05-29T19:25:10  <dongcarl> - #18242 -> #14032 seems to be the main line of progression
467 2020-05-29T19:25:10  <dongcarl> - #15197 + #15206 seem to be additional improvements that 1. Can be merged independently of the main line of progression, 2. Can help/simplify the implementation of BIP324. Question here: Could you give concrete examples as to how they help/simplify the implementation?
468 2020-05-29T19:25:13  <gribble> https://github.com/bitcoin/bitcoin/issues/14032 | Add p2p layer encryption with ECDH/ChaCha20Poly1305 by jonasschnelli · Pull Request #14032 · bitcoin/bitcoin · GitHub
469 2020-05-29T19:25:16  <gribble> https://github.com/bitcoin/bitcoin/issues/18242 | Add BIP324 encrypted p2p transport de-/serializer (only used in tests) by jonasschnelli · Pull Request #18242 · bitcoin/bitcoin · GitHub
470 2020-05-29T19:25:16  <gribble> https://github.com/bitcoin/bitcoin/issues/14032 | Add p2p layer encryption with ECDH/ChaCha20Poly1305 by jonasschnelli · Pull Request #14032 · bitcoin/bitcoin · GitHub
471 2020-05-29T19:25:18  <gribble> https://github.com/bitcoin/bitcoin/issues/15197 | Refactor and slightly stricter p2p message processing by jonasschnelli · Pull Request #15197 · bitcoin/bitcoin · GitHub
472 2020-05-29T19:25:21  <gribble> https://github.com/bitcoin/bitcoin/issues/15206 | Immediately disconnect on invalid net message checksum by jonasschnelli · Pull Request #15206 · bitcoin/bitcoin · GitHub
473 2020-05-29T19:26:41  <dongcarl> Sorry, some of my apostrophes got converted to question marks. *shakes fist at Synergy*
474 2020-05-29T19:33:54  *** bitcoin-git has joined #bitcoin-core-dev
475 2020-05-29T19:33:54  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19110: test: Explain that a bug should be filed when the tests fail (master...2005-testBug) https://github.com/bitcoin/bitcoin/pull/19110
476 2020-05-29T19:33:55  *** bitcoin-git has left #bitcoin-core-dev
477 2020-05-29T19:37:06  *** Guest7387 has quit IRC
478 2020-05-29T19:45:50  <jonasschnelli> dongcarl: 14032 was an overview/concept. The only relevant PR now is 18242
479 2020-05-29T19:46:06  <jonasschnelli> 15206/15197 are now BIP324 irrelevant
480 2020-05-29T19:47:02  <jonasschnelli> So as for BIP342, just focus on #18242
481 2020-05-29T19:47:05  <gribble> https://github.com/bitcoin/bitcoin/issues/18242 | Add BIP324 encrypted p2p transport de-/serializer (only used in tests) by jonasschnelli · Pull Request #18242 · bitcoin/bitcoin · GitHub
482 2020-05-29T19:47:29  <jonasschnelli> The rest are just relicts that might be a refactor/improvement on its own.
483 2020-05-29T19:48:06  *** lehnberg has quit IRC
484 2020-05-29T19:48:49  <jonasschnelli> Once 18242 is merged,... I would like to "complete" it with the ECDH handshake (another mid size PR).
485 2020-05-29T19:50:02  <jonasschnelli> After that,... i could be enabled behind an experimental off-by-default runtime argument
486 2020-05-29T19:51:38  <dongcarl> jonasschnelli: I see, so after #18242, we need #14049, and then BIP324 handshake + BIP324 ECDH calc + BIP324 HKDF key deriv (last few commits from 2019/08/net_v2)?
487 2020-05-29T19:51:41  <gribble> https://github.com/bitcoin/bitcoin/issues/18242 | Add BIP324 encrypted p2p transport de-/serializer (only used in tests) by jonasschnelli · Pull Request #18242 · bitcoin/bitcoin · GitHub
488 2020-05-29T19:51:43  <gribble> https://github.com/bitcoin/bitcoin/issues/14049 | Enable libsecp256k1 ecdh module, add ECDH function to CKey by jonasschnelli · Pull Request #14049 · bitcoin/bitcoin · GitHub
489 2020-05-29T19:52:56  <jonasschnelli> Yeah. It needs 14049 with some actual handshake implementation. My remote branch you may look at could be outdated and if recent, it may only be the concept.
490 2020-05-29T19:53:29  <dongcarl> Sounds good, I think we're on the same page
491 2020-05-29T19:53:35  <jonasschnelli> HKDF is already implemented,... but not the actually symmetric key derivation from the ecdh_secret
492 2020-05-29T19:53:39  <jonasschnelli> But...
493 2020-05-29T19:53:44  <jonasschnelli> (there is always a but)
494 2020-05-29T19:53:49  <dongcarl> haha
495 2020-05-29T19:54:06  <jonasschnelli> BIP342 is still in discussion.
496 2020-05-29T19:54:19  <jonasschnelli> Questions came up about the missing MAC of the encrypted length field
497 2020-05-29T19:54:38  <jonasschnelli> https://gist.github.com/jonasschnelli/c530ea8421b8d0e80c51486325587c52#gistcomment-3295536
498 2020-05-29T19:54:58  <jonasschnelli> (sipa eventually likes to take a deeper look)
499 2020-05-29T19:55:16  <jonasschnelli> I think it is fine since we use a different encryption context for it.
500 2020-05-29T19:55:50  <jonasschnelli> then... secondly, there are discussions about possible handshake upgrades with downgrade protection (which are currently not directly supported by the bip).
501 2020-05-29T19:56:06  <jonasschnelli> Thats the main reason why the BIP is still not submitted
502 2020-05-29T19:56:25  <jonasschnelli> (as well as the fact that the implementation often reveals conceptual issues)
503 2020-05-29T19:57:31  <jonasschnelli> despite the – eventually –  altering BIP324, I think we can finalise the implementation and hide it behind an experimental runtime parameter.
504 2020-05-29T19:58:20  <jonasschnelli> (which will still allow changing it without users getting mad)
505 2020-05-29T19:58:57  <dongcarl> I see I see, I didn't see that discussion in the gist before, will take a closer look there.
506 2020-05-29T19:59:53  <dongcarl> any links to the discussions about downgrade protection?
507 2020-05-29T20:00:17  <jonasschnelli> I guess it is email only,... mainly real_or_random and sipa
508 2020-05-29T20:00:27  <sipa> i need to respond :)
509 2020-05-29T20:00:31  <jonasschnelli> We hoped for a coredev meeting to tackle it.
510 2020-05-29T20:00:36  <jonasschnelli> sipa: no hurry.
511 2020-05-29T20:00:44  <sipa> we've been talking to boneh about our authentication scheme as well
512 2020-05-29T20:00:53  <sipa> (a week or two ago)
513 2020-05-29T20:01:04  <jonasschnelli> the blind auth scheme?
514 2020-05-29T20:01:10  <sipa> yeah
515 2020-05-29T20:01:22  <jonasschnelli> okay... thats next step of next step. :)
516 2020-05-29T20:01:51  <jonasschnelli> sipa: do you think it could have implications for v2/BIP342?
517 2020-05-29T20:02:07  <jonasschnelli> or would it be more "on the top"?
518 2020-05-29T20:02:15  <sipa> it's why we think we need an upgrade mechanism in BIP342
519 2020-05-29T20:02:43  <sipa> so that the authentication can be done as part of the handshake, rather than as a application level thing later on
520 2020-05-29T20:02:55  <jonasschnelli> ah.. i see
521 2020-05-29T20:03:23  <sipa> but i think the upgrade mechanism can be very simple; just the connecting party sending a "i'm done; here is my hash of the session key"
522 2020-05-29T20:03:25  <jonasschnelli> Yeah. Would be great to have a place/time to discuss the upgrade mechanism
523 2020-05-29T20:03:37  <sipa> and the other side responding "ok, here is my hash"
524 2020-05-29T20:04:12  <dongcarl> is the blind auth scheme you guys are talking about just the new version of the single-party countersign?
525 2020-05-29T20:04:13  <sipa> anything else would be left unspecified, and close the connection
526 2020-05-29T20:04:16  <sipa> dongcarl: yes
527 2020-05-29T20:06:41  <jonasschnelli> I'll take it up soon (the upgrade mechanism) and will bother sipa and real_or_random with a concrete BIP change
528 2020-05-29T20:08:14  <dongcarl> 👍
529 2020-05-29T20:16:54  *** shesek has joined #bitcoin-core-dev
530 2020-05-29T20:16:54  *** shesek has joined #bitcoin-core-dev
531 2020-05-29T20:17:47  *** Guyver2 has quit IRC
532 2020-05-29T20:20:48  *** Chris_Stewart_5 has quit IRC
533 2020-05-29T20:21:19  *** shesek has quit IRC
534 2020-05-29T20:25:46  *** Talkless has quit IRC
535 2020-05-29T20:33:03  *** harrigan has quit IRC
536 2020-05-29T20:34:03  *** proofofkeags has quit IRC
537 2020-05-29T20:34:05  *** harrigan has joined #bitcoin-core-dev
538 2020-05-29T20:34:29  *** proofofkeags has joined #bitcoin-core-dev
539 2020-05-29T20:35:45  *** Chris_Stewart_5 has joined #bitcoin-core-dev
540 2020-05-29T20:38:34  *** proofofkeags has quit IRC
541 2020-05-29T20:47:28  *** proofofkeags has joined #bitcoin-core-dev
542 2020-05-29T21:00:01  *** Windurr has quit IRC
543 2020-05-29T21:17:25  *** ghghjghjghjghjgh has joined #bitcoin-core-dev
544 2020-05-29T21:26:50  *** bitcoin-git has joined #bitcoin-core-dev
545 2020-05-29T21:26:51  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19111: Limit scope of all global std::once_flag (master...2005-NoGlobalOnce) https://github.com/bitcoin/bitcoin/pull/19111
546 2020-05-29T21:26:51  *** bitcoin-git has left #bitcoin-core-dev
547 2020-05-29T21:32:22  *** proofofkeags has quit IRC
548 2020-05-29T21:32:49  *** proofofkeags has joined #bitcoin-core-dev
549 2020-05-29T21:37:08  *** proofofkeags has quit IRC
550 2020-05-29T21:45:53  *** marcoagner has quit IRC
551 2020-05-29T21:49:06  *** PeErLesS has joined #bitcoin-core-dev
552 2020-05-29T21:50:49  *** ghghjghjghjghjgh has quit IRC
553 2020-05-29T22:06:23  *** bitcoin-git has joined #bitcoin-core-dev
554 2020-05-29T22:06:24  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19112: rpc: Remove special case for unknown service flags (master...2005-rpcServiceFlagsUnknown) https://github.com/bitcoin/bitcoin/pull/19112
555 2020-05-29T22:06:24  *** bitcoin-git has left #bitcoin-core-dev
556 2020-05-29T22:12:51  *** proofofkeags has joined #bitcoin-core-dev
557 2020-05-29T22:16:54  *** proofofkeags has quit IRC
558 2020-05-29T22:17:58  *** proofofkeags has joined #bitcoin-core-dev
559 2020-05-29T22:18:57  <ariard> jonasschnelli: fyi will host a Review Club session on seralizer/deserializer commits of #18242 in 2 weeks
560 2020-05-29T22:19:00  <gribble> https://github.com/bitcoin/bitcoin/issues/18242 | Add BIP324 encrypted p2p transport de-/serializer (only used in tests) by jonasschnelli · Pull Request #18242 · bitcoin/bitcoin · GitHub
561 2020-05-29T22:19:24  <ariard> will dig into the rational of MACIng the encrypted length field or not for the occasion
562 2020-05-29T22:33:46  *** belcher has quit IRC
563 2020-05-29T22:34:10  *** proofofkeags has quit IRC
564 2020-05-29T22:34:38  *** proofofkeags has joined #bitcoin-core-dev
565 2020-05-29T22:38:14  *** belcher has joined #bitcoin-core-dev
566 2020-05-29T22:38:51  *** proofofkeags has quit IRC
567 2020-05-29T22:44:37  *** Zenton has quit IRC
568 2020-05-29T22:57:00  *** proofofkeags has joined #bitcoin-core-dev
569 2020-05-29T22:58:22  *** proofofkeags has quit IRC
570 2020-05-29T22:58:49  *** proofofkeags has joined #bitcoin-core-dev
571 2020-05-29T23:03:00  *** proofofkeags has quit IRC
572 2020-05-29T23:10:12  *** mdunnio has quit IRC
573 2020-05-29T23:16:53  *** justanotheruser has quit IRC
574 2020-05-29T23:23:13  *** dgenr8 has quit IRC
575 2020-05-29T23:23:31  *** dgenr8 has joined #bitcoin-core-dev
576 2020-05-29T23:33:26  *** justanotheruser has joined #bitcoin-core-dev
577 2020-05-29T23:36:35  *** proofofkeags has joined #bitcoin-core-dev
578 2020-05-29T23:39:21  *** bitdex has joined #bitcoin-core-dev
579 2020-05-29T23:40:54  *** proofofkeags has quit IRC
580 2020-05-29T23:42:38  *** mdunnio has joined #bitcoin-core-dev
581 2020-05-29T23:47:14  *** mdunnio has quit IRC
582 2020-05-29T23:57:58  *** pinheadm_ has joined #bitcoin-core-dev