1 2020-06-01T00:00:01  *** jtk has quit IRC
  2 2020-06-01T00:00:03  *** vasild has quit IRC
  3 2020-06-01T00:00:05  *** bitdex has quit IRC
  4 2020-06-01T00:00:26  *** vasild has joined #bitcoin-core-dev
  5 2020-06-01T00:01:54  *** bitdex has joined #bitcoin-core-dev
  6 2020-06-01T00:20:41  *** SRV_DW20 has joined #bitcoin-core-dev
  7 2020-06-01T00:23:23  *** promag has quit IRC
  8 2020-06-01T00:39:56  *** TheHoliestRoger has quit IRC
  9 2020-06-01T00:40:47  *** TheHoliestRoger has joined #bitcoin-core-dev
 10 2020-06-01T01:20:17  *** promag_ has quit IRC
 11 2020-06-01T01:22:56  *** proofofkeags has joined #bitcoin-core-dev
 12 2020-06-01T02:05:05  *** willcl_ark has quit IRC
 13 2020-06-01T02:07:26  *** AaronvanW has quit IRC
 14 2020-06-01T02:07:33  *** willcl_ark has joined #bitcoin-core-dev
 15 2020-06-01T02:08:16  *** troygiorshev has joined #bitcoin-core-dev
 16 2020-06-01T02:17:31  *** Highway61 has quit IRC
 17 2020-06-01T02:21:13  *** Processus42_ has joined #bitcoin-core-dev
 18 2020-06-01T02:23:58  *** promag has joined #bitcoin-core-dev
 19 2020-06-01T02:28:30  *** Processus42 has quit IRC
 20 2020-06-01T02:28:30  *** Lightsword has quit IRC
 21 2020-06-01T02:28:33  *** moneyball has quit IRC
 22 2020-06-01T02:28:33  *** hugohn has quit IRC
 23 2020-06-01T02:28:33  *** mol has quit IRC
 24 2020-06-01T02:29:07  *** promag has quit IRC
 25 2020-06-01T02:29:12  *** mol has joined #bitcoin-core-dev
 26 2020-06-01T02:31:10  *** Lightsword has joined #bitcoin-core-dev
 27 2020-06-01T02:31:30  *** mol_ has joined #bitcoin-core-dev
 28 2020-06-01T02:31:54  *** icota[m] has quit IRC
 29 2020-06-01T02:32:24  *** mrostecki[m] has quit IRC
 30 2020-06-01T02:32:28  *** TheFuzzStone[m] has quit IRC
 31 2020-06-01T02:34:36  *** mol has quit IRC
 32 2020-06-01T02:44:48  *** troygiorshev has quit IRC
 33 2020-06-01T02:45:48  *** jarthur has joined #bitcoin-core-dev
 34 2020-06-01T02:46:42  *** troygiorshev has joined #bitcoin-core-dev
 35 2020-06-01T02:48:46  *** molz_ has joined #bitcoin-core-dev
 36 2020-06-01T02:51:50  *** mol_ has quit IRC
 37 2020-06-01T02:53:01  *** mol_ has joined #bitcoin-core-dev
 38 2020-06-01T02:55:40  *** molz_ has quit IRC
 39 2020-06-01T02:59:17  *** surja795 has quit IRC
 40 2020-06-01T03:00:02  *** SRV_DW20 has quit IRC
 41 2020-06-01T03:03:02  *** icota[m] has joined #bitcoin-core-dev
 42 2020-06-01T03:04:50  *** AaronvanW has joined #bitcoin-core-dev
 43 2020-06-01T03:15:25  *** TheFuzzStone[m] has joined #bitcoin-core-dev
 44 2020-06-01T03:21:37  *** Kmos has joined #bitcoin-core-dev
 45 2020-06-01T03:22:01  *** Kmos is now known as Guest69505
 46 2020-06-01T03:24:09  *** Relis has quit IRC
 47 2020-06-01T03:24:16  *** Deacyde has quit IRC
 48 2020-06-01T03:31:47  *** Relis has joined #bitcoin-core-dev
 49 2020-06-01T03:43:37  *** troygiorshev has quit IRC
 50 2020-06-01T03:51:40  *** Relis has quit IRC
 51 2020-06-01T03:57:12  *** EagleTM has joined #bitcoin-core-dev
 52 2020-06-01T03:59:14  *** Eagle[TM] has quit IRC
 53 2020-06-01T04:00:15  *** harrigan has quit IRC
 54 2020-06-01T04:00:52  *** harrigan has joined #bitcoin-core-dev
 55 2020-06-01T04:01:03  *** bitdex has quit IRC
 56 2020-06-01T04:01:26  *** bitdex has joined #bitcoin-core-dev
 57 2020-06-01T04:03:49  *** Relis has joined #bitcoin-core-dev
 58 2020-06-01T04:13:25  *** go11111111111 has joined #bitcoin-core-dev
 59 2020-06-01T04:15:49  *** go1111111 has quit IRC
 60 2020-06-01T04:20:26  *** vasild_ has joined #bitcoin-core-dev
 61 2020-06-01T04:23:44  *** vasild has quit IRC
 62 2020-06-01T04:23:44  *** vasild_ is now known as vasild
 63 2020-06-01T04:29:43  *** morcos has quit IRC
 64 2020-06-01T04:29:44  *** bitcoin-git has joined #bitcoin-core-dev
 65 2020-06-01T04:29:44  <bitcoin-git> [bitcoin] ajtowns opened pull request #19130: doc: make it easier to work out size of bloom filter (master...202005-bloom-doc) https://github.com/bitcoin/bitcoin/pull/19130
 66 2020-06-01T04:29:45  *** bitcoin-git has left #bitcoin-core-dev
 67 2020-06-01T04:36:52  *** morcos has joined #bitcoin-core-dev
 68 2020-06-01T04:40:12  *** proofofkeags has quit IRC
 69 2020-06-01T04:41:49  *** dongcarl has quit IRC
 70 2020-06-01T04:45:30  *** Emcy has quit IRC
 71 2020-06-01T04:46:01  *** Emcy has joined #bitcoin-core-dev
 72 2020-06-01T04:53:37  *** Relis has quit IRC
 73 2020-06-01T04:53:51  *** justanotheruser has quit IRC
 74 2020-06-01T04:58:43  *** Relis has joined #bitcoin-core-dev
 75 2020-06-01T05:00:28  *** Relis has quit IRC
 76 2020-06-01T05:06:02  *** jarthur has quit IRC
 77 2020-06-01T05:15:46  *** proofofkeags has joined #bitcoin-core-dev
 78 2020-06-01T05:19:49  *** mol_ has quit IRC
 79 2020-06-01T05:22:57  *** mol has joined #bitcoin-core-dev
 80 2020-06-01T05:23:15  *** proofofkeags has quit IRC
 81 2020-06-01T05:23:32  *** marcoagner has joined #bitcoin-core-dev
 82 2020-06-01T05:25:12  *** justanotheruser has joined #bitcoin-core-dev
 83 2020-06-01T05:49:24  *** jarthur has joined #bitcoin-core-dev
 84 2020-06-01T05:52:13  *** proofofkeags has joined #bitcoin-core-dev
 85 2020-06-01T05:57:18  *** proofofkeags has quit IRC
 86 2020-06-01T06:00:02  *** Guest69505 has quit IRC
 87 2020-06-01T06:21:58  *** SummerNinja has joined #bitcoin-core-dev
 88 2020-06-01T06:29:23  *** sipa has quit IRC
 89 2020-06-01T06:29:54  *** lehnberg has joined #bitcoin-core-dev
 90 2020-06-01T06:32:39  *** sipa has joined #bitcoin-core-dev
 91 2020-06-01T06:40:23  *** mol_ has joined #bitcoin-core-dev
 92 2020-06-01T06:40:33  *** mol_ has quit IRC
 93 2020-06-01T06:40:56  *** mol_ has joined #bitcoin-core-dev
 94 2020-06-01T06:41:30  *** Guyver2 has joined #bitcoin-core-dev
 95 2020-06-01T06:42:26  *** mol has quit IRC
 96 2020-06-01T07:08:25  *** mol_ has quit IRC
 97 2020-06-01T07:31:03  *** jarthur has quit IRC
 98 2020-06-01T07:31:33  *** jarthur has joined #bitcoin-core-dev
 99 2020-06-01T07:39:37  *** bitcoin-git has joined #bitcoin-core-dev
100 2020-06-01T07:39:38  <bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/a65b55fa45d4...a8327fd71f5c
101 2020-06-01T07:39:39  <bitcoin-git> bitcoin/master fab893e MarcoFalke: doc: Fix unrelated typos reported by codespell
102 2020-06-01T07:39:39  <bitcoin-git> bitcoin/master 100000d MarcoFalke: doc: Add headings to CONTRIBUTING.md
103 2020-06-01T07:39:40  <bitcoin-git> bitcoin/master fae2fb2 MarcoFalke: doc: Expand section on Getting Started
104 2020-06-01T07:39:42  *** bitcoin-git has left #bitcoin-core-dev
105 2020-06-01T07:39:57  *** bitcoin-git has joined #bitcoin-core-dev
106 2020-06-01T07:39:57  <bitcoin-git> [bitcoin] fanquake merged pull request #19072: doc: Expand section on Getting Started (master...2005-docContribClarif) https://github.com/bitcoin/bitcoin/pull/19072
107 2020-06-01T07:39:58  *** bitcoin-git has left #bitcoin-core-dev
108 2020-06-01T07:53:14  *** proofofkeags has joined #bitcoin-core-dev
109 2020-06-01T07:57:49  *** proofofkeags has quit IRC
110 2020-06-01T08:07:38  *** bitcoin-git has joined #bitcoin-core-dev
111 2020-06-01T08:07:39  <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a8327fd71f5c...9bc7751cadbd
112 2020-06-01T08:07:39  <bitcoin-git> bitcoin/master fa86179 MarcoFalke: doc: Add release notes for 17219
113 2020-06-01T08:07:40  <bitcoin-git> bitcoin/master fac0ed1 MarcoFalke: doc: Sync "how to upgrade" with 0.20.0 release notes
114 2020-06-01T08:07:40  <bitcoin-git> bitcoin/master 9bc7751 fanquake: Merge #19115: doc: Add release notes for 17219
115 2020-06-01T08:07:42  *** bitcoin-git has left #bitcoin-core-dev
116 2020-06-01T08:07:58  *** bitcoin-git has joined #bitcoin-core-dev
117 2020-06-01T08:07:58  <bitcoin-git> [bitcoin] fanquake merged pull request #19115: doc: Add release notes for 17219 (master...2005-docRel) https://github.com/bitcoin/bitcoin/pull/19115
118 2020-06-01T08:07:59  *** bitcoin-git has left #bitcoin-core-dev
119 2020-06-01T08:25:01  *** promag has joined #bitcoin-core-dev
120 2020-06-01T08:25:58  *** bitcoin-git has joined #bitcoin-core-dev
121 2020-06-01T08:25:59  <bitcoin-git> [bitcoin] jonathanschoeller opened pull request #19131: refactor: Fix unreachable code in init arg checks (master...fix-Wunreachable-code-loop-increment) https://github.com/bitcoin/bitcoin/pull/19131
122 2020-06-01T08:26:04  *** bitcoin-git has left #bitcoin-core-dev
123 2020-06-01T08:27:03  *** dr-orlovsky has joined #bitcoin-core-dev
124 2020-06-01T08:29:11  *** promag has quit IRC
125 2020-06-01T08:31:44  *** Processus42_ is now known as Processus42
126 2020-06-01T08:31:57  *** nullptr_ has quit IRC
127 2020-06-01T08:34:46  *** nullptr| has joined #bitcoin-core-dev
128 2020-06-01T08:49:13  *** jarthur_ has joined #bitcoin-core-dev
129 2020-06-01T08:49:45  *** dr-orlovsky has quit IRC
130 2020-06-01T08:50:53  *** jarthur_ has quit IRC
131 2020-06-01T08:51:18  *** jarthur has quit IRC
132 2020-06-01T08:59:53  *** Yukinochan has joined #bitcoin-core-dev
133 2020-06-01T09:00:02  *** SummerNinja has quit IRC
134 2020-06-01T09:03:07  *** timothy has joined #bitcoin-core-dev
135 2020-06-01T09:09:03  *** timothy has quit IRC
136 2020-06-01T09:10:54  *** mol has joined #bitcoin-core-dev
137 2020-06-01T09:15:40  *** Pavlenex has joined #bitcoin-core-dev
138 2020-06-01T09:18:43  *** timothy has joined #bitcoin-core-dev
139 2020-06-01T09:22:03  *** jeremyb has joined #bitcoin-core-dev
140 2020-06-01T09:22:27  *** jeremyb is now known as Guest23530
141 2020-06-01T09:23:01  *** wullon5 has joined #bitcoin-core-dev
142 2020-06-01T09:25:23  *** Pavlenex has quit IRC
143 2020-06-01T09:25:43  *** Pavlenex has joined #bitcoin-core-dev
144 2020-06-01T09:46:56  *** Pavlenex has quit IRC
145 2020-06-01T09:50:30  *** dr-orlov1ky has joined #bitcoin-core-dev
146 2020-06-01T09:54:15  *** proofofkeags has joined #bitcoin-core-dev
147 2020-06-01T09:55:40  *** timothy has quit IRC
148 2020-06-01T09:58:39  *** proofofkeags has quit IRC
149 2020-06-01T10:01:25  *** Kiminuo has joined #bitcoin-core-dev
150 2020-06-01T10:03:29  *** Matt5Crooks has joined #bitcoin-core-dev
151 2020-06-01T10:05:06  *** promag has joined #bitcoin-core-dev
152 2020-06-01T10:08:38  *** Matt5Crooks has quit IRC
153 2020-06-01T10:09:38  *** promag has quit IRC
154 2020-06-01T10:12:38  <fanquake> practicalswift asked for #18288 to be their high-prio PR; so I've added it.
155 2020-06-01T10:12:40  <gribble> https://github.com/bitcoin/bitcoin/issues/18288 | build: Add MemorySanitizer (MSan) in Travis to detect use of uninitialized memory by practicalswift · Pull Request #18288 · bitcoin/bitcoin · GitHub
156 2020-06-01T10:14:11  *** surja795 has joined #bitcoin-core-dev
157 2020-06-01T10:18:42  *** surja795 has quit IRC
158 2020-06-01T11:00:44  *** proofofkeags has joined #bitcoin-core-dev
159 2020-06-01T11:05:26  *** cltrbreak_MAD2 has quit IRC
160 2020-06-01T11:05:52  *** cltrbreak_MAD2 has joined #bitcoin-core-dev
161 2020-06-01T11:32:48  <Kiminuo> Hi, can I make my PR https://github.com/bitcoin/bitcoin/pull/18210 more attractive for review somehow? I have just rewritten the first post to articulate more clearly what the PR does.
162 2020-06-01T11:45:01  *** Pavlenex has joined #bitcoin-core-dev
163 2020-06-01T11:46:35  *** Pavlenex has quit IRC
164 2020-06-01T11:49:24  <jonatack> Kiminuo: rebasing promptly helps, and giving review is a good way to (a) to see the review bottleneck and (b) receive review back
165 2020-06-01T11:50:32  <jonatack> Kiminuo: because there are more people who open PRs than people who review them
166 2020-06-01T11:51:47  *** Yukinochan has quit IRC
167 2020-06-01T11:58:11  *** shesek has quit IRC
168 2020-06-01T12:00:02  *** Guest23530 has quit IRC
169 2020-06-01T12:01:14  *** surja795 has joined #bitcoin-core-dev
170 2020-06-01T12:04:05  *** proofofkeags has quit IRC
171 2020-06-01T12:05:48  *** surja795 has quit IRC
172 2020-06-01T12:15:43  *** surja795 has joined #bitcoin-core-dev
173 2020-06-01T12:16:39  *** Relis has joined #bitcoin-core-dev
174 2020-06-01T12:22:09  *** defnordic has joined #bitcoin-core-dev
175 2020-06-01T12:24:37  *** Relis has quit IRC
176 2020-06-01T12:28:19  *** bitcoin-git has joined #bitcoin-core-dev
177 2020-06-01T12:28:20  <bitcoin-git> [bitcoin] vasild opened pull request #19132: qt: lock cs_main, m_cached_tip_mutex in that order (master...lock_order_m_cached_tip_mutex) https://github.com/bitcoin/bitcoin/pull/19132
178 2020-06-01T12:28:21  *** bitcoin-git has left #bitcoin-core-dev
179 2020-06-01T12:33:06  *** bitcoin-git has joined #bitcoin-core-dev
180 2020-06-01T12:33:06  <bitcoin-git> [bitcoin] jonatack opened pull request #19133: rpc, cli, test: add bitcoin-cli -generate command (master...cli-generate-command) https://github.com/bitcoin/bitcoin/pull/19133
181 2020-06-01T12:33:07  *** bitcoin-git has left #bitcoin-core-dev
182 2020-06-01T12:33:50  *** Highway61 has joined #bitcoin-core-dev
183 2020-06-01T12:37:37  *** troygiorshev has joined #bitcoin-core-dev
184 2020-06-01T12:37:43  *** Evel-Knievel has quit IRC
185 2020-06-01T12:40:14  <vasild> Maybe #19132 should be included in the coming release. It fixes a regression since 0.19.
186 2020-06-01T12:40:16  <gribble> https://github.com/bitcoin/bitcoin/issues/19132 | qt: lock cs_main, m_cached_tip_mutex in that order by vasild · Pull Request #19132 · bitcoin/bitcoin · GitHub
187 2020-06-01T12:42:04  <vasild> Either a deadlock (infinite hang) or a crash if the (possible) deadlock is detected. I am not sure if the deadlock detecting code is always enabled - in release builds and for all compilers?
188 2020-06-01T12:42:59  <fanquake> vasild: how is it an issue since 0.19 if the PR that supposedly introduced it (17993), was only merged 3 days ago?
189 2020-06-01T12:43:28  <vasild> well, the problem does not exist in 0.19
190 2020-06-01T12:43:59  <fanquake> Right. So the issue only currently exists in master?
191 2020-06-01T12:44:06  <vasild> yes
192 2020-06-01T12:44:09  <fanquake> If so, there is no need to backport anything.
193 2020-06-01T12:44:46  <vasild> by "regression since 0.19" I mean that the problem does not exist in 0.19 but would exist in 0.20 (if released without a fix)
194 2020-06-01T12:45:01  <vasild> right, I think no need to backport anything
195 2020-06-01T12:45:14  <fanquake> I don't see how it can exist in 0.20 if it's only been merged into master
196 2020-06-01T12:45:31  <fanquake> It will be fixed in master, and should hopefully never exist in any release.
197 2020-06-01T12:47:52  <vasild> It _would_ exist in 0.20 if 0.20 is released without a fix.
198 2020-06-01T12:48:54  <vasild> All I am saying is that this is a new problem that IMO should be fixed before the release. If the problem existed in 0.19 (an old one), maybe it would have been less important to get the fix into 0.20.
199 2020-06-01T12:50:08  <fanquake> vasild: the 0.20 release is currently based on the 0.20. branch: https://github.com/bitcoin/bitcoin/tree/0.20 (not master), so if the PR introduced the issue (17993) has. only been merged into master, then there is no issue with 0.20.
200 2020-06-01T12:50:18  <Kiminuo> jonatack, My PR is buried at this point, so I don't expect anyone to find it really..
201 2020-06-01T12:51:15  <Kiminuo> and rebasing also does not make too much sense because it only claims valuable resources for other PRs
202 2020-06-01T12:51:33  <Kiminuo> (I don't modify cpp code)
203 2020-06-01T12:52:23  <vasild> fanquake: oh, this is my confusion - I assumed that 0.20 is yet to be created from master, sorry. So 0.20 does not have the bug, meaning it should only be fixed before 0.21! :)
204 2020-06-01T12:53:43  *** Pavlenex has joined #bitcoin-core-dev
205 2020-06-01T12:53:49  <fanquake> vasild: 👍
206 2020-06-01T13:04:14  <vasild> What about attaching a "lock order" number to each mutex (hardcoded in the source code) and enforce that locking always happens in ascending order?
207 2020-06-01T13:09:02  *** Pavlenex has quit IRC
208 2020-06-01T13:09:17  *** timothy has joined #bitcoin-core-dev
209 2020-06-01T13:11:02  *** Relis has joined #bitcoin-core-dev
210 2020-06-01T13:12:44  *** troygiorshev has quit IRC
211 2020-06-01T13:13:42  *** troygiorshev has joined #bitcoin-core-dev
212 2020-06-01T13:15:26  *** Evel-Knievel has joined #bitcoin-core-dev
213 2020-06-01T13:19:44  *** surja795 has quit IRC
214 2020-06-01T13:27:35  *** Pavlenex has joined #bitcoin-core-dev
215 2020-06-01T13:55:01  *** hebasto has quit IRC
216 2020-06-01T13:59:25  *** hebasto has joined #bitcoin-core-dev
217 2020-06-01T14:00:42  <hebasto> vasild: maybe some of thread safety annotations could be useful?
218 2020-06-01T14:04:40  <vasild> hebasto: you mean for detecting cycles in the waits-for DAG? That would be excellent as I think our deadlock detection mechanism has a deficiency. https://github.com/google/sanitizers/wiki/ThreadSanitizerDeadlockDetector
219 2020-06-01T14:04:51  <vasild> is relevant
220 2020-06-01T14:06:26  <hebasto> what a deficiency?
221 2020-06-01T14:09:05  <vasild> hebasto: https://paste.gg/p/anonymous/4f3dd080b5ef4a09a0cba6a6eaffc6a6 -- if somebody can confirm that this is indeed a problem and I am not delusional, then I will open a bug report about it.
222 2020-06-01T14:09:42  <vasild> The push_lock() function is in src/sync.cpp
223 2020-06-01T14:18:10  <hebasto> vasild: does TSan detect such deadlock possibilities?
224 2020-06-01T14:23:38  *** Kiminuo has quit IRC
225 2020-06-01T14:31:42  <vasild> no idea
226 2020-06-01T14:35:22  *** jb55 has quit IRC
227 2020-06-01T14:35:22  *** ghost43 has quit IRC
228 2020-06-01T14:35:40  *** ghost43 has joined #bitcoin-core-dev
229 2020-06-01T14:35:55  *** jb55 has joined #bitcoin-core-dev
230 2020-06-01T14:50:56  *** bitcoin-git has joined #bitcoin-core-dev
231 2020-06-01T14:50:57  <bitcoin-git> [bitcoin] dboures opened pull request #19134: test: Replace global wait_until with mininode.wait_until (master...master) https://github.com/bitcoin/bitcoin/pull/19134
232 2020-06-01T14:50:57  *** bitcoin-git has left #bitcoin-core-dev
233 2020-06-01T14:54:03  <vasild> hebasto: https://clang.llvm.org/docs/ThreadSafetyAnalysis.html#acquired-before-acquired-after is promising, but it is only limited to things that can be detected at compile time.
234 2020-06-01T14:54:17  *** sdaftuar has quit IRC
235 2020-06-01T14:54:39  *** sdaftuar has joined #bitcoin-core-dev
236 2020-06-01T14:54:59  <hebasto> vasild: https://clang.llvm.org/docs/ThreadSafetyAnalysis.html#acquired-before-and-acquired-after-are-currently-unimplemented
237 2020-06-01T14:55:00  <vasild> I just tried the following on master (which has #19132):
238 2020-06-01T14:55:02  <gribble> https://github.com/bitcoin/bitcoin/issues/19132 | qt: lock cs_main, m_cached_tip_mutex in that order by vasild · Pull Request #19132 · bitcoin/bitcoin · GitHub
239 2020-06-01T14:55:03  <vasild> -    Mutex m_cached_tip_mutex;
240 2020-06-01T14:55:03  <vasild> +    Mutex m_cached_tip_mutex ACQUIRED_AFTER(cs_main);
241 2020-06-01T14:55:50  <vasild> 1. it compiled and 2. it abort()ed at runtime, detecting the deadlock from inside our push_lock()
242 2020-06-01T14:56:37  <vasild> oh, are currently unimplemented :(
243 2020-06-01T14:57:19  <vasild> but even if they are implemented I doubt it would be possible to detect complicated lock order violations at compile time
244 2020-06-01T15:00:02  *** defnordic has quit IRC
245 2020-06-01T15:02:24  *** troygiorshev has quit IRC
246 2020-06-01T15:03:16  *** troygiorshev has joined #bitcoin-core-dev
247 2020-06-01T15:19:08  *** Pavlenex has quit IRC
248 2020-06-01T15:22:54  *** Pavlenex has joined #bitcoin-core-dev
249 2020-06-01T15:23:18  *** Talkless has joined #bitcoin-core-dev
250 2020-06-01T15:24:40  *** Pavlenex has quit IRC
251 2020-06-01T15:25:30  *** mol_ has joined #bitcoin-core-dev
252 2020-06-01T15:29:02  *** mol has quit IRC
253 2020-06-01T15:37:14  *** mol_ has quit IRC
254 2020-06-01T15:44:50  *** hugohn has joined #bitcoin-core-dev
255 2020-06-01T15:44:51  *** moneyball has joined #bitcoin-core-dev
256 2020-06-01T15:50:46  *** Talkless has quit IRC
257 2020-06-01T15:56:46  *** kexkey has joined #bitcoin-core-dev
258 2020-06-01T16:00:18  *** Talkless has joined #bitcoin-core-dev
259 2020-06-01T16:01:33  *** timothy has quit IRC
260 2020-06-01T16:01:50  *** mol has joined #bitcoin-core-dev
261 2020-06-01T16:04:07  *** justanotheruser has quit IRC
262 2020-06-01T16:10:20  *** Emcy has quit IRC
263 2020-06-01T16:10:57  *** Emcy has joined #bitcoin-core-dev
264 2020-06-01T16:12:45  *** ghost43 has quit IRC
265 2020-06-01T16:13:12  *** ghost43 has joined #bitcoin-core-dev
266 2020-06-01T16:16:05  *** joerodgers has joined #bitcoin-core-dev
267 2020-06-01T16:19:37  *** proofofkeags has joined #bitcoin-core-dev
268 2020-06-01T16:19:56  *** justanotheruser has joined #bitcoin-core-dev
269 2020-06-01T16:23:23  *** vasild has quit IRC
270 2020-06-01T16:25:22  *** vasild has joined #bitcoin-core-dev
271 2020-06-01T16:29:14  *** troygiorshev has quit IRC
272 2020-06-01T16:33:09  *** troygiorshev has joined #bitcoin-core-dev
273 2020-06-01T17:01:14  *** troygiorshev has quit IRC
274 2020-06-01T17:02:15  *** Bille has joined #bitcoin-core-dev
275 2020-06-01T17:06:43  *** mrostecki has quit IRC
276 2020-06-01T17:08:51  *** troygiorshev has joined #bitcoin-core-dev
277 2020-06-01T17:13:22  *** mrostecki has joined #bitcoin-core-dev
278 2020-06-01T17:14:45  *** Highway61 has quit IRC
279 2020-06-01T17:20:05  *** ghost43 has quit IRC
280 2020-06-01T17:20:25  *** ghost43 has joined #bitcoin-core-dev
281 2020-06-01T17:37:23  *** jarthur has joined #bitcoin-core-dev
282 2020-06-01T17:43:08  *** Highway61 has joined #bitcoin-core-dev
283 2020-06-01T17:49:38  *** bitcoin-git has joined #bitcoin-core-dev
284 2020-06-01T17:49:38  <bitcoin-git> [bitcoin] andersonbr opened pull request #19135: Update bitcoin_pt_BR.ts (master...andersonbr-patch-1) https://github.com/bitcoin/bitcoin/pull/19135
285 2020-06-01T17:49:39  *** bitcoin-git has left #bitcoin-core-dev
286 2020-06-01T17:57:52  *** shesek has joined #bitcoin-core-dev
287 2020-06-01T17:57:52  *** shesek has joined #bitcoin-core-dev
288 2020-06-01T18:00:01  *** Bille has quit IRC
289 2020-06-01T18:13:04  *** Kiminuo has joined #bitcoin-core-dev
290 2020-06-01T18:14:05  *** lehnberg has quit IRC
291 2020-06-01T18:21:58  *** bcremer has joined #bitcoin-core-dev
292 2020-06-01T18:25:31  *** mol has quit IRC
293 2020-06-01T18:35:51  *** TheFuzzStone[m] has quit IRC
294 2020-06-01T18:38:05  *** mol has joined #bitcoin-core-dev
295 2020-06-01T18:38:51  *** Talkless has quit IRC
296 2020-06-01T18:42:00  *** icota[m] has quit IRC
297 2020-06-01T18:44:14  *** TheFuzzStone[m] has joined #bitcoin-core-dev
298 2020-06-01T18:45:20  *** TheFuzzStone[m] has quit IRC
299 2020-06-01T19:08:54  *** mol_ has joined #bitcoin-core-dev
300 2020-06-01T19:11:56  *** mol has quit IRC
301 2020-06-01T19:13:32  *** Highway61 has quit IRC
302 2020-06-01T19:15:59  *** owowo has quit IRC
303 2020-06-01T19:16:58  *** icota[m] has joined #bitcoin-core-dev
304 2020-06-01T19:17:49  *** Pavlenex has joined #bitcoin-core-dev
305 2020-06-01T19:21:10  *** owowo has joined #bitcoin-core-dev
306 2020-06-01T19:23:49  *** TheFuzzStone[m] has joined #bitcoin-core-dev
307 2020-06-01T19:23:50  *** mrostecki[m] has joined #bitcoin-core-dev
308 2020-06-01T19:33:08  *** nullptr| has quit IRC
309 2020-06-01T19:34:40  *** proofofkeags has quit IRC
310 2020-06-01T19:34:51  *** dr-orlov1ky has quit IRC
311 2020-06-01T19:34:54  *** nullptr| has joined #bitcoin-core-dev
312 2020-06-01T19:35:07  *** proofofkeags has joined #bitcoin-core-dev
313 2020-06-01T19:39:33  *** proofofkeags has quit IRC
314 2020-06-01T19:46:13  *** lehnberg has joined #bitcoin-core-dev
315 2020-06-01T19:46:36  *** lehnberg has quit IRC
316 2020-06-01T19:48:43  *** jorijn has quit IRC
317 2020-06-01T19:49:09  *** jorijn has joined #bitcoin-core-dev
318 2020-06-01T19:49:53  *** Highway61 has joined #bitcoin-core-dev
319 2020-06-01T20:09:14  <gwillen> MarcoFalke: I'm curious what inspired you to fix all the codespell typos a few days ago -- I was never sure if those only show up for me, or for mac users, or what
320 2020-06-01T20:09:27  <gwillen> I always assumed they must not be in whatever dictionary Travis uses, or something
321 2020-06-01T20:18:34  *** bitcoin-git has joined #bitcoin-core-dev
322 2020-06-01T20:18:35  <bitcoin-git> [bitcoin] achow101 opened pull request #19136: wallet: add dumpwalletdescriptor RPC (master...export-descriptor) https://github.com/bitcoin/bitcoin/pull/19136
323 2020-06-01T20:18:36  *** bitcoin-git has left #bitcoin-core-dev
324 2020-06-01T20:22:24  *** Kiminuo has quit IRC
325 2020-06-01T20:24:23  *** proofofkeags has joined #bitcoin-core-dev
326 2020-06-01T20:48:56  *** marcoagner has quit IRC
327 2020-06-01T20:58:40  *** Eulah89Stracke has joined #bitcoin-core-dev
328 2020-06-01T21:00:03  *** bcremer has quit IRC
329 2020-06-01T21:00:17  *** surja795 has joined #bitcoin-core-dev
330 2020-06-01T21:10:21  *** owowo has quit IRC
331 2020-06-01T21:10:24  *** Eulah89Stracke has quit IRC
332 2020-06-01T21:12:48  *** Guyver2 has quit IRC
333 2020-06-01T21:15:23  *** owowo has joined #bitcoin-core-dev
334 2020-06-01T21:22:13  *** chrippa has joined #bitcoin-core-dev
335 2020-06-01T21:24:14  *** owowo has quit IRC
336 2020-06-01T21:29:24  *** owowo has joined #bitcoin-core-dev
337 2020-06-01T21:36:17  *** EagleTM has quit IRC
338 2020-06-01T21:45:03  *** surja795 has quit IRC
339 2020-06-01T21:45:41  *** dfmb_ has joined #bitcoin-core-dev
340 2020-06-01T21:48:01  *** dfmb_ has quit IRC
341 2020-06-01T21:49:52  *** surja795 has joined #bitcoin-core-dev
342 2020-06-01T21:51:25  *** troygiorshev has quit IRC
343 2020-06-01T21:54:26  *** surja795 has quit IRC
344 2020-06-01T22:17:34  *** surja795 has joined #bitcoin-core-dev
345 2020-06-01T22:18:11  *** promag has joined #bitcoin-core-dev
346 2020-06-01T22:20:09  *** surja795 has quit IRC
347 2020-06-01T22:25:21  *** surja795 has joined #bitcoin-core-dev
348 2020-06-01T22:27:45  *** kexkey has quit IRC
349 2020-06-01T22:29:33  *** surja795 has quit IRC
350 2020-06-01T22:30:09  *** kexkey has joined #bitcoin-core-dev
351 2020-06-01T22:30:23  *** bitcoin-git has joined #bitcoin-core-dev
352 2020-06-01T22:30:24  <bitcoin-git> [bitcoin] achow101 opened pull request #19137: wallettool: Add dump and createfromdump commands (master...dumpwalletrecords) https://github.com/bitcoin/bitcoin/pull/19137
353 2020-06-01T22:30:25  *** bitcoin-git has left #bitcoin-core-dev
354 2020-06-01T22:31:30  *** troygiorshev has joined #bitcoin-core-dev
355 2020-06-01T22:36:20  *** kexkey has quit IRC
356 2020-06-01T22:56:11  *** troygiorshev has quit IRC
357 2020-06-01T22:59:33  *** EagleTM has joined #bitcoin-core-dev
358 2020-06-01T23:02:57  *** filchef has joined #bitcoin-core-dev
359 2020-06-01T23:02:59  <promag> are there real benefits of rpc batching?
360 2020-06-01T23:03:52  *** filchef has quit IRC
361 2020-06-01T23:04:35  *** bitcoin-git has joined #bitcoin-core-dev
362 2020-06-01T23:04:35  <bitcoin-git> [bitcoin] fanquake closed pull request #19135: qt: Update bitcoin_pt_BR.ts (master...andersonbr-patch-1) https://github.com/bitcoin/bitcoin/pull/19135
363 2020-06-01T23:04:36  *** bitcoin-git has left #bitcoin-core-dev
364 2020-06-01T23:21:07  *** Cory has quit IRC
365 2020-06-01T23:21:16  <jarthur> promag: definitely, at least vs single RPC per HTTP request. A new HTTP request is expensive. From dynamic languages that have an expensive stack like Python and JavaScript, not having to go up and down the stack as much for multiple sends carries a performance benefit. JSON-RPC Pipelining is better on memory usage than batching, just harder to program support for.
366 2020-06-01T23:22:23  <promag> at least vs single RPC per HTTP request <- yeah I don't mind in this case
367 2020-06-01T23:24:06  <promag> so in the case the connection is established, only saving is on http protocol right?
368 2020-06-01T23:25:13  <promag> because for the server batching is actually worse, at least memory wise
369 2020-06-01T23:26:20  <promag> s/mind in /mean/
370 2020-06-01T23:26:39  <aj> sipa: "after how much time are we okay with attackers knowing everything that was in the mempool at the time?" -- if 99.9% of tx's are relayed to 99.9% of nodes within X seconds, then 2*X seconds? (fsv of 2 and 99.9%)
371 2020-06-01T23:27:11  <sipa> aj: maybe that's even to strong a question
372 2020-06-01T23:27:43  <sipa> "after how much time beyond the time it takes to send an INV are we ok with attackers knowing our mempool"
373 2020-06-01T23:28:10  <sipa> if the answer is: whenever we send an INV, attackers can know our entire mempool before that point... it's very easy
374 2020-06-01T23:28:41  <jarthur> promag: right, assuming the server supports pipelining multiple requests on the same connection (like JSON-RPC 2.0 TCP Transport w/ JSON Splitting, Stratum Mining TCP Transport, Stratum Wallet TCP Transport etc), I don't see an advantage batching would have.
375 2020-06-01T23:29:30  *** Cory has joined #bitcoin-core-dev
376 2020-06-01T23:32:10  <sipa> aj: if so, we'd just keep track of the last timestamp when we sent out a tx INV, and respond to requests for anything that was in the mempool before that point
377 2020-06-01T23:32:34  <sipa> we'd still need a relay pool + bloom filter for dealing with things not in the mempool
378 2020-06-01T23:32:44  <aj> sipa: "whenever we send an INV, an attacker can know the presence or absence of every tx that entered our mempool prior to the latest tx in that INV" maybe. i don't see a lot of benefit to doing much else, since an attacker could just make more connections to get around it?
379 2020-06-01T23:33:03  <sipa> but the latter can go away once fast NOTFOUND handling is widespread on the network
380 2020-06-01T23:38:02  <aj> sipa: is this protecting against anything other than tracing transaction sources?
381 2020-06-01T23:38:13  <sipa> i don't think so
382 2020-06-01T23:42:42  *** justanotheruser has quit IRC
383 2020-06-01T23:51:03  <sipa> aj: here is a downside: for a very new connection, by observing the difference between what we actually announce to a peer, and what they can request (after our first INV)... they get an exact point distinguishing transaction we learned right before and right after the connection was created
384 2020-06-01T23:54:14  <aj> sipa: ha. could hack around that by not sending the first INV worth of tx's to them?
385 2020-06-01T23:55:43  <sipa> does that help?
386 2020-06-01T23:56:02  <sipa> right, it does a bit
387 2020-06-01T23:56:57  <aj> sipa: it makes it no more leaky than anytime you get an INV after the two prior INVs had less than 100 txids, i think?
388 2020-06-01T23:57:29  <aj> wish it was easier to keep all the relay related rules in my head at the same time
389 2020-06-01T23:59:16  *** justanotheruser has joined #bitcoin-core-dev