1 2020-06-02T00:00:03  *** chrippa has quit IRC
  2 2020-06-02T00:00:32  *** jb55 has quit IRC
  3 2020-06-02T00:01:33  *** jb55 has joined #bitcoin-core-dev
  4 2020-06-02T00:04:25  *** proofofkeags has quit IRC
  5 2020-06-02T00:04:34  <sipa> where does the number 100 come from?
  6 2020-06-02T00:04:52  *** proofofkeags has joined #bitcoin-core-dev
  7 2020-06-02T00:09:18  *** proofofkeags has quit IRC
  8 2020-06-02T00:09:51  *** surja795 has joined #bitcoin-core-dev
  9 2020-06-02T00:12:06  <aj> sipa: sorry 35 not 100; if you get less than that in a single message, it means you've emptied setInventoryTxToSend
 10 2020-06-02T00:13:32  <sipa> right
 11 2020-06-02T00:16:15  <aj> sipa: which brings you back to knowing about a timepoint, but the timepoint's chosen by the victim's poisson schedule, not the attacker's choice of when to connect?
 12 2020-06-02T00:16:15  *** surja795 has quit IRC
 13 2020-06-02T00:16:49  *** surja795 has joined #bitcoin-core-dev
 14 2020-06-02T00:20:09  <phantomcircuit> promag, it depends on which rpc calls you're making
 15 2020-06-02T00:20:31  <promag> how so?
 16 2020-06-02T00:21:04  <phantomcircuit> if you're making lots of fast calls it will matter, if you make a few slow calls you won't even notice
 17 2020-06-02T00:22:34  *** Darki has joined #bitcoin-core-dev
 18 2020-06-02T00:27:13  *** troygiorshev has joined #bitcoin-core-dev
 19 2020-06-02T00:32:02  *** troygiorshev has quit IRC
 20 2020-06-02T00:35:13  <promag> phantomcircuit: #5050
 21 2020-06-02T00:35:15  <gribble> https://github.com/bitcoin/bitcoin/issues/5050 | contrib: Use batched JSON-RPC in linearize.py for speedup by laanwj · Pull Request #5050 · bitcoin/bitcoin · GitHub
 22 2020-06-02T00:41:23  <sipa> aj: it feels fragile to rely on that
 23 2020-06-02T00:42:11  <phantomcircuit> promag, yeah the getblockhash rpc is probably the biggest win for batching, ages ago i implemented a getblockhashes that took a range but it was too craptastic for a pr
 24 2020-06-02T00:45:15  <aj> sipa: yes, it does
 25 2020-06-02T00:45:24  <promag> phantomcircuit: right
 26 2020-06-02T00:49:43  <sipa> aj: so WDYT about relay pool 2 minutes, bloom filter per peer for last (whatever can be relayed in 2 minutes) transactions, things can be requested if they're in the bloom filter OR in mempool and older than 2 minutes OR older than the last BIP35 response; BIP35 responses don't go into the bloom filter
 27 2020-06-02T00:51:17  <aj> oh, i see, bitcoin does 7tx/second because that's 420tx/minute -- blazing fast
 28 2020-06-02T00:51:44  <sipa> ?
 29 2020-06-02T00:52:00  <aj> "420 blaze it" nevermind
 30 2020-06-02T00:52:16  <phantomcircuit> ok so now i have a keypool problem, i've generated a list of scripPubKeys and can get notified when the keypool changes... but this is in a tight loop and im not sure if the NotifyCanGetAddressesChanged thing is guaranteed to run before anything else
 31 2020-06-02T00:52:26  <phantomcircuit> also it's kind of ugly to use a callback here
 32 2020-06-02T00:52:47  <aj> sipa: why not do bip35 via bloom as well?
 33 2020-06-02T00:53:06  <sipa> aj: it would easily overflow the filter
 34 2020-06-02T00:53:56  <aj> right, right
 35 2020-06-02T00:54:22  <sipa> unless the filter is made much larger
 36 2020-06-02T00:56:26  <aj> yeah, i was thinking of making it so bip35 wouldn't let you see stuff that hadn't made it into the bloom filter, but seems too complicated, esp if we think bip35 is only for trusted-ish peers
 37 2020-06-02T00:56:50  <sipa> you have to explicitly enable bip37, or whitelist the peer
 38 2020-06-02T00:56:52  *** promag has quit IRC
 39 2020-06-02T01:00:35  <aj> so "whatever can be relayed in 2 minutes" ~= 840 tx for inbound, 2110 tx for outbound? i think it'd make sense to be "bloom filter (for whatever can be relayed in 1.5*X minutes) OR in the mempool and older than X minutes" so there's no weird, exploitable gaps?
 40 2020-06-02T01:06:44  <sipa> hmm, what kind of gaps?
 41 2020-06-02T01:07:27  <sipa> the rolling bloom filter is already maintaining between 1.5*x and x entries
 42 2020-06-02T01:07:59  <aj> sipa: as in txs drop out of the bloom filter in <2m, because your poisson timing goes really quick by random chance?
 43 2020-06-02T01:08:57  <aj> i guess there's 24 intervals in 2minutes, so 1.5x is probably vast overkill
 44 2020-06-02T01:09:03  <sipa> ah!
 45 2020-06-02T01:09:13  <sipa> this calls for some statistics
 46 2020-06-02T01:09:47  *** AaronvanW has quit IRC
 47 2020-06-02T01:09:54  <aj> (when you said "ah!" i thought, "oh no, a spider??", now i wish it were just that)
 48 2020-06-02T01:12:37  *** Morton29Crooks has joined #bitcoin-core-dev
 49 2020-06-02T01:16:08  *** EagleTM has quit IRC
 50 2020-06-02T01:17:01  <sipa> so this is a poisson distribution with lambda=24 (we expect 24 inv broadcasts in 2 minutes)... there could be up to 50 broadcasts however in 2 minutes, with probability up to 99.9999%
 51 2020-06-02T01:18:28  <aj> lambda=60 for outbounds, i guess?
 52 2020-06-02T01:18:50  *** joerodgers has quit IRC
 53 2020-06-02T01:19:02  <sipa> yup, and there we need to account for up to 95 broadcasts in 2 minutes
 54 2020-06-02T01:19:11  <sipa> (to have 99.9999% probability)
 55 2020-06-02T01:23:29  <aj> means about 1800 and 3500 txs for 9.7kB and 19kB filters?
 56 2020-06-02T01:24:44  *** troygiorshev has joined #bitcoin-core-dev
 57 2020-06-02T01:24:44  *** Morton29Crooks has quit IRC
 58 2020-06-02T01:25:24  <sipa> more accurate numbers: 51 and 100
 59 2020-06-02T01:27:41  <midnight> har har "blazing fast"
 60 2020-06-02T01:28:40  *** AaronvanW has joined #bitcoin-core-dev
 61 2020-06-02T01:33:14  <aj> sipa: 52 would stay just under 10kB; 105 would be just under 20kB. so about 1.3M in total with max peers?
 62 2020-06-02T01:35:00  <sipa> i think anything in the order of 10s of kilobytes per peer is negligable
 63 2020-06-02T01:39:44  <aj> yeah
 64 2020-06-02T01:41:28  <sipa> could just go for an even 3500 sized filter for everyone
 65 2020-06-02T02:44:57  *** mol has joined #bitcoin-core-dev
 66 2020-06-02T02:46:07  *** troygiorshev has quit IRC
 67 2020-06-02T02:47:27  *** mol_ has quit IRC
 68 2020-06-02T03:00:02  *** Darki has quit IRC
 69 2020-06-02T03:01:14  *** Highway61 has quit IRC
 70 2020-06-02T03:03:11  *** mol_ has joined #bitcoin-core-dev
 71 2020-06-02T03:04:09  *** mol has quit IRC
 72 2020-06-02T03:04:46  *** surja795 has quit IRC
 73 2020-06-02T03:09:25  *** troygiorshev has joined #bitcoin-core-dev
 74 2020-06-02T03:10:37  *** mol_ has quit IRC
 75 2020-06-02T03:15:08  *** troygiorshev has quit IRC
 76 2020-06-02T03:23:56  *** mol has joined #bitcoin-core-dev
 77 2020-06-02T03:33:18  *** mol has quit IRC
 78 2020-06-02T03:37:54  *** mol has joined #bitcoin-core-dev
 79 2020-06-02T03:51:31  *** jarthur has quit IRC
 80 2020-06-02T03:56:21  *** ajbiz11 has joined #bitcoin-core-dev
 81 2020-06-02T04:08:45  *** tylerdmace has quit IRC
 82 2020-06-02T04:23:23  *** vasild has quit IRC
 83 2020-06-02T04:24:46  *** Deacyde has joined #bitcoin-core-dev
 84 2020-06-02T04:25:19  *** vasild has joined #bitcoin-core-dev
 85 2020-06-02T04:27:58  *** mol_ has joined #bitcoin-core-dev
 86 2020-06-02T04:31:15  *** mol has quit IRC
 87 2020-06-02T04:50:30  *** bitcoin-git has joined #bitcoin-core-dev
 88 2020-06-02T04:50:30  <bitcoin-git> [bitcoin] laanwj opened pull request #19138: doc: Merge 0.20.0 release notes from wiki (0.20...2020_06_0.20_relnot) https://github.com/bitcoin/bitcoin/pull/19138
 89 2020-06-02T04:50:41  *** bitcoin-git has left #bitcoin-core-dev
 90 2020-06-02T05:11:07  *** IGHOR has quit IRC
 91 2020-06-02T05:14:58  *** IGHOR has joined #bitcoin-core-dev
 92 2020-06-02T05:24:17  *** Guest13 has joined #bitcoin-core-dev
 93 2020-06-02T05:27:43  *** Guest13 has left #bitcoin-core-dev
 94 2020-06-02T05:30:18  *** marcoagner has joined #bitcoin-core-dev
 95 2020-06-02T05:44:41  *** achow101 has quit IRC
 96 2020-06-02T05:47:57  <hebasto> MarcoFalke: how to preserve travis log with an intermittent error for issue submitting? If I re-run build log pointed by url will be re-written...
 97 2020-06-02T05:48:02  <hebasto> https://travis-ci.org/github/bitcoin/bitcoin/jobs/692067912
 98 2020-06-02T05:52:20  *** cncr04s_ has left #bitcoin-core-dev
 99 2020-06-02T05:53:05  *** cncr04s_ has joined #bitcoin-core-dev
100 2020-06-02T05:54:32  *** cncr04s_ has quit IRC
101 2020-06-02T05:55:56  *** cncr04s has joined #bitcoin-core-dev
102 2020-06-02T05:56:43  *** Kiminuo has joined #bitcoin-core-dev
103 2020-06-02T06:00:02  *** ajbiz11 has quit IRC
104 2020-06-02T06:01:02  <cncr04s> can any one explain this "[00:47:45] cncr04s #bitcoin-core-dev Cannot change nickname while banned/quieted on channel" I have not spoken on this channel in weeks so...
105 2020-06-02T06:03:00  <gwillen> cncr04s: assuming someone doesn't come correct me, and given that you appear not to be banned or quieted now, I would assume it was an accident / collateral damage of some other ban
106 2020-06-02T06:03:48  *** achow101 has joined #bitcoin-core-dev
107 2020-06-02T06:12:37  *** Guyver2 has joined #bitcoin-core-dev
108 2020-06-02T06:14:51  *** bitcoin-git has joined #bitcoin-core-dev
109 2020-06-02T06:14:51  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/6f7f94a27687...60e8e74d1085
110 2020-06-02T06:14:52  <bitcoin-git> bitcoin/0.20 1dfad42 Wladimir J. van der Laan: doc: Merge 0.20.0 release notes from wiki
111 2020-06-02T06:14:52  <bitcoin-git> bitcoin/0.20 60e8e74 fanquake: Merge #19138: doc: Merge 0.20.0 release notes from wiki
112 2020-06-02T06:14:54  *** bitcoin-git has left #bitcoin-core-dev
113 2020-06-02T06:15:11  *** bitcoin-git has joined #bitcoin-core-dev
114 2020-06-02T06:15:11  <bitcoin-git> [bitcoin] fanquake merged pull request #19138: doc: Merge 0.20.0 release notes from wiki (0.20...2020_06_0.20_relnot) https://github.com/bitcoin/bitcoin/pull/19138
115 2020-06-02T06:15:12  *** bitcoin-git has left #bitcoin-core-dev
116 2020-06-02T06:21:51  *** paulk-collins has joined #bitcoin-core-dev
117 2020-06-02T06:36:28  *** kristapsk has quit IRC
118 2020-06-02T06:36:51  *** kristapsk has joined #bitcoin-core-dev
119 2020-06-02T06:42:05  *** morcos has quit IRC
120 2020-06-02T06:48:46  *** bitcoin-git has joined #bitcoin-core-dev
121 2020-06-02T06:48:46  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9bc7751cadbd...44307449f758
122 2020-06-02T06:48:46  <bitcoin-git> bitcoin/master 4f49d52 João Barbosa: gui, refactor: Register Qt meta types in application constructor
123 2020-06-02T06:48:47  <bitcoin-git> bitcoin/master 4430744 Jonas Schnelli: Merge #19104: gui, refactor: Register Qt meta types in application constru...
124 2020-06-02T06:48:48  *** bitcoin-git has left #bitcoin-core-dev
125 2020-06-02T06:49:05  *** bitcoin-git has joined #bitcoin-core-dev
126 2020-06-02T06:49:05  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #19104: gui, refactor: Register Qt meta types in application constructor (master...2020-05-register-metatypes) https://github.com/bitcoin/bitcoin/pull/19104
127 2020-06-02T06:49:07  *** bitcoin-git has left #bitcoin-core-dev
128 2020-06-02T06:49:30  *** morcos has joined #bitcoin-core-dev
129 2020-06-02T07:04:31  *** guest534543 has joined #bitcoin-core-dev
130 2020-06-02T07:08:03  *** Kiminuo has quit IRC
131 2020-06-02T07:09:27  *** guest534543 has quit IRC
132 2020-06-02T07:15:24  *** promag has joined #bitcoin-core-dev
133 2020-06-02T07:17:09  *** votesmith has quit IRC
134 2020-06-02T07:19:59  *** promag has quit IRC
135 2020-06-02T07:30:29  *** promag has joined #bitcoin-core-dev
136 2020-06-02T07:34:50  *** promag has quit IRC
137 2020-06-02T07:45:40  *** bitcoin-git has joined #bitcoin-core-dev
138 2020-06-02T07:45:40  *** EagleTM has joined #bitcoin-core-dev
139 2020-06-02T07:45:41  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/60e8e74d1085...a62f0ed64f8b
140 2020-06-02T07:45:41  <bitcoin-git> bitcoin/0.20 808c8d1 Wladimir J. van der Laan: build: Set rc to 0 for -final
141 2020-06-02T07:45:42  <bitcoin-git> bitcoin/0.20 a62f0ed Wladimir J. van der Laan: doc: Manpages update pre-final
142 2020-06-02T07:45:44  *** bitcoin-git has left #bitcoin-core-dev
143 2020-06-02T07:46:19  *** bitcoin-git has joined #bitcoin-core-dev
144 2020-06-02T07:46:19  <bitcoin-git> [bitcoin] laanwj pushed tag v0.20.0: https://github.com/bitcoin/bitcoin/compare/v0.20.0
145 2020-06-02T07:46:30  *** bitcoin-git has left #bitcoin-core-dev
146 2020-06-02T07:46:32  <fanquake> 🚀
147 2020-06-02T07:47:38  <sipa>     🚀
148 2020-06-02T07:47:49  <luke-jr> &nbsp;
149 2020-06-02T07:51:43  <wumpus> ^^
150 2020-06-02T07:53:48  *** jonatack has quit IRC
151 2020-06-02T08:05:23  <CubicEarth> strong work devs!
152 2020-06-02T08:13:22  *** kljasdfvv has joined #bitcoin-core-dev
153 2020-06-02T08:14:10  *** promag has joined #bitcoin-core-dev
154 2020-06-02T08:18:16  *** jonatack has joined #bitcoin-core-dev
155 2020-06-02T08:32:03  *** afk11` has quit IRC
156 2020-06-02T08:34:40  *** afk11` has joined #bitcoin-core-dev
157 2020-06-02T09:00:03  *** paulk-collins has quit IRC
158 2020-06-02T09:05:19  *** Guyver2 has quit IRC
159 2020-06-02T09:22:23  *** BjarniRunar1 has joined #bitcoin-core-dev
160 2020-06-02T09:32:08  <emzy>      🚀
161 2020-06-02T09:41:07  *** shesek has quit IRC
162 2020-06-02T10:03:22  *** Bettye82Leuschke has joined #bitcoin-core-dev
163 2020-06-02T10:13:18  *** surja795 has joined #bitcoin-core-dev
164 2020-06-02T10:15:02  *** Bettye82Leuschke has quit IRC
165 2020-06-02T10:30:55  *** setpill has joined #bitcoin-core-dev
166 2020-06-02T10:34:56  *** bitcoin-git has joined #bitcoin-core-dev
167 2020-06-02T10:34:56  <bitcoin-git> [bitcoin] hebasto closed pull request #18731: refactor: Make CCheckQueue RAII-styled (master...200421-queue-raii) https://github.com/bitcoin/bitcoin/pull/18731
168 2020-06-02T10:34:57  *** bitcoin-git has left #bitcoin-core-dev
169 2020-06-02T10:35:16  *** bitcoin-git has joined #bitcoin-core-dev
170 2020-06-02T10:35:17  <bitcoin-git> [bitcoin] hebasto reopened pull request #18731: refactor: Make CCheckQueue RAII-styled (master...200421-queue-raii) https://github.com/bitcoin/bitcoin/pull/18731
171 2020-06-02T10:35:18  *** bitcoin-git has left #bitcoin-core-dev
172 2020-06-02T10:43:54  *** bitcoin-git has joined #bitcoin-core-dev
173 2020-06-02T10:43:55  <bitcoin-git> [bitcoin] hebasto closed pull request #18898: gui: Display warnings as rich text (master...200506-no-html) https://github.com/bitcoin/bitcoin/pull/18898
174 2020-06-02T10:43:55  *** bitcoin-git has left #bitcoin-core-dev
175 2020-06-02T10:44:09  *** bitcoin-git has joined #bitcoin-core-dev
176 2020-06-02T10:44:10  <bitcoin-git> [bitcoin] hebasto reopened pull request #18898: gui: Display warnings as rich text (master...200506-no-html) https://github.com/bitcoin/bitcoin/pull/18898
177 2020-06-02T10:44:10  *** bitcoin-git has left #bitcoin-core-dev
178 2020-06-02T10:47:06  *** bitcoin-git has joined #bitcoin-core-dev
179 2020-06-02T10:47:06  <bitcoin-git> [bitcoin] hebasto closed pull request #18896: qt: Reset toolbar after all wallets are closed (master...200506-toolbar) https://github.com/bitcoin/bitcoin/pull/18896
180 2020-06-02T10:47:07  *** bitcoin-git has left #bitcoin-core-dev
181 2020-06-02T10:47:25  *** bitcoin-git has joined #bitcoin-core-dev
182 2020-06-02T10:47:25  <bitcoin-git> [bitcoin] hebasto reopened pull request #18896: qt: Reset toolbar after all wallets are closed (master...200506-toolbar) https://github.com/bitcoin/bitcoin/pull/18896
183 2020-06-02T10:47:26  *** bitcoin-git has left #bitcoin-core-dev
184 2020-06-02T10:47:51  *** surja795 has quit IRC
185 2020-06-02T11:03:38  *** Pavlenex has joined #bitcoin-core-dev
186 2020-06-02T11:05:40  *** bitcoin-git has joined #bitcoin-core-dev
187 2020-06-02T11:05:41  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/44307449f758...1f7fe59460db
188 2020-06-02T11:05:41  <bitcoin-git> bitcoin/master fa9c675 MarcoFalke: Limit scope of all global std::once_flag
189 2020-06-02T11:05:42  <bitcoin-git> bitcoin/master 1f7fe59 MarcoFalke: Merge #19111: Limit scope of all global std::once_flag
190 2020-06-02T11:05:43  *** bitcoin-git has left #bitcoin-core-dev
191 2020-06-02T11:06:00  *** bitcoin-git has joined #bitcoin-core-dev
192 2020-06-02T11:06:01  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19111: Limit scope of all global std::once_flag (master...2005-NoGlobalOnce) https://github.com/bitcoin/bitcoin/pull/19111
193 2020-06-02T11:06:05  *** bitcoin-git has left #bitcoin-core-dev
194 2020-06-02T11:15:15  *** bitcoin-git has joined #bitcoin-core-dev
195 2020-06-02T11:15:16  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1f7fe59460db...45a1489997a5
196 2020-06-02T11:15:17  <bitcoin-git> bitcoin/master eeeed51 MarcoFalke: test: pep-8 wallet_hd
197 2020-06-02T11:15:17  <bitcoin-git> bitcoin/master fa7d3a8 MarcoFalke: test: Add missing sync_blocks to wallet_hd
198 2020-06-02T11:15:18  <bitcoin-git> bitcoin/master 45a1489 MarcoFalke: Merge #19122: test: Add missing sync_blocks to wallet_hd
199 2020-06-02T11:15:19  *** bitcoin-git has left #bitcoin-core-dev
200 2020-06-02T11:15:40  *** bitcoin-git has joined #bitcoin-core-dev
201 2020-06-02T11:15:41  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19122: test: Add missing sync_blocks to wallet_hd (master...2005-testSyncBlocksHd) https://github.com/bitcoin/bitcoin/pull/19122
202 2020-06-02T11:15:41  *** bitcoin-git has left #bitcoin-core-dev
203 2020-06-02T11:20:49  *** Relis has quit IRC
204 2020-06-02T11:32:22  *** jb55 has quit IRC
205 2020-06-02T11:33:28  *** bitcoin-git has joined #bitcoin-core-dev
206 2020-06-02T11:33:29  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/45a1489997a5...9e8bd217cd2a
207 2020-06-02T11:33:30  <bitcoin-git> bitcoin/master 5495fa5 Jeremy Rubin: Add Hash Padding Microbenchmarks
208 2020-06-02T11:33:30  <bitcoin-git> bitcoin/master 152e8ba Jeremy Rubin: Use salted hasher instead of nonce in sigcache
209 2020-06-02T11:33:31  <bitcoin-git> bitcoin/master 9e8bd21 MarcoFalke: Merge #13204: Faster sigcache nonce
210 2020-06-02T11:33:33  *** bitcoin-git has left #bitcoin-core-dev
211 2020-06-02T11:35:23  *** bitcoin-git has joined #bitcoin-core-dev
212 2020-06-02T11:35:23  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #13204: Faster sigcache nonce (master...faster-sigcache-nonce) https://github.com/bitcoin/bitcoin/pull/13204
213 2020-06-02T11:35:25  *** bitcoin-git has left #bitcoin-core-dev
214 2020-06-02T11:35:58  *** jb55 has joined #bitcoin-core-dev
215 2020-06-02T11:54:37  *** bitcoin-git has joined #bitcoin-core-dev
216 2020-06-02T11:54:37  <bitcoin-git> [bitcoin] practicalswift opened pull request #19140: tests: Avoid fuzzer-specific nullptr dereference in libevent when handling PROXY requests (master...fuzzers-libevent-proxy) https://github.com/bitcoin/bitcoin/pull/19140
217 2020-06-02T11:54:38  *** bitcoin-git has left #bitcoin-core-dev
218 2020-06-02T11:54:56  *** promag has quit IRC
219 2020-06-02T12:00:01  *** BjarniRunar1 has quit IRC
220 2020-06-02T12:02:25  *** Zenton has quit IRC
221 2020-06-02T12:02:56  *** murr4y has quit IRC
222 2020-06-02T12:06:56  *** bitcoin-git has joined #bitcoin-core-dev
223 2020-06-02T12:06:56  <bitcoin-git> [bitcoin] hebasto closed pull request #18898: gui: Display warnings as rich text (master...200506-no-html) https://github.com/bitcoin/bitcoin/pull/18898
224 2020-06-02T12:06:57  *** bitcoin-git has left #bitcoin-core-dev
225 2020-06-02T12:07:16  *** bitcoin-git has joined #bitcoin-core-dev
226 2020-06-02T12:07:16  <bitcoin-git> [bitcoin] hebasto reopened pull request #18898: gui: Display warnings as rich text (master...200506-no-html) https://github.com/bitcoin/bitcoin/pull/18898
227 2020-06-02T12:07:17  *** bitcoin-git has left #bitcoin-core-dev
228 2020-06-02T12:14:55  *** Relis has joined #bitcoin-core-dev
229 2020-06-02T12:21:00  *** Eprom has joined #bitcoin-core-dev
230 2020-06-02T12:26:15  *** Pavlenex has quit IRC
231 2020-06-02T12:36:03  *** Highway61 has joined #bitcoin-core-dev
232 2020-06-02T12:45:14  *** Eprom has quit IRC
233 2020-06-02T12:51:44  *** promag has joined #bitcoin-core-dev
234 2020-06-02T12:56:43  *** promag has quit IRC
235 2020-06-02T12:56:57  *** Zenton has joined #bitcoin-core-dev
236 2020-06-02T13:03:48  *** securekim has joined #bitcoin-core-dev
237 2020-06-02T13:05:08  *** securekim has quit IRC
238 2020-06-02T13:06:51  *** murr4y has joined #bitcoin-core-dev
239 2020-06-02T13:12:20  *** cltrbreak_MAD2 has quit IRC
240 2020-06-02T13:12:48  *** cltrbreak_MAD2 has joined #bitcoin-core-dev
241 2020-06-02T13:26:05  *** Chris_Stewart_5 has joined #bitcoin-core-dev
242 2020-06-02T13:38:06  *** bitcoin-git has joined #bitcoin-core-dev
243 2020-06-02T13:38:07  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18815: bench: Add logging benchmark (master...2004-benchLog) https://github.com/bitcoin/bitcoin/pull/18815
244 2020-06-02T13:38:07  *** bitcoin-git has left #bitcoin-core-dev
245 2020-06-02T13:38:21  *** bitcoin-git has joined #bitcoin-core-dev
246 2020-06-02T13:38:22  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18815: bench: Add logging benchmark (master...2004-benchLog) https://github.com/bitcoin/bitcoin/pull/18815
247 2020-06-02T13:38:22  *** bitcoin-git has left #bitcoin-core-dev
248 2020-06-02T13:51:07  *** dongcarl has joined #bitcoin-core-dev
249 2020-06-02T14:03:39  *** icota[m] has quit IRC
250 2020-06-02T14:07:39  *** Guest94234 has joined #bitcoin-core-dev
251 2020-06-02T14:12:51  *** dfmb_ has joined #bitcoin-core-dev
252 2020-06-02T14:12:57  *** dfmbbtc has joined #bitcoin-core-dev
253 2020-06-02T14:13:15  *** dfmbbtc has quit IRC
254 2020-06-02T14:20:45  *** dfmb_ has quit IRC
255 2020-06-02T14:28:08  *** Guest94234 has quit IRC
256 2020-06-02T14:28:30  *** mol_ has quit IRC
257 2020-06-02T14:29:30  *** tomkap1 has joined #bitcoin-core-dev
258 2020-06-02T14:30:12  <jonasschnelli> I’m macOS code-signing the 0.20 release in a few hours.
259 2020-06-02T14:35:32  *** tomkap1 has quit IRC
260 2020-06-02T14:35:38  *** bitcoin-git has joined #bitcoin-core-dev
261 2020-06-02T14:35:39  <bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/9e8bd217cd2a...5879bfa9a541
262 2020-06-02T14:35:39  <bitcoin-git> bitcoin/master 5555d97 MarcoFalke: wallet: Make PeriodicFlush uninterruptible
263 2020-06-02T14:35:40  <bitcoin-git> bitcoin/master fa7b885 MarcoFalke: walletdb: Remove unsed boost/thread
264 2020-06-02T14:35:40  <bitcoin-git> bitcoin/master fa1c74f MarcoFalke: wallet: Remove unused boost::thread_interrupted
265 2020-06-02T14:35:42  *** bitcoin-git has left #bitcoin-core-dev
266 2020-06-02T14:36:13  *** bitcoin-git has joined #bitcoin-core-dev
267 2020-06-02T14:36:13  <bitcoin-git> [bitcoin] fanquake merged pull request #18792: wallet: Remove boost from PeriodicFlush (master...2004-walletNoBoostPeriodicFlush) https://github.com/bitcoin/bitcoin/pull/18792
268 2020-06-02T14:36:24  *** bitcoin-git has left #bitcoin-core-dev
269 2020-06-02T14:45:02  *** mol has joined #bitcoin-core-dev
270 2020-06-02T14:58:03  *** zalun1 has joined #bitcoin-core-dev
271 2020-06-02T15:00:01  *** zalun1 has quit IRC
272 2020-06-02T15:06:14  *** mol has quit IRC
273 2020-06-02T15:09:37  *** promag has joined #bitcoin-core-dev
274 2020-06-02T15:25:05  *** proofofkeags has joined #bitcoin-core-dev
275 2020-06-02T15:28:25  *** owowo has quit IRC
276 2020-06-02T15:29:18  *** jb55 has quit IRC
277 2020-06-02T15:29:19  *** morcos has quit IRC
278 2020-06-02T15:29:19  *** ghost43 has quit IRC
279 2020-06-02T15:29:19  *** vasild has quit IRC
280 2020-06-02T15:29:19  *** sdaftuar has quit IRC
281 2020-06-02T15:29:19  *** afk11` has quit IRC
282 2020-06-02T15:29:19  *** bitdex has quit IRC
283 2020-06-02T15:29:19  *** mrostecki has quit IRC
284 2020-06-02T15:29:19  *** sipa has quit IRC
285 2020-06-02T15:29:19  *** kristapsk has quit IRC
286 2020-06-02T15:29:19  *** SiAnDoG has quit IRC
287 2020-06-02T15:32:02  *** jb55 has joined #bitcoin-core-dev
288 2020-06-02T15:32:12  *** morcos has joined #bitcoin-core-dev
289 2020-06-02T15:32:38  *** ghost43 has joined #bitcoin-core-dev
290 2020-06-02T15:33:40  <jonasschnelli> achow101: ping for win 0.20 signatures (macOS are pushed)
291 2020-06-02T15:34:20  *** owowo has joined #bitcoin-core-dev
292 2020-06-02T15:34:30  *** mrostecki has joined #bitcoin-core-dev
293 2020-06-02T15:34:52  <achow101> oh! I just woke up
294 2020-06-02T15:34:53  *** afk11` has joined #bitcoin-core-dev
295 2020-06-02T15:35:13  *** justanotheruser has quit IRC
296 2020-06-02T15:35:18  <achow101> i'll get those done soon
297 2020-06-02T15:35:31  *** Talkless has joined #bitcoin-core-dev
298 2020-06-02T15:36:29  *** Talkless has joined #bitcoin-core-dev
299 2020-06-02T15:39:31  *** vasild has joined #bitcoin-core-dev
300 2020-06-02T15:40:28  *** sipa has joined #bitcoin-core-dev
301 2020-06-02T15:41:14  *** bitdex has joined #bitcoin-core-dev
302 2020-06-02T15:41:44  *** troygiorshev has joined #bitcoin-core-dev
303 2020-06-02T15:51:04  *** justanotheruser has joined #bitcoin-core-dev
304 2020-06-02T15:51:18  *** rob01 has joined #bitcoin-core-dev
305 2020-06-02T15:56:43  *** belcher has quit IRC
306 2020-06-02T16:02:03  *** sdaftuar has joined #bitcoin-core-dev
307 2020-06-02T16:03:49  *** proofofkeags has quit IRC
308 2020-06-02T16:04:12  *** proofofkeags has joined #bitcoin-core-dev
309 2020-06-02T16:04:17  *** promag has quit IRC
310 2020-06-02T16:05:11  *** icemc has joined #bitcoin-core-dev
311 2020-06-02T16:06:42  *** icemc has quit IRC
312 2020-06-02T16:20:08  *** jarthur has joined #bitcoin-core-dev
313 2020-06-02T16:20:25  *** vasild_ has joined #bitcoin-core-dev
314 2020-06-02T16:21:14  *** Pavlenex has joined #bitcoin-core-dev
315 2020-06-02T16:23:23  *** vasild has quit IRC
316 2020-06-02T16:23:24  *** vasild_ is now known as vasild
317 2020-06-02T16:29:34  <stevenroose> Pruned nodes can still provide responses to all `getblockheader` RPCs, right?
318 2020-06-02T16:29:46  <sipa> yes
319 2020-06-02T16:31:18  <achow101> gitian builders: 0.20.0 sigs are pushed
320 2020-06-02T16:40:34  *** Pavlenex has quit IRC
321 2020-06-02T16:52:07  *** salim has joined #bitcoin-core-dev
322 2020-06-02T16:54:40  *** dfmb_ has joined #bitcoin-core-dev
323 2020-06-02T17:03:57  *** setpill has quit IRC
324 2020-06-02T17:04:00  *** ghost43 has quit IRC
325 2020-06-02T17:04:29  *** ghost43 has joined #bitcoin-core-dev
326 2020-06-02T17:06:32  <jonatack> jonasschnelli: achow101: thanks
327 2020-06-02T17:09:03  *** mol has joined #bitcoin-core-dev
328 2020-06-02T17:11:28  *** dr-orlovsky has joined #bitcoin-core-dev
329 2020-06-02T17:12:07  *** troygiorshev has quit IRC
330 2020-06-02T17:14:15  *** Guyver2 has joined #bitcoin-core-dev
331 2020-06-02T17:15:42  *** kristapsk has joined #bitcoin-core-dev
332 2020-06-02T17:26:17  *** promag has joined #bitcoin-core-dev
333 2020-06-02T17:28:52  *** justanotheruser has quit IRC
334 2020-06-02T17:29:13  *** justanotheruser has joined #bitcoin-core-dev
335 2020-06-02T17:30:35  *** promag has quit IRC
336 2020-06-02T17:32:39  *** rob01 has quit IRC
337 2020-06-02T17:34:19  *** promag has joined #bitcoin-core-dev
338 2020-06-02T17:42:11  *** bitcoin-git has joined #bitcoin-core-dev
339 2020-06-02T17:42:12  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19142: validation: Make VerifyDB level 4 interruptible (master...2006-valVerifyDbInterrupt4) https://github.com/bitcoin/bitcoin/pull/19142
340 2020-06-02T17:42:15  *** bitcoin-git has left #bitcoin-core-dev
341 2020-06-02T17:48:31  *** promag has quit IRC
342 2020-06-02T17:55:44  *** promag has joined #bitcoin-core-dev
343 2020-06-02T17:58:50  *** ironmarx has joined #bitcoin-core-dev
344 2020-06-02T18:00:01  *** ironmarx has quit IRC
345 2020-06-02T18:15:47  *** justanotheruser has quit IRC
346 2020-06-02T18:20:55  *** kierank1 has joined #bitcoin-core-dev
347 2020-06-02T18:28:19  *** promag has quit IRC
348 2020-06-02T18:36:03  <luke-jr> can someone add #18818 to HPR?
349 2020-06-02T18:36:08  <gribble> https://github.com/bitcoin/bitcoin/issues/18818 | Fix release tarball generated by gitian by luke-jr · Pull Request #18818 · bitcoin/bitcoin · GitHub
350 2020-06-02T18:47:15  *** cltrbreak_MAD2 has quit IRC
351 2020-06-02T18:47:40  *** cltrbreak_MAD2 has joined #bitcoin-core-dev
352 2020-06-02T18:47:52  *** troygiorshev has joined #bitcoin-core-dev
353 2020-06-02T18:51:41  *** justanotheruser has joined #bitcoin-core-dev
354 2020-06-02T18:57:17  *** Talkless has quit IRC
355 2020-06-02T19:01:30  *** roconnor has joined #bitcoin-core-dev
356 2020-06-02T19:02:48  *** promag has joined #bitcoin-core-dev
357 2020-06-02T19:06:06  *** proofofkeags has quit IRC
358 2020-06-02T19:06:54  *** promag has quit IRC
359 2020-06-02T19:08:01  *** proofofkeags has joined #bitcoin-core-dev
360 2020-06-02T19:08:02  *** proofofkeags has quit IRC
361 2020-06-02T19:08:15  *** proofofkeags has joined #bitcoin-core-dev
362 2020-06-02T19:10:54  <phantomcircuit> ok i don't get it how am i supposed to use NotifyCanGetAddressesChanged ?
363 2020-06-02T19:11:00  <phantomcircuit> BlueMatt, halp
364 2020-06-02T19:11:10  <achow101> phantomcircuit: what are you trying to use it for?
365 2020-06-02T19:11:57  <achow101> and how are you trying to use it?
366 2020-06-02T19:13:02  <provoostenator> I can also gurantee Blue Matt will not know the answer, unless he's a secret wallet code admirer :-)
367 2020-06-02T19:13:13  <BlueMatt> right, that.
368 2020-06-02T19:13:33  <phantomcircuit> BlueMatt, hi
369 2020-06-02T19:13:42  <BlueMatt> sup.
370 2020-06-02T19:14:02  <phantomcircuit> achow101, im just trying to set a flag in CWallet to recalculate a list of script pubkeys for block filter index based rescanning
371 2020-06-02T19:15:04  *** bitcoin-git has joined #bitcoin-core-dev
372 2020-06-02T19:15:05  <bitcoin-git> [bitcoin] practicalswift opened pull request #19143: tests: Add fuzzing harnesses for CAutoFile, CBufferedFile, LoadExternalBlockFile and other FILE* consumers (master...fuzzers-FILE) https://github.com/bitcoin/bitcoin/pull/19143
373 2020-06-02T19:15:13  *** bitcoin-git has left #bitcoin-core-dev
374 2020-06-02T19:15:43  <achow101> phantomcircuit: if the list is persistent, can't you just add to it as new scriptpubkeys are generated?
375 2020-06-02T19:16:22  *** troygiorshev has quit IRC
376 2020-06-02T19:16:44  <phantomcircuit> achow101, there's a bunch of ways for the list to be changed now
377 2020-06-02T19:16:59  *** dfmb_ has quit IRC
378 2020-06-02T19:16:59  <achow101> NotifyCanGetAddressesChanged does not necessarily mean that a new scriptPubKey has been generated. it's used to indicate whether it's possible to even get a new address
379 2020-06-02T19:17:51  <achow101> phantomcircuit: where?
380 2020-06-02T19:18:23  <sipa> i think it's pretty much impossible to just incrementally update that list
381 2020-06-02T19:18:42  *** marcoagner has quit IRC
382 2020-06-02T19:18:47  <sipa> just inserting a new pubkey may cause some indirectly multisig combination with it inside p2sh/p2wsh to become marked IsMine
383 2020-06-02T19:20:15  <achow101> but also why is the list persistent? I thought we had discussed previously that you should compute it at rescan time
384 2020-06-02T19:20:24  <provoostenator> If someone picks up #15845 it should be significiantly less painful to just rescan the whole wallet history
385 2020-06-02T19:20:30  <gribble> https://github.com/bitcoin/bitcoin/issues/15845 | wallet: Fast rescan with BIP157 block filters by MarcoFalke · Pull Request #15845 · bitcoin/bitcoin · GitHub
386 2020-06-02T19:20:44  <achow101> provoostenator: I think that's what phantomcircuit is doing
387 2020-06-02T19:20:53  <provoostenator> Ah OK, that's good news
388 2020-06-02T19:21:26  *** troygiorshev has joined #bitcoin-core-dev
389 2020-06-02T19:21:48  <sipa> achow101: i think the problem is that during rescan, new keys may be pulled from the keypool, which would require recomputing the list
390 2020-06-02T19:22:10  <provoostenator> That was one of the bugs in the original implementation, at some point anyway, not sure if it was fixed.
391 2020-06-02T19:22:12  <achow101> lock cs_wallet *ducks*
392 2020-06-02T19:22:36  <phantomcircuit> provoostenator, that's what im doing and why im asking about it
393 2020-06-02T19:22:48  <sipa> "this new rescan is super fast; one minor downside is that it deadlocks whenever it finds a new tx"
394 2020-06-02T19:22:58  <provoostenator> Or just start the rescan from scratch if you had to expand the keypool :-)
395 2020-06-02T19:23:35  <provoostenator> "this rescan runs in circles, but it does so really fast"
396 2020-06-02T19:24:29  <phantomcircuit> really i just need a flag that says the keypool has been changed, but it seems like there's multiple places that can happen now so this callback is the thing to use
397 2020-06-02T19:24:55  <achow101> provoostenator: and I think that brings us back to the phantomcircuit's original question about NotifyCanGetAddressesChanged as he needs a way to know whether to restart if the keypool changed
398 2020-06-02T19:25:37  <achow101> phantomcircuit: NotifyCanGetAddressesChanged is a boost signal. you have to bind and connect to it from elsewhere
399 2020-06-02T19:26:24  <phantomcircuit> it's a boost signal for whatever the current pwallet is i guess? it has no parameters
400 2020-06-02T19:26:34  <achow101> yes
401 2020-06-02T19:26:37  <achow101> it's a CWallet member
402 2020-06-02T19:27:09  <achow101> (well ScriptPubKeyMan member too, but these end up in CWallet)
403 2020-06-02T19:32:47  <provoostenator> Would it makes sense to have a skpman->keypool_update_at field?
404 2020-06-02T19:34:06  *** ghost43 has quit IRC
405 2020-06-02T19:34:35  *** ghost43 has joined #bitcoin-core-dev
406 2020-06-02T19:36:04  <phantomcircuit> provoostenator, i was going to use an atomic bool flag since it doesn't really matter when it was updated just that it needs to be regenerated
407 2020-06-02T19:36:22  <phantomcircuit> achow101, so can i use this-> within the callback? it doesn't seem like i can
408 2020-06-02T19:36:56  <achow101> why wouldn't you be able to?
409 2020-06-02T19:40:56  <sipa> boost callbacks happen in the same thread
410 2020-06-02T19:41:03  <sipa> maybe that's what phantomcircuit is confused about?
411 2020-06-02T19:41:58  *** promag has joined #bitcoin-core-dev
412 2020-06-02T19:42:58  *** belcher has joined #bitcoin-core-dev
413 2020-06-02T19:46:58  *** promag has quit IRC
414 2020-06-02T19:53:24  *** promag has joined #bitcoin-core-dev
415 2020-06-02T19:55:26  <phantomcircuit> oh right i was trying to use a lambda and i had the syntax very wrong
416 2020-06-02T19:59:27  *** promag has quit IRC
417 2020-06-02T20:06:14  *** Aliza has joined #bitcoin-core-dev
418 2020-06-02T20:06:48  *** Aliza has quit IRC
419 2020-06-02T20:16:12  *** SiAnDoG has joined #bitcoin-core-dev
420 2020-06-02T20:16:50  *** SiAnDoG has quit IRC
421 2020-06-02T20:25:47  *** promag has joined #bitcoin-core-dev
422 2020-06-02T20:32:11  *** promag_ has joined #bitcoin-core-dev
423 2020-06-02T20:38:38  *** promag_ has quit IRC
424 2020-06-02T20:49:37  *** surja795 has joined #bitcoin-core-dev
425 2020-06-02T21:00:01  *** kierank1 has quit IRC
426 2020-06-02T21:04:03  *** sipa has quit IRC
427 2020-06-02T21:04:54  *** Ahmad7Hodkiewicz has joined #bitcoin-core-dev
428 2020-06-02T21:07:17  *** filchef has joined #bitcoin-core-dev
429 2020-06-02T21:11:26  *** sipa has joined #bitcoin-core-dev
430 2020-06-02T21:11:38  *** Chris_Stewart_5 has quit IRC
431 2020-06-02T21:12:07  *** Ahmad7Hodkiewicz has quit IRC
432 2020-06-02T21:30:48  *** mol_ has joined #bitcoin-core-dev
433 2020-06-02T21:32:59  *** bitcoin-git has joined #bitcoin-core-dev
434 2020-06-02T21:33:00  <bitcoin-git> [bitcoin] puchu opened pull request #19144: include QPainterPath to fix compile error with Qt 5.15 (0.20...0.20) https://github.com/bitcoin/bitcoin/pull/19144
435 2020-06-02T21:33:01  *** bitcoin-git has left #bitcoin-core-dev
436 2020-06-02T21:33:21  *** mol has quit IRC
437 2020-06-02T21:35:36  <harding> wumpus: PR for the 0.20 release on BitcoinCore.org: https://github.com/bitcoin-core/bitcoincore.org/pull/703
438 2020-06-02T21:41:34  *** Luke has joined #bitcoin-core-dev
439 2020-06-02T21:46:05  *** surja795 has quit IRC
440 2020-06-02T21:47:00  *** surja795 has joined #bitcoin-core-dev
441 2020-06-02T21:47:45  *** Chris_Stewart_5 has joined #bitcoin-core-dev
442 2020-06-02T21:51:12  *** Luke has quit IRC
443 2020-06-02T21:51:14  *** surja795 has quit IRC
444 2020-06-02T21:54:00  *** jacob11 has joined #bitcoin-core-dev
445 2020-06-02T21:55:50  *** bitcoin-git has joined #bitcoin-core-dev
446 2020-06-02T21:55:51  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/a62f0ed64f8b...e42c959c1dcc
447 2020-06-02T21:55:52  <bitcoin-git> bitcoin/0.20 2abe8cc Luke Dashjr: Bugfix: Include "csv","!segwit" in "rules"
448 2020-06-02T21:55:53  <bitcoin-git> bitcoin/0.20 412d5fe Luke Dashjr: QA: feature_segwit: Check that template "rules" includes "!segwit" as appr...
449 2020-06-02T21:55:54  <bitcoin-git> bitcoin/0.20 e42c959 MarcoFalke: Merge #19019: [0.20] Fix GBT: Restore "!segwit" and "csv" to "rules" key
450 2020-06-02T21:55:55  *** bitcoin-git has left #bitcoin-core-dev
451 2020-06-02T21:56:10  *** bitcoin-git has joined #bitcoin-core-dev
452 2020-06-02T21:56:11  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19019: [0.20] Fix GBT: Restore "!segwit" and "csv" to "rules" key (0.20...fix_gbt_buried) https://github.com/bitcoin/bitcoin/pull/19019
453 2020-06-02T21:56:17  *** bitcoin-git has left #bitcoin-core-dev
454 2020-06-02T21:56:21  *** Guyver2 has quit IRC
455 2020-06-02T21:59:51  <promag> #18863 merge ready?
456 2020-06-02T21:59:53  <gribble> https://github.com/bitcoin/bitcoin/issues/18863 | refactor: Drop unused CScriptVisitor return type by promag · Pull Request #18863 · bitcoin/bitcoin · GitHub
457 2020-06-02T22:00:41  <phantomcircuit> sipa, the false positive rate for this seems really high, searching only for p2pkh on 12k keys none of which have actually been used im seeing a pretty consistent scroll of blocks matching
458 2020-06-02T22:06:49  <phantomcircuit> "Empirical analysis also shows that was chosen as these parameters minimize the bandwidth utilized, considering both the expected number of blocks downloaded due to false positives and the size of the filters themselves." - BIP158
459 2020-06-02T22:06:59  <phantomcircuit> that must only be true for pretty small filters
460 2020-06-02T22:08:00  <achow101> phantomcircuit: are you sure there isn't a bug?
461 2020-06-02T22:08:33  *** bitcoin-git has joined #bitcoin-core-dev
462 2020-06-02T22:08:33  <bitcoin-git> [bitcoin] fjahr opened pull request #19145: [WIP] Allow hash_type options for gettxoutsetinfo (master...csi-3-muhash-rpc) https://github.com/bitcoin/bitcoin/pull/19145
463 2020-06-02T22:08:34  *** bitcoin-git has left #bitcoin-core-dev
464 2020-06-02T22:09:09  <phantomcircuit> achow101, pretty sure, it successfully finds all the blocks that do have keys in a regtest example and mostly doesn't false positive since each block only has a coinbase, im now benchmarking against the main chain and to say there's a lot of false positives would be quite the understatement
465 2020-06-02T22:10:52  <phantomcircuit> achow101, i just updated #19116 with the exact code im running
466 2020-06-02T22:10:54  <gribble> https://github.com/bitcoin/bitcoin/issues/19116 | [WIP] wallet: use BlockFilterIndex in ScanForWalletTransactions by pstratem · Pull Request #19116 · bitcoin/bitcoin · GitHub
467 2020-06-02T22:11:10  <achow101> i'm gonna need to brush up on bip158 first
468 2020-06-02T22:13:09  *** bitcoin-git has joined #bitcoin-core-dev
469 2020-06-02T22:13:10  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5879bfa9a541...3657aee2d25c
470 2020-06-02T22:13:11  <bitcoin-git> bitcoin/master b604c5c Russell Yanofsky: wallet: Minimal fix to restore conflicted transaction notifications
471 2020-06-02T22:13:12  <bitcoin-git> bitcoin/master 7eaf86d Russell Yanofsky: trivial: Suggested cleanups to surrounding code
472 2020-06-02T22:13:13  <bitcoin-git> bitcoin/master 3657aee MarcoFalke: Merge #18982: wallet: Minimal fix to restore conflicted transaction notifi...
473 2020-06-02T22:13:14  *** bitcoin-git has left #bitcoin-core-dev
474 2020-06-02T22:13:29  *** bitcoin-git has joined #bitcoin-core-dev
475 2020-06-02T22:13:29  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18982: wallet: Minimal fix to restore conflicted transaction notifications (master...pr/cblock) https://github.com/bitcoin/bitcoin/pull/18982
476 2020-06-02T22:13:30  *** bitcoin-git has left #bitcoin-core-dev
477 2020-06-02T22:13:56  <sipa> phantomcircuit: i think bip158 was designed for much smaller sets of keys, yes
478 2020-06-02T22:14:12  <sipa> *sets of sPKs
479 2020-06-02T22:14:40  <sipa> it has an fprate of 1/784000
480 2020-06-02T22:15:42  <sipa> so if you're matching with a set of 120000 sPKs you'd see a match for 120000/784000 = 1.5% of blocks
481 2020-06-02T22:15:57  <sipa> i expect that's still a lot better than reading through all blocks
482 2020-06-02T22:16:48  <sipa> eh, 12000 sPKs
483 2020-06-02T22:17:24  <phantomcircuit> it took 53m using the block filters, currently running without to compare
484 2020-06-02T22:17:52  <phantomcircuit> with them it's about equal time between the filter operations and sha256 which i assume is verifying merkle tree roots
485 2020-06-02T22:18:08  <phantomcircuit> possibly saving a hash of the entire block in the block index would be a good idea?
486 2020-06-02T22:18:17  <achow101> A default legacy wallet has at least 8000 sPKs
487 2020-06-02T22:18:32  <achow101> so 12000 sPKs is not unreasonable
488 2020-06-02T22:19:40  <phantomcircuit> yeah and im doing this cause i know there's wallets with way more than that
489 2020-06-02T22:19:52  <phantomcircuit> i have a testnet wallet with like a million keys, most of which were actually used
490 2020-06-02T22:20:35  <sipa> with a million keys the bip158 filter won't help
491 2020-06-02T22:20:36  <achow101> phantomcircuit: that sounds like it'd match on the entire testnet chain with a pretty high true positive rate too
492 2020-06-02T22:20:45  <sipa> you'd match every block
493 2020-06-02T22:20:45  *** bitcoin-git has joined #bitcoin-core-dev
494 2020-06-02T22:20:46  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19146: doc: Remove release note fragments of 0.20.1 release, Add release-notes-0.20.0 (master...2006-docRel) https://github.com/bitcoin/bitcoin/pull/19146
495 2020-06-02T22:20:46  *** bitcoin-git has left #bitcoin-core-dev
496 2020-06-02T22:21:50  <phantomcircuit> sipa, i guess i could add another index with different parameters?
497 2020-06-02T22:22:19  <phantomcircuit> the size of the filter is pretty irrelevant if you're not sending it to anybody
498 2020-06-02T22:22:40  <phantomcircuit> and im only hashing the wallet contents per block not the block contents
499 2020-06-02T22:25:46  <sipa> phantomcircuit: maybe... but is that worth it? i expect that the number of wallets with million of keys is tiny, and when they need a rescan, it's typically a one time thing
500 2020-06-02T22:28:49  *** surja795 has joined #bitcoin-core-dev
501 2020-06-02T22:29:42  <luke-jr> fwiw, I added pbzx to my Gentoo overlay
502 2020-06-02T22:33:23  *** surja795 has quit IRC
503 2020-06-02T22:34:34  *** Highway61 has quit IRC
504 2020-06-02T22:43:56  *** promag has quit IRC
505 2020-06-02T22:48:10  <phantomcircuit> sipa, maybe just as an optional extra index? not something for everybody to be generating for sure
506 2020-06-02T22:53:18  <phantomcircuit> yeah without the filter was actually faster
507 2020-06-02T22:53:25  <phantomcircuit> 46m vs 53m
508 2020-06-02T23:00:07  *** bitcoin-git has joined #bitcoin-core-dev
509 2020-06-02T23:00:07  <bitcoin-git> [bitcoin] ariard opened pull request #19147: Document BanMan with regards to malicious exploitation (master...2020-06-doc-banman-infra) https://github.com/bitcoin/bitcoin/pull/19147
510 2020-06-02T23:00:08  *** bitcoin-git has left #bitcoin-core-dev
511 2020-06-02T23:00:49  *** ghost43 has quit IRC
512 2020-06-02T23:01:36  *** ghost43 has joined #bitcoin-core-dev
513 2020-06-02T23:08:47  *** surja795 has joined #bitcoin-core-dev
514 2020-06-02T23:09:04  *** AaronvanW has quit IRC
515 2020-06-02T23:09:23  *** justanotheruser has quit IRC
516 2020-06-02T23:09:24  *** jb55 has quit IRC
517 2020-06-02T23:13:26  *** surja795 has quit IRC
518 2020-06-02T23:17:34  *** Relis has quit IRC
519 2020-06-02T23:22:43  *** jb55 has joined #bitcoin-core-dev
520 2020-06-02T23:23:44  *** Relis has joined #bitcoin-core-dev
521 2020-06-02T23:27:18  <phantomcircuit> ok so the 1 in a billion filter might be too extreme
522 2020-06-02T23:28:07  *** justanotheruser has joined #bitcoin-core-dev
523 2020-06-02T23:39:44  *** surja795 has joined #bitcoin-core-dev
524 2020-06-02T23:40:27  *** AaronvanW has joined #bitcoin-core-dev
525 2020-06-02T23:44:02  *** troygiorshev has quit IRC
526 2020-06-02T23:45:14  *** AaronvanW has quit IRC
527 2020-06-02T23:50:01  *** surja795 has quit IRC