1 2020-06-04T00:00:02  *** retroj1 has quit IRC
  2 2020-06-04T00:22:11  *** Lord1 has joined #bitcoin-core-dev
  3 2020-06-04T01:00:01  *** Relis has quit IRC
  4 2020-06-04T01:01:48  *** _andrewtoth_ has joined #bitcoin-core-dev
  5 2020-06-04T01:01:54  *** andrewtoth_ has quit IRC
  6 2020-06-04T01:06:21  *** troygiorshev has joined #bitcoin-core-dev
  7 2020-06-04T01:07:23  *** Relis has joined #bitcoin-core-dev
  8 2020-06-04T01:39:54  <instagibbs> stevenroose, do note that in master there's not export of xpub yet even for descriptor wallets, achow says he's on it at some point
  9 2020-06-04T02:36:04  *** Relis has quit IRC
 10 2020-06-04T02:45:10  *** bitcoin-git has joined #bitcoin-core-dev
 11 2020-06-04T02:45:10  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a1c0e5fce139...b42bc33d2d4d
 12 2020-06-04T02:45:11  <bitcoin-git> bitcoin/master 0fef60c sachinkm77: build: improved output of configure for build OS
 13 2020-06-04T02:45:11  <bitcoin-git> bitcoin/master b42bc33 fanquake: Merge #19152: build: improve build OS configure output
 14 2020-06-04T02:45:13  *** bitcoin-git has left #bitcoin-core-dev
 15 2020-06-04T02:45:41  *** bitcoin-git has joined #bitcoin-core-dev
 16 2020-06-04T02:45:41  <bitcoin-git> [bitcoin] fanquake merged pull request #19152: build: improve build OS configure output (master...fixbuildos) https://github.com/bitcoin/bitcoin/pull/19152
 17 2020-06-04T02:45:42  *** bitcoin-git has left #bitcoin-core-dev
 18 2020-06-04T02:47:30  <achow101> instagibbs: #19136
 19 2020-06-04T02:47:32  <gribble> https://github.com/bitcoin/bitcoin/issues/19136 | wallet: add dumpwalletdescriptor RPC by achow101 · Pull Request #19136 · bitcoin/bitcoin · GitHub
 20 2020-06-04T02:47:41  <achow101> for xpub export
 21 2020-06-04T02:54:47  *** asoltys has quit IRC
 22 2020-06-04T02:56:25  *** proofofkeags has quit IRC
 23 2020-06-04T03:00:01  *** Lord1 has quit IRC
 24 2020-06-04T03:03:12  *** bitcoin-git has joined #bitcoin-core-dev
 25 2020-06-04T03:03:13  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b42bc33d2d4d...76e64525ff38
 26 2020-06-04T03:03:13  <bitcoin-git> bitcoin/master fab7d95 MarcoFalke: test: Make valgrind.supp work on aarch64
 27 2020-06-04T03:03:14  <bitcoin-git> bitcoin/master 76e6452 fanquake: Merge #19159: test: Make valgrind.supp work on aarch64
 28 2020-06-04T03:03:16  *** bitcoin-git has left #bitcoin-core-dev
 29 2020-06-04T03:03:31  *** bitcoin-git has joined #bitcoin-core-dev
 30 2020-06-04T03:03:31  <bitcoin-git> [bitcoin] fanquake merged pull request #19159: test: Make valgrind.supp work on aarch64 (master...2006-valgrindAarch64) https://github.com/bitcoin/bitcoin/pull/19159
 31 2020-06-04T03:03:32  *** bitcoin-git has left #bitcoin-core-dev
 32 2020-06-04T03:07:11  *** kristapsk has quit IRC
 33 2020-06-04T03:08:38  *** kristapsk has joined #bitcoin-core-dev
 34 2020-06-04T03:21:54  *** DJWillis has joined #bitcoin-core-dev
 35 2020-06-04T03:21:59  *** kristapsk has quit IRC
 36 2020-06-04T03:27:46  *** jarthur_ has joined #bitcoin-core-dev
 37 2020-06-04T03:30:47  *** jarthur_ has quit IRC
 38 2020-06-04T03:31:48  *** jarthur has quit IRC
 39 2020-06-04T03:33:34  *** jarthur has joined #bitcoin-core-dev
 40 2020-06-04T03:37:12  *** surja795 has quit IRC
 41 2020-06-04T03:38:47  *** jarthur has quit IRC
 42 2020-06-04T03:41:38  *** dviola has quit IRC
 43 2020-06-04T03:42:04  *** surja795 has joined #bitcoin-core-dev
 44 2020-06-04T03:45:05  *** troygiorshev has quit IRC
 45 2020-06-04T03:45:39  *** dviola has joined #bitcoin-core-dev
 46 2020-06-04T03:46:45  *** surja795 has quit IRC
 47 2020-06-04T03:46:46  *** dviola has left #bitcoin-core-dev
 48 2020-06-04T03:47:08  *** dviola has joined #bitcoin-core-dev
 49 2020-06-04T03:49:28  *** jarthur has joined #bitcoin-core-dev
 50 2020-06-04T03:53:06  *** Eagle[TM] has joined #bitcoin-core-dev
 51 2020-06-04T03:55:20  *** EagleTM has quit IRC
 52 2020-06-04T04:24:23  *** vasild has quit IRC
 53 2020-06-04T04:25:20  *** vasild has joined #bitcoin-core-dev
 54 2020-06-04T04:59:40  *** MM77788811 has joined #bitcoin-core-dev
 55 2020-06-04T05:02:16  <MM77788811> Are python tests expected to pass in master branch? I build from master and run extended tests and some of them fails.
 56 2020-06-04T05:03:35  *** MM77788811 has quit IRC
 57 2020-06-04T05:20:37  <fanquake> MM7778811: They sometimes fail sporadically. If you can't find an issue open with the failure you're seeing, feel free to open one, or, open a PR with a fix.
 58 2020-06-04T05:21:47  *** user1324 has joined #bitcoin-core-dev
 59 2020-06-04T05:27:32  *** MM77788811 has joined #bitcoin-core-dev
 60 2020-06-04T05:28:34  *** user1324 has quit IRC
 61 2020-06-04T05:29:57  *** harrigan has quit IRC
 62 2020-06-04T05:30:36  *** harrigan has joined #bitcoin-core-dev
 63 2020-06-04T05:59:28  *** Guyver2 has joined #bitcoin-core-dev
 64 2020-06-04T06:00:02  *** DJWillis has quit IRC
 65 2020-06-04T06:15:23  *** user1324 has joined #bitcoin-core-dev
 66 2020-06-04T06:21:57  *** gws has joined #bitcoin-core-dev
 67 2020-06-04T07:23:05  *** spinza has quit IRC
 68 2020-06-04T07:32:39  *** spinza has joined #bitcoin-core-dev
 69 2020-06-04T07:39:02  *** molz_ has joined #bitcoin-core-dev
 70 2020-06-04T07:42:14  *** mol_ has quit IRC
 71 2020-06-04T08:10:05  *** promag has joined #bitcoin-core-dev
 72 2020-06-04T08:13:38  *** provoostenator has quit IRC
 73 2020-06-04T08:14:30  *** provoostenator has joined #bitcoin-core-dev
 74 2020-06-04T08:19:15  *** sipsorcery has joined #bitcoin-core-dev
 75 2020-06-04T08:21:10  *** shesek has joined #bitcoin-core-dev
 76 2020-06-04T08:37:52  *** user1324 has left #bitcoin-core-dev
 77 2020-06-04T09:00:04  *** gws has quit IRC
 78 2020-06-04T09:19:15  *** wotwot1 has joined #bitcoin-core-dev
 79 2020-06-04T09:34:54  *** molz_ has quit IRC
 80 2020-06-04T09:38:49  <hebasto> something wrong happens with travis arm builds...
 81 2020-06-04T09:41:42  *** jarthur has quit IRC
 82 2020-06-04T09:45:10  *** jarthur has joined #bitcoin-core-dev
 83 2020-06-04T09:46:36  *** jarthur_ has joined #bitcoin-core-dev
 84 2020-06-04T09:47:00  *** jarthur_ has quit IRC
 85 2020-06-04T09:49:36  *** jarthur has quit IRC
 86 2020-06-04T09:55:43  *** frogar- has joined #bitcoin-core-dev
 87 2020-06-04T09:55:47  *** frogar has quit IRC
 88 2020-06-04T09:55:48  *** nsh has quit IRC
 89 2020-06-04T09:56:01  *** masterdonx2 has joined #bitcoin-core-dev
 90 2020-06-04T09:56:17  *** MasterdonX has quit IRC
 91 2020-06-04T09:56:24  *** lesderid_ has joined #bitcoin-core-dev
 92 2020-06-04T09:56:42  *** nsh has joined #bitcoin-core-dev
 93 2020-06-04T09:56:46  *** nickler has quit IRC
 94 2020-06-04T09:56:47  *** Anduck has quit IRC
 95 2020-06-04T09:56:53  *** nickler has joined #bitcoin-core-dev
 96 2020-06-04T09:57:15  *** wullon5 has quit IRC
 97 2020-06-04T09:57:16  *** pingwindyktator has quit IRC
 98 2020-06-04T09:57:16  *** lesderid has quit IRC
 99 2020-06-04T09:57:24  *** wullon5 has joined #bitcoin-core-dev
100 2020-06-04T09:57:29  *** frogar- is now known as frogar
101 2020-06-04T09:57:42  *** pingwindyktator has joined #bitcoin-core-dev
102 2020-06-04T09:58:08  *** Anduck has joined #bitcoin-core-dev
103 2020-06-04T10:01:10  *** mol has joined #bitcoin-core-dev
104 2020-06-04T10:03:22  *** Skyla45Rutherfor has joined #bitcoin-core-dev
105 2020-06-04T10:08:22  *** Skyla45Rutherfor has quit IRC
106 2020-06-04T10:13:07  *** surja795 has joined #bitcoin-core-dev
107 2020-06-04T10:16:42  <hebasto> MarcoFalke: about TSan -- https://github.com/google/sanitizers/issues/1258#issuecomment-638755284
108 2020-06-04T10:17:49  *** Relis has joined #bitcoin-core-dev
109 2020-06-04T10:19:54  *** Relis has quit IRC
110 2020-06-04T10:32:24  <phantomcircuit> do we have any kind of per node nonce already?
111 2020-06-04T10:32:41  <phantomcircuit> i need one for the block filter indexes and i don't want to double up on that
112 2020-06-04T10:37:25  *** dfmb_ has joined #bitcoin-core-dev
113 2020-06-04T11:01:51  *** Relis has joined #bitcoin-core-dev
114 2020-06-04T11:11:04  *** surja795 has quit IRC
115 2020-06-04T11:45:40  *** kristapsk has joined #bitcoin-core-dev
116 2020-06-04T11:47:06  *** Stopwatch has joined #bitcoin-core-dev
117 2020-06-04T12:00:01  *** wotwot1 has quit IRC
118 2020-06-04T12:09:09  *** cltrbreak_MAD2 has quit IRC
119 2020-06-04T12:09:32  *** cltrbreak_MAD2 has joined #bitcoin-core-dev
120 2020-06-04T12:22:03  *** larsivi has joined #bitcoin-core-dev
121 2020-06-04T12:24:32  *** lesderid_ has quit IRC
122 2020-06-04T12:24:43  *** lesderid has joined #bitcoin-core-dev
123 2020-06-04T12:32:31  *** Relis7 has joined #bitcoin-core-dev
124 2020-06-04T12:33:20  *** yevaud` has joined #bitcoin-core-dev
125 2020-06-04T12:33:51  *** TheRec_ has joined #bitcoin-core-dev
126 2020-06-04T12:33:51  *** TheRec_ has joined #bitcoin-core-dev
127 2020-06-04T12:34:38  *** Livestradamus_ has joined #bitcoin-core-dev
128 2020-06-04T12:34:42  *** DougieBot5000_ has joined #bitcoin-core-dev
129 2020-06-04T12:34:56  *** gribble has quit IRC
130 2020-06-04T12:35:55  *** spinza_ has joined #bitcoin-core-dev
131 2020-06-04T12:36:16  *** enasigurd_ has joined #bitcoin-core-dev
132 2020-06-04T12:36:25  *** meshcoll- has joined #bitcoin-core-dev
133 2020-06-04T12:36:32  *** hadjiszs_ has joined #bitcoin-core-dev
134 2020-06-04T12:36:39  *** a5m0 has quit IRC
135 2020-06-04T12:36:40  *** yevaud has quit IRC
136 2020-06-04T12:36:40  *** Relis has quit IRC
137 2020-06-04T12:36:41  *** ja has quit IRC
138 2020-06-04T12:36:41  *** TheRec has quit IRC
139 2020-06-04T12:36:41  *** Zenton has quit IRC
140 2020-06-04T12:36:41  *** baldur has quit IRC
141 2020-06-04T12:36:45  *** a5m0_ has joined #bitcoin-core-dev
142 2020-06-04T12:36:46  *** spinza has quit IRC
143 2020-06-04T12:36:46  *** Henry151 has quit IRC
144 2020-06-04T12:36:47  *** isis has quit IRC
145 2020-06-04T12:36:47  *** z3232 has quit IRC
146 2020-06-04T12:36:47  *** meshcollider has quit IRC
147 2020-06-04T12:36:47  *** so has quit IRC
148 2020-06-04T12:36:47  *** enasigurd has quit IRC
149 2020-06-04T12:36:47  *** niftynei has quit IRC
150 2020-06-04T12:36:47  *** thaumavorio has quit IRC
151 2020-06-04T12:36:48  *** hadjiszs has quit IRC
152 2020-06-04T12:36:48  *** DougieBot5000 has quit IRC
153 2020-06-04T12:36:48  *** hebasto has quit IRC
154 2020-06-04T12:36:48  *** Livestradamus has quit IRC
155 2020-06-04T12:36:54  *** isis_ has joined #bitcoin-core-dev
156 2020-06-04T12:37:22  *** so has joined #bitcoin-core-dev
157 2020-06-04T12:37:22  *** ja has joined #bitcoin-core-dev
158 2020-06-04T12:37:38  *** Henry151 has joined #bitcoin-core-dev
159 2020-06-04T12:37:56  *** hebasto has joined #bitcoin-core-dev
160 2020-06-04T12:37:58  *** thaumavorio has joined #bitcoin-core-dev
161 2020-06-04T12:37:59  *** baldur has joined #bitcoin-core-dev
162 2020-06-04T12:37:59  *** z3232 has joined #bitcoin-core-dev
163 2020-06-04T12:38:03  *** Bullit has quit IRC
164 2020-06-04T12:38:14  *** niftynei has joined #bitcoin-core-dev
165 2020-06-04T12:39:02  *** Bullit has joined #bitcoin-core-dev
166 2020-06-04T12:47:03  *** gribble has joined #bitcoin-core-dev
167 2020-06-04T12:49:22  *** Stopwatch has quit IRC
168 2020-06-04T12:49:40  *** _andrewtoth_ has quit IRC
169 2020-06-04T12:49:40  *** sdaftuar has quit IRC
170 2020-06-04T12:50:06  *** _andrewtoth_ has joined #bitcoin-core-dev
171 2020-06-04T12:50:42  *** sdaftuar has joined #bitcoin-core-dev
172 2020-06-04T12:55:12  *** Zenton has joined #bitcoin-core-dev
173 2020-06-04T13:18:06  *** cryptoIndio has joined #bitcoin-core-dev
174 2020-06-04T13:20:31  *** mol_ has joined #bitcoin-core-dev
175 2020-06-04T13:23:14  <wumpus> phantomcircuit: you mean like CNode::GetLocalNonce? it's used for checking against connections to self
176 2020-06-04T13:23:50  *** troygiorshev has joined #bitcoin-core-dev
177 2020-06-04T13:24:03  *** mol has quit IRC
178 2020-06-04T13:46:03  *** bitcoin-git has joined #bitcoin-core-dev
179 2020-06-04T13:46:04  <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/76e64525ff38...584170a3888e
180 2020-06-04T13:46:05  <bitcoin-git> bitcoin/master fa1d580 MarcoFalke: validation: Remove unused boost interruption_point
181 2020-06-04T13:46:06  <bitcoin-git> bitcoin/master fa3b4f9 MarcoFalke: validation: Make VerifyDB level 4 interruptible
182 2020-06-04T13:46:06  <bitcoin-git> bitcoin/master 584170a fanquake: Merge #19142: validation: Make VerifyDB level 4 interruptible
183 2020-06-04T13:46:08  *** bitcoin-git has left #bitcoin-core-dev
184 2020-06-04T13:46:23  *** bitcoin-git has joined #bitcoin-core-dev
185 2020-06-04T13:46:23  <bitcoin-git> [bitcoin] fanquake merged pull request #19142: validation: Make VerifyDB level 4 interruptible (master...2006-valVerifyDbInterrupt4) https://github.com/bitcoin/bitcoin/pull/19142
186 2020-06-04T13:46:24  *** bitcoin-git has left #bitcoin-core-dev
187 2020-06-04T13:46:48  *** dfmb_ has quit IRC
188 2020-06-04T13:58:42  *** molz_ has joined #bitcoin-core-dev
189 2020-06-04T14:01:47  *** mol_ has quit IRC
190 2020-06-04T14:02:54  *** molz_ has quit IRC
191 2020-06-04T14:03:46  *** cltrbreak_MAD2 has quit IRC
192 2020-06-04T14:04:10  *** cltrbreak_MAD2 has joined #bitcoin-core-dev
193 2020-06-04T14:07:09  *** brianhoffman has quit IRC
194 2020-06-04T14:09:21  *** brianhoffman has joined #bitcoin-core-dev
195 2020-06-04T14:09:50  *** proofofkeags has joined #bitcoin-core-dev
196 2020-06-04T14:16:19  *** brianhoffman has quit IRC
197 2020-06-04T14:28:30  *** bitcoin-git has joined #bitcoin-core-dev
198 2020-06-04T14:28:32  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/584170a3888e...b46fb5cb1058
199 2020-06-04T14:28:32  <bitcoin-git> bitcoin/master d15db4b Jonathan Schoeller: refactor: Fix unreachable code in init arg checks
200 2020-06-04T14:28:33  <bitcoin-git> bitcoin/master eea8114 Jonathan Schoeller: build: Enable unreachable-code-loop-increment
201 2020-06-04T14:28:34  <bitcoin-git> bitcoin/master b46fb5c Wladimir J. van der Laan: Merge #19131: refactor: Fix unreachable code in init arg checks
202 2020-06-04T14:28:36  *** bitcoin-git has left #bitcoin-core-dev
203 2020-06-04T14:28:50  *** bitcoin-git has joined #bitcoin-core-dev
204 2020-06-04T14:28:50  <bitcoin-git> [bitcoin] laanwj merged pull request #19131: refactor: Fix unreachable code in init arg checks (master...fix-Wunreachable-code-loop-increment) https://github.com/bitcoin/bitcoin/pull/19131
205 2020-06-04T14:28:51  *** bitcoin-git has left #bitcoin-core-dev
206 2020-06-04T14:29:53  *** cryptoIndio has quit IRC
207 2020-06-04T14:31:54  *** Relis7 has quit IRC
208 2020-06-04T14:36:19  *** molz_ has joined #bitcoin-core-dev
209 2020-06-04T14:39:44  *** bitcoin-git has joined #bitcoin-core-dev
210 2020-06-04T14:39:45  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b46fb5cb1058...011fe009f9ee
211 2020-06-04T14:39:45  <bitcoin-git> bitcoin/master ac94141 Karl-Johan Alm: validation: delay flushing undo files in syncing node case
212 2020-06-04T14:39:46  <bitcoin-git> bitcoin/master 011fe00 Wladimir J. van der Laan: Merge #17994: validation: flush undo files after last block write
213 2020-06-04T14:39:48  *** bitcoin-git has left #bitcoin-core-dev
214 2020-06-04T14:40:39  *** bitcoin-git has joined #bitcoin-core-dev
215 2020-06-04T14:40:39  <bitcoin-git> [bitcoin] laanwj merged pull request #17994: validation: flush undo files after last block write (master...200124-rev-files) https://github.com/bitcoin/bitcoin/pull/17994
216 2020-06-04T14:40:40  *** bitcoin-git has left #bitcoin-core-dev
217 2020-06-04T14:47:04  *** Relis has joined #bitcoin-core-dev
218 2020-06-04T14:53:32  *** molz_ has quit IRC
219 2020-06-04T14:56:32  *** LarryRuane has joined #bitcoin-core-dev
220 2020-06-04T15:00:02  *** larsivi has quit IRC
221 2020-06-04T15:14:14  *** proofofkeags has quit IRC
222 2020-06-04T15:14:50  *** proofofkeags has joined #bitcoin-core-dev
223 2020-06-04T15:15:16  *** LarryRuane74 has joined #bitcoin-core-dev
224 2020-06-04T15:17:25  *** bitcoin-git has joined #bitcoin-core-dev
225 2020-06-04T15:17:26  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/011fe009f9ee...365f1082e1e6
226 2020-06-04T15:17:26  <bitcoin-git> bitcoin/master fa1433a MarcoFalke: rpc: Remove special case for unknown service flags
227 2020-06-04T15:17:27  <bitcoin-git> bitcoin/master 365f108 Wladimir J. van der Laan: Merge #19112: rpc: Remove special case for unknown service flags
228 2020-06-04T15:17:32  *** bitcoin-git has left #bitcoin-core-dev
229 2020-06-04T15:17:50  *** bitcoin-git has joined #bitcoin-core-dev
230 2020-06-04T15:17:51  <bitcoin-git> [bitcoin] laanwj merged pull request #19112: rpc: Remove special case for unknown service flags (master...2005-rpcServiceFlagsUnknown) https://github.com/bitcoin/bitcoin/pull/19112
231 2020-06-04T15:17:51  *** bitcoin-git has left #bitcoin-core-dev
232 2020-06-04T15:19:26  *** proofofkeags has quit IRC
233 2020-06-04T15:22:11  *** tlockney has joined #bitcoin-core-dev
234 2020-06-04T15:27:31  *** mol has joined #bitcoin-core-dev
235 2020-06-04T15:29:22  *** bitcoin-git has joined #bitcoin-core-dev
236 2020-06-04T15:29:22  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/365f1082e1e6...39afe5b1c68c
237 2020-06-04T15:29:23  <bitcoin-git> bitcoin/master 7daffc6 Gillian Chu: [test] CScriptNum Decode Check as Unit Tests
238 2020-06-04T15:29:24  <bitcoin-git> bitcoin/master 39afe5b Wladimir J. van der Laan: Merge #19082: test: Moved the CScriptNum asserts into the unit test in scr...
239 2020-06-04T15:29:25  *** bitcoin-git has left #bitcoin-core-dev
240 2020-06-04T15:29:42  *** bitcoin-git has joined #bitcoin-core-dev
241 2020-06-04T15:29:42  <bitcoin-git> [bitcoin] laanwj merged pull request #19082: test: Moved the CScriptNum asserts into the unit test in script.py (master...issue24) https://github.com/bitcoin/bitcoin/pull/19082
242 2020-06-04T15:29:43  *** bitcoin-git has left #bitcoin-core-dev
243 2020-06-04T15:49:27  *** justanotheruser has quit IRC
244 2020-06-04T15:49:43  *** proofofkeags has joined #bitcoin-core-dev
245 2020-06-04T15:49:51  *** tarboss has joined #bitcoin-core-dev
246 2020-06-04T15:53:17  *** bitdex has quit IRC
247 2020-06-04T15:57:26  *** harrigan has quit IRC
248 2020-06-04T15:59:02  *** tarboss has quit IRC
249 2020-06-04T16:00:08  *** harrigan has joined #bitcoin-core-dev
250 2020-06-04T16:04:51  *** justanotheruser has joined #bitcoin-core-dev
251 2020-06-04T16:13:59  *** jeremyrubin has joined #bitcoin-core-dev
252 2020-06-04T16:23:23  *** vasild has quit IRC
253 2020-06-04T16:25:27  *** vasild has joined #bitcoin-core-dev
254 2020-06-04T16:28:25  *** Talkless has joined #bitcoin-core-dev
255 2020-06-04T16:30:03  *** gzhao408 has joined #bitcoin-core-dev
256 2020-06-04T16:33:28  *** jonatack has quit IRC
257 2020-06-04T16:34:30  *** jonatack has joined #bitcoin-core-dev
258 2020-06-04T16:41:03  *** asoltys has joined #bitcoin-core-dev
259 2020-06-04T16:47:54  *** IGHOR has quit IRC
260 2020-06-04T17:03:27  *** jb55 has quit IRC
261 2020-06-04T17:03:45  *** dfmb_ has joined #bitcoin-core-dev
262 2020-06-04T17:03:58  *** jb55 has joined #bitcoin-core-dev
263 2020-06-04T17:13:40  *** Mercury_Vapor has quit IRC
264 2020-06-04T17:13:55  *** DougieBot5000_ is now known as DougieBot5000
265 2020-06-04T17:24:50  *** barrydingles has joined #bitcoin-core-dev
266 2020-06-04T17:28:03  *** owowo has quit IRC
267 2020-06-04T17:32:56  *** owowo has joined #bitcoin-core-dev
268 2020-06-04T17:35:41  <phantomcircuit> wumpus, no i need a permanent secret to set the siphash keys
269 2020-06-04T17:36:25  <phantomcircuit> if i use a per node siphash key i can avoid recalculating the hashes of all the wallet elements when using the filter index for rescan
270 2020-06-04T17:36:46  <sipa> phantomcircuit: by per node, you mean one globally for the current node
271 2020-06-04T17:36:49  <sipa> not one per peer?
272 2020-06-04T17:37:03  <phantomcircuit> sipa, globally
273 2020-06-04T17:37:34  <phantomcircuit> im talking about building a new filter index with siphash keys that are random to that node but are fixed
274 2020-06-04T17:37:44  <phantomcircuit> i don't see how i can add that to the index db itself
275 2020-06-04T17:37:55  <phantomcircuit> but maybe im missing something obvious
276 2020-06-04T17:38:16  <sipa> addrman has one
277 2020-06-04T17:38:37  <phantomcircuit> for benchmarking i just have them fixed as 0 1 but that's kind of easy to guess
278 2020-06-04T18:00:02  *** tlockney has quit IRC
279 2020-06-04T18:14:23  *** gzhao408 has quit IRC
280 2020-06-04T18:21:23  *** johncylee has joined #bitcoin-core-dev
281 2020-06-04T18:31:16  *** belcher has quit IRC
282 2020-06-04T18:36:45  *** bitcoin-git has joined #bitcoin-core-dev
283 2020-06-04T18:36:45  <bitcoin-git> [bitcoin] fjahr opened pull request #19168: Refactor: Improve setup_clean_chain semantics (master...test_chain) https://github.com/bitcoin/bitcoin/pull/19168
284 2020-06-04T18:36:46  *** bitcoin-git has left #bitcoin-core-dev
285 2020-06-04T18:41:19  *** gkrizek has quit IRC
286 2020-06-04T18:42:18  *** Mercury_Vapor has joined #bitcoin-core-dev
287 2020-06-04T18:47:52  *** bitcoin-git has joined #bitcoin-core-dev
288 2020-06-04T18:47:52  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/39afe5b1c68c...01b45b2e016f
289 2020-06-04T18:47:52  <bitcoin-git> bitcoin/master 8b3136b Sebastian Falbesoner: refactor: replace CNode pointers by references within net_processing.{h,cp...
290 2020-06-04T18:47:53  <bitcoin-git> bitcoin/master 01b45b2 MarcoFalke: Merge #19053: refactor: replace CNode pointers by references within net_pr...
291 2020-06-04T18:47:54  *** bitcoin-git has left #bitcoin-core-dev
292 2020-06-04T18:47:58  <sipa> #proposedmeetingtopic merging of Schnorr in libsecp256k1
293 2020-06-04T18:48:12  *** bitcoin-git has joined #bitcoin-core-dev
294 2020-06-04T18:48:12  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19053: refactor: replace CNode pointers by references within net_processing.{h,cpp} (master...20200522-refactor-use-cnode-references-within-net_processing) https://github.com/bitcoin/bitcoin/pull/19053
295 2020-06-04T18:48:13  *** bitcoin-git has left #bitcoin-core-dev
296 2020-06-04T18:50:07  <kanzure> (the scan for proposals runs five minutes prior to the meeting)
297 2020-06-04T18:51:13  <sipa> ah good to know
298 2020-06-04T18:51:44  *** belcher has joined #bitcoin-core-dev
299 2020-06-04T18:53:00  *** kvaciral has joined #bitcoin-core-dev
300 2020-06-04T18:55:33  *** Chris_Stewart_5 has quit IRC
301 2020-06-04T18:59:25  <MarcoFalke> #proposedmeetingtopic kill travis
302 2020-06-04T18:59:32  <MarcoFalke> #proposedmeetingtopic kill 0.14
303 2020-06-04T18:59:38  <jonasschnelli> heh
304 2020-06-04T18:59:52  <wumpus> 0.14 is still alive?
305 2020-06-04T18:59:53  <jonasschnelli> MarcoFalke: extend https://bitcoinbuilds.org?
306 2020-06-04T19:00:15  <MarcoFalke> Something with GitHub integration would be nice
307 2020-06-04T19:00:22  <wumpus> #startmeeting
308 2020-06-04T19:00:22  <lightningbot> Meeting started Thu Jun  4 19:00:22 2020 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
309 2020-06-04T19:00:22  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
310 2020-06-04T19:00:25  <jnewbery> hi
311 2020-06-04T19:00:26  <kanzure> hi
312 2020-06-04T19:00:29  <MarcoFalke> hoy
313 2020-06-04T19:00:29  <sipa> hi
314 2020-06-04T19:00:43  <troygiorshev> hi
315 2020-06-04T19:00:46  <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr
316 2020-06-04T19:00:48  <ariard> hi
317 2020-06-04T19:00:49  <wumpus> jeremyrubin lightlike emilengler jonatack hebasto jb55 elichai2
318 2020-06-04T19:00:52  <fjahr> hi
319 2020-06-04T19:00:53  <elichai2> Hi
320 2020-06-04T19:00:54  <jonasschnelli> hi
321 2020-06-04T19:00:57  <achow101> hi
322 2020-06-04T19:01:11  <luke-jr> hi
323 2020-06-04T19:01:29  <jamesob> hi
324 2020-06-04T19:01:34  <real_or_random> hi
325 2020-06-04T19:01:39  <wumpus> hi
326 2020-06-04T19:02:00  <wumpus> #topic High priority for review
327 2020-06-04T19:02:17  <wumpus> https://github.com/bitcoin/bitcoin/projects/8  currently 12 blockers, 3 chasing concept ACK
328 2020-06-04T19:02:22  <jonatack> hi
329 2020-06-04T19:02:39  <wumpus> this is a record high number :)
330 2020-06-04T19:03:03  <luke-jr> please add #18818
331 2020-06-04T19:03:06  <gribble> https://github.com/bitcoin/bitcoin/issues/18818 | Fix release tarball generated by gitian by luke-jr · Pull Request #18818 · bitcoin/bitcoin · GitHub
332 2020-06-04T19:04:15  <amiti> hi
333 2020-06-04T19:04:18  <ariard> if we can add #18797 too plz ? it's pretty simple to review and added a lengthy motivation
334 2020-06-04T19:04:20  <gribble> https://github.com/bitcoin/bitcoin/issues/18797 | Export standard Script flags in bitcoinconsensus by ariard · Pull Request #18797 · bitcoin/bitcoin · GitHub
335 2020-06-04T19:04:26  <wumpus> luke-jr: added
336 2020-06-04T19:04:30  <luke-jr> thx
337 2020-06-04T19:04:39  <wumpus> I think we need more review before we add even more PRs but okay
338 2020-06-04T19:04:44  <luke-jr> ariard: it's conceptually non-simple
339 2020-06-04T19:05:10  <MarcoFalke> I looked at some of the high prio ones, but no one looked at mine :(
340 2020-06-04T19:05:12  <wumpus> at some point if we keep adding high priority PRs then it's no more of a help than github's PR list
341 2020-06-04T19:05:17  <ariard> luke-jr: I added a motivation since last discussion, I invite you to express your reply on the PR
342 2020-06-04T19:05:21  *** go11111111111 has joined #bitcoin-core-dev
343 2020-06-04T19:05:40  *** go121212 has quit IRC
344 2020-06-04T19:05:42  *** proofofkeags has quit IRC
345 2020-06-04T19:05:46  <wumpus> anyhow, added
346 2020-06-04T19:05:56  <jamesob> MarcoFalke: will try to take a look this weekend
347 2020-06-04T19:05:57  <jonatack> wumpus: I agree... too many blockers means no blockers
348 2020-06-04T19:06:05  <sipsorcery> hi
349 2020-06-04T19:06:17  *** proofofkeags has joined #bitcoin-core-dev
350 2020-06-04T19:06:25  <wumpus> I mean everyone is entitled to having one high prio PR and there's a lot of contributors so it's not entirely unexpected
351 2020-06-04T19:06:32  <MarcoFalke> jamesob: thx
352 2020-06-04T19:06:38  <wumpus> I kind of hope reviewing will go back to pre-corona activity at some point
353 2020-06-04T19:08:50  <ariard> it sounds also all hi prio prs affect different parts of the codebase, which may be not a bad signal to have a lot of them?
354 2020-06-04T19:09:01  <wumpus> ok, let's go over the rest of the proposed topics, there's a lot for today
355 2020-06-04T19:09:04  <luke-jr> hmm
356 2020-06-04T19:09:49  <wumpus> #topic Peer logging (troygiorshev)
357 2020-06-04T19:10:10  <troygiorshev> Hey everyone
358 2020-06-04T19:10:11  <troygiorshev> I have a proposal for extending the per-peer message capture and resource tracking capabilities.
359 2020-06-04T19:10:13  <jeremyrubin> MarcoFalke: fwiw I'm more likely to look at something when explicitly asked to review it
360 2020-06-04T19:10:20  *** Talkless has quit IRC
361 2020-06-04T19:10:38  <troygiorshev> It's here
362 2020-06-04T19:10:39  <troygiorshev> https://gist.github.com/troygiorshev/f2fedca9b2ab8a2c6449c92d92e17678
363 2020-06-04T19:10:49  <troygiorshev> If anyone's given it a look I'm happy to answer any questions
364 2020-06-04T19:11:02  *** proofofkeags has quit IRC
365 2020-06-04T19:11:53  *** Highway61 has quit IRC
366 2020-06-04T19:12:08  <wumpus> is there a PR or issue for this?
367 2020-06-04T19:12:16  <jeremyrubin> troygiorshev: I like this kind of stuff. I'm curious if you have intuition on how much overhead it is to track
368 2020-06-04T19:12:31  <wumpus> if not, I don't think yo ucan expect anyone to have had a look at this
369 2020-06-04T19:12:43  <elichai2> troygiorshev: the general idea sounds interesting, especially if there will be a defined structure to it, so that external tools can analyze/aggregate the logs
370 2020-06-04T19:12:50  <jamesob> Concept ACK, would love more comprehensive per-peer statistics for the for-now-fictional monitoring framework I've been noodling on
371 2020-06-04T19:12:53  <sipa> concept ack, but it's very high level
372 2020-06-04T19:12:54  <troygiorshev> wumpus: not yet, thanks for the suggestion
373 2020-06-04T19:13:12  <sipa> things will depend on how invasive it is, what performance impact it has, ...
374 2020-06-04T19:13:28  <sipa> but in general, gather more of these statistics is definitely useful
375 2020-06-04T19:13:32  <jamesob> sipa: presumably it would be opt-in, but your questions are still relevant
376 2020-06-04T19:13:42  <wumpus> also how complex the added code is and how much extra maintence work it is
377 2020-06-04T19:14:09  <troygiorshev> jeremyrubin: I don't expect it will be run all of the time, but that will be something I keep a close eye on.  With it being toggleable, when people are using it they probably won't care about the performace impact (as I don't expect it will be massive my any means)
378 2020-06-04T19:14:16  <sipa> right, but even if it's opt-in, if it's so invasive that it alters the data it's measuring... it may be a problem :)
379 2020-06-04T19:14:31  <jamesob> true!
380 2020-06-04T19:14:50  <troygiorshev> elichai2: absolutely.  I'll also be building a bit of an analysis tool
381 2020-06-04T19:15:04  <jamesob> maybe there's a validation-queue-style decoupling you could do (or resurrect the logging thread PR and extend that)
382 2020-06-04T19:15:11  <jnewbery> jamesob: for stats tracking it might not be opt-in. Eventually we might want to use those stats to do peer throttling/eviction
383 2020-06-04T19:15:12  <wumpus> it reminds me of the statoshi changes (which IIRC never got integrated, nor even proposed, beause they're too invasive)
384 2020-06-04T19:15:34  <sipa> jnewbery: indeed
385 2020-06-04T19:15:39  <phantomcircuit> hi
386 2020-06-04T19:15:47  <jamesob> jnewbery: makes sense, but could start opt-in and make various measurements mandatory on a case-by-case basis
387 2020-06-04T19:15:54  <sipa> of course
388 2020-06-04T19:15:59  <jonatack> troygiorshev: i read it. i think it addresses a real issue but needs much more detail and also describe much more any previous work on this
389 2020-06-04T19:16:19  <luke-jr> one thing to keep in mind is we don't want detailed logging by default
390 2020-06-04T19:16:20  <jamesob> wumpus: and they introduce a dependency on a statsd library iirc
391 2020-06-04T19:16:22  <jnewbery> wumpus: statoshi is global statistics for the node. This is more targetted towards troubleshooting/investigating interactions with individual peers
392 2020-06-04T19:16:29  <wumpus> in which case you might want to talk with Jameson Lopp
393 2020-06-04T19:16:33  <luke-jr> last thing we need is people getting subpoena'd to find out which peer relayed what
394 2020-06-04T19:16:48  <wumpus> jnewbery: which sounds even more involved
395 2020-06-04T19:17:01  <sipa> luke-jr: logging to an external file should definitely remain opt-in, of course
396 2020-06-04T19:17:02  <wumpus> luke-jr: that's also a serious risk
397 2020-06-04T19:17:20  <wumpus> detailed logging should *definitely* not be enabled by default
398 2020-06-04T19:17:44  *** dfmbbtc has joined #bitcoin-core-dev
399 2020-06-04T19:17:47  <jamesob> is there a near costless way of "teeing" each P2P message received to some separate analysis thread?
400 2020-06-04T19:17:52  <troygiorshev> jamesob, sipa: I hope that, in its initial form, it will have no impact whatsover when disabled, and that it won't modify messages in any way when enabled.  imo it wouldn't be an effetive monitoring tool if it changed things
401 2020-06-04T19:18:04  <troygiorshev> (We're not quanum physics here :))
402 2020-06-04T19:18:09  <sipa> sure
403 2020-06-04T19:18:27  <jamesob> troygiorshev: I think the concern is not message modification but introducing some delay that materially affects p2p behavior as a second-order thing
404 2020-06-04T19:18:33  <wumpus> jamesob: tcpdump? :)
405 2020-06-04T19:18:46  *** cltrbreak_MAD2 has quit IRC
406 2020-06-04T19:18:49  <jeremyrubin> TBH I think the best thing is tcpdump-like
407 2020-06-04T19:18:50  <jamesob> wumpus: sounds good to me! let's not do this in core if that's practical!
408 2020-06-04T19:19:11  <sipa> i think there are two separate goals, and they may need different solutions
409 2020-06-04T19:19:13  *** cltrbreak_MAD2 has joined #bitcoin-core-dev
410 2020-06-04T19:19:13  <jeremyrubin> You might want to do it in core for encryption reasons
411 2020-06-04T19:19:16  <wumpus> wireshark has a bitcoin P2P protocol dissector, for example
412 2020-06-04T19:19:23  <sipa> dumping logs may be doable with tcpdump or other external tools
413 2020-06-04T19:19:27  <jnewbery> I don't think there's a huge amount to discuss yet. I just suggested that troy raise this in a meeting so people are aware of the project and know where to leave feedback/suggestions
414 2020-06-04T19:19:39  <sipa> but tracking of statistics that we may want to one day use to influence p2p behavior can't be done that way
415 2020-06-04T19:19:44  <wumpus> if your goal is really to capture all P2P data, that approach sounds better than adding yet another layer in bitcoind
416 2020-06-04T19:19:57  <MarcoFalke> I think it is hard to give feedback when the exact goal is a bit vague right now. Is this for internal node stats? Is this for logging plaintext to a file? Is this for exporting stats to a serialized file?
417 2020-06-04T19:19:59  <wumpus> yes it's useless for statistics
418 2020-06-04T19:20:09  <wumpus> agree there's mixed goals here
419 2020-06-04T19:20:16  <jamesob> an OOB process could then feed back into core via an RPC interface, if desired
420 2020-06-04T19:21:01  <wumpus> we already have some light statistics, like a P2P message type histogram in core, doesn't hurt to add more oft hose things esp. if they're opt-in and don't add to memory use of the CNode struct too much
421 2020-06-04T19:21:09  <phantomcircuit> wireguard even has a dissector for this
422 2020-06-04T19:21:11  <sipa> yeah
423 2020-06-04T19:21:22  <wumpus> but if you want full traffic intercept, that kind of thing doesn't belong in bitcoind imo
424 2020-06-04T19:21:28  *** dfmb_ has quit IRC
425 2020-06-04T19:21:40  <wumpus> phantomcircuit: yup
426 2020-06-04T19:22:32  <jamesob> troygiorshev: anyway, looking forward to some details!
427 2020-06-04T19:22:33  <jnewbery> wumpus: tcpdump isn't aware of application details. It'd be impossible to log messages from peers with subversion="thing" for example
428 2020-06-04T19:22:51  <jnewbery> unless you dumped all traffic all the time and then filtered after the fact
429 2020-06-04T19:22:53  <troygiorshev> lots of good points, thanks.  Certainly I agree, it's not for statistics.  The immediate benefit would be for debugging, one of the long term benefits could be intelligent peer-selection
430 2020-06-04T19:22:56  <sipa> yeah, let's wait for some details
431 2020-06-04T19:22:57  <jb55> troygiorshev: I have been adding usdt bpf traces to my node for exactly this use case. it adds low-overhead nop instructions that linux can plug into at runtime. and with bpftrace you can write scripts to gather node stats
432 2020-06-04T19:23:03  <luke-jr> not impossible w wireshark
433 2020-06-04T19:23:03  <phantomcircuit> jnewbery, the wireguard dissector actually means you can do exactly that
434 2020-06-04T19:23:15  <luke-jr> though maybe not implemented
435 2020-06-04T19:23:24  *** Highway61 has joined #bitcoin-core-dev
436 2020-06-04T19:23:35  <wumpus> jnewbery: dunno about tcpdump but wireshark can do some quite complex context/application-specific filters
437 2020-06-04T19:23:39  <jnewbery> yes, I understand you can filter afterwards. The point is that you end up with enormous pcap files because you have to capture all traffic
438 2020-06-04T19:23:53  <wumpus> yes, but also it is a pretty rare case for most people
439 2020-06-04T19:23:56  <phantomcircuit> luke-jr, it's literally implemented bitcoin.version.user_agent
440 2020-06-04T19:24:02  <wumpus> some things should really be external tooling
441 2020-06-04T19:24:20  <luke-jr> phantomcircuit: that just matches the version packet tho?
442 2020-06-04T19:24:41  <phantomcircuit> luke-jr, you can select tcp streams based on it though
443 2020-06-04T19:24:47  <wumpus> yupp
444 2020-06-04T19:24:48  <phantomcircuit> i cant remember how but i know you can
445 2020-06-04T19:24:50  <sipa> fwiw, i'm more interested in gathering statistics (possibly some day gathered by default) than just protocol dumps
446 2020-06-04T19:25:03  <jonasschnelli> would ne no longer fun for post BIP324 connections
447 2020-06-04T19:25:16  <jonasschnelli> (outside core)
448 2020-06-04T19:25:17  <sipa> jonasschnelli: also a good point
449 2020-06-04T19:25:29  <jamesob> would be nice to make it easy for people to voluntarily give a detailed dump of p2p stats
450 2020-06-04T19:25:34  <luke-jr> cool
451 2020-06-04T19:25:40  <troygiorshev> i'm personally a huge fan of BIP324 and AltNet and related, so I'
452 2020-06-04T19:25:53  <troygiorshev> I'm keeping those in the back of my mind as I think about htis
453 2020-06-04T19:25:57  <wumpus> so: statistics yes, protocol dump controversial
454 2020-06-04T19:26:16  <jnewbery> right, it's impossible to do any kind of dynamic packet filtering outside the application if it's encrypted
455 2020-06-04T19:26:18  <wumpus> let's regard thes as separate topics
456 2020-06-04T19:26:35  <luke-jr> jnewbery: NOT IF YOU PROVIDE KEYS
457 2020-06-04T19:26:42  <luke-jr> oops sorry for caps
458 2020-06-04T19:27:05  <sipa> shower thought: are pcap files easy? if so, maybe it's useful post-BIP324 to permit dumping the decrypted stream in pcap format
459 2020-06-04T19:27:06  <jonasschnelli> luke-jr: would probably be complicated to impossible in wireshark
460 2020-06-04T19:27:20  <wumpus> but I'd suggest first writing some document detailing more what you want to do, or make a example implementation
461 2020-06-04T19:27:30  <luke-jr> jonasschnelli: it does for https already
462 2020-06-04T19:27:31  <MarcoFalke> For logging, one could disable bip324
463 2020-06-04T19:27:32  <sipa> indeed, seems there are many partially overlapping ideas here
464 2020-06-04T19:27:33  <wumpus> as said this is quite vague and abstract right now
465 2020-06-04T19:27:52  <jnewbery> sipa: I don't think you'd want pcap. By the time you've got to the application, you've lost all the lower protocol layers
466 2020-06-04T19:28:11  <sipa> perhaps
467 2020-06-04T19:29:08  <wumpus> you could add these zero-cost linux abstraction hooks to bitcoind (forgot the name)
468 2020-06-04T19:29:16  <jb55> ebpf
469 2020-06-04T19:29:20  <wumpus> yess
470 2020-06-04T19:29:22  <jb55> I have a branch for it
471 2020-06-04T19:29:57  <wumpus> that's extremely flexible and allows for all kinds of diagnostics and experiments without impact on the code itself
472 2020-06-04T19:30:15  <jb55> I've been using it to time ibd and gathering histograms. it just inserts NOP instructions that linux hooks into
473 2020-06-04T19:30:21  <jb55> so only had overhead when you are plugged in
474 2020-06-04T19:30:29  <jb55> but you could also just compile it with traces disabled
475 2020-06-04T19:31:23  <troygiorshev> well I'll definitely be checking out everything that was said here, thanks everyone!
476 2020-06-04T19:31:32  <wumpus> someone even did a presentation at a bitcoin coredev meetup about this once, I forgot who
477 2020-06-04T19:31:50  <luke-jr> iirc gcc can inject tracing stuff auto
478 2020-06-04T19:31:54  *** Chris_Stewart_5 has joined #bitcoin-core-dev
479 2020-06-04T19:32:08  <jb55> here's an example bpftrace script that I am using + a connect_block usdt tracepoint https://jb55.com/s/ibd.bt.txt
480 2020-06-04T19:32:28  <wumpus> jb55: thanks!
481 2020-06-04T19:32:39  <sipa> seeing USDT in this channel scares me
482 2020-06-04T19:32:39  <troygiorshev> jb55: amazing!
483 2020-06-04T19:32:41  <jb55> so you can share these bpftrace scripts that gather stats without hardcoding anything into core itself, you just have to insert the tracepoints in interesting places
484 2020-06-04T19:32:59  <jb55> and you can extract values as well from the tracepoints, so you can log structs, etc
485 2020-06-04T19:33:00  <jnewbery> wumpus: are you thinking of evan klitzke's work on flame graphs and probing?
486 2020-06-04T19:33:20  <wumpus>  eklitzke was that
487 2020-06-04T19:33:22  <jamesob> jnewbery: I thought same but I think those are kernel probs; this looks like userland stuff
488 2020-06-04T19:33:22  <wumpus> yes
489 2020-06-04T19:33:29  <jamesob> *probes
490 2020-06-04T19:33:38  <wumpus> they work in userland too
491 2020-06-04T19:33:43  <wumpus> jnewbery: yes!
492 2020-06-04T19:33:44  <jb55> yeah the perf tool uses the same underlying tech, linux tracepoints, ebpf a way of executing these scripts securely within the kernel as bytecode
493 2020-06-04T19:34:17  <wumpus> could add a probe that is called on every P2P packet, for ex.
494 2020-06-04T19:34:20  <jb55> that's what the script I linked is doing. that is compiled and run within the kernel, and taps into those usdt tracepoints
495 2020-06-04T19:34:47  <jb55> it can also access low level io/net kernel traces within the same script which is nice
496 2020-06-04T19:35:12  <jb55> might be overkill but its super powerful
497 2020-06-04T19:35:17  <wumpus> that's really awesome
498 2020-06-04T19:35:49  <wumpus> well it's overkill but also the range of things you miht need for diagnosing or testing specific things calls for something flexible which is why it is that way
499 2020-06-04T19:36:03  <jb55> here's the patch I'm using to experiment with it https://jb55.com/s/tracepoints.patch.txt
500 2020-06-04T19:36:21  <wumpus> the alternative is generally to recompile with all kinds of instrumentation but that requires a recompile and patching every time
501 2020-06-04T19:36:54  <jamesob> seems like it'd make a lot of sense to build in ./configure-able dtrace taps...
502 2020-06-04T19:36:56  <jb55> if there's interest I would PR it, just wasn't sure
503 2020-06-04T19:37:17  <wumpus> there definitely is interest!
504 2020-06-04T19:37:20  <jb55> kk
505 2020-06-04T19:37:31  <jonatack> jb55: yes
506 2020-06-04T19:37:42  <jamesob> jb55: cool work
507 2020-06-04T19:38:18  <sipa> indeed
508 2020-06-04T19:38:56  <wumpus> we need to cover some other topics today so moving on for now, maybe discuss this further out of meeting
509 2020-06-04T19:39:04  <wumpus> #topic Merging of Schnorr in libsecp256k1 (sipa)
510 2020-06-04T19:39:14  <sipa> hi
511 2020-06-04T19:39:23  <troygiorshev> yep thanks again everyone I'll make an issue with this more formalized and many questions answered!
512 2020-06-04T19:39:38  <wumpus> troygiorshev: thanks
513 2020-06-04T19:39:50  <sipa> so with the prospect of having BIP340-342 one day merged, there will need to be a time to merge BIP340 support in libsecp256k1
514 2020-06-04T19:40:02  <sipa> and i was wondering if we have a good feel for when the right time is
515 2020-06-04T19:40:36  <wumpus> I don't see any drawbacks to merging it as an optionally enabled feature
516 2020-06-04T19:40:45  <sipa> yeah
517 2020-06-04T19:41:05  <sipa> i think the code is pretty much done; it was recently stripped of some future feature (batch validation) and cleaned up
518 2020-06-04T19:41:11  <nickler> it's an experimental module right now, so it needs to be explicitly enabled
519 2020-06-04T19:41:19  <sipa> of course it'd be experimental for now
520 2020-06-04T19:41:27  <sipa> (thanks to nickler)
521 2020-06-04T19:41:48  <sipa> do we want to update libsecp256k1 in master before adding the schnorr code first?
522 2020-06-04T19:41:54  <sipa> so that the diff is minimized?
523 2020-06-04T19:41:54  <wumpus> I guess before exposing it publicly there needs to be some agreement with regard to the interface, though not 100%, it's expected for there to be some drift over the initial releases with it
524 2020-06-04T19:42:17  <wumpus> sipa: I don't think that can hurt in any case
525 2020-06-04T19:42:26  <sipa> to me, it feels that there needs to be some confidence that this is the functionality that will eventually make it into bitcoin
526 2020-06-04T19:42:36  <wumpus> last secp256k1 subtree update has been a while
527 2020-06-04T19:42:43  <sipa> we wouldn't just merge support for anything in libsecp256k1, being a subproject of bitcoin core
528 2020-06-04T19:42:57  <wumpus> there's a lot of expectations around it ending up in bitcoin eventually at least
529 2020-06-04T19:43:08  <sipa> but i think that confidence can be (significantly) lower than full consensus rules implemented in core
530 2020-06-04T19:43:16  <sipa> *than what is needed for
531 2020-06-04T19:43:17  <nickler> fwiw the PR looks good to me right now and many people looked at it already but it has changed quite a bit over time. If these people would be interested in having another look, that would be helpful.
532 2020-06-04T19:43:42  <elichai2> I'd like to review the new keypair direction but I do hope that BIP340 will actually end up in bitcoin in the end so I think it's ok to move toward merging schnorr to libsecp
533 2020-06-04T19:44:17  <wumpus> I think the most important thing to be confident about is that the algorithm, and the code, is secure
534 2020-06-04T19:44:18  <sipa> link: https://github.com/bitcoin-core/secp256k1/pull/558
535 2020-06-04T19:44:28  <real_or_random> elichai2: I mean we don't need to merge it in the current state.
536 2020-06-04T19:45:47  <real_or_random> but it's good to know when we feel confident enough that we want it in the codebase at all
537 2020-06-04T19:45:59  <sipa> yeah
538 2020-06-04T19:46:08  <sipa> that's why i'm bringing it up here
539 2020-06-04T19:46:56  <sipa> unless there are other comments, that's all from me
540 2020-06-04T19:46:57  <nickler> Afaik we've addressed all comments on the BIPS on the mailing list in some form of another
541 2020-06-04T19:47:30  <sipa> some TODOs left for clarifications/rationales, but no semantics changes
542 2020-06-04T19:47:32  *** proofofkeags has joined #bitcoin-core-dev
543 2020-06-04T19:47:38  <jamesob> who are the people who have spent enough time on this to give meaningful ACKs?
544 2020-06-04T19:48:47  <nickler> for the libsecp PR there's a few that could review it relatively quickly (elichai, real-or-random, sipa)
545 2020-06-04T19:49:26  <jamesob> I'm curious if there's anyone here who *doesn't* think schnorr will or should eventually be a part of bitcoin
546 2020-06-04T19:49:34  <elichai2> I think the big "political" question in terms of merging is if anyone believes that BIP340 doesn't have a good chance of landing in bitcoin core
547 2020-06-04T19:49:40  <elichai2> jamesob: exactly :)
548 2020-06-04T19:49:41  <jamesob> right
549 2020-06-04T19:49:47  <wumpus> FWIW: this was what eklitzke wrote about tracepoints at the time: https://eklitzke.org/how-sytemtap-userspace-probes-work
550 2020-06-04T19:49:47  <sipa> jamesob: i think the right question is whether it will be part of bitcoin *in this form*
551 2020-06-04T19:49:55  <jamesob> sipa: ah
552 2020-06-04T19:50:09  <troygiorshev> wumpus: thanks
553 2020-06-04T19:50:35  <elichai2> sipa: by *this form* I assume you mean the algorithm and not the API?
554 2020-06-04T19:50:45  <sipa> elichai2: yes
555 2020-06-04T19:51:33  <elichai2> sipa: did you get any comments on the curve mailinglist?
556 2020-06-04T19:51:38  <wumpus> we have 10 minutes left and two (small) topics left
557 2020-06-04T19:51:43  <jamesob> I think anyone who feels they're capable of evaluation should speak up, because I think a whole lot of us are not qualified...
558 2020-06-04T19:51:50  <real_or_random> also not everything is in the current PR
559 2020-06-04T19:51:59  <real_or_random> e.g., no batch verification at the moment
560 2020-06-04T19:52:53  <wumpus> but I guess it's better to postpone those to next week
561 2020-06-04T19:52:54  <real_or_random> we (the BIPauthors) feel it's in a good state, I think otherwise sipa wouldn't bring this up
562 2020-06-04T19:53:24  <elichai2> The last time I reviewed it it was in a pretty good state, I assume it's even better now
563 2020-06-04T19:53:25  <jeremyrubin> jamesob: it's also useful to have people out themselves as useless
564 2020-06-04T19:53:42  <jamesob> jeremyrubin: /me raises hand
565 2020-06-04T19:53:47  <jeremyrubin> jamesob: rather than seeming passive ack. I'm not opposed but am unqualified to comment
566 2020-06-04T19:54:23  <jamesob> I think I would not be wrong in characterizing most people at this meeting as "generally favorable towards schnorr -> bitcoin but unable to provide meaningful commentary on the specifics"
567 2020-06-04T19:55:03  *** mol_ has joined #bitcoin-core-dev
568 2020-06-04T19:55:16  <sipa> i think part of the question is here are about measuring community expectations, and not necessarily technical review itself
569 2020-06-04T19:55:17  <jamesob> IMO PR it. Best way to get the qualified commentary out.
570 2020-06-04T19:55:47  <wumpus> definitely favorable enough to merge it into secp256k1, which is a small step and easily reverted
571 2020-06-04T19:56:18  <MarcoFalke> Well, a bump to the current libsecp wouldn't hurt
572 2020-06-04T19:56:28  <MarcoFalke> The overhead is just another two commits
573 2020-06-04T19:56:31  <sipa> MarcoFalke: I'll PR a bump (pre-schnorr) soon
574 2020-06-04T19:56:39  <MarcoFalke> thx
575 2020-06-04T19:56:51  <sipa> there have been some nice improvements in master too
576 2020-06-04T19:56:53  <wumpus> I don't think this is a point where Schnorr progress should be held up on
577 2020-06-04T19:57:41  <wumpus> ofc. there will be a long stuggle to get it into bitcoin itself and hopefully a lot of people that will review the cryptography and code in detail
578 2020-06-04T19:58:04  <MarcoFalke> Btw, my short topic was to delete the 0.14 and 0.15 branches because they won't be pushed to anymore and are EOL https://github.com/bitcoin-core/bitcoincore.org/pull/704
579 2020-06-04T19:58:07  *** mol has quit IRC
580 2020-06-04T19:58:10  <MarcoFalke> Any objections?
581 2020-06-04T19:58:30  <jeremyrubin> Keeping the tags tho?
582 2020-06-04T19:58:31  <sipa> delete the branches, keep the tags?
583 2020-06-04T19:58:35  <wumpus> ACK: if there have been no commits since the last version tag
584 2020-06-04T19:58:36  <MarcoFalke> jeremyrubin: Sure
585 2020-06-04T19:58:44  <jeremyrubin> sipa: jinx
586 2020-06-04T19:58:48  <MarcoFalke> wumpus: The only commit is deleting the release notes
587 2020-06-04T19:58:51  <wumpus> if there have been commits since please create a -final tag or so
588 2020-06-04T19:58:56  <wumpus> fine w/ me
589 2020-06-04T19:59:08  <wumpus> yes, the tags should *definitely* be kept
590 2020-06-04T19:59:11  <wumpus> never delete tags
591 2020-06-04T19:59:22  <MarcoFalke> I don't think we need another tag when just the release notes have been cleared
592 2020-06-04T19:59:30  <sipa> agree
593 2020-06-04T19:59:41  <wumpus> (e.g. see v0.12-final etc)
594 2020-06-04T19:59:51  <wumpus> MarcoFalke: I agree if that's the only thing
595 2020-06-04T20:00:36  <MarcoFalke> I think for 0.12 we had some code change backports
596 2020-06-04T20:00:38  <wumpus> the other branches has unreleased bugfixes ported to them I think
597 2020-06-04T20:00:40  <wumpus> yes
598 2020-06-04T20:00:53  <MarcoFalke> Jup, 0.16 has a CVE fix xD
599 2020-06-04T20:00:54  <wumpus> #endmeeting
600 2020-06-04T20:00:54  <lightningbot> Meeting ended Thu Jun  4 20:00:54 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
601 2020-06-04T20:00:54  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-06-04-19.00.html
602 2020-06-04T20:00:54  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-06-04-19.00.txt
603 2020-06-04T20:00:54  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-06-04-19.00.log.html
604 2020-06-04T20:01:31  <gwillen> has there been discussion here of https://cryptopotato.com/trezor-releases-a-firmware-update-to-patch-a-possible-vulenrability-with-segwit-transactions/
605 2020-06-04T20:01:32  <MarcoFalke> oh, no. There was 0.16.3, so it was released after all
606 2020-06-04T20:01:55  <gwillen> I am surprised not to have seen much discussion of this yet
607 2020-06-04T20:03:35  <MarcoFalke> gwillen: Hasn't this been discussed on the mailing list a while ago?
608 2020-06-04T20:03:35  <achow101> gwillen: it was ostensibly public knowledge already, we just happened to be ignoring it
609 2020-06-04T20:03:46  <gwillen> ok, makes sense
610 2020-06-04T20:04:00  <MarcoFalke> Pretty sure I saw at least one thread with this (or somthing like that)
611 2020-06-04T20:04:09  <achow101> but with hardware wallets doing something about it, we will need to change PSBT stuff
612 2020-06-04T20:04:14  <achow101> which I'm working on
613 2020-06-04T20:04:25  <sipa> i assumed that everyone thought it was too hard to deal with, and only of minimal impact (attackers would need to consistently get you to sign twice, and only gain miners money)
614 2020-06-04T20:04:45  <sipa> it's fixed (and referenced) in BIP341
615 2020-06-04T20:04:57  <gwillen> right, they would need either a colluding miner, or they would have to make it an extortion threat ("pay me or I burn your coins")
616 2020-06-04T20:05:03  <jonatack> https://github.com/bitcoin/bips/blob/master/bip-0341.mediawiki#cite_note-17
617 2020-06-04T20:05:24  <achow101> I guess there's a question if we want the Core signer to also require non_witness_utxo too for segwit inputs and basically just ignore witness_utxo
618 2020-06-04T20:05:38  <achow101> or maybe supplement witness_utxo with utxo set info. or just do nothing
619 2020-06-04T20:06:00  <achow101> i'm inclined to go with do nothing
620 2020-06-04T20:06:18  <sipa> that'll break the ability to sign on trezor (and others that adopt similar changes)?
621 2020-06-04T20:06:18  <achow101> and just change updating to also put a non_witnes_utxo for segwit inputs
622 2020-06-04T20:06:44  <gwillen> I don't think that requiring the full UTXO actually fixes the whole problem, although it makes it harder to exploit
623 2020-06-04T20:07:05  <sipa> gwillen: if signers verify that information, it's a full solution i think
624 2020-06-04T20:07:14  <achow101> sipa: we only need to change updating to let signing work
625 2020-06-04T20:07:19  <achow101> with those hardware wallets
626 2020-06-04T20:07:25  <sipa> yes
627 2020-06-04T20:07:45  <sipa> because i think our signer already verifies the full non-witness utxo information if it's present
628 2020-06-04T20:07:48  <sipa> right?
629 2020-06-04T20:07:55  <achow101> yes
630 2020-06-04T20:08:18  <achow101> what I mean is whether we should have our signer require non_witness_utxo for segwit inputs too as the hardware wallets are doing
631 2020-06-04T20:08:26  <sipa> that's a good question
632 2020-06-04T20:08:42  <sipa> perhaps it should - but have the ability to disable it?
633 2020-06-04T20:08:43  <gwillen> sipa: nevermind, the alternate attack I was imagining doesn't work
634 2020-06-04T20:09:16  <achow101> I was thinking possibly look up the UTXO in the UTXO set if we have a witness_utxo
635 2020-06-04T20:09:22  <achow101> otherwise require the non_witness_utxo
636 2020-06-04T20:09:36  <sipa> achow101: that also works, but makes the signer non-stateless
637 2020-06-04T20:09:40  *** filchef has joined #bitcoin-core-dev
638 2020-06-04T20:09:41  <sipa> *stateful
639 2020-06-04T20:09:46  <achow101> yes..
640 2020-06-04T20:09:55  <sipa> but it is a great solution
641 2020-06-04T20:10:16  <achow101> also means I won't have to rewrite all of the psbt tests
642 2020-06-04T20:10:20  <sipa> though, why are you signing on an online machine? :p
643 2020-06-04T20:10:31  *** filchef has quit IRC
644 2020-06-04T20:11:12  <achow101> because you're running the functional tests :)
645 2020-06-04T20:11:19  <sipa> ha
646 2020-06-04T20:11:57  <achow101> maybe something to discuss at the wallet meeting tomorrow?
647 2020-06-04T20:12:01  <sipa> yeah
648 2020-06-04T20:29:37  <phantomcircuit> i could do something horrible and stuff the nonce into the 32 bits of zero in the block hash
649 2020-06-04T20:34:23  <jeremyrubin> phantomcircuit: you can also just elide the block hash entirely and get 32 bytes of space
650 2020-06-04T20:35:28  <sipa> phantomcircuit: why do you need a per-node salt? given that the gcs code tweaks by block hash, it should be unpredictable to anyone even with a fixed siphash key
651 2020-06-04T20:41:09  <phantomcircuit> sipa, so that it doesn't tweak by block hash and i dont have to recalculate the siphash of every script pub key for every block
652 2020-06-04T20:41:52  <sipa> ah of course
653 2020-06-04T20:43:51  <phantomcircuit> it kind of all strongly assumes you dont want to do that though so it's kind of annoying
654 2020-06-04T20:44:09  <phantomcircuit> thus the hack
655 2020-06-04T20:49:12  *** surja795 has joined #bitcoin-core-dev
656 2020-06-04T20:49:37  *** surja795 has quit IRC
657 2020-06-04T20:50:22  *** surja795 has joined #bitcoin-core-dev
658 2020-06-04T20:56:22  *** Guyver2 has quit IRC
659 2020-06-04T21:00:02  *** johncylee has quit IRC
660 2020-06-04T21:29:43  *** dfmbbtc has quit IRC
661 2020-06-04T21:36:20  *** bitcoin-git has joined #bitcoin-core-dev
662 2020-06-04T21:36:20  <bitcoin-git> [bitcoin] PastaPastaPasta opened pull request #19169: rpc: Validate provided keys for query_options parameter in listunspent (master...bitcoin-validate-keys-listunspent) https://github.com/bitcoin/bitcoin/pull/19169
663 2020-06-04T21:36:21  *** bitcoin-git has left #bitcoin-core-dev
664 2020-06-04T21:54:56  *** Fiver has joined #bitcoin-core-dev
665 2020-06-04T21:58:14  *** bitcoin-git has joined #bitcoin-core-dev
666 2020-06-04T21:58:14  <bitcoin-git> [bitcoin] luke-jr opened pull request #19170: [0.20] Add missing QPainterPath include (0.20...bugfix_incl_qpainterpath-0.9) https://github.com/bitcoin/bitcoin/pull/19170
667 2020-06-04T21:58:15  *** bitcoin-git has left #bitcoin-core-dev
668 2020-06-04T22:02:03  *** pinheadmz has quit IRC
669 2020-06-04T22:06:02  *** rabidus has quit IRC
670 2020-06-04T22:06:59  *** rabidus has joined #bitcoin-core-dev
671 2020-06-04T22:07:35  *** shesek has quit IRC
672 2020-06-04T22:08:10  *** proofofkeags has quit IRC
673 2020-06-04T22:08:36  *** proofofkeags has joined #bitcoin-core-dev
674 2020-06-04T22:13:19  *** proofofkeags has quit IRC
675 2020-06-04T22:22:10  *** bitcoin-git has joined #bitcoin-core-dev
676 2020-06-04T22:22:11  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/e42c959c1dcc...cd32134bda3e
677 2020-06-04T22:22:12  <bitcoin-git> bitcoin/0.20 384d3f9 Andrew Chow: Add missing QPainterPath include
678 2020-06-04T22:22:13  <bitcoin-git> bitcoin/0.20 cd32134 MarcoFalke: Merge #19170: [0.20] Add missing QPainterPath include
679 2020-06-04T22:22:15  *** bitcoin-git has left #bitcoin-core-dev
680 2020-06-04T22:22:30  *** bitcoin-git has joined #bitcoin-core-dev
681 2020-06-04T22:22:30  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19170: [0.20] Add missing QPainterPath include (0.20...bugfix_incl_qpainterpath-0.9) https://github.com/bitcoin/bitcoin/pull/19170
682 2020-06-04T22:22:31  *** bitcoin-git has left #bitcoin-core-dev
683 2020-06-04T22:22:50  *** bitcoin-git has joined #bitcoin-core-dev
684 2020-06-04T22:22:50  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #19144: include QPainterPath to fix compile error with Qt 5.15 (0.20...0.20) https://github.com/bitcoin/bitcoin/pull/19144
685 2020-06-04T22:22:51  *** bitcoin-git has left #bitcoin-core-dev
686 2020-06-04T22:23:50  *** jarthur has joined #bitcoin-core-dev
687 2020-06-04T22:24:18  *** proofofkeags has joined #bitcoin-core-dev
688 2020-06-04T22:28:44  *** proofofkeags has quit IRC
689 2020-06-04T22:29:12  *** proofofkeags has joined #bitcoin-core-dev
690 2020-06-04T22:32:23  *** proofofkeags has quit IRC
691 2020-06-04T22:32:30  *** proofofkeags has joined #bitcoin-core-dev
692 2020-06-04T22:35:43  *** elichai2 has quit IRC
693 2020-06-04T22:35:44  *** Isthmus has quit IRC
694 2020-06-04T22:35:47  *** bosma has quit IRC
695 2020-06-04T22:35:51  *** jakesyl has quit IRC
696 2020-06-04T22:35:52  *** fjahr has quit IRC
697 2020-06-04T22:36:02  *** RubenSomsen has quit IRC
698 2020-06-04T22:36:18  *** NicolasDorier has quit IRC
699 2020-06-04T22:36:18  *** endogenic has quit IRC
700 2020-06-04T22:36:18  *** digi_james has quit IRC
701 2020-06-04T22:36:18  *** pierre_rochard has quit IRC
702 2020-06-04T22:36:18  *** vfP56jSe has quit IRC
703 2020-06-04T22:36:29  *** fanquake has quit IRC
704 2020-06-04T22:36:30  *** rodarmor has quit IRC
705 2020-06-04T22:36:30  *** arik__ has quit IRC
706 2020-06-04T22:36:37  *** gertjaap has quit IRC
707 2020-06-04T22:36:37  *** jamesob has quit IRC
708 2020-06-04T22:36:37  *** en10n has quit IRC
709 2020-06-04T22:36:37  *** valwal_ has quit IRC
710 2020-06-04T22:36:51  *** nejon has quit IRC
711 2020-06-04T22:36:53  *** someone235 has quit IRC
712 2020-06-04T22:36:53  *** peltre has quit IRC
713 2020-06-04T22:37:04  *** prusnak has quit IRC
714 2020-06-04T22:37:07  *** Jackielove4u has quit IRC
715 2020-06-04T22:37:08  *** corollari has quit IRC
716 2020-06-04T22:37:08  *** CodeShark___ has quit IRC
717 2020-06-04T22:37:08  *** amiti has quit IRC
718 2020-06-04T22:37:12  *** jkczyz has quit IRC
719 2020-06-04T22:37:12  *** petezz4 has quit IRC
720 2020-06-04T22:37:26  *** moneyball has quit IRC
721 2020-06-04T22:37:26  *** hugohn has quit IRC
722 2020-06-04T22:37:28  *** hsmiths has quit IRC
723 2020-06-04T22:37:40  *** mariorz_ has joined #bitcoin-core-dev
724 2020-06-04T22:37:43  *** corollari has joined #bitcoin-core-dev
725 2020-06-04T22:37:46  *** mmitech_ has quit IRC
726 2020-06-04T22:37:46  *** michagogo has quit IRC
727 2020-06-04T22:37:46  *** Lexyon___ has quit IRC
728 2020-06-04T22:37:46  *** ajonas has quit IRC
729 2020-06-04T22:37:46  *** schmidty has quit IRC
730 2020-06-04T22:37:46  *** ccook has quit IRC
731 2020-06-04T22:37:46  *** eragmus has quit IRC
732 2020-06-04T22:37:47  *** mariorz has quit IRC
733 2020-06-04T22:37:47  *** prusnak has joined #bitcoin-core-dev
734 2020-06-04T22:37:48  *** mariorz_ is now known as mariorz
735 2020-06-04T22:37:48  *** vfP56jSe has joined #bitcoin-core-dev
736 2020-06-04T22:37:49  *** moneyball has joined #bitcoin-core-dev
737 2020-06-04T22:37:51  *** someone235 has joined #bitcoin-core-dev
738 2020-06-04T22:37:53  *** bosma has joined #bitcoin-core-dev
739 2020-06-04T22:38:09  *** Bullit has quit IRC
740 2020-06-04T22:38:09  *** michagogo_ has joined #bitcoin-core-dev
741 2020-06-04T22:38:29  *** shesek has joined #bitcoin-core-dev
742 2020-06-04T22:38:29  *** shesek has joined #bitcoin-core-dev
743 2020-06-04T22:38:32  *** elichai2 has joined #bitcoin-core-dev
744 2020-06-04T22:38:33  *** peltre has joined #bitcoin-core-dev
745 2020-06-04T22:38:45  *** Lexyon___ has joined #bitcoin-core-dev
746 2020-06-04T22:38:46  *** gertjaap has joined #bitcoin-core-dev
747 2020-06-04T22:38:48  *** fanquake has joined #bitcoin-core-dev
748 2020-06-04T22:39:00  *** Bullit has joined #bitcoin-core-dev
749 2020-06-04T22:39:03  *** valwal_ has joined #bitcoin-core-dev
750 2020-06-04T22:39:07  *** digi_james has joined #bitcoin-core-dev
751 2020-06-04T22:39:28  *** amiti has joined #bitcoin-core-dev
752 2020-06-04T22:39:29  *** NicolasDorier has joined #bitcoin-core-dev
753 2020-06-04T22:39:45  *** jakesyl has joined #bitcoin-core-dev
754 2020-06-04T22:39:57  *** petezz4 has joined #bitcoin-core-dev
755 2020-06-04T22:40:03  *** arik__ has joined #bitcoin-core-dev
756 2020-06-04T22:40:10  *** Victorsueca has quit IRC
757 2020-06-04T22:40:11  *** endogenic has joined #bitcoin-core-dev
758 2020-06-04T22:40:28  *** CodeShark___ has joined #bitcoin-core-dev
759 2020-06-04T22:40:38  *** RubenSomsen has joined #bitcoin-core-dev
760 2020-06-04T22:40:39  *** Isthmus has joined #bitcoin-core-dev
761 2020-06-04T22:41:03  *** rodarmor has joined #bitcoin-core-dev
762 2020-06-04T22:41:05  *** pierre_rochard has joined #bitcoin-core-dev
763 2020-06-04T22:41:29  *** jkczyz has joined #bitcoin-core-dev
764 2020-06-04T22:42:02  *** en10n has joined #bitcoin-core-dev
765 2020-06-04T22:42:06  *** jamesob has joined #bitcoin-core-dev
766 2020-06-04T22:42:30  *** ajonas has joined #bitcoin-core-dev
767 2020-06-04T22:42:34  *** schmidty has joined #bitcoin-core-dev
768 2020-06-04T22:43:24  *** Jackielove4u has joined #bitcoin-core-dev
769 2020-06-04T22:43:29  *** eragmus has joined #bitcoin-core-dev
770 2020-06-04T22:43:31  *** fjahr has joined #bitcoin-core-dev
771 2020-06-04T22:44:45  *** Victorsueca has joined #bitcoin-core-dev
772 2020-06-04T22:46:50  *** pinheadmz has joined #bitcoin-core-dev
773 2020-06-04T22:51:01  *** ccook has joined #bitcoin-core-dev
774 2020-06-04T22:51:25  *** hsmiths has joined #bitcoin-core-dev
775 2020-06-04T22:54:27  *** mol_ has quit IRC
776 2020-06-04T23:01:29  *** mol has joined #bitcoin-core-dev
777 2020-06-04T23:02:12  *** hugohn has joined #bitcoin-core-dev
778 2020-06-04T23:02:48  *** mmitech_ has joined #bitcoin-core-dev
779 2020-06-04T23:07:30  *** justanotheruser has quit IRC
780 2020-06-04T23:21:14  *** promag has quit IRC
781 2020-06-04T23:24:10  *** justanotheruser has joined #bitcoin-core-dev
782 2020-06-04T23:32:29  *** sanket1729 has joined #bitcoin-core-dev
783 2020-06-04T23:42:21  *** mol has quit IRC
784 2020-06-04T23:42:42  *** _andrewtoth_ has quit IRC
785 2020-06-04T23:43:15  *** _andrewtoth_ has joined #bitcoin-core-dev
786 2020-06-04T23:45:10  *** Bullit has quit IRC
787 2020-06-04T23:45:57  *** Bullit has joined #bitcoin-core-dev
788 2020-06-04T23:47:49  *** AaronvanW has quit IRC
789 2020-06-04T23:50:03  *** _andrewtoth_ has quit IRC
790 2020-06-04T23:52:30  *** mol has joined #bitcoin-core-dev
791 2020-06-04T23:58:00  *** bitdex has joined #bitcoin-core-dev
792 2020-06-04T23:59:44  *** pinheadmz has quit IRC