1 2020-06-06T00:00:02  *** pntbr has quit IRC
  2 2020-06-06T00:18:38  *** dgenr8 has quit IRC
  3 2020-06-06T00:18:52  *** ctrlbreak has quit IRC
  4 2020-06-06T00:19:16  *** ctrlbreak has joined #bitcoin-core-dev
  5 2020-06-06T00:21:24  *** peeja has joined #bitcoin-core-dev
  6 2020-06-06T00:26:47  *** promag has quit IRC
  7 2020-06-06T00:29:08  *** Chris_Stewart_5 has quit IRC
  8 2020-06-06T00:31:33  *** dgenr8 has joined #bitcoin-core-dev
  9 2020-06-06T00:41:05  *** Relis has quit IRC
 10 2020-06-06T00:49:24  *** mol has quit IRC
 11 2020-06-06T00:50:06  *** mol has joined #bitcoin-core-dev
 12 2020-06-06T00:55:30  *** Relis has joined #bitcoin-core-dev
 13 2020-06-06T00:58:09  *** Relis has quit IRC
 14 2020-06-06T00:58:44  *** Relis has joined #bitcoin-core-dev
 15 2020-06-06T01:07:12  *** AaronvanW has quit IRC
 16 2020-06-06T01:38:01  *** Relis has quit IRC
 17 2020-06-06T01:46:24  *** jarthur has joined #bitcoin-core-dev
 18 2020-06-06T02:14:12  *** proofofkeags has joined #bitcoin-core-dev
 19 2020-06-06T02:19:42  *** jarthur has quit IRC
 20 2020-06-06T02:23:55  *** proofofkeags has quit IRC
 21 2020-06-06T02:27:41  *** bitcoin-git has joined #bitcoin-core-dev
 22 2020-06-06T02:27:41  <bitcoin-git> [bitcoin] sipa opened pull request #19184: Overhaul transaction request logic (master...202004_txrequest_rand) https://github.com/bitcoin/bitcoin/pull/19184
 23 2020-06-06T02:27:42  *** bitcoin-git has left #bitcoin-core-dev
 24 2020-06-06T02:31:37  *** jarthur has joined #bitcoin-core-dev
 25 2020-06-06T03:00:01  *** peeja has quit IRC
 26 2020-06-06T03:05:34  *** pi has joined #bitcoin-core-dev
 27 2020-06-06T03:10:07  *** pi has quit IRC
 28 2020-06-06T03:21:18  *** sendak has joined #bitcoin-core-dev
 29 2020-06-06T03:33:56  *** tryphe_ has joined #bitcoin-core-dev
 30 2020-06-06T03:35:50  *** shesek has quit IRC
 31 2020-06-06T03:36:14  *** shesek has joined #bitcoin-core-dev
 32 2020-06-06T03:36:14  *** shesek has joined #bitcoin-core-dev
 33 2020-06-06T03:36:54  *** tryphe has quit IRC
 34 2020-06-06T03:47:34  *** proofofkeags has joined #bitcoin-core-dev
 35 2020-06-06T03:52:06  *** proofofkeags has quit IRC
 36 2020-06-06T04:20:35  *** vasild_ has joined #bitcoin-core-dev
 37 2020-06-06T04:23:27  *** proofofkeags has joined #bitcoin-core-dev
 38 2020-06-06T04:23:43  *** vasild has quit IRC
 39 2020-06-06T04:23:44  *** vasild_ is now known as vasild
 40 2020-06-06T04:27:20  *** morcos has quit IRC
 41 2020-06-06T04:28:33  *** proofofkeags has quit IRC
 42 2020-06-06T04:34:06  *** Highway61 has quit IRC
 43 2020-06-06T04:35:42  *** morcos has joined #bitcoin-core-dev
 44 2020-06-06T05:00:26  *** Highway61 has joined #bitcoin-core-dev
 45 2020-06-06T06:00:02  *** sendak has quit IRC
 46 2020-06-06T06:20:54  *** tryphe_ is now known as tryphe
 47 2020-06-06T06:21:49  *** langseth1 has joined #bitcoin-core-dev
 48 2020-06-06T06:24:13  *** proofofkeags has joined #bitcoin-core-dev
 49 2020-06-06T06:25:34  *** bitcoin-git has joined #bitcoin-core-dev
 50 2020-06-06T06:25:35  <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/0fc6ea216c00...17cfa52d3806
 51 2020-06-06T06:25:35  <bitcoin-git> bitcoin/master 7dda912 Hennadii Stepanov: test: Do not swallow flake8 exit code
 52 2020-06-06T06:25:36  <bitcoin-git> bitcoin/master 5d77549 Hennadii Stepanov: doc: Add mypy to test dependencies
 53 2020-06-06T06:25:36  <bitcoin-git> bitcoin/master 17cfa52 fanquake: Merge #19172: test: Do not swallow flake8 exit code
 54 2020-06-06T06:25:38  *** bitcoin-git has left #bitcoin-core-dev
 55 2020-06-06T06:25:54  *** bitcoin-git has joined #bitcoin-core-dev
 56 2020-06-06T06:25:54  <bitcoin-git> [bitcoin] fanquake merged pull request #19172: test: Do not swallow flake8 exit code (master...200605-mypy) https://github.com/bitcoin/bitcoin/pull/19172
 57 2020-06-06T06:25:55  *** bitcoin-git has left #bitcoin-core-dev
 58 2020-06-06T06:28:33  *** proofofkeags has quit IRC
 59 2020-06-06T06:31:17  *** Kiminuo has joined #bitcoin-core-dev
 60 2020-06-06T06:49:36  *** braydonf has joined #bitcoin-core-dev
 61 2020-06-06T07:02:15  *** bitcoin-git has joined #bitcoin-core-dev
 62 2020-06-06T07:02:15  <bitcoin-git> [bitcoin] hebasto closed pull request #18927: Pass bilingual_str argument to AbortNode() (master...200510-abort) https://github.com/bitcoin/bitcoin/pull/18927
 63 2020-06-06T07:02:16  *** bitcoin-git has left #bitcoin-core-dev
 64 2020-06-06T07:02:35  *** bitcoin-git has joined #bitcoin-core-dev
 65 2020-06-06T07:02:35  <bitcoin-git> [bitcoin] hebasto reopened pull request #18927: Pass bilingual_str argument to AbortNode() (master...200510-abort) https://github.com/bitcoin/bitcoin/pull/18927
 66 2020-06-06T07:02:36  *** bitcoin-git has left #bitcoin-core-dev
 67 2020-06-06T07:21:59  *** Talkless has joined #bitcoin-core-dev
 68 2020-06-06T07:30:34  *** Talkless has quit IRC
 69 2020-06-06T08:04:56  *** Talkless has joined #bitcoin-core-dev
 70 2020-06-06T08:08:30  *** marcoagner has joined #bitcoin-core-dev
 71 2020-06-06T08:16:11  <jonatack> any preference in naming for an assertion that an amount has the expected number of digits after the decimal? i'm thinking "assert_scale", "assert_fractional_part_size", "assert_mantissa_length", "assert_decimal_places", etc.
 72 2020-06-06T08:23:38  <jonatack> going with "assert_scale" and an explanatory docstring for now
 73 2020-06-06T08:25:10  *** proofofkeags has joined #bitcoin-core-dev
 74 2020-06-06T08:29:48  *** proofofkeags has quit IRC
 75 2020-06-06T08:36:10  *** harrigan has quit IRC
 76 2020-06-06T08:36:22  *** harrigan has joined #bitcoin-core-dev
 77 2020-06-06T09:00:01  *** langseth1 has quit IRC
 78 2020-06-06T09:21:41  *** jdsharp has joined #bitcoin-core-dev
 79 2020-06-06T09:22:41  *** Relis has joined #bitcoin-core-dev
 80 2020-06-06T09:25:52  *** AaronvanW has joined #bitcoin-core-dev
 81 2020-06-06T09:26:49  *** promag has joined #bitcoin-core-dev
 82 2020-06-06T09:27:18  *** promag has quit IRC
 83 2020-06-06T09:29:14  *** harrigan has quit IRC
 84 2020-06-06T09:30:56  *** harrigan has joined #bitcoin-core-dev
 85 2020-06-06T09:32:31  *** Relis has quit IRC
 86 2020-06-06T10:03:18  *** Kade88Reilly has joined #bitcoin-core-dev
 87 2020-06-06T10:17:16  *** Relis has joined #bitcoin-core-dev
 88 2020-06-06T10:26:54  *** baldur has quit IRC
 89 2020-06-06T10:31:05  *** Kade88Reilly has quit IRC
 90 2020-06-06T10:38:02  *** Kiminuo has quit IRC
 91 2020-06-06T10:38:10  *** AaronvanW has quit IRC
 92 2020-06-06T10:39:58  *** baldur has joined #bitcoin-core-dev
 93 2020-06-06T10:41:41  <ryanofsky> phantomcircuit, to fix link errors you may need to move blockfilter.cpp from libbitcoin_server library to libbitcoin_util library in makefile
 94 2020-06-06T10:42:36  <ryanofsky> wallet isn't linked against libbitcoin_server to prevent wallet code from trying to access node global variables
 95 2020-06-06T10:43:55  <ryanofsky> but a lot of things in libbitcoin_server that are just utilities without server state don't really belong there
 96 2020-06-06T11:00:30  *** justanotheruser has quit IRC
 97 2020-06-06T11:13:26  *** bitcoin-git has joined #bitcoin-core-dev
 98 2020-06-06T11:13:27  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19185: [0.19] Fix GBT: Restore "!segwit" and "csv" to "rules" key (0.19...fix_gbt_buried) https://github.com/bitcoin/bitcoin/pull/19185
 99 2020-06-06T11:13:27  *** bitcoin-git has left #bitcoin-core-dev
100 2020-06-06T11:15:40  *** bitcoin-git has joined #bitcoin-core-dev
101 2020-06-06T11:15:40  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #19185: [0.19] Fix GBT: Restore "!segwit" and "csv" to "rules" key (0.19...fix_gbt_buried) https://github.com/bitcoin/bitcoin/pull/19185
102 2020-06-06T11:15:41  *** bitcoin-git has left #bitcoin-core-dev
103 2020-06-06T11:17:51  *** EagleTM has joined #bitcoin-core-dev
104 2020-06-06T11:30:19  *** justanotheruser has joined #bitcoin-core-dev
105 2020-06-06T11:32:40  *** bitcoin-git has joined #bitcoin-core-dev
106 2020-06-06T11:32:41  <bitcoin-git> [bitcoin] hebasto closed pull request #18927: Pass bilingual_str argument to AbortNode() (master...200510-abort) https://github.com/bitcoin/bitcoin/pull/18927
107 2020-06-06T11:32:50  *** bitcoin-git has left #bitcoin-core-dev
108 2020-06-06T11:33:05  *** bitcoin-git has joined #bitcoin-core-dev
109 2020-06-06T11:33:06  <bitcoin-git> [bitcoin] hebasto reopened pull request #18927: Pass bilingual_str argument to AbortNode() (master...200510-abort) https://github.com/bitcoin/bitcoin/pull/18927
110 2020-06-06T11:33:06  *** bitcoin-git has left #bitcoin-core-dev
111 2020-06-06T12:00:02  *** jdsharp has quit IRC
112 2020-06-06T12:15:00  *** bitcoin-git has joined #bitcoin-core-dev
113 2020-06-06T12:15:01  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19188: 2006 test no shadow field (master...2006-testNoShadowField) https://github.com/bitcoin/bitcoin/pull/19188
114 2020-06-06T12:15:02  *** bitcoin-git has left #bitcoin-core-dev
115 2020-06-06T12:20:24  *** sendak has joined #bitcoin-core-dev
116 2020-06-06T12:26:55  *** proofofkeags has joined #bitcoin-core-dev
117 2020-06-06T12:28:06  *** Guyver2 has joined #bitcoin-core-dev
118 2020-06-06T12:31:43  *** proofofkeags has quit IRC
119 2020-06-06T12:46:49  *** dviola has joined #bitcoin-core-dev
120 2020-06-06T12:49:53  *** Chris_Stewart_5 has joined #bitcoin-core-dev
121 2020-06-06T13:03:56  *** Kiminuo has joined #bitcoin-core-dev
122 2020-06-06T13:04:24  *** sendak has quit IRC
123 2020-06-06T13:05:00  *** guest534543 has joined #bitcoin-core-dev
124 2020-06-06T13:08:36  *** Kiminuo has quit IRC
125 2020-06-06T13:53:03  *** bitcoin-git has joined #bitcoin-core-dev
126 2020-06-06T13:53:04  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/17cfa52d3806...b1b173994406
127 2020-06-06T13:53:05  <bitcoin-git> bitcoin/master fa3999f MarcoFalke: net: Reformat excessively long if condition into multiple lines
128 2020-06-06T13:53:06  <bitcoin-git> bitcoin/master fa9604c MarcoFalke: doc: noban precludes maxuploadtarget disconnects
129 2020-06-06T13:53:06  <bitcoin-git> bitcoin/master b1b1739 MarcoFalke: Merge #18968: doc: noban precludes maxuploadtarget disconnects
130 2020-06-06T13:53:08  *** bitcoin-git has left #bitcoin-core-dev
131 2020-06-06T13:53:23  *** bitcoin-git has joined #bitcoin-core-dev
132 2020-06-06T13:53:23  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18968: doc: noban precludes maxuploadtarget disconnects (master...2005-docMaxuploadtarget) https://github.com/bitcoin/bitcoin/pull/18968
133 2020-06-06T13:53:24  *** bitcoin-git has left #bitcoin-core-dev
134 2020-06-06T13:55:39  *** EagleTM has quit IRC
135 2020-06-06T14:02:32  *** bitcoin-git has joined #bitcoin-core-dev
136 2020-06-06T14:02:32  <bitcoin-git> [bitcoin] hebasto opened pull request #19189: refactor: Replace RecursiveMutex with Mutex in timedata.cpp (master...200605-timedata) https://github.com/bitcoin/bitcoin/pull/19189
137 2020-06-06T14:02:33  *** bitcoin-git has left #bitcoin-core-dev
138 2020-06-06T14:15:31  *** ernesto has joined #bitcoin-core-dev
139 2020-06-06T14:16:10  *** ernesto has left #bitcoin-core-dev
140 2020-06-06T14:21:12  *** DuncanT1 has joined #bitcoin-core-dev
141 2020-06-06T14:37:48  *** bitcoin-git has joined #bitcoin-core-dev
142 2020-06-06T14:37:48  <bitcoin-git> [bitcoin] hebasto opened pull request #19190: refactor: Replace RecursiveMutex with Mutex in netbase.cpp (master...200606-netbase) https://github.com/bitcoin/bitcoin/pull/19190
143 2020-06-06T14:37:49  *** bitcoin-git has left #bitcoin-core-dev
144 2020-06-06T14:43:24  *** Relis has quit IRC
145 2020-06-06T14:54:20  *** Relis has joined #bitcoin-core-dev
146 2020-06-06T15:00:01  *** DuncanT1 has quit IRC
147 2020-06-06T15:02:04  *** proofofkeags has joined #bitcoin-core-dev
148 2020-06-06T15:05:38  *** bitcoin-git has joined #bitcoin-core-dev
149 2020-06-06T15:05:38  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19191: net: Extract download permission from noban (master...2006-netPerDow) https://github.com/bitcoin/bitcoin/pull/19191
150 2020-06-06T15:05:39  *** bitcoin-git has left #bitcoin-core-dev
151 2020-06-06T15:20:43  *** Bjarki has joined #bitcoin-core-dev
152 2020-06-06T15:35:42  *** mol has quit IRC
153 2020-06-06T15:38:40  *** mol has joined #bitcoin-core-dev
154 2020-06-06T16:19:06  *** owowo has quit IRC
155 2020-06-06T16:23:43  *** owowo has joined #bitcoin-core-dev
156 2020-06-06T16:23:43  *** vasild has quit IRC
157 2020-06-06T16:30:41  *** vasild has joined #bitcoin-core-dev
158 2020-06-06T16:38:23  *** EagleTM has joined #bitcoin-core-dev
159 2020-06-06T16:47:41  *** Kiminuo has joined #bitcoin-core-dev
160 2020-06-06T16:51:33  *** guest534543 has quit IRC
161 2020-06-06T16:52:13  *** promag has joined #bitcoin-core-dev
162 2020-06-06T16:56:48  *** promag has quit IRC
163 2020-06-06T17:20:42  *** bitcoin-git has joined #bitcoin-core-dev
164 2020-06-06T17:20:42  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19192: doc: Extract net permissions doc (master...2006-docNetPerm) https://github.com/bitcoin/bitcoin/pull/19192
165 2020-06-06T17:20:43  *** bitcoin-git has left #bitcoin-core-dev
166 2020-06-06T17:26:55  *** EagleTM has quit IRC
167 2020-06-06T17:35:20  *** bitcoin-git has joined #bitcoin-core-dev
168 2020-06-06T17:35:21  <bitcoin-git> [bitcoin] hebasto opened pull request #19193: refactor, qt, net: Deduplicate NumConnections enum (master...200606-numconn) https://github.com/bitcoin/bitcoin/pull/19193
169 2020-06-06T17:35:21  *** bitcoin-git has left #bitcoin-core-dev
170 2020-06-06T17:56:28  *** bitcoin-git has joined #bitcoin-core-dev
171 2020-06-06T17:56:28  <bitcoin-git> [bitcoin] miztake opened pull request #19194: util: Don't reference errno when pthread fails. (master...prototype) https://github.com/bitcoin/bitcoin/pull/19194
172 2020-06-06T17:56:29  *** bitcoin-git has left #bitcoin-core-dev
173 2020-06-06T18:00:02  *** Bjarki has quit IRC
174 2020-06-06T18:06:21  *** jarthur has quit IRC
175 2020-06-06T18:07:02  *** jarthur has joined #bitcoin-core-dev
176 2020-06-06T18:11:26  <jarthur> Does the REST API use libevent goodness?
177 2020-06-06T18:13:01  <fjahr> jarthur: yes
178 2020-06-06T18:13:05  <jarthur> ty
179 2020-06-06T18:14:38  *** dviola has quit IRC
180 2020-06-06T18:21:11  <phantomcircuit> eyyyy using a filter with fixed siphash parameters and 30 bits does a wallet rescan in 4.6 minutes
181 2020-06-06T18:55:16  *** harrigan has quit IRC
182 2020-06-06T18:56:21  *** Iam_thor has joined #bitcoin-core-dev
183 2020-06-06T18:57:00  *** harrigan has joined #bitcoin-core-dev
184 2020-06-06T19:00:56  *** belcher has quit IRC
185 2020-06-06T19:03:17  *** bitdex has joined #bitcoin-core-dev
186 2020-06-06T19:11:30  <sipa> phantomcircuit: nice
187 2020-06-06T19:20:58  *** EagleTM has joined #bitcoin-core-dev
188 2020-06-06T19:37:40  *** Relis has quit IRC
189 2020-06-06T19:38:54  *** Relis has joined #bitcoin-core-dev
190 2020-06-06T20:19:44  <phantomcircuit> sipa, i also realized last night i was still loading the blocks when i did the BASIC filter benchmarks so im redoing those correctly
191 2020-06-06T20:19:55  <phantomcircuit> i can tell from the heat of my laptop that it's much much slower though
192 2020-06-06T20:25:49  *** dongcarl has quit IRC
193 2020-06-06T20:32:54  *** Kiminuo has quit IRC
194 2020-06-06T20:40:51  *** promag has joined #bitcoin-core-dev
195 2020-06-06T20:42:41  *** EagleTM has quit IRC
196 2020-06-06T20:43:46  *** Guyver2 has quit IRC
197 2020-06-06T20:48:59  *** EagleTM has joined #bitcoin-core-dev
198 2020-06-06T20:53:40  <phantomcircuit> sipa, there's some house keeping stuff to do in the ScanForWalletTransactions method that could be a separate pr and are trivial, should i do that?
199 2020-06-06T20:53:48  <phantomcircuit> im not sure what the thinking is on that right now
200 2020-06-06T21:00:02  *** Iam_thor has quit IRC
201 2020-06-06T21:20:46  *** bitcoin-git has joined #bitcoin-core-dev
202 2020-06-06T21:20:47  <bitcoin-git> [bitcoin] pstratem opened pull request #19195: wallet: ScanForWalletTransactions cleanup (master...2020-06-06-scanforwallettransactions-cleanup) https://github.com/bitcoin/bitcoin/pull/19195
203 2020-06-06T21:20:47  *** bitcoin-git has left #bitcoin-core-dev
204 2020-06-06T21:21:14  *** kormoc1 has joined #bitcoin-core-dev
205 2020-06-06T21:27:39  <phantomcircuit> btw is master broken? make check "ERROR: ConnectBlock(): coinbase pays too much (actual=5010000000 vs limit=5000000000)"
206 2020-06-06T21:30:04  <sipa> phantomcircuit: when?
207 2020-06-06T21:34:00  <phantomcircuit> no it's just my branch that has nothing to do with the coinbase values
208 2020-06-06T21:34:01  <phantomcircuit> what
209 2020-06-06T21:36:20  *** EagleTM has quit IRC
210 2020-06-06T21:37:39  *** filchef has joined #bitcoin-core-dev
211 2020-06-06T21:55:41  *** jarthur has quit IRC
212 2020-06-06T21:58:32  *** jarthur has joined #bitcoin-core-dev
213 2020-06-06T22:02:09  *** harrigan- has joined #bitcoin-core-dev
214 2020-06-06T22:02:29  <phantomcircuit> oh hmm findNextBlock has identical results for a reorg and a straight failure to load the block
215 2020-06-06T22:03:14  <phantomcircuit> so the wallet test is expecting FAILURE when im returning success because the reorg flag is set, but the reorg flag doesn't mean reorg it means reorg or the block couldn't be found
216 2020-06-06T22:03:39  *** harrigan has quit IRC
217 2020-06-06T22:04:51  *** EagleTM has joined #bitcoin-core-dev
218 2020-06-06T22:05:28  *** lightlike has joined #bitcoin-core-dev
219 2020-06-06T22:17:38  <phantomcircuit> right there's no way to distinguish between the start block is invalid and the start block was reorg'd so this test is just bad
220 2020-06-06T22:18:30  *** Talkless has quit IRC
221 2020-06-06T22:28:57  *** lightlike has quit IRC
222 2020-06-06T22:29:39  *** marcoagner has quit IRC
223 2020-06-06T22:37:24  *** jarthur has quit IRC
224 2020-06-06T22:54:38  *** jeremyrubin has quit IRC
225 2020-06-06T23:03:03  *** Zenton has quit IRC
226 2020-06-06T23:03:21  *** Zenton has joined #bitcoin-core-dev
227 2020-06-06T23:07:03  *** ja has left #bitcoin-core-dev
228 2020-06-06T23:51:10  *** promag has quit IRC
229 2020-06-06T23:53:26  *** mol has quit IRC
230 2020-06-06T23:53:51  *** mol has joined #bitcoin-core-dev
231 2020-06-06T23:55:36  *** jarthur has joined #bitcoin-core-dev
232 2020-06-06T23:56:04  *** jarthur_ has joined #bitcoin-core-dev
233 2020-06-06T23:59:41  *** jarthur has quit IRC