1 2020-06-07T00:00:01 *** kormoc1 has quit IRC
2 2020-06-07T00:02:14 *** michagogo_ is now known as michagogo
3 2020-06-07T00:06:00 *** pretyflaco has joined #bitcoin-core-dev
4 2020-06-07T00:21:39 *** justanotheruser has quit IRC
5 2020-06-07T00:21:52 *** ajpiano1 has joined #bitcoin-core-dev
6 2020-06-07T00:22:20 *** promag has joined #bitcoin-core-dev
7 2020-06-07T00:27:14 *** promag has quit IRC
8 2020-06-07T00:29:22 *** justanotheruser has joined #bitcoin-core-dev
9 2020-06-07T00:41:39 *** mol_ has joined #bitcoin-core-dev
10 2020-06-07T00:44:02 *** mol has quit IRC
11 2020-06-07T00:44:33 *** jarthur_ has quit IRC
12 2020-06-07T00:47:13 *** jarthur has joined #bitcoin-core-dev
13 2020-06-07T00:47:51 *** jarthur_ has joined #bitcoin-core-dev
14 2020-06-07T00:51:32 *** jarthur has quit IRC
15 2020-06-07T01:00:17 *** bitcoin-git has joined #bitcoin-core-dev
16 2020-06-07T01:00:17 <bitcoin-git> [bitcoin] svannord opened pull request #19196: Create Starting Out (master...patch-1) https://github.com/bitcoin/bitcoin/pull/19196
17 2020-06-07T01:00:18 *** bitcoin-git has left #bitcoin-core-dev
18 2020-06-07T01:01:02 *** bitcoin-git has joined #bitcoin-core-dev
19 2020-06-07T01:01:02 <bitcoin-git> [bitcoin] fanquake closed pull request #19196: Create Starting Out (master...patch-1) https://github.com/bitcoin/bitcoin/pull/19196
20 2020-06-07T01:01:03 *** bitcoin-git has left #bitcoin-core-dev
21 2020-06-07T01:12:55 *** promag has joined #bitcoin-core-dev
22 2020-06-07T01:14:35 *** justanotheruser has quit IRC
23 2020-06-07T01:17:55 *** justanotheruser has joined #bitcoin-core-dev
24 2020-06-07T01:30:17 *** mdunnio has joined #bitcoin-core-dev
25 2020-06-07T01:38:47 *** mdunnio has quit IRC
26 2020-06-07T01:39:54 *** Squidicc has quit IRC
27 2020-06-07T01:44:31 *** Relis has quit IRC
28 2020-06-07T01:54:45 *** Relis has joined #bitcoin-core-dev
29 2020-06-07T02:12:49 *** pretyflaco has quit IRC
30 2020-06-07T02:14:15 *** promag has quit IRC
31 2020-06-07T02:38:30 *** Relis has quit IRC
32 2020-06-07T03:00:02 *** ajpiano1 has quit IRC
33 2020-06-07T03:01:07 *** jarthur_ is now known as jarthur
34 2020-06-07T03:04:28 <phantomcircuit> sipa, for the asmap stuff is there a simple "is this ip in this asn?" function?
35 2020-06-07T03:17:24 <sipa> phantomcircuit: my asmap tool PR has a lookup function
36 2020-06-07T03:17:36 <sipa> i also have python code that can do the same
37 2020-06-07T03:18:01 <sipa> #18573
38 2020-06-07T03:18:04 <gribble> https://github.com/bitcoin/bitcoin/issues/18573 | [RFC] bitcoin-asmap utility by sipa · Pull Request #18573 · bitcoin/bitcoin · GitHub
39 2020-06-07T03:20:13 <sipa> also testmap.py in https://github.com/sipa/asmap
40 2020-06-07T03:20:22 *** Eagle[TM] has joined #bitcoin-core-dev
41 2020-06-07T03:21:50 <sipa> phantomcircuit: or you mean inside bitcoin core codebase? GetMappedAs in CNetAddr
42 2020-06-07T03:21:57 *** EagleTM has quit IRC
43 2020-06-07T03:22:21 *** rob01 has joined #bitcoin-core-dev
44 2020-06-07T03:35:34 *** justan0theruser has joined #bitcoin-core-dev
45 2020-06-07T03:35:53 *** shesek has quit IRC
46 2020-06-07T03:36:20 *** shesek has joined #bitcoin-core-dev
47 2020-06-07T03:36:20 *** shesek has joined #bitcoin-core-dev
48 2020-06-07T03:37:05 *** justanotheruser has quit IRC
49 2020-06-07T04:20:38 *** vasild_ has joined #bitcoin-core-dev
50 2020-06-07T04:21:46 *** mdunnio has joined #bitcoin-core-dev
51 2020-06-07T04:23:43 *** vasild has quit IRC
52 2020-06-07T04:23:44 *** vasild_ is now known as vasild
53 2020-06-07T04:24:33 *** Highway61 has quit IRC
54 2020-06-07T04:27:38 *** vasild has quit IRC
55 2020-06-07T04:35:57 *** vasild has joined #bitcoin-core-dev
56 2020-06-07T04:36:11 *** mdunnio has quit IRC
57 2020-06-07T04:40:18 *** mdunnio has joined #bitcoin-core-dev
58 2020-06-07T04:46:36 *** mdunnio has quit IRC
59 2020-06-07T05:12:58 *** sdaftuar has quit IRC
60 2020-06-07T05:13:47 *** sdaftuar has joined #bitcoin-core-dev
61 2020-06-07T05:37:45 *** bitcoin-git has joined #bitcoin-core-dev
62 2020-06-07T05:37:45 <bitcoin-git> [bitcoin] fanquake opened pull request #19197: init: use std::thread for ThreadImport() (master...thread_import_no_boost) https://github.com/bitcoin/bitcoin/pull/19197
63 2020-06-07T05:37:46 *** bitcoin-git has left #bitcoin-core-dev
64 2020-06-07T05:38:01 *** rh0nj has quit IRC
65 2020-06-07T05:39:08 *** rh0nj has joined #bitcoin-core-dev
66 2020-06-07T05:58:28 *** Kiminuo has joined #bitcoin-core-dev
67 2020-06-07T06:00:01 *** rob01 has quit IRC
68 2020-06-07T06:12:58 *** justan0theruser has quit IRC
69 2020-06-07T06:16:00 *** justanotheruser has joined #bitcoin-core-dev
70 2020-06-07T06:22:21 *** jaekwon has joined #bitcoin-core-dev
71 2020-06-07T06:31:15 <phantomcircuit> sipa, i mean for banning by AS
72 2020-06-07T06:33:55 <phantomcircuit> sipa, is there a reason the asmap isn't a global? seems like something that should be a global
73 2020-06-07T06:41:57 <sipa> phantomcircuit: i think connman or addrman is a reasonable place for.it
74 2020-06-07T06:42:03 <sipa> i forget where it's held
75 2020-06-07T07:29:44 *** Talkless has joined #bitcoin-core-dev
76 2020-06-07T07:35:28 *** mdunnio has joined #bitcoin-core-dev
77 2020-06-07T07:51:58 *** mdunnio has quit IRC
78 2020-06-07T08:17:31 *** filchef has joined #bitcoin-core-dev
79 2020-06-07T08:21:38 *** justanotheruser has quit IRC
80 2020-06-07T08:23:21 *** ccook_ has joined #bitcoin-core-dev
81 2020-06-07T08:23:27 *** ccook has quit IRC
82 2020-06-07T08:23:27 *** ccook_ is now known as ccook
83 2020-06-07T08:25:30 *** justanotheruser has joined #bitcoin-core-dev
84 2020-06-07T08:25:31 *** marcinja has quit IRC
85 2020-06-07T08:25:43 *** marcinja has joined #bitcoin-core-dev
86 2020-06-07T08:35:06 *** pinheadmz has quit IRC
87 2020-06-07T08:35:06 *** sanket1729 has quit IRC
88 2020-06-07T08:35:06 *** cncr04s has quit IRC
89 2020-06-07T08:36:01 *** pinheadmz has joined #bitcoin-core-dev
90 2020-06-07T08:36:21 *** sanket1729 has joined #bitcoin-core-dev
91 2020-06-07T08:36:21 *** cncr04s has joined #bitcoin-core-dev
92 2020-06-07T08:48:41 *** Eagle[TM] has quit IRC
93 2020-06-07T09:00:02 *** jaekwon has quit IRC
94 2020-06-07T09:03:15 *** Kiminuo has quit IRC
95 2020-06-07T09:22:32 *** nickr has joined #bitcoin-core-dev
96 2020-06-07T09:33:00 *** promag has joined #bitcoin-core-dev
97 2020-06-07T09:34:22 *** ctrlbreak_MAD has joined #bitcoin-core-dev
98 2020-06-07T09:37:27 *** ctrlbreak has quit IRC
99 2020-06-07T09:47:46 *** AaronvanW has joined #bitcoin-core-dev
100 2020-06-07T09:57:20 *** Emcy has quit IRC
101 2020-06-07T10:02:46 *** sdaftuar has quit IRC
102 2020-06-07T10:03:21 *** Myra34Moore has joined #bitcoin-core-dev
103 2020-06-07T10:03:29 *** sdaftuar has joined #bitcoin-core-dev
104 2020-06-07T10:08:15 *** Myra34Moore has quit IRC
105 2020-06-07T10:27:09 *** Emcy has joined #bitcoin-core-dev
106 2020-06-07T10:28:52 *** promag has quit IRC
107 2020-06-07T10:31:13 *** jarthur has quit IRC
108 2020-06-07T10:38:39 *** Landryl has quit IRC
109 2020-06-07T10:43:41 *** bitcoin-git has joined #bitcoin-core-dev
110 2020-06-07T10:43:42 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b1b173994406...1b90a7b61a37
111 2020-06-07T10:43:42 <bitcoin-git> bitcoin/master 501e6ab Calvin Kim: doc: Add documentation for 'checklevel' argument in 'verifychain' RPC call
112 2020-06-07T10:43:42 <bitcoin-git> bitcoin/master 1b90a7b MarcoFalke: Merge #19005: doc: Add documentation for 'checklevel' argument in 'verifyc...
113 2020-06-07T10:43:43 *** bitcoin-git has left #bitcoin-core-dev
114 2020-06-07T10:44:01 *** bitcoin-git has joined #bitcoin-core-dev
115 2020-06-07T10:44:02 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19005: doc: Add documentation for 'checklevel' argument in 'verifychain' RPC⦠(master...add-documentation-for-verifychain) https://github.com/bitcoin/bitcoin/pull/19005
116 2020-06-07T10:44:03 *** bitcoin-git has left #bitcoin-core-dev
117 2020-06-07T11:21:30 *** Relis has joined #bitcoin-core-dev
118 2020-06-07T11:26:56 *** Relis has quit IRC
119 2020-06-07T11:28:48 *** Highway61 has joined #bitcoin-core-dev
120 2020-06-07T11:43:59 *** pretyflaco has joined #bitcoin-core-dev
121 2020-06-07T11:44:32 *** pretyflaco1 has joined #bitcoin-core-dev
122 2020-06-07T11:45:13 *** pretyflaco has quit IRC
123 2020-06-07T11:54:29 *** Relis has joined #bitcoin-core-dev
124 2020-06-07T11:56:32 *** Relis has quit IRC
125 2020-06-07T11:58:47 *** Kiminuo has joined #bitcoin-core-dev
126 2020-06-07T12:00:02 *** nickr has quit IRC
127 2020-06-07T12:01:30 *** Relis has joined #bitcoin-core-dev
128 2020-06-07T12:14:20 *** AaronvanW has quit IRC
129 2020-06-07T12:17:40 *** pretyflaco1 is now known as pretyflaco
130 2020-06-07T12:21:01 *** ski1 has joined #bitcoin-core-dev
131 2020-06-07T12:30:25 *** gribble has quit IRC
132 2020-06-07T12:40:49 *** gribble has joined #bitcoin-core-dev
133 2020-06-07T12:48:34 *** pretyflaco has quit IRC
134 2020-06-07T12:50:42 *** pretyflaco has joined #bitcoin-core-dev
135 2020-06-07T13:03:14 *** pretyflaco has quit IRC
136 2020-06-07T13:07:35 *** Landryl has joined #bitcoin-core-dev
137 2020-06-07T13:41:16 *** DeanGuss has quit IRC
138 2020-06-07T13:44:17 *** bitcoin-git has joined #bitcoin-core-dev
139 2020-06-07T13:44:17 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19198: test: Check that peers with forcerelay permission are not asked to feefilter (master...2006-testForcerelayFeefilter) https://github.com/bitcoin/bitcoin/pull/19198
140 2020-06-07T13:44:18 *** bitcoin-git has left #bitcoin-core-dev
141 2020-06-07T14:05:26 *** dviola has joined #bitcoin-core-dev
142 2020-06-07T14:08:21 *** Bullitje has joined #bitcoin-core-dev
143 2020-06-07T14:09:26 *** Bullitje has quit IRC
144 2020-06-07T14:09:47 *** troygiorshev has quit IRC
145 2020-06-07T14:09:57 *** bitcoin-git has joined #bitcoin-core-dev
146 2020-06-07T14:09:57 <bitcoin-git> [bitcoin] jonatack opened pull request #19200: rpc: remove deprecated getaddressinfo fields (master...remove-deprecated-getaddressinfo-fields) https://github.com/bitcoin/bitcoin/pull/19200
147 2020-06-07T14:09:58 *** bitcoin-git has left #bitcoin-core-dev
148 2020-06-07T14:10:41 *** Bullitje has joined #bitcoin-core-dev
149 2020-06-07T14:16:45 *** looping747 has joined #bitcoin-core-dev
150 2020-06-07T14:17:00 *** molz_ has joined #bitcoin-core-dev
151 2020-06-07T14:19:51 *** mol_ has quit IRC
152 2020-06-07T14:23:08 *** looping747 has quit IRC
153 2020-06-07T14:24:28 *** Guyver2 has joined #bitcoin-core-dev
154 2020-06-07T14:26:42 *** mol_ has joined #bitcoin-core-dev
155 2020-06-07T14:30:14 *** molz_ has quit IRC
156 2020-06-07T14:32:19 *** bitcoin-git has joined #bitcoin-core-dev
157 2020-06-07T14:32:19 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19201: ci: Switch to bitcoincore.org download (master...2006-ci404) https://github.com/bitcoin/bitcoin/pull/19201
158 2020-06-07T14:32:20 *** bitcoin-git has left #bitcoin-core-dev
159 2020-06-07T14:34:07 *** promag has joined #bitcoin-core-dev
160 2020-06-07T14:37:49 *** troygiorshev has joined #bitcoin-core-dev
161 2020-06-07T14:42:34 *** promag has quit IRC
162 2020-06-07T14:42:59 *** bitcoin-git has joined #bitcoin-core-dev
163 2020-06-07T14:42:59 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1b90a7b61a37...43695b0cf851
164 2020-06-07T14:43:00 <bitcoin-git> bitcoin/master fa4cd1f MarcoFalke: ci: Switch to bitcoincore.org download
165 2020-06-07T14:43:00 <bitcoin-git> bitcoin/master 43695b0 MarcoFalke: Merge #19201: ci: Switch to bitcoincore.org download
166 2020-06-07T14:43:02 *** bitcoin-git has left #bitcoin-core-dev
167 2020-06-07T14:43:19 *** bitcoin-git has joined #bitcoin-core-dev
168 2020-06-07T14:43:19 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19201: ci: Switch to bitcoincore.org download (master...2006-ci404) https://github.com/bitcoin/bitcoin/pull/19201
169 2020-06-07T14:43:20 *** bitcoin-git has left #bitcoin-core-dev
170 2020-06-07T14:51:11 *** mol_ has quit IRC
171 2020-06-07T14:52:11 *** mol has joined #bitcoin-core-dev
172 2020-06-07T14:52:34 *** troygiorshev has quit IRC
173 2020-06-07T15:00:02 *** ski1 has quit IRC
174 2020-06-07T15:15:33 *** Victorsueca has quit IRC
175 2020-06-07T15:18:59 *** someone235 has quit IRC
176 2020-06-07T15:21:56 *** k0da has joined #bitcoin-core-dev
177 2020-06-07T15:26:28 *** proofofkeags has quit IRC
178 2020-06-07T15:32:16 *** bitcoin-git has joined #bitcoin-core-dev
179 2020-06-07T15:32:16 <bitcoin-git> [bitcoin] jonatack opened pull request #19202: log: remove deprecated `db` log category (master...remove-deprecated-db-log-category) https://github.com/bitcoin/bitcoin/pull/19202
180 2020-06-07T15:32:17 *** bitcoin-git has left #bitcoin-core-dev
181 2020-06-07T15:33:54 *** promag has joined #bitcoin-core-dev
182 2020-06-07T15:54:24 *** Kad34 has joined #bitcoin-core-dev
183 2020-06-07T15:55:13 *** promag has quit IRC
184 2020-06-07T15:56:32 *** Kad34 has quit IRC
185 2020-06-07T16:12:22 *** AaronvanW has joined #bitcoin-core-dev
186 2020-06-07T16:12:32 *** XORder has joined #bitcoin-core-dev
187 2020-06-07T16:16:11 *** davterra has quit IRC
188 2020-06-07T16:17:15 *** Luke has joined #bitcoin-core-dev
189 2020-06-07T16:20:34 *** vasild_ has joined #bitcoin-core-dev
190 2020-06-07T16:23:43 *** vasild has quit IRC
191 2020-06-07T16:23:44 *** vasild_ is now known as vasild
192 2020-06-07T16:32:22 *** promag has joined #bitcoin-core-dev
193 2020-06-07T16:32:40 *** bitcoin-git has joined #bitcoin-core-dev
194 2020-06-07T16:32:41 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/43695b0cf851...b3091b2be7d1
195 2020-06-07T16:32:41 <bitcoin-git> bitcoin/master 4c0c893 Jon Atack: log: remove deprecated `db` log category
196 2020-06-07T16:32:42 <bitcoin-git> bitcoin/master c514a4f Jon Atack: doc: release note for `db` log category removal
197 2020-06-07T16:32:42 <bitcoin-git> bitcoin/master b3091b2 MarcoFalke: Merge #19202: log: remove deprecated `db` log category
198 2020-06-07T16:32:44 *** bitcoin-git has left #bitcoin-core-dev
199 2020-06-07T16:33:00 *** bitcoin-git has joined #bitcoin-core-dev
200 2020-06-07T16:33:00 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19202: log: remove deprecated `db` log category (master...remove-deprecated-db-log-category) https://github.com/bitcoin/bitcoin/pull/19202
201 2020-06-07T16:33:01 *** bitcoin-git has left #bitcoin-core-dev
202 2020-06-07T16:37:03 *** promag has quit IRC
203 2020-06-07T16:46:50 *** Luke has quit IRC
204 2020-06-07T16:49:59 *** proofofkeags has joined #bitcoin-core-dev
205 2020-06-07T16:51:11 *** dviola has quit IRC
206 2020-06-07T16:57:59 *** proofofkeags has quit IRC
207 2020-06-07T16:58:32 *** proofofkeags has joined #bitcoin-core-dev
208 2020-06-07T17:02:41 *** jonatack has quit IRC
209 2020-06-07T17:03:18 *** Bullitje has quit IRC
210 2020-06-07T17:03:22 *** proofofkeags has quit IRC
211 2020-06-07T17:10:23 *** pretyflaco has joined #bitcoin-core-dev
212 2020-06-07T17:15:08 <phantomcircuit> sipa, can i get all of the subnets in an asn from the asmap?
213 2020-06-07T17:15:28 <sipa> not without decoding the entire thing
214 2020-06-07T17:15:36 <phantomcircuit> it looks like no
215 2020-06-07T17:15:45 <sipa> but that's still pretty fast
216 2020-06-07T17:16:00 <phantomcircuit> that makes adding asn based bans much harder but yeah definitely still doable
217 2020-06-07T17:16:11 <sipa> ah i see
218 2020-06-07T17:16:21 <sipa> you want to translate banned ASes to subnets
219 2020-06-07T17:16:31 <phantomcircuit> would it be reasonable to do that when adding asn bans? cause that changes it to like two lines of code from many more
220 2020-06-07T17:17:43 <luke-jr> maybe the banlist should support ASNs directly?
221 2020-06-07T17:17:51 <sipa> that would certainly be cleaner
222 2020-06-07T17:17:58 <sipa> but i see how that would be harder to implement
223 2020-06-07T17:18:26 <sipa> i think if banlists on disk supported ASes natively, but at runtime they're converted to subnets, maybe it's ok?
224 2020-06-07T17:18:39 <phantomcircuit> i can definitely support asn's directly instead, it's not something where one approach is obviously better to me though
225 2020-06-07T17:18:42 <sipa> so that they correctly persist across restarts if asmap gets updated
226 2020-06-07T17:20:42 <phantomcircuit> adding support naively will break backwards compat with banlist.dat though
227 2020-06-07T17:20:44 <luke-jr> sipa: nah imo
228 2020-06-07T17:21:10 <luke-jr> sipa: setban should support adding/removing AS bans, without affecting overlapping subnet bans, IMO
229 2020-06-07T17:21:18 <sipa> luke-jr: that's reasonable
230 2020-06-07T17:21:23 <luke-jr> plus we might want to update ASmaps at runtime someday
231 2020-06-07T17:22:00 *** davterra has joined #bitcoin-core-dev
232 2020-06-07T17:22:01 <sipa> phantomcircuit: i think it's expected that banlist.dat compatibility breaks when you ban an AS - there is no way for an old version to behave correctly
233 2020-06-07T17:22:17 *** Pavlenex has joined #bitcoin-core-dev
234 2020-06-07T17:22:18 <sipa> you wouldn't want to run with a partial set of bans
235 2020-06-07T17:22:26 <phantomcircuit> sipa, no i mean doing this naively would mean clearing all your old bans
236 2020-06-07T17:22:34 <sipa> why?
237 2020-06-07T17:22:47 <luke-jr> hmm
238 2020-06-07T17:23:04 <luke-jr> sipa: do we have a way to sanely handle an incompatible banlist in current/old versions?
239 2020-06-07T17:23:11 <sipa> no clue
240 2020-06-07T17:23:18 <luke-jr> losing the banlist entirely would be strictly worse than just losing AS bans
241 2020-06-07T17:23:19 <sipa> i have never looked at its serialization
242 2020-06-07T17:24:26 <sipa> agree
243 2020-06-07T17:24:31 <sipa> well
244 2020-06-07T17:24:39 <phantomcircuit> sipa, banlist.dat is basically just a serialized banmap_t which is a map of subnets
245 2020-06-07T17:24:49 <sipa> i think that if you add an AS ban, you should not lose existing subnet bans
246 2020-06-07T17:25:17 <sipa> but if you add an AS ban, and then downgrade to a version that does not support AS bans, ideally it just fails to start
247 2020-06-07T17:25:52 *** Pavlenex has quit IRC
248 2020-06-07T17:25:53 <sipa> phantomcircuit: banlist serialized entries have a version number
249 2020-06-07T17:26:04 <sipa> so there is no problem
250 2020-06-07T17:26:23 <sipa> just increment the version number of AS-based bans; but keep supporting the old subnet-only one in the deserializer
251 2020-06-07T17:27:09 <sipa> unfortunately the version number is not enforced
252 2020-06-07T17:27:21 <sipa> so old versions with read corrupted data
253 2020-06-07T17:28:04 <luke-jr> looks like if we change the root type (currently map<CSubNet, CBanEntry>) old versions should refuse to load it
254 2020-06-07T17:28:08 <phantomcircuit> that means changing a bunch of the logic for serialize/deserialize
255 2020-06-07T17:28:10 <luke-jr> and refuse to start
256 2020-06-07T17:28:40 <phantomcircuit> or i could just map asn's to subnet and it's potentially much less code and compatible...
257 2020-06-07T17:28:46 <luke-jr> sipa: there's a checksum to stop corrupted data
258 2020-06-07T17:29:05 <luke-jr> phantomcircuit: could make a new type that serialises the same for subnets?
259 2020-06-07T17:29:57 <luke-jr> and just serialise ::0/0 followed by AS info for anAS ban
260 2020-06-07T17:30:08 <luke-jr> the checksum should stop it from loading that as ::0/0 in old versions
261 2020-06-07T17:30:57 <luke-jr> (possibly stored as ::ASN/0 in memory to avoid wasting extra RAM
262 2020-06-07T17:30:58 <sipa> phantomcircuit: i'll have a look at making the ser/deser code more upgradable
263 2020-06-07T17:32:14 <phantomcircuit> sipa, the addrdb and bandb share the ser/deser logic to do this they probably just need to be split
264 2020-06-07T17:32:36 <sipa> phantomcircuit: perhaps
265 2020-06-07T17:32:49 <sipa> phantomcircuit: std::map is serialized with a size prefix
266 2020-06-07T17:33:07 <sipa> so we could change the serialization to stary with a giant number
267 2020-06-07T17:33:15 <sipa> to indicate a new version
268 2020-06-07T17:33:26 <sipa> so that it will fail to load on old versions
269 2020-06-07T17:33:32 <sipa> *start
270 2020-06-07T17:34:22 <phantomcircuit> just start with a dummy db that has a bad checksum
271 2020-06-07T17:34:36 <sipa> that's also possible
272 2020-06-07T17:35:33 <phantomcircuit> that seems like it would be more obvious
273 2020-06-07T17:35:55 *** XORder has quit IRC
274 2020-06-07T17:37:23 <phantomcircuit> also changing banmap_t is going to effect a whole bunch of logic
275 2020-06-07T17:38:05 <sipa> i know
276 2020-06-07T17:38:26 <sipa> but that code is due for a cleanup anyway, o think
277 2020-06-07T17:39:36 <sipa> *i
278 2020-06-07T17:40:44 <luke-jr> â¦
279 2020-06-07T17:41:33 <luke-jr> these all sound much more complex than what I just suggested :P
280 2020-06-07T17:42:20 <sipa> which is?
281 2020-06-07T17:45:52 <luke-jr> [17:29:56] <luke-jr> and just serialise ::0/0 followed by AS info for anAS ban
282 2020-06-07T17:46:49 <sipa> that won't work
283 2020-06-07T17:47:05 <luke-jr> why not?
284 2020-06-07T17:47:14 <sipa> it will result in old software reading corrupted datae
285 2020-06-07T17:47:20 <luke-jr> which will fail the checksum
286 2020-06-07T17:47:49 <sipa> ah, indeed!
287 2020-06-07T17:47:58 *** Sylveste has joined #bitcoin-core-dev
288 2020-06-07T17:48:18 *** justanotheruser has quit IRC
289 2020-06-07T17:48:44 <sipa> so you'd need a new data type instead of CSubNet to use as key in the map
290 2020-06-07T17:49:00 <sipa> which can represent either a CSubNet or an ASN
291 2020-06-07T17:49:10 <luke-jr> yes
292 2020-06-07T17:49:16 <sipa> and csubnet's remain serialized as-is
293 2020-06-07T17:49:20 <luke-jr> exactly
294 2020-06-07T17:49:37 *** pretyflaco has quit IRC
295 2020-06-07T17:49:53 *** pretyflaco has joined #bitcoin-core-dev
296 2020-06-07T17:50:17 <sipa> and ASN are serialized as some sentinel value that's unlikely to be already present in banmans (::0/0 seems right as luke-jr suggests) + version number + ASN
297 2020-06-07T17:50:38 *** Sylveste has quit IRC
298 2020-06-07T17:51:00 <luke-jr> I mean, we could use the CSubNet part for ASN data too, so long as we don't end up with the same length
299 2020-06-07T17:51:20 <sipa> it needs to be recognizable as an AS entry to the deserializer
300 2020-06-07T17:51:47 <sipa> CSubNets do not have an explicit length in their serialization afaik
301 2020-06-07T17:52:04 <luke-jr> ah
302 2020-06-07T17:59:12 <phantomcircuit> uh whuch checksum would that fail?
303 2020-06-07T17:59:37 <phantomcircuit> i dont see any reason that would fail the checksum in DeserializeDB
304 2020-06-07T18:00:01 *** k0da has quit IRC
305 2020-06-07T18:00:35 <sipa> phantomcircuit: because the data deserialized wouldn't match
306 2020-06-07T18:00:44 <sipa> so it would read a checksum in the wrong place
307 2020-06-07T18:01:48 <phantomcircuit> i mean we can just append the asn stuff then and the checksum will be wrong that way to
308 2020-06-07T18:02:36 <sipa> yes, but how would a deserializer notice that there is more stuff to follow?
309 2020-06-07T18:02:50 <sipa> it would need to distinguish ban entries from the checksum...
310 2020-06-07T18:05:43 <phantomcircuit> start/data/data/hash and try to read data as both a hash and a map of asns
311 2020-06-07T18:06:51 <sipa> that's pretty ugly i think, but yes it will work
312 2020-06-07T18:06:59 <sipa> i think it's a bigger change
313 2020-06-07T18:08:38 *** justanotheruser has joined #bitcoin-core-dev
314 2020-06-07T18:09:34 <phantomcircuit> sipa, could equally just have v1/v2 deserializers
315 2020-06-07T18:09:59 <sipa> phantomcircuit: and try both?
316 2020-06-07T18:10:03 <phantomcircuit> yeah
317 2020-06-07T18:10:45 <sipa> well, see it this way: i think you're going to need a data type that represents "subnet or ASN" anyway, to put in the banmap map as key
318 2020-06-07T18:11:20 <sipa> if you give that data type a serialization that's identical to a subnet's for subsets, and to some sentinal + ASN for asns, you have no other serialization issues
319 2020-06-07T18:12:07 *** Pavlenex has joined #bitcoin-core-dev
320 2020-06-07T18:12:48 <sipa> *sentinel
321 2020-06-07T18:14:23 <phantomcircuit> yeah that's a good point
322 2020-06-07T18:14:58 <phantomcircuit> why is it `using banman_t = std::map...` and not a typedef ?
323 2020-06-07T18:15:36 <sipa> using is the newer syntax
324 2020-06-07T18:15:44 <sipa> it does the same as a typedef, but is more flexible
325 2020-06-07T18:16:50 <sipa> https://stackoverflow.com/questions/10747810/what-is-the-difference-between-typedef-and-using-in-c11
326 2020-06-07T18:20:01 <phantomcircuit> ok so they can still be templated where typedef cannot be
327 2020-06-07T18:20:02 <phantomcircuit> interesting
328 2020-06-07T18:20:14 *** Pavlenex has quit IRC
329 2020-06-07T18:22:09 *** Bille has joined #bitcoin-core-dev
330 2020-06-07T18:24:14 <phantomcircuit> sipa, oh CSubNet has a bool is valid flag
331 2020-06-07T18:24:29 *** davterra has quit IRC
332 2020-06-07T18:25:35 *** davterra has joined #bitcoin-core-dev
333 2020-06-07T18:25:49 <sipa> oh, and it's serialized!
334 2020-06-07T18:37:54 <sipa> so all you need to do is serialize ASN entries as something that gets read as valid=false by old nodes, and has a different length
335 2020-06-07T18:39:15 *** jonatack has joined #bitcoin-core-dev
336 2020-06-07T18:43:01 *** jonatack has quit IRC
337 2020-06-07T18:44:01 *** jonatack has joined #bitcoin-core-dev
338 2020-06-07T18:47:21 *** DeanGuss has joined #bitcoin-core-dev
339 2020-06-07T19:02:27 *** davterra has quit IRC
340 2020-06-07T19:06:52 *** Talkless has quit IRC
341 2020-06-07T19:07:36 <luke-jr> nice
342 2020-06-07T19:11:37 *** justanotheruser has quit IRC
343 2020-06-07T19:20:54 *** owowo has quit IRC
344 2020-06-07T19:22:22 *** adiabat has quit IRC
345 2020-06-07T19:22:49 <phantomcircuit> CSubNetOrAsn ?
346 2020-06-07T19:23:04 <phantomcircuit> CNetworkBlock?
347 2020-06-07T19:23:05 <sipa> BanMatch ?
348 2020-06-07T19:23:09 <phantomcircuit> im bad at naming things
349 2020-06-07T19:23:13 <sipa> (no more C prefix for classes)
350 2020-06-07T19:23:37 <phantomcircuit> banmatch is good
351 2020-06-07T19:24:25 <phantomcircuit> asn's are being represented just as a 32bit number right
352 2020-06-07T19:24:56 <sipa> yeah
353 2020-06-07T19:25:51 *** owowo has joined #bitcoin-core-dev
354 2020-06-07T19:25:52 *** owowo has joined #bitcoin-core-dev
355 2020-06-07T19:30:09 *** promag has joined #bitcoin-core-dev
356 2020-06-07T19:30:40 *** EagleTM has joined #bitcoin-core-dev
357 2020-06-07T19:32:08 *** jarthur has joined #bitcoin-core-dev
358 2020-06-07T20:06:37 *** bitdex has quit IRC
359 2020-06-07T20:06:46 *** guest534543 has joined #bitcoin-core-dev
360 2020-06-07T20:07:00 *** sanket1729 has quit IRC
361 2020-06-07T20:07:32 *** bitdex has joined #bitcoin-core-dev
362 2020-06-07T20:08:10 *** sanket1729 has joined #bitcoin-core-dev
363 2020-06-07T20:09:14 *** Kiminuo has quit IRC
364 2020-06-07T20:09:46 *** EagleTM has quit IRC
365 2020-06-07T20:21:19 *** jonatack_ has joined #bitcoin-core-dev
366 2020-06-07T20:21:51 *** jonatack has quit IRC
367 2020-06-07T20:24:11 *** bitcoin-git has joined #bitcoin-core-dev
368 2020-06-07T20:24:12 <bitcoin-git> [bitcoin] practicalswift opened pull request #19203: tests/net: Add regression fuzz harness for CVE-2017-18350. Add FuzzedSocket. Add thin SOCKET wrapper. (master...fuzzers-Socks5) https://github.com/bitcoin/bitcoin/pull/19203
369 2020-06-07T20:24:13 *** bitcoin-git has left #bitcoin-core-dev
370 2020-06-07T20:24:39 *** promag has quit IRC
371 2020-06-07T20:25:33 *** jarthur_ has joined #bitcoin-core-dev
372 2020-06-07T20:28:57 *** jarthur has quit IRC
373 2020-06-07T20:51:49 *** ppisati has quit IRC
374 2020-06-07T20:58:26 *** ppisati has joined #bitcoin-core-dev
375 2020-06-07T21:00:02 *** Bille has quit IRC
376 2020-06-07T21:06:45 *** jarthur has joined #bitcoin-core-dev
377 2020-06-07T21:10:19 *** jarthur_ has quit IRC
378 2020-06-07T21:13:22 *** jeremyrubin has joined #bitcoin-core-dev
379 2020-06-07T21:21:00 *** filchef has quit IRC
380 2020-06-07T21:22:00 *** kaeru has joined #bitcoin-core-dev
381 2020-06-07T21:23:11 *** EagleTM has joined #bitcoin-core-dev
382 2020-06-07T21:25:39 *** AaronvanW has quit IRC
383 2020-06-07T21:27:20 *** Chris_Stewart_5 has quit IRC
384 2020-06-07T21:29:11 *** justanotheruser has joined #bitcoin-core-dev
385 2020-06-07T21:31:27 *** Chris_Stewart_5 has joined #bitcoin-core-dev
386 2020-06-07T21:33:05 *** davterra has joined #bitcoin-core-dev
387 2020-06-07T21:39:18 *** Guyver2 has quit IRC
388 2020-06-07T21:48:14 *** dviola has joined #bitcoin-core-dev
389 2020-06-07T21:48:58 *** davterra has quit IRC
390 2020-06-07T21:51:50 *** ilu has joined #bitcoin-core-dev
391 2020-06-07T21:52:07 *** davterra has joined #bitcoin-core-dev
392 2020-06-07T21:53:23 *** ctrlbreak_MAD has quit IRC
393 2020-06-07T21:53:51 *** baldur has quit IRC
394 2020-06-07T21:53:52 *** tryphe has quit IRC
395 2020-06-07T21:53:52 *** meshcollider has quit IRC
396 2020-06-07T21:53:52 *** NicolasDorier has quit IRC
397 2020-06-07T21:53:52 *** digi_james has quit IRC
398 2020-06-07T21:53:52 *** valwal_ has quit IRC
399 2020-06-07T21:53:52 *** fanquake has quit IRC
400 2020-06-07T21:53:52 *** peltre has quit IRC
401 2020-06-07T21:53:52 *** bosma has quit IRC
402 2020-06-07T21:53:52 *** provoostenator has quit IRC
403 2020-06-07T21:53:52 *** nullptr| has quit IRC
404 2020-06-07T21:54:09 *** baldur has joined #bitcoin-core-dev
405 2020-06-07T21:54:09 *** tryphe has joined #bitcoin-core-dev
406 2020-06-07T21:54:09 *** meshcollider has joined #bitcoin-core-dev
407 2020-06-07T21:54:09 *** NicolasDorier has joined #bitcoin-core-dev
408 2020-06-07T21:54:09 *** digi_james has joined #bitcoin-core-dev
409 2020-06-07T21:54:09 *** valwal_ has joined #bitcoin-core-dev
410 2020-06-07T21:54:09 *** fanquake has joined #bitcoin-core-dev
411 2020-06-07T21:54:09 *** peltre has joined #bitcoin-core-dev
412 2020-06-07T21:54:09 *** bosma has joined #bitcoin-core-dev
413 2020-06-07T21:54:09 *** provoostenator has joined #bitcoin-core-dev
414 2020-06-07T21:54:09 *** nullptr| has joined #bitcoin-core-dev
415 2020-06-07T21:54:25 *** ilu has quit IRC
416 2020-06-07T21:54:32 *** peltre has quit IRC
417 2020-06-07T21:54:33 *** ilu has joined #bitcoin-core-dev
418 2020-06-07T21:55:09 *** takinbo has quit IRC
419 2020-06-07T21:55:09 *** asoltys has quit IRC
420 2020-06-07T21:55:09 *** isis_ has quit IRC
421 2020-06-07T21:55:09 *** a5m0_ has quit IRC
422 2020-06-07T21:55:09 *** hadjiszs_ has quit IRC
423 2020-06-07T21:55:09 *** enasigurd_ has quit IRC
424 2020-06-07T21:55:09 *** DougieBot5000 has quit IRC
425 2020-06-07T21:55:09 *** hex17or has quit IRC
426 2020-06-07T21:55:09 *** esotericnonsense has quit IRC
427 2020-06-07T21:55:10 *** CubicEarth has quit IRC
428 2020-06-07T21:55:10 *** tripleslash has quit IRC
429 2020-06-07T21:55:10 *** MarcoFalke has quit IRC
430 2020-06-07T21:55:10 *** waxwing has quit IRC
431 2020-06-07T21:55:10 *** jnewbery has quit IRC
432 2020-06-07T21:55:10 *** tynes_ has quit IRC
433 2020-06-07T21:55:10 *** GAit has quit IRC
434 2020-06-07T21:55:10 *** wraithm has quit IRC
435 2020-06-07T21:55:10 *** IPGlider has quit IRC
436 2020-06-07T21:55:28 *** takinbo has joined #bitcoin-core-dev
437 2020-06-07T21:55:28 *** asoltys has joined #bitcoin-core-dev
438 2020-06-07T21:55:28 *** isis_ has joined #bitcoin-core-dev
439 2020-06-07T21:55:28 *** a5m0_ has joined #bitcoin-core-dev
440 2020-06-07T21:55:28 *** hadjiszs_ has joined #bitcoin-core-dev
441 2020-06-07T21:55:28 *** enasigurd_ has joined #bitcoin-core-dev
442 2020-06-07T21:55:28 *** DougieBot5000 has joined #bitcoin-core-dev
443 2020-06-07T21:55:28 *** hex17or has joined #bitcoin-core-dev
444 2020-06-07T21:55:28 *** esotericnonsense has joined #bitcoin-core-dev
445 2020-06-07T21:55:28 *** CubicEarth has joined #bitcoin-core-dev
446 2020-06-07T21:55:28 *** tripleslash has joined #bitcoin-core-dev
447 2020-06-07T21:55:28 *** MarcoFalke has joined #bitcoin-core-dev
448 2020-06-07T21:55:28 *** waxwing has joined #bitcoin-core-dev
449 2020-06-07T21:55:28 *** jnewbery has joined #bitcoin-core-dev
450 2020-06-07T21:55:28 *** tynes_ has joined #bitcoin-core-dev
451 2020-06-07T21:55:28 *** GAit has joined #bitcoin-core-dev
452 2020-06-07T21:55:28 *** wraithm has joined #bitcoin-core-dev
453 2020-06-07T21:55:28 *** IPGlider has joined #bitcoin-core-dev
454 2020-06-07T21:55:45 *** esotericnonsense has quit IRC
455 2020-06-07T21:55:49 *** Chris_Stewart_5 has quit IRC
456 2020-06-07T21:56:02 *** mrostecki[m] has quit IRC
457 2020-06-07T21:56:15 *** esotericnonsense has joined #bitcoin-core-dev
458 2020-06-07T21:56:16 *** mrostecki[m] has joined #bitcoin-core-dev
459 2020-06-07T21:56:37 *** TheFuzzStone[m] has quit IRC
460 2020-06-07T21:56:38 *** jorijn has quit IRC
461 2020-06-07T21:56:40 *** windsok has quit IRC
462 2020-06-07T21:56:44 *** davterra has quit IRC
463 2020-06-07T21:56:48 *** mrostecki[m] has quit IRC
464 2020-06-07T21:57:15 *** shesek has quit IRC
465 2020-06-07T21:57:38 *** tryphe has quit IRC
466 2020-06-07T21:57:51 *** shesek has joined #bitcoin-core-dev
467 2020-06-07T21:57:53 *** mmitech_ has quit IRC
468 2020-06-07T21:57:53 *** nejon has quit IRC
469 2020-06-07T21:57:53 *** kinlo has quit IRC
470 2020-06-07T21:57:59 *** tryphe has joined #bitcoin-core-dev
471 2020-06-07T21:58:10 *** mmitech_ has joined #bitcoin-core-dev
472 2020-06-07T21:58:10 *** nejon has joined #bitcoin-core-dev
473 2020-06-07T21:58:10 *** kinlo has joined #bitcoin-core-dev
474 2020-06-07T21:58:27 *** windsok has joined #bitcoin-core-dev
475 2020-06-07T21:58:29 *** windsok has joined #bitcoin-core-dev
476 2020-06-07T21:58:32 *** jorijn has joined #bitcoin-core-dev
477 2020-06-07T21:58:32 *** thaumavorio has quit IRC
478 2020-06-07T21:58:33 *** z3232 has quit IRC
479 2020-06-07T21:58:33 *** Henry151 has quit IRC
480 2020-06-07T21:58:33 *** wullon5 has quit IRC
481 2020-06-07T21:58:33 *** luke-jr has quit IRC
482 2020-06-07T21:58:33 *** Lightsword has quit IRC
483 2020-06-07T21:58:33 *** willcl_ark has quit IRC
484 2020-06-07T21:58:33 *** instagibbs has quit IRC
485 2020-06-07T21:58:33 *** bsm117532 has quit IRC
486 2020-06-07T21:58:33 *** chjj has quit IRC
487 2020-06-07T21:58:33 *** rhiaro has quit IRC
488 2020-06-07T21:58:33 *** raj_149 has quit IRC
489 2020-06-07T21:58:33 *** hirish_ has quit IRC
490 2020-06-07T21:58:33 *** dlb76 has quit IRC
491 2020-06-07T21:58:34 *** gwillen has quit IRC
492 2020-06-07T21:58:34 *** sturles has quit IRC
493 2020-06-07T21:58:34 *** wxss has quit IRC
494 2020-06-07T21:58:34 *** earlz has quit IRC
495 2020-06-07T21:58:34 *** balbirs has quit IRC
496 2020-06-07T21:59:38 *** z3232 has joined #bitcoin-core-dev
497 2020-06-07T21:59:38 *** thaumavorio has joined #bitcoin-core-dev
498 2020-06-07T21:59:38 *** Henry151 has joined #bitcoin-core-dev
499 2020-06-07T21:59:38 *** wullon5 has joined #bitcoin-core-dev
500 2020-06-07T21:59:38 *** luke-jr has joined #bitcoin-core-dev
501 2020-06-07T21:59:38 *** Lightsword has joined #bitcoin-core-dev
502 2020-06-07T21:59:38 *** willcl_ark has joined #bitcoin-core-dev
503 2020-06-07T21:59:38 *** instagibbs has joined #bitcoin-core-dev
504 2020-06-07T21:59:38 *** bsm117532 has joined #bitcoin-core-dev
505 2020-06-07T21:59:38 *** chjj has joined #bitcoin-core-dev
506 2020-06-07T21:59:38 *** rhiaro has joined #bitcoin-core-dev
507 2020-06-07T21:59:38 *** raj_149 has joined #bitcoin-core-dev
508 2020-06-07T21:59:38 *** hirish_ has joined #bitcoin-core-dev
509 2020-06-07T21:59:38 *** dlb76 has joined #bitcoin-core-dev
510 2020-06-07T21:59:38 *** gwillen has joined #bitcoin-core-dev
511 2020-06-07T21:59:38 *** sturles has joined #bitcoin-core-dev
512 2020-06-07T21:59:38 *** wxss has joined #bitcoin-core-dev
513 2020-06-07T21:59:38 *** earlz has joined #bitcoin-core-dev
514 2020-06-07T21:59:38 *** balbirs has joined #bitcoin-core-dev
515 2020-06-07T22:00:02 *** davterra has joined #bitcoin-core-dev
516 2020-06-07T22:00:04 *** Bullit has quit IRC
517 2020-06-07T22:00:05 *** Henry151 has quit IRC
518 2020-06-07T22:01:07 *** Bullit has joined #bitcoin-core-dev
519 2020-06-07T22:01:12 *** Henry151 has joined #bitcoin-core-dev
520 2020-06-07T22:01:51 *** peltre has joined #bitcoin-core-dev
521 2020-06-07T22:09:30 *** guest534543 has quit IRC
522 2020-06-07T22:19:43 *** TheFuzzStone[m] has joined #bitcoin-core-dev
523 2020-06-07T22:22:29 *** mrostecki[m] has joined #bitcoin-core-dev
524 2020-06-07T22:33:32 *** promag has joined #bitcoin-core-dev
525 2020-06-07T22:55:06 *** kvaciral has quit IRC
526 2020-06-07T23:04:02 *** jarthur has quit IRC
527 2020-06-07T23:04:33 *** jarthur has joined #bitcoin-core-dev
528 2020-06-07T23:10:30 *** Randolf has joined #bitcoin-core-dev
529 2020-06-07T23:35:46 *** proofofkeags has joined #bitcoin-core-dev
530 2020-06-07T23:45:14 *** rafalcpp has joined #bitcoin-core-dev
531 2020-06-07T23:50:58 *** mol has quit IRC
532 2020-06-07T23:51:32 *** mol has joined #bitcoin-core-dev
533 2020-06-07T23:51:37 *** proofofkeags has quit IRC
534 2020-06-07T23:52:10 *** proofofkeags has joined #bitcoin-core-dev
535 2020-06-07T23:53:00 *** bitcoin-git has joined #bitcoin-core-dev
536 2020-06-07T23:53:00 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19204: p2p: Reduce inv traffic during IBD (master...2006-netInvWaste) https://github.com/bitcoin/bitcoin/pull/19204
537 2020-06-07T23:53:11 *** bitcoin-git has left #bitcoin-core-dev
538 2020-06-07T23:56:38 *** proofofkeags has quit IRC