1 2020-06-23T00:00:03  *** clintbellanger has quit IRC
  2 2020-06-23T00:19:56  *** blackjid has joined #bitcoin-core-dev
  3 2020-06-23T00:54:43  *** AaronvanW has quit IRC
  4 2020-06-23T01:22:07  *** bitdex has joined #bitcoin-core-dev
  5 2020-06-23T02:02:00  *** promag has quit IRC
  6 2020-06-23T02:07:02  *** Majes has quit IRC
  7 2020-06-23T02:11:31  *** Majes has joined #bitcoin-core-dev
  8 2020-06-23T02:17:18  *** jarthur_ has quit IRC
  9 2020-06-23T02:34:13  *** promag has joined #bitcoin-core-dev
 10 2020-06-23T02:39:03  *** promag has quit IRC
 11 2020-06-23T02:42:39  *** bitcoin-git has joined #bitcoin-core-dev
 12 2020-06-23T02:42:39  <bitcoin-git> [bitcoin] gwillen opened pull request #19356: build: Fix & improve the search for BDB (master...feature-bdb-search-fix-osx) https://github.com/bitcoin/bitcoin/pull/19356
 13 2020-06-23T02:42:40  *** bitcoin-git has left #bitcoin-core-dev
 14 2020-06-23T02:43:17  <gwillen> if anybody loves (or hates) autotools, I would love a look at the PR I just opened ^
 15 2020-06-23T02:43:21  *** shesek` has joined #bitcoin-core-dev
 16 2020-06-23T02:43:29  *** shesek` has quit IRC
 17 2020-06-23T02:43:41  <gwillen> I made one change that I actually need to fix a specific issue on my OS X system, and some general cleanup that I will remove if it's controversial.
 18 2020-06-23T02:43:46  *** shesek has joined #bitcoin-core-dev
 19 2020-06-23T02:43:46  *** shesek has quit IRC
 20 2020-06-23T02:43:46  *** shesek has joined #bitcoin-core-dev
 21 2020-06-23T02:43:48  * sipa summons cfields ^
 22 2020-06-23T02:44:48  <gwillen> if anybody remembers my comment about mysterious segfaults when building another PR, this PR is the punchline (without it, I end up getting headers from one version of bdb, and libs from another version.)
 23 2020-06-23T02:47:31  *** Relis has quit IRC
 24 2020-06-23T02:52:15  *** Relis has joined #bitcoin-core-dev
 25 2020-06-23T03:00:02  *** blackjid has quit IRC
 26 2020-06-23T03:05:54  *** vincenzopalazzo has quit IRC
 27 2020-06-23T03:07:02  <cfields> gwillen: thanks. Looks more correct at a glance, will look in detail tomorrow.
 28 2020-06-23T03:07:18  <gwillen> thanks very much for the quick look cfields!
 29 2020-06-23T03:08:38  *** vincenzopalazzo has joined #bitcoin-core-dev
 30 2020-06-23T03:09:59  * cfields considers picking a CFLAGS fight just because gwillen seems to want it
 31 2020-06-23T03:10:46  <cfields> Joking, of course. I agree with you. It's just sometimes hard to balance the fact that everyone wants CFLAGS as a hammer.
 32 2020-06-23T03:11:22  * sipa idly suggests switching to maven
 33 2020-06-23T03:11:49  <cfields> sipa: patches welcome!
 34 2020-06-23T03:12:01  <fanquake> 😢
 35 2020-06-23T03:12:02  <cfields> (comprehensive patches :p)
 36 2020-06-23T03:12:02  <sipa> haha
 37 2020-06-23T03:19:53  <gwillen> cfields: yeah I am happy to relinquish the CFLAGS/CPPFLAGS part of the change if that will make life easier, but I figured I'd try for a cleanup while I was poking around
 38 2020-06-23T03:20:36  <gwillen> I can understand why people reach for CFLAGS, it is all over documentation everywhere, I would have done the same but I learned the difference in reading the documentation while making this change :-)
 39 2020-06-23T03:26:10  *** tryphe_ has joined #bitcoin-core-dev
 40 2020-06-23T03:29:30  *** tryphe has quit IRC
 41 2020-06-23T03:31:10  *** tryphe_ has quit IRC
 42 2020-06-23T03:39:26  <cfields> gwillen: the reason I think I'm going to have to fight you on it is because pkg-config uses the _CFLAGS convention. So if you do "./configure --help", all of the paths are _CFLAGS. Which is really unfortunate, because _CPPFLAGS would make much more sense for those.
 43 2020-06-23T03:41:22  <cfields> But I'm not completely sure what your problem is independent of the _CFLAGS change. Is it just that the include-order is wrong in the brew case?
 44 2020-06-23T03:52:27  <gwillen> cfields: correct, the change from CFLAGS/LIBS to BDB_CFLAGS/BDB_LIBS fixes the include order in the brew case, it pushes the BDB 4.8 include earlier, to override the inclusion of /usr/local/include elsewhere in the list of paths, which pulls in all kinds of random stuff
 45 2020-06-23T03:53:03  <gwillen> whereas the CFLAGS/CPPFLAGS change is just for fun
 46 2020-06-23T03:53:17  <gwillen> I confess I don't know much at all about pkg-config, I will read up on that
 47 2020-06-23T03:58:21  *** S3RK has joined #bitcoin-core-dev
 48 2020-06-23T03:58:57  *** Relis has quit IRC
 49 2020-06-23T03:59:51  <cfields> gwillen: many projects (like us) use pkg-config to add dependencies. Doing so automatically hooks up a FOO_CFLAGS and FOO_LIBS that can be used to supply the respective paths for that dependency.
 50 2020-06-23T04:00:55  <cfields> gwillen: so when you run "./configure --help" you see those possible overrides. That's why the _CFLAGS convention is so (annoyingly) common for specifying an include path.
 51 2020-06-23T04:02:08  <cfields> So while wishing to pass BDB_CPPFLAGS is *far* more correct, it's not what anything expects.
 52 2020-06-23T04:03:21  <gwillen> yeah that makes sense, I see that at some point pkg-config apparently grew the ability to deal with CPPFLAGS, but late enough that it's probably locked in at this point
 53 2020-06-23T04:03:25  *** davterra has joined #bitcoin-core-dev
 54 2020-06-23T04:04:28  <gwillen> let me fix it up to work the other way, I think there is a small annoyance I will have to deal with in the process and you can review the result
 55 2020-06-23T04:05:14  <cfields> gwillen: it's up to package maintainers to supply their own flags...
 56 2020-06-23T04:05:26  <cfields> as a data point, we don't use cppflags: https://github.com/bitcoin/bitcoin/blob/master/libbitcoinconsensus.pc.in
 57 2020-06-23T04:05:34  <cfields> (maybe we should :)
 58 2020-06-23T04:05:51  <luke-jr> libbitcoinconsensus is a C library..
 59 2020-06-23T04:06:06  <sipa> cpp = c preprocessor
 60 2020-06-23T04:06:07  <cfields> luke-jr: CPP == C PreProcessor
 61 2020-06-23T04:06:22  <sipa> cxxflags is for c++ flags
 62 2020-06-23T04:06:24  <gwillen> well the thing that makes it annoying is that automake does require it to be CPPFLAGS for BDB in particular, or CXXFLAGS, since we need it to be present for C++ compilation
 63 2020-06-23T04:07:05  <luke-jr> the spec seems to say there is no cppflags for pkg-config
 64 2020-06-23T04:07:22  <luke-jr> https://dev.gentoo.org/~mgorny/pkg-config-spec.html#keyword-value-interpretation
 65 2020-06-23T04:08:51  <gwillen> I'm curious how other projects that use pkg-config with C++ deal with this
 66 2020-06-23T04:09:51  <cfields> gwillen: afaik they all just assume paths are coming in via cflags.
 67 2020-06-23T04:10:22  <luke-jr> the autoconf stuff for pkg-config also seems to be CFLAGS/LIBS only
 68 2020-06-23T04:10:35  *** Relis has joined #bitcoin-core-dev
 69 2020-06-23T04:10:52  <luke-jr> "The flags encountered in Cflags are grouped into the two following groups: the -I (include path) flags, …"
 70 2020-06-23T04:10:57  <cfields> I seem to recall getting really grumpy at some project for including an actual cflag there.
 71 2020-06-23T04:11:04  <luke-jr> so yes, pkg-config cflags are *supposed* to include the -Is
 72 2020-06-23T04:11:14  <gwillen> but automake does not feed CFLAGS to the C++ compiler
 73 2020-06-23T04:11:24  <gwillen> so if you're building C++, you have to bridge that somehow
 74 2020-06-23T04:11:38  <luke-jr> gwillen: it doesn't feed *_C*FLAGS to it either - you need to explicitly include those somewhere
 75 2020-06-23T04:11:45  <luke-jr> not even for C
 76 2020-06-23T04:13:37  <luke-jr> as much as it might makes sense to say CFLAGS = concat(*_CFLAGS), it really doesn't work that way <.<
 77 2020-06-23T04:13:41  <cfields> gwillen: as an example of how it works...
 78 2020-06-23T04:13:45  <cfields> https://github.com/bitcoin/bitcoin/blob/master/configure.ac#L1381
 79 2020-06-23T04:13:55  <cfields> PKG_CHECK_MODULES([UNIVALUE],[libunivalue >= 1.0.4],[found_univalue=yes],[true])
 80 2020-06-23T04:14:13  <cfields> That creates UNIVALUE_CFLAGS and UNIVALUE_LIBS for us
 81 2020-06-23T04:14:45  <cfields> then: https://github.com/bitcoin/bitcoin/blob/master/src/Makefile.am#L25
 82 2020-06-23T04:14:53  <gwillen> luke-jr: it doesn't automatically include BDB_CPPFLAGS, but it does automatically include libbitcoin_server_a_CPPFLAGS, which is what we put BDB_CPPFLAGS into
 83 2020-06-23T04:14:53  <cfields> BITCOIN_INCLUDES += $(UNIVALUE_CFLAGS)
 84 2020-06-23T04:15:18  <luke-jr> gwillen: point is, DEP_CFLAGS is supposed to be the place for -I and such
 85 2020-06-23T04:15:19  <gwillen> anyway, I guess the answer is that someone somewhere stuffs the contents of CFLAGS into something named CPPFLAGS somewhere
 86 2020-06-23T04:15:39  <cfields> gwillen: yep, that.
 87 2020-06-23T04:15:46  <gwillen> hmmm actually I guess I understand luke-jr's point
 88 2020-06-23T04:16:17  <gwillen> although I'm not sure if it quite makes sense for BDB which is itself a C++ library
 89 2020-06-23T04:16:43  <luke-jr> gwillen: this is also how C++ libraries do it.. <.<
 90 2020-06-23T04:17:03  <luke-jr> there is no Cxxflags in pkg-config either
 91 2020-06-23T04:19:06  <gwillen> so basically pkg-config and automake just like, permanently differ on this, I guess?
 92 2020-06-23T04:19:16  <luke-jr> seems so
 93 2020-06-23T04:19:20  <gwillen> (e.g. ax_boost_base.m4 defines AC_SUBST(BOOST_CPPFLAGS), not BOOST_CFLAGS, for where it finds boost)
 94 2020-06-23T04:20:53  *** vasild_ has joined #bitcoin-core-dev
 95 2020-06-23T04:21:04  <cfields> gwillen: I don't see those exported.
 96 2020-06-23T04:21:13  *** drewdrew has joined #bitcoin-core-dev
 97 2020-06-23T04:22:11  <cfields> also, boost doesn't ship pkg-config files. Which is why we carry that monstrosity of a .m4.
 98 2020-06-23T04:22:55  <gwillen> I'm looking at https://github.com/bitcoin/bitcoin/blob/master/build-aux/m4/ax_boost_base.m4#L80
 99 2020-06-23T04:23:19  <gwillen> anyway this just confirms my existing hatred for build systems :D
100 2020-06-23T04:23:52  <luke-jr> could be worse - could be maven
101 2020-06-23T04:23:53  * luke-jr hides
102 2020-06-23T04:24:02  <cfields> gwillen: right, but that's available as an override (not visible externally via ./configure --help)
103 2020-06-23T04:24:03  *** vasild has quit IRC
104 2020-06-23T04:24:04  *** vasild_ is now known as vasild
105 2020-06-23T04:24:34  <gwillen> ahh, yeah, because it is AC_SUBST and not AC_ARG_VAR
106 2020-06-23T04:25:03  <cfields> right
107 2020-06-23T04:25:28  <luke-jr> what I really don't get is how there are so many efforts to replace autoconf, and they always end up worse
108 2020-06-23T04:25:40  <cfields> *that's not availble. sorry. apparently you understood :)
109 2020-06-23T04:27:19  <sipa> xkcd 927 lalala
110 2020-06-23T04:31:20  *** Relis has quit IRC
111 2020-06-23T04:32:27  *** Relis has joined #bitcoin-core-dev
112 2020-06-23T04:32:31  *** tryphe has joined #bitcoin-core-dev
113 2020-06-23T04:34:28  *** Randolf has joined #bitcoin-core-dev
114 2020-06-23T04:35:31  *** tryphe_ has joined #bitcoin-core-dev
115 2020-06-23T04:36:14  *** tryphe has quit IRC
116 2020-06-23T04:41:21  <fanquake> It seems my Windows VM has "expired", and now shuts itself down ~ every 45 minutes.
117 2020-06-23T04:41:31  <fanquake>  Incredibly convenient
118 2020-06-23T04:43:04  <luke-jr> I bet illicit sources don't have that problem
119 2020-06-23T04:44:36  <fanquake> heh
120 2020-06-23T04:44:39  <fanquake> I will persevere while I wait for the 16GB of "new" VM to download
121 2020-06-23T04:57:41  *** Relis has quit IRC
122 2020-06-23T05:00:11  *** troygiorshev has quit IRC
123 2020-06-23T05:00:58  *** troygiorshev has joined #bitcoin-core-dev
124 2020-06-23T05:01:36  *** harrigan has quit IRC
125 2020-06-23T05:04:47  *** harrigan has joined #bitcoin-core-dev
126 2020-06-23T05:09:16  *** promag has joined #bitcoin-core-dev
127 2020-06-23T05:13:02  *** bitcoin-git has joined #bitcoin-core-dev
128 2020-06-23T05:13:02  <bitcoin-git> [bitcoin] jonatack opened pull request #19357: doc: add release note for bitcoin-cli -generate (master...cli-generate-release-note) https://github.com/bitcoin/bitcoin/pull/19357
129 2020-06-23T05:13:03  *** bitcoin-git has left #bitcoin-core-dev
130 2020-06-23T05:14:02  *** promag has quit IRC
131 2020-06-23T05:14:22  *** troygiorshev has quit IRC
132 2020-06-23T05:16:25  *** IGHOR has joined #bitcoin-core-dev
133 2020-06-23T05:19:39  *** drewdrew has quit IRC
134 2020-06-23T05:22:05  *** robwerks has joined #bitcoin-core-dev
135 2020-06-23T05:22:29  *** robwerks is now known as Guest44539
136 2020-06-23T05:26:27  *** Guest44539 has quit IRC
137 2020-06-23T05:27:38  *** S3RK has quit IRC
138 2020-06-23T05:28:05  *** S3RK has joined #bitcoin-core-dev
139 2020-06-23T05:32:14  *** S3RK has quit IRC
140 2020-06-23T05:44:47  <fanquake> I think I have figured out the underlying issue with ipv6 & Windows (#18287)
141 2020-06-23T05:44:49  <gribble> https://github.com/bitcoin/bitcoin/issues/18287 | depends: Patch libevent build to fix IPv6 -rpcbind on Windows by luke-jr · Pull Request #18287 · bitcoin/bitcoin · GitHub
142 2020-06-23T05:45:01  <fanquake> The problem is deeper inside libevent, but hopefully can get that fixed up for 0.20.1
143 2020-06-23T06:06:53  <luke-jr> fanquake: ?
144 2020-06-23T06:09:39  *** EagleTM has joined #bitcoin-core-dev
145 2020-06-23T06:21:53  *** Randolf has quit IRC
146 2020-06-23T06:22:16  *** SirVerII has joined #bitcoin-core-dev
147 2020-06-23T06:23:48  *** Guyver2 has joined #bitcoin-core-dev
148 2020-06-23T06:47:28  *** marcoagner has joined #bitcoin-core-dev
149 2020-06-23T06:49:25  *** sipsorcery has joined #bitcoin-core-dev
150 2020-06-23T07:04:40  *** S3RK has joined #bitcoin-core-dev
151 2020-06-23T07:05:02  *** zolo56534 has joined #bitcoin-core-dev
152 2020-06-23T07:08:00  *** vincenzopalazzo has quit IRC
153 2020-06-23T07:12:11  <fanquake> luke-jr: the problem seems to be with the “hint” flags that libevent is setting before getaddr* calls. The changes in the PR don’t fix the issue for us entirely, as mentioned in the comments there.
154 2020-06-23T07:16:49  *** zolo56534 has quit IRC
155 2020-06-23T07:16:51  *** Pavlenex has joined #bitcoin-core-dev
156 2020-06-23T07:17:03  <luke-jr> hrm, been too long since I made that to remember about hint stuff :/
157 2020-06-23T07:17:13  <luke-jr> strange that it fixes it for some of us and not others
158 2020-06-23T07:27:07  *** zolo56534 has joined #bitcoin-core-dev
159 2020-06-23T07:48:39  *** zolo56534 has quit IRC
160 2020-06-23T07:52:07  *** zolo56534 has joined #bitcoin-core-dev
161 2020-06-23T07:52:24  *** S3RK has quit IRC
162 2020-06-23T07:52:51  *** S3RK has joined #bitcoin-core-dev
163 2020-06-23T07:53:39  *** zolo56534 has quit IRC
164 2020-06-23T07:56:54  *** S3RK has quit IRC
165 2020-06-23T08:00:31  *** S3RK has joined #bitcoin-core-dev
166 2020-06-23T08:01:23  *** zolo56534 has joined #bitcoin-core-dev
167 2020-06-23T08:03:09  *** zolo56534 has quit IRC
168 2020-06-23T08:04:55  *** bitcoin-git has joined #bitcoin-core-dev
169 2020-06-23T08:04:56  <bitcoin-git> [bitcoin] Saibato opened pull request #19358: net: Make sure we do not override proxy settings in hidden service. (master...pr351-bitcoin) https://github.com/bitcoin/bitcoin/pull/19358
170 2020-06-23T08:05:07  *** bitcoin-git has left #bitcoin-core-dev
171 2020-06-23T08:05:08  *** promag has joined #bitcoin-core-dev
172 2020-06-23T08:06:25  *** zolo56534 has joined #bitcoin-core-dev
173 2020-06-23T08:09:20  *** promag has quit IRC
174 2020-06-23T08:12:47  *** zolo56534 has quit IRC
175 2020-06-23T08:12:59  *** Randolf has joined #bitcoin-core-dev
176 2020-06-23T08:15:29  *** bitcoin-git has joined #bitcoin-core-dev
177 2020-06-23T08:15:30  <bitcoin-git> [bitcoin] fanquake pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/e3fa3c7d671e...80fd474e402b
178 2020-06-23T08:15:31  <bitcoin-git> bitcoin/master b3394ab Carl Dong: contrib: macdeploy: Correctly generate macOS SDK
179 2020-06-23T08:15:32  <bitcoin-git> bitcoin/master 3381e4a Carl Dong: Adapt rest of tooling to new SDK naming scheme
180 2020-06-23T08:15:32  <bitcoin-git> bitcoin/master fbcfcf6 Carl Dong: native_cctools: Don't use libc++ from pinned clang
181 2020-06-23T08:15:34  *** bitcoin-git has left #bitcoin-core-dev
182 2020-06-23T08:15:42  *** jonatack has quit IRC
183 2020-06-23T08:15:49  *** bitcoin-git has joined #bitcoin-core-dev
184 2020-06-23T08:15:49  <bitcoin-git> [bitcoin] fanquake merged pull request #19240: build: macOS toolchain simplification and bump (master...2020-06-macos-sdkgen-simplify) https://github.com/bitcoin/bitcoin/pull/19240
185 2020-06-23T08:15:50  *** promag has joined #bitcoin-core-dev
186 2020-06-23T08:15:50  *** bitcoin-git has left #bitcoin-core-dev
187 2020-06-23T08:34:33  *** bitdex has quit IRC
188 2020-06-23T08:34:57  *** bitdex has joined #bitcoin-core-dev
189 2020-06-23T08:40:05  *** provoostenator has joined #bitcoin-core-dev
190 2020-06-23T08:43:13  *** AaronvanW has joined #bitcoin-core-dev
191 2020-06-23T09:00:01  *** SirVerII has quit IRC
192 2020-06-23T09:05:42  *** S3RK has quit IRC
193 2020-06-23T09:06:09  *** S3RK has joined #bitcoin-core-dev
194 2020-06-23T09:07:17  *** Victor_sueca has joined #bitcoin-core-dev
195 2020-06-23T09:08:37  *** Victorsueca has quit IRC
196 2020-06-23T09:08:38  *** warren_ has quit IRC
197 2020-06-23T09:08:58  *** jrayhawk has quit IRC
198 2020-06-23T09:09:26  *** jrayhawk has joined #bitcoin-core-dev
199 2020-06-23T09:10:23  *** S3RK has quit IRC
200 2020-06-23T09:11:54  *** warren has joined #bitcoin-core-dev
201 2020-06-23T09:20:14  *** BjarniRunar1 has joined #bitcoin-core-dev
202 2020-06-23T09:28:02  *** bitcoin-git has joined #bitcoin-core-dev
203 2020-06-23T09:28:03  <bitcoin-git> [bitcoin] vasild opened pull request #19360: net: improve encapsulation of CNetAddr (master...improve_encapsulation_of_cnetaddr) https://github.com/bitcoin/bitcoin/pull/19360
204 2020-06-23T09:28:03  *** bitcoin-git has left #bitcoin-core-dev
205 2020-06-23T09:57:53  *** jonatack has joined #bitcoin-core-dev
206 2020-06-23T09:58:13  *** jonatack has joined #bitcoin-core-dev
207 2020-06-23T10:01:20  *** S3RK has joined #bitcoin-core-dev
208 2020-06-23T10:02:44  *** jonatack has quit IRC
209 2020-06-23T10:03:13  *** zolo56534 has joined #bitcoin-core-dev
210 2020-06-23T10:03:21  *** Braulio3Paucek has joined #bitcoin-core-dev
211 2020-06-23T10:04:58  *** jonatack has joined #bitcoin-core-dev
212 2020-06-23T10:09:09  *** PDI has joined #bitcoin-core-dev
213 2020-06-23T10:13:39  *** Pavlenex has quit IRC
214 2020-06-23T10:20:40  *** kristapsk_ has joined #bitcoin-core-dev
215 2020-06-23T10:20:59  *** kristapsk has quit IRC
216 2020-06-23T10:35:05  *** PDI has quit IRC
217 2020-06-23T10:37:18  *** kristapsk_ has quit IRC
218 2020-06-23T10:37:35  *** harrigan has quit IRC
219 2020-06-23T10:37:59  *** kristapsk_ has joined #bitcoin-core-dev
220 2020-06-23T10:38:36  *** harrigan has joined #bitcoin-core-dev
221 2020-06-23T11:00:08  *** S3RK has quit IRC
222 2020-06-23T11:01:16  *** S3RK has joined #bitcoin-core-dev
223 2020-06-23T11:03:34  *** Pavlenex has joined #bitcoin-core-dev
224 2020-06-23T11:20:55  *** Braulio3Paucek has quit IRC
225 2020-06-23T11:29:58  *** Relis has joined #bitcoin-core-dev
226 2020-06-23T11:30:28  *** S3RK has quit IRC
227 2020-06-23T11:37:57  *** jonatack has quit IRC
228 2020-06-23T11:43:32  *** kristapsk_ has quit IRC
229 2020-06-23T11:56:44  *** bitcoin-git has joined #bitcoin-core-dev
230 2020-06-23T11:56:44  <bitcoin-git> [bitcoin] prusnak opened pull request #19362: rpc/blockchain: Reset scantxoutset progress before inferring descriptors (master...rpc-scantxoutset-reset-progress) https://github.com/bitcoin/bitcoin/pull/19362
231 2020-06-23T11:56:45  *** bitcoin-git has left #bitcoin-core-dev
232 2020-06-23T11:57:39  *** Relis has quit IRC
233 2020-06-23T12:00:01  *** BjarniRunar1 has quit IRC
234 2020-06-23T12:21:17  *** drewdrew has joined #bitcoin-core-dev
235 2020-06-23T12:21:17  *** zolo56534 has quit IRC
236 2020-06-23T12:33:44  *** ahmed_ has quit IRC
237 2020-06-23T12:38:05  *** Relis has joined #bitcoin-core-dev
238 2020-06-23T12:38:46  *** Pavlenex has quit IRC
239 2020-06-23T12:49:29  *** troygiorshev has joined #bitcoin-core-dev
240 2020-06-23T13:02:39  *** Mercury_Vapor has quit IRC
241 2020-06-23T13:05:36  *** Mercury_Vapor has joined #bitcoin-core-dev
242 2020-06-23T13:29:02  <hebasto> ryanofsky: nice write-up https://github.com/bitcoin-core/bitcoin-devwiki/wiki/Settings-design-questions
243 2020-06-23T13:34:06  *** Pavlenex has joined #bitcoin-core-dev
244 2020-06-23T14:11:54  *** kiwi_53 has quit IRC
245 2020-06-23T14:37:50  *** bitdex has quit IRC
246 2020-06-23T14:40:24  *** belcher has joined #bitcoin-core-dev
247 2020-06-23T14:41:05  *** Dean_Guss has quit IRC
248 2020-06-23T15:00:02  *** drewdrew has quit IRC
249 2020-06-23T15:10:34  *** S3RK has joined #bitcoin-core-dev
250 2020-06-23T15:18:13  *** S3RK has quit IRC
251 2020-06-23T15:24:04  *** jonatack has joined #bitcoin-core-dev
252 2020-06-23T15:39:36  *** Pavlenex has quit IRC
253 2020-06-23T15:42:15  *** mol_ has joined #bitcoin-core-dev
254 2020-06-23T15:42:32  *** mol_ has quit IRC
255 2020-06-23T15:42:51  *** mol_ has joined #bitcoin-core-dev
256 2020-06-23T15:43:47  *** mol has quit IRC
257 2020-06-23T15:45:18  *** sipsorcery has quit IRC
258 2020-06-23T15:46:57  *** Pavlenex has joined #bitcoin-core-dev
259 2020-06-23T15:50:26  *** davterra has quit IRC
260 2020-06-23T15:50:33  *** davterra has joined #bitcoin-core-dev
261 2020-06-23T15:53:47  *** Eramdam1 has joined #bitcoin-core-dev
262 2020-06-23T15:54:13  *** Randolf has quit IRC
263 2020-06-23T15:55:40  *** Relis has quit IRC
264 2020-06-23T16:07:43  *** Relis has joined #bitcoin-core-dev
265 2020-06-23T16:13:09  *** sipsorcery has joined #bitcoin-core-dev
266 2020-06-23T16:13:59  *** Pavlenex has quit IRC
267 2020-06-23T16:19:39  *** jonatack has quit IRC
268 2020-06-23T16:21:38  *** Pavlenex has joined #bitcoin-core-dev
269 2020-06-23T16:24:03  *** vasild has quit IRC
270 2020-06-23T16:24:18  *** jonatack has joined #bitcoin-core-dev
271 2020-06-23T16:25:56  *** vasild has joined #bitcoin-core-dev
272 2020-06-23T16:33:24  <sipa> MarcoFalke: i'm finding it a bit annoying that codebase changes often break existing fuzz tests, which require travis or an entirely separate build to find out
273 2020-06-23T16:33:30  *** proofofkeags has joined #bitcoin-core-dev
274 2020-06-23T16:33:53  <sipa> what do you think about "building" the fuzz tests in normal make all mode (but without the actual fuzzing enabled)
275 2020-06-23T16:34:06  <sipa> one caveat is that the fuzz tests currently already need c++17
276 2020-06-23T16:43:07  *** justanotheruser has quit IRC
277 2020-06-23T16:48:46  *** bitcoin-git has joined #bitcoin-core-dev
278 2020-06-23T16:48:46  <bitcoin-git> [bitcoin] hebasto closed pull request #18710: Add local thread pool to CCheckQueue (master...200419-thread-pool) https://github.com/bitcoin/bitcoin/pull/18710
279 2020-06-23T16:48:47  *** bitcoin-git has left #bitcoin-core-dev
280 2020-06-23T16:49:06  *** bitcoin-git has joined #bitcoin-core-dev
281 2020-06-23T16:49:06  <bitcoin-git> [bitcoin] hebasto reopened pull request #18710: Add local thread pool to CCheckQueue (master...200419-thread-pool) https://github.com/bitcoin/bitcoin/pull/18710
282 2020-06-23T16:49:07  *** bitcoin-git has left #bitcoin-core-dev
283 2020-06-23T17:00:40  *** justanotheruser has joined #bitcoin-core-dev
284 2020-06-23T17:04:03  *** dr-orlovsky has joined #bitcoin-core-dev
285 2020-06-23T17:10:42  *** jarthur has joined #bitcoin-core-dev
286 2020-06-23T17:11:04  <cfields> sipa / MarcoFalke: See top 2 commits here for how that could work: https://github.com/theuni/bitcoin/commits/build-fuzz
287 2020-06-23T17:22:23  *** dr-orlovsky has quit IRC
288 2020-06-23T17:49:10  *** S3RK has joined #bitcoin-core-dev
289 2020-06-23T17:53:52  *** S3RK has quit IRC
290 2020-06-23T17:55:44  *** Pavlenex has quit IRC
291 2020-06-23T17:57:10  <wumpus> sipa: I'm not sure it should be the default, but I do agree it should be easier (e.g. a single configure option) to build the fuzz tests as well sa everything else
292 2020-06-23T17:57:56  <wumpus> having to do a second build with either-or exclusive options is kind of a time sink and easy to forget
293 2020-06-23T17:58:46  <sipa> wumpus: it seems that building the actual fuzz tests within one configure is very hard
294 2020-06-23T17:59:14  <wumpus> okay
295 2020-06-23T17:59:15  <sipa> but just something that can test whether the fuzz tests build is great already, i think
296 2020-06-23T17:59:52  <sipa> because it's really easy to introduce compile errors in them (and this will likely worsen as their coverage increases)
297 2020-06-23T18:00:01  *** Eramdam1 has quit IRC
298 2020-06-23T18:00:32  <wumpus> right
299 2020-06-23T18:01:37  <sipa> we could even have a minimal main() for the fake-fuzz tests that reads a single input from stdin, and runs the test code on it
300 2020-06-23T18:01:59  *** Pavlenex has joined #bitcoin-core-dev
301 2020-06-23T18:02:04  <sipa> or all entries in a directory... meaning it'd be actually useful as a test harness; you just wouldn't be able to fuzz with it
302 2020-06-23T18:06:55  <wumpus> that's a neat idea, at least the building feels less like dead weight in that case
303 2020-06-23T18:09:17  <sipa> as the travis fuzz build isn't actually doing any fuzzing, this may even be sufficient there
304 2020-06-23T18:09:21  *** bitcoin-git has joined #bitcoin-core-dev
305 2020-06-23T18:09:21  <bitcoin-git> [bitcoin] jnewbery opened pull request #19364: net processing: Move orphan reprocessing to a global (master...2020-06-global-orphans) https://github.com/bitcoin/bitcoin/pull/19364
306 2020-06-23T18:09:22  *** bitcoin-git has left #bitcoin-core-dev
307 2020-06-23T18:11:15  <cfields> it seems getting them to link as real progs will have linker issues due to missing libs. I guess the linker doesn't go looking for unresolved symbols with no main?
308 2020-06-23T18:11:37  *** Pavlenex has quit IRC
309 2020-06-23T18:11:49  <sipa> cfields: hmm, what symbols are missing?
310 2020-06-23T18:12:19  <cfields> sipa: zmq/miniupnpc/etc.
311 2020-06-23T18:12:25  <sipa> oh
312 2020-06-23T18:12:34  <sipa> that sounds fixable?
313 2020-06-23T18:12:37  <cfields> We could tack them on, but that kinda sucks.
314 2020-06-23T18:13:04  <cfields> Yeah, there's another approach though to avoid linking altogether though, 1 sec.
315 2020-06-23T18:13:06  <sipa> or maybe it's just not an issue
316 2020-06-23T18:13:17  <sipa> because if it's not a problem for real fuzzing, why would it here?
317 2020-06-23T18:13:32  <sipa> perhaps it's due to not having main() indeed
318 2020-06-23T18:17:03  <cfields> different approach: https://github.com/theuni/bitcoin/commit/d36b2b9cfe7d3916f261e88b63c03a7a3edd9ea5
319 2020-06-23T18:17:15  <cfields> That one's verbose though, requires us to c/p the object names to that list.
320 2020-06-23T18:20:42  <sipa> that's somewhat annoying (it's already annoying to need to add a blob to the makefile for every new fuzz test)
321 2020-06-23T18:20:51  <sipa> but not terrible i guess
322 2020-06-23T18:22:12  *** limpkin1 has joined #bitcoin-core-dev
323 2020-06-23T18:24:02  <cfields> I'll play with the linker errors a bit, see if there's a quick fix.
324 2020-06-23T18:41:43  *** justanotheruser has quit IRC
325 2020-06-23T18:42:05  *** justanotheruser has joined #bitcoin-core-dev
326 2020-06-23T18:48:29  *** ahmed_ has joined #bitcoin-core-dev
327 2020-06-23T18:49:43  <wumpus> even just compiling and not linking would find the largest part of the errors introduced by changes and drift i guess
328 2020-06-23T18:50:07  <wumpus> link-time errors are kind of rare
329 2020-06-23T18:52:30  *** dr-orlovsky has joined #bitcoin-core-dev
330 2020-06-23T19:12:20  *** dr-orlovsky has quit IRC
331 2020-06-23T19:39:03  *** owowo has quit IRC
332 2020-06-23T19:39:53  *** owowo has joined #bitcoin-core-dev
333 2020-06-23T19:46:03  *** meshcollider has quit IRC
334 2020-06-23T19:49:37  *** Highway62 has joined #bitcoin-core-dev
335 2020-06-23T19:51:03  *** Highway61 has quit IRC
336 2020-06-23T19:51:03  *** Highway62 is now known as Highway61
337 2020-06-23T19:56:11  *** Highway62 has joined #bitcoin-core-dev
338 2020-06-23T19:57:54  *** Highway61 has quit IRC
339 2020-06-23T19:59:51  *** Highway61 has joined #bitcoin-core-dev
340 2020-06-23T20:00:42  *** Highway62 has quit IRC
341 2020-06-23T20:01:57  *** belcher has quit IRC
342 2020-06-23T20:21:38  *** meshcollider has joined #bitcoin-core-dev
343 2020-06-23T20:36:02  *** harrigan has quit IRC
344 2020-06-23T20:38:17  *** harrigan has joined #bitcoin-core-dev
345 2020-06-23T20:39:33  *** owowo has quit IRC
346 2020-06-23T20:44:29  *** owowo has joined #bitcoin-core-dev
347 2020-06-23T20:46:52  *** freedomcode has left #bitcoin-core-dev
348 2020-06-23T20:47:01  *** reardencode has joined #bitcoin-core-dev
349 2020-06-23T21:00:01  *** limpkin1 has quit IRC
350 2020-06-23T21:21:12  *** Cotillion has joined #bitcoin-core-dev
351 2020-06-23T21:26:11  *** marcoagner has quit IRC
352 2020-06-23T21:30:27  *** troygiorshev has quit IRC
353 2020-06-23T21:30:59  *** troygiorshev has joined #bitcoin-core-dev
354 2020-06-23T21:32:28  <luke-jr> in case I overlooked any remaining value, would be good to get extra eyes on https://github.com/bitcoin-core/bitcoincore.org/pull/707
355 2020-06-23T21:32:32  <luke-jr> sipa: instagibbs ^
356 2020-06-23T21:32:51  *** Guyver2 has quit IRC
357 2020-06-23T21:33:27  *** harrigan has quit IRC
358 2020-06-23T21:34:09  *** harrigan has joined #bitcoin-core-dev
359 2020-06-23T21:34:56  <sipa> luke-jr: it depends, i think
360 2020-06-23T21:35:57  <sipa> though it can certainly use a note at least that it's subject to users noticing they're being asked to sign multiple times
361 2020-06-23T21:36:47  <luke-jr> sipa: they might think they're only signing twice to 0.0001 BTC txs, and figure "meh, worst case I lose 0.0002 BTC"
362 2020-06-23T21:37:10  <luke-jr> (while the fee could end up being 100 BTC or whatever)
363 2020-06-23T21:38:14  <sipa> a weaker benefit also remains: you can sign without transfering all txn-creating-outputs-being-spent, in case you know they're correct
364 2020-06-23T21:38:50  <sipa> while pre-segwit you just had to have the full transactions at signing time
365 2020-06-23T21:39:43  *** Talkless has joined #bitcoin-core-dev
366 2020-06-23T21:42:42  *** proofofkeags has quit IRC
367 2020-06-23T21:43:15  *** proofofkeags has joined #bitcoin-core-dev
368 2020-06-23T21:47:47  *** proofofkeags has quit IRC
369 2020-06-23T21:48:06  *** filchef has joined #bitcoin-core-dev
370 2020-06-23T21:48:31  *** bitcoin-git has joined #bitcoin-core-dev
371 2020-06-23T21:48:32  <bitcoin-git> [bitcoin] practicalswift opened pull request #19366: tests: Provide main(...) function in fuzzer. Allow building uninstrumented harnesses with --enable-fuzz. (master...provide-main-function-in-fuzzer) https://github.com/bitcoin/bitcoin/pull/19366
372 2020-06-23T21:48:33  *** bitcoin-git has left #bitcoin-core-dev
373 2020-06-23T21:48:53  *** filchef has quit IRC
374 2020-06-23T21:51:00  *** S3RK has joined #bitcoin-core-dev
375 2020-06-23T21:53:59  *** Highway61 has quit IRC
376 2020-06-23T21:55:29  *** S3RK has quit IRC
377 2020-06-23T22:04:19  <luke-jr> sipa: I don't understand what you mean
378 2020-06-23T22:04:58  <sipa> luke-jr: nvm, i'm wrong
379 2020-06-23T22:07:16  <luke-jr> sipa: there is a request to make a revision to taproot, and call it tarproot.
380 2020-06-23T22:07:30  *** proofofkeags has joined #bitcoin-core-dev
381 2020-06-23T22:08:04  <luke-jr> https://twitter.com/Ethan_Heilman/status/1275545432697995276?s=20 :p
382 2020-06-23T22:08:49  <sipa> ha
383 2020-06-23T22:27:23  *** davterra has quit IRC
384 2020-06-23T22:33:50  *** luke-jr has quit IRC
385 2020-06-23T22:34:41  *** Highway61 has joined #bitcoin-core-dev
386 2020-06-23T22:35:34  *** Pavlenex has joined #bitcoin-core-dev
387 2020-06-23T22:36:14  *** justanotheruser has quit IRC
388 2020-06-23T22:37:09  *** luke-jr has joined #bitcoin-core-dev
389 2020-06-23T22:43:11  *** AaronvanW has quit IRC
390 2020-06-23T22:46:55  *** Pavlenex has quit IRC
391 2020-06-23T22:51:48  *** Dean_Guss has joined #bitcoin-core-dev
392 2020-06-23T22:52:38  *** justanotheruser has joined #bitcoin-core-dev
393 2020-06-23T22:58:06  *** davterra has joined #bitcoin-core-dev
394 2020-06-23T23:15:44  <fanquake> sipa / wumpus: can you block kkarimalami if you haven’t already
395 2020-06-23T23:17:05  <sipa> fanquake: i already did
396 2020-06-23T23:22:56  *** Talkless has quit IRC
397 2020-06-23T23:33:40  *** dr-orlovsky has joined #bitcoin-core-dev
398 2020-06-23T23:37:37  *** dviola has joined #bitcoin-core-dev