1 2020-06-25T00:00:01  *** funkatron has quit IRC
  2 2020-06-25T00:25:12  *** proofofkeags has quit IRC
  3 2020-06-25T00:40:46  *** AaronvanW has quit IRC
  4 2020-06-25T00:41:11  *** S3RK has joined #bitcoin-core-dev
  5 2020-06-25T00:45:30  *** S3RK has quit IRC
  6 2020-06-25T00:48:06  *** S3RK has joined #bitcoin-core-dev
  7 2020-06-25T00:48:43  *** IGHOR has joined #bitcoin-core-dev
  8 2020-06-25T00:52:09  *** IGHOR has quit IRC
  9 2020-06-25T00:54:49  *** zerstoerer has joined #bitcoin-core-dev
 10 2020-06-25T00:56:20  *** tryphe_ has joined #bitcoin-core-dev
 11 2020-06-25T00:56:50  *** tryphe has quit IRC
 12 2020-06-25T01:00:54  *** S3RK has quit IRC
 13 2020-06-25T01:05:58  *** bitdex has joined #bitcoin-core-dev
 14 2020-06-25T01:19:08  *** AaronvanW has joined #bitcoin-core-dev
 15 2020-06-25T01:19:23  *** jarthur_ has joined #bitcoin-core-dev
 16 2020-06-25T01:22:47  *** jarthur has quit IRC
 17 2020-06-25T01:24:11  *** AaronvanW has quit IRC
 18 2020-06-25T01:29:33  *** IGHOR has joined #bitcoin-core-dev
 19 2020-06-25T01:40:52  *** proofofkeags has joined #bitcoin-core-dev
 20 2020-06-25T01:45:41  *** proofofkeags has quit IRC
 21 2020-06-25T01:49:13  *** jarthur_ is now known as jarthur
 22 2020-06-25T03:00:02  *** zerstoerer has quit IRC
 23 2020-06-25T03:05:49  *** Eagle[TM] has joined #bitcoin-core-dev
 24 2020-06-25T03:06:46  *** AaronvanW has joined #bitcoin-core-dev
 25 2020-06-25T03:07:35  *** EagleTM has quit IRC
 26 2020-06-25T03:21:26  *** bitcoin-git has joined #bitcoin-core-dev
 27 2020-06-25T03:21:27  <bitcoin-git> [bitcoin] fanquake opened pull request #19375: build: target Windows 7 when building libevent and fix ipv6 usage (master...libevent_target_0x0601) https://github.com/bitcoin/bitcoin/pull/19375
 28 2020-06-25T03:21:27  *** bitcoin-git has left #bitcoin-core-dev
 29 2020-06-25T03:22:19  *** shrug has joined #bitcoin-core-dev
 30 2020-06-25T03:26:27  *** Highway61 has quit IRC
 31 2020-06-25T03:37:09  *** S3RK has joined #bitcoin-core-dev
 32 2020-06-25T03:39:34  *** AaronvanW has quit IRC
 33 2020-06-25T03:40:57  *** vasild_ has joined #bitcoin-core-dev
 34 2020-06-25T03:44:23  *** vasild has quit IRC
 35 2020-06-25T03:44:24  *** vasild_ is now known as vasild
 36 2020-06-25T04:02:13  <fanquake> wumpus / sipa: can you block dahuisong
 37 2020-06-25T04:42:12  *** jeremyrubin has joined #bitcoin-core-dev
 38 2020-06-25T04:53:29  *** bitcoin-git has joined #bitcoin-core-dev
 39 2020-06-25T04:53:29  <bitcoin-git> [bitcoin] fanquake closed pull request #18287: depends: Patch libevent build to fix IPv6 -rpcbind on Windows (master...fix_libevent_win_ipv6) https://github.com/bitcoin/bitcoin/pull/18287
 40 2020-06-25T04:53:30  *** bitcoin-git has left #bitcoin-core-dev
 41 2020-06-25T05:00:00  *** tryphe_ is now known as tryphe
 42 2020-06-25T05:03:46  *** S3RK has quit IRC
 43 2020-06-25T05:04:14  *** S3RK has joined #bitcoin-core-dev
 44 2020-06-25T05:08:56  *** S3RK has quit IRC
 45 2020-06-25T05:28:21  *** Guyver2 has joined #bitcoin-core-dev
 46 2020-06-25T05:31:27  *** justanotheruser has quit IRC
 47 2020-06-25T05:32:51  *** andrewtoth has quit IRC
 48 2020-06-25T05:36:31  *** AaronvanW has joined #bitcoin-core-dev
 49 2020-06-25T05:59:34  *** jarthur has quit IRC
 50 2020-06-25T06:00:01  *** shrug has quit IRC
 51 2020-06-25T06:06:35  *** IGHOR has quit IRC
 52 2020-06-25T06:08:55  *** IGHOR has joined #bitcoin-core-dev
 53 2020-06-25T06:09:54  *** AaronvanW has quit IRC
 54 2020-06-25T06:22:27  *** Mlpearc has joined #bitcoin-core-dev
 55 2020-06-25T06:25:18  *** bitcoin-git has joined #bitcoin-core-dev
 56 2020-06-25T06:25:19  <bitcoin-git> [bitcoin] hebasto opened pull request #19377: bench: Add OrphanTxPool benchmark (master...200624-m-bench) https://github.com/bitcoin/bitcoin/pull/19377
 57 2020-06-25T06:25:20  *** bitcoin-git has left #bitcoin-core-dev
 58 2020-06-25T06:28:01  *** marcoagner has joined #bitcoin-core-dev
 59 2020-06-25T06:58:43  *** dviola has quit IRC
 60 2020-06-25T07:24:51  *** S3RK has joined #bitcoin-core-dev
 61 2020-06-25T07:29:39  *** bitcoin-git has joined #bitcoin-core-dev
 62 2020-06-25T07:29:39  <bitcoin-git> [bitcoin] hebasto opened pull request #19378: refactor: Use Mutex type for g_cs_recent_confirmed_transactions (master...200625-recent-mx) https://github.com/bitcoin/bitcoin/pull/19378
 63 2020-06-25T07:29:40  *** bitcoin-git has left #bitcoin-core-dev
 64 2020-06-25T07:38:49  *** midnight has quit IRC
 65 2020-06-25T07:47:08  *** midnight has joined #bitcoin-core-dev
 66 2020-06-25T07:56:09  *** AaronvanW has joined #bitcoin-core-dev
 67 2020-06-25T07:57:47  *** midnight has quit IRC
 68 2020-06-25T08:00:33  *** proofofkeags has joined #bitcoin-core-dev
 69 2020-06-25T08:05:14  *** proofofkeags has quit IRC
 70 2020-06-25T08:09:11  *** Pavlenex has joined #bitcoin-core-dev
 71 2020-06-25T08:09:42  *** dr-orlovsky has joined #bitcoin-core-dev
 72 2020-06-25T08:25:52  *** ghost43 has quit IRC
 73 2020-06-25T08:26:11  *** ghost43 has joined #bitcoin-core-dev
 74 2020-06-25T08:33:19  *** Relis has quit IRC
 75 2020-06-25T08:37:46  *** rex4539 has joined #bitcoin-core-dev
 76 2020-06-25T08:38:59  *** kljasdfvv has quit IRC
 77 2020-06-25T08:40:43  *** kljasdfvv has joined #bitcoin-core-dev
 78 2020-06-25T08:56:41  *** midnight has joined #bitcoin-core-dev
 79 2020-06-25T08:59:25  *** dr-orlovsky has quit IRC
 80 2020-06-25T09:00:02  *** Mlpearc has quit IRC
 81 2020-06-25T09:01:27  *** dr-orlovsky has joined #bitcoin-core-dev
 82 2020-06-25T09:14:52  *** S3RK has quit IRC
 83 2020-06-25T09:15:19  *** S3RK has joined #bitcoin-core-dev
 84 2020-06-25T09:19:38  *** S3RK has quit IRC
 85 2020-06-25T09:26:06  *** promag has quit IRC
 86 2020-06-25T09:26:52  *** promag has joined #bitcoin-core-dev
 87 2020-06-25T09:31:23  *** promag has quit IRC
 88 2020-06-25T09:50:18  *** promag has joined #bitcoin-core-dev
 89 2020-06-25T09:56:25  *** simonbusborg has joined #bitcoin-core-dev
 90 2020-06-25T10:01:38  *** proofofkeags has joined #bitcoin-core-dev
 91 2020-06-25T10:03:26  *** Yoshiko54Kub has joined #bitcoin-core-dev
 92 2020-06-25T10:05:49  *** proofofkeags has quit IRC
 93 2020-06-25T10:06:03  *** dr-orlovsky has quit IRC
 94 2020-06-25T10:06:30  *** S3RK has joined #bitcoin-core-dev
 95 2020-06-25T10:07:56  *** Yoshiko54Kub has quit IRC
 96 2020-06-25T10:08:16  *** dr-orlovsky has joined #bitcoin-core-dev
 97 2020-06-25T10:08:39  *** promag has quit IRC
 98 2020-06-25T10:18:41  <wumpus> fanquake: done
 99 2020-06-25T10:30:38  *** dr-orlovsky has quit IRC
100 2020-06-25T10:32:07  *** dr-orlovsky has joined #bitcoin-core-dev
101 2020-06-25T10:45:19  *** promag has joined #bitcoin-core-dev
102 2020-06-25T10:51:43  *** reallll has joined #bitcoin-core-dev
103 2020-06-25T10:52:51  *** dr-orlovsky has quit IRC
104 2020-06-25T10:55:20  *** belcher has quit IRC
105 2020-06-25T11:08:36  <fanquake> wumpus: thanks
106 2020-06-25T11:29:49  *** rex4539 has quit IRC
107 2020-06-25T11:30:59  *** S3RK has quit IRC
108 2020-06-25T11:31:29  *** S3RK has joined #bitcoin-core-dev
109 2020-06-25T11:33:40  *** bitcoin-git has joined #bitcoin-core-dev
110 2020-06-25T11:33:41  <bitcoin-git> [bitcoin] practicalswift opened pull request #19379: tests: Add fuzzing harness for SigHasLowR(...) and ecdsa_signature_parse_der_lax(...) (master...fuzzers-SigHashLowR) https://github.com/bitcoin/bitcoin/pull/19379
111 2020-06-25T11:33:41  *** bitcoin-git has left #bitcoin-core-dev
112 2020-06-25T11:35:58  *** S3RK has quit IRC
113 2020-06-25T11:55:48  *** promag has quit IRC
114 2020-06-25T12:00:01  *** simonbusborg has quit IRC
115 2020-06-25T12:02:20  *** proofofkeags has joined #bitcoin-core-dev
116 2020-06-25T12:07:01  *** proofofkeags has quit IRC
117 2020-06-25T12:08:45  *** Highway61 has joined #bitcoin-core-dev
118 2020-06-25T12:09:06  *** bitcoin-git has joined #bitcoin-core-dev
119 2020-06-25T12:09:07  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/67881de0e3b1...c9d1040d254e
120 2020-06-25T12:09:07  <bitcoin-git> bitcoin/master 9b8907f Elichai Turkel: Check size after Unserializing CPubKey
121 2020-06-25T12:09:08  <bitcoin-git> bitcoin/master 37ae687 Elichai Turkel: Add tests for CPubKey serialization/unserialization
122 2020-06-25T12:09:08  <bitcoin-git> bitcoin/master c9d1040 MarcoFalke: Merge #19237: wallet: Check size after unserializing a pubkey
123 2020-06-25T12:09:10  *** bitcoin-git has left #bitcoin-core-dev
124 2020-06-25T12:09:26  *** bitcoin-git has joined #bitcoin-core-dev
125 2020-06-25T12:09:26  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19237: wallet: Check size after unserializing a pubkey (master...2020-06-pubkey) https://github.com/bitcoin/bitcoin/pull/19237
126 2020-06-25T12:09:27  *** bitcoin-git has left #bitcoin-core-dev
127 2020-06-25T12:21:30  *** miconda has joined #bitcoin-core-dev
128 2020-06-25T12:23:07  *** IGHOR has quit IRC
129 2020-06-25T12:24:36  *** TheRec has joined #bitcoin-core-dev
130 2020-06-25T12:24:37  *** TheRec has joined #bitcoin-core-dev
131 2020-06-25T12:25:54  *** troygiorshev has quit IRC
132 2020-06-25T12:27:13  *** troygiorshev has joined #bitcoin-core-dev
133 2020-06-25T12:59:34  *** bitcoin-git has joined #bitcoin-core-dev
134 2020-06-25T12:59:34  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c9d1040d254e...ead6d686eb68
135 2020-06-25T12:59:34  <bitcoin-git> bitcoin/master 3f686d1 practicalswift: ci: Run fuzz testing test cases (bitcoin-core/qa-assets) under valgrind to...
136 2020-06-25T12:59:35  <bitcoin-git> bitcoin/master ead6d68 MarcoFalke: Merge #18912: ci: Run fuzz testing test cases (bitcoin-core/qa-assets) und...
137 2020-06-25T12:59:35  *** bitcoin-git has left #bitcoin-core-dev
138 2020-06-25T13:00:18  *** bitcoin-git has joined #bitcoin-core-dev
139 2020-06-25T13:00:19  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18912: ci: Run fuzz testing test cases (bitcoin-core/qa-assets) under valgrind to catch memory errors (master...fuzzers-under-valgrind) https://github.com/bitcoin/bitcoin/pull/18912
140 2020-06-25T13:00:20  *** bitcoin-git has left #bitcoin-core-dev
141 2020-06-25T13:09:14  *** nullptr| has quit IRC
142 2020-06-25T13:24:50  *** sipsorcery has quit IRC
143 2020-06-25T13:25:51  *** IGHOR has joined #bitcoin-core-dev
144 2020-06-25T13:26:42  *** IGHOR has quit IRC
145 2020-06-25T13:30:36  *** IGHOR has joined #bitcoin-core-dev
146 2020-06-25T13:31:43  *** bitcoin-git has joined #bitcoin-core-dev
147 2020-06-25T13:31:45  <bitcoin-git> [bitcoin] MarcoFalke pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/ead6d686eb68...3a4a3729d933
148 2020-06-25T13:31:46  <bitcoin-git> bitcoin/master fa609c4 MarcoFalke: scheduler: Remove unused REVERSE_LOCK
149 2020-06-25T13:31:47  <bitcoin-git> bitcoin/master fa98196 MarcoFalke: test: Remove unused scheduler.h include from the common setup
150 2020-06-25T13:31:47  <bitcoin-git> bitcoin/master fab2950 MarcoFalke: doc: Switch boost::thread to std::thread in scheduler
151 2020-06-25T13:31:49  *** bitcoin-git has left #bitcoin-core-dev
152 2020-06-25T13:32:17  *** bitcoin-git has joined #bitcoin-core-dev
153 2020-06-25T13:32:18  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19090: refactor: Misc scheduler cleanups (master...2005-schedulerCleanup) https://github.com/bitcoin/bitcoin/pull/19090
154 2020-06-25T13:32:19  *** bitcoin-git has left #bitcoin-core-dev
155 2020-06-25T13:35:53  *** sipsorcery has joined #bitcoin-core-dev
156 2020-06-25T13:37:04  *** bitcoin-git has joined #bitcoin-core-dev
157 2020-06-25T13:37:04  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3a4a3729d933...90981b7d683a
158 2020-06-25T13:37:04  <bitcoin-git> bitcoin/master 67bb7be practicalswift: tests: Add fuzzing harness for CHash{160,256}, C{HMAC_,}SHA{1,256,512}, CR...
159 2020-06-25T13:37:05  <bitcoin-git> bitcoin/master 90981b7 MarcoFalke: Merge #19286: tests: Add fuzzing harness for CHash{160,256}, C{HMAC_,}SHA{...
160 2020-06-25T13:37:06  *** bitcoin-git has left #bitcoin-core-dev
161 2020-06-25T13:37:24  *** bitcoin-git has joined #bitcoin-core-dev
162 2020-06-25T13:37:24  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19286: tests: Add fuzzing harness for CHash{160,256}, C{HMAC_,}SHA{1,256,512}, CRIPEMD160, CSipHasher, etc. (master...fuzzers-crypto) https://github.com/bitcoin/bitcoin/pull/19286
163 2020-06-25T13:37:26  *** bitcoin-git has left #bitcoin-core-dev
164 2020-06-25T13:47:39  *** bitcoin-git has joined #bitcoin-core-dev
165 2020-06-25T13:47:39  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/90981b7d683a...c8fa03d1766c
166 2020-06-25T13:47:39  <bitcoin-git> bitcoin/master 1307686 Hennadii Stepanov: refactor: Use Mutex type for g_cs_recent_confirmed_transactions
167 2020-06-25T13:47:39  <bitcoin-git> bitcoin/master c8fa03d MarcoFalke: Merge #19378: refactor: Use Mutex type for g_cs_recent_confirmed_transacti...
168 2020-06-25T13:47:41  *** bitcoin-git has left #bitcoin-core-dev
169 2020-06-25T13:47:59  *** bitcoin-git has joined #bitcoin-core-dev
170 2020-06-25T13:47:59  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19378: refactor: Use Mutex type for g_cs_recent_confirmed_transactions (master...200625-recent-mx) https://github.com/bitcoin/bitcoin/pull/19378
171 2020-06-25T13:48:00  *** bitcoin-git has left #bitcoin-core-dev
172 2020-06-25T13:53:17  *** promag has joined #bitcoin-core-dev
173 2020-06-25T13:55:50  *** yiannix has joined #bitcoin-core-dev
174 2020-06-25T13:56:08  *** reallll is now known as belcher
175 2020-06-25T14:01:18  *** kristapsk has joined #bitcoin-core-dev
176 2020-06-25T14:01:25  *** proofofkeags has joined #bitcoin-core-dev
177 2020-06-25T14:13:16  *** yancy has quit IRC
178 2020-06-25T14:23:14  *** Pavlenex has quit IRC
179 2020-06-25T14:25:44  *** root has joined #bitcoin-core-dev
180 2020-06-25T14:25:46  *** root is now known as Guest8998
181 2020-06-25T14:27:01  *** Guest8998 has left #bitcoin-core-dev
182 2020-06-25T14:27:46  *** yancy has joined #bitcoin-core-dev
183 2020-06-25T14:31:32  *** raycoms has joined #bitcoin-core-dev
184 2020-06-25T15:00:02  *** miconda has quit IRC
185 2020-06-25T15:00:34  *** molz_ has quit IRC
186 2020-06-25T15:07:14  *** Highway62 has joined #bitcoin-core-dev
187 2020-06-25T15:08:45  *** Highway61 has quit IRC
188 2020-06-25T15:08:45  *** Highway62 is now known as Highway61
189 2020-06-25T15:10:17  *** bitcoin-git has joined #bitcoin-core-dev
190 2020-06-25T15:10:18  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c8fa03d1766c...910f0468a1f7
191 2020-06-25T15:10:18  <bitcoin-git> bitcoin/master 39d526b Duncan Dean: test: Bump linter versions
192 2020-06-25T15:10:19  <bitcoin-git> bitcoin/master 910f046 MarcoFalke: Merge #19348: test: Bump linter versions
193 2020-06-25T15:10:21  *** bitcoin-git has left #bitcoin-core-dev
194 2020-06-25T15:10:37  *** bitcoin-git has joined #bitcoin-core-dev
195 2020-06-25T15:10:37  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19348: test: Bump linter versions (master...bump-mypy) https://github.com/bitcoin/bitcoin/pull/19348
196 2020-06-25T15:10:38  *** bitcoin-git has left #bitcoin-core-dev
197 2020-06-25T15:11:21  *** promag has quit IRC
198 2020-06-25T15:13:13  *** yancy has quit IRC
199 2020-06-25T15:13:30  *** bitcoin-git has joined #bitcoin-core-dev
200 2020-06-25T15:13:30  <bitcoin-git> [bitcoin] practicalswift closed pull request #19366: tests: Provide main(...) function in fuzzer. Allow building uninstrumented harnesses with --enable-fuzz. (master...provide-main-function-in-fuzzer) https://github.com/bitcoin/bitcoin/pull/19366
201 2020-06-25T15:13:31  *** bitcoin-git has left #bitcoin-core-dev
202 2020-06-25T15:13:49  *** bitcoin-git has joined #bitcoin-core-dev
203 2020-06-25T15:13:50  <bitcoin-git> [bitcoin] practicalswift reopened pull request #19366: tests: Provide main(...) function in fuzzer. Allow building uninstrumented harnesses with --enable-fuzz. (master...provide-main-function-in-fuzzer) https://github.com/bitcoin/bitcoin/pull/19366
204 2020-06-25T15:13:51  *** bitcoin-git has left #bitcoin-core-dev
205 2020-06-25T15:19:52  *** yancy has joined #bitcoin-core-dev
206 2020-06-25T15:21:34  *** serAphim has joined #bitcoin-core-dev
207 2020-06-25T15:22:20  *** yancy has quit IRC
208 2020-06-25T15:23:48  *** root has joined #bitcoin-core-dev
209 2020-06-25T15:23:51  *** root is now known as Guest1802
210 2020-06-25T15:24:07  *** Guest1802 has left #bitcoin-core-dev
211 2020-06-25T15:25:10  *** bitdex has quit IRC
212 2020-06-25T15:26:50  *** Highway61 has quit IRC
213 2020-06-25T15:33:24  *** raycoms has quit IRC
214 2020-06-25T15:34:54  *** owowo has joined #bitcoin-core-dev
215 2020-06-25T15:34:54  *** owowo has joined #bitcoin-core-dev
216 2020-06-25T15:38:27  *** raycoms has joined #bitcoin-core-dev
217 2020-06-25T15:44:00  *** Talkless has joined #bitcoin-core-dev
218 2020-06-25T15:44:03  *** vasild has quit IRC
219 2020-06-25T15:45:51  *** vasild has joined #bitcoin-core-dev
220 2020-06-25T15:51:05  *** yancy has joined #bitcoin-core-dev
221 2020-06-25T15:58:29  *** jarthur has joined #bitcoin-core-dev
222 2020-06-25T16:01:35  *** baldur has quit IRC
223 2020-06-25T16:02:53  *** yiannix has quit IRC
224 2020-06-25T16:03:28  *** owowo has quit IRC
225 2020-06-25T16:10:54  *** owowo has joined #bitcoin-core-dev
226 2020-06-25T16:11:03  *** troygiorshev has quit IRC
227 2020-06-25T16:11:41  *** troygiorshev has joined #bitcoin-core-dev
228 2020-06-25T16:14:07  *** baldur has joined #bitcoin-core-dev
229 2020-06-25T16:22:13  *** owowo has quit IRC
230 2020-06-25T16:26:56  *** owowo has joined #bitcoin-core-dev
231 2020-06-25T16:29:34  *** Pavlenex has joined #bitcoin-core-dev
232 2020-06-25T16:30:49  *** promag has joined #bitcoin-core-dev
233 2020-06-25T16:32:08  *** gymhet50 has joined #bitcoin-core-dev
234 2020-06-25T16:32:11  *** Highway61 has joined #bitcoin-core-dev
235 2020-06-25T16:32:14  *** gymhet50 has quit IRC
236 2020-06-25T16:36:07  *** jellybois has left #bitcoin-core-dev
237 2020-06-25T16:44:55  <provoostenator> sipa shesek achow101see also #18043
238 2020-06-25T16:44:57  <gribble> https://github.com/bitcoin/bitcoin/issues/18043 | Output Descriptor encoding · Issue #18043 · bitcoin/bitcoin · GitHub
239 2020-06-25T16:47:05  *** troygiorshev has quit IRC
240 2020-06-25T16:51:14  <jonatack> meshcollider: kallewoof: #11413 has 3 acks now 🚀
241 2020-06-25T16:51:18  <gribble> https://github.com/bitcoin/bitcoin/issues/11413 | [wallet] [rpc] sendtoaddress/sendmany: Add explicit feerate option by kallewoof · Pull Request #11413 · bitcoin/bitcoin · GitHub
242 2020-06-25T16:57:32  * kallewoof cheers :)
243 2020-06-25T17:01:35  *** asoltys has quit IRC
244 2020-06-25T17:04:19  *** mol has joined #bitcoin-core-dev
245 2020-06-25T17:18:42  *** bitcoin-git has joined #bitcoin-core-dev
246 2020-06-25T17:18:42  <bitcoin-git> [bitcoin] rajarshimaitra opened pull request #19381: Fixes UB reported in issue #19278 (master...loadmempool-UB) https://github.com/bitcoin/bitcoin/pull/19381
247 2020-06-25T17:18:43  *** bitcoin-git has left #bitcoin-core-dev
248 2020-06-25T17:23:29  *** raycoms has quit IRC
249 2020-06-25T17:25:05  *** Highway62 has joined #bitcoin-core-dev
250 2020-06-25T17:25:26  *** Highway61 has quit IRC
251 2020-06-25T17:25:26  *** Highway62 is now known as Highway61
252 2020-06-25T17:26:36  *** mol_ has joined #bitcoin-core-dev
253 2020-06-25T17:28:22  *** mol has quit IRC
254 2020-06-25T17:48:24  *** someone235 has quit IRC
255 2020-06-25T17:50:30  *** justanotheruser has joined #bitcoin-core-dev
256 2020-06-25T17:54:24  *** bitcoin-git has joined #bitcoin-core-dev
257 2020-06-25T17:54:24  <bitcoin-git> [bitcoin] laanwj pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/910f0468a1f7...f32f7e907a5e
258 2020-06-25T17:54:25  <bitcoin-git> bitcoin/master 69158b4 Karl-Johan Alm: added CURRENCY_ATOM to express minimum indivisible unit
259 2020-06-25T17:54:25  <bitcoin-git> bitcoin/master 91f6d2b Karl-Johan Alm: rpc/wallet: add conf_target as alias to confTarget in bumpfee
260 2020-06-25T17:54:27  <bitcoin-git> bitcoin/master 5d1a411 Karl-Johan Alm: fees: add FeeModes doc helper function
261 2020-06-25T17:54:28  *** bitcoin-git has left #bitcoin-core-dev
262 2020-06-25T17:56:31  *** bitcoin-git has joined #bitcoin-core-dev
263 2020-06-25T17:56:31  <bitcoin-git> [bitcoin] laanwj merged pull request #11413: [wallet] [rpc] sendtoaddress/sendmany: Add explicit feerate option (master...explicit-fee) https://github.com/bitcoin/bitcoin/pull/11413
264 2020-06-25T17:56:32  *** bitcoin-git has left #bitcoin-core-dev
265 2020-06-25T17:57:46  *** Guyver2_ has joined #bitcoin-core-dev
266 2020-06-25T18:00:01  *** serAphim has quit IRC
267 2020-06-25T18:00:58  *** Guyver2 has quit IRC
268 2020-06-25T18:09:24  <provoostenator> Can #19215 be added to the hardware wallet project? It's a pain test stuff on updated devices without that...
269 2020-06-25T18:09:26  <gribble> https://github.com/bitcoin/bitcoin/issues/19215 | psbt: Include and allow both non_witness_utxo and witness_utxo for segwit inputs by achow101 · Pull Request #19215 · bitcoin/bitcoin · GitHub
270 2020-06-25T18:13:10  <luke-jr> on that note, it might be nice if there was a HWI preview release people could play with
271 2020-06-25T18:16:17  <achow101> luke-jr: https://github.com/bitcoin-core/HWI/releases/tag/1.1.2-rc.2 ?
272 2020-06-25T18:17:55  <sipa> achow101: hmm, so the solution is to generally store both witness utxo and non-witness utxo in every psbt?
273 2020-06-25T18:18:00  <luke-jr> achow101: oh, there are
274 2020-06-25T18:18:10  <achow101> sipa: yes
275 2020-06-25T18:18:16  <sipa> or rather, non-witness utxo for non-witness inputs; and both for witness inputs
276 2020-06-25T18:18:45  <sipa> that's probably the most compatible solution... but it's also a bit overkill to store the witness one if you have the non-witness one already
277 2020-06-25T18:19:11  <sipa> do you think anything would break with just having the non-witness one for witness inputs?
278 2020-06-25T18:19:25  <wumpus> should I revert #11413?
279 2020-06-25T18:19:28  <gribble> https://github.com/bitcoin/bitcoin/issues/11413 | [wallet] [rpc] sendtoaddress/sendmany: Add explicit feerate option by kallewoof · Pull Request #11413 · bitcoin/bitcoin · GitHub
280 2020-06-25T18:19:41  <achow101> the previous version of HWI will break with just the non-witness one
281 2020-06-25T18:19:57  <wumpus> with all the ACKs I did not realise it was still contentious
282 2020-06-25T18:19:57  <achow101> it will sign but with the wrong type of signature
283 2020-06-25T18:20:01  <luke-jr> achow101: aha, I meant a fork of Core with the full HWI integration stuff
284 2020-06-25T18:20:15  <achow101> luke-jr: oh, not that I know of
285 2020-06-25T18:20:23  <wumpus> I think MarcoFalke 's comment makes sense though
286 2020-06-25T18:20:39  *** kensanata1 has joined #bitcoin-core-dev
287 2020-06-25T18:20:44  <provoostenator> The idea of making it a single argument was discussed earlier in that thread I believe
288 2020-06-25T18:21:01  <provoostenator> I was an endless back and forth between keeping it backwards capatible or more sane
289 2020-06-25T18:21:20  <wumpus> this sounds dangerous though
290 2020-06-25T18:21:40  <wumpus> I do not want this to result in people adidng 1000x as much fee as expected or things like that
291 2020-06-25T18:21:47  <sipa> achow101: makes sense... it is a violaton of the BIP unfortunately :(
292 2020-06-25T18:21:49  <luke-jr> #17356 might make it cleaner
293 2020-06-25T18:21:51  <gribble> https://github.com/bitcoin/bitcoin/issues/17356 | RPC: Internal named params by luke-jr · Pull Request #17356 · bitcoin/bitcoin · GitHub
294 2020-06-25T18:22:07  <provoostenator> wumpus: it's supposed to prevent that
295 2020-06-25T18:22:26  <wumpus> provoostenator: added #19215 to hw project
296 2020-06-25T18:22:26  <provoostenator> Because if you enter "1" it won't interpret that at BTC/KB
297 2020-06-25T18:22:28  <gribble> https://github.com/bitcoin/bitcoin/issues/19215 | psbt: Include and allow both non_witness_utxo and witness_utxo for segwit inputs by achow101 · Pull Request #19215 · bitcoin/bitcoin · GitHub
298 2020-06-25T18:23:22  <achow101> sipa: I guess I should update the bip
299 2020-06-25T18:23:23  <wumpus> provoostenator: OK, I guess there is still some time to figure this out before the release
300 2020-06-25T18:23:37  <wumpus> I'm also not sure reverting the entire PR makes sense
301 2020-06-25T18:24:09  <sipa> achow101: right
302 2020-06-25T18:24:52  <luke-jr> Even if we get to a release point, might be nicer to just minimally remove the RPC interface to it
303 2020-06-25T18:25:14  <sipa> achow101: it's unfortunate that this pushes behaviour towards a postel's law...
304 2020-06-25T18:26:31  <provoostenator> This uses the "unset" estimate mode, as before IIUC: bitcoin-cli sendtoaddress bcrt1... 1 "" "" false false 1
305 2020-06-25T18:26:46  <provoostenator> And this uses satoshi per byte: bitcoin-cli sendtoaddress bcrt1... 1 "" "" false false 1 sat/b
306 2020-06-25T18:27:52  <provoostenator> I've never been a fan of the "unset" estimate mode, documented as "Use default settings based on other criteria". I would prefer failure.
307 2020-06-25T18:28:16  <achow101> sipa: it's supposed to be for compatibility with older software that relies on the type of utxo available to determine signing
308 2020-06-25T18:28:36  <sipa> achow101: yes, i understand - i'm not saying it's the wrong choice
309 2020-06-25T18:28:36  *** dr-orlovsky has joined #bitcoin-core-dev
310 2020-06-25T18:28:42  <sipa> only saddened by its necessity
311 2020-06-25T18:28:58  <achow101> but it might also be probable that most of those software are following our same check that both utxos aren't provided
312 2020-06-25T18:29:43  *** Mercury_Vapor has quit IRC
313 2020-06-25T18:29:46  <achow101> in which case it wouldn't be necessary
314 2020-06-25T18:30:14  <luke-jr> and then the witness_utxo gets renamed to taproot_utxo? :p
315 2020-06-25T18:32:26  *** Pavlenex has quit IRC
316 2020-06-25T18:32:26  *** proofofkeags has quit IRC
317 2020-06-25T18:33:01  *** proofofkeags has joined #bitcoin-core-dev
318 2020-06-25T18:37:14  *** proofofkeags has quit IRC
319 2020-06-25T18:41:00  *** Highway62 has joined #bitcoin-core-dev
320 2020-06-25T18:42:34  *** Highway61 has quit IRC
321 2020-06-25T18:42:34  *** Highway62 is now known as Highway61
322 2020-06-25T18:44:07  *** troygiorshev has joined #bitcoin-core-dev
323 2020-06-25T18:48:33  *** IGHOR has quit IRC
324 2020-06-25T18:59:28  <provoostenator> #16378 just went from 16 commits down to 4...
325 2020-06-25T18:59:30  <gribble> https://github.com/bitcoin/bitcoin/issues/16378 | The ultimate send RPC by Sjors · Pull Request #16378 · bitcoin/bitcoin · GitHub
326 2020-06-25T19:00:33  <wumpus> #startmeeting
327 2020-06-25T19:00:33  <lightningbot> Meeting started Thu Jun 25 19:00:33 2020 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
328 2020-06-25T19:00:33  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
329 2020-06-25T19:00:40  <promag> hi
330 2020-06-25T19:00:41  <achow101> hi
331 2020-06-25T19:00:45  <hebasto> hi
332 2020-06-25T19:00:46  <sipsorcery> hi
333 2020-06-25T19:00:57  <sipa> hi
334 2020-06-25T19:00:59  <fjahr> hi
335 2020-06-25T19:01:10  <jonatack> sleepy hi
336 2020-06-25T19:01:10  <ariard> hi
337 2020-06-25T19:01:15  <jonasschnelli> hi
338 2020-06-25T19:01:21  <provoostenator> hi
339 2020-06-25T19:01:26  <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr
340 2020-06-25T19:01:28  <wumpus> jeremyrubin lightlike emilengler jonatack hebasto jb55 elichai2
341 2020-06-25T19:01:42  <meshcollider> hi
342 2020-06-25T19:02:14  <instagibbs> hi
343 2020-06-25T19:02:15  <wumpus> there are no pre-proposed meeting topics for this week in http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.tx
344 2020-06-25T19:02:26  <wumpus> any last minute ones ?
345 2020-06-25T19:02:30  *** proofofkeags has joined #bitcoin-core-dev
346 2020-06-25T19:02:55  *** IGHOR has joined #bitcoin-core-dev
347 2020-06-25T19:03:10  <wumpus> #topic High priority for review
348 2020-06-25T19:03:28  <wumpus> currently https://github.com/bitcoin/bitcoin/projects/8   13 blockers, 1 bugfix, 3 chasing concept ACK
349 2020-06-25T19:03:44  <wumpus> anything to add/remove/switch around?
350 2020-06-25T19:03:53  <hebasto> Could I nominate #18307 for high-prio?
351 2020-06-25T19:03:55  <gribble> https://github.com/bitcoin/bitcoin/issues/18307 | build: Require pkg-config for all of the hosts by hebasto · Pull Request #18307 · bitcoin/bitcoin · GitHub
352 2020-06-25T19:05:02  <wumpus> hebasto: sure, added
353 2020-06-25T19:05:08  <hebasto> thanks!
354 2020-06-25T19:05:34  <wumpus> I somehow thought  #18297 already did this :)
355 2020-06-25T19:05:37  <gribble> https://github.com/bitcoin/bitcoin/issues/18297 | build: Use pkg-config in BITCOIN_QT_CONFIGURE for all hosts including Windows by hebasto · Pull Request #18297 · bitcoin/bitcoin · GitHub
356 2020-06-25T19:05:40  <jeremyrubin> hi
357 2020-06-25T19:05:45  <luke-jr> tbh I  never really understood why we didn't do this from the start
358 2020-06-25T19:06:12  <hebasto> 18297 did for Qt only
359 2020-06-25T19:06:27  <luke-jr> yes, I mean why we *ever* had any other behaviour
360 2020-06-25T19:06:43  <wumpus> luke-jr: it used to be extremely difficult or even impossible to get pkgconfig to do the right thing on mingw
361 2020-06-25T19:06:54  <luke-jr> wumpus: really? I never had a problem :/
362 2020-06-25T19:07:05  <wumpus> or at least that was the assumption, it grew from that
363 2020-06-25T19:07:24  <wumpus> sure, it could have been a faulty assumption
364 2020-06-25T19:07:38  <wumpus> in any case I'm happy that this can use a simpler unified approach now
365 2020-06-25T19:08:10  <luke-jr> I guess someone should test it in the same environment that once had problems?
366 2020-06-25T19:08:12  <wumpus> FWIW I also remember pkg-config horror with cross-compiles in the past, this became a lot better in recent times
367 2020-06-25T19:08:24  <cfields> ^^ what wumpus said. mingw+pkgconfig wasn't well supported when it was implemented.
368 2020-06-25T19:08:36  <wumpus> I doubt that environment still exists, or is capable of building bitcoin core :)
369 2020-06-25T19:08:42  <luke-jr> wumpus: I thought half the point of pkg-config in the first place was to fix cross-compile stuff
370 2020-06-25T19:09:14  <luke-jr> ie, by having text files defining the requirements instead of custom qt-config type binaries
371 2020-06-25T19:10:01  <luke-jr> wumpus: well, MingW on Windows then?
372 2020-06-25T19:10:12  <wumpus> in my case it was something with paths not getting set right in the text files
373 2020-06-25T19:10:19  <luke-jr> would be a shame to get locked into MSVC++ for native Windows builds
374 2020-06-25T19:10:26  <luke-jr> i c
375 2020-06-25T19:10:28  <cfields> luke-jr: a big part of the problem was that libs didn't bother trying to get the libs right for windows. Now they're better.
376 2020-06-25T19:10:37  <wumpus> so it required an ugly level of patching, or, the target program supporting another way to pass in dependencies
377 2020-06-25T19:10:45  <wumpus> in any case this was problably solved 5 years ago :)
378 2020-06-25T19:11:03  <wumpus> it's no longer relevant and we can move on
379 2020-06-25T19:11:13  <wumpus> does anyone have other topics to discuss?
380 2020-06-25T19:11:27  <luke-jr> wtxid relay got a BIP I saw
381 2020-06-25T19:12:13  <luke-jr> oh, and shaolinfry merged my PR to BIP 8, which fixes up some stuff and also enables a path forward for any other revisions we might want to make
382 2020-06-25T19:12:24  <wumpus> good to hear that
383 2020-06-25T19:12:29  <sipa> BIP 339 is wtxid relay
384 2020-06-25T19:12:33  <luke-jr> (enables it because that PR added me as a co-champion)
385 2020-06-25T19:13:37  <sipa> anyway, short meeting is best meeting?
386 2020-06-25T19:13:50  <wumpus> https://github.com/bitcoin/bips/blob/master/bip-0339.mediawiki
387 2020-06-25T19:13:52  <luke-jr> XD
388 2020-06-25T19:13:55  <wumpus> yes :)
389 2020-06-25T19:13:57  <wumpus> #endmeeting
390 2020-06-25T19:13:57  <lightningbot> Meeting ended Thu Jun 25 19:13:57 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
391 2020-06-25T19:13:57  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-06-25-19.00.html
392 2020-06-25T19:13:57  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-06-25-19.00.txt
393 2020-06-25T19:13:57  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-06-25-19.00.log.html
394 2020-06-25T19:17:38  *** Talkless has quit IRC
395 2020-06-25T19:17:44  *** gimballock has joined #bitcoin-core-dev
396 2020-06-25T19:17:46  <promag> Marco ping re 19033
397 2020-06-25T19:18:19  *** tryphe has quit IRC
398 2020-06-25T19:18:21  *** tryphe_ has joined #bitcoin-core-dev
399 2020-06-25T19:19:39  *** kristapsk has quit IRC
400 2020-06-25T19:24:34  *** gimballock has quit IRC
401 2020-06-25T19:27:30  *** dr-orlovsky has quit IRC
402 2020-06-25T19:50:26  *** yiannix has joined #bitcoin-core-dev
403 2020-06-25T19:50:46  *** promag has quit IRC
404 2020-06-25T20:03:24  *** rex4539 has joined #bitcoin-core-dev
405 2020-06-25T20:05:01  *** rex4539 has quit IRC
406 2020-06-25T20:09:52  *** Guyver2_ has quit IRC
407 2020-06-25T20:10:10  *** rex4539 has joined #bitcoin-core-dev
408 2020-06-25T20:18:17  *** Mercury_Vapor has joined #bitcoin-core-dev
409 2020-06-25T20:48:02  *** jonatack has quit IRC
410 2020-06-25T20:51:50  *** justan0theruser has joined #bitcoin-core-dev
411 2020-06-25T20:53:05  *** justanotheruser has quit IRC
412 2020-06-25T20:57:12  *** rex4539 has quit IRC
413 2020-06-25T21:00:02  *** kensanata1 has quit IRC
414 2020-06-25T21:09:06  *** owowo has quit IRC
415 2020-06-25T21:09:51  *** owowo has joined #bitcoin-core-dev
416 2020-06-25T21:20:55  *** yiannix has quit IRC
417 2020-06-25T21:21:48  *** drewdrew has joined #bitcoin-core-dev
418 2020-06-25T21:24:01  *** tryphe_ is now known as tryphe
419 2020-06-25T21:26:14  *** marcoagner has quit IRC
420 2020-06-25T21:29:01  *** tryphe_ has joined #bitcoin-core-dev
421 2020-06-25T21:29:34  *** tryphe has quit IRC
422 2020-06-25T21:44:56  *** proofofkeags has quit IRC
423 2020-06-25T21:45:29  *** proofofkeags has joined #bitcoin-core-dev
424 2020-06-25T21:47:41  *** mol_ has quit IRC
425 2020-06-25T21:50:01  *** proofofkeags has quit IRC
426 2020-06-25T21:51:24  *** promag has joined #bitcoin-core-dev
427 2020-06-25T21:55:54  *** promag has quit IRC
428 2020-06-25T21:55:56  *** proofofkeags has joined #bitcoin-core-dev
429 2020-06-25T21:56:28  *** isis is now known as isis_
430 2020-06-25T22:18:35  *** mol has joined #bitcoin-core-dev
431 2020-06-25T22:24:35  *** proofofkeags has quit IRC
432 2020-06-25T22:25:10  *** proofofkeags has joined #bitcoin-core-dev
433 2020-06-25T22:29:25  *** proofofkeags has quit IRC
434 2020-06-25T22:29:42  *** proofofkeags has joined #bitcoin-core-dev
435 2020-06-25T22:58:12  *** kristapsk has joined #bitcoin-core-dev
436 2020-06-25T22:59:34  *** AaronvanW has quit IRC
437 2020-06-25T23:03:11  *** jeremyrubin has quit IRC
438 2020-06-25T23:28:12  *** mol_ has joined #bitcoin-core-dev
439 2020-06-25T23:30:13  *** promag has joined #bitcoin-core-dev
440 2020-06-25T23:30:50  *** justan0theruser has quit IRC
441 2020-06-25T23:32:14  *** mol has quit IRC
442 2020-06-25T23:35:06  *** promag has quit IRC
443 2020-06-25T23:46:40  <shesek> provoostenator, thanks for the link
444 2020-06-25T23:47:26  *** tralfaz has quit IRC
445 2020-06-25T23:49:15  *** justan0theruser has joined #bitcoin-core-dev
446 2020-06-25T23:53:44  *** tralfaz has joined #bitcoin-core-dev
447 2020-06-25T23:54:48  *** tralfaz is now known as davterra