1 2020-06-26T00:00:02  *** drewdrew has quit IRC
  2 2020-06-26T00:21:57  *** brrr has joined #bitcoin-core-dev
  3 2020-06-26T00:27:22  *** mol has joined #bitcoin-core-dev
  4 2020-06-26T00:29:54  *** mol_ has quit IRC
  5 2020-06-26T00:40:09  *** proofofkeags has quit IRC
  6 2020-06-26T00:40:14  *** Bullitje has left #bitcoin-core-dev
  7 2020-06-26T01:00:54  *** proofofkeags has joined #bitcoin-core-dev
  8 2020-06-26T01:23:52  *** rodarmor has quit IRC
  9 2020-06-26T01:40:04  *** dviola has joined #bitcoin-core-dev
 10 2020-06-26T01:43:28  *** isis_ is now known as isis
 11 2020-06-26T01:48:13  *** proofofkeags has quit IRC
 12 2020-06-26T01:59:54  *** Highway61 has quit IRC
 13 2020-06-26T02:11:43  *** bitdex has joined #bitcoin-core-dev
 14 2020-06-26T02:18:40  *** shesek has quit IRC
 15 2020-06-26T02:19:07  *** shesek has joined #bitcoin-core-dev
 16 2020-06-26T02:19:07  *** shesek has joined #bitcoin-core-dev
 17 2020-06-26T02:19:34  *** proofofkeags has joined #bitcoin-core-dev
 18 2020-06-26T02:21:04  *** ppisati has quit IRC
 19 2020-06-26T02:22:24  <cfields> sipa: did you use cppreference as a template for implementing span?
 20 2020-06-26T02:23:12  <cfields> trying to figure out some weirdness.
 21 2020-06-26T02:23:35  <sipa> cfields: yeah
 22 2020-06-26T02:23:43  *** proofofkeags has quit IRC
 23 2020-06-26T02:23:59  <sipa> but just because it lists a copy constructor doesn't mean the implementation needs one explicitly of course
 24 2020-06-26T02:24:38  <cfields> sipa: sure, not concerned about that.
 25 2020-06-26T02:26:31  <cfields> sipa: I believe cppreference is using an outdated draft. Just wanted to see if that's what you were going by.
 26 2020-06-26T02:26:43  <cfields> will dig deeper tomorrow.
 27 2020-06-26T02:27:52  <sipa> cfields: at least it's up to date with using size_t as size type (it used to be ssize_t in an even older draft)
 28 2020-06-26T02:29:22  <cfields> sipa: aha, right. Thanks, that helps.
 29 2020-06-26T02:42:37  <cfields> sipa: specifically, ctor #7 is absent from the current draft: https://en.cppreference.com/w/cpp/container/span/span
 30 2020-06-26T02:42:40  <gribble> https://github.com/bitcoin/bitcoin/issues/7 | Block-header-only, faster startup client · Issue #7 · bitcoin/bitcoin · GitHub
 31 2020-06-26T02:42:57  <cfields> as implemented by libc++: https://github.com/llvm/llvm-project/blob/master/libcxx/include/span
 32 2020-06-26T02:46:35  <sipa> cfields: cppreference.cpp is a wiki ;)
 33 2020-06-26T02:48:20  <luke-jr> lol
 34 2020-06-26T02:48:33  <cfields> haha, fair enough.
 35 2020-06-26T02:48:45  <cfields> s/will dig deeper tomorrow/will perform surgery tomorrow/
 36 2020-06-26T02:48:46  <cfields> :)
 37 2020-06-26T02:52:51  *** proofofkeags has joined #bitcoin-core-dev
 38 2020-06-26T02:55:42  <sipa> cfields: fwiw, https://godbolt.org/z/B5VHgu
 39 2020-06-26T02:56:09  <sipa> gcc trunk works; no clang version on godbolt seems to support span at all
 40 2020-06-26T02:57:09  <cfields> sipa: any chance there's a "g++ -stdlib=libc++" option ?
 41 2020-06-26T02:58:59  *** Deacyde has joined #bitcoin-core-dev
 42 2020-06-26T02:59:02  <sipa> g++: error: unrecognized command-line option '-stdlib=libc++'
 43 2020-06-26T02:59:43  *** ppisati has joined #bitcoin-core-dev
 44 2020-06-26T03:00:02  *** brrr has quit IRC
 45 2020-06-26T03:00:02  <cfields> ok, thanks.
 46 2020-06-26T03:00:20  <cfields> well I'm about 10 kinds of confused. Going to call it a night.
 47 2020-06-26T03:00:25  <sipa> are you sure that's the right syntax?
 48 2020-06-26T03:00:31  *** afk11` has quit IRC
 49 2020-06-26T03:00:35  *** bitdex has quit IRC
 50 2020-06-26T03:00:49  <sipa> i see no -stdlib=... documented in gcc's manpage
 51 2020-06-26T03:00:58  *** bitdex has joined #bitcoin-core-dev
 52 2020-06-26T03:01:21  <cfields> sipa: https://github.com/bitcoin/bitcoin/blob/master/depends/hosts/darwin.mk#L9
 53 2020-06-26T03:01:26  *** afk11` has joined #bitcoin-core-dev
 54 2020-06-26T03:01:32  <cfields> Oh, maybe gcc hasn't learned that? I could've sworn you could select it there too.
 55 2020-06-26T03:02:15  <cfields> sipa: huh, guess you're right.
 56 2020-06-26T03:02:28  *** tryphe_ is now known as tryphe
 57 2020-06-26T03:05:32  *** EagleTM has joined #bitcoin-core-dev
 58 2020-06-26T03:06:02  <fanquake> cfields: https://gcc.gnu.org/pipermail/gcc/2020-March/000230.html
 59 2020-06-26T03:06:08  <fanquake> Maybe coming in GCC 11
 60 2020-06-26T03:06:12  <sipa> https://libcxx.llvm.org/docs/UsingLibcxx.html#using-libc-with-gcc
 61 2020-06-26T03:07:34  *** Eagle[TM] has quit IRC
 62 2020-06-26T03:08:27  <cfields> sipa: that example compiles for me locally with clang and libc++. Another helpful data point, thanks.
 63 2020-06-26T03:09:43  <cfields> fanquake: ah, nice :)
 64 2020-06-26T03:10:10  *** Deacyde has quit IRC
 65 2020-06-26T03:24:14  *** troygiorshev has quit IRC
 66 2020-06-26T03:30:23  *** troygiorshev has joined #bitcoin-core-dev
 67 2020-06-26T03:40:59  *** vasild_ has joined #bitcoin-core-dev
 68 2020-06-26T03:43:43  *** vasild has quit IRC
 69 2020-06-26T03:43:44  *** vasild_ is now known as vasild
 70 2020-06-26T03:45:07  <sipa> cfields: constructor 7 is https://github.com/llvm/llvm-project/blob/master/libcxx/include/span#L62L65 and https://github.com/llvm/llvm-project/blob/master/libcxx/include/span#L226L240
 71 2020-06-26T03:45:50  <sipa> they don't have an explicit universal reference constructor, instead relying on temporaries binding with const lvalue reference
 72 2020-06-26T03:46:05  <sipa> that's a more elegant way of doing it actually
 73 2020-06-26T03:46:11  *** S3RK has joined #bitcoin-core-dev
 74 2020-06-26T03:54:39  <sipa> https://github.com/llvm/llvm-project/blob/master/libcxx/include/span#L400L410 actually
 75 2020-06-26T03:55:00  *** daim2k5 has joined #bitcoin-core-dev
 76 2020-06-26T04:08:12  *** proofofkeags has quit IRC
 77 2020-06-26T04:08:44  *** proofofkeags has joined #bitcoin-core-dev
 78 2020-06-26T04:12:55  *** proofofkeags has quit IRC
 79 2020-06-26T04:12:56  *** troygiorshev has quit IRC
 80 2020-06-26T04:13:50  *** troygiorshev has joined #bitcoin-core-dev
 81 2020-06-26T04:35:16  *** ghost43 has quit IRC
 82 2020-06-26T04:36:03  *** ghost43 has joined #bitcoin-core-dev
 83 2020-06-26T04:59:02  *** rh0nj has quit IRC
 84 2020-06-26T05:00:08  *** rh0nj has joined #bitcoin-core-dev
 85 2020-06-26T05:01:28  *** S3RK has quit IRC
 86 2020-06-26T05:01:59  *** S3RK has joined #bitcoin-core-dev
 87 2020-06-26T05:06:41  *** S3RK has quit IRC
 88 2020-06-26T05:12:13  *** troygiorshev has quit IRC
 89 2020-06-26T05:12:34  *** troygiorshev has joined #bitcoin-core-dev
 90 2020-06-26T05:36:25  *** promag has joined #bitcoin-core-dev
 91 2020-06-26T05:41:08  *** promag has quit IRC
 92 2020-06-26T06:00:02  *** daim2k5 has quit IRC
 93 2020-06-26T06:06:17  *** S3RK has joined #bitcoin-core-dev
 94 2020-06-26T06:10:31  *** S3RK has quit IRC
 95 2020-06-26T06:10:58  *** marcoagner has joined #bitcoin-core-dev
 96 2020-06-26T06:12:04  *** S3RK has joined #bitcoin-core-dev
 97 2020-06-26T06:16:51  *** S3RK has quit IRC
 98 2020-06-26T06:22:05  *** iMast777 has joined #bitcoin-core-dev
 99 2020-06-26T06:51:07  *** nullptr| has joined #bitcoin-core-dev
100 2020-06-26T06:57:11  *** jonatack has joined #bitcoin-core-dev
101 2020-06-26T07:09:50  *** S3RK has joined #bitcoin-core-dev
102 2020-06-26T07:13:54  *** S3RK has quit IRC
103 2020-06-26T07:31:37  *** S3RK has joined #bitcoin-core-dev
104 2020-06-26T08:01:10  *** RCasatta has joined #bitcoin-core-dev
105 2020-06-26T08:08:29  *** S3RK has quit IRC
106 2020-06-26T08:09:52  *** dr-orlovsky has joined #bitcoin-core-dev
107 2020-06-26T08:15:33  *** AaronvanW has joined #bitcoin-core-dev
108 2020-06-26T08:27:03  *** promag has joined #bitcoin-core-dev
109 2020-06-26T08:35:42  *** Pavlenex has joined #bitcoin-core-dev
110 2020-06-26T08:43:50  *** Mercury_Vapor has quit IRC
111 2020-06-26T08:44:16  *** Mercury_Vapor has joined #bitcoin-core-dev
112 2020-06-26T08:47:37  *** S3RK has joined #bitcoin-core-dev
113 2020-06-26T08:52:03  *** S3RK has quit IRC
114 2020-06-26T09:00:02  *** iMast777 has quit IRC
115 2020-06-26T09:12:07  *** dr-orlovsky has quit IRC
116 2020-06-26T09:21:14  *** Squidicc has quit IRC
117 2020-06-26T09:22:06  *** omega8cc has joined #bitcoin-core-dev
118 2020-06-26T09:35:53  *** S3RK has joined #bitcoin-core-dev
119 2020-06-26T09:36:13  *** RCasatta has quit IRC
120 2020-06-26T10:03:20  *** Arturo11Mayer has joined #bitcoin-core-dev
121 2020-06-26T10:06:25  *** omega8cc has quit IRC
122 2020-06-26T10:20:41  *** bitcoin-git has joined #bitcoin-core-dev
123 2020-06-26T10:20:41  <bitcoin-git> [bitcoin] S3RK opened pull request #19384: test: speed up functional tests (master...test_speed_up) https://github.com/bitcoin/bitcoin/pull/19384
124 2020-06-26T10:20:48  *** bitcoin-git has left #bitcoin-core-dev
125 2020-06-26T10:23:32  *** dr-orlovsky has joined #bitcoin-core-dev
126 2020-06-26T10:25:22  *** Arturo11Mayer has quit IRC
127 2020-06-26T10:28:21  *** Alphi has joined #bitcoin-core-dev
128 2020-06-26T10:51:47  *** reallll has joined #bitcoin-core-dev
129 2020-06-26T10:55:09  *** belcher has quit IRC
130 2020-06-26T10:58:40  *** reallll is now known as belcher
131 2020-06-26T11:29:27  *** S3RK has quit IRC
132 2020-06-26T11:30:03  *** S3RK has joined #bitcoin-core-dev
133 2020-06-26T11:34:04  *** S3RK_ has joined #bitcoin-core-dev
134 2020-06-26T11:34:05  *** S3RK has quit IRC
135 2020-06-26T11:38:27  *** S3RK_ has quit IRC
136 2020-06-26T11:39:04  *** dr-orlovsky has quit IRC
137 2020-06-26T11:49:13  *** dr-orlovsky has joined #bitcoin-core-dev
138 2020-06-26T11:53:02  *** sdaftuar has quit IRC
139 2020-06-26T11:53:28  *** sdaftuar has joined #bitcoin-core-dev
140 2020-06-26T11:54:32  *** mol_ has joined #bitcoin-core-dev
141 2020-06-26T11:57:49  *** mol has quit IRC
142 2020-06-26T12:00:02  *** Alphi has quit IRC
143 2020-06-26T12:22:00  *** ogelbukh has joined #bitcoin-core-dev
144 2020-06-26T12:32:53  *** Highway61 has joined #bitcoin-core-dev
145 2020-06-26T12:42:17  *** Guyver2 has joined #bitcoin-core-dev
146 2020-06-26T12:52:50  *** SteveyG has joined #bitcoin-core-dev
147 2020-06-26T12:57:03  *** SteveyG has quit IRC
148 2020-06-26T13:15:30  *** Eagle[TM] has joined #bitcoin-core-dev
149 2020-06-26T13:15:44  *** molz_ has joined #bitcoin-core-dev
150 2020-06-26T13:16:34  *** EagleTM has quit IRC
151 2020-06-26T13:18:35  *** mol_ has quit IRC
152 2020-06-26T13:21:39  *** dr-orlovsky has quit IRC
153 2020-06-26T13:25:25  *** Pavlenex has quit IRC
154 2020-06-26T13:26:53  *** Pavlenex has joined #bitcoin-core-dev
155 2020-06-26T13:42:33  *** mol has joined #bitcoin-core-dev
156 2020-06-26T13:44:34  *** molz_ has quit IRC
157 2020-06-26T14:05:52  *** bitcoin-git has joined #bitcoin-core-dev
158 2020-06-26T14:05:53  <bitcoin-git> [bitcoin] yancyribbens opened pull request #19385: test: Change default test logging directory (master...unit-log-location) https://github.com/bitcoin/bitcoin/pull/19385
159 2020-06-26T14:05:53  *** bitcoin-git has left #bitcoin-core-dev
160 2020-06-26T14:20:01  *** sipsorcery has quit IRC
161 2020-06-26T14:30:14  *** promag has quit IRC
162 2020-06-26T14:34:19  *** Guyver2 has quit IRC
163 2020-06-26T14:40:02  *** sipsorcery has joined #bitcoin-core-dev
164 2020-06-26T14:42:58  *** kljasdfvv has quit IRC
165 2020-06-26T14:47:34  *** Highway61 has quit IRC
166 2020-06-26T14:47:53  *** Highway61 has joined #bitcoin-core-dev
167 2020-06-26T14:52:25  *** troygiorshev has quit IRC
168 2020-06-26T14:52:52  *** troygiorshev has joined #bitcoin-core-dev
169 2020-06-26T14:54:04  *** mol_ has joined #bitcoin-core-dev
170 2020-06-26T14:56:50  *** mol has quit IRC
171 2020-06-26T14:58:51  *** gribble has quit IRC
172 2020-06-26T15:00:02  *** ogelbukh has quit IRC
173 2020-06-26T15:03:18  *** jb55 has joined #bitcoin-core-dev
174 2020-06-26T15:10:37  *** bitdex has quit IRC
175 2020-06-26T15:13:51  *** gribble has joined #bitcoin-core-dev
176 2020-06-26T15:16:10  <cfields> sipa: right, sorry, I didn't mean to imply that the construction was no longer possible. Only that it's no longer a universal reference.
177 2020-06-26T15:17:15  *** Pavlenex has quit IRC
178 2020-06-26T15:21:13  *** leafstorm has joined #bitcoin-core-dev
179 2020-06-26T15:40:37  *** Talkless has joined #bitcoin-core-dev
180 2020-06-26T15:40:46  *** promag has joined #bitcoin-core-dev
181 2020-06-26T15:44:03  *** vasild has quit IRC
182 2020-06-26T15:47:03  *** alko89 has joined #bitcoin-core-dev
183 2020-06-26T15:50:03  *** molz_ has joined #bitcoin-core-dev
184 2020-06-26T15:52:56  *** mol_ has quit IRC
185 2020-06-26T16:01:37  *** proofofkeags has joined #bitcoin-core-dev
186 2020-06-26T16:04:21  *** molz_ has quit IRC
187 2020-06-26T16:04:45  *** molz_ has joined #bitcoin-core-dev
188 2020-06-26T16:06:09  *** vasild has joined #bitcoin-core-dev
189 2020-06-26T16:12:52  *** troygiorshev has quit IRC
190 2020-06-26T16:13:58  *** troygiorshev has joined #bitcoin-core-dev
191 2020-06-26T16:27:01  *** Pavlenex has joined #bitcoin-core-dev
192 2020-06-26T16:35:57  *** Guyver2 has joined #bitcoin-core-dev
193 2020-06-26T16:41:58  *** mol has joined #bitcoin-core-dev
194 2020-06-26T16:43:36  *** troygiorshev has quit IRC
195 2020-06-26T16:43:55  *** troygiorshev has joined #bitcoin-core-dev
196 2020-06-26T16:44:19  *** Talkless has quit IRC
197 2020-06-26T16:44:43  *** Pavlenex has quit IRC
198 2020-06-26T16:44:47  *** molz_ has quit IRC
199 2020-06-26T16:45:39  *** proofofkeags has quit IRC
200 2020-06-26T16:46:06  *** proofofkeags has joined #bitcoin-core-dev
201 2020-06-26T16:49:04  *** mol_ has joined #bitcoin-core-dev
202 2020-06-26T16:51:00  *** proofofkeags has quit IRC
203 2020-06-26T16:52:05  *** mol has quit IRC
204 2020-06-26T16:53:33  *** justan0theruser has quit IRC
205 2020-06-26T16:57:19  *** proofofkeags has joined #bitcoin-core-dev
206 2020-06-26T17:05:07  *** kristapsk has quit IRC
207 2020-06-26T17:10:05  *** mol has joined #bitcoin-core-dev
208 2020-06-26T17:12:47  *** mol_ has quit IRC
209 2020-06-26T17:19:22  *** justan0theruser has joined #bitcoin-core-dev
210 2020-06-26T17:20:07  *** mol_ has joined #bitcoin-core-dev
211 2020-06-26T17:22:34  *** mol has quit IRC
212 2020-06-26T17:22:44  *** proofofkeags has quit IRC
213 2020-06-26T17:23:11  *** proofofkeags has joined #bitcoin-core-dev
214 2020-06-26T17:25:06  <cfields> sipa: I'm regretting starting down this path now, I don't think it's really worth the effort. I'm mainly seeing it through now as a learning experience...
215 2020-06-26T17:25:11  <cfields> that said.. what do you think of this: https://github.com/theuni/bitcoin/commit/bb75cdf5634da606fb592b462b3ca24fc818cfdb ?
216 2020-06-26T17:26:07  <cfields> That ensures that trivial copies are sent through the trivial constructor, and splits out the const reference case so that we can apply lifetimebound specifically to it.
217 2020-06-26T17:27:21  *** Pavlenex has joined #bitcoin-core-dev
218 2020-06-26T17:27:35  <sipa> any reason why you wouldn't want the lifetimebound on both?
219 2020-06-26T17:27:43  *** proofofkeags has quit IRC
220 2020-06-26T17:27:51  <sipa> ah, because temporaries just wouldn't bind against the mutable lvalue reference one?
221 2020-06-26T17:28:05  <cfields> Right, no reason other than I don't see the need.
222 2020-06-26T17:28:13  <sipa> but as i understand it, there is no harm in applying it to both
223 2020-06-26T17:28:41  <cfields> sure, not opposed.
224 2020-06-26T17:29:22  <sipa> in the second one, i think you need const V in the type checks?
225 2020-06-26T17:30:05  <cfields> yup, nice catch.
226 2020-06-26T17:30:34  <sipa> also, does that compile? it looks like the template argument to std::enable_if<... is not closed
227 2020-06-26T17:30:47  <sipa> oh, it is
228 2020-06-26T17:30:48  <sipa> nvm
229 2020-06-26T17:31:09  <cfields> hehe. it's an arg enable_if now, not a template one.
230 2020-06-26T17:31:47  <sipa> ah, is that preferable?
231 2020-06-26T17:33:19  <sipa> i think it makes sense to more closely match the exact conditions used in an actual std lib
232 2020-06-26T17:34:37  <cfields> that's why i switched it, I'm not sure if it's preferred though. Might be part of some overload matching rule that I'll never understand.
233 2020-06-26T17:35:04  <sipa> i've had to fight with old compiler versions in travis a few times to make it work
234 2020-06-26T17:35:23  <sipa> but i think this approach of splitting up const and nonconst is pretty elegant, and perhaps more likely to work
235 2020-06-26T17:35:39  <sipa> *more likely to work on the first try
236 2020-06-26T17:35:49  <cfields> oh, fun. guess I'll start that process.
237 2020-06-26T17:37:00  <cfields> sipa: I'm guessing you didn't add the std::array overload because Extent isn't implemented?
238 2020-06-26T17:38:11  *** mol has joined #bitcoin-core-dev
239 2020-06-26T17:38:13  <cfields> std::array constructor, sorry.
240 2020-06-26T17:38:32  <sipa> yeah, it should be captured by the container constructor
241 2020-06-26T17:38:45  *** proofofkeags has joined #bitcoin-core-dev
242 2020-06-26T17:39:24  <cfields> ack
243 2020-06-26T17:39:24  *** proofofkeags has quit IRC
244 2020-06-26T17:39:50  *** proofofkeags has joined #bitcoin-core-dev
245 2020-06-26T17:39:58  <sipa> actually, the criterion to avoid arrays in your type expressions is superfluous too, i think
246 2020-06-26T17:40:05  *** proofofkeags has quit IRC
247 2020-06-26T17:40:08  <sipa> as arrays don't have .data() and .size() member functions
248 2020-06-26T17:40:12  *** proofofk_ has joined #bitcoin-core-dev
249 2020-06-26T17:40:21  *** proofofk_ has quit IRC
250 2020-06-26T17:40:43  *** mol_ has quit IRC
251 2020-06-26T17:40:59  <sipa> C++17 adds std::data and std::size, which generalize the data and size member functions to arrays
252 2020-06-26T17:41:05  *** proofofkeags has joined #bitcoin-core-dev
253 2020-06-26T17:41:07  <cfields> Aha, right... they use the newer generic data(foo) rather than foo.data(), which must have an overload
254 2020-06-26T17:41:07  *** Pavlenex has quit IRC
255 2020-06-26T17:41:50  <cfields> will remove
256 2020-06-26T17:43:11  <hebasto> do we have a functional test for orphan tx eviction when a new block is connected? couldn't find it...
257 2020-06-26T17:43:39  <sipa> hebasto: break it, and see if tests fail :)
258 2020-06-26T17:43:53  <hebasto> yes!
259 2020-06-26T17:44:01  <hebasto> thanks  :)
260 2020-06-26T17:44:54  <cfields> hehe
261 2020-06-26T17:45:55  *** proofofkeags has quit IRC
262 2020-06-26T17:47:13  *** alko89 has quit IRC
263 2020-06-26T17:49:10  *** alko89 has joined #bitcoin-core-dev
264 2020-06-26T17:49:15  *** Pavlenex has joined #bitcoin-core-dev
265 2020-06-26T17:51:13  *** bitcoin-git has joined #bitcoin-core-dev
266 2020-06-26T17:51:13  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19386: rpc: Assert that RPCArg names are equal to CRPCCommand ones (server) (master...2006-rpcManServer) https://github.com/bitcoin/bitcoin/pull/19386
267 2020-06-26T17:51:14  *** bitcoin-git has left #bitcoin-core-dev
268 2020-06-26T17:52:42  *** Pavlenex has quit IRC
269 2020-06-26T17:57:06  <hebasto> I've broke a half of `PeerLogicValidation::BlockConnected()` but functional test passed... It seems we need more tests :)
270 2020-06-26T18:00:02  *** leafstorm has quit IRC
271 2020-06-26T18:04:23  *** bitcoin-git has joined #bitcoin-core-dev
272 2020-06-26T18:04:23  <bitcoin-git> [bitcoin] theuni closed pull request #19382: span: Add lifetimebound attribute to guard against temporary lifetime issues (master...lifetimebound) https://github.com/bitcoin/bitcoin/pull/19382
273 2020-06-26T18:04:34  *** bitcoin-git has left #bitcoin-core-dev
274 2020-06-26T18:12:02  *** mol_ has joined #bitcoin-core-dev
275 2020-06-26T18:15:22  *** mol has quit IRC
276 2020-06-26T18:20:58  *** greynix has joined #bitcoin-core-dev
277 2020-06-26T18:24:20  *** bitcoin-git has joined #bitcoin-core-dev
278 2020-06-26T18:24:20  <bitcoin-git> [bitcoin] theuni opened pull request #19387: span: update constructors to match c++20 draft spec and add lifetimebound attribute (master...lifetimebound2) https://github.com/bitcoin/bitcoin/pull/19387
279 2020-06-26T18:24:21  *** bitcoin-git has left #bitcoin-core-dev
280 2020-06-26T18:30:37  *** vincenzopalazzo has joined #bitcoin-core-dev
281 2020-06-26T18:45:29  *** bitcoin-git has joined #bitcoin-core-dev
282 2020-06-26T18:45:29  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f32f7e907a5e...3bbd8225b92d
283 2020-06-26T18:45:29  <bitcoin-git> bitcoin/master 1087807 practicalswift: tests: Provide main(...) function in fuzzer
284 2020-06-26T18:45:30  <bitcoin-git> bitcoin/master 3bbd822 MarcoFalke: Merge #19366: tests: Provide main(...) function in fuzzer. Allow building ...
285 2020-06-26T18:45:31  *** bitcoin-git has left #bitcoin-core-dev
286 2020-06-26T18:45:49  *** bitcoin-git has joined #bitcoin-core-dev
287 2020-06-26T18:45:49  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19366: tests: Provide main(...) function in fuzzer. Allow building uninstrumented harnesses with --enable-fuzz. (master...provide-main-function-in-fuzzer) https://github.com/bitcoin/bitcoin/pull/19366
288 2020-06-26T18:45:50  *** bitcoin-git has left #bitcoin-core-dev
289 2020-06-26T18:46:54  *** bitcoin-git has joined #bitcoin-core-dev
290 2020-06-26T18:46:55  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3bbd8225b92d...49464004701e
291 2020-06-26T18:46:55  <bitcoin-git> bitcoin/master d906aaa Hennadii Stepanov: qt: Fix regression in TransactionTableModel
292 2020-06-26T18:46:56  <bitcoin-git> bitcoin/master 4946400 MarcoFalke: Merge bitcoin-core/gui#8: Fix regression in TransactionTableModel
293 2020-06-26T18:46:58  *** bitcoin-git has left #bitcoin-core-dev
294 2020-06-26T18:54:31  *** kristapsk has joined #bitcoin-core-dev
295 2020-06-26T18:59:33  <jamesob> do we have release signing pubkeys referenced anywhere in the repo?
296 2020-06-26T19:03:39  *** kristapsk has quit IRC
297 2020-06-26T19:05:54  *** kristapsk has joined #bitcoin-core-dev
298 2020-06-26T19:20:23  <jamesob> (we do: https://github.com/bitcoin/bitcoin/tree/master/contrib/verifybinaries, though the key I retrieved differs from the one on bitcoin.org: https://bitcoin.org/laanwj-releases.asc)
299 2020-06-26T19:30:31  *** splunkworth has joined #bitcoin-core-dev
300 2020-06-26T19:32:05  *** splunkworth has quit IRC
301 2020-06-26T19:35:21  *** Pavlenex has joined #bitcoin-core-dev
302 2020-06-26T19:35:58  <luke-jr> should encourage people to use the gitian sigs more anyway imo
303 2020-06-26T19:36:28  <jamesob> did we ever figure out distribution for asmap? is the recommended method just to use sipa's python repo and build it yourself?
304 2020-06-26T19:36:40  *** Pavlenex has quit IRC
305 2020-06-26T19:36:41  <sipa> jamesob: you're behind :p
306 2020-06-26T19:36:57  <jamesob> too true
307 2020-06-26T19:37:08  <sipa> the answer is no, but the encoder in https://github.com/bitcoin/bitcoin/pull/18573 is far better than my python scripts
308 2020-06-26T19:38:05  <sipa> however, actually gathering the routing information... i don't really have a solution, except having some people build it independently and compare
309 2020-06-26T19:40:20  <jamesob> would be nice to have a script in contrib that makes it easy to build one (with parameterized routing sources or something)
310 2020-06-26T19:40:32  <sipa> and unless you have access to routing tables yourself like BlueMatt... you'll be relying on someone giving you a dump
311 2020-06-26T19:40:41  <sipa> which necessarily puts trust in that entity
312 2020-06-26T19:40:59  <sipa> there is https://github.com/rrybarczyk/asmap-rs
313 2020-06-26T19:41:11  <sipa> (which only gathers/aggregates dumps, it doesn't encode)
314 2020-06-26T19:43:49  <BlueMatt> right, given there's at least 3 public routing table dumps I'm aware of that can be found online, and likely many more possible, plus a few folks who have access to the routing table, I dont think its unreasonable to ship something presuming we have some ability to diff asmaps
315 2020-06-26T19:44:42  <BlueMatt> ripe ris, oregon route views, caidia bgpstream are all good resources, plus anyone who is on a super small isp can probably just ask for a relevant routing table dump if you ping the noc.
316 2020-06-26T19:45:14  <BlueMatt> you can probably find some other random route servers that have the ability to generate a dump left on
317 2020-06-26T19:45:16  <sipa> BlueMatt: thanks for the reminder that i should add a asmap diff tool
318 2020-06-26T19:45:18  <sipa> somewhefe
319 2020-06-26T19:45:47  <BlueMatt> right, cerainly not practical to ship anything without a diff tool.
320 2020-06-26T19:45:50  * luke-jr wonders if there's any way for random joes to monitor BGP or whatever directly
321 2020-06-26T19:46:08  *** proofofkeags has joined #bitcoin-core-dev
322 2020-06-26T19:46:41  <BlueMatt> directly? ask your isp for a session. indirectly? see the list i just wrote above :)
323 2020-06-26T20:32:05  *** Talkless has joined #bitcoin-core-dev
324 2020-06-26T20:34:55  *** justan0theruser has quit IRC
325 2020-06-26T20:35:13  *** justanotheruser has joined #bitcoin-core-dev
326 2020-06-26T20:35:56  *** proofofkeags has quit IRC
327 2020-06-26T20:36:23  *** proofofkeags has joined #bitcoin-core-dev
328 2020-06-26T20:40:38  *** proofofkeags has quit IRC
329 2020-06-26T20:44:39  *** gribble has quit IRC
330 2020-06-26T20:53:17  *** proofofkeags has joined #bitcoin-core-dev
331 2020-06-26T20:57:26  *** gribble has joined #bitcoin-core-dev
332 2020-06-26T21:00:01  *** greynix has quit IRC
333 2020-06-26T21:13:29  *** proofofkeags has quit IRC
334 2020-06-26T21:13:55  *** proofofkeags has joined #bitcoin-core-dev
335 2020-06-26T21:18:26  *** proofofkeags has quit IRC
336 2020-06-26T21:20:08  *** bitcoin-git has joined #bitcoin-core-dev
337 2020-06-26T21:20:09  <bitcoin-git> [bitcoin] luke-jr opened pull request #19390: doc/REST-interface: Remove stale info (master...restdoc_rm_stale) https://github.com/bitcoin/bitcoin/pull/19390
338 2020-06-26T21:20:10  *** bitcoin-git has left #bitcoin-core-dev
339 2020-06-26T21:21:08  *** filchef has joined #bitcoin-core-dev
340 2020-06-26T21:22:09  *** Xorlev has joined #bitcoin-core-dev
341 2020-06-26T21:22:21  *** filchef has quit IRC
342 2020-06-26T21:24:19  *** bitcoin-git has joined #bitcoin-core-dev
343 2020-06-26T21:24:19  <bitcoin-git> [bitcoin] luke-jr opened pull request #19391: RPC/Mining: Clean out pre-Segwit miner compatibility code (master...gbt_rm_versionforce) https://github.com/bitcoin/bitcoin/pull/19391
344 2020-06-26T21:24:20  *** bitcoin-git has left #bitcoin-core-dev
345 2020-06-26T21:29:26  * luke-jr peers at BSD CI failing on doc change O.o
346 2020-06-26T21:39:13  *** troygiorshev has quit IRC
347 2020-06-26T21:39:59  *** Guyver2 has quit IRC
348 2020-06-26T21:41:33  <sipa> cfields: Span<const int> bad{MakeSpan(std::vector<int>{})} works fine :(
349 2020-06-26T21:41:41  <sipa> without lifetimebound warning
350 2020-06-26T21:44:47  *** kristapsk has quit IRC
351 2020-06-26T21:46:12  *** kristapsk has joined #bitcoin-core-dev
352 2020-06-26T21:48:23  *** jarthur has quit IRC
353 2020-06-26T21:54:39  *** marcoagner has quit IRC
354 2020-06-26T22:02:11  *** davterra has quit IRC
355 2020-06-26T22:03:59  *** sipsorcery has quit IRC
356 2020-06-26T22:10:41  *** proofofkeags has joined #bitcoin-core-dev
357 2020-06-26T22:13:16  <midnight> seeing an odd fdatasync() problem starting up a regtest instance to complete unit tests on a NetBSD vm, in the leveldb code.. :-/
358 2020-06-26T22:13:35  *** Talkless has quit IRC
359 2020-06-26T22:17:07  *** kristapsk has quit IRC
360 2020-06-26T22:17:28  *** justanotheruser has quit IRC
361 2020-06-26T22:35:03  *** justanotheruser has joined #bitcoin-core-dev
362 2020-06-26T22:35:23  *** proofofkeags has quit IRC
363 2020-06-26T22:35:49  *** proofofkeags has joined #bitcoin-core-dev
364 2020-06-26T22:40:20  *** proofofkeags has quit IRC
365 2020-06-26T22:42:57  *** sipsorcery has joined #bitcoin-core-dev
366 2020-06-26T22:43:20  *** proofofkeags has joined #bitcoin-core-dev
367 2020-06-26T22:43:50  *** proofofkeags has quit IRC
368 2020-06-26T22:44:17  *** proofofkeags has joined #bitcoin-core-dev
369 2020-06-26T22:48:44  *** proofofkeags has quit IRC
370 2020-06-26T23:01:43  *** davterra has joined #bitcoin-core-dev
371 2020-06-26T23:20:20  *** proofofkeags has joined #bitcoin-core-dev
372 2020-06-26T23:24:40  *** mol_ has quit IRC
373 2020-06-26T23:24:46  *** proofofkeags has quit IRC
374 2020-06-26T23:25:54  *** proofofkeags has joined #bitcoin-core-dev
375 2020-06-26T23:29:38  *** mol has joined #bitcoin-core-dev
376 2020-06-26T23:30:47  *** proofofkeags has quit IRC
377 2020-06-26T23:31:15  *** baldur has quit IRC
378 2020-06-26T23:34:27  *** baldur has joined #bitcoin-core-dev
379 2020-06-26T23:41:32  *** proofofkeags has joined #bitcoin-core-dev
380 2020-06-26T23:45:47  *** proofofkeags has quit IRC
381 2020-06-26T23:46:40  *** AaronvanW has quit IRC