12020-07-03T00:00:02 *** RhodiumToad1 has quit IRC
22020-07-03T00:00:36 *** vincenzopalazzo has joined #bitcoin-core-dev
32020-07-03T00:09:25 *** AaronvanW has quit IRC
42020-07-03T00:12:38 *** nik-j has quit IRC
52020-07-03T00:13:11 *** nik-j has joined #bitcoin-core-dev
62020-07-03T00:13:30 *** justanotheruser has quit IRC
72020-07-03T00:27:26 *** justanotheruser has joined #bitcoin-core-dev
82020-07-03T00:31:45 *** nik-j_ has joined #bitcoin-core-dev
92020-07-03T00:34:46 *** nik-j has quit IRC
102020-07-03T00:56:25 *** nik-j_ has quit IRC
112020-07-03T00:57:43 *** eam1 has joined #bitcoin-core-dev
122020-07-03T00:58:25 *** Evel-Knievel has quit IRC
132020-07-03T00:58:44 *** Evel-Knievel has joined #bitcoin-core-dev
142020-07-03T01:00:20 *** nik-j has joined #bitcoin-core-dev
152020-07-03T01:02:49 *** nik-j_ has joined #bitcoin-core-dev
162020-07-03T01:02:50 *** nik-j has quit IRC
172020-07-03T01:04:38 *** filchef has quit IRC
182020-07-03T01:20:57 *** bitcoin-git has joined #bitcoin-core-dev
192020-07-03T01:20:57 <bitcoin-git> [bitcoin] promag opened pull request #19434: http: Detect remote disconnect (master...2020-06-remote-disconnect) https://github.com/bitcoin/bitcoin/pull/19434
202020-07-03T01:20:58 *** bitcoin-git has left #bitcoin-core-dev
212020-07-03T01:47:47 *** promag has quit IRC
222020-07-03T01:51:30 *** Highway61 has quit IRC
232020-07-03T01:54:00 *** nik-j_ has quit IRC
242020-07-03T01:55:34 *** nik-j has joined #bitcoin-core-dev
252020-07-03T01:57:04 *** sharpiro_ has quit IRC
262020-07-03T02:03:30 *** proofofkeags has quit IRC
272020-07-03T02:04:04 *** proofofkeags has joined #bitcoin-core-dev
282020-07-03T02:08:12 *** proofofkeags has quit IRC
292020-07-03T02:25:28 *** promag has joined #bitcoin-core-dev
302020-07-03T02:31:47 *** Relis has quit IRC
312020-07-03T02:32:37 *** proofofkeags has joined #bitcoin-core-dev
322020-07-03T02:33:54 *** promag has quit IRC
332020-07-03T02:38:05 *** nullptr| has quit IRC
342020-07-03T02:42:52 *** bitcoin-git has joined #bitcoin-core-dev
352020-07-03T02:42:52 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a24806c25d7a...daae8b8a1b03
362020-07-03T02:42:52 <bitcoin-git> bitcoin/master 54b5eb2 practicalswift: tests: Add std::locale::global to list of locale dependent functions in li...
372020-07-03T02:42:53 <bitcoin-git> bitcoin/master daae8b8 fanquake: Merge #18649: tests: Add std::locale::global to list of locale dependent f...
382020-07-03T02:42:54 *** bitcoin-git has left #bitcoin-core-dev
392020-07-03T02:43:52 *** bitcoin-git has joined #bitcoin-core-dev
402020-07-03T02:43:52 <bitcoin-git> [bitcoin] fanquake merged pull request #18649: tests: Add std::locale::global to list of locale dependent functions (master...locale-dependent-functions) https://github.com/bitcoin/bitcoin/pull/18649
412020-07-03T02:43:53 *** bitcoin-git has left #bitcoin-core-dev
422020-07-03T02:46:18 *** nullptr| has joined #bitcoin-core-dev
432020-07-03T02:50:50 *** proofofkeags has quit IRC
442020-07-03T02:51:25 *** proofofkeags has joined #bitcoin-core-dev
452020-07-03T02:55:50 *** proofofkeags has quit IRC
462020-07-03T03:00:01 *** eam1 has quit IRC
472020-07-03T03:05:20 *** nik-j has quit IRC
482020-07-03T03:05:56 *** nik-j has joined #bitcoin-core-dev
492020-07-03T03:10:14 *** nik-j has quit IRC
502020-07-03T03:14:45 *** bitdex has joined #bitcoin-core-dev
512020-07-03T03:20:17 *** hggdh1 has joined #bitcoin-core-dev
522020-07-03T03:29:36 *** proofofkeags has joined #bitcoin-core-dev
532020-07-03T03:36:06 *** proofofkeags has quit IRC
542020-07-03T03:56:58 *** face has joined #bitcoin-core-dev
552020-07-03T04:01:55 *** infamously[m] has joined #bitcoin-core-dev
562020-07-03T04:12:12 *** proofofkeags has joined #bitcoin-core-dev
572020-07-03T04:15:37 *** luke-jr has quit IRC
582020-07-03T04:15:58 *** luke-jr has joined #bitcoin-core-dev
592020-07-03T04:18:49 *** proofofkeags has quit IRC
602020-07-03T04:27:15 *** justanotheruser has quit IRC
612020-07-03T04:30:13 *** face has quit IRC
622020-07-03T04:34:36 *** justanotheruser has joined #bitcoin-core-dev
632020-07-03T04:51:50 *** face has joined #bitcoin-core-dev
642020-07-03T05:11:56 *** bitcoin-git has joined #bitcoin-core-dev
652020-07-03T05:11:56 <bitcoin-git> [bitcoin] hebasto closed pull request #19374: refactor: Drop g_orphan_list global (master...200624-orphan) https://github.com/bitcoin/bitcoin/pull/19374
662020-07-03T05:11:57 *** bitcoin-git has left #bitcoin-core-dev
672020-07-03T05:39:49 *** face has quit IRC
682020-07-03T05:42:31 *** nik-j has joined #bitcoin-core-dev
692020-07-03T05:43:17 *** nik-j_ has joined #bitcoin-core-dev
702020-07-03T05:47:01 *** nik-j has quit IRC
712020-07-03T05:47:37 *** nik-j_ has quit IRC
722020-07-03T05:56:19 *** vincenzopalazzo has quit IRC
732020-07-03T05:59:29 *** jarthur has quit IRC
742020-07-03T06:00:01 *** hggdh1 has quit IRC
752020-07-03T06:10:52 *** mdunnio has joined #bitcoin-core-dev
762020-07-03T06:15:34 *** mdunnio has quit IRC
772020-07-03T06:16:14 *** proofofkeags has joined #bitcoin-core-dev
782020-07-03T06:16:51 *** marcoagner has joined #bitcoin-core-dev
792020-07-03T06:20:51 *** proofofkeags has quit IRC
802020-07-03T06:21:54 *** BlaDe^ has joined #bitcoin-core-dev
812020-07-03T06:24:25 *** alko has joined #bitcoin-core-dev
822020-07-03T06:28:09 *** face has joined #bitcoin-core-dev
832020-07-03T06:37:02 *** Pavlenex has joined #bitcoin-core-dev
842020-07-03T06:50:11 *** mdunnio has joined #bitcoin-core-dev
852020-07-03T06:54:46 *** mdunnio has quit IRC
862020-07-03T07:09:47 *** jonatack has quit IRC
872020-07-03T07:43:03 *** vasild has quit IRC
882020-07-03T07:43:11 *** vasild_ has joined #bitcoin-core-dev
892020-07-03T07:43:17 *** vasild_ is now known as vasild
902020-07-03T07:44:25 *** nik-j_ has joined #bitcoin-core-dev
912020-07-03T07:48:32 *** nik-j_ has quit IRC
922020-07-03T07:56:52 *** promag has joined #bitcoin-core-dev
932020-07-03T07:57:52 *** promag has quit IRC
942020-07-03T07:58:50 *** jonatack has joined #bitcoin-core-dev
952020-07-03T07:58:56 *** promag has joined #bitcoin-core-dev
962020-07-03T08:00:43 *** vasild has quit IRC
972020-07-03T08:01:42 *** EagleTM has joined #bitcoin-core-dev
982020-07-03T08:02:40 *** vasild has joined #bitcoin-core-dev
992020-07-03T08:03:34 *** promag has quit IRC
1002020-07-03T08:04:57 *** promag has joined #bitcoin-core-dev
1012020-07-03T08:16:46 *** bitcoin-git has joined #bitcoin-core-dev
1022020-07-03T08:16:47 <bitcoin-git> [bitcoin] fanquake pushed 11 commits to master: https://github.com/bitcoin/bitcoin/compare/daae8b8a1b03...7d9008f43e50
1032020-07-03T08:16:48 <bitcoin-git> bitcoin/master 9e2e753 Hennadii Stepanov: build: Always define ZMQ_STATIC for MinGW
1042020-07-03T08:16:48 <bitcoin-git> bitcoin/master e9edbe4 Hennadii Stepanov: build: Always use pkg-config
1052020-07-03T08:16:48 <bitcoin-git> bitcoin/master 6fd2118 Hennadii Stepanov: build: Drop dead non-pkg-config code for UNIVALUE check
1062020-07-03T08:16:49 *** bitcoin-git has left #bitcoin-core-dev
1072020-07-03T08:17:11 *** proofofkeags has joined #bitcoin-core-dev
1082020-07-03T08:17:52 *** bitcoin-git has joined #bitcoin-core-dev
1092020-07-03T08:17:52 <bitcoin-git> [bitcoin] fanquake merged pull request #18307: build: Require pkg-config for all of the hosts (master...20200309-pkgconfig) https://github.com/bitcoin/bitcoin/pull/18307
1102020-07-03T08:17:52 *** bitcoin-git has left #bitcoin-core-dev
1112020-07-03T08:21:42 *** proofofkeags has quit IRC
1122020-07-03T08:23:04 *** EagleTM has quit IRC
1132020-07-03T08:23:27 *** EagleTM has joined #bitcoin-core-dev
1142020-07-03T08:26:27 *** EagleTM has quit IRC
1152020-07-03T08:26:53 *** EagleTM has joined #bitcoin-core-dev
1162020-07-03T08:27:11 *** face has quit IRC
1172020-07-03T08:28:58 *** promag has quit IRC
1182020-07-03T08:31:11 *** promag has joined #bitcoin-core-dev
1192020-07-03T08:39:37 *** EagleTM has quit IRC
1202020-07-03T08:40:01 *** EagleTM has joined #bitcoin-core-dev
1212020-07-03T08:45:53 *** EagleTM has quit IRC
1222020-07-03T08:46:18 *** EagleTM has joined #bitcoin-core-dev
1232020-07-03T09:00:01 *** BlaDe^ has quit IRC
1242020-07-03T09:01:37 *** AaronvanW has joined #bitcoin-core-dev
1252020-07-03T09:02:10 *** Pavlenex1 has joined #bitcoin-core-dev
1262020-07-03T09:02:44 *** Pavlenex has quit IRC
1272020-07-03T09:02:44 *** Pavlenex1 is now known as Pavlenex
1282020-07-03T09:05:40 *** jonatack has quit IRC
1292020-07-03T09:05:43 *** EagleTM has quit IRC
1302020-07-03T09:06:07 *** EagleTM has joined #bitcoin-core-dev
1312020-07-03T09:08:09 *** jonatack has joined #bitcoin-core-dev
1322020-07-03T09:18:11 *** EagleTM has quit IRC
1332020-07-03T09:18:37 *** EagleTM has joined #bitcoin-core-dev
1342020-07-03T09:18:43 *** sipa has quit IRC
1352020-07-03T09:21:55 *** theos1 has joined #bitcoin-core-dev
1362020-07-03T09:22:12 *** jonatack has quit IRC
1372020-07-03T09:23:01 *** jonatack has joined #bitcoin-core-dev
1382020-07-03T09:23:50 *** EagleTM has quit IRC
1392020-07-03T09:24:17 *** EagleTM has joined #bitcoin-core-dev
1402020-07-03T09:25:43 *** sipa has joined #bitcoin-core-dev
1412020-07-03T09:34:43 *** Aaronvan_ has joined #bitcoin-core-dev
1422020-07-03T09:37:42 *** AaronvanW has quit IRC
1432020-07-03T09:39:11 *** bitcoin-git has joined #bitcoin-core-dev
1442020-07-03T09:39:11 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7d9008f43e50...f61019f5a2c6
1452020-07-03T09:39:11 <bitcoin-git> bitcoin/master a8d39b8 fanquake: doc: explain why passing -mlinker-version is required
1462020-07-03T09:39:12 <bitcoin-git> bitcoin/master f61019f fanquake: Merge #19407: doc: explain why passing -mlinker-version is required when c...
1472020-07-03T09:39:13 *** bitcoin-git has left #bitcoin-core-dev
1482020-07-03T09:39:30 *** bitcoin-git has joined #bitcoin-core-dev
1492020-07-03T09:39:30 <bitcoin-git> [bitcoin] fanquake merged pull request #19407: doc: explain why passing -mlinker-version is required when cross-compiling (master...explain_mlinker_version_required) https://github.com/bitcoin/bitcoin/pull/19407
1502020-07-03T09:39:33 *** bitcoin-git has left #bitcoin-core-dev
1512020-07-03T09:41:49 <fanquake> practicalswift: has asked for #18817 to be their high-prio PR. So I've added that.
1522020-07-03T09:41:50 <gribble> https://github.com/bitcoin/bitcoin/issues/18817 | doc: Document differences in bitcoind and bitcoin-qt locale handling by practicalswift · Pull Request #18817 · bitcoin/bitcoin · GitHub
1532020-07-03T09:44:05 *** EagleTM has quit IRC
1542020-07-03T09:44:32 *** EagleTM has joined #bitcoin-core-dev
1552020-07-03T09:45:14 *** nik-j has joined #bitcoin-core-dev
1562020-07-03T09:48:14 *** EagleTM has quit IRC
1572020-07-03T09:48:37 *** EagleTM has joined #bitcoin-core-dev
1582020-07-03T09:49:34 *** nik-j has quit IRC
1592020-07-03T09:49:58 *** vasild has quit IRC
1602020-07-03T09:53:09 *** EagleTM has quit IRC
1612020-07-03T09:53:35 *** EagleTM has joined #bitcoin-core-dev
1622020-07-03T09:56:07 *** windsok has quit IRC
1632020-07-03T09:58:44 *** windsok has joined #bitcoin-core-dev
1642020-07-03T09:58:44 *** windsok has joined #bitcoin-core-dev
1652020-07-03T09:59:07 *** EagleTM has quit IRC
1662020-07-03T09:59:32 *** EagleTM has joined #bitcoin-core-dev
1672020-07-03T10:05:27 *** Fidel88Buckridge has joined #bitcoin-core-dev
1682020-07-03T10:08:59 *** vasild has joined #bitcoin-core-dev
1692020-07-03T10:10:18 *** promag has quit IRC
1702020-07-03T10:10:25 *** Fidel88Buckridge has quit IRC
1712020-07-03T10:10:46 *** promag has joined #bitcoin-core-dev
1722020-07-03T10:12:00 *** EagleTM has quit IRC
1732020-07-03T10:12:23 *** EagleTM has joined #bitcoin-core-dev
1742020-07-03T10:15:24 *** EagleTM has quit IRC
1752020-07-03T10:15:48 *** EagleTM has joined #bitcoin-core-dev
1762020-07-03T10:18:04 *** proofofkeags has joined #bitcoin-core-dev
1772020-07-03T10:21:52 *** EagleTM has quit IRC
1782020-07-03T10:22:16 *** EagleTM has joined #bitcoin-core-dev
1792020-07-03T10:22:39 *** proofofkeags has quit IRC
1802020-07-03T10:25:17 *** bitcoin-git has joined #bitcoin-core-dev
1812020-07-03T10:25:17 <bitcoin-git> [bitcoin] jonatack opened pull request #19436: consensus, test: use `OP_RIGHT`, ensure `OP_1NEGATE` satisfies BIP62 (master...test-OP_1NEGATE-and-use-OP_RIGHT) https://github.com/bitcoin/bitcoin/pull/19436
1822020-07-03T10:25:18 *** bitcoin-git has left #bitcoin-core-dev
1832020-07-03T10:25:39 *** EagleTM has quit IRC
1842020-07-03T10:26:02 *** EagleTM has joined #bitcoin-core-dev
1852020-07-03T10:29:02 *** EagleTM has quit IRC
1862020-07-03T10:29:29 *** EagleTM has joined #bitcoin-core-dev
1872020-07-03T10:44:14 *** promag has quit IRC
1882020-07-03T10:44:40 *** Aaronvan_ has quit IRC
1892020-07-03T10:50:26 *** EagleTM has quit IRC
1902020-07-03T10:50:50 *** EagleTM has joined #bitcoin-core-dev
1912020-07-03T10:51:50 *** tryphe has quit IRC
1922020-07-03T10:52:13 *** belcher_ has joined #bitcoin-core-dev
1932020-07-03T10:52:31 *** tryphe has joined #bitcoin-core-dev
1942020-07-03T10:54:42 *** Highway61 has joined #bitcoin-core-dev
1952020-07-03T10:55:34 *** belcher has quit IRC
1962020-07-03T11:01:19 *** Pavlenex has quit IRC
1972020-07-03T11:09:08 *** bitcoin-git has joined #bitcoin-core-dev
1982020-07-03T11:09:09 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #19431: ci: Avoid failing pull requests destory the appveyor cache (master...2007-ciAppv) https://github.com/bitcoin/bitcoin/pull/19431
1992020-07-03T11:09:10 *** bitcoin-git has left #bitcoin-core-dev
2002020-07-03T11:09:41 *** EagleTM has quit IRC
2012020-07-03T11:15:51 *** nik-j has joined #bitcoin-core-dev
2022020-07-03T11:30:40 *** vasild_ has joined #bitcoin-core-dev
2032020-07-03T11:34:23 *** vasild has quit IRC
2042020-07-03T11:34:24 *** vasild_ is now known as vasild
2052020-07-03T11:36:22 *** AaronvanW has joined #bitcoin-core-dev
2062020-07-03T11:39:55 *** bitcoin-git has joined #bitcoin-core-dev
2072020-07-03T11:39:55 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f61019f5a2c6...915ac8a86192
2082020-07-03T11:39:56 <bitcoin-git> bitcoin/master fa0dfdf MarcoFalke: refactor: Remove confusing BlockIndex global
2092020-07-03T11:39:56 <bitcoin-git> bitcoin/master 915ac8a MarcoFalke: Merge #19413: refactor: Remove confusing BlockIndex global
2102020-07-03T11:39:58 *** bitcoin-git has left #bitcoin-core-dev
2112020-07-03T11:40:15 *** bitcoin-git has joined #bitcoin-core-dev
2122020-07-03T11:40:15 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19413: refactor: Remove confusing BlockIndex global (master...2006-noBlockIndexGlobal) https://github.com/bitcoin/bitcoin/pull/19413
2132020-07-03T11:40:16 *** bitcoin-git has left #bitcoin-core-dev
2142020-07-03T11:42:20 *** bitcoin-git has joined #bitcoin-core-dev
2152020-07-03T11:42:20 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/915ac8a86192...3276c148c4ca
2162020-07-03T11:42:21 <bitcoin-git> bitcoin/master fa8e6df MarcoFalke: ci: Run tsan ci config on cirrus
2172020-07-03T11:42:21 <bitcoin-git> bitcoin/master 3276c14 MarcoFalke: Merge #19424: ci: Run tsan ci config on cirrus
2182020-07-03T11:42:23 *** bitcoin-git has left #bitcoin-core-dev
2192020-07-03T11:42:40 *** bitcoin-git has joined #bitcoin-core-dev
2202020-07-03T11:42:40 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19424: ci: Run tsan ci config on cirrus (master...2006-ciTsanCirrus) https://github.com/bitcoin/bitcoin/pull/19424
2212020-07-03T11:42:41 *** bitcoin-git has left #bitcoin-core-dev
2222020-07-03T11:49:41 *** jonatack has quit IRC
2232020-07-03T11:55:39 *** promag has joined #bitcoin-core-dev
2242020-07-03T11:56:54 *** nik-j has quit IRC
2252020-07-03T11:57:09 *** nik-j has joined #bitcoin-core-dev
2262020-07-03T12:00:01 *** theos1 has quit IRC
2272020-07-03T12:04:18 *** promag has quit IRC
2282020-07-03T12:32:22 *** jonatack has joined #bitcoin-core-dev
2292020-07-03T12:52:04 *** lukedashjr has joined #bitcoin-core-dev
2302020-07-03T12:52:42 *** luke-jr has quit IRC
2312020-07-03T12:56:07 *** geek00l has joined #bitcoin-core-dev
2322020-07-03T12:56:29 *** lukedashjr is now known as luke-jr
2332020-07-03T13:16:24 *** promag has joined #bitcoin-core-dev
2342020-07-03T13:19:52 *** Guyver2 has joined #bitcoin-core-dev
2352020-07-03T13:21:57 *** Relis has joined #bitcoin-core-dev
2362020-07-03T13:30:55 *** mdunnio has joined #bitcoin-core-dev
2372020-07-03T13:32:37 *** Relis has quit IRC
2382020-07-03T13:34:15 *** Relis has joined #bitcoin-core-dev
2392020-07-03T14:00:39 *** proofofkeags has joined #bitcoin-core-dev
2402020-07-03T14:02:59 *** sipsorcery has joined #bitcoin-core-dev
2412020-07-03T14:04:16 *** luke-jr has quit IRC
2422020-07-03T14:06:06 *** luke-jr has joined #bitcoin-core-dev
2432020-07-03T14:20:31 *** Highway61 has quit IRC
2442020-07-03T14:20:57 *** Highway61 has joined #bitcoin-core-dev
2452020-07-03T14:25:34 *** MasterdonX has quit IRC
2462020-07-03T14:26:06 *** MasterdonX has joined #bitcoin-core-dev
2472020-07-03T14:29:43 *** mol_ has joined #bitcoin-core-dev
2482020-07-03T14:32:52 *** alko has quit IRC
2492020-07-03T14:33:13 *** mol has quit IRC
2502020-07-03T14:34:11 *** mdunnio has quit IRC
2512020-07-03T14:38:05 *** mol has joined #bitcoin-core-dev
2522020-07-03T14:38:55 *** sipsorcery has quit IRC
2532020-07-03T14:39:09 *** sipsorcery has joined #bitcoin-core-dev
2542020-07-03T14:41:01 *** mol_ has quit IRC
2552020-07-03T14:41:59 *** AaronvanW has quit IRC
2562020-07-03T14:46:20 *** bitdex has quit IRC
2572020-07-03T14:46:27 *** mol_ has joined #bitcoin-core-dev
2582020-07-03T14:47:15 *** davec has quit IRC
2592020-07-03T14:48:58 *** mol has quit IRC
2602020-07-03T14:50:45 *** molz_ has joined #bitcoin-core-dev
2612020-07-03T14:51:44 *** EagleTM has joined #bitcoin-core-dev
2622020-07-03T14:54:02 *** mol_ has quit IRC
2632020-07-03T14:54:07 *** davec has joined #bitcoin-core-dev
2642020-07-03T15:00:02 *** geek00l has quit IRC
2652020-07-03T15:04:18 *** proofofkeags has quit IRC
2662020-07-03T15:05:17 *** Randolf has joined #bitcoin-core-dev
2672020-07-03T15:05:32 *** promag has quit IRC
2682020-07-03T15:05:46 *** jarthur has joined #bitcoin-core-dev
2692020-07-03T15:06:05 *** Randolf has quit IRC
2702020-07-03T15:09:06 *** promag has joined #bitcoin-core-dev
2712020-07-03T15:11:13 *** kljasdfvv has quit IRC
2722020-07-03T15:11:48 *** promag has quit IRC
2732020-07-03T15:16:07 *** molz_ has quit IRC
2742020-07-03T15:16:30 *** sipsorcery has quit IRC
2752020-07-03T15:16:59 *** RavenSoft has joined #bitcoin-core-dev
2762020-07-03T15:17:06 *** promag has joined #bitcoin-core-dev
2772020-07-03T15:24:34 *** jnewbery_ has joined #bitcoin-core-dev
2782020-07-03T15:25:40 *** jnewbery has quit IRC
2792020-07-03T15:25:41 *** IGHOR has quit IRC
2802020-07-03T15:25:41 *** wallet42 has quit IRC
2812020-07-03T15:25:41 *** BGL has quit IRC
2822020-07-03T15:25:42 *** wallet42_ has joined #bitcoin-core-dev
2832020-07-03T15:25:52 *** IGHOR has joined #bitcoin-core-dev
2842020-07-03T15:48:48 *** EagleTM has quit IRC
2852020-07-03T15:49:11 *** justanotheruser has quit IRC
2862020-07-03T15:55:33 *** AaronvanW has joined #bitcoin-core-dev
2872020-07-03T16:02:57 *** molz_ has joined #bitcoin-core-dev
2882020-07-03T16:07:20 *** Relis has quit IRC
2892020-07-03T16:09:41 *** proofofkeags has joined #bitcoin-core-dev
2902020-07-03T16:14:23 *** promag has quit IRC
2912020-07-03T16:17:29 *** sipsorcery has joined #bitcoin-core-dev
2922020-07-03T16:17:36 *** owowo has quit IRC
2932020-07-03T16:20:16 *** Relis has joined #bitcoin-core-dev
2942020-07-03T16:23:11 *** owowo has joined #bitcoin-core-dev
2952020-07-03T16:26:12 *** AaronvanW has quit IRC
2962020-07-03T16:26:13 *** promag has joined #bitcoin-core-dev
2972020-07-03T16:28:02 *** BGL has joined #bitcoin-core-dev
2982020-07-03T16:37:44 *** ahmed_ has quit IRC
2992020-07-03T16:41:56 *** promag has quit IRC
3002020-07-03T16:43:20 *** luke-jr has quit IRC
3012020-07-03T16:48:46 *** mol_ has joined #bitcoin-core-dev
3022020-07-03T16:52:06 *** molz_ has quit IRC
3032020-07-03T17:03:37 *** bitcoin-git has joined #bitcoin-core-dev
3042020-07-03T17:03:37 <bitcoin-git> [bitcoin] ajtowns opened pull request #19438: Introduce deploymentstatus (master...202007-deployment-refactor) https://github.com/bitcoin/bitcoin/pull/19438
3052020-07-03T17:03:38 *** bitcoin-git has left #bitcoin-core-dev
3062020-07-03T17:05:06 <dongcarl> According to the tor-dev mailing list, Tor plans to deprecate v2 with 0.4.4.x (Sept. 15th, 2020) and obsolete it in 0.4.6.x (July 15th, 2021)
3072020-07-03T17:05:11 <dongcarl> More details here: https://lists.torproject.org/pipermail/tor-dev/2020-June/014365.html
3082020-07-03T17:05:49 <dongcarl> (Originally found by BlueMatt)
3092020-07-03T17:06:02 <dongcarl> Perhaps this warrants renewed attention on vasild's addrv2 work
3102020-07-03T17:07:12 *** proofofkeags has quit IRC
3112020-07-03T17:07:37 *** proofofkeags has joined #bitcoin-core-dev
3122020-07-03T17:08:43 <sipa> yeah
3132020-07-03T17:09:29 *** jnewbery has joined #bitcoin-core-dev
3142020-07-03T17:11:54 *** proofofkeags has quit IRC
3152020-07-03T17:12:58 *** luke-jr has joined #bitcoin-core-dev
3162020-07-03T17:25:41 *** jnewbery_ has quit IRC
3172020-07-03T17:27:08 *** bitdex has joined #bitcoin-core-dev
3182020-07-03T17:32:14 *** AaronvanW has joined #bitcoin-core-dev
3192020-07-03T17:32:22 *** AaronvanW has quit IRC
3202020-07-03T17:37:36 *** greypw has joined #bitcoin-core-dev
3212020-07-03T17:43:45 *** proofofkeags has joined #bitcoin-core-dev
3222020-07-03T17:47:54 *** proofofkeags has quit IRC
3232020-07-03T17:53:45 *** bitdex has quit IRC
3242020-07-03T18:00:01 *** RavenSoft has quit IRC
3252020-07-03T18:19:55 *** jarthur has quit IRC
3262020-07-03T18:22:06 *** defnordic has joined #bitcoin-core-dev
3272020-07-03T18:29:07 *** Luke has joined #bitcoin-core-dev
3282020-07-03T18:31:06 *** AaronvanW has joined #bitcoin-core-dev
3292020-07-03T18:31:25 *** Luke has joined #bitcoin-core-dev
3302020-07-03T18:42:28 *** Luke has quit IRC
3312020-07-03T18:42:35 *** promag has joined #bitcoin-core-dev
3322020-07-03T18:43:33 *** Luke has joined #bitcoin-core-dev
3332020-07-03T18:46:53 *** promag has quit IRC
3342020-07-03T18:47:44 <BlueMatt> yea, basically it sounds like either addrv2 ships in the next release-ish, or tor support is gonna be pretty manual until it ships.
3352020-07-03T18:49:21 <BlueMatt> (also more confirmation the other night about how tor addresses already largely dont realy through the p2p network - wiz's new dnsseed has been running for weeks and the only onion it learned was the one he manually tested which was his own...only after adding a bunch of onions from a few random lists did it start picking up new onion addrs, presumably because at least one or two of those nodes were tor-only and thus had onions in
3362020-07-03T18:49:21 <BlueMatt> their addrdb....but, essentially, even asking every node on the network for addresses every hour or so for a week or two will get you *zero* onion addresses)
3372020-07-03T18:55:56 <luke-jr> BlueMatt: ?
3382020-07-03T18:56:40 <BlueMatt> which bit was more unclear?
3392020-07-03T18:56:44 <luke-jr> what does addrv2 to address this that can't be done with addrv1?
3402020-07-03T18:56:54 <luke-jr> do to address*
3412020-07-03T18:57:03 <BlueMatt> support tor v3 onion addresses
3422020-07-03T18:57:07 *** luke-jr has quit IRC
3432020-07-03T18:57:14 <BlueMatt> that is a separate issue from onions not propagating at all
3442020-07-03T18:57:30 <BlueMatt> hum...bye, luke, i guess
3452020-07-03T18:59:31 <sipa> BlueMatt: my dns seed/crawler has 1778 onion addresses that it considers good
3462020-07-03T19:00:03 *** luke-jr has joined #bitcoin-core-dev
3472020-07-03T19:00:25 <meshcollider> Wallet meeting :)
3482020-07-03T19:00:30 <achow101> wallet meeting?
3492020-07-03T19:00:31 <meshcollider> #startmeeting
3502020-07-03T19:00:31 <lightningbot> Meeting started Fri Jul 3 19:00:31 2020 UTC. The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot.
3512020-07-03T19:00:31 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
3522020-07-03T19:00:36 <meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball ariard digi_james amiti fjahr
3532020-07-03T19:00:36 <meshcollider> jeremyrubin emilengler jonatack hebasto jb55
3542020-07-03T19:00:41 <BlueMatt> sipa: yes, afaict, once you 'find them' you're good, but essentially its super, super, super difficult to find onions from square 1
3552020-07-03T19:00:45 <achow101> hi
3562020-07-03T19:01:04 <sipa> BlueMatt: they only really propagate through onion-enabled peers
3572020-07-03T19:01:07 <BlueMatt> (presumably because they dont relay between non-onion peers nearly at all, and unless you are onion-only you'll be largely blind)
3582020-07-03T19:01:10 <meshcollider> Now, I know luke-jr still has a proposed topic, were there any more?
3592020-07-03T19:01:36 <BlueMatt> right, but my observations seem to indicate that you almost have to be onion-only, or at least connect to onion only to learn any, really
3602020-07-03T19:01:47 *** en10n has quit IRC
3612020-07-03T19:01:50 <BlueMatt> all anecdotal, of course
3622020-07-03T19:02:02 <achow101> is it too early to discuss deprecating and removing the legacy wallet?
3632020-07-03T19:02:10 <meshcollider> Yes :p
3642020-07-03T19:02:13 <sipa> achow101: yes
3652020-07-03T19:02:58 <meshcollider> Try again in v0.27
3662020-07-03T19:03:30 <achow101> i'll try again next year
3672020-07-03T19:03:44 <meshcollider> Is luke-jr here this time for his topic
3682020-07-03T19:04:39 <meshcollider> I guess not
3692020-07-03T19:04:56 <achow101> maybe if we say luke-jr enough times he'll show up
3702020-07-03T19:05:08 <sipa> tonal tonal tonal
3712020-07-03T19:05:52 <meshcollider> Alright, short meeting again then :)
3722020-07-03T19:05:55 <luke-jr> achow101 must be joking
3732020-07-03T19:06:11 <luke-jr> I need a reminder what my topic is :D
3742020-07-03T19:06:12 <luke-jr> â¦
3752020-07-03T19:06:14 <luke-jr> is my IRC broken?
3762020-07-03T19:06:19 <achow101> luke-jr: not anymore
3772020-07-03T19:06:23 <sipa> we can read you
3782020-07-03T19:06:27 <achow101> 2020-06-17.log:12:15 < luke-jr> #proposedwalletmeetingtopic revert #6550 (conceptually) - merkle branches stored in the wallet would be useful for pruned nodes [w/ watch-only wallets]
3792020-07-03T19:06:29 *** Luke has left #bitcoin-core-dev
3802020-07-03T19:06:31 <gribble> https://github.com/bitcoin/bitcoin/issues/6550 | Do not store Merkle branches in the wallet. by sipa · Pull Request #6550 · bitcoin/bitcoin · GitHub
3812020-07-03T19:06:58 <luke-jr> ah right
3822020-07-03T19:07:14 <luke-jr> apparently Electrum-Personal-Server and similar projects could really use those merkle branches
3832020-07-03T19:07:41 <meshcollider> #topic Merkle branches stored in wallet (luke-jr)
3842020-07-03T19:08:17 <luke-jr> sipa: what was the motivation for removing them? is it okay to add them back?
3852020-07-03T19:08:18 <achow101> I can see the case for wanting these for pruned wallets in general
3862020-07-03T19:08:36 <achow101> it seems like the original motivation was that they were useless
3872020-07-03T19:08:36 <sipa> luke-jr: they were just not used by anything at the time
3882020-07-03T19:08:49 <sipa> no objection to adding them back if that is no longer the case
3892020-07-03T19:09:21 <luke-jr> should we bother to try to make it compatible with the old thing?
3902020-07-03T19:09:24 <sipa> vaguely related: we should also store the network fee for wallet transactions
3912020-07-03T19:09:30 <sipa> i don't think so
3922020-07-03T19:09:46 <achow101> i would prefer to be wholly new
3932020-07-03T19:09:59 <achow101> less headaches with possible compatibility states
3942020-07-03T19:10:10 <luke-jr> k
3952020-07-03T19:10:27 <luke-jr> what to do with wallets missing the info?
3962020-07-03T19:10:41 <sipa> a rescan will fix it
3972020-07-03T19:11:00 <luke-jr> but pruned wallets can't rescan necessarily
3982020-07-03T19:11:03 <luke-jr> and this is mainly for them..
3992020-07-03T19:11:12 <achow101> for not pruned wallets, it's easy to compute
4002020-07-03T19:11:25 <sipa> well if the data isn't there, there is nothing we can do
4012020-07-03T19:11:57 <achow101> i suppose a related feature would be the fetching of individual blocks over p2p for pruned nodes
4022020-07-03T19:12:00 <luke-jr> so maybe just omit it in RPC requests for txs missing it?
4032020-07-03T19:12:11 <sipa> achow101: ah the perennial feature request
4042020-07-03T19:12:12 <luke-jr> should it be an optional wallet feature?
4052020-07-03T19:12:38 <luke-jr> achow101: hmm, I suppose if we know the height it's possible, but seems complex
4062020-07-03T19:12:59 <luke-jr> and even if we get that, there's a period of time before the request is fulfilled
4072020-07-03T19:13:00 <achow101> luke-jr: I think we know the hash
4082020-07-03T19:13:26 <sipa> that's not enough to fetch it
4092020-07-03T19:14:33 <luke-jr> there's no way to get just the merkle tree I suspect
4102020-07-03T19:14:43 <luke-jr> bloom would get us exactly what we need, but has privacy problems
4112020-07-03T19:15:00 <luke-jr> in any case, I suspect all such fetching can be a later PR - it doesn't simplify the upfront feature
4122020-07-03T19:15:41 <achow101> it can just be one of those features that we do from now on and for old wallets that we can get the merkle branch for
4132020-07-03T19:16:12 <achow101> but for pruned nodes where those blocks have already been disarded, they're SOL
4142020-07-03T19:16:21 <luke-jr> achow101: I thought we weren't going to try to be compatible? besides, I think 0.12+ deleted that info even in old wallets?
4152020-07-03T19:16:44 *** jarthur has joined #bitcoin-core-dev
4162020-07-03T19:16:50 <achow101> luke-jr: if you're adding a new record, it'll still be openable in old wallets, just not useful data
4172020-07-03T19:17:03 * luke-jr wonders if we should have a pruning setting to never discard blocks your wallet is involved in
4182020-07-03T19:17:05 <achow101> so it's not a version bump or an incompatible wallet flag
4192020-07-03T19:17:41 <luke-jr> achow101: oh, I misunderstood "old wallets that we can get the merkle branch for"
4202020-07-03T19:17:44 <jonatack> hi
4212020-07-03T19:17:49 <achow101> right
4222020-07-03T19:18:18 <luke-jr> is there any other info we might want to save?
4232020-07-03T19:18:33 <luke-jr> perhaps the transactions used as inputs?
4242020-07-03T19:18:37 <meshcollider> I feel like keeping the entire blocks your wallet is involved in would not be useful other than in weird cases like right now
4252020-07-03T19:18:51 <luke-jr> meshcollider: definitely don't want to do that âº
4262020-07-03T19:18:53 <achow101> didn't we use to save transactions used as inputs
4272020-07-03T19:19:00 <luke-jr> oh, not in the wallet
4282020-07-03T19:19:05 <luke-jr> achow101: I think so
4292020-07-03T19:19:09 <sipa> we should store unconfirmed inputs too, i think
4302020-07-03T19:19:24 <sipa> but not using the exponential-blowup-fest approach that was used before
4312020-07-03T19:19:41 <luke-jr> sipa: I forget what we had before for this
4322020-07-03T19:20:01 <luke-jr> was the problem it saved the txs in the wallettx?
4332020-07-03T19:20:08 <sipa> yes
4342020-07-03T19:20:19 <luke-jr> so a new db entry per txid should fix that, right?
4352020-07-03T19:20:20 <achow101> CWalletTx needs to be trimmed
4362020-07-03T19:20:51 <luke-jr> refcounted I suppose
4372020-07-03T19:21:07 * luke-jr feels like he's had this discussion recently already :x
4382020-07-03T19:21:50 <sipa> i think we can just store the inputs as wallet txn
4392020-07-03T19:22:02 *** proofofkeags has joined #bitcoin-core-dev
4402020-07-03T19:22:04 <achow101> We might want to store just the prev txos?
4412020-07-03T19:22:12 <sipa> which won't be IsMine(), but just there to fetch
4422020-07-03T19:22:18 <luke-jr> hmm
4432020-07-03T19:22:30 <luke-jr> achow101: that won't work if we need to send the entire tx to the hw wallet?
4442020-07-03T19:22:31 <sipa> achow101: i don't think that's useful
4452020-07-03T19:22:50 <sipa> ah, in taproot it may be
4462020-07-03T19:23:04 <sipa> but i was more thinking that this can help rebroadcasting
4472020-07-03T19:23:26 <achow101> ah.
4482020-07-03T19:23:50 <luke-jr> it used to be your wallet would keep the transactions it has an interest in alive..
4492020-07-03T19:23:58 <luke-jr> I guess we lost that
4502020-07-03T19:24:12 <achow101> I think storing the prevtxs as a wallet txn will confuse many things
4512020-07-03T19:24:23 <sipa> it may be, i'm not sure
4522020-07-03T19:24:45 <achow101> I'm pretty sure there's an implicit assumption that things in mapWalletTxs are actually involved in your wallet
4532020-07-03T19:24:49 <achow101> as in an input or output is yours
4542020-07-03T19:25:09 <sipa> maybe - but i think most things still filter using IsMine
4552020-07-03T19:25:21 <luke-jr> harmless to just change the db key
4562020-07-03T19:25:27 <achow101> I'd like to not do that (as much) in the future :)
4572020-07-03T19:25:28 <luke-jr> can read it as a wallettx type if that's useful
4582020-07-03T19:25:56 <achow101> right, just have it as another record would probably be better
4592020-07-03T19:26:03 <sipa> perhaps yes
4602020-07-03T19:26:23 <sipa> that also has less risk causing backward compatibility issues
4612020-07-03T19:28:14 <achow101> topic suggestion: legacy to descriptor wallet migration
4622020-07-03T19:29:15 *** nik-j has quit IRC
4632020-07-03T19:29:23 <meshcollider> #topic legacy to descriptor wallet migration (achow101)
4642020-07-03T19:30:08 <achow101> did we determine whether it was possible to make all of the legacy things fit into descriptors?
4652020-07-03T19:30:44 <meshcollider> What do you mean by possible
4662020-07-03T19:30:55 <achow101> I would actually like to figure out how/if we can migrate people's wallets to descriptors so they don't lose anything
4672020-07-03T19:31:21 <sipa> sure, but it may need a huge amount of descriptors
4682020-07-03T19:31:39 <achow101> as in can we represent everything that could be in a legacy wallet as descriptors, and preferably not as thousands of descriptors
4692020-07-03T19:32:11 *** nik-j_ has joined #bitcoin-core-dev
4702020-07-03T19:32:12 <achow101> I think we previously had concern that IsMine would match to a nearly infinite number of scripts, but I don't think that's possible anymore?
4712020-07-03T19:32:23 *** nik-j_ has quit IRC
4722020-07-03T19:32:31 <sipa> i believe that's not the case anymore since bare multisig matching is gone
4732020-07-03T19:32:34 <achow101> s/possible/concern
4742020-07-03T19:33:38 <meshcollider> You can probably turn an HD wallet into a descriptor wallet okay
4752020-07-03T19:33:48 * luke-jr still prefers JBOK wallets
4762020-07-03T19:34:08 <sipa> infer a descriptor from HD information, expand it, see which scriptpubkeys it does not cover
4772020-07-03T19:34:26 <sipa> store the remaining ones as additional descriptors
4782020-07-03T19:34:29 <meshcollider> Obviously a non-HD wallet it's gonna be thousands of individual descriptors
4792020-07-03T19:34:30 <achow101> for non-HD, that's going to be a lot of descriptors
4802020-07-03T19:34:37 <sipa> yes
4812020-07-03T19:34:50 <achow101> what about imports?
4822020-07-03T19:35:13 <sipa> perhaps it makes sense to have a list() descriptor or something, which contains a list of non-ranged descriptors
4832020-07-03T19:35:28 <sipa> so that you can have one thing that represents an entire wallet, but still expose it as a "list"
4842020-07-03T19:35:54 <sipa> s/list/range/
4852020-07-03T19:35:56 <meshcollider> And have a similar range index thing as a ranged descriptor?
4862020-07-03T19:36:00 <sipa> right
4872020-07-03T19:36:21 <achow101> also, with descriptors we don't have the address type mutation thing, so I think migrating would require generating new active descriptors and all the old stuff is no longer used
4882020-07-03T19:37:34 <luke-jr> achow101: that was never *supposed* to work though
4892020-07-03T19:37:36 <luke-jr> do we need to support it?
4902020-07-03T19:38:24 <achow101> luke-jr: i mean retaining possible mutations on the old stuff that has already been used
4912020-07-03T19:38:38 <sipa> luke-jr: i think it's dangerous to remove things that were treated as IsMine
4922020-07-03T19:39:14 <luke-jr> I think once an address is used, we don't need to look for it in new blocks anymore <.<
4932020-07-03T19:39:30 <achow101> unfortunately that's not a reasonable assumption
4942020-07-03T19:39:48 <sipa> yeah
4952020-07-03T19:41:49 <achow101> so I think it should be possible to migrate, but it might be a bit ugly
4962020-07-03T19:42:01 <achow101> that's good to know
4972020-07-03T19:42:25 <meshcollider> The list descriptor is worth thinking about imo
4982020-07-03T19:42:54 <sipa> it's easy to add, but may become huge :)
4992020-07-03T19:43:18 <meshcollider> Certainly would become huge in a lot of cases :p
5002020-07-03T19:43:27 <luke-jr> I don't really get what there is to gain from this
5012020-07-03T19:43:45 <meshcollider> Achow just wants eventual legacy deprecation
5022020-07-03T19:44:16 <achow101> it's so we can ditch the legacy wallet in the future without forcing people to make wholly new wallets
5032020-07-03T19:44:22 <luke-jr> why?
5042020-07-03T19:44:43 <meshcollider> Because descriptor wallets are better
5052020-07-03T19:44:48 <luke-jr> â¦
5062020-07-03T19:44:56 <achow101> less stuff to maintaini
5072020-07-03T19:45:13 <luke-jr> couldn't we just load the old keys as descriptors in memory?
5082020-07-03T19:45:31 <achow101> yes but that's (probably) expensive
5092020-07-03T19:45:33 <meshcollider> That loses most of the benefits
5102020-07-03T19:45:43 <meshcollider> Anyway any other topics?
5112020-07-03T19:47:02 <meshcollider> #endmeeting
5122020-07-03T19:47:02 <lightningbot> Meeting ended Fri Jul 3 19:47:02 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
5132020-07-03T19:47:02 <lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-07-03-19.00.html
5142020-07-03T19:47:02 <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-07-03-19.00.txt
5152020-07-03T19:47:02 <lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-07-03-19.00.log.html
5162020-07-03T19:48:48 *** afk11 has quit IRC
5172020-07-03T19:49:25 *** afk11 has joined #bitcoin-core-dev
5182020-07-03T19:55:52 *** Relis has quit IRC
5192020-07-03T19:59:44 <jeremyrubin> To an extent we should be storing all ancestors of an IsMine output (especially if they are currently unconfirmed)
5202020-07-03T20:01:40 <sipa> "i updated my bitcoin core wallet and the wallet.dat file is now 230 GB, what happened?"
5212020-07-03T20:02:11 <jeremyrubin> to an extent --> within some reorg limit maybe?
5222020-07-03T20:02:17 <jeremyrubin> e.g., 100 blocks?
5232020-07-03T20:04:43 <jeremyrubin> I guess it's whatever you set your pruning window to
5242020-07-03T20:19:06 <luke-jr> your mempool won't accept the tx in the first place if it's too deep?
5252020-07-03T20:19:49 <luke-jr> or you mean confirmed txs.. not sure why we'd store those more than 1 level deep
5262020-07-03T20:19:58 <jeremyrubin> reorgs
5272020-07-03T20:20:10 <jeremyrubin> You'd want a minimum of 6 blocks, likely 100
5282020-07-03T20:20:21 <luke-jr> when they're reorging out, we can add them as unconfirmed inputs
5292020-07-03T20:20:38 <jeremyrubin> But only if you've stored them to be able to rebroadcast
5302020-07-03T20:21:05 <luke-jr> hmm, I guess the node/wallet separation might interfere
5312020-07-03T20:21:17 <luke-jr> wallet I guess doesn't get to look at the old block before it's reorg'd out
5322020-07-03T20:21:24 <sipa> the wallet could store transactions at the time of the reorg
5332020-07-03T20:21:29 <sipa> when they become unconfirmed
5342020-07-03T20:21:40 <luke-jr> sipa: just said that, and figured out why it doesn't work ^ :P
5352020-07-03T20:21:49 <jeremyrubin> the tricky thing is that you recursively want to store all parents
5362020-07-03T20:21:51 <luke-jr> unless my IRC is broken again..
5372020-07-03T20:22:04 <jeremyrubin> so it's not just a simple ismine check. It's ismine and any now-unconf parents
5382020-07-03T20:22:06 <sipa> why can't wallet see those blocks at the time of reorg?
5392020-07-03T20:22:27 <luke-jr> sipa: the wallet might not even be loaded
5402020-07-03T20:22:58 <sipa> then it would see it afterwards; it needs to be updated to the new chain at some poimt
5412020-07-03T20:23:07 <luke-jr> but by then, the old blocks are gone
5422020-07-03T20:23:11 <luke-jr> conceptually
5432020-07-03T20:23:12 <sipa> if by then the block is pruned... of course that won't work
5442020-07-03T20:24:32 *** Relis has joined #bitcoin-core-dev
5452020-07-03T20:25:01 <jeremyrubin> Which is why you want to store as you go a window of parents to things which trigger IsMine :/
5462020-07-03T20:25:27 <jeremyrubin> If you want to be able to rebroadcast things which didn't get into the new chain on reorg at least
5472020-07-03T20:26:26 *** Talkless has joined #bitcoin-core-dev
5482020-07-03T20:26:43 <luke-jr> jeremyrubin: can we even do that without a txindex?
5492020-07-03T20:27:18 <sipa> nope
5502020-07-03T20:28:27 <jeremyrubin> Well, if you have a window (e.g., 100 blocks) you can just rescan only those. Otherwise yeah i guess you need txindex
5512020-07-03T20:30:04 <luke-jr> hrm
5522020-07-03T20:30:31 <luke-jr> I suppose it's not too terrible
5532020-07-03T20:30:40 <jeremyrubin> luke-jr: how does pruning interract with not loaded wallets?
5542020-07-03T20:30:52 <jeremyrubin> E.g., if I'm pruning after 200 blocks. And wallet B is not loaded
5552020-07-03T20:30:57 <jeremyrubin> and 400 blocks go by
5562020-07-03T20:31:03 <jeremyrubin> do I wait to prune until B is loaded?
5572020-07-03T20:31:16 <luke-jr> jeremyrubin: IIRC right now you just can't load wallet B anymore
5582020-07-03T20:31:19 <gwillen> I bet the answer is "you lose"
5592020-07-03T20:31:44 <jeremyrubin> luke-jr: Can't load meaning results in a clean error
5602020-07-03T20:31:52 <luke-jr> it *would* be nice if we had a prune-blocking directory
5612020-07-03T20:31:53 <jeremyrubin> or loads but could be missing 200 blks of txns
5622020-07-03T20:32:01 <luke-jr> clean error IIRC
5632020-07-03T20:32:11 <luke-jr> not only for wallets, but arbitrary RPC clients
5642020-07-03T20:32:12 <gwillen> the wallet knows where it needs to start scanning from
5652020-07-03T20:32:18 *** EagleTM has joined #bitcoin-core-dev
5662020-07-03T20:32:21 <gwillen> so presumably it knows it can't, although I don't know what the error looks like
5672020-07-03T20:32:24 <luke-jr> eg, JoinMarket or Lightning or such could set a prune block
5682020-07-03T20:32:48 <gwillen> luke-jr: there's at least one proposal for an RPC interface for this, but I think it's unimplemented because so far nobody cares enough to implement it
5692020-07-03T20:33:04 <gwillen> although that doesn't directly handle the case of unloaded wallets
5702020-07-03T20:33:13 <luke-jr> gwillen: but it's the same concept
5712020-07-03T20:33:18 <gwillen> yeah
5722020-07-03T20:33:52 <gwillen> it's tricky with wallets, though -- if they are in your wallet directory then that's sort of one thing (although if you made a test wallet and then never touched it again, and that silently permanently disabled pruning, that would be bad)
5732020-07-03T20:34:03 <gwillen> but if you have a wallet on removable media this gets really messy
5742020-07-03T20:34:13 <luke-jr> yeah, need a way for users to override case-by-case
5752020-07-03T20:34:18 <gwillen> you need some kind of wallet set metadata and a way to manage it
5762020-07-03T20:34:32 <luke-jr> might also want to block syncing at some point too (with a notable warning)
5772020-07-03T20:34:37 <gwillen> (look at e.g. how git handles worktrees on removable media, which is not ideal but has the same sort of problem)
5782020-07-03T20:34:51 <gwillen> (and they have an approach that is basically default pinning that you can mmanually override, IIRC)
5792020-07-03T20:35:11 <luke-jr> GUI could just show a list of "Wallet: X - synced to 2222", "c-lightning wallet Y - synced to 2221" etc
5802020-07-03T20:35:23 <luke-jr> and a "prune anyway" button
5812020-07-03T20:35:30 <luke-jr> maybe a way to tell your node to ignore them in the future
5822020-07-03T20:35:58 <gwillen> *nod*, this elevates the concept of a list of wallets to be first-class, which it isn't now, the current system happily treats a wallet.dat you found in the street as being equivalent to one it created (as far as I know)
5832020-07-03T20:36:41 <gwillen> (it probably should be, to be clear, IMO)
5842020-07-03T20:37:22 <luke-jr> "Backup of wallet X made on 2020-06-01"
5852020-07-03T20:37:52 <luke-jr> gwillen: it doesn't need to be based on the wallet list
5862020-07-03T20:38:04 <luke-jr> gwillen: just let wallets add themselves when they're loaded and sync
5872020-07-03T20:38:35 <luke-jr> I suppose the backup GUI should be revised to ask the user if they're replacing an old backup
5882020-07-03T20:39:12 <luke-jr> kinda hesitant to start on something like this tho since I have so many open PRs waiting already :x
5892020-07-03T20:41:51 * luke-jr wonders why #11082 has "Waiting for author"â¦
5902020-07-03T20:41:54 <gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
5912020-07-03T20:44:26 *** promag has joined #bitcoin-core-dev
5922020-07-03T20:48:08 *** EagleTM has quit IRC
5932020-07-03T20:48:34 *** EagleTM has joined #bitcoin-core-dev
5942020-07-03T20:51:56 *** nik-j has joined #bitcoin-core-dev
5952020-07-03T20:55:54 *** nik-j has quit IRC
5962020-07-03T20:58:16 *** EagleTM has quit IRC
5972020-07-03T20:58:43 *** EagleTM has joined #bitcoin-core-dev
5982020-07-03T21:00:01 *** defnordic has quit IRC
5992020-07-03T21:00:21 *** filchef has joined #bitcoin-core-dev
6002020-07-03T21:01:22 *** filchef has quit IRC
6012020-07-03T21:03:30 *** EagleTM has quit IRC
6022020-07-03T21:03:54 *** EagleTM has joined #bitcoin-core-dev
6032020-07-03T21:07:08 *** EagleTM has quit IRC
6042020-07-03T21:07:32 *** EagleTM has joined #bitcoin-core-dev
6052020-07-03T21:09:23 *** lehnberg has quit IRC
6062020-07-03T21:11:11 *** EagleTM has quit IRC
6072020-07-03T21:11:36 *** EagleTM has joined #bitcoin-core-dev
6082020-07-03T21:14:11 *** ahmed_ has joined #bitcoin-core-dev
6092020-07-03T21:16:04 *** ukboi has joined #bitcoin-core-dev
6102020-07-03T21:19:37 *** EagleTM has quit IRC
6112020-07-03T21:20:01 *** EagleTM has joined #bitcoin-core-dev
6122020-07-03T21:21:12 *** bitcoin-git has joined #bitcoin-core-dev
6132020-07-03T21:21:12 <bitcoin-git> [bitcoin] Ghorbanian opened pull request #19439: script: Linter to check commit message formatting (master...linter-addition) https://github.com/bitcoin/bitcoin/pull/19439
6142020-07-03T21:21:13 *** bitcoin-git has left #bitcoin-core-dev
6152020-07-03T21:32:26 *** EagleTM has quit IRC
6162020-07-03T21:32:59 *** vincenzopalazzo has joined #bitcoin-core-dev
6172020-07-03T21:36:21 *** Guyver2 has quit IRC
6182020-07-03T21:42:53 *** nik-j has joined #bitcoin-core-dev
6192020-07-03T22:05:26 *** nik-j has quit IRC
6202020-07-03T22:15:13 *** Talkless has quit IRC
6212020-07-03T22:21:04 *** proofofkeags has quit IRC
6222020-07-03T22:21:31 *** proofofkeags has joined #bitcoin-core-dev
6232020-07-03T22:23:00 *** luke-jr has quit IRC
6242020-07-03T22:24:54 *** luke-jr has joined #bitcoin-core-dev
6252020-07-03T22:25:58 *** proofofkeags has quit IRC
6262020-07-03T22:32:11 *** marcoagner has quit IRC
6272020-07-03T22:37:16 *** AaronvanW has quit IRC
6282020-07-03T22:37:51 *** AaronvanW has joined #bitcoin-core-dev
6292020-07-03T22:42:05 *** AaronvanW has quit IRC
6302020-07-03T22:43:06 *** _atos has joined #bitcoin-core-dev
6312020-07-03T23:02:28 *** luke-jr has quit IRC
6322020-07-03T23:03:03 *** Relis7 has joined #bitcoin-core-dev
6332020-07-03T23:03:23 *** luke-jr has joined #bitcoin-core-dev
6342020-07-03T23:04:34 *** Relis has quit IRC
6352020-07-03T23:04:40 *** justanotheruser has joined #bitcoin-core-dev
6362020-07-03T23:20:40 *** _atos has quit IRC
6372020-07-03T23:28:54 *** sipsorcery has quit IRC
6382020-07-03T23:29:12 *** aqua42 has quit IRC
6392020-07-03T23:29:32 *** aqua42 has joined #bitcoin-core-dev
6402020-07-03T23:33:43 *** vasild has quit IRC
6412020-07-03T23:35:39 *** vasild has joined #bitcoin-core-dev
6422020-07-03T23:37:53 *** molz_ has joined #bitcoin-core-dev
6432020-07-03T23:40:52 *** mol_ has quit IRC
6442020-07-03T23:46:05 *** mol has joined #bitcoin-core-dev
6452020-07-03T23:49:25 *** molz_ has quit IRC
6462020-07-03T23:49:41 *** proofofkeags has joined #bitcoin-core-dev