1 2020-07-13T00:00:01  *** funkatron has quit IRC
  2 2020-07-13T00:01:38  <meshcollider> Yes we can see both of your "test" messages
  3 2020-07-13T00:02:40  *** jarthur_ is now known as jarthur
  4 2020-07-13T00:05:23  *** braydonf has quit IRC
  5 2020-07-13T00:07:22  *** braydonf has joined #bitcoin-core-dev
  6 2020-07-13T00:21:57  *** defnordic has joined #bitcoin-core-dev
  7 2020-07-13T00:38:47  *** promag has joined #bitcoin-core-dev
  8 2020-07-13T00:38:48  *** promag_ has quit IRC
  9 2020-07-13T00:42:30  *** mdunnio has joined #bitcoin-core-dev
 10 2020-07-13T00:45:09  *** arowser has quit IRC
 11 2020-07-13T00:45:38  *** arowser has joined #bitcoin-core-dev
 12 2020-07-13T01:29:28  *** harrigan has quit IRC
 13 2020-07-13T01:32:41  *** harrigan has joined #bitcoin-core-dev
 14 2020-07-13T01:41:18  *** shesek has joined #bitcoin-core-dev
 15 2020-07-13T01:42:34  *** mdunnio has quit IRC
 16 2020-07-13T01:44:23  *** proofofkeags has quit IRC
 17 2020-07-13T01:44:59  *** proofofkeags has joined #bitcoin-core-dev
 18 2020-07-13T01:46:12  *** Relis has quit IRC
 19 2020-07-13T01:49:14  *** proofofkeags has quit IRC
 20 2020-07-13T01:50:10  *** arowser has quit IRC
 21 2020-07-13T01:50:41  *** arowser has joined #bitcoin-core-dev
 22 2020-07-13T01:52:09  *** arowser has quit IRC
 23 2020-07-13T01:52:33  *** arowser has joined #bitcoin-core-dev
 24 2020-07-13T01:59:10  *** proofofkeags has joined #bitcoin-core-dev
 25 2020-07-13T02:06:35  *** r8921039 has joined #bitcoin-core-dev
 26 2020-07-13T02:07:07  *** rafalcpp has quit IRC
 27 2020-07-13T02:09:56  *** Relis has joined #bitcoin-core-dev
 28 2020-07-13T02:16:57  *** Relis has quit IRC
 29 2020-07-13T02:17:15  *** Relis has joined #bitcoin-core-dev
 30 2020-07-13T02:19:00  *** mdunnio has joined #bitcoin-core-dev
 31 2020-07-13T02:20:32  *** adiabat has quit IRC
 32 2020-07-13T02:24:10  *** mdunnio has quit IRC
 33 2020-07-13T02:37:14  *** arowser has quit IRC
 34 2020-07-13T02:37:26  *** proofofkeags has quit IRC
 35 2020-07-13T02:37:42  *** arowser has joined #bitcoin-core-dev
 36 2020-07-13T02:38:00  *** proofofkeags has joined #bitcoin-core-dev
 37 2020-07-13T02:40:11  *** arowser has quit IRC
 38 2020-07-13T02:40:17  *** proofofkeags has quit IRC
 39 2020-07-13T02:40:34  *** proofofkeags has joined #bitcoin-core-dev
 40 2020-07-13T02:40:35  *** arowser has joined #bitcoin-core-dev
 41 2020-07-13T02:44:20  *** nik-j has joined #bitcoin-core-dev
 42 2020-07-13T02:49:21  *** promag_ has joined #bitcoin-core-dev
 43 2020-07-13T02:49:22  *** promag has quit IRC
 44 2020-07-13T02:53:45  *** nik-j has quit IRC
 45 2020-07-13T03:00:02  *** defnordic has quit IRC
 46 2020-07-13T03:01:24  *** braydonf has quit IRC
 47 2020-07-13T03:01:48  *** braydonf has joined #bitcoin-core-dev
 48 2020-07-13T03:06:07  *** bitcoin-git has joined #bitcoin-core-dev
 49 2020-07-13T03:06:08  <bitcoin-git> [bitcoin] luke-jr opened pull request #19502: Bugfix: Wallet: Soft-fail exceptions within ListWalletDir file checks (master...bugfix_listwalletdir_errors) https://github.com/bitcoin/bitcoin/pull/19502
 50 2020-07-13T03:06:19  *** bitcoin-git has left #bitcoin-core-dev
 51 2020-07-13T03:07:43  *** TheHoliestRoger has quit IRC
 52 2020-07-13T03:08:35  *** TheHoliestRoger has joined #bitcoin-core-dev
 53 2020-07-13T03:10:40  *** nik-j has joined #bitcoin-core-dev
 54 2020-07-13T03:14:11  *** adiabat has joined #bitcoin-core-dev
 55 2020-07-13T03:21:28  *** Relis has quit IRC
 56 2020-07-13T03:22:20  *** omega8cc has joined #bitcoin-core-dev
 57 2020-07-13T03:23:14  *** arowser has quit IRC
 58 2020-07-13T03:24:59  *** nik-j has quit IRC
 59 2020-07-13T03:26:55  *** arowser has joined #bitcoin-core-dev
 60 2020-07-13T03:30:55  *** vasild_ has joined #bitcoin-core-dev
 61 2020-07-13T03:33:09  *** arowser has quit IRC
 62 2020-07-13T03:33:38  *** arowser has joined #bitcoin-core-dev
 63 2020-07-13T03:34:23  *** vasild has quit IRC
 64 2020-07-13T03:34:24  *** vasild_ is now known as vasild
 65 2020-07-13T03:37:09  *** Dean_Guss has quit IRC
 66 2020-07-13T03:38:21  *** Dean_Guss has joined #bitcoin-core-dev
 67 2020-07-13T03:39:14  *** troygiorshev has joined #bitcoin-core-dev
 68 2020-07-13T03:41:05  *** troygiorshev has quit IRC
 69 2020-07-13T03:49:44  *** harrigan has quit IRC
 70 2020-07-13T03:52:18  *** harrigan has joined #bitcoin-core-dev
 71 2020-07-13T03:58:09  *** arowser has quit IRC
 72 2020-07-13T03:58:20  *** promag_ has quit IRC
 73 2020-07-13T03:58:46  *** arowser has joined #bitcoin-core-dev
 74 2020-07-13T03:59:00  *** promag has joined #bitcoin-core-dev
 75 2020-07-13T04:13:18  <luke-jr> I wonder if CIs should automatically detect when a lot of stuff is failing, and retest something known good previously.. then delete questionable results and pause until fixed?
 76 2020-07-13T04:24:09  <aj> it'd be nice to have an index of CI logs by failure type -- this PR failed due to X, did any others? oh, yes, everything after time T; some did, but it seems low-probability random; yes, a bunch of PRs touching this code do; nope, just yours
 77 2020-07-13T04:26:40  <luke-jr> well, that FreeBSD one seems to always fail?
 78 2020-07-13T04:28:35  <aj> "pkg: repository meta /var/db/pkg/FreeBSD.meta has wrong version 2" ? lame
 79 2020-07-13T04:29:08  <aj> cirrus-ci had some other "sysmtem is misconfigured and keeps failing" for me too
 80 2020-07-13T04:37:25  *** r8921039 has quit IRC
 81 2020-07-13T04:37:40  <kallewoof> sipa: getting "could not convert ‘(const uint8_t*)(& SIGNET_HEADER)’ from ‘const uint8_t*’ {aka ‘const unsigned char*’} to ‘Span<const unsigned char>’"
 82 2020-07-13T04:37:41  *** r8921039 has joined #bitcoin-core-dev
 83 2020-07-13T04:38:08  <sipa> just pass SIGNET_HEADER
 84 2020-07-13T04:38:11  <sipa> don't cast it to a pointer
 85 2020-07-13T04:38:25  <kallewoof> I am
 86 2020-07-13T04:38:30  <sipa> what is the code?
 87 2020-07-13T04:38:32  <kallewoof> if (!GetWitnessCommitmentSection(block, SIGNET_HEADER, signet_data)) {
 88 2020-07-13T04:38:42  <sipa> how is SIGNET_HEADER declared?
 89 2020-07-13T04:38:58  <kallewoof> static const uint8_t SIGNET_HEADER[4] = {0xec, 0xc7, 0xda, 0xa2};
 90 2020-07-13T04:39:08  <sipa> hmm!
 91 2020-07-13T04:39:13  <kallewoof> and bool GetWitnessCommitmentSection(const CBlock& block, Span<const uint8_t> header, std::vector<uint8_t>& result);
 92 2020-07-13T04:39:15  <sipa> you have a branch somewhere i can try?
 93 2020-07-13T04:40:32  <kallewoof> https://github.com/kallewoof/bitcoin/tree/signet-tmp
 94 2020-07-13T04:40:52  *** bitcoin-git has joined #bitcoin-core-dev
 95 2020-07-13T04:40:52  <bitcoin-git> [bitcoin] sipa opened pull request #19503: Add parameter feature to serialization and use it for CAddress (master...202007_ser_options) https://github.com/bitcoin/bitcoin/pull/19503
 96 2020-07-13T04:41:03  *** bitcoin-git has left #bitcoin-core-dev
 97 2020-07-13T04:41:06  <r8921039> thx meshcollider i'm also verifying with the log http://www.erisian.com.au/bitcoin-core-dev a bit delay tho
 98 2020-07-13T04:41:20  <aj> kallewoof: my patch has the span stuff already
 99 2020-07-13T04:41:40  <kallewoof> aj: is that from your two emails? I haven't gotten to those yet :) Was going there next
100 2020-07-13T04:42:19  <kallewoof> Maybe if you already have this down, sipa doesn't really have to waste his time on it tho..
101 2020-07-13T04:42:28  <aj> kallewoof: https://github.com/ajtowns/bitcoin/commit/9d4949c6beab69f088d35ad333becfa0909ac0c9#diff-4bdd7c44636dae0429a4d61909eeed17R111
102 2020-07-13T04:42:58  <kallewoof> oh, so use MakeSpan() is the solution?
103 2020-07-13T04:43:22  <aj> kallewoof: yeah, i started a review then got distracted by the stuff in those emails, then looked at the pr again and it had a half finished review so i thought "should submit that" :)
104 2020-07-13T04:43:23  <sipa> kallewoof: you should just rebase :p
105 2020-07-13T04:43:32  <sipa> you don't have the recent Span improvements that permit this
106 2020-07-13T04:43:42  <kallewoof> oh! thanks, will do
107 2020-07-13T04:46:45  *** mdunnio has joined #bitcoin-core-dev
108 2020-07-13T04:46:53  <sipa> kallewoof: specifically, you need #18468
109 2020-07-13T04:46:57  <gribble> https://github.com/bitcoin/bitcoin/issues/18468 | Span improvements by sipa · Pull Request #18468 · bitcoin/bitcoin · GitHub
110 2020-07-13T04:47:38  <kallewoof> very cool
111 2020-07-13T04:47:59  <kallewoof> we don't need new c++ standards, we'll just bake it into our codebase ourselves! :P
112 2020-07-13T04:48:21  <luke-jr> I thought this was just intended to be temporary until we upgrade?
113 2020-07-13T04:49:12  <kallewoof> I was joking, ofc, but it might be a long time before we are on C++20, I assume.
114 2020-07-13T04:49:44  <sipa> luke-jr: c++20 may take a while still
115 2020-07-13T04:49:54  <sipa> as it doesn't formally exist yet
116 2020-07-13T04:50:23  <sipa> but sure, once that's the case, obviously we don't need our own anymore (the interface is compatible)
117 2020-07-13T04:50:33  <sipa> so it should just be a search/replace pretty much
118 2020-07-13T04:51:18  <kallewoof> we are on c++11 now, though, right? or did we switch to 14 when I wasn't looking
119 2020-07-13T04:51:43  <sipa> kallewoof: currently c++11; 0.22 will be c++17
120 2020-07-13T04:51:52  <kallewoof> nice
121 2020-07-13T04:52:06  <sipa> https://github.com/bitcoin/bitcoin/issues/16684
122 2020-07-13T04:52:11  * kallewoof needs to read up on diff between 11 and 17
123 2020-07-13T04:54:05  *** mdunnio has quit IRC
124 2020-07-13T04:59:24  *** r8921039 has quit IRC
125 2020-07-13T05:00:34  *** proofofkeags has quit IRC
126 2020-07-13T05:01:09  *** proofofkeags has joined #bitcoin-core-dev
127 2020-07-13T05:03:21  *** r8921039 has joined #bitcoin-core-dev
128 2020-07-13T05:05:14  *** proofofkeags has quit IRC
129 2020-07-13T05:26:37  *** bitcoin-git has joined #bitcoin-core-dev
130 2020-07-13T05:26:37  <bitcoin-git> [bitcoin] ajtowns opened pull request #19504: Bump minimum python version to 3.6 (master...202007-python3.6) https://github.com/bitcoin/bitcoin/pull/19504
131 2020-07-13T05:26:38  *** bitcoin-git has left #bitcoin-core-dev
132 2020-07-13T05:29:16  *** gleb has joined #bitcoin-core-dev
133 2020-07-13T05:34:58  *** proofofkeags has joined #bitcoin-core-dev
134 2020-07-13T05:41:48  *** proofofkeags has quit IRC
135 2020-07-13T05:59:32  *** arowser has quit IRC
136 2020-07-13T05:59:54  *** jonatack has quit IRC
137 2020-07-13T06:00:01  *** omega8cc has quit IRC
138 2020-07-13T06:00:35  *** arowser has joined #bitcoin-core-dev
139 2020-07-13T06:08:00  *** arowser has quit IRC
140 2020-07-13T06:08:28  *** arowser has joined #bitcoin-core-dev
141 2020-07-13T06:23:07  *** jarthur has quit IRC
142 2020-07-13T06:29:19  *** arowser has quit IRC
143 2020-07-13T06:37:24  *** vincenzopalazzo has joined #bitcoin-core-dev
144 2020-07-13T06:38:05  *** r8921039 has quit IRC
145 2020-07-13T06:41:30  *** arowser has joined #bitcoin-core-dev
146 2020-07-13T06:59:06  *** marcoagner has joined #bitcoin-core-dev
147 2020-07-13T07:11:28  *** arowser has quit IRC
148 2020-07-13T07:12:33  *** Guyver2 has joined #bitcoin-core-dev
149 2020-07-13T07:23:36  *** arowser has joined #bitcoin-core-dev
150 2020-07-13T07:29:52  *** lcb1 has joined #bitcoin-core-dev
151 2020-07-13T07:39:11  *** proofofkeags has joined #bitcoin-core-dev
152 2020-07-13T07:48:34  *** proofofkeags has quit IRC
153 2020-07-13T07:53:12  *** arowser has quit IRC
154 2020-07-13T07:53:30  *** arowser has joined #bitcoin-core-dev
155 2020-07-13T07:57:47  *** kljasdfvv has joined #bitcoin-core-dev
156 2020-07-13T07:58:21  *** Pavlenex has joined #bitcoin-core-dev
157 2020-07-13T08:15:33  *** jonatack has joined #bitcoin-core-dev
158 2020-07-13T08:25:47  <jnewbery> MarcoFalke wumpus fanquake: now that github is up again, I think #19109 and #19486 are Ready For Merge
159 2020-07-13T08:25:50  <gribble> https://github.com/bitcoin/bitcoin/issues/19109 | Only allow getdata of recently announced invs by sipa · Pull Request #19109 · bitcoin/bitcoin · GitHub
160 2020-07-13T08:25:51  <gribble> https://github.com/bitcoin/bitcoin/issues/19486 | Remove unused constants `CADDR_TIME_VERSION` and `GETHEADERS_VERSION` by jnewbery · Pull Request #19486 · bitcoin/bitcoin · GitHub
161 2020-07-13T08:34:28  *** bitcoin-git has joined #bitcoin-core-dev
162 2020-07-13T08:34:29  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4db44acf2d5d...631284f09a18
163 2020-07-13T08:34:30  <bitcoin-git> bitcoin/master 37a934e John Newbery: [protocol] Remove unused CADDR_TIME_VERSION
164 2020-07-13T08:34:31  <bitcoin-git> bitcoin/master 7bb6f9b John Newbery: [protocol] Remove unused GETHEADERS_VERSION
165 2020-07-13T08:34:32  <bitcoin-git> bitcoin/master 631284f MarcoFalke: Merge #19486: Remove unused constants `CADDR_TIME_VERSION` and `GETHEADERS...
166 2020-07-13T08:34:33  *** bitcoin-git has left #bitcoin-core-dev
167 2020-07-13T08:34:48  *** bitcoin-git has joined #bitcoin-core-dev
168 2020-07-13T08:34:48  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19486: Remove unused constants `CADDR_TIME_VERSION` and `GETHEADERS_VERSION` (master...pr14033.1) https://github.com/bitcoin/bitcoin/pull/19486
169 2020-07-13T08:34:49  *** bitcoin-git has left #bitcoin-core-dev
170 2020-07-13T08:35:40  *** dr-orlovsky has joined #bitcoin-core-dev
171 2020-07-13T08:37:39  *** bitcoin-git has joined #bitcoin-core-dev
172 2020-07-13T08:37:39  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/631284f09a18...d52bfc491617
173 2020-07-13T08:37:40  <bitcoin-git> bitcoin/master e74cd20 Hennadii Stepanov: qt, refactor: Cleanup ModalOverlay slots
174 2020-07-13T08:37:40  <bitcoin-git> bitcoin/master d0cc1f6 Hennadii Stepanov: qt: Disable toolbar when overlay is shown
175 2020-07-13T08:37:41  <bitcoin-git> bitcoin/master d52bfc4 MarcoFalke: Merge bitcoin-core/gui#30: Disable the main window toolbar when the modal ...
176 2020-07-13T08:37:42  *** bitcoin-git has left #bitcoin-core-dev
177 2020-07-13T08:44:22  *** hsmiths has quit IRC
178 2020-07-13T08:45:22  <MarcoFalke> wumpus: Mind to activate cirrus ci for the qa-assets repo ( https://github.com/apps/cirrus-ci/installations/9863527 ) ?
179 2020-07-13T08:46:01  *** dr-orlovsky has quit IRC
180 2020-07-13T08:48:12  *** Pavlenex has quit IRC
181 2020-07-13T08:50:05  *** dr-orlovsky has joined #bitcoin-core-dev
182 2020-07-13T08:50:45  *** Pavlenex has joined #bitcoin-core-dev
183 2020-07-13T08:54:01  *** proofofkeags has joined #bitcoin-core-dev
184 2020-07-13T08:58:35  *** proofofkeags has quit IRC
185 2020-07-13T09:00:02  *** lcb1 has quit IRC
186 2020-07-13T09:02:53  *** dr_orlovsky has joined #bitcoin-core-dev
187 2020-07-13T09:06:02  *** dr-orlovsky has quit IRC
188 2020-07-13T09:10:43  *** Pavlenex has quit IRC
189 2020-07-13T09:10:55  *** davec has quit IRC
190 2020-07-13T09:12:32  *** davec has joined #bitcoin-core-dev
191 2020-07-13T09:13:11  *** arowser has quit IRC
192 2020-07-13T09:13:30  *** arowser has joined #bitcoin-core-dev
193 2020-07-13T09:18:59  *** dr_orlovsky has quit IRC
194 2020-07-13T09:20:59  *** hollisb has joined #bitcoin-core-dev
195 2020-07-13T09:21:02  *** dr-orlovsky has joined #bitcoin-core-dev
196 2020-07-13T09:22:23  *** dr-orlovsky has quit IRC
197 2020-07-13T09:23:30  *** Pavlenex has joined #bitcoin-core-dev
198 2020-07-13T09:31:26  *** promag_ has joined #bitcoin-core-dev
199 2020-07-13T09:31:35  *** promag has quit IRC
200 2020-07-13T09:31:51  *** promag has joined #bitcoin-core-dev
201 2020-07-13T09:34:18  *** promag_ has quit IRC
202 2020-07-13T09:37:18  *** dr-orlovsky has joined #bitcoin-core-dev
203 2020-07-13T09:46:20  *** Pavlenex has quit IRC
204 2020-07-13T09:53:03  *** Relis has joined #bitcoin-core-dev
205 2020-07-13T09:57:40  <vasild> sipa: MarcoFalke: Is there a reason to avoid `auto` in e.g. `auto var = FuncFoo();` and to prefer writing the type explicitly in some cases?
206 2020-07-13T09:58:20  <vasild> Or is it just a matter of "taste"?
207 2020-07-13T09:58:43  <hebasto> vasild: https://herbsutter.com/2013/08/12/gotw-94-solution-aaa-style-almost-always-auto/
208 2020-07-13T10:00:23  *** Guyver2_ has joined #bitcoin-core-dev
209 2020-07-13T10:00:39  <jonatack> steve meyers' effective c++ books generally recommended auto, but for consensus-critical bitcoin code i have observed a preference for explicit typing in some reviews and by some authors
210 2020-07-13T10:02:02  *** Guyver2 has quit IRC
211 2020-07-13T10:03:28  *** Aglae79Barton has joined #bitcoin-core-dev
212 2020-07-13T10:09:01  <jonatack> just came across https://josephmansfield.uk/articles/dont-use-auto-unless-you-mean-it.html
213 2020-07-13T10:09:54  *** vasild has quit IRC
214 2020-07-13T10:10:17  *** vasild has joined #bitcoin-core-dev
215 2020-07-13T10:10:20  *** Aglae79Barton has quit IRC
216 2020-07-13T10:13:51  *** r8921039 has joined #bitcoin-core-dev
217 2020-07-13T10:18:00  *** r8921039 has quit IRC
218 2020-07-13T10:21:26  *** arowser has quit IRC
219 2020-07-13T10:23:35  *** arowser has joined #bitcoin-core-dev
220 2020-07-13T10:25:08  *** AaronvanW has joined #bitcoin-core-dev
221 2020-07-13T10:32:43  *** morcos has quit IRC
222 2020-07-13T10:33:52  *** morcos has joined #bitcoin-core-dev
223 2020-07-13T10:37:03  *** r8921039 has joined #bitcoin-core-dev
224 2020-07-13T10:45:11  *** Guyver2__ has joined #bitcoin-core-dev
225 2020-07-13T10:48:13  *** Guyver2_ has quit IRC
226 2020-07-13T10:53:04  *** belcher_ has joined #bitcoin-core-dev
227 2020-07-13T10:53:57  *** promag_ has joined #bitcoin-core-dev
228 2020-07-13T10:56:10  *** belcher has quit IRC
229 2020-07-13T11:01:29  *** jonatack has quit IRC
230 2020-07-13T11:01:29  *** r8921039 has quit IRC
231 2020-07-13T11:03:26  *** davec has quit IRC
232 2020-07-13T11:07:09  *** arowser has quit IRC
233 2020-07-13T11:07:34  *** arowser has joined #bitcoin-core-dev
234 2020-07-13T11:09:59  *** davec has joined #bitcoin-core-dev
235 2020-07-13T11:22:38  *** dr-orlovsky has quit IRC
236 2020-07-13T11:27:50  *** mdunnio has joined #bitcoin-core-dev
237 2020-07-13T11:32:25  *** mdunnio has quit IRC
238 2020-07-13T11:33:16  *** promag has quit IRC
239 2020-07-13T11:33:50  *** promag has joined #bitcoin-core-dev
240 2020-07-13T11:35:23  *** promag has quit IRC
241 2020-07-13T11:35:39  *** promag has joined #bitcoin-core-dev
242 2020-07-13T11:43:21  *** proofofkeags has joined #bitcoin-core-dev
243 2020-07-13T11:43:32  *** dr-orlovsky has joined #bitcoin-core-dev
244 2020-07-13T11:46:40  *** lehnberg has joined #bitcoin-core-dev
245 2020-07-13T11:47:59  *** proofofkeags has quit IRC
246 2020-07-13T12:00:01  *** hollisb has quit IRC
247 2020-07-13T12:10:28  *** promag has quit IRC
248 2020-07-13T12:10:57  *** promag has joined #bitcoin-core-dev
249 2020-07-13T12:15:27  *** promag has quit IRC
250 2020-07-13T12:15:38  *** mdunnio has joined #bitcoin-core-dev
251 2020-07-13T12:16:08  *** promag has joined #bitcoin-core-dev
252 2020-07-13T12:17:38  *** bitdex has quit IRC
253 2020-07-13T12:18:08  *** bitcoin-git has joined #bitcoin-core-dev
254 2020-07-13T12:18:09  <bitcoin-git> [bitcoin] Mr-Leshiy opened pull request #19505: ProcessHeadersMessage() fix potential bug (master...ProcessHeadersMessage/fix_bug) https://github.com/bitcoin/bitcoin/pull/19505
255 2020-07-13T12:18:10  *** bitcoin-git has left #bitcoin-core-dev
256 2020-07-13T12:19:51  *** dr-orlovsky has quit IRC
257 2020-07-13T12:20:12  *** AIM has joined #bitcoin-core-dev
258 2020-07-13T12:26:31  *** nik-j has joined #bitcoin-core-dev
259 2020-07-13T12:26:59  *** rabidus has quit IRC
260 2020-07-13T12:27:01  *** r8921039 has joined #bitcoin-core-dev
261 2020-07-13T12:27:25  *** rabidus has joined #bitcoin-core-dev
262 2020-07-13T12:29:33  *** bitcoin-git has joined #bitcoin-core-dev
263 2020-07-13T12:29:34  <bitcoin-git> [bitcoin] Mr-Leshiy closed pull request #19505: ProcessHeadersMessage() fix potential bug (master...ProcessHeadersMessage/fix_bug) https://github.com/bitcoin/bitcoin/pull/19505
264 2020-07-13T12:29:35  *** bitcoin-git has left #bitcoin-core-dev
265 2020-07-13T12:30:16  *** troygiorshev has joined #bitcoin-core-dev
266 2020-07-13T12:30:16  *** hsmiths has joined #bitcoin-core-dev
267 2020-07-13T12:31:25  *** nik-j has quit IRC
268 2020-07-13T12:38:22  *** r8921039 has quit IRC
269 2020-07-13T12:42:24  *** proofofkeags has joined #bitcoin-core-dev
270 2020-07-13T12:46:34  *** proofofkeags has quit IRC
271 2020-07-13T12:49:26  *** r8921039 has joined #bitcoin-core-dev
272 2020-07-13T12:50:06  *** harrigan has quit IRC
273 2020-07-13T12:51:00  *** Highway61 has joined #bitcoin-core-dev
274 2020-07-13T12:52:19  *** krvopije has joined #bitcoin-core-dev
275 2020-07-13T12:53:30  *** promag has quit IRC
276 2020-07-13T12:53:30  *** r8921039 has quit IRC
277 2020-07-13T12:53:42  *** promag has joined #bitcoin-core-dev
278 2020-07-13T12:54:14  <elichai2> jonatack: personally I think auto is great for iterators and other complex types where you don't really care about the type, but I find it harder to reason about things like auto return type, especially the way it can interact with implicit constructors
279 2020-07-13T12:55:24  *** krvopije has quit IRC
280 2020-07-13T12:57:21  *** polylunar has joined #bitcoin-core-dev
281 2020-07-13T13:00:42  *** Highway61 has quit IRC
282 2020-07-13T13:02:33  *** goosie has joined #bitcoin-core-dev
283 2020-07-13T13:07:13  *** arowser has quit IRC
284 2020-07-13T13:07:40  *** arowser has joined #bitcoin-core-dev
285 2020-07-13T13:09:14  *** arowser has quit IRC
286 2020-07-13T13:09:42  *** arowser has joined #bitcoin-core-dev
287 2020-07-13T13:10:15  *** arowser has quit IRC
288 2020-07-13T13:10:33  *** arowser has joined #bitcoin-core-dev
289 2020-07-13T13:12:16  *** Highway61 has joined #bitcoin-core-dev
290 2020-07-13T13:13:08  *** Pavlenex has joined #bitcoin-core-dev
291 2020-07-13T13:13:13  *** arowser has quit IRC
292 2020-07-13T13:13:59  *** arowser has joined #bitcoin-core-dev
293 2020-07-13T13:14:27  *** nik-j has joined #bitcoin-core-dev
294 2020-07-13T13:15:11  *** arowser has quit IRC
295 2020-07-13T13:15:41  *** arowser has joined #bitcoin-core-dev
296 2020-07-13T13:16:09  *** arowser has quit IRC
297 2020-07-13T13:16:38  *** arowser has joined #bitcoin-core-dev
298 2020-07-13T13:26:38  *** mdunnio has quit IRC
299 2020-07-13T13:27:36  *** mdunnio_ has joined #bitcoin-core-dev
300 2020-07-13T13:27:43  *** nik-j has quit IRC
301 2020-07-13T13:27:44  *** promag has quit IRC
302 2020-07-13T13:27:44  *** davec has quit IRC
303 2020-07-13T13:27:44  *** adiabat has quit IRC
304 2020-07-13T13:27:44  *** TheHoliestRoger has quit IRC
305 2020-07-13T13:27:44  *** joerodgers has quit IRC
306 2020-07-13T13:27:44  *** pinheadmz has quit IRC
307 2020-07-13T13:27:44  *** meshcollider has quit IRC
308 2020-07-13T13:27:44  *** victorSN has quit IRC
309 2020-07-13T13:27:44  *** treyzania has quit IRC
310 2020-07-13T13:27:44  *** takinbo has quit IRC
311 2020-07-13T13:27:44  *** isis_ has quit IRC
312 2020-07-13T13:27:44  *** hadjiszs_ has quit IRC
313 2020-07-13T13:27:44  *** DougieBot5000 has quit IRC
314 2020-07-13T13:27:44  *** waxwing has quit IRC
315 2020-07-13T13:27:44  *** tynes_ has quit IRC
316 2020-07-13T13:27:44  *** wraithm has quit IRC
317 2020-07-13T13:28:16  *** nik-j has joined #bitcoin-core-dev
318 2020-07-13T13:28:16  *** promag has joined #bitcoin-core-dev
319 2020-07-13T13:28:16  *** davec has joined #bitcoin-core-dev
320 2020-07-13T13:28:16  *** adiabat has joined #bitcoin-core-dev
321 2020-07-13T13:28:16  *** TheHoliestRoger has joined #bitcoin-core-dev
322 2020-07-13T13:28:16  *** joerodgers has joined #bitcoin-core-dev
323 2020-07-13T13:28:16  *** pinheadmz has joined #bitcoin-core-dev
324 2020-07-13T13:28:16  *** meshcollider has joined #bitcoin-core-dev
325 2020-07-13T13:28:16  *** victorSN has joined #bitcoin-core-dev
326 2020-07-13T13:28:16  *** treyzania has joined #bitcoin-core-dev
327 2020-07-13T13:28:16  *** takinbo has joined #bitcoin-core-dev
328 2020-07-13T13:28:16  *** isis_ has joined #bitcoin-core-dev
329 2020-07-13T13:28:16  *** hadjiszs_ has joined #bitcoin-core-dev
330 2020-07-13T13:28:16  *** DougieBot5000 has joined #bitcoin-core-dev
331 2020-07-13T13:28:16  *** waxwing has joined #bitcoin-core-dev
332 2020-07-13T13:28:16  *** tynes_ has joined #bitcoin-core-dev
333 2020-07-13T13:28:16  *** wraithm has joined #bitcoin-core-dev
334 2020-07-13T13:29:48  <fjahr> Can someone kick Travis for me on #19055? One job just didn't start...
335 2020-07-13T13:29:51  <gribble> https://github.com/bitcoin/bitcoin/issues/19055 | Add MuHash3072 implementation by fjahr · Pull Request #19055 · bitcoin/bitcoin · GitHub
336 2020-07-13T13:32:31  *** polylunar has quit IRC
337 2020-07-13T13:33:27  <wumpus> MarcoFalke: the Cirrus CI should be approved now
338 2020-07-13T13:33:40  <instagibbs> elichai2, ack, mostly use it for iterators. I find it generally more confusing otherwise for review
339 2020-07-13T13:33:45  <fjahr> Not sure if I should be able to do it myself but I am not seeing the restart button. I remember others having similar issues.
340 2020-07-13T13:34:20  <fjahr> I can restart AppVeyor for example
341 2020-07-13T13:34:46  <wumpus> fjahr: restarted
342 2020-07-13T13:34:58  <fjahr> wumpus: thanks!
343 2020-07-13T13:35:37  <wumpus> I think to restart travis runs you need write access to the repository
344 2020-07-13T13:36:45  <fjahr> Ok :)
345 2020-07-13T13:55:43  *** r8921039 has joined #bitcoin-core-dev
346 2020-07-13T14:00:26  *** Davterra has joined #bitcoin-core-dev
347 2020-07-13T14:05:03  *** AaronvanW has quit IRC
348 2020-07-13T14:07:13  *** r8921039 has quit IRC
349 2020-07-13T14:10:22  *** harrigan has joined #bitcoin-core-dev
350 2020-07-13T14:10:52  *** Davterra has quit IRC
351 2020-07-13T14:11:10  *** Davterra has joined #bitcoin-core-dev
352 2020-07-13T14:11:17  *** ajonas has joined #bitcoin-core-dev
353 2020-07-13T14:14:17  *** Tralfaz has joined #bitcoin-core-dev
354 2020-07-13T14:16:26  *** Davterra has quit IRC
355 2020-07-13T14:22:35  *** jonatack has joined #bitcoin-core-dev
356 2020-07-13T14:25:11  *** r8921039 has joined #bitcoin-core-dev
357 2020-07-13T14:30:53  *** mdunnio_ has quit IRC
358 2020-07-13T14:35:43  *** mdunnio has joined #bitcoin-core-dev
359 2020-07-13T14:39:49  *** instagibbs has quit IRC
360 2020-07-13T14:40:35  *** instagibbs has joined #bitcoin-core-dev
361 2020-07-13T14:43:21  *** proofofkeags has joined #bitcoin-core-dev
362 2020-07-13T14:48:35  *** proofofkeags has quit IRC
363 2020-07-13T14:54:14  *** arowser has quit IRC
364 2020-07-13T14:54:38  *** arowser has joined #bitcoin-core-dev
365 2020-07-13T14:55:11  *** wrq352345ysxcasd has joined #bitcoin-core-dev
366 2020-07-13T14:55:16  *** wrq352345ysxcasd has left #bitcoin-core-dev
367 2020-07-13T14:58:22  *** joerodgers1 has joined #bitcoin-core-dev
368 2020-07-13T15:00:01  *** AIM has quit IRC
369 2020-07-13T15:01:41  *** joerodgers has quit IRC
370 2020-07-13T15:01:41  *** joerodgers1 is now known as joerodgers
371 2020-07-13T15:03:41  *** proofofkeags has joined #bitcoin-core-dev
372 2020-07-13T15:06:16  *** arowser has quit IRC
373 2020-07-13T15:06:40  *** arowser has joined #bitcoin-core-dev
374 2020-07-13T15:12:25  *** kinlo has quit IRC
375 2020-07-13T15:14:11  *** kinlo has joined #bitcoin-core-dev
376 2020-07-13T15:16:13  *** arowser has quit IRC
377 2020-07-13T15:16:42  *** arowser has joined #bitcoin-core-dev
378 2020-07-13T15:20:14  *** Relis has quit IRC
379 2020-07-13T15:23:20  *** r8921039 has quit IRC
380 2020-07-13T15:26:09  *** arowser has quit IRC
381 2020-07-13T15:26:37  *** arowser has joined #bitcoin-core-dev
382 2020-07-13T15:31:01  *** vasild_ has joined #bitcoin-core-dev
383 2020-07-13T15:31:42  *** Relis has joined #bitcoin-core-dev
384 2020-07-13T15:33:13  *** justanotheruser has quit IRC
385 2020-07-13T15:34:43  *** vasild has quit IRC
386 2020-07-13T15:34:44  *** vasild_ is now known as vasild
387 2020-07-13T15:42:14  *** proofofkeags has quit IRC
388 2020-07-13T15:42:51  *** proofofkeags has joined #bitcoin-core-dev
389 2020-07-13T15:44:32  *** promag has quit IRC
390 2020-07-13T15:45:16  *** promag has joined #bitcoin-core-dev
391 2020-07-13T15:47:33  *** proofofkeags has quit IRC
392 2020-07-13T15:54:13  *** arowser has quit IRC
393 2020-07-13T15:54:21  *** justanotheruser has joined #bitcoin-core-dev
394 2020-07-13T15:54:32  *** arowser has joined #bitcoin-core-dev
395 2020-07-13T15:55:51  *** dlareg1 has joined #bitcoin-core-dev
396 2020-07-13T16:11:17  *** dviola has quit IRC
397 2020-07-13T16:13:40  *** Pavlenex has quit IRC
398 2020-07-13T16:14:54  *** troygiorshev has quit IRC
399 2020-07-13T16:19:42  <jonatack> elichai2: thanks, seems sensible
400 2020-07-13T16:20:43  *** troygiorshev has joined #bitcoin-core-dev
401 2020-07-13T16:21:07  *** belcher_ has quit IRC
402 2020-07-13T16:22:50  *** Talkless has joined #bitcoin-core-dev
403 2020-07-13T16:33:34  *** bitcoin-git has joined #bitcoin-core-dev
404 2020-07-13T16:33:37  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d52bfc491617...37485baa2751
405 2020-07-13T16:33:37  <bitcoin-git> bitcoin/master faa3d2e MarcoFalke: doc: Remove release notes of backports
406 2020-07-13T16:33:37  <bitcoin-git> bitcoin/master fa740d4 MarcoFalke: doc: move-only release notes
407 2020-07-13T16:33:38  <bitcoin-git> bitcoin/master 37485ba Wladimir J. van der Laan: Merge #19483: doc: Merge release notes
408 2020-07-13T16:33:40  *** bitcoin-git has left #bitcoin-core-dev
409 2020-07-13T16:33:54  *** bitcoin-git has joined #bitcoin-core-dev
410 2020-07-13T16:33:55  <bitcoin-git> [bitcoin] laanwj merged pull request #19483: doc: Merge release notes (master...2007-docRel) https://github.com/bitcoin/bitcoin/pull/19483
411 2020-07-13T16:33:56  *** bitcoin-git has left #bitcoin-core-dev
412 2020-07-13T16:38:47  *** jarthur has joined #bitcoin-core-dev
413 2020-07-13T16:40:12  *** arowser has quit IRC
414 2020-07-13T16:40:31  *** arowser has joined #bitcoin-core-dev
415 2020-07-13T16:41:54  *** joerodgers has quit IRC
416 2020-07-13T16:42:16  *** joerodgers has joined #bitcoin-core-dev
417 2020-07-13T16:49:22  *** AaronvanW has joined #bitcoin-core-dev
418 2020-07-13T17:04:03  *** Pavlenex has joined #bitcoin-core-dev
419 2020-07-13T17:10:37  *** Pavlenex has quit IRC
420 2020-07-13T17:14:27  *** ghost43 has quit IRC
421 2020-07-13T17:14:43  *** jb55 has quit IRC
422 2020-07-13T17:14:45  *** ghost43 has joined #bitcoin-core-dev
423 2020-07-13T17:15:24  *** AaronvanW has quit IRC
424 2020-07-13T17:15:36  *** jb55 has joined #bitcoin-core-dev
425 2020-07-13T17:15:42  *** AaronvanW has joined #bitcoin-core-dev
426 2020-07-13T17:22:51  *** proofofkeags has joined #bitcoin-core-dev
427 2020-07-13T17:40:14  *** BGL has quit IRC
428 2020-07-13T18:00:02  *** dlareg1 has quit IRC
429 2020-07-13T18:17:47  *** mol_ has joined #bitcoin-core-dev
430 2020-07-13T18:17:52  *** gleb has quit IRC
431 2020-07-13T18:18:33  *** Pavlenex has joined #bitcoin-core-dev
432 2020-07-13T18:20:23  *** CareBearemcho has joined #bitcoin-core-dev
433 2020-07-13T18:20:45  *** Pavlenex has quit IRC
434 2020-07-13T18:20:48  *** mol has quit IRC
435 2020-07-13T18:23:08  *** troygiorshev has quit IRC
436 2020-07-13T18:25:18  *** troygiorshev has joined #bitcoin-core-dev
437 2020-07-13T18:48:07  *** bitcoin-git has joined #bitcoin-core-dev
438 2020-07-13T18:48:08  <bitcoin-git> [bitcoin] instagibbs opened pull request #19507: Expand functional zmq transaction tests (master...zmq_testing) https://github.com/bitcoin/bitcoin/pull/19507
439 2020-07-13T18:48:09  *** bitcoin-git has left #bitcoin-core-dev
440 2020-07-13T18:52:59  *** lehnberg has quit IRC
441 2020-07-13T18:55:40  *** CareBearemcho has quit IRC
442 2020-07-13T19:04:52  *** BGL has joined #bitcoin-core-dev
443 2020-07-13T19:11:21  *** belcher has joined #bitcoin-core-dev
444 2020-07-13T19:12:22  *** brianhoffman has quit IRC
445 2020-07-13T19:12:28  *** Talkless has quit IRC
446 2020-07-13T19:12:54  *** Guyver2_ has joined #bitcoin-core-dev
447 2020-07-13T19:13:24  *** Guyver2_ is now known as Guyver2
448 2020-07-13T19:14:52  *** proofofkeags has quit IRC
449 2020-07-13T19:15:40  *** Guyver2__ has quit IRC
450 2020-07-13T19:17:15  *** Chris_Stewart_5 has joined #bitcoin-core-dev
451 2020-07-13T19:21:35  *** proofofkeags has joined #bitcoin-core-dev
452 2020-07-13T19:23:29  *** kristapsk has joined #bitcoin-core-dev
453 2020-07-13T19:25:45  *** dr-orlovsky has joined #bitcoin-core-dev
454 2020-07-13T19:26:54  *** Evel-Knievel has quit IRC
455 2020-07-13T19:27:24  *** Evel-Knievel has joined #bitcoin-core-dev
456 2020-07-13T19:28:48  *** owowo has quit IRC
457 2020-07-13T19:29:23  *** Highway61 has quit IRC
458 2020-07-13T19:33:27  *** owowo has joined #bitcoin-core-dev
459 2020-07-13T19:33:27  *** owowo has joined #bitcoin-core-dev
460 2020-07-13T19:34:51  *** Pavlenex has joined #bitcoin-core-dev
461 2020-07-13T19:37:41  *** justanotheruser has quit IRC
462 2020-07-13T19:38:13  *** promag has quit IRC
463 2020-07-13T19:38:25  *** promag has joined #bitcoin-core-dev
464 2020-07-13T19:48:15  *** Pavlenex has quit IRC
465 2020-07-13T19:52:28  *** dr-orlovsky has quit IRC
466 2020-07-13T19:56:32  *** DJWillis has joined #bitcoin-core-dev
467 2020-07-13T19:59:50  *** proofofkeags has quit IRC
468 2020-07-13T20:00:18  *** proofofkeags has joined #bitcoin-core-dev
469 2020-07-13T20:01:06  *** bitcoin-git has joined #bitcoin-core-dev
470 2020-07-13T20:01:06  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19508: Work around memory-aliasing in descriptor ParsePubkey (master...2007-noAliasMemDesc) https://github.com/bitcoin/bitcoin/pull/19508
471 2020-07-13T20:01:07  *** bitcoin-git has left #bitcoin-core-dev
472 2020-07-13T20:07:16  *** Highway61 has joined #bitcoin-core-dev
473 2020-07-13T20:15:20  *** proofofkeags has quit IRC
474 2020-07-13T20:15:47  *** proofofkeags has joined #bitcoin-core-dev
475 2020-07-13T20:16:00  *** Highway62 has joined #bitcoin-core-dev
476 2020-07-13T20:17:01  *** Highway61 has quit IRC
477 2020-07-13T20:17:02  *** Highway62 is now known as Highway61
478 2020-07-13T20:20:02  *** proofofkeags has quit IRC
479 2020-07-13T20:20:36  *** lnostdal has joined #bitcoin-core-dev
480 2020-07-13T20:22:36  *** goosie has quit IRC
481 2020-07-13T20:23:23  *** Relis has quit IRC
482 2020-07-13T20:31:27  *** csknk has joined #bitcoin-core-dev
483 2020-07-13T20:31:27  *** csknk has quit IRC
484 2020-07-13T20:31:50  *** Relis has joined #bitcoin-core-dev
485 2020-07-13T20:32:44  *** proofofkeags has joined #bitcoin-core-dev
486 2020-07-13T20:33:27  *** justanotheruser has joined #bitcoin-core-dev
487 2020-07-13T20:35:14  *** promag has quit IRC
488 2020-07-13T20:35:50  *** promag has joined #bitcoin-core-dev
489 2020-07-13T20:39:38  *** dr-orlovsky has joined #bitcoin-core-dev
490 2020-07-13T20:49:01  *** Guyver2 has quit IRC
491 2020-07-13T20:56:22  *** tryphe has quit IRC
492 2020-07-13T20:56:46  *** tryphe has joined #bitcoin-core-dev
493 2020-07-13T21:00:02  *** DJWillis has quit IRC
494 2020-07-13T21:00:58  *** dr-orlovsky has quit IRC
495 2020-07-13T21:18:44  *** nik-j has quit IRC
496 2020-07-13T21:19:17  *** nik-j has joined #bitcoin-core-dev
497 2020-07-13T21:20:35  *** schwuk has joined #bitcoin-core-dev
498 2020-07-13T21:23:34  *** nik-j has quit IRC
499 2020-07-13T21:35:55  *** proofofkeags has quit IRC
500 2020-07-13T21:36:22  *** proofofkeags has joined #bitcoin-core-dev
501 2020-07-13T21:40:44  *** proofofkeags has quit IRC
502 2020-07-13T21:48:23  *** mdunnio has quit IRC
503 2020-07-13T21:48:35  *** jb55 has quit IRC
504 2020-07-13T21:48:35  *** sdaftuar_ has quit IRC
505 2020-07-13T21:48:59  *** sdaftuar_ has joined #bitcoin-core-dev
506 2020-07-13T21:49:05  *** jb55 has joined #bitcoin-core-dev
507 2020-07-13T21:57:04  *** nik-j has joined #bitcoin-core-dev
508 2020-07-13T22:01:23  *** marcoagner has quit IRC
509 2020-07-13T22:03:13  *** nik-j has quit IRC
510 2020-07-13T22:05:02  *** sdaftuar_ has quit IRC
511 2020-07-13T22:05:29  *** sdaftuar_ has joined #bitcoin-core-dev
512 2020-07-13T22:08:32  *** justanotheruser has quit IRC
513 2020-07-13T22:11:51  *** isis_ is now known as isis
514 2020-07-13T22:20:59  *** vincenzopalazzo has joined #bitcoin-core-dev
515 2020-07-13T22:24:07  *** justanotheruser has joined #bitcoin-core-dev
516 2020-07-13T22:27:41  *** pinheadmz has quit IRC
517 2020-07-13T22:31:19  *** nik-j has joined #bitcoin-core-dev
518 2020-07-13T22:31:59  *** Tralfaz has quit IRC
519 2020-07-13T22:43:22  *** nik-j has quit IRC
520 2020-07-13T22:58:12  *** isis is now known as isis_
521 2020-07-13T23:04:08  *** jarthur has quit IRC
522 2020-07-13T23:06:25  *** promag has quit IRC
523 2020-07-13T23:06:39  *** promag has joined #bitcoin-core-dev
524 2020-07-13T23:09:47  *** bitcoin-git has joined #bitcoin-core-dev
525 2020-07-13T23:09:47  <bitcoin-git> [bitcoin] kallewoof closed pull request #18265: build: add data.h dependency to raw files (master...2003-makefile-bench-data) https://github.com/bitcoin/bitcoin/pull/18265
526 2020-07-13T23:09:48  *** bitcoin-git has left #bitcoin-core-dev
527 2020-07-13T23:11:53  <kallewoof> wumpus: nah, i can restart travis builds and i'm readonly
528 2020-07-13T23:12:04  <kallewoof> fjahr: sometimes you have to log out and back in. a bug i think
529 2020-07-13T23:12:53  *** bitdex has joined #bitcoin-core-dev
530 2020-07-13T23:23:47  *** Relis has quit IRC
531 2020-07-13T23:24:31  *** jarthur has joined #bitcoin-core-dev
532 2020-07-13T23:27:45  *** Relis has joined #bitcoin-core-dev
533 2020-07-13T23:33:54  *** Bullit has joined #bitcoin-core-dev
534 2020-07-13T23:41:13  *** proofofkeags has joined #bitcoin-core-dev