1 2020-07-24T00:00:01  *** voet has quit IRC
  2 2020-07-24T00:11:38  *** promag has joined #bitcoin-core-dev
  3 2020-07-24T00:14:19  *** sipsorcery has quit IRC
  4 2020-07-24T00:20:33  *** grubles has quit IRC
  5 2020-07-24T00:20:42  *** Dragavnir has joined #bitcoin-core-dev
  6 2020-07-24T00:20:48  *** grubles has joined #bitcoin-core-dev
  7 2020-07-24T00:32:29  *** promag has quit IRC
  8 2020-07-24T00:36:17  *** arowser has quit IRC
  9 2020-07-24T00:36:35  *** arowser has joined #bitcoin-core-dev
 10 2020-07-24T00:40:21  *** CubicEarth has quit IRC
 11 2020-07-24T00:41:28  *** S3RK has joined #bitcoin-core-dev
 12 2020-07-24T00:42:15  *** CubicEarth has joined #bitcoin-core-dev
 13 2020-07-24T00:52:06  *** kristapsk_ has joined #bitcoin-core-dev
 14 2020-07-24T00:52:20  *** jarthur has quit IRC
 15 2020-07-24T00:53:23  *** kristapsk has quit IRC
 16 2020-07-24T00:55:45  *** S3RK has quit IRC
 17 2020-07-24T00:56:43  *** kristapsk_ has quit IRC
 18 2020-07-24T00:58:26  *** bitcoin-git has joined #bitcoin-core-dev
 19 2020-07-24T00:58:26  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f4cfa6d01900...007e15dcd7f8
 20 2020-07-24T00:58:27  <bitcoin-git> bitcoin/master ef3d4ce fanquake: build: call AC_PATH_TOOL for dsymutil in macOS cross-compile
 21 2020-07-24T00:58:28  <bitcoin-git> bitcoin/master 007e15d fanquake: Merge #19565: build: call AC_PATH_TOOL for dsymutil in macOS cross-compile...
 22 2020-07-24T00:58:29  *** bitcoin-git has left #bitcoin-core-dev
 23 2020-07-24T00:58:46  *** bitcoin-git has joined #bitcoin-core-dev
 24 2020-07-24T00:58:46  <bitcoin-git> [bitcoin] fanquake merged pull request #19565: build: call AC_PATH_TOOL for dsymutil in macOS cross-compile (master...cant_find_dsymutil) https://github.com/bitcoin/bitcoin/pull/19565
 25 2020-07-24T00:58:47  *** bitcoin-git has left #bitcoin-core-dev
 26 2020-07-24T01:01:02  *** arowser has quit IRC
 27 2020-07-24T01:04:19  *** promag has joined #bitcoin-core-dev
 28 2020-07-24T01:06:08  *** arowser has joined #bitcoin-core-dev
 29 2020-07-24T01:09:15  *** promag has quit IRC
 30 2020-07-24T01:12:57  *** instagibbs has quit IRC
 31 2020-07-24T01:15:18  *** jb55 has quit IRC
 32 2020-07-24T01:15:49  *** jb55 has joined #bitcoin-core-dev
 33 2020-07-24T01:20:11  *** instagibbs has joined #bitcoin-core-dev
 34 2020-07-24T01:23:21  *** Highway61 has quit IRC
 35 2020-07-24T01:29:01  *** rh0nj has quit IRC
 36 2020-07-24T01:30:07  *** rh0nj has joined #bitcoin-core-dev
 37 2020-07-24T01:59:11  *** arowser has quit IRC
 38 2020-07-24T02:11:17  *** arowser has joined #bitcoin-core-dev
 39 2020-07-24T02:14:53  *** proofofkeags has quit IRC
 40 2020-07-24T02:15:27  *** proofofkeags has joined #bitcoin-core-dev
 41 2020-07-24T02:16:38  *** arowser has quit IRC
 42 2020-07-24T02:17:38  *** arowser has joined #bitcoin-core-dev
 43 2020-07-24T02:19:54  *** proofofkeags has quit IRC
 44 2020-07-24T02:25:47  *** arowser has quit IRC
 45 2020-07-24T02:26:17  *** arowser has joined #bitcoin-core-dev
 46 2020-07-24T02:36:09  *** arowser has quit IRC
 47 2020-07-24T02:48:17  *** arowser has joined #bitcoin-core-dev
 48 2020-07-24T02:54:30  *** arowser has quit IRC
 49 2020-07-24T02:55:32  *** arowser has joined #bitcoin-core-dev
 50 2020-07-24T03:00:01  *** Dragavnir has quit IRC
 51 2020-07-24T03:20:46  *** paolo|out has joined #bitcoin-core-dev
 52 2020-07-24T03:21:40  *** proofofkeags has joined #bitcoin-core-dev
 53 2020-07-24T03:25:28  *** proofofkeags has quit IRC
 54 2020-07-24T03:25:43  *** proofofkeags has joined #bitcoin-core-dev
 55 2020-07-24T03:31:05  *** vasild_ has joined #bitcoin-core-dev
 56 2020-07-24T03:33:59  *** S3RK has joined #bitcoin-core-dev
 57 2020-07-24T03:34:23  *** vasild has quit IRC
 58 2020-07-24T03:34:24  *** vasild_ is now known as vasild
 59 2020-07-24T03:50:49  *** arowser has quit IRC
 60 2020-07-24T03:51:45  *** arowser has joined #bitcoin-core-dev
 61 2020-07-24T03:58:56  *** go121212 has joined #bitcoin-core-dev
 62 2020-07-24T04:01:38  *** go11111111111 has quit IRC
 63 2020-07-24T04:03:21  *** proofofkeags has quit IRC
 64 2020-07-24T04:03:58  *** proofofkeags has joined #bitcoin-core-dev
 65 2020-07-24T04:08:28  *** proofofkeags has quit IRC
 66 2020-07-24T04:10:13  *** arowser has quit IRC
 67 2020-07-24T04:10:37  *** arowser has joined #bitcoin-core-dev
 68 2020-07-24T04:17:27  *** gzhao408 has quit IRC
 69 2020-07-24T04:40:15  *** arowser has quit IRC
 70 2020-07-24T04:42:43  *** arowser has joined #bitcoin-core-dev
 71 2020-07-24T04:43:11  *** arowser has quit IRC
 72 2020-07-24T04:43:29  *** arowser has joined #bitcoin-core-dev
 73 2020-07-24T04:44:12  *** arowser has quit IRC
 74 2020-07-24T04:44:31  *** arowser has joined #bitcoin-core-dev
 75 2020-07-24T04:55:42  *** smurfjack has joined #bitcoin-core-dev
 76 2020-07-24T04:58:43  *** bitdex has joined #bitcoin-core-dev
 77 2020-07-24T05:17:37  *** arowser has quit IRC
 78 2020-07-24T05:18:02  *** arowser has joined #bitcoin-core-dev
 79 2020-07-24T05:34:19  *** promag has joined #bitcoin-core-dev
 80 2020-07-24T05:37:40  *** cyberscout_ has joined #bitcoin-core-dev
 81 2020-07-24T05:38:48  *** promag has quit IRC
 82 2020-07-24T05:40:48  *** cyberscout_ has quit IRC
 83 2020-07-24T05:41:43  *** cyberscout has joined #bitcoin-core-dev
 84 2020-07-24T05:53:07  *** S3RK has quit IRC
 85 2020-07-24T05:53:34  *** S3RK has joined #bitcoin-core-dev
 86 2020-07-24T05:57:05  *** arowser has quit IRC
 87 2020-07-24T05:57:45  *** S3RK has quit IRC
 88 2020-07-24T05:59:01  *** vincenzopalazzo has joined #bitcoin-core-dev
 89 2020-07-24T06:00:02  *** paolo|out has quit IRC
 90 2020-07-24T06:05:28  *** promag has joined #bitcoin-core-dev
 91 2020-07-24T06:09:25  *** arowser has joined #bitcoin-core-dev
 92 2020-07-24T06:09:50  *** promag has quit IRC
 93 2020-07-24T06:16:11  *** arowser has quit IRC
 94 2020-07-24T06:16:40  *** arowser has joined #bitcoin-core-dev
 95 2020-07-24T06:17:51  *** justanotheruser has quit IRC
 96 2020-07-24T06:19:42  *** cyberscout has quit IRC
 97 2020-07-24T06:28:58  *** S3RK has joined #bitcoin-core-dev
 98 2020-07-24T06:31:12  <vasild> Is there a python function in test/functional that can be used to serialize varint?
 99 2020-07-24T06:31:52  *** arowser has quit IRC
100 2020-07-24T06:32:01  <vasild> There is ser_compact_size() test/functional/test_framework/messages.py, but I can't seem to find one for varint
101 2020-07-24T06:32:37  *** jonatack has quit IRC
102 2020-07-24T06:33:34  *** S3RK has quit IRC
103 2020-07-24T06:38:36  *** sipsorcery has joined #bitcoin-core-dev
104 2020-07-24T06:39:06  *** justMaD has joined #bitcoin-core-dev
105 2020-07-24T06:44:11  *** arowser has joined #bitcoin-core-dev
106 2020-07-24T06:57:21  *** Pavlenex has joined #bitcoin-core-dev
107 2020-07-24T06:58:48  *** arowser has quit IRC
108 2020-07-24T06:59:45  *** arowser has joined #bitcoin-core-dev
109 2020-07-24T07:01:58  *** Pavlenex has quit IRC
110 2020-07-24T07:04:25  *** Pavlenex has joined #bitcoin-core-dev
111 2020-07-24T07:11:16  *** S3RK has joined #bitcoin-core-dev
112 2020-07-24T07:14:41  <luke-jr> this error makes no sense and I can't reproduce it :/ https://travis-ci.org/github/bitcoin/bitcoin/jobs/711362669#L3131
113 2020-07-24T07:15:45  *** S3RK has quit IRC
114 2020-07-24T07:18:51  *** kristapsk has joined #bitcoin-core-dev
115 2020-07-24T07:22:28  *** jeremyrubin has quit IRC
116 2020-07-24T07:24:30  *** marcoagner has joined #bitcoin-core-dev
117 2020-07-24T07:24:56  *** jonatack has joined #bitcoin-core-dev
118 2020-07-24T07:30:38  *** S3RK has joined #bitcoin-core-dev
119 2020-07-24T07:35:34  <vasild> src/wallet/walletdb.h:44:using WalletDatabase = BerkeleyDatabase;
120 2020-07-24T07:36:14  <vasild> luke-jr: maybe it picked some "strange" berkeley db version that does not have "env" and "GetFileId" members?
121 2020-07-24T07:36:35  <vasild> -I/home/travis/build/bitcoin/bitcoin/db4/include
122 2020-07-24T07:37:07  *** arowser has quit IRC
123 2020-07-24T07:40:50  *** jeremyrubin has joined #bitcoin-core-dev
124 2020-07-24T07:49:31  *** arowser has joined #bitcoin-core-dev
125 2020-07-24T07:55:54  <luke-jr> vasild: that's not a bdb class
126 2020-07-24T07:57:16  <vasild> hm, right, it is defined in src/wallet/bdb.h:101:class BerkeleyDatabase
127 2020-07-24T08:00:42  *** promag has joined #bitcoin-core-dev
128 2020-07-24T08:10:24  <vasild> luke-jr: I can't reproduce it locally either, but it failed to compile for me for another reason: https://bpa.st/PUHA
129 2020-07-24T08:10:45  *** arowser has quit IRC
130 2020-07-24T08:12:13  *** IGHOR has quit IRC
131 2020-07-24T08:15:10  <luke-jr> yeah, I was wondering why I wasn't getting that one..
132 2020-07-24T08:15:52  <vasild> clang 11 here
133 2020-07-24T08:16:19  <luke-jr> hmm, does GCC lack it entirely? :/
134 2020-07-24T08:17:00  <vasild> g++10 -Wthread-safety-analysis
135 2020-07-24T08:17:01  <vasild> g++10: error: unrecognized command-line option '-Wthread-safety-analysis'
136 2020-07-24T08:18:33  <luke-jr> apparently it was removed at some point :/
137 2020-07-24T08:21:19  *** bitcoin-git has joined #bitcoin-core-dev
138 2020-07-24T08:21:19  <bitcoin-git> [bitcoin] hebasto closed pull request #19567: p2p, refactor: Do not over-reserve vAddr capacity (master...200722-addr) https://github.com/bitcoin/bitcoin/pull/19567
139 2020-07-24T08:21:20  *** bitcoin-git has left #bitcoin-core-dev
140 2020-07-24T08:22:21  *** Pavlenex has joined #bitcoin-core-dev
141 2020-07-24T08:24:13  *** IGHOR has joined #bitcoin-core-dev
142 2020-07-24T08:29:45  *** IGHOR has quit IRC
143 2020-07-24T08:33:20  *** IGHOR has joined #bitcoin-core-dev
144 2020-07-24T08:40:18  *** davec has quit IRC
145 2020-07-24T08:40:33  *** davec has joined #bitcoin-core-dev
146 2020-07-24T08:42:33  *** justMaD has quit IRC
147 2020-07-24T08:43:29  *** arowser has joined #bitcoin-core-dev
148 2020-07-24T08:50:50  *** S3RK has quit IRC
149 2020-07-24T09:04:25  *** promag has quit IRC
150 2020-07-24T09:07:04  *** S3RK has joined #bitcoin-core-dev
151 2020-07-24T09:11:25  *** S3RK has quit IRC
152 2020-07-24T09:15:22  *** harrigan has quit IRC
153 2020-07-24T09:16:17  *** harrigan has joined #bitcoin-core-dev
154 2020-07-24T09:19:56  *** Pavlenex has quit IRC
155 2020-07-24T09:23:18  *** arowser has quit IRC
156 2020-07-24T09:24:26  *** arowser has joined #bitcoin-core-dev
157 2020-07-24T09:30:36  *** dongcarl has quit IRC
158 2020-07-24T09:32:22  *** csharpsteen has joined #bitcoin-core-dev
159 2020-07-24T09:32:24  *** AaronvanW has joined #bitcoin-core-dev
160 2020-07-24T09:34:10  *** MasterdonX has joined #bitcoin-core-dev
161 2020-07-24T09:35:18  *** masterdonx2 has quit IRC
162 2020-07-24T09:40:03  *** Zenton has quit IRC
163 2020-07-24T09:40:19  *** Zenton has joined #bitcoin-core-dev
164 2020-07-24T09:41:38  *** jonatack has quit IRC
165 2020-07-24T09:53:08  *** EagleTM has joined #bitcoin-core-dev
166 2020-07-24T10:03:19  *** Ignacio32Lockman has joined #bitcoin-core-dev
167 2020-07-24T10:05:02  *** arowser has quit IRC
168 2020-07-24T10:14:16  *** S3RK has joined #bitcoin-core-dev
169 2020-07-24T10:17:08  *** Ignacio32Lockman has quit IRC
170 2020-07-24T10:18:50  *** S3RK has quit IRC
171 2020-07-24T10:27:27  *** arowser has joined #bitcoin-core-dev
172 2020-07-24T10:31:46  *** jonatack has joined #bitcoin-core-dev
173 2020-07-24T10:34:51  *** arowser has quit IRC
174 2020-07-24T10:41:20  *** arowser has joined #bitcoin-core-dev
175 2020-07-24T10:48:08  *** Pavlenex has joined #bitcoin-core-dev
176 2020-07-24T10:50:30  *** S3RK has joined #bitcoin-core-dev
177 2020-07-24T10:50:56  *** S3RK has joined #bitcoin-core-dev
178 2020-07-24T10:51:35  <achow101> luke-jr: you need to rebase
179 2020-07-24T10:52:44  <achow101> An actual WalletDatabase virtual class was added. It doesn't have an env member
180 2020-07-24T10:53:41  *** belcher_ has quit IRC
181 2020-07-24T10:53:48  *** reallll has joined #bitcoin-core-dev
182 2020-07-24T10:55:48  <achow101> Do you really need the bdb unique file id? Sqlite doesn't have a similar id so it's not guaranteed that file IDs will exist for all WalletDatabase classes
183 2020-07-24T10:58:03  *** Chris_Stewart_5 has quit IRC
184 2020-07-24T11:00:34  <wumpus> yanmaani: it should be preferred to use named parameters with RPC where possible as they prevent some kinds of bugs, positional arguments are mainly still accepted for historical compatiblity (no, they're not going away any time soon if it's up to me)
185 2020-07-24T11:03:45  *** Highway61 has joined #bitcoin-core-dev
186 2020-07-24T11:05:31  <achow101> Personally I still prefer positional because I can never spell the named args correctly the first time
187 2020-07-24T11:09:02  <wumpus> right for use in a program is different than using it manually
188 2020-07-24T11:11:15  *** bitdex has quit IRC
189 2020-07-24T11:15:31  <jonatack> +1. for manual use, I mostly use positional.
190 2020-07-24T11:15:31  *** promag_ has quit IRC
191 2020-07-24T11:18:12  *** arowser has quit IRC
192 2020-07-24T11:18:43  *** promag_ has joined #bitcoin-core-dev
193 2020-07-24T11:20:10  *** troygiorshev has joined #bitcoin-core-dev
194 2020-07-24T11:22:45  *** promag_ has quit IRC
195 2020-07-24T11:22:47  *** S3RK has quit IRC
196 2020-07-24T11:23:07  *** S3RK has joined #bitcoin-core-dev
197 2020-07-24T11:25:54  *** jonatack has quit IRC
198 2020-07-24T11:27:05  *** S3RK has quit IRC
199 2020-07-24T11:27:31  *** S3RK has joined #bitcoin-core-dev
200 2020-07-24T11:29:30  *** jonatack has joined #bitcoin-core-dev
201 2020-07-24T11:30:19  *** arowser has joined #bitcoin-core-dev
202 2020-07-24T11:35:24  *** mutatrum has quit IRC
203 2020-07-24T11:36:18  *** S3RK has quit IRC
204 2020-07-24T11:46:04  *** Chris_Stewart_5 has joined #bitcoin-core-dev
205 2020-07-24T11:47:23  *** arowser has quit IRC
206 2020-07-24T11:50:49  *** reallll is now known as belcher_
207 2020-07-24T11:58:16  <wumpus> in principle bitcoin-cli could add in the names before sending it to the server and emulate the same interface
208 2020-07-24T11:59:31  *** arowser has joined #bitcoin-core-dev
209 2020-07-24T12:00:02  *** csharpsteen has quit IRC
210 2020-07-24T12:09:34  *** vincenzopalazzo has quit IRC
211 2020-07-24T12:11:59  <jonatack> heh, just realised i've made 4 failed CLI PRs in a row, and 16439 by aj has been open for exactly a year now with only one ACK (from me)... CLI PRs seem unsexy :D
212 2020-07-24T12:18:16  *** bitcoin-git has joined #bitcoin-core-dev
213 2020-07-24T12:18:17  <bitcoin-git> [bitcoin] troygiorshev opened pull request #19580: Remove message_count (master...2020-07-remove-message_count) https://github.com/bitcoin/bitcoin/pull/19580
214 2020-07-24T12:18:17  *** bitcoin-git has left #bitcoin-core-dev
215 2020-07-24T12:19:12  *** arowser has quit IRC
216 2020-07-24T12:20:22  *** arowser has joined #bitcoin-core-dev
217 2020-07-24T12:20:57  *** bayashi has joined #bitcoin-core-dev
218 2020-07-24T12:29:15  *** Pavlenex has quit IRC
219 2020-07-24T12:34:02  *** Guyver2 has joined #bitcoin-core-dev
220 2020-07-24T12:35:51  *** Tralfaz has joined #bitcoin-core-dev
221 2020-07-24T12:36:10  *** Davterra has quit IRC
222 2020-07-24T12:52:25  *** arowser has quit IRC
223 2020-07-24T12:53:58  *** Deacyde has joined #bitcoin-core-dev
224 2020-07-24T12:58:52  *** arowser has joined #bitcoin-core-dev
225 2020-07-24T13:03:15  *** arowser has quit IRC
226 2020-07-24T13:03:43  *** arowser has joined #bitcoin-core-dev
227 2020-07-24T13:07:13  *** arowser has quit IRC
228 2020-07-24T13:07:42  *** arowser has joined #bitcoin-core-dev
229 2020-07-24T13:08:13  *** arowser has quit IRC
230 2020-07-24T13:08:36  *** arowser has joined #bitcoin-core-dev
231 2020-07-24T13:09:15  *** arowser has quit IRC
232 2020-07-24T13:09:36  *** arowser has joined #bitcoin-core-dev
233 2020-07-24T13:10:14  *** arowser has quit IRC
234 2020-07-24T13:10:39  *** arowser has joined #bitcoin-core-dev
235 2020-07-24T13:10:47  <instagibbs> jonatack, clearly the -cli is perfect then
236 2020-07-24T13:17:58  *** arowser has quit IRC
237 2020-07-24T13:29:00  *** pingwindyktator has quit IRC
238 2020-07-24T13:29:22  *** pingwindyktator has joined #bitcoin-core-dev
239 2020-07-24T13:30:04  *** arowser has joined #bitcoin-core-dev
240 2020-07-24T13:31:23  *** grubles has quit IRC
241 2020-07-24T13:32:17  <elichai2> harding: Thanks! russell's tool was exactly what I was looking for :)
242 2020-07-24T13:34:45  *** owowo has quit IRC
243 2020-07-24T13:38:29  *** grubles has joined #bitcoin-core-dev
244 2020-07-24T13:40:34  *** owowo has joined #bitcoin-core-dev
245 2020-07-24T13:40:35  *** owowo has joined #bitcoin-core-dev
246 2020-07-24T13:45:19  *** mdunnio has joined #bitcoin-core-dev
247 2020-07-24T13:46:15  *** harrigan has quit IRC
248 2020-07-24T13:46:32  *** Tralfaz is now known as Davterra
249 2020-07-24T13:54:07  *** harrigan has joined #bitcoin-core-dev
250 2020-07-24T13:57:23  *** arowser has quit IRC
251 2020-07-24T14:09:19  *** mdunnio has quit IRC
252 2020-07-24T14:09:36  *** mdunnio has joined #bitcoin-core-dev
253 2020-07-24T14:09:43  *** arowser has joined #bitcoin-core-dev
254 2020-07-24T14:22:22  *** proofofkeags has joined #bitcoin-core-dev
255 2020-07-24T14:28:48  *** jb55 has quit IRC
256 2020-07-24T14:31:14  *** arowser has quit IRC
257 2020-07-24T14:31:43  *** jb55 has joined #bitcoin-core-dev
258 2020-07-24T14:32:47  <jonatack> instagibbs: yup seems so
259 2020-07-24T14:37:05  *** cubancorona has quit IRC
260 2020-07-24T14:40:32  *** harrigan has quit IRC
261 2020-07-24T14:43:22  *** arowser has joined #bitcoin-core-dev
262 2020-07-24T14:45:47  *** Tralfaz has joined #bitcoin-core-dev
263 2020-07-24T14:46:13  *** Davterra has quit IRC
264 2020-07-24T14:46:21  *** Tralfaz is now known as Davterra
265 2020-07-24T14:49:02  *** harrigan has joined #bitcoin-core-dev
266 2020-07-24T14:49:22  *** EagleTM has quit IRC
267 2020-07-24T14:53:36  <jnewbery> wumpus: I think #19472 is RFM. It has 4 ACKs
268 2020-07-24T14:53:39  <gribble> https://github.com/bitcoin/bitcoin/issues/19472 | [net processing] Reduce cs_main scope in MaybeDiscourageAndDisconnect() by jnewbery · Pull Request #19472 · bitcoin/bitcoin · GitHub
269 2020-07-24T15:00:01  *** bayashi has quit IRC
270 2020-07-24T15:02:25  <wumpus> jnewbery: thanks
271 2020-07-24T15:03:21  *** Pavlenex has joined #bitcoin-core-dev
272 2020-07-24T15:04:26  *** Talkless has joined #bitcoin-core-dev
273 2020-07-24T15:06:01  *** Talkless has quit IRC
274 2020-07-24T15:06:13  *** Talkless has joined #bitcoin-core-dev
275 2020-07-24T15:14:33  *** proofofkeags has quit IRC
276 2020-07-24T15:15:08  *** proofofkeags has joined #bitcoin-core-dev
277 2020-07-24T15:15:10  <yanmaani> possible to subscribe to bitcoin-dev list without using the browser? captcha doesn't work on tor
278 2020-07-24T15:18:18  *** arowser has quit IRC
279 2020-07-24T15:19:25  *** proofofkeags has quit IRC
280 2020-07-24T15:19:32  *** kljasdfvv has quit IRC
281 2020-07-24T15:21:29  *** bitcoin-git has joined #bitcoin-core-dev
282 2020-07-24T15:21:31  <bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/007e15dcd7f8...40a04814d130
283 2020-07-24T15:21:31  <bitcoin-git> bitcoin/master 1a1c23f John Newbery: [net processing] Change cs_main TRY_LOCK to LOCK in SendMessages()
284 2020-07-24T15:21:32  <bitcoin-git> bitcoin/master a1d5a42 John Newbery: [net processing] Fix bad indentation in SendMessages()
285 2020-07-24T15:21:33  <bitcoin-git> bitcoin/master a49781e John Newbery: [net processing] Only call MaybeDiscourageAndDisconnect from SendMessages
286 2020-07-24T15:21:35  *** bitcoin-git has left #bitcoin-core-dev
287 2020-07-24T15:21:49  *** bitcoin-git has joined #bitcoin-core-dev
288 2020-07-24T15:21:49  <bitcoin-git> [bitcoin] laanwj merged pull request #19472: [net processing] Reduce cs_main scope in MaybeDiscourageAndDisconnect() (master...2020-07-tidyup-maybediscourage) https://github.com/bitcoin/bitcoin/pull/19472
289 2020-07-24T15:21:50  *** bitcoin-git has left #bitcoin-core-dev
290 2020-07-24T15:21:56  *** hollowleviathan1 has joined #bitcoin-core-dev
291 2020-07-24T15:22:20  *** hollowleviathan1 is now known as Guest1131
292 2020-07-24T15:30:31  *** arowser has joined #bitcoin-core-dev
293 2020-07-24T15:34:23  *** vasild has quit IRC
294 2020-07-24T15:36:10  *** vasild has joined #bitcoin-core-dev
295 2020-07-24T15:37:21  *** proofofkeags has joined #bitcoin-core-dev
296 2020-07-24T15:38:13  *** arowser has quit IRC
297 2020-07-24T15:38:36  *** arowser has joined #bitcoin-core-dev
298 2020-07-24T15:45:57  *** bitcoin-git has joined #bitcoin-core-dev
299 2020-07-24T15:45:57  <bitcoin-git> [bitcoin] jnewbery opened pull request #19583: Clean up Misbehaving() (master...2020-07-tidy-misbehavior) https://github.com/bitcoin/bitcoin/pull/19583
300 2020-07-24T15:45:58  *** bitcoin-git has left #bitcoin-core-dev
301 2020-07-24T15:50:03  *** vasild has quit IRC
302 2020-07-24T15:51:43  *** michagogo has joined #bitcoin-core-dev
303 2020-07-24T15:58:31  *** smurfjack has quit IRC
304 2020-07-24T16:00:54  *** vasild has joined #bitcoin-core-dev
305 2020-07-24T16:02:10  *** vincenzopalazzo has joined #bitcoin-core-dev
306 2020-07-24T16:05:54  *** bitcoin-git has joined #bitcoin-core-dev
307 2020-07-24T16:05:54  <bitcoin-git> [bitcoin] ecurrencyhodler opened pull request #19584: doc: Update obsolete links to online reference #19582 (master...patch-1) https://github.com/bitcoin/bitcoin/pull/19584
308 2020-07-24T16:05:55  *** bitcoin-git has left #bitcoin-core-dev
309 2020-07-24T16:17:46  *** someone235 has joined #bitcoin-core-dev
310 2020-07-24T16:18:18  *** Talkless has quit IRC
311 2020-07-24T16:20:44  *** bitcoin-git has joined #bitcoin-core-dev
312 2020-07-24T16:20:45  <bitcoin-git> [bitcoin] stylesuxx opened pull request #19585: rpc: RPCResult Type of MempoolEntryDescription should be OBJ. (master...19579) https://github.com/bitcoin/bitcoin/pull/19585
313 2020-07-24T16:20:46  *** bitcoin-git has left #bitcoin-core-dev
314 2020-07-24T16:23:43  *** proofofkeags has quit IRC
315 2020-07-24T16:24:09  *** proofofkeags has joined #bitcoin-core-dev
316 2020-07-24T16:24:29  *** proofofkeags has quit IRC
317 2020-07-24T16:24:35  *** proofofkeags has joined #bitcoin-core-dev
318 2020-07-24T16:26:43  <luke-jr> achow101: what else uniquely identifies a wallet? if sqlite doesn't have one, I suggest adding one explicitly from the start..
319 2020-07-24T16:42:47  *** vincenzopalazzo has quit IRC
320 2020-07-24T16:43:41  *** troygiorshev has quit IRC
321 2020-07-24T16:44:13  *** troygiorshev has joined #bitcoin-core-dev
322 2020-07-24T16:45:10  *** arowser has quit IRC
323 2020-07-24T16:45:33  *** arowser has joined #bitcoin-core-dev
324 2020-07-24T17:08:47  <cfields_> jnewbery: I just happened to see it here, haven't looked into it fully...
325 2020-07-24T17:09:41  <cfields_> "Change cs_main TRY_LOCK to LOCK" IIRC the TRY_LOCK was _very_ important for making sure that peers are visited fairly.
326 2020-07-24T17:11:57  <cfields_> I believe that change may significantly change how peers are processed.
327 2020-07-24T17:11:59  <sipa> vasild: what do you need varint for? afaik it's not used in any public interface
328 2020-07-24T17:12:02  <cfields_> I'll add it to my review queue.
329 2020-07-24T17:12:10  <luke-jr> achow101: thanks for the explanation of rebase needed; I was quite confused, lol
330 2020-07-24T17:13:04  *** dongcarl has joined #bitcoin-core-dev
331 2020-07-24T17:13:18  *** Pavlenex has quit IRC
332 2020-07-24T17:21:53  *** dongcarl has quit IRC
333 2020-07-24T17:22:18  *** dongcarl has joined #bitcoin-core-dev
334 2020-07-24T17:26:32  <jonatack> cfields_: TIL, interesting!
335 2020-07-24T17:26:43  *** filchef has joined #bitcoin-core-dev
336 2020-07-24T17:27:31  <cfields_> jonatack: I'm struggling trying to remember the details.
337 2020-07-24T17:28:17  <sipa> cfields_: i believe that a long time ago, during ProcessMessages cs_recv was held, and during SendMessages cs_send was held
338 2020-07-24T17:28:54  <sipa> and the network thread would try to grab what wasn't locked, so sends could be done in parallel with ProcessMessages, and receives could be done in parallel with SendMessages, for the same peer
339 2020-07-24T17:29:22  <sipa> i believe that's no longer the case, and SendMessages/ProcessMessages just grab send/recv locks whenever needed
340 2020-07-24T17:29:46  <sipa> in particular, ProcessMessages doesn't lock cs_recv while validating a block...
341 2020-07-24T17:29:48  <cfields_> sipa: maybe, but there's something about taking cs_main and stalling the processing pipeline.
342 2020-07-24T17:30:25  <sipa> nothing in net locks cs_main
343 2020-07-24T17:31:40  *** Pavlenex has joined #bitcoin-core-dev
344 2020-07-24T17:31:40  <cfields_> sipa: right, but now SendMessages is guaranteed to wait for cs_main for every peer, every run through the loop.
345 2020-07-24T17:32:04  <cfields_> before that would've caused it to hop around peers due to randomly failing to grab the lock.
346 2020-07-24T17:32:15  <cfields_> Now they'll be guaranteed processed in-order.
347 2020-07-24T17:32:22  <sipa> right
348 2020-07-24T17:32:34  <sipa> exactly which PR are you talking about, btw?
349 2020-07-24T17:32:58  <cfields_> Which iirc was explicitly not desired at one point, though I can't remember why :(
350 2020-07-24T17:33:00  <cfields_> #19472
351 2020-07-24T17:33:02  <gribble> https://github.com/bitcoin/bitcoin/issues/19472 | [net processing] Reduce cs_main scope in MaybeDiscourageAndDisconnect() by jnewbery · Pull Request #19472 · bitcoin/bitcoin · GitHub
352 2020-07-24T17:35:10  <sipa> cfields_: ah i see
353 2020-07-24T17:35:49  <sipa> cfields_: i'm not sure this really matters, as nearly every message being processed for incoming messages also grabs cs_main
354 2020-07-24T17:36:50  <cfields_> sipa: sure, for post-handshake peers :)
355 2020-07-24T17:37:30  <cfields_> you're right though. I'm struggling to remember how this could've been significant.
356 2020-07-24T17:38:37  *** Giszmo1 has quit IRC
357 2020-07-24T17:46:04  *** kristapsk has quit IRC
358 2020-07-24T17:49:22  *** Pavlenex has quit IRC
359 2020-07-24T17:54:03  *** Giszmo has joined #bitcoin-core-dev
360 2020-07-24T17:57:20  <cfields_> sipa: that's what it is... ProcessMessages and SendMessages are called together, as "we have a message to process" is what we use as a proxy for "maybe we should send some stuff too". Now the SendMessages are all guaranteed to run to the end, so we'll be spending more time in there now than before. I have no idea what the hit/miss ratio looked like before, so I'm not sure if that's significant.
361 2020-07-24T17:58:18  <cfields_> *TRY_LOCK hit/miss
362 2020-07-24T18:00:02  *** Guest1131 has quit IRC
363 2020-07-24T18:03:04  *** Pavlenex has joined #bitcoin-core-dev
364 2020-07-24T18:08:12  *** Pavlenex has quit IRC
365 2020-07-24T18:08:14  *** justanotheruser has joined #bitcoin-core-dev
366 2020-07-24T18:09:46  *** michagogo has quit IRC
367 2020-07-24T18:11:38  <achow101> luke-jr: the full file path to the wallet should be sufficient
368 2020-07-24T18:11:45  *** Giszmo has quit IRC
369 2020-07-24T18:11:47  <achow101> As a unique identifier
370 2020-07-24T18:13:12  <sdaftuar> cfields_: does that mean that if a user is doing a bunch of RPC calls that are grabbing cs_main, we might let our receive buffers fill up more?
371 2020-07-24T18:13:53  <sdaftuar> that seems like a plausible reason why the old behavior might have been desirable i guess
372 2020-07-24T18:14:28  <cfields_> sdaftuar: not on the socket side, but on the processing side, yes.
373 2020-07-24T18:15:21  <cfields_> sdaftuar: but like sipa said, something would be bound to take cs_main eventually anyway.
374 2020-07-24T18:16:01  <luke-jr> achow101: not if the user moves it
375 2020-07-24T18:17:24  <sipa> luke-jr: i think it makes sense to be able to give a warning to detect a (fork of) a wallet file being loaded multiple times, but it's not really as necessary as it was with bdb (which would give annoying errors if you had the same db opened twice in the same env)
376 2020-07-24T18:17:39  <cfields_> sdaftuar: the more I think about it, the more I think it was probably just a way of throttling SendMessages to be called less often than every run through the message handler loop.
377 2020-07-24T18:17:48  <sipa> luke-jr: we could do the check at a more semantic level... like do you have multiple wallets watching the same addresses
378 2020-07-24T18:18:15  <cfields_> s/to be called/to fully execute/
379 2020-07-24T18:18:35  <achow101> luke-jr: you're persisting the IDs?
380 2020-07-24T18:19:53  <sipa> cfields_, sdaftuar: in that scenario i think the difference is spinning through SendMessages and blocking on the first ProcessMessages that needs cs_main, vs blocking immediately in SendMessages
381 2020-07-24T18:20:03  <sipa> i don't think that's a big difference
382 2020-07-24T18:21:42  <luke-jr> sipa: this isn't for detecting forks..
383 2020-07-24T18:21:46  *** ds has joined #bitcoin-core-dev
384 2020-07-24T18:22:03  <sipa> luke-jr: i mean forks in the history of the wallet file; not blockchain forks
385 2020-07-24T18:22:03  <luke-jr> achow101: yes, that's the whole point
386 2020-07-24T18:22:04  *** ds is now known as Guest78261
387 2020-07-24T18:22:08  <luke-jr> sipa: right
388 2020-07-24T18:22:33  <luke-jr> sipa: what I'm doing in that PR, is preventing pruning if we know we have a wallet that needs the blocks for syncing
389 2020-07-24T18:22:54  <cfields_> sipa: I agree with that. I drop the cs_main objection. I am still concerned about the time spent in that function, though. Will follow-up with jnewbery for some before/after benchmarks.
390 2020-07-24T18:23:35  <sipa> cfields_: i think post-move-to-more-net_processing-and-it-having-its-own-lock(s), there are more opportunities to do conditional processing anyway
391 2020-07-24T18:23:42  <luke-jr> sipa: once the wallet is synced, we want pruning to continue, so it uses the fileid to track the prune lock
392 2020-07-24T18:23:43  <achow101> luke-jr: I guess you could add an id record..
393 2020-07-24T18:23:50  <sdaftuar> sipa: i think the differene is that in SendMessages, if you were waiting a long time before you get invoked, then you might be sending stale data to your peers
394 2020-07-24T18:24:04  <luke-jr> achow101: bdb already has this, it's just sqlite where we'd need to add it
395 2020-07-24T18:24:12  <luke-jr> which is fine since sqlite has no existing wallets yet
396 2020-07-24T18:24:26  <luke-jr> (and if we migrate bdb to sqlite someday, we can migrate fileid)
397 2020-07-24T18:24:58  <sipa> luke-jr: i'm not really a fan of mixing a dblayer identifier with an application level identifier
398 2020-07-24T18:25:18  <sipa> if you import a descriptors from one wallet file into another, shouldn't that also be treated as a duplicate?
399 2020-07-24T18:25:36  <luke-jr> dunno
400 2020-07-24T18:25:49  <luke-jr> syncing the new one won't sync the old one if you still have it around
401 2020-07-24T18:25:56  *** jb55 has quit IRC
402 2020-07-24T18:26:02  <sdaftuar> actually, scratch what i said, i misremembered how those ProcessMessages/SendMessages calls work
403 2020-07-24T18:26:24  *** jb55 has joined #bitcoin-core-dev
404 2020-07-24T18:26:39  <cfields_> sdaftuar: right, the actual sends are happening async :)
405 2020-07-24T18:27:11  <luke-jr> sipa: it's not the keys in the wallet that matter for this per se, but the state of the sync of the wallet
406 2020-07-24T18:27:20  <luke-jr> which isn't really correlated with the descriptor
407 2020-07-24T18:28:40  <sipa> luke-jr: i see
408 2020-07-24T18:31:28  *** proofofkeags has quit IRC
409 2020-07-24T18:31:52  *** jarthur has joined #bitcoin-core-dev
410 2020-07-24T18:31:54  *** proofofkeags has joined #bitcoin-core-dev
411 2020-07-24T18:34:03  *** grubles has quit IRC
412 2020-07-24T18:34:24  <achow101> luke-jr: I suppose it's fine to use the bdb I'd. But I would prefer if you didn't use WalletDatabaseFileId. A uint160 should work, the id is 20 bytes
413 2020-07-24T18:34:59  *** grubles has joined #bitcoin-core-dev
414 2020-07-24T18:36:17  *** Giszmo has joined #bitcoin-core-dev
415 2020-07-24T18:36:24  *** proofofkeags has quit IRC
416 2020-07-24T18:38:58  *** jarthur has quit IRC
417 2020-07-24T18:46:01  *** reardencode has quit IRC
418 2020-07-24T18:46:53  <luke-jr> achow101: well, I'm turning it into a std::string in CWallet - maybe I should do that at the WalletDatabase level?
419 2020-07-24T18:47:42  <achow101> That would be preferable
420 2020-07-24T19:01:09  *** arowser has quit IRC
421 2020-07-24T19:01:33  *** arowser has joined #bitcoin-core-dev
422 2020-07-24T19:02:44  *** proofofkeags has joined #bitcoin-core-dev
423 2020-07-24T19:03:00  *** jarthur has joined #bitcoin-core-dev
424 2020-07-24T19:10:43  *** Dean_Guss has quit IRC
425 2020-07-24T19:11:38  *** Dean_Guss has joined #bitcoin-core-dev
426 2020-07-24T19:35:56  *** roconnor_ has joined #bitcoin-core-dev
427 2020-07-24T19:36:41  *** roconnor has quit IRC
428 2020-07-24T19:36:44  *** roconnor_ is now known as roconnor
429 2020-07-24T19:38:53  *** AaronvanW has quit IRC
430 2020-07-24T20:06:00  <jnewbery> cfields_: Just catching up on this now. Thanks for looking at the PR.
431 2020-07-24T20:06:37  <jnewbery> My understanding was that the TRY_LOCK was added to fix a potential deadlock between cs_main and cs_vSend, introduced in #1117
432 2020-07-24T20:06:39  <gribble> https://github.com/bitcoin/bitcoin/issues/1117 | Fix potential deadlock by sipa · Pull Request #1117 · bitcoin/bitcoin · GitHub
433 2020-07-24T20:07:41  <jnewbery> I expect that the hit ratio for that TRY_LOCK is almost 1 (ie we get the lock almost always), because other threads don't hold cs_main very much
434 2020-07-24T20:08:16  <jnewbery> unless you're really hammering the RPC with something that takes cs_main, but even then it'd be difficult
435 2020-07-24T20:10:32  *** cryptapus_ is now known as cryptapus
436 2020-07-24T20:16:31  *** Andrew has joined #bitcoin-core-dev
437 2020-07-24T20:18:07  *** Andrew has quit IRC
438 2020-07-24T20:19:35  *** frogger has joined #bitcoin-core-dev
439 2020-07-24T20:23:33  *** Talkless has joined #bitcoin-core-dev
440 2020-07-24T20:27:45  *** arowser has quit IRC
441 2020-07-24T20:28:02  *** arowser has joined #bitcoin-core-dev
442 2020-07-24T20:39:03  *** frogger has quit IRC
443 2020-07-24T20:41:13  *** proofofkeags has quit IRC
444 2020-07-24T20:41:41  *** proofofkeags has joined #bitcoin-core-dev
445 2020-07-24T20:45:47  *** proofofkeags has quit IRC
446 2020-07-24T20:47:01  *** promag has joined #bitcoin-core-dev
447 2020-07-24T20:55:14  *** S3RK has joined #bitcoin-core-dev
448 2020-07-24T20:58:32  *** justanotheruser has quit IRC
449 2020-07-24T21:00:02  *** Guest78261 has quit IRC
450 2020-07-24T21:00:48  *** filchef has quit IRC
451 2020-07-24T21:01:34  *** S3RK has quit IRC
452 2020-07-24T21:08:21  *** S3RK has joined #bitcoin-core-dev
453 2020-07-24T21:12:29  *** S3RK has quit IRC
454 2020-07-24T21:12:30  *** proofofkeags has joined #bitcoin-core-dev
455 2020-07-24T21:21:25  *** Antimatter has joined #bitcoin-core-dev
456 2020-07-24T21:21:25  *** bitcoin-git has joined #bitcoin-core-dev
457 2020-07-24T21:21:25  <bitcoin-git> [bitcoin] sanjaykdragon opened pull request #19586: REFACTOR: moved from percent format to proper format for consistency (master...master) https://github.com/bitcoin/bitcoin/pull/19586
458 2020-07-24T21:21:34  *** bitcoin-git has left #bitcoin-core-dev
459 2020-07-24T21:21:45  *** proofofkeags has quit IRC
460 2020-07-24T21:24:45  *** S3RK has joined #bitcoin-core-dev
461 2020-07-24T21:29:18  *** S3RK has quit IRC
462 2020-07-24T21:31:05  *** S3RK has joined #bitcoin-core-dev
463 2020-07-24T21:32:42  *** troygiorshev has quit IRC
464 2020-07-24T21:34:21  *** Guyver2 has quit IRC
465 2020-07-24T21:35:50  *** S3RK has quit IRC
466 2020-07-24T21:36:52  *** Giszmo has quit IRC
467 2020-07-24T21:38:43  *** sipsorcery has quit IRC
468 2020-07-24T21:39:02  *** sipsorcery has joined #bitcoin-core-dev
469 2020-07-24T21:39:46  *** troygiorshev has joined #bitcoin-core-dev
470 2020-07-24T21:40:23  *** Talkless has quit IRC
471 2020-07-24T21:40:51  *** vasild has quit IRC
472 2020-07-24T21:41:03  *** vasild has joined #bitcoin-core-dev
473 2020-07-24T21:46:31  *** arowser has quit IRC
474 2020-07-24T21:48:07  <yanmaani> What's the purpose of the options objects in RPCs, such as bumpfee?
475 2020-07-24T21:48:22  <yanmaani> couldn't you just leave them as normal root-level named params?
476 2020-07-24T21:49:13  <luke-jr> yanmaani: if you want an ugly interface..
477 2020-07-24T21:49:38  <yanmaani> luke-jr: how do you mean? Aren't named params optional?
478 2020-07-24T21:49:55  <sipa> yanmaani: ootions objects existed before we supported named params
479 2020-07-24T21:49:56  <luke-jr> yanmaani: foo(1, null, null, null, null, null, null, null, null, null, 2) is super ugly
480 2020-07-24T21:50:09  *** arowser has joined #bitcoin-core-dev
481 2020-07-24T21:50:16  <sipa> and it makes the positional interface pretty annoying
482 2020-07-24T21:50:22  <sipa> as luke-jr points out
483 2020-07-24T21:50:32  <luke-jr> yanmaani: after #17356 I have a commit that allows mixing options in with the usual named params
484 2020-07-24T21:50:33  <gribble> https://github.com/bitcoin/bitcoin/issues/17356 | RPC: Internal named params by luke-jr · Pull Request #17356 · bitcoin/bitcoin · GitHub
485 2020-07-24T21:50:45  <yanmaani> Oh wait, so named args are sort of positional at the same time?
486 2020-07-24T21:50:59  <yanmaani> Couldn't you just have all the named args at the end? Or would you still need nulls
487 2020-07-24T21:51:01  <luke-jr> yanmaani: root-level are positional
488 2020-07-24T21:51:02  <sipa> yanmaani: internally everything is positional
489 2020-07-24T21:51:10  <promag> yanmaani:
490 2020-07-24T21:51:12  <yanmaani> Are named args positional?
491 2020-07-24T21:51:13  <luke-jr> yanmaani: you'd need nulls to get to the option you want
492 2020-07-24T21:51:16  <promag> ops
493 2020-07-24T21:51:27  <sipa> yanmaani: they're mapped to positional arguments internally
494 2020-07-24T21:51:32  <yanmaani> luke-jr: Can't I write option=value?
495 2020-07-24T21:51:44  <luke-jr> positional arguments only make sense for things you would normally specify for every/common use case
496 2020-07-24T21:51:50  <luke-jr> yanmaani: only if you're using named params
497 2020-07-24T21:52:05  <sipa> yanmaani: the external interface supports both named or positional, as json-rpc specifies
498 2020-07-24T21:52:19  *** Giszmo has joined #bitcoin-core-dev
499 2020-07-24T21:52:21  <sipa> internally every named argument is just mapped to an internal positional on3
500 2020-07-24T21:52:23  <yanmaani> Ohh. So you don't want them because of that reason?
501 2020-07-24T21:52:44  <sipa> yanmaani: i don't think this matters
502 2020-07-24T21:52:51  <luke-jr> yanmaani: the only reason for args to be root-level, is for them to be used positionally
503 2020-07-24T21:52:54  <yanmaani> If someone is using something where they can only use positional args, then you don't want them to write null, null, null, ...
504 2020-07-24T21:53:08  <sipa> even if things were implemented differently internally, we still want to support a usable.positional interface
505 2020-07-24T21:53:24  <promag> yanmaani: if you read rpc method implementations then you see that params are read with index, like param[2]..
506 2020-07-24T21:54:01  <yanmaani> luke-jr: Well it's a bit cleaner to write rpccall true 1 foo=bar asd=asd than rpccall true 1 '{"foo": "bar", "asd": "asd"}'
507 2020-07-24T21:54:05  <luke-jr> sipa: implementing it differently would enable naming options without an options={…} though
508 2020-07-24T21:54:13  <sipa> luke-jr: right
509 2020-07-24T21:54:19  <luke-jr> yanmaani: JSON-RPC doesn't allow that
510 2020-07-24T21:54:29  <promag> yanmaani: you mean on the console?
511 2020-07-24T21:54:31  <yanmaani> So the names are just cosmetic?
512 2020-07-24T21:54:33  <yanmaani> promag: yeah
513 2020-07-24T21:54:37  <luke-jr> yanmaani: JSON-RPC only allows ALL positional or ALL named
514 2020-07-24T21:54:44  <luke-jr> options is how we can get both
515 2020-07-24T21:54:46  <yanmaani> oh.
516 2020-07-24T21:54:48  <yanmaani> nice
517 2020-07-24T21:55:06  <yanmaani> And if you're using all named, then you still need a fallback all-named API?
518 2020-07-24T21:55:29  <sipa> you mean all-positionalm
519 2020-07-24T21:55:30  <sipa> ?
520 2020-07-24T21:56:05  <promag> rpccall true 1 foo=bar asd=asd   <----- you are mixing here
521 2020-07-24T21:56:12  <sipa> tbh, i never use the named interface
522 2020-07-24T21:57:29  <promag> sipa: I though you use brain-ipc-foo
523 2020-07-24T21:57:29  <yanmaani> sipa: yes
524 2020-07-24T21:57:33  <yanmaani> a fallback all-pos
525 2020-07-24T21:57:51  <sipa> right, we need some way of supporting an all-pos interface
526 2020-07-24T21:58:03  <sipa> i wouldn't call it fallback - it's just one of the two supported interfacez
527 2020-07-24T21:58:05  <yanmaani> Oh. Nice.
528 2020-07-24T21:58:35  <sipa> promag: lol
529 2020-07-24T21:59:01  <promag> what was the motivation for named params btw?
530 2020-07-24T21:59:10  <sipa> json-rpc specifies them
531 2020-07-24T21:59:21  <luke-jr> XD
532 2020-07-24T21:59:27  <sipa> and in some contexts, i think they're useful
533 2020-07-24T21:59:29  *** samry has joined #bitcoin-core-dev
534 2020-07-24T21:59:37  <promag> it's not mandatory is it?
535 2020-07-24T21:59:37  <sipa> though i hacen't seen much need personally
536 2020-07-24T22:00:03  <promag> for methods with optional params then yeah, named is cool
537 2020-07-24T22:00:24  <sipa> promag: it is not clear from the spec, to me
538 2020-07-24T22:00:36  <sipa> whether thet're required to be supported on the server side or not
539 2020-07-24T22:01:27  *** yanmaani has quit IRC
540 2020-07-24T22:01:33  <promag> commit -m "drop rpc, add graphql"
541 2020-07-24T22:03:15  <promag> jk, long live json-rpc, its awesome
542 2020-07-24T22:04:04  <sipa> i think we need x86-rpc; the client sends a bit of x86 assembly to the server, which executes it
543 2020-07-24T22:04:15  <sipa> it's extremely flexible!
544 2020-07-24T22:05:32  <promag> ack
545 2020-07-24T22:08:48  *** Highway62 has joined #bitcoin-core-dev
546 2020-07-24T22:09:26  *** Highway61 has quit IRC
547 2020-07-24T22:09:27  *** Highway62 is now known as Highway61
548 2020-07-24T22:11:04  *** Highway61 has quit IRC
549 2020-07-24T22:12:50  *** mdunnio has quit IRC
550 2020-07-24T22:13:09  *** promag has quit IRC
551 2020-07-24T22:15:29  *** AaronvanW has joined #bitcoin-core-dev
552 2020-07-24T22:17:03  *** grubles has quit IRC
553 2020-07-24T22:18:11  *** yanmaani has joined #bitcoin-core-dev
554 2020-07-24T22:21:04  *** sipsorcery has quit IRC
555 2020-07-24T22:21:30  *** sipsorcery has joined #bitcoin-core-dev
556 2020-07-24T22:25:01  *** Highway61 has joined #bitcoin-core-dev
557 2020-07-24T22:26:51  *** isis_ is now known as isis
558 2020-07-24T22:27:38  *** Giszmo has quit IRC
559 2020-07-24T22:37:23  *** promag has joined #bitcoin-core-dev
560 2020-07-24T22:37:57  *** gzhao408 has joined #bitcoin-core-dev
561 2020-07-24T22:42:58  *** Giszmo has joined #bitcoin-core-dev
562 2020-07-24T22:44:12  *** mdunnio has joined #bitcoin-core-dev
563 2020-07-24T22:45:51  *** AaronvanW has quit IRC
564 2020-07-24T22:49:00  *** mdunnio has quit IRC
565 2020-07-24T22:59:25  *** Giszmo has quit IRC
566 2020-07-24T23:01:18  *** arowser has quit IRC
567 2020-07-24T23:04:43  *** arowser has joined #bitcoin-core-dev
568 2020-07-24T23:05:22  *** Giszmo has joined #bitcoin-core-dev
569 2020-07-24T23:12:29  *** proofofkeags has joined #bitcoin-core-dev
570 2020-07-24T23:16:53  *** jarthur_ has joined #bitcoin-core-dev
571 2020-07-24T23:20:33  *** jarthur has quit IRC
572 2020-07-24T23:25:19  *** promag has quit IRC
573 2020-07-24T23:25:47  *** sipsorcery has quit IRC
574 2020-07-24T23:36:41  *** proofofkeags has quit IRC
575 2020-07-24T23:37:07  *** proofofkeags has joined #bitcoin-core-dev
576 2020-07-24T23:41:50  *** proofofkeags has quit IRC
577 2020-07-24T23:43:18  *** proofofkeags has joined #bitcoin-core-dev
578 2020-07-24T23:44:58  *** proofofkeags has quit IRC
579 2020-07-24T23:45:24  *** proofofkeags has joined #bitcoin-core-dev
580 2020-07-24T23:46:25  *** jarthur_ has quit IRC
581 2020-07-24T23:47:29  <instagibbs> named params are super helpful when you have an rpc call with 9+ args :)
582 2020-07-24T23:47:47  *** promag has joined #bitcoin-core-dev
583 2020-07-24T23:49:45  *** proofofkeags has quit IRC
584 2020-07-24T23:54:24  *** jarthur has joined #bitcoin-core-dev
585 2020-07-24T23:55:45  *** marcoagner has quit IRC
586 2020-07-24T23:58:35  *** jarthur has quit IRC
587 2020-07-24T23:58:51  *** sipsorcery has joined #bitcoin-core-dev