1 2020-07-27T00:00:03 *** xorAxAx has quit IRC
2 2020-07-27T00:15:23 *** gzhao408 has quit IRC
3 2020-07-27T00:22:20 *** noirin has joined #bitcoin-core-dev
4 2020-07-27T00:39:42 *** promag has quit IRC
5 2020-07-27T00:42:59 *** Victorsueca has quit IRC
6 2020-07-27T00:44:03 *** jarthur_ has joined #bitcoin-core-dev
7 2020-07-27T00:47:46 *** jarthur has quit IRC
8 2020-07-27T00:49:32 *** Victorsueca has joined #bitcoin-core-dev
9 2020-07-27T00:58:40 *** troygiorshev has quit IRC
10 2020-07-27T00:59:15 *** troygiorshev has joined #bitcoin-core-dev
11 2020-07-27T01:01:01 *** arowser has quit IRC
12 2020-07-27T01:01:27 *** arowser has joined #bitcoin-core-dev
13 2020-07-27T01:05:10 *** arowser has quit IRC
14 2020-07-27T01:05:29 *** arowser has joined #bitcoin-core-dev
15 2020-07-27T01:10:59 *** Victorsueca has quit IRC
16 2020-07-27T01:14:51 *** Victorsueca has joined #bitcoin-core-dev
17 2020-07-27T01:38:08 *** arowser has quit IRC
18 2020-07-27T01:39:15 *** arowser has joined #bitcoin-core-dev
19 2020-07-27T01:46:07 *** arowser has quit IRC
20 2020-07-27T01:46:28 *** gzhao408 has joined #bitcoin-core-dev
21 2020-07-27T01:48:40 *** jarthur_ is now known as jarthur
22 2020-07-27T01:49:38 *** arowser_ has joined #bitcoin-core-dev
23 2020-07-27T01:54:35 *** arowser_ has quit IRC
24 2020-07-27T01:55:20 *** Victorsueca has quit IRC
25 2020-07-27T01:58:51 *** Victorsueca has joined #bitcoin-core-dev
26 2020-07-27T02:01:59 *** arowser_ has joined #bitcoin-core-dev
27 2020-07-27T02:05:46 *** noirin has quit IRC
28 2020-07-27T02:11:35 *** shesek has joined #bitcoin-core-dev
29 2020-07-27T02:11:35 *** shesek has joined #bitcoin-core-dev
30 2020-07-27T02:13:23 *** Victorsueca has quit IRC
31 2020-07-27T02:15:05 *** arowser_ has quit IRC
32 2020-07-27T02:15:34 *** arowser_ has joined #bitcoin-core-dev
33 2020-07-27T02:20:35 *** arowser_ has quit IRC
34 2020-07-27T02:22:09 *** arowser_ has joined #bitcoin-core-dev
35 2020-07-27T02:22:53 *** Victorsueca has joined #bitcoin-core-dev
36 2020-07-27T02:30:57 *** stranger64 has joined #bitcoin-core-dev
37 2020-07-27T02:41:11 *** arowser_ has quit IRC
38 2020-07-27T02:41:36 *** arowser_ has joined #bitcoin-core-dev
39 2020-07-27T02:50:57 *** arowser_ has quit IRC
40 2020-07-27T03:00:01 *** stranger64 has quit IRC
41 2020-07-27T03:03:08 *** arowser_ has joined #bitcoin-core-dev
42 2020-07-27T03:13:42 *** bitcoin-git has joined #bitcoin-core-dev
43 2020-07-27T03:13:42 <bitcoin-git> [bitcoin] freenancial closed pull request #19480: build: Only use `@` prefix for `echo` command in Makefiles (master...remove_at_sign_makefile) https://github.com/bitcoin/bitcoin/pull/19480
44 2020-07-27T03:13:43 *** bitcoin-git has left #bitcoin-core-dev
45 2020-07-27T03:14:06 *** Victorsueca has quit IRC
46 2020-07-27T03:18:04 *** Victorsueca has joined #bitcoin-core-dev
47 2020-07-27T03:22:21 *** seefischer has joined #bitcoin-core-dev
48 2020-07-27T03:30:27 *** troygiorshev has quit IRC
49 2020-07-27T03:30:56 *** troygiorshev has joined #bitcoin-core-dev
50 2020-07-27T03:31:12 *** vasild_ has joined #bitcoin-core-dev
51 2020-07-27T03:34:03 *** vasild has quit IRC
52 2020-07-27T03:34:04 *** vasild_ is now known as vasild
53 2020-07-27T03:41:16 *** Highway61 has quit IRC
54 2020-07-27T03:44:38 *** Guest416 has joined #bitcoin-core-dev
55 2020-07-27T03:49:03 *** bitdex has quit IRC
56 2020-07-27T03:50:25 *** bitdex has joined #bitcoin-core-dev
57 2020-07-27T03:52:03 *** justan0theruser has quit IRC
58 2020-07-27T03:52:44 *** Guest416 has left #bitcoin-core-dev
59 2020-07-27T04:01:32 *** bitcoin-git has joined #bitcoin-core-dev
60 2020-07-27T04:01:32 <bitcoin-git> [bitcoin] sdaftuar opened pull request #19596: Deduplicate parent txid loop of requested transactions and missing parents of orphan transactions (master...2020-07-dedup-inputs) https://github.com/bitcoin/bitcoin/pull/19596
61 2020-07-27T04:01:33 *** bitcoin-git has left #bitcoin-core-dev
62 2020-07-27T04:01:46 *** arowser_ has quit IRC
63 2020-07-27T04:03:00 *** arowser_ has joined #bitcoin-core-dev
64 2020-07-27T04:05:25 *** gzhao408 has quit IRC
65 2020-07-27T04:12:05 *** arowser_ has quit IRC
66 2020-07-27T04:34:39 *** arowser_ has joined #bitcoin-core-dev
67 2020-07-27T04:41:07 *** jarthur has quit IRC
68 2020-07-27T04:41:58 *** jarthur has joined #bitcoin-core-dev
69 2020-07-27T05:03:32 *** TheHoliestRoger has quit IRC
70 2020-07-27T05:04:26 *** TheHoliestRoger has joined #bitcoin-core-dev
71 2020-07-27T05:09:03 *** Asbestos_Vapor has quit IRC
72 2020-07-27T05:19:05 *** arowser_ has quit IRC
73 2020-07-27T05:20:13 *** arowser_ has joined #bitcoin-core-dev
74 2020-07-27T05:42:38 *** justanotheruser has joined #bitcoin-core-dev
75 2020-07-27T05:42:59 *** jonatack has quit IRC
76 2020-07-27T05:49:11 *** mdunnio has joined #bitcoin-core-dev
77 2020-07-27T05:53:58 *** mdunnio has quit IRC
78 2020-07-27T06:00:01 *** seefischer has quit IRC
79 2020-07-27T06:11:02 *** arowser_ has quit IRC
80 2020-07-27T06:11:28 *** arowser_ has joined #bitcoin-core-dev
81 2020-07-27T06:22:45 *** jonatack has joined #bitcoin-core-dev
82 2020-07-27T06:24:16 *** icota[m] has joined #bitcoin-core-dev
83 2020-07-27T06:41:01 *** arowser_ has quit IRC
84 2020-07-27T06:47:36 *** arowser_ has joined #bitcoin-core-dev
85 2020-07-27T06:51:59 *** marcoagner has joined #bitcoin-core-dev
86 2020-07-27T06:55:59 *** Xorlev has joined #bitcoin-core-dev
87 2020-07-27T07:00:50 *** arowser_ has quit IRC
88 2020-07-27T07:02:08 *** arowser_ has joined #bitcoin-core-dev
89 2020-07-27T07:12:41 *** infernix has quit IRC
90 2020-07-27T07:23:01 *** justanotheruser has quit IRC
91 2020-07-27T07:28:32 *** justanotheruser has joined #bitcoin-core-dev
92 2020-07-27T07:29:03 *** jarthur has quit IRC
93 2020-07-27T07:31:11 *** jarthur has joined #bitcoin-core-dev
94 2020-07-27T07:34:41 <vasild> sipa: I need varint in order to be able to create and parse addrv2 messages: https://github.com/bitcoin/bips/blob/master/bip-0155.mediawiki "time" and "services" use VARINT
95 2020-07-27T07:36:28 *** jonatack has quit IRC
96 2020-07-27T07:37:28 <sipa> vasild: heh, that's quite underspecified
97 2020-07-27T07:37:49 <sipa> bitcoin core's internal varint type isn't used in the p2p protocol anywhere
98 2020-07-27T07:37:52 <vasild> I implemented (de)ser_varint: https://bpa.st/HTBA, it will end up in some of the addrv2 PRs (still I am only playing with it locally)
99 2020-07-27T07:38:26 <sipa> vasild: could it just mean compactsize ?
100 2020-07-27T07:38:50 <sipa> that's the varint type that's used elsewhere in the p2p protocol
101 2020-07-27T07:38:55 <vasild> Isn't used _yet_ ;-)
102 2020-07-27T07:39:03 <vasild> I agree it is underspecified other than "see bitcoin core source code"
103 2020-07-27T07:39:28 <sipa> i don't even see that?
104 2020-07-27T07:39:32 <vasild> no idea if it is supposed to mean compactsize, wumpus ?
105 2020-07-27T07:41:43 <vasild> "i don't even see that?" -- yes, not even "see bitcoin core source code", but I think that would be undesirable because the code may change
106 2020-07-27T07:42:10 <vasild> why are there two encodings, compactsize and varint?
107 2020-07-27T07:43:07 <sipa> compactsize is the one the original source code and protocol from satoshi's time used
108 2020-07-27T07:43:44 <sipa> which was called varint everywhere, but compactsize inside the source code (as it was only used to serialize the length of things)
109 2020-07-27T07:44:37 <sipa> the varint one was inspired by BER's length encoding, with a slight (and in retrospect not worthwhile) efficiency improvement i came up with
110 2020-07-27T07:45:36 <sipa> it was part of the database redesign in 0.8 that introduced the utxo set chainstate database
111 2020-07-27T07:45:55 <sipa> where i think it performed better than the compactsize we had
112 2020-07-27T07:46:20 <vasild> I see
113 2020-07-27T07:47:00 <vasild> is compactsize specified anywhere (other than "look at the code")?
114 2020-07-27T07:47:20 <sipa> and maybe part of the confusion here is because the compactsize encoding is often jusy referred to as varint
115 2020-07-27T07:48:03 <sipa> vasild: not in any BIPs afaik; things that existed in the protocol before the BIPs process existed as generally just taken as gospel
116 2020-07-27T07:48:26 <vasild> maybe the new type should have been named something else than varint
117 2020-07-27T07:50:35 <vasild> Ok, so neither one of varint or compactsize is defined in BIPs, but compact size is already used in other places in the p2p protocol whereas varint is not.
118 2020-07-27T07:50:44 <vasild> BIP155 says:
119 2020-07-27T07:50:44 <vasild> - Jonas Schnelli: change services field to VARINT, to make the message more compact in the likely case instead of always using 8 bytes.
120 2020-07-27T07:50:45 <vasild> - Luke-Jr: change time field to VARINT, for post-2038 compatibility.
121 2020-07-27T07:51:10 <vasild> jonasschnelli: luke-jr: ^^^ Did you mean compactsize instead of varint? Should we change that to compactsize now?
122 2020-07-27T07:52:18 <sipa> for BIP152 there was initially an intention to use varint, but it was changed to compactsize to simplify specification
123 2020-07-27T07:52:18 <jonasschnelli> what is the difference between compact size and varint?
124 2020-07-27T07:52:32 <sipa> vasild: ^ that's what i mean :p
125 2020-07-27T07:52:39 <vasild> Or, well, if in other specs the word "VARINT" is used to mean "compactsize", then should the BIP155 C++ source code use compactsize?
126 2020-07-27T07:53:01 <sipa> when people say varint in the context of the protocol, it usually refers to what is known as compactsize in the source code
127 2020-07-27T07:53:39 <sipa> jonasschnelli: scroll up a few lines, i gave the history :)
128 2020-07-27T07:53:50 <jonasschnelli> just read back... :)
129 2020-07-27T07:54:50 *** arowser_ has quit IRC
130 2020-07-27T07:59:56 *** arowser_ has joined #bitcoin-core-dev
131 2020-07-27T08:02:34 <vasild> git grep -il varint ./bip-0* # 8 occurrences
132 2020-07-27T08:02:41 <vasild> s/8 occurrences/mentioned in 8 BIPs/
133 2020-07-27T08:03:00 <vasild> and "compactsize" is mentioned in 6 BIPs
134 2020-07-27T08:03:02 <sipa> which ones?
135 2020-07-27T08:03:23 <vasild> varint:
136 2020-07-27T08:03:25 <vasild> bip-0010.mediawiki
137 2020-07-27T08:03:25 <vasild> bip-0023.mediawiki
138 2020-07-27T08:03:25 <vasild> bip-0037.mediawiki
139 2020-07-27T08:03:25 <vasild> bip-0098.mediawiki
140 2020-07-27T08:03:25 <vasild> bip-0154.mediawiki
141 2020-07-27T08:03:26 <vasild> bip-0155.mediawiki
142 2020-07-27T08:03:26 <vasild> bip-0180.mediawiki
143 2020-07-27T08:03:26 <vasild> bip-0322.mediawiki
144 2020-07-27T08:03:57 <vasild> compactsize:
145 2020-07-27T08:04:07 <vasild> bip-0152.mediawiki
146 2020-07-27T08:04:07 <vasild> bip-0157.mediawiki
147 2020-07-27T08:04:07 <vasild> bip-0158.mediawiki
148 2020-07-27T08:04:07 <vasild> bip-0330.mediawiki
149 2020-07-27T08:04:07 <vasild> bip-0341.mediawiki
150 2020-07-27T08:04:08 <vasild> bip-0342.mediawiki
151 2020-07-27T08:07:32 <vasild> Anyway, given that compact size is used in p2p and not varint, I suggest that we change the spec to say "compactsize" instead of "varint" with some clarification like "For the purposes of this section, CompactSize refers to the variable-length integer encoding used acros..." (from bip152) and also change the code to use compactsize instead of varint (the code is in
152 2020-07-27T08:07:36 <vasild> https://github.com/bitcoin/bitcoin/pull/19031)
153 2020-07-27T08:09:17 <vasild> jonasschnelli: luke-jr: sipa: wumpus: what do you think, (s/VARINT/CompactSize/ in BIP155)?
154 2020-07-27T08:09:57 *** promag has joined #bitcoin-core-dev
155 2020-07-27T08:10:12 *** promag has quit IRC
156 2020-07-27T08:10:30 *** promag has joined #bitcoin-core-dev
157 2020-07-27T08:17:24 *** EagleTM has joined #bitcoin-core-dev
158 2020-07-27T08:19:25 *** jonatack has joined #bitcoin-core-dev
159 2020-07-27T08:23:03 *** Pavlenex has joined #bitcoin-core-dev
160 2020-07-27T08:29:38 *** promag_ has joined #bitcoin-core-dev
161 2020-07-27T08:30:13 *** infernix has joined #bitcoin-core-dev
162 2020-07-27T08:31:05 *** arowser_ has quit IRC
163 2020-07-27T08:32:10 *** arowser_ has joined #bitcoin-core-dev
164 2020-07-27T08:34:20 *** promag_ has quit IRC
165 2020-07-27T08:36:27 *** Xorlev has quit IRC
166 2020-07-27T08:47:35 *** promag_ has joined #bitcoin-core-dev
167 2020-07-27T08:50:56 <luke-jr> vasild: https://en.bitcoin.it/wiki/Protocol_documentation#Variable_length_integer
168 2020-07-27T08:51:04 *** promag_ has quit IRC
169 2020-07-27T08:52:48 *** promag_ has joined #bitcoin-core-dev
170 2020-07-27T08:52:51 <luke-jr> I'm not sure it makes sense to use the old varint for time/services.. benefits more from the new varint
171 2020-07-27T09:02:15 *** promag_ has quit IRC
172 2020-07-27T09:22:07 *** kierank1 has joined #bitcoin-core-dev
173 2020-07-27T09:34:57 *** promag_ has joined #bitcoin-core-dev
174 2020-07-27T09:42:03 *** AaronvanW has joined #bitcoin-core-dev
175 2020-07-27T09:56:48 *** promag_ has quit IRC
176 2020-07-27T09:58:32 *** promag_ has joined #bitcoin-core-dev
177 2020-07-27T10:03:18 *** Marcelino9Daniel has joined #bitcoin-core-dev
178 2020-07-27T10:03:18 *** promag_ has quit IRC
179 2020-07-27T10:04:45 *** arowser_ has quit IRC
180 2020-07-27T10:06:50 *** arowser_ has joined #bitcoin-core-dev
181 2020-07-27T10:20:14 *** Marcelino9Daniel has quit IRC
182 2020-07-27T10:21:47 *** mutatrum has joined #bitcoin-core-dev
183 2020-07-27T10:47:25 *** arowser_ has quit IRC
184 2020-07-27T10:47:44 *** arowser_ has joined #bitcoin-core-dev
185 2020-07-27T10:50:01 *** infernix has quit IRC
186 2020-07-27T10:53:09 *** arowser_ has quit IRC
187 2020-07-27T10:53:31 *** arowser_ has joined #bitcoin-core-dev
188 2020-07-27T10:53:57 *** belcher_ has joined #bitcoin-core-dev
189 2020-07-27T10:57:43 *** belcher has quit IRC
190 2020-07-27T10:59:36 *** promag_ has joined #bitcoin-core-dev
191 2020-07-27T11:00:56 *** AaronvanW has quit IRC
192 2020-07-27T11:04:30 *** promag_ has quit IRC
193 2020-07-27T11:09:32 <vasild> luke-jr: actually 4 bytes unsigned integer supports time up to year 2106. Only signed 4 bytes will brick after 2038
194 2020-07-27T11:12:03 <vasild> CAddress::nTime is uint32_t - it will work as is in master until 2106. I think there is no need to change it to varint or compact size in order to make it post-2038 proof. varint or compactsize would need 5 bytes today.
195 2020-07-27T11:19:47 *** arowser_ has quit IRC
196 2020-07-27T11:21:39 <vasild> For services - both varint and compact size will use 1 byte if NODE_NETWORK_LIMITED is not involved.
197 2020-07-27T11:22:06 <vasild> And if NODE_NETWORK_LIMITED is set, then compactsize will use 3 bytes whereas varint will use 2 bytes.
198 2020-07-27T11:23:11 *** bitcoin-git has joined #bitcoin-core-dev
199 2020-07-27T11:23:12 <bitcoin-git> [bitcoin] theStack opened pull request #19597: test: test decodepsbt fee calculation (count input value only once per UTXO) (master...20200726-test-check-deceodepsbt-fee-calculation) https://github.com/bitcoin/bitcoin/pull/19597
200 2020-07-27T11:23:13 *** bitcoin-git has left #bitcoin-core-dev
201 2020-07-27T11:23:26 <vasild> Is saving 1 byte worth introducing a new encoding?
202 2020-07-27T11:23:33 *** Victorsueca has quit IRC
203 2020-07-27T11:27:59 *** Victorsueca has joined #bitcoin-core-dev
204 2020-07-27T11:32:12 *** arowser_ has joined #bitcoin-core-dev
205 2020-07-27T11:32:25 *** Pavlenex has quit IRC
206 2020-07-27T11:39:49 *** AaronvanW has joined #bitcoin-core-dev
207 2020-07-27T11:41:41 *** troygiorshev has quit IRC
208 2020-07-27T11:42:26 *** Mercury_Vapor has joined #bitcoin-core-dev
209 2020-07-27T11:42:44 *** troygiorshev has joined #bitcoin-core-dev
210 2020-07-27T11:43:43 *** Pavlenex has joined #bitcoin-core-dev
211 2020-07-27T11:44:37 *** AaronvanW has quit IRC
212 2020-07-27T11:46:25 *** arowser_ has quit IRC
213 2020-07-27T11:46:55 <wumpus> vasild: does it introduce a new encoding?
214 2020-07-27T11:47:41 <wumpus> saving a byte per address sounds good actually
215 2020-07-27T11:48:20 *** arowser_ has joined #bitcoin-core-dev
216 2020-07-27T11:48:22 <vasild> wumpus: as it turns out VARINT is not used anywhere in P2P, CompactSize is used instead.
217 2020-07-27T11:49:02 <wumpus> ok
218 2020-07-27T11:49:16 <vasild> So from P2P point of view VARINT is a new encoding.
219 2020-07-27T11:49:38 <wumpus> so VARINT is only used in on-disk files?
220 2020-07-27T11:49:50 <wumpus> agree that it'd be preferable not to introduce it into P2P then
221 2020-07-27T11:50:00 <wumpus> though it's not a complex encoding
222 2020-07-27T11:50:12 <vasild> btw, I did not check that myself, but I trust sipa on it
223 2020-07-27T11:50:32 <vasild> both varint and compactsize are mentioned in some BIPs
224 2020-07-27T11:51:11 <vasild> but I gather "varint" in BIPs may be used to denote what the source code calls compactsize
225 2020-07-27T11:51:45 <wumpus> I'm definitely going with sipa's judgement on this :)
226 2020-07-27T11:51:48 *** AaronvanW has joined #bitcoin-core-dev
227 2020-07-27T11:52:29 <vasild> yes, it is not complex - I did the python implementation in order to do some more testing of it, python ser/deser: https://bpa.st/HTBA
228 2020-07-27T11:52:59 *** vincenzopalazzo has joined #bitcoin-core-dev
229 2020-07-27T11:54:51 <vasild> btw, there is one more concern wrt VARINT - it supports unlimited size and the deserializer would throw an exception for a code like: uint64_t x; stream >> VARINT(x); given a specially crafted sequence of bytes
230 2020-07-27T11:55:36 <vasild> e.g. 9 bytes that all have the first bit set would overflow uint64_t
231 2020-07-27T11:57:04 *** promag_ has joined #bitcoin-core-dev
232 2020-07-27T11:57:21 <vasild> So, any code that reads varint from the network has to do: try { stream >> VARINT(x); } catch (...) { aha! }
233 2020-07-27T11:58:02 *** bitcoin-git has joined #bitcoin-core-dev
234 2020-07-27T11:58:02 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/31d2b4098a9e...b62fbf9e1c19
235 2020-07-27T11:58:03 <bitcoin-git> bitcoin/master 7b3851e Hennadii Stepanov: refactor: Drop unused CBufferedFile::Seek()
236 2020-07-27T11:58:03 <bitcoin-git> bitcoin/master b62fbf9 Wladimir J. van der Laan: Merge #19593: refactor: Drop unused CBufferedFile::Seek()
237 2020-07-27T11:58:05 *** bitcoin-git has left #bitcoin-core-dev
238 2020-07-27T11:58:22 *** bitcoin-git has joined #bitcoin-core-dev
239 2020-07-27T11:58:22 <bitcoin-git> [bitcoin] laanwj merged pull request #19593: refactor: Drop unused CBufferedFile::Seek() (master...200726-seek) https://github.com/bitcoin/bitcoin/pull/19593
240 2020-07-27T11:58:23 *** bitcoin-git has left #bitcoin-core-dev
241 2020-07-27T12:00:02 *** kierank1 has quit IRC
242 2020-07-27T12:01:47 *** bitcoin-git has joined #bitcoin-core-dev
243 2020-07-27T12:01:47 <bitcoin-git> [bitcoin] troygiorshev opened pull request #19599: Clean message_count and last_message (master...2020-07-clean-message_count) https://github.com/bitcoin/bitcoin/pull/19599
244 2020-07-27T12:01:48 *** bitcoin-git has left #bitcoin-core-dev
245 2020-07-27T12:01:54 *** promag_ has quit IRC
246 2020-07-27T12:10:07 *** bitcoin-git has joined #bitcoin-core-dev
247 2020-07-27T12:10:07 <bitcoin-git> [bitcoin] troygiorshev closed pull request #19580: test: Remove message_count (master...2020-07-remove-message_count) https://github.com/bitcoin/bitcoin/pull/19580
248 2020-07-27T12:10:08 *** bitcoin-git has left #bitcoin-core-dev
249 2020-07-27T12:10:12 *** arowser_ has quit IRC
250 2020-07-27T12:10:42 *** arowser_ has joined #bitcoin-core-dev
251 2020-07-27T12:11:24 *** mably has joined #bitcoin-core-dev
252 2020-07-27T12:16:07 *** promag_ has joined #bitcoin-core-dev
253 2020-07-27T12:18:54 *** arowser_ has quit IRC
254 2020-07-27T12:20:11 *** promag_ has quit IRC
255 2020-07-27T12:21:40 *** amcrae1 has joined #bitcoin-core-dev
256 2020-07-27T12:24:11 *** Pavlenex has quit IRC
257 2020-07-27T12:25:24 *** Pavlenex has joined #bitcoin-core-dev
258 2020-07-27T12:31:05 *** arowser_ has joined #bitcoin-core-dev
259 2020-07-27T12:34:14 *** Pavlenex has quit IRC
260 2020-07-27T12:41:48 *** Davterra has quit IRC
261 2020-07-27T12:41:56 *** Davterra has joined #bitcoin-core-dev
262 2020-07-27T12:44:05 *** Guyver2 has joined #bitcoin-core-dev
263 2020-07-27T12:46:40 *** EagleTM has quit IRC
264 2020-07-27T12:49:39 *** EagleTM has joined #bitcoin-core-dev
265 2020-07-27T12:56:42 *** arowser_ has quit IRC
266 2020-07-27T12:56:49 *** Deacyde has joined #bitcoin-core-dev
267 2020-07-27T12:58:36 *** arowser_ has joined #bitcoin-core-dev
268 2020-07-27T13:01:10 *** Deacyde has quit IRC
269 2020-07-27T13:07:11 *** arowser_ has quit IRC
270 2020-07-27T13:07:31 *** arowser_ has joined #bitcoin-core-dev
271 2020-07-27T13:08:08 *** arowser_ has quit IRC
272 2020-07-27T13:08:32 *** arowser_ has joined #bitcoin-core-dev
273 2020-07-27T13:09:11 *** arowser_ has quit IRC
274 2020-07-27T13:09:30 *** arowser_ has joined #bitcoin-core-dev
275 2020-07-27T13:10:15 *** arowser_ has quit IRC
276 2020-07-27T13:10:25 *** vasild_ has joined #bitcoin-core-dev
277 2020-07-27T13:10:47 *** arowser_ has joined #bitcoin-core-dev
278 2020-07-27T13:12:11 *** arowser_ has quit IRC
279 2020-07-27T13:12:29 *** arowser_ has joined #bitcoin-core-dev
280 2020-07-27T13:12:43 *** vasild has quit IRC
281 2020-07-27T13:12:44 *** vasild_ is now known as vasild
282 2020-07-27T13:15:14 *** infernix has joined #bitcoin-core-dev
283 2020-07-27T13:23:01 *** arowser_ has quit IRC
284 2020-07-27T13:23:54 *** Victorsueca has quit IRC
285 2020-07-27T13:29:37 *** arowser_ has joined #bitcoin-core-dev
286 2020-07-27T13:30:02 *** harrigan has quit IRC
287 2020-07-27T13:30:13 *** harrigan has joined #bitcoin-core-dev
288 2020-07-27T13:30:41 *** proofofkeags has joined #bitcoin-core-dev
289 2020-07-27T13:32:19 *** Victorsueca has joined #bitcoin-core-dev
290 2020-07-27T13:40:11 *** Victorsueca has quit IRC
291 2020-07-27T13:42:31 *** infernix has quit IRC
292 2020-07-27T13:45:30 *** Victorsueca has joined #bitcoin-core-dev
293 2020-07-27T13:45:35 *** mdunnio has joined #bitcoin-core-dev
294 2020-07-27T13:45:56 *** Earnest16Gottlie has joined #bitcoin-core-dev
295 2020-07-27T13:50:44 *** bitdex has quit IRC
296 2020-07-27T13:51:12 *** arowser_ has quit IRC
297 2020-07-27T13:51:14 *** Earnest16Gottlie has quit IRC
298 2020-07-27T13:51:39 *** arowser_ has joined #bitcoin-core-dev
299 2020-07-27T13:57:54 *** Victorsueca has quit IRC
300 2020-07-27T14:01:47 *** infernix has joined #bitcoin-core-dev
301 2020-07-27T14:02:08 *** Victorsueca has joined #bitcoin-core-dev
302 2020-07-27T14:09:25 *** Victorsueca has quit IRC
303 2020-07-27T14:11:11 *** Victorsueca has joined #bitcoin-core-dev
304 2020-07-27T14:13:11 *** mdunnio has quit IRC
305 2020-07-27T14:13:15 *** arowser_ has quit IRC
306 2020-07-27T14:13:33 *** mdunnio has joined #bitcoin-core-dev
307 2020-07-27T14:13:34 *** arowser_ has joined #bitcoin-core-dev
308 2020-07-27T14:18:45 *** proofofkeags has quit IRC
309 2020-07-27T14:29:57 *** mably has quit IRC
310 2020-07-27T14:30:49 *** jb55 has quit IRC
311 2020-07-27T14:31:46 *** jb55 has joined #bitcoin-core-dev
312 2020-07-27T14:32:04 *** arowser_ has quit IRC
313 2020-07-27T14:32:44 *** Davterra has quit IRC
314 2020-07-27T14:40:03 *** Davterra has joined #bitcoin-core-dev
315 2020-07-27T14:44:37 *** arowser_ has joined #bitcoin-core-dev
316 2020-07-27T14:57:41 *** Davterra has quit IRC
317 2020-07-27T14:59:58 *** Davterra has joined #bitcoin-core-dev
318 2020-07-27T15:00:02 *** amcrae1 has quit IRC
319 2020-07-27T15:01:06 *** hack_you_now has joined #bitcoin-core-dev
320 2020-07-27T15:03:56 *** Deacyde has joined #bitcoin-core-dev
321 2020-07-27T15:07:47 *** infernix has quit IRC
322 2020-07-27T15:11:44 *** Guyver2 has quit IRC
323 2020-07-27T15:14:43 *** Guyver2 has joined #bitcoin-core-dev
324 2020-07-27T15:17:47 *** arowser_ has quit IRC
325 2020-07-27T15:20:35 *** Victorsueca has quit IRC
326 2020-07-27T15:21:25 *** gnomus has joined #bitcoin-core-dev
327 2020-07-27T15:25:59 *** Victorsueca has joined #bitcoin-core-dev
328 2020-07-27T15:29:56 *** arowser_ has joined #bitcoin-core-dev
329 2020-07-27T15:31:11 *** vasild_ has joined #bitcoin-core-dev
330 2020-07-27T15:35:03 *** vasild has quit IRC
331 2020-07-27T15:35:04 *** vasild_ is now known as vasild
332 2020-07-27T15:35:30 *** roconnor has quit IRC
333 2020-07-27T15:35:52 *** roconnor has joined #bitcoin-core-dev
334 2020-07-27T15:37:18 *** EagleTM has quit IRC
335 2020-07-27T15:41:32 *** gnomus has quit IRC
336 2020-07-27T15:56:05 *** wgolden has joined #bitcoin-core-dev
337 2020-07-27T15:56:40 *** infernix has joined #bitcoin-core-dev
338 2020-07-27T15:57:05 *** arowser_ has quit IRC
339 2020-07-27T15:58:03 *** arowser_ has joined #bitcoin-core-dev
340 2020-07-27T15:59:03 *** Victorsueca has quit IRC
341 2020-07-27T16:04:06 *** Victorsueca has joined #bitcoin-core-dev
342 2020-07-27T16:07:14 *** proofofkeags has joined #bitcoin-core-dev
343 2020-07-27T16:11:39 *** infernix has quit IRC
344 2020-07-27T16:28:00 *** jarthur_ has joined #bitcoin-core-dev
345 2020-07-27T16:28:49 *** Talkless has joined #bitcoin-core-dev
346 2020-07-27T16:30:41 *** jarthur has quit IRC
347 2020-07-27T16:39:40 <alko89> hi, I have a question about segwit (I know late...)
348 2020-07-27T16:39:51 <alko89> so if the segwit data is separated and not part of the blockchain
349 2020-07-27T16:39:57 <alko89> what is the incentive to store that data?
350 2020-07-27T16:40:06 <sipa> it is part of the blockchain, and committed to by blocks
351 2020-07-27T16:40:20 <sipa> just not by the txid that are used by other transactions that refer back to it
352 2020-07-27T16:40:29 <alko89> but the block is 1MB and the withess data is 4MB right?
353 2020-07-27T16:40:40 <alko89> ahhh
354 2020-07-27T16:41:03 <alko89> so when the utxo is spent, the data gets removed?
355 2020-07-27T16:41:07 <sipa> no
356 2020-07-27T16:41:16 <sipa> it's part of the blockchain just as much as everything else
357 2020-07-27T16:41:19 <sipa> it's just separate
358 2020-07-27T16:41:38 <sipa> but it is data that never enters the utxo set, so it has less impact on nodes' operations
359 2020-07-27T16:41:43 <alko89> hmmmm...but that means the block size did increase with segwit update :P
360 2020-07-27T16:41:50 <sipa> yes, of course
361 2020-07-27T16:42:06 <alko89> awwwwwwww!!!!
362 2020-07-27T16:42:10 <alko89> thanks!
363 2020-07-27T16:42:17 <sipa> https://bitcoin.stackexchange.com/questions/52196/is-segwit-a-blocksize-increase-or-more-efficient-use-of-blockspace
364 2020-07-27T16:47:13 <alko89> another question: If I'm not mistaken segwit transactions are visible by the old nodes as being spendable by all?
365 2020-07-27T16:47:46 *** infernix has joined #bitcoin-core-dev
366 2020-07-27T16:48:19 <sipa> bitcoin.stackexchange.com is probably a better place to ask
367 2020-07-27T16:48:42 <sipa> there are plenty of questions on that topic already
368 2020-07-27T16:53:06 *** Pavlenex has joined #bitcoin-core-dev
369 2020-07-27T17:00:25 *** proofofkeags has quit IRC
370 2020-07-27T17:05:01 *** rh0nj has quit IRC
371 2020-07-27T17:05:08 *** asoltys has joined #bitcoin-core-dev
372 2020-07-27T17:05:20 *** troygiorshev has quit IRC
373 2020-07-27T17:05:39 *** troygiorshev has joined #bitcoin-core-dev
374 2020-07-27T17:06:08 *** rh0nj has joined #bitcoin-core-dev
375 2020-07-27T17:06:15 *** promag_ has joined #bitcoin-core-dev
376 2020-07-27T17:10:25 *** promag_ has quit IRC
377 2020-07-27T17:11:25 *** esotericnonsense has quit IRC
378 2020-07-27T17:15:14 *** Pavlenex has quit IRC
379 2020-07-27T17:16:10 *** Pavlenex has joined #bitcoin-core-dev
380 2020-07-27T17:19:34 *** pinheadmz has quit IRC
381 2020-07-27T17:19:46 *** mutatrum has quit IRC
382 2020-07-27T17:20:13 *** Pavlenex has joined #bitcoin-core-dev
383 2020-07-27T17:21:13 *** Victorsueca has quit IRC
384 2020-07-27T17:22:52 *** jarthur_ is now known as jarthur
385 2020-07-27T17:24:49 *** esotericnonsense has joined #bitcoin-core-dev
386 2020-07-27T17:26:31 *** Victorsueca has joined #bitcoin-core-dev
387 2020-07-27T17:34:11 *** Victorsueca has quit IRC
388 2020-07-27T17:35:03 *** someone235 has quit IRC
389 2020-07-27T17:39:05 *** proofofkeags has joined #bitcoin-core-dev
390 2020-07-27T17:41:31 *** Victorsueca has joined #bitcoin-core-dev
391 2020-07-27T17:44:14 *** bitcoin-git has joined #bitcoin-core-dev
392 2020-07-27T17:44:15 <bitcoin-git> [bitcoin] hebasto opened pull request #19600: doc: Fix log message for -reindex (master...200727-load-log) https://github.com/bitcoin/bitcoin/pull/19600
393 2020-07-27T17:44:16 *** bitcoin-git has left #bitcoin-core-dev
394 2020-07-27T17:48:05 *** Victorsueca has quit IRC
395 2020-07-27T17:52:41 *** earlz has joined #bitcoin-core-dev
396 2020-07-27T17:56:50 *** Victorsueca has joined #bitcoin-core-dev
397 2020-07-27T17:57:36 *** troygiorshev has quit IRC
398 2020-07-27T17:58:17 *** troygiorshev has joined #bitcoin-core-dev
399 2020-07-27T18:00:02 *** wgolden has quit IRC
400 2020-07-27T18:00:05 *** proofofkeags has quit IRC
401 2020-07-27T18:03:05 *** Victorsueca has quit IRC
402 2020-07-27T18:04:13 *** Pavlenex has quit IRC
403 2020-07-27T18:06:42 *** mutatrum has joined #bitcoin-core-dev
404 2020-07-27T18:10:56 * midnight prods sipa re: graphs..?
405 2020-07-27T18:10:59 *** Victorsueca has joined #bitcoin-core-dev
406 2020-07-27T18:16:30 *** hack_you_now has quit IRC
407 2020-07-27T18:18:01 *** thunderbiscuit has joined #bitcoin-core-dev
408 2020-07-27T18:21:26 *** dscho has joined #bitcoin-core-dev
409 2020-07-27T18:27:30 <sipa> midnight: oops, on it
410 2020-07-27T18:28:59 *** Chris_Stewart_5 has quit IRC
411 2020-07-27T18:31:55 <midnight> <3
412 2020-07-27T18:32:35 *** Chris_Stewart_5 has joined #bitcoin-core-dev
413 2020-07-27T18:34:15 *** thunderbiscuit1 has joined #bitcoin-core-dev
414 2020-07-27T18:37:47 *** mutatrum has quit IRC
415 2020-07-27T18:55:45 *** troygiorshev has quit IRC
416 2020-07-27T18:57:02 *** troygiorshev has joined #bitcoin-core-dev
417 2020-07-27T18:57:23 *** vasild has quit IRC
418 2020-07-27T19:00:03 *** Talkless has quit IRC
419 2020-07-27T19:01:14 *** arowser_ has quit IRC
420 2020-07-27T19:01:39 *** arowser_ has joined #bitcoin-core-dev
421 2020-07-27T19:02:22 *** proofofkeags has joined #bitcoin-core-dev
422 2020-07-27T19:06:43 *** proofofkeags has quit IRC
423 2020-07-27T19:12:05 *** arowser_ has quit IRC
424 2020-07-27T19:12:23 *** arowser_ has joined #bitcoin-core-dev
425 2020-07-27T19:12:32 <sipa> midnight: better?
426 2020-07-27T19:15:35 *** isis is now known as isis_
427 2020-07-27T19:23:10 *** Victorsueca has quit IRC
428 2020-07-27T19:26:46 <midnight> sipa: beautiful!
429 2020-07-27T19:28:24 <ahmed_> https://gist.github.com/ahmedbodi/c19eae5afddb72348a53d7b71b185bae <- does anyone have any ideas what im doing wrong here? i get a CDataStream error while trying to connect to the P2P port of bitcoind
430 2020-07-27T19:29:28 <sipa> ahmed_: most likely that means you sent a message that's shorter than expected
431 2020-07-27T19:30:26 <ahmed_> @sipa thats why im confused, ive pulled CAddress code from @petertodd's bitcoin-python and the Version message code is tidied up version of the msg_version code in his repo
432 2020-07-27T19:30:44 *** Victorsueca has joined #bitcoin-core-dev
433 2020-07-27T19:32:56 *** vasild has joined #bitcoin-core-dev
434 2020-07-27T19:35:09 *** mutatrum has joined #bitcoin-core-dev
435 2020-07-27T19:40:42 *** proofofkeags has joined #bitcoin-core-dev
436 2020-07-27T19:45:47 *** proofofkeags has quit IRC
437 2020-07-27T19:46:30 *** mutatrum has quit IRC
438 2020-07-27T20:01:56 *** proofofkeags has joined #bitcoin-core-dev
439 2020-07-27T20:02:27 *** bitcoin-git has joined #bitcoin-core-dev
440 2020-07-27T20:02:27 <bitcoin-git> [bitcoin] JeremyRubin opened pull request #19601: Refactoring CHashWriter & Get{Prevouts,Sequence,Outputs}Hash to SHA256 (Alternative to #18071) (master...refactoring-hashers-2) https://github.com/bitcoin/bitcoin/pull/19601
441 2020-07-27T20:02:28 *** bitcoin-git has left #bitcoin-core-dev
442 2020-07-27T20:04:36 *** filchef has joined #bitcoin-core-dev
443 2020-07-27T20:05:27 *** filchef has quit IRC
444 2020-07-27T20:11:03 *** ossifrage has quit IRC
445 2020-07-27T20:18:32 *** dscho has quit IRC
446 2020-07-27T20:22:42 *** bitcoin-git has joined #bitcoin-core-dev
447 2020-07-27T20:22:42 <bitcoin-git> [bitcoin] achow101 opened pull request #19602: wallet: Migrate legacy wallets to descriptor wallets (master...descriptor-wallet-migration) https://github.com/bitcoin/bitcoin/pull/19602
448 2020-07-27T20:22:43 *** bitcoin-git has left #bitcoin-core-dev
449 2020-07-27T20:25:37 *** mutatrum has joined #bitcoin-core-dev
450 2020-07-27T20:34:55 *** alpounet has joined #bitcoin-core-dev
451 2020-07-27T20:55:41 *** owowo has joined #bitcoin-core-dev
452 2020-07-27T20:55:42 *** owowo has joined #bitcoin-core-dev
453 2020-07-27T21:00:02 *** alpounet has quit IRC
454 2020-07-27T21:14:20 *** isis_ is now known as isis
455 2020-07-27T21:14:41 *** isis is now known as isis_
456 2020-07-27T21:17:23 *** Victorsueca has quit IRC
457 2020-07-27T21:21:17 *** ogelbukh has joined #bitcoin-core-dev
458 2020-07-27T21:27:00 *** Victorsueca has joined #bitcoin-core-dev
459 2020-07-27T21:32:29 *** Victorsueca has quit IRC
460 2020-07-27T21:45:48 *** pinheadmz has joined #bitcoin-core-dev
461 2020-07-27T21:46:35 *** arowser_ has quit IRC
462 2020-07-27T21:52:13 *** Victorsueca has joined #bitcoin-core-dev
463 2020-07-27T21:52:52 *** Guyver2 has quit IRC
464 2020-07-27T21:53:05 *** arowser_ has joined #bitcoin-core-dev
465 2020-07-27T22:00:13 *** Victorsueca has quit IRC
466 2020-07-27T22:33:36 *** Chris_Stewart_5 has quit IRC
467 2020-07-27T22:34:22 *** marcoagner has quit IRC
468 2020-07-27T22:37:44 *** ossifrage has joined #bitcoin-core-dev
469 2020-07-27T22:44:55 *** owowo has quit IRC
470 2020-07-27T22:55:02 *** EagleTM has joined #bitcoin-core-dev
471 2020-07-27T23:01:30 *** arowser_ has quit IRC
472 2020-07-27T23:02:12 *** arowser_ has joined #bitcoin-core-dev
473 2020-07-27T23:19:23 *** Evel-Knievel has quit IRC
474 2020-07-27T23:19:42 *** Evel-Knievel has joined #bitcoin-core-dev
475 2020-07-27T23:21:13 *** mdunnio has quit IRC
476 2020-07-27T23:41:25 *** troygiorshev has quit IRC
477 2020-07-27T23:46:48 *** vincenzopalazzo has quit IRC
478 2020-07-27T23:48:18 *** proofofkeags has quit IRC
479 2020-07-27T23:49:38 *** nckx is now known as ^
480 2020-07-27T23:50:37 *** ^ is now known as nckx
481 2020-07-27T23:54:25 *** EagleTM has quit IRC